⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Mar 6, 2017:

11:38 PM Changeset in webkit [213506] by sbarati@apple.com
  • 7 edits
    1 add in trunk

WebAssembly: Implement the WebAssembly.instantiate API
​https://bugs.webkit.org/show_bug.cgi?id=165982
<rdar://problem/29760110>

Reviewed by Keith Miller.

JSTests:

  • wasm/js-api/web-assembly-instantiate.js: Added.

(assert.eq.async.test):
(assert.eq):
(assert.truthy.async.test):
(assert.truthy):

Source/JavaScriptCore:

This patch is a straight forward implementation of the WebAssembly.instantiate
API: ​https://github.com/WebAssembly/design/blob/master/JS.md#webassemblyinstantiate

I implemented the API in a synchronous manner. We should make it
asynchronous: ​https://bugs.webkit.org/show_bug.cgi?id=169187

  • wasm/JSWebAssembly.cpp:

(JSC::webAssemblyCompileFunc):
(JSC::webAssemblyInstantiateFunc):
(JSC::JSWebAssembly::finishCreation):

  • wasm/js/WebAssemblyInstanceConstructor.cpp:

(JSC::constructJSWebAssemblyInstance):
(JSC::WebAssemblyInstanceConstructor::createInstance):

  • wasm/js/WebAssemblyInstanceConstructor.h:
  • wasm/js/WebAssemblyModuleConstructor.cpp:

(JSC::constructJSWebAssemblyModule):
(JSC::WebAssemblyModuleConstructor::createModule):

  • wasm/js/WebAssemblyModuleConstructor.h:
11:30 PM Changeset in webkit [213505] by mmaxfield@apple.com
  • 6 edits
    2 adds in trunk

Apply well-known-axis variation values at the right time in preparePlatformFont()
​https://bugs.webkit.org/show_bug.cgi?id=168896

Reviewed by Jon Lee.

Source/WebCore:

Simply plumb the FontSelectionRequest to the place where font variations are implemented.

Test: fast/text/variations/font-selection-properties.html

  • platform/graphics/FontCache.h:
  • platform/graphics/cocoa/FontCacheCoreText.cpp:

(WebCore::preparePlatformFont):
(WebCore::fontWithFamily):
(WebCore::FontCache::createFontPlatformData):
(WebCore::FontCache::systemFallbackForCharacters):

  • platform/graphics/mac/FontCustomPlatformData.cpp:

(WebCore::FontCustomPlatformData::fontPlatformData):

LayoutTests:

  • fast/text/variations/font-selection-properties-expected.html: Added.
  • fast/text/variations/font-selection-properties.html: Added.
11:19 PM Changeset in webkit [213504] by aakash_jain@apple.com
  • 4 edits in trunk/Source/WebKit2

Enable SUPPORTS_TEXT_BASED_API in WebKit2 for iOS
​https://bugs.webkit.org/show_bug.cgi?id=169233

Reviewed by Alexey Proskuryakov.

  • Configurations/Base.xcconfig: Enable SUPPORTS_TEXT_BASED_API.
  • Configurations/WebKit.xcconfig: Pass information to TAPI about reexporting WebKitLegacy and few extra headers.
  • WebKit2.xcodeproj/project.pbxproj: Run scripts which are run for installhdrs phase for installapi phase as well.
11:01 PM Changeset in webkit [213503] by Yusuke Suzuki
  • 2 edits in trunk/Tools

Add Fujii Hironori to contributor's list
​https://bugs.webkit.org/show_bug.cgi?id=169261

Patch by Fujii Hironori <Fujii Hironori> on 2017-03-06
Reviewed by Yusuke Suzuki.

Add myself to the contributor's lists so that my e-mail autocompletes for CC

  • Scripts/webkitpy/common/config/contributors.json:
10:24 PM Changeset in webkit [213502] by mmaxfield@apple.com
  • 3 edits in trunk/Source/WebCore

Unreviewed post-review fixup after r213464
​https://bugs.webkit.org/show_bug.cgi?id=169255

  • platform/graphics/FontCache.h:

(WebCore::FontDescriptionKey::FontDescriptionKey):
(WebCore::FontDescriptionKey::operator==):
(WebCore::FontDescriptionKey::computeHash):
(WebCore::FontDescriptionKey::makeFlagsKey):

  • platform/graphics/cocoa/FontCacheCoreText.cpp:

(WebCore::computeNecessarySynthesis):

10:10 PM Changeset in webkit [213501] by Brent Fulgham
  • 3 edits
    2 adds in trunk

Validate DOM after potentially destructive actions during parser insert operations
​https://bugs.webkit.org/show_bug.cgi?id=169222
<rdar://problem/30689729>

Reviewed by Ryosuke Niwa.

Source/WebCore:

Do not perform an insert operation if the next child's parent is no longer
part of the tree. This can happen if JavaScript runs during node removal
events and modifies the contents of the document.

This patch was inspired by a similar Blink change by Marius Mlynski:
<​https://src.chromium.org/viewvc/blink?view=revision&revision=200690>

Tests: fast/parser/scriptexec-during-parserInsertBefore.html

  • html/parser/HTMLConstructionSite.cpp:

(WebCore::executeReparentTask):
(WebCore::executeInsertAlreadyParsedChildTask):

LayoutTests:

This change merges a Blink test case from:
<​https://src.chromium.org/viewvc/blink?view=revision&revision=200690>

  • fast/parser/scriptexec-during-parserInsertBefore-expected.txt: Added.
  • fast/parser/scriptexec-during-parserInsertBefore.html: Added.
9:44 PM Changeset in webkit [213500] by msaboff@apple.com
  • 2 edits in trunk/Source/WebKit/mac

Unreviewed build fix to add
-isystem $(SDKROOT)/System/Library/Frameworks/System.framework/PrivateHeaders
for objective C++ files.

  • Configurations/WebKitLegacy.xcconfig:
9:37 PM Changeset in webkit [213499] by mmaxfield@apple.com
  • 6 edits in trunk

Update isEmojiGroupCandidate() to the latest version of Unicode
​https://bugs.webkit.org/show_bug.cgi?id=168198

Reviewed by Jon Lee.

Source/WebCore:

In the latest version of Unicode, many more code points are candidates for emoji groups.
Therefore, isEmojiGroupCandidate() should be made more permissive. This way, the function
is more future-proof.

Test: editing/deleting/delete-emoji.html

  • platform/text/CharacterProperties.h:

(WebCore::icuLibraryUnderstandsSupplementalSymbolsAndPictographs):
(WebCore::isEmojiGroupCandidate):

LayoutTests:

  • platform/ios-simulator/editing/deleting/delete-emoji-expected.txt:
  • platform/mac/editing/deleting/delete-emoji-expected.txt:
  • editing/deleting/delete-emoji.html:
9:15 PM Changeset in webkit [213498] by mitz@apple.com
  • 3 edits in trunk/Source/WebKit2

[Cocoa] Expose API::InjectedBundle::EditorClient::didChange via the Objective-C bundle SPI
​https://bugs.webkit.org/show_bug.cgi?id=169223

Reviewed by Tim Horton.

  • WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInEditingDelegate.h: Declared new delegate method -_webProcessPlugInBrowserContextControllerDidChangeByEditing:.
  • WebProcess/InjectedBundle/API/mac/WKWebProcessPlugInBrowserContextController.mm:

(-[WKWebProcessPlugInBrowserContextController _setEditingDelegate:]): Added an override

of API::InjectedBundle::EditorClient::didChange that calls the new delegate method.

8:44 PM Changeset in webkit [213497] by commit-queue@webkit.org
  • 3 edits in trunk/Source/ThirdParty/libwebrtc

Bring back WebKit specific changes to disable temporarily libwebrtc video adaptation
​https://bugs.webkit.org/show_bug.cgi?id=169229

Patch by Youenn Fablet <​youenn@apple.com> on 2017-03-06
Reviewed by Alex Christensen.

  • Source/webrtc/modules/video_coding/video_sender.cc: disabling frame dropping.
  • Source/webrtc/video/vie_encoder.cc: disabling resolution decrease based on CPU overuse.
8:39 PM Changeset in webkit [213496] by msaboff@apple.com
  • 2 edits in trunk/Source/WebKit2

Unreviewed build fix after r213492.

  • Configurations/Base.xcconfig:
8:22 PM Changeset in webkit [213495] by aakash_jain@apple.com
  • 3 edits in trunk/Source/WebKit2

Add WK_CLASS_AVAILABLE to _WKLinkIconParameters and _WKWebViewPrintFormatter
​https://bugs.webkit.org/show_bug.cgi?id=169225

Reviewed by Tim Horton.

  • UIProcess/API/Cocoa/_WKLinkIconParameters.h:
  • UIProcess/_WKWebViewPrintFormatter.h:
8:21 PM Changeset in webkit [213494] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Use default configuration for libwebrtc peerconnection
​https://bugs.webkit.org/show_bug.cgi?id=169239

Patch by Youenn Fablet <​youenn@apple.com> on 2017-03-06
Reviewed by Alex Christensen.

  • Modules/mediastream/libwebrtc/LibWebRTCPeerConnectionBackend.cpp:

(WebCore::configurationFromMediaEndpointConfiguration): Using the default configuration instead of the aggressive one.

8:17 PM Changeset in webkit [213493] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[CMake] SN-DBS fails to build: Cannot open include file: 'WebCoreTestSupportPrefix.h'
​https://bugs.webkit.org/show_bug.cgi?id=169244

Patch by Fujii Hironori <Fujii Hironori> on 2017-03-06
Reviewed by Alex Christensen.

A distributed build system SN-DBS can not find
WebCoreTestSupportPrefix.h without an include path to it.

  • CMakeLists.txt: Add 'WebCore/testing/js' to include paths.
7:37 PM Changeset in webkit [213492] by msaboff@apple.com
  • 2 edits in trunk/Source/WebKit2

Unreviewed build fix after r213483.

  • Configurations/Base.xcconfig:
7:11 PM Changeset in webkit [213491] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[cairo] error C2065: 'quality': undeclared identifier since r213412
​https://bugs.webkit.org/show_bug.cgi?id=169240

Patch by Fujii Hironori <Fujii Hironori> on 2017-03-06
Reviewed by Ryosuke Niwa.

  • platform/graphics/cairo/ImageBufferCairo.cpp:

(WebCore::ImageBuffer::toDataURL): Name the unnamed second argument 'quality'.

7:09 PM Changeset in webkit [213490] by Brent Fulgham
  • 2 edits in trunk/Source/WebKit2

[Mac][WK2] Support new CoreMedia routing features
​https://bugs.webkit.org/show_bug.cgi?id=169241
<rdar://problem/30077969>

Reviewed by Alexey Proskuryakov.

  • WebProcess/com.apple.WebProcess.sb.in:
6:56 PM Changeset in webkit [213489] by jiewen_tan@apple.com
  • 19 edits
    6 copies
    15 adds in trunk

[WebCrypto] Implement ECDH GenerateKey operation
​https://bugs.webkit.org/show_bug.cgi?id=169093
<rdar://problem/23789585>

Reviewed by Brent Fulgham.

LayoutTests/imported/w3c:

  • web-platform-tests/WebCryptoAPI/generateKey/failures_ECDH.worker-expected.txt:
  • web-platform-tests/WebCryptoAPI/generateKey/successes_ECDH.worker-expected.txt:
  • web-platform-tests/WebCryptoAPI/generateKey/test_failures_ECDH-expected.txt:
  • web-platform-tests/WebCryptoAPI/generateKey/test_successes_ECDH-expected.txt:

Source/WebCore:

This patch implements GenerateKey operation of ECDH according to:
​https://www.w3.org/TR/WebCryptoAPI/#ecdh-operations.
Note: Sad that we are not able to support P-521 at this moment due
to lack of necessary support in the underlying crypto library.

Tests: crypto/subtle/ec-generate-key-malformed-parameters.html

crypto/subtle/ecdh-generate-key-extractable.html
crypto/subtle/ecdh-generate-key-p256.html
crypto/subtle/ecdh-generate-key-p384.html
crypto/subtle/ecdh-generate-key-single-usage.html
crypto/workers/subtle/ec-generate-key.html

  • CMakeLists.txt:
  • DerivedSources.make:
  • PlatformGTK.cmake:
  • PlatformMac.cmake:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSCryptoKeyCustom.cpp:

(WebCore::JSCryptoKey::algorithm):

  • bindings/js/JSSubtleCryptoCustom.cpp:

(WebCore::normalizeCryptoAlgorithmParameters):
(WebCore::jsSubtleCryptoFunctionGenerateKeyPromise):
Add support for ECDH.

  • bindings/js/SerializedScriptValue.cpp:

(WebCore::CloneSerializer::write):
Structured clonable will be added later on.

  • crypto/CommonCryptoUtilities.h:

Add SPI for EC.

  • crypto/CryptoAlgorithmParameters.h:
  • crypto/CryptoKey.h:
  • crypto/algorithms/CryptoAlgorithmECDH.cpp: Added.

(WebCore::CryptoAlgorithmECDH::create):
(WebCore::CryptoAlgorithmECDH::identifier):
(WebCore::CryptoAlgorithmECDH::generateKey):

  • crypto/algorithms/CryptoAlgorithmECDH.h: Added.
  • crypto/gnutls/CryptoKeyECGnuTLS.cpp: Added.

(WebCore::CryptoKeyEC::~CryptoKeyEC):
(WebCore::CryptoKeyEC::platformGeneratePair):

  • crypto/keys/CryptoKeyEC.cpp: Added.

(WebCore::CryptoKeyEC::CryptoKeyEC):
(WebCore::CryptoKeyEC::generatePair):
(WebCore::CryptoKeyEC::buildAlgorithm):
(WebCore::CryptoKeyEC::exportData):

  • crypto/keys/CryptoKeyEC.h: Added.

(WebCore::EcKeyAlgorithm::EcKeyAlgorithm):
(WebCore::EcKeyAlgorithm::namedCurve):

  • crypto/mac/CryptoAlgorithmRegistryMac.cpp:

(WebCore::CryptoAlgorithmRegistry::platformRegisterAlgorithms):
Add support for ECDH.

  • crypto/mac/CryptoKeyECMac.cpp: Added.

(WebCore::CryptoKeyEC::~CryptoKeyEC):
(WebCore::CryptoKeyEC::platformGeneratePair):

  • crypto/parameters/CryptoAlgorithmEcKeyParams.h: Added.
  • crypto/parameters/EcKeyParams.idl: Added.

LayoutTests:

  • crypto/subtle/ec-generate-key-malformed-parameters-expected.txt: Added.
  • crypto/subtle/ec-generate-key-malformed-parameters.html: Added.
  • crypto/subtle/ecdh-generate-key-extractable-expected.txt: Added.
  • crypto/subtle/ecdh-generate-key-extractable.html: Added.
  • crypto/subtle/ecdh-generate-key-p256-expected.txt: Added.
  • crypto/subtle/ecdh-generate-key-p256.html: Added.
  • crypto/subtle/ecdh-generate-key-p384-expected.txt: Added.
  • crypto/subtle/ecdh-generate-key-p384.html: Added.
  • crypto/subtle/ecdh-generate-key-single-usage-expected.txt: Added.
  • crypto/subtle/ecdh-generate-key-single-usage.html: Added.
  • crypto/workers/subtle/ec-generate-key-expected.txt: Added.
  • crypto/workers/subtle/ec-generate-key.html: Added.
  • crypto/workers/subtle/resources/ec-generate-key.js: Added.
6:54 PM Changeset in webkit [213488] by jmarcell@apple.com
  • 6 edits in tags/Safari-604.1.8.1.2/Source

Versioning.

6:46 PM Changeset in webkit [213487] by jmarcell@apple.com
  • 1 copy in tags/Safari-604.1.8.1.2

Tag Safari-604.1.8.1.2.

6:32 PM Changeset in webkit [213486] by Michael Catanzaro
  • 2 edits in trunk/Source/WebCore

Unreviewed, fix unused parameter warning after r213464

  • platform/graphics/freetype/FontCacheFreeType.cpp:

(WebCore::FontCache::getFontSelectionCapabilitiesInFamily):

6:31 PM Changeset in webkit [213485] by clopez@igalia.com
  • 2 edits in trunk/Tools

[GTK] Mark WTF_Lock.ContendedLongSection and WTF_WordLock.ContendedLongSection as slow.

Unreviewed test gardening.

The ContendedShortSection version of this tests were already marked as slow.
And the ContendedLongSection version takes more or less the same time to run.
They cause time outs on the bot sometimes.

  • Scripts/run-gtk-tests:

(TestRunner):

6:10 PM Changeset in webkit [213484] by sbarati@apple.com
  • 2 edits in trunk/JSTests

Unreviewed. Fix test expected error message.

  • wasm/js-api/element.js:

(assert.throws):

5:51 PM Changeset in webkit [213483] by msaboff@apple.com
  • 18 edits in trunk

Take advantage of fast permissions switching of JIT memory for devices that support it
​https://bugs.webkit.org/show_bug.cgi?id=169155

Reviewed by Saam Barati.

Source/JavaScriptCore:

Start using the os_thread_self_restrict_rwx_to_XX() SPIs when available to
control access to JIT memory.

Had to update the Xcode config files to handle various build variations of
public and internal SDKs.

  • Configurations/Base.xcconfig:
  • Configurations/FeatureDefines.xcconfig:
  • jit/ExecutableAllocator.cpp:

(JSC::FixedVMPoolExecutableAllocator::FixedVMPoolExecutableAllocator):
(JSC::FixedVMPoolExecutableAllocator::initializeSeparatedWXHeaps):

  • jit/ExecutableAllocator.h:

(JSC::performJITMemcpy):

Source/WebCore:

Updated the Xcode config files to match what is in the JavaScriptCore ones.

  • Configurations/Base.xcconfig:
  • Configurations/FeatureDefines.xcconfig:
  • Configurations/WebCore.xcconfig:

Source/WebCore/PAL:

Updated the Xcode config files to match what is in the JavaScriptCore ones.

  • Configurations/FeatureDefines.xcconfig:

Source/WebKit/mac:

Updated the Xcode config files to match what is in the JavaScriptCore ones.

  • Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

Updated the Xcode config files to match what is in the JavaScriptCore ones.

  • Configurations/FeatureDefines.xcconfig:

Tools:

Updated the Xcode config files to match what is in the JavaScriptCore ones.

  • TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
5:39 PM Changeset in webkit [213482] by aakash_jain@apple.com
  • 4 edits in trunk/Source

Make WKMenuItemIdentifiersPrivate.h private header
​https://bugs.webkit.org/show_bug.cgi?id=168981

Reviewed by Tim Horton.

Source/WebCore:

  • platform/spi/mac/NSMenuSPI.h: NSUserInterfaceItemIdentification is in the public header in recent SDKs.

Source/WebKit2:

  • WebKit2.xcodeproj/project.pbxproj: Made WKMenuItemIdentifiersPrivate.h private.
5:39 PM Changeset in webkit [213481] by ap@apple.com
  • 2 edits in trunk/Source/WebKit2

Replace -sub_umbrella linker flag with a build setting
​https://bugs.webkit.org/show_bug.cgi?id=169146

Reviewed by Tim Horton.

  • Configurations/WebKit.xcconfig:
5:29 PM Changeset in webkit [213480] by hyatt@apple.com
  • 22 edits
    2 adds in trunk

REGRESSION: Block no longer shrinks to preferred width in this flex box layout
​https://bugs.webkit.org/show_bug.cgi?id=169203
<rdar://problem/30873895>

Reviewed by Simon Fraser.

Source/WebCore:

Added new test in css3/flexbox.

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::adjustRenderStyle):
(WebCore::StyleResolver::adjustStyleForAlignment):

  • html/shadow/TextControlInnerElements.cpp:

(WebCore::TextControlInnerElement::resolveCustomStyle):
Resolve auto alignment values by adjusting the render style as needed. Make a helper
function for adjusting only alignment that can be called from the inner text control
custom style creation.

  • rendering/GridTrackSizingAlgorithm.cpp:

(WebCore::GridTrackSizingAlgorithmStrategy::minSizeForChild):
Replaced items in grids should not stretch by default.

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::hasStretchedLogicalWidth):
Patched to properly check the default alignment for the child, making sure
that if it's a replacd item inside a grid, that the default is start and not
stretch.

  • rendering/RenderBox.h:

(WebCore::RenderBox::selfAlignmentNormalBehavior):
Self-alignment function now takes an optional child argument, since the behavior
varies in grids depending on the child being replaced or not.

  • rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::alignmentForChild):
Fixed to do the right thing when the child is anonymous.

(WebCore::RenderFlexibleBox::styleDidChange): Deleted.

  • rendering/RenderFlexibleBox.h:

Deleted, since alignment changes are handled at the style diff level now.

  • rendering/RenderFullScreen.h:

Patched the selfAlignmentNormalBehavior method to take an optional child argument.

  • rendering/RenderGrid.cpp:

(WebCore::RenderGrid::styleDidChange):
(WebCore::RenderGrid::alignSelfForChild):
(WebCore::RenderGrid::justifySelfForChild):
(WebCore::RenderGrid::columnAxisPositionForChild):
(WebCore::RenderGrid::rowAxisPositionForChild):
(WebCore::RenderGrid::columnAxisOffsetForChild):
(WebCore::RenderGrid::rowAxisOffsetForChild):
(WebCore::defaultAlignmentIsStretch): Deleted.
(WebCore::defaultAlignmentChangedToStretchInRowAxis): Deleted.
(WebCore::defaultAlignmentChangedFromStretchInRowAxis): Deleted.
(WebCore::defaultAlignmentChangedFromStretchInColumnAxis): Deleted.
(WebCore::selfAlignmentChangedToStretchInRowAxis): Deleted.
(WebCore::selfAlignmentChangedFromStretchInRowAxis): Deleted.
(WebCore::selfAlignmentChangedFromStretchInColumnAxis): Deleted.

  • rendering/RenderGrid.h:

Removed the alignment change logic in styleDidChange for grids, since style diffing handles
it now. Updated all selfAlignmentForNormalBehavior queries to pass in the child so that
replaced elements are handled properly.

  • rendering/style/RenderStyle.h:

(WebCore::RenderStyle::overflowInlineDirection):
(WebCore::RenderStyle::overflowBlockDirection):
(WebCore::RenderStyle::setJustifySelfPosition):
New helpers used by grid and by adjustRenderStyle.

  • style/StyleChange.cpp:

(WebCore::Style::determineChange):
If alignment or justification changes occur on a parent that could affect the child (e.g., align-items)
return Inherit so the child render styles get adjusted properly.

LayoutTests:

  • css3/flexbox/column-inside-normal-block-preferred-width-expected.html: Added.
  • css3/flexbox/column-inside-normal-block-preferred-width.html: Added.
  • fast/css-grid-layout/grid-align-stretching-replaced-items-expected.txt:
  • fast/css-grid-layout/grid-align-stretching-replaced-items.html:
  • fast/repaint/align-items-change-expected.txt:
  • fast/repaint/align-items-overflow-change-expected.txt:
  • fast/repaint/justify-items-change-expected.txt:
  • fast/repaint/justify-items-legacy-change-expected.txt:
  • fast/repaint/justify-items-overflow-change-expected.txt:
4:20 PM Changeset in webkit [213479] by Lucas Forschler
  • 2 edits in trunk/Tools

​https://bugs.webkit.org/show_bug.cgi?id=169234
torchmobile.com.cn is no longer a registered domain. These email addresses will bounce, so clean them up.

Reviewed by Alexey Proskuryakov.

  • Scripts/webkitpy/common/config/contributors.json:
4:09 PM Changeset in webkit [213478] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

ASSERTION FAILED: numberOfChannels == 2 in WebCore::RealtimeIncomingAudioSource::OnData
​https://bugs.webkit.org/show_bug.cgi?id=169224
<rdar://problem/30856811>

Patch by Youenn Fablet <​youenn@apple.com> on 2017-03-06
Reviewed by Alex Christensen.

  • platform/mediastream/mac/RealtimeIncomingAudioSource.cpp:

(WebCore::RealtimeIncomingAudioSource::OnData): Updated assertion to allow 1 channel since we can handle it as well.

3:38 PM Changeset in webkit [213477] by Ryan Haddad
  • 2 edits in trunk/LayoutTests

Mark inspector/worker/console-basic.html as flaky.
​https://bugs.webkit.org/show_bug.cgi?id=169228

Unreviewed test gardening.

  • platform/mac/TestExpectations:
3:33 PM Changeset in webkit [213476] by Ryan Haddad
  • 2 edits in trunk/LayoutTests

Mark scrollingcoordinator/ios/non-stable-viewport-scroll.html as flaky on ios-simulator.
​https://bugs.webkit.org/show_bug.cgi?id=168924

Unreviewed test gardening.

  • platform/ios-simulator-wk2/TestExpectations:
3:29 PM Changeset in webkit [213475] by Ryan Haddad
  • 2 edits in trunk/LayoutTests

Mark media/modern-media-controls/tracks-support/tracks-support-click-track-in-panel.html as flaky.
​https://bugs.webkit.org/show_bug.cgi?id=169159

Unreviewed test gardening.

  • platform/mac/TestExpectations:
3:24 PM Changeset in webkit [213474] by Ryan Haddad
  • 2 edits in trunk/LayoutTests

Mark media/modern-media-controls/tracks-support/tracks-support-show-panel-after-dragging-controls.html as flaky.
​https://bugs.webkit.org/show_bug.cgi?id=169158

Unreviewed test gardening.

  • platform/mac/TestExpectations:
3:07 PM Changeset in webkit [213473] by Chris Dumez
  • 9 edits
    2 adds in trunk

[iOS] Throttle CSS animations to 30fps in low power mode
​https://bugs.webkit.org/show_bug.cgi?id=169138
<rdar://problem/30837805>

Reviewed by Said Abou-Hallawa.

Source/WebCore:

Throttle software CSS animations to 30fps in low power mode on iOS
to save battery.

Test: fast/animation/css-animation-throttling-lowPowerMode.html

  • page/Page.cpp:

(WebCore::Page::handleLowModePowerChange):

  • page/animation/CSSAnimationController.cpp:

(WebCore::CSSAnimationControllerPrivate::CSSAnimationControllerPrivate):
(WebCore::CSSAnimationControllerPrivate::updateAnimationTimer):
(WebCore::CSSAnimationControllerPrivate::updateThrottlingState):
(WebCore::CSSAnimationControllerPrivate::animationInterval):
(WebCore::CSSAnimationControllerPrivate::beginAnimationUpdateTime):
(WebCore::CSSAnimationControllerPrivate::beginAnimationUpdate):
(WebCore::CSSAnimationController::updateThrottlingState):
(WebCore::CSSAnimationController::animationInterval):

  • page/animation/CSSAnimationController.h:
  • page/animation/CSSAnimationControllerPrivate.h:
  • testing/Internals.cpp:

(WebCore::Internals::animationsInterval):

  • testing/Internals.h:
  • testing/Internals.idl:

LayoutTests:

Add layout test coverage.

  • fast/animation/css-animation-throttling-lowPowerMode-expected.txt: Added.
  • fast/animation/css-animation-throttling-lowPowerMode.html: Added.
3:07 PM Changeset in webkit [213472] by Csaba Osztrogonác
  • 2 edits in trunk/Source/JavaScriptCore

REGRESSION(r212778): It made 400 tests crash on AArch64 Linux
​https://bugs.webkit.org/show_bug.cgi?id=168502

Reviewed by Filip Pizlo.

  • heap/RegisterState.h: Use setjmp code path on AArch64 Linux too to fix crashes.
3:06 PM Changeset in webkit [213471] by mrajca@apple.com
  • 7 edits in trunk

Media: notify clients when the user never plays a media element that was prevented from auto-playing
​https://bugs.webkit.org/show_bug.cgi?id=169150

Reviewed by Alex Christensen.

Source/WebCore:

Added API tests.

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::mediaPlayerTimeChanged):
(WebCore::HTMLMediaElement::stopWithoutDestroyingMediaPlayer):

  • page/AutoplayEvent.h:

Source/WebKit2:

  • UIProcess/API/C/WKPageUIClient.h:

Tools:

  • TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:

(TEST): Added.

2:56 PM Changeset in webkit [213470] by achristensen@apple.com
  • 2 edits in trunk/Source/WebCore

Refactor ContentExtensionParser
​https://bugs.webkit.org/show_bug.cgi?id=169214

Reviewed by Brady Eidson.

No change in behavior, as verified by existing API tests.
This will make it easier to use getStringList for other things in coming patches.

  • contentextensions/ContentExtensionParser.cpp:

(WebCore::ContentExtensions::getStringList):
(WebCore::ContentExtensions::getDomainList):

2:55 PM Changeset in webkit [213469] by achristensen@apple.com
  • 11 edits in trunk

Fix URLs relative to file URLs with paths beginning with Windows drive letters
​https://bugs.webkit.org/show_bug.cgi?id=169178

Reviewed by Tim Horton.

LayoutTests/imported/w3c:

  • web-platform-tests/url/a-element-expected.txt:
  • web-platform-tests/url/a-element-xhtml-expected.txt:
  • web-platform-tests/url/url-constructor-expected.txt:

Source/WebCore:

Windows drives in file URLs can begin with windows drive letters, such as ​file:///C:/
which should not be removed when making other URLs relative to them.
See ​https://url.spec.whatwg.org/#file-slash-state

Covered by new API tests and newly passing web-platform-tests.

  • platform/URLParser.cpp:

(WebCore::URLParser::copyBaseWindowsDriveLetter):
(WebCore::URLParser::copyASCIIStringUntil):
(WebCore::URLParser::parse):

  • platform/URLParser.h:

Tools:

  • TestWebKitAPI/Tests/WebCore/URLParser.cpp:

(TestWebKitAPI::TEST_F):

LayoutTests:

  • fast/url/relative-win-expected.txt:

Some tests pass now. localhost should indeed be removed according to the latest spec.

2:46 PM Changeset in webkit [213468] by achristensen@apple.com
  • 3 edits in trunk/Source/ThirdParty/libwebrtc

Fix Production libwebrtc build after r213418
​https://bugs.webkit.org/show_bug.cgi?id=169217
<rdar://problem/30876775>

Reviewed by Tim Horton.

  • Source/webrtc/base/checks.h:
  • libwebrtc.xcodeproj/project.pbxproj:

MakeCheckOpString was a weak export, and it wasn't needed.
There is an internal build that checks for weak exports and fails if there is one.
Run the check-for-weak-vtables-and-externals script for libwebrtc.dylib like we do for the other frameworks.

2:03 PM Changeset in webkit [213467] by commit-queue@webkit.org
  • 29 edits
    4 adds in trunk

op_get_by_id_with_this should use inline caching
​https://bugs.webkit.org/show_bug.cgi?id=162124

Patch by Caio Lima <Caio Lima> on 2017-03-06
Reviewed by Saam Barati.

JSTests:

  • microbenchmarks/super-getter.js: Added.

(A.prototype.get f):
(A):
(B.prototype.get f):
(B):

  • stress/super-force-ic-fail.js: Added.

(let.assert):
(let.aObj.get foo):
(let.obj.jaz):
(let.bObj.get foo):
(let.obj2.foo):

  • stress/super-get-by-id.js: Added.

(assert):
(Base):
(Base.prototype.get name):
(Base.prototype.set name):
(Subclass.prototype.get name):
(Subclass):
(getterName):
(getterValue):
(PolymorphicSubclass.prototype.get value):
(PolymorphicSubclass):
(i.let.BaseCode):
(i.get value):
(MegamorphicSubclass.prototype.get value):
(MegamorphicSubclass):
(let.subObj.get value):
(i.catch):
(subObj.get value):
(BaseException):
(BaseException.prototype.get name):
(SubclassException.prototype.get name):
(SubclassException):
(prototype.foo):
(prototype.get name):
(SubclassExceptionComplex.prototype.get name):
(SubclassExceptionComplex):

  • stress/super-getter-reset-ic.js: Added.

(let.assert):
(let.B.f):

Source/JavaScriptCore:

This patch is enabling inline cache for op_get_by_id_with_this in all
tiers. It means that operations using super.member are going to
be able to be optimized by PIC. To enable it, we introduced a new
member of StructureStubInfo.patch named thisGPR, created a new class
to manage the IC named JITGetByIdWithThisGenerator and changed
PolymorphicAccess.regenerate that uses StructureStubInfo.patch.thisGPR
to decide the correct this value on inline caches.
With inline cached enabled, super.member are ~4.5x faster,
according microbenchmarks.

  • bytecode/AccessCase.cpp:

(JSC::AccessCase::generateImpl):

  • bytecode/PolymorphicAccess.cpp:

(JSC::PolymorphicAccess::regenerate):

  • bytecode/PolymorphicAccess.h:
  • bytecode/StructureStubInfo.cpp:

(JSC::StructureStubInfo::reset):

  • bytecode/StructureStubInfo.h:
  • dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode):

  • dfg/DFGJITCompiler.cpp:

(JSC::DFG::JITCompiler::link):

  • dfg/DFGJITCompiler.h:

(JSC::DFG::JITCompiler::addGetByIdWithThis):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileIn):

  • dfg/DFGSpeculativeJIT.h:

(JSC::DFG::SpeculativeJIT::callOperation):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::cachedGetByIdWithThis):
(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::cachedGetByIdWithThis):
(JSC::DFG::SpeculativeJIT::compile):

  • ftl/FTLLowerDFGToB3.cpp:

(JSC::FTL::DFG::LowerDFGToB3::compileGetByIdWithThis):
(JSC::FTL::DFG::LowerDFGToB3::compileIn):
(JSC::FTL::DFG::LowerDFGToB3::getByIdWithThis):

  • jit/CCallHelpers.h:

(JSC::CCallHelpers::setupArgumentsWithExecState):

  • jit/ICStats.h:
  • jit/JIT.cpp:

(JSC::JIT::JIT):
(JSC::JIT::privateCompileSlowCases):
(JSC::JIT::link):

  • jit/JIT.h:
  • jit/JITInlineCacheGenerator.cpp:

(JSC::JITByIdGenerator::JITByIdGenerator):
(JSC::JITGetByIdWithThisGenerator::JITGetByIdWithThisGenerator):
(JSC::JITGetByIdWithThisGenerator::generateFastPath):

  • jit/JITInlineCacheGenerator.h:

(JSC::JITGetByIdWithThisGenerator::JITGetByIdWithThisGenerator):

  • jit/JITInlines.h:

(JSC::JIT::callOperation):

  • jit/JITOperations.cpp:
  • jit/JITOperations.h:
  • jit/JITPropertyAccess.cpp:

(JSC::JIT::emit_op_get_by_id_with_this):
(JSC::JIT::emitSlow_op_get_by_id_with_this):

  • jit/JITPropertyAccess32_64.cpp:

(JSC::JIT::emit_op_get_by_id_with_this):
(JSC::JIT::emitSlow_op_get_by_id_with_this):

  • jit/Repatch.cpp:

(JSC::appropriateOptimizingGetByIdFunction):
(JSC::appropriateGenericGetByIdFunction):
(JSC::tryCacheGetByID):

  • jit/Repatch.h:
  • jsc.cpp:

(WTF::CustomGetter::getOwnPropertySlot):
(WTF::CustomGetter::customGetterAcessor):

1:45 PM Changeset in webkit [213466] by Simon Fraser
  • 18 edits
    1 copy
    15 adds in trunk

Only use layer backing store which supports subpixel antialiased text if we know subpixel antialiased will be painted into it
​https://bugs.webkit.org/show_bug.cgi?id=169191

Reviewed by Zalan Bujtas.

Source/WebCore:

Instead of unconditionally calling setSupportsSubpixelAntialiasedText() on GraphicsLayers created
by RenderLayerBacking, only do so when we know (or suspect) that a layer contains smoothed text.

This is done by enhancing RenderLayer::isVisuallyNonEmpty() and RenderLayer::hasNonEmptyChildRenderers()
to take a PaintedContentRequest parameter, which allows the caller to specify what qualities of
the layer contents it is interested in. Most of the time, this is just any painted content, but on
platforms where GraphicsLayer::supportsSubpixelAntialiasedLayerText() returns true, the query also
asks about whether the layer will contain subpixel-antialiased text. In this case, it can't early
return as soon as painted content is found; it must keep iterating renderers while all the query
requests are unsatisfied, or until it hits depth or sibling limits. If a limit is hit, we take the
same path of assuming there is subpixel-antialiased text (via the "Undetermined" state).

RenderLayerBacking also makes use of PaintedContentRequest during its non-composited child layer walk.

To offset the additional cost of this tree walking, RenderLayerBacking now caches information about its
painted content for the duration of a single update via PaintedContentsInfo, so we no longer call
isDirectlyCompositedImage() and isSimpleContainerCompositingLayer() multiple times per backing per update.
The traversal code here too now has to continue until all necessary states in the request have been computed.

Add some functions to RenderImage so that we know if it's showing the alt text or has a non-bitmap image
(which may contain text).

Subpixel-antialiased ("smoothed") text is disabled by DRT and WTR by default, so we need Internals API to enable it.

Platforms now express their support for subpixel-antialiased text via GraphicsLayer::supportsSubpixelAntialiasedLayerText()
which only returns true on Mac.

Tests: compositing/contents-format/subpixel-antialiased-text-configs-antialiasing-style.html

compositing/contents-format/subpixel-antialiased-text-configs.html
compositing/contents-format/subpixel-antialiased-text-images.html
compositing/contents-format/subpixel-antialiased-text-visibility.html

  • platform/graphics/GraphicsLayer.cpp:

(WebCore::GraphicsLayer::supportsSubpixelAntialiasedLayerText):

  • platform/graphics/GraphicsLayer.h:
  • platform/graphics/ca/GraphicsLayerCA.cpp:

(WebCore::GraphicsLayer::supportsSubpixelAntialiasedLayerText):
(WebCore::GraphicsLayerCA::changeLayerTypeTo):

  • rendering/RenderImage.cpp:

(WebCore::RenderImage::isShowingMissingOrImageError):
(WebCore::RenderImage::isShowingAltText):
(WebCore::RenderImage::hasNonBitmapImage):

  • rendering/RenderImage.h:
  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::calculateClipRects):

  • rendering/RenderLayer.h:
  • rendering/RenderLayerBacking.cpp:

(WebCore::PaintedContentsInfo::PaintedContentsInfo):
(WebCore::PaintedContentsInfo::setWantsSubpixelAntialiasedTextState):
(WebCore::PaintedContentsInfo::paintsBoxDecorations):
(WebCore::PaintedContentsInfo::paintsContent):
(WebCore::PaintedContentsInfo::paintsSubpixelAntialiasedText):
(WebCore::PaintedContentsInfo::isSimpleContainer):
(WebCore::PaintedContentsInfo::isDirectlyCompositedImage):
(WebCore::PaintedContentsInfo::paintsBoxDecorationsDetermination):
(WebCore::PaintedContentsInfo::paintsContentDetermination):
(WebCore::PaintedContentsInfo::paintsSubpixelAntialiasedTextDetermination):
(WebCore::PaintedContentsInfo::contentsTypeDetermination):
(WebCore::RenderLayerBacking::createGraphicsLayer):
(WebCore::RenderLayerBacking::updateConfiguration):
(WebCore::RenderLayerBacking::computeParentGraphicsLayerRect):
(WebCore::RenderLayerBacking::updateAfterDescendants):
(WebCore::RenderLayerBacking::updateDirectlyCompositedBoxDecorations):
(WebCore::RenderLayerBacking::updateDrawsContent):
(WebCore::RenderLayerBacking::updateDirectlyCompositedBackgroundColor):
(WebCore::RenderLayerBacking::updateDirectlyCompositedBackgroundImage):
(WebCore::RenderLayerBacking::paintsContent):
(WebCore::RenderLayerBacking::isSimpleContainerCompositingLayer):
(WebCore::RenderLayerBacking::isPaintDestinationForDescendantLayers):
(WebCore::RenderLayerBacking::hasVisibleNonCompositedDescendants):
(WebCore::RenderLayerBacking::containsPaintedContent):
(WebCore::RenderLayerBacking::contentChanged):
(WebCore::RenderLayerBacking::updateImageContents):
(WebCore::RenderLayerBacking::paintsChildRenderers): Deleted.

  • rendering/RenderLayerBacking.h:
  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::logLayerInfo):

  • testing/Internals.cpp:

(WebCore::Internals::setFontSmoothingEnabled):

  • testing/Internals.h:
  • testing/Internals.idl:

LayoutTests:

Test lots of layer configs for subpixel antialiased text support. Only Mac results show the
"(supports subpixel antialiased text 1)" flag on layers now, since the patch makes this
dependent on platform support.

  • compositing/contents-format/subpixel-antialiased-text-configs-antialiasing-style-expected.txt: Added.
  • compositing/contents-format/subpixel-antialiased-text-configs-antialiasing-style.html: Added.
  • compositing/contents-format/subpixel-antialiased-text-configs-expected.txt: Added.
  • compositing/contents-format/subpixel-antialiased-text-configs.html: Added.
  • compositing/contents-format/subpixel-antialiased-text-enabled-expected.txt:
  • compositing/contents-format/subpixel-antialiased-text-enabled.html:
  • compositing/contents-format/subpixel-antialiased-text-images-expected.txt: Added.
  • compositing/contents-format/subpixel-antialiased-text-images.html: Added.
  • compositing/contents-format/subpixel-antialiased-text-visibility-expected.txt: Added.
  • compositing/contents-format/subpixel-antialiased-text-visibility.html: Added.
  • compositing/resources/circle-with-text.svg: Added.
  • compositing/resources/circle.svg: Added.
  • platform/mac-wk1/compositing/contents-format/subpixel-antialiased-text-enabled-expected.txt:
  • platform/mac/compositing/contents-format/subpixel-antialiased-text-configs-antialiasing-style-expected.txt: Added.
  • platform/mac/compositing/contents-format/subpixel-antialiased-text-configs-expected.txt: Added.
  • platform/mac/compositing/contents-format/subpixel-antialiased-text-enabled-expected.txt: Copied from LayoutTests/compositing/contents-format/subpixel-antialiased-text-enabled-expected.txt.
  • platform/mac/compositing/contents-format/subpixel-antialiased-text-images-expected.txt: Added.
  • platform/mac/compositing/contents-format/subpixel-antialiased-text-visibility-expected.txt: Added.
1:44 PM Changeset in webkit [213465] by sbarati@apple.com
  • 9 edits in trunk

WebAssembly: implement init_expr for Element
​https://bugs.webkit.org/show_bug.cgi?id=165888
<rdar://problem/29760199>

Reviewed by Keith Miller.

JSTests:

  • wasm/Builder_WebAssemblyBinary.js:

(const.emitters.Element):

  • wasm/assert.js:
  • wasm/js-api/element.js:

(assert.throws):
(badInstantiation.makeModule):
(badInstantiation.test):
(badInstantiation):

  • wasm/js-api/global-error.js:

Source/JavaScriptCore:

This patch fixes a few bugs. The main change is allowing init_expr
for the Element's offset. To do this, I had to fix a couple of
other bugs:

  • I removed our invalid early module-parse-time invalidation

of out of bound Element sections. This is not in the spec because
it can't be validated in the general case when the offset is a
get_global.

  • Our get_global validation inside our init_expr parsing code was simply wrong.

It thought that the index operand to get_global went into the pool of imports,
but it does not. It indexes into the pool of globals. I changed the code to
refer to the global pool instead.

  • wasm/WasmFormat.h:

(JSC::Wasm::Element::Element):

  • wasm/WasmModuleParser.cpp:
  • wasm/js/WebAssemblyModuleRecord.cpp:

(JSC::WebAssemblyModuleRecord::evaluate):

1:40 PM Changeset in webkit [213464] by mmaxfield@apple.com
  • 56 edits
    2 copies
    7 adds in trunk

Expand font-weight and font-stretch to take any number
​https://bugs.webkit.org/show_bug.cgi?id=168889

Reviewed by Simon Fraser.

Source/WebCore:

This patch expands parsing support for font-weight and font-stretch so that they can accept
numbers in addition to the keyword values they accepted previously. Eventually, these numbers
will be used as inputs to select variation fonts; however, in this patch, the values are just
parsed and held in our internal data model. This means that this patch doesn't actually change
the general behavior of WebKit; instead, it parses new values, outputs them (via
getComputedStyle() and similar functions), and provides them as input to our preexisting font
selection algorithm.

This patch doesn't actually modify anything algorithmically, and therefore, it doesn't include
any additional tests for the font selection algorithm. Instead, it tests the parsing of the
newly accepted values (both input and output).

Because our internal data model needs to hold numbers now, this patch also completely eliminates
the FontWidth, FontItalic, and FontTraitsMask enum values in favor of FontSelectionValues (which
can hold numbers instead of individual enum values). Therefore, every place which we were using
these enum values is migrated in this patch to using FontSelectionValues instead.

Tests: fast/text/font-selection-font-face-parse.html

fast/text/font-selection-font-loading-api-parse.html
fast/text/font-style-parse.html
fast/text/font-weight-parse.html

  • accessibility/AccessibilityRenderObject.cpp: Migrate off of old enum types.

(WebCore::AccessibilityRenderObject::hasBoldFont):
(WebCore::AccessibilityRenderObject::hasItalicFont):
(WebCore::AccessibilityRenderObject::hasPlainText):

  • accessibility/atk/WebKitAccessibleInterfaceText.cpp: Ditto.

(getAttributeSetForAccessibilityObject):

  • css/CSSComputedStyleDeclaration.cpp: Output newly parsed values.

(WebCore::fontWeightFromStyle):
(WebCore::fontStretchFromStyle):
(WebCore::fontStyleFromStyle):
(WebCore::fontShorthandValueForSelectionProperties):
(WebCore::ComputedStyleExtractor::propertyValue):

  • css/CSSFontFace.cpp: Migrate off old enum types.

(WebCore::calculateWeightRange):
(WebCore::CSSFontFace::setWeight):
(WebCore::calculateStretchRange):
(WebCore::CSSFontFace::setStretch):
(WebCore::calculateStyleRange):
(WebCore::CSSFontFace::setStyle):
(WebCore::CSSFontFace::calculateStyleMask): Deleted.
(WebCore::CSSFontFace::calculateWeightMask): Deleted.
(WebCore::CSSFontFace::calculateStretch): Deleted.

  • css/CSSFontFace.h:
  • css/CSSFontFaceSet.cpp: Migrate off old enum types.

(WebCore::CSSFontFaceSet::ensureLocalFontFacesForFamilyRegistered):
(WebCore::calculateWeightValue):
(WebCore::calculateStretchValue):
(WebCore::calculateStyleValue):
(WebCore::computeFontSelectionRequest):
(WebCore::CSSFontFaceSet::matchingFaces):
(WebCore::CSSFontFaceSet::fontFace):
(WebCore::computeFontTraitsMask): Deleted.
(WebCore::computeFontStretch): Deleted.

  • css/CSSFontFaceSet.h:
  • css/CSSFontSelector.cpp: Migrate off old enum types.

(WebCore::CSSFontSelector::fontRangesForFamily):

  • css/CSSPrimitiveValueMappings.h: font-weight and font-style are no longer

keyword properties.
(WebCore::CSSPrimitiveValue::operator FontWeight): Deleted.
(WebCore::CSSPrimitiveValue::operator FontItalic): Deleted.

  • css/CSSProperties.json: Use the same infrastructure for all three of the

font selection properties.

  • css/CSSSegmentedFontFace.cpp: Migrate off old enum types.

(WebCore::CSSSegmentedFontFace::fontRanges):

  • css/CSSValueKeywords.in: The 100-based font-weight values are now represented

as real numbers.

  • css/FontFace.cpp: Update the string output functions for the new values.

(WebCore::rangeIsSingleValue):
(WebCore::FontFace::style):
(WebCore::FontFace::weight):
(WebCore::FontFace::stretch):

  • css/StyleBuilderConverter.h: Use CSSValue conversion functions to convert

to our new data model.
(WebCore::StyleBuilderConverter::convertFontWeight):
(WebCore::StyleBuilderConverter::convertFontStretch):
(WebCore::StyleBuilderConverter::convertFontStyle):

  • css/StyleBuilderCustom.h: font-weight is no longer a completely custom

property.
(WebCore::StyleBuilderCustom::applyInitialFontWeight): Deleted.
(WebCore::StyleBuilderCustom::applyInheritFontWeight): Deleted.
(WebCore::StyleBuilderCustom::applyValueFontWeight): Deleted.

  • css/parser/CSSParserFastPaths.cpp: font-style is no longer a keyword property.

(WebCore::CSSParserFastPaths::isValidKeywordPropertyAndValue):
(WebCore::CSSParserFastPaths::isKeywordPropertyID):

  • css/parser/CSSPropertyParser.cpp: Parse the new values in the font selection

properties.
(WebCore::consumeFontWeightKeywordValue):
(WebCore::consumeFontWeightCSS21):
(WebCore::consumeFontWeight):
(WebCore::consumeFontStyleKeywordValue):
(WebCore::consumeFontStyle):
(WebCore::CSSPropertyParser::parseSingleValue):
(WebCore::CSSPropertyParser::parseFontFaceDescriptor):
(WebCore::CSSPropertyParser::consumeSystemFont):
(WebCore::CSSPropertyParser::consumeFont):

  • editing/EditingStyle.cpp: Migrate off old enum types.

(WebCore::fontWeightIsBold):

  • editing/mac/EditorMac.mm: Ditto.

(WebCore::Editor::applyFontStyles):

  • platform/graphics/FontCache.h: Unify our font selection values into

their enclosing struct, FontSelectionCapabilities. Also, clean up utility
functions.

  • platform/graphics/FontCascade.cpp: Migrate off old enum types.

(WebCore::FontCascade::FontCascade):

  • platform/graphics/FontCascade.h: Ditto.

(WebCore::FontCascade::italic):
(WebCore::FontCascade::weight):

  • platform/graphics/FontDescription.cpp: Ditto.

(WebCore::FontDescription::FontDescription):
(WebCore::FontCascadeDescription::lighterWeight):
(WebCore::FontCascadeDescription::bolderWeight):
(WebCore::FontDescription::traitsMask): Deleted.

  • platform/graphics/FontDescription.h: Migrate off old enum types.

(WebCore::FontDescription::italic):
(WebCore::FontDescription::stretch):
(WebCore::FontDescription::weight):
(WebCore::FontDescription::fontSelectionRequest):
(WebCore::FontDescription::computedPixelSize):
(WebCore::FontDescription::setItalic):
(WebCore::FontDescription::setStretch):
(WebCore::FontDescription::setIsItalic):
(WebCore::FontDescription::setWeight):
(WebCore::FontDescription::operator==):
(WebCore::FontCascadeDescription::lighterWeight):
(WebCore::FontCascadeDescription::bolderWeight):
(WebCore::FontCascadeDescription::initialItalic):
(WebCore::FontCascadeDescription::initialWeight):
(WebCore::FontCascadeDescription::initialStretch):

  • platform/graphics/FontSelectionAlgorithm.cpp: Delete code which was only

present to convert from the old enum types to the new FontSelectionRequest
type.
(WebCore::fontSelectionRequestForTraitsMask): Deleted.
(WebCore::initialFontSelectionCapabilitiesForTraitsMask): Deleted.
(WebCore::fontSelectionCapabilitiesForTraitsMask): Deleted.

  • platform/graphics/FontSelectionAlgorithm.h: Migrate to new named functions

for special values.
(WebCore::isItalic):
(WebCore::boldWeightValue):
(WebCore::normalWeightValue):
(WebCore::isFontWeightBold):
(WebCore::normalStretchValue):
(WebCore::FontSelectionRequest::FontSelectionRequest):

  • platform/graphics/cocoa/FontCacheCoreText.cpp: Migrate all platforms which

compile this file to know about FontDatabase. This simplifies the interaction
between @font-face fonts and installed fonts. Also, migrate off old enum types.
(WebCore::stretchFromCoreTextTraits):
(WebCore::fontWeightFromCoreText):
(WebCore::capabilitiesForFontDescriptor):
(WebCore::FontCache::getFontSelectionCapabilitiesInFamily):
(WebCore::platformFontLookupWithFamily):
(WebCore::invalidateFontCache):
(WebCore::fontWithFamily):
(WebCore::FontCache::createFontPlatformData):
(WebCore::lookupFallbackFont):
(WebCore::toTraitsMask): Deleted.
(WebCore::isFontWeightBold): Deleted.
(WebCore::toCoreTextFontWeight): Deleted.
(): Deleted.
(WebCore::FontDatabase::capabilitiesForFontDescriptor): Deleted.
(WebCore::calculateFontSelectionRequest): Deleted.

  • platform/graphics/freetype/FontCacheFreeType.cpp: Migrate off old enum types.

(WebCore::FontCache::getFontSelectionCapabilitiesInFamily):
(WebCore::fontWeightToFontconfigWeight):
(): Deleted.

  • platform/graphics/freetype/FontPlatformDataFreeType.cpp: Ditto.

(WebCore::FontPlatformData::FontPlatformData):

  • platform/graphics/ios/FontCacheIOS.mm: Ditto.

(WebCore::baseSystemFontDescriptor):
(WebCore::systemFontModificationAttributes):
(WebCore::systemFontDescriptor):
(WebCore::platformFontWithFamilySpecialCase):
(WebCore::FontCache::weightOfCTFont): Deleted.

  • platform/graphics/mac/FontCacheMac.mm: Ditto.

(WebCore::toNSFontWeight):
(WebCore::platformFontWithFamilySpecialCase):

  • platform/graphics/win/FontCacheWin.cpp: Ditto.

(WebCore::toGDIFontWeight):
(WebCore::traitsInFamilyEnumProc):
(WebCore::FontCache::getFontSelectionCapabilitiesInFamily):
(): Deleted.

  • platform/mock/MockRealtimeVideoSource.cpp: Ditto.

(WebCore::MockRealtimeVideoSource::applySize):

  • platform/text/TextFlags.h: Delete old enum types.
  • platform/win/DragImageWin.cpp: Migrate off old enum types.

(WebCore::dragLabelFont):

  • rendering/RenderEmbeddedObject.cpp: Ditto.

(WebCore::RenderEmbeddedObject::getReplacementTextGeometry):

  • rendering/RenderThemeGtk.cpp: Ditto.

(WebCore::RenderThemeGtk::updateCachedSystemFontDescription):

  • rendering/RenderThemeIOS.mm: Ditto.

(WebCore::RenderThemeIOS::updateCachedSystemFontDescription):

  • rendering/RenderThemeMac.mm: Ditto.

(WebCore::toFontWeight):

  • rendering/RenderThemeWin.cpp: Ditto.

(WebCore::fillFontDescription):

Source/WebKit/mac:

Migrate off old enum types.

  • WebCoreSupport/PopupMenuMac.mm:

(PopupMenuMac::populate):

  • WebView/WebHTMLView.mm:

(fontNameForDescription):

  • WebView/WebView.mm:

(-[WebView updateTextTouchBar]):

Source/WebKit/win:

Migrate off old enum types.

  • WebKitGraphics.cpp:

(makeFont):

Source/WebKit2:

Migrate off old enum types.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::editorState):

Tools:

Migrate off old enum types.

  • TestWebKitAPI/Tests/WebCore/FontCache.cpp:

(TestWebKitAPI::createPlatformFont):
(TestWebKitAPI::compareFonts):
(TestWebKitAPI::TEST_F):

LayoutTests:

  • fast/text/font-selection-font-face-parse-expected.txt: Added.
  • fast/text/font-selection-font-face-parse.html: Added.
  • fast/text/font-selection-font-loading-api-parse-expected.txt: Added.
  • fast/text/font-selection-font-loading-api-parse.html: Added.
  • fast/text/font-stretch-parse-expected.txt:
  • fast/text/font-stretch-parse.html:
  • fast/text/font-style-parse-expected.txt: Copied from LayoutTests/fast/text/font-stretch-parse-expected.txt.
  • fast/text/font-style-parse.html: Added.
  • fast/text/font-weight-parse-expected.txt: Copied from LayoutTests/fast/text/font-stretch-parse-expected.txt.
  • fast/text/font-weight-parse.html: Added.
1:14 PM Changeset in webkit [213463] by Jon Davis
  • 5 edits
    1 copy in trunk/PerformanceTests

Refined the ARES-6 experience
​https://bugs.webkit.org/show_bug.cgi?id=169205

Reviewed by Saam Barati.

  • ARES-6/about.html: Copied from PerformanceTests/ARES-6/index.html.
  • ARES-6/driver.js:

(Driver.prototype.start):
(Driver.prototype._updateIterations):
(Driver):

  • ARES-6/index.html:
  • ARES-6/stats.js:

(Stats.prototype.toString.span.span):

  • ARES-6/styles.css:

(body):
(.swoop):
(p):
(.logo):
(.start):
(.test):
(.test:nth-child(odd)):
(.overall):
(.about h2):
(.button):
(.button:hover):
(.button.return:before):
(@keyframes fade-in):
(@keyframes scale-in):
(@keyframes flicker-in):
(@keyframes wipe-in):
(.flip): Deleted.
(.testing, .about): Deleted.
(.testing): Deleted.
(.about): Deleted.
(#about:target): Deleted.

1:13 PM Changeset in webkit [213462] by clopez@igalia.com
  • 2 edits in trunk/LayoutTests

[GTK] Mark fast/parser/adoption-agency-unload-iframe-4.html as timing out on platform GTK.

Unreviewed test gardening.

  • platform/gtk/TestExpectations:
12:27 PM Changeset in webkit [213461] by commit-queue@webkit.org
  • 2 edits in trunk/PerformanceTests

StandardCanPlayThrough.html does not work on iOS.
​https://bugs.webkit.org/show_bug.cgi?id=169207

Patch by Jeremy Jones <​jeremyj@apple.com> on 2017-03-06
Reviewed by Jer Noble.

On iOS only, add muted=true and autoplay=allowed. The loading policy on iOS requires these attributes to load enough
data to trigger canPlayThrough.

  • Media/StandardCanPlayThrough.html:
11:43 AM Changeset in webkit [213460] by Chris Dumez
  • 12 edits
    2 adds in trunk

[iOS] Disable autoplay of silent videos in low power mode
​https://bugs.webkit.org/show_bug.cgi?id=168985
<rdar://problem/30739051>

Reviewed by Jer Noble.

Source/WebCore:

Disable autoplay of silent videos in low power mode on iOS to save battery.
We force the display of the start button when denying autoplay in low power
mode to allow the user to start playback.

Test: media/modern-media-controls/start-support/start-support-lowPowerMode.html

  • Modules/mediacontrols/MediaControlsHost.cpp:

(WebCore::MediaControlsHost::shouldForceControlsDisplay):

  • Modules/mediacontrols/MediaControlsHost.h:
  • Modules/mediacontrols/MediaControlsHost.idl:

Add shouldForceControlsDisplay property on MediaControlsHost. This property
is set to true when we want to force the display for media controls. Currently,
this only returns true for autoplay videos, while in low power mode.

  • Modules/modern-media-controls/media/controls-visibility-support.js:

(ControlsVisibilitySupport.prototype._updateControls):
Take into consideration MediaControlsHost.shouldForceControlsDisplay when
initializing shouldShowControls variable.

  • Modules/modern-media-controls/media/start-support.js:

(StartSupport.prototype._shouldShowStartButton):
Show the start button when MediaControlsHost.shouldForceControlsDisplay
returns true.

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::HTMLMediaElement):
Add MediaElementSession::RequireUserGestureForVideoDueToLowPowerMode restriction
to the session when low power mode is enabled so we know we need to force a
gesture to start playback of autoplay videos.

(WebCore::HTMLMediaElement::shouldForceControlsDisplay):
Add convenience function to decide if we should force display of media controls.
This returns true if the media element is a video with autoplay attribute and
its session has the MediaElementSession::RequireUserGestureForVideoDueToLowPowerMode
restriction (i.e. we are in low power mode).

(WebCore::HTMLMediaElement::configureMediaControls):
Force requireControls variable to true if shouldForceControlsDisplay() returns
true. We do this here instead of inside HTMLMediaElement::controls() because
we do not want to change the value of media.controls exposed to JavaScript.

(WebCore::HTMLMediaElement::removeBehaviorsRestrictionsAfterFirstUserGesture):
Add MediaElementSession::RequireUserGestureForVideoDueToLowPowerMode to the list
of restrictions that get removed on user gesture.

  • html/MediaElementSession.cpp:

(WebCore::MediaElementSession::playbackPermitted):
Deny playback for videos that have the RequireUserGestureForVideoDueToLowPowerMode
restriction unless there is a user gesture.

  • html/MediaElementSession.h:

Add new MediaElementSession::RequireUserGestureForVideoDueToLowPowerMode
restriction.

LayoutTests:

Add layout test coverage.

  • media/modern-media-controls/start-support/start-support-lowPowerMode-expected.txt: Added.
  • media/modern-media-controls/start-support/start-support-lowPowerMode.html: Added.
11:24 AM Changeset in webkit [213459] by Ryan Haddad
  • 2 edits in trunk/LayoutTests

Mark media/modern-media-controls/icon-button/icon-button-active-state.html as flaky.
​https://bugs.webkit.org/show_bug.cgi?id=167752

Unreviewed test gardening.

  • platform/mac-wk1/TestExpectations:
11:14 AM Changeset in webkit [213458] by Chris Dumez
  • 16 edits in trunk

LayoutTest fast/dom/timer-throttling-hidden-page.html is a flaky failure
​https://bugs.webkit.org/show_bug.cgi?id=168927

Reviewed by Simon Fraser.

Source/WebCore:

Update internals.isTimerThrottled() to return true for any kind of throttling.
It used to only account only for specific timers that do not cause changes
inside the viewport. It now accounts for all kind of throttling, such as
timer alignment due to the page being hidden.

  • page/DOMTimer.h:
  • testing/Internals.cpp:

(WebCore::Internals::isTimerThrottled):

LayoutTests:

  • fast/dom/nested-timer-visible-element-throttling.html:
  • fast/dom/repeating-timer-element-overflow-throttling.html:
  • fast/dom/repeating-timer-element-overflowing-child-own-layer-throttling.html:
  • fast/dom/repeating-timer-mixed-visible-display-none-elements-throttling.html:
  • fast/dom/repeating-timer-visible-element-throttling.html:
  • fast/dom/timer-height-change-no-throttling.html:
  • fast/frames/flattening/resources/iframe-to-resize.html:

Use 10 milliseconds interval for tests relying on internals.isTimerThrottled().
Using 0 is problematic because we always internally cap to 1ms and 4ms after
reaching the max nesting level. Therefore, a 0 delay timer is always considered
to be throttled.

  • fast/dom/timer-throttling-hidden-page-expected.txt:
  • fast/dom/timer-throttling-hidden-page-non-nested-expected.txt:
  • fast/dom/timer-throttling-hidden-page-non-nested.html:
  • fast/dom/timer-throttling-hidden-page.html:

Rewrite tests to stop measuring timer intervals as this is inherently
flaky and rely on internals.isTimerThrottled() instead.

  • platform/mac/TestExpectations:

Unskip test that used to be flaky.

11:09 AM Changeset in webkit [213457] by Manuel Rego Casasnovas
  • 5 edits
    286 adds in trunk/LayoutTests

[css-grid] Import W3C Test Suite
​https://bugs.webkit.org/show_bug.cgi?id=169196

Reviewed by Youenn Fablet.

LayoutTests/imported/w3c:

This patch imports the CSS Grid Layout test suite from csswg-test repository:
​https://github.com/w3c/csswg-test/tree/master/css-grid-1

  • csswg-test/css-grid-1/OWNERS: Added.
  • csswg-test/css-grid-1/README.md: Added.
  • csswg-test/css-grid-1/grid-definition/fr-unit-expected.html: Added.
  • csswg-test/css-grid-1/grid-definition/fr-unit-with-percentage-expected.html: Added.
  • csswg-test/css-grid-1/grid-definition/fr-unit-with-percentage.html: Added.
  • csswg-test/css-grid-1/grid-definition/fr-unit.html: Added.
  • csswg-test/css-grid-1/grid-definition/grid-inline-support-flexible-lengths-001-expected.txt: Added.
  • csswg-test/css-grid-1/grid-definition/grid-inline-support-flexible-lengths-001.xht: Added.
  • csswg-test/css-grid-1/grid-definition/grid-inline-support-grid-template-areas-001-expected.txt: Added.
  • csswg-test/css-grid-1/grid-definition/grid-inline-support-grid-template-areas-001.xht: Added.
  • csswg-test/css-grid-1/grid-definition/grid-inline-support-grid-template-columns-rows-001-expected.txt: Added.
  • csswg-test/css-grid-1/grid-definition/grid-inline-support-grid-template-columns-rows-001.xht: Added.
  • csswg-test/css-grid-1/grid-definition/grid-inline-support-named-grid-lines-001-expected.txt: Added.
  • csswg-test/css-grid-1/grid-definition/grid-inline-support-named-grid-lines-001.xht: Added.
  • csswg-test/css-grid-1/grid-definition/grid-inline-support-repeat-001-expected.txt: Added.
  • csswg-test/css-grid-1/grid-definition/grid-inline-support-repeat-001.xht: Added.
  • csswg-test/css-grid-1/grid-definition/grid-inline-template-columns-rows-resolved-values-001-expected.txt: Added.
  • csswg-test/css-grid-1/grid-definition/grid-inline-template-columns-rows-resolved-values-001.xht: Added.
  • csswg-test/css-grid-1/grid-definition/grid-layout-auto-tracks-expected.html: Added.
  • csswg-test/css-grid-1/grid-definition/grid-layout-auto-tracks.html: Added.
  • csswg-test/css-grid-1/grid-definition/grid-layout-basic-expected.html: Added.
  • csswg-test/css-grid-1/grid-definition/grid-layout-basic.html: Added.
  • csswg-test/css-grid-1/grid-definition/grid-layout-repeat-notation-expected.html: Added.
  • csswg-test/css-grid-1/grid-definition/grid-layout-repeat-notation.html: Added.
  • csswg-test/css-grid-1/grid-definition/grid-support-flexible-lengths-001-expected.txt: Added.
  • csswg-test/css-grid-1/grid-definition/grid-support-flexible-lengths-001.xht: Added.
  • csswg-test/css-grid-1/grid-definition/grid-support-grid-template-areas-001-expected.txt: Added.
  • csswg-test/css-grid-1/grid-definition/grid-support-grid-template-areas-001.xht: Added.
  • csswg-test/css-grid-1/grid-definition/grid-support-grid-template-columns-rows-001-expected.txt: Added.
  • csswg-test/css-grid-1/grid-definition/grid-support-grid-template-columns-rows-001.xht: Added.
  • csswg-test/css-grid-1/grid-definition/grid-support-named-grid-lines-001-expected.txt: Added.
  • csswg-test/css-grid-1/grid-definition/grid-support-named-grid-lines-001.xht: Added.
  • csswg-test/css-grid-1/grid-definition/grid-support-repeat-001-expected.txt: Added.
  • csswg-test/css-grid-1/grid-definition/grid-support-repeat-001.xht: Added.
  • csswg-test/css-grid-1/grid-definition/grid-template-columns-rows-resolved-values-001-expected.txt: Added.
  • csswg-test/css-grid-1/grid-definition/grid-template-columns-rows-resolved-values-001.xht: Added.
  • csswg-test/css-grid-1/grid-definition/support/testing-utils.js: Added.

(checkGridTemplateRows):
(testGridTemplateColumnsRows):
(testGridTemplateAreas):
(TestingUtils):

  • csswg-test/css-grid-1/grid-definition/support/w3c-import.log: Added.
  • csswg-test/css-grid-1/grid-definition/w3c-import.log: Added.
  • csswg-test/css-grid-1/grid-items/grid-inline-items-001-expected.xht: Added.
  • csswg-test/css-grid-1/grid-items/grid-inline-items-001.xht: Added.
  • csswg-test/css-grid-1/grid-items/grid-inline-items-002-expected.xht: Added.
  • csswg-test/css-grid-1/grid-items/grid-inline-items-002.xht: Added.
  • csswg-test/css-grid-1/grid-items/grid-inline-items-003-expected.xht: Added.
  • csswg-test/css-grid-1/grid-items/grid-inline-items-003.xht: Added.
  • csswg-test/css-grid-1/grid-items/grid-inline-items-inline-blocks-001-expected.xht: Added.
  • csswg-test/css-grid-1/grid-items/grid-inline-items-inline-blocks-001.xht: Added.
  • csswg-test/css-grid-1/grid-items/grid-inline-order-property-auto-placement-001-expected.xht: Added.
  • csswg-test/css-grid-1/grid-items/grid-inline-order-property-auto-placement-001.xht: Added.
  • csswg-test/css-grid-1/grid-items/grid-inline-order-property-auto-placement-002-expected.xht: Added.
  • csswg-test/css-grid-1/grid-items/grid-inline-order-property-auto-placement-002.xht: Added.
  • csswg-test/css-grid-1/grid-items/grid-inline-order-property-auto-placement-003-expected.xht: Added.
  • csswg-test/css-grid-1/grid-items/grid-inline-order-property-auto-placement-003.xht: Added.
  • csswg-test/css-grid-1/grid-items/grid-inline-order-property-auto-placement-004-expected.xht: Added.
  • csswg-test/css-grid-1/grid-items/grid-inline-order-property-auto-placement-004.xht: Added.
  • csswg-test/css-grid-1/grid-items/grid-inline-order-property-auto-placement-005-expected.xht: Added.
  • csswg-test/css-grid-1/grid-items/grid-inline-order-property-auto-placement-005.xht: Added.
  • csswg-test/css-grid-1/grid-items/grid-inline-order-property-painting-001-expected.xht: Added.
  • csswg-test/css-grid-1/grid-items/grid-inline-order-property-painting-001.xht: Added.
  • csswg-test/css-grid-1/grid-items/grid-inline-order-property-painting-002-expected.xht: Added.
  • csswg-test/css-grid-1/grid-items/grid-inline-order-property-painting-002.xht: Added.
  • csswg-test/css-grid-1/grid-items/grid-inline-order-property-painting-003-expected.xht: Added.
  • csswg-test/css-grid-1/grid-items/grid-inline-order-property-painting-003.xht: Added.
  • csswg-test/css-grid-1/grid-items/grid-inline-order-property-painting-004-expected.xht: Added.
  • csswg-test/css-grid-1/grid-items/grid-inline-order-property-painting-004.xht: Added.
  • csswg-test/css-grid-1/grid-items/grid-inline-order-property-painting-005-expected.xht: Added.
  • csswg-test/css-grid-1/grid-items/grid-inline-order-property-painting-005.xht: Added.
  • csswg-test/css-grid-1/grid-items/grid-inline-z-axis-ordering-001-expected.xht: Added.
  • csswg-test/css-grid-1/grid-items/grid-inline-z-axis-ordering-001.xht: Added.
  • csswg-test/css-grid-1/grid-items/grid-inline-z-axis-ordering-002-expected.xht: Added.
  • csswg-test/css-grid-1/grid-items/grid-inline-z-axis-ordering-002.xht: Added.
  • csswg-test/css-grid-1/grid-items/grid-inline-z-axis-ordering-003-expected.xht: Added.
  • csswg-test/css-grid-1/grid-items/grid-inline-z-axis-ordering-003.xht: Added.
  • csswg-test/css-grid-1/grid-items/grid-inline-z-axis-ordering-004-expected.xht: Added.
  • csswg-test/css-grid-1/grid-items/grid-inline-z-axis-ordering-004.xht: Added.
  • csswg-test/css-grid-1/grid-items/grid-inline-z-axis-ordering-005-expected.xht: Added.
  • csswg-test/css-grid-1/grid-items/grid-inline-z-axis-ordering-005.xht: Added.
  • csswg-test/css-grid-1/grid-items/grid-inline-z-axis-ordering-overlapped-items-001-expected.xht: Added.
  • csswg-test/css-grid-1/grid-items/grid-inline-z-axis-ordering-overlapped-items-001.xht: Added.
  • csswg-test/css-grid-1/grid-items/grid-inline-z-axis-ordering-overlapped-items-002-expected.xht: Added.
  • csswg-test/css-grid-1/grid-items/grid-inline-z-axis-ordering-overlapped-items-002.xht: Added.
  • csswg-test/css-grid-1/grid-items/grid-inline-z-axis-ordering-overlapped-items-003-expected.xht: Added.
  • csswg-test/css-grid-1/grid-items/grid-inline-z-axis-ordering-overlapped-items-003.xht: Added.
  • csswg-test/css-grid-1/grid-items/grid-inline-z-axis-ordering-overlapped-items-004-expected.xht: Added.
  • csswg-test/css-grid-1/grid-items/grid-inline-z-axis-ordering-overlapped-items-004.xht: Added.
  • csswg-test/css-grid-1/grid-items/grid-inline-z-axis-ordering-overlapped-items-005-expected.xht: Added.
  • csswg-test/css-grid-1/grid-items/grid-inline-z-axis-ordering-overlapped-items-005.xht: Added.
  • csswg-test/css-grid-1/grid-items/grid-inline-z-axis-ordering-overlapped-items-006-expected.xht: Added.
  • csswg-test/css-grid-1/grid-items/grid-inline-z-axis-ordering-overlapped-items-006.xht: Added.
  • csswg-test/css-grid-1/grid-items/grid-item-containing-block-001-expected.xht: Added.
  • csswg-test/css-grid-1/grid-items/grid-item-containing-block-001.html: Added.
  • csswg-test/css-grid-1/grid-items/grid-item-containing-block-002-expected.xht: Added.
  • csswg-test/css-grid-1/grid-items/grid-item-containing-block-002.html: Added.
  • csswg-test/css-grid-1/grid-items/grid-item-containing-block-003-expected.xht: Added.
  • csswg-test/css-grid-1/grid-items/grid-item-containing-block-003.html: Added.
  • csswg-test/css-grid-1/grid-items/grid-item-containing-block-004-expected.xht: Added.
  • csswg-test/css-grid-1/grid-items/grid-item-containing-block-004.html: Added.
  • csswg-test/css-grid-1/grid-items/grid-items-001-expected.xht: Added.
  • csswg-test/css-grid-1/grid-items/grid-items-001.xht: Added.
  • csswg-test/css-grid-1/grid-items/grid-items-002-expected.xht: Added.
  • csswg-test/css-grid-1/grid-items/grid-items-002.xht: Added.
  • csswg-test/css-grid-1/grid-items/grid-items-003-expected.xht: Added.
  • csswg-test/css-grid-1/grid-items/grid-items-003.xht: Added.
  • csswg-test/css-grid-1/grid-items/grid-items-inline-blocks-001-expected.xht: Added.
  • csswg-test/css-grid-1/grid-items/grid-items-inline-blocks-001.xht: Added.
  • csswg-test/css-grid-1/grid-items/grid-items-sizing-alignment-001-expected.html: Added.
  • csswg-test/css-grid-1/grid-items/grid-items-sizing-alignment-001.html: Added.
  • csswg-test/css-grid-1/grid-items/grid-layout-grid-in-grid-expected.html: Added.
  • csswg-test/css-grid-1/grid-items/grid-layout-grid-in-grid.html: Added.
  • csswg-test/css-grid-1/grid-items/grid-layout-z-order-a-expected.html: Added.
  • csswg-test/css-grid-1/grid-items/grid-layout-z-order-a.html: Added.
  • csswg-test/css-grid-1/grid-items/grid-layout-z-order-b-expected.html: Added.
  • csswg-test/css-grid-1/grid-items/grid-layout-z-order-b.html: Added.
  • csswg-test/css-grid-1/grid-items/grid-minimum-size-grid-items-001-expected.xht: Added.
  • csswg-test/css-grid-1/grid-items/grid-minimum-size-grid-items-001.xht: Added.
  • csswg-test/css-grid-1/grid-items/grid-minimum-size-grid-items-002-expected.xht: Added.
  • csswg-test/css-grid-1/grid-items/grid-minimum-size-grid-items-002.xht: Added.
  • csswg-test/css-grid-1/grid-items/grid-minimum-size-grid-items-003-expected.xht: Added.
  • csswg-test/css-grid-1/grid-items/grid-minimum-size-grid-items-003.xht: Added.
  • csswg-test/css-grid-1/grid-items/grid-minimum-size-grid-items-004-expected.xht: Added.
  • csswg-test/css-grid-1/grid-items/grid-minimum-size-grid-items-004.xht: Added.
  • csswg-test/css-grid-1/grid-items/grid-minimum-size-grid-items-005-expected.html: Added.
  • csswg-test/css-grid-1/grid-items/grid-minimum-size-grid-items-005.xht: Added.
  • csswg-test/css-grid-1/grid-items/grid-minimum-size-grid-items-006-expected.html: Added.
  • csswg-test/css-grid-1/grid-items/grid-minimum-size-grid-items-006.xht: Added.
  • csswg-test/css-grid-1/grid-items/grid-minimum-size-grid-items-007-expected.html: Added.
  • csswg-test/css-grid-1/grid-items/grid-minimum-size-grid-items-007.xht: Added.
  • csswg-test/css-grid-1/grid-items/grid-minimum-size-grid-items-008-expected.html: Added.
  • csswg-test/css-grid-1/grid-items/grid-minimum-size-grid-items-008.xht: Added.
  • csswg-test/css-grid-1/grid-items/grid-minimum-size-grid-items-009-expected.html: Added.
  • csswg-test/css-grid-1/grid-items/grid-minimum-size-grid-items-009.xht: Added.
  • csswg-test/css-grid-1/grid-items/grid-minimum-size-grid-items-010-expected.xht: Added.
  • csswg-test/css-grid-1/grid-items/grid-minimum-size-grid-items-010.html: Added.
  • csswg-test/css-grid-1/grid-items/grid-minimum-size-grid-items-011-expected.xht: Added.
  • csswg-test/css-grid-1/grid-items/grid-minimum-size-grid-items-011.html: Added.
  • csswg-test/css-grid-1/grid-items/grid-minimum-size-grid-items-012-expected.xht: Added.
  • csswg-test/css-grid-1/grid-items/grid-minimum-size-grid-items-012.html: Added.
  • csswg-test/css-grid-1/grid-items/grid-minimum-size-grid-items-013-expected.xht: Added.
  • csswg-test/css-grid-1/grid-items/grid-minimum-size-grid-items-013.html: Added.
  • csswg-test/css-grid-1/grid-items/grid-minimum-size-grid-items-014-expected.xht: Added.
  • csswg-test/css-grid-1/grid-items/grid-minimum-size-grid-items-014.html: Added.
  • csswg-test/css-grid-1/grid-items/grid-minimum-size-grid-items-015-expected.xht: Added.
  • csswg-test/css-grid-1/grid-items/grid-minimum-size-grid-items-015.html: Added.
  • csswg-test/css-grid-1/grid-items/grid-minimum-size-grid-items-016-expected.xht: Added.
  • csswg-test/css-grid-1/grid-items/grid-minimum-size-grid-items-016.html: Added.
  • csswg-test/css-grid-1/grid-items/grid-minimum-size-grid-items-017-expected.xht: Added.
  • csswg-test/css-grid-1/grid-items/grid-minimum-size-grid-items-017.html: Added.
  • csswg-test/css-grid-1/grid-items/grid-minimum-size-grid-items-018-expected.xht: Added.
  • csswg-test/css-grid-1/grid-items/grid-minimum-size-grid-items-018.html: Added.
  • csswg-test/css-grid-1/grid-items/grid-order-property-auto-placement-001-expected.xht: Added.
  • csswg-test/css-grid-1/grid-items/grid-order-property-auto-placement-001.xht: Added.
  • csswg-test/css-grid-1/grid-items/grid-order-property-auto-placement-002-expected.xht: Added.
  • csswg-test/css-grid-1/grid-items/grid-order-property-auto-placement-002.xht: Added.
  • csswg-test/css-grid-1/grid-items/grid-order-property-auto-placement-003-expected.xht: Added.
  • csswg-test/css-grid-1/grid-items/grid-order-property-auto-placement-003.xht: Added.
  • csswg-test/css-grid-1/grid-items/grid-order-property-auto-placement-004-expected.xht: Added.
  • csswg-test/css-grid-1/grid-items/grid-order-property-auto-placement-004.xht: Added.
  • csswg-test/css-grid-1/grid-items/grid-order-property-auto-placement-005-expected.xht: Added.
  • csswg-test/css-grid-1/grid-items/grid-order-property-auto-placement-005.xht: Added.
  • csswg-test/css-grid-1/grid-items/grid-order-property-painting-001-expected.xht: Added.
  • csswg-test/css-grid-1/grid-items/grid-order-property-painting-001.xht: Added.
  • csswg-test/css-grid-1/grid-items/grid-order-property-painting-002-expected.xht: Added.
  • csswg-test/css-grid-1/grid-items/grid-order-property-painting-002.xht: Added.
  • csswg-test/css-grid-1/grid-items/grid-order-property-painting-003-expected.xht: Added.
  • csswg-test/css-grid-1/grid-items/grid-order-property-painting-003.xht: Added.
  • csswg-test/css-grid-1/grid-items/grid-order-property-painting-004-expected.xht: Added.
  • csswg-test/css-grid-1/grid-items/grid-order-property-painting-004.xht: Added.
  • csswg-test/css-grid-1/grid-items/grid-order-property-painting-005-expected.xht: Added.
  • csswg-test/css-grid-1/grid-items/grid-order-property-painting-005.xht: Added.
  • csswg-test/css-grid-1/grid-items/grid-z-axis-ordering-001-expected.xht: Added.
  • csswg-test/css-grid-1/grid-items/grid-z-axis-ordering-001.xht: Added.
  • csswg-test/css-grid-1/grid-items/grid-z-axis-ordering-002-expected.xht: Added.
  • csswg-test/css-grid-1/grid-items/grid-z-axis-ordering-002.xht: Added.
  • csswg-test/css-grid-1/grid-items/grid-z-axis-ordering-003-expected.xht: Added.
  • csswg-test/css-grid-1/grid-items/grid-z-axis-ordering-003.xht: Added.
  • csswg-test/css-grid-1/grid-items/grid-z-axis-ordering-004-expected.xht: Added.
  • csswg-test/css-grid-1/grid-items/grid-z-axis-ordering-004.xht: Added.
  • csswg-test/css-grid-1/grid-items/grid-z-axis-ordering-005-expected.xht: Added.
  • csswg-test/css-grid-1/grid-items/grid-z-axis-ordering-005.xht: Added.
  • csswg-test/css-grid-1/grid-items/grid-z-axis-ordering-overlapped-items-001-expected.xht: Added.
  • csswg-test/css-grid-1/grid-items/grid-z-axis-ordering-overlapped-items-001.xht: Added.
  • csswg-test/css-grid-1/grid-items/grid-z-axis-ordering-overlapped-items-002-expected.xht: Added.
  • csswg-test/css-grid-1/grid-items/grid-z-axis-ordering-overlapped-items-002.xht: Added.
  • csswg-test/css-grid-1/grid-items/grid-z-axis-ordering-overlapped-items-003-expected.xht: Added.
  • csswg-test/css-grid-1/grid-items/grid-z-axis-ordering-overlapped-items-003.xht: Added.
  • csswg-test/css-grid-1/grid-items/grid-z-axis-ordering-overlapped-items-004-expected.xht: Added.
  • csswg-test/css-grid-1/grid-items/grid-z-axis-ordering-overlapped-items-004.xht: Added.
  • csswg-test/css-grid-1/grid-items/grid-z-axis-ordering-overlapped-items-005-expected.xht: Added.
  • csswg-test/css-grid-1/grid-items/grid-z-axis-ordering-overlapped-items-005.xht: Added.
  • csswg-test/css-grid-1/grid-items/grid-z-axis-ordering-overlapped-items-006-expected.xht: Added.
  • csswg-test/css-grid-1/grid-items/grid-z-axis-ordering-overlapped-items-006.xht: Added.
  • csswg-test/css-grid-1/grid-items/ref-filled-green-100px-square-image.html: Added.
  • csswg-test/css-grid-1/grid-items/support/100x100-green.png: Added.
  • csswg-test/css-grid-1/grid-items/support/100x50-green.png: Added.
  • csswg-test/css-grid-1/grid-items/support/200x200-green.png: Added.
  • csswg-test/css-grid-1/grid-items/support/50x100-green.png: Added.
  • csswg-test/css-grid-1/grid-items/support/50x50-green.png: Added.
  • csswg-test/css-grid-1/grid-items/support/w3c-import.log: Added.
  • csswg-test/css-grid-1/grid-items/w3c-import.log: Added.
  • csswg-test/css-grid-1/grid-layout-properties-expected.txt: Added.
  • csswg-test/css-grid-1/grid-layout-properties.html: Added.
  • csswg-test/css-grid-1/grid-model/display-grid-expected.html: Added.
  • csswg-test/css-grid-1/grid-model/display-grid.html: Added.
  • csswg-test/css-grid-1/grid-model/display-inline-grid-expected.html: Added.
  • csswg-test/css-grid-1/grid-model/display-inline-grid.html: Added.
  • csswg-test/css-grid-1/grid-model/grid-computed-value-display-floated-items-001-expected.txt: Added.
  • csswg-test/css-grid-1/grid-model/grid-computed-value-display-floated-items-001.xht: Added.
  • csswg-test/css-grid-1/grid-model/grid-display-grid-001-expected.xht: Added.
  • csswg-test/css-grid-1/grid-model/grid-display-grid-001.xht: Added.
  • csswg-test/css-grid-1/grid-model/grid-display-inline-grid-001-expected.xht: Added.
  • csswg-test/css-grid-1/grid-model/grid-display-inline-grid-001.xht: Added.
  • csswg-test/css-grid-1/grid-model/grid-first-letter-001-expected.xht: Added.
  • csswg-test/css-grid-1/grid-model/grid-first-letter-001.xht: Added.
  • csswg-test/css-grid-1/grid-model/grid-first-letter-002-expected.xht: Added.
  • csswg-test/css-grid-1/grid-model/grid-first-letter-002.xht: Added.
  • csswg-test/css-grid-1/grid-model/grid-first-letter-003-expected.xht: Added.
  • csswg-test/css-grid-1/grid-model/grid-first-letter-003.xht: Added.
  • csswg-test/css-grid-1/grid-model/grid-first-line-001-expected.xht: Added.
  • csswg-test/css-grid-1/grid-model/grid-first-line-001.xht: Added.
  • csswg-test/css-grid-1/grid-model/grid-first-line-002-expected.xht: Added.
  • csswg-test/css-grid-1/grid-model/grid-first-line-002.xht: Added.
  • csswg-test/css-grid-1/grid-model/grid-first-line-003-expected.xht: Added.
  • csswg-test/css-grid-1/grid-model/grid-first-line-003.xht: Added.
  • csswg-test/css-grid-1/grid-model/grid-float-001-expected.xht: Added.
  • csswg-test/css-grid-1/grid-model/grid-float-001.xht: Added.
  • csswg-test/css-grid-1/grid-model/grid-floats-no-intrude-001-expected.xht: Added.
  • csswg-test/css-grid-1/grid-model/grid-floats-no-intrude-001.xht: Added.
  • csswg-test/css-grid-1/grid-model/grid-inline-first-letter-001-expected.xht: Added.
  • csswg-test/css-grid-1/grid-model/grid-inline-first-letter-001.xht: Added.
  • csswg-test/css-grid-1/grid-model/grid-inline-first-letter-002-expected.xht: Added.
  • csswg-test/css-grid-1/grid-model/grid-inline-first-letter-002.xht: Added.
  • csswg-test/css-grid-1/grid-model/grid-inline-first-letter-003-expected.xht: Added.
  • csswg-test/css-grid-1/grid-model/grid-inline-first-letter-003.xht: Added.
  • csswg-test/css-grid-1/grid-model/grid-inline-first-line-001-expected.xht: Added.
  • csswg-test/css-grid-1/grid-model/grid-inline-first-line-001.xht: Added.
  • csswg-test/css-grid-1/grid-model/grid-inline-first-line-002-expected.xht: Added.
  • csswg-test/css-grid-1/grid-model/grid-inline-first-line-002.xht: Added.
  • csswg-test/css-grid-1/grid-model/grid-inline-first-line-003-expected.xht: Added.
  • csswg-test/css-grid-1/grid-model/grid-inline-first-line-003.xht: Added.
  • csswg-test/css-grid-1/grid-model/grid-inline-float-001-expected.xht: Added.
  • csswg-test/css-grid-1/grid-model/grid-inline-float-001.xht: Added.
  • csswg-test/css-grid-1/grid-model/grid-inline-floats-no-intrude-001-expected.xht: Added.
  • csswg-test/css-grid-1/grid-model/grid-inline-floats-no-intrude-001.xht: Added.
  • csswg-test/css-grid-1/grid-model/grid-inline-margins-no-collapse-001-expected.xht: Added.
  • csswg-test/css-grid-1/grid-model/grid-inline-margins-no-collapse-001.xht: Added.
  • csswg-test/css-grid-1/grid-model/grid-inline-multicol-001-expected.xht: Added.
  • csswg-test/css-grid-1/grid-model/grid-inline-multicol-001.xht: Added.
  • csswg-test/css-grid-1/grid-model/grid-inline-vertical-align-001-expected.xht: Added.
  • csswg-test/css-grid-1/grid-model/grid-inline-vertical-align-001.xht: Added.
  • csswg-test/css-grid-1/grid-model/grid-margins-no-collapse-001-expected.xht: Added.
  • csswg-test/css-grid-1/grid-model/grid-margins-no-collapse-001.xht: Added.
  • csswg-test/css-grid-1/grid-model/grid-multicol-001-expected.xht: Added.
  • csswg-test/css-grid-1/grid-model/grid-multicol-001.xht: Added.
  • csswg-test/css-grid-1/grid-model/grid-support-display-001-expected.txt: Added.
  • csswg-test/css-grid-1/grid-model/grid-support-display-001.xht: Added.
  • csswg-test/css-grid-1/grid-model/grid-vertical-align-001-expected.xht: Added.
  • csswg-test/css-grid-1/grid-model/grid-vertical-align-001.xht: Added.
  • csswg-test/css-grid-1/grid-model/w3c-import.log: Added.
  • csswg-test/css-grid-1/implicit-grids/grid-support-grid-auto-columns-rows-001-expected.html: Added.
  • csswg-test/css-grid-1/implicit-grids/grid-support-grid-auto-columns-rows-001.html: Added.
  • csswg-test/css-grid-1/implicit-grids/w3c-import.log: Added.
  • csswg-test/css-grid-1/layout-algorithm/grid-layout-free-space-unit-expected.html: Added.
  • csswg-test/css-grid-1/layout-algorithm/grid-layout-free-space-unit.html: Added.
  • csswg-test/css-grid-1/layout-algorithm/w3c-import.log: Added.
  • csswg-test/css-grid-1/placement/grid-layout-grid-span-expected.html: Added.
  • csswg-test/css-grid-1/placement/grid-layout-grid-span.html: Added.
  • csswg-test/css-grid-1/placement/grid-layout-lines-expected.html: Added.
  • csswg-test/css-grid-1/placement/grid-layout-lines-shorthands-expected.html: Added.
  • csswg-test/css-grid-1/placement/grid-layout-lines-shorthands.html: Added.
  • csswg-test/css-grid-1/placement/grid-layout-lines.html: Added.
  • csswg-test/css-grid-1/placement/grid-layout-placement-shorthands-expected.html: Added.
  • csswg-test/css-grid-1/placement/grid-layout-placement-shorthands.html: Added.
  • csswg-test/css-grid-1/placement/w3c-import.log: Added.
  • csswg-test/css-grid-1/test-plan/index.html: Added.
  • csswg-test/css-grid-1/test-plan/w3c-import.log: Added.
  • csswg-test/css-grid-1/w3c-import.log: Added.
  • resources/import-expectations.json:
  • resources/resource-files.json:

LayoutTests:

A few tests are not passing yet, so the TextExpectations file
has been updated accordingly linking the different bugs.

11:01 AM Changeset in webkit [213456] by clopez@igalia.com
  • 2 edits in trunk/JSTests

[JSC] [Linux] Test stress/spread-forward-call-varargs-stack-overflow.js fails
​https://bugs.webkit.org/show_bug.cgi?id=169206

Unreviewed test gardening.

  • stress/spread-forward-call-varargs-stack-overflow.js: Skip on Linux platforms.
10:00 AM Changeset in webkit [213455] by hyatt@apple.com
  • 38 edits
    22 adds
    2 deletes in trunk

Enable fieldsets to be flexboxes, grids and multicolumn.
​https://bugs.webkit.org/show_bug.cgi?id=169082

Source/WebCore:

Reviewed by Simon Fraser .

Added new tests in fast/forms/fieldset.

This patch eliminates RenderFieldset and moves the functionality into RenderBlock so that
derived classes can also be fieldsets.

  • CMakeLists.txt:
  • WebCore.xcodeproj/project.pbxproj:

Remove RenderFieldset from the project.

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::titleUIElement):
Call in to RenderBlock now instead of RenderFieldset.

  • html/HTMLFieldSetElement.cpp:

(WebCore::HTMLFieldSetElement::createElementRenderer):

  • html/HTMLFieldSetElement.h:

The fieldset DOM element now uses RenderElement::createFor to make renderers so that multiple display types
can be supported. A special flag has been added that indicates only to make flexbox and block-related
renderers (not table display types).

  • rendering/OrderIterator.cpp:

(WebCore::OrderIterator::shouldSkipChild):
(WebCore::OrderIteratorPopulator::collectChild):

  • rendering/OrderIterator.h:

Streamline child collection for flexboxes and grids to indicate whether the child should be skipped as a return
value from collectChild. Add a shouldSkipChild method that skips both out of flow positioned objects and
excluded children like the legends of fieldsets.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlockRareData::RenderBlockRareData):
When the legend is taller than the fieldset's borderBefore(), intrinsic border is added to the CSS border width.
This intrinsic border being factored in ensures that the padding and content boxes of fieldsets are correct
across any layout system, since the legend is now just treated as part of the border.

(WebCore::RenderBlock::computePreferredLogicalWidths):
(WebCore::RenderBlock::computeBlockPreferredLogicalWidths):
Call the new computePreferredWidthsForExcludedChildren to ensure that excluded children contribute to
preferred width in their own way and not as part of a specific layout system.

(WebCore::RenderBlock::renderName):
Hacked to still return RenderFieldSet for RenderBlockFlow-backed fieldsets for layout test compatibility.

(WebCore::RenderBlock::layoutExcludedChildren):
Renamed from layoutSpecialExcludedChild to more accurately reflect the fact that multiple excluded children
can be included here (e.g., both a multicolumn flow thread and a legend). The RenderBlock base class handles
the layout of legends by both placing them and setting the correct intrinsic border before amount on the
block.

(WebCore::RenderBlock::findFieldsetLegend):
Moved from RenderFieldset.

(WebCore::RenderBlock::adjustBorderBoxRectForPainting):
(WebCore::RenderBlock::paintRectToClipOutFromBorder):
These methods are used when painting to shrink the border box as needed to account for the legend and to
provide the portion of the border that needs to be clipped out. These methods have been enhanced to
properly support all writing modes.

(WebCore::RenderBlock::intrinsicBorderForFieldset):
(WebCore::RenderBlock::setIntrinsicBorderForFieldset):
(WebCore::RenderBlock::borderTop):
(WebCore::RenderBlock::borderLeft):
(WebCore::RenderBlock::borderBottom):
(WebCore::RenderBlock::borderRight):
(WebCore::RenderBlock::borderBefore):
These methods are overridden for border to ensure that the intrinsic border added by a tall legend is
properly factored in.

(WebCore::RenderBlock::computePreferredWidthsForExcludedChildren):

  • rendering/RenderBlock.h:

This method computes the preferred widths for legend children in order to ensure that the legend properly
grows the width of the fieldset when it is the widest item.

(WebCore::RenderBlock::adjustBorderBoxLogicalHeightForBoxSizing):
(WebCore::RenderBlock::adjustContentBoxLogicalHeightForBoxSizing):
Preserve the behavior of fieldsets in that the available content size includes the space lost accounting
for the legend. I don't think this makes much sense, but it matches the behavior of other browsers
(and our old behavior).

(WebCore::RenderBlock::paintExcludedChildrenInBorder):
Method for painting the excluded children that might be present in our border. We only do this if the
paint phase is a box decoration painting phase and if the legend isn't self-painting.

  • rendering/RenderBlockFlow.cpp:

(WebCore::RenderBlockFlow::willCreateColumns):
Allow fieldsets to create columns now.

(WebCore::RenderBlockFlow::layoutBlockChildren):
(WebCore::RenderBlockFlow::layoutExcludedChildren):
Renamed this method and change it to call the base class to ensure that legends in multicolumn fieldsets
get handled properly.

(WebCore::RenderBlockFlow::addChild):
Patched to make sure legends don't get put into the multicolumn flow thread, as they need to
remain outside of it.

(WebCore::RenderBlockFlow::layoutSpecialExcludedChild): Deleted.
Renamed to layoutExcludedChildren.

  • rendering/RenderBlockFlow.h:
  • rendering/RenderBox.cpp:

(WebCore::RenderBox::paintBoxDecorations):
(WebCore::RenderBox::paintMask):
Patched to call the new adjustBorderBoxRectForPainting and paintRectToClipOutFromBorder methods in
order to properly shrink the border box rect for painting and to clip out the portion of the border
covered by the legend.

(WebCore::RenderBox::avoidsFloats):
Add fieldsets as avoiding floats. RenderFieldset used to subclass this method to return true, but with
its removal, we need to put this in the base class along with legends.

  • rendering/RenderBox.h:

(WebCore::RenderBox::isGridItem):
(WebCore::RenderBox::isFlexItem):
Patched to exclude legends so that they don't try to size like they are really in the grid or flexbox.

(WebCore::RenderBox::adjustBorderBoxRectForPainting):
This method is overridden by RenderBLock to handle adjusting fieldset border rects for painting.

  • rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::paintBorder):

  • rendering/RenderBoxModelObject.h:

(WebCore::RenderBoxModelObject::paintRectToClipOutFromBorder):
Patched to properly paint fieldsets using the new helpers.

  • rendering/RenderDeprecatedFlexibleBox.cpp:

(WebCore::FlexBoxIterator::next):
(WebCore::RenderDeprecatedFlexibleBox::layoutBlock):
(WebCore::RenderDeprecatedFlexibleBox::layoutHorizontalBox):
Make sure deprecated flexible boxes lay out their legends properly by calling layoutExcludedChildren.

  • rendering/RenderElement.cpp:

(WebCore::RenderElement::createFor):

  • rendering/RenderElement.h:

Patched to take a flag that limits what renderers can be created so that fieldsets don't make table
display types.

  • rendering/RenderFieldset.cpp: Removed.
  • rendering/RenderFieldset.h: Removed.

Remove RenderFieldset files from the tree.

  • rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::computeIntrinsicLogicalWidths):
(WebCore::RenderFlexibleBox::firstLineBaseline):
(WebCore::RenderFlexibleBox::layoutBlock):
(WebCore::RenderFlexibleBox::layoutFlexItems):
(WebCore::RenderFlexibleBox::prepareOrderIteratorAndMargins):
Make sure flexible boxes lay out their legends properly by calling layoutExcludedChildren.
Patch methods to use the OrderIterator's new shouldSkipChild method to ensure legends aren't
part of the flexible box layout.

  • rendering/RenderGrid.cpp:

(WebCore::RenderGrid::layoutBlock):
(WebCore::RenderGrid::computeIntrinsicLogicalWidths):
(WebCore::RenderGrid::placeItemsOnGrid):
(WebCore::RenderGrid::populateExplicitGridAndOrderIterator):
(WebCore::RenderGrid::layoutGridItems):
Make sure grids lay out their legends properly by calling layoutExcludedChildren.
Patch methods to use the OrderIterator's new shouldSkipChild method to ensure legends aren't
part of the grid's layout.

  • rendering/RenderMultiColumnFlowThread.cpp:

(WebCore::RenderMultiColumnFlowThread::populate):
Pull legends back up into the block and don't let them be part of the flow thread.

  • rendering/RenderMultiColumnSet.cpp:

(WebCore::RenderMultiColumnSet::requiresBalancing):
Fix an assert to allow legends to exist as siblings of multicolumn sets.

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::isFieldset):
Changed to examine the HTML element rather than RenderFieldset.

  • rendering/RenderObject.h:

(WebCore::RenderObject::isExcludedFromNormalLayout):
(WebCore::RenderObject::setIsExcludedFromNormalLayout):
(WebCore::RenderObject::RenderObjectBitfields::RenderObjectBitfields):
RenderObjects now have a new bit that is set for excluded objects like legends, flow threads,
placeholders, and ruby text. This bit lets code easily detect that an object is excluded from
the layout system and can be skipped.

(WebCore::RenderObject::isExcludedAndPlacedInBorder):
Helper method for asking if an object is painting inside the border. Used to know we
need to factor it into preferred width calculations outside of any one layout system
and also to know that we need to paint it when we paint the fieldset's border instead of
later (after we might have scrolled or clipped the child painting area).

  • rendering/RenderRubyRun.cpp:

(WebCore::RenderRubyRun::layoutExcludedChildren):
(WebCore::RenderRubyRun::layoutSpecialExcludedChild): Deleted.

  • rendering/RenderRubyRun.h:

Rename layoutSpecialExcludedChild to layoutExcludedChildren.

  • rendering/RenderTable.cpp:

(WebCore::RenderTable::adjustBorderBoxRectForPainting):
(WebCore::RenderTable::paintBoxDecorations):
(WebCore::RenderTable::paintMask):
(WebCore::RenderTable::subtractCaptionRect): Deleted.

  • rendering/RenderTable.h:

Patched tables to share the same border box rect adjustment used by fieldsets when subtracting
out captions. This is prep work to allow tables to be fieldsets, but for now I didn't go all the
way.

  • rendering/RenderTableCell.cpp:

(WebCore::RenderTableCell::paintBoxDecorations):
(WebCore::RenderTableCell::paintMask):
Make sure table cells adjust their border box rects for painting. Again this is prep work for
cells potentially being fieldsets, but not supported yet.

  • rendering/RenderTextControl.cpp:

(WebCore::RenderTextControl::layoutExcludedChildren):
(WebCore::RenderTextControl::layoutSpecialExcludedChild): Deleted.

  • rendering/RenderTextControl.h:
  • rendering/RenderTextControlMultiLine.cpp:

(WebCore::RenderTextControlMultiLine::layoutExcludedChildren):
(WebCore::RenderTextControlMultiLine::layoutSpecialExcludedChild): Deleted.

  • rendering/RenderTextControlMultiLine.h:

Renamed the methods for doing the excluded child layout.

  • rendering/RenderTreeAsText.cpp:

(WebCore::RenderTreeAsText::writeRenderObject):
Make sure to dump the original fieldset border and not the border with the extra legend stuff in it.

LayoutTests:

Reviewed by Simon Fraser.

  • fast/forms/fieldset/abs-pos-child-sizing-expected.html: Added.
  • fast/forms/fieldset/abs-pos-child-sizing.html: Added.
  • fast/forms/fieldset/fieldset-deprecated-flexbox-expected.html: Added.
  • fast/forms/fieldset/fieldset-deprecated-flexbox.html: Added.
  • fast/forms/fieldset/fieldset-flexbox-expected.html: Added.
  • fast/forms/fieldset/fieldset-flexbox.html: Added.
  • fast/forms/fieldset/fieldset-grid-expected.html: Added.
  • fast/forms/fieldset/fieldset-grid.html: Added.
  • fast/forms/fieldset/fieldset-multicolumn-expected.html: Added.
  • fast/forms/fieldset/fieldset-multicolumn.html: Added.
  • fast/forms/fieldset/fieldset-overflow-auto-expected.html: Added.
  • fast/forms/fieldset/fieldset-overflow-auto.html: Added.
  • fast/forms/fieldset/fieldset-overflow-hidden-expected.html: Added.
  • fast/forms/fieldset/fieldset-overflow-hidden.html: Added.
  • fast/forms/fieldset/fieldset-positioned-children-expected.html: Added.
  • fast/forms/fieldset/fieldset-positioned-children.html: Added.
  • fast/forms/fieldset/fieldset-positioned-legend-expected.html: Added.
  • fast/forms/fieldset/fieldset-positioned-legend.html: Added.
  • fast/forms/fieldset/fieldset-self-painting-legend-expected.html: Added.
  • fast/forms/fieldset/fieldset-self-painting-legend.html: Added.
  • fast/forms/fieldset/fieldset-writing-modes-expected.html: Added.
  • fast/forms/fieldset/fieldset-writing-modes.html: Added.
9:49 AM Changeset in webkit [213454] by commit-queue@webkit.org
  • 12 edits
    1 copy
    1 add in trunk

[Modern Media Controls] Tracks panel should clip and scroll content when numerous tracks are available
​https://bugs.webkit.org/show_bug.cgi?id=169201
<rdar://problem/30867979>

Patch by Antoine Quint <Antoine Quint> on 2017-03-06
Reviewed by Eric Carlson.

Source/WebCore:

We now position and size the tracks panel dynamically and ensure a max-height is applied
to the panel so that it allows a margin of 10px above it within the media controls. We also
apply that same max-height to a new intermediary scrollable container for the track lists,
so that it scrolls independently of the container and the background tint.

Test: media/modern-media-controls/tracks-panel/tracks-panel-position-and-size.html

  • Modules/modern-media-controls/controls/macos-fullscreen-media-controls.js:

(MacOSFullscreenMediaControls.prototype.showTracksPanel): Deleted.

  • Modules/modern-media-controls/controls/macos-inline-media-controls.css:

(.media-controls.mac.inline .volume.slider):
(.media-controls.mac.inline .tracks-panel): Deleted.

  • Modules/modern-media-controls/controls/macos-inline-media-controls.js:

(MacOSInlineMediaControls.prototype.showTracksPanel): Deleted.

  • Modules/modern-media-controls/controls/macos-media-controls.js:

(MacOSMediaControls.prototype.showTracksPanel):

  • Modules/modern-media-controls/controls/tracks-panel.css:

(.tracks-panel > .background-tint > div,):
(.tracks-panel > .scrollable-container):
(.tracks-panel section):
(.tracks-panel section:first-of-type):
(.tracks-panel section > h3):
(.tracks-panel section > ul):
(.tracks-panel section > ul > li):
(.tracks-panel section > ul > li:focus):
(.tracks-panel section > ul > li.selected:before):
(.tracks-panel section > ul > li.animated):
(.tracks-panel > .background-tint > div): Deleted.
(.tracks-panel > section): Deleted.
(.tracks-panel > section:first-of-type): Deleted.
(.tracks-panel > section > h3): Deleted.
(.tracks-panel > section > ul): Deleted.
(.tracks-panel > section > ul > li): Deleted.
(.tracks-panel > section > ul > li:focus): Deleted.
(.tracks-panel > section > ul > li.selected:before): Deleted.
(.tracks-panel > section > ul > li.animated): Deleted.

  • Modules/modern-media-controls/controls/tracks-panel.js:

(TracksPanel.prototype.presentInParent):
(TracksPanel.prototype.get maxHeight):
(TracksPanel.prototype.set maxHeight):
(TracksPanel.prototype.commitProperty):
(TracksPanel.prototype._childrenFromDataSource):

LayoutTests:

Rebaseline a couple of existing tests to account for the DOM structure change in
the tracks panel and the fact that positioning is now dependent on the bounds of
the tracks button.

We also add a new test that checks that the tracks panel is positioned and sized
correctly to ensure that it can be scrolled when it has too many tracks to fit.

  • media/modern-media-controls/tracks-panel/tracks-panel-population-expected.txt:
  • media/modern-media-controls/tracks-panel/tracks-panel-population.html:
  • media/modern-media-controls/tracks-panel/tracks-panel-position-and-size-expected.txt: Added.
  • media/modern-media-controls/tracks-panel/tracks-panel-position-and-size.html: Added.
  • media/modern-media-controls/tracks-panel/tracks-panel-select-track-with-mouse-expected.txt:
  • media/modern-media-controls/tracks-panel/tracks-panel-select-track-with-mouse.html:
9:26 AM Changeset in webkit [213453] by Yusuke Suzuki
  • 5 edits in trunk

[JSC] Allow indexed module namespace object fields
​https://bugs.webkit.org/show_bug.cgi?id=168870

Reviewed by Saam Barati.

JSTests:

  • wasm/spec-tests/names.wast.js:

Source/JavaScriptCore:

While JS modules cannot expose any indexed bindings,
Wasm modules can expose them. However, module namespace
object currently does not support indexed properties.
This patch allows module namespace objects to offer
indexed binding accesses.

  • runtime/JSModuleNamespaceObject.cpp:

(JSC::JSModuleNamespaceObject::getOwnPropertySlotCommon):
(JSC::JSModuleNamespaceObject::getOwnPropertySlot):
(JSC::JSModuleNamespaceObject::getOwnPropertySlotByIndex):

  • runtime/JSModuleNamespaceObject.h:
8:57 AM Changeset in webkit [213452] by Yusuke Suzuki
  • 4 edits
    2 adds in trunk

Null pointer crash when loading module with unresolved import also as a script file
​https://bugs.webkit.org/show_bug.cgi?id=168971

Reviewed by Saam Barati.

JSTests:

  • stress/re-execute-error-module.js: Added.

(shouldBe):
(async):

  • stress/resources/error-module.js: Added.

Source/JavaScriptCore:

If linking throws an error, this error should be re-thrown
when requesting the same module.

  • builtins/ModuleLoaderPrototype.js:

(globalPrivate.newRegistryEntry):

  • runtime/JSModuleRecord.cpp:

(JSC::JSModuleRecord::link):

8:02 AM Changeset in webkit [213451] by Yusuke Suzuki
  • 2 edits in trunk

Unreviewed, fix AppleWin build
​https://bugs.webkit.org/show_bug.cgi?id=164032

  • Source/cmake/WebKitFeatures.cmake:
7:43 AM Changeset in webkit [213450] by Yusuke Suzuki
  • 12 edits in trunk

[GTK][JSCOnly] Enable WebAssembly on Linux environment
​https://bugs.webkit.org/show_bug.cgi?id=164032

Reviewed by Michael Catanzaro.

.:

  • Source/cmake/OptionsGTK.cmake:
  • Source/cmake/OptionsJSCOnly.cmake:
  • Source/cmake/OptionsMac.cmake:
  • Source/cmake/WebKitFeatures.cmake:

Source/JavaScriptCore:

This patch enables WebAssembly on JSCOnly and GTK ports.
Basically, almost all the WASM code is portable to Linux.
One platform-dependent part is faster memory load using SIGBUS
signal handler. This patch ports this part to Linux.

  • CMakeLists.txt:
  • llint/LLIntSlowPaths.cpp:

(JSC::LLInt::LLINT_SLOW_PATH_DECL):

  • wasm/WasmFaultSignalHandler.cpp:

(JSC::Wasm::trapHandler):
(JSC::Wasm::enableFastMemory):

Tools:

  • Scripts/run-jsc-stress-tests:

Enable WASM tests.

  • Scripts/webkitperl/FeatureList.pm:

Enable WebAssembly.

7:30 AM Changeset in webkit [213449] by Manuel Rego Casasnovas
  • 6 edits in trunk

[css-grid] Stretch should grow and shrink items to fit its grid area
​https://bugs.webkit.org/show_bug.cgi?id=163200

Reviewed by Darin Adler.

Source/WebCore:

After some discussions the CSS WG agreed that stretch should not only
grow items, but also shrink them to fit its grid area.
That way the "min-width|height: auto" is somehow ignored for grid items.
More info at: ​https://github.com/w3c/csswg-drafts/issues/283

The good part is that this allows us to remove some ugly code we've
in RenderBox that was only used by Grid Layout.

For images, we'll be stretching on both axis right now, so the aspect
ratio won't be preserved. The default behavior might change in those
cases, but that should be implemented in a different patch.

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::computeLogicalWidthInRegion):
(WebCore::RenderBox::computeLogicalHeight):

LayoutTests:

The tests have been updated according to the new expected behavior.

  • fast/css-grid-layout/grid-container-percentage-columns.html:
  • fast/css-grid-layout/min-width-height-auto-and-margins.html:
  • fast/css-grid-layout/min-width-height-auto.html:
6:19 AM Changeset in webkit [213448] by magomez@igalia.com
  • 2 edits in trunk/Source/WebCore

[GTK] WebProcess from WebKitGtk+ 2.15.x SIGSEVs in GIFLZWContext::doLZW(unsigned char const*, unsigned long) at Source/WebCore/platform/image-decoders/gif/GIFImageReader.cpp:303
​https://bugs.webkit.org/show_bug.cgi?id=167304

Reviewed by Carlos Garcia Campos.

Add a lock to ensure that the GIFImageReader that we are using for decoding is not deleted while
the decoding thread is using it.

No new tests.

  • platform/image-decoders/gif/GIFImageDecoder.cpp:

(WebCore::GIFImageDecoder::clearFrameBufferCache):

6:06 AM Changeset in webkit [213447] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

Currency digits calculation in Intl.NumberFormat should call out to ICU
​https://bugs.webkit.org/show_bug.cgi?id=169182

Patch by Daniel Ehrenberg <​littledan@igalia.com> on 2017-03-06
Reviewed by Yusuke Suzuki.

  • runtime/IntlNumberFormat.cpp:

(JSC::computeCurrencyDigits):
(JSC::computeCurrencySortKey): Deleted.
(JSC::extractCurrencySortKey): Deleted.

4:19 AM Changeset in webkit [213446] by Antti Koivisto
  • 16 edits in trunk

Allow render tree building before loading stylesheet elements
​https://bugs.webkit.org/show_bug.cgi?id=169079
Source/WebCore:

<rdar://problem/30865709>

Reviewed by Andreas Kling.

Currently we don't resolve style or construct renderers if there are any pending
stylesheet loads. This patch enables style and renderer constuction up to the
first encountered loading style element.

This is a step toward allowing incremental rendering for in-body stylesheets.

  • dom/Document.cpp:

(WebCore::Document::needsStyleRecalc):

Ensure scrolling to anchor eventually happens.

  • dom/Document.h:

(WebCore::Document::isIgnoringPendingStylesheets):

  • dom/InlineStyleSheetOwner.cpp:

(WebCore::InlineStyleSheetOwner::createSheet):
(WebCore::InlineStyleSheetOwner::sheetLoaded):
(WebCore::InlineStyleSheetOwner::startLoadingDynamicSheet):

  • dom/ProcessingInstruction.cpp:

(WebCore::ProcessingInstruction::checkStyleSheet):
(WebCore::ProcessingInstruction::sheetLoaded):
(WebCore::ProcessingInstruction::removedFrom):

  • html/HTMLLinkElement.cpp:

(WebCore::HTMLLinkElement::addPendingSheet):
(WebCore::HTMLLinkElement::removePendingSheet):

  • style/StyleScope.cpp:

(WebCore::Style::Scope::addPendingSheet):
(WebCore::Style::Scope::removePendingSheet):

Track pending sheet nodes in a map so we can test if a given node has a pending sheet.
This is also more robust in general.

(WebCore::Style::Scope::hasProcessingInstructionWithPendingSheet):
(WebCore::Style::Scope::updateActiveStyleSheets):

  • style/StyleScope.h:

(WebCore::Style::Scope::hasPendingSheet):
(WebCore::Style::Scope::hasPendingSheets):
(WebCore::Style::Scope::addPendingSheet): Deleted.

  • style/StyleTreeResolver.cpp:

(WebCore::Style::TreeResolver::styleForElement):

Instead of global test for placeholder construction check the status of the pending sheet flag.

(WebCore::Style::hasLoadingStylesheet):
(WebCore::Style::TreeResolver::resolveComposedTree):

Set a flag when encountering a pending top level sheet during DOM traversal.

(WebCore::Style::TreeResolver::resolve):

  • style/StyleTreeResolver.h:
  • svg/graphics/SVGImage.cpp:

(WebCore::SVGImage::dataChanged):

Ensure SVG images have layout before getting the size.

LayoutTests:

Reviewed by Andreas Kling.

Ensure that style is synchronized after adding a stylesheet dynamically by doing an additional test.
Otherwise the class/attr invalidation test may as we don't know about the new stylesheet yet.
This is functionally fine (future synchronization would invalidate the style) but messes up the test
trying to verify class/attr change invalidation specifically.

  • fast/css/style-invalidation-attribute-change-descendants-expected.txt:
  • fast/css/style-invalidation-attribute-change-descendants.html:
  • fast/css/style-invalidation-class-change-descendants-expected.txt:
  • fast/css/style-invalidation-class-change-descendants.html:
2:32 AM Changeset in webkit [213445] by commit-queue@webkit.org
  • 18 edits in trunk/Source/WebCore

[GStreamer] Adopt nullptr
​https://bugs.webkit.org/show_bug.cgi?id=123438

Patch by Vanessa Chipirrás Navalón <​vchipirras@igalia.com> on 2017-03-06
Reviewed by Xabier Rodriguez-Calvar.

To adapt the code to the C++11 standard, all NULL or 0 pointers have been changed to nullptr.

  • platform/audio/gstreamer/AudioDestinationGStreamer.cpp:

(WebCore::AudioDestinationGStreamer::AudioDestinationGStreamer):

  • platform/audio/gstreamer/AudioFileReaderGStreamer.cpp:

(WebCore::AudioFileReader::handleNewDeinterleavePad):
(WebCore::AudioFileReader::plugDeinterleave):
(WebCore::AudioFileReader::decodeAudioForBusCreation):

  • platform/audio/gstreamer/AudioSourceProviderGStreamer.cpp:

(WebCore::AudioSourceProviderGStreamer::AudioSourceProviderGStreamer):
(WebCore::AudioSourceProviderGStreamer::configureAudioBin):
(WebCore::AudioSourceProviderGStreamer::setClient):
(WebCore::AudioSourceProviderGStreamer::handleNewDeinterleavePad):

  • platform/audio/gstreamer/WebKitWebAudioSourceGStreamer.cpp:

(webkit_web_audio_src_init):
(webKitWebAudioSrcLoop):
(webKitWebAudioSrcChangeState):

  • platform/graphics/gstreamer/AudioTrackPrivateGStreamer.cpp:

(WebCore::AudioTrackPrivateGStreamer::setEnabled):

  • platform/graphics/gstreamer/GStreamerUtilities.cpp:

(WebCore::initializeGStreamer):

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:

(WebCore::MediaPlayerPrivateGStreamer::setAudioStreamProperties):
(WebCore::MediaPlayerPrivateGStreamer::registerMediaEngine):
(WebCore::initializeGStreamerAndRegisterWebKitElements):
(WebCore::MediaPlayerPrivateGStreamer::MediaPlayerPrivateGStreamer):
(WebCore::MediaPlayerPrivateGStreamer::~MediaPlayerPrivateGStreamer):
(WebCore::MediaPlayerPrivateGStreamer::newTextSample):
(WebCore::MediaPlayerPrivateGStreamer::handleMessage):
(WebCore::MediaPlayerPrivateGStreamer::processTableOfContents):
Removed the unused second argument on processTableOfContentsEntry function.
(WebCore::MediaPlayerPrivateGStreamer::processTableOfContentsEntry):
Removed the unused second argument on this function.
(WebCore::MediaPlayerPrivateGStreamer::fillTimerFired):
(WebCore::MediaPlayerPrivateGStreamer::loadNextLocation):
(WebCore::MediaPlayerPrivateGStreamer::createAudioSink):
(WebCore::MediaPlayerPrivateGStreamer::createGSTPlayBin):

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:

Removed the unused second argument on processTableOfContentsEntry function.

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:

(WebCore::MediaPlayerPrivateGStreamerBase::MediaPlayerPrivateGStreamerBase):
(WebCore::MediaPlayerPrivateGStreamerBase::setMuted):
(WebCore::MediaPlayerPrivateGStreamerBase::muted):
(WebCore::MediaPlayerPrivateGStreamerBase::notifyPlayerOfMute):
(WebCore::MediaPlayerPrivateGStreamerBase::setStreamVolumeElement):
(WebCore::MediaPlayerPrivateGStreamerBase::decodedFrameCount):
(WebCore::MediaPlayerPrivateGStreamerBase::droppedFrameCount):

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamerOwr.cpp:

(WebCore::MediaPlayerPrivateGStreamerOwr::registerMediaEngine):

  • platform/graphics/gstreamer/TextCombinerGStreamer.cpp:

(webkit_text_combiner_init):
(webkitTextCombinerPadEvent):
(webkitTextCombinerRequestNewPad):
(webkitTextCombinerNew):

  • platform/graphics/gstreamer/TextSinkGStreamer.cpp:

(webkitTextSinkNew):

  • platform/graphics/gstreamer/TrackPrivateBaseGStreamer.cpp:

(WebCore::TrackPrivateBaseGStreamer::tagsChanged):
(WebCore::TrackPrivateBaseGStreamer::notifyTrackOfActiveChanged):

  • platform/graphics/gstreamer/VideoSinkGStreamer.cpp:

(webkit_video_sink_init):
(webkitVideoSinkProposeAllocation):
(webkitVideoSinkNew):

  • platform/graphics/gstreamer/VideoTrackPrivateGStreamer.cpp:

(WebCore::VideoTrackPrivateGStreamer::setSelected):

  • platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:

(webkit_web_src_init):
(webKitWebSrcDispose):
(webKitWebSrcSetProperty):
(webKitWebSrcStop):
(webKitWebSrcChangeState):
(webKitWebSrcQueryWithParent):
(webKitWebSrcGetProtocols):
(StreamingClient::handleResponseReceived):
(StreamingClient::handleDataReceived):
(ResourceHandleStreamingClient::didFail):
(ResourceHandleStreamingClient::wasBlocked):
(ResourceHandleStreamingClient::cannotShowURL):

  • platform/graphics/gstreamer/mse/WebKitMediaSourceGStreamer.cpp:

(webKitMediaSrcGetProtocols):

2:02 AM Changeset in webkit [213444] by akling@apple.com
  • 10 edits in trunk/Source

[iOS] Report domains crashing under memory pressure via enhanced privacy logging.
<​https://webkit.org/b/169133>
<rdar://problem/29964017>

Reviewed by Antti Koivisto.

Source/WebCore:

  • page/DiagnosticLoggingKeys.h:

Source/WebKit2:

Notify the UI process when the memory pressure status changes.
If a web process crashes while under memory pressure, log the domain of the last open page
using enhanced privacy logging.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::processDidCrash):

  • UIProcess/WebProcessProxy.h:

(WebKit::WebProcessProxy::memoryPressureStatusChanged):
(WebKit::WebProcessProxy::isUnderMemoryPressure):

  • UIProcess/WebProcessProxy.messages.in:
  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::initializeWebProcess):

Source/WTF:

Add a mechanism for getting a callback when the memory pressure status changes.

  • wtf/MemoryPressureHandler.cpp:

(WTF::MemoryPressureHandler::measurementTimerFired):
(WTF::MemoryPressureHandler::beginSimulatedMemoryPressure):
(WTF::MemoryPressureHandler::endSimulatedMemoryPressure):
(WTF::MemoryPressureHandler::setUnderMemoryPressure):
(WTF::MemoryPressureHandler::memoryPressureStatusChanged):

  • wtf/MemoryPressureHandler.h:

(WTF::MemoryPressureHandler::setMemoryPressureStatusChangedCallback):
(WTF::MemoryPressureHandler::setUnderMemoryPressure): Deleted.

Mar 5, 2017:

11:38 PM Changeset in webkit [213443] by Carlos Garcia Campos
  • 2 edits in trunk/LayoutTests

Unreviewed GTK+ gardening. Rebaseline fast/css/css2-system-fonts.html after r213267.

  • platform/gtk/fast/css/css2-system-fonts-expected.txt:
9:51 PM Changeset in webkit [213442] by beidson@apple.com
  • 1 edit
    3 deletes in trunk/Source/WebKit2

Remove new files accidentally added in r213441

Unreviewed.

  • UIProcess/WebLoadingProviderProxy.cpp: Removed.
  • UIProcess/WebLoadingProviderProxy.h: Removed.
  • UIProcess/WebLoadingProviderProxy.messages.in: Removed.
6:53 PM Changeset in webkit [213441] by beidson@apple.com
  • 23 edits
    3 copies
    9 moves
    1 add
    1 delete in trunk/Source/WebKit2

Rename CustomProtocolFoo to LegacyCustomProtocolFoo.
​https://bugs.webkit.org/show_bug.cgi?id=169188

Reviewed by Andy Estes.

  • CMakeLists.txt:
  • DerivedSources.make:
  • NetworkProcess/CustomProtocols/Cocoa/LegacyCustomProtocolManagerCocoa.mm: Renamed from Source/WebKit2/NetworkProcess/CustomProtocols/Cocoa/CustomProtocolManagerCocoa.mm.

(+[WKCustomProtocol canInitWithRequest:]):
(+[WKCustomProtocol canonicalRequestForRequest:]):
(+[WKCustomProtocol requestIsCacheEquivalent:toRequest:]):
(-[WKCustomProtocol initWithRequest:cachedResponse:client:]):
(-[WKCustomProtocol initializationRunLoop]):
(-[WKCustomProtocol startLoading]):
(-[WKCustomProtocol stopLoading]):
(WebKit::LegacyCustomProtocolManager::registerProtocolClass):
(WebKit::LegacyCustomProtocolManager::registerScheme):
(WebKit::LegacyCustomProtocolManager::unregisterScheme):
(WebKit::LegacyCustomProtocolManager::supportsScheme):
(WebKit::dispatchOnInitializationRunLoop):
(WebKit::LegacyCustomProtocolManager::didFailWithError):
(WebKit::LegacyCustomProtocolManager::didLoadData):
(WebKit::LegacyCustomProtocolManager::didReceiveResponse):
(WebKit::LegacyCustomProtocolManager::didFinishLoading):
(WebKit::LegacyCustomProtocolManager::wasRedirectedToRequest):
(WebKit::LegacyCustomProtocolManager::protocolForID):

  • NetworkProcess/CustomProtocols/LegacyCustomProtocolManager.cpp: Renamed from Source/WebKit2/NetworkProcess/CustomProtocols/CustomProtocolManager.cpp.

(WebKit::generateCustomProtocolID):
(WebKit::LegacyCustomProtocolManager::supplementName):
(WebKit::LegacyCustomProtocolManager::LegacyCustomProtocolManager):
(WebKit::LegacyCustomProtocolManager::initialize):
(WebKit::LegacyCustomProtocolManager::addCustomProtocol):
(WebKit::LegacyCustomProtocolManager::removeCustomProtocol):
(WebKit::LegacyCustomProtocolManager::startLoading):
(WebKit::LegacyCustomProtocolManager::stopLoading):

  • NetworkProcess/CustomProtocols/LegacyCustomProtocolManager.h: Renamed from Source/WebKit2/NetworkProcess/CustomProtocols/CustomProtocolManager.h.
  • NetworkProcess/CustomProtocols/LegacyCustomProtocolManager.messages.in: Renamed from Source/WebKit2/NetworkProcess/CustomProtocols/CustomProtocolManager.messages.in.
  • NetworkProcess/CustomProtocols/soup/LegacyCustomProtocolManagerSoup.cpp: Renamed from Source/WebKit2/NetworkProcess/CustomProtocols/soup/CustomProtocolManagerSoup.cpp.

(WebKit::CustomProtocolManager::WebSoupRequestAsyncData::WebSoupRequestAsyncData):
(WebKit::CustomProtocolManager::WebSoupRequestAsyncData::~WebSoupRequestAsyncData):
(WebKit::CustomProtocolManager::registerProtocolClass):
(WebKit::CustomProtocolManager::registerScheme):
(WebKit::CustomProtocolManager::unregisterScheme):
(WebKit::CustomProtocolManager::supportsScheme):
(WebKit::CustomProtocolManager::didFailWithError):
(WebKit::CustomProtocolManager::didLoadData):
(WebKit::CustomProtocolManager::didReceiveResponse):
(WebKit::CustomProtocolManager::didFinishLoading):
(WebKit::CustomProtocolManager::wasRedirectedToRequest):

  • NetworkProcess/NetworkProcess.cpp:

(WebKit::NetworkProcess::NetworkProcess):

  • NetworkProcess/NetworkSession.cpp:

(WebKit::NetworkSession::create):

  • NetworkProcess/NetworkSession.h:
  • NetworkProcess/cocoa/NetworkSessionCocoa.h:
  • NetworkProcess/cocoa/NetworkSessionCocoa.mm:

(WebKit::globalLegacyCustomProtocolManager):
(WebKit::NetworkSessionCocoa::setLegacyCustomProtocolManager):
(WebKit::NetworkSessionCocoa::create):
(WebKit::NetworkSessionCocoa::defaultSession):
(WebKit::NetworkSessionCocoa::NetworkSessionCocoa):
(WebKit::globalCustomProtocolManager): Deleted.
(WebKit::NetworkSessionCocoa::setCustomProtocolManager): Deleted.

  • NetworkProcess/mac/RemoteNetworkingContext.mm:

(WebKit::RemoteNetworkingContext::ensurePrivateBrowsingSession):

  • UIProcess/API/APICustomProtocolManagerClient.h:

(API::LegacyCustomProtocolManagerClient::~LegacyCustomProtocolManagerClient):
(API::LegacyCustomProtocolManagerClient::startLoading):
(API::LegacyCustomProtocolManagerClient::stopLoading):
(API::LegacyCustomProtocolManagerClient::invalidate):
(API::CustomProtocolManagerClient::~CustomProtocolManagerClient): Deleted.
(API::CustomProtocolManagerClient::startLoading): Deleted.
(API::CustomProtocolManagerClient::stopLoading): Deleted.
(API::CustomProtocolManagerClient::invalidate): Deleted.

  • UIProcess/Cocoa/LegacyCustomProtocolManagerClient.h: Renamed from Source/WebKit2/UIProcess/Cocoa/CustomProtocolManagerClient.h.
  • UIProcess/Cocoa/LegacyCustomProtocolManagerClient.mm: Renamed from Source/WebKit2/UIProcess/Cocoa/CustomProtocolManagerClient.mm.

(-[WKCustomProtocolLoader initWithLegacyCustomProtocolManagerProxy:customProtocolID:request:]):
(-[WKCustomProtocolLoader dealloc]):
(-[WKCustomProtocolLoader customProtocolManagerProxyDestroyed]):
(-[WKCustomProtocolLoader connection:didFailWithError:]):
(-[WKCustomProtocolLoader connection:willCacheResponse:]):
(-[WKCustomProtocolLoader connection:didReceiveResponse:]):
(-[WKCustomProtocolLoader connection:didReceiveData:]):
(-[WKCustomProtocolLoader connection:willSendRequest:redirectResponse:]):
(-[WKCustomProtocolLoader connectionDidFinishLoading:]):
(WebKit::LegacyCustomProtocolManagerClient::startLoading):
(WebKit::LegacyCustomProtocolManagerClient::stopLoading):
(WebKit::LegacyCustomProtocolManagerClient::invalidate):

  • UIProcess/Cocoa/WebProcessPoolCocoa.mm:

(WebKit::WebProcessPool::platformInitialize):

  • UIProcess/Network/CustomProtocols/CustomProtocolManagerProxy.cpp: Removed.
  • UIProcess/Network/CustomProtocols/LegacyCustomProtocolManagerProxy.cpp: Added.

(WebKit::LegacyCustomProtocolManagerProxy::LegacyCustomProtocolManagerProxy):
(WebKit::LegacyCustomProtocolManagerProxy::~LegacyCustomProtocolManagerProxy):
(WebKit::LegacyCustomProtocolManagerProxy::startLoading):
(WebKit::LegacyCustomProtocolManagerProxy::stopLoading):
(WebKit::LegacyCustomProtocolManagerProxy::processDidClose):
(WebKit::LegacyCustomProtocolManagerProxy::wasRedirectedToRequest):
(WebKit::LegacyCustomProtocolManagerProxy::didReceiveResponse):
(WebKit::LegacyCustomProtocolManagerProxy::didLoadData):
(WebKit::LegacyCustomProtocolManagerProxy::didFailWithError):
(WebKit::LegacyCustomProtocolManagerProxy::didFinishLoading):

  • UIProcess/Network/CustomProtocols/LegacyCustomProtocolManagerProxy.h: Renamed from Source/WebKit2/UIProcess/Network/CustomProtocols/CustomProtocolManagerProxy.h.
  • UIProcess/Network/CustomProtocols/LegacyCustomProtocolManagerProxy.messages.in: Renamed from Source/WebKit2/UIProcess/Network/CustomProtocols/CustomProtocolManagerProxy.messages.in.
  • UIProcess/Network/NetworkProcessProxy.cpp:
  • UIProcess/Network/NetworkProcessProxy.h:
  • UIProcess/WebProcessPool.cpp:

(WebKit::WebProcessPool::WebProcessPool):
(WebKit::WebProcessPool::setLegacyCustomProtocolManagerClient):
(WebKit::WebProcessPool::registerSchemeForCustomProtocol):
(WebKit::WebProcessPool::unregisterSchemeForCustomProtocol):
(WebKit::WebProcessPool::setCustomProtocolManagerClient): Deleted.

  • UIProcess/WebProcessPool.h:
  • WebKit2.xcodeproj/project.pbxproj:
  • WebProcess/cocoa/WebProcessCocoa.mm:
6:48 PM Changeset in webkit [213440] by Simon Fraser
  • 9 edits in trunk

Avoid backing store for layers with empty text nodes in a few more cases
​https://bugs.webkit.org/show_bug.cgi?id=169185

Reviewed by Dan Bernstein.

Source/WebCore:

In hasPaintingNonLayerDescendants() we can check whether the RenderText's linesBoundingBox()
is empty to avoid backing store in a few more cases. Also use containsOnlyWhitespace() rather
than isAllCollapsibleWhitespace(), because there's no need for backing store for non-selectable
whitespace text.

Covered by existing tests.

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::calculateClipRects):

LayoutTests:

inline-block-no-backing.html enhanced to have a layer with non-collapsible whitespace (an &nbsp;).

Rebaselined other tests.

  • compositing/backing/inline-block-no-backing-expected.txt:
  • compositing/backing/inline-block-no-backing.html:
  • compositing/iframes/page-cache-layer-tree-expected.txt:
  • css3/blending/blend-mode-clip-accelerated-blending-canvas-expected.txt:
  • platform/ios-simulator-wk2/compositing/backing/inline-block-no-backing-expected.txt:
  • platform/ios-simulator-wk2/compositing/iframes/page-cache-layer-tree-expected.txt:
5:37 PM Changeset in webkit [213439] by Chris Dumez
  • 2 edits in trunk/Source/WebCore

Drop unnecessary backslash in ResourceResponse::sanitizeSuggestedFilename()
​https://bugs.webkit.org/show_bug.cgi?id=169066

Reviewed by Sam Weinig.

Drop unnecessary backslash in ResourceResponse::sanitizeSuggestedFilename().

  • platform/network/ResourceResponseBase.cpp:

(WebCore::ResourceResponseBase::sanitizeSuggestedFilename):

5:36 PM Changeset in webkit [213438] by Chris Dumez
  • 3 edits
    2 adds in trunk

Using <form> in <template> causes following <form> to get swallowed
​https://bugs.webkit.org/show_bug.cgi?id=163552

Reviewed by Sam Weinig.

Source/WebCore:

As per the HTML specification [1], when finding a "form" tag in the "in body"
insertion mode, we should insert an HTML element for the token, and, if there
is no template element on the stack of open elements, set the form element
pointer to point to the element created.

We were missing the "if there is no template element on the stack of open
elements" check and setting the form element pointer unconditionally.
This patch fixes the issue.

[1] ​https://html.spec.whatwg.org/multipage/syntax.html#parsing-main-inbody:form-element-pointer-2

Test: fast/parser/form-after-template.html

  • html/parser/HTMLConstructionSite.cpp:

(WebCore::HTMLConstructionSite::insertHTMLFormElement):

LayoutTests:

Add layout test coverage.

  • fast/parser/form-after-template-expected.html: Added.
  • fast/parser/form-after-template.html: Added.
12:31 PM Changeset in webkit [213437] by aestes@apple.com
  • 3 edits in trunk/Source/WebCore

Add support for canvas.toBlob
​https://bugs.webkit.org/show_bug.cgi?id=148878

Reviewed by Tim Horton.

Address additional review feedback received after r213412 landed.

  • html/HTMLCanvasElement.cpp:

(WebCore::HTMLCanvasElement::toBlob): Passed null to the blob callback if blob conversion
fails for any reason.

  • platform/graphics/cg/ImageBufferCG.cpp:

(WebCore::cgImage): Removed an unnecessary local variable.

12:14 PM Changeset in webkit [213436] by mmaxfield@apple.com
  • 19 edits
    2 adds in trunk

Update CSSFontSelector's matching algorithm to understand ranges
​https://bugs.webkit.org/show_bug.cgi?id=168892

Reviewed by Jon Lee.

Source/WebCore:

This patch migrates the font selection algorithm out of FontCacheCoreText and into its own file which can be shared
among all ports. It then migrates our web font selection algorithm to use it.

This patch doesn't actually change the parsing rules; it just changes the internal machinery for how fonts get
selected. Therefore, this patch simply makes zero-length ranges from the discrete values the parser emits, and passes
those zero-length ranges to the range-based font selection routine. This means that this patch doesn't actually
change the results of the font selection algorithm.

One of the inputs to the new font selection algorithm is font-stretch, which previously was not parsed inside
@font-face blocks or the CSS Font Loading API. This patch therefore adds parsing support and modifies the existing
tests for these pieces to expect parsing to work. Because the font selection algorithm itself is shared between
installed fonts and webfonts, this patch doesn't add any additional tests for it (because it is already covered under
existing tests).

No new tests because there is no behavior change.

  • CMakeLists.txt:
  • WebCore.xcodeproj/project.pbxproj: Add new file for the font selection algorithm.
  • css/CSSFontFace.cpp:

(WebCore::CSSFontFace::calculateStretch): Used on @font-face blocks and the CSS Font Loading API.
(WebCore::CSSFontFace::setStretch): Fill out the previously stubbed function.

  • css/CSSFontFace.h: Add the range member variable to CSSFontFaces.
  • css/CSSFontFaceSet.cpp:

(WebCore::CSSFontFaceSet::ensureLocalFontFacesForFamilyRegistered): Now that we care about font-stretch, we need to
look it up for local fonts too. This current approach of an extra FontSelectionValue hanging around with a
FontTraitsMask is very ugly and will be removed soon (​https://bugs.webkit.org/show_bug.cgi?id=168889 and
​https://bugs.webkit.org/show_bug.cgi?id=168890).
(WebCore::computeFontStretch): Used on @font-face blocks and the CSS Font Loading API.
(WebCore::CSSFontFaceSet::matchingFaces): Educate about font-stretch.
(WebCore::CSSFontFaceSet::fontFace): Migrate to the new font-selection algorithm.
(WebCore::fontFaceComparator): Deleted.

  • css/CSSFontFaceSet.h:
  • css/CSSFontSelector.cpp:

(WebCore::CSSFontSelector::addFontFaceRule): Educate about font-stretch.
(WebCore::CSSFontSelector::fontRangesForFamily): Ditto.

  • css/FontFace.cpp:

(WebCore::FontFace::setStretch): Ditto.
(WebCore::FontFace::stretch): Ditto.

  • css/parser/CSSPropertyParser.cpp:

(WebCore::CSSPropertyParser::parseFontFaceDescriptor): Ditto.

  • platform/graphics/FontCache.h: Ditto.
  • platform/graphics/FontDescription.h:
  • platform/graphics/FontSelectionAlgorithm.cpp: Added.

(WebCore::FontSelectionAlgorithm::filterCapability):
(WebCore::FontSelectionAlgorithm::indexOfBestCapabilities):
(WebCore::fontSelectionRequestForTraitsMask):
(WebCore::initialFontSelectionCapabilitiesForTraitsMask):
(WebCore::fontSelectionCapabilitiesForTraitsMask):

  • platform/graphics/FontSelectionAlgorithm.h: Added. Taken from FontCacheCoreText.cpp.

(WebCore::FontSelectionValue::FontSelectionValue):
(WebCore::FontSelectionValue::operator float):
(WebCore::FontSelectionValue::rawValue):
(WebCore::FontSelectionValue::maximumValue):
(WebCore::FontSelectionValue::minimumValue):
(WebCore::FontSelectionValue::operator+):
(WebCore::FontSelectionValue::operator-):
(WebCore::FontSelectionValue::operator*):
(WebCore::FontSelectionValue::operator/):
(WebCore::FontSelectionValue::operator==):
(WebCore::FontSelectionValue::operator!=):
(WebCore::FontSelectionValue::operator<):
(WebCore::FontSelectionValue::operator<=):
(WebCore::FontSelectionValue::operator>):
(WebCore::FontSelectionValue::operator>=):
(WebCore::FontSelectionRange::isValid):
(WebCore::FontSelectionRange::expand):
(WebCore::FontSelectionRange::includes):
(WebCore::FontSelectionRequest::operator==):
(WebCore::FontSelectionRequest::operator!=):
(WebCore::FontSelectionRequestKey::FontSelectionRequestKey):
(WebCore::FontSelectionRequestKey::isHashTableDeletedValue):
(WebCore::FontSelectionRequestKey::operator==):
(WebCore::FontSelectionRequestKeyHash::hash):
(WebCore::FontSelectionRequestKeyHash::equal):
(WebCore::FontSelectionCapabilities::expand):
(WebCore::FontSelectionAlgorithm::FontSelectionAlgorithm):
(WebCore::FontSelectionAlgorithm::iterateActiveCapabilitiesWithReturn):
(WebCore::FontSelectionAlgorithm::iterateActiveCapabilities):

  • platform/graphics/cocoa/FontCacheCoreText.cpp: Moved to FontSelectionAlgorithm.

(WebCore::stretchFromCoreTextTraits):
(WebCore::FontDatabase::capabilitiesForFontDescriptor):
(WebCore::findClosestFont):
(WebCore::calculateFontSelectionRequest):
(WebCore::platformFontLookupWithFamily):
(WebCore::FontCache::getTraitsInFamily): Deleted.
(WebCore::iterateActiveFontsWithReturn): Deleted.
(WebCore::iterateActiveFonts): Deleted.
(WebCore::findClosestStretch): Deleted.
(WebCore::filterStretch): Deleted.
(WebCore::findClosestStyle): Deleted.
(WebCore::filterStyle): Deleted.
(WebCore::findClosestWeight): Deleted.
(WebCore::filterWeight): Deleted.
(WebCore::computeTargetWeight): Deleted.

  • platform/text/TextFlags.h: Moved to FontSelectionAlgorithm.

(WebCore::FontSelectionValue::FontSelectionValue): Deleted.
(WebCore::FontSelectionValue::operator float): Deleted.
(WebCore::FontSelectionValue::operator+): Deleted.
(WebCore::FontSelectionValue::operator-): Deleted.
(WebCore::FontSelectionValue::operator*): Deleted.
(WebCore::FontSelectionValue::operator/): Deleted.
(WebCore::FontSelectionValue::operator==): Deleted.
(WebCore::FontSelectionValue::operator!=): Deleted.
(WebCore::FontSelectionValue::operator<): Deleted.
(WebCore::FontSelectionValue::operator<=): Deleted.
(WebCore::FontSelectionValue::operator>): Deleted.
(WebCore::FontSelectionValue::operator>=): Deleted.
(WebCore::FontSelectionValue::rawValue): Deleted.
(WebCore::FontSelectionValue::maximumValue): Deleted.
(WebCore::FontSelectionValue::minimumValue): Deleted.
(WebCore::FontSelectionRange::isValid): Deleted.
(WebCore::FontSelectionRange::expand): Deleted.
(WebCore::FontSelectionRange::includes): Deleted.
(WebCore::FontSelectionCapabilities::expand): Deleted.

LayoutTests:

Update CSS Font Loading API test to accept font-stretch values.

  • fast/text/font-face-javascript-expected.txt:
  • fast/text/font-face-javascript.html:
11:14 AM Changeset in webkit [213435] by Simon Fraser
  • 3 edits in trunk/Source/WebCore

Make some RenderLayer tree traversal in RenderLayerBacking more generic
​https://bugs.webkit.org/show_bug.cgi?id=169177

Reviewed by Zalan Bujtas.

The real goal of this patch is reduce the number of callers of
RenderLayerBacking::isPaintDestinationForDescendantLayers() to one. To achieve that,
have the setContentsVisible() logic (which is really just about the CSS 'visibility' property)
do its own tree traversal which just consults layer.hasVisibleContent(). So
make descendantLayerPaintsIntoAncestor() a generic traversal function which walks
descendant layers which may paint into the target layer. The "Visible" in the name
reflects the fact that it can bypass a subtree for a layer with !hasVisibleDescendant().

  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::updateAfterDescendants):
(WebCore::traverseVisibleNonCompositedDescendantLayers):
(WebCore::RenderLayerBacking::isPaintDestinationForDescendantLayers):
(WebCore::RenderLayerBacking::hasVisibleNonCompositedDescendants):
(WebCore::descendantLayerPaintsIntoAncestor): Deleted.

  • rendering/RenderLayerBacking.h:
3:10 AM Changeset in webkit [213434] by commit-queue@webkit.org
  • 3 edits in trunk/LayoutTests

[GTK] Two file reset tests are failing in the bots since they were added in r213042
​https://bugs.webkit.org/show_bug.cgi?id=169126

Patch by Carlos Garcia Campos <​cgarcia@igalia.com> on 2017-03-05
Reviewed by Michael Catanzaro.

They are failing because the GTK+ event sender is not firing the second UIHelper.activateAt() after the change
event. In one case this causes that the reset button is not clicked, and in the other one the file input is not
unfocused. This is because the change event is emitted before the mouse up, and the GTK+ event sender ignores
mouse down events when the button is already down to not confuse Xvfb. So, we can easily fix theses tests by
using a timeout to ensure the next UIHelper.activateAt() happens in a different run loop iteration, after the
mouse up.

  • fast/forms/file/file-input-reset-using-open-panel.html:
  • fast/forms/file/file-reset-in-change-using-open-panel.html:
12:37 AM Changeset in webkit [213433] by Yusuke Suzuki
  • 3 edits in trunk/Source/JavaScriptCore

[JSCOnly][GTK] Suppress warnings on return type in B3 and WASM
​https://bugs.webkit.org/show_bug.cgi?id=168869

Reviewed by Keith Miller.

  • b3/B3Width.h:
  • wasm/WasmSections.h:
Note: See TracTimeline for information about the timeline view.