Timeline

Mar 7, 2017:

11:52 PM Changeset in webkit [213569] by ap@apple.com

• 2 edits in trunk/Source/WebKit2

WebKit should not export dyld install name hints on watchOS and tvOS
​https://bugs.webkit.org/show_bug.cgi?id=169342

Reviewed by Dan Bernstein.

• Shared/API/Cocoa/WebKit.m:

11:32 PM Changeset in webkit [213568] by ap@apple.com

• 2 edits in trunk/Source/WebKit/mac

WebKitLegacy should re-export symbols from WebCore on watchos and tvos
​https://bugs.webkit.org/show_bug.cgi?id=169341
<rdar://problem/30913788>

Reviewed by Dan Bernstein.

• MigrateHeaders.make:

10:06 PM Changeset in webkit [213567] by Simon Fraser

• 5 edits in trunk/Source/WebCore

Remove never-implemented CSS3 text decoration-related properties
​https://bugs.webkit.org/show_bug.cgi?id=169009

Reviewed by Zalan Bujtas.

The following CSS properties were added many years ago based on an old CSS3 Text
draft (​https://www.w3.org/TR/2003/CR-css3-text-20030514/), but never had any implementations.
Remove them.

text-line-through
text-line-through-color
text-line-through-mode
text-line-through-style
text-line-through-width
text-overline
text-overline-color
text-overline-mode
text-overline-style
text-overline-width
text-underline
text-underline-color
text-underline-mode
text-underline-style
text-underline-width

• WebCore.xcodeproj/project.pbxproj:
• css/CSSComputedStyleDeclaration.cpp:

(WebCore::ComputedStyleExtractor::propertyValue):

• css/CSSProperties.json:
• css/parser/CSSParserFastPaths.cpp:

(WebCore::CSSParserFastPaths::isKeywordPropertyID):

9:46 PM Changeset in webkit [213566] by Simon Fraser

• 30 edits in trunk

Have fixedPositionCreatesStackingContext be on by default everywhere
​https://bugs.webkit.org/show_bug.cgi?id=169334

Reviewed by Zalan Bujtas.

It makes no sense to have web-exposed CSS functionality be different based on setting,
and other browser are now aligned with having position:fixed create stacking context.

So remove the fixedPositionCreatesStackingContext setting and have StyleResolver::adjustRenderStyle()
always force stacking context for position:fixed.

Source/WebCore:

• css/StyleResolver.cpp:

(WebCore::StyleResolver::adjustRenderStyle):

• page/Settings.cpp:
• page/Settings.in:

Source/WebKit/mac:

• WebView/WebView.mm:

(-[WebView _preferencesChanged:]):

Source/WebKit2:

• WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::setUseFixedLayout):

• WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.mm:

(WebKit::RemoteLayerTreeDrawingArea::updatePreferences):

• WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:

(WebKit::TiledCoreAnimationDrawingArea::updatePreferences):

LayoutTests:

• compositing/absolute-inside-out-of-view-fixed.html:
• compositing/geometry/fixed-position-composited-page-scale-smaller-than-viewport.html:
• compositing/layer-creation/fixed-overlap-extent-rtl.html:
• compositing/layer-creation/fixed-overlap-extent.html:
• compositing/layer-creation/fixed-position-change-out-of-view-in-view.html:
• compositing/layer-creation/fixed-position-in-view-dynamic.html:
• compositing/layer-creation/fixed-position-out-of-view-dynamic.html:
• compositing/layer-creation/fixed-position-out-of-view-scaled-iframe-scroll.html:
• compositing/layer-creation/fixed-position-out-of-view-scaled-iframe.html:
• compositing/layer-creation/fixed-position-out-of-view-scaled-scroll.html:
• compositing/layer-creation/fixed-position-out-of-view-scaled.html:
• compositing/layer-creation/fixed-position-transformed-into-view.html:
• compositing/layer-creation/fixed-position-transformed-outside-view.html:
• compositing/layer-creation/no-compositing-for-fixed-position-under-transform.html:
• compositing/repaint/scroll-fixed-layer-no-content.html:
• compositing/repaint/scroll-fixed-layer-out-of-view.html:
• fast/block/positioning/fixed-position-stacking-context2.html:
• fullscreen/full-screen-fixed-pos-parent.html:

9:18 PM Changeset in webkit [213565] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebInspectorUI

Web Inspector: DOM Tree broken if an element has a "debounce" attribute
​https://bugs.webkit.org/show_bug.cgi?id=169336
<rdar://problem/30899430>

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2017-03-07
Reviewed by Brian Burg.

• UserInterface/Models/DOMNode.js:

(WebInspector.DOMNode):
(WebInspector.DOMNode.prototype.getAttribute):
(WebInspector.DOMNode.prototype.removeAttribute.mycallback):
(WebInspector.DOMNode.prototype.removeAttribute):
Convert the attributes map to an actual Map to avoid name collisions
with Object.prototype properties.

8:49 PM Changeset in webkit [213564] by Brent Fulgham

• 5 edits in trunk/Source/WebKit2

[Mac][WK2] Whitelist iokit-get-properties
​https://bugs.webkit.org/show_bug.cgi?id=169331
<rdar://problem/16363632>

Reviewed by Alex Christensen.

Block access to all IOKit properties by default. Turn on only those properties
that are actually needed by our engine.

• DatabaseProcess/mac/com.apple.WebKit.Databases.sb.in:
• NetworkProcess/mac/com.apple.WebKit.NetworkProcess.sb.in:
• PluginProcess/mac/com.apple.WebKit.plugin-common.sb.in:
• WebProcess/com.apple.WebProcess.sb.in:

7:54 PM Changeset in webkit [213563] by commit-queue@webkit.org

• 17 edits in trunk/Source/WebCore

Asynchronous image decoding should consider the drawing size if it is smaller than the size of the image
​https://bugs.webkit.org/show_bug.cgi?id=168814

Patch by Said Abou-Hallawa <​sabouhallawa@apple.com> on 2017-03-07
Reviewed by Simon Fraser.

If the image destinationRect.size() is smaller than the imageSourceSize
(e.g. 3000x3000 pixels), CGImageSourceCreateThumbnailAtIndex() is slower
than CGImageSourceCreateImageAtIndex() in decoding this image. To overcome
this problem, the entry (kCGImageSourceThumbnailMaxPixelSize,
max(destinationRect.width, destinationRect.height)) is added to the options
dictionary when calling CGImageSourceCreateThumbnailAtIndex(). This will
avoid copying a large block of memory for the unscaled bitmap image.

An argument named 'sizeForDrawing' of type std::optional<IntSize> will be passed
all the way from BitmapImage to ImageDecoder. If bool(sizeForDrawing) equals
true that means we want async image decoding. Otherwise the image will be decoded
synchronously.

The subsamplingLevel argument will be passed as std::optional<SubsamplingLevel>.
to ImageFrame query functions. When combined with sizeForDrawing, the meaning of
these two arguments will be the following:
-- !bool(subsamplingLevel): No caching is required. return what is stored in ImageFrameCache.
-- bool(subsamplingLevel) && !bool(sizeForDrawing): Match subsamplingLevel only. Recache if it's different.
-- bool(subsamplingLevel) && bool(sizeForDrawing): Match both both. . Recache if one of them is different.

We are going to allow decoding the same ImageFrame for different sizeForDrawings.
The rule is a new decoding is allowed only if the maxPixelSize(sizeForDrawing) of
the last requested image decoding is less than the new request sizeForDrawing.

• loader/cache/CachedImage.h: Add a helper function which returns the URL of a CachedImage.

• platform/graphics/BitmapImage.cpp:

(WebCore::BitmapImage::frameImageAtIndex): Add a new argument for sizeForDrawing.
(WebCore::BitmapImage::nativeImage): Pass an empty sizeForDrawing to frameImageAtIndex(). We an image with the native size.
(WebCore::BitmapImage::nativeImageForCurrentFrame): Ditto.
(WebCore::BitmapImage::nativeImageOfSize): Ditto.
(WebCore::BitmapImage::draw): Pass the destRect.size() to internalStartAnimation().
(WebCore::BitmapImage::isAsyncDecodingRequired): A helper function to answer the question
whether the async image decoding is required. It takes into account the animated images, the
large image, and the image size.
(WebCore::BitmapImage::internalStartAnimation): If async image decoding is requested for this frame m_sizeForDraw
will be set. If internalStartAnimation() is called from startAnimation(), sizeForDraw will be empty. In this
case no async image decoding will be requested. This happens only when startAnimation() is called from outside
BitmapImage::draw().
(WebCore::BitmapImage::advanceAnimation): Change the log message.
(WebCore::BitmapImage::newFrameNativeImageAvailableAtIndex): Ditto.

• platform/graphics/BitmapImage.h:

• platform/graphics/ImageFrame.cpp:

(WebCore::ImageFrame::operator=): Include m_sizeForDraw in the properties of ImageFrame.
(WebCore::maxPixelSize): Returns the maximum of the width() and the height of an IntSize.
(WebCore::ImageFrame::isBeingDecoded): Returns true if the ImageFrame is currently being decoded for a specific sizeForDrawing.
(WebCore::ImageFrame::hasValidNativeImage): Ditto.

• platform/graphics/ImageFrame.h:

(WebCore::ImageFrame::enqueueSizeForDecoding): Adds a new sizeForDrawing; this sets the ImageFrame is being decoded for this sizeForDrawing.
(WebCore::ImageFrame::dequeueSizeForDecoding): Removes the first sizeForDrawing was enqueued; this marks this ImageFrame has finished decoding for this sizeForDrawing.
(WebCore::ImageFrame::clearSizeForDecoding): Clears the sizeForDecoding queue. Marks the ImageFrame for not being decoded.
(WebCore::ImageFrame::isEmpty): Replace Decoding::Empty by Decoding::None.
(WebCore::ImageFrame::sizeForDrawing): Returns the ImageFrame sizeForDraw.
(WebCore::ImageFrame::hasDecodedNativeImage): Returns true if the ImageFrame doesn't need decoding before drawing.
(WebCore::ImageFrame::hasValidNativeImage): Deleted. Moved to the source file.

• platform/graphics/ImageFrameCache.cpp:

(WebCore::ImageFrameCache::setFrameNativeImageAtIndex): Take a new argument for sizeForDraw.
(WebCore::ImageFrameCache::setFrameMetadataAtIndex): When sizeForDraw is set, use the decoder to get the image
frame size. Otherwise, get the size of the nativeImage.
(WebCore::ImageFrameCache::replaceFrameNativeImageAtIndex): Take a new argument for sizeForDraw.
(WebCore::ImageFrameCache::cacheFrameNativeImageAtIndex): Ditto.
(WebCore::ImageFrameCache::startAsyncDecodingQueue): Pass the sizeForDraw as a new property of the ImageFrame.
(WebCore::ImageFrameCache::requestFrameAsyncDecodingAtIndex): Store sizeForDraw in ImageFrameRequest. Delete unneeded check.
This function always receives a valid subsamplingLevel.
(WebCore::ImageFrameCache::stopAsyncDecodingQueue): Marks all the queued ImageFrames for not being decoded.
(WebCore::ImageFrameCache::frameAtIndexCacheIfNeeded): Take a new argument for sizeForDraw. If this function fixes the
properties of ImageFrame properties, keep the old sizeForDraw and/or subsamplingLevel. If a new frame is
decoded, no async image decoding will be done in this code path. So pass an empty std::optional<IntSize> to
ImageDecoder::createFrameImageAtIndex() and store std::optional<IntSize> in ImageFrame.
(WebCore::ImageFrameCache::frameMetadataAtIndex): A new helper function which takes a variable number of arguments which
will be passed to the (ImageFrame::*functor).
(WebCore::ImageFrameCache::frameMetadataAtIndexCacheIfNeeded): Make this function takes a variable number of arguments which
will be passed to the frameAtIndexCacheIfNeeded().
(WebCore::ImageFrameCache::size): Pass an Metadata, valid SubsamplingLevel and empty sizeForDraw to frameMetadataAtIndexCacheIfNeeded().
(WebCore::ImageFrameCache::sizeRespectingOrientation): Ditto.
(WebCore::ImageFrameCache::singlePixelSolidColor): Pass MetadataAndImage, empty SubsamplingLevel and empty sizeForDraw to
frameMetadataAtIndexCacheIfNeeded(); we can use the current frame image regardless of its size.
(WebCore::ImageFrameCache::frameIsBeingDecodedAtIndex): Pass the ImageFrame method as a function argument instead of
passing it as a template argument.
(WebCore::ImageFrameCache::frameIsCompleteAtIndex): Ditto.
(WebCore::ImageFrameCache::frameHasAlphaAtIndex): Ditto.
(WebCore::ImageFrameCache::frameHasImageAtIndex): Ditto.
(WebCore::ImageFrameCache::frameHasValidNativeImageAtIndex): Pass subsamplingLevel and sizeForDrawing to frameMetadataAtIndex().
(WebCore::ImageFrameCache::frameHasDecodedNativeImage): New helper function to answer the question whether an ImageFrame will need
decoding when drawing or not.
(WebCore::ImageFrameCache::frameSubsamplingLevelAtIndex): Pass the ImageFrame method as a function argument instead of
passing it as a template argument.
(WebCore::ImageFrameCache::frameSizeAtIndex): Ditto.
(WebCore::ImageFrameCache::frameBytesAtIndex): Ditto.
(WebCore::ImageFrameCache::frameDurationAtIndex): Ditto.
(WebCore::ImageFrameCache::frameOrientationAtIndex):
(WebCore::ImageFrameCache::frameImageAtIndex): Ditto.
(WebCore::ImageFrameCache::frameAtIndex): Deleted. Renamed to frameAtIndexCacheIfNeeded().

• platform/graphics/ImageFrameCache.h:

(WebCore::ImageFrameCache::frameAtIndexCacheIfNeeded):

• platform/graphics/ImageObserver.h: Define a virtual function for image sourceUrl().

• platform/graphics/ImageSource.cpp:

(WebCore::ImageSource::frameImageAtIndex): Take a new argument for sizeForDrawing.

• platform/graphics/ImageSource.h:

(WebCore::ImageSource::requestFrameAsyncDecodingAtIndex): Take a new argument for sizeForDrawing.
(WebCore::ImageSource::frameHasValidNativeImageAtIndex): Ditto.
(WebCore::ImageSource::frameHasDecodedNativeImage): New helper function.
(WebCore::ImageSource::frameImageAtIndex): Ditto.

• platform/graphics/cg/ImageDecoderCG.cpp:

(WebCore::createImageSourceOptions): Create a dictionary with the basic image decoding options.
(WebCore::createImageSourceAsyncOptions): Create a dictionary with the basic asynchronous image decoding options.
(WebCore::appendImageSourceOption): Append the SubsamplingLevel or the MaxPixelSize option to an CGImageSource options dictionary.
(WebCore::appendImageSourceOptions): Append the SubsamplingLevel and the MaxPixelSize option to an CGImageSource options dictionary.
(WebCore::imageSourceOptions): Creates a dictionary for the synchronous image decoding options.
(WebCore::imageSourceAsyncOptions): Creates a dictionary for the asynchronous image decoding options.
(WebCore::ImageDecoder::createFrameImageAtIndex): Replace the DecodingMode argument by an std::optional<IntSize>.

• platform/graphics/cg/ImageDecoderCG.h: Change a prototype.

• platform/graphics/win/ImageDecoderDirect2D.cpp:

(WebCore::ImageDecoder::createFrameImageAtIndex): Replace the DecodingMode argument by an std::optional<IntSize>.

• platform/graphics/win/ImageDecoderDirect2D.h: Change a prototype.

• platform/image-decoders/ImageDecoder.cpp:

(WebCore::ImageDecoder::createFrameImageAtIndex): Replace the DecodingMode argument by an std::optional<IntSize>.

• platform/image-decoders/ImageDecoder.h: Change a prototype.

7:46 PM Changeset in webkit [213562] by commit-queue@webkit.org

• 8 edits in trunk/Tools

Perf and layout test results should report using correct scm revision.
​https://bugs.webkit.org/show_bug.cgi?id=169171

Patch by Kocsen Chung <Kocsen Chung> on 2017-03-07
Reviewed by Ryosuke Niwa.

For accurate record keeping, perf test and layout test results should
report using the native scm revision as an identifier.
To do so we introduce a new scm functions:

native_revision() and timestamp_of_native_revision().

The former is responsible for returning a git hash if scm.git or an
svn revision if scm.svn. The latter is responsible for retrieving the correct timestamp.
We also add the corresponding tests and a helper function _most_recent_log_for_revision.

• Scripts/webkitpy/common/checkout/scm/scm.py:

(SCM.run):
Drive-by indentation fix to adhere to WebKit style conventions.
(SCM.svn_revision):
Remove superfluous comment.
(SCM.native_revision):
Add new abstract function native_revision and make it a _subclass_must_implement()
as we want to closely mimic svn_revision() function due to their similar behavior.
(SCM.timestamp_of_native_revision):
Add new abstract function timestamp_of_native_revision to closely mimic timestamp_of_revision.

• Scripts/webkitpy/common/checkout/scm/git.py:

(Git._most_recent_log_for_revision):
New helper function similar to _most_recent_log_matching that is git hash friendly.
(Git.native_revision):
Implement new function native_revision(). Get the native_revision by running:

git log -1 --pretty=format:%H

and thus returning the latest git hash (in long format).
(Git.timestamp_of_native_revision):
Since perftestrunner and layout_test.controllers.manager use the new native_revision
function, we create a new native_revision timestamp retriever.
You will notice this uses a far more simplified way to retrieve UTC strict-ISO timestamp
than its non-native counterpart: timestamp_of_revision().

• Scripts/webkitpy/common/checkout/scm/svn.py:

(SVN.native_revision):
Implement native_revision for SVN: simply return self.svn_revision()
(SVN.timestamp_of_native_revision):
Implement timestamp_of_native_revision for SVN: simply return self.timestamp_of_revision()

• Scripts/webkitpy/common/checkout/scm/scm_unittest.py:

(test_native_revision):
[SVN] Confirm that svn_revision == native_revision. And that native_revision returns 5.
Use '.' as the path parameter instead of svn_checkout_path to avoid violating pylint/E1101
and since we are guaranteed by test setUp to be in the correct SVN dir.
(GitTest.test_native_revision):
[Git] Confirm that git rev-parse HEAD is equal to newly implemented native_revision().
(GitSVNTest.test_native_revision):
[Git] Confirm that git rev-parse HEAD is equal to newly implemented native_revision().
(test_timestamp_of_native_revision):
Test new function timestamp_of_native_revision. Very similar fashion to
test_timestamp_of_revision.

• Scripts/webkitpy/common/checkout/scm/scm_mock.py:

(MockSCM.native_revision):
Add MockSCM.native_revision to behave like svn.py (default).
(MockSCM.test_native_revision):
Add MockSCM.test_native_revision to behave like its non-native counterpart.

• Scripts/webkitpy/layout_tests/controllers/manager.py:

(Manager.upload_results):
When iterating through a list of projects, make sure we use the project's new native revision.

• Scripts/webkitpy/performance_tests/perftestsrunner.py:

(_generate_results_dict):
As per the FIXME in manager.py, we have duplicate code in perftestsrunner.py.
So make the same exact change here.

7:15 PM Changeset in webkit [213561] by Simon Fraser

• 2 edits in trunk/Source/WebCore

Parsing -webkit-hyphenate-character uses confusingly named consumeLocale()
​https://bugs.webkit.org/show_bug.cgi?id=168638

Reviewed by Zalan Bujtas.

Parsing CSSPropertyWebkitHyphenateCharacter very confusingly called consumeLocale(),
which is really just "consume the 'auto' ident or a string", so rename that function.

• css/parser/CSSPropertyParser.cpp:

(WebCore::consumeAutoOrString):
(WebCore::CSSPropertyParser::parseSingleValue):
(WebCore::consumeLocale): Deleted.

6:09 PM Changeset in webkit [213560] by jiewen_tan@apple.com

• 20 edits
  51 adds in trunk

[WebCrypto] Implement ECDH ImportKey/ExportKey operations
​https://bugs.webkit.org/show_bug.cgi?id=169257
<rdar://problem/23789585>

Reviewed by Brent Fulgham.

LayoutTests/imported/w3c:

• web-platform-tests/WebCryptoAPI/import_export/ec_importKey.worker-expected.txt:
• web-platform-tests/WebCryptoAPI/import_export/test_ec_importKey-expected.txt:

Source/WebCore:

This patch implements ECDH ImportKey/ExportKey operations according to:
​https://www.w3.org/TR/WebCryptoAPI/#ecdh-operations. Sad that we can't
support SPKI/PKCS8 formats at this moment due to lack of necessary
support in the underlying crypto library. Bug 169318 is tracking the
issue. Also, this patch fixes minor bugs while importing JWK keys for
HMAC/RSA.

Tests: crypto/subtle/ec-export-key-malformed-parameters.html

crypto/subtle/ec-import-jwk-key-export-jwk-key-private.html
crypto/subtle/ec-import-jwk-key-export-jwk-key-public.html
crypto/subtle/ec-import-jwk-key-export-raw-key.html
crypto/subtle/ec-import-key-malformed-parameters.html
crypto/subtle/ec-import-raw-key-export-jwk-key.html
crypto/subtle/ec-import-raw-key-export-raw-key.html
crypto/subtle/ecdh-generate-export-jwk-key-p256.html
crypto/subtle/ecdh-generate-export-jwk-key-p384.html
crypto/subtle/ecdh-generate-export-key-raw-p256.html
crypto/subtle/ecdh-generate-export-key-raw-p384.html
crypto/subtle/ecdh-import-jwk-key-minimum.html
crypto/subtle/ecdh-import-jwk-private-key-p256.html
crypto/subtle/ecdh-import-jwk-private-key-p384.html
crypto/subtle/ecdh-import-jwk-public-key-p256.html
crypto/subtle/ecdh-import-jwk-public-key-p384.html
crypto/subtle/ecdh-import-raw-key-p256.html
crypto/subtle/ecdh-import-raw-key-p384.html
crypto/workers/subtle/ec-generate-export-jwk-key.html
crypto/workers/subtle/ec-generate-export-raw-key.html
crypto/workers/subtle/ec-import-jwk-key-private.html
crypto/workers/subtle/ec-import-jwk-key-public.html
crypto/workers/subtle/ec-import-raw-key.html

• bindings/js/JSSubtleCryptoCustom.cpp:

(WebCore::normalizeCryptoAlgorithmParameters):
(WebCore::supportExportKeyThrow):
Added EC family support.

• crypto/CommonCryptoUtilities.h:

Added needed CommonCrypto SPIs.

• crypto/CryptoAlgorithm.h:
• crypto/algorithms/CryptoAlgorithmECDH.cpp:

(WebCore::CryptoAlgorithmECDH::importKey):
(WebCore::CryptoAlgorithmECDH::exportKey):

• crypto/algorithms/CryptoAlgorithmECDH.h:
• crypto/gnutls/CryptoKeyECGnuTLS.cpp:

(WebCore::CryptoKeyEC::keySizeInBits):
(WebCore::CryptoKeyEC::exportRaw):
(WebCore::CryptoKeyEC::platformImportRaw):
(WebCore::CryptoKeyEC::platformImportJWKPublic):
(WebCore::CryptoKeyEC::platformImportJWKPrivate):
(WebCore::CryptoKeyEC::platformAddFieldElements):
Faked implementations for GTK+.

• crypto/keys/CryptoKeyEC.cpp:

(WebCore::toNamedCurve):
(WebCore::CryptoKeyEC::generatePair):
(WebCore::CryptoKeyEC::importRaw):
(WebCore::CryptoKeyEC::importJwk):
(WebCore::CryptoKeyEC::exportJwk):

• crypto/keys/CryptoKeyEC.h:
• crypto/keys/CryptoKeyHMAC.cpp:

(WebCore::CryptoKeyHMAC::importJwk):
Fixed a bug.

• crypto/keys/CryptoKeyRSA.cpp:

(WebCore::CryptoKeyRSA::importJwk):
Fixed a bug.

• crypto/mac/CryptoKeyECMac.cpp:

(WebCore::doesUncompressedPointMatchNamedCurve):
(WebCore::doesFieldElementMatchNamedCurve):
(WebCore::getKeySizeFromNamedCurve):
(WebCore::CryptoKeyEC::~CryptoKeyEC):
(WebCore::CryptoKeyEC::keySizeInBits):
(WebCore::CryptoKeyEC::exportRaw):
(WebCore::CryptoKeyEC::platformGeneratePair):
(WebCore::CryptoKeyEC::platformImportRaw):
(WebCore::CryptoKeyEC::platformImportJWKPublic):
(WebCore::CryptoKeyEC::platformImportJWKPrivate):
(WebCore::CryptoKeyEC::platformAddFieldElements):

LayoutTests:

• crypto/subtle/ec-export-key-malformed-parameters-expected.txt: Added.
• crypto/subtle/ec-export-key-malformed-parameters.html: Added.
• crypto/subtle/ec-import-jwk-key-export-jwk-key-private-expected.txt: Added.
• crypto/subtle/ec-import-jwk-key-export-jwk-key-private.html: Added.
• crypto/subtle/ec-import-jwk-key-export-jwk-key-public-expected.txt: Added.
• crypto/subtle/ec-import-jwk-key-export-jwk-key-public.html: Added.
• crypto/subtle/ec-import-jwk-key-export-raw-key-expected.txt: Added.
• crypto/subtle/ec-import-jwk-key-export-raw-key.html: Added.
• crypto/subtle/ec-import-key-malformed-parameters-expected.txt: Added.
• crypto/subtle/ec-import-key-malformed-parameters.html: Added.
• crypto/subtle/ec-import-raw-key-export-jwk-key-expected.txt: Added.
• crypto/subtle/ec-import-raw-key-export-jwk-key.html: Added.
• crypto/subtle/ec-import-raw-key-export-raw-key-expected.txt: Added.
• crypto/subtle/ec-import-raw-key-export-raw-key.html: Added.
• crypto/subtle/ecdh-generate-export-jwk-key-p256-expected.txt: Added.
• crypto/subtle/ecdh-generate-export-jwk-key-p256.html: Added.
• crypto/subtle/ecdh-generate-export-jwk-key-p384-expected.txt: Added.
• crypto/subtle/ecdh-generate-export-jwk-key-p384.html: Added.
• crypto/subtle/ecdh-generate-export-key-raw-p256-expected.txt: Added.
• crypto/subtle/ecdh-generate-export-key-raw-p256.html: Added.
• crypto/subtle/ecdh-generate-export-key-raw-p384-expected.txt: Added.
• crypto/subtle/ecdh-generate-export-key-raw-p384.html: Added.
• crypto/subtle/ecdh-import-jwk-key-minimum-expected.txt: Added.
• crypto/subtle/ecdh-import-jwk-key-minimum.html: Added.
• crypto/subtle/ecdh-import-jwk-private-key-p256-expected.txt: Added.
• crypto/subtle/ecdh-import-jwk-private-key-p256.html: Added.
• crypto/subtle/ecdh-import-jwk-private-key-p384-expected.txt: Added.
• crypto/subtle/ecdh-import-jwk-private-key-p384.html: Added.
• crypto/subtle/ecdh-import-jwk-public-key-p256-expected.txt: Added.
• crypto/subtle/ecdh-import-jwk-public-key-p256.html: Added.
• crypto/subtle/ecdh-import-jwk-public-key-p384-expected.txt: Added.
• crypto/subtle/ecdh-import-jwk-public-key-p384.html: Added.
• crypto/subtle/ecdh-import-raw-key-p256-expected.txt: Added.
• crypto/subtle/ecdh-import-raw-key-p256.html: Added.
• crypto/subtle/ecdh-import-raw-key-p384-expected.txt: Added.
• crypto/subtle/ecdh-import-raw-key-p384.html: Added.
• crypto/subtle/hmac-import-key-malformed-parameters-expected.txt:
• crypto/subtle/hmac-import-key-malformed-parameters.html:
• crypto/subtle/rsa-import-key-malformed-parameters-expected.txt:
• crypto/subtle/rsa-import-key-malformed-parameters.html:

Fixed some minor bugs.

• crypto/workers/subtle/ec-generate-export-jwk-key-expected.txt: Added.
• crypto/workers/subtle/ec-generate-export-jwk-key.html: Added.
• crypto/workers/subtle/ec-generate-export-raw-key-expected.txt: Added.
• crypto/workers/subtle/ec-generate-export-raw-key.html: Added.
• crypto/workers/subtle/ec-import-jwk-key-private-expected.txt: Added.
• crypto/workers/subtle/ec-import-jwk-key-private.html: Added.
• crypto/workers/subtle/ec-import-jwk-key-public-expected.txt: Added.
• crypto/workers/subtle/ec-import-jwk-key-public.html: Added.
• crypto/workers/subtle/ec-import-raw-key-expected.txt: Added.
• crypto/workers/subtle/ec-import-raw-key.html: Added.
• crypto/workers/subtle/resources/ec-generate-export-jwk-key.js: Added.
• crypto/workers/subtle/resources/ec-generate-export-raw-key.js: Added.
• crypto/workers/subtle/resources/ec-import-jwk-key-private.js: Added.
• crypto/workers/subtle/resources/ec-import-jwk-key-public.js: Added.
• crypto/workers/subtle/resources/ec-import-raw-key.js: Added.

5:50 PM Changeset in webkit [213559] by Simon Fraser

• 2 edits in trunk/Source/WebKit/mac

Initialize the subpixelAntialiasedLayerTextEnabled Setting in WebKit1
​https://bugs.webkit.org/show_bug.cgi?id=169230

Reviewed by Tim Horton.

• WebView/WebView.mm:

(-[WebView _preferencesChanged:]):

5:48 PM Changeset in webkit [213558] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebCore

WebRTC can be used even if getUserMedia is off
​https://bugs.webkit.org/show_bug.cgi?id=169303

Patch by Youenn Fablet <​youenn@apple.com> on 2017-03-07
Reviewed by Alex Christensen.

• page/RuntimeEnabledFeatures.h:

(WebCore::RuntimeEnabledFeatures::peerConnectionEnabled): No longer tieing peerConnectionEnabled to
mediaStreamEnabled.

5:43 PM Changeset in webkit [213557] by Simon Fraser

• 4 edits in trunk/Source

Enable SubpixelAntialiasedLayerTextEnabled by default on some versions of macOS
​https://bugs.webkit.org/show_bug.cgi?id=169329

Reviewed by Tim Horton.

If the macOS version is > 101300, enable subpixelAntialiasedLayerTextEnabled.

Source/WebKit/mac:

• WebView/WebPreferences.mm:

(+[WebPreferences initialize]):

Source/WebKit2:

• Shared/WebPreferencesDefinitions.h:

5:36 PM Changeset in webkit [213556] by dino@apple.com

• 3 edits in trunk/Source/WebCore

Make platformDevice() not inline, to avoid a
weak external symbol issue on newer compilers/linkers

• platform/graphics/cocoa/GPUDeviceMetal.mm:

(WebCore::GPUDevice::platformDevice):

• platform/graphics/gpu/GPUDevice.h:

(WebCore::GPUDevice::platformDevice): Deleted.

5:03 PM Changeset in webkit [213555] by timothy_horton@apple.com

• 2 edits in trunk/Tools

Fix the TestWebKitAPI build

Rubber-stamped by Anders Carlsson.

• TestWebKitAPI/Tests/WTF/MetaAllocator.cpp:

(TestWebKitAPI::TEST_F):
Fix a new warning about default argument promotion and va_start by
making this a enum class.

4:59 PM Changeset in webkit [213554] by Ryan Haddad

• 2 edits in trunk/LayoutTests

Add Debug flag to TestExpectation for webrtc/libwebrtc/descriptionGetters.html.

Unreviewed test gardening.

• platform/mac-wk2/TestExpectations:

4:54 PM Changeset in webkit [213553] by Ryan Haddad

• 2 edits in trunk/LayoutTests

Mark webrtc/libwebrtc/descriptionGetters.html as failing.
​https://bugs.webkit.org/show_bug.cgi?id=169317

Unreviewed test gardening.

• platform/mac-wk2/TestExpectations:

4:54 PM Changeset in webkit [213552] by commit-queue@webkit.org

• 2 edits in trunk/Source/ThirdParty/libwebrtc

TurnPort::OnSocketConnect is crashing
​https://bugs.webkit.org/show_bug.cgi?id=169284

Patch by Youenn Fablet <​youenn@apple.com> on 2017-03-07
Reviewed by Eric Carlson.

• Source/webrtc/p2p/base/turnport.cc: Fixing the assertion.

4:41 PM Changeset in webkit [213551] by Megan Gardner

• 3 edits in trunk/Source/WebKit/mac

Additional DataInteraction Support
​https://bugs.webkit.org/show_bug.cgi?id=169316
<rdar://problem/30884234>

Reviewed by Wenson Hsieh.

Add stub implementations to WebView for methods that handle data interaction

• WebView/WebView.mm:

(-[WebView _enteredDataInteraction:client:global:operation:]):
(-[WebView _updatedDataInteraction:client:global:operation:]):
(-[WebView _exitedDataInteraction:client:global:operation:]):
(-[WebView _performDataInteraction:client:global:operation:]):
(-[WebView _endedDataInteraction:global:]):

• WebView/WebViewPrivate.h:

4:31 PM Changeset in webkit [213550] by Chris Dumez

• 1 edit
  2 adds in trunk/LayoutTests

Add test case to check that MessageEvent.data returns the value it was initialized to
​https://bugs.webkit.org/show_bug.cgi?id=169311

Reviewed by Sam Weinig.

• fast/events/constructors/message-event-constructor-data-identity-expected.txt: Added.
• fast/events/constructors/message-event-constructor-data-identity.html: Added.

4:09 PM Changeset in webkit [213549] by dino@apple.com

• 15 edits in trunk

Some platforms won't be able to create a GPUDevice
​https://bugs.webkit.org/show_bug.cgi?id=169314
<rdar://problems/30907521>

Reviewed by Jon Lee.

Source/JavaScriptCore:

Disable WEB_GPU on the iOS Simulator.

• Configurations/FeatureDefines.xcconfig:

Source/WebCore:

Protect for the case where the hardware doesn't support Metal. And
we might as well disable WebGPU completely in the iOS simulator
for now.

• Configurations/FeatureDefines.xcconfig:
• platform/graphics/cocoa/GPUDeviceMetal.mm:

(WebCore::GPUDevice::GPUDevice):

• platform/graphics/gpu/GPUDevice.cpp:

(WebCore::GPUDevice::create):

Source/WebCore/PAL:

Disable WEB_GPU on the iOS Simulator.

• Configurations/FeatureDefines.xcconfig:

Source/WebKit/mac:

Disable WEB_GPU on the iOS Simulator.

• Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

Disable WEB_GPU on the iOS Simulator.

• Configurations/FeatureDefines.xcconfig:

Tools:

Protect for the case where the hardware doesn't support Metal.

• TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
• TestWebKitAPI/Tests/WebCore/mac/GPUDevice.mm:

(TestWebKitAPI::TEST):

3:21 PM Changeset in webkit [213548] by rniwa@webkit.org

• 2 edits in trunk/Websites/perf.webkit.org

Update ReadMe.md to use directory format for backing up & restoring the database
​https://bugs.webkit.org/show_bug.cgi?id=169263

Reviewed by Joseph Pecoraro.

Update ReadMe.md's instruction to backup and restore the database to use directory format instead of
piping it to gzip. The new command will backup and restore the database with multiple concurrent processes
with a custom compression level.

• ReadMe.md:

3:12 PM Changeset in webkit [213547] by Ryan Haddad

• 6 edits
  1 add in trunk

Correctly check for an empty database file.
<rdar://problem/30542242> Removing Website Data not working (WebSQL directories being left behind)
​https://bugs.webkit.org/show_bug.cgi?id=169256

Patch by Maureen Daum <​mdaum@apple.com> on 2017-03-07
Reviewed by Brady Eidson.

Source/WebCore:

Tests: DatabaseTrackerTest.DeleteDatabaseFileIfEmpty verifies that we actually delete an empty file.

Instead of checking that a database file's size is zero bytes, we should check if it contains
any tables. Once we open an empty database file and set its journal mode to WAL, it will have a
valid SQLite header and therefore will no longer be empty. We can know that the database was empty
if it does not contain any tables.

• Modules/webdatabase/DatabaseTracker.cpp:

(WebCore::DatabaseTracker::deleteDatabaseFileIfEmpty):
Use BEGIN EXCLUSIVE TRANSACTION in order to obtain the exclusive lock. If the database doesn't contain
any tables, it is empty and can be deleted.

Source/WebKit/mac:

Check if the folder for an origin's WebSQL databases is empty after trying to delete
all of its files. Currently we check if the deletedDatabaseFileCount matches the number
of files that were in the folder. However, when we delete the actual database file in
DatabaseTracker::deleteDatabaseFileIfEmpty(), the shm and wal files get deleted along with
the database file, but deletedDatabaseFileCount only gets incremented once.

• Storage/WebDatabaseManager.mm:

(+[WebDatabaseManager removeEmptyDatabaseFiles]):
Delete the folder if it is empty.

Tools:

Add a test for DatabaseTracker::deleteDatabaseFileIfEmpty that verifies
that if we pass in an empty file it actually gets deleted.

• TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:

Add TestWebKitAPI/Tests/WebCore/DatabaseTrackerTest.cpp.

• TestWebKitAPI/Tests/WebCore/DatabaseTrackerTest.cpp: Added.

(TestWebKitAPI::TEST):

3:07 PM Changeset in webkit [213546] by commit-queue@webkit.org

• 8 edits in trunk

[URLParser] Fix file URLs that are just ​file:// and a Windows drive letter
​https://bugs.webkit.org/show_bug.cgi?id=169242

Patch by Alex Christensen <​achristensen@webkit.org> on 2017-03-07
Reviewed by Tim Horton.

LayoutTests/imported/w3c:

• web-platform-tests/url/a-element-expected.txt:
• web-platform-tests/url/a-element-xhtml-expected.txt:
• web-platform-tests/url/url-constructor-expected.txt:

Source/WebCore:

This is specified in ​https://url.spec.whatwg.org/#file-host-state and tested by a newly-passing
web platform test. I added the check for the windows drive quirk in the FileHost state of the
parser but I forgot it when FileHost is the terminal state.

• platform/URLParser.cpp:

(WebCore::URLParser::parse):

Tools:

• TestWebKitAPI/Tests/WebCore/URLParser.cpp:

(TestWebKitAPI::TEST_F):

3:05 PM Changeset in webkit [213545] by Jonathan Bedard

• 9 edits in trunk/Tools

Standardize device/simulator naming conventions
​https://bugs.webkit.org/show_bug.cgi?id=169083
<rdar://problem/30810466>

Reviewed by Alexey Proskuryakov.

• Scripts/build-webkit: Document --ios-device and --simulator options.
• Scripts/package-root:

(usage): Ditto.

• Scripts/run-api-tests: Document --simulator option.
• Scripts/webkitdirs.pm:

(argumentsForConfiguration): Use --ios-device by default rather than --device.
(determineXcodeSDK): Parse --ios-device and --simulator options.

• Scripts/webkitpy/common/config/ews.json: Change port name from ios to ios-device.
• Scripts/webkitpy/common/config/ports.py: Ditto.

(DeprecatedPort.port):
(IOSPort): Change port name from ios to ios-device.

• Scripts/webkitpy/port/factory.py:

(platform_options): Add --simulator option.
(PortFactory): Update comment.

• Scripts/webkitpy/port/ios_device.py:

(IOSDevicePort): Change port name from ios to ios-device.
(IOSDevicePort.operating_system): Ditto.

2:53 PM Changeset in webkit [213544] by Brent Fulgham

• 8 edits in trunk/Source/WebKit2

[Mac][iOS][WK2] Whitelist sysctl-read
​https://bugs.webkit.org/show_bug.cgi?id=169306
<rdar://problem/16371458>

Reviewed by Alex Christensen.

Limit access to the 'sysctl' call to read-only cases of the very small
set of operations we actually use.

• DatabaseProcess/mac/com.apple.WebKit.Databases.sb.in:
• NetworkProcess/mac/com.apple.WebKit.NetworkProcess.sb.in:
• PluginProcess/mac/com.apple.WebKit.plugin-common.sb.in:
• Resources/SandboxProfiles/ios/com.apple.WebKit.Databases.sb:
• Resources/SandboxProfiles/ios/com.apple.WebKit.Networking.sb:
• Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:
• WebProcess/com.apple.WebProcess.sb.in:

2:44 PM Changeset in webkit [213543] by Chris Dumez

• 5 edits in trunk/Source

Drop non-standard MessageEvent.webkitInitMessageEvent()
​https://bugs.webkit.org/show_bug.cgi?id=169295

Reviewed by Joseph Pecoraro.

Source/WebCore:

Drop non-standard MessageEvent.webkitInitMessageEvent().

Chrome dropped it almost 3 years ago. They had UseCounter data showing
consistent 0% usage:

• ​https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/H6lsGFqdy3Y
• ​https://www.chromestatus.com/metrics/feature/timeline/popularity/223
• ​https://src.chromium.org/viewvc/blink?revision=174967&view=revision

• bindings/js/JSMessageEventCustom.cpp:

(WebCore::handleInitMessageEvent): Deleted.
(WebCore::JSMessageEvent::webkitInitMessageEvent): Deleted.

• dom/MessageEvent.idl:

Source/WebInspectorUI:

Drop MessageEvent.webkitInitMessageEvent and update parameters for various
init*Event() operations to match the current implementation.

• UserInterface/Models/NativeFunctionParameters.js:

2:24 PM Changeset in webkit [213542] by Chris Dumez

• 4 edits
  6 adds in trunk

Label of an <option> element should not be displayed in quirks mode
​https://bugs.webkit.org/show_bug.cgi?id=169296
<rdar://problem/30900751>

Reviewed by Simon Fraser.

Source/WebCore:

Label of an <option> element should not be displayed in quirks mode, to
match Chrome and Firefox. However, we should still display the label in
strict mode, as per the HTML specification:

• ​https://html.spec.whatwg.org/multipage/rendering.html#the-select-element-2

Chrome renders the label in strict mode, same as us. Firefox does not:

• ​https://bugzilla.mozilla.org/show_bug.cgi?id=1345242

Tests: fast/dom/HTMLOptionElement/option-label-quirksmode.html

fast/dom/HTMLOptionElement/option-label-quirksmode2.html
fast/dom/HTMLOptionElement/option-label-strictmode.html

• html/HTMLOptionElement.cpp:

(WebCore::HTMLOptionElement::displayLabel):
(WebCore::HTMLOptionElement::textIndentedToRespectGroupLabel):

• html/HTMLOptionElement.h:

LayoutTests:

Add layout test coverage.

• fast/dom/HTMLOptionElement/option-label-quirksmode-expected.html: Added.
• fast/dom/HTMLOptionElement/option-label-quirksmode.html: Added.
• fast/dom/HTMLOptionElement/option-label-quirksmode2-expected.html: Added.
• fast/dom/HTMLOptionElement/option-label-quirksmode2.html: Added.
• fast/dom/HTMLOptionElement/option-label-strictmode-expected.html: Added.
• fast/dom/HTMLOptionElement/option-label-strictmode.html: Added.

2:23 PM Changeset in webkit [213541] by dino@apple.com

• 7 edits
  7 adds in trunk

Add GPUDevice implementation and WebGPULayer
​https://bugs.webkit.org/show_bug.cgi?id=169219
<rdar://problem/30879048>

Reviewed by Sam Weinig.

Source/WebCore:

Add a basic implementation of a GPUDevice object,
which references a MTLDevice. Also add a WebGPULayer
that will ultimately be used to host WebGPU content.

WebKit API Test: WebCore/mac/GPUDevice.mm

• Configurations/WebCore.xcconfig: Link to Metal.

• PlatformMac.cmake: New files.
• WebCore.xcodeproj/project.pbxproj:

• platform/Logging.h: Add a WebGPU logging channel.

• platform/graphics/cocoa/GPUDeviceMetal.mm: Added.

(WebCore::GPUDevice::GPUDevice): Cocoa implementation.
(WebCore::GPUDevice::reshape):

• platform/graphics/cocoa/WebGPULayer.h: Added.
• platform/graphics/cocoa/WebGPULayer.mm: Added.

(-[WebGPULayer initWithGPUDevice:]):
(-[WebGPULayer copyImageSnapshotWithColorSpace:]):
(-[WebGPULayer display]):

• platform/graphics/gpu/GPUDevice.cpp: Added.

(WebCore::GPUDevice::create):
(WebCore::GPUDevice::~GPUDevice):
(WebCore::GPUDevice::GPUDevice): Implementation for platforms
other than Mac and iOS hardware.
(WebCore::GPUDevice::reshape):

• platform/graphics/gpu/GPUDevice.h: Added.

(WebCore::GPUDevice::platformLayer):
(WebCore::GPUDevice::platformDevice):
(WebCore::GPUDevice::layer):

Tools:

Test for WebCore's GPUDevice class.

• TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
• TestWebKitAPI/Tests/WebCore/mac/GPUDevice.mm: Added.

(TestWebKitAPI::TEST):

2:22 PM Changeset in webkit [213540] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebCore

[Modern Media Controls] Log an error to the console when an image fails to load
​https://bugs.webkit.org/show_bug.cgi?id=169292

Patch by Antoine Quint <Antoine Quint> on 2017-03-07
Reviewed by Dean Jackson.

In order to help debug flaky tests we now log the image source when an image fails to load.

• Modules/modern-media-controls/controls/icon-button.js:

(IconButton.prototype.handleEvent):
(IconButton.prototype._loadImage):

1:51 PM Changeset in webkit [213539] by jmarcell@apple.com

• 6 edits in tags/Safari-604.1.8.2.1/Source

Versioning.

1:46 PM Changeset in webkit [213538] by jmarcell@apple.com

• 1 copy in tags/Safari-604.1.8.2.1

Tag Safari-604.1.8.2.1.

1:26 PM Changeset in webkit [213537] by Ryan Haddad

• 2 edits in trunk/LayoutTests

Mark media/modern-media-controls/seek-backward-support/seek-backward-support.html as flaky.
​https://bugs.webkit.org/show_bug.cgi?id=165386

Unreviewed test gardening.

• platform/mac/TestExpectations:

1:26 PM Changeset in webkit [213536] by Ryan Haddad

• 2 edits in trunk/LayoutTests

Mark media/modern-media-controls/macos-inline-media-controls/macos-inline-media-controls-audio-background.html as flaky.
​https://bugs.webkit.org/show_bug.cgi?id=169117

Unreviewed test gardening.

• platform/mac-wk1/TestExpectations:

1:26 PM Changeset in webkit [213535] by Ryan Haddad

• 2 edits in trunk/LayoutTests

Remove Debug flag from flaky test http/tests/cache/disk-cache/memory-cache-revalidation-updates-disk-cache.html.
​https://bugs.webkit.org/show_bug.cgi?id=162975

Unreviewed test gardening.

• platform/mac-wk2/TestExpectations:

1:02 PM Changeset in webkit [213534] by Alan Bujtas

• 3 edits
  2 adds in trunk

Simple line layout: Do not use invalid m_lastNonWhitespaceFragment while removing trailing whitespace.
​https://bugs.webkit.org/show_bug.cgi?id=169288
rdar://problem/30576976

Reviewed by Antti Koivisto.

Source/WebCore:

When the current line has nothing but whitespace, m_lastNonWhitespaceFragment is invalid so
we should not use the start/end values to decide how many characters we need to revert.
This patch makes m_lastNonWhitespaceFragment optional. When it's invalid we just remove
all the runs from the current line since they are all considered whitespace runs.

Test: fast/text/simple-line-layout-line-is-all-whitespace.html

• rendering/SimpleLineLayout.cpp:

(WebCore::SimpleLineLayout::revertAllRunsOnCurrentLine):
(WebCore::SimpleLineLayout::LineState::removeTrailingWhitespace):

LayoutTests:

• fast/text/simple-line-layout-line-is-all-whitespace-expected.txt: Added.
• fast/text/simple-line-layout-line-is-all-whitespace.html: Added.

12:54 PM Changeset in webkit [213533] by achristensen@apple.com

• 25 edits in trunk

[Content Extensions] Rename "Domain" to "Condition" where appropriate
​https://bugs.webkit.org/show_bug.cgi?id=169297

Reviewed by Brady Eidson.

Source/WebCore:

In r184116 I added the ability for a content blocker author to add conditions to the triggers,
if-domain and unless-domain which look at the domain of the main document URL.
I plan to add more conditions soon to run regexes on the entire URL, but to make that patch more
manageable, I took the non-behavior-changing parts and put them in this patch.

No change in behavior except some error messages were made more generic.

• contentextensions/CompiledContentExtension.h:
• contentextensions/ContentExtension.cpp:

(WebCore::ContentExtensions::ContentExtension::ContentExtension):
(WebCore::ContentExtensions::ContentExtension::compileGlobalDisplayNoneStyleSheet):
(WebCore::ContentExtensions::ContentExtension::populateConditionCacheIfNeeded):
Pass the main document URL instead of just the domain. No change in behavior yet.
(WebCore::ContentExtensions::ContentExtension::cachedConditionedActions):
(WebCore::ContentExtensions::ContentExtension::universalActionsWithConditions):
(WebCore::ContentExtensions::ContentExtension::populateDomainCacheIfNeeded): Deleted.
(WebCore::ContentExtensions::ContentExtension::cachedDomainActions): Deleted.
(WebCore::ContentExtensions::ContentExtension::universalActionsWithDomains): Deleted.

• contentextensions/ContentExtension.h:

(WebCore::ContentExtensions::ContentExtension::universalActionsWithoutConditions):
(WebCore::ContentExtensions::ContentExtension::universalActionsWithoutDomains): Deleted.

• contentextensions/ContentExtensionCompiler.cpp:

(WebCore::ContentExtensions::serializeActions):
(WebCore::ContentExtensions::compileRuleList):

• contentextensions/ContentExtensionCompiler.h:
• contentextensions/ContentExtensionError.cpp:

(WebCore::ContentExtensions::contentExtensionErrorCategory):

• contentextensions/ContentExtensionError.h:
• contentextensions/ContentExtensionParser.cpp:

(WebCore::ContentExtensions::getStringList):
Don't pass the error type as a parameter. It's always JSONInvalidConditionList.
(WebCore::ContentExtensions::getDomainList):
(WebCore::ContentExtensions::loadTrigger):

• contentextensions/ContentExtensionRule.h:

(WebCore::ContentExtensions::Trigger::~Trigger):
(WebCore::ContentExtensions::Trigger::isEmpty):
(WebCore::ContentExtensions::Trigger::operator==):
(WebCore::ContentExtensions::TriggerHash::hash):
Use bitwise xor instead of bitwise or to have fewer hash collisions.
Also, before we were accidentally doing the same hash operation here for IfDomain and UnlessDomain.
This caused unnecessary hash collisions. This is fixed, but should not change any behavior.

• contentextensions/ContentExtensionsBackend.cpp:

(WebCore::ContentExtensions::ContentExtensionsBackend::actionsForResourceLoad):

• contentextensions/DFABytecode.h:

(WebCore::ContentExtensions::instructionSizeWithArguments):

• contentextensions/DFABytecodeCompiler.cpp:

(WebCore::ContentExtensions::DFABytecodeCompiler::emitAppendAction):

• contentextensions/DFABytecodeInterpreter.cpp:

(WebCore::ContentExtensions::matchesCondition):
(WebCore::ContentExtensions::DFABytecodeInterpreter::interpretAppendAction):
(WebCore::ContentExtensions::DFABytecodeInterpreter::interpretTestFlagsAndAppendAction):
(WebCore::ContentExtensions::DFABytecodeInterpreter::actionsMatchingEverything):
(WebCore::ContentExtensions::DFABytecodeInterpreter::interpretWithConditions):
(WebCore::ContentExtensions::DFABytecodeInterpreter::interpret):
(WebCore::ContentExtensions::matchesDomain): Deleted.
(WebCore::ContentExtensions::DFABytecodeInterpreter::interpretWithDomains): Deleted.

• contentextensions/DFABytecodeInterpreter.h:
• loader/ResourceLoadInfo.h:

Source/WebKit2:

• Shared/WebCompiledContentExtension.cpp:

(WebKit::WebCompiledContentExtension::filtersWithoutConditionsBytecode):
(WebKit::WebCompiledContentExtension::filtersWithoutConditionsBytecodeLength):
(WebKit::WebCompiledContentExtension::filtersWithConditionsBytecode):
(WebKit::WebCompiledContentExtension::filtersWithConditionsBytecodeLength):
(WebKit::WebCompiledContentExtension::conditionedFiltersBytecode):
(WebKit::WebCompiledContentExtension::conditionedFiltersBytecodeLength):
(WebKit::WebCompiledContentExtension::filtersWithoutDomainsBytecode): Deleted.
(WebKit::WebCompiledContentExtension::filtersWithoutDomainsBytecodeLength): Deleted.
(WebKit::WebCompiledContentExtension::filtersWithDomainsBytecode): Deleted.
(WebKit::WebCompiledContentExtension::filtersWithDomainsBytecodeLength): Deleted.
(WebKit::WebCompiledContentExtension::domainFiltersBytecode): Deleted.
(WebKit::WebCompiledContentExtension::domainFiltersBytecodeLength): Deleted.

• Shared/WebCompiledContentExtension.h:
• Shared/WebCompiledContentExtensionData.cpp:

(WebKit::WebCompiledContentExtensionData::encode):
(WebKit::WebCompiledContentExtensionData::decode):

• Shared/WebCompiledContentExtensionData.h:

(WebKit::WebCompiledContentExtensionData::WebCompiledContentExtensionData):

• UIProcess/API/APIUserContentExtensionStore.cpp:

(API::ContentExtensionMetaData::fileSize):
(API::encodeContentExtensionMetaData):
(API::decodeContentExtensionMetaData):
(API::compiledToFile):
(API::createExtension):
(API::UserContentExtensionStore::lookupContentExtension):
(API::UserContentExtensionStore::compileContentExtension):
(API::UserContentExtensionStore::removeContentExtension):

• UIProcess/API/APIUserContentExtensionStore.h:

Tools:

• TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:

(TestWebKitAPI::InMemoryCompiledContentExtension::create):
(TestWebKitAPI::TEST_F):

12:36 PM Changeset in webkit [213532] by Michael Catanzaro

• 2 edits in trunk/Source/WebCore

[FreeType] FontPlatformData::fallbacks() returns unprepared FcPatterns
​https://bugs.webkit.org/show_bug.cgi?id=164689

Reviewed by Carlos Garcia Campos.

From the documentation of FcFontSort():

"""The returned FcFontSet references FcPattern structures which may be shared by the
return value from multiple FcFontSort calls, applications must not modify these patterns.
Instead, they should be passed, along with p to FcFontRenderPrepare which combines them into
a complete pattern."""

That means each call to FcFontSort() must be followed up by a call to FcFontRenderPrepare(),
else the patterns will lack information about how to draw the font properly.

• platform/graphics/freetype/FontPlatformDataFreeType.cpp:

(WebCore::FontPlatformData::fallbacks):

12:16 PM Changeset in webkit [213531] by commit-queue@webkit.org

• 4 edits in trunk/LayoutTests

Flaky Test: media/modern-media-controls/tracks-support/tracks-support-click-track-in-panel.html
​https://bugs.webkit.org/show_bug.cgi?id=169159

Patch by Antoine Quint <Antoine Quint> on 2017-03-07
Reviewed by Dean Jackson.

Make this test more defensive to ensure it doesn't fail.

• media/modern-media-controls/tracks-support/tracks-support-click-track-in-panel-expected.txt:
• media/modern-media-controls/tracks-support/tracks-support-click-track-in-panel.html:
• platform/mac/TestExpectations:

12:05 PM Changeset in webkit [213530] by Jonathan Bedard

• 3 edits in trunk/Tools

webkitpy: Refactor setup_test_run for IOSPort and IOSSimulator
​https://bugs.webkit.org/show_bug.cgi?id=169220
<rdar://problem/30879645>

Reviewed by Daniel Bates.

Provide more specific port setup functions for iOS ports to allow more sharing of common code.

• Scripts/webkitpy/port/ios.py:

(IOSPort):
(IOSPort._create_devices): Added.
(IOSPort.setup_test_run): Shared iOS device setup code.

• Scripts/webkitpy/port/ios_simulator.py:

(IOSSimulatorPort._create_devices): Renamed from setup_test_run.
(IOSSimulatorPort.setup_test_run): Renamed as _create_devices.

11:27 AM Changeset in webkit [213529] by andersca@apple.com

• 2 edits in trunk/Tools

Rewrite the DRT Pasteboard implementation to use UTIs and WTF types
​https://bugs.webkit.org/show_bug.cgi?id=169289

Reviewed by Tim Horton.

• DumpRenderTree/mac/DumpRenderTreePasteboard.mm:

(-[LocalPasteboard initWithName:]):
(-[LocalPasteboard name]):
(-[LocalPasteboard declareTypes:owner:]):
(isUTI):
(toUTI):
(-[LocalPasteboard addTypes:owner:]):
(-[LocalPasteboard changeCount]):
(-[LocalPasteboard types]):
(-[LocalPasteboard availableTypeFromArray:]):
(-[LocalPasteboard setData:forType:]):
(-[LocalPasteboard dataForType:]):
(-[LocalPasteboard writeObjects:]):
(-[LocalPasteboard dealloc]): Deleted.

11:26 AM Changeset in webkit [213528] by mmaxfield@apple.com

• 7 edits
  1 add in trunk

Parsing font descriptors inside @font-face needs to accept ranges
​https://bugs.webkit.org/show_bug.cgi?id=168893

Reviewed by Dean Jackson.

Source/WebCore:

Parse font-weight, font-stretch, and font-style ranges according to
​https://drafts.csswg.org/css-fonts-4/#font-prop-desc. There is one difference, though:
as documented in ​https://github.com/w3c/csswg-drafts/issues/783, slashes are a better
delimiters than hyphens, so this patch implements that instead. I'll update the spec to
include slashes as soon as possible.

Because this patch is all about creating FontSelectionValues from fonts, it doesn't
actually modify the font selection algorithm, and therefore only tests the creation of
these new values. The font selection algorithm itself is already tested elsewhere.

This new work is behind the ENABLE(VARIATION_FONTS) flag.

Test: fast/text/font-selection-font-face-parse.html

• css/CSSFontFace.cpp:

(WebCore::calculateWeightRange):
(WebCore::calculateStretchRange):
(WebCore::calculateItalicRange):

• css/parser/CSSPropertyParser.cpp:

(WebCore::consumeFontWeightRange):
(WebCore::consumeFontStretchRange):
(WebCore::consumeFontStyleRange):
(WebCore::CSSPropertyParser::parseFontFaceDescriptor):

• platform/graphics/cocoa/FontCacheCoreText.cpp:

(WebCore::extractVariationBounds):
(WebCore::variationCapabilitiesForFontDescriptor):
(WebCore::capabilitiesForFontDescriptor):

LayoutTests:

• fast/text/font-selection-font-face-parse-expected.txt:
• fast/text/font-selection-font-face-parse.html:
• platform/mac-elcapitan/fast/text/font-selection-font-face-parse-expected.txt:

Variations are off on El Capitan, so this platform needs explicit results.

11:21 AM Changeset in webkit [213527] by fpizlo@apple.com

• 2 edits in trunk/PerformanceTests

Revise the ARES-6 explainer text
​https://bugs.webkit.org/show_bug.cgi?id=169287

Reviewed by Saam Barati.

Just did some copy-editing.

• ARES-6/about.html:

11:16 AM Changeset in webkit [213526] by clopez@igalia.com

• 1 edit
  2 moves in trunk/LayoutTests

Move webrtc/descriptionGetters.html to webrtc/libwebrtc/descriptionGetters.html
​https://bugs.webkit.org/show_bug.cgi?id=169216

Unreviewed test gardening.

Move the test webrtc/descriptionGetters.html under the directory webrtc/libwebrtc
because its still not testing the spec, but the current libwebrtc based implementation.

This way the test is skipped on the GTK+ port (The whole directory webrtc/libwebrtc is skipped).

• webrtc/libwebrtc/descriptionGetters-expected.txt: Renamed from LayoutTests/webrtc/descriptionGetters-expected.txt.
• webrtc/libwebrtc/descriptionGetters.html: Renamed from LayoutTests/webrtc/descriptionGetters.html.

10:54 AM Changeset in webkit [213525] by mmaxfield@apple.com

• 2 edits in trunk/Tools

Add David Jonathan Ross to contributors.json
​https://bugs.webkit.org/show_bug.cgi?id=169265

Unreviewed.

David Jonathan Ross very kindly offered to create and contribute his Boxis font in r211060,
which is used for testing font variations.

• Scripts/webkitpy/common/config/contributors.json:

10:37 AM CoordinatedGraphicsSystem edited by Konstantin Tokarev

Mention that TextureMapperBackingStore is the interface (diff)

10:06 AM Changeset in webkit [213524] by Brent Fulgham

• 2 edits in trunk/Source/WebKit2

[Mac][WK2] Expand sandbox to support access to audio component registrar
​https://bugs.webkit.org/show_bug.cgi?id=169283
<rdar://problem/30793512>

Reviewed by Alexey Proskuryakov.

• WebProcess/com.apple.WebProcess.sb.in:

9:59 AM Changeset in webkit [213523] by hyatt@apple.com

• 2 edits in trunk/Source/WebCore

Animated GIFs fail to play in multi-column layout
​https://bugs.webkit.org/show_bug.cgi?id=167901
<rdar://problem/30382262>

Reviewed by Zalan Bujtas.

• rendering/RenderBox.cpp:

(WebCore::RenderBox::computeRectForRepaint):
Make sure to handle the case where we pass in a null repaintContainer and need
to cross a multicolumn flow thread -> region boundary as a result.

9:43 AM CoordinatedGraphicsSystem edited by Konstantin Tokarev

GraphicsLayerAnimation was renamed to TextureMapperAnimation (diff)

9:36 AM CoordinatedGraphicsSystem edited by Konstantin Tokarev

LayerTreeRenderer was renamed to CoordinatedGraphicsScene (diff)

9:33 AM Changeset in webkit [213522] by Alan Bujtas

• 3 edits in trunk/Source/WebCore

ShadowBlur::calculateLayerBoundingRect doesn't need to return the enclosingIntRect of layerRect
​https://bugs.webkit.org/show_bug.cgi?id=168650

Patch by Fujii Hironori <Fujii Hironori> on 2017-03-07
Reviewed by Simon Fraser.

No new tests, no behavior change.

• platform/graphics/ShadowBlur.h: Change the type of return value

from IntRect to IntSize.

• platform/graphics/ShadowBlur.cpp:

(WebCore::ShadowBlur::calculateLayerBoundingRect): Ditto.
(WebCore::ShadowBlur::drawRectShadow): Rename a variable layerRect layerSize.
(WebCore::ShadowBlur::drawInsetShadow): Ditto.
(WebCore::ShadowBlur::drawRectShadowWithoutTiling): Ditto.
(WebCore::ShadowBlur::drawInsetShadowWithoutTiling): Ditto.
(WebCore::ShadowBlur::beginShadowLayer): Ditto.

9:29 AM CoordinatedGraphicsSystem edited by Konstantin Tokarev

Updated paths of some source files (diff)

9:22 AM Changeset in webkit [213521] by Chris Dumez

• 4 edits in trunk/Source/WebCore

Replace debug assertion with release one in Frame::setView()
​https://bugs.webkit.org/show_bug.cgi?id=169189

Reviewed by Ryosuke Niwa.

Replace debug assertion with release one in Frame::setView() to make make sure the
document does not have a living render tree. This will help identify possible
remaining cases where this can happen.

• dom/Document.cpp:

(WebCore::Document::didBecomeCurrentDocumentInView): Deleted.

• dom/Document.h:
• page/Frame.cpp:

(WebCore::Frame::setView):

9:15 AM Changeset in webkit [213520] by commit-queue@webkit.org

• 6 edits
  2 adds in trunk

Expose WebRTC current/pending description getters
​https://bugs.webkit.org/show_bug.cgi?id=169216

Patch by Youenn Fablet <​youenn@apple.com> on 2017-03-07
Reviewed by Alex Christensen.

Source/WebCore:

Test: webrtc/descriptionGetters.html

Implement pending and current description getters through libwebrtc.
These getters do not yet match the spec as can be seen from the test, which is written to match the implemented behavior.

• Modules/mediastream/libwebrtc/LibWebRTCPeerConnectionBackend.cpp:

(WebCore::LibWebRTCPeerConnectionBackend::currentLocalDescription):
(WebCore::LibWebRTCPeerConnectionBackend::currentRemoteDescription):
(WebCore::LibWebRTCPeerConnectionBackend::pendingLocalDescription):
(WebCore::LibWebRTCPeerConnectionBackend::pendingRemoteDescription):

• Modules/mediastream/libwebrtc/LibWebRTCPeerConnectionBackend.h:

LayoutTests:

• webrtc/descriptionGetters-expected.txt: Added.
• webrtc/descriptionGetters.html: Added.

9:11 AM Changeset in webkit [213519] by Chris Dumez

• 32 edits in trunk/Source

Port DOMTimer from std::chrono::milliseconds to WTF::Seconds type
​https://bugs.webkit.org/show_bug.cgi?id=169236

Reviewed by Simon Fraser.

Source/WebCore:

• dom/Document.cpp:

(WebCore::Document::minimumDOMTimerInterval):
(WebCore::Document::timerAlignmentInterval):

• dom/Document.h:
• dom/ScriptExecutionContext.cpp:

(WebCore::ScriptExecutionContext::adjustMinimumDOMTimerInterval):
(WebCore::ScriptExecutionContext::minimumDOMTimerInterval):
(WebCore::ScriptExecutionContext::timerAlignmentInterval):

• dom/ScriptExecutionContext.h:
• inspector/InspectorInstrumentation.cpp:

(WebCore::InspectorInstrumentation::didInstallTimerImpl):

• inspector/InspectorInstrumentation.h:

(WebCore::InspectorInstrumentation::didInstallTimer):

• inspector/InspectorTimelineAgent.cpp:

(WebCore::InspectorTimelineAgent::didInstallTimer):

• inspector/InspectorTimelineAgent.h:
• inspector/TimelineRecordFactory.cpp:

(WebCore::TimelineRecordFactory::createTimerInstallData):

• inspector/TimelineRecordFactory.h:
• page/DOMTimer.cpp:

(WebCore::shouldForwardUserGesture):
(WebCore::userGestureTokenToForward):
(WebCore::DOMTimer::DOMTimer):
(WebCore::DOMTimer::install):
(WebCore::DOMTimer::intervalClampedToMinimum):
(WebCore::DOMTimer::alignedFireTime):

• page/DOMTimer.h:
• page/DOMWindow.cpp:

(WebCore::DOMWindow::setTimeout):
(WebCore::DOMWindow::setInterval):

• page/Page.cpp:

(WebCore::Page::setTimerThrottlingState):
(WebCore::Page::setDOMTimerAlignmentIntervalIncreaseLimit):
(WebCore::Page::updateDOMTimerAlignmentInterval):

• page/Page.h:

(WebCore::Page::domTimerAlignmentInterval):

• page/Settings.cpp:

(WebCore::Settings::setMinimumDOMTimerInterval):

• page/Settings.h:

(WebCore::Settings::minimumDOMTimerInterval):

• page/SuspendableTimer.h:

(WebCore::SuspendableTimer::startRepeating):
(WebCore::SuspendableTimer::startOneShot):
(WebCore::SuspendableTimer::augmentFireInterval):
(WebCore::SuspendableTimer::augmentRepeatInterval):

• platform/Timer.cpp:

(WebCore::TimerBase::setNextFireTime):

• platform/Timer.h:

(WebCore::TimerBase::alignedFireTime):

• testing/InternalSettings.cpp:

(WebCore::InternalSettings::setMinimumTimerInterval):

• testing/InternalSettings.h:
• testing/Internals.cpp:

(WebCore::Internals::isTimerThrottled):

• workers/WorkerGlobalScope.cpp:

(WebCore::WorkerGlobalScope::setTimeout):
(WebCore::WorkerGlobalScope::setInterval):

Source/WebKit2:

• UIProcess/WebProcessPool.cpp:

(WebKit::WebProcessPool::updateHiddenPageThrottlingAutoIncreaseLimit):

• WebProcess/WebPage/WebPage.h:

(WebKit::WebPage::setHiddenPageDOMTimerThrottlingIncreaseLimit):

• WebProcess/WebProcess.cpp:

(WebKit::WebProcess::setHiddenPageDOMTimerThrottlingIncreaseLimit):

• WebProcess/WebProcess.h:
• WebProcess/WebProcess.messages.in:

9:10 AM CoordinatedGraphicsSystem edited by Konstantin Tokarev

USE(UI_SIDE_COMPOSITING) is USE(COORDINATED_GRAPHICS) now (diff)

9:08 AM Changeset in webkit [213518] by commit-queue@webkit.org

• 6 edits in trunk

W3C importer should be able to update the import expectations file
​https://bugs.webkit.org/show_bug.cgi?id=168037

LayoutTests/imported/w3c:

Patch by Youenn Fablet <​youenn@apple.com> on 2017-03-07
Reviewed by Ryosuke Niwa.

• resources/import-expectations.json:

Tools:

Patch by Youenn Fablet <​youennf@gmail.com> on 2017-03-07
Reviewed by Ryosuke Niwa.

Changing import expectations from an array to a map.
Marking all test paths as import and updating import expectations file accordingly.

• Scripts/webkitpy/w3c/test_downloader.py:

(TestDownloader.init):
(TestDownloader._init_paths_from_expectations):
(TestDownloader):
(TestDownloader.update_import_expectations):

• Scripts/webkitpy/w3c/test_importer.py:

(TestImporter.do_import):

• Scripts/webkitpy/w3c/test_importer_unittest.py:

9:03 AM Changeset in webkit [213517] by Chris Dumez

• 20 edits
  1 copy
  2 adds
  2 deletes in trunk

Align initEvent / initCustomEvent / initMessageEvent with the latest specification
​https://bugs.webkit.org/show_bug.cgi?id=169176

Reviewed by Alex Christensen.

LayoutTests/imported/w3c:

Re-sync web-platform tests from upstream after:

• ​https://github.com/w3c/web-platform-tests/pull/5043
• ​https://github.com/w3c/web-platform-tests/pull/5044

• web-platform-tests/dom/events/CustomEvent-expected.txt:
• web-platform-tests/dom/events/CustomEvent.html:
• web-platform-tests/dom/events/Event-initEvent-expected.txt:
• web-platform-tests/dom/events/Event-initEvent.html:
• web-platform-tests/dom/interfaces-expected.txt:
• web-platform-tests/dom/interfaces.html:
• web-platform-tests/html/dom/interfaces-expected.txt:
• web-platform-tests/html/dom/interfaces.html:
• web-platform-tests/html/dom/resources/interfaces.idl: Copied from LayoutTests/imported/w3c/web-platform-tests/html/dom/interfaces.html.
• web-platform-tests/html/dom/resources/untested-interfaces.idl: Added.
• web-platform-tests/html/webappapis/scripting/events/messageevent-constructor-expected.txt: Removed.
• web-platform-tests/html/webappapis/scripting/events/messageevent-constructor.html: Removed.
• web-platform-tests/html/webappapis/scripting/events/messageevent-constructor.https-expected.txt:
• web-platform-tests/html/webappapis/scripting/events/messageevent-constructor.https.html:

Source/WebCore:

Align initEvent / initCustomEvent / initMessageEvent with the latest specification
after:

• ​https://github.com/whatwg/dom/pull/417
• ​https://github.com/whatwg/html/pull/2410

In particular, the following changes were made:

• initEvent: The length property now properly returns 1 instead of 3 as only the first parameter is mandatory. We were already behaving correcting the the length property value was wrong because we forgot to drop a hack from the bindings generator.
• initCustomEvent: Make all parameters except the first optional. Previously, all parameters were mandatory so this is safe.
• initMessageEvent: Drop the custom code and mark the first parameter as mandatory. A side effect of dropping the custom code is that null is no longer considered as valid input for the last parameter. The parameter is of type sequence<> and the new behavior is consistent with the specification and Firefox. If it turns out to break existing content, I'll make the parameter nullable in a follow-up.

No new tests, updated existing tests.

• bindings/js/JSMessageEventCustom.cpp:
• bindings/scripts/CodeGeneratorJS.pm:

(GeneratePropertiesHashTable):

• dom/CustomEvent.idl:
• dom/MessageEvent.idl:

LayoutTests:

Updated existing tests to reflect behavior change.

• fast/events/init-events-expected.txt:
• fast/events/script-tests/init-events.js:
• fast/eventsource/eventsource-attribute-listeners.html:

9:02 AM Changeset in webkit [213516] by clopez@igalia.com

• 3 edits in trunk/LayoutTests

[GTK][Wayland] Update list of test failing on the Wayland release test bot.

Unreviewed test gardening.

• platform/gtk-wayland/TestExpectations: Update list of test failing on the Wayland release test bot.
• platform/gtk/TestExpectations: media/video-played-collapse.html crashes sometimes.

8:54 AM Changeset in webkit [213515] by Antti Koivisto

• 4 edits in trunk/Source/WebCore

Differentiate between pending head and body stylesheets in Style::Scope
​https://bugs.webkit.org/show_bug.cgi?id=169277

Reviewed by Andreas Kling.

Split pending stylesheet node set into separate sets for head and body elements and processing instructions.

This tightens typing and will also be useful later.

• style/StyleScope.cpp:

(WebCore::Style::Scope::~Scope):
(WebCore::Style::Scope::addPendingSheet):
(WebCore::Style::Scope::removePendingSheet):
(WebCore::Style::Scope::didRemovePendingStylesheet):
(WebCore::Style::Scope::hasPendingSheet):
(WebCore::Style::Scope::hasPendingSheetInBody):
(WebCore::Style::Scope::hasProcessingInstructionWithPendingSheet): Deleted.

• style/StyleScope.h:

(WebCore::Style::Scope::hasPendingSheet): Deleted.
(WebCore::Style::Scope::hasPendingSheets): Deleted.

• style/StyleTreeResolver.cpp:

(WebCore::Style::hasLoadingStylesheet):

Just test for body stylesheets.

(WebCore::Style::TreeResolver::resolve):

Treat all before-body stylesheets uniformly.

8:35 AM CoordinatedGraphicsSystem edited by Konstantin Tokarev

Updated TiledBackingStore and CoordinatedTile description to reflect … (diff)

8:23 AM Changeset in webkit [213514] by commit-queue@webkit.org

• 3 edits
  2 adds in trunk

[Modern Media Controls] Setting a valid source after an invalid one retains the invalid placard
​https://bugs.webkit.org/show_bug.cgi?id=169280
<rdar://problem/30876078>

Patch by Antoine Quint <Antoine Quint> on 2017-03-07
Reviewed by Jon Lee.

Source/WebCore:

We need to track when a new load start to see if we might have recovered from an error
and hide the "invalid" placard.

Test: media/modern-media-controls/placard-support/placard-support-error-recover.html

• Modules/modern-media-controls/media/placard-support.js:

(PlacardSupport.prototype.get mediaEvents):

LayoutTests:

Add a new test that checks that we know to remove the "invalid" placard if a new source is
set and media starts loading again.

• media/modern-media-controls/placard-support/placard-support-error-recover-expected.txt: Added.
• media/modern-media-controls/placard-support/placard-support-error-recover.html: Added.

6:45 AM Changeset in webkit [213513] by clopez@igalia.com

• 2 edits in trunk/LayoutTests

[GTK] Mark media/video-buffered.html as flaky.

Unreviewed test gardening.

• platform/gtk/TestExpectations:

5:16 AM Changeset in webkit [213512] by Manuel Rego Casasnovas

• 3 edits in trunk/Tools

Add pdr to the rendering watchlist
​https://bugs.webkit.org/show_bug.cgi?id=167298

Patch by Philip Rogers <​pdr@google.com> on 2017-03-07
Reviewed by Andreas Kling.

• Scripts/webkitpy/common/config/contributors.json: Switch to ​pdr+autocc@chromium.org
• Scripts/webkitpy/common/config/watchlist: Add pdr to the rendering watchlist.

5:05 AM Changeset in webkit [213511] by Manuel Rego Casasnovas

• 2 edits in trunk/LayoutTests

[css-grid] Mark a few tests from the W3C suite as pass after r213480
​https://bugs.webkit.org/show_bug.cgi?id=169270

Unreviewed test gardening.

r213480 was porting some Blink patches that makes these tests to pass now.
Check the following bugs for more information:

• ​http://webkit.org/b/169197
• ​http://webkit.org/b/169198

• TestExpectations: Mark grid-minimum-size-grid-items-007.xht and

grid-minimum-size-grid-items-009.xht as passing.
Keep grid-items-sizing-alignment-001.html as failure but now for a different issue
(see ​http://webkit.org/b/169271).

4:46 AM Changeset in webkit [213510] by clopez@igalia.com

• 2 edits in trunk/LayoutTests

[GTK] ECDH tests from imported/w3c/web-platform-tests/WebCryptoAPI/generateKey fail.

Unreviewed test gardening.

• platform/gtk/TestExpectations:

2:15 AM Changeset in webkit [213509] by mario@webkit.org

• 2 edits in trunk/Tools

Unreviewed. Removed myself from the Accessibility watch list

Patch by Mario Sanchez Prada <​mario@webkit.org> on 2017-03-07

• Scripts/webkitpy/common/config/watchlist: Removed myself.

1:51 AM Changeset in webkit [213508] by aestes@apple.com

• 3 edits in trunk/Source/WebCore

REGRESSION (r213412): JPEG premultiplication tests fail under GuardMalloc
​https://bugs.webkit.org/show_bug.cgi?id=169266

Reviewed by Tim Horton.

r213412 added functions to create a CGImageRef from a canvas image buffer, which were used
to create data: URLs and blobs. If JPEG premultiplication is applied, though,
WebCore::cgImage() would return an image with a data provider pointing to stack memory.

I fixed a similar issue in ImageBuffer::toCGImage() by leaking the reference to a
Uint8ClampedArray then creating a CGDataProviderRef with a releaseData function that adopts
the leaked reference.

We could take that approach in cgImage() too by allocating the premultiplied data buffer on
the heap then freeing it with a releaseData function, but it's simpler to refactor
toCGImage()/cgImage() to return an encoded image as a CFDataRef instead of a CFImageRef.
This ensures that a CGDataProviderRef never outlives the data it points to.

Covered by existing tests.

• platform/graphics/ImageBuffer.h: Renamed toCGImage() to toCFData().
• platform/graphics/cg/ImageBufferCG.cpp:

(WebCore::dataURL): Changed to take a CFDataRef.
(WebCore::dataVector): Renamed from data(). Changed to take a CFDataRef.
(WebCore::ImageBuffer::toDataURL): Changed to call toCFData().
(WebCore::ImageBuffer::toData): Ditto.
(WebCore::ImageBuffer::toCFData): Changed to return a CFDataRef after encoding the
CGImageRef that was previously returned.
(WebCore::cfData): Ditto.
(WebCore::dataURL): Changed to call cfData().
(WebCore::data): Ditto.
(WebCore::ImageBuffer::toCGImage): Renamed to ImageBuffer::toCFData().
(WebCore::cgImage): Renamed to WebCore::cfData().

12:47 AM Changeset in webkit [213507] by mmaxfield@apple.com

• 2 edits in trunk/Source/WebCore

Test fix after r213505
​https://bugs.webkit.org/show_bug.cgi?id=169267

Unreviewed.

• platform/graphics/cocoa/FontCacheCoreText.cpp:

(WebCore::preparePlatformFont):

Mar 6, 2017:

11:38 PM Changeset in webkit [213506] by sbarati@apple.com

• 7 edits
  1 add in trunk

WebAssembly: Implement the WebAssembly.instantiate API
​https://bugs.webkit.org/show_bug.cgi?id=165982
<rdar://problem/29760110>

Reviewed by Keith Miller.

JSTests:

• wasm/js-api/web-assembly-instantiate.js: Added.

(assert.eq.async.test):
(assert.eq):
(assert.truthy.async.test):
(assert.truthy):

Source/JavaScriptCore:

This patch is a straight forward implementation of the WebAssembly.instantiate
API: ​https://github.com/WebAssembly/design/blob/master/JS.md#webassemblyinstantiate

I implemented the API in a synchronous manner. We should make it
asynchronous: ​https://bugs.webkit.org/show_bug.cgi?id=169187

• wasm/JSWebAssembly.cpp:

(JSC::webAssemblyCompileFunc):
(JSC::webAssemblyInstantiateFunc):
(JSC::JSWebAssembly::finishCreation):

• wasm/js/WebAssemblyInstanceConstructor.cpp:

(JSC::constructJSWebAssemblyInstance):
(JSC::WebAssemblyInstanceConstructor::createInstance):

• wasm/js/WebAssemblyInstanceConstructor.h:
• wasm/js/WebAssemblyModuleConstructor.cpp:

(JSC::constructJSWebAssemblyModule):
(JSC::WebAssemblyModuleConstructor::createModule):

• wasm/js/WebAssemblyModuleConstructor.h:

11:30 PM Changeset in webkit [213505] by mmaxfield@apple.com

• 6 edits
  2 adds in trunk

Apply well-known-axis variation values at the right time in preparePlatformFont()
​https://bugs.webkit.org/show_bug.cgi?id=168896

Reviewed by Jon Lee.

Source/WebCore:

Simply plumb the FontSelectionRequest to the place where font variations are implemented.

Test: fast/text/variations/font-selection-properties.html

• platform/graphics/FontCache.h:
• platform/graphics/cocoa/FontCacheCoreText.cpp:

(WebCore::preparePlatformFont):
(WebCore::fontWithFamily):
(WebCore::FontCache::createFontPlatformData):
(WebCore::FontCache::systemFallbackForCharacters):

• platform/graphics/mac/FontCustomPlatformData.cpp:

(WebCore::FontCustomPlatformData::fontPlatformData):

LayoutTests:

• fast/text/variations/font-selection-properties-expected.html: Added.
• fast/text/variations/font-selection-properties.html: Added.

11:19 PM Changeset in webkit [213504] by aakash_jain@apple.com

• 4 edits in trunk/Source/WebKit2

Enable SUPPORTS_TEXT_BASED_API in WebKit2 for iOS
​https://bugs.webkit.org/show_bug.cgi?id=169233

Reviewed by Alexey Proskuryakov.

• Configurations/Base.xcconfig: Enable SUPPORTS_TEXT_BASED_API.
• Configurations/WebKit.xcconfig: Pass information to TAPI about reexporting WebKitLegacy and few extra headers.
• WebKit2.xcodeproj/project.pbxproj: Run scripts which are run for installhdrs phase for installapi phase as well.

11:01 PM Changeset in webkit [213503] by Yusuke Suzuki

• 2 edits in trunk/Tools

Add Fujii Hironori to contributor's list
​https://bugs.webkit.org/show_bug.cgi?id=169261

Patch by Fujii Hironori <Fujii Hironori> on 2017-03-06
Reviewed by Yusuke Suzuki.

Add myself to the contributor's lists so that my e-mail autocompletes for CC

• Scripts/webkitpy/common/config/contributors.json:

10:24 PM Changeset in webkit [213502] by mmaxfield@apple.com

• 3 edits in trunk/Source/WebCore

Unreviewed post-review fixup after r213464
​https://bugs.webkit.org/show_bug.cgi?id=169255

• platform/graphics/FontCache.h:

(WebCore::FontDescriptionKey::FontDescriptionKey):
(WebCore::FontDescriptionKey::operator==):
(WebCore::FontDescriptionKey::computeHash):
(WebCore::FontDescriptionKey::makeFlagsKey):

• platform/graphics/cocoa/FontCacheCoreText.cpp:

(WebCore::computeNecessarySynthesis):

10:10 PM Changeset in webkit [213501] by Brent Fulgham

• 3 edits
  2 adds in trunk

Validate DOM after potentially destructive actions during parser insert operations
​https://bugs.webkit.org/show_bug.cgi?id=169222
<rdar://problem/30689729>

Reviewed by Ryosuke Niwa.

Source/WebCore:

Do not perform an insert operation if the next child's parent is no longer
part of the tree. This can happen if JavaScript runs during node removal
events and modifies the contents of the document.

This patch was inspired by a similar Blink change by Marius Mlynski:
<​https://src.chromium.org/viewvc/blink?view=revision&revision=200690>

Tests: fast/parser/scriptexec-during-parserInsertBefore.html

• html/parser/HTMLConstructionSite.cpp:

(WebCore::executeReparentTask):
(WebCore::executeInsertAlreadyParsedChildTask):

LayoutTests:

This change merges a Blink test case from:
<​https://src.chromium.org/viewvc/blink?view=revision&revision=200690>

• fast/parser/scriptexec-during-parserInsertBefore-expected.txt: Added.
• fast/parser/scriptexec-during-parserInsertBefore.html: Added.

9:44 PM Changeset in webkit [213500] by msaboff@apple.com

• 2 edits in trunk/Source/WebKit/mac

Unreviewed build fix to add
-isystem $(SDKROOT)/System/Library/Frameworks/System.framework/PrivateHeaders
for objective C++ files.

• Configurations/WebKitLegacy.xcconfig:

9:37 PM Changeset in webkit [213499] by mmaxfield@apple.com

• 6 edits in trunk

Update isEmojiGroupCandidate() to the latest version of Unicode
​https://bugs.webkit.org/show_bug.cgi?id=168198

Reviewed by Jon Lee.

Source/WebCore:

In the latest version of Unicode, many more code points are candidates for emoji groups.
Therefore, isEmojiGroupCandidate() should be made more permissive. This way, the function
is more future-proof.

Test: editing/deleting/delete-emoji.html

• platform/text/CharacterProperties.h:

(WebCore::icuLibraryUnderstandsSupplementalSymbolsAndPictographs):
(WebCore::isEmojiGroupCandidate):

LayoutTests:

• platform/ios-simulator/editing/deleting/delete-emoji-expected.txt:
• platform/mac/editing/deleting/delete-emoji-expected.txt:
• editing/deleting/delete-emoji.html:

9:15 PM Changeset in webkit [213498] by mitz@apple.com

• 3 edits in trunk/Source/WebKit2

[Cocoa] Expose API::InjectedBundle::EditorClient::didChange via the Objective-C bundle SPI
​https://bugs.webkit.org/show_bug.cgi?id=169223

Reviewed by Tim Horton.

• WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInEditingDelegate.h: Declared new delegate method -_webProcessPlugInBrowserContextControllerDidChangeByEditing:.
• WebProcess/InjectedBundle/API/mac/WKWebProcessPlugInBrowserContextController.mm:

(-[WKWebProcessPlugInBrowserContextController _setEditingDelegate:]): Added an override

of API::InjectedBundle::EditorClient::didChange that calls the new delegate method.

8:44 PM Changeset in webkit [213497] by commit-queue@webkit.org

• 3 edits in trunk/Source/ThirdParty/libwebrtc

Bring back WebKit specific changes to disable temporarily libwebrtc video adaptation
​https://bugs.webkit.org/show_bug.cgi?id=169229

Patch by Youenn Fablet <​youenn@apple.com> on 2017-03-06
Reviewed by Alex Christensen.

• Source/webrtc/modules/video_coding/video_sender.cc: disabling frame dropping.
• Source/webrtc/video/vie_encoder.cc: disabling resolution decrease based on CPU overuse.

8:39 PM Changeset in webkit [213496] by msaboff@apple.com

• 2 edits in trunk/Source/WebKit2

Unreviewed build fix after r213492.

• Configurations/Base.xcconfig:

8:22 PM Changeset in webkit [213495] by aakash_jain@apple.com

• 3 edits in trunk/Source/WebKit2

Add WK_CLASS_AVAILABLE to _WKLinkIconParameters and _WKWebViewPrintFormatter
​https://bugs.webkit.org/show_bug.cgi?id=169225

Reviewed by Tim Horton.

• UIProcess/API/Cocoa/_WKLinkIconParameters.h:
• UIProcess/_WKWebViewPrintFormatter.h:

8:21 PM Changeset in webkit [213494] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebCore

Use default configuration for libwebrtc peerconnection
​https://bugs.webkit.org/show_bug.cgi?id=169239

Patch by Youenn Fablet <​youenn@apple.com> on 2017-03-06
Reviewed by Alex Christensen.

• Modules/mediastream/libwebrtc/LibWebRTCPeerConnectionBackend.cpp:

(WebCore::configurationFromMediaEndpointConfiguration): Using the default configuration instead of the aggressive one.

8:17 PM Changeset in webkit [213493] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebCore

[CMake] SN-DBS fails to build: Cannot open include file: 'WebCoreTestSupportPrefix.h'
​https://bugs.webkit.org/show_bug.cgi?id=169244

Patch by Fujii Hironori <Fujii Hironori> on 2017-03-06
Reviewed by Alex Christensen.

A distributed build system SN-DBS can not find
WebCoreTestSupportPrefix.h without an include path to it.

• CMakeLists.txt: Add 'WebCore/testing/js' to include paths.

7:37 PM Changeset in webkit [213492] by msaboff@apple.com

• 2 edits in trunk/Source/WebKit2

Unreviewed build fix after r213483.

• Configurations/Base.xcconfig:

7:11 PM Changeset in webkit [213491] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebCore

[cairo] error C2065: 'quality': undeclared identifier since r213412
​https://bugs.webkit.org/show_bug.cgi?id=169240

Patch by Fujii Hironori <Fujii Hironori> on 2017-03-06
Reviewed by Ryosuke Niwa.

• platform/graphics/cairo/ImageBufferCairo.cpp:

(WebCore::ImageBuffer::toDataURL): Name the unnamed second argument 'quality'.

7:09 PM Changeset in webkit [213490] by Brent Fulgham

• 2 edits in trunk/Source/WebKit2

[Mac][WK2] Support new CoreMedia routing features
​https://bugs.webkit.org/show_bug.cgi?id=169241
<rdar://problem/30077969>

Reviewed by Alexey Proskuryakov.

• WebProcess/com.apple.WebProcess.sb.in:

6:56 PM Changeset in webkit [213489] by jiewen_tan@apple.com

• 19 edits
  6 copies
  15 adds in trunk

[WebCrypto] Implement ECDH GenerateKey operation
​https://bugs.webkit.org/show_bug.cgi?id=169093
<rdar://problem/23789585>

Reviewed by Brent Fulgham.

LayoutTests/imported/w3c:

• web-platform-tests/WebCryptoAPI/generateKey/failures_ECDH.worker-expected.txt:
• web-platform-tests/WebCryptoAPI/generateKey/successes_ECDH.worker-expected.txt:
• web-platform-tests/WebCryptoAPI/generateKey/test_failures_ECDH-expected.txt:
• web-platform-tests/WebCryptoAPI/generateKey/test_successes_ECDH-expected.txt:

Source/WebCore:

This patch implements GenerateKey operation of ECDH according to:
​https://www.w3.org/TR/WebCryptoAPI/#ecdh-operations.
Note: Sad that we are not able to support P-521 at this moment due
to lack of necessary support in the underlying crypto library.

Tests: crypto/subtle/ec-generate-key-malformed-parameters.html

crypto/subtle/ecdh-generate-key-extractable.html
crypto/subtle/ecdh-generate-key-p256.html
crypto/subtle/ecdh-generate-key-p384.html
crypto/subtle/ecdh-generate-key-single-usage.html
crypto/workers/subtle/ec-generate-key.html

• CMakeLists.txt:
• DerivedSources.make:
• PlatformGTK.cmake:
• PlatformMac.cmake:
• WebCore.xcodeproj/project.pbxproj:
• bindings/js/JSCryptoKeyCustom.cpp:

(WebCore::JSCryptoKey::algorithm):

• bindings/js/JSSubtleCryptoCustom.cpp:

(WebCore::normalizeCryptoAlgorithmParameters):
(WebCore::jsSubtleCryptoFunctionGenerateKeyPromise):
Add support for ECDH.

• bindings/js/SerializedScriptValue.cpp:

(WebCore::CloneSerializer::write):
Structured clonable will be added later on.

• crypto/CommonCryptoUtilities.h:

Add SPI for EC.

• crypto/CryptoAlgorithmParameters.h:
• crypto/CryptoKey.h:
• crypto/algorithms/CryptoAlgorithmECDH.cpp: Added.

(WebCore::CryptoAlgorithmECDH::create):
(WebCore::CryptoAlgorithmECDH::identifier):
(WebCore::CryptoAlgorithmECDH::generateKey):

• crypto/algorithms/CryptoAlgorithmECDH.h: Added.
• crypto/gnutls/CryptoKeyECGnuTLS.cpp: Added.

(WebCore::CryptoKeyEC::~CryptoKeyEC):
(WebCore::CryptoKeyEC::platformGeneratePair):

• crypto/keys/CryptoKeyEC.cpp: Added.

(WebCore::CryptoKeyEC::CryptoKeyEC):
(WebCore::CryptoKeyEC::generatePair):
(WebCore::CryptoKeyEC::buildAlgorithm):
(WebCore::CryptoKeyEC::exportData):

• crypto/keys/CryptoKeyEC.h: Added.

(WebCore::EcKeyAlgorithm::EcKeyAlgorithm):
(WebCore::EcKeyAlgorithm::namedCurve):

• crypto/mac/CryptoAlgorithmRegistryMac.cpp:

(WebCore::CryptoAlgorithmRegistry::platformRegisterAlgorithms):
Add support for ECDH.

• crypto/mac/CryptoKeyECMac.cpp: Added.

(WebCore::CryptoKeyEC::~CryptoKeyEC):
(WebCore::CryptoKeyEC::platformGeneratePair):

• crypto/parameters/CryptoAlgorithmEcKeyParams.h: Added.
• crypto/parameters/EcKeyParams.idl: Added.

LayoutTests:

• crypto/subtle/ec-generate-key-malformed-parameters-expected.txt: Added.
• crypto/subtle/ec-generate-key-malformed-parameters.html: Added.
• crypto/subtle/ecdh-generate-key-extractable-expected.txt: Added.
• crypto/subtle/ecdh-generate-key-extractable.html: Added.
• crypto/subtle/ecdh-generate-key-p256-expected.txt: Added.
• crypto/subtle/ecdh-generate-key-p256.html: Added.
• crypto/subtle/ecdh-generate-key-p384-expected.txt: Added.
• crypto/subtle/ecdh-generate-key-p384.html: Added.
• crypto/subtle/ecdh-generate-key-single-usage-expected.txt: Added.
• crypto/subtle/ecdh-generate-key-single-usage.html: Added.
• crypto/workers/subtle/ec-generate-key-expected.txt: Added.
• crypto/workers/subtle/ec-generate-key.html: Added.
• crypto/workers/subtle/resources/ec-generate-key.js: Added.

6:54 PM Changeset in webkit [213488] by jmarcell@apple.com

• 6 edits in tags/Safari-604.1.8.1.2/Source

Versioning.

6:46 PM Changeset in webkit [213487] by jmarcell@apple.com

• 1 copy in tags/Safari-604.1.8.1.2

Tag Safari-604.1.8.1.2.

6:32 PM Changeset in webkit [213486] by Michael Catanzaro

• 2 edits in trunk/Source/WebCore

Unreviewed, fix unused parameter warning after r213464

• platform/graphics/freetype/FontCacheFreeType.cpp:

(WebCore::FontCache::getFontSelectionCapabilitiesInFamily):

6:31 PM Changeset in webkit [213485] by clopez@igalia.com

• 2 edits in trunk/Tools

[GTK] Mark WTF_Lock.ContendedLongSection and WTF_WordLock.ContendedLongSection as slow.

Unreviewed test gardening.

The ContendedShortSection version of this tests were already marked as slow.
And the ContendedLongSection version takes more or less the same time to run.
They cause time outs on the bot sometimes.

• Scripts/run-gtk-tests:

(TestRunner):

6:10 PM Changeset in webkit [213484] by sbarati@apple.com

• 2 edits in trunk/JSTests

Unreviewed. Fix test expected error message.

• wasm/js-api/element.js:

(assert.throws):

5:51 PM Changeset in webkit [213483] by msaboff@apple.com

• 18 edits in trunk

Take advantage of fast permissions switching of JIT memory for devices that support it
​https://bugs.webkit.org/show_bug.cgi?id=169155

Reviewed by Saam Barati.

Source/JavaScriptCore:

Start using the os_thread_self_restrict_rwx_to_XX() SPIs when available to
control access to JIT memory.

Had to update the Xcode config files to handle various build variations of
public and internal SDKs.

• Configurations/Base.xcconfig:
• Configurations/FeatureDefines.xcconfig:
• jit/ExecutableAllocator.cpp:

(JSC::FixedVMPoolExecutableAllocator::FixedVMPoolExecutableAllocator):
(JSC::FixedVMPoolExecutableAllocator::initializeSeparatedWXHeaps):

• jit/ExecutableAllocator.h:

(JSC::performJITMemcpy):

Source/WebCore:

Updated the Xcode config files to match what is in the JavaScriptCore ones.

• Configurations/Base.xcconfig:
• Configurations/FeatureDefines.xcconfig:
• Configurations/WebCore.xcconfig:

Source/WebCore/PAL:

Updated the Xcode config files to match what is in the JavaScriptCore ones.

• Configurations/FeatureDefines.xcconfig:

Source/WebKit/mac:

Updated the Xcode config files to match what is in the JavaScriptCore ones.

• Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

Updated the Xcode config files to match what is in the JavaScriptCore ones.

• Configurations/FeatureDefines.xcconfig:

Tools:

Updated the Xcode config files to match what is in the JavaScriptCore ones.

• TestWebKitAPI/Configurations/FeatureDefines.xcconfig:

5:39 PM Changeset in webkit [213482] by aakash_jain@apple.com

• 4 edits in trunk/Source

Make WKMenuItemIdentifiersPrivate.h private header
​https://bugs.webkit.org/show_bug.cgi?id=168981

Reviewed by Tim Horton.

Source/WebCore:

• platform/spi/mac/NSMenuSPI.h: NSUserInterfaceItemIdentification is in the public header in recent SDKs.

Source/WebKit2:

• WebKit2.xcodeproj/project.pbxproj: Made WKMenuItemIdentifiersPrivate.h private.

5:39 PM Changeset in webkit [213481] by ap@apple.com

• 2 edits in trunk/Source/WebKit2

Replace -sub_umbrella linker flag with a build setting
​https://bugs.webkit.org/show_bug.cgi?id=169146

Reviewed by Tim Horton.

• Configurations/WebKit.xcconfig:

5:29 PM Changeset in webkit [213480] by hyatt@apple.com

• 22 edits
  2 adds in trunk

REGRESSION: Block no longer shrinks to preferred width in this flex box layout
​https://bugs.webkit.org/show_bug.cgi?id=169203
<rdar://problem/30873895>

Reviewed by Simon Fraser.

Source/WebCore:

Added new test in css3/flexbox.

• css/StyleResolver.cpp:

(WebCore::StyleResolver::adjustRenderStyle):
(WebCore::StyleResolver::adjustStyleForAlignment):

• html/shadow/TextControlInnerElements.cpp:

(WebCore::TextControlInnerElement::resolveCustomStyle):
Resolve auto alignment values by adjusting the render style as needed. Make a helper
function for adjusting only alignment that can be called from the inner text control
custom style creation.

• rendering/GridTrackSizingAlgorithm.cpp:

(WebCore::GridTrackSizingAlgorithmStrategy::minSizeForChild):
Replaced items in grids should not stretch by default.

• rendering/RenderBox.cpp:

(WebCore::RenderBox::hasStretchedLogicalWidth):
Patched to properly check the default alignment for the child, making sure
that if it's a replacd item inside a grid, that the default is start and not
stretch.

• rendering/RenderBox.h:

(WebCore::RenderBox::selfAlignmentNormalBehavior):
Self-alignment function now takes an optional child argument, since the behavior
varies in grids depending on the child being replaced or not.

• rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::alignmentForChild):
Fixed to do the right thing when the child is anonymous.

(WebCore::RenderFlexibleBox::styleDidChange): Deleted.

• rendering/RenderFlexibleBox.h:

Deleted, since alignment changes are handled at the style diff level now.

• rendering/RenderFullScreen.h:

Patched the selfAlignmentNormalBehavior method to take an optional child argument.

• rendering/RenderGrid.cpp:

(WebCore::RenderGrid::styleDidChange):
(WebCore::RenderGrid::alignSelfForChild):
(WebCore::RenderGrid::justifySelfForChild):
(WebCore::RenderGrid::columnAxisPositionForChild):
(WebCore::RenderGrid::rowAxisPositionForChild):
(WebCore::RenderGrid::columnAxisOffsetForChild):
(WebCore::RenderGrid::rowAxisOffsetForChild):
(WebCore::defaultAlignmentIsStretch): Deleted.
(WebCore::defaultAlignmentChangedToStretchInRowAxis): Deleted.
(WebCore::defaultAlignmentChangedFromStretchInRowAxis): Deleted.
(WebCore::defaultAlignmentChangedFromStretchInColumnAxis): Deleted.
(WebCore::selfAlignmentChangedToStretchInRowAxis): Deleted.
(WebCore::selfAlignmentChangedFromStretchInRowAxis): Deleted.
(WebCore::selfAlignmentChangedFromStretchInColumnAxis): Deleted.

• rendering/RenderGrid.h:

Removed the alignment change logic in styleDidChange for grids, since style diffing handles
it now. Updated all selfAlignmentForNormalBehavior queries to pass in the child so that
replaced elements are handled properly.

• rendering/style/RenderStyle.h:

(WebCore::RenderStyle::overflowInlineDirection):
(WebCore::RenderStyle::overflowBlockDirection):
(WebCore::RenderStyle::setJustifySelfPosition):
New helpers used by grid and by adjustRenderStyle.

• style/StyleChange.cpp:

(WebCore::Style::determineChange):
If alignment or justification changes occur on a parent that could affect the child (e.g., align-items)
return Inherit so the child render styles get adjusted properly.

LayoutTests:

• css3/flexbox/column-inside-normal-block-preferred-width-expected.html: Added.
• css3/flexbox/column-inside-normal-block-preferred-width.html: Added.
• fast/css-grid-layout/grid-align-stretching-replaced-items-expected.txt:
• fast/css-grid-layout/grid-align-stretching-replaced-items.html:
• fast/repaint/align-items-change-expected.txt:
• fast/repaint/align-items-overflow-change-expected.txt:
• fast/repaint/justify-items-change-expected.txt:
• fast/repaint/justify-items-legacy-change-expected.txt:
• fast/repaint/justify-items-overflow-change-expected.txt:

4:20 PM Changeset in webkit [213479] by Lucas Forschler

• 2 edits in trunk/Tools

​https://bugs.webkit.org/show_bug.cgi?id=169234
torchmobile.com.cn is no longer a registered domain. These email addresses will bounce, so clean them up.

Reviewed by Alexey Proskuryakov.

• Scripts/webkitpy/common/config/contributors.json:

4:09 PM Changeset in webkit [213478] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebCore

ASSERTION FAILED: numberOfChannels == 2 in WebCore::RealtimeIncomingAudioSource::OnData
​https://bugs.webkit.org/show_bug.cgi?id=169224
<rdar://problem/30856811>

Patch by Youenn Fablet <​youenn@apple.com> on 2017-03-06
Reviewed by Alex Christensen.

• platform/mediastream/mac/RealtimeIncomingAudioSource.cpp:

(WebCore::RealtimeIncomingAudioSource::OnData): Updated assertion to allow 1 channel since we can handle it as well.

3:38 PM Changeset in webkit [213477] by Ryan Haddad

• 2 edits in trunk/LayoutTests

Mark inspector/worker/console-basic.html as flaky.
​https://bugs.webkit.org/show_bug.cgi?id=169228

Unreviewed test gardening.

• platform/mac/TestExpectations:

3:33 PM Changeset in webkit [213476] by Ryan Haddad

• 2 edits in trunk/LayoutTests

Mark scrollingcoordinator/ios/non-stable-viewport-scroll.html as flaky on ios-simulator.
​https://bugs.webkit.org/show_bug.cgi?id=168924

Unreviewed test gardening.

• platform/ios-simulator-wk2/TestExpectations:

3:29 PM Changeset in webkit [213475] by Ryan Haddad

• 2 edits in trunk/LayoutTests

Mark media/modern-media-controls/tracks-support/tracks-support-click-track-in-panel.html as flaky.
​https://bugs.webkit.org/show_bug.cgi?id=169159

Unreviewed test gardening.

• platform/mac/TestExpectations:

3:24 PM Changeset in webkit [213474] by Ryan Haddad

• 2 edits in trunk/LayoutTests

Mark media/modern-media-controls/tracks-support/tracks-support-show-panel-after-dragging-controls.html as flaky.
​https://bugs.webkit.org/show_bug.cgi?id=169158

Unreviewed test gardening.

• platform/mac/TestExpectations:

3:07 PM Changeset in webkit [213473] by Chris Dumez

• 9 edits
  2 adds in trunk

[iOS] Throttle CSS animations to 30fps in low power mode
​https://bugs.webkit.org/show_bug.cgi?id=169138
<rdar://problem/30837805>

Reviewed by Said Abou-Hallawa.

Source/WebCore:

Throttle software CSS animations to 30fps in low power mode on iOS
to save battery.

Test: fast/animation/css-animation-throttling-lowPowerMode.html

• page/Page.cpp:

(WebCore::Page::handleLowModePowerChange):

• page/animation/CSSAnimationController.cpp:

(WebCore::CSSAnimationControllerPrivate::CSSAnimationControllerPrivate):
(WebCore::CSSAnimationControllerPrivate::updateAnimationTimer):
(WebCore::CSSAnimationControllerPrivate::updateThrottlingState):
(WebCore::CSSAnimationControllerPrivate::animationInterval):
(WebCore::CSSAnimationControllerPrivate::beginAnimationUpdateTime):
(WebCore::CSSAnimationControllerPrivate::beginAnimationUpdate):
(WebCore::CSSAnimationController::updateThrottlingState):
(WebCore::CSSAnimationController::animationInterval):

• page/animation/CSSAnimationController.h:
• page/animation/CSSAnimationControllerPrivate.h:
• testing/Internals.cpp:

(WebCore::Internals::animationsInterval):

• testing/Internals.h:
• testing/Internals.idl:

LayoutTests:

Add layout test coverage.

• fast/animation/css-animation-throttling-lowPowerMode-expected.txt: Added.
• fast/animation/css-animation-throttling-lowPowerMode.html: Added.

3:07 PM Changeset in webkit [213472] by Csaba Osztrogonác

• 2 edits in trunk/Source/JavaScriptCore

REGRESSION(r212778): It made 400 tests crash on AArch64 Linux
​https://bugs.webkit.org/show_bug.cgi?id=168502

Reviewed by Filip Pizlo.

• heap/RegisterState.h: Use setjmp code path on AArch64 Linux too to fix crashes.

3:06 PM Changeset in webkit [213471] by mrajca@apple.com

• 7 edits in trunk

Media: notify clients when the user never plays a media element that was prevented from auto-playing
​https://bugs.webkit.org/show_bug.cgi?id=169150

Reviewed by Alex Christensen.

Source/WebCore:

Added API tests.

• html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::mediaPlayerTimeChanged):
(WebCore::HTMLMediaElement::stopWithoutDestroyingMediaPlayer):

• page/AutoplayEvent.h:

Source/WebKit2:

• UIProcess/API/C/WKPageUIClient.h:

Tools:

• TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:

(TEST): Added.

2:56 PM Changeset in webkit [213470] by achristensen@apple.com

• 2 edits in trunk/Source/WebCore

Refactor ContentExtensionParser
​https://bugs.webkit.org/show_bug.cgi?id=169214

Reviewed by Brady Eidson.

No change in behavior, as verified by existing API tests.
This will make it easier to use getStringList for other things in coming patches.

• contentextensions/ContentExtensionParser.cpp:

(WebCore::ContentExtensions::getStringList):
(WebCore::ContentExtensions::getDomainList):

2:55 PM Changeset in webkit [213469] by achristensen@apple.com

• 11 edits in trunk

Fix URLs relative to file URLs with paths beginning with Windows drive letters
​https://bugs.webkit.org/show_bug.cgi?id=169178

Reviewed by Tim Horton.

LayoutTests/imported/w3c:

• web-platform-tests/url/a-element-expected.txt:
• web-platform-tests/url/a-element-xhtml-expected.txt:
• web-platform-tests/url/url-constructor-expected.txt:

Source/WebCore:

Windows drives in file URLs can begin with windows drive letters, such as ​file:///C:/
which should not be removed when making other URLs relative to them.
See ​https://url.spec.whatwg.org/#file-slash-state

Covered by new API tests and newly passing web-platform-tests.

• platform/URLParser.cpp:

(WebCore::URLParser::copyBaseWindowsDriveLetter):
(WebCore::URLParser::copyASCIIStringUntil):
(WebCore::URLParser::parse):

• platform/URLParser.h:

Tools:

• TestWebKitAPI/Tests/WebCore/URLParser.cpp:

(TestWebKitAPI::TEST_F):

LayoutTests:

• fast/url/relative-win-expected.txt:

Some tests pass now. localhost should indeed be removed according to the latest spec.

2:46 PM Changeset in webkit [213468] by achristensen@apple.com

• 3 edits in trunk/Source/ThirdParty/libwebrtc

Fix Production libwebrtc build after r213418
​https://bugs.webkit.org/show_bug.cgi?id=169217
<rdar://problem/30876775>

Reviewed by Tim Horton.

• Source/webrtc/base/checks.h:
• libwebrtc.xcodeproj/project.pbxproj:

MakeCheckOpString was a weak export, and it wasn't needed.
There is an internal build that checks for weak exports and fails if there is one.
Run the check-for-weak-vtables-and-externals script for libwebrtc.dylib like we do for the other frameworks.

2:03 PM Changeset in webkit [213467] by commit-queue@webkit.org

• 29 edits
  4 adds in trunk

op_get_by_id_with_this should use inline caching
​https://bugs.webkit.org/show_bug.cgi?id=162124

Patch by Caio Lima <Caio Lima> on 2017-03-06
Reviewed by Saam Barati.

JSTests:

• microbenchmarks/super-getter.js: Added.

(A.prototype.get f):
(A):
(B.prototype.get f):
(B):

• stress/super-force-ic-fail.js: Added.

(let.assert):
(let.aObj.get foo):
(let.obj.jaz):
(let.bObj.get foo):
(let.obj2.foo):

• stress/super-get-by-id.js: Added.

(assert):
(Base):
(Base.prototype.get name):
(Base.prototype.set name):
(Subclass.prototype.get name):
(Subclass):
(getterName):
(getterValue):
(PolymorphicSubclass.prototype.get value):
(PolymorphicSubclass):
(i.let.BaseCode):
(i.get value):
(MegamorphicSubclass.prototype.get value):
(MegamorphicSubclass):
(let.subObj.get value):
(i.catch):
(subObj.get value):
(BaseException):
(BaseException.prototype.get name):
(SubclassException.prototype.get name):
(SubclassException):
(prototype.foo):
(prototype.get name):
(SubclassExceptionComplex.prototype.get name):
(SubclassExceptionComplex):

• stress/super-getter-reset-ic.js: Added.

(let.assert):
(let.B.f):

Source/JavaScriptCore:

This patch is enabling inline cache for op_get_by_id_with_this in all
tiers. It means that operations using super.member are going to
be able to be optimized by PIC. To enable it, we introduced a new
member of StructureStubInfo.patch named thisGPR, created a new class
to manage the IC named JITGetByIdWithThisGenerator and changed
PolymorphicAccess.regenerate that uses StructureStubInfo.patch.thisGPR
to decide the correct this value on inline caches.
With inline cached enabled, super.member are ~4.5x faster,
according microbenchmarks.

• bytecode/AccessCase.cpp:

(JSC::AccessCase::generateImpl):

• bytecode/PolymorphicAccess.cpp:

(JSC::PolymorphicAccess::regenerate):

• bytecode/PolymorphicAccess.h:
• bytecode/StructureStubInfo.cpp:

(JSC::StructureStubInfo::reset):

• bytecode/StructureStubInfo.h:
• dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode):

• dfg/DFGJITCompiler.cpp:

(JSC::DFG::JITCompiler::link):

• dfg/DFGJITCompiler.h:

(JSC::DFG::JITCompiler::addGetByIdWithThis):

• dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileIn):

• dfg/DFGSpeculativeJIT.h:

(JSC::DFG::SpeculativeJIT::callOperation):

• dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::cachedGetByIdWithThis):
(JSC::DFG::SpeculativeJIT::compile):

• dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::cachedGetByIdWithThis):
(JSC::DFG::SpeculativeJIT::compile):

• ftl/FTLLowerDFGToB3.cpp:

(JSC::FTL::DFG::LowerDFGToB3::compileGetByIdWithThis):
(JSC::FTL::DFG::LowerDFGToB3::compileIn):
(JSC::FTL::DFG::LowerDFGToB3::getByIdWithThis):

• jit/CCallHelpers.h:

(JSC::CCallHelpers::setupArgumentsWithExecState):

• jit/ICStats.h:
• jit/JIT.cpp:

(JSC::JIT::JIT):
(JSC::JIT::privateCompileSlowCases):
(JSC::JIT::link):

• jit/JIT.h:
• jit/JITInlineCacheGenerator.cpp:

(JSC::JITByIdGenerator::JITByIdGenerator):
(JSC::JITGetByIdWithThisGenerator::JITGetByIdWithThisGenerator):
(JSC::JITGetByIdWithThisGenerator::generateFastPath):

• jit/JITInlineCacheGenerator.h:

(JSC::JITGetByIdWithThisGenerator::JITGetByIdWithThisGenerator):

• jit/JITInlines.h:

(JSC::JIT::callOperation):

• jit/JITOperations.cpp:
• jit/JITOperations.h:
• jit/JITPropertyAccess.cpp:

(JSC::JIT::emit_op_get_by_id_with_this):
(JSC::JIT::emitSlow_op_get_by_id_with_this):

• jit/JITPropertyAccess32_64.cpp:

(JSC::JIT::emit_op_get_by_id_with_this):
(JSC::JIT::emitSlow_op_get_by_id_with_this):

• jit/Repatch.cpp:

(JSC::appropriateOptimizingGetByIdFunction):
(JSC::appropriateGenericGetByIdFunction):
(JSC::tryCacheGetByID):

• jit/Repatch.h:
• jsc.cpp:

(WTF::CustomGetter::getOwnPropertySlot):
(WTF::CustomGetter::customGetterAcessor):

1:45 PM Changeset in webkit [213466] by Simon Fraser

• 18 edits
  1 copy
  15 adds in trunk

Only use layer backing store which supports subpixel antialiased text if we know subpixel antialiased will be painted into it
​https://bugs.webkit.org/show_bug.cgi?id=169191

Reviewed by Zalan Bujtas.

Source/WebCore:

Instead of unconditionally calling setSupportsSubpixelAntialiasedText() on GraphicsLayers created
by RenderLayerBacking, only do so when we know (or suspect) that a layer contains smoothed text.

This is done by enhancing RenderLayer::isVisuallyNonEmpty() and RenderLayer::hasNonEmptyChildRenderers()
to take a PaintedContentRequest parameter, which allows the caller to specify what qualities of
the layer contents it is interested in. Most of the time, this is just any painted content, but on
platforms where GraphicsLayer::supportsSubpixelAntialiasedLayerText() returns true, the query also
asks about whether the layer will contain subpixel-antialiased text. In this case, it can't early
return as soon as painted content is found; it must keep iterating renderers while all the query
requests are unsatisfied, or until it hits depth or sibling limits. If a limit is hit, we take the
same path of assuming there is subpixel-antialiased text (via the "Undetermined" state).

RenderLayerBacking also makes use of PaintedContentRequest during its non-composited child layer walk.

To offset the additional cost of this tree walking, RenderLayerBacking now caches information about its
painted content for the duration of a single update via PaintedContentsInfo, so we no longer call
isDirectlyCompositedImage() and isSimpleContainerCompositingLayer() multiple times per backing per update.
The traversal code here too now has to continue until all necessary states in the request have been computed.

Add some functions to RenderImage so that we know if it's showing the alt text or has a non-bitmap image
(which may contain text).

Subpixel-antialiased ("smoothed") text is disabled by DRT and WTR by default, so we need Internals API to enable it.

Platforms now express their support for subpixel-antialiased text via GraphicsLayer::supportsSubpixelAntialiasedLayerText()
which only returns true on Mac.

Tests: compositing/contents-format/subpixel-antialiased-text-configs-antialiasing-style.html

compositing/contents-format/subpixel-antialiased-text-configs.html
compositing/contents-format/subpixel-antialiased-text-images.html
compositing/contents-format/subpixel-antialiased-text-visibility.html

• platform/graphics/GraphicsLayer.cpp:

(WebCore::GraphicsLayer::supportsSubpixelAntialiasedLayerText):

• platform/graphics/GraphicsLayer.h:
• platform/graphics/ca/GraphicsLayerCA.cpp:

(WebCore::GraphicsLayer::supportsSubpixelAntialiasedLayerText):
(WebCore::GraphicsLayerCA::changeLayerTypeTo):

• rendering/RenderImage.cpp:

(WebCore::RenderImage::isShowingMissingOrImageError):
(WebCore::RenderImage::isShowingAltText):
(WebCore::RenderImage::hasNonBitmapImage):

• rendering/RenderImage.h:
• rendering/RenderLayer.cpp:

(WebCore::RenderLayer::calculateClipRects):

• rendering/RenderLayer.h:
• rendering/RenderLayerBacking.cpp:

(WebCore::PaintedContentsInfo::PaintedContentsInfo):
(WebCore::PaintedContentsInfo::setWantsSubpixelAntialiasedTextState):
(WebCore::PaintedContentsInfo::paintsBoxDecorations):
(WebCore::PaintedContentsInfo::paintsContent):
(WebCore::PaintedContentsInfo::paintsSubpixelAntialiasedText):
(WebCore::PaintedContentsInfo::isSimpleContainer):
(WebCore::PaintedContentsInfo::isDirectlyCompositedImage):
(WebCore::PaintedContentsInfo::paintsBoxDecorationsDetermination):
(WebCore::PaintedContentsInfo::paintsContentDetermination):
(WebCore::PaintedContentsInfo::paintsSubpixelAntialiasedTextDetermination):
(WebCore::PaintedContentsInfo::contentsTypeDetermination):
(WebCore::RenderLayerBacking::createGraphicsLayer):
(WebCore::RenderLayerBacking::updateConfiguration):
(WebCore::RenderLayerBacking::computeParentGraphicsLayerRect):
(WebCore::RenderLayerBacking::updateAfterDescendants):
(WebCore::RenderLayerBacking::updateDirectlyCompositedBoxDecorations):
(WebCore::RenderLayerBacking::updateDrawsContent):
(WebCore::RenderLayerBacking::updateDirectlyCompositedBackgroundColor):
(WebCore::RenderLayerBacking::updateDirectlyCompositedBackgroundImage):
(WebCore::RenderLayerBacking::paintsContent):
(WebCore::RenderLayerBacking::isSimpleContainerCompositingLayer):
(WebCore::RenderLayerBacking::isPaintDestinationForDescendantLayers):
(WebCore::RenderLayerBacking::hasVisibleNonCompositedDescendants):
(WebCore::RenderLayerBacking::containsPaintedContent):
(WebCore::RenderLayerBacking::contentChanged):
(WebCore::RenderLayerBacking::updateImageContents):
(WebCore::RenderLayerBacking::paintsChildRenderers): Deleted.

• rendering/RenderLayerBacking.h:
• rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::logLayerInfo):

• testing/Internals.cpp:

(WebCore::Internals::setFontSmoothingEnabled):

• testing/Internals.h:
• testing/Internals.idl:

LayoutTests:

Test lots of layer configs for subpixel antialiased text support. Only Mac results show the
"(supports subpixel antialiased text 1)" flag on layers now, since the patch makes this
dependent on platform support.

• compositing/contents-format/subpixel-antialiased-text-configs-antialiasing-style-expected.txt: Added.
• compositing/contents-format/subpixel-antialiased-text-configs-antialiasing-style.html: Added.
• compositing/contents-format/subpixel-antialiased-text-configs-expected.txt: Added.
• compositing/contents-format/subpixel-antialiased-text-configs.html: Added.
• compositing/contents-format/subpixel-antialiased-text-enabled-expected.txt:
• compositing/contents-format/subpixel-antialiased-text-enabled.html:
• compositing/contents-format/subpixel-antialiased-text-images-expected.txt: Added.
• compositing/contents-format/subpixel-antialiased-text-images.html: Added.
• compositing/contents-format/subpixel-antialiased-text-visibility-expected.txt: Added.
• compositing/contents-format/subpixel-antialiased-text-visibility.html: Added.
• compositing/resources/circle-with-text.svg: Added.
• compositing/resources/circle.svg: Added.
• platform/mac-wk1/compositing/contents-format/subpixel-antialiased-text-enabled-expected.txt:
• platform/mac/compositing/contents-format/subpixel-antialiased-text-configs-antialiasing-style-expected.txt: Added.
• platform/mac/compositing/contents-format/subpixel-antialiased-text-configs-expected.txt: Added.
• platform/mac/compositing/contents-format/subpixel-antialiased-text-enabled-expected.txt: Copied from LayoutTests/compositing/contents-format/subpixel-antialiased-text-enabled-expected.txt.
• platform/mac/compositing/contents-format/subpixel-antialiased-text-images-expected.txt: Added.
• platform/mac/compositing/contents-format/subpixel-antialiased-text-visibility-expected.txt: Added.

1:44 PM Changeset in webkit [213465] by sbarati@apple.com

• 9 edits in trunk

WebAssembly: implement init_expr for Element
​https://bugs.webkit.org/show_bug.cgi?id=165888
<rdar://problem/29760199>

Reviewed by Keith Miller.

JSTests:

• wasm/Builder_WebAssemblyBinary.js:

(const.emitters.Element):

• wasm/assert.js:
• wasm/js-api/element.js:

(assert.throws):
(badInstantiation.makeModule):
(badInstantiation.test):
(badInstantiation):

• wasm/js-api/global-error.js:

Source/JavaScriptCore:

This patch fixes a few bugs. The main change is allowing init_expr
for the Element's offset. To do this, I had to fix a couple of
other bugs:

• I removed our invalid early module-parse-time invalidation

of out of bound Element sections. This is not in the spec because
it can't be validated in the general case when the offset is a
get_global.

• Our get_global validation inside our init_expr parsing code was simply wrong.

It thought that the index operand to get_global went into the pool of imports,
but it does not. It indexes into the pool of globals. I changed the code to
refer to the global pool instead.

• wasm/WasmFormat.h:

(JSC::Wasm::Element::Element):

• wasm/WasmModuleParser.cpp:
• wasm/js/WebAssemblyModuleRecord.cpp:

(JSC::WebAssemblyModuleRecord::evaluate):

1:40 PM Changeset in webkit [213464] by mmaxfield@apple.com

• 56 edits
  2 copies
  7 adds in trunk

Expand font-weight and font-stretch to take any number
​https://bugs.webkit.org/show_bug.cgi?id=168889

Reviewed by Simon Fraser.

Source/WebCore:

This patch expands parsing support for font-weight and font-stretch so that they can accept
numbers in addition to the keyword values they accepted previously. Eventually, these numbers
will be used as inputs to select variation fonts; however, in this patch, the values are just
parsed and held in our internal data model. This means that this patch doesn't actually change
the general behavior of WebKit; instead, it parses new values, outputs them (via
getComputedStyle() and similar functions), and provides them as input to our preexisting font
selection algorithm.

This patch doesn't actually modify anything algorithmically, and therefore, it doesn't include
any additional tests for the font selection algorithm. Instead, it tests the parsing of the
newly accepted values (both input and output).

Because our internal data model needs to hold numbers now, this patch also completely eliminates
the FontWidth, FontItalic, and FontTraitsMask enum values in favor of FontSelectionValues (which
can hold numbers instead of individual enum values). Therefore, every place which we were using
these enum values is migrated in this patch to using FontSelectionValues instead.

Tests: fast/text/font-selection-font-face-parse.html

fast/text/font-selection-font-loading-api-parse.html
fast/text/font-style-parse.html
fast/text/font-weight-parse.html

• accessibility/AccessibilityRenderObject.cpp: Migrate off of old enum types.

(WebCore::AccessibilityRenderObject::hasBoldFont):
(WebCore::AccessibilityRenderObject::hasItalicFont):
(WebCore::AccessibilityRenderObject::hasPlainText):

• accessibility/atk/WebKitAccessibleInterfaceText.cpp: Ditto.

(getAttributeSetForAccessibilityObject):

• css/CSSComputedStyleDeclaration.cpp: Output newly parsed values.

(WebCore::fontWeightFromStyle):
(WebCore::fontStretchFromStyle):
(WebCore::fontStyleFromStyle):
(WebCore::fontShorthandValueForSelectionProperties):
(WebCore::ComputedStyleExtractor::propertyValue):

• css/CSSFontFace.cpp: Migrate off old enum types.

(WebCore::calculateWeightRange):
(WebCore::CSSFontFace::setWeight):
(WebCore::calculateStretchRange):
(WebCore::CSSFontFace::setStretch):
(WebCore::calculateStyleRange):
(WebCore::CSSFontFace::setStyle):
(WebCore::CSSFontFace::calculateStyleMask): Deleted.
(WebCore::CSSFontFace::calculateWeightMask): Deleted.
(WebCore::CSSFontFace::calculateStretch): Deleted.

• css/CSSFontFace.h:
• css/CSSFontFaceSet.cpp: Migrate off old enum types.

(WebCore::CSSFontFaceSet::ensureLocalFontFacesForFamilyRegistered):
(WebCore::calculateWeightValue):
(WebCore::calculateStretchValue):
(WebCore::calculateStyleValue):
(WebCore::computeFontSelectionRequest):
(WebCore::CSSFontFaceSet::matchingFaces):
(WebCore::CSSFontFaceSet::fontFace):
(WebCore::computeFontTraitsMask): Deleted.
(WebCore::computeFontStretch): Deleted.

• css/CSSFontFaceSet.h:
• css/CSSFontSelector.cpp: Migrate off old enum types.

(WebCore::CSSFontSelector::fontRangesForFamily):

• css/CSSPrimitiveValueMappings.h: font-weight and font-style are no longer

keyword properties.
(WebCore::CSSPrimitiveValue::operator FontWeight): Deleted.
(WebCore::CSSPrimitiveValue::operator FontItalic): Deleted.

• css/CSSProperties.json: Use the same infrastructure for all three of the

font selection properties.

• css/CSSSegmentedFontFace.cpp: Migrate off old enum types.

(WebCore::CSSSegmentedFontFace::fontRanges):

• css/CSSValueKeywords.in: The 100-based font-weight values are now represented

as real numbers.

• css/FontFace.cpp: Update the string output functions for the new values.

(WebCore::rangeIsSingleValue):
(WebCore::FontFace::style):
(WebCore::FontFace::weight):
(WebCore::FontFace::stretch):

• css/StyleBuilderConverter.h: Use CSSValue conversion functions to convert

to our new data model.
(WebCore::StyleBuilderConverter::convertFontWeight):
(WebCore::StyleBuilderConverter::convertFontStretch):
(WebCore::StyleBuilderConverter::convertFontStyle):

• css/StyleBuilderCustom.h: font-weight is no longer a completely custom

property.
(WebCore::StyleBuilderCustom::applyInitialFontWeight): Deleted.
(WebCore::StyleBuilderCustom::applyInheritFontWeight): Deleted.
(WebCore::StyleBuilderCustom::applyValueFontWeight): Deleted.

• css/parser/CSSParserFastPaths.cpp: font-style is no longer a keyword property.

(WebCore::CSSParserFastPaths::isValidKeywordPropertyAndValue):
(WebCore::CSSParserFastPaths::isKeywordPropertyID):

• css/parser/CSSPropertyParser.cpp: Parse the new values in the font selection

properties.
(WebCore::consumeFontWeightKeywordValue):
(WebCore::consumeFontWeightCSS21):
(WebCore::consumeFontWeight):
(WebCore::consumeFontStyleKeywordValue):
(WebCore::consumeFontStyle):
(WebCore::CSSPropertyParser::parseSingleValue):
(WebCore::CSSPropertyParser::parseFontFaceDescriptor):
(WebCore::CSSPropertyParser::consumeSystemFont):
(WebCore::CSSPropertyParser::consumeFont):

• editing/EditingStyle.cpp: Migrate off old enum types.

(WebCore::fontWeightIsBold):

• editing/mac/EditorMac.mm: Ditto.

(WebCore::Editor::applyFontStyles):

• platform/graphics/FontCache.h: Unify our font selection values into

their enclosing struct, FontSelectionCapabilities. Also, clean up utility
functions.

• platform/graphics/FontCascade.cpp: Migrate off old enum types.

(WebCore::FontCascade::FontCascade):

• platform/graphics/FontCascade.h: Ditto.

(WebCore::FontCascade::italic):
(WebCore::FontCascade::weight):

• platform/graphics/FontDescription.cpp: Ditto.

(WebCore::FontDescription::FontDescription):
(WebCore::FontCascadeDescription::lighterWeight):
(WebCore::FontCascadeDescription::bolderWeight):
(WebCore::FontDescription::traitsMask): Deleted.

• platform/graphics/FontDescription.h: Migrate off old enum types.

(WebCore::FontDescription::italic):
(WebCore::FontDescription::stretch):
(WebCore::FontDescription::weight):
(WebCore::FontDescription::fontSelectionRequest):
(WebCore::FontDescription::computedPixelSize):
(WebCore::FontDescription::setItalic):
(WebCore::FontDescription::setStretch):
(WebCore::FontDescription::setIsItalic):
(WebCore::FontDescription::setWeight):
(WebCore::FontDescription::operator==):
(WebCore::FontCascadeDescription::lighterWeight):
(WebCore::FontCascadeDescription::bolderWeight):
(WebCore::FontCascadeDescription::initialItalic):
(WebCore::FontCascadeDescription::initialWeight):
(WebCore::FontCascadeDescription::initialStretch):

• platform/graphics/FontSelectionAlgorithm.cpp: Delete code which was only

present to convert from the old enum types to the new FontSelectionRequest
type.
(WebCore::fontSelectionRequestForTraitsMask): Deleted.
(WebCore::initialFontSelectionCapabilitiesForTraitsMask): Deleted.
(WebCore::fontSelectionCapabilitiesForTraitsMask): Deleted.

• platform/graphics/FontSelectionAlgorithm.h: Migrate to new named functions

for special values.
(WebCore::isItalic):
(WebCore::boldWeightValue):
(WebCore::normalWeightValue):
(WebCore::isFontWeightBold):
(WebCore::normalStretchValue):
(WebCore::FontSelectionRequest::FontSelectionRequest):

• platform/graphics/cocoa/FontCacheCoreText.cpp: Migrate all platforms which

compile this file to know about FontDatabase. This simplifies the interaction
between @font-face fonts and installed fonts. Also, migrate off old enum types.
(WebCore::stretchFromCoreTextTraits):
(WebCore::fontWeightFromCoreText):
(WebCore::capabilitiesForFontDescriptor):
(WebCore::FontCache::getFontSelectionCapabilitiesInFamily):
(WebCore::platformFontLookupWithFamily):
(WebCore::invalidateFontCache):
(WebCore::fontWithFamily):
(WebCore::FontCache::createFontPlatformData):
(WebCore::lookupFallbackFont):
(WebCore::toTraitsMask): Deleted.
(WebCore::isFontWeightBold): Deleted.
(WebCore::toCoreTextFontWeight): Deleted.
(): Deleted.
(WebCore::FontDatabase::capabilitiesForFontDescriptor): Deleted.
(WebCore::calculateFontSelectionRequest): Deleted.

• platform/graphics/freetype/FontCacheFreeType.cpp: Migrate off old enum types.

(WebCore::FontCache::getFontSelectionCapabilitiesInFamily):
(WebCore::fontWeightToFontconfigWeight):
(): Deleted.

• platform/graphics/freetype/FontPlatformDataFreeType.cpp: Ditto.

(WebCore::FontPlatformData::FontPlatformData):

• platform/graphics/ios/FontCacheIOS.mm: Ditto.

(WebCore::baseSystemFontDescriptor):
(WebCore::systemFontModificationAttributes):
(WebCore::systemFontDescriptor):
(WebCore::platformFontWithFamilySpecialCase):
(WebCore::FontCache::weightOfCTFont): Deleted.

• platform/graphics/mac/FontCacheMac.mm: Ditto.

(WebCore::toNSFontWeight):
(WebCore::platformFontWithFamilySpecialCase):

• platform/graphics/win/FontCacheWin.cpp: Ditto.

(WebCore::toGDIFontWeight):
(WebCore::traitsInFamilyEnumProc):
(WebCore::FontCache::getFontSelectionCapabilitiesInFamily):
(): Deleted.

• platform/mock/MockRealtimeVideoSource.cpp: Ditto.

(WebCore::MockRealtimeVideoSource::applySize):

• platform/text/TextFlags.h: Delete old enum types.
• platform/win/DragImageWin.cpp: Migrate off old enum types.

(WebCore::dragLabelFont):

• rendering/RenderEmbeddedObject.cpp: Ditto.

(WebCore::RenderEmbeddedObject::getReplacementTextGeometry):

• rendering/RenderThemeGtk.cpp: Ditto.

(WebCore::RenderThemeGtk::updateCachedSystemFontDescription):

• rendering/RenderThemeIOS.mm: Ditto.

(WebCore::RenderThemeIOS::updateCachedSystemFontDescription):

• rendering/RenderThemeMac.mm: Ditto.

(WebCore::toFontWeight):

• rendering/RenderThemeWin.cpp: Ditto.

(WebCore::fillFontDescription):

Source/WebKit/mac:

Migrate off old enum types.

• WebCoreSupport/PopupMenuMac.mm:

(PopupMenuMac::populate):

• WebView/WebHTMLView.mm:

(fontNameForDescription):

• WebView/WebView.mm:

(-[WebView updateTextTouchBar]):

Source/WebKit/win:

Migrate off old enum types.

• WebKitGraphics.cpp:

(makeFont):

Source/WebKit2:

Migrate off old enum types.

• WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::editorState):

Tools:

Migrate off old enum types.

• TestWebKitAPI/Tests/WebCore/FontCache.cpp:

(TestWebKitAPI::createPlatformFont):
(TestWebKitAPI::compareFonts):
(TestWebKitAPI::TEST_F):

LayoutTests:

• fast/text/font-selection-font-face-parse-expected.txt: Added.
• fast/text/font-selection-font-face-parse.html: Added.
• fast/text/font-selection-font-loading-api-parse-expected.txt: Added.
• fast/text/font-selection-font-loading-api-parse.html: Added.
• fast/text/font-stretch-parse-expected.txt:
• fast/text/font-stretch-parse.html:
• fast/text/font-style-parse-expected.txt: Copied from LayoutTests/fast/text/font-stretch-parse-expected.txt.
• fast/text/font-style-parse.html: Added.
• fast/text/font-weight-parse-expected.txt: Copied from LayoutTests/fast/text/font-stretch-parse-expected.txt.
• fast/text/font-weight-parse.html: Added.

1:14 PM Changeset in webkit [213463] by Jon Davis

• 5 edits
  1 copy in trunk/PerformanceTests

Refined the ARES-6 experience
​https://bugs.webkit.org/show_bug.cgi?id=169205

Reviewed by Saam Barati.

• ARES-6/about.html: Copied from PerformanceTests/ARES-6/index.html.
• ARES-6/driver.js:

(Driver.prototype.start):
(Driver.prototype._updateIterations):
(Driver):

• ARES-6/index.html:
• ARES-6/stats.js:

(Stats.prototype.toString.span.span):

• ARES-6/styles.css:

(body):
(.swoop):
(p):
(.logo):
(.start):
(.test):
(.test:nth-child(odd)):
(.overall):
(.about h2):
(.button):
(.button:hover):
(.button.return:before):
(@keyframes fade-in):
(@keyframes scale-in):
(@keyframes flicker-in):
(@keyframes wipe-in):
(.flip): Deleted.
(.testing, .about): Deleted.
(.testing): Deleted.
(.about): Deleted.
(#about:target): Deleted.

1:13 PM Changeset in webkit [213462] by clopez@igalia.com

• 2 edits in trunk/LayoutTests

[GTK] Mark fast/parser/adoption-agency-unload-iframe-4.html as timing out on platform GTK.

Unreviewed test gardening.

• platform/gtk/TestExpectations:

12:27 PM Changeset in webkit [213461] by commit-queue@webkit.org

• 2 edits in trunk/PerformanceTests

StandardCanPlayThrough.html does not work on iOS.
​https://bugs.webkit.org/show_bug.cgi?id=169207

Patch by Jeremy Jones <​jeremyj@apple.com> on 2017-03-06
Reviewed by Jer Noble.

On iOS only, add muted=true and autoplay=allowed. The loading policy on iOS requires these attributes to load enough
data to trigger canPlayThrough.

• Media/StandardCanPlayThrough.html:

11:43 AM Changeset in webkit [213460] by Chris Dumez

• 12 edits
  2 adds in trunk

[iOS] Disable autoplay of silent videos in low power mode
​https://bugs.webkit.org/show_bug.cgi?id=168985
<rdar://problem/30739051>

Reviewed by Jer Noble.

Source/WebCore:

Disable autoplay of silent videos in low power mode on iOS to save battery.
We force the display of the start button when denying autoplay in low power
mode to allow the user to start playback.

Test: media/modern-media-controls/start-support/start-support-lowPowerMode.html

• Modules/mediacontrols/MediaControlsHost.cpp:

(WebCore::MediaControlsHost::shouldForceControlsDisplay):

• Modules/mediacontrols/MediaControlsHost.h:
• Modules/mediacontrols/MediaControlsHost.idl:

Add shouldForceControlsDisplay property on MediaControlsHost. This property
is set to true when we want to force the display for media controls. Currently,
this only returns true for autoplay videos, while in low power mode.

• Modules/modern-media-controls/media/controls-visibility-support.js:

(ControlsVisibilitySupport.prototype._updateControls):
Take into consideration MediaControlsHost.shouldForceControlsDisplay when
initializing shouldShowControls variable.

• Modules/modern-media-controls/media/start-support.js:

(StartSupport.prototype._shouldShowStartButton):
Show the start button when MediaControlsHost.shouldForceControlsDisplay
returns true.

• html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::HTMLMediaElement):
Add MediaElementSession::RequireUserGestureForVideoDueToLowPowerMode restriction
to the session when low power mode is enabled so we know we need to force a
gesture to start playback of autoplay videos.

(WebCore::HTMLMediaElement::shouldForceControlsDisplay):
Add convenience function to decide if we should force display of media controls.
This returns true if the media element is a video with autoplay attribute and
its session has the MediaElementSession::RequireUserGestureForVideoDueToLowPowerMode
restriction (i.e. we are in low power mode).

(WebCore::HTMLMediaElement::configureMediaControls):
Force requireControls variable to true if shouldForceControlsDisplay() returns
true. We do this here instead of inside HTMLMediaElement::controls() because
we do not want to change the value of media.controls exposed to JavaScript.

(WebCore::HTMLMediaElement::removeBehaviorsRestrictionsAfterFirstUserGesture):
Add MediaElementSession::RequireUserGestureForVideoDueToLowPowerMode to the list
of restrictions that get removed on user gesture.

• html/MediaElementSession.cpp:

(WebCore::MediaElementSession::playbackPermitted):
Deny playback for videos that have the RequireUserGestureForVideoDueToLowPowerMode
restriction unless there is a user gesture.

• html/MediaElementSession.h:

Add new MediaElementSession::RequireUserGestureForVideoDueToLowPowerMode
restriction.

LayoutTests:

Add layout test coverage.

• media/modern-media-controls/start-support/start-support-lowPowerMode-expected.txt: Added.
• media/modern-media-controls/start-support/start-support-lowPowerMode.html: Added.

11:24 AM Changeset in webkit [213459] by Ryan Haddad

• 2 edits in trunk/LayoutTests

Mark media/modern-media-controls/icon-button/icon-button-active-state.html as flaky.
​https://bugs.webkit.org/show_bug.cgi?id=167752

Unreviewed test gardening.

• platform/mac-wk1/TestExpectations:

11:14 AM Changeset in webkit [213458] by Chris Dumez

• 16 edits in trunk

LayoutTest fast/dom/timer-throttling-hidden-page.html is a flaky failure
​https://bugs.webkit.org/show_bug.cgi?id=168927

Reviewed by Simon Fraser.

Source/WebCore:

Update internals.isTimerThrottled() to return true for any kind of throttling.
It used to only account only for specific timers that do not cause changes
inside the viewport. It now accounts for all kind of throttling, such as
timer alignment due to the page being hidden.

• page/DOMTimer.h:
• testing/Internals.cpp:

(WebCore::Internals::isTimerThrottled):

LayoutTests:

• fast/dom/nested-timer-visible-element-throttling.html:
• fast/dom/repeating-timer-element-overflow-throttling.html:
• fast/dom/repeating-timer-element-overflowing-child-own-layer-throttling.html:
• fast/dom/repeating-timer-mixed-visible-display-none-elements-throttling.html:
• fast/dom/repeating-timer-visible-element-throttling.html:
• fast/dom/timer-height-change-no-throttling.html:
• fast/frames/flattening/resources/iframe-to-resize.html:

Use 10 milliseconds interval for tests relying on internals.isTimerThrottled().
Using 0 is problematic because we always internally cap to 1ms and 4ms after
reaching the max nesting level. Therefore, a 0 delay timer is always considered
to be throttled.

• fast/dom/timer-throttling-hidden-page-expected.txt:
• fast/dom/timer-throttling-hidden-page-non-nested-expected.txt:
• fast/dom/timer-throttling-hidden-page-non-nested.html:
• fast/dom/timer-throttling-hidden-page.html:

Rewrite tests to stop measuring timer intervals as this is inherently
flaky and rely on internals.isTimerThrottled() instead.

• platform/mac/TestExpectations:

Unskip test that used to be flaky.

11:09 AM Changeset in webkit [213457] by Manuel Rego Casasnovas

• 5 edits
  286 adds in trunk/LayoutTests

[css-grid] Import W3C Test Suite
​https://bugs.webkit.org/show_bug.cgi?id=169196

Reviewed by Youenn Fablet.

LayoutTests/imported/w3c:

This patch imports the CSS Grid Layout test suite from csswg-test repository:
​https://github.com/w3c/csswg-test/tree/master/css-grid-1

• csswg-test/css-grid-1/OWNERS: Added.
• csswg-test/css-grid-1/README.md: Added.
• csswg-test/css-grid-1/grid-definition/fr-unit-expected.html: Added.
• csswg-test/css-grid-1/grid-definition/fr-unit-with-percentage-expected.html: Added.
• csswg-test/css-grid-1/grid-definition/fr-unit-with-percentage.html: Added.
• csswg-test/css-grid-1/grid-definition/fr-unit.html: Added.
• csswg-test/css-grid-1/grid-definition/grid-inline-support-flexible-lengths-001-expected.txt: Added.
• csswg-test/css-grid-1/grid-definition/grid-inline-support-flexible-lengths-001.xht: Added.
• csswg-test/css-grid-1/grid-definition/grid-inline-support-grid-template-areas-001-expected.txt: Added.
• csswg-test/css-grid-1/grid-definition/grid-inline-support-grid-template-areas-001.xht: Added.
• csswg-test/css-grid-1/grid-definition/grid-inline-support-grid-template-columns-rows-001-expected.txt: Added.
• csswg-test/css-grid-1/grid-definition/grid-inline-support-grid-template-columns-rows-001.xht: Added.
• csswg-test/css-grid-1/grid-definition/grid-inline-support-named-grid-lines-001-expected.txt: Added.
• csswg-test/css-grid-1/grid-definition/grid-inline-support-named-grid-lines-001.xht: Added.
• csswg-test/css-grid-1/grid-definition/grid-inline-support-repeat-001-expected.txt: Added.
• csswg-test/css-grid-1/grid-definition/grid-inline-support-repeat-001.xht: Added.
• csswg-test/css-grid-1/grid-definition/grid-inline-template-columns-rows-resolved-values-001-expected.txt: Added.
• csswg-test/css-grid-1/grid-definition/grid-inline-template-columns-rows-resolved-values-001.xht: Added.
• csswg-test/css-grid-1/grid-definition/grid-layout-auto-tracks-expected.html: Added.
• csswg-test/css-grid-1/grid-definition/grid-layout-auto-tracks.html: Added.
• csswg-test/css-grid-1/grid-definition/grid-layout-basic-expected.html: Added.
• csswg-test/css-grid-1/grid-definition/grid-layout-basic.html: Added.
• csswg-test/css-grid-1/grid-definition/grid-layout-repeat-notation-expected.html: Added.
• csswg-test/css-grid-1/grid-definition/grid-layout-repeat-notation.html: Added.
• csswg-test/css-grid-1/grid-definition/grid-support-flexible-lengths-001-expected.txt: Added.
• csswg-test/css-grid-1/grid-definition/grid-support-flexible-lengths-001.xht: Added.
• csswg-test/css-grid-1/grid-definition/grid-support-grid-template-areas-001-expected.txt: Added.
• csswg-test/css-grid-1/grid-definition/grid-support-grid-template-areas-001.xht: Added.
• csswg-test/css-grid-1/grid-definition/grid-support-grid-template-columns-rows-001-expected.txt: Added.
• csswg-test/css-grid-1/grid-definition/grid-support-grid-template-columns-rows-001.xht: Added.
• csswg-test/css-grid-1/grid-definition/grid-support-named-grid-lines-001-expected.txt: Added.
• csswg-test/css-grid-1/grid-definition/grid-support-named-grid-lines-001.xht: Added.
• csswg-test/css-grid-1/grid-definition/grid-support-repeat-001-expected.txt: Added.
• csswg-test/css-grid-1/grid-definition/grid-support-repeat-001.xht: Added.
• csswg-test/css-grid-1/grid-definition/grid-template-columns-rows-resolved-values-001-expected.txt: Added.
• csswg-test/css-grid-1/grid-definition/grid-template-columns-rows-resolved-values-001.xht: Added.
• csswg-test/css-grid-1/grid-definition/support/testing-utils.js: Added.

(checkGridTemplateRows):
(testGridTemplateColumnsRows):
(testGridTemplateAreas):
(TestingUtils):

• csswg-test/css-grid-1/grid-definition/support/w3c-import.log: Added.
• csswg-test/css-grid-1/grid-definition/w3c-import.log: Added.
• csswg-test/css-grid-1/grid-items/grid-inline-items-001-expected.xht: Added.
• csswg-test/css-grid-1/grid-items/grid-inline-items-001.xht: Added.
• csswg-test/css-grid-1/grid-items/grid-inline-items-002-expected.xht: Added.
• csswg-test/css-grid-1/grid-items/grid-inline-items-002.xht: Added.
• csswg-test/css-grid-1/grid-items/grid-inline-items-003-expected.xht: Added.
• csswg-test/css-grid-1/grid-items/grid-inline-items-003.xht: Added.
• csswg-test/css-grid-1/grid-items/grid-inline-items-inline-blocks-001-expected.xht: Added.
• csswg-test/css-grid-1/grid-items/grid-inline-items-inline-blocks-001.xht: Added.
• csswg-test/css-grid-1/grid-items/grid-inline-order-property-auto-placement-001-expected.xht: Added.
• csswg-test/css-grid-1/grid-items/grid-inline-order-property-auto-placement-001.xht: Added.
• csswg-test/css-grid-1/grid-items/grid-inline-order-property-auto-placement-002-expected.xht: Added.
• csswg-test/css-grid-1/grid-items/grid-inline-order-property-auto-placement-002.xht: Added.
• csswg-test/css-grid-1/grid-items/grid-inline-order-property-auto-placement-003-expected.xht: Added.
• csswg-test/css-grid-1/grid-items/grid-inline-order-property-auto-placement-003.xht: Added.
• csswg-test/css-grid-1/grid-items/grid-inline-order-property-auto-placement-004-expected.xht: Added.
• csswg-test/css-grid-1/grid-items/grid-inline-order-property-auto-placement-004.xht: Added.
• csswg-test/css-grid-1/grid-items/grid-inline-order-property-auto-placement-005-expected.xht: Added.
• csswg-test/css-grid-1/grid-items/grid-inline-order-property-auto-placement-005.xht: Added.
• csswg-test/css-grid-1/grid-items/grid-inline-order-property-painting-001-expected.xht: Added.
• csswg-test/css-grid-1/grid-items/grid-inline-order-property-painting-001.xht: Added.
• csswg-test/css-grid-1/grid-items/grid-inline-order-property-painting-002-expected.xht: Added.
• csswg-test/css-grid-1/grid-items/grid-inline-order-property-painting-002.xht: Added.
• csswg-test/css-grid-1/grid-items/grid-inline-order-property-painting-003-expected.xht: Added.
• csswg-test/css-grid-1/grid-items/grid-inline-order-property-painting-003.xht: Added.
• csswg-test/css-grid-1/grid-items/grid-inline-order-property-painting-004-expected.xht: Added.
• csswg-test/css-grid-1/grid-items/grid-inline-order-property-painting-004.xht: Added.
• csswg-test/css-grid-1/grid-items/grid-inline-order-property-painting-005-expected.xht: Added.
• csswg-test/css-grid-1/grid-items/grid-inline-order-property-painting-005.xht: Added.
• csswg-test/css-grid-1/grid-items/grid-inline-z-axis-ordering-001-expected.xht: Added.
• csswg-test/css-grid-1/grid-items/grid-inline-z-axis-ordering-001.xht: Added.
• csswg-test/css-grid-1/grid-items/grid-inline-z-axis-ordering-002-expected.xht: Added.
• csswg-test/css-grid-1/grid-items/grid-inline-z-axis-ordering-002.xht: Added.
• csswg-test/css-grid-1/grid-items/grid-inline-z-axis-ordering-003-expected.xht: Added.
• csswg-test/css-grid-1/grid-items/grid-inline-z-axis-ordering-003.xht: Added.
• csswg-test/css-grid-1/grid-items/grid-inline-z-axis-ordering-004-expected.xht: Added.
• csswg-test/css-grid-1/grid-items/grid-inline-z-axis-ordering-004.xht: Added.
• csswg-test/css-grid-1/grid-items/grid-inline-z-axis-ordering-005-expected.xht: Added.
• csswg-test/css-grid-1/grid-items/grid-inline-z-axis-ordering-005.xht: Added.
• csswg-test/css-grid-1/grid-items/grid-inline-z-axis-ordering-overlapped-items-001-expected.xht: Added.
• csswg-test/css-grid-1/grid-items/grid-inline-z-axis-ordering-overlapped-items-001.xht: Added.
• csswg-test/css-grid-1/grid-items/grid-inline-z-axis-ordering-overlapped-items-002-expected.xht: Added.
• csswg-test/css-grid-1/grid-items/grid-inline-z-axis-ordering-overlapped-items-002.xht: Added.
• csswg-test/css-grid-1/grid-items/grid-inline-z-axis-ordering-overlapped-items-003-expected.xht: Added.
• csswg-test/css-grid-1/grid-items/grid-inline-z-axis-ordering-overlapped-items-003.xht: Added.
• csswg-test/css-grid-1/grid-items/grid-inline-z-axis-ordering-overlapped-items-004-expected.xht: Added.
• csswg-test/css-grid-1/grid-items/grid-inline-z-axis-ordering-overlapped-items-004.xht: Added.
• csswg-test/css-grid-1/grid-items/grid-inline-z-axis-ordering-overlapped-items-005-expected.xht: Added.
• csswg-test/css-grid-1/grid-items/grid-inline-z-axis-ordering-overlapped-items-005.xht: Added.
• csswg-test/css-grid-1/grid-items/grid-inline-z-axis-ordering-overlapped-items-006-expected.xht: Added.
• csswg-test/css-grid-1/grid-items/grid-inline-z-axis-ordering-overlapped-items-006.xht: Added.
• csswg-test/css-grid-1/grid-items/grid-item-containing-block-001-expected.xht: Added.
• csswg-test/css-grid-1/grid-items/grid-item-containing-block-001.html: Added.
• csswg-test/css-grid-1/grid-items/grid-item-containing-block-002-expected.xht: Added.
• csswg-test/css-grid-1/grid-items/grid-item-containing-block-002.html: Added.
• csswg-test/css-grid-1/grid-items/grid-item-containing-block-003-expected.xht: Added.
• csswg-test/css-grid-1/grid-items/grid-item-containing-block-003.html: Added.
• csswg-test/css-grid-1/grid-items/grid-item-containing-block-004-expected.xht: Added.
• csswg-test/css-grid-1/grid-items/grid-item-containing-block-004.html: Added.
• csswg-test/css-grid-1/grid-items/grid-items-001-expected.xht: Added.
• csswg-test/css-grid-1/grid-items/grid-items-001.xht: Added.
• csswg-test/css-grid-1/grid-items/grid-items-002-expected.xht: Added.
• csswg-test/css-grid-1/grid-items/grid-items-002.xht: Added.
• csswg-test/css-grid-1/grid-items/grid-items-003-expected.xht: Added.
• csswg-test/css-grid-1/grid-items/grid-items-003.xht: Added.
• csswg-test/css-grid-1/grid-items/grid-items-inline-blocks-001-expected.xht: Added.
• csswg-test/css-grid-1/grid-items/grid-items-inline-blocks-001.xht: Added.
• csswg-test/css-grid-1/grid-items/grid-items-sizing-alignment-001-expected.html: Added.
• csswg-test/css-grid-1/grid-items/grid-items-sizing-alignment-001.html: Added.
• csswg-test/css-grid-1/grid-items/grid-layout-grid-in-grid-expected.html: Added.
• csswg-test/css-grid-1/grid-items/grid-layout-grid-in-grid.html: Added.
• csswg-test/css-grid-1/grid-items/grid-layout-z-order-a-expected.html: Added.
• csswg-test/css-grid-1/grid-items/grid-layout-z-order-a.html: Added.
• csswg-test/css-grid-1/grid-items/grid-layout-z-order-b-expected.html: Added.
• csswg-test/css-grid-1/grid-items/grid-layout-z-order-b.html: Added.
• csswg-test/css-grid-1/grid-items/grid-minimum-size-grid-items-001-expected.xht: Added.
• csswg-test/css-grid-1/grid-items/grid-minimum-size-grid-items-001.xht: Added.
• csswg-test/css-grid-1/grid-items/grid-minimum-size-grid-items-002-expected.xht: Added.
• csswg-test/css-grid-1/grid-items/grid-minimum-size-grid-items-002.xht: Added.
• csswg-test/css-grid-1/grid-items/grid-minimum-size-grid-items-003-expected.xht: Added.
• csswg-test/css-grid-1/grid-items/grid-minimum-size-grid-items-003.xht: Added.
• csswg-test/css-grid-1/grid-items/grid-minimum-size-grid-items-004-expected.xht: Added.
• csswg-test/css-grid-1/grid-items/grid-minimum-size-grid-items-004.xht: Added.
• csswg-test/css-grid-1/grid-items/grid-minimum-size-grid-items-005-expected.html: Added.
• csswg-test/css-grid-1/grid-items/grid-minimum-size-grid-items-005.xht: Added.
• csswg-test/css-grid-1/grid-items/grid-minimum-size-grid-items-006-expected.html: Added.
• csswg-test/css-grid-1/grid-items/grid-minimum-size-grid-items-006.xht: Added.
• csswg-test/css-grid-1/grid-items/grid-minimum-size-grid-items-007-expected.html: Added.
• csswg-test/css-grid-1/grid-items/grid-minimum-size-grid-items-007.xht: Added.
• csswg-test/css-grid-1/grid-items/grid-minimum-size-grid-items-008-expected.html: Added.
• csswg-test/css-grid-1/grid-items/grid-minimum-size-grid-items-008.xht: Added.
• csswg-test/css-grid-1/grid-items/grid-minimum-size-grid-items-009-expected.html: Added.
• csswg-test/css-grid-1/grid-items/grid-minimum-size-grid-items-009.xht: Added.
• csswg-test/css-grid-1/grid-items/grid-minimum-size-grid-items-010-expected.xht: Added.
• csswg-test/css-grid-1/grid-items/grid-minimum-size-grid-items-010.html: Added.
• csswg-test/css-grid-1/grid-items/grid-minimum-size-grid-items-011-expected.xht: Added.
• csswg-test/css-grid-1/grid-items/grid-minimum-size-grid-items-011.html: Added.
• csswg-test/css-grid-1/grid-items/grid-minimum-size-grid-items-012-expected.xht: Added.
• csswg-test/css-grid-1/grid-items/grid-minimum-size-grid-items-012.html: Added.
• csswg-test/css-grid-1/grid-items/grid-minimum-size-grid-items-013-expected.xht: Added.
• csswg-test/css-grid-1/grid-items/grid-minimum-size-grid-items-013.html: Added.
• csswg-test/css-grid-1/grid-items/grid-minimum-size-grid-items-014-expected.xht: Added.
• csswg-test/css-grid-1/grid-items/grid-minimum-size-grid-items-014.html: Added.
• csswg-test/css-grid-1/grid-items/grid-minimum-size-grid-items-015-expected.xht: Added.
• csswg-test/css-grid-1/grid-items/grid-minimum-size-grid-items-015.html: Added.
• csswg-test/css-grid-1/grid-items/grid-minimum-size-grid-items-016-expected.xht: Added.
• csswg-test/css-grid-1/grid-items/grid-minimum-size-grid-items-016.html: Added.
• csswg-test/css-grid-1/grid-items/grid-minimum-size-grid-items-017-expected.xht: Added.
• csswg-test/css-grid-1/grid-items/grid-minimum-size-grid-items-017.html: Added.
• csswg-test/css-grid-1/grid-items/grid-minimum-size-grid-items-018-expected.xht: Added.
• csswg-test/css-grid-1/grid-items/grid-minimum-size-grid-items-018.html: Added.
• csswg-test/css-grid-1/grid-items/grid-order-property-auto-placement-001-expected.xht: Added.
• csswg-test/css-grid-1/grid-items/grid-order-property-auto-placement-001.xht: Added.
• csswg-test/css-grid-1/grid-items/grid-order-property-auto-placement-002-expected.xht: Added.
• csswg-test/css-grid-1/grid-items/grid-order-property-auto-placement-002.xht: Added.
• csswg-test/css-grid-1/grid-items/grid-order-property-auto-placement-003-expected.xht: Added.
• csswg-test/css-grid-1/grid-items/grid-order-property-auto-placement-003.xht: Added.
• csswg-test/css-grid-1/grid-items/grid-order-property-auto-placement-004-expected.xht: Added.
• csswg-test/css-grid-1/grid-items/grid-order-property-auto-placement-004.xht: Added.
• csswg-test/css-grid-1/grid-items/grid-order-property-auto-placement-005-expected.xht: Added.
• csswg-test/css-grid-1/grid-items/grid-order-property-auto-placement-005.xht: Added.
• csswg-test/css-grid-1/grid-items/grid-order-property-painting-001-expected.xht: Added.
• csswg-test/css-grid-1/grid-items/grid-order-property-painting-001.xht: Added.
• csswg-test/css-grid-1/grid-items/grid-order-property-painting-002-expected.xht: Added.
• csswg-test/css-grid-1/grid-items/grid-order-property-painting-002.xht: Added.
• csswg-test/css-grid-1/grid-items/grid-order-property-painting-003-expected.xht: Added.
• csswg-test/css-grid-1/grid-items/grid-order-property-painting-003.xht: Added.
• csswg-test/css-grid-1/grid-items/grid-order-property-painting-004-expected.xht: Added.
• csswg-test/css-grid-1/grid-items/grid-order-property-painting-004.xht: Added.
• csswg-test/css-grid-1/grid-items/grid-order-property-painting-005-expected.xht: Added.
• csswg-test/css-grid-1/grid-items/grid-order-property-painting-005.xht: Added.
• csswg-test/css-grid-1/grid-items/grid-z-axis-ordering-001-expected.xht: Added.
• csswg-test/css-grid-1/grid-items/grid-z-axis-ordering-001.xht: Added.
• csswg-test/css-grid-1/grid-items/grid-z-axis-ordering-002-expected.xht: Added.
• csswg-test/css-grid-1/grid-items/grid-z-axis-ordering-002.xht: Added.
• csswg-test/css-grid-1/grid-items/grid-z-axis-ordering-003-expected.xht: Added.
• csswg-test/css-grid-1/grid-items/grid-z-axis-ordering-003.xht: Added.
• csswg-test/css-grid-1/grid-items/grid-z-axis-ordering-004-expected.xht: Added.
• csswg-test/css-grid-1/grid-items/grid-z-axis-ordering-004.xht: Added.
• csswg-test/css-grid-1/grid-items/grid-z-axis-ordering-005-expected.xht: Added.
• csswg-test/css-grid-1/grid-items/grid-z-axis-ordering-005.xht: Added.
• csswg-test/css-grid-1/grid-items/grid-z-axis-ordering-overlapped-items-001-expected.xht: Added.
• csswg-test/css-grid-1/grid-items/grid-z-axis-ordering-overlapped-items-001.xht: Added.
• csswg-test/css-grid-1/grid-items/grid-z-axis-ordering-overlapped-items-002-expected.xht: Added.
• csswg-test/css-grid-1/grid-items/grid-z-axis-ordering-overlapped-items-002.xht: Added.
• csswg-test/css-grid-1/grid-items/grid-z-axis-ordering-overlapped-items-003-expected.xht: Added.
• csswg-test/css-grid-1/grid-items/grid-z-axis-ordering-overlapped-items-003.xht: Added.
• csswg-test/css-grid-1/grid-items/grid-z-axis-ordering-overlapped-items-004-expected.xht: Added.
• csswg-test/css-grid-1/grid-items/grid-z-axis-ordering-overlapped-items-004.xht: Added.
• csswg-test/css-grid-1/grid-items/grid-z-axis-ordering-overlapped-items-005-expected.xht: Added.
• csswg-test/css-grid-1/grid-items/grid-z-axis-ordering-overlapped-items-005.xht: Added.
• csswg-test/css-grid-1/grid-items/grid-z-axis-ordering-overlapped-items-006-expected.xht: Added.
• csswg-test/css-grid-1/grid-items/grid-z-axis-ordering-overlapped-items-006.xht: Added.
• csswg-test/css-grid-1/grid-items/ref-filled-green-100px-square-image.html: Added.
• csswg-test/css-grid-1/grid-items/support/100x100-green.png: Added.
• csswg-test/css-grid-1/grid-items/support/100x50-green.png: Added.
• csswg-test/css-grid-1/grid-items/support/200x200-green.png: Added.
• csswg-test/css-grid-1/grid-items/support/50x100-green.png: Added.
• csswg-test/css-grid-1/grid-items/support/50x50-green.png: Added.
• csswg-test/css-grid-1/grid-items/support/w3c-import.log: Added.
• csswg-test/css-grid-1/grid-items/w3c-import.log: Added.
• csswg-test/css-grid-1/grid-layout-properties-expected.txt: Added.
• csswg-test/css-grid-1/grid-layout-properties.html: Added.
• csswg-test/css-grid-1/grid-model/display-grid-expected.html: Added.
• csswg-test/css-grid-1/grid-model/display-grid.html: Added.
• csswg-test/css-grid-1/grid-model/display-inline-grid-expected.html: Added.
• csswg-test/css-grid-1/grid-model/display-inline-grid.html: Added.
• csswg-test/css-grid-1/grid-model/grid-computed-value-display-floated-items-001-expected.txt: Added.
• csswg-test/css-grid-1/grid-model/grid-computed-value-display-floated-items-001.xht: Added.
• csswg-test/css-grid-1/grid-model/grid-display-grid-001-expected.xht: Added.
• csswg-test/css-grid-1/grid-model/grid-display-grid-001.xht: Added.
• csswg-test/css-grid-1/grid-model/grid-display-inline-grid-001-expected.xht: Added.
• csswg-test/css-grid-1/grid-model/grid-display-inline-grid-001.xht: Added.
• csswg-test/css-grid-1/grid-model/grid-first-letter-001-expected.xht: Added.
• csswg-test/css-grid-1/grid-model/grid-first-letter-001.xht: Added.
• csswg-test/css-grid-1/grid-model/grid-first-letter-002-expected.xht: Added.
• csswg-test/css-grid-1/grid-model/grid-first-letter-002.xht: Added.
• csswg-test/css-grid-1/grid-model/grid-first-letter-003-expected.xht: Added.
• csswg-test/css-grid-1/grid-model/grid-first-letter-003.xht: Added.
• csswg-test/css-grid-1/grid-model/grid-first-line-001-expected.xht: Added.
• csswg-test/css-grid-1/grid-model/grid-first-line-001.xht: Added.
• csswg-test/css-grid-1/grid-model/grid-first-line-002-expected.xht: Added.
• csswg-test/css-grid-1/grid-model/grid-first-line-002.xht: Added.
• csswg-test/css-grid-1/grid-model/grid-first-line-003-expected.xht: Added.
• csswg-test/css-grid-1/grid-model/grid-first-line-003.xht: Added.
• csswg-test/css-grid-1/grid-model/grid-float-001-expected.xht: Added.
• csswg-test/css-grid-1/grid-model/grid-float-001.xht: Added.
• csswg-test/css-grid-1/grid-model/grid-floats-no-intrude-001-expected.xht: Added.
• csswg-test/css-grid-1/grid-model/grid-floats-no-intrude-001.xht: Added.
• csswg-test/css-grid-1/grid-model/grid-inline-first-letter-001-expected.xht: Added.
• csswg-test/css-grid-1/grid-model/grid-inline-first-letter-001.xht: Added.
• csswg-test/css-grid-1/grid-model/grid-inline-first-letter-002-expected.xht: Added.
• csswg-test/css-grid-1/grid-model/grid-inline-first-letter-002.xht: Added.
• csswg-test/css-grid-1/grid-model/grid-inline-first-letter-003-expected.xht: Added.
• csswg-test/css-grid-1/grid-model/grid-inline-first-letter-003.xht: Added.
• csswg-test/css-grid-1/grid-model/grid-inline-first-line-001-expected.xht: Added.
• csswg-test/css-grid-1/grid-model/grid-inline-first-line-001.xht: Added.
• csswg-test/css-grid-1/grid-model/grid-inline-first-line-002-expected.xht: Added.
• csswg-test/css-grid-1/grid-model/grid-inline-first-line-002.xht: Added.
• csswg-test/css-grid-1/grid-model/grid-inline-first-line-003-expected.xht: Added.
• csswg-test/css-grid-1/grid-model/grid-inline-first-line-003.xht: Added.
• csswg-test/css-grid-1/grid-model/grid-inline-float-001-expected.xht: Added.
• csswg-test/css-grid-1/grid-model/grid-inline-float-001.xht: Added.
• csswg-test/css-grid-1/grid-model/grid-inline-floats-no-intrude-001-expected.xht: Added.
• csswg-test/css-grid-1/grid-model/grid-inline-floats-no-intrude-001.xht: Added.
• csswg-test/css-grid-1/grid-model/grid-inline-margins-no-collapse-001-expected.xht: Added.
• csswg-test/css-grid-1/grid-model/grid-inline-margins-no-collapse-001.xht: Added.
• csswg-test/css-grid-1/grid-model/grid-inline-multicol-001-expected.xht: Added.
• csswg-test/css-grid-1/grid-model/grid-inline-multicol-001.xht: Added.
• csswg-test/css-grid-1/grid-model/grid-inline-vertical-align-001-expected.xht: Added.
• csswg-test/css-grid-1/grid-model/grid-inline-vertical-align-001.xht: Added.
• csswg-test/css-grid-1/grid-model/grid-margins-no-collapse-001-expected.xht: Added.
• csswg-test/css-grid-1/grid-model/grid-margins-no-collapse-001.xht: Added.
• csswg-test/css-grid-1/grid-model/grid-multicol-001-expected.xht: Added.
• csswg-test/css-grid-1/grid-model/grid-multicol-001.xht: Added.
• csswg-test/css-grid-1/grid-model/grid-support-display-001-expected.txt: Added.
• csswg-test/css-grid-1/grid-model/grid-support-display-001.xht: Added.
• csswg-test/css-grid-1/grid-model/grid-vertical-align-001-expected.xht: Added.
• csswg-test/css-grid-1/grid-model/grid-vertical-align-001.xht: Added.
• csswg-test/css-grid-1/grid-model/w3c-import.log: Added.
• csswg-test/css-grid-1/implicit-grids/grid-support-grid-auto-columns-rows-001-expected.html: Added.
• csswg-test/css-grid-1/implicit-grids/grid-support-grid-auto-columns-rows-001.html: Added.
• csswg-test/css-grid-1/implicit-grids/w3c-import.log: Added.
• csswg-test/css-grid-1/layout-algorithm/grid-layout-free-space-unit-expected.html: Added.
• csswg-test/css-grid-1/layout-algorithm/grid-layout-free-space-unit.html: Added.
• csswg-test/css-grid-1/layout-algorithm/w3c-import.log: Added.
• csswg-test/css-grid-1/placement/grid-layout-grid-span-expected.html: Added.
• csswg-test/css-grid-1/placement/grid-layout-grid-span.html: Added.
• csswg-test/css-grid-1/placement/grid-layout-lines-expected.html: Added.
• csswg-test/css-grid-1/placement/grid-layout-lines-shorthands-expected.html: Added.
• csswg-test/css-grid-1/placement/grid-layout-lines-shorthands.html: Added.
• csswg-test/css-grid-1/placement/grid-layout-lines.html: Added.
• csswg-test/css-grid-1/placement/grid-layout-placement-shorthands-expected.html: Added.
• csswg-test/css-grid-1/placement/grid-layout-placement-shorthands.html: Added.
• csswg-test/css-grid-1/placement/w3c-import.log: Added.
• csswg-test/css-grid-1/test-plan/index.html: Added.
• csswg-test/css-grid-1/test-plan/w3c-import.log: Added.
• csswg-test/css-grid-1/w3c-import.log: Added.
• resources/import-expectations.json:
• resources/resource-files.json:

LayoutTests:

A few tests are not passing yet, so the TextExpectations file
has been updated accordingly linking the different bugs.

• TestExpectations:

11:01 AM Changeset in webkit [213456] by clopez@igalia.com

• 2 edits in trunk/JSTests

[JSC] [Linux] Test stress/spread-forward-call-varargs-stack-overflow.js fails
​https://bugs.webkit.org/show_bug.cgi?id=169206

Unreviewed test gardening.

• stress/spread-forward-call-varargs-stack-overflow.js: Skip on Linux platforms.

10:00 AM Changeset in webkit [213455] by hyatt@apple.com

• 38 edits
  22 adds
  2 deletes in trunk

Enable fieldsets to be flexboxes, grids and multicolumn.
​https://bugs.webkit.org/show_bug.cgi?id=169082

Source/WebCore:

Reviewed by Simon Fraser .

Added new tests in fast/forms/fieldset.

This patch eliminates RenderFieldset and moves the functionality into RenderBlock so that
derived classes can also be fieldsets.

• CMakeLists.txt:
• WebCore.xcodeproj/project.pbxproj:

Remove RenderFieldset from the project.

• accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::titleUIElement):
Call in to RenderBlock now instead of RenderFieldset.

• html/HTMLFieldSetElement.cpp:

(WebCore::HTMLFieldSetElement::createElementRenderer):

• html/HTMLFieldSetElement.h:

The fieldset DOM element now uses RenderElement::createFor to make renderers so that multiple display types
can be supported. A special flag has been added that indicates only to make flexbox and block-related
renderers (not table display types).

• rendering/OrderIterator.cpp:

(WebCore::OrderIterator::shouldSkipChild):
(WebCore::OrderIteratorPopulator::collectChild):

• rendering/OrderIterator.h:

Streamline child collection for flexboxes and grids to indicate whether the child should be skipped as a return
value from collectChild. Add a shouldSkipChild method that skips both out of flow positioned objects and
excluded children like the legends of fieldsets.

• rendering/RenderBlock.cpp:

(WebCore::RenderBlockRareData::RenderBlockRareData):
When the legend is taller than the fieldset's borderBefore(), intrinsic border is added to the CSS border width.
This intrinsic border being factored in ensures that the padding and content boxes of fieldsets are correct
across any layout system, since the legend is now just treated as part of the border.

(WebCore::RenderBlock::computePreferredLogicalWidths):
(WebCore::RenderBlock::computeBlockPreferredLogicalWidths):
Call the new computePreferredWidthsForExcludedChildren to ensure that excluded children contribute to
preferred width in their own way and not as part of a specific layout system.

(WebCore::RenderBlock::renderName):
Hacked to still return RenderFieldSet for RenderBlockFlow-backed fieldsets for layout test compatibility.

(WebCore::RenderBlock::layoutExcludedChildren):
Renamed from layoutSpecialExcludedChild to more accurately reflect the fact that multiple excluded children
can be included here (e.g., both a multicolumn flow thread and a legend). The RenderBlock base class handles
the layout of legends by both placing them and setting the correct intrinsic border before amount on the
block.

(WebCore::RenderBlock::findFieldsetLegend):
Moved from RenderFieldset.

(WebCore::RenderBlock::adjustBorderBoxRectForPainting):
(WebCore::RenderBlock::paintRectToClipOutFromBorder):
These methods are used when painting to shrink the border box as needed to account for the legend and to
provide the portion of the border that needs to be clipped out. These methods have been enhanced to
properly support all writing modes.

(WebCore::RenderBlock::intrinsicBorderForFieldset):
(WebCore::RenderBlock::setIntrinsicBorderForFieldset):
(WebCore::RenderBlock::borderTop):
(WebCore::RenderBlock::borderLeft):
(WebCore::RenderBlock::borderBottom):
(WebCore::RenderBlock::borderRight):
(WebCore::RenderBlock::borderBefore):
These methods are overridden for border to ensure that the intrinsic border added by a tall legend is
properly factored in.

(WebCore::RenderBlock::computePreferredWidthsForExcludedChildren):

• rendering/RenderBlock.h:

This method computes the preferred widths for legend children in order to ensure that the legend properly
grows the width of the fieldset when it is the widest item.

(WebCore::RenderBlock::adjustBorderBoxLogicalHeightForBoxSizing):
(WebCore::RenderBlock::adjustContentBoxLogicalHeightForBoxSizing):
Preserve the behavior of fieldsets in that the available content size includes the space lost accounting
for the legend. I don't think this makes much sense, but it matches the behavior of other browsers
(and our old behavior).

(WebCore::RenderBlock::paintExcludedChildrenInBorder):
Method for painting the excluded children that might be present in our border. We only do this if the
paint phase is a box decoration painting phase and if the legend isn't self-painting.

• rendering/RenderBlockFlow.cpp:

(WebCore::RenderBlockFlow::willCreateColumns):
Allow fieldsets to create columns now.

(WebCore::RenderBlockFlow::layoutBlockChildren):
(WebCore::RenderBlockFlow::layoutExcludedChildren):
Renamed this method and change it to call the base class to ensure that legends in multicolumn fieldsets
get handled properly.

(WebCore::RenderBlockFlow::addChild):
Patched to make sure legends don't get put into the multicolumn flow thread, as they need to
remain outside of it.

(WebCore::RenderBlockFlow::layoutSpecialExcludedChild): Deleted.
Renamed to layoutExcludedChildren.

• rendering/RenderBlockFlow.h:
• rendering/RenderBox.cpp:

(WebCore::RenderBox::paintBoxDecorations):
(WebCore::RenderBox::paintMask):
Patched to call the new adjustBorderBoxRectForPainting and paintRectToClipOutFromBorder methods in
order to properly shrink the border box rect for painting and to clip out the portion of the border
covered by the legend.

(WebCore::RenderBox::avoidsFloats):
Add fieldsets as avoiding floats. RenderFieldset used to subclass this method to return true, but with
its removal, we need to put this in the base class along with legends.

• rendering/RenderBox.h:

(WebCore::RenderBox::isGridItem):
(WebCore::RenderBox::isFlexItem):
Patched to exclude legends so that they don't try to size like they are really in the grid or flexbox.

(WebCore::RenderBox::adjustBorderBoxRectForPainting):
This method is overridden by RenderBLock to handle adjusting fieldset border rects for painting.

• rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::paintBorder):

• rendering/RenderBoxModelObject.h:

(WebCore::RenderBoxModelObject::paintRectToClipOutFromBorder):
Patched to properly paint fieldsets using the new helpers.

• rendering/RenderDeprecatedFlexibleBox.cpp:

(WebCore::FlexBoxIterator::next):
(WebCore::RenderDeprecatedFlexibleBox::layoutBlock):
(WebCore::RenderDeprecatedFlexibleBox::layoutHorizontalBox):
Make sure deprecated flexible boxes lay out their legends properly by calling layoutExcludedChildren.

• rendering/RenderElement.cpp:

(WebCore::RenderElement::createFor):

• rendering/RenderElement.h:

Patched to take a flag that limits what renderers can be created so that fieldsets don't make table
display types.

• rendering/RenderFieldset.cpp: Removed.
• rendering/RenderFieldset.h: Removed.

Remove RenderFieldset files from the tree.

• rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::computeIntrinsicLogicalWidths):
(WebCore::RenderFlexibleBox::firstLineBaseline):
(WebCore::RenderFlexibleBox::layoutBlock):
(WebCore::RenderFlexibleBox::layoutFlexItems):
(WebCore::RenderFlexibleBox::prepareOrderIteratorAndMargins):
Make sure flexible boxes lay out their legends properly by calling layoutExcludedChildren.
Patch methods to use the OrderIterator's new shouldSkipChild method to ensure legends aren't
part of the flexible box layout.

• rendering/RenderGrid.cpp:

(WebCore::RenderGrid::layoutBlock):
(WebCore::RenderGrid::computeIntrinsicLogicalWidths):
(WebCore::RenderGrid::placeItemsOnGrid):
(WebCore::RenderGrid::populateExplicitGridAndOrderIterator):
(WebCore::RenderGrid::layoutGridItems):
Make sure grids lay out their legends properly by calling layoutExcludedChildren.
Patch methods to use the OrderIterator's new shouldSkipChild method to ensure legends aren't
part of the grid's layout.

• rendering/RenderMultiColumnFlowThread.cpp:

(WebCore::RenderMultiColumnFlowThread::populate):
Pull legends back up into the block and don't let them be part of the flow thread.

• rendering/RenderMultiColumnSet.cpp:

(WebCore::RenderMultiColumnSet::requiresBalancing):
Fix an assert to allow legends to exist as siblings of multicolumn sets.

• rendering/RenderObject.cpp:

(WebCore::RenderObject::isFieldset):
Changed to examine the HTML element rather than RenderFieldset.

• rendering/RenderObject.h:

(WebCore::RenderObject::isExcludedFromNormalLayout):
(WebCore::RenderObject::setIsExcludedFromNormalLayout):
(WebCore::RenderObject::RenderObjectBitfields::RenderObjectBitfields):
RenderObjects now have a new bit that is set for excluded objects like legends, flow threads,
placeholders, and ruby text. This bit lets code easily detect that an object is excluded from
the layout system and can be skipped.

(WebCore::RenderObject::isExcludedAndPlacedInBorder):
Helper method for asking if an object is painting inside the border. Used to know we
need to factor it into preferred width calculations outside of any one layout system
and also to know that we need to paint it when we paint the fieldset's border instead of
later (after we might have scrolled or clipped the child painting area).

• rendering/RenderRubyRun.cpp:

(WebCore::RenderRubyRun::layoutExcludedChildren):
(WebCore::RenderRubyRun::layoutSpecialExcludedChild): Deleted.

• rendering/RenderRubyRun.h:

Rename layoutSpecialExcludedChild to layoutExcludedChildren.

• rendering/RenderTable.cpp:

(WebCore::RenderTable::adjustBorderBoxRectForPainting):
(WebCore::RenderTable::paintBoxDecorations):
(WebCore::RenderTable::paintMask):
(WebCore::RenderTable::subtractCaptionRect): Deleted.

• rendering/RenderTable.h:

Patched tables to share the same border box rect adjustment used by fieldsets when subtracting
out captions. This is prep work to allow tables to be fieldsets, but for now I didn't go all the
way.

• rendering/RenderTableCell.cpp:

(WebCore::RenderTableCell::paintBoxDecorations):
(WebCore::RenderTableCell::paintMask):
Make sure table cells adjust their border box rects for painting. Again this is prep work for
cells potentially being fieldsets, but not supported yet.

• rendering/RenderTextControl.cpp:

(WebCore::RenderTextControl::layoutExcludedChildren):
(WebCore::RenderTextControl::layoutSpecialExcludedChild): Deleted.

• rendering/RenderTextControl.h:
• rendering/RenderTextControlMultiLine.cpp:

(WebCore::RenderTextControlMultiLine::layoutExcludedChildren):
(WebCore::RenderTextControlMultiLine::layoutSpecialExcludedChild): Deleted.

• rendering/RenderTextControlMultiLine.h:

Renamed the methods for doing the excluded child layout.

• rendering/RenderTreeAsText.cpp:

(WebCore::RenderTreeAsText::writeRenderObject):
Make sure to dump the original fieldset border and not the border with the extra legend stuff in it.

LayoutTests:

Reviewed by Simon Fraser.

• fast/forms/fieldset/abs-pos-child-sizing-expected.html: Added.
• fast/forms/fieldset/abs-pos-child-sizing.html: Added.
• fast/forms/fieldset/fieldset-deprecated-flexbox-expected.html: Added.
• fast/forms/fieldset/fieldset-deprecated-flexbox.html: Added.
• fast/forms/fieldset/fieldset-flexbox-expected.html: Added.
• fast/forms/fieldset/fieldset-flexbox.html: Added.
• fast/forms/fieldset/fieldset-grid-expected.html: Added.
• fast/forms/fieldset/fieldset-grid.html: Added.
• fast/forms/fieldset/fieldset-multicolumn-expected.html: Added.
• fast/forms/fieldset/fieldset-multicolumn.html: Added.
• fast/forms/fieldset/fieldset-overflow-auto-expected.html: Added.
• fast/forms/fieldset/fieldset-overflow-auto.html: Added.
• fast/forms/fieldset/fieldset-overflow-hidden-expected.html: Added.
• fast/forms/fieldset/fieldset-overflow-hidden.html: Added.
• fast/forms/fieldset/fieldset-positioned-children-expected.html: Added.
• fast/forms/fieldset/fieldset-positioned-children.html: Added.
• fast/forms/fieldset/fieldset-positioned-legend-expected.html: Added.
• fast/forms/fieldset/fieldset-positioned-legend.html: Added.
• fast/forms/fieldset/fieldset-self-painting-legend-expected.html: Added.
• fast/forms/fieldset/fieldset-self-painting-legend.html: Added.
• fast/forms/fieldset/fieldset-writing-modes-expected.html: Added.
• fast/forms/fieldset/fieldset-writing-modes.html: Added.

9:49 AM Changeset in webkit [213454] by commit-queue@webkit.org

• 12 edits
  1 copy
  1 add in trunk

[Modern Media Controls] Tracks panel should clip and scroll content when numerous tracks are available
​https://bugs.webkit.org/show_bug.cgi?id=169201
<rdar://problem/30867979>

Patch by Antoine Quint <Antoine Quint> on 2017-03-06
Reviewed by Eric Carlson.

Source/WebCore:

We now position and size the tracks panel dynamically and ensure a max-height is applied
to the panel so that it allows a margin of 10px above it within the media controls. We also
apply that same max-height to a new intermediary scrollable container for the track lists,
so that it scrolls independently of the container and the background tint.

Test: media/modern-media-controls/tracks-panel/tracks-panel-position-and-size.html

• Modules/modern-media-controls/controls/macos-fullscreen-media-controls.js:

(MacOSFullscreenMediaControls.prototype.showTracksPanel): Deleted.

• Modules/modern-media-controls/controls/macos-inline-media-controls.css:

(.media-controls.mac.inline .volume.slider):
(.media-controls.mac.inline .tracks-panel): Deleted.

• Modules/modern-media-controls/controls/macos-inline-media-controls.js:

(MacOSInlineMediaControls.prototype.showTracksPanel): Deleted.

• Modules/modern-media-controls/controls/macos-media-controls.js:

(MacOSMediaControls.prototype.showTracksPanel):

• Modules/modern-media-controls/controls/tracks-panel.css:

(.tracks-panel > .background-tint > div,):
(.tracks-panel > .scrollable-container):
(.tracks-panel section):
(.tracks-panel section:first-of-type):
(.tracks-panel section > h3):
(.tracks-panel section > ul):
(.tracks-panel section > ul > li):
(.tracks-panel section > ul > li:focus):
(.tracks-panel section > ul > li.selected:before):
(.tracks-panel section > ul > li.animated):
(.tracks-panel > .background-tint > div): Deleted.
(.tracks-panel > section): Deleted.
(.tracks-panel > section:first-of-type): Deleted.
(.tracks-panel > section > h3): Deleted.
(.tracks-panel > section > ul): Deleted.
(.tracks-panel > section > ul > li): Deleted.
(.tracks-panel > section > ul > li:focus): Deleted.
(.tracks-panel > section > ul > li.selected:before): Deleted.
(.tracks-panel > section > ul > li.animated): Deleted.

• Modules/modern-media-controls/controls/tracks-panel.js:

(TracksPanel.prototype.presentInParent):
(TracksPanel.prototype.get maxHeight):
(TracksPanel.prototype.set maxHeight):
(TracksPanel.prototype.commitProperty):
(TracksPanel.prototype._childrenFromDataSource):

LayoutTests:

Rebaseline a couple of existing tests to account for the DOM structure change in
the tracks panel and the fact that positioning is now dependent on the bounds of
the tracks button.

We also add a new test that checks that the tracks panel is positioned and sized
correctly to ensure that it can be scrolled when it has too many tracks to fit.

• media/modern-media-controls/tracks-panel/tracks-panel-population-expected.txt:
• media/modern-media-controls/tracks-panel/tracks-panel-population.html:
• media/modern-media-controls/tracks-panel/tracks-panel-position-and-size-expected.txt: Added.
• media/modern-media-controls/tracks-panel/tracks-panel-position-and-size.html: Added.
• media/modern-media-controls/tracks-panel/tracks-panel-select-track-with-mouse-expected.txt:
• media/modern-media-controls/tracks-panel/tracks-panel-select-track-with-mouse.html:

9:26 AM Changeset in webkit [213453] by Yusuke Suzuki

• 5 edits in trunk

[JSC] Allow indexed module namespace object fields
​https://bugs.webkit.org/show_bug.cgi?id=168870

Reviewed by Saam Barati.

JSTests:

• wasm/spec-tests/names.wast.js:

Source/JavaScriptCore:

While JS modules cannot expose any indexed bindings,
Wasm modules can expose them. However, module namespace
object currently does not support indexed properties.
This patch allows module namespace objects to offer
indexed binding accesses.

• runtime/JSModuleNamespaceObject.cpp:

(JSC::JSModuleNamespaceObject::getOwnPropertySlotCommon):
(JSC::JSModuleNamespaceObject::getOwnPropertySlot):
(JSC::JSModuleNamespaceObject::getOwnPropertySlotByIndex):

• runtime/JSModuleNamespaceObject.h:

8:57 AM Changeset in webkit [213452] by Yusuke Suzuki

• 4 edits
  2 adds in trunk

Null pointer crash when loading module with unresolved import also as a script file
​https://bugs.webkit.org/show_bug.cgi?id=168971

Reviewed by Saam Barati.

JSTests:

• stress/re-execute-error-module.js: Added.

(shouldBe):
(async):

• stress/resources/error-module.js: Added.

Source/JavaScriptCore:

If linking throws an error, this error should be re-thrown
when requesting the same module.

• builtins/ModuleLoaderPrototype.js:

(globalPrivate.newRegistryEntry):

• runtime/JSModuleRecord.cpp:

(JSC::JSModuleRecord::link):

8:02 AM Changeset in webkit [213451] by Yusuke Suzuki

• 2 edits in trunk

Unreviewed, fix AppleWin build
​https://bugs.webkit.org/show_bug.cgi?id=164032

• Source/cmake/WebKitFeatures.cmake:

7:43 AM Changeset in webkit [213450] by Yusuke Suzuki

• 12 edits in trunk

[GTK][JSCOnly] Enable WebAssembly on Linux environment
​https://bugs.webkit.org/show_bug.cgi?id=164032

Reviewed by Michael Catanzaro.

.:

• Source/cmake/OptionsGTK.cmake:
• Source/cmake/OptionsJSCOnly.cmake:
• Source/cmake/OptionsMac.cmake:
• Source/cmake/WebKitFeatures.cmake:

Source/JavaScriptCore:

This patch enables WebAssembly on JSCOnly and GTK ports.
Basically, almost all the WASM code is portable to Linux.
One platform-dependent part is faster memory load using SIGBUS
signal handler. This patch ports this part to Linux.

• CMakeLists.txt:
• llint/LLIntSlowPaths.cpp:

(JSC::LLInt::LLINT_SLOW_PATH_DECL):

• wasm/WasmFaultSignalHandler.cpp:

(JSC::Wasm::trapHandler):
(JSC::Wasm::enableFastMemory):

Tools:

• Scripts/run-jsc-stress-tests:

Enable WASM tests.

• Scripts/webkitperl/FeatureList.pm:

Enable WebAssembly.

7:30 AM Changeset in webkit [213449] by Manuel Rego Casasnovas

• 6 edits in trunk

[css-grid] Stretch should grow and shrink items to fit its grid area
​https://bugs.webkit.org/show_bug.cgi?id=163200

Reviewed by Darin Adler.

Source/WebCore:

After some discussions the CSS WG agreed that stretch should not only
grow items, but also shrink them to fit its grid area.
That way the "min-width|height: auto" is somehow ignored for grid items.
More info at: ​https://github.com/w3c/csswg-drafts/issues/283

The good part is that this allows us to remove some ugly code we've
in RenderBox that was only used by Grid Layout.

For images, we'll be stretching on both axis right now, so the aspect
ratio won't be preserved. The default behavior might change in those
cases, but that should be implemented in a different patch.

• rendering/RenderBox.cpp:

(WebCore::RenderBox::computeLogicalWidthInRegion):
(WebCore::RenderBox::computeLogicalHeight):

LayoutTests:

The tests have been updated according to the new expected behavior.

• fast/css-grid-layout/grid-container-percentage-columns.html:
• fast/css-grid-layout/min-width-height-auto-and-margins.html:
• fast/css-grid-layout/min-width-height-auto.html:

6:19 AM Changeset in webkit [213448] by magomez@igalia.com

• 2 edits in trunk/Source/WebCore

[GTK] WebProcess from WebKitGtk+ 2.15.x SIGSEVs in GIFLZWContext::doLZW(unsigned char const*, unsigned long) at Source/WebCore/platform/image-decoders/gif/GIFImageReader.cpp:303
​https://bugs.webkit.org/show_bug.cgi?id=167304

Reviewed by Carlos Garcia Campos.

Add a lock to ensure that the GIFImageReader that we are using for decoding is not deleted while
the decoding thread is using it.

No new tests.

• platform/image-decoders/gif/GIFImageDecoder.cpp:

(WebCore::GIFImageDecoder::clearFrameBufferCache):

6:06 AM Changeset in webkit [213447] by commit-queue@webkit.org

• 2 edits in trunk/Source/JavaScriptCore

Currency digits calculation in Intl.NumberFormat should call out to ICU
​https://bugs.webkit.org/show_bug.cgi?id=169182

Patch by Daniel Ehrenberg <​littledan@igalia.com> on 2017-03-06
Reviewed by Yusuke Suzuki.

• runtime/IntlNumberFormat.cpp:

(JSC::computeCurrencyDigits):
(JSC::computeCurrencySortKey): Deleted.
(JSC::extractCurrencySortKey): Deleted.

4:19 AM Changeset in webkit [213446] by Antti Koivisto

• 16 edits in trunk

Allow render tree building before loading stylesheet elements
​https://bugs.webkit.org/show_bug.cgi?id=169079
Source/WebCore:

<rdar://problem/30865709>

Reviewed by Andreas Kling.

Currently we don't resolve style or construct renderers if there are any pending
stylesheet loads. This patch enables style and renderer constuction up to the
first encountered loading style element.

This is a step toward allowing incremental rendering for in-body stylesheets.

• dom/Document.cpp:

(WebCore::Document::needsStyleRecalc):

Ensure scrolling to anchor eventually happens.

• dom/Document.h:

(WebCore::Document::isIgnoringPendingStylesheets):

• dom/InlineStyleSheetOwner.cpp:

(WebCore::InlineStyleSheetOwner::createSheet):
(WebCore::InlineStyleSheetOwner::sheetLoaded):
(WebCore::InlineStyleSheetOwner::startLoadingDynamicSheet):

• dom/ProcessingInstruction.cpp:

(WebCore::ProcessingInstruction::checkStyleSheet):
(WebCore::ProcessingInstruction::sheetLoaded):
(WebCore::ProcessingInstruction::removedFrom):

• html/HTMLLinkElement.cpp:

(WebCore::HTMLLinkElement::addPendingSheet):
(WebCore::HTMLLinkElement::removePendingSheet):

• style/StyleScope.cpp:

(WebCore::Style::Scope::addPendingSheet):
(WebCore::Style::Scope::removePendingSheet):

Track pending sheet nodes in a map so we can test if a given node has a pending sheet.
This is also more robust in general.

(WebCore::Style::Scope::hasProcessingInstructionWithPendingSheet):
(WebCore::Style::Scope::updateActiveStyleSheets):

• style/StyleScope.h:

(WebCore::Style::Scope::hasPendingSheet):
(WebCore::Style::Scope::hasPendingSheets):
(WebCore::Style::Scope::addPendingSheet): Deleted.

• style/StyleTreeResolver.cpp:

(WebCore::Style::TreeResolver::styleForElement):

Instead of global test for placeholder construction check the status of the pending sheet flag.

(WebCore::Style::hasLoadingStylesheet):
(WebCore::Style::TreeResolver::resolveComposedTree):

Set a flag when encountering a pending top level sheet during DOM traversal.

(WebCore::Style::TreeResolver::resolve):

• style/StyleTreeResolver.h:
• svg/graphics/SVGImage.cpp:

(WebCore::SVGImage::dataChanged):

Ensure SVG images have layout before getting the size.

LayoutTests:

Reviewed by Andreas Kling.

Ensure that style is synchronized after adding a stylesheet dynamically by doing an additional test.
Otherwise the class/attr invalidation test may as we don't know about the new stylesheet yet.
This is functionally fine (future synchronization would invalidate the style) but messes up the test
trying to verify class/attr change invalidation specifically.

• fast/css/style-invalidation-attribute-change-descendants-expected.txt:
• fast/css/style-invalidation-attribute-change-descendants.html:
• fast/css/style-invalidation-class-change-descendants-expected.txt:
• fast/css/style-invalidation-class-change-descendants.html:

2:32 AM Changeset in webkit [213445] by commit-queue@webkit.org

• 18 edits in trunk/Source/WebCore

[GStreamer] Adopt nullptr
​https://bugs.webkit.org/show_bug.cgi?id=123438

Patch by Vanessa Chipirrás Navalón <​vchipirras@igalia.com> on 2017-03-06
Reviewed by Xabier Rodriguez-Calvar.

To adapt the code to the C++11 standard, all NULL or 0 pointers have been changed to nullptr.

• platform/audio/gstreamer/AudioDestinationGStreamer.cpp:

(WebCore::AudioDestinationGStreamer::AudioDestinationGStreamer):

• platform/audio/gstreamer/AudioFileReaderGStreamer.cpp:

(WebCore::AudioFileReader::handleNewDeinterleavePad):
(WebCore::AudioFileReader::plugDeinterleave):
(WebCore::AudioFileReader::decodeAudioForBusCreation):

• platform/audio/gstreamer/AudioSourceProviderGStreamer.cpp:

(WebCore::AudioSourceProviderGStreamer::AudioSourceProviderGStreamer):
(WebCore::AudioSourceProviderGStreamer::configureAudioBin):
(WebCore::AudioSourceProviderGStreamer::setClient):
(WebCore::AudioSourceProviderGStreamer::handleNewDeinterleavePad):

• platform/audio/gstreamer/WebKitWebAudioSourceGStreamer.cpp:

(webkit_web_audio_src_init):
(webKitWebAudioSrcLoop):
(webKitWebAudioSrcChangeState):

• platform/graphics/gstreamer/AudioTrackPrivateGStreamer.cpp:

(WebCore::AudioTrackPrivateGStreamer::setEnabled):

• platform/graphics/gstreamer/GStreamerUtilities.cpp:

(WebCore::initializeGStreamer):

• platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:

(WebCore::MediaPlayerPrivateGStreamer::setAudioStreamProperties):
(WebCore::MediaPlayerPrivateGStreamer::registerMediaEngine):
(WebCore::initializeGStreamerAndRegisterWebKitElements):
(WebCore::MediaPlayerPrivateGStreamer::MediaPlayerPrivateGStreamer):
(WebCore::MediaPlayerPrivateGStreamer::~MediaPlayerPrivateGStreamer):
(WebCore::MediaPlayerPrivateGStreamer::newTextSample):
(WebCore::MediaPlayerPrivateGStreamer::handleMessage):
(WebCore::MediaPlayerPrivateGStreamer::processTableOfContents):
Removed the unused second argument on processTableOfContentsEntry function.
(WebCore::MediaPlayerPrivateGStreamer::processTableOfContentsEntry):
Removed the unused second argument on this function.
(WebCore::MediaPlayerPrivateGStreamer::fillTimerFired):
(WebCore::MediaPlayerPrivateGStreamer::loadNextLocation):
(WebCore::MediaPlayerPrivateGStreamer::createAudioSink):
(WebCore::MediaPlayerPrivateGStreamer::createGSTPlayBin):

• platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:

Removed the unused second argument on processTableOfContentsEntry function.

• platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:

(WebCore::MediaPlayerPrivateGStreamerBase::MediaPlayerPrivateGStreamerBase):
(WebCore::MediaPlayerPrivateGStreamerBase::setMuted):
(WebCore::MediaPlayerPrivateGStreamerBase::muted):
(WebCore::MediaPlayerPrivateGStreamerBase::notifyPlayerOfMute):
(WebCore::MediaPlayerPrivateGStreamerBase::setStreamVolumeElement):
(WebCore::MediaPlayerPrivateGStreamerBase::decodedFrameCount):
(WebCore::MediaPlayerPrivateGStreamerBase::droppedFrameCount):

• platform/graphics/gstreamer/MediaPlayerPrivateGStreamerOwr.cpp:

(WebCore::MediaPlayerPrivateGStreamerOwr::registerMediaEngine):

• platform/graphics/gstreamer/TextCombinerGStreamer.cpp:

(webkit_text_combiner_init):
(webkitTextCombinerPadEvent):
(webkitTextCombinerRequestNewPad):
(webkitTextCombinerNew):

• platform/graphics/gstreamer/TextSinkGStreamer.cpp:

(webkitTextSinkNew):

• platform/graphics/gstreamer/TrackPrivateBaseGStreamer.cpp:

(WebCore::TrackPrivateBaseGStreamer::tagsChanged):
(WebCore::TrackPrivateBaseGStreamer::notifyTrackOfActiveChanged):

• platform/graphics/gstreamer/VideoSinkGStreamer.cpp:

(webkit_video_sink_init):
(webkitVideoSinkProposeAllocation):
(webkitVideoSinkNew):

• platform/graphics/gstreamer/VideoTrackPrivateGStreamer.cpp:

(WebCore::VideoTrackPrivateGStreamer::setSelected):

• platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:

(webkit_web_src_init):
(webKitWebSrcDispose):
(webKitWebSrcSetProperty):
(webKitWebSrcStop):
(webKitWebSrcChangeState):
(webKitWebSrcQueryWithParent):
(webKitWebSrcGetProtocols):
(StreamingClient::handleResponseReceived):
(StreamingClient::handleDataReceived):
(ResourceHandleStreamingClient::didFail):
(ResourceHandleStreamingClient::wasBlocked):
(ResourceHandleStreamingClient::cannotShowURL):

• platform/graphics/gstreamer/mse/WebKitMediaSourceGStreamer.cpp:

(webKitMediaSrcGetProtocols):

2:02 AM Changeset in webkit [213444] by akling@apple.com

• 10 edits in trunk/Source

[iOS] Report domains crashing under memory pressure via enhanced privacy logging.
<​https://webkit.org/b/169133>
<rdar://problem/29964017>

Reviewed by Antti Koivisto.

Source/WebCore:

• page/DiagnosticLoggingKeys.h:

Source/WebKit2:

Notify the UI process when the memory pressure status changes.
If a web process crashes while under memory pressure, log the domain of the last open page
using enhanced privacy logging.

• UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::processDidCrash):

• UIProcess/WebProcessProxy.h:

(WebKit::WebProcessProxy::memoryPressureStatusChanged):
(WebKit::WebProcessProxy::isUnderMemoryPressure):

• UIProcess/WebProcessProxy.messages.in:
• WebProcess/WebProcess.cpp:

(WebKit::WebProcess::initializeWebProcess):

Source/WTF:

Add a mechanism for getting a callback when the memory pressure status changes.

• wtf/MemoryPressureHandler.cpp:

(WTF::MemoryPressureHandler::measurementTimerFired):
(WTF::MemoryPressureHandler::beginSimulatedMemoryPressure):
(WTF::MemoryPressureHandler::endSimulatedMemoryPressure):
(WTF::MemoryPressureHandler::setUnderMemoryPressure):
(WTF::MemoryPressureHandler::memoryPressureStatusChanged):

• wtf/MemoryPressureHandler.h:

(WTF::MemoryPressureHandler::setMemoryPressureStatusChangedCallback):
(WTF::MemoryPressureHandler::setUnderMemoryPressure): Deleted.