Timeline

Mar 15, 2017:

11:48 PM Changeset in webkit [214032] by achristensen@apple.com

• 2 edits in trunk/Source/WebKit2

Fix CMake build.

• PlatformMac.cmake:

11:29 PM Changeset in webkit [214031] by Dewei Zhu

• 3 edits in trunk/Websites/perf.webkit.org

Fix unit test and bug fix for 'pull-os-versions.js' script.
​https://bugs.webkit.org/show_bug.cgi?id=169701

Reviewed by Ryosuke Niwa.

Fix unit tests warnings on node-6.10.0.
Fix 'pull-os-versions.js' does not fetch new builds and report.

• server-tests/tools-os-build-fetcher-tests.js:

(then):
(beforeEach):
(afterEach):

• tools/pull-os-versions.js:

(syncLoop):

11:10 PM Changeset in webkit [214030] by jonlee@apple.com

• 23 edits
  6 adds in trunk/Source/WebCore

Flatten RTC enum naming
​https://bugs.webkit.org/show_bug.cgi?id=169664

Reviewed by Youenn Fablet.

Use consistent names of RTC enums throughout WebCore. This means surfacing
ICE enums out of PeerConnectionState. Keep the old names around for other
ports.

Add RTCIceConnectionState, RTCIceGatheringState, and RTCSignalingState enums.

• CMakeLists.txt:
• DerivedSources.make:
• Modules/mediastream/RTCIceConnectionState.h: Added. The enum is defined in

PeerConnectionStates.h, so just include that file.

• Modules/mediastream/RTCIceConnectionState.idl: Added.
• Modules/mediastream/RTCIceGatheringState.h: Added.
• Modules/mediastream/RTCIceGatheringState.idl: Added.
• Modules/mediastream/RTCSignalingState.h: Added.
• Modules/mediastream/RTCSignalingState.idl: Added.
• WebCore.xcodeproj/project.pbxproj:

• platform/mediastream/PeerConnectionStates.h: Move the existing enums into

WebCore, but keep aliases to the old names within the PeerConnectionStates
namespace.

Refactor to use the new enum names.

• Modules/mediastream/MediaEndpointPeerConnection.cpp: Refactor.
• Modules/mediastream/MediaEndpointPeerConnection.h:
• Modules/mediastream/PeerConnectionBackend.cpp:
• Modules/mediastream/PeerConnectionBackend.h:
• Modules/mediastream/RTCConfiguration.h:
• Modules/mediastream/RTCConfiguration.idl: Add FIXMEs for bringing this up

to spec.

• Modules/mediastream/RTCIceTransport.h:
• Modules/mediastream/RTCPeerConnection.cpp: Refactor the three functions

below to using the enum instead of returning strings. This allows remove of
the internal* versions of these functions.
(WebCore::RTCPeerConnection::signalingState): Deleted.
(WebCore::RTCPeerConnection::iceGatheringState): Deleted.
(WebCore::RTCPeerConnection::iceConnectionState): Deleted.

• Modules/mediastream/RTCPeerConnection.h: Replace internalSignalingState,

internalIceGatheringState, and internalIceConnectionState.

• Modules/mediastream/RTCPeerConnection.idl:
• Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp:
• Modules/mediastream/libwebrtc/LibWebRTCPeerConnectionBackend.cpp:
• platform/mediastream/MediaEndpoint.h:
• platform/mediastream/MediaEndpointConfiguration.cpp:
• platform/mediastream/MediaEndpointConfiguration.h:
• platform/mock/MockMediaEndpoint.cpp:
• platform/mock/MockMediaEndpoint.h:
• platform/mediastream/openwebrtc/MediaEndpointOwr.cpp:

(WebCore::MediaEndpointOwr::processIceTransportStateChange):

10:12 PM Changeset in webkit [214029] by Yusuke Suzuki

• 16 edits
  2 adds in trunk

[JSC] Default parameter part should be retrieved by op_get_argument opcode instead of changing arity
​https://bugs.webkit.org/show_bug.cgi?id=164582

Reviewed by Saam Barati.

JSTests:

• stress/function-with-defaults-inlining.js: Added.

(shouldBe):
(ok):
(a):

• stress/function-with-defaults-non-inlining.js: Added.

(shouldBe):
(ok):
(a):

Source/JavaScriptCore:

Previously we implement the default parameters as follows.

1. We count the default parameters as the usual parameters.
2. We just get the argument register.
3. Check it with op_is_undefined.
4. And fill the binding with either the argument register or default value.

The above is simple. However, it has the side effect that it always increase the arity of the function.
While function.length does not increase, internally, the number of parameters of CodeBlock increases.
This effectively prevent our DFG / FTL to perform inlining: currently we only allows DFG to inline
the function with the arity less than or equal the number of passing arguments. It is OK. But when using
default parameters, we frequently do not pass the argument for the parameter with the default value.
Thus, in our current implementation, we frequently need to fixup the arity. And we frequently fail
to inline the function.

This patch fixes the above problem by not increasing the arity of the function. When we encounter the
parameter with the default value, we use op_argument to get the argument instead of using the argument
registers.

This improves six-speed defaults.es6 performance by 4.45x.

defaults.es6 968.4126+-101.2350 ^{217.6602+-14.8831} definitely 4.4492x faster

• bytecode/UnlinkedFunctionExecutable.cpp:

(JSC::UnlinkedFunctionExecutable::UnlinkedFunctionExecutable):

• bytecode/UnlinkedFunctionExecutable.h:
• bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::BytecodeGenerator):
(JSC::BytecodeGenerator::initializeDefaultParameterValuesAndSetupFunctionScopeStack):
(JSC::BytecodeGenerator::initializeNextParameter):
(JSC::BytecodeGenerator::initializeParameters):

• bytecompiler/BytecodeGenerator.h:
• bytecompiler/NodesCodegen.cpp:

(JSC::FunctionNode::emitBytecode):

• dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::inliningCost):

• parser/ASTBuilder.h:

(JSC::ASTBuilder::createFunctionMetadata):

• parser/Nodes.cpp:

(JSC::FunctionMetadataNode::FunctionMetadataNode):

• parser/Nodes.h:

(JSC::FunctionParameters::size):
(JSC::FunctionParameters::at):
(JSC::FunctionParameters::append):
(JSC::FunctionParameters::isSimpleParameterList):

• parser/Parser.cpp:

(JSC::Parser<LexerType>::isArrowFunctionParameters):
(JSC::Parser<LexerType>::parseGeneratorFunctionSourceElements):
(JSC::Parser<LexerType>::parseAsyncFunctionSourceElements):
(JSC::Parser<LexerType>::parseFormalParameters):
(JSC::Parser<LexerType>::parseFunctionBody):
(JSC::Parser<LexerType>::parseFunctionParameters):
(JSC::Parser<LexerType>::parseFunctionInfo):

• parser/Parser.h:
• parser/SyntaxChecker.h:

(JSC::SyntaxChecker::createFunctionMetadata):

• runtime/FunctionExecutable.h:
• runtime/JSFunction.cpp:

(JSC::JSFunction::createBuiltinFunction):
(JSC::JSFunction::reifyLength):

9:49 PM Changeset in webkit [214028] by Yusuke Suzuki

• 10 edits
  2 adds in trunk

[DFG] ToString operation should have fixup for primitives to say this node does not have side effects
​https://bugs.webkit.org/show_bug.cgi?id=169544

Reviewed by Saam Barati.

JSTests:

• microbenchmarks/template-string-array.js: Added.

(test):

• stress/to-string-non-cell-use.js: Added.

(shouldBe):
(shouldThrow):

Source/JavaScriptCore:

Our DFG ToString only considers well about String operands. While ToString(non cell operand) does not have
any side effect, it is not modeled well in DFG.

This patch introduces a fixup for ToString with NonCellUse edge. If this edge is set, ToString does not
clobber things (like ToLowerCase, producing String). And ToString(NonCellUse) allows us to perform CSE!

Our microbenchmark shows 32.9% improvement due to dropped GetButterfly and CSE for ToString().

baseline patched

template-string-array 12.6284+-0.2766 ^{9.4998+-0.2295} definitely 1.3293x faster

And SixSpeed template_string.es6 shows 16.68x performance improvement due to LICM onto this non-side-effectful ToString().

baseline patched

template_string.es6 3229.7343+-40.5705 ^{193.6077+-36.3349} definitely 16.6818x faster

• dfg/DFGAbstractInterpreterInlines.h:

(JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):

• dfg/DFGClobberize.h:

(JSC::DFG::clobberize):

• dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupToStringOrCallStringConstructor):

• dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileToStringOrCallStringConstructorOnCell):
(JSC::DFG::SpeculativeJIT::speculateNotCell):

• dfg/DFGSpeculativeJIT.h:
• dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

• dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

• ftl/FTLLowerDFGToB3.cpp:

(JSC::FTL::DFG::LowerDFGToB3::compileToStringOrCallStringConstructor):
(JSC::FTL::DFG::LowerDFGToB3::lowNotCell):
(JSC::FTL::DFG::LowerDFGToB3::speculateNotCell):

9:10 PM Changeset in webkit [214027] by jer.noble@apple.com

• 17 edits
  1 copy
  5 adds
  1 delete in trunk/Source

Optionally capture audio in the UIProcess
​https://bugs.webkit.org/show_bug.cgi?id=169609

Reviewed by Alex Christensen.

Source/WebCore:

Export some previously un-exported symbols from WebCore for use in WebKit2.

• WebCore.xcodeproj/project.pbxproj:
• platform/audio/WebAudioBufferList.h:
• platform/mediastream/RealtimeMediaSource.h:

Source/WebKit2:

Add a new class pair, UserMediaCaptureManager/Proxy, to allow a RealtimeMediaSource
requested in a WebProcess to be created in the UIProcess and push its audio data across the
process boundary to its clients in the WebProcess. Because these classes are clients of the
RealtimeMediaSourceCenter::singleton(), they must be a singleton in the WebProcess as well,
so they are attached to the WebProcess class in the web process and to WebProcessProxy in
the UIProcess.

• UIProcess/Cocoa/UserMediaCaptureManagerProxy.cpp: Added.

(WebKit::UserMediaCaptureManagerProxy::SourceProxy::SourceProxy):
(WebKit::UserMediaCaptureManagerProxy::SourceProxy::~SourceProxy):
(WebKit::UserMediaCaptureManagerProxy::SourceProxy::source):
(WebKit::UserMediaCaptureManagerProxy::SourceProxy::description):
(WebKit::UserMediaCaptureManagerProxy::SourceProxy::numberOfFrames):
(WebKit::UserMediaCaptureManagerProxy::UserMediaCaptureManagerProxy):
(WebKit::UserMediaCaptureManagerProxy::~UserMediaCaptureManagerProxy):
(WebKit::UserMediaCaptureManagerProxy::createMediaSourceForCaptureDeviceWithConstraints):
(WebKit::UserMediaCaptureManagerProxy::startProducingData):
(WebKit::UserMediaCaptureManagerProxy::stopProducingData):

• UIProcess/Cocoa/UserMediaCaptureManagerProxy.h:

(WebKit::UserMediaCaptureManagerProxy::process):

• UIProcess/Cocoa/UserMediaCaptureManagerProxy.messages.in: Added.
• WebProcess/cocoa/UserMediaCaptureManager.cpp: Added.

(WebKit::nextSessionID):
(WebKit::UserMediaCaptureManager::Source::Source):
(WebKit::UserMediaCaptureManager::Source::~Source):
(WebKit::UserMediaCaptureManager::Source::setCapabilities):
(WebKit::UserMediaCaptureManager::Source::setSettings):
(WebKit::UserMediaCaptureManager::Source::description):
(WebKit::UserMediaCaptureManager::Source::setStorage):
(WebKit::UserMediaCaptureManager::Source::setRingBufferFrameBounds):
(WebKit::UserMediaCaptureManager::Source::audioSamplesAvailable):
(WebKit::UserMediaCaptureManager::UserMediaCaptureManager):
(WebKit::UserMediaCaptureManager::~UserMediaCaptureManager):
(WebKit::UserMediaCaptureManager::supplementName):
(WebKit::UserMediaCaptureManager::initialize):
(WebKit::UserMediaCaptureManager::createMediaSourceForCaptureDeviceWithConstraints):
(WebKit::UserMediaCaptureManager::sourceStopped):
(WebKit::UserMediaCaptureManager::sourceMutedChanged):
(WebKit::UserMediaCaptureManager::sourceEnabledChanged):
(WebKit::UserMediaCaptureManager::sourceSettingsChanged):
(WebKit::UserMediaCaptureManager::storageChanged):
(WebKit::UserMediaCaptureManager::ringBufferFrameBoundsChanged):
(WebKit::UserMediaCaptureManager::audioSamplesAvailable):
(WebKit::UserMediaCaptureManager::startProducingData):
(WebKit::UserMediaCaptureManager::stopProducingData):

• WebProcess/cocoa/UserMediaCaptureManager.h: Added.
• WebProcess/cocoa/UserMediaCaptureManager.messages.in: Added.

Initialize UserMediaCaptureManager/Proxy:

• UIProcess/Cocoa/WebProcessPoolCocoa.mm:

(WebKit::WebProcessPool::platformInitializeWebProcess):

• UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::WebProcessProxy):

• UIProcess/WebProcessProxy.h:
• WebProcess/WebProcess.cpp:

(WebKit::WebProcess::WebProcess):

WebUserMediaClientMac is no longer necessary now that the UserMediaCaptureManager overrides
the factories:

• WebProcess/WebCoreSupport/WebUserMediaClient.cpp:

(WebKit::WebUserMediaClient::WebUserMediaClient):
(WebKit::WebUserMediaClient::initializeFactories): Deleted.

Add a new preference and WebProcessCreationParameters member to control whether
capturing is done in the UIProcess:

• Shared/WebPreferencesDefinitions.h:
• Shared/WebProcessCreationParameters.cpp:

(WebKit::WebProcessCreationParameters::encode):
(WebKit::WebProcessCreationParameters::decode):

• Shared/WebProcessCreationParameters.h:

Add new files to the project:

• DerivedSources.make:
• WebKit2.xcodeproj/project.pbxproj:

8:41 PM Changeset in webkit [214026] by Ryan Haddad

• 2 edits in trunk/Source/JavaScriptCore

Revert part of r213978 to see if it resolves LayoutTest crashes.
​https://bugs.webkit.org/show_bug.cgi?id=169729

Reviewed by Alexey Proskuryakov.

• JavaScriptCore.xcodeproj/project.pbxproj:

8:15 PM Changeset in webkit [214025] by clopez@igalia.com

• 3 edits in trunk/Source/WTF

[CMake][JSCOnly] Fix build with GLib event loop
​https://bugs.webkit.org/show_bug.cgi?id=169730

Reviewed by Michael Catanzaro.

• wtf/MainThread.cpp:
• wtf/PlatformJSCOnly.cmake: WorkQueueGLib was removed in r199713.

7:48 PM Changeset in webkit [214024] by webkit@devinrousso.com

• 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Selecting text in the console does not do what I expect
​https://bugs.webkit.org/show_bug.cgi?id=169570

Reviewed by Matt Baker.

• UserInterface/Views/ConsoleMessageView.css:

(.console-message-text > span > :matches(.console-message-enclosed, .console-message-preview, .console-message-preview-divider)):
(.console-message .console-message-location):
(.console-message-location.call-frame):
Prevent text selection on anything other than the message text. The other information that
is not selectable can still be copied by selecting the message itself and copying.

6:56 PM Changeset in webkit [214023] by Alan Bujtas

• 5 edits
  2 adds in trunk

Do not reparent floating object until after intruding/overhanging dependency is cleared.
​https://bugs.webkit.org/show_bug.cgi?id=169711
<rdar://problem/30959743>

Reviewed by Simon Fraser.

Source/WebCore:

This patch ensures that we cleanup the m_floatingObjects for siblings before reparenting the fresh float.

Test: fast/block/float/inline-becomes-float-and-moves-around.html

• rendering/RenderBlockFlow.cpp:

(WebCore::RenderBlockFlow::styleDidChange):

• rendering/RenderElement.cpp:

(WebCore::RenderElement::styleDidChange):

• rendering/RenderElement.h:

(WebCore::RenderElement::noLongerAffectsParentBlock):

LayoutTests:

• fast/block/float/inline-becomes-float-and-moves-around-expected.txt: Added.
• fast/block/float/inline-becomes-float-and-moves-around.html: Added.

6:01 PM Changeset in webkit [214022] by commit-queue@webkit.org

• 2 edits in trunk/Source/JavaScriptCore

[jsc][mips] Fix compilation error introduced in r213652
​https://bugs.webkit.org/show_bug.cgi?id=169723

Patch by Guillaume Emont <​guijemont@igalia.com> on 2017-03-15
Reviewed by Mark Lam.

The new replaceWithBkpt() contains a lapsus in it
(s/code/instructionStart) and won't compile.

• assembler/MIPSAssembler.h:

(JSC::MIPSAssembler::replaceWithBkpt):

6:01 PM Changeset in webkit [214021] by Nikita Vasilyev

• 3 edits in trunk/Source/WebInspectorUI

Web Inspector: WebSockets: Update Arrow Up icon to fit in with the rest of our iconography
​https://bugs.webkit.org/show_bug.cgi?id=169696
<rdar://problem/31073748>

Reviewed by Matt Baker.

• UserInterface/Images/ArrowUp.svg:
• UserInterface/Images/gtk/ArrowUp.svg:

4:40 PM Changeset in webkit [214020] by commit-queue@webkit.org

• 2 edits in trunk/Source/JavaScriptCore

Switch back to ISO 4217 for Intl CurrencyDigits data
​https://bugs.webkit.org/show_bug.cgi?id=169182

Previously, a patch switched Intl.NumberFormat to use CLDR data through
ICU to get the default number of decimal digits for a currency.
However, that change actually violated the ECMA 402 specification,
which references ISO 4217 as the data source. This patch reverts to
an in-line implementation of that data.

Patch by Daniel Ehrenberg <​littledan@chromium.org> on 2017-03-15
Reviewed by Saam Barati.

• runtime/IntlNumberFormat.cpp:

(JSC::computeCurrencySortKey):
(JSC::extractCurrencySortKey):
(JSC::computeCurrencyDigits):

4:29 PM Changeset in webkit [214019] by timothy_horton@apple.com

• 4 edits
  1 add in trunk

Null deref under callAfterNextPresentationUpdate
​https://bugs.webkit.org/show_bug.cgi?id=169710
<rdar://problem/30987863>

Reviewed by Simon Fraser.

Source/WebKit2:

• UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::callAfterNextPresentationUpdate):
Call the callback with an error if we don't have a web process or drawing area.

Tools:

• TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
• TestWebKitAPI/Tests/WebKit2Cocoa/DoAfterNextPresentationUpdateAfterCrash.mm: Added.

(TEST):

4:17 PM Changeset in webkit [214018] by sbarati@apple.com

• 2 edits in trunk/Source/JavaScriptCore

WebAssembly: When we GC to try to get a fast memory, we should call collectAllGarbage(), not collectSync()
​https://bugs.webkit.org/show_bug.cgi?id=169704

Reviewed by Mark Lam.

We weren't always sweeping the memory needed to free
the WasmMemory we wanted to use. collectAllGarbage()
will do this if the JS objects wrapping WasmMemory
are dead.

This patch also moves the increment of the allocatedFastMemories
integer to be thread safe.

• wasm/WasmMemory.cpp:

(JSC::Wasm::tryGetFastMemory):

3:56 PM Changeset in webkit [214017] by dino@apple.com

• 10 edits
  1 add in trunk/Source/WebCore

Make a base class for WebGL and WebGPU contexts
​https://bugs.webkit.org/show_bug.cgi?id=169651
<rdar://problem/31053489>

Reviewed by Simon Fraser.

Add a new pure virtual base class, GPUBasedCanvasRenderingContext, that
will be used by WebGL and WebGPU rendering contexts. This allows us
to avoid some code duplication, since many places treat the two
as the same.

Also rename is3d() -> isWebGL() and isGPU() -> isWebGPU().

• WebCore.xcodeproj/project.pbxproj: New file.
• html/HTMLCanvasElement.cpp:

(WebCore::HTMLCanvasElement::getContextWebGL):
(WebCore::HTMLCanvasElement::getContextWebGPU):
(WebCore::HTMLCanvasElement::reset):
(WebCore::HTMLCanvasElement::paint):
(WebCore::HTMLCanvasElement::isGPUBased):
(WebCore::HTMLCanvasElement::getImageData):
(WebCore::HTMLCanvasElement::isGPU): Deleted.
(WebCore::HTMLCanvasElement::is3D): Deleted.

• html/HTMLCanvasElement.h:
• html/canvas/CanvasRenderingContext.h:

(WebCore::CanvasRenderingContext::isWebGL):
(WebCore::CanvasRenderingContext::isWebGPU):
(WebCore::CanvasRenderingContext::isGPUBased):
(WebCore::CanvasRenderingContext::is3d): Deleted.
(WebCore::CanvasRenderingContext::isGPU): Deleted.

• html/canvas/GPUBasedCanvasRenderingContext.h: Added.

(WebCore::GPUBasedCanvasRenderingContext::GPUBasedCanvasRenderingContext):

• html/canvas/WebGLRenderingContextBase.cpp:

(WebCore::WebGLRenderingContextBase::WebGLRenderingContextBase):

• html/canvas/WebGLRenderingContextBase.h:
• html/canvas/WebGPURenderingContext.cpp:

(WebCore::WebGPURenderingContext::WebGPURenderingContext):

• html/canvas/WebGPURenderingContext.h:
• rendering/RenderLayerBacking.cpp:

(WebCore::canvasCompositingStrategy):

3:49 PM Changeset in webkit [214016] by mark.lam@apple.com

• 2 edits in trunk/Source/JavaScriptCore

Fix exception scope verification failures in jsc.cpp.
​https://bugs.webkit.org/show_bug.cgi?id=164968

Reviewed by Saam Barati.

• jsc.cpp:

(WTF::CustomGetter::customGetter):

(GlobalObject::moduleLoaderResolve):
(GlobalObject::moduleLoaderFetch):

• The only way modules would throw an exception is if we encounter an OutOfMemory error. This should be extremely rare. At this point, I don't think it's worth doing the dance to propagate the exception when this happens. Instead, we'll simply do a RELEASE_ASSERT that we don't see any exceptions here.

(functionRun):
(functionRunString):
(functionLoadModule):
(functionCheckModuleSyntax):
(box):
(dumpException):
(runWithScripts):

3:46 PM Changeset in webkit [214015] by matthew_hanson@apple.com

• 1 copy in tags/Safari-604.1.30.4.5

Tag Safari-604.1.30.4.5.

3:44 PM Changeset in webkit [214014] by dbates@webkit.org

• 6 edits in trunk/Source/WebCore

Iteratively dispatch DOM events after restoring a cached page
​https://bugs.webkit.org/show_bug.cgi?id=169703
<rdar://problem/31075903>

Reviewed by Brady Eidson.

Make dispatching of DOM events when restoring a page from the page cache symmetric with
dispatching of events when saving a page to the page cache.

• history/CachedFrame.cpp:

(WebCore::CachedFrameBase::restore): Move code to dispatch events from here to FrameLoader::didRestoreFromCachedPage().

• loader/FrameLoader.cpp:

(WebCore::FrameLoader::commitProvisionalLoad): Ensure that no DOM events are dispatched during
restoration of a cached page. Call didRestoreFromCachedPage() after restoring the page to
dispatch DOM events on the restored frames.
(WebCore::FrameLoader::willRestoreFromCachedPage): Renamed; formerly named prepareForCachedPageRestore().
(WebCore::FrameLoader::didRestoreFromCachedPage): Added.
(WebCore::FrameLoader::prepareForCachedPageRestore): Renamed to willRestoreFromCachedPage().

• loader/FrameLoader.h:
• page/FrameTree.cpp:

(WebCore::FrameTree::traverseNextInPostOrderWithWrap): Returns the next Frame* in a post-order
traversal of the frame tree optionally wrapping around to the deepest first child in the tree.
(WebCore::FrameTree::deepFirstChild): Added.

• page/FrameTree.h:

3:43 PM Changeset in webkit [214013] by matthew_hanson@apple.com

• 2 edits in branches/safari-603.1.30.4-branch/Source/WebCore

Merge r213847. rdar://problem/30983702

3:43 PM Changeset in webkit [214012] by matthew_hanson@apple.com

• 3 edits in branches/safari-603.1.30.4-branch/Source/WebKit/win

Merge r213737. rdar://problem/30983702

3:29 PM Changeset in webkit [214011] by webkit@devinrousso.com

• 3 edits
  4 adds in trunk/Source/WebInspectorUI

Web Inspector: Add icons for SVG Image cluster path components
​https://bugs.webkit.org/show_bug.cgi?id=169687

Reviewed by Joseph Pecoraro.

• UserInterface/Images/Image.svg: Added.
• UserInterface/Images/Source.svg: Added.
• UserInterface/Images/gtk/Image.svg: Added.
• UserInterface/Images/gtk/Source.svg: Added.

• UserInterface/Views/PathComponentIcons.css:

(.image-icon .icon):
(.source-icon .icon):

• UserInterface/Views/SVGImageResourceClusterContentView.js:

(WebInspector.SVGImageResourceClusterContentView):

3:09 PM Changeset in webkit [214010] by hyatt@apple.com

• 10 edits
  2 adds in trunk

Positioned SVG not sized correctly
​https://bugs.webkit.org/show_bug.cgi?id=169693
<rdar://problem/30996893>

Reviewed by Zalan Bujtas.

Source/WebCore:

Test: svg/in-html/rect-positioned.html

Change computeReplacedLogicalHeight to take an estimatedUsedWidth. This
value is used instead of the available logical width to resolve replaced
elements without intrinsic sizes but with aspect ratios set.

• rendering/RenderBox.cpp:

(WebCore::RenderBox::computeReplacedLogicalHeight):

• rendering/RenderBox.h:
• rendering/RenderReplaced.cpp:

(WebCore::RenderReplaced::computeConstrainedLogicalWidth):
(WebCore::RenderReplaced::computeReplacedLogicalWidth):
(WebCore::RenderReplaced::computeReplacedLogicalHeight):

• rendering/RenderReplaced.h:
• rendering/RenderVideo.cpp:

(WebCore::RenderVideo::computeReplacedLogicalHeight): Deleted.

• rendering/RenderVideo.h:
• rendering/svg/RenderSVGRoot.cpp:

(WebCore::RenderSVGRoot::computeReplacedLogicalWidth):
(WebCore::RenderSVGRoot::computeReplacedLogicalHeight):

• rendering/svg/RenderSVGRoot.h:

LayoutTests:

• svg/in-html/rect-positioned-expected.html: Added.
• svg/in-html/rect-positioned.html: Added.

3:04 PM Changeset in webkit [214009] by webkit@devinrousso.com

• 2 edits in trunk/Source/WebInspectorUI

Web Inspector: RTL: flip Memory timelines
​https://bugs.webkit.org/show_bug.cgi?id=169694

Reviewed by Brian Burg.

• UserInterface/Views/MemoryCategoryView.css:

(body[dir=rtl] .memory-category-view > .graph):

2:59 PM Changeset in webkit [214008] by rniwa@webkit.org

• 9 edits
  1 add in trunk/Websites/perf.webkit.org

In-browser and node.js implementations of RemoteAPI should share some code
​https://bugs.webkit.org/show_bug.cgi?id=169695

Rubber-stamped by Antti Koivisto.

Extracted CommonRemoteAPI out of RemoteAPI implementations for node.js and browser.

• public/shared/common-remote.js: Added.

(CommonRemoteAPI): Added.
(CommonRemoteAPI.prototype.postJSON): Extracted from RemoteAPI.
(CommonRemoteAPI.prototype.postJSONWithStatus): Ditto.
(CommonRemoteAPI.prototype.getJSON): Ditto.
(CommonRemoteAPI.prototype.getJSONWithStatus): Ditto.
(CommonRemoteAPI.prototype.sendHttpRequest): Added. Needs to implemented by a subclass.
(CommonRemoteAPI.prototype._asJSON): Added.
(CommonRemoteAPI.prototype._checkStatus): Added.

• public/v3/index.html: Include common-remote.js.

• public/v3/privileged-api.js:

(PrivilegedAPI): Use class now that we don't include data.js.
(PrivilegedAPI.sendRequest): Modernized the code.
(PrivilegedAPI.requestCSRFToken): Ditto.

• public/v3/remote.js:

(BrowserRemoteAPI): Renamed from RemoteAPI. window.RemoteAPI is now an instance of this class.
(BrowserRemoteAPI.prototype.sendHttpRequest): Moved from RemoteAPI.sendHttpRequest.
(BrowserRemoteAPI.prototype.sendHttpRequest):

• server-tests/privileged-api-create-analysis-task-tests.js: Updated tests since NodeJSRemoteAPI

now throws the JSON status as an error to be consistent with BrowserRemoteAPI.

• server-tests/privileged-api-create-test-group-tests.js: Ditto.
• server-tests/privileged-api-upate-run-status.js: Ditto.

• tools/js/buildbot-triggerable.js:

(BuildbotTriggerable.prototype.syncOnce): Just use postJSONWithStatus instead of manually
checking the status.

• tools/js/remote.js:

(NodeRemoteAPI): Renamed from RemoteAPI. Still exported as RemoteAPI.
(NodeRemoteAPI.prototype.constructor):
(NodeRemoteAPI.prototype.sendHttpRequest): Modernized the code.

2:47 PM Changeset in webkit [214007] by Ryan Haddad

• 2 edits in trunk/LayoutTests

Clean up TestExpectations for some WPT LayoutTests.

Unreviewed test gardening.

• TestExpectations:

2:31 PM Changeset in webkit [214006] by Chris Dumez

• 6 edits
  1 add in trunk

Document state (e.g. form data) is lost after a tab is terminated in the background for power reasons
​https://bugs.webkit.org/show_bug.cgi?id=169635
<rdar://problem/31046729>

Reviewed by Andreas Kling.

Source/WebKit2:

Document state (e.g. form data) was lost after a tab was terminated in the background for power
reasons. To address the issue, we now save the document state whenever a page is backgrounded.
This document state automatically gets restored when reloading the page after termination.

• WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::visibilityDidChange):
(WebKit::WebPage::setActivityState):

• WebProcess/WebPage/WebPage.h:

Tools:

Add API test coverage.

• TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
• TestWebKitAPI/Tests/WebKit2/mac/RestoreStateAfterTermination.mm: Added.

(TestWebKitAPI::runJavaScriptAlert):
(TestWebKitAPI::didFinishLoad):
(TestWebKitAPI::didCrash):
(TestWebKitAPI::TEST):

• TestWebKitAPI/Tests/WebKit2/simple-form.html:

1:19 PM Changeset in webkit [214005] by mark.lam@apple.com

• 2 edits in trunk/Source/JavaScriptCore

Fix missing exception checks in Interpreter.cpp.
​https://bugs.webkit.org/show_bug.cgi?id=164964

Reviewed by Saam Barati.

• interpreter/Interpreter.cpp:

(JSC::eval):
(JSC::sizeOfVarargs):
(JSC::sizeFrameForVarargs):
(JSC::Interpreter::executeProgram):
(JSC::Interpreter::executeCall):
(JSC::Interpreter::executeConstruct):
(JSC::Interpreter::prepareForRepeatCall):
(JSC::Interpreter::execute):

1:00 PM Changeset in webkit [214004] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebInspectorUI

JSContext Inspector: NetworkAgent may be unavailable
​https://bugs.webkit.org/show_bug.cgi?id=169691

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2017-03-15
Reviewed by Brian Burg.

• UserInterface/Views/ResourceDetailsSidebarPanel.js:

(WebInspector.ResourceDetailsSidebarPanel.prototype._refreshRequestAndResponse):
Check that NetworkAgent even exists. An augmented JSContext may have Resources
without having a NetworkAgent.

12:56 PM Changeset in webkit [214003] by Wenson Hsieh

• 2 edits in trunk/Source/WebKit2

WebContent crash due to bad variant access in WebKit: WebKit::WebPage::expandedRangeFromHandle
​https://bugs.webkit.org/show_bug.cgi?id=169657
<rdar://problem/30631070>

Reviewed by Tim Horton.

In WebPageIOS.mm, the call to unionDOMRanges from WebPage::expandedRangeFromHandle invokes
Range::compareBoundaryPoints, assuming that the return value is not an exception, and then attempts to perform
integer comparison on the result. This is one speculative cause of the web content crash in the radar.

There isn't a known way to reproduce this crash.

• WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::unionDOMRanges):

12:35 PM Changeset in webkit [214002] by Nikita Vasilyev

• 2 edits in trunk/Source/WebInspectorUI

REGRESSION (r213622): Web Inspector: DataGrid headers should NOT be centered
​https://bugs.webkit.org/show_bug.cgi?id=169645
<rdar://problem/31051520>

Reviewed by Matt Baker.

• UserInterface/Views/DataGrid.css:

(.data-grid th):
(body[dir=ltr] .data-grid th):
(body[dir=rtl] .data-grid th):

12:34 PM Changeset in webkit [214001] by timothy_horton@apple.com

• 7 edits
  3 deletes in trunk/Source/WebKit2

Un-deprecate the original PDFPlugin
​https://bugs.webkit.org/show_bug.cgi?id=169655

Reviewed by Anders Carlsson.

• Shared/mac/PDFKitImports.h:
• WebKit2.xcodeproj/project.pbxproj:
• WebProcess/Plugins/PDF/DeprecatedPDFLayerControllerSPI.h: Removed.
• WebProcess/Plugins/PDF/DeprecatedPDFPlugin.h: Removed.
• WebProcess/Plugins/PDF/DeprecatedPDFPlugin.mm: Removed.
• WebProcess/Plugins/PDF/PDFLayerControllerSPI.h:
• WebProcess/Plugins/PDF/PDFPlugin.h:
• WebProcess/Plugins/PDF/PDFPlugin.mm:
• WebProcess/Plugins/PDF/PDFPluginAnnotation.mm:

The transition to the non-deprecated PDFPlugin never happened,
and we have a very different plan now.

12:34 PM Changeset in webkit [214000] by rniwa@webkit.org

• 6 edits in trunk/Websites/perf.webkit.org

Fix server tests after r213998 and r213969
​https://bugs.webkit.org/show_bug.cgi?id=169690

Reviewed by Antti Koivisto.

Fixed the existing server tests.

• public/v3/models/analysis-task.js:

(AnalysisTask.prototype._updateRemoteState): Use the relative path from the root so that it works inside tests.
(AnalysisTask.prototype.associateBug): Ditto.
(AnalysisTask.prototype.dissociateBug): Ditto.
(AnalysisTask.prototype.associateCommit): Ditto.
(AnalysisTask.prototype.dissociateCommit): Ditto.
(AnalysisTask._fetchSubset): Ditto.
(AnalysisTask.fetchAll): Ditto.

• public/v3/models/test-group.js:

(TestGroup.prototype.updateName): Ditto.
(TestGroup.prototype.updateHiddenFlag): Ditto.
(TestGroup.createAndRefetchTestGroups): Ditto.
(TestGroup.cachedFetch): Ditto.

• server-tests/api-manifest.js: Reverted an inadvertant change in r213969.
• tools/js/database.js:

(tableToPrefixMap): Added analysis_strategies.

• unit-tests/analysis-task-tests.js: Updated expectations per changes to AnalysisTask.

12:15 PM Changeset in webkit [213999] by webkit@devinrousso.com

• 4 edits
  1 add in trunk/Source/WebInspectorUI

Web Inspector: SVG image content view should toggle between image and source
​https://bugs.webkit.org/show_bug.cgi?id=16079

Reviewed by Joseph Pecoraro.

• Localizations/en.lproj/localizedStrings.js:
• UserInterface/Main.html:

• UserInterface/Views/ResourceClusterContentView.js:

(WebInspector.ResourceClusterContentView.prototype.get responseContentView):
Show the SVG cluster content view if the MIME type matches an SVG file.

• UserInterface/Views/SVGImageResourceClusterContentView.js: Added.

(WebInspector.SVGImageResourceClusterContentView):
(WebInspector.SVGImageResourceClusterContentView.prototype.get resource):
(WebInspector.SVGImageResourceClusterContentView.prototype.get selectionPathComponents):
(WebInspector.SVGImageResourceClusterContentView.prototype.shown):
(WebInspector.SVGImageResourceClusterContentView.prototype.closed):
(WebInspector.SVGImageResourceClusterContentView.prototype.saveToCookie):
(WebInspector.SVGImageResourceClusterContentView.prototype.restoreFromCookie):
(WebInspector.SVGImageResourceClusterContentView.prototype._pathComponentForContentView):
(WebInspector.SVGImageResourceClusterContentView.prototype._identifierForContentView):
(WebInspector.SVGImageResourceClusterContentView.prototype._showContentViewForIdentifier):
(WebInspector.SVGImageResourceClusterContentView.prototype._pathComponentSelected):

12:15 PM Changeset in webkit [213998] by rniwa@webkit.org

• 5 edits
  2 adds in trunk/Websites/perf.webkit.org

Add tests for privileged-api/create-analysis-task and privileged-api/create-test-group
​https://bugs.webkit.org/show_bug.cgi?id=169688

Rubber-stamped by Antti Koivisto.

Added tests for privileged-api/create-analysis-task and privileged-api/create-test-group, and fixed newly found bugs.

• public/privileged-api/create-analysis-task.php:

(main): Fixed the bug that we were not explicitly checking whether start_run and end_run were integers or not.
Also return InvalidTimeRange when start and end times are identical as that makes no sense for an analysis task.

• public/privileged-api/create-test-group.php:

(main): Fixed a bug that we were not explicitly checking task and repetitionCount to be an integer.
(ensure_commit_sets): Fixed the bug that the number of commit sets weren't checked.

• server-tests/privileged-api-create-analysis-task-tests.js: Added.
• server-tests/privileged-api-create-test-group-tests.js: Added.

• server-tests/resources/common-operations.js:

(prepareServerTest): Increase the timeout from 1s to 5s.

• server-tests/resources/mock-data.js:

(MockData.addMockData): Use a higher database ID of 20 for a mock build_slave to avoid a conflict with auto-generated IDs.

12:07 PM Changeset in webkit [213997] by webkit@devinrousso.com

• 5 edits in trunk/Source/WebInspectorUI

Web Inspector: RTL: add support for Timeline ruler selections/movement
​https://bugs.webkit.org/show_bug.cgi?id=169588

Reviewed by Matt Baker.

• UserInterface/Views/TimelineOverview.css:

(body[dir=ltr] .timeline-overview.frames > .timeline-ruler:not(.both-handles-clamped) > .selection-handle.right):
(body[dir=rtl] .timeline-overview.frames > .timeline-ruler:not(.both-handles-clamped) > .selection-handle.left):
(body[dir=ltr] .timeline-overview.frames > .timeline-ruler:not(.both-handles-clamped) > .shaded-area.right):
(body[dir=rtl] .timeline-overview.frames > .timeline-ruler:not(.both-handles-clamped) > .shaded-area.left):
(.timeline-overview.frames > .timeline-ruler:not(.both-handles-clamped) > .selection-handle.right): Deleted.
(.timeline-overview.frames > .timeline-ruler:not(.both-handles-clamped) > .shaded-area.right): Deleted.
Fixes alignment of selection handles when in Frames view.

• UserInterface/Views/TimelineOverview.js:

(WebInspector.TimelineOverview.prototype._handleScrollEvent):
Support horizontal scrolling in timelines by treating the current scroll value as negative
when in RTL, flipping the scroll direction.

• UserInterface/Views/TimelineRuler.css:

(body[dir=ltr] .timeline-ruler > .selection-handle.left):
(body[dir=rtl] .timeline-ruler > .selection-handle.left):
(body[dir=ltr] .timeline-ruler > .selection-handle.right):
(body[dir=rtl] .timeline-ruler > .selection-handle.right):
(body[dir=ltr] .timeline-ruler > .shaded-area.left):
(body[dir=rtl] .timeline-ruler > .shaded-area.left):
(body[dir=ltr] .timeline-ruler > .shaded-area.right):
(body[dir=rtl] .timeline-ruler > .shaded-area.right):
(.timeline-ruler > .selection-handle.left): Deleted.
(.timeline-ruler > .selection-handle.right): Deleted.
(.timeline-ruler > .shaded-area.left): Deleted.
(.timeline-ruler > .shaded-area.right): Deleted.
Flip the position alignment of the selection handles and shaded areas when in RTL.

• UserInterface/Views/TimelineRuler.js:

(WebInspector.TimelineRuler.prototype._handleMouseDown):
(WebInspector.TimelineRuler.prototype._handleMouseMove):
(WebInspector.TimelineRuler.prototype._handleMouseUp):
(WebInspector.TimelineRuler.prototype._handleSelectionHandleMouseDown):
(WebInspector.TimelineRuler.prototype._handleSelectionHandleMouseMove):
Treat the current mouse position (event.pageX) as a negative value when in RTL, meaning that
the delta movement from the starting position is flipped.

11:51 AM Changeset in webkit [213996] by commit-queue@webkit.org

• 3 edits
  2 adds in trunk

[Modern Media Controls] Using the arrow keys to navigate in the tracks menu also scrolls the page
​https://bugs.webkit.org/show_bug.cgi?id=169671
<rdar://problem/31060091>

Patch by Antoine Quint <Antoine Quint> on 2017-03-15
Reviewed by Eric Carlson.

Source/WebCore:

We need to call preventDefault() when handling a "keydown" event that we recognize.

Test: media/modern-media-controls/tracks-panel/tracks-panel-prevent-default-on-keydown.html

• Modules/modern-media-controls/controls/tracks-panel.js:

(TracksPanel.prototype._handleKeydown):

LayoutTests:

Add a test that checks that preventDefault() is called on "keydown" events that we know to handle.

• media/modern-media-controls/tracks-panel/tracks-panel-prevent-default-on-keydown-expected.txt: Added.
• media/modern-media-controls/tracks-panel/tracks-panel-prevent-default-on-keydown.html: Added.

11:26 AM Changeset in webkit [213995] by Jonathan Bedard

• 1 edit
  1 delete in trunk/LayoutTests

Remove TestExpectations.orig after r213882

Unreviewed, removing file committed by mistake.

• TestExpectations.orig: Removed.

11:21 AM Changeset in webkit [213994] by commit-queue@webkit.org

• 6 edits in trunk

[Modern Media Controls] Tracks menu overlaps controls bar in fullscreen
​https://bugs.webkit.org/show_bug.cgi?id=169670
<rdar://problem/31060086>
Source/WebCore:

Patch by Antoine Quint <Antoine Quint> on 2017-03-15
Reviewed by Eric Carlson.

It used to be that the top of the tracks button was the same as the top of the controls
bar, but that changed when we fixed ​https://bugs.webkit.org/show_bug.cgi?id=169412. We
now use the top of the controls bar to computed the y-position for the tracks panel.

We are not adding a new test, instead we're unflaking a test that started failing
reliably once we fixed ​https://bugs.webkit.org/show_bug.cgi?id=169412.

• Modules/modern-media-controls/controls/macos-media-controls.js:

(MacOSMediaControls.prototype.showTracksPanel):

LayoutTests:

Patch by Antoine Quint <Antoine Quint> on 2017-03-15
Reviewed by Eric Carlson.

Unflake a test that checks the tracks panel position in fullscreen.

• media/modern-media-controls/tracks-support/tracks-support-show-panel-fullscreen-expected.txt:
• media/modern-media-controls/tracks-support/tracks-support-show-panel-fullscreen.html:
• platform/mac/TestExpectations:

11:15 AM Changeset in webkit [213993] by rniwa@webkit.org

• 5 edits in trunk/Websites/perf.webkit.org

Make unit tests return a promise instead of manually calling done
​https://bugs.webkit.org/show_bug.cgi?id=169663

Reviewed by Antti Koivisto.

Make the existing unit tests always reutrn a promise instead of manually calling "done" callback as done
in r213969. The promise tests are a lot more stable and less error prone.

Also use MockRemoteAPI.waitForRequest() instead of chaining two resolved promises where appropriate.

• unit-tests/analysis-task-tests.js:
• unit-tests/buildbot-syncer-tests.js:
• unit-tests/checkconfig.js:
• unit-tests/privileged-api-tests.js:

11:15 AM Changeset in webkit [213992] by jonlee@apple.com

• 11 edits
  8 adds in trunk/Source/WebCore

Clean up RTCPeerConnection IDL
​https://bugs.webkit.org/show_bug.cgi?id=169660

Reviewed by Youenn Fablet.

• Modules/mediastream/RTCPeerConnection.cpp:

(WebCore::RTCPeerConnection::addTransceiver): Refactor to use RTCRtpTransceiverInit.
(WebCore::RTCPeerConnection::completeAddTransceiver):

• Modules/mediastream/RTCPeerConnection.h: Remove redundant definitions.
• Modules/mediastream/RTCPeerConnection.idl: Using 13 March 2017 Editor's Draft of

WebRTC spec. Move RTCOfferAnswerOptions out to separate IDLs. Keep RTCDataChannelInit and
RTCRtpTransceiverInit since they appear to be used only in RTCPeerConnection.

Reorder the properties, functions, and events based on their appearance in the spec.

Legacy MediaStream calls are placed at the end. I tried to use "partial interface" in the
same file, but in the end nothing was generated, so everything is contained in one interface
block.

• Modules/mediastream/RTCEnums.h: Added. This will be an all-in-one header to hold the

enums.

Move RTCAnswerOptions, RTCOfferAnswerOptions, RTCOfferOptions, RTCRtpTransceiverDirection
out to their own IDL's.

• CMakeLists.txt:
• DerivedSources.make:
• Modules/mediastream/RTCAnswerOptions.h: Added.
• Modules/mediastream/RTCAnswerOptions.idl: Added.
• Modules/mediastream/RTCOfferAnswerOptions.h:
• Modules/mediastream/RTCOfferAnswerOptions.idl: Added.
• Modules/mediastream/RTCOfferOptions.h: Added. Remove |offerToReceiveVideo| and

|offerToReceiveAudio|, which are not used.

• Modules/mediastream/RTCOfferOptions.idl: Added.
• Modules/mediastream/RTCRtpTransceiverDirection.h: Added.
• Modules/mediastream/RTCRtpTransceiverDirection.idl: Added. Use a typedef for

RTCRtpTransceiverDirection to prevent the code generator from prefixing RTCRtpTransceiver.

• Modules/mediastream/RTCRtpTransceiver.idl: Move RTCRtpTransceiverDirection.
• WebCore.xcodeproj/project.pbxproj: Add IDLs and derived sources. Remove unused

HTMLMediaElementMediaStream.h. Reorder.

Refactor.

• Modules/mediastream/RTCRtpTransceiver.h: Use RTCRtpTransceiverDirection.
• Modules/mediastream/MediaEndpointPeerConnection.cpp:

11:15 AM Changeset in webkit [213991] by Joseph Pecoraro

• 4 edits in trunk/Source/WebInspectorUI

Web Inspector: REGRESSION: Elements Tab > Node Details Sidebar > Properties Section is spammed with TypeErrors
​https://bugs.webkit.org/show_bug.cgi?id=153911
<rdar://problem/24520098>

Reviewed by Devin Rousso.

• UserInterface/Views/DOMNodeDetailsSidebarPanel.js:

(WebInspector.DOMNodeDetailsSidebarPanel.prototype._refreshProperties.nodeResolved.inspectedPage_node_collectPrototypes):
(WebInspector.DOMNodeDetailsSidebarPanel.prototype._refreshProperties.nodeResolved):
Update due to naming conventions for code that evalutes in the inspected page.

(WebInspector.DOMNodeDetailsSidebarPanel.prototype._refreshProperties.fillSection):
(WebInspector.DOMNodeDetailsSidebarPanel.prototype._refreshProperties):
Create a more complete ObjectTreeView for the different sections.

• UserInterface/Views/ObjectTreePropertyTreeElement.js:

(WebInspector.ObjectTreePropertyTreeElement.prototype._updateChildren):
PureAPI behaves the same as ClassAPI and just shows own properties.

• UserInterface/Views/ObjectTreeView.js:

(WebInspector.ObjectTreeView.prototype.showOnlyProperties):
In only properties mode don't show the Prototype expander at the end.

(WebInspector.ObjectTreeView.prototype.setPrototypeNameOverride):
Allow a prototype name override at the top level. This will allow clients
to specify that the object at the top level is a Prototype object, so that
ObjectTreePropertyTreeElements can infer the right NativeFunctionParameter
information knowing that those properties are on a particular prototype.

(WebInspector.ObjectTreeView.prototype.update):
For the PureAPI use getOwnProperties instead of getDisplayableProperties.
This avoids the special handling we have for DOM native properties which
we bubble up to the top as value descriptors even though they are actually
accessor descriptors on prototypes.

(WebInspector.ObjectTreeView.prototype._updateProperties):
Pass the prototype name override onward for object properties.

11:03 AM Changeset in webkit [213990] by zandobersek@gmail.com

• 2 edits in trunk/Source/WebCore

[GTK] Initialize m_button, m_clickCount members in PlatformMouseEvent constructors
​https://bugs.webkit.org/show_bug.cgi?id=169666

Reviewed by Michael Catanzaro.

Initialize the m_button and m_clickCount class members in the GTK+-specific
implementation of PlatformMouseEvent constructors to NoButton and 0,
respectively. The constructors expect to operate on passed-in GTK+ events
that will be able to initialize those two members to some valid values, but
this is not guaranteed.

• platform/gtk/PlatformMouseEventGtk.cpp:

(WebCore::PlatformMouseEvent::PlatformMouseEvent):

11:02 AM Changeset in webkit [213989] by zandobersek@gmail.com

• 5 edits in trunk/Source/WebCore

[TexMap] Add missing class member initializations
​https://bugs.webkit.org/show_bug.cgi?id=169665

Reviewed by Michael Catanzaro.

Zero-initialize the members in various TextureMapper classes
that are missing the proper initialization, as reported by
the Coverity tool.

• platform/graphics/texmap/BitmapTexturePool.h:
• platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.h:
• platform/graphics/texmap/coordinated/CoordinatedGraphicsState.h:

(WebCore::CoordinatedGraphicsLayerState::CoordinatedGraphicsLayerState):

• platform/graphics/texmap/coordinated/SurfaceUpdateInfo.h:

10:59 AM Changeset in webkit [213988] by achristensen@apple.com

• 14 edits in trunk

Compiled content extensions should include the JSON source
​https://bugs.webkit.org/show_bug.cgi?id=169643

Reviewed by Geoffrey Garen.

Source/WebCore:

Serializing the JSON string from which a content extension was compiled
to disk with the compiled content extension will allow us to validate content
extensions and automatically migrate older content extensions to new versions.
It less than doubles the size of the compiled content extension on disk, and when
interpreting the bytecode that memory is never read, so it doesn't increase our
dirty memory usage.

Covered by new API tests.

• contentextensions/ContentExtensionCompiler.cpp:

(WebCore::ContentExtensions::compileRuleList):

• contentextensions/ContentExtensionCompiler.h:

Source/WebKit2:

• UIProcess/API/APIContentExtensionStore.cpp:

(API::ContentExtensionStore::ContentExtensionStore):
(API::ContentExtensionMetaData::fileSize):
(API::encodeContentExtensionMetaData):
(API::decodeContentExtensionMetaData):
(API::compiledToFile):
(API::createExtension):
(API::ContentExtensionStore::getContentExtensionSource):

• UIProcess/API/APIContentExtensionStore.h:
• UIProcess/API/Cocoa/WKContentExtensionStore.mm:

(toWKErrorCode):
(-[WKContentExtensionStore lookupContentExtensionForIdentifier:completionHandler:]):
(-[WKContentExtensionStore removeContentExtensionForIdentifier:completionHandler:]):
(-[WKContentExtensionStore _getContentExtensionSourceForIdentifier:completionHandler:]):

• UIProcess/API/Cocoa/WKContentExtensionStorePrivate.h:
• UIProcess/API/Cocoa/WKError.h:
• UIProcess/API/Cocoa/_WKUserContentExtensionStore.h:
• UIProcess/API/Cocoa/_WKUserContentExtensionStore.mm:

(toUserContentExtensionStoreError):
(-[_WKUserContentExtensionStore compileContentExtensionForIdentifier:encodedContentExtension:completionHandler:]):
(-[_WKUserContentExtensionStore lookupContentExtensionForIdentifier:completionHandler:]):
(-[_WKUserContentExtensionStore removeContentExtensionForIdentifier:completionHandler:]):

Tools:

• TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
• TestWebKitAPI/Tests/WebKit2Cocoa/WKUserContentExtensionStore.mm:

(TEST_F):

10:40 AM Changeset in webkit [213987] by commit-queue@webkit.org

• 3 edits
  4 adds in trunk

[Modern Media Controls] Captions do not default to Auto when language is changed
​https://bugs.webkit.org/show_bug.cgi?id=169675
<rdar://problem/30423369>

Patch by Antoine Quint <Antoine Quint> on 2017-03-15
Reviewed by Eric Carlson.

Source/WebCore:

Ensure we correctly mark the Off and Auto items as selected when we are using the
Off and Auto tracks.

Tests: media/modern-media-controls/tracks-support/tracks-support-auto-text-track.html

media/modern-media-controls/tracks-support/tracks-support-off-text-track.html

• Modules/modern-media-controls/media/tracks-support.js:

(TracksSupport.prototype.tracksPanelIsTrackInSectionSelected):
(TracksSupport.prototype.tracksPanelSelectionDidChange):

LayoutTests:

Add new tests that check the cases where the expected selected track should be "Off" or "Auto".

• media/modern-media-controls/tracks-support/tracks-support-auto-text-track-expected.txt: Added.
• media/modern-media-controls/tracks-support/tracks-support-auto-text-track.html: Added.
• media/modern-media-controls/tracks-support/tracks-support-off-text-track-expected.txt: Added.
• media/modern-media-controls/tracks-support/tracks-support-off-text-track.html: Added.

10:21 AM Changeset in webkit [213986] by commit-queue@webkit.org

• 2 edits in trunk/Tools

Use git's -C flag when possible in VCSUtils.pm
​https://bugs.webkit.org/show_bug.cgi?id=169003

Patch by Kocsen Chung <Kocsen Chung> on 2017-03-15
Reviewed by Sam Weinig.

Use the git -C flag where appropriate to perform the
operation on a target directory and avoid unnecessary logic
to cd in and out of the target directory.

• Scripts/VCSUtils.pm:

(isGitDirectory):
(isGitSVNDirectory):
(svnRevisionForDirectory):
(svnInfoForPath):
For all four subroutines, use git's -C flag and strip cd logic.

10:06 AM Changeset in webkit [213985] by Ryan Haddad

• 10 edits
  1 delete in trunk/Source/WebCore

Unreviewed, rolling out r213977.

This change broke the Windows build.

Reverted changeset:

"Make a base class for WebGL and WebGPU contexts"
​https://bugs.webkit.org/show_bug.cgi?id=169651
​http://trac.webkit.org/changeset/213977

10:04 AM Changeset in webkit [213984] by Ryan Haddad

• 2 edits in trunk/LayoutTests

Mark http/tests/media/modern-media-controls/time-labels-support/long-time.html as flaky on mac-wk1.
​https://bugs.webkit.org/show_bug.cgi?id=169677

Unreviewed test gardening.

• platform/mac-wk1/TestExpectations:

9:38 AM Changeset in webkit [213983] by commit-queue@webkit.org

• 10 edits
  4 adds in trunk

run-webkit-tests is always creating mock libwebrtc tracks
​https://bugs.webkit.org/show_bug.cgi?id=169658

Patch by Youenn Fablet <​youenn@apple.com> on 2017-03-15
Reviewed by Alex Christensen.

Source/WebCore:

Tests: webrtc/peer-connection-audio-mute.html

webrtc/video-mute.html

Creating real libwebrtc av tracks in case of RealTwoPeerConnections mock factory.

• testing/MockLibWebRTCPeerConnection.cpp:

(WebCore::MockLibWebRTCPeerConnectionFactory::CreateVideoTrack):
(WebCore::MockLibWebRTCPeerConnectionFactory::CreateAudioTrack):

• testing/MockLibWebRTCPeerConnection.h:

LayoutTests:

• TestExpectations:
• webrtc/audio-peer-connection-webaudio.html:
• webrtc/peer-connection-audio-mute-expected.txt: Added.
• webrtc/peer-connection-audio-mute.html: Added.
• webrtc/routines.js:

(analyseAudio):

• webrtc/video-expected.txt:
• webrtc/video-mute-expected.txt: Added.
• webrtc/video-mute.html: Added.
• webrtc/video.html:

9:35 AM Changeset in webkit [213982] by commit-queue@webkit.org

• 5 edits in trunk

Preventive clean-up: ensure RTCPeerConnection stays valid when calling postTask
​https://bugs.webkit.org/show_bug.cgi?id=169661

Patch by Youenn Fablet <​youenn@apple.com> on 2017-03-15
Reviewed by Alex Christensen.

Source/WebCore:

Protecting the RTCPeerConnection object when calling postTask since it might get collected between the task post
and task run. Also do not send negotiationNeeded event if RTCPeerConnection is closed (covered by added test).

• Modules/mediastream/RTCPeerConnection.cpp:

(WebCore::RTCPeerConnection::updateIceGatheringState):
(WebCore::RTCPeerConnection::updateIceConnectionState):
(WebCore::RTCPeerConnection::scheduleNegotiationNeededEvent):

LayoutTests:

• webrtc/negotiatedneeded-event-addStream-expected.txt:
• webrtc/negotiatedneeded-event-addStream.html:

8:58 AM Changeset in webkit [213981] by Ryan Haddad

• 2 edits in trunk/LayoutTests

Mark media/modern-media-controls/volume-down-support/volume-down-support.html as flaky.
​https://bugs.webkit.org/show_bug.cgi?id=169568

Unreviewed test gardening.

• platform/mac/TestExpectations:

5:42 AM Changeset in webkit [213980] by commit-queue@webkit.org

• 7 edits
  2 moves in trunk

[Modern Media Controls] Always use six digits to display time when overall media duration is an hour or more
​https://bugs.webkit.org/show_bug.cgi?id=169668
<rdar://problem/31059699>

Patch by Antoine Quint <Antoine Quint> on 2017-03-15
Reviewed by Dean Jackson.

Source/WebCore:

Always use six digits to display times when the overall media duration is an hour or more. This
ensures that we don't display too much white space around labels when we know we will eventually
need six digits to display the full time, but the current time to display is under an hour.

Test: media/modern-media-controls/time-control/time-control-use-six-digits-for-time-labels.html

• Modules/modern-media-controls/controls/time-control.js:

(TimeControl.prototype.get useSixDigitsForTimeLabels):
(TimeControl.prototype.set useSixDigitsForTimeLabels):
(TimeControl.prototype.set width):
(TimeControl.prototype.get isSufficientlyWide):
(TimeControl.prototype._availableWidthHasChanged):
(TimeControl.prototype.get labelsMayDisplayTimesOverAnHour): Deleted.
(TimeControl.prototype.set labelsMayDisplayTimesOverAnHour): Deleted.

• Modules/modern-media-controls/controls/time-label.js:

(TimeLabel.prototype._formattedTime):

• Modules/modern-media-controls/media/time-labels-support.js:

(TimeLabelsSupport.prototype.syncControl):
(TimeLabelsSupport):

LayoutTests:

Rebase some tests due to the rename of the labelsMayDisplayTimesOverAnHour property to
useSixDigitsForTimeLabels. We also add an assertion in long-time.html to check that
we currently use six digits to display a time that is under an hour but where the
media duration is over an hour.

• http/tests/media/modern-media-controls/time-labels-support/long-time-expected.txt:
• http/tests/media/modern-media-controls/time-labels-support/long-time.html:
• media/modern-media-controls/time-control/time-control-use-six-digits-for-time-labels-expected.txt: Renamed from LayoutTests/media/modern-media-controls/time-control/time-control-labels-may-display-times-over-an-hour-expected.txt.
• media/modern-media-controls/time-control/time-control-use-six-digits-for-time-labels.html: Renamed from LayoutTests/media/modern-media-controls/time-control/time-control-labels-may-display-times-over-an-hour.html.

3:19 AM Changeset in webkit [213979] by commit-queue@webkit.org

• 3 edits in trunk/LayoutTests

[mac-wk1 debug] LayoutTest media/modern-media-controls/airplay-placard/airplay-placard-text-section.html is a flaky timeout
​https://bugs.webkit.org/show_bug.cgi?id=169654
<rdar://problem/31059092>

Patch by Antoine Quint <Antoine Quint> on 2017-03-15
Reviewed by Dean Jackson.

Using an asynchronous assertion to improve reliability.

• media/modern-media-controls/airplay-placard/airplay-placard-text-section-expected.txt:
• media/modern-media-controls/airplay-placard/airplay-placard-text-section.html:

2:51 AM Changeset in webkit [213978] by dino@apple.com

• 12 edits in trunk/Source

Sort Xcode project files
​https://bugs.webkit.org/show_bug.cgi?id=169669

Reviewed by Antoine Quint.

Source/JavaScriptCore:

• JavaScriptCore.xcodeproj/project.pbxproj:

Source/WebCore:

• WebCore.xcodeproj/project.pbxproj:

Source/WebCore/PAL:

• PAL.xcodeproj/project.pbxproj:

Source/WebKit:

• WebKit.xcodeproj/project.pbxproj:

Source/WebKit2:

• WebKit2.xcodeproj/project.pbxproj:

Source/WTF:

• WTF.xcodeproj/project.pbxproj:

2:43 AM Changeset in webkit [213977] by dino@apple.com

• 10 edits
  1 add in trunk/Source/WebCore

Make a base class for WebGL and WebGPU contexts
​https://bugs.webkit.org/show_bug.cgi?id=169651
<rdar://problem/31053489>

Reviewed by Simon Fraser.

Add a new pure virtual base class, GPUBasedCanvasRenderingContext, that
will be used by WebGL and WebGPU rendering contexts. This allows us
to avoid some code duplication, since many places treat the two
as the same.

Also rename is3d() -> isWebGL() and isGPU() -> isWebGPU().

• WebCore.xcodeproj/project.pbxproj: New file.
• html/HTMLCanvasElement.cpp:

(WebCore::HTMLCanvasElement::getContextWebGL):
(WebCore::HTMLCanvasElement::getContextWebGPU):
(WebCore::HTMLCanvasElement::reset):
(WebCore::HTMLCanvasElement::paint):
(WebCore::HTMLCanvasElement::isGPUBased):
(WebCore::HTMLCanvasElement::getImageData):
(WebCore::HTMLCanvasElement::isGPU): Deleted.
(WebCore::HTMLCanvasElement::is3D): Deleted.

• html/HTMLCanvasElement.h:
• html/canvas/CanvasRenderingContext.h:

(WebCore::CanvasRenderingContext::isWebGL):
(WebCore::CanvasRenderingContext::isWebGPU):
(WebCore::CanvasRenderingContext::isGPUBased):
(WebCore::CanvasRenderingContext::is3d): Deleted.
(WebCore::CanvasRenderingContext::isGPU): Deleted.

• html/canvas/GPUBasedCanvasRenderingContext.h: Added.

(WebCore::GPUBasedCanvasRenderingContext::GPUBasedCanvasRenderingContext):

• html/canvas/WebGLRenderingContextBase.cpp:

(WebCore::WebGLRenderingContextBase::WebGLRenderingContextBase):

• html/canvas/WebGLRenderingContextBase.h:
• html/canvas/WebGPURenderingContext.cpp:

(WebCore::WebGPURenderingContext::WebGPURenderingContext):

• html/canvas/WebGPURenderingContext.h:
• rendering/RenderLayerBacking.cpp:

(WebCore::canvasCompositingStrategy):

1:35 AM Changeset in webkit [213976] by Dewei Zhu

• 10 edits
  7 adds in trunk/Websites/perf.webkit.org

Rewrite 'pull-os-versions' script in Javascript to add support for reporting os revisions with sub commits.
​https://bugs.webkit.org/show_bug.cgi?id=169542

Reviewed by Ryosuke Niwa.

Extend '/api/commits/<repository>/last-reported' to accept a range and return last reported commits in given range.
Rewrite 'pull-os-versions' in JavaScript and add unit tests for it.
Instead of writing query manually while searching criteria contains null columns, use the methods provided in 'db.php'.
Add '.gitignore' file to ommit files generated by while running tests/instances locally.

• .gitignore: Added.
• public/api/commits.php:
• public/api/report-commits.php:
• public/include/commit-log-fetcher.php:
• public/include/db.php: 'null_columns' of prepare_params should be a reference.
• public/include/report-processor.php:
• server-tests/api-commits.js:

(then):

• server-tests/api-report-commits-tests.js:
• server-tests/resources/mock-logger.js: Added.

(MockLogger):
(MockLogger.prototype.log):
(MockLogger.prototype.error):

• server-tests/resources/mock-subprocess.js: Added.

(MockSubprocess.call):
(MockSubprocess.waitingForInvocation):
(MockSubprocess.inject):
(MockSubprocess.reset):

• server-tests/tools-buildbot-triggerable-tests.js:

(MockLogger): Deleted.
(MockLogger.prototype.log): Deleted.
(MockLogger.prototype.error): Deleted.

• server-tests/tools-os-build-fetcher-tests.js: Added.

(beforeEach):
(return.waitingForInvocationPromise.then):
(then):
(string_appeared_here.return.waitingForInvocationPromise.then):
(return.addSlaveForReport.emptyReport.then):

• tools/js/os-build-fetcher.js: Added.

(OSBuildFetcher):
(OSBuildFetcher.prototype._fetchAvailableBuilds):
(OSBuildFetcher.prototype._computeOrder):
(OSBuildFetcher.prototype._commitsForAvailableBuilds.return.this._subprocess.call.then.):
(OSBuildFetcher.prototype._commitsForAvailableBuilds):
(OSBuildFetcher.prototype._addSubCommitsForBuild):
(OSBuildFetcher.prototype._submitCommits):
(OSBuildFetcher.prototype.fetchAndReportNewBuilds):

• tools/js/subprocess.js: Added.

(const.childProcess.require.string_appeared_here.Subprocess.prototype.call):
(const.childProcess.require.string_appeared_here.Subprocess):

• tools/pull-os-versions.js: Added.

(main):
(syncLoop):

• tools/sync-commits.py:

(Repository.fetch_commits_and_submit):

12:47 AM Changeset in webkit [213975] by zandobersek@gmail.com

• 4 edits in trunk/Source/WebCore

Unreviewed GTK+ build fix. Sprinkle ENABLE(MEDIA_STREAM) build guards
in the Internals class to avoid compilation failures when building
with this feature disabled.

• testing/Internals.cpp:

(WebCore::Internals::~Internals):

• testing/Internals.h:
• testing/Internals.idl:

Mar 14, 2017:

11:18 PM Changeset in webkit [213974] by aakash_jain@apple.com

• 2 edits in trunk/Tools

start-queue-mac.sh should create logs directory if it doesn't exist
​https://bugs.webkit.org/show_bug.cgi?id=169634

Reviewed by Alexey Proskuryakov.

• EWSTools/start-queue-mac.sh: Creating logs directory if it doesn't exist.

10:52 PM Changeset in webkit [213973] by tpopela@redhat.com

• 2 edits in trunk/Source/JavaScriptCore

Wrong condition in offlineasm/risc.rb
​https://bugs.webkit.org/show_bug.cgi?id=169597

Reviewed by Mark Lam.

It's missing the 'and' operator between the conditions.

• offlineasm/risc.rb:

10:21 PM Changeset in webkit [213972] by commit-queue@webkit.org

• 9 edits
  2 adds in trunk

CanvasCapture should not generate a frame per each canvas draw command
​https://bugs.webkit.org/show_bug.cgi?id=169498

Patch by Youenn Fablet <​youenn@apple.com> on 2017-03-14
Reviewed by Simon Fraser & Eric Carlson.

Source/WebCore:

Test: fast/mediastream/captureStream/canvas2d-heavy-drawing.html

Making Canvas capture be asynchronous.
This ensures that one frame will be created for a set of synchronous draw commands.
In the future, we should find a better approach, like aligning with requestAnimationFrame.
Adding internals observer API for media stream tracks.

• Modules/mediastream/CanvasCaptureMediaStreamTrack.cpp:

(WebCore::CanvasCaptureMediaStreamTrack::Source::Source):
(WebCore::CanvasCaptureMediaStreamTrack::Source::canvasChanged):

• Modules/mediastream/CanvasCaptureMediaStreamTrack.h:
• Modules/mediastream/MediaStreamTrack.idl:
• platform/mediastream/RealtimeMediaSource.h:
• testing/Internals.cpp:

(WebCore::Internals::~Internals):
(WebCore::Internals::observeMediaStreamTrack):

• testing/Internals.h:
• testing/Internals.idl:

LayoutTests:

• fast/mediastream/captureStream/canvas2d-heavy-drawing-expected.txt: Added.
• fast/mediastream/captureStream/canvas2d-heavy-drawing.html: Added.

8:28 PM Changeset in webkit [213971] by Wenson Hsieh

• 2 edits in trunk/LayoutTests

Unreviewed, skip fast/media/video-element-in-details-collapse.html on iOS

• platform/ios-simulator/TestExpectations:

8:27 PM Changeset in webkit [213970] by aestes@apple.com

• 4 edits
  2 adds in trunk

[iOS] -[WKWebView _dataForDisplayedPDF] returns nil when called before an encrypted PDF has been unlocked
​https://bugs.webkit.org/show_bug.cgi?id=169653
<rdar://problem/24137675>

Reviewed by Tim Horton.

Source/WebKit2:

• UIProcess/ios/WKPDFView.mm:

(-[WKPDFView pdfDocument]): Changed to return _cgPDFDocument directly instead of via the
UIPDFDocument, which is only created after the PDF has been unlocked.

Tools:

• TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
• TestWebKitAPI/Tests/WebKit2/encrypted.pdf: Added.
• TestWebKitAPI/Tests/WebKit2Cocoa/WKPDFView.mm: Added.

(runTest):
(TEST):

8:19 PM Changeset in webkit [213969] by rniwa@webkit.org

• 13 edits in trunk/Websites/perf.webkit.org

Make server tests return a promise instead of manually calling done
​https://bugs.webkit.org/show_bug.cgi?id=169648

Rubber-stamped by Chris Dumez.

Make the existing server tests always reutrn a promise instead of manually calling "done" callback.
The promise tests are a lot more stable and less error prone.

Also use arrow functions everywhere and use prepareServerTest, renamed from connectToDatabaseInEveryTest,
in more tests instead of manually connecting to database in every test, and reset v3 models.

• server-tests/admin-platforms-tests.js:
• server-tests/admin-reprocess-report-tests.js:
• server-tests/api-build-requests-tests.js:
• server-tests/api-manifest.js:
• server-tests/api-measurement-set-tests.js:

(.postReports): Deleted. Not used in any test.

• server-tests/api-report-commits-tests.js:
• server-tests/api-report-tests.js:
• server-tests/api-update-triggerable.js:
• server-tests/privileged-api-upate-run-status.js:
• server-tests/resources/common-operations.js:

(prepareServerTest): Renamed from connectToDatabaseInEveryTest. Increase the timeout and reset v3 models.

• server-tests/tools-buildbot-triggerable-tests.js:

7:08 PM Changeset in webkit [213968] by commit-queue@webkit.org

• 3 edits in trunk/LayoutTests

REGRESSION (r213882): 12 new/updated web-platform-tests failing
​https://bugs.webkit.org/show_bug.cgi?id=169615

Unreviewed.

Patch by Youenn Fablet <​youenn@apple.com> on 2017-03-14

• TestExpectations: Marking tests requiring updated wptserver as failing.

6:20 PM Changeset in webkit [213967] by Wenson Hsieh

• 3 edits
  2 adds in trunk

RenderElements should unregister for viewport visibility callbacks when they are destroyed
​https://bugs.webkit.org/show_bug.cgi?id=169521
<rdar://problem/30959545>

Reviewed by Simon Fraser.

Source/WebCore:

When registering a RenderElement for viewport visibility callbacks, we always need to make sure that it is unregistered
before it is destroyed. While we account for this in the destructor of RenderElement, we only unregister in the destructor
if we are already registered for visibility callbacks. In the call to RenderObject::willBeDestroyed(), we clear out rare
data, which holds RenderElement's viewport callback registration state, so upon entering the destructor of RenderElement,
we skip unregistration because RenderElement thinks that it is not registered.

We can mitigate this by unregistering the RenderElement earlier, in RenderElement::willBeDestroyed, prior to clearing out
the rare data. However, we'd ideally want to move the cleanup logic out of the destructor altogether and into willBeDestroyed
(see ​https://bugs.webkit.org/show_bug.cgi?id=169650).

Test: fast/media/video-element-in-details-collapse.html

• rendering/RenderElement.cpp:

(WebCore::RenderElement::willBeDestroyed):

LayoutTests:

Adds a new layout test covering this regression. See WebCore ChangeLog for more details.

• fast/media/video-element-in-details-collapse-expected.txt: Added.
• fast/media/video-element-in-details-collapse.html: Added.

5:53 PM Changeset in webkit [213966] by mark.lam@apple.com

• 3 edits in trunk/Source/JavaScriptCore

BytecodeGenerator should use the same function to determine if it needs to store the DerivedConstructor in an ArrowFunction lexical environment.
​https://bugs.webkit.org/show_bug.cgi?id=169647
<rdar://problem/31051832>

Reviewed by Michael Saboff.

• bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::usesDerivedConstructorInArrowFunctionLexicalEnvironment):
(JSC::BytecodeGenerator::initializeArrowFunctionContextScopeIfNeeded):
(JSC::BytecodeGenerator::emitPutDerivedConstructorToArrowFunctionContextScope):

• bytecompiler/BytecodeGenerator.h:

5:18 PM Changeset in webkit [213965] by matthew_hanson@apple.com

• 1 copy in tags/Safari-603.1.30.0.34

Tag Safari-603.1.30.0.34.

5:18 PM Changeset in webkit [213964] by matthew_hanson@apple.com

• 1 copy in tags/Safari-603.1.30.1.33

Tag Safari-603.1.30.1.33.

5:17 PM Changeset in webkit [213963] by dino@apple.com

• 2 edits in trunk/Source/WebCore

Rename LayerTypeWebGLLayer and use it for both WebGL and WebGPU
​https://bugs.webkit.org/show_bug.cgi?id=169628
<rdar://problems/31047025>

Fix Windows build.

• platform/graphics/ca/win/PlatformCALayerWin.cpp:

(printLayer):

5:09 PM Changeset in webkit [213962] by matthew_hanson@apple.com

• 1 delete in tags/Safari-603.1.30.0.34

Delete tag.

5:05 PM Changeset in webkit [213961] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Exception when fetching computed styles can break future updates of section
​https://bugs.webkit.org/show_bug.cgi?id=169638
<rdar://problem/30588688>

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2017-03-14
Reviewed by Devin Rousso.

• UserInterface/Models/DOMNodeStyles.js:

(WebInspector.DOMNodeStyles.prototype.refresh.wrap):
(WebInspector.DOMNodeStyles.prototype.refresh):
Gracefully handle exceptions. If an exception did happen we
would be unable to update these in the future.

4:44 PM Changeset in webkit [213960] by BJ Burg

• 6 edits in trunk/Source/JavaScriptCore

[Cocoa] Web Inspector: generated code for parsing an array of primitive-type enums from payload does not work
​https://bugs.webkit.org/show_bug.cgi?id=169629

Reviewed by Joseph Pecoraro.

This was encountered while trying to compile new protocol definitions that support the Actions API.

• inspector/scripts/codegen/models.py:

(EnumType.repr): Improve debug logging so fields match the class member names.

• inspector/scripts/codegen/objc_generator.py:

(ObjCGenerator.payload_to_objc_expression_for_member):
If the array elements are actually a primitive type, then there's no need to do any
conversion from a payload. This happens for free since the payload is a tree of
NSDictionary, NSString, NSNumber, etc.

• inspector/scripts/tests/generic/expected/shadowed-optional-type-setters.json-result:
• inspector/scripts/tests/generic/expected/type-declaration-object-type.json-result:

Rebaseline.

• inspector/scripts/tests/generic/type-declaration-object-type.json:

Add new cases for properties that contain an array with enum type references and an array of anonymous enums.

4:41 PM Changeset in webkit [213959] by matthew_hanson@apple.com

• 3 edits in branches/safari-603.1.30.1-branch/LayoutTests

Merge r213953. rdar://problem/31049877

4:41 PM Changeset in webkit [213958] by matthew_hanson@apple.com

• 2 edits in branches/safari-603.1.30.1-branch/Source/WebCore

Merge r213949. rdar://problem/31049877

4:41 PM Changeset in webkit [213957] by matthew_hanson@apple.com

• 5 edits in branches/safari-603.1.30.1-branch/Source

Versioning.

4:35 PM Changeset in webkit [213956] by matthew_hanson@apple.com

• 3 edits in branches/safari-603.1.30.0-branch/LayoutTests

Merge r213953. rdar://problem/31049771

4:34 PM Changeset in webkit [213955] by matthew_hanson@apple.com

• 2 edits in branches/safari-603.1.30.0-branch/Source/WebCore

Merge r213949. rdar://problem/31049771

4:18 PM Changeset in webkit [213954] by timothy_horton@apple.com

• 4 edits in trunk/Source/WebKit2

Let PDFLayerController drive cursor updates so that it's correct more often
​https://bugs.webkit.org/show_bug.cgi?id=169626
<rdar://problem/30762943>

Reviewed by Simon Fraser.

• WebProcess/Plugins/PDF/DeprecatedPDFLayerControllerSPI.h:
• WebProcess/Plugins/PDF/DeprecatedPDFPlugin.h:
• WebProcess/Plugins/PDF/DeprecatedPDFPlugin.mm:

(-[WKPDFLayerControllerDelegate setMouseCursor:]):
(WebKit::PDFPlugin::handleMouseEvent):
(WebKit::PDFPlugin::handleMouseEnterEvent):
(WebKit::pdfLayerControllerCursorTypeToCursor):
(WebKit::PDFPlugin::notifyCursorChanged):
Disable updateCursor and use the setMouseCursor delegate method when possible.

4:17 PM Changeset in webkit [213953] by aestes@apple.com

• 3 edits in trunk/LayoutTests

Update ApplePaySession.html after r213949

Rubber-stamped by Beth Dakin.

• http/tests/ssl/applepay/ApplePaySession-expected.txt:
• http/tests/ssl/applepay/ApplePaySession.html:

4:06 PM Changeset in webkit [213952] by rniwa@webkit.org

• 31 edits
  1 move
  1 delete in trunk/Websites/perf.webkit.org

Rename RootSet to CommitSet
​https://bugs.webkit.org/show_bug.cgi?id=169580

Rubber-stamped by Chris Dumez.

Renamed root_sets to commit_sets and roots to commit_set_relationships in the database schema, and renamed
related classes in public/v3/ and tools accordingly.

RootSet, MeasurementRootSet, and CustomRootSet are respectively renamed to CommitSet, MeasurementCommitSet,
and CustomCommitSet.

In order to migrate the database, run:
`
BEGIN;
ALTER TABLE root_sets RENAME TO commit_sets;
ALTER TABLE commit_sets RENAME COLUMN rootset_id TO commitset_id;
ALTER TABLE roots RENAME TO commit_set_relationships;
ALTER TABLE commit_set_relationships RENAME COLUMN root_set TO commitset_set;
ALTER TABLE commit_set_relationships RENAME COLUMN root_commit TO commitset_commit;
ALTER TABLE build_requests RENAME COLUMN request_root_set TO request_commit_set;
END;
`

• browser-tests/index.html:
• init-database.sql:
• public/api/build-requests.php:

(main):

• public/api/test-groups.php:

(main):
(format_test_group):

• public/include/build-requests-fetcher.php:

(BuildRequestsFetcher::construct):
(BuildRequestsFetcher::results_internal):
(BuildRequestsFetcher::commit_sets): Renamed from root_sets.
(BuildRequestsFetcher::commits): Renamed from roots.
(BuildRequestsFetcher::fetch_commits_for_set_if_needed): Renamed from fetch_roots_for_set_if_needed.

• public/privileged-api/create-test-group.php:

(main):
(ensure_commit_sets): Renamed from commit_sets_from_root_sets.

• public/v3/components/analysis-results-viewer.js:

(AnalysisResultsViewer.prototype.buildRowGroups):
(AnalysisResultsViewer.prototype._collectCommitSetsInTestGroups): Renamed from _collectRootSetsInTestGroups.
(AnalysisResultsViewer.prototype._buildRowsForPointsAndTestGroups):
(AnalysisResultsViewer.prototype._buildRowsForPointsAndTestGroups):
(AnalysisResultsViewer.CommitSetInTestGroup): Renamed from RootSetInTestGroup.
(AnalysisResultsViewer.CommitSetInTestGroup.prototype.constructor):
(AnalysisResultsViewer.CommitSetInTestGroup.prototype.commitSet): Renamed from rootSet.
(AnalysisResultsViewer.CommitSetInTestGroup.prototype.succeedingCommitSet): Renamed from succeedingRootSet.
(AnalysisResultsViewer.TestGroupStackingBlock.prototype.constructor):
(AnalysisResultsViewer.TestGroupStackingBlock.prototype.addRowIndex):
(AnalysisResultsViewer.TestGroupStackingBlock.prototype.isComplete):
(AnalysisResultsViewer.TestGroupStackingBlock.prototype.startRowIndex):
(AnalysisResultsViewer.TestGroupStackingBlock.prototype.endRowIndex):
(AnalysisResultsViewer.TestGroupStackingBlock.prototype._computeTestGroupStatus):

• public/v3/components/chart-revision-range.js:

(ChartRevisionRange.prototype._revisionForPoint):
(ChartRevisionRange.prototype._computeRevisionList):

• public/v3/components/customizable-test-group-form.js:

(CustomizableTestGroupForm.prototype.constructor):
(CustomizableTestGroupForm.prototype.setCommitSetMap): Renamed from setRootSetMap.
(CustomizableTestGroupForm.prototype._submitted):
(CustomizableTestGroupForm.prototype._computeCommitSetMap): Renamed from _computeRootSetMap.
(CustomizableTestGroupForm.prototype.render): Renamed from render.
(CustomizableTestGroupForm.prototype._constructRevisionRadioButtons):

• public/v3/components/results-table.js:

(ResultsTable.prototype.render):
(ResultsTable.prototype._createRevisionListCells):
(ResultsTable.prototype._computeRepositoryList):
(ResultsTableRow.prototype.constructor):
(ResultsTableRow.prototype.commitSet): Renamed from rootSet.

• public/v3/components/test-group-results-table.js:

(TestGroupResultsTable.prototype.buildRowGroups):

• public/v3/index.html:
• public/v3/models/build-request.js:

(BuildRequest.prototype.constructor):
(BuildRequest.prototype.updateSingleton):
(BuildRequest.prototype.commitSet): Renamed from rootSet.
(BuildRequest.constructBuildRequestsFromData):

• public/v3/models/commit-set.js: Renamed from public/v3/models/root-set.js.

(CommitSet): Renamed from RootSet.
(CommitSet.containsMultipleCommitsForRepository):
(MeasurementCommitSet): Renamed from MeasurementRootSet.
(MeasurementCommitSet.prototype.namedStaticMap):
(MeasurementCommitSet.prototype.ensureNamedStaticMap):
(MeasurementCommitSet.namedStaticMap):
(MeasurementCommitSet.ensureNamedStaticMap):
(MeasurementCommitSet.ensureSingleton):
(CustomCommitSet): Renamed from CustomRootSet.

• public/v3/models/measurement-adaptor.js:

(MeasurementAdaptor.prototype.applyTo):

• public/v3/models/test-group.js:

(TestGroup.prototype.constructor):
(TestGroup.prototype.addBuildRequest):
(TestGroup.prototype.repetitionCount):
(TestGroup.prototype.requestedCommitSets): Renamed from requestedRootSets.
(TestGroup.prototype.requestsForCommitSet): Renamed from requestsForRootSet.
(TestGroup.prototype.labelForCommitSet): Renamed from labelForRootSet.
(TestGroup.prototype.didSetResult):
(TestGroup.prototype.compareTestResults):
(TestGroup.prototype._valuesForCommitSet): Renamed from _valuesForRootSet.
(TestGroup.prototype.createAndRefetchTestGroups):

• public/v3/pages/analysis-task-page.js:

(AnalysisTaskPage.prototype.render):
(AnalysisTaskPage.prototype._retryCurrentTestGroup):
(AnalysisTaskPage.prototype._createNewTestGroupFromChart):
(AnalysisTaskPage.prototype._createNewTestGroupFromViewer):
(AnalysisTaskPage.prototype._createTestGroupAfterVerifyingCommitSetList):

• server-tests/api-build-requests-tests.js:
• server-tests/resources/mock-data.js:

(MockData.resetV3Models):
(MockData.addMockData):
(MockData.addAnotherMockTestGroup):

• tools/detect-changes.js:

(createAnalysisTaskAndNotify):

• tools/js/buildbot-syncer.js:

(BuildbotSyncer.prototype._propertiesForBuildRequest):
(BuildbotSyncer.prototype._revisionSetFromCommitSetWithExclusionList):

• tools/js/database.js:

(tableToPrefixMap):

• tools/js/v3-models.js:
• tools/sync-buildbot.js:

(syncLoop):

• tools/sync-with-buildbot.py: Deleted. No longer used.
• unit-tests/analysis-task-tests.js:
• unit-tests/build-request-tests.js:

(sampleBuildRequestData):

• unit-tests/buildbot-syncer-tests.js:

(sampleCommitSetData):

• unit-tests/measurement-adaptor-tests.js:
• unit-tests/measurement-set-tests.js:
• unit-tests/resources/mock-v3-models.js:

(MockModels.inject):

• unit-tests/test-groups-tests.js:

(sampleTestGroup):

4:03 PM Changeset in webkit [213951] by Ryan Haddad

• 2 edits in trunk/LayoutTests

Mark imported/w3c/web-platform-tests/html/webappapis/scripting/events/event-handler-javascript.html as failing on ios-simulator-wk2.
​https://bugs.webkit.org/show_bug.cgi?id=169640

Unreviewed test gardening.

• platform/ios-simulator-wk2/TestExpectations:

3:59 PM Changeset in webkit [213950] by Ryan Haddad

• 2 edits in trunk/LayoutTests

Mark imported/w3c/web-platform-tests/html/webappapis/scripting/events/event-handler-javascript.html as failing on mac-wk2.
​https://bugs.webkit.org/show_bug.cgi?id=169640

Unreviewed test gardening.

• platform/mac-wk2/TestExpectations:

3:53 PM Changeset in webkit [213949] by aestes@apple.com

• 2 edits in trunk/Source/WebCore

REGRESSION (r209760): Apple Pay doesn't work on sites that specify empty contact fields
​https://bugs.webkit.org/show_bug.cgi?id=169639
<rdar://problem/30957789>

Reviewed by Anders Carlsson.

Shipping and billing contact fields are allowed to be empty.

• Modules/applepay/ApplePaySession.cpp:

(WebCore::convertAndValidate):

3:38 PM Changeset in webkit [213948] by commit-queue@webkit.org

• 3 edits in trunk/Source/WebKit2

Extend WKPreferences to include preferences for testing MediaCapture.
​https://bugs.webkit.org/show_bug.cgi?id=169560

Patch by Andrew Gold <​agold@apple.com> on 2017-03-14
Reviewed by Youenn Fablet.

• UIProcess/API/Cocoa/WKPreferences.mm:

(-[WKPreferences _mockCaptureDevicesEnabled]):
(-[WKPreferences _setMockCaptureDevicesEnabled:]):
(-[WKPreferences _mediaCaptureRequiresSecureConnection]):
(-[WKPreferences _setMediaCaptureRequiresSecureConnection:]):
(-[WKPreferences _enumeratingAllNetworkInterfacesEnabled]):
(-[WKPreferences _setEnumeratingAllNetworkInterfacesEnabled:]):
(-[WKPreferences _iceCandidateFiltertingEnabled]):
(-[WKPreferences _setICECandidateFilteringEnabled:]):

• UIProcess/API/Cocoa/WKPreferencesPrivate.h:

3:36 PM Changeset in webkit [213947] by beidson@apple.com

• 14 edits
  5 moves in trunk

Rename WKHTTPCookieStorage to WKHTTPCookieStore.
​https://bugs.webkit.org/show_bug.cgi?id=169630

Reviewed by Tim Horton.

Source/WebKit2:

• CMakeLists.txt:

• Shared/API/APIObject.h:
• Shared/Cocoa/APIObject.mm:

(API::Object::newObject):

• UIProcess/API/APIHTTPCookieStore.cpp: Renamed from Source/WebKit2/UIProcess/API/APIHTTPCookieStorage.cpp.

(API::HTTPCookieStore::HTTPCookieStore):
(API::HTTPCookieStore::~HTTPCookieStore):
(API::HTTPCookieStore::cookies):
(API::HTTPCookieStore::setCookie):
(API::HTTPCookieStore::setCookies):
(API::HTTPCookieStore::deleteCookie):
(API::HTTPCookieStore::removeCookiesSinceDate):
(API::HTTPCookieStore::setHTTPCookieAcceptPolicy):
(API::HTTPCookieStore::getHTTPCookieAcceptPolicy):

• UIProcess/API/APIHTTPCookieStore.h: Renamed from Source/WebKit2/UIProcess/API/APIHTTPCookieStorage.h.

• UIProcess/API/APIWebsiteDataStore.cpp:

(API::WebsiteDataStore::httpCookieStore):
(API::WebsiteDataStore::httpCookieStorage): Deleted.

• UIProcess/API/APIWebsiteDataStore.h:

• UIProcess/API/Cocoa/WKHTTPCookieStore.h: Renamed from Source/WebKit2/UIProcess/API/Cocoa/WKHTTPCookieStorage.h.
• UIProcess/API/Cocoa/WKHTTPCookieStore.mm: Renamed from Source/WebKit2/UIProcess/API/Cocoa/WKHTTPCookieStorage.mm.

(coreCookiesToNSCookies):
(-[WKHTTPCookieStore dealloc]):
(-[WKHTTPCookieStore fetchCookies:]):
(-[WKHTTPCookieStore fetchCookiesForURL:completionHandler:]):
(-[WKHTTPCookieStore setCookie:completionHandler:]):
(-[WKHTTPCookieStore deleteCookie:completionHandler:]):
(-[WKHTTPCookieStore setCookies:forURL:mainDocumentURL:completionHandler:]):
(-[WKHTTPCookieStore removeCookiesSinceDate:completionHandler:]):
(-[WKHTTPCookieStore setCookieAcceptPolicy:completionHandler:]):
(kitCookiePolicyToNSCookiePolicy):
(-[WKHTTPCookieStore fetchCookieAcceptPolicy:]):
(-[WKHTTPCookieStore _apiObject]):

• UIProcess/API/Cocoa/WKHTTPCookieStoreInternal.h: Renamed from Source/WebKit2/UIProcess/API/Cocoa/WKHTTPCookieStorageInternal.h.

(WebKit::wrapper):

• UIProcess/API/Cocoa/WKWebsiteDataStore.mm:

(-[WKWebsiteDataStore _httpCookieStore]):
(-[WKWebsiteDataStore _httpCookieStorage]): Deleted.

• UIProcess/API/Cocoa/WKWebsiteDataStorePrivate.h:

• UIProcess/WebProcessPool.cpp:
• UIProcess/WebProcessPool.h:

• UIProcess/WebsiteData/WebsiteDataStore.cpp:

(WebKit::WebsiteDataStore::processPoolForCookieStorageOperations):

• WebKit2.xcodeproj/project.pbxproj:

Tools:

• TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStorage.mm:

(TEST):

3:32 PM Changeset in webkit [213946] by andersca@apple.com

• 6 edits in trunk/Source

Propagate PassKit errors
​https://bugs.webkit.org/show_bug.cgi?id=169633
rdar://problem/31043392

Reviewed by Dean Jackson.

Source/WebCore:

• Modules/applepay/ApplePayError.idl:
• Modules/applepay/ApplePaySession.cpp:

(WebCore::convert):
(WebCore::convertAndValidate):

• Modules/applepay/PaymentRequest.h:

Source/WebKit2:

• UIProcess/ApplePay/cocoa/WebPaymentCoordinatorProxyCocoa.mm:

(WebKit::toNSError):

3:23 PM Changeset in webkit [213945] by fpizlo@apple.com

• 2 edits in trunk/Source/WTF

Fix some typos in this benchmark.

Rubber stamped by Saam Barati.

• benchmarks/HashSetDFGReplay.cpp:

(main):

2:58 PM Changeset in webkit [213944] by Alan Bujtas

• 4 edits
  2 adds in trunk

Simple line layout: Adjust hyphenation constrains based on the normal line layout line-breaking logic.
​https://bugs.webkit.org/show_bug.cgi?id=169617

Source/WebCore:

Reviewed by Antti Koivisto.

This patch ensures that simple line layout ends up with the same hyphenation context as normal line layout.

Test: fast/text/simple-line-layout-hyphenation-constrains.html

• rendering/SimpleLineLayout.cpp:

(WebCore::SimpleLineLayout::hyphenPositionForFragment): see webkit.org/b/169613
(WebCore::SimpleLineLayout::splitFragmentToFitLine):

• rendering/line/BreakingContext.h: Integral -> fractional.

(WebCore::tryHyphenating):

LayoutTests:

Reviewed by Antti Koivisto.

• fast/text/simple-line-layout-hyphenation-constrains-expected.html: Added.
• fast/text/simple-line-layout-hyphenation-constrains.html: Added.

2:48 PM Changeset in webkit [213943] by matthew_hanson@apple.com

• 1 copy in tags/Safari-603.1.30.0.34

Tag Safari-603.1.30.0.34.

2:41 PM Changeset in webkit [213942] by webkit@devinrousso.com

• 5 edits in trunk/Source/WebInspectorUI

Web Inspector: RTL: add support for Memory timeline
​https://bugs.webkit.org/show_bug.cgi?id=169584

Reviewed by Brian Burg.

• UserInterface/Views/MemoryCategoryView.css:

(.memory-category-view > .details):
(body[dir=ltr] .memory-category-view > .details):
(body[dir=rtl] .memory-category-view > .details):

• UserInterface/Views/MemoryTimelineOverviewGraph.css:

(.timeline-overview-graph.memory > .legend):
(body[dir=ltr] .timeline-overview-graph.memory > .legend):
(body[dir=rtl] .timeline-overview-graph.memory > .legend):
(.timeline-overview-graph.memory .memory-pressure-event):
(body[dir=ltr] .timeline-overview-graph.memory .memory-pressure-event):
(body[dir=rtl] .timeline-overview-graph.memory .memory-pressure-event):

• UserInterface/Views/MemoryTimelineOverviewGraph.js:

(WebInspector.MemoryTimelineOverviewGraph.prototype.layout):
Rework the calculation for the marker offset to use "right" in RTL.

• UserInterface/Views/MemoryTimelineView.css:

(.timeline-view.memory > .content > .details > .timeline-ruler):
(body[dir=ltr] .timeline-view.memory > .content > .details > .timeline-ruler):
(body[dir=rtl] .timeline-view.memory > .content > .details > .timeline-ruler):
(.timeline-view.memory > .content > .overview > .divider):
(body[dir=ltr] .timeline-view.memory > .content > .overview > .divider):
(body[dir=rtl] .timeline-view.memory > .content > .overview > .divider):
(.timeline-view.memory .legend):
(body[dir=ltr] .timeline-view.memory .legend):
(body[dir=rtl] .timeline-view.memory .legend):
(.timeline-view.memory .legend > .row):
(.timeline-view.memory .legend > .row > .swatch):
(body[dir=ltr] .timeline-view.memory .legend > .row > .swatch):
(body[dir=rtl] .timeline-view.memory .legend > .row > .swatch):
(body[dir=ltr] .timeline-view.memory .legend > .row > :matches(.label, .size)):
(body[dir=rtl] .timeline-view.memory .legend > .row > :matches(.label, .size)):
(.timeline-view.memory .legend > .row > .label):
(.timeline-view.memory .legend > .row > .size):

2:41 PM Changeset in webkit [213941] by jer.noble@apple.com

• 25 edits
  2 adds in trunk/Source

Refactor: Allow WebKit2 to override the creation of RealtimeMediaSources
​https://bugs.webkit.org/show_bug.cgi?id=169227

Reviewed by Eric Carlson.

Source/WebCore:

Allow clients of RealtimeMediaSourceCenter to specify a factory for creating
RealtimeMediaSources, to be used by subclasess of RealtimeMediaSourceCenter. Add virtual
methods to retrieve the "default" factories for the RealtimeMediaSourceCenter subclass. The
requires moving the creation of sources up from CaptureDeviceManager into
RealtimeMediaSourceCenterMac, and the addition of factory methods to AVAudioCaptureSource
and AVVideoCaptureSource.

• platform/mediastream/CaptureDeviceManager.cpp:

(CaptureDeviceManager::deviceWithUID):
(CaptureDeviceManager::bestSourcesForTypeAndConstraints): Deleted.
(CaptureDeviceManager::sourceWithUID): Deleted.

• platform/mediastream/CaptureDeviceManager.h:
• platform/mediastream/RealtimeMediaSource.h:
• platform/mediastream/RealtimeMediaSourceCenter.cpp:

(WebCore::RealtimeMediaSourceCenter::setAudioFactory):
(WebCore::RealtimeMediaSourceCenter::unsetAudioFactory):
(WebCore::RealtimeMediaSourceCenter::setVideoFactory):
(WebCore::RealtimeMediaSourceCenter::unsetVideoFactory):

• platform/mediastream/RealtimeMediaSourceCenter.h:

(WebCore::RealtimeMediaSourceCenter::audioFactory):
(WebCore::RealtimeMediaSourceCenter::videoFactory):

• platform/mediastream/mac/AVAudioCaptureSource.h:
• platform/mediastream/mac/AVAudioCaptureSource.mm:

(WebCore::AVAudioCaptureSource::factory):

• platform/mediastream/mac/AVCaptureDeviceManager.h:
• platform/mediastream/mac/AVCaptureDeviceManager.mm:

(WebCore::AVCaptureDeviceManager::createMediaSourceForCaptureDeviceWithConstraints): Deleted.

• platform/mediastream/mac/AVMediaCaptureSource.h:
• platform/mediastream/mac/AVVideoCaptureSource.h:
• platform/mediastream/mac/AVVideoCaptureSource.mm:

(WebCore::AVVideoCaptureSource::factory):

• platform/mediastream/mac/RealtimeMediaSourceCenterMac.cpp:

(WebCore::RealtimeMediaSourceCenterMac::RealtimeMediaSourceCenterMac):
(WebCore::RealtimeMediaSourceCenterMac::validateRequestConstraints):
(WebCore::RealtimeMediaSourceCenterMac::createMediaStream):
(WebCore::RealtimeMediaSourceCenterMac::bestSourcesForTypeAndConstraints):
(WebCore::RealtimeMediaSourceCenterMac::defaultAudioFactory):
(WebCore::RealtimeMediaSourceCenterMac::defaultVideoFactory):

• platform/mediastream/mac/RealtimeMediaSourceCenterMac.h:
• platform/mock/MockRealtimeAudioSource.cpp:

(WebCore::MockRealtimeAudioSource::factory):

• platform/mock/MockRealtimeAudioSource.h:
• platform/mock/MockRealtimeMediaSourceCenter.cpp:

(WebCore::MockRealtimeMediaSourceCenter::defaultAudioFactory):
(WebCore::MockRealtimeMediaSourceCenter::defaultVideoFactory):

• platform/mock/MockRealtimeMediaSourceCenter.h:
• platform/mock/MockRealtimeVideoSource.cpp:

(WebCore::MockRealtimeVideoSource::factory):

• platform/mock/MockRealtimeVideoSource.h:

Source/WebKit2:

• WebKit2.xcodeproj/project.pbxproj:
• WebProcess/WebCoreSupport/WebUserMediaClient.cpp:

(WebKit::WebUserMediaClient::WebUserMediaClient):
(WebKit::WebUserMediaClient::initializeFactories): Add empty non-Cocoa implementation.

• WebProcess/WebCoreSupport/WebUserMediaClient.h:
• WebProcess/WebCoreSupport/cocoa/WebUserMediaClientMac.mm: Added.

(WebKit::WebUserMediaClient::initializeFactories): Initialize a (for now) pass-through factory.

2:39 PM Changeset in webkit [213940] by dino@apple.com

• 10 edits in trunk/Source

Rename LayerTypeWebGLLayer and use it for both WebGL and WebGPU
​https://bugs.webkit.org/show_bug.cgi?id=169628
<rdar://problems/31047025>

Reviewed by Simon Fraser.

Rename LayerTypeWebGLLayer to LayerTypeContentsProvidedLayer
and use it for both WebGLLayer and WebGPULayer, to avoid
code duplication.

Source/WebCore:

• platform/graphics/ca/PlatformCALayer.cpp:

(WebCore::operator<<):

• platform/graphics/ca/PlatformCALayer.h:
• platform/graphics/ca/cocoa/PlatformCALayerCocoa.mm:

(PlatformCALayerCocoa::layerTypeForPlatformLayer):
(PlatformCALayerCocoa::PlatformCALayerCocoa):
(PlatformCALayerCocoa::commonInit):

Source/WebKit2:

• Shared/mac/RemoteLayerBackingStore.mm:

(WebKit::RemoteLayerBackingStore::drawInContext):

• Shared/mac/RemoteLayerTreeTransaction.mm:

(WebKit::RemoteLayerTreeTransaction::description):

• UIProcess/ios/RemoteLayerTreeHostIOS.mm:

(WebKit::RemoteLayerTreeHost::createLayer):

• UIProcess/mac/RemoteLayerTreeHost.mm:

(WebKit::RemoteLayerTreeHost::createLayer):

• WebProcess/WebPage/mac/PlatformCALayerRemoteCustom.mm:

(WebKit::PlatformCALayerRemoteCustom::PlatformCALayerRemoteCustom):
(WebKit::PlatformCALayerRemoteCustom::clone):

2:37 PM Changeset in webkit [213939] by fpizlo@apple.com

• 13 edits
  7 adds in trunk/Source

Record the HashSet/HashMap operations in DFG/FTL/B3 and replay them in a benchmark
​https://bugs.webkit.org/show_bug.cgi?id=169590

Reviewed by Saam Barati.

Source/JavaScriptCore:

Adds code to support logging some hashtable stuff in the DFG.

• dfg/DFGAvailabilityMap.cpp:

(JSC::DFG::AvailabilityMap::pruneHeap):

• dfg/DFGCombinedLiveness.cpp:

(JSC::DFG::liveNodesAtHead):
(JSC::DFG::CombinedLiveness::CombinedLiveness):

• dfg/DFGCombinedLiveness.h:
• dfg/DFGLivenessAnalysisPhase.cpp:

(JSC::DFG::LivenessAnalysisPhase::run):
(JSC::DFG::LivenessAnalysisPhase::processBlock):

• dfg/DFGNode.cpp:
• dfg/DFGNode.h:
• dfg/DFGObjectAllocationSinkingPhase.cpp:

Source/WTF:

This adds LoggingHashSet and LoggingHashMap, which are drop-in replacements for HashSet and
HashMap that log everything that they do, so that you can replay it later.

This also adds a benchmark (HashSetDFGReplay) based on doing a recording of some of the HashSets
in the DFG compiler.

• WTF.xcodeproj/project.pbxproj:
• benchmarks/HashSetDFGReplay.cpp: Added.

(benchmark):
(main):

• wtf/CMakeLists.txt:
• wtf/GlobalVersion.cpp: Added.

(WTF::newGlobalVersion):

• wtf/GlobalVersion.h: Added.
• wtf/HashMap.h:

(WTF::X>::swap):

• wtf/HashSet.h:

(WTF::V>::addVoid):

• wtf/LoggingHashID.h: Added.

(WTF::LoggingHashID::LoggingHashID):
(WTF::LoggingHashID::dump):

• wtf/LoggingHashMap.h: Added.
• wtf/LoggingHashSet.h: Added.
• wtf/LoggingHashTraits.h: Added.

(WTF::LoggingHashKeyTraits::print):
(WTF::LoggingHashValueTraits::print):

2:16 PM Changeset in webkit [213938] by Ryan Haddad

• 2 edits in trunk/LayoutTests

Mark imported/w3c/web-platform-tests/cors/status.htm as flaky.
​https://bugs.webkit.org/show_bug.cgi?id=169625

Unreviewed test gardening.

• TestExpectations:

1:55 PM Changeset in webkit [213937] by matthew_hanson@apple.com

• 5 edits in branches/safari-603.1.30.0-branch/Source

‘Versioning.’

1:50 PM Changeset in webkit [213936] by jer.noble@apple.com

• 9 edits in trunk/Source

Make classes used by Media Stream encode/decode friendly
​https://bugs.webkit.org/show_bug.cgi?id=169567

Reviewed by Eric Carlson.

Source/WebCore:

Add encode() and decode() methods and implementations to a variety of media stream related classes.

• platform/audio/mac/CAAudioStreamDescription.h:

(WebCore::CAAudioStreamDescription::encode):
(WebCore::CAAudioStreamDescription::decode):

• platform/mediastream/RealtimeMediaSourceSettings.h:

(WebCore::RealtimeMediaSourceSettings::width):
(WebCore::RealtimeMediaSourceSettings::setWidth):
(WebCore::RealtimeMediaSourceSettings::height):
(WebCore::RealtimeMediaSourceSettings::setHeight):
(WebCore::RealtimeMediaSourceSettings::sampleRate):
(WebCore::RealtimeMediaSourceSettings::setSampleRate):
(WebCore::RealtimeMediaSourceSettings::sampleSize):
(WebCore::RealtimeMediaSourceSettings::setSampleSize):
(WebCore::RealtimeMediaSourceSettings::encode):
(WebCore::RealtimeMediaSourceSettings::decode):

• platform/mediastream/RealtimeMediaSourceSupportedConstraints.h:

(WebCore::RealtimeMediaSourceSupportedConstraints::encode):
(WebCore::RealtimeMediaSourceSupportedConstraints::decode):

Source/WebKit2:

Make the encoder and decoder for MediaConstraintsData a little less wordy.

• Shared/WebCoreArgumentCoders.cpp:

(IPC::ArgumentCoder<MediaConstraintsData>::encode):
(IPC::ArgumentCoder<MediaConstraintsData>::decode):

Source/WTF:

• wtf/MediaTime.h:

(WTF::MediaTime::encode):
(WTF::MediaTime::decode):

1:45 PM Changeset in webkit [213935] by jer.noble@apple.com

• 5 edits
  2 adds in trunk/Source

Adapt CARingBuffer to be usable across processes
​https://bugs.webkit.org/show_bug.cgi?id=169591

Reviewed by Alex Christensen.

Source/WebCore:

When used with a SharedMemory backing store, storing the pointers to channel data at the beginning
of the channel data itself is problematic: when the SharedMemory is mapped on the far side of the
process boundary, it will not exist at the same memory location as it did on the near side. Instead
of storing these pointers inside the channel data, store them in a small (usually 1 or 2 entry) vector
recreated when the backing store is (re-)allocated.

• platform/audio/mac/CARingBuffer.cpp:

(WebCore::CARingBuffer::CARingBuffer):
(WebCore::CARingBuffer::allocate):
(WebCore::CARingBuffer::deallocate):
(WebCore::ZeroRange):
(WebCore::StoreABL):
(WebCore::FetchABL):
(WebCore::CARingBuffer::store):
(WebCore::CARingBuffer::getCurrentFrameBounds):
(WebCore::CARingBuffer::fetch):

• platform/audio/mac/CARingBuffer.h:

Source/WebKit2:

Add a new class which wraps a SharedMemory object and uses that shared memory as the
backing store of a CARingBuffer. This backing store can be set to "read only", which
prevents the backing from being de- or re-allocated.

• WebKit2.xcodeproj/project.pbxproj:
• Shared/Cocoa/SharedRingBufferStorage.cpp: Added.

(WebKit::SharedRingBufferStorage::setStorage):
(WebKit::SharedRingBufferStorage::setReadOnly):
(WebKit::SharedRingBufferStorage::allocate):
(WebKit::SharedRingBufferStorage::deallocate):
(WebKit::SharedRingBufferStorage::data):

• Shared/Cocoa/SharedRingBufferStorage.h: Added.

(WebKit::SharedRingBufferStorage::SharedRingBufferStorage):
(WebKit::SharedRingBufferStorage::invalidate):
(WebKit::SharedRingBufferStorage::storage):
(WebKit::SharedRingBufferStorage::readOnly):

1:07 PM Changeset in webkit [213934] by Ryan Haddad

• 2 edits in trunk/LayoutTests

Mark imported/w3c/web-platform-tests/IndexedDB/fire-error-event-exception.html as flaky on mac-wk2.
​https://bugs.webkit.org/show_bug.cgi?id=169621

Unreviewed test gardening.

• platform/mac-wk2/TestExpectations:

1:03 PM Changeset in webkit [213933] by eric.carlson@apple.com

• 3 edits in trunk/Source/WebKit2

[iOS] The web process should inherit application state from UI process
​https://bugs.webkit.org/show_bug.cgi?id=169156
<rdar://problem/30845473>

Reviewed by Brady Eidson.

Move PID proxy setup to platformInitializeWebProcess as suggested in
post-landing feedback.

• WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::platformInitialize):

• WebProcess/cocoa/WebProcessCocoa.mm:

(WebKit::WebProcess::platformInitializeWebProcess):

1:01 PM Changeset in webkit [213932] by commit-queue@webkit.org

• 2 edits in trunk/Source/JavaScriptCore

Web Inspector: Remove unused Network protocol event
​https://bugs.webkit.org/show_bug.cgi?id=169619

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2017-03-14
Reviewed by Mark Lam.

• inspector/protocol/Network.json:

This became unused in r213621 and should have been removed
from the protocol file then.

12:57 PM Changeset in webkit [213931] by jer.noble@apple.com

• 3 edits in trunk/Source/WebCore

Pulling more frames from AudioSampleDataSource than the last push added will always fail.
​https://bugs.webkit.org/show_bug.cgi?id=168644

Reviewed by Eric Carlson.

Rather than use the delta between the ring buffer's end time and the last pushed timestamp
(or what is effectively the number of samples in the last push operation) to determine if
there is enough buffered data to satisfy a pull operation, use the ring buffer's actual
buffered duration.

Then, instead of saving the last pushed timestamp, explicitly save the last push count, and
use that data to inform how much to offset the output timestamps (or what is effectively how
much to allow the source to pre-buffer).

• platform/audio/mac/AudioSampleDataSource.cpp:

(WebCore::AudioSampleDataSource::pushSamplesInternal):
(WebCore::AudioSampleDataSource::pullSamplesInternal):

• platform/audio/mac/AudioSampleDataSource.h:

12:29 PM Changeset in webkit [213930] by mark.lam@apple.com

• 3 edits in trunk/Source/JavaScriptCore

Add a null check in VMTraps::willDestroyVM() to handle a race condition.
​https://bugs.webkit.org/show_bug.cgi?id=169620

Reviewed by Filip Pizlo.

There exists a race between VMTraps::willDestroyVM() (which removed SignalSenders
from its m_signalSenders list) and SignalSender::send() (which removes itself
from the list). In the event that SignalSender::send() removes itself between
the time that VMTraps::willDestroyVM() checks if m_signalSenders is empty and the
time it takes a sender from m_signalSenders, VMTraps::willDestroyVM() may end up
with a NULL sender pointer. The fix is to add the missing null check before using
the sender pointer.

• runtime/VMTraps.cpp:

(JSC::VMTraps::willDestroyVM):
(JSC::VMTraps::fireTrap):

• runtime/VMTraps.h:

12:22 PM Changeset in webkit [213929] by Megan Gardner

• 4 edits in trunk/Source

Correctly export WebItemProviderPasteboard
​https://bugs.webkit.org/show_bug.cgi?id=169578

Reviewed by Tim Horton.

Source/WebCore:

• platform/ios/WebItemProviderPasteboard.h:

Source/WebKit/mac:

• MigrateHeaders.make:

12:20 PM Changeset in webkit [213928] by webkit@devinrousso.com

• 7 edits in trunk/Source/WebInspectorUI

Web Inspector: RTL: add support for Timeline graphs
​https://bugs.webkit.org/show_bug.cgi?id=169585

Reviewed by Brian Burg.

• UserInterface/Views/HeapAllocationsTimelineOverviewGraph.js:

(WebInspector.HeapAllocationsTimelineOverviewGraph.prototype.layout):
Rework the calculation for the icon offset to use "right" in RTL.

• UserInterface/Views/MemoryTimelineOverviewGraph.css:

(body[dir=rtl] .timeline-overview-graph.memory > .stacked-line-chart):
Flip the chart when in RTL.

• UserInterface/Views/TimelineRecordBar.css:

(.timeline-record-bar):
(body[dir=ltr] .timeline-record-bar > .segment.inactive):
(body[dir=rtl] .timeline-record-bar > .segment.inactive):
(body[dir=ltr] .timeline-record-bar.unfinished > .segment):
(body[dir=rtl] .timeline-record-bar.unfinished > .segment):
(body[dir=ltr] .timeline-record-bar.has-inactive-segment > .segment:not(.inactive)):
(body[dir=rtl] .timeline-record-bar.has-inactive-segment > .segment:not(.inactive)):
(body[dir=ltr] :matches(:focus, .force-focus) .selected .timeline-record-bar.has-inactive-segment > .segment:not(.inactive)):
(body[dir=rtl] :matches(:focus, .force-focus) .selected .timeline-record-bar.has-inactive-segment > .segment:not(.inactive)):
(.timeline-record-bar > .segment.inactive,): Deleted.
(.timeline-record-bar.has-inactive-segment > .segment:not(.inactive)): Deleted.
(:matches(:focus, .force-focus) .selected .timeline-record-bar.has-inactive-segment > .segment:not(.inactive)): Deleted.

• UserInterface/Views/TimelineRecordBar.js:

(WebInspector.TimelineRecordBar.prototype.refresh):
Apply the position updates to "right" in RTL.

• UserInterface/Views/TimelineRecordFrame.js:

(WebInspector.TimelineRecordFrame.prototype.refresh):
Apply the position updates to "right" in RTL.

• UserInterface/Views/TimelineRuler.js:

(WebInspector.TimelineRuler.prototype.layout):
(WebInspector.TimelineRuler.prototype._updatePositionOfElement):
(WebInspector.TimelineRuler.prototype._updateMarkers):
(WebInspector.TimelineRuler.prototype._updateSelection):
Apply the position updates to "right" in RTL.

12:16 PM Changeset in webkit [213927] by Ryan Haddad

• 6 edits in trunk/Source/WebKit2

Unreviewed, rolling out r213915.

Caused WK2 LayoutTests to exit early with timeouts.

Reverted changeset:

"Fix uninitialized public members in NetworkProcess"
​https://bugs.webkit.org/show_bug.cgi?id=169598
​http://trac.webkit.org/changeset/213915

12:16 PM Changeset in webkit [213926] by Jonathan Bedard

• 3 edits in trunk/Tools

webkitpy: Efficient app installation for device testing
​https://bugs.webkit.org/show_bug.cgi?id=169054
<rdar://problem/30790207>

Reviewed by Daniel Bates.

We should only install an app on a device once, not every time the app is run.
Move app installation to setup.

• Scripts/webkitpy/port/ios.py:

(IOSPort.setup_test_run): Install app to device.

• Scripts/webkitpy/port/simulator_process.py:

(SimulatorProcess.init): Remove app installation.

12:12 PM Changeset in webkit [213925] by webkit@devinrousso.com

• 4 edits in trunk/Source/WebInspectorUI

Web Inspector: RTL: add support for DataGrid disclosure arrows and indentation
​https://bugs.webkit.org/show_bug.cgi?id=169582

Reviewed by Brian Burg.

• UserInterface/Views/DataGrid.css:

(body[dir=rtl] .data-grid tr.parent td.disclosure::before):
Flip the image in RTL.

• UserInterface/Views/DataGrid.js:

(WebInspector.DataGrid.prototype._updateScrollbarPadding):
Rework the padding calculation for the scrollbar offset to use "right" in RTL.

• UserInterface/Views/DataGridNode.js:

(WebInspector.DataGridNode.prototype.get indentPadding):
(WebInspector.DataGridNode.prototype.createCell):
Rework the padding calculation for indenting (as a child) to use "right" in RTL.

(WebInspector.DataGridNode.prototype.isEventWithinDisclosureTriangle):
Calculate the position of the ::before triangle based on the layout direction.

(WebInspector.DataGridNode.prototype.get leftPadding): Deleted.

12:07 PM Changeset in webkit [213924] by webkit@devinrousso.com

• 2 edits in trunk/Source/WebInspectorUI

Web Inspector: RTL: add support for TimelineOverview sidebar and container layout
​https://bugs.webkit.org/show_bug.cgi?id=169583

Reviewed by Brian Burg.

• UserInterface/Views/TimelineOverview.css:

(body[dir=ltr] .timeline-overview > :matches(.navigation-bar.timelines, .tree-outline.timelines)):
(body[dir=rtl] .timeline-overview > :matches(.navigation-bar.timelines, .tree-outline.timelines)):
(body[dir=ltr] .timeline-overview:not(.frames) > :matches(.scroll-container, .timeline-ruler, .graphs-container)):
(body[dir=rtl] .timeline-overview:not(.frames) > :matches(.scroll-container, .timeline-ruler, .graphs-container)):
(.timeline-overview > .navigation-bar.timelines):
(.timeline-overview > .tree-outline.timelines):
(.timeline-overview > .scroll-container):
(.timeline-overview > .timeline-ruler):
(.timeline-overview > .graphs-container):
(.timeline-overview > .scroll-container > .scroll-width-sizer):
(body[dir=ltr] .timeline-overview > .scroll-container > .scroll-width-sizer):
(body[dir=rtl] .timeline-overview > .scroll-container > .scroll-width-sizer):
(.timeline-overview.frames > .graphs-container): Deleted.

11:53 AM Changeset in webkit [213923] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebCore

Remove redundant check for "firstLine" in RenderBlock::lineHeight()
​https://bugs.webkit.org/show_bug.cgi?id=169610

Patch by Adrian Perez de Castro <Adrian Perez de Castro> on 2017-03-14
Reviewed by Michael Catanzaro.

• rendering/RenderBlock.cpp:

(WebCore::RenderBlock::lineHeight): Remove test of "firstLine" that
was already checked in the condition for the enclosing if-clause.

11:36 AM Changeset in webkit [213922] by jmarcell@apple.com

• 1 copy in tags/Safari-604.1.12

Tag Safari-604.1.12.

11:35 AM Changeset in webkit [213921] by jmarcell@apple.com

• 7 edits in trunk/Source

Versioning.

11:29 AM Changeset in webkit [213920] by commit-queue@webkit.org

• 10 edits
  3 adds in trunk

[Modern Media Controls] Fullscreen controls during Live Broadcast is completely broken
​https://bugs.webkit.org/show_bug.cgi?id=169354
<rdar://problem/30636370>

Patch by Antoine Quint <Antoine Quint> on 2017-03-14
Reviewed by Dean Jackson.

Source/WebCore:

When playing a Live Broadcast video in fullscreen, we should not show any scrubbing-related
piece of UI and ensure that we show the status label.

Test: http/tests/media/modern-media-controls/macos-fullscreen-media-controls/macos-fullscreen-media-controls-live-broadcast.html

• Modules/modern-media-controls/controls/macos-fullscreen-media-controls.css:

(.media-controls.mac.fullscreen > .controls-bar .status-label):

• Modules/modern-media-controls/controls/macos-fullscreen-media-controls.js:

(MacOSFullscreenMediaControls.prototype.layout):

• Modules/modern-media-controls/media/seek-support.js:

(SeekSupport.prototype.get mediaEvents):
(SeekSupport.prototype.syncControl):

LayoutTests:

Add a new test, skipped on iOS, to check scrubbing controls are disabled in fullscreen
for a Live Broadcast video and that the status label is visible. We also rebaseline a
couple of tests now that the time control is added on first layout instead of inside
the constructor.

• http/tests/media/modern-media-controls/macos-fullscreen-media-controls/macos-fullscreen-media-controls-live-broadcast-expected.txt: Added.
• http/tests/media/modern-media-controls/macos-fullscreen-media-controls/macos-fullscreen-media-controls-live-broadcast.html: Added.
• media/modern-media-controls/macos-fullscreen-media-controls/macos-fullscreen-media-controls-constructor-expected.txt:
• media/modern-media-controls/macos-fullscreen-media-controls/macos-fullscreen-media-controls-constructor.html:
• media/modern-media-controls/macos-fullscreen-media-controls/macos-fullscreen-media-controls-time-control-styles-expected.txt:
• media/modern-media-controls/macos-fullscreen-media-controls/macos-fullscreen-media-controls-time-control-styles.html:
• platform/ios-simulator/TestExpectations:

11:24 AM Changeset in webkit [213919] by Ryan Haddad

• 2 edits in trunk/LayoutTests

Skip 12 web-platform-tests until wptserver is upgraded.
​https://bugs.webkit.org/show_bug.cgi?id=169615

Unreviewed test gardening.

• TestExpectations:

11:22 AM Changeset in webkit [213918] by commit-queue@webkit.org

• 2 edits in trunk/Tools

Nwtr ignores ImageDiff's errors for ref tests
​https://bugs.webkit.org/show_bug.cgi?id=168033

Patch by Fujii Hironori <Fujii Hironori> on 2017-03-14
Reviewed by Alexey Proskuryakov.

Nwtr checks ImageDiff's errors only for pixel tests, but for ref
tests. Those errors of ref tests also should be checked.

In the current implementation of expected mismatch ref tests,
diff_image was called if the image hashes match. This is useless
because two images are ensured identical in that case. Calling
image_hash is considered unnecessary for expected mismatch ref
tests. Do not call diff_image for them.

As the result, check the error only for expected match ref tests.

• Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:

(SingleTestRunner._compare_image): Rename a variable 'err_str' to 'error_string'.
(SingleTestRunner._compare_output_with_reference): Do not call
diff_image for expected mismatch ref tests. Check the error and
marked the test failed for expected match ref tests.

11:19 AM Changeset in webkit [213917] by commit-queue@webkit.org

• 13 edits in trunk/Source

Web Inspector: More accurate Resource Timing data in Web Inspector
​https://bugs.webkit.org/show_bug.cgi?id=169577

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2017-03-14
Reviewed by Youenn Fablet.

Source/WebCore:

• inspector/InspectorNetworkAgent.h:
• inspector/InspectorNetworkAgent.cpp:

(WebCore::InspectorNetworkAgent::didFinishLoading):
Use the ResourceLoader to get the start time that responseEnd is relative to
so we can send the more accurate responseEnd when available.

• inspector/InspectorInstrumentation.cpp:

(WebCore::InspectorInstrumentation::didFinishLoadingImpl):

• inspector/InspectorInstrumentation.h:

(WebCore::InspectorInstrumentation::didFinishLoading):

• loader/CrossOriginPreflightChecker.cpp:

(WebCore::CrossOriginPreflightChecker::validatePreflightResponse):

• loader/DocumentLoader.cpp:

(WebCore::DocumentLoader::finishedLoading):

• loader/ResourceLoadNotifier.cpp:

(WebCore::ResourceLoadNotifier::didFinishLoad):
(WebCore::ResourceLoadNotifier::dispatchDidFinishLoading):
(WebCore::ResourceLoadNotifier::sendRemainingDelegateMessages):

• loader/ResourceLoadNotifier.h:
• loader/appcache/ApplicationCacheGroup.cpp:

(WebCore::ApplicationCacheGroup::didFinishLoading):
Pass ResourceLoader through to Web Inspector in didFinishLoading.

• platform/network/cocoa/NetworkLoadMetrics.mm:

(WebCore::copyTimingData):
The differences from the reference start are in Seconds, not milliseconds.

Source/WebInspectorUI:

• UserInterface/Models/ResourceTimingData.js:

(WebInspector.ResourceTimingData.prototype.get requestStart):
(WebInspector.ResourceTimingData.prototype.get responseStart):
Fallback to the startTime if available instead of using the
inaccurate WebContentProcess gathered timestamps.

(WebInspector.ResourceTimingData.prototype.markResponseEndTime):
Verify responseEnd compared to other times we may have.

10:58 AM Changeset in webkit [213916] by beidson@apple.com

• 4 edits in trunk

REGRESSION (r213877): WebKit2.CookieManager fails.
​https://bugs.webkit.org/show_bug.cgi?id=169581

Reviewed by Tim Horton.

Source/WebKit2:

• UIProcess/WebCookieManagerProxy.cpp:

(WebKit::WebCookieManagerProxy::processPoolDestroyed): Invalidate the new sets of callbacks.
(WebKit::WebCookieManagerProxy::processDidClose): Ditto.

Tools:

• TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Reenable the test.

10:39 AM Changeset in webkit [213915] by tpopela@redhat.com

• 6 edits in trunk/Source/WebKit2

Fix uninitialized public members in NetworkProcess
​https://bugs.webkit.org/show_bug.cgi?id=169598

Reviewed by Alex Christensen.

• NetworkProcess/NetworkProcess.cpp:

(WebKit::NetworkProcess::NetworkProcess):

• NetworkProcess/NetworkProcessCreationParameters.h:
• NetworkProcess/cache/NetworkCacheStorage.cpp:
• UIProcess/WebProcessPool.cpp:

(WebKit::WebProcessPool::WebProcessPool):

• UIProcess/soup/WebProcessPoolSoup.cpp:

(WebKit::WebProcessPool::platformInitializeNetworkProcess):

10:30 AM Changeset in webkit [213914] by commit-queue@webkit.org

• 6 edits
  53 adds in trunk/LayoutTests

Import web-platform-tests/cors
​https://bugs.webkit.org/show_bug.cgi?id=169565

Patch by Youenn Fablet <​youenn@apple.com> on 2017-03-14
Reviewed by Sam Weinig.

LayoutTests/imported/w3c:

• resources/import-expectations.json:
• web-platform-tests/cors/304-expected.txt: Added.
• web-platform-tests/cors/304.htm: Added.
• web-platform-tests/cors/OWNERS: Added.
• web-platform-tests/cors/README.md: Added.
• web-platform-tests/cors/allow-headers-expected.txt: Added.
• web-platform-tests/cors/allow-headers.htm: Added.
• web-platform-tests/cors/basic-expected.txt: Added.
• web-platform-tests/cors/basic.htm: Added.
• web-platform-tests/cors/credentials-flag-expected.txt: Added.
• web-platform-tests/cors/credentials-flag.htm: Added.
• web-platform-tests/cors/late-upload-events-expected.txt: Added.
• web-platform-tests/cors/late-upload-events.htm: Added.
• web-platform-tests/cors/origin-expected.txt: Added.
• web-platform-tests/cors/origin.htm: Added.
• web-platform-tests/cors/preflight-cache-expected.txt: Added.
• web-platform-tests/cors/preflight-cache.htm: Added.
• web-platform-tests/cors/preflight-failure-expected.txt: Added.
• web-platform-tests/cors/preflight-failure.htm: Added.
• web-platform-tests/cors/redirect-origin-expected.txt: Added.
• web-platform-tests/cors/redirect-origin.htm: Added.
• web-platform-tests/cors/redirect-preflight-2-expected.txt: Added.
• web-platform-tests/cors/redirect-preflight-2.htm: Added.
• web-platform-tests/cors/redirect-preflight-expected.txt: Added.
• web-platform-tests/cors/redirect-preflight.htm: Added.
• web-platform-tests/cors/redirect-userinfo-expected.txt: Added.
• web-platform-tests/cors/redirect-userinfo.htm: Added.
• web-platform-tests/cors/remote-origin-expected.txt: Added.
• web-platform-tests/cors/remote-origin.htm: Added.
• web-platform-tests/cors/request-headers-expected.txt: Added.
• web-platform-tests/cors/request-headers.htm: Added.
• web-platform-tests/cors/resources/304.py: Added.

(error):
(main):

• web-platform-tests/cors/resources/checkandremove.py: Added.

(main):

• web-platform-tests/cors/resources/cors-cookie.py: Added.

(main):

• web-platform-tests/cors/resources/cors-headers.asis: Added.
• web-platform-tests/cors/resources/cors-makeheader.py: Added.

(main):

• web-platform-tests/cors/resources/preflight.py: Added.

(main):

• web-platform-tests/cors/resources/remote-xhrer.html: Added.
• web-platform-tests/cors/resources/status.py: Added.

(main):

• web-platform-tests/cors/resources/w3c-import.log: Added.
• web-platform-tests/cors/response-headers-expected.txt: Added.
• web-platform-tests/cors/response-headers.htm: Added.
• web-platform-tests/cors/simple-requests-expected.txt: Added.
• web-platform-tests/cors/simple-requests.htm: Added.
• web-platform-tests/cors/status-async-expected.txt: Added.
• web-platform-tests/cors/status-async.htm: Added.
• web-platform-tests/cors/status-expected.txt: Added.
• web-platform-tests/cors/status-preflight-expected.txt: Added.
• web-platform-tests/cors/status-preflight.htm: Added.
• web-platform-tests/cors/status.htm: Added.
• web-platform-tests/cors/support.js: Added.

(dirname):

• web-platform-tests/cors/w3c-import.log: Added.

LayoutTests:

• tests-options.json:

10:21 AM Changeset in webkit [213913] by adachan@apple.com

• 2 edits
  2 adds in trunk/Source/WebKit2

[Mac] Add API to get the NSURLProtectionSpace from WKProtectionSpaceRef
​https://bugs.webkit.org/show_bug.cgi?id=169494
<rdar://problem/11872163>

Reviewed by Dan Bernstein.

• UIProcess/API/C/mac/WKProtectionSpaceNS.h: Added.
• UIProcess/API/C/mac/WKProtectionSpaceNS.mm: Added.

(WKProtectionSpaceCopyNSURLProtectionSpace):

• WebKit2.xcodeproj/project.pbxproj:

10:13 AM Changeset in webkit [213912] by matthew_hanson@apple.com

• 4 edits in branches/safari-603-branch/Source/WebCore

Roll out r212554 via r212893. rdar://problem/30812551

10:13 AM Changeset in webkit [213911] by matthew_hanson@apple.com

• 2 edits in branches/safari-603-branch/Source/JavaScriptCore

rdar://problem/30675867

10:13 AM Changeset in webkit [213910] by matthew_hanson@apple.com

• 2 edits in branches/safari-603-branch/Source/WebCore

rdar://problem/30657889

10:13 AM Changeset in webkit [213909] by matthew_hanson@apple.com

• 3 edits in branches/safari-603-branch/Source/WebCore

Merge r213211. rdar://problem/30742143

10:13 AM Changeset in webkit [213908] by matthew_hanson@apple.com

• 2 edits in branches/safari-603-branch/Source/WebCore

Merge r212822. rdar://problem/30682429

10:13 AM Changeset in webkit [213907] by matthew_hanson@apple.com

• 19 edits in branches/safari-603-branch

Roll out r212459 via r212537. rdar://problem/30699480

10:13 AM Changeset in webkit [213906] by matthew_hanson@apple.com

• 1 edit in branches/safari-603-branch/Source/WebCore/ChangeLog

Merge r212828. rdar://problem/30636288

10:13 AM Changeset in webkit [213905] by matthew_hanson@apple.com

• 2 edits in branches/safari-603-branch/Source

Merge r212692. rdar://problem/30635854

10:02 AM Changeset in webkit [213904] by mark.lam@apple.com

• 2 edits in trunk/Source/JavaScriptCore

Gardening: Speculative build fix for CLoop after r213886.
​https://bugs.webkit.org/show_bug.cgi?id=169436

Not reviewed.

• runtime/MachineContext.h:

10:01 AM Changeset in webkit [213903] by Wenson Hsieh

• 6 edits in trunk/Source/WebKit2

[WK2] Adopt updated data operation interfaces for data interaction
​https://bugs.webkit.org/show_bug.cgi?id=169414
<rdar://problem/30948186>

Reviewed by Tim Horton.

Plumb additional information about the data interaction caret over to the UI process after handling a data
interaction action in the web process.

• UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::didPerformDragControllerAction):
(WebKit::WebPageProxy::resetCurrentDragInformation):

• UIProcess/WebPageProxy.h:

(WebKit::WebPageProxy::currentDragCaretRect):
(WebKit::WebPageProxy::resetCurrentDragInformation): Deleted.

• UIProcess/WebPageProxy.messages.in:
• UIProcess/ios/WKContentViewInteraction.h:
• WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::performDragControllerAction):

10:01 AM Changeset in webkit [213902] by Wenson Hsieh

• 21 edits in trunk

[WK2] Data interaction tests occasionally hit assertions in debug builds
​https://bugs.webkit.org/show_bug.cgi?id=169002
<rdar://problem/30994806>

Reviewed by Tim Horton.

Source/WebCore:

Data interaction unit tests occasionally fail due to the UI process expecting the latest received EditorState to
contain post layout data, but finding that it does not in -[WKContentView selectedTextRange]. The incomplete
EditorStates in question are sent while performing a data interaction operation, due to transient changes in the
frame selection. The UI process does not need to (and should not) be informed of these selection changes at all.

We can fix this by preventing the editor client from responding to selection changes during data interaction
operation. This patch also renames setIgnoreCompositionSelectionChange to setIgnoreSelectionChanges to better
reflect the fact that it is used outside of the context of holding selection change updates during IME. We
already use this affordance in various places, such as TextIndicator (while taking a snapshot on iOS), in
FindController on iOS, and when replacing selected or dictated text. Additionally, there is no logic in
setIgnoreCompositionSelectionChange that limits its use to composition.

• editing/Editor.cpp:

(WebCore::Editor::cancelCompositionIfSelectionIsInvalid):
(WebCore::Editor::setComposition):
(WebCore::Editor::revealSelectionAfterEditingOperation):
(WebCore::Editor::setIgnoreSelectionChanges):
(WebCore::Editor::changeSelectionAfterCommand):
(WebCore::Editor::respondToChangedSelection):
(WebCore::Editor::setIgnoreCompositionSelectionChange): Deleted.

• editing/Editor.h:

(WebCore::Editor::ignoreSelectionChanges):
(WebCore::Editor::ignoreCompositionSelectionChange): Deleted.

• editing/mac/EditorMac.mm:

(WebCore::Editor::selectionWillChange):

• page/TextIndicator.cpp:

(WebCore::TextIndicator::createWithRange):

Source/WebKit/mac:

Renames setIgnoreCompositionSelectionChange to setIgnoreSelectionChanges. See WebCore ChangeLog for more details.

• WebView/WebHTMLView.mm:

(-[WebHTMLView _updateSelectionForInputManager]):

• WebView/WebView.mm:

(-[WebView updateTextTouchBar]):

Source/WebKit2:

Renames setIgnoreCompositionSelectionChange to setIgnoreSelectionChanges. See WebCore ChangeLog for more details.

• Shared/EditorState.cpp:

(WebKit::EditorState::encode):
(WebKit::EditorState::decode):

• Shared/EditorState.h:
• UIProcess/gtk/WebPageProxyGtk.cpp:
• UIProcess/ios/WebPageProxyIOS.mm:

(WebKit::WebPageProxy::editorStateChanged):

• UIProcess/mac/WebPageProxyMac.mm:

(WebKit::WebPageProxy::editorStateChanged):

• WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::editorState):
(WebKit::WebPage::performDragControllerAction):
(WebKit::WebPage::setComposition):
(WebKit::WebPage::didChangeSelection):

• WebProcess/WebPage/ios/FindControllerIOS.mm:

(WebKit::setSelectionChangeUpdatesEnabledInAllFrames):
(WebKit::FindController::willFindString):
(WebKit::FindController::didFailToFindString):
(WebKit::FindController::didHideFindIndicator):
(WebKit::setCompositionSelectionChangeEnabledInAllFrames): Deleted.

• WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::updateSelectionAppearance):
(WebKit::WebPage::replaceSelectedText):
(WebKit::WebPage::replaceDictatedText):

Tools:

Reenables and refactors data interaction tests.

• TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
• TestWebKitAPI/ios/DataInteractionSimulator.h:
• TestWebKitAPI/ios/DataInteractionSimulator.mm:

(-[DataInteractionSimulator _resetSimulatedState]):
(-[DataInteractionSimulator runFrom:to:]):
(-[DataInteractionSimulator _advanceProgress]):

9:59 AM Changeset in webkit [213901] by Yusuke Suzuki

• 3 edits in trunk/Source/JavaScriptCore

[JSC] Drop unnecessary pthread_attr_t for JIT enabled Linux / FreeBSD environment
​https://bugs.webkit.org/show_bug.cgi?id=169592

Reviewed by Carlos Garcia Campos.

Since suspended mcontext_t has all the necessary information, we can drop
pthread_attr_t allocation and destroy for JIT enabled Linux / FreeBSD environment.

• heap/MachineStackMarker.cpp:

(JSC::MachineThreads::Thread::getRegisters):
(JSC::MachineThreads::Thread::Registers::stackPointer):
(JSC::MachineThreads::Thread::Registers::framePointer):
(JSC::MachineThreads::Thread::Registers::instructionPointer):
(JSC::MachineThreads::Thread::Registers::llintPC):
(JSC::MachineThreads::Thread::freeRegisters):

• heap/MachineStackMarker.h:

9:16 AM Changeset in webkit [213900] by commit-queue@webkit.org

• 5 edits in trunk

[Modern Media Controls] iOS may attempt to load fullscreen icon variants
​https://bugs.webkit.org/show_bug.cgi?id=169608
<rdar://problem/31037369>

Patch by Antoine Quint <Antoine Quint> on 2017-03-14
Reviewed by Eric Carlson.

Source/WebCore:

Only return fullscreen or compact variants for macOS.

• Modules/modern-media-controls/controls/icon-service.js:

(const.iconService.new.IconService.prototype._fileNameAndPlatformForIconNameAndLayoutTraits):
(const.iconService.new.IconService):

LayoutTests:

Amend an existing test to check that we disregard fullscreen and compact variants on iOS.

• media/modern-media-controls/icon-service/icon-service-expected.txt:
• media/modern-media-controls/icon-service/icon-service.html:

9:13 AM Changeset in webkit [213899] by commit-queue@webkit.org

• 3 edits
  2 adds in trunk

[Modern Media Controls] Controls are laid out incorrectly with RTL languages
​https://bugs.webkit.org/show_bug.cgi?id=169605
<rdar://problem/30975709>

Patch by Antoine Quint <Antoine Quint> on 2017-03-14
Reviewed by Eric Carlson.

Source/WebCore:

Encorce "direction: ltr" on the controls since the controls layout should not be changed
by the host page's direction.

Test: media/modern-media-controls/media-controls/media-controls-controls-bar-always-ltr.html

• Modules/modern-media-controls/controls/controls-bar.css:

(.controls-bar):

LayoutTests:

Add a test that enforces "direction: rtl" on a parent element to check that the controls
bar use "direction: ltr" anyway.

• media/modern-media-controls/media-controls/media-controls-controls-bar-always-ltr-expected.txt: Added.
• media/modern-media-controls/media-controls/media-controls-controls-bar-always-ltr.html: Added.

8:52 AM Changeset in webkit [213898] by beidson@apple.com

• 2 edits in trunk/Tools

REGRESSION (r213877): WebKit2.CookieManager fails.
​https://bugs.webkit.org/show_bug.cgi?id=169581

Unreviewed gardening

• TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Skip for now until I can fix.

8:11 AM Changeset in webkit [213897] by Wenson Hsieh

• 7 edits
  3 adds in trunk

Make RepaintRegionAccumulator hold a WeakPtr to its root RenderView
​https://bugs.webkit.org/show_bug.cgi?id=168480
<rdar://problem/30566976>

Reviewed by Antti Koivisto.

Source/WebCore:

Implements two mitigations to prevent the symptoms of the bug from occurring (see the bugzilla for more details).

Test: editing/execCommand/show-modal-dialog-during-execCommand.html

• editing/EditorCommand.cpp:

(WebCore::Editor::Command::execute):

Do not allow edit commands to execute if the frame's document before and after layout differ (that is, edit commands
triggered by a certain document should not run on a different document).

• rendering/RenderView.cpp:

(WebCore::RenderView::RenderView):
(WebCore::RenderView::RepaintRegionAccumulator::RepaintRegionAccumulator):

Turns RepaintRegionAccumulator's reference to its root RenderView into a WeakPtr to gracefully handle the case
where its RenderView is destroyed before RepaintRegionAccumulator's destructor gets a chance to flush the
RenderView's repaint regions.

• rendering/RenderView.h:

LayoutTests:

Introduces a new layout test. See WebCore ChangeLog for more details.

• TestExpectations:
• editing/execCommand/show-modal-dialog-during-execCommand-expected.txt: Added.
• editing/execCommand/show-modal-dialog-during-execCommand.html: Added.
• editing/execCommand/resources/self-closing-modal-dialog.html: Added.
• platform/mac-wk1/TestExpectations:

6:20 AM Changeset in webkit [213896] by Yusuke Suzuki

• 7 edits in trunk

Source/WTF:
Add secondsAs<T> methods to Seconds to convert it to integers with clamp
​https://bugs.webkit.org/show_bug.cgi?id=169537

Reviewed by Carlos Garcia Campos.

When using the usual static_cast, infinity becomes 0 accidentally.
It is not intended value when using Seconds for timeout value.
Instead, we use clampToAccepting64 to convert Seconds to
integer values to pass them to the system functions.

• wtf/MathExtras.h:

(clampToAccepting64):

• wtf/Seconds.h:

(WTF::Seconds::minutesAs):
(WTF::Seconds::secondsAs):
(WTF::Seconds::millisecondsAs):
(WTF::Seconds::microsecondsAs):
(WTF::Seconds::nanosecondsAs):

• wtf/cocoa/WorkQueueCocoa.cpp:

(WTF::WorkQueue::dispatchAfter):

• wtf/glib/RunLoopGLib.cpp:

(WTF::RunLoop::dispatchAfter):
(WTF::RunLoop::TimerBase::updateReadyTime):

Tools:
[WTF] Clean up RunLoop and WorkQueue with Seconds and Function
​https://bugs.webkit.org/show_bug.cgi?id=169537

Reviewed by Carlos Garcia Campos.

• TestWebKitAPI/Tests/WTF/Time.cpp:

(TestWebKitAPI::TEST):

2:01 AM Changeset in webkit [213895] by Carlos Garcia Campos

• 1 copy in releases/WebKitGTK/webkit-2.15.92

WebKitGTK+ 2.15.92

2:01 AM Changeset in webkit [213894] by Carlos Garcia Campos

• 4 edits in releases/WebKitGTK/webkit-2.16

Unreviewed. Update OptionsGTK.cmake and NEWS for 2.15.92 release.

.:

• Source/cmake/OptionsGTK.cmake: Bump version numbers.

Source/WebKit2:

• gtk/NEWS: Add release notes for 2.15.92.

1:30 AM Changeset in webkit [213893] by zandobersek@gmail.com

• 3 edits in trunk/Source/WebCore

[GLib] Use USE(GLIB) guards in WebCore/workers/
​https://bugs.webkit.org/show_bug.cgi?id=169595

Reviewed by Carlos Garcia Campos.

Utilize the USE(GLIB) build guards in the WorkerRunLoop and WorkerThread
class implementations to guard GLib-specific header inclusions and GLib
API invocations, instead of the more specific PLATFORM(GTK) guards.

• workers/WorkerRunLoop.cpp:

(WebCore::WorkerRunLoop::runInMode):

• workers/WorkerThread.cpp:

(WebCore::WorkerThread::workerThread):

1:29 AM Changeset in webkit [213892] by zandobersek@gmail.com

• 2 edits in trunk/Source/JavaScriptCore

[GLib] Use USE(GLIB) guards in JavaScriptCore/inspector/EventLoop.cpp
​https://bugs.webkit.org/show_bug.cgi?id=169594

Reviewed by Carlos Garcia Campos.

Instead of PLATFORM(GTK) guards, utilize the USE(GLIB) build guards
to guard the GLib-specific includes and invocations in the JSC
inspector's EventLoop class implementation.

• inspector/EventLoop.cpp:

(Inspector::EventLoop::cycle):

1:28 AM Changeset in webkit [213891] by zandobersek@gmail.com

• 2 edits in trunk/Source/WebCore

[Soup] Suppress compiler warnings in NetworkStorageSession
​https://bugs.webkit.org/show_bug.cgi?id=169593

Reviewed by Carlos Garcia Campos.

Return default-constructed Vector objects in the NetworkStorageSession's
getAllCookies() and getCookies() methods, avoiding compiler warnings.

• platform/network/soup/NetworkStorageSessionSoup.cpp:

(WebCore::NetworkStorageSession::getAllCookies):
(WebCore::NetworkStorageSession::getCookies):

1:28 AM Changeset in webkit [213890] by webkit@devinrousso.com

• 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Remove unnecessary assert for Number.percentageString
​https://bugs.webkit.org/show_bug.cgi?id=169589

Reviewed by Matt Baker.

• UserInterface/Base/Utilities.js:

(Number.percentageString):

1:22 AM Changeset in webkit [213889] by Carlos Garcia Campos

• 2 edits in releases/WebKitGTK/webkit-2.16/Source/WebKit2

Merge r213888 - Unreviewed. Fix syntax error in GTK+ API docs.

• UIProcess/API/gtk/WebKitWebView.cpp:

(webkit_web_view_class_init):

1:21 AM Changeset in webkit [213888] by Carlos Garcia Campos

• 2 edits in trunk/Source/WebKit2

Unreviewed. Fix syntax error in GTK+ API docs.

• UIProcess/API/gtk/WebKitWebView.cpp:

(webkit_web_view_class_init):

12:57 AM Changeset in webkit [213887] by webkit@devinrousso.com

• 2 edits in trunk/Source/WebInspectorUI

Web Inspector: allow the user to copy locked CSS selectors in Style - Rules
​https://bugs.webkit.org/show_bug.cgi?id=169587

Reviewed by Matt Baker.

• UserInterface/Views/CSSStyleDeclarationSection.css:

(.style-declaration-section:matches(.locked, .selector-locked) > .header > .selector):

12:33 AM Changeset in webkit [213886] by Yusuke Suzuki

• 12 edits
  1 add in trunk/Source

[JSC][Linux] Implement VMTrap in Linux ports
​https://bugs.webkit.org/show_bug.cgi?id=169436

Reviewed by Mark Lam.

Source/JavaScriptCore:

This patch port VMTrap to Linux ports.
We extract MachineContext accessors from various places (wasm/, heap/ and tools/)
and use them in all the JSC code.

• JavaScriptCore.xcodeproj/project.pbxproj:
• heap/MachineStackMarker.cpp:

(JSC::MachineThreads::Thread::Registers::stackPointer):
(JSC::MachineThreads::Thread::Registers::framePointer):
(JSC::MachineThreads::Thread::Registers::instructionPointer):
(JSC::MachineThreads::Thread::Registers::llintPC):

• heap/MachineStackMarker.h:
• runtime/MachineContext.h: Added.

(JSC::MachineContext::stackPointer):
(JSC::MachineContext::framePointer):
(JSC::MachineContext::instructionPointer):
(JSC::MachineContext::argumentPointer<1>):
(JSC::MachineContext::argumentPointer):
(JSC::MachineContext::llintInstructionPointer):

• runtime/PlatformThread.h:

(JSC::platformThreadSignal):

• runtime/VMTraps.cpp:

(JSC::SignalContext::SignalContext):
(JSC::SignalContext::adjustPCToPointToTrappingInstruction):

• tools/CodeProfiling.cpp:

(JSC::profilingTimer):

• tools/SigillCrashAnalyzer.cpp:

(JSC::SignalContext::SignalContext):
(JSC::SignalContext::dump):

• tools/VMInspector.cpp:
• wasm/WasmFaultSignalHandler.cpp:

(JSC::Wasm::trapHandler):

Source/WTF:

Enable VMTrap mechanism for Linux and FreeBSD.

• wtf/Platform.h: