⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Mar 16, 2017:

10:29 PM Changeset in webkit [214099] by webkit@devinrousso.com
  • 2 edits in trunk/Source/WebInspectorUI

Web Inspector: memory category timelines would look better with ruler tick-aligned guides
​https://bugs.webkit.org/show_bug.cgi?id=158100

Reviewed by Joseph Pecoraro.

  • UserInterface/Views/MemoryTimelineView.css:

(.timeline-view.memory > .content > .details):
(.timeline-view.memory > .content > .details > .timeline-ruler):
(body[dir=ltr] .timeline-view.memory > .content > .details > .timeline-ruler):
(body[dir=rtl] .timeline-view.memory > .content > .details > .timeline-ruler):
Make the TimelineRuler absolutely positioned so it can use the full height of the view,
providing enough space for the markers to be visible.

10:14 PM Changeset in webkit [214098] by Ryan Haddad
  • 2 edits in trunk/LayoutTests

Mark imported/w3c/web-platform-tests/html/browsers/history/the-location-interface/location_hash.html as flaky.
​https://bugs.webkit.org/show_bug.cgi?id=169572

Unreviewed test gardening.

  • platform/mac/TestExpectations:
9:49 PM Changeset in webkit [214097] by Ryan Haddad
  • 4 edits in trunk/LayoutTests

Rebaseline js/dom/global-constructors-attributes.html.

Unreviewed test gardening.

  • platform/mac-elcapitan/js/dom/global-constructors-attributes-expected.txt:
  • platform/mac-wk1/js/dom/global-constructors-attributes-expected.txt:
  • platform/mac/js/dom/global-constructors-attributes-expected.txt:
9:33 PM Changeset in webkit [214096] by Ryan Haddad
  • 3 edits in branches/safari-603.1.30.0-branch/LayoutTests

Merge r213174.

9:33 PM Changeset in webkit [214095] by Ryan Haddad
  • 2 edits in branches/safari-603.1.30.0-branch/LayoutTests

Merge r212132.

9:33 PM Changeset in webkit [214094] by Ryan Haddad
  • 1 edit
    3 adds in branches/safari-603.1.30.0-branch/LayoutTests

Add baseline for fast/canvas/webgl/context-creation-attributes.html.
Unreviewed test gardening.

  • platform/mac-wk1/fast/canvas/webgl/context-creation-attributes-expected.txt: Added.
7:14 PM Changeset in webkit [214093] by webkit@devinrousso.com
  • 4 edits in trunk/Source/WebInspectorUI

Web Inspector: Console Evaluation links in the Console should not show normally
​https://bugs.webkit.org/show_bug.cgi?id=157483

Reviewed by Matt Baker.

  • UserInterface/Models/CallFrame.js:

(WebInspector.CallFrame):
(WebInspector.CallFrame.prototype.get isConsoleEvaluation):
(WebInspector.CallFrame.fromDebuggerPayload):
(WebInspector.CallFrame.fromPayload):
Move console evaluation check to the constructor for consistency.

  • UserInterface/Views/ConsoleMessageView.js:

(WebInspector.ConsoleMessageView.prototype._appendLocationLink):

  • UserInterface/Views/StackTraceView.js:

(WebInspector.StackTraceView):
Only add CallFrameView elements if the corresponding CallFame is not a console evaluation.

7:07 PM Changeset in webkit [214092] by achristensen@apple.com
  • 2 edits in trunk/Source/WebKit2

Fix GTK build.

  • UIProcess/InspectorServer/WebSocketServerConnection.h:
6:56 PM Changeset in webkit [214091] by achristensen@apple.com
  • 3 edits in trunk/Source/WebKit2

Fix GTK build.

  • UIProcess/InspectorServer/WebSocketServerConnection.cpp:

(WebKit::WebSocketServerConnection::didReceiveSocketStreamData):

  • UIProcess/InspectorServer/WebSocketServerConnection.h:
6:43 PM Changeset in webkit [214090] by achristensen@apple.com
  • 2 edits in trunk/Source/WebCore

Fix GTK build.

  • platform/network/soup/SocketStreamHandleImplSoup.cpp:

(WebCore::SocketStreamHandleImpl::readBytes):
Changing RefPtr to Ref broke something.
For the record, EWS was orange so I couldn't see these build failures.

6:37 PM Changeset in webkit [214089] by msaboff@apple.com
  • 2 edits in trunk/Source/WebKit2

Turn off JavaScript Configuration File processing for Debug builds
​https://bugs.webkit.org/show_bug.cgi?id=169799

Reviewed by Dean Jackson.

Change the default value for m_javaScriptConfigurationFileEnabled for Debug
builds to be the same as a Release build, that is false (off).

  • UIProcess/WebProcessPool.h:
6:23 PM Changeset in webkit [214088] by achristensen@apple.com
  • 2 edits in trunk/Source/WebCore

Fix GTK build.

  • platform/network/soup/SocketStreamHandleImplSoup.cpp:

(WebCore::SocketStreamHandleImpl::readBytes):
didFailToReceiveSocketStreamData needs a parameter.

5:51 PM Changeset in webkit [214087] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

activating webrtc tests on Release bots
​https://bugs.webkit.org/show_bug.cgi?id=169775

Unreviewed.

Patch by Youenn Fablet <​youenn@apple.com> on 2017-03-16

5:51 PM Changeset in webkit [214086] by dino@apple.com
  • 7 edits
    2 adds in trunk

WebGL: Improve index validation when using uint index values
​https://bugs.webkit.org/show_bug.cgi?id=169798

Reviewed by Simon Fraser.

Source/WebCore:

Make sure that we test index validation with the correct type.
Also stop using -1 in WebGLBuffer to indicate non-existant values.

Test: fast/canvas/webgl/draw-elements-out-of-bounds-uint-index.html

  • html/canvas/WebGL2RenderingContext.cpp:

(WebCore::WebGL2RenderingContext::validateIndexArrayConservative): Use optional<> and
unsigned values.

  • html/canvas/WebGLBuffer.cpp: Use unsigned for maxIndex (they can't be negative)

and optional<> to indicate unknown value.
(WebCore::WebGLBuffer::getCachedMaxIndex):
(WebCore::WebGLBuffer::setCachedMaxIndex):

  • html/canvas/WebGLBuffer.h:
  • html/canvas/WebGLRenderingContext.cpp:

(WebCore::WebGLRenderingContext::validateIndexArrayConservative): Use optional<> and
unsigned values.

  • html/canvas/WebGLRenderingContextBase.cpp:

(WebCore::WebGLRenderingContextBase::validateVertexAttributes): No need to check if
an unsigned value is less than zero.

LayoutTests:

  • fast/canvas/webgl/draw-elements-out-of-bounds-uint-index-expected.txt: Added.
  • fast/canvas/webgl/draw-elements-out-of-bounds-uint-index.html: Added.
5:51 PM Changeset in webkit [214085] by mark.lam@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Fix exception scope verification failures in GenericArgumentsInlines.h.
​https://bugs.webkit.org/show_bug.cgi?id=165012

Reviewed by Saam Barati.

  • runtime/GenericArgumentsInlines.h:

(JSC::GenericArguments<Type>::defineOwnProperty):

5:47 PM Changeset in webkit [214084] by Simon Fraser
  • 23 edits in trunk

Improve the system tracing points
​https://bugs.webkit.org/show_bug.cgi?id=169790

Reviewed by Zalan Bujtas.

Use a more cohesive set of system trace points that give a good overview of what
WebKit is doing. Added points for resource loading, render tree building, sync messages
to the web process, async image decode, WASM and fetching cookies.

Source/JavaScriptCore:

  • wasm/WasmPlan.cpp:

(JSC::Wasm::Plan::run):

  • wasm/js/WebAssemblyFunction.cpp:

(JSC::callWebAssemblyFunction):

Source/WebCore:

  • loader/CookieJar.cpp:

(WebCore::cookies):

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::provisionalLoadStarted):
(WebCore::FrameLoader::checkLoadCompleteForThisFrame):

  • loader/SubresourceLoader.cpp:

(WebCore::SubresourceLoader::willSendRequestInternal):
(WebCore::logResourceLoaded):
(WebCore::SubresourceLoader::didFinishLoading):
(WebCore::SubresourceLoader::didFail):
(WebCore::SubresourceLoader::didCancel):

  • page/FrameView.cpp:

(WebCore::FrameView::paintContents):

  • platform/graphics/ImageFrameCache.cpp:

(WebCore::ImageFrameCache::startAsyncDecodingQueue):

  • platform/graphics/ios/DisplayRefreshMonitorIOS.mm:

(WebCore::DisplayRefreshMonitorIOS::requestRefreshCallback):
(WebCore::DisplayRefreshMonitorIOS::displayLinkFired):

  • style/RenderTreeUpdater.cpp:

(WebCore::RenderTreeUpdater::commit):

Source/WebKit/mac:

  • WebView/WebHTMLView.mm:

(-[WebHTMLView drawRect:]):

Source/WebKit2:

  • UIProcess/ChildProcessProxy.h:

(WebKit::ChildProcessProxy::sendSync):

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::handleTouchEventSynchronously):

  • UIProcess/mac/RemoteLayerTreeDrawingAreaProxy.mm:

(WebKit::RemoteLayerTreeDrawingAreaProxy::commitLayerTree):
(WebKit::RemoteLayerTreeDrawingAreaProxy::didRefreshDisplay):

  • WebProcess/WebPage/mac/RemoteLayerTreeContext.mm:

(WebKit::RemoteLayerTreeContext::buildTransaction):

  • WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.mm:

(WebKit::RemoteLayerTreeDrawingArea::didUpdate):
(WebKit::RemoteLayerTreeDrawingArea::BackingStoreFlusher::flush):

Source/WTF:

  • wtf/SystemTracing.h:

Tools:

  • Tracing/SystemTracePoints.plist:
5:23 PM Changeset in webkit [214083] by Matt Baker
  • 2 edits in trunk/Source/WebInspectorUI

Web Inspector: REGRESSION (r213691): Saving DOM breakpoints broken after refactoring
​https://bugs.webkit.org/show_bug.cgi?id=169779

Reviewed by Joseph Pecoraro.

Use correct method: _saveBreakpoints -> _saveDOMBreakpoints.

  • UserInterface/Controllers/DOMDebuggerManager.js:

(WebInspector.DOMDebuggerManager.prototype.addDOMBreakpoint):
Remove check before saving to be consistent with similar code in
DebuggerManager and DOMDebuggerManager.

5:20 PM Changeset in webkit [214082] by Simon Fraser
  • 29 edits in trunk/Source/WebCore

RenderView::documentBeingDestroyed() needs a new name.
​https://bugs.webkit.org/show_bug.cgi?id=166727

Reviewed by Andreas Kling.

Now that we destroy the render tree for documents going into the page cache, RenderView::documentBeingDestroyed()
is misleadingly named. Rename it to renderTreeBeingDestroyed() and fix all callers.

  • page/FrameView.cpp:

(WebCore::FrameView::scheduleRelayoutOfSubtree):

  • page/scrolling/ScrollingCoordinator.cpp:

(WebCore::ScrollingCoordinator::absoluteEventTrackingRegionsForFrame):

  • rendering/CounterNode.cpp:

(WebCore::CounterNode::resetRenderers):

  • rendering/ImageQualityController.cpp:

(WebCore::ImageQualityController::highQualityRepaintTimerFired):

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::willBeDestroyed):
(WebCore::canMergeContiguousAnonymousBlocks):
(WebCore::RenderBlock::removeChild):

  • rendering/RenderBlockFlow.cpp:

(WebCore::RenderBlockFlow::willBeDestroyed):
(WebCore::RenderBlockFlow::removeChild):

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::removeFloatingOrPositionedChildFromBlockLists):
(WebCore::RenderBox::deleteLineBoxWrapper):

  • rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::willBeDestroyed):

  • rendering/RenderElement.cpp:

(WebCore::RenderElement::insertChildInternal):
(WebCore::RenderElement::removeChildInternal):
(WebCore::RenderElement::clearLayoutRootIfNeeded):
(WebCore::RenderElement::willBeDestroyed):

  • rendering/RenderImage.cpp:

(WebCore::RenderImage::imageChanged):
(WebCore::RenderImage::notifyFinished):

  • rendering/RenderInline.cpp:

(WebCore::RenderInline::willBeDestroyed):

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::removeChild):
(WebCore::RenderLayer::calculateClipRects):

  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::notifyFlushRequired):

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::layerWillBeRemoved):
(WebCore::RenderLayerCompositor::fixedRootBackgroundLayerChanged):

  • rendering/RenderLineBreak.cpp:

(WebCore::RenderLineBreak::deleteInlineBoxWrapper):

  • rendering/RenderNamedFlowFragment.cpp:

(WebCore::RenderNamedFlowFragment::attachRegion):

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::resetFlowThreadStateOnRemoval):
(WebCore::RenderObject::willBeDestroyed):
(WebCore::RenderObject::destroyAndCleanupAnonymousWrappers):

  • rendering/RenderObject.h:

(WebCore::RenderObject::renderTreeBeingDestroyed):
(WebCore::RenderObject::documentBeingDestroyed): Deleted.

  • rendering/RenderQuote.cpp:

(WebCore::RenderQuote::detachQuote):

  • rendering/RenderRegion.cpp:

(WebCore::RenderRegion::attachRegion):

  • rendering/RenderReplaced.cpp:

(WebCore::RenderReplaced::willBeDestroyed):

  • rendering/RenderRubyRun.cpp:

(WebCore::RenderRubyRun::removeChild):

  • rendering/RenderTable.h:

(WebCore::RenderTable::setNeedsSectionRecalc):

  • rendering/RenderText.cpp:

(WebCore::RenderText::removeAndDestroyTextBoxes):

  • rendering/RenderVideo.cpp:

(WebCore::RenderVideo::updatePlayer):

  • rendering/svg/RenderSVGResource.cpp:

(WebCore::RenderSVGResource::markForLayoutAndParentResourceInvalidation):

  • rendering/svg/RenderSVGResourceContainer.cpp:

(WebCore::RenderSVGResourceContainer::markClientForInvalidation):

  • rendering/svg/RenderSVGText.cpp:

(WebCore::RenderSVGText::subtreeChildWasAdded):
(WebCore::RenderSVGText::subtreeChildWillBeRemoved):
(WebCore::RenderSVGText::subtreeChildWasRemoved):
(WebCore::RenderSVGText::subtreeStyleDidChange):

5:11 PM Changeset in webkit [214081] by Ryan Haddad
  • 7 edits
    2 deletes in branches/safari-603.1.30.0-branch/LayoutTests

Unreviewed test gardening.

LayoutTests/imported/w3c:

  • web-platform-tests/html/browsers/origin/cross-origin-objects/cross-origin-objects-expected.txt:

LayoutTests:

  • TestExpectations:
  • compositing/canvas/accelerated-canvas-compositing-size-limit-expected.txt:
  • pageoverlay/overlay-remove-reinsert-view-expected.txt:
  • platform/mac-wk2/TestExpectations:
  • workers/sab/sent-from-worker-transfer-expected.txt: Removed.
  • workers/sab/sent-from-worker-transfer.html: Removed.
5:05 PM Changeset in webkit [214080] by commit-queue@webkit.org
  • 24 edits
    2 adds in trunk

Wrap legacy WebRTC API in runtime flag
​https://bugs.webkit.org/show_bug.cgi?id=169646

Patch by Youenn Fablet <​youenn@apple.com> on 2017-03-16
Reviewed by Alex Christensen.

Source/WebCore:

Test: webrtc/legacy-api.html

Adding a runtime flag for legacy API.
Making some WebIDL peer connection members runtime-enabled.
Adding a JS private getter on this flag so that overloaded operations behave as promise-based only if flag is turned off.

  • Modules/mediastream/RTCPeerConnection.idl:
  • Modules/mediastream/RTCPeerConnectionInternals.js:
  • bindings/js/JSDOMGlobalObject.cpp:

(WebCore::isWebRTCLegacyAPIEnabled):
(WebCore::JSDOMGlobalObject::addBuiltinGlobals):

  • bindings/js/WebCoreBuiltinNames.h:
  • page/RuntimeEnabledFeatures.h:

(WebCore::RuntimeEnabledFeatures::webRTCLegacyAPIEnabled):
(WebCore::RuntimeEnabledFeatures::setWebRTCLegacyAPIEnabled):

Source/WebKit/mac:

  • WebView/WebPreferenceKeysPrivate.h:
  • WebView/WebPreferences.mm:

(+[WebPreferences initialize]):
(-[WebPreferences webRTCLegacyAPIEnabled]):
(-[WebPreferences setWebRTCLegacyAPIEnabled:]):

  • WebView/WebPreferencesPrivate.h:
  • WebView/WebView.mm:

(-[WebView _preferencesChanged:]):

Source/WebKit2:

Adding preference to legacy API.

  • Shared/WebPreferencesDefinitions.h:
  • UIProcess/API/C/WKPreferences.cpp:

(WKPreferencesSetWebRTCLegacyAPIEnabled):
(WKPreferencesGetWebRTCLegacyAPIEnabled):

  • UIProcess/API/C/WKPreferencesRef.h:
  • WebProcess/InjectedBundle/InjectedBundle.cpp:

(WebKit::InjectedBundle::overrideBoolPreferenceForTestRunner):

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::updatePreferences):

Tools:

  • DumpRenderTree/mac/DumpRenderTree.mm:

(enableExperimentalFeatures):

  • WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
  • WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:

(WTR::InjectedBundle::beginTesting):

  • WebKitTestRunner/InjectedBundle/TestRunner.cpp:

(WTR::TestRunner::setWebRTCLegacyAPIEnabled):

  • WebKitTestRunner/InjectedBundle/TestRunner.h:

LayoutTests:

  • webrtc/legacy-api-expected.txt: Added.
  • webrtc/legacy-api.html: Added.
4:51 PM Changeset in webkit [214079] by mark.lam@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Array concat operation should check for length overflows.
​https://bugs.webkit.org/show_bug.cgi?id=169796
<rdar://problem/31095276>

Reviewed by Keith Miller.

  • runtime/ArrayPrototype.cpp:

(JSC::concatAppendOne):
(JSC::arrayProtoPrivateFuncConcatMemcpy):

4:30 PM Changeset in webkit [214078] by beidson@apple.com
  • 14 edits
    1 move in trunk

Update the WKHTTPCookieStore API to be simpler and add observers.
<rdar://problem/31096000> and ​https://bugs.webkit.org/show_bug.cgi?id=169776

Reviewed by Alex Christensen.
Source/WebKit2:

When reviewing the API internally we realized the NSHTTPCookieStorage model doesn't
necessarily fit perfectly, and that to handle partitioned cookies going forward we
need to be much simpler right now.

We also realized that we should implement the "cookie store changed" observer for
any clients that might be providing a cookie viewing API.

  • UIProcess/API/APIHTTPCookieStore.cpp:

(API::HTTPCookieStore::~HTTPCookieStore):
(API::HTTPCookieStore::deleteCookie):
(API::APIWebCookieManagerProxyObserver::APIWebCookieManagerProxyObserver):
(API::HTTPCookieStore::registerObserver):
(API::HTTPCookieStore::unregisterObserver):
(API::HTTPCookieStore::cookiesDidChange):
(API::HTTPCookieStore::cookieManagerDestroyed):
(API::HTTPCookieStore::registerForNewProcessPoolNotifications):
(API::HTTPCookieStore::unregisterForNewProcessPoolNotifications):
(API::HTTPCookieStore::setCookies): Deleted.
(API::HTTPCookieStore::removeCookiesSinceDate): Deleted.
(API::HTTPCookieStore::setHTTPCookieAcceptPolicy): Deleted.
(API::HTTPCookieStore::getHTTPCookieAcceptPolicy): Deleted.

  • UIProcess/API/APIHTTPCookieStore.h:
  • UIProcess/API/Cocoa/WKHTTPCookieStore.h:
  • UIProcess/API/Cocoa/WKHTTPCookieStore.mm:

(WKHTTPCookieStoreObserver::WKHTTPCookieStoreObserver):
(-[WKHTTPCookieStore dealloc]):
(-[WKHTTPCookieStore allCookies:]):
(-[WKHTTPCookieStore addObserver:]):
(-[WKHTTPCookieStore removeObserver:]):
(-[WKHTTPCookieStore fetchCookies:]): Deleted.
(-[WKHTTPCookieStore fetchCookiesForURL:completionHandler:]): Deleted.
(-[WKHTTPCookieStore setCookies:forURL:mainDocumentURL:completionHandler:]): Deleted.
(-[WKHTTPCookieStore removeCookiesSinceDate:completionHandler:]): Deleted.
(-[WKHTTPCookieStore setCookieAcceptPolicy:completionHandler:]): Deleted.
(kitCookiePolicyToNSCookiePolicy): Deleted.
(-[WKHTTPCookieStore fetchCookieAcceptPolicy:]): Deleted.

  • UIProcess/Cocoa/WebProcessPoolCocoa.mm:

(WebKit::WebProcessPool::platformInitializeNetworkProcess):

  • UIProcess/WebCookieManagerProxy.cpp:

(WebKit::WebCookieManagerProxy::~WebCookieManagerProxy):
(WebKit::WebCookieManagerProxy::processPoolDestroyed):
(WebKit::WebCookieManagerProxy::registerObserver):
(WebKit::WebCookieManagerProxy::unregisterObserver):
(WebKit::WebCookieManagerProxy::cookiesDidChange):
(WebKit::WebCookieManagerProxy::setCookieObserverCallback): Deleted.

  • UIProcess/WebCookieManagerProxy.h:

(WebKit::WebCookieManagerProxy::Observer::~Observer):

Add the ability for interested clients to listen for the creation of new WebProcessPools,
which is needed by APIHTTPCookieStore:

  • UIProcess/WebProcessPool.cpp:

(WebKit::generateListenerIdentifier):
(WebKit::processPoolCreationListenerFunctionMap):
(WebKit::WebProcessPool::registerProcessPoolCreationListener):
(WebKit::WebProcessPool::unregisterProcessPoolCreationListener):
(WebKit::WebProcessPool::create):

  • UIProcess/WebProcessPool.h:
  • UIProcess/WebsiteData/WebsiteDataStore.cpp:

(WebKit::WebsiteDataStore::processPoolForCookieStorageNotifications):
(WebKit::WebsiteDataStore::isAssociatedProcessPool):
(WebKit::WebsiteDataStore::processPools):

  • UIProcess/WebsiteData/WebsiteDataStore.h:

Tools:

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStore.mm: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStorage.mm.

(-[CookieObserver cookiesDidChangeInCookieStore:]):
(TEST): Also test delete and observers.

4:19 PM Changeset in webkit [214077] by webkit@devinrousso.com
  • 4 edits in trunk/Source/WebInspectorUI

Web Inspector: add "Save Selected" context menu item to Console
​https://bugs.webkit.org/show_bug.cgi?id=151837

Reviewed by Joseph Pecoraro.

  • Localizations/en.lproj/localizedStrings.js:
  • UserInterface/Base/Main.js:

(WebInspector.saveDataToFile):
Allow data to be saved without a provided URL. It will default to localized "Untitled".

  • UserInterface/Views/LogContentView.js:

(WebInspector.LogContentView.prototype._handleContextMenuEvent):

4:11 PM Changeset in webkit [214076] by webkit@devinrousso.com
  • 3 edits in trunk/Source/WebInspectorUI

Web Inspector: RTL: selected frame indicator is not positioned correctly
​https://bugs.webkit.org/show_bug.cgi?id=169763

Reviewed by Matt Baker.

  • UserInterface/Views/RenderingFrameTimelineOverviewGraph.js:

(WebInspector.RenderingFrameTimelineOverviewGraph.prototype._updateFrameMarker):
(WebInspector.RenderingFrameTimelineOverviewGraph.prototype._mouseClicked):
Treat the current mouse position (event.pageX) as a negative value when in RTL, meaning that
the delta movement from the starting position is flipped.

  • UserInterface/Views/TimelineRuler.css:

(body[dir=ltr] .timeline-ruler > .header > .divider,):
(body[dir=rtl] .timeline-ruler > .header > .divider,):
(.timeline-ruler > .header > .divider):
(.timeline-ruler > .header > .divider > .label):
(body[dir=ltr] .timeline-ruler > .header > .divider > .label):
(body[dir=rtl] .timeline-ruler > .header > .divider > .label):
(.timeline-ruler > .markers > .divider):
(.timeline-ruler > .markers > .marker):
(body[dir=ltr] .timeline-ruler > .markers > .marker):
(body[dir=rtl] .timeline-ruler > .markers > .marker):
(.timeline-ruler > .markers > .marker::before):
(body[dir=ltr] .timeline-ruler > .markers > .marker::before):
(body[dir=rtl] .timeline-ruler > .markers > .marker::before):
(body[dir=ltr] .timeline-ruler > .markers > .marker.current-time):
(body[dir=rtl] .timeline-ruler > .markers > .marker.current-time):
(.timeline-ruler > .markers > .marker.current-time::before):
(.timeline-ruler > .markers > .marker.current-time): Deleted.

(.timeline-ruler > .selection-handle):
(body[dir=ltr] .timeline-ruler > .selection-handle.left):
(body[dir=rtl] .timeline-ruler > .selection-handle.left):
(body[dir=ltr] .timeline-ruler > .selection-handle.right):
(body[dir=rtl] .timeline-ruler > .selection-handle.right):
Drive-by: add CSS variable for clarity.

3:53 PM Changeset in webkit [214075] by commit-queue@webkit.org
  • 14 edits in trunk/LayoutTests

Rebase webrtc tests
​https://bugs.webkit.org/show_bug.cgi?id=169791

Unreviewed.

Patch by Youenn Fablet <​youenn@apple.com> on 2017-03-16

  • TestExpectations:
  • fast/mediastream/MediaStream-add-remove-tracks-expected.txt:
  • fast/mediastream/MediaStreamTrack-expected.txt:
  • fast/mediastream/MediaStreamTrack-onended-expected.txt:
  • fast/mediastream/RTCPeerConnection-addIceCandidate-expected.txt:
  • fast/mediastream/RTCPeerConnection-events-expected.txt:
  • fast/mediastream/RTCPeerConnection-media-setup-single-dialog-expected.txt:
  • fast/mediastream/RTCPeerConnection-media-setup-two-dialogs-expected.txt:
  • fast/mediastream/RTCPeerConnection-remotely-assigned-transceiver-mid-expected.txt:
  • fast/mediastream/RTCPeerConnection-setLocalDescription-offer-expected.txt:
  • fast/mediastream/RTCPeerConnection-setRemoteDescription-offer-expected.txt:
  • fast/mediastream/RTCPeerConnection-statsSelector-expected.txt:
  • platform/mac/TestExpectations:
3:32 PM Changeset in webkit [214074] by jiewen_tan@apple.com
  • 18 edits
    6 copies
    43 adds in trunk

[WebCrypto] Support SPKI/PKCS8 for Elliptic Curve
​https://bugs.webkit.org/show_bug.cgi?id=169318
<rdar://problem/31081956>

Reviewed by Brent Fulgham.

LayoutTests/imported/w3c:

  • web-platform-tests/WebCryptoAPI/import_export/ec_importKey.worker-expected.txt:
  • web-platform-tests/WebCryptoAPI/import_export/test_ec_importKey-expected.txt:

Source/WebCore:

This patch adds SPKI/PKCS8 support for Elliptic Curve cryptos. We can now import/export
SPKI/PKCS8 Elliptic Curve keys after this change. Few things to note: 1) This patch
implements a loose DER encoder/decoder for hacking the underlying CommonCrypto library.
2) It only permits id-ecPublicKey as the AlgorithmIdentifier following OpenSSL/Chrome(BoringSSL).
3) It follows OpenSSL/Chrome(BoringSSL) to replace ECParameters in ECPrivateKey with custom
tags. Hence, we should fully comply with OpenSSL/Chrome(BoringSSL).

Tests: crypto/subtle/ec-import-jwk-key-export-pkcs8-key.html

crypto/subtle/ec-import-jwk-key-export-spki-key.html
crypto/subtle/ec-import-pkcs8-key-export-jwk-key.html
crypto/subtle/ec-import-pkcs8-key-export-pkcs8-key-p256.html
crypto/subtle/ec-import-pkcs8-key-export-pkcs8-key-p384.html
crypto/subtle/ec-import-raw-key-export-spki-key.html
crypto/subtle/ec-import-spki-key-export-jwk-key.html
crypto/subtle/ec-import-spki-key-export-raw-key.html
crypto/subtle/ec-import-spki-key-export-spki-key-p256.html
crypto/subtle/ec-import-spki-key-export-spki-key-p384.html
crypto/subtle/ecdh-generate-export-key-spki-p256.html
crypto/subtle/ecdh-generate-export-key-spki-p384.html
crypto/subtle/ecdh-generate-export-pkcs8-p256.html
crypto/subtle/ecdh-generate-export-pkcs8-p384.html
crypto/subtle/ecdh-import-pkcs8-key-p256.html
crypto/subtle/ecdh-import-pkcs8-key-p384.html
crypto/subtle/ecdh-import-spki-key-p256.html
crypto/subtle/ecdh-import-spki-key-p384.html
crypto/workers/subtle/ec-generate-export-pkcs8-key.html
crypto/workers/subtle/ec-generate-export-spki-key.html
crypto/workers/subtle/ec-import-pkcs8-key.html
crypto/workers/subtle/ec-import-spki-key.html

  • WebCore.xcodeproj/project.pbxproj:
  • crypto/algorithms/CryptoAlgorithmECDH.cpp:

(WebCore::CryptoAlgorithmECDH::importKey):
(WebCore::CryptoAlgorithmECDH::exportKey):

  • crypto/gnutls/CryptoKeyECGnuTLS.cpp:

(WebCore::CryptoKeyEC::platformExportRaw):
(WebCore::CryptoKeyEC::platformImportSpki):
(WebCore::CryptoKeyEC::platformExportSpki):
(WebCore::CryptoKeyEC::platformImportPkcs8):
(WebCore::CryptoKeyEC::platformExportPkcs8):
(WebCore::CryptoKeyEC::exportRaw): Deleted.

  • crypto/keys/CryptoKeyEC.cpp:

(WebCore::CryptoKeyEC::importSpki):
(WebCore::CryptoKeyEC::importPkcs8):
(WebCore::CryptoKeyEC::exportRaw):
(WebCore::CryptoKeyEC::exportSpki):
(WebCore::CryptoKeyEC::exportPkcs8):

  • crypto/keys/CryptoKeyEC.h:
  • crypto/mac/CommonCryptoDERUtilities.h: Added.

(WebCore::bytesUsedToEncodedLength):
(WebCore::extraBytesNeededForEncodedLength):
(WebCore::addEncodedASN1Length):
(WebCore::bytesNeededForEncodedLength):

  • crypto/mac/CryptoKeyECMac.cpp:

(WebCore::compareBytes):
(WebCore::CryptoKeyEC::platformExportRaw):
(WebCore::CryptoKeyEC::platformImportJWKPrivate):
(WebCore::getOID):
(WebCore::CryptoKeyEC::platformImportSpki):
(WebCore::CryptoKeyEC::platformExportSpki):
(WebCore::CryptoKeyEC::platformImportPkcs8):
(WebCore::CryptoKeyEC::platformExportPkcs8):
(WebCore::CryptoKeyEC::exportRaw): Deleted.
Enlarge the robust of exportRaw.

  • crypto/mac/CryptoKeyRSAMac.cpp:

(WebCore::CryptoKeyRSA::exportSpki):
(WebCore::CryptoKeyRSA::exportPkcs8):
Enhance the implementation.
(WebCore::bytesUsedToEncodedLength): Deleted.
(WebCore::bytesNeededForEncodedLength): Deleted.
(WebCore::addEncodedASN1Length): Deleted.
Moved to CommonCryptoDERUtilities.h.

LayoutTests:

  • crypto/subtle/ec-export-key-malformed-parameters-expected.txt:
  • crypto/subtle/ec-export-key-malformed-parameters.html:
  • crypto/subtle/ec-import-jwk-key-export-jwk-key-private-expected.txt:
  • crypto/subtle/ec-import-jwk-key-export-jwk-key-private.html:
  • crypto/subtle/ec-import-jwk-key-export-pkcs8-key-expected.txt: Added.
  • crypto/subtle/ec-import-jwk-key-export-pkcs8-key.html: Added.
  • crypto/subtle/ec-import-jwk-key-export-spki-key-expected.txt: Added.
  • crypto/subtle/ec-import-jwk-key-export-spki-key.html: Added.
  • crypto/subtle/ec-import-key-malformed-parameters-expected.txt:
  • crypto/subtle/ec-import-key-malformed-parameters.html:
  • crypto/subtle/ec-import-pkcs8-key-export-jwk-key-expected.txt: Added.
  • crypto/subtle/ec-import-pkcs8-key-export-jwk-key.html: Added.
  • crypto/subtle/ec-import-pkcs8-key-export-pkcs8-key-p256-expected.txt: Added.
  • crypto/subtle/ec-import-pkcs8-key-export-pkcs8-key-p256.html: Added.
  • crypto/subtle/ec-import-pkcs8-key-export-pkcs8-key-p384-expected.txt: Added.
  • crypto/subtle/ec-import-pkcs8-key-export-pkcs8-key-p384.html: Added.
  • crypto/subtle/ec-import-raw-key-export-spki-key-expected.txt: Added.
  • crypto/subtle/ec-import-raw-key-export-spki-key.html: Added.
  • crypto/subtle/ec-import-spki-key-export-jwk-key-expected.txt: Added.
  • crypto/subtle/ec-import-spki-key-export-jwk-key.html: Added.
  • crypto/subtle/ec-import-spki-key-export-raw-key-expected.txt: Added.
  • crypto/subtle/ec-import-spki-key-export-raw-key.html: Added.
  • crypto/subtle/ec-import-spki-key-export-spki-key-p256-expected.txt: Added.
  • crypto/subtle/ec-import-spki-key-export-spki-key-p256.html: Added.
  • crypto/subtle/ec-import-spki-key-export-spki-key-p384-expected.txt: Added.
  • crypto/subtle/ec-import-spki-key-export-spki-key-p384.html: Added.
  • crypto/subtle/ecdh-generate-export-key-spki-p256-expected.txt: Added.
  • crypto/subtle/ecdh-generate-export-key-spki-p256.html: Added.
  • crypto/subtle/ecdh-generate-export-key-spki-p384-expected.txt: Added.
  • crypto/subtle/ecdh-generate-export-key-spki-p384.html: Added.
  • crypto/subtle/ecdh-generate-export-pkcs8-p256-expected.txt: Added.
  • crypto/subtle/ecdh-generate-export-pkcs8-p256.html: Added.
  • crypto/subtle/ecdh-generate-export-pkcs8-p384-expected.txt: Added.
  • crypto/subtle/ecdh-generate-export-pkcs8-p384.html: Added.
  • crypto/subtle/ecdh-import-pkcs8-key-p256-expected.txt: Added.
  • crypto/subtle/ecdh-import-pkcs8-key-p256.html: Added.
  • crypto/subtle/ecdh-import-pkcs8-key-p384-expected.txt: Added.
  • crypto/subtle/ecdh-import-pkcs8-key-p384.html: Added.
  • crypto/subtle/ecdh-import-spki-key-p256-expected.txt: Added.
  • crypto/subtle/ecdh-import-spki-key-p256.html: Added.
  • crypto/subtle/ecdh-import-spki-key-p384-expected.txt: Added.
  • crypto/subtle/ecdh-import-spki-key-p384.html: Added.
  • crypto/workers/subtle/ec-generate-export-pkcs8-key-expected.txt: Added.
  • crypto/workers/subtle/ec-generate-export-pkcs8-key.html: Added.
  • crypto/workers/subtle/ec-generate-export-spki-key-expected.txt: Added.
  • crypto/workers/subtle/ec-generate-export-spki-key.html: Added.
  • crypto/workers/subtle/ec-import-pkcs8-key-expected.txt: Added.
  • crypto/workers/subtle/ec-import-pkcs8-key.html: Added.
  • crypto/workers/subtle/ec-import-spki-key-expected.txt: Added.
  • crypto/workers/subtle/ec-import-spki-key.html: Added.
  • crypto/workers/subtle/resources/ec-generate-export-pkcs8-key.js: Added.
  • crypto/workers/subtle/resources/ec-generate-export-spki-key.js: Added.
  • crypto/workers/subtle/resources/ec-import-pkcs8-key.js: Added.
  • crypto/workers/subtle/resources/ec-import-spki-key.js: Added.
3:15 PM Changeset in webkit [214073] by achristensen@apple.com
  • 6 edits in trunk/Source/WebCore

Don't use an optional for didReceiveSocketStreamData's length
​https://bugs.webkit.org/show_bug.cgi?id=169699

Reviewed by Brady Eidson.

Rather than sending a message with an optional length, send a message with a length
and send a different message if the receiving of bytes failed.

No new tests (no behavior change).

  • Modules/websockets/WebSocketChannel.cpp:

(WebCore::WebSocketChannel::didReceiveSocketStreamData):

  • Modules/websockets/WebSocketChannel.h:
  • platform/network/SocketStreamHandleClient.h:
  • platform/network/cf/SocketStreamHandleImplCFNet.cpp:

(WebCore::SocketStreamHandleImpl::readStreamCallback):

  • platform/network/soup/SocketStreamHandleImplSoup.cpp:

(WebCore::SocketStreamHandleImpl::readBytes):

3:14 PM Changeset in webkit [214072] by Alan Bujtas
  • 5 edits
    2 adds in trunk

Simple line layout: Extend webkit-hyphenate-limit-lines to cover subsequent words.
​https://bugs.webkit.org/show_bug.cgi?id=169631

Reviewed by Antti Koivisto.

Source/WebCore:

This patch extends webkit-hyphenate-limit-lines to cover separate words across multiple lines.
Example:

webkit-hyphenate-limit-lines: 1;
"if this line wraps at foo-
bar, the next line should
not hyphenate at all. How-
ever the line after that
could."

Test: fast/text/simple-line-layout-hyphenation-limit-lines-accross-words.html

  • rendering/SimpleLineLayout.cpp:

(WebCore::SimpleLineLayout::LineState::setHyphenationDisabled):
(WebCore::SimpleLineLayout::LineState::isHyphenationDisabled):
(WebCore::SimpleLineLayout::updateLineConstrains):
(WebCore::SimpleLineLayout::hyphenPositionForFragment):
(WebCore::SimpleLineLayout::splitFragmentToFitLine):
(WebCore::SimpleLineLayout::createLineRuns):
(WebCore::SimpleLineLayout::createTextRuns):

  • rendering/SimpleLineLayoutTextFragmentIterator.h:

(WebCore::SimpleLineLayout::TextFragmentIterator::TextFragment::hasHyphen):
(WebCore::SimpleLineLayout::TextFragmentIterator::TextFragment::splitWithHyphen):
(WebCore::SimpleLineLayout::TextFragmentIterator::TextFragment::wrappingWithHyphenCounter): Deleted.

LayoutTests:

  • fast/text/simple-line-layout-hyphenation-limit-lines-accross-words-expected.html: Added.
  • fast/text/simple-line-layout-hyphenation-limit-lines-accross-words.html: Added.
2:53 PM Changeset in webkit [214071] by mark.lam@apple.com
  • 8 edits in trunk/Source/JavaScriptCore

The new array with spread operation needs to check for length overflows.
​https://bugs.webkit.org/show_bug.cgi?id=169780
<rdar://problem/31072182>

Reviewed by Filip Pizlo.

  • dfg/DFGOperations.cpp:
  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileNewArrayWithSpread):

  • ftl/FTLLowerDFGToB3.cpp:

(JSC::FTL::DFG::LowerDFGToB3::compileNewArrayWithSpread):

  • ftl/FTLOperations.cpp:

(JSC::FTL::operationMaterializeObjectInOSR):

  • llint/LLIntSlowPaths.cpp:
  • runtime/CommonSlowPaths.cpp:

(JSC::SLOW_PATH_DECL):

  • runtime/JSGlobalObject.cpp:
2:49 PM Changeset in webkit [214070] by BJ Burg
  • 4 edits
    2 adds in trunk/Source/WebKit2

[iOS WK2] Web Automation: implement platform methods for simulating keyboard events
​https://bugs.webkit.org/show_bug.cgi?id=169487
<rdar://problem/28360564>

Reviewed by Joseph Pecoraro.

Reimplement platformSimulateKey{Stroke, Sequence} to simulate events coming from UIKit.
These events are sent directly into WebCore without going through the keyboard system,
since we don't need to show the keyboard when simulating keystrokes. For example, the
keystrokes may not be representable given the current keyboard layout and system language.

  • UIProcess/Automation/WebAutomationSession.cpp:
  • UIProcess/Automation/WebAutomationSession.h:

Un-stub implementations that now exist for iOS.

  • UIProcess/Automation/ios/WebAutomationSessionIOS.mm: Added.

(WebKit::WebAutomationSession::sendSynthesizedEventsToPage): Added.
This is similar to the Mac version, but it sends events directly into WebPageProxy
instead of sending them to the NSWindow containing the WebView.

(WebKit::WebAutomationSession::platformSimulateKeyStroke):
Use a somewhat different strategy for determining the charCode/keyCode since we cannot
rely on the system keyboard / input manager to generate and deliver real key events.
Compared to the Mac platform method, this requires setting up fewer fields and does
not use AppKit's current modifier state to determine the effect of sticky modifiers.

(WebKit::WebAutomationSession::platformSimulateKeySequence):
This is almost verbatim from the Mac platform method but uses a different event class.

  • WebKit2.xcodeproj/project.pbxproj: Add new file.
2:19 PM Changeset in webkit [214069] by fpizlo@apple.com
  • 14 edits
    3 adds in trunk

FTL should support global and eval code
​https://bugs.webkit.org/show_bug.cgi?id=169656

Reviewed by Geoffrey Garen and Saam Barati.

JSTests:

Added basic performance tests of global and eval code. These tests will run a lot faster in with
the FTL because of the object allocation.

  • microbenchmarks/eval-code-ftl-reentry.js: Added.
  • microbenchmarks/eval-code-ftl.js: Added.
  • microbenchmarks/global-code-ftl.js: Added.
  • stress/arith-log-on-various-types.js: This was a flaky fail with concurrent JIT, so I stopped running it with concurrent JIT. The failure was its assertion about how many times something gets compiled.

Source/JavaScriptCore:

Turned off the restriction against global and eval code running in the FTL, and then fixed all of
the things that didn't work.

This is a big speed-up on microbenchmarks that I wrote for this patch. One of the reasons why we
hadn't done this earlier is that we've never seen a benchmark that needed it. Global and eval
code rarely gets FTL-hot. Still, this seems like possibly a small JetStream speed-up.

  • dfg/DFGJITCode.cpp:

(JSC::DFG::JITCode::setOSREntryBlock): I outlined this for better debugging.

  • dfg/DFGJITCode.h:

(JSC::DFG::JITCode::setOSREntryBlock): Deleted.

  • dfg/DFGNode.h:

(JSC::DFG::Node::isSemanticallySkippable): It turns out that global code often has InvalidationPoints before LoopHints. They are also skippable from the standpoint of OSR entrypoint analysis.

  • dfg/DFGOperations.cpp: Don't do any normal compiles of global code - just do OSR compiles.
  • ftl/FTLCapabilities.cpp: Enable FTL for global and eval code.

(JSC::FTL::canCompile):

  • ftl/FTLCompile.cpp: Just debugging clean-ups.

(JSC::FTL::compile):

  • ftl/FTLJITFinalizer.cpp: Implement finalize() and ensure that we only do things with the entrypoint buffer if we have one. We won't have one for eval code that we aren't OSR entering into.

(JSC::FTL::JITFinalizer::finalize):
(JSC::FTL::JITFinalizer::finalizeFunction):
(JSC::FTL::JITFinalizer::finalizeCommon):

  • ftl/FTLJITFinalizer.h:
  • ftl/FTLLink.cpp: When entering a function normally, we need the "entrypoint" to put the arity check code. Global and eval code don't need this.

(JSC::FTL::link):

  • ftl/FTLOSREntry.cpp: Fix a dataLog statement.

(JSC::FTL::prepareOSREntry):

  • ftl/FTLOSRExitCompiler.cpp: Remove dead code that happened to assert that we're exiting from a function.

(JSC::FTL::compileStub):

2:10 PM Changeset in webkit [214068] by msaboff@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

WebAssembly: function-tests/load-offset.js fails on ARM64
​https://bugs.webkit.org/show_bug.cgi?id=169724

Reviewed by Keith Miller.

We need to use the two source version of Add64 to create a Wasm address with the
other source the first child.

  • b3/B3LowerToAir.cpp:

(JSC::B3::Air::LowerToAir::lower):

1:55 PM Changeset in webkit [214067] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

Fix quotes around --pretty format git flag.
​https://bugs.webkit.org/show_bug.cgi?id=169712

Patch by Kocsen Chung <Kocsen Chung> on 2017-03-16
Reviewed by Ryosuke Niwa.

Remove double quotes from command list element '--pretty="format:%ct"' since it will cause
subprocess to not work as expected.
Additionally, take advantage of git -C flag.

  • Scripts/webkitpy/common/checkout/scm/git.py:

(Git.native_revision):
Take advantage of git -C flag.
(Git.timestamp_of_native_revision):
Take advantage of git -C flag and remove double quotes from git formatter.
We know this works from committer_email_for_revision() function.

1:53 PM Changeset in webkit [214066] by webkit@devinrousso.com
  • 2 edits in trunk/Source/WebInspectorUI

Web Inspector: RTL: filter mode icon in Debugger sidebar is misaligned
​https://bugs.webkit.org/show_bug.cgi?id=169766

Reviewed by Matt Baker.

  • UserInterface/Views/FilterBar.css:

(.filter-bar > .navigation-bar > .item):
(body[dir=ltr] .filter-bar > .navigation-bar > .item):
(body[dir=rtl] .filter-bar > .navigation-bar > .item):

1:53 PM Changeset in webkit [214065] by rniwa@webkit.org
  • 15 edits
    8 adds in trunk/Websites/perf.webkit.org

Add the file uploading capability to the perf dashboard.
​https://bugs.webkit.org/show_bug.cgi?id=169737

Reviewed by Chris Dumez.

Added /privileged-api/upload-file to upload a file, and /api/uploaded-file/ to download the file
and retrieve its meta data based on its SHA256. We treat two files with the identical SHA256 as
identical since anyone who can upload a file using this mechanism can execute arbitrary code in
our bots anyway. This is important for avoiding uploading a large darwinup roots multiple times
to the server, saving both user's time/bandwidth and server's disk space.

  • config.json: Added uploadDirectory, uploadFileLimitInMB, and uploadUserQuotaInMB as options.
  • init-database.sql: Added uploaded_files table.
  • public/api/uploaded-file.php: Added.

(main): /api/uploaded-file/N would download uploaded_file with id=N. /api/uploaded-file/?sha256=X
would return the meta data for uploaded_file with sha256=X.
(stream_file_content): Streams the file content in 64KB chunks. We support Range & If-Range HTTP
request headers so that browsers can pause and resume downloading of a large root file.
(parse_range_header): Parses Range HTTP request header.

  • public/include/json-header.php:

(remote_user_name): Use the default argument of NULL.

  • public/include/manifest-generator.php:

(ManifestGenerator::generate): Include the maximum upload size in the manifest file to let the
frontend code preemptively check the file size before attempting to submit a file.

  • public/include/uploaded-file-helpers.php: Added.

(format_uploaded_file):
(uploaded_file_path_for_row):

  • public/privileged-api/upload-file-form.html: Added. For debugging purposes.

(fetchCSRFfToken):
(upload):

  • public/privileged-api/upload-file.php: Added.

(main):
(query_total_file_size):
(create_uploaded_file_from_form_data):

  • public/shared/common-remote.js:

(CommonRemoteAPI.prototype.postFormData): Added.
(CommonRemoteAPI.prototype.postFormDataWithStatus): Added.
(CommonRemoteAPI.prototype.sendHttpRequestWithFormData): Added.
(CommonRemoteAPI.prototype._asJSON): Throw an exception instead of calling a non-existent reject.

  • public/v3/models/uploaded-file.js: Added.

(UploadedFile): Added.
(UploadedFile.uploadFile): Added.
(UploadedFile.fetchUnloadedFileWithIdenticalHash): Added. Finds the file with the same SHA256 in
the server to avoid uploading a large custom root multiple times.
(UploadedFile._computeSHA256Hash): Added.

  • public/v3/privileged-api.js:

(PrivilegedAPI.prototype.sendRequest): Added the options dictionary as a third argument. For now,
only support useFormData boolean.

  • public/v3/remote.js:

(BrowserRemoteAPI.prototype.sendHttpRequestWithFormData): Added.

  • server-tests/api-manifest.js: Updated per the inclusion of fileUploadSizeLimit in the manifest.
  • server-tests/api-uploaded-file.js: Added.
  • server-tests/privileged-api-upload-file-tests.js: Added.
  • server-tests/resources/temporary-file.js: Added.

(TemporaryFile): Added. A helper class for creating a temporary file to upload.
(TemporaryFile.makeTemporaryFileOfSizeInMB):
(TemporaryFile.makeTemporaryFile):
(TemporaryFile.inject):

  • server-tests/resources/test-server.conf: Set upload_max_filesize and post_max_size for testing.
  • server-tests/resources/test-server.js:

(TestServer.prototype.testConfig): Use uploadFileLimitInMB and uploadUserQuotaInMB of 2MB and 5MB.
(TestServer.prototype._ensureDataDirectory): Create a directory to store uploaded files inside
the data directory. In a production server, we can place it outside ServerRoot / DocumentRoot.
(TestServer.prototype.cleanDataDirectory): Delete the aforementioned directory as needed.

  • tools/js/database.js:

(tableToPrefixMap): Added uploaded_files.

  • tools/js/remote.js:

(NodeRemoteAPI.prototype.sendHttpRequest): Added a dictionary to specify request headers and
a callback to process the response as arguments. Fixed the bug that any 2xx code other than 200
was resulting in a rejected promise. Also include the response headers in the result for tests.
Finally, when content is a function, call that instead of writing the content since FormData
requires a custom logic.
(NodeRemoteAPI.prototype.sendHttpRequestWithFormData): Added.

  • tools/js/v3-models.js: Include uploaded-file.js.
  • tools/run-tests.py:

(main): Add form-data as a new dependency.

1:50 PM Changeset in webkit [214064] by Matt Baker
  • 5 edits
    1 delete in trunk/Source/WebInspectorUI

Web Inspector: Refactoring: remove DebuggerTreeElement class
​https://bugs.webkit.org/show_bug.cgi?id=169697

Reviewed by Devin Rousso.

Remove unnecessary class DebuggerTreeElement from TreeElement class hierarchy.
The sourceCodeLocation property on IssueMessage and Breakpoint (the debugger
objects) can be tested for generically using TreeElement.prototype.representedObject.

  • UserInterface/Main.html:

Remove file.

  • UserInterface/Views/BreakpointTreeElement.js:
  • UserInterface/Views/IssueTreeElement.js:

Change base class to GeneralTreeElement.

  • UserInterface/Views/DebuggerSidebarPanel.js:

(WebInspector.DebuggerSidebarPanel.prototype._addBreakpoint):
(WebInspector.DebuggerSidebarPanel.prototype._compareTreeElements):
(WebInspector.DebuggerSidebarPanel.prototype._addIssue):
(WebInspector.DebuggerSidebarPanel.prototype._compareDebuggerTreeElements): Deleted.
Renamed to just "_compareTreeElements".

  • UserInterface/Views/DebuggerTreeElement.js: Removed.
1:42 PM Changeset in webkit [214063] by commit-queue@webkit.org
  • 6 edits in trunk

[mac-wk2 debug] LayoutTest webrtc/video-mute.html is timing out
​https://bugs.webkit.org/show_bug.cgi?id=169758

Patch by Youenn Fablet <​youenn@apple.com> on 2017-03-16
Reviewed by Eric Carlson.

Source/WebKit2:

Test is timing out due to the UIProcess requesting to disable/enable ICE candidate filtering
on a page whose preference is set to not enabling ICE candidate filtering.
Current fix is to act upon what UI process asks if the page preference is to enable ICE candidate filtering.
If ICE candidate filtering preference is disable for that page (WebKitTestRunner case), no disabling/enabling is done at all.

  • UIProcess/UserMediaProcessManager.cpp:

(WebKit::UserMediaProcessManager::endedCaptureSession):

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::m_backgroundCPULimit):
(WebKit::m_backgroundCPULimit):
(WebKit::WebPage::disableICECandidateFiltering):
(WebKit::WebPage::enableICECandidateFiltering):

  • WebProcess/WebPage/WebPage.h:

LayoutTests:

1:28 PM Changeset in webkit [214062] by webkit@devinrousso.com
  • 2 edits in trunk/Source/WebInspectorUI

Web Inspector: RTL: goto arrow for source locations is pointing wrong way in Timeline data grids
​https://bugs.webkit.org/show_bug.cgi?id=169764

Reviewed by Matt Baker.

  • UserInterface/Views/DataGrid.css:

(body[dir=rtl] .data-grid td .go-to-arrow):

12:06 PM Changeset in webkit [214061] by achristensen@apple.com
  • 12 edits in trunk

Clean up WKContentExtension API
​https://bugs.webkit.org/show_bug.cgi?id=169772

Reviewed by Geoffrey Garen.

Source/WebKit2:

Based on feedback I have decided to do the following:

  1. Rename lookup to lookUp because look and up are two words.
  2. Change the parameter of removeContentExtension to a WKContentExtension* to match addContentExtension.
  3. Add an identifier property accessor to WKContentExtension.
  4. Change the order of the new error types. This wasn't exactly based on any feedback, but they look more organized now.
  • UIProcess/API/Cocoa/WKContentExtension.h:
  • UIProcess/API/Cocoa/WKContentExtension.mm:

(-[WKContentExtension identifier]):

  • UIProcess/API/Cocoa/WKContentExtensionStore.h:
  • UIProcess/API/Cocoa/WKContentExtensionStore.mm:

(toWKErrorCode):
(-[WKContentExtensionStore lookUpContentExtensionForIdentifier:completionHandler:]):
(-[WKContentExtensionStore lookupContentExtensionForIdentifier:completionHandler:]): Deleted.

  • UIProcess/API/Cocoa/WKError.h:
  • UIProcess/API/Cocoa/WKError.mm:

(localizedDescriptionForErrorCode):

  • UIProcess/API/Cocoa/WKUserContentController.h:
  • UIProcess/API/Cocoa/WKUserContentController.mm:

(-[WKUserContentController removeContentExtension:]):

  • UIProcess/API/Cocoa/_WKUserContentExtensionStore.mm:

(toUserContentExtensionStoreError):
(-[_WKUserContentExtensionStore lookupContentExtensionForIdentifier:completionHandler:]):

Tools:

  • TestWebKitAPI/Tests/WebKit2Cocoa/WKUserContentExtensionStore.mm:

(TEST_F):
(-[ContentExtensionDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):

11:58 AM Changeset in webkit [214060] by zandobersek@gmail.com
  • 2 edits
    1 add
    1 delete in trunk/Source/WebCore

[GLib] Add SSLKeyGeneratorGLib.cpp
​https://bugs.webkit.org/show_bug.cgi?id=169740

Reviewed by Sergio Villar Senin.

Move the getSupportedKeySizes() and signedPublicKeyAndChallengeString()
functions from TemporaryLinkStubs.cpp to SSLKeyGeneratorGLib.cpp. The
userIdleTime() function can be removed in this process since it's not
used anywhere anymore.

  • PlatformGTK.cmake:
  • platform/glib/SSLKeyGeneratorGLib.cpp: Renamed from Source/WebCore/platform/gtk/TemporaryLinkStubs.cpp.

(WebCore::getSupportedKeySizes):
(WebCore::signedPublicKeyAndChallengeString):

11:43 AM Changeset in webkit [214059] by Alan Bujtas
  • 3 edits
    2 adds in trunk

Stay inside the continuation while searching for a candidate ancestor for insertion.
​https://bugs.webkit.org/show_bug.cgi?id=169768
<rdar://problem/30959936>

Reviewed by David Hyatt.

Source/WebCore:

Test: fast/inline/continuation-crash-with-anon-ancestors.html

  • rendering/RenderInline.cpp:

(WebCore::RenderInline::addChildToContinuation):

LayoutTests:

  • fast/inline/continuation-crash-with-anon-ancestors-expected.txt: Added.
  • fast/inline/continuation-crash-with-anon-ancestors.html: Added.
11:31 AM Changeset in webkit [214058] by matthew_hanson@apple.com
  • 1 copy in tags/Safari-603.1.30.4.6

Tag Safari-603.1.30.4.6.

11:28 AM Changeset in webkit [214057] by matthew_hanson@apple.com
  • 3 edits in branches/safari-603-branch/Source/WebKit/win

Merge r213846. rdar://problem/30983702

11:28 AM Changeset in webkit [214056] by matthew_hanson@apple.com
  • 3 edits in branches/safari-603-branch/Source/WebKit/win

Merge r213737. rdar://problem/30983702

11:26 AM Changeset in webkit [214055] by matthew_hanson@apple.com
  • 5 edits in branches/safari-603.1.30.4-branch/Source

Versioning

11:18 AM Changeset in webkit [214054] by matthew_hanson@apple.com
  • 3 edits in branches/safari-603.1.30.4-branch/Source/WebKit/win

Merge r213846. rdar://problem/30983702

11:18 AM Changeset in webkit [214053] by matthew_hanson@apple.com
  • 2 edits in branches/safari-603.1.30.4-branch/Source/WebCore

Roll out r213847 via r214013. rdar://problem/30983702

11:18 AM Changeset in webkit [214052] by matthew_hanson@apple.com
  • 5 edits in branches/safari-603.1.30.4-branch/Source

Versioning.

11:01 AM QtWebKitSecurity edited by Konstantin Tokarev
Removed info about 2.2.0 that is not the latest stable release for a … (diff)
10:31 AM Changeset in webkit [214051] by Ryan Haddad
  • 2 edits in trunk/LayoutTests

Mark fast/mediacapturefromelement/CanvasCaptureMediaStream-request-frame-events.html as flaky.
​https://bugs.webkit.org/show_bug.cgi?id=169719

Unreviewed test gardening.

  • platform/mac-wk2/TestExpectations:
10:20 AM Changeset in webkit [214050] by Ryan Haddad
  • 3 edits in trunk/LayoutTests

TestExpectations gardening for modern-media-controls tests.

Unreviewed test gardening.

  • platform/mac-wk1/TestExpectations:
  • platform/mac/TestExpectations:
10:20 AM Changeset in webkit [214049] by Ryan Haddad
  • 3 edits in trunk/LayoutTests

Mark imported/w3c/web-platform-tests/IndexedDB/fire-success-event-exception.html as flaky.
​https://bugs.webkit.org/show_bug.cgi?id=169760

Unreviewed test gardening.

  • platform/ios-simulator-wk2/TestExpectations:
  • platform/mac-wk2/TestExpectations:
10:19 AM Changeset in webkit [214048] by BJ Burg
  • 3 edits in trunk/Source/WebInspectorUI

Web Inspector: RTL: add FindBanner support for RTL layout
​https://bugs.webkit.org/show_bug.cgi?id=168723

Reviewed by Timothy Hatcher.

Due to the large number of CSS tricks used by this widget, adding RTL
support involves changing a large number of rules. The important parts:

  • Use '.segmented.{previous,next}-result' instead of '.segmented.

{left,right}', this makes the style rules way less confusing for RTL.

  • Flip icons so icons look like "< >" but actions are reversed.
  • Get rid of the weird expanding button divider. This is impossible

to mirror with the existing adjacent sibling combinator, and it does
not match the system appearance. Just replace the mini-divider with a
full divider and remove related dynamic rules that trigger on :active.

  • Always keep the button divider between next/previous on the rightmost

button, to avoid subtle differences between LTR and RTL.

  • Fix some mistakes where we weren't using --border-color and also

didn't adjust the handcoded border color for the inactive window case.

  • UserInterface/Views/FindBanner.css:

(.find-banner):
(body[dir=ltr] .find-banner > :first-child,):
(body[dir=ltr] .find-banner > :last-child,):
(.find-banner > input[type="search"]):
(body[dir=ltr] .find-banner > input[type="search"]):
(body[dir=rtl] .find-banner > input[type="search"]):
(.find-banner > button:active:not(:disabled)):
(.find-banner > button.segmented):
(.find-banner > button.segmented.previous-result):
(body[dir=ltr] .find-banner > button.segmented.previous-result):
(body[dir=rtl] .find-banner > button.segmented.previous-result):
(body[dir=ltr] .find-banner > button.segmented.previous-result > .glyph):
(body[dir=rtl] .find-banner > button.segmented.previous-result > .glyph):
(body[dir=ltr] .find-banner > button.segmented.previous-result:active:not(:disabled) > .glyph):
(body[dir=rtl] .find-banner > button.segmented.previous-result:active:not(:disabled) > .glyph):
(.find-banner > button.segmented.next-result):
(body[dir=ltr] .find-banner > button.segmented.next-result):
(body[dir=rtl] .find-banner > button.segmented.next-result):
(body[dir=ltr] .find-banner > button.segmented.next-result > .glyph):
(body[dir=rtl] .find-banner > button.segmented.next-result > .glyph):
(body[dir=ltr] .find-banner > button.segmented.next-result:active:not(:disabled) > .glyph):
(body[dir=rtl] .find-banner > button.segmented.next-result:active:not(:disabled) > .glyph):
(.find-banner.console-find-banner > input[type="search"]):
(body[dir=ltr] .find-banner.console-find-banner > input[type="search"]):
(body[dir=rtl] .find-banner.console-find-banner > input[type="search"]):
(body[dir=ltr] .find-banner.console-find-banner > input[type="search"]::-webkit-textfield-decoration-container):
(body[dir=rtl] .find-banner.console-find-banner > input[type="search"]::-webkit-textfield-decoration-container):
(.find-banner > :first-child): Deleted.
(.find-banner > :last-child): Deleted.
(.find-banner > button.segmented.left): Deleted.
(.find-banner > button:not(:active).segmented.right:before): Deleted.
(.find-banner > button.segmented.left:active + button.segmented.right,): Deleted.
(.find-banner > button.segmented.left:active + button.segmented.right:before): Deleted.
(.find-banner > button.segmented.left > .glyph): Deleted.
(.find-banner > button.segmented.left:active:not(:disabled) > .glyph): Deleted.
(.find-banner > button.segmented.right): Deleted.
(.find-banner > button.segmented.right > .glyph): Deleted.
(.find-banner > button.segmented.right:active:not(:disabled) > .glyph): Deleted.
(.find-banner.console-find-banner > input[type="search"]::-webkit-textfield-decoration-container): Deleted.

  • UserInterface/Views/FindBanner.js:

(WebInspector.FindBanner):
Change left and right to logical names for the buttons, and inline
some style classes with single uses.

10:16 AM Changeset in webkit [214047] by dbates@webkit.org
  • 3 edits
    2 adds in trunk/LayoutTests

Update test fast/events/pageshow-pagehide-on-back-cached-with-frames.html to ensure
that pageshow events are dispatched to frames in post-order traversal
<​https://bugs.webkit.org/show_bug.cgi?id=169682>

Reviewed by Brady Eidson.

  • fast/events/pageshow-pagehide-on-back-cached-with-frames-expected.txt:
  • fast/events/pageshow-pagehide-on-back-cached-with-frames.html:
  • fast/events/resources/pageshow-pagehide-subframe-cachable-2.html: Added.
  • fast/events/resources/pageshow-pagehide-subsubframe-cachable-2.html: Added.
10:12 AM Changeset in webkit [214046] by Jonathan Bedard
  • 3 edits in trunk/Tools

webktpy: Fix device regular expression for parsing simctl output
​https://bugs.webkit.org/show_bug.cgi?id=169757

Reviewed by Alex Christensen.

If a device is unavailable, the changes in r213164 mean that the
name of the device will consume the UDID and return the state as
the device UDID and the availability string as the device state.

  • Scripts/webkitpy/xcode/simulator.py:

(Simulator): Make UDID regular expression more strict.

  • Scripts/webkitpy/xcode/simulator_unittest.py: Test an unavailable device.
9:49 AM Changeset in webkit [214045] by jonlee@apple.com
  • 20 edits
    4 adds in trunk/Source

Add FIXMEs to update WebRTC
​https://bugs.webkit.org/show_bug.cgi?id=169735

Reviewed by Youenn Fablet.

Source/JavaScriptCore:

  • runtime/CommonIdentifiers.h: Add RTCIceTransport.

Source/WebCore:

Rearrange order of methods and properties based on the 13 March 2017
version of the WebRTC spec.

  • CMakeLists.txt: Add RTCIceTransport and RTCIceTransportState.
  • DerivedSources.make:
  • Modules/mediastream/RTCDTMFSender.idl:
  • Modules/mediastream/RTCDTMFToneChangeEvent.idl:
  • Modules/mediastream/RTCDataChannelEvent.idl:
  • Modules/mediastream/RTCIceCandidate.idl:
  • Modules/mediastream/RTCIceCandidateEvent.idl:
  • Modules/mediastream/RTCIceServer.idl:
  • Modules/mediastream/RTCIceTransport.cpp: Added.
  • Modules/mediastream/RTCIceTransport.idl: Added.
  • Modules/mediastream/RTCIceTransport.h: Minor update to rename state to transportState.

(WebCore::RTCIceTransport::state):
(WebCore::RTCIceTransport::setState):
(WebCore::RTCIceTransport::transportState): Deleted.
(WebCore::RTCIceTransport::setTransportState): Deleted.

  • Modules/mediastream/RTCIceTransportState.h: Added.
  • Modules/mediastream/RTCIceTransportState.idl: Added.
  • Modules/mediastream/RTCPeerConnection.h:
  • Modules/mediastream/RTCPeerConnection.idl:
  • Modules/mediastream/RTCRtpReceiver.idl:
  • Modules/mediastream/RTCRtpSender.idl:
  • Modules/mediastream/RTCRtpTransceiver.idl:
  • Modules/mediastream/RTCStatsReport.idl:
  • WebCore.xcodeproj/project.pbxproj:
  • Modules/mediastream/MediaEndpointPeerConnection.cpp:

(WebCore::MediaEndpointPeerConnection::iceTransportStateChanged): Refactor.

9:09 AM Changeset in webkit [214044] by commit-queue@webkit.org
  • 14 edits
    2 copies
    6 adds in trunk

Improve WebRTC track enabled support
​https://bugs.webkit.org/show_bug.cgi?id=169727

Patch by Youenn Fablet <​youenn@apple.com> on 2017-03-16
Reviewed by Alex Christensen.

Source/WebCore:

Tests: webrtc/peer-connection-audio-mute2.html

webrtc/peer-connection-remote-audio-mute.html
webrtc/video-remote-mute.html

Making sure muted/disabled sources produce silence/black frames.
For outgoing audio/video sources, this should be done by the actual a/v providers.
We keep this filtering here until we are sure they implement that.

  • platform/audio/mac/AudioSampleDataSource.mm:

(WebCore::AudioSampleDataSource::pullAvalaibleSamplesAsChunks): Ensuring disabled audio tracks send silence.
Used for outgoing webrtc tracks.

  • platform/mediastream/mac/MockRealtimeAudioSourceMac.mm:

(WebCore::MockRealtimeAudioSourceMac::render): Ditto.

  • platform/mediastream/mac/RealtimeIncomingAudioSource.cpp:

(WebCore::RealtimeIncomingAudioSource::OnData): Ditto.

  • platform/mediastream/mac/RealtimeIncomingVideoSource.cpp:

(WebCore::RealtimeIncomingVideoSource::pixelBufferFromVideoFrame): Generating black frames if muted.
(WebCore::RealtimeIncomingVideoSource::OnFrame):

  • platform/mediastream/mac/RealtimeIncomingVideoSource.h:
  • platform/mediastream/mac/RealtimeOutgoingVideoSource.cpp:

(WebCore::RealtimeOutgoingVideoSource::videoSampleAvailable): Ensuring we quit after sending black frame.

LayoutTests:

  • TestExpectations:
  • webrtc/audio-peer-connection-webaudio.html:
  • webrtc/peer-connection-audio-mute-expected.txt:
  • webrtc/peer-connection-audio-mute.html:
  • webrtc/peer-connection-audio-mute2-expected.txt: Added.
  • webrtc/peer-connection-audio-mute2.html: Added.
  • webrtc/peer-connection-remote-audio-mute-expected.txt: Added.
  • webrtc/peer-connection-remote-audio-mute.html: Added.
  • webrtc/video-mute-expected.txt:
  • webrtc/video-mute.html:
  • webrtc/video-remote-mute-expected.txt: Added.
  • webrtc/video-remote-mute.html: Added.
8:23 AM Changeset in webkit [214043] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

LibWebRTC outgoing source should be thread safe refcounted
​https://bugs.webkit.org/show_bug.cgi?id=169726

Patch by Youenn Fablet <​youenn@apple.com> on 2017-03-16
Reviewed by Alex Christensen.

Preventive fix.
Also fixing the size of the buffer for the audio source as its reserved size is byte count.

  • platform/mediastream/mac/RealtimeOutgoingAudioSource.h:
  • platform/mediastream/mac/RealtimeOutgoingVideoSource.h:
8:21 AM Changeset in webkit [214042] by commit-queue@webkit.org
  • 15 edits in trunk/Source/WebCore

MediaStreamTrack remote() no longer exists
​https://bugs.webkit.org/show_bug.cgi?id=169734

Patch by Youenn Fablet <​youenn@apple.com> on 2017-03-16
Reviewed by Alex Christensen.

Removing MediaStreamTrack remote.
Removing RealtimeMediaSource::remote as isCaptureSource which is closer to its use in MediaStreamPrivate to
detect whether sources are capture sources or not.

  • Modules/mediastream/MediaStream.cpp:

(WebCore::MediaStream::mediaState):

  • platform/mediastream/MediaStreamPrivate.cpp:

(WebCore::MediaStreamPrivate::hasCaptureVideoSource):
(WebCore::MediaStreamPrivate::hasCaptureAudioSource):
(WebCore::MediaStreamPrivate::hasLocalVideoSource): Deleted.
(WebCore::MediaStreamPrivate::hasLocalAudioSource): Deleted.

  • platform/mediastream/MediaStreamPrivate.h:
  • Modules/mediastream/MediaStreamTrack.cpp:

(WebCore::MediaStreamTrack::stopProducingData):
(WebCore::MediaStreamTrack::remote): Deleted.

  • Modules/mediastream/MediaStreamTrack.h:
  • Modules/mediastream/MediaStreamTrack.idl:
  • Modules/webaudio/MediaStreamAudioSource.h:
  • platform/mediastream/MediaStreamPrivate.cpp:

(WebCore::MediaStreamPrivate::hasLocalVideoSource):
(WebCore::MediaStreamPrivate::hasLocalAudioSource):

  • platform/mediastream/MediaStreamTrackPrivate.cpp:

(WebCore::MediaStreamTrackPrivate::isCaptureTrack):
(WebCore::MediaStreamTrackPrivate::remote): Deleted.

  • platform/mediastream/MediaStreamTrackPrivate.h:
  • platform/mediastream/RealtimeMediaSource.cpp:

(WebCore::RealtimeMediaSource::reset):

  • platform/mediastream/RealtimeMediaSource.h:

(WebCore::RealtimeMediaSource::isCaptureSource):
(WebCore::RealtimeMediaSource::remote): Deleted.
(WebCore::RealtimeMediaSource::setRemote): Deleted.

  • platform/mediastream/mac/AVMediaCaptureSource.h:
  • platform/mock/MockRealtimeAudioSource.h:
  • platform/mock/MockRealtimeVideoSource.h:
6:52 AM Changeset in webkit [214041] by Yusuke Suzuki
  • 2 edits in trunk/Source/JavaScriptCore

Unreviewed, copy m_numberOfArgumentsToSkip
​https://bugs.webkit.org/show_bug.cgi?id=164582

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::CodeBlock):

6:24 AM Changeset in webkit [214040] by Yusuke Suzuki
  • 4 edits in trunk/Source/JavaScriptCore

Unreviewed, fix numParameter() - 1 OSRExit materialization
​https://bugs.webkit.org/show_bug.cgi?id=164582

When materializing rest parameters, we rely on that numParameter() - 1 equals to
the numberOfArgumentsToSkip. But this assumption is broken in r214029.

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::finishCreation):

  • bytecode/CodeBlock.h:

(JSC::CodeBlock::numberOfArgumentsToSkip):

  • ftl/FTLOperations.cpp:

(JSC::FTL::operationMaterializeObjectInOSR):

6:13 AM Changeset in webkit [214039] by Manuel Rego Casasnovas
  • 3 edits
    2 adds in trunk

[css-grid] Crash on debug removing a positioned child
​https://bugs.webkit.org/show_bug.cgi?id=169739

Reviewed by Sergio Villar Senin.

Source/WebCore:

When we add or remove a positioned item we don't need to mark
the grid as dirty, because positioned items do not affect the layout
of the grid at all.

This was causing a crash when a positioned item was removed
after a layout. As after the positioned item was removed,
the method RenderGrid::layoutBlock() was not called,
so when the grid was repainted we got a crash.

Test: fast/css-grid-layout/grid-crash-remove-positioned-item.html

  • rendering/RenderGrid.cpp:

(WebCore::RenderGrid::addChild): Add early return to avoid marking
the grid as dirty for positioned grid items.
(WebCore::RenderGrid::removeChild): Ditto.

LayoutTests:

Add new test that checks that adding and removing a positioned grid item
doesn't cause any crashes.

  • fast/css-grid-layout/grid-crash-remove-positioned-item-expected.txt: Added.
  • fast/css-grid-layout/grid-crash-remove-positioned-item.html: Added.
5:58 AM Changeset in webkit [214038] by commit-queue@webkit.org
  • 19 edits
    1 add in trunk

[ESnext] Implement Object Spread
​https://bugs.webkit.org/show_bug.cgi?id=167963

Patch by Caio Lima <Caio Lima> on 2017-03-16
Reviewed by Yusuke Suzuki.

JSTests:

  • stress/object-spread.js: Added.

(let.assert):
(assert.sameValue):
(let.o.get a):
(let.obj.get c):
(cthulhu.get x):
(let.obj.set c):
(calls.o.get z):
(calls.o.get a):
(try.let.obj.get foo):
(get calls):

Source/JavaScriptCore:

This patch implements ECMA262 stage 3 Object Spread proposal [1].
It's implemented using CopyDataProperties to copy all enumerable keys
from object being spreaded.

It's also fixing CopyDataProperties that was using
Object.getOwnPropertyNames to list all keys to be copied, and now is
using Relect.ownKeys.

[1] - ​https://github.com/sebmarkbage/ecmascript-rest-spread

  • builtins/GlobalOperations.js:

(globalPrivate.copyDataProperties):

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::setConstantIdentifierSetRegisters):

  • bytecode/UnlinkedCodeBlock.h:

(JSC::UnlinkedCodeBlock::addSetConstant):

  • bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::emitLoad):

  • bytecompiler/BytecodeGenerator.h:
  • bytecompiler/NodesCodegen.cpp:

(JSC::PropertyListNode::emitBytecode):
(JSC::ObjectPatternNode::bindValue):
(JSC::ObjectSpreadExpressionNode::emitBytecode):

  • parser/ASTBuilder.h:

(JSC::ASTBuilder::createObjectSpreadExpression):
(JSC::ASTBuilder::createProperty):

  • parser/NodeConstructors.h:

(JSC::PropertyNode::PropertyNode):
(JSC::ObjectSpreadExpressionNode::ObjectSpreadExpressionNode):

  • parser/Nodes.h:

(JSC::ObjectSpreadExpressionNode::expression):

  • parser/Parser.cpp:

(JSC::Parser<LexerType>::parseProperty):

  • parser/SyntaxChecker.h:

(JSC::SyntaxChecker::createObjectSpreadExpression):
(JSC::SyntaxChecker::createProperty):

  • runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::init):

  • runtime/JSGlobalObjectFunctions.cpp:

(JSC::privateToObject): Deleted.

  • runtime/JSGlobalObjectFunctions.h:

LayoutTests:

  • js/parser-syntax-check-expected.txt:
  • js/script-tests/parser-syntax-check.js:
4:59 AM Changeset in webkit [214037] by clopez@igalia.com
  • 5 edits in trunk

[WebRTC] SDP sess-id in the "o=" line should be a value between 0 and LLONG_MAX.
​https://bugs.webkit.org/show_bug.cgi?id=169681

Reviewed by Alejandro G. Castro.

Source/WebCore:

Use an int64_t type for storing sess-id and ensure that the value generated is always between 0 and LLONG_MAX (263-1).
To the JS world (sdp.js) we pass and read this value as a string type.

The JS world (sdp.js) was already using a string type for sess-id.
This caused a bug when reading the sess-id value at configurationFromJSON(): no value was obtained because a numeric type was expected.

So, after this patch, sess-id is passed and read as a string from sdp.js, and converted to an int64_t type for internal use.
This way we also avoid a rounding problem that happens with values near LLONG_MAX when converting from int64_t to double when passed to the JS world,
and that could cause that we end passing a number bigger than LLONG_MAX to sdp.js.

  • Modules/mediastream/SDPProcessor.cpp:

(WebCore::configurationFromJSON):
(WebCore::configurationToJSON):

  • platform/mediastream/MediaEndpointSessionConfiguration.h:

(WebCore::MediaEndpointSessionConfiguration::sessionId):
(WebCore::MediaEndpointSessionConfiguration::setSessionId):
(WebCore::MediaEndpointSessionConfiguration::MediaEndpointSessionConfiguration):

LayoutTests:

Check that the generated sess-id value its between the limits before validating it.
This is covered by the tests fast/mediastream/RTCPeerConnection-inspect-answer.html
and fast/mediastream/RTCPeerConnection-inspect-offer.html.
Both tests will fail if the sess-id value generated is not within the limits.

  • fast/mediastream/resources/sdp-utils.js:

(printComparableSessionDescription):

4:55 AM Changeset in webkit [214036] by Carlos Garcia Campos
  • 3 edits
    1 copy
    1 add
    2 deletes in trunk/Source/WTF

[UNIX] Implement currentSearchLocaleID() and currentTextBreakLocaleID()
​https://bugs.webkit.org/show_bug.cgi?id=169745

Reviewed by Yusuke Suzuki.

Add a common implementation for Unix based ports using setlocale.

  • wtf/PlatformGTK.cmake:
  • wtf/PlatformJSCOnly.cmake:
  • wtf/text/gtk/TextBreakIteratorInternalICUGtk.cpp: Removed.
  • wtf/text/unix/TextBreakIteratorInternalICUUnix.cpp: Renamed from Source/WTF/wtf/text/jsconly/TextBreakIteratorInternalICUJSCOnly.cpp.

(WTF::currentSearchLocaleID):
(WTF::currentTextBreakLocaleID):

2:57 AM Changeset in webkit [214035] by Carlos Garcia Campos
  • 3 edits in trunk/Source/WTF

[GLIB] MainThread implementation is not GTK+ specific
​https://bugs.webkit.org/show_bug.cgi?id=169736

Reviewed by Yusuke Suzuki.

It's implemented in MainThreadGLib.cpp for glib based ports, so ifdefs in MainThread should not be
PLATFORM(GTK) but USE(GLIB).

  • wtf/MainThread.cpp:
  • wtf/MainThread.h:
1:40 AM Changeset in webkit [214034] by tpopela@redhat.com
  • 4 edits in trunk/Source/WebKit2

Fix uninitialized public members in Webkit2/UIProcess/API/gtk
​https://bugs.webkit.org/show_bug.cgi?id=169602

Reviewed by Michael Catanzaro.

Found by Coverity scan.

  • UIProcess/API/gtk/WebKitMimeInfo.cpp:
  • UIProcess/API/gtk/WebKitSettings.cpp:
  • UIProcess/API/gtk/WebKitWebViewBase.cpp:
12:51 AM Changeset in webkit [214033] by zandobersek@gmail.com
  • 2 edits in trunk/Source/WebKit2

Unreviewed follow-up to r213787. Move the DatabaseProcess build targets
to the top of WebKit2_SOURCES list in order to maintain the alphabetical
order.

  • CMakeLists.txt:

Mar 15, 2017:

11:48 PM Changeset in webkit [214032] by achristensen@apple.com
  • 2 edits in trunk/Source/WebKit2

Fix CMake build.

  • PlatformMac.cmake:
11:29 PM Changeset in webkit [214031] by Dewei Zhu
  • 3 edits in trunk/Websites/perf.webkit.org

Fix unit test and bug fix for 'pull-os-versions.js' script.
​https://bugs.webkit.org/show_bug.cgi?id=169701

Reviewed by Ryosuke Niwa.

Fix unit tests warnings on node-6.10.0.
Fix 'pull-os-versions.js' does not fetch new builds and report.

  • server-tests/tools-os-build-fetcher-tests.js:

(then):
(beforeEach):
(afterEach):

  • tools/pull-os-versions.js:

(syncLoop):

11:10 PM Changeset in webkit [214030] by jonlee@apple.com
  • 23 edits
    6 adds in trunk/Source/WebCore

Flatten RTC enum naming
​https://bugs.webkit.org/show_bug.cgi?id=169664

Reviewed by Youenn Fablet.

Use consistent names of RTC enums throughout WebCore. This means surfacing
ICE enums out of PeerConnectionState. Keep the old names around for other
ports.

Add RTCIceConnectionState, RTCIceGatheringState, and RTCSignalingState enums.

  • CMakeLists.txt:
  • DerivedSources.make:
  • Modules/mediastream/RTCIceConnectionState.h: Added. The enum is defined in

PeerConnectionStates.h, so just include that file.

  • Modules/mediastream/RTCIceConnectionState.idl: Added.
  • Modules/mediastream/RTCIceGatheringState.h: Added.
  • Modules/mediastream/RTCIceGatheringState.idl: Added.
  • Modules/mediastream/RTCSignalingState.h: Added.
  • Modules/mediastream/RTCSignalingState.idl: Added.
  • WebCore.xcodeproj/project.pbxproj:
  • platform/mediastream/PeerConnectionStates.h: Move the existing enums into

WebCore, but keep aliases to the old names within the PeerConnectionStates
namespace.

Refactor to use the new enum names.

  • Modules/mediastream/MediaEndpointPeerConnection.cpp: Refactor.
  • Modules/mediastream/MediaEndpointPeerConnection.h:
  • Modules/mediastream/PeerConnectionBackend.cpp:
  • Modules/mediastream/PeerConnectionBackend.h:
  • Modules/mediastream/RTCConfiguration.h:
  • Modules/mediastream/RTCConfiguration.idl: Add FIXMEs for bringing this up

to spec.

  • Modules/mediastream/RTCIceTransport.h:
  • Modules/mediastream/RTCPeerConnection.cpp: Refactor the three functions

below to using the enum instead of returning strings. This allows remove of
the internal* versions of these functions.
(WebCore::RTCPeerConnection::signalingState): Deleted.
(WebCore::RTCPeerConnection::iceGatheringState): Deleted.
(WebCore::RTCPeerConnection::iceConnectionState): Deleted.

  • Modules/mediastream/RTCPeerConnection.h: Replace internalSignalingState,

internalIceGatheringState, and internalIceConnectionState.

  • Modules/mediastream/RTCPeerConnection.idl:
  • Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp:
  • Modules/mediastream/libwebrtc/LibWebRTCPeerConnectionBackend.cpp:
  • platform/mediastream/MediaEndpoint.h:
  • platform/mediastream/MediaEndpointConfiguration.cpp:
  • platform/mediastream/MediaEndpointConfiguration.h:
  • platform/mock/MockMediaEndpoint.cpp:
  • platform/mock/MockMediaEndpoint.h:
  • platform/mediastream/openwebrtc/MediaEndpointOwr.cpp:

(WebCore::MediaEndpointOwr::processIceTransportStateChange):

10:12 PM Changeset in webkit [214029] by Yusuke Suzuki
  • 16 edits
    2 adds in trunk

[JSC] Default parameter part should be retrieved by op_get_argument opcode instead of changing arity
​https://bugs.webkit.org/show_bug.cgi?id=164582

Reviewed by Saam Barati.

JSTests:

  • stress/function-with-defaults-inlining.js: Added.

(shouldBe):
(ok):
(a):

  • stress/function-with-defaults-non-inlining.js: Added.

(shouldBe):
(ok):
(a):

Source/JavaScriptCore:

Previously we implement the default parameters as follows.

  1. We count the default parameters as the usual parameters.
  2. We just get the argument register.
  3. Check it with op_is_undefined.
  4. And fill the binding with either the argument register or default value.

The above is simple. However, it has the side effect that it always increase the arity of the function.
While function.length does not increase, internally, the number of parameters of CodeBlock increases.
This effectively prevent our DFG / FTL to perform inlining: currently we only allows DFG to inline
the function with the arity less than or equal the number of passing arguments. It is OK. But when using
default parameters, we frequently do not pass the argument for the parameter with the default value.
Thus, in our current implementation, we frequently need to fixup the arity. And we frequently fail
to inline the function.

This patch fixes the above problem by not increasing the arity of the function. When we encounter the
parameter with the default value, we use op_argument to get the argument instead of using the argument
registers.

This improves six-speed defaults.es6 performance by 4.45x.

defaults.es6 968.4126+-101.2350 217.6602+-14.8831 definitely 4.4492x faster

  • bytecode/UnlinkedFunctionExecutable.cpp:

(JSC::UnlinkedFunctionExecutable::UnlinkedFunctionExecutable):

  • bytecode/UnlinkedFunctionExecutable.h:
  • bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::BytecodeGenerator):
(JSC::BytecodeGenerator::initializeDefaultParameterValuesAndSetupFunctionScopeStack):
(JSC::BytecodeGenerator::initializeNextParameter):
(JSC::BytecodeGenerator::initializeParameters):

  • bytecompiler/BytecodeGenerator.h:
  • bytecompiler/NodesCodegen.cpp:

(JSC::FunctionNode::emitBytecode):

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::inliningCost):

  • parser/ASTBuilder.h:

(JSC::ASTBuilder::createFunctionMetadata):

  • parser/Nodes.cpp:

(JSC::FunctionMetadataNode::FunctionMetadataNode):

  • parser/Nodes.h:

(JSC::FunctionParameters::size):
(JSC::FunctionParameters::at):
(JSC::FunctionParameters::append):
(JSC::FunctionParameters::isSimpleParameterList):

  • parser/Parser.cpp:

(JSC::Parser<LexerType>::isArrowFunctionParameters):
(JSC::Parser<LexerType>::parseGeneratorFunctionSourceElements):
(JSC::Parser<LexerType>::parseAsyncFunctionSourceElements):
(JSC::Parser<LexerType>::parseFormalParameters):
(JSC::Parser<LexerType>::parseFunctionBody):
(JSC::Parser<LexerType>::parseFunctionParameters):
(JSC::Parser<LexerType>::parseFunctionInfo):

  • parser/Parser.h:
  • parser/SyntaxChecker.h:

(JSC::SyntaxChecker::createFunctionMetadata):

  • runtime/FunctionExecutable.h:
  • runtime/JSFunction.cpp:

(JSC::JSFunction::createBuiltinFunction):
(JSC::JSFunction::reifyLength):

9:49 PM Changeset in webkit [214028] by Yusuke Suzuki
  • 10 edits
    2 adds in trunk

[DFG] ToString operation should have fixup for primitives to say this node does not have side effects
​https://bugs.webkit.org/show_bug.cgi?id=169544

Reviewed by Saam Barati.

JSTests:

  • microbenchmarks/template-string-array.js: Added.

(test):

  • stress/to-string-non-cell-use.js: Added.

(shouldBe):
(shouldThrow):

Source/JavaScriptCore:

Our DFG ToString only considers well about String operands. While ToString(non cell operand) does not have
any side effect, it is not modeled well in DFG.

This patch introduces a fixup for ToString with NonCellUse edge. If this edge is set, ToString does not
clobber things (like ToLowerCase, producing String). And ToString(NonCellUse) allows us to perform CSE!

Our microbenchmark shows 32.9% improvement due to dropped GetButterfly and CSE for ToString().

baseline patched

template-string-array 12.6284+-0.2766 9.4998+-0.2295 definitely 1.3293x faster

And SixSpeed template_string.es6 shows 16.68x performance improvement due to LICM onto this non-side-effectful ToString().

baseline patched

template_string.es6 3229.7343+-40.5705 193.6077+-36.3349 definitely 16.6818x faster

  • dfg/DFGAbstractInterpreterInlines.h:

(JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):

  • dfg/DFGClobberize.h:

(JSC::DFG::clobberize):

  • dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupToStringOrCallStringConstructor):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileToStringOrCallStringConstructorOnCell):
(JSC::DFG::SpeculativeJIT::speculateNotCell):

  • dfg/DFGSpeculativeJIT.h:
  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • ftl/FTLLowerDFGToB3.cpp:

(JSC::FTL::DFG::LowerDFGToB3::compileToStringOrCallStringConstructor):
(JSC::FTL::DFG::LowerDFGToB3::lowNotCell):
(JSC::FTL::DFG::LowerDFGToB3::speculateNotCell):

9:10 PM Changeset in webkit [214027] by jer.noble@apple.com
  • 17 edits
    1 copy
    5 adds
    1 delete in trunk/Source

Optionally capture audio in the UIProcess
​https://bugs.webkit.org/show_bug.cgi?id=169609

Reviewed by Alex Christensen.

Source/WebCore:

Export some previously un-exported symbols from WebCore for use in WebKit2.

  • WebCore.xcodeproj/project.pbxproj:
  • platform/audio/WebAudioBufferList.h:
  • platform/mediastream/RealtimeMediaSource.h:

Source/WebKit2:

Add a new class pair, UserMediaCaptureManager/Proxy, to allow a RealtimeMediaSource
requested in a WebProcess to be created in the UIProcess and push its audio data across the
process boundary to its clients in the WebProcess. Because these classes are clients of the
RealtimeMediaSourceCenter::singleton(), they must be a singleton in the WebProcess as well,
so they are attached to the WebProcess class in the web process and to WebProcessProxy in
the UIProcess.

  • UIProcess/Cocoa/UserMediaCaptureManagerProxy.cpp: Added.

(WebKit::UserMediaCaptureManagerProxy::SourceProxy::SourceProxy):
(WebKit::UserMediaCaptureManagerProxy::SourceProxy::~SourceProxy):
(WebKit::UserMediaCaptureManagerProxy::SourceProxy::source):
(WebKit::UserMediaCaptureManagerProxy::SourceProxy::description):
(WebKit::UserMediaCaptureManagerProxy::SourceProxy::numberOfFrames):
(WebKit::UserMediaCaptureManagerProxy::UserMediaCaptureManagerProxy):
(WebKit::UserMediaCaptureManagerProxy::~UserMediaCaptureManagerProxy):
(WebKit::UserMediaCaptureManagerProxy::createMediaSourceForCaptureDeviceWithConstraints):
(WebKit::UserMediaCaptureManagerProxy::startProducingData):
(WebKit::UserMediaCaptureManagerProxy::stopProducingData):

  • UIProcess/Cocoa/UserMediaCaptureManagerProxy.h:

(WebKit::UserMediaCaptureManagerProxy::process):

  • UIProcess/Cocoa/UserMediaCaptureManagerProxy.messages.in: Added.
  • WebProcess/cocoa/UserMediaCaptureManager.cpp: Added.

(WebKit::nextSessionID):
(WebKit::UserMediaCaptureManager::Source::Source):
(WebKit::UserMediaCaptureManager::Source::~Source):
(WebKit::UserMediaCaptureManager::Source::setCapabilities):
(WebKit::UserMediaCaptureManager::Source::setSettings):
(WebKit::UserMediaCaptureManager::Source::description):
(WebKit::UserMediaCaptureManager::Source::setStorage):
(WebKit::UserMediaCaptureManager::Source::setRingBufferFrameBounds):
(WebKit::UserMediaCaptureManager::Source::audioSamplesAvailable):
(WebKit::UserMediaCaptureManager::UserMediaCaptureManager):
(WebKit::UserMediaCaptureManager::~UserMediaCaptureManager):
(WebKit::UserMediaCaptureManager::supplementName):
(WebKit::UserMediaCaptureManager::initialize):
(WebKit::UserMediaCaptureManager::createMediaSourceForCaptureDeviceWithConstraints):
(WebKit::UserMediaCaptureManager::sourceStopped):
(WebKit::UserMediaCaptureManager::sourceMutedChanged):
(WebKit::UserMediaCaptureManager::sourceEnabledChanged):
(WebKit::UserMediaCaptureManager::sourceSettingsChanged):
(WebKit::UserMediaCaptureManager::storageChanged):
(WebKit::UserMediaCaptureManager::ringBufferFrameBoundsChanged):
(WebKit::UserMediaCaptureManager::audioSamplesAvailable):
(WebKit::UserMediaCaptureManager::startProducingData):
(WebKit::UserMediaCaptureManager::stopProducingData):

  • WebProcess/cocoa/UserMediaCaptureManager.h: Added.
  • WebProcess/cocoa/UserMediaCaptureManager.messages.in: Added.

Initialize UserMediaCaptureManager/Proxy:

  • UIProcess/Cocoa/WebProcessPoolCocoa.mm:

(WebKit::WebProcessPool::platformInitializeWebProcess):

  • UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::WebProcessProxy):

  • UIProcess/WebProcessProxy.h:
  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::WebProcess):

WebUserMediaClientMac is no longer necessary now that the UserMediaCaptureManager overrides
the factories:

  • WebProcess/WebCoreSupport/WebUserMediaClient.cpp:

(WebKit::WebUserMediaClient::WebUserMediaClient):
(WebKit::WebUserMediaClient::initializeFactories): Deleted.

Add a new preference and WebProcessCreationParameters member to control whether
capturing is done in the UIProcess:

  • Shared/WebPreferencesDefinitions.h:
  • Shared/WebProcessCreationParameters.cpp:

(WebKit::WebProcessCreationParameters::encode):
(WebKit::WebProcessCreationParameters::decode):

  • Shared/WebProcessCreationParameters.h:

Add new files to the project:

  • DerivedSources.make:
  • WebKit2.xcodeproj/project.pbxproj:
8:41 PM Changeset in webkit [214026] by Ryan Haddad
  • 2 edits in trunk/Source/JavaScriptCore

Revert part of r213978 to see if it resolves LayoutTest crashes.
​https://bugs.webkit.org/show_bug.cgi?id=169729

Reviewed by Alexey Proskuryakov.

8:15 PM Changeset in webkit [214025] by clopez@igalia.com
  • 3 edits in trunk/Source/WTF

[CMake][JSCOnly] Fix build with GLib event loop
​https://bugs.webkit.org/show_bug.cgi?id=169730

Reviewed by Michael Catanzaro.

  • wtf/MainThread.cpp:
  • wtf/PlatformJSCOnly.cmake: WorkQueueGLib was removed in r199713.
7:48 PM Changeset in webkit [214024] by webkit@devinrousso.com
  • 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Selecting text in the console does not do what I expect
​https://bugs.webkit.org/show_bug.cgi?id=169570

Reviewed by Matt Baker.

  • UserInterface/Views/ConsoleMessageView.css:

(.console-message-text > span > :matches(.console-message-enclosed, .console-message-preview, .console-message-preview-divider)):
(.console-message .console-message-location):
(.console-message-location.call-frame):
Prevent text selection on anything other than the message text. The other information that
is not selectable can still be copied by selecting the message itself and copying.

6:56 PM Changeset in webkit [214023] by Alan Bujtas
  • 5 edits
    2 adds in trunk

Do not reparent floating object until after intruding/overhanging dependency is cleared.
​https://bugs.webkit.org/show_bug.cgi?id=169711
<rdar://problem/30959743>

Reviewed by Simon Fraser.

Source/WebCore:

This patch ensures that we cleanup the m_floatingObjects for siblings before reparenting the fresh float.

Test: fast/block/float/inline-becomes-float-and-moves-around.html

  • rendering/RenderBlockFlow.cpp:

(WebCore::RenderBlockFlow::styleDidChange):

  • rendering/RenderElement.cpp:

(WebCore::RenderElement::styleDidChange):

  • rendering/RenderElement.h:

(WebCore::RenderElement::noLongerAffectsParentBlock):

LayoutTests:

  • fast/block/float/inline-becomes-float-and-moves-around-expected.txt: Added.
  • fast/block/float/inline-becomes-float-and-moves-around.html: Added.
6:01 PM Changeset in webkit [214022] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

[jsc][mips] Fix compilation error introduced in r213652
​https://bugs.webkit.org/show_bug.cgi?id=169723

Patch by Guillaume Emont <​guijemont@igalia.com> on 2017-03-15
Reviewed by Mark Lam.

The new replaceWithBkpt() contains a lapsus in it
(s/code/instructionStart) and won't compile.

  • assembler/MIPSAssembler.h:

(JSC::MIPSAssembler::replaceWithBkpt):

6:01 PM Changeset in webkit [214021] by Nikita Vasilyev
  • 3 edits in trunk/Source/WebInspectorUI

Web Inspector: WebSockets: Update Arrow Up icon to fit in with the rest of our iconography
​https://bugs.webkit.org/show_bug.cgi?id=169696
<rdar://problem/31073748>

Reviewed by Matt Baker.

  • UserInterface/Images/ArrowUp.svg:
  • UserInterface/Images/gtk/ArrowUp.svg:
4:40 PM Changeset in webkit [214020] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

Switch back to ISO 4217 for Intl CurrencyDigits data
​https://bugs.webkit.org/show_bug.cgi?id=169182

Previously, a patch switched Intl.NumberFormat to use CLDR data through
ICU to get the default number of decimal digits for a currency.
However, that change actually violated the ECMA 402 specification,
which references ISO 4217 as the data source. This patch reverts to
an in-line implementation of that data.

Patch by Daniel Ehrenberg <​littledan@chromium.org> on 2017-03-15
Reviewed by Saam Barati.

  • runtime/IntlNumberFormat.cpp:

(JSC::computeCurrencySortKey):
(JSC::extractCurrencySortKey):
(JSC::computeCurrencyDigits):

4:29 PM Changeset in webkit [214019] by timothy_horton@apple.com
  • 4 edits
    1 add in trunk

Null deref under callAfterNextPresentationUpdate
​https://bugs.webkit.org/show_bug.cgi?id=169710
<rdar://problem/30987863>

Reviewed by Simon Fraser.

Source/WebKit2:

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::callAfterNextPresentationUpdate):
Call the callback with an error if we don't have a web process or drawing area.

Tools:

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/Tests/WebKit2Cocoa/DoAfterNextPresentationUpdateAfterCrash.mm: Added.

(TEST):

4:17 PM Changeset in webkit [214018] by sbarati@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

WebAssembly: When we GC to try to get a fast memory, we should call collectAllGarbage(), not collectSync()
​https://bugs.webkit.org/show_bug.cgi?id=169704

Reviewed by Mark Lam.

We weren't always sweeping the memory needed to free
the WasmMemory we wanted to use. collectAllGarbage()
will do this if the JS objects wrapping WasmMemory
are dead.

This patch also moves the increment of the allocatedFastMemories
integer to be thread safe.

  • wasm/WasmMemory.cpp:

(JSC::Wasm::tryGetFastMemory):

3:56 PM Changeset in webkit [214017] by dino@apple.com
  • 10 edits
    1 add in trunk/Source/WebCore

Make a base class for WebGL and WebGPU contexts
​https://bugs.webkit.org/show_bug.cgi?id=169651
<rdar://problem/31053489>

Reviewed by Simon Fraser.

Add a new pure virtual base class, GPUBasedCanvasRenderingContext, that
will be used by WebGL and WebGPU rendering contexts. This allows us
to avoid some code duplication, since many places treat the two
as the same.

Also rename is3d() -> isWebGL() and isGPU() -> isWebGPU().

  • WebCore.xcodeproj/project.pbxproj: New file.
  • html/HTMLCanvasElement.cpp:

(WebCore::HTMLCanvasElement::getContextWebGL):
(WebCore::HTMLCanvasElement::getContextWebGPU):
(WebCore::HTMLCanvasElement::reset):
(WebCore::HTMLCanvasElement::paint):
(WebCore::HTMLCanvasElement::isGPUBased):
(WebCore::HTMLCanvasElement::getImageData):
(WebCore::HTMLCanvasElement::isGPU): Deleted.
(WebCore::HTMLCanvasElement::is3D): Deleted.

  • html/HTMLCanvasElement.h:
  • html/canvas/CanvasRenderingContext.h:

(WebCore::CanvasRenderingContext::isWebGL):
(WebCore::CanvasRenderingContext::isWebGPU):
(WebCore::CanvasRenderingContext::isGPUBased):
(WebCore::CanvasRenderingContext::is3d): Deleted.
(WebCore::CanvasRenderingContext::isGPU): Deleted.

  • html/canvas/GPUBasedCanvasRenderingContext.h: Added.

(WebCore::GPUBasedCanvasRenderingContext::GPUBasedCanvasRenderingContext):

  • html/canvas/WebGLRenderingContextBase.cpp:

(WebCore::WebGLRenderingContextBase::WebGLRenderingContextBase):

  • html/canvas/WebGLRenderingContextBase.h:
  • html/canvas/WebGPURenderingContext.cpp:

(WebCore::WebGPURenderingContext::WebGPURenderingContext):

  • html/canvas/WebGPURenderingContext.h:
  • rendering/RenderLayerBacking.cpp:

(WebCore::canvasCompositingStrategy):

3:49 PM Changeset in webkit [214016] by mark.lam@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Fix exception scope verification failures in jsc.cpp.
​https://bugs.webkit.org/show_bug.cgi?id=164968

Reviewed by Saam Barati.

  • jsc.cpp:

(WTF::CustomGetter::customGetter):

(GlobalObject::moduleLoaderResolve):
(GlobalObject::moduleLoaderFetch):

  • The only way modules would throw an exception is if we encounter an OutOfMemory error. This should be extremely rare. At this point, I don't think it's worth doing the dance to propagate the exception when this happens. Instead, we'll simply do a RELEASE_ASSERT that we don't see any exceptions here.

(functionRun):
(functionRunString):
(functionLoadModule):
(functionCheckModuleSyntax):
(box):
(dumpException):
(runWithScripts):

3:46 PM Changeset in webkit [214015] by matthew_hanson@apple.com
  • 1 copy in tags/Safari-604.1.30.4.5

Tag Safari-604.1.30.4.5.

3:44 PM Changeset in webkit [214014] by dbates@webkit.org
  • 6 edits in trunk/Source/WebCore

Iteratively dispatch DOM events after restoring a cached page
​https://bugs.webkit.org/show_bug.cgi?id=169703
<rdar://problem/31075903>

Reviewed by Brady Eidson.

Make dispatching of DOM events when restoring a page from the page cache symmetric with
dispatching of events when saving a page to the page cache.

  • history/CachedFrame.cpp:

(WebCore::CachedFrameBase::restore): Move code to dispatch events from here to FrameLoader::didRestoreFromCachedPage().

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::commitProvisionalLoad): Ensure that no DOM events are dispatched during
restoration of a cached page. Call didRestoreFromCachedPage() after restoring the page to
dispatch DOM events on the restored frames.
(WebCore::FrameLoader::willRestoreFromCachedPage): Renamed; formerly named prepareForCachedPageRestore().
(WebCore::FrameLoader::didRestoreFromCachedPage): Added.
(WebCore::FrameLoader::prepareForCachedPageRestore): Renamed to willRestoreFromCachedPage().

  • loader/FrameLoader.h:
  • page/FrameTree.cpp:

(WebCore::FrameTree::traverseNextInPostOrderWithWrap): Returns the next Frame* in a post-order
traversal of the frame tree optionally wrapping around to the deepest first child in the tree.
(WebCore::FrameTree::deepFirstChild): Added.

  • page/FrameTree.h:
3:43 PM Changeset in webkit [214013] by matthew_hanson@apple.com
  • 2 edits in branches/safari-603.1.30.4-branch/Source/WebCore

Merge r213847. rdar://problem/30983702

3:43 PM Changeset in webkit [214012] by matthew_hanson@apple.com
  • 3 edits in branches/safari-603.1.30.4-branch/Source/WebKit/win

Merge r213737. rdar://problem/30983702

3:29 PM Changeset in webkit [214011] by webkit@devinrousso.com
  • 3 edits
    4 adds in trunk/Source/WebInspectorUI

Web Inspector: Add icons for SVG Image cluster path components
​https://bugs.webkit.org/show_bug.cgi?id=169687

Reviewed by Joseph Pecoraro.

  • UserInterface/Images/Image.svg: Added.
  • UserInterface/Images/Source.svg: Added.
  • UserInterface/Images/gtk/Image.svg: Added.
  • UserInterface/Images/gtk/Source.svg: Added.
  • UserInterface/Views/PathComponentIcons.css:

(.image-icon .icon):
(.source-icon .icon):

  • UserInterface/Views/SVGImageResourceClusterContentView.js:

(WebInspector.SVGImageResourceClusterContentView):

3:09 PM Changeset in webkit [214010] by hyatt@apple.com
  • 10 edits
    2 adds in trunk

Positioned SVG not sized correctly
​https://bugs.webkit.org/show_bug.cgi?id=169693
<rdar://problem/30996893>

Reviewed by Zalan Bujtas.

Source/WebCore:

Test: svg/in-html/rect-positioned.html

Change computeReplacedLogicalHeight to take an estimatedUsedWidth. This
value is used instead of the available logical width to resolve replaced
elements without intrinsic sizes but with aspect ratios set.

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::computeReplacedLogicalHeight):

  • rendering/RenderBox.h:
  • rendering/RenderReplaced.cpp:

(WebCore::RenderReplaced::computeConstrainedLogicalWidth):
(WebCore::RenderReplaced::computeReplacedLogicalWidth):
(WebCore::RenderReplaced::computeReplacedLogicalHeight):

  • rendering/RenderReplaced.h:
  • rendering/RenderVideo.cpp:

(WebCore::RenderVideo::computeReplacedLogicalHeight): Deleted.

  • rendering/RenderVideo.h:
  • rendering/svg/RenderSVGRoot.cpp:

(WebCore::RenderSVGRoot::computeReplacedLogicalWidth):
(WebCore::RenderSVGRoot::computeReplacedLogicalHeight):

  • rendering/svg/RenderSVGRoot.h:

LayoutTests:

  • svg/in-html/rect-positioned-expected.html: Added.
  • svg/in-html/rect-positioned.html: Added.
3:04 PM Changeset in webkit [214009] by webkit@devinrousso.com
  • 2 edits in trunk/Source/WebInspectorUI

Web Inspector: RTL: flip Memory timelines
​https://bugs.webkit.org/show_bug.cgi?id=169694

Reviewed by Brian Burg.

  • UserInterface/Views/MemoryCategoryView.css:

(body[dir=rtl] .memory-category-view > .graph):

2:59 PM Changeset in webkit [214008] by rniwa@webkit.org
  • 9 edits
    1 add in trunk/Websites/perf.webkit.org

In-browser and node.js implementations of RemoteAPI should share some code
​https://bugs.webkit.org/show_bug.cgi?id=169695

Rubber-stamped by Antti Koivisto.

Extracted CommonRemoteAPI out of RemoteAPI implementations for node.js and browser.

  • public/shared/common-remote.js: Added.

(CommonRemoteAPI): Added.
(CommonRemoteAPI.prototype.postJSON): Extracted from RemoteAPI.
(CommonRemoteAPI.prototype.postJSONWithStatus): Ditto.
(CommonRemoteAPI.prototype.getJSON): Ditto.
(CommonRemoteAPI.prototype.getJSONWithStatus): Ditto.
(CommonRemoteAPI.prototype.sendHttpRequest): Added. Needs to implemented by a subclass.
(CommonRemoteAPI.prototype._asJSON): Added.
(CommonRemoteAPI.prototype._checkStatus): Added.

  • public/v3/index.html: Include common-remote.js.
  • public/v3/privileged-api.js:

(PrivilegedAPI): Use class now that we don't include data.js.
(PrivilegedAPI.sendRequest): Modernized the code.
(PrivilegedAPI.requestCSRFToken): Ditto.

  • public/v3/remote.js:

(BrowserRemoteAPI): Renamed from RemoteAPI. window.RemoteAPI is now an instance of this class.
(BrowserRemoteAPI.prototype.sendHttpRequest): Moved from RemoteAPI.sendHttpRequest.
(BrowserRemoteAPI.prototype.sendHttpRequest):

  • server-tests/privileged-api-create-analysis-task-tests.js: Updated tests since NodeJSRemoteAPI

now throws the JSON status as an error to be consistent with BrowserRemoteAPI.

  • server-tests/privileged-api-create-test-group-tests.js: Ditto.
  • server-tests/privileged-api-upate-run-status.js: Ditto.
  • tools/js/buildbot-triggerable.js:

(BuildbotTriggerable.prototype.syncOnce): Just use postJSONWithStatus instead of manually
checking the status.

  • tools/js/remote.js:

(NodeRemoteAPI): Renamed from RemoteAPI. Still exported as RemoteAPI.
(NodeRemoteAPI.prototype.constructor):
(NodeRemoteAPI.prototype.sendHttpRequest): Modernized the code.

2:47 PM Changeset in webkit [214007] by Ryan Haddad
  • 2 edits in trunk/LayoutTests

Clean up TestExpectations for some WPT LayoutTests.

Unreviewed test gardening.

2:31 PM Changeset in webkit [214006] by Chris Dumez
  • 6 edits
    1 add in trunk

Document state (e.g. form data) is lost after a tab is terminated in the background for power reasons
​https://bugs.webkit.org/show_bug.cgi?id=169635
<rdar://problem/31046729>

Reviewed by Andreas Kling.

Source/WebKit2:

Document state (e.g. form data) was lost after a tab was terminated in the background for power
reasons. To address the issue, we now save the document state whenever a page is backgrounded.
This document state automatically gets restored when reloading the page after termination.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::visibilityDidChange):
(WebKit::WebPage::setActivityState):

  • WebProcess/WebPage/WebPage.h:

Tools:

Add API test coverage.

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/Tests/WebKit2/mac/RestoreStateAfterTermination.mm: Added.

(TestWebKitAPI::runJavaScriptAlert):
(TestWebKitAPI::didFinishLoad):
(TestWebKitAPI::didCrash):
(TestWebKitAPI::TEST):

  • TestWebKitAPI/Tests/WebKit2/simple-form.html:
1:19 PM Changeset in webkit [214005] by mark.lam@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Fix missing exception checks in Interpreter.cpp.
​https://bugs.webkit.org/show_bug.cgi?id=164964

Reviewed by Saam Barati.

  • interpreter/Interpreter.cpp:

(JSC::eval):
(JSC::sizeOfVarargs):
(JSC::sizeFrameForVarargs):
(JSC::Interpreter::executeProgram):
(JSC::Interpreter::executeCall):
(JSC::Interpreter::executeConstruct):
(JSC::Interpreter::prepareForRepeatCall):
(JSC::Interpreter::execute):

1:00 PM Changeset in webkit [214004] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebInspectorUI

JSContext Inspector: NetworkAgent may be unavailable
​https://bugs.webkit.org/show_bug.cgi?id=169691

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2017-03-15
Reviewed by Brian Burg.

  • UserInterface/Views/ResourceDetailsSidebarPanel.js:

(WebInspector.ResourceDetailsSidebarPanel.prototype._refreshRequestAndResponse):
Check that NetworkAgent even exists. An augmented JSContext may have Resources
without having a NetworkAgent.

12:56 PM Changeset in webkit [214003] by Wenson Hsieh
  • 2 edits in trunk/Source/WebKit2

WebContent crash due to bad variant access in WebKit: WebKit::WebPage::expandedRangeFromHandle
​https://bugs.webkit.org/show_bug.cgi?id=169657
<rdar://problem/30631070>

Reviewed by Tim Horton.

In WebPageIOS.mm, the call to unionDOMRanges from WebPage::expandedRangeFromHandle invokes
Range::compareBoundaryPoints, assuming that the return value is not an exception, and then attempts to perform
integer comparison on the result. This is one speculative cause of the web content crash in the radar.

There isn't a known way to reproduce this crash.

  • WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::unionDOMRanges):

12:35 PM Changeset in webkit [214002] by Nikita Vasilyev
  • 2 edits in trunk/Source/WebInspectorUI

REGRESSION (r213622): Web Inspector: DataGrid headers should NOT be centered
​https://bugs.webkit.org/show_bug.cgi?id=169645
<rdar://problem/31051520>

Reviewed by Matt Baker.

  • UserInterface/Views/DataGrid.css:

(.data-grid th):
(body[dir=ltr] .data-grid th):
(body[dir=rtl] .data-grid th):

12:34 PM Changeset in webkit [214001] by timothy_horton@apple.com
  • 7 edits
    3 deletes in trunk/Source/WebKit2

Un-deprecate the original PDFPlugin
​https://bugs.webkit.org/show_bug.cgi?id=169655

Reviewed by Anders Carlsson.

  • Shared/mac/PDFKitImports.h:
  • WebKit2.xcodeproj/project.pbxproj:
  • WebProcess/Plugins/PDF/DeprecatedPDFLayerControllerSPI.h: Removed.
  • WebProcess/Plugins/PDF/DeprecatedPDFPlugin.h: Removed.
  • WebProcess/Plugins/PDF/DeprecatedPDFPlugin.mm: Removed.
  • WebProcess/Plugins/PDF/PDFLayerControllerSPI.h:
  • WebProcess/Plugins/PDF/PDFPlugin.h:
  • WebProcess/Plugins/PDF/PDFPlugin.mm:
  • WebProcess/Plugins/PDF/PDFPluginAnnotation.mm:

The transition to the non-deprecated PDFPlugin never happened,
and we have a very different plan now.

12:34 PM Changeset in webkit [214000] by rniwa@webkit.org
  • 6 edits in trunk/Websites/perf.webkit.org

Fix server tests after r213998 and r213969
​https://bugs.webkit.org/show_bug.cgi?id=169690

Reviewed by Antti Koivisto.

Fixed the existing server tests.

  • public/v3/models/analysis-task.js:

(AnalysisTask.prototype._updateRemoteState): Use the relative path from the root so that it works inside tests.
(AnalysisTask.prototype.associateBug): Ditto.
(AnalysisTask.prototype.dissociateBug): Ditto.
(AnalysisTask.prototype.associateCommit): Ditto.
(AnalysisTask.prototype.dissociateCommit): Ditto.
(AnalysisTask._fetchSubset): Ditto.
(AnalysisTask.fetchAll): Ditto.

  • public/v3/models/test-group.js:

(TestGroup.prototype.updateName): Ditto.
(TestGroup.prototype.updateHiddenFlag): Ditto.
(TestGroup.createAndRefetchTestGroups): Ditto.
(TestGroup.cachedFetch): Ditto.

  • server-tests/api-manifest.js: Reverted an inadvertant change in r213969.
  • tools/js/database.js:

(tableToPrefixMap): Added analysis_strategies.

  • unit-tests/analysis-task-tests.js: Updated expectations per changes to AnalysisTask.
12:15 PM Changeset in webkit [213999] by webkit@devinrousso.com
  • 4 edits
    1 add in trunk/Source/WebInspectorUI

Web Inspector: SVG image content view should toggle between image and source
​https://bugs.webkit.org/show_bug.cgi?id=16079

Reviewed by Joseph Pecoraro.

  • Localizations/en.lproj/localizedStrings.js:
  • UserInterface/Main.html:
  • UserInterface/Views/ResourceClusterContentView.js:

(WebInspector.ResourceClusterContentView.prototype.get responseContentView):
Show the SVG cluster content view if the MIME type matches an SVG file.

  • UserInterface/Views/SVGImageResourceClusterContentView.js: Added.

(WebInspector.SVGImageResourceClusterContentView):
(WebInspector.SVGImageResourceClusterContentView.prototype.get resource):
(WebInspector.SVGImageResourceClusterContentView.prototype.get selectionPathComponents):
(WebInspector.SVGImageResourceClusterContentView.prototype.shown):
(WebInspector.SVGImageResourceClusterContentView.prototype.closed):
(WebInspector.SVGImageResourceClusterContentView.prototype.saveToCookie):
(WebInspector.SVGImageResourceClusterContentView.prototype.restoreFromCookie):
(WebInspector.SVGImageResourceClusterContentView.prototype._pathComponentForContentView):
(WebInspector.SVGImageResourceClusterContentView.prototype._identifierForContentView):
(WebInspector.SVGImageResourceClusterContentView.prototype._showContentViewForIdentifier):
(WebInspector.SVGImageResourceClusterContentView.prototype._pathComponentSelected):

12:15 PM Changeset in webkit [213998] by rniwa@webkit.org
  • 5 edits
    2 adds in trunk/Websites/perf.webkit.org

Add tests for privileged-api/create-analysis-task and privileged-api/create-test-group
​https://bugs.webkit.org/show_bug.cgi?id=169688

Rubber-stamped by Antti Koivisto.

Added tests for privileged-api/create-analysis-task and privileged-api/create-test-group, and fixed newly found bugs.

  • public/privileged-api/create-analysis-task.php:

(main): Fixed the bug that we were not explicitly checking whether start_run and end_run were integers or not.
Also return InvalidTimeRange when start and end times are identical as that makes no sense for an analysis task.

  • public/privileged-api/create-test-group.php:

(main): Fixed a bug that we were not explicitly checking task and repetitionCount to be an integer.
(ensure_commit_sets): Fixed the bug that the number of commit sets weren't checked.

  • server-tests/privileged-api-create-analysis-task-tests.js: Added.
  • server-tests/privileged-api-create-test-group-tests.js: Added.
  • server-tests/resources/common-operations.js:

(prepareServerTest): Increase the timeout from 1s to 5s.

  • server-tests/resources/mock-data.js:

(MockData.addMockData): Use a higher database ID of 20 for a mock build_slave to avoid a conflict with auto-generated IDs.

12:07 PM Changeset in webkit [213997] by webkit@devinrousso.com
  • 5 edits in trunk/Source/WebInspectorUI

Web Inspector: RTL: add support for Timeline ruler selections/movement
​https://bugs.webkit.org/show_bug.cgi?id=169588

Reviewed by Matt Baker.

  • UserInterface/Views/TimelineOverview.css:

(body[dir=ltr] .timeline-overview.frames > .timeline-ruler:not(.both-handles-clamped) > .selection-handle.right):
(body[dir=rtl] .timeline-overview.frames > .timeline-ruler:not(.both-handles-clamped) > .selection-handle.left):
(body[dir=ltr] .timeline-overview.frames > .timeline-ruler:not(.both-handles-clamped) > .shaded-area.right):
(body[dir=rtl] .timeline-overview.frames > .timeline-ruler:not(.both-handles-clamped) > .shaded-area.left):
(.timeline-overview.frames > .timeline-ruler:not(.both-handles-clamped) > .selection-handle.right): Deleted.
(.timeline-overview.frames > .timeline-ruler:not(.both-handles-clamped) > .shaded-area.right): Deleted.
Fixes alignment of selection handles when in Frames view.

  • UserInterface/Views/TimelineOverview.js:

(WebInspector.TimelineOverview.prototype._handleScrollEvent):
Support horizontal scrolling in timelines by treating the current scroll value as negative
when in RTL, flipping the scroll direction.

  • UserInterface/Views/TimelineRuler.css:

(body[dir=ltr] .timeline-ruler > .selection-handle.left):
(body[dir=rtl] .timeline-ruler > .selection-handle.left):
(body[dir=ltr] .timeline-ruler > .selection-handle.right):
(body[dir=rtl] .timeline-ruler > .selection-handle.right):
(body[dir=ltr] .timeline-ruler > .shaded-area.left):
(body[dir=rtl] .timeline-ruler > .shaded-area.left):
(body[dir=ltr] .timeline-ruler > .shaded-area.right):
(body[dir=rtl] .timeline-ruler > .shaded-area.right):
(.timeline-ruler > .selection-handle.left): Deleted.
(.timeline-ruler > .selection-handle.right): Deleted.
(.timeline-ruler > .shaded-area.left): Deleted.
(.timeline-ruler > .shaded-area.right): Deleted.
Flip the position alignment of the selection handles and shaded areas when in RTL.

  • UserInterface/Views/TimelineRuler.js:

(WebInspector.TimelineRuler.prototype._handleMouseDown):
(WebInspector.TimelineRuler.prototype._handleMouseMove):
(WebInspector.TimelineRuler.prototype._handleMouseUp):
(WebInspector.TimelineRuler.prototype._handleSelectionHandleMouseDown):
(WebInspector.TimelineRuler.prototype._handleSelectionHandleMouseMove):
Treat the current mouse position (event.pageX) as a negative value when in RTL, meaning that
the delta movement from the starting position is flipped.

11:51 AM Changeset in webkit [213996] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

[Modern Media Controls] Using the arrow keys to navigate in the tracks menu also scrolls the page
​https://bugs.webkit.org/show_bug.cgi?id=169671
<rdar://problem/31060091>

Patch by Antoine Quint <Antoine Quint> on 2017-03-15
Reviewed by Eric Carlson.

Source/WebCore:

We need to call preventDefault() when handling a "keydown" event that we recognize.

Test: media/modern-media-controls/tracks-panel/tracks-panel-prevent-default-on-keydown.html

  • Modules/modern-media-controls/controls/tracks-panel.js:

(TracksPanel.prototype._handleKeydown):

LayoutTests:

Add a test that checks that preventDefault() is called on "keydown" events that we know to handle.

  • media/modern-media-controls/tracks-panel/tracks-panel-prevent-default-on-keydown-expected.txt: Added.
  • media/modern-media-controls/tracks-panel/tracks-panel-prevent-default-on-keydown.html: Added.
11:26 AM Changeset in webkit [213995] by Jonathan Bedard
  • 1 edit
    1 delete in trunk/LayoutTests

Remove TestExpectations.orig after r213882

Unreviewed, removing file committed by mistake.

11:21 AM Changeset in webkit [213994] by commit-queue@webkit.org
  • 6 edits in trunk

[Modern Media Controls] Tracks menu overlaps controls bar in fullscreen
​https://bugs.webkit.org/show_bug.cgi?id=169670
<rdar://problem/31060086>
Source/WebCore:

Patch by Antoine Quint <Antoine Quint> on 2017-03-15
Reviewed by Eric Carlson.

It used to be that the top of the tracks button was the same as the top of the controls
bar, but that changed when we fixed ​https://bugs.webkit.org/show_bug.cgi?id=169412. We
now use the top of the controls bar to computed the y-position for the tracks panel.

We are not adding a new test, instead we're unflaking a test that started failing
reliably once we fixed ​https://bugs.webkit.org/show_bug.cgi?id=169412.

  • Modules/modern-media-controls/controls/macos-media-controls.js:

(MacOSMediaControls.prototype.showTracksPanel):

LayoutTests:

Patch by Antoine Quint <Antoine Quint> on 2017-03-15
Reviewed by Eric Carlson.

Unflake a test that checks the tracks panel position in fullscreen.

  • media/modern-media-controls/tracks-support/tracks-support-show-panel-fullscreen-expected.txt:
  • media/modern-media-controls/tracks-support/tracks-support-show-panel-fullscreen.html:
  • platform/mac/TestExpectations:
11:15 AM Changeset in webkit [213993] by rniwa@webkit.org
  • 5 edits in trunk/Websites/perf.webkit.org

Make unit tests return a promise instead of manually calling done
​https://bugs.webkit.org/show_bug.cgi?id=169663

Reviewed by Antti Koivisto.

Make the existing unit tests always reutrn a promise instead of manually calling "done" callback as done
in r213969. The promise tests are a lot more stable and less error prone.

Also use MockRemoteAPI.waitForRequest() instead of chaining two resolved promises where appropriate.

  • unit-tests/analysis-task-tests.js:
  • unit-tests/buildbot-syncer-tests.js:
  • unit-tests/checkconfig.js:
  • unit-tests/privileged-api-tests.js:
11:15 AM Changeset in webkit [213992] by jonlee@apple.com
  • 11 edits
    8 adds in trunk/Source/WebCore

Clean up RTCPeerConnection IDL
​https://bugs.webkit.org/show_bug.cgi?id=169660

Reviewed by Youenn Fablet.

  • Modules/mediastream/RTCPeerConnection.cpp:

(WebCore::RTCPeerConnection::addTransceiver): Refactor to use RTCRtpTransceiverInit.
(WebCore::RTCPeerConnection::completeAddTransceiver):

  • Modules/mediastream/RTCPeerConnection.h: Remove redundant definitions.
  • Modules/mediastream/RTCPeerConnection.idl: Using 13 March 2017 Editor's Draft of

WebRTC spec. Move RTCOfferAnswerOptions out to separate IDLs. Keep RTCDataChannelInit and
RTCRtpTransceiverInit since they appear to be used only in RTCPeerConnection.

Reorder the properties, functions, and events based on their appearance in the spec.

Legacy MediaStream calls are placed at the end. I tried to use "partial interface" in the
same file, but in the end nothing was generated, so everything is contained in one interface
block.

  • Modules/mediastream/RTCEnums.h: Added. This will be an all-in-one header to hold the

enums.

Move RTCAnswerOptions, RTCOfferAnswerOptions, RTCOfferOptions, RTCRtpTransceiverDirection
out to their own IDL's.

  • CMakeLists.txt:
  • DerivedSources.make:
  • Modules/mediastream/RTCAnswerOptions.h: Added.
  • Modules/mediastream/RTCAnswerOptions.idl: Added.
  • Modules/mediastream/RTCOfferAnswerOptions.h:
  • Modules/mediastream/RTCOfferAnswerOptions.idl: Added.
  • Modules/mediastream/RTCOfferOptions.h: Added. Remove |offerToReceiveVideo| and

|offerToReceiveAudio|, which are not used.

  • Modules/mediastream/RTCOfferOptions.idl: Added.
  • Modules/mediastream/RTCRtpTransceiverDirection.h: Added.
  • Modules/mediastream/RTCRtpTransceiverDirection.idl: Added. Use a typedef for

RTCRtpTransceiverDirection to prevent the code generator from prefixing RTCRtpTransceiver.

  • Modules/mediastream/RTCRtpTransceiver.idl: Move RTCRtpTransceiverDirection.
  • WebCore.xcodeproj/project.pbxproj: Add IDLs and derived sources. Remove unused

HTMLMediaElementMediaStream.h. Reorder.

Refactor.

  • Modules/mediastream/RTCRtpTransceiver.h: Use RTCRtpTransceiverDirection.
  • Modules/mediastream/MediaEndpointPeerConnection.cpp:
11:15 AM Changeset in webkit [213991] by Joseph Pecoraro
  • 4 edits in trunk/Source/WebInspectorUI

Web Inspector: REGRESSION: Elements Tab > Node Details Sidebar > Properties Section is spammed with TypeErrors
​https://bugs.webkit.org/show_bug.cgi?id=153911
<rdar://problem/24520098>

Reviewed by Devin Rousso.

  • UserInterface/Views/DOMNodeDetailsSidebarPanel.js:

(WebInspector.DOMNodeDetailsSidebarPanel.prototype._refreshProperties.nodeResolved.inspectedPage_node_collectPrototypes):
(WebInspector.DOMNodeDetailsSidebarPanel.prototype._refreshProperties.nodeResolved):
Update due to naming conventions for code that evalutes in the inspected page.

(WebInspector.DOMNodeDetailsSidebarPanel.prototype._refreshProperties.fillSection):
(WebInspector.DOMNodeDetailsSidebarPanel.prototype._refreshProperties):
Create a more complete ObjectTreeView for the different sections.

  • UserInterface/Views/ObjectTreePropertyTreeElement.js:

(WebInspector.ObjectTreePropertyTreeElement.prototype._updateChildren):
PureAPI behaves the same as ClassAPI and just shows own properties.

  • UserInterface/Views/ObjectTreeView.js:

(WebInspector.ObjectTreeView.prototype.showOnlyProperties):
In only properties mode don't show the Prototype expander at the end.

(WebInspector.ObjectTreeView.prototype.setPrototypeNameOverride):
Allow a prototype name override at the top level. This will allow clients
to specify that the object at the top level is a Prototype object, so that
ObjectTreePropertyTreeElements can infer the right NativeFunctionParameter
information knowing that those properties are on a particular prototype.

(WebInspector.ObjectTreeView.prototype.update):
For the PureAPI use getOwnProperties instead of getDisplayableProperties.
This avoids the special handling we have for DOM native properties which
we bubble up to the top as value descriptors even though they are actually
accessor descriptors on prototypes.

(WebInspector.ObjectTreeView.prototype._updateProperties):
Pass the prototype name override onward for object properties.

11:03 AM Changeset in webkit [213990] by zandobersek@gmail.com
  • 2 edits in trunk/Source/WebCore

[GTK] Initialize m_button, m_clickCount members in PlatformMouseEvent constructors
​https://bugs.webkit.org/show_bug.cgi?id=169666

Reviewed by Michael Catanzaro.

Initialize the m_button and m_clickCount class members in the GTK+-specific
implementation of PlatformMouseEvent constructors to NoButton and 0,
respectively. The constructors expect to operate on passed-in GTK+ events
that will be able to initialize those two members to some valid values, but
this is not guaranteed.

  • platform/gtk/PlatformMouseEventGtk.cpp:

(WebCore::PlatformMouseEvent::PlatformMouseEvent):

11:02 AM Changeset in webkit [213989] by zandobersek@gmail.com
  • 5 edits in trunk/Source/WebCore

[TexMap] Add missing class member initializations
​https://bugs.webkit.org/show_bug.cgi?id=169665

Reviewed by Michael Catanzaro.

Zero-initialize the members in various TextureMapper classes
that are missing the proper initialization, as reported by
the Coverity tool.

  • platform/graphics/texmap/BitmapTexturePool.h:
  • platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.h:
  • platform/graphics/texmap/coordinated/CoordinatedGraphicsState.h:

(WebCore::CoordinatedGraphicsLayerState::CoordinatedGraphicsLayerState):

  • platform/graphics/texmap/coordinated/SurfaceUpdateInfo.h:
10:59 AM Changeset in webkit [213988] by achristensen@apple.com
  • 14 edits in trunk

Compiled content extensions should include the JSON source
​https://bugs.webkit.org/show_bug.cgi?id=169643

Reviewed by Geoffrey Garen.

Source/WebCore:

Serializing the JSON string from which a content extension was compiled
to disk with the compiled content extension will allow us to validate content
extensions and automatically migrate older content extensions to new versions.
It less than doubles the size of the compiled content extension on disk, and when
interpreting the bytecode that memory is never read, so it doesn't increase our
dirty memory usage.

Covered by new API tests.

  • contentextensions/ContentExtensionCompiler.cpp:

(WebCore::ContentExtensions::compileRuleList):

  • contentextensions/ContentExtensionCompiler.h:

Source/WebKit2:

  • UIProcess/API/APIContentExtensionStore.cpp:

(API::ContentExtensionStore::ContentExtensionStore):
(API::ContentExtensionMetaData::fileSize):
(API::encodeContentExtensionMetaData):
(API::decodeContentExtensionMetaData):
(API::compiledToFile):
(API::createExtension):
(API::ContentExtensionStore::getContentExtensionSource):

  • UIProcess/API/APIContentExtensionStore.h:
  • UIProcess/API/Cocoa/WKContentExtensionStore.mm:

(toWKErrorCode):
(-[WKContentExtensionStore lookupContentExtensionForIdentifier:completionHandler:]):
(-[WKContentExtensionStore removeContentExtensionForIdentifier:completionHandler:]):
(-[WKContentExtensionStore _getContentExtensionSourceForIdentifier:completionHandler:]):

  • UIProcess/API/Cocoa/WKContentExtensionStorePrivate.h:
  • UIProcess/API/Cocoa/WKError.h:
  • UIProcess/API/Cocoa/_WKUserContentExtensionStore.h:
  • UIProcess/API/Cocoa/_WKUserContentExtensionStore.mm:

(toUserContentExtensionStoreError):
(-[_WKUserContentExtensionStore compileContentExtensionForIdentifier:encodedContentExtension:completionHandler:]):
(-[_WKUserContentExtensionStore lookupContentExtensionForIdentifier:completionHandler:]):
(-[_WKUserContentExtensionStore removeContentExtensionForIdentifier:completionHandler:]):

Tools:

  • TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
  • TestWebKitAPI/Tests/WebKit2Cocoa/WKUserContentExtensionStore.mm:

(TEST_F):

10:40 AM Changeset in webkit [213987] by commit-queue@webkit.org
  • 3 edits
    4 adds in trunk

[Modern Media Controls] Captions do not default to Auto when language is changed
​https://bugs.webkit.org/show_bug.cgi?id=169675
<rdar://problem/30423369>

Patch by Antoine Quint <Antoine Quint> on 2017-03-15
Reviewed by Eric Carlson.

Source/WebCore:

Ensure we correctly mark the Off and Auto items as selected when we are using the
Off and Auto tracks.

Tests: media/modern-media-controls/tracks-support/tracks-support-auto-text-track.html

media/modern-media-controls/tracks-support/tracks-support-off-text-track.html

  • Modules/modern-media-controls/media/tracks-support.js:

(TracksSupport.prototype.tracksPanelIsTrackInSectionSelected):
(TracksSupport.prototype.tracksPanelSelectionDidChange):

LayoutTests:

Add new tests that check the cases where the expected selected track should be "Off" or "Auto".

  • media/modern-media-controls/tracks-support/tracks-support-auto-text-track-expected.txt: Added.
  • media/modern-media-controls/tracks-support/tracks-support-auto-text-track.html: Added.
  • media/modern-media-controls/tracks-support/tracks-support-off-text-track-expected.txt: Added.
  • media/modern-media-controls/tracks-support/tracks-support-off-text-track.html: Added.
10:21 AM Changeset in webkit [213986] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

Use git's -C flag when possible in VCSUtils.pm
​https://bugs.webkit.org/show_bug.cgi?id=169003

Patch by Kocsen Chung <Kocsen Chung> on 2017-03-15
Reviewed by Sam Weinig.

Use the git -C flag where appropriate to perform the
operation on a target directory and avoid unnecessary logic
to cd in and out of the target directory.

  • Scripts/VCSUtils.pm:

(isGitDirectory):
(isGitSVNDirectory):
(svnRevisionForDirectory):
(svnInfoForPath):
For all four subroutines, use git's -C flag and strip cd logic.

10:06 AM Changeset in webkit [213985] by Ryan Haddad
  • 10 edits
    1 delete in trunk/Source/WebCore

Unreviewed, rolling out r213977.

This change broke the Windows build.

Reverted changeset:

"Make a base class for WebGL and WebGPU contexts"
​https://bugs.webkit.org/show_bug.cgi?id=169651
​http://trac.webkit.org/changeset/213977

10:04 AM Changeset in webkit [213984] by Ryan Haddad
  • 2 edits in trunk/LayoutTests

Mark http/tests/media/modern-media-controls/time-labels-support/long-time.html as flaky on mac-wk1.
​https://bugs.webkit.org/show_bug.cgi?id=169677

Unreviewed test gardening.

  • platform/mac-wk1/TestExpectations:
9:38 AM Changeset in webkit [213983] by commit-queue@webkit.org
  • 10 edits
    4 adds in trunk

run-webkit-tests is always creating mock libwebrtc tracks
​https://bugs.webkit.org/show_bug.cgi?id=169658

Patch by Youenn Fablet <​youenn@apple.com> on 2017-03-15
Reviewed by Alex Christensen.

Source/WebCore:

Tests: webrtc/peer-connection-audio-mute.html

webrtc/video-mute.html

Creating real libwebrtc av tracks in case of RealTwoPeerConnections mock factory.

  • testing/MockLibWebRTCPeerConnection.cpp:

(WebCore::MockLibWebRTCPeerConnectionFactory::CreateVideoTrack):
(WebCore::MockLibWebRTCPeerConnectionFactory::CreateAudioTrack):

  • testing/MockLibWebRTCPeerConnection.h:

LayoutTests:

  • TestExpectations:
  • webrtc/audio-peer-connection-webaudio.html:
  • webrtc/peer-connection-audio-mute-expected.txt: Added.
  • webrtc/peer-connection-audio-mute.html: Added.
  • webrtc/routines.js:

(analyseAudio):

  • webrtc/video-expected.txt:
  • webrtc/video-mute-expected.txt: Added.
  • webrtc/video-mute.html: Added.
  • webrtc/video.html:
9:35 AM Changeset in webkit [213982] by commit-queue@webkit.org
  • 5 edits in trunk

Preventive clean-up: ensure RTCPeerConnection stays valid when calling postTask
​https://bugs.webkit.org/show_bug.cgi?id=169661

Patch by Youenn Fablet <​youenn@apple.com> on 2017-03-15
Reviewed by Alex Christensen.

Source/WebCore:

Protecting the RTCPeerConnection object when calling postTask since it might get collected between the task post
and task run. Also do not send negotiationNeeded event if RTCPeerConnection is closed (covered by added test).

  • Modules/mediastream/RTCPeerConnection.cpp:

(WebCore::RTCPeerConnection::updateIceGatheringState):
(WebCore::RTCPeerConnection::updateIceConnectionState):
(WebCore::RTCPeerConnection::scheduleNegotiationNeededEvent):

LayoutTests:

  • webrtc/negotiatedneeded-event-addStream-expected.txt:
  • webrtc/negotiatedneeded-event-addStream.html:
8:58 AM Changeset in webkit [213981] by Ryan Haddad
  • 2 edits in trunk/LayoutTests

Mark media/modern-media-controls/volume-down-support/volume-down-support.html as flaky.
​https://bugs.webkit.org/show_bug.cgi?id=169568

Unreviewed test gardening.

  • platform/mac/TestExpectations:
5:42 AM Changeset in webkit [213980] by commit-queue@webkit.org
  • 7 edits
    2 moves in trunk

[Modern Media Controls] Always use six digits to display time when overall media duration is an hour or more
​https://bugs.webkit.org/show_bug.cgi?id=169668
<rdar://problem/31059699>

Patch by Antoine Quint <Antoine Quint> on 2017-03-15
Reviewed by Dean Jackson.

Source/WebCore:

Always use six digits to display times when the overall media duration is an hour or more. This
ensures that we don't display too much white space around labels when we know we will eventually
need six digits to display the full time, but the current time to display is under an hour.

Test: media/modern-media-controls/time-control/time-control-use-six-digits-for-time-labels.html

  • Modules/modern-media-controls/controls/time-control.js:

(TimeControl.prototype.get useSixDigitsForTimeLabels):
(TimeControl.prototype.set useSixDigitsForTimeLabels):
(TimeControl.prototype.set width):
(TimeControl.prototype.get isSufficientlyWide):
(TimeControl.prototype._availableWidthHasChanged):
(TimeControl.prototype.get labelsMayDisplayTimesOverAnHour): Deleted.
(TimeControl.prototype.set labelsMayDisplayTimesOverAnHour): Deleted.

  • Modules/modern-media-controls/controls/time-label.js:

(TimeLabel.prototype._formattedTime):

  • Modules/modern-media-controls/media/time-labels-support.js:

(TimeLabelsSupport.prototype.syncControl):
(TimeLabelsSupport):

LayoutTests:

Rebase some tests due to the rename of the labelsMayDisplayTimesOverAnHour property to
useSixDigitsForTimeLabels. We also add an assertion in long-time.html to check that
we currently use six digits to display a time that is under an hour but where the
media duration is over an hour.

  • http/tests/media/modern-media-controls/time-labels-support/long-time-expected.txt:
  • http/tests/media/modern-media-controls/time-labels-support/long-time.html:
  • media/modern-media-controls/time-control/time-control-use-six-digits-for-time-labels-expected.txt: Renamed from LayoutTests/media/modern-media-controls/time-control/time-control-labels-may-display-times-over-an-hour-expected.txt.
  • media/modern-media-controls/time-control/time-control-use-six-digits-for-time-labels.html: Renamed from LayoutTests/media/modern-media-controls/time-control/time-control-labels-may-display-times-over-an-hour.html.
3:19 AM Changeset in webkit [213979] by commit-queue@webkit.org
  • 3 edits in trunk/LayoutTests

[mac-wk1 debug] LayoutTest media/modern-media-controls/airplay-placard/airplay-placard-text-section.html is a flaky timeout
​https://bugs.webkit.org/show_bug.cgi?id=169654
<rdar://problem/31059092>

Patch by Antoine Quint <Antoine Quint> on 2017-03-15
Reviewed by Dean Jackson.

Using an asynchronous assertion to improve reliability.

  • media/modern-media-controls/airplay-placard/airplay-placard-text-section-expected.txt:
  • media/modern-media-controls/airplay-placard/airplay-placard-text-section.html:
2:51 AM Changeset in webkit [213978] by dino@apple.com
  • 12 edits in trunk/Source

Sort Xcode project files
​https://bugs.webkit.org/show_bug.cgi?id=169669

Reviewed by Antoine Quint.

Source/JavaScriptCore:

Source/WebCore:

  • WebCore.xcodeproj/project.pbxproj:

Source/WebCore/PAL:

  • PAL.xcodeproj/project.pbxproj:

Source/WebKit:

  • WebKit.xcodeproj/project.pbxproj:

Source/WebKit2:

  • WebKit2.xcodeproj/project.pbxproj:

Source/WTF:

  • WTF.xcodeproj/project.pbxproj:
2:43 AM Changeset in webkit [213977] by dino@apple.com
  • 10 edits
    1 add in trunk/Source/WebCore

Make a base class for WebGL and WebGPU contexts
​https://bugs.webkit.org/show_bug.cgi?id=169651
<rdar://problem/31053489>

Reviewed by Simon Fraser.

Add a new pure virtual base class, GPUBasedCanvasRenderingContext, that
will be used by WebGL and WebGPU rendering contexts. This allows us
to avoid some code duplication, since many places treat the two
as the same.

Also rename is3d() -> isWebGL() and isGPU() -> isWebGPU().

  • WebCore.xcodeproj/project.pbxproj: New file.
  • html/HTMLCanvasElement.cpp:

(WebCore::HTMLCanvasElement::getContextWebGL):
(WebCore::HTMLCanvasElement::getContextWebGPU):
(WebCore::HTMLCanvasElement::reset):
(WebCore::HTMLCanvasElement::paint):
(WebCore::HTMLCanvasElement::isGPUBased):
(WebCore::HTMLCanvasElement::getImageData):
(WebCore::HTMLCanvasElement::isGPU): Deleted.
(WebCore::HTMLCanvasElement::is3D): Deleted.

  • html/HTMLCanvasElement.h:
  • html/canvas/CanvasRenderingContext.h:

(WebCore::CanvasRenderingContext::isWebGL):
(WebCore::CanvasRenderingContext::isWebGPU):
(WebCore::CanvasRenderingContext::isGPUBased):
(WebCore::CanvasRenderingContext::is3d): Deleted.
(WebCore::CanvasRenderingContext::isGPU): Deleted.

  • html/canvas/GPUBasedCanvasRenderingContext.h: Added.

(WebCore::GPUBasedCanvasRenderingContext::GPUBasedCanvasRenderingContext):

  • html/canvas/WebGLRenderingContextBase.cpp:

(WebCore::WebGLRenderingContextBase::WebGLRenderingContextBase):

  • html/canvas/WebGLRenderingContextBase.h:
  • html/canvas/WebGPURenderingContext.cpp:

(WebCore::WebGPURenderingContext::WebGPURenderingContext):

  • html/canvas/WebGPURenderingContext.h:
  • rendering/RenderLayerBacking.cpp:

(WebCore::canvasCompositingStrategy):

1:35 AM Changeset in webkit [213976] by Dewei Zhu
  • 10 edits
    7 adds in trunk/Websites/perf.webkit.org

Rewrite 'pull-os-versions' script in Javascript to add support for reporting os revisions with sub commits.
​https://bugs.webkit.org/show_bug.cgi?id=169542

Reviewed by Ryosuke Niwa.

Extend '/api/commits/<repository>/last-reported' to accept a range and return last reported commits in given range.
Rewrite 'pull-os-versions' in JavaScript and add unit tests for it.
Instead of writing query manually while searching criteria contains null columns, use the methods provided in 'db.php'.
Add '.gitignore' file to ommit files generated by while running tests/instances locally.

  • .gitignore: Added.
  • public/api/commits.php:
  • public/api/report-commits.php:
  • public/include/commit-log-fetcher.php:
  • public/include/db.php: 'null_columns' of prepare_params should be a reference.
  • public/include/report-processor.php:
  • server-tests/api-commits.js:

(then):

  • server-tests/api-report-commits-tests.js:
  • server-tests/resources/mock-logger.js: Added.

(MockLogger):
(MockLogger.prototype.log):
(MockLogger.prototype.error):

  • server-tests/resources/mock-subprocess.js: Added.

(MockSubprocess.call):
(MockSubprocess.waitingForInvocation):
(MockSubprocess.inject):
(MockSubprocess.reset):

  • server-tests/tools-buildbot-triggerable-tests.js:

(MockLogger): Deleted.
(MockLogger.prototype.log): Deleted.
(MockLogger.prototype.error): Deleted.

  • server-tests/tools-os-build-fetcher-tests.js: Added.

(beforeEach):
(return.waitingForInvocationPromise.then):
(then):
(string_appeared_here.return.waitingForInvocationPromise.then):
(return.addSlaveForReport.emptyReport.then):

  • tools/js/os-build-fetcher.js: Added.

(OSBuildFetcher):
(OSBuildFetcher.prototype._fetchAvailableBuilds):
(OSBuildFetcher.prototype._computeOrder):
(OSBuildFetcher.prototype._commitsForAvailableBuilds.return.this._subprocess.call.then.):
(OSBuildFetcher.prototype._commitsForAvailableBuilds):
(OSBuildFetcher.prototype._addSubCommitsForBuild):
(OSBuildFetcher.prototype._submitCommits):
(OSBuildFetcher.prototype.fetchAndReportNewBuilds):

  • tools/js/subprocess.js: Added.

(const.childProcess.require.string_appeared_here.Subprocess.prototype.call):
(const.childProcess.require.string_appeared_here.Subprocess):

  • tools/pull-os-versions.js: Added.

(main):
(syncLoop):

  • tools/sync-commits.py:

(Repository.fetch_commits_and_submit):

12:47 AM Changeset in webkit [213975] by zandobersek@gmail.com
  • 4 edits in trunk/Source/WebCore

Unreviewed GTK+ build fix. Sprinkle ENABLE(MEDIA_STREAM) build guards
in the Internals class to avoid compilation failures when building
with this feature disabled.

  • testing/Internals.cpp:

(WebCore::Internals::~Internals):

  • testing/Internals.h:
  • testing/Internals.idl:
Note: See TracTimeline for information about the timeline view.