Timeline
Mar 17, 2017:
- 9:32 PM Changeset in webkit [214134] by
-
- 6 edits in trunk/Source/WebCore
Stop sending media data as soon as peer connection is closed
https://bugs.webkit.org/show_bug.cgi?id=169813
Patch by Youenn Fablet <youenn@apple.com> on 2017-03-17
Reviewed by Eric Carlson.
Stopping sending of media data as soon as the peer connection is closed.
By stopping sending at source level, this may stop by a few frames/chunks earlier than before.
Making sure RealtimeOutgoingVideoSource is stopping observing the media source when being stopped and deleted.
- Modules/mediastream/libwebrtc/LibWebRTCPeerConnectionBackend.cpp:
(WebCore::LibWebRTCPeerConnectionBackend::doStop):
- platform/mediastream/mac/RealtimeOutgoingAudioSource.cpp:
(WebCore::RealtimeOutgoingAudioSource::stop):
- platform/mediastream/mac/RealtimeOutgoingAudioSource.h:
- platform/mediastream/mac/RealtimeOutgoingVideoSource.cpp:
(WebCore::RealtimeOutgoingVideoSource::stop):
- platform/mediastream/mac/RealtimeOutgoingVideoSource.h:
- 8:49 PM Changeset in webkit [214133] by
-
- 4 edits in trunk/Source/WebInspectorUI
Web Inspector: wrong filename when saving resource from ResourceImageContentView
https://bugs.webkit.org/show_bug.cgi?id=54454
Reviewed by Joseph Pecoraro.
- UserInterface/Views/ResourceContentView.js:
(WebInspector.ResourceContentView.prototype.get supportsSave):
(WebInspector.ResourceContentView.prototype.get saveData):
- UserInterface/Views/TextResourceContentView.js:
(WebInspector.TextResourceContentView.prototype.get supportsSave): Deleted.
Add save data getter to the parent class, so that both Images and Fonts can be saved.
- UserInterface/Views/Resource.js:
(WebInspector.Resource.prototype.canRequestContent):
Drive-by: remove unused function.
- 7:36 PM Changeset in webkit [214132] by
-
- 13 edits1 copy1 add in trunk
Implement incoming webrtc data based on tracksCurr
https://bugs.webkit.org/show_bug.cgi?id=169836
Patch by Youenn Fablet <youenn@apple.com> on 2017-03-17
Reviewed by Eric Carlson.
Source/WebCore:
Test: webrtc/video-with-receiver.html
Constructing incoming tracks based on libwebrtc OnAddTrack.
Constructing incoming media streams based on libwebrtc OnAddStream.
Firing only addstream if legacy API flag is on.
Ensuring that media stream and media stream tracks relationship is still correctly implemented.
For that, we keep a map that relates libwebrtc media streams with WebCore media streams.
Adding the ability to get a receiver related to the track on the track event.
Implementing the possibility to create a transceiver ahead of track arrival time.
Created transceivers that are not related to any real source are kept in the peer connection back end.
When a libwebrtc track is appearing, it is associated with the track source of the corresponding transceiver based on track type.
Added the ability to create empty real time sources and set their data libwebrtc track when being available.
- Modules/mediastream/MediaStream.cpp:
(WebCore::MediaStream::addTrackFromPlatform):
- Modules/mediastream/MediaStream.h:
- Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp:
(WebCore::LibWebRTCMediaEndpoint::mediaStreamFromRTCStream):
(WebCore::LibWebRTCMediaEndpoint::addRemoteStream):
(WebCore::LibWebRTCMediaEndpoint::addRemoteTrack):
(WebCore::LibWebRTCMediaEndpoint::removeRemoteStream):
(WebCore::LibWebRTCMediaEndpoint::OnAddStream):
(WebCore::LibWebRTCMediaEndpoint::OnRemoveStream):
(WebCore::LibWebRTCMediaEndpoint::OnAddTrack):
(WebCore::LibWebRTCMediaEndpoint::stop):
(WebCore::createMediaStreamTrack): Deleted.
(WebCore::LibWebRTCMediaEndpoint::addStream): Deleted.
- Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.h:
- Modules/mediastream/libwebrtc/LibWebRTCPeerConnectionBackend.cpp:
(WebCore::LibWebRTCPeerConnectionBackend::doStop):
(WebCore::createReceiverForSource):
(WebCore::createEmptySource):
(WebCore::LibWebRTCPeerConnectionBackend::createReceiver):
(WebCore::LibWebRTCPeerConnectionBackend::videoReceiver):
(WebCore::LibWebRTCPeerConnectionBackend::audioReceiver):
(WebCore::LibWebRTCPeerConnectionBackend::removeRemoteStream):
(WebCore::LibWebRTCPeerConnectionBackend::addRemoteStream):
- Modules/mediastream/libwebrtc/LibWebRTCPeerConnectionBackend.h:
- platform/mediastream/mac/RealtimeIncomingAudioSource.cpp:
(WebCore::RealtimeIncomingAudioSource::setSourceTrack):
- platform/mediastream/mac/RealtimeIncomingAudioSource.h:
- platform/mediastream/mac/RealtimeIncomingVideoSource.cpp:
(WebCore::RealtimeIncomingVideoSource::setSourceTrack):
- platform/mediastream/mac/RealtimeIncomingVideoSource.h:
LayoutTests:
- webrtc/video-with-receiver-expected.txt: Added.
- webrtc/video-with-receiver.html: Copied from LayoutTests/webrtc/video.html.
- webrtc/video.html:
- 5:39 PM Changeset in webkit [214131] by
-
- 2 edits in trunk/LayoutTests
Remove TestExpectation for a test that is no longer in the tree.
Unreviewed test gardening.
- platform/mac/TestExpectations:
- 5:34 PM Changeset in webkit [214130] by
-
- 2 edits in trunk/Source/WebCore
[MediaStream] Compensate for video capture orientation
https://bugs.webkit.org/show_bug.cgi?id=169313
<rdar://problem/30994785>
Unreviewed, fix a crash in r214120 found by the bots.
- platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.mm:
(-[WebAVSampleBufferStatusChangeListener invalidate]): Drive-by removal of unnecessary code.
(-[WebAVSampleBufferStatusChangeListener observeValueForKeyPath:ofObject:change:context:]):
Actually retain self before callOnMainThread.
(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::~MediaPlayerPrivateMediaStreamAVFObjC):
Invalidate the change listener first.
- 4:40 PM Changeset in webkit [214129] by
-
- 3 edits2 adds in trunk
MediaQueryList instances do not update for
prefers-reduced-motion
https://bugs.webkit.org/show_bug.cgi?id=169835
<rdar://problem/30339378>
Reviewed by Anders Carlsson.
Source/WebCore:
Tell the document it needs to evaluate the MediaQueryLists
if accessibility settings change.
Test: fast/media/mq-prefers-reduced-motion-matchMedia.html
- page/Page.cpp:
(WebCore::Page::accessibilitySettingsDidChange):
LayoutTests:
- fast/media/mq-prefers-reduced-motion-matchMedia-expected.txt: Added.
- fast/media/mq-prefers-reduced-motion-matchMedia.html: Added.
- 4:33 PM Changeset in webkit [214128] by
-
- 2 edits in trunk/LayoutTests
Mark media/modern-media-controls/airplay-placard/airplay-placard-text-section.html as flaky.
https://bugs.webkit.org/show_bug.cgi?id=169654
Unreviewed test gardening.
- platform/mac-wk1/TestExpectations:
- 4:23 PM Changeset in webkit [214127] by
-
- 11 edits in trunk/Source
Make HTTPCookieStorage operate in the UIProcess in absence of a WebProcessPool.
<rdar://problem/31102330> and https://bugs.webkit.org/show_bug.cgi?id=169797
Reviewed by Alex Christensen.
Source/WebCore:
No new tests (No behavior change).
- platform/network/NetworkStorageSession.h:
- platform/network/cocoa/NetworkStorageSessionCocoa.mm:
(WebCore::NetworkStorageSession::flushCookieStore):
- platform/network/soup/NetworkStorageSessionSoup.cpp:
(WebCore::NetworkStorageSession::flushCookieStore):
Source/WebKit2:
- UIProcess/API/APIHTTPCookieStore.cpp:
(API::HTTPCookieStore::~HTTPCookieStore):
(API::HTTPCookieStore::cookies):
(API::HTTPCookieStore::setCookie):
(API::HTTPCookieStore::deleteCookie):
(API::HTTPCookieStore::registerObserver):
(API::HTTPCookieStore::unregisterObserver):
(API::HTTPCookieStore::cookieManagerDestroyed):
(API::HTTPCookieStore::registerForNewProcessPoolNotifications):
- UIProcess/API/APIHTTPCookieStore.h:
- UIProcess/WebProcessPool.cpp:
(WebKit::WebProcessPool::create):
(WebKit::WebProcessPool::notifyThisWebProcessPoolWasCreated):
(WebKit::m_hiddenPageThrottlingTimer):
- UIProcess/WebProcessPool.h:
- UIProcess/WebsiteData/WebsiteDataStore.cpp:
(WebKit::WebsiteDataStore::processPoolForCookieStorageOperations):
(WebKit::WebsiteDataStore::processPoolForCookieStorageNotifications): Deleted.
- UIProcess/WebsiteData/WebsiteDataStore.h:
- 2:59 PM Changeset in webkit [214126] by
-
- 4 edits2 adds in trunk
Disable per-region boxes for multicolumn
https://bugs.webkit.org/show_bug.cgi?id=169830
Reviewed by Zalan Bujtas.
Source/WebCore:
Test: fast/multicol/float-adjacent-to-overflow-block.html
- rendering/RenderBlockFlow.cpp:
(WebCore::RenderBlockFlow::determineLogicalLeftPositionForChild):
- rendering/RenderBox.cpp:
(WebCore::RenderBox::borderBoxRectInRegion):
(WebCore::RenderBox::renderBoxRegionInfo):
Limit all of the per-region box code to RenderNamedFlowThreads.
This code should never be used by multicolumn layout.
LayoutTests:
- fast/multicol/float-adjacent-to-overflow-block-expected.html: Added.
- fast/multicol/float-adjacent-to-overflow-block.html: Added.
- 2:51 PM Changeset in webkit [214125] by
-
- 7 edits in trunk/Source
Time channel attack on SVG Filters
https://bugs.webkit.org/show_bug.cgi?id=118689
Reviewed by Simon Fraser.
Source/WebCore:
The time channel attack can happen if the attacker applies FEColorMatrix
or FEConvolveMatrix and provides a matrix which is filled with subnormal
floating point values. Performing floating-point operations on subnormals
is very expensive unless the pixel in the source graphics is black (or
zero). By measuring the time a filter takes to be applied, the attacker
can know whether the pixel he wants to steal from an iframe is black or
white. By repeating the same process on all the pixels in the iframe, the
attacker can reconstruct the whole page of the iframe.
To fix this issue, the values in the matrices of these filters will clamped
to FLT_MIN. We do not want to consume too much time calculating filtered
pixels because of such tiny values. The difference between applying FLT_MIN
and applying a subnormal should not be even noticeable. Normalizing the
floating-point matrices should happen only at the beginning of the filter
platformApplySoftware().
- platform/graphics/filters/FEColorMatrix.cpp:
(WebCore::FEColorMatrix::platformApplySoftware):
- platform/graphics/filters/FEConvolveMatrix.cpp:
(WebCore::FEConvolveMatrix::fastSetInteriorPixels):
(WebCore::FEConvolveMatrix::fastSetOuterPixels):
(WebCore::FEConvolveMatrix::platformApplySoftware):
- platform/graphics/filters/FEConvolveMatrix.h:
- platform/graphics/filters/FilterEffect.h:
(WebCore::FilterEffect::normalizedFloats):
Source/WTF:
Performing arithmetic operations on subnormal floating-point numbers is
very expensive. Normalizing the floating-point number to the minimum normal
value should accelerate the calculations and there won't be a noticeable
difference in the result since all the subnormal values and the minimum
normal value are all very close to zero.
- wtf/MathExtras.h:
(normalizedFloat):
- 2:31 PM Changeset in webkit [214124] by
-
- 2 edits in trunk/Source/WebCore
Explicitly resize the audio buffer in RealtimeOutgoingAudioSource.
https://bugs.webkit.org/show_bug.cgi?id=169814
<rdar://problem/30975496>
Reviewed by Eric Carlson.
Rather than just reserving sufficient capacity, actually change the buffer's underlying size to match.
- platform/mediastream/mac/RealtimeOutgoingAudioSource.cpp:
(WebCore::RealtimeOutgoingAudioSource::pullAudioData):
- 2:28 PM Changeset in webkit [214123] by
-
- 2 edits in trunk/Source/WebKit2
[WK2] Disable background tab responsiveness detection on iOS
https://bugs.webkit.org/show_bug.cgi?id=169824
<rdar://problem/30913776>
Reviewed by Dan Bernstein.
Disable background tab responsiveness detection on iOS where background tabs
often get suspended. This feature was not tested or meant to be enabled on
iOS, this was an oversight on my part.
- UIProcess/BackgroundProcessResponsivenessTimer.cpp:
(WebKit::BackgroundProcessResponsivenessTimer::shouldBeActive):
- 2:18 PM Changeset in webkit [214122] by
-
- 12 edits1 copy5 adds in trunk
[WebCrypto] Make sure all CryptoKey classes are structured clonable
https://bugs.webkit.org/show_bug.cgi?id=169232
<rdar://problem/31106660>
Reviewed by Brent Fulgham.
Source/WebCore:
This patch does the following few things: 1) It makes CryptoKeyEC and CryptoKeyRaw
structured clonable; 2) It makes CryptoKeyAES and CryptoKeyHMAC to use a move importer
during deserialization; 3) It adds some tests to make sure CryptoKeyAES, CryptoKeyHMAC
and CryptoKeyRSA won't lose their internal data during serialization/deserialization.
Tests: crypto/workers/subtle/ec-postMessage-worker.html
crypto/workers/subtle/raw-postMessage-worker.html
- bindings/js/SerializedScriptValue.cpp:
(WebCore::CloneSerializer::write):
(WebCore::CloneDeserializer::readHMACKey):
(WebCore::CloneDeserializer::readAESKey):
(WebCore::CloneDeserializer::readECKey):
(WebCore::CloneDeserializer::readRawKey):
(WebCore::CloneDeserializer::readCryptoKey):
- crypto/keys/CryptoKeyEC.cpp:
(WebCore::CryptoKeyEC::namedCurveString):
(WebCore::CryptoKeyEC::isValidECAlgorithm):
- crypto/keys/CryptoKeyEC.h:
LayoutTests:
- crypto/workers/subtle/aes-postMessage-worker-expected.txt:
- crypto/workers/subtle/aes-postMessage-worker.html:
- crypto/workers/subtle/ec-postMessage-worker-expected.txt: Added.
- crypto/workers/subtle/ec-postMessage-worker.html: Added.
- crypto/workers/subtle/hmac-postMessage-worker-expected.txt:
- crypto/workers/subtle/hmac-postMessage-worker.html:
- crypto/workers/subtle/raw-postMessage-worker-expected.txt: Added.
- crypto/workers/subtle/raw-postMessage-worker.html: Added.
- crypto/workers/subtle/resources/ec-postMessage-worker.js: Added.
- crypto/workers/subtle/resources/raw-postMessage-worker.js: Added.
- crypto/workers/subtle/resources/rsa-postMessage-worker.js:
- crypto/workers/subtle/rsa-postMessage-worker-expected.txt:
- crypto/workers/subtle/rsa-postMessage-worker.html:
- 2:16 PM Changeset in webkit [214121] by
-
- 12 edits in trunk
Use USE_INTERNAL_SDK to compute ENABLE_FAST_JIT_PERMISSIONS instead of HAVE_INTERNAL_SDK
https://bugs.webkit.org/show_bug.cgi?id=169817
Reviewed by Filip Pizlo.
Source/JavaScriptCore:
- Configurations/FeatureDefines.xcconfig:
Source/WebCore:
- Configurations/FeatureDefines.xcconfig:
Source/WebCore/PAL:
- Configurations/FeatureDefines.xcconfig:
Source/WebKit/mac:
- Configurations/FeatureDefines.xcconfig:
Source/WebKit2:
- Configurations/FeatureDefines.xcconfig:
Tools:
- TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
- 2:14 PM Changeset in webkit [214120] by
-
- 9 edits in trunk/Source/WebCore
[MediaStream] Compensate for video capture orientation
https://bugs.webkit.org/show_bug.cgi?id=169313
<rdar://problem/30994785>
Reviewed by Jer Noble.
No new tests, the mock video source doesn't support rotation. Test will be added when this
is fixed in https://bugs.webkit.org/show_bug.cgi?id=169822.
Add 'orientation' and 'mirrored' attributes to MediaSample
- platform/MediaSample.h:
(WebCore::MediaSample::videoOrientation):
(WebCore::MediaSample::videoMirrored):
- platform/graphics/avfoundation/MediaSampleAVFObjC.h:
A video sample can be rotated and/or mirrored, so the video layer may need to be rotated
and resized for display. We don't want expose this information to the renderer, so allocate
return a generic CALayer as the player's platforLayer, and add the video layer as a sublayer
so we can adjust it to display correctly. Add an enum for playback state as well as display
mode so we correctly display a black frame when video frames are available but playback has
not yet started.
- platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.h:
- platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.mm:
(-[WebAVSampleBufferStatusChangeListener initWithParent:]):
(-[WebAVSampleBufferStatusChangeListener invalidate]):
(-[WebAVSampleBufferStatusChangeListener beginObservingLayers]):
(-[WebAVSampleBufferStatusChangeListener stopObservingLayers]): Ditto.
(-[WebAVSampleBufferStatusChangeListener observeValueForKeyPath:ofObject:change:context:]):
(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::videoTransformationMatrix):
(WebCore::runWithoutAnimations):
(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::enqueueVideoSample):
(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::layerErrorDidChange):
(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::ensureLayers):
(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::destroyLayers):
(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::cancelLoad):
(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::platformLayer):
(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::displayLayer):
(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::backgroundLayer):
(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::currentDisplayMode):
(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::updateDisplayMode):
(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::play):
(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::pause):
(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::currentMediaTime):
(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::activeStatusChanged):
(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::updateRenderingMode):
(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::checkSelectedVideoTrack):
(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::paintCurrentFrameInContext):
(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::acceleratedRenderingStateChanged):
(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::setShouldBufferData):
(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::backgroundLayerBoundsChanged):
(-[WebAVSampleBufferStatusChangeListener beginObservingLayer:]): Deleted.
(-[WebAVSampleBufferStatusChangeListener stopObservingLayer:]): Deleted.
(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::ensureLayer): Deleted.
(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::destroyLayer): Deleted.
(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::paused): Deleted.
(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::shouldBePlaying): Deleted.
- platform/mediastream/mac/AVVideoCaptureSource.h:
- platform/mediastream/mac/AVVideoCaptureSource.mm:
(WebCore::AVVideoCaptureSource::processNewFrame): Add connection parameter so we can get the
video orientation.
(WebCore::AVVideoCaptureSource::captureOutputDidOutputSampleBufferFromConnection):
Pass sample orientation to libwebrtc.
- platform/mediastream/mac/RealtimeOutgoingVideoSource.cpp:
(WebCore::RealtimeOutgoingVideoSource::sendFrame):
(WebCore::RealtimeOutgoingVideoSource::videoSampleAvailable):
- platform/mediastream/mac/RealtimeOutgoingVideoSource.h:
- 2:12 PM Changeset in webkit [214119] by
-
- 3 edits2 adds in trunk
Fix the flow thread state on the descendants of out of flow positioned replaced elements.
https://bugs.webkit.org/show_bug.cgi?id=169821
<rdar://problem/30964017>
Reviewed by Simon Fraser.
Source/WebCore:
Descendants of a replaced out of flow elmement should inherit the flowthread state
from the replaced element and not from the replaced element's parent.
Test: fast/multicol/fix-inherit-when-container-is-replaced.html
- rendering/RenderObject.cpp:
(WebCore::RenderObject::computedFlowThreadState):
LayoutTests:
- fast/multicol/fix-inherit-when-container-is-replaced-expected.txt: Added.
- fast/multicol/fix-inherit-when-container-is-replaced.html: Added.
- 1:59 PM Changeset in webkit [214118] by
-
- 2 edits in trunk/Source/WebCore
Update feature status for outdated entries: CSS Shapes, Force Click Events
https://bugs.webkit.org/show_bug.cgi?id=169829
Reviewed by Matt Baker.
- features.json:
- 1:45 PM Changeset in webkit [214117] by
-
- 2 edits in trunk/Source/WebCore
Make SocketStreamError a private header.
https://bugs.webkit.org/show_bug.cgi?id=169831
- WebCore.xcodeproj/project.pbxproj:
I'll need this from WebKit2.
- 1:45 PM Changeset in webkit [214116] by
-
- 2 edits in trunk/LayoutTests
Update webrtc tests expectations
https://bugs.webkit.org/show_bug.cgi?id=169828
Unreviewed.
Patch by Youenn Fablet <youenn@apple.com> on 2017-03-17
- TestExpectations: Marking some webrtc tests as flaky.
- 1:42 PM Changeset in webkit [214115] by
-
- 2 edits in trunk/Source/WebCore
Add encoder for SocketStreamError
https://bugs.webkit.org/show_bug.cgi?id=169831
Reviewed by Andy Estes.
This isn't used yet, but we'll soon need to send these across IPC.
- platform/network/SocketStreamError.h:
(WebCore::SocketStreamError::encode):
(WebCore::SocketStreamError::decode):
- 1:30 PM Changeset in webkit [214114] by
-
- 11 edits1 add in trunk/Source/WebCore
Make SocketStreamHandle virtual functions asynchronous
https://bugs.webkit.org/show_bug.cgi?id=169818
Reviewed by Andy Estes.
No change in behavior. Instead of returning immediately, call a completion handler.
This is in preparation for making them truly asynchronous.
I still need to be able to synchronously get the number of buffered bytes, but the
buffer itself will soon be in the NetworkProcess with a new subclass of SocketStreamHandle
that messages across IPC. The number of buffered bytes will still be stored in the WebProcess,
and when it updates, the message from SocketStreamHandleClient::didUpdateBufferedAmount will update it.
- CMakeLists.txt:
- WebCore.xcodeproj/project.pbxproj:
- platform/network/SocketStreamHandle.cpp:
(WebCore::SocketStreamHandle::send):
(WebCore::SocketStreamHandle::close):
(WebCore::SocketStreamHandle::sendPendingData): Deleted.
- platform/network/SocketStreamHandle.h:
(WebCore::SocketStreamHandle::bufferedAmount): Deleted.
- platform/network/SocketStreamHandleImpl.cpp: Added.
(WebCore::SocketStreamHandleImpl::platformSend):
(WebCore::SocketStreamHandleImpl::sendPendingData):
(WebCore::SocketStreamHandleImpl::bufferedAmount):
m_buffer was moved from SocketStreamHandle to SocketStreamHandleImpl, so some of the logic must move with it.
I moved as much logic that was shared in the superclass to a new shared location for code shared among the subclass implementations.
- platform/network/cf/SocketStreamHandleImpl.h:
- platform/network/cf/SocketStreamHandleImplCFNet.cpp:
(WebCore::SocketStreamHandleImpl::platformSendInternal):
(WebCore::SocketStreamHandleImpl::platformSend): Deleted.
- platform/network/curl/SocketStreamHandleImpl.h:
- platform/network/curl/SocketStreamHandleImplCurl.cpp:
(WebCore::SocketStreamHandleImpl::platformSendInternal):
(WebCore::SocketStreamHandleImpl::platformSend): Deleted.
- platform/network/soup/SocketStreamHandleImpl.h:
- platform/network/soup/SocketStreamHandleImplSoup.cpp:
(WebCore::SocketStreamHandleImpl::platformSendInternal):
(WebCore::SocketStreamHandleImpl::platformSend): Deleted.
- 12:52 PM Changeset in webkit [214113] by
-
- 33 edits3 adds in trunk
Add a reload policy where only expired subresources are revalidated
https://bugs.webkit.org/show_bug.cgi?id=169756
Reviewed by Andreas Kling.
Source/WebCore:
Test: http/tests/cache/reload-expired-only.html
The default reload behavior revalidates all resources on the page. This patch adds
a new policy that revalidates expired (and uncacheable) resources only. Using this
policy can speed up reloads significantly and also reduce network traffic and server
load.
- history/PageCache.cpp:
(WebCore::canCachePage):
- inspector/InspectorPageAgent.cpp:
(WebCore::InspectorPageAgent::reload):
- loader/FrameLoader.cpp:
(WebCore::isBackForwardLoadType):
(WebCore::isReload):
Add a helper function.
(WebCore::FrameLoader::loadURL):
(WebCore::logNavigation):
(WebCore::FrameLoader::reload):
Replace bool arguments with OptionSet<ReloadOption>. Most of the patch is about adapting to this.
(WebCore::FrameLoader::transitionToCommitted):
(WebCore::FrameLoader::subresourceCachePolicy):
Return CachePolicyVerify for 'ReloadExpiredOnly' frame load type. This is the substantive
change that causes the behavior difference.
(WebCore::FrameLoader::checkLoadCompleteForThisFrame):
(WebCore::FrameLoader::defaultRequestCachingPolicy):
Flip the isMainResource condition for better readability.
(WebCore::FrameLoader::shouldPerformFragmentNavigation):
(WebCore::FrameLoader::loadDifferentDocumentItem):
- loader/FrameLoader.h:
(WebCore::FrameLoader::reload):
- loader/FrameLoaderTypes.h:
- loader/HistoryController.cpp:
(WebCore::HistoryController::restoreDocumentState):
- page/DiagnosticLoggingKeys.cpp:
(WebCore::DiagnosticLoggingKeys::reloadRevalidatingExpiredKey):
- page/DiagnosticLoggingKeys.h:
- replay/UserInputBridge.cpp:
(WebCore::UserInputBridge::reloadFrame):
- replay/UserInputBridge.h:
- testing/Internals.cpp:
(WebCore::Internals::forceReload):
(WebCore::Internals::reloadExpiredOnly):
Testing support.
- testing/Internals.h:
- testing/Internals.idl:
Source/WebKit/mac:
- WebView/WebFrame.mm:
(toWebFrameLoadType):
(-[WebFrame reload]):
(-[WebFrame reloadFromOrigin]):
Source/WebKit2:
- UIProcess/API/C/WKPage.cpp:
(WKPageReload):
(WKPageReloadWithoutContentBlockers):
(WKPageReloadFromOrigin):
(WKPageReloadExpiredOnly):
- UIProcess/API/C/WKPage.h:
- UIProcess/API/Cocoa/WKBrowsingContextController.mm:
(-[WKBrowsingContextController reload]):
(-[WKBrowsingContextController reloadFromOrigin]):
- UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView reload]):
(-[WKWebView reloadFromOrigin]):
(-[WKWebView _reloadWithoutContentBlockers]):
(-[WKWebView _reloadExpiredOnly]):
- UIProcess/API/Cocoa/WKWebViewPrivate.h:
- UIProcess/Automation/WebAutomationSession.cpp:
(WebKit::WebAutomationSession::reloadBrowsingContext):
- UIProcess/WebFrameProxy.cpp:
(WebKit::WebFrameProxy::didHandleContentFilterUnblockNavigation):
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::reload):
- UIProcess/WebPageProxy.h:
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::reload):
(WebKit::shouldReuseCommittedSandboxExtension):
- WebProcess/WebPage/WebPage.h:
- WebProcess/WebPage/WebPage.messages.in:
LayoutTests:
- http/tests/cache/reload-expired-only-expected.txt: Added.
- http/tests/cache/reload-expired-only.html: Added.
- http/tests/cache/resources/document-with-cached-unique-script.html: Added.
- http/tests/cache/resources/random-cached.cgi:
- 12:48 PM Changeset in webkit [214112] by
-
- 4 edits4 adds in trunk
AX: VoiceOver no longer works corectly with editable text in the web
https://bugs.webkit.org/show_bug.cgi?id=169801
Reviewed by Chris Fleizach.
Source/WebCore:
The issue is that since we are entering text controls when getting the text marker,
the end text marker of the input tag might associate to the placeholder div instead of
the input tag itself.
Fixed the issue by checking the shadow elements using shadowHost() instead of isShadowRoot().
Also, only enter text controls when navigating by characters/indexes, so that both Mac and
iOS will get the correct text marker ranges for shadow host elements.
Tests: accessibility/ios-simulator/element-text-range-for-text-control.html
accessibility/mac/text-markers-for-input-with-placeholder.html
- accessibility/AXObjectCache.cpp:
(WebCore::AXObjectCache::traverseToOffsetInRange):
(WebCore::AXObjectCache::startOrEndCharacterOffsetForRange):
(WebCore::AXObjectCache::characterOffsetForIndex):
- accessibility/AXObjectCache.h:
LayoutTests:
- accessibility/ios-simulator/element-text-range-for-text-control-expected.txt: Added.
- accessibility/ios-simulator/element-text-range-for-text-control.html: Added.
- accessibility/mac/text-markers-for-input-with-placeholder-expected.txt: Added.
- accessibility/mac/text-markers-for-input-with-placeholder.html: Added.
- 12:30 PM Changeset in webkit [214111] by
-
- 11 edits in trunk/Source
[WK1] Support animated transitions when performing a data interaction operation
https://bugs.webkit.org/show_bug.cgi?id=169805
<rdar://problem/31045767>
Reviewed by Beth Dakin and Megan Gardner.
Source/WebCore:
When performing a snapshot excluding the current selection, use ScrollableArea::visibleContentRect to compute
the visible content rect rather than FrameView::visualViewportRect. In WebKit1, the latter will return the
entire content view's bounds.
- page/TextIndicator.cpp:
(WebCore::takeSnapshots):
Source/WebKit/mac:
Adds WebKit1 support for animated transitions when performing a data interaction operation. See per-method changes
for more details.
- DOM/DOMElement.h:
- DOM/DOMElement.mm:
(-[DOMElement boundsInRootViewSpace]):
Introduce -[DOMElement boundsInRootViewSpace], which returns the bounds of the element in root view coordinates.
- WebCoreSupport/WebDragClient.h:
(): Deleted.
- WebCoreSupport/WebDragClient.mm:
(WebDragClient::didConcludeEditDrag):
Add boilerplate plumbing.
- WebView/WebView.mm:
(-[WebUITextIndicatorData initWithImage:textIndicatorData:scale:]):
Add contentImageWithoutSelection and contentImageWithoutSelectionRectInRootViewCoordinates to WebUITextIndicatorData.
(floatRectsForCGRectArray):
(-[WebView _createImageWithPlatterForImage:boundingRect:contentScaleFactor:clippingRects:]):
Introduces a SPI helper method in WebView that clients can use to generate an image of a text platter given an
image of some text, as well as clipping rects to apply to the image.
(-[WebView _dataOperationTextIndicator]):
Add SPI to fetch the text indicator used to drive animations for the current data operation.
(-[WebView _didConcludeEditDataInteraction]):
- WebView/WebViewData.h:
- WebView/WebViewInternal.h:
- WebView/WebViewPrivate.h:
- 11:54 AM Changeset in webkit [214110] by
-
- 12 edits8 adds in trunk
Initial letter does not paginate properly.
https://bugs.webkit.org/show_bug.cgi?id=169795
<rdar://problem/23715770>
Reviewed by Zalan Bujtas.
Source/WebCore:
Tests: fast/css-generated-content/initial-letter-pagination-raised.html
fast/css-generated-content/initial-letter-pagination-raised-rl.html
fast/css-generated-content/initial-letter-pagination-sunken.html
fast/css-generated-content/initial-letter-pagination-sunken-rl.html
- rendering/FloatingObjects.cpp:
(WebCore::FloatingObject::FloatingObject):
(WebCore::FloatingObject::copyToNewContainer):
(WebCore::FloatingObject::cloneForNewParent):
(WebCore::FloatingObject::translationOffsetToAncestor):
- rendering/FloatingObjects.h:
(WebCore::FloatingObject::setMarginOffset):
(WebCore::FloatingObject::locationOffsetOfBorderBox):
(WebCore::FloatingObject::marginOffset):
Add the margin offset to the FloatingObject so that we can control the
placement of the border box relative to the margin box without relying
on only the CSS-specified margins. This allows for sunken initial letter
FloatingObjects to be created and propagated out to ancestor blocks for painting
without altering the CSS margins of the sunken letter.
- rendering/RenderBlockFlow.cpp:
(WebCore::RenderBlockFlow::adjustForUnsplittableChild):
Update the logical height for initial letter containers after the initial
letter shifts to the next page, since the lines that follow need to lay out
relative to the initial letter, i.e., they shift down if it shifts down.
(WebCore::RenderBlockFlow::addOverflowFromFloats):
(WebCore::RenderBlockFlow::paintFloats):
(WebCore::RenderBlockFlow::clipOutFloatingObjects):
Patched to use the new helpers on FloatingObject rather than
xPositionForFloatIncludingMargins and yPositionForFloatIncludingMargins.
(WebCore::RenderBlockFlow::computeLogicalLocationForFloat):
Updated to set the placement and margins of the floating object before
returning. The initial letter adjustments have been factored out into their
own function.
(WebCore::RenderBlockFlow::adjustInitialLetterPosition):
A helper function called by computeLogicalLocationForFloat that handles
the placement and margin adjustments for initial letters. Note that sunken
letters no longer "hack" the top margin of the child but instead rely on
the fact that the FloatingObject has its own independent margin offset now
that can be set to a value that is distinct from the CSS supplied margin.
(WebCore::RenderBlockFlow::positionNewFloats):
Revised to no longer do the placement, but to let computeLogicalLocationForFloat
do it. The height is still set here however, since we don't know that until after
the child has received a layout.
(WebCore::RenderBlockFlow::addOverhangingFloats):
(WebCore::RenderBlockFlow::flipFloatForWritingModeForChild):
(WebCore::RenderBlockFlow::hitTestFloats):
(WebCore::RenderBlockFlow::adjustForBorderFit):
Patched to use the new FloatingObject helpers rather than
xPositionForFloatIncludingMargins and yPositionForFloatIncludingMargins.
- rendering/RenderBlockFlow.h:
(WebCore::RenderBlockFlow::setLogicalMarginsForFloat):
New helper function for setting the margin offsets on a FloatingObject.
(WebCore::RenderBlockFlow::xPositionForFloatIncludingMargin): Deleted.
(WebCore::RenderBlockFlow::yPositionForFloatIncludingMargin): Deleted.
Deleted in favor of new FloatingObject helpers.
- rendering/RenderBox.cpp:
(WebCore::RenderBox::isUnsplittableForPagination):
Make initial letter unsplittable as far as pagination is concerned.
- rendering/RootInlineBox.cpp:
(WebCore::RootInlineBox::ascentAndDescentForBox):
(WebCore::RootInlineBox::includeFontForBox):
(WebCore::RootInlineBox::includeGlyphsForBox):
(WebCore::RootInlineBox::fitsToGlyphs):
Turn off the restriction that you can't fit to vertical glyphs. The numbers returned
are fine now. This allows vertical initial letters to work.
LayoutTests:
- fast/css-generated-content/initial-letter-pagination-raised-expected.html: Added.
- fast/css-generated-content/initial-letter-pagination-raised.html: Added.
- fast/css-generated-content/initial-letter-pagination-sunken-expected.html: Added.
- fast/css-generated-content/initial-letter-pagination-sunken.html: Added.
- platform/ios-simulator/TestExpectations:
- 10:58 AM Changeset in webkit [214109] by
-
- 12 edits2 adds in trunk/Source
Air should be powerful enough to support Tmp-splitting
https://bugs.webkit.org/show_bug.cgi?id=169515
Reviewed by Saam Barati.
Source/JavaScriptCore:
In the process of implementing the Tmp-splitting optimization, I made some small
clean-ups. They don't affect anything - it's basically moving code around and adding
utility functions.
- CMakeLists.txt:
- JavaScriptCore.xcodeproj/project.pbxproj:
- assembler/LinkBuffer.cpp:
(JSC::LinkBuffer::allocate): testb3 was sometimes failing its checkDoesNotUseInstruction check because of uninitialized memory. This initializes the internal fragmentation slop of every JIT allocation.
- b3/air/AirAllocateRegistersByGraphColoring.cpp:
- b3/air/AirAllocateRegistersByGraphColoring.h:
(JSC::B3::Air::useIRC): It's useful to be able to query which register allocator we're using.
- b3/air/AirArg.cpp:
(WTF::printInternal):
- b3/air/AirArg.h:
(JSC::B3::Air::Arg::temperature): The temperature of a role is a useful concept to have factored out.
- b3/air/AirBreakCriticalEdges.cpp: Added.
(JSC::B3::Air::breakCriticalEdges): I was surprised that we didn't have this already. It's a pretty fundamental CFG utility.
- b3/air/AirBreakCriticalEdges.h: Added.
- b3/air/AirGenerate.cpp:
- b3/air/AirInsertionSet.h: You can't use & if you want copy-constructibility, which seems to be a prerequisite to IndexMap<BasicBlock, InsertionSet>.
(JSC::B3::Air::InsertionSet::InsertionSet):
(JSC::B3::Air::InsertionSet::code):
- b3/air/AirLiveness.h: Teach Liveness to track only warm liveness.
(JSC::B3::Air::TmpLivenessAdapter::acceptsRole):
(JSC::B3::Air::StackSlotLivenessAdapter::acceptsRole):
(JSC::B3::Air::RegLivenessAdapter::acceptsRole):
(JSC::B3::Air::AbstractLiveness::AbstractLiveness):
(JSC::B3::Air::AbstractLiveness::LocalCalc::execute):
Source/WTF:
Teach IndexMap how to handle types that don't have a default constructor. This makes it
easy to create a IndexMap<BasicBlock, InsertionSet>, which is a super powerful
construct.
- wtf/IndexMap.h:
(WTF::IndexMap::IndexMap):
(WTF::IndexMap::resize):
(WTF::IndexMap::clear):
- 10:16 AM Changeset in webkit [214108] by
-
- 3 edits2 adds in trunk
RealtimeIncomingAudioSource is not stopping properly
https://bugs.webkit.org/show_bug.cgi?id=169807
Patch by Youenn Fablet <youenn@apple.com> on 2017-03-17
Reviewed by Eric Carlson.
Source/WebCore:
Test: webrtc/release-after-getting-track.html
- platform/mediastream/mac/RealtimeIncomingAudioSource.cpp:
(WebCore::RealtimeIncomingAudioSource::~RealtimeIncomingAudioSource):
(WebCore::RealtimeIncomingAudioSource::stopProducingData):
LayoutTests:
- webrtc/release-after-getting-track-expected.txt: Added.
- webrtc/release-after-getting-track.html: Added.
- 10:09 AM Changeset in webkit [214107] by
-
- 5 edits in branches/safari-603-branch/Source
Versioning.
- 8:57 AM Changeset in webkit [214106] by
-
- 8 edits in trunk/Source
Use completion handlers instead of return values for sending websocket data
https://bugs.webkit.org/show_bug.cgi?id=169802
Reviewed by Carlos Garcia Campos.
Source/WebCore:
No change in behavior, but this is a baby step towards making things more asynchronous.
- Modules/websockets/WebSocketChannel.cpp:
(WebCore::WebSocketChannel::didOpenSocketStream):
(WebCore::WebSocketChannel::processOutgoingFrameQueue):
(WebCore::WebSocketChannel::sendFrame):
- Modules/websockets/WebSocketChannel.h:
- platform/network/SocketStreamHandle.cpp:
(WebCore::SocketStreamHandle::send):
- platform/network/SocketStreamHandle.h:
- platform/network/cf/SocketStreamHandleImpl.h:
Source/WebKit2:
- UIProcess/InspectorServer/WebSocketServerConnection.cpp:
(WebKit::WebSocketServerConnection::sendWebSocketMessage):
(WebKit::WebSocketServerConnection::sendHTTPResponseHeader):
(WebKit::WebSocketServerConnection::sendRawData):
- 7:11 AM Changeset in webkit [214105] by
-
- 7 edits in trunk/Source/WebCore
WebGPU: build fixes for non-Cocoa platforms
https://bugs.webkit.org/show_bug.cgi?id=169781
Reviewed by Alex Christensen.
Enable building WebGPU code for other ports and fix various build
failures. This still leaves the GPUDevice::platformLayer() method
missing for other ports, as well as the general implementation of
the WebGPU platform abstractions under platform/graphics/gpu/.
- CMakeLists.txt: Move the WebGPU build targets here.
- PlatformMac.cmake:
- html/canvas/WebGPULibrary.h: Explicitly include the WTFString.h
header to suppress missing WTF::String definition errors.
- platform/graphics/gpu/GPUBuffer.cpp:
(WebCore::GPUBuffer::contents): Avoid ambiguous calls to
ArrayBuffer::create() by passing nullptr as the first argument.
- platform/graphics/gpu/GPUDevice.h: Include the Forward.h header
to forward-declare the WTF::String class. Also remove the unused
PlatformGPUDevice typedef for non-Cocoa platforms.
(WebCore::GPUDevice::layer): Move this and the related m_layer
member variable under the PLATFORM(COCOA) guard.
- platform/graphics/gpu/GPUFunction.cpp:
(WebCore::GPUFunction::GPUFunction): Remove the GPULibrary
parameter checks in this no-op constructor that's used on
non-Cocoa platforms.
- 6:13 AM Changeset in webkit [214104] by
-
- 5 edits in trunk/Source/WebKit2
Fix uninitialized public members in WebProcess
https://bugs.webkit.org/show_bug.cgi?id=169604
Reviewed by Michael Catanzaro.
Found by Coverity scan.
- WebProcess/Databases/IndexedDB/WebIDBConnectionToServer.h:
- WebProcess/InjectedBundle/InjectedBundleNavigationAction.h:
- WebProcess/Plugins/Netscape/NetscapePlugin.h:
- WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp:
(WebKit::NetscapePluginX11::NetscapePluginX11):
- 5:22 AM Changeset in webkit [214103] by
-
- 7 edits2 adds in trunk
Follow-up (r213833): write a layout test for 169199
https://bugs.webkit.org/show_bug.cgi?id=169576
<rdar://problem/31024766>
Reviewed by Said Abou-Hallawa.
Source/WebCore:
Add a function to Internals to force the deletion of the ImageDecoder just after
requesting the async decoding of a frame, and implement that behaviour in BitmapImage.
Test: fast/images/clear-animation-decoder.html
- platform/graphics/BitmapImage.cpp:
(WebCore::BitmapImage::internalStartAnimation):
- platform/graphics/BitmapImage.h:
- testing/Internals.cpp:
(WebCore::Internals::setClearDecoderAfterAsyncFrameRequestForTesting):
- testing/Internals.h:
- testing/Internals.idl:
LayoutTests:
Add a test that ensures there's no crash when deleting the ImageDecoder after requesting
an async decoding operation.
- fast/images/clear-animation-decoder-expected.txt: Added.
- fast/images/clear-animation-decoder.html: Added.
- 2:46 AM Changeset in webkit [214102] by
-
- 2 edits in trunk/LayoutTests
Unreviewed GTK+ gardening. Mark mediastream and webrtc new failures.
- platform/gtk/TestExpectations:
- 2:45 AM Changeset in webkit [214101] by
-
- 3 edits in trunk/Source/WebKit2
Fix uninitialized public members in NetworkProcess
https://bugs.webkit.org/show_bug.cgi?id=169598
Reviewed by Alex Christensen.
Found by Coverity scan.
- NetworkProcess/NetworkProcessCreationParameters.h:
- NetworkProcess/cache/NetworkCacheStorage.cpp:
- 1:22 AM Changeset in webkit [214100] by
-
- 4 edits in trunk/Source/WebCore
[Cairo] Handle the blend mode in GraphicsContext::drawPattern
https://bugs.webkit.org/show_bug.cgi?id=169746
Reviewed by Žan Doberšek.
We are not taking into account the blend mode when passing the cairo operator to drawPatternToCairoContext().
This is based on patch by Žan Doberšek, just adding the toCairoOperator changes to make it easier to handle
it. Instead of checking everywhere if blend mode is Normal to decide whether to use toCairoOperator with
CompositeOperator or BlendMode, there's no a single toCairoOperator that receives both parameters, but BlendMode
is optional and defaults to Normal.
- platform/graphics/cairo/CairoUtilities.cpp:
(WebCore::toCairoCompositeOperator):
(WebCore::toCairoOperator):
- platform/graphics/cairo/CairoUtilities.h:
- platform/graphics/cairo/GraphicsContextCairo.cpp:
(WebCore::GraphicsContext::setPlatformCompositeOperation):
(WebCore::GraphicsContext::drawPattern):
Mar 16, 2017:
- 10:29 PM Changeset in webkit [214099] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: memory category timelines would look better with ruler tick-aligned guides
https://bugs.webkit.org/show_bug.cgi?id=158100
Reviewed by Joseph Pecoraro.
- UserInterface/Views/MemoryTimelineView.css:
(.timeline-view.memory > .content > .details):
(.timeline-view.memory > .content > .details > .timeline-ruler):
(body[dir=ltr] .timeline-view.memory > .content > .details > .timeline-ruler):
(body[dir=rtl] .timeline-view.memory > .content > .details > .timeline-ruler):
Make the TimelineRuler absolutely positioned so it can use the full height of the view,
providing enough space for the markers to be visible.
- 10:14 PM Changeset in webkit [214098] by
-
- 2 edits in trunk/LayoutTests
Mark imported/w3c/web-platform-tests/html/browsers/history/the-location-interface/location_hash.html as flaky.
https://bugs.webkit.org/show_bug.cgi?id=169572
Unreviewed test gardening.
- platform/mac/TestExpectations:
- 9:49 PM Changeset in webkit [214097] by
-
- 4 edits in trunk/LayoutTests
Rebaseline js/dom/global-constructors-attributes.html.
Unreviewed test gardening.
- platform/mac-elcapitan/js/dom/global-constructors-attributes-expected.txt:
- platform/mac-wk1/js/dom/global-constructors-attributes-expected.txt:
- platform/mac/js/dom/global-constructors-attributes-expected.txt:
- 9:33 PM Changeset in webkit [214096] by
-
- 3 edits in branches/safari-603.1.30.0-branch/LayoutTests
Merge r213174.
- 9:33 PM Changeset in webkit [214095] by
-
- 2 edits in branches/safari-603.1.30.0-branch/LayoutTests
Merge r212132.
- 9:33 PM Changeset in webkit [214094] by
-
- 1 edit3 adds in branches/safari-603.1.30.0-branch/LayoutTests
Add baseline for fast/canvas/webgl/context-creation-attributes.html.
Unreviewed test gardening.
- platform/mac-wk1/fast/canvas/webgl/context-creation-attributes-expected.txt: Added.
- 7:14 PM Changeset in webkit [214093] by
-
- 4 edits in trunk/Source/WebInspectorUI
Web Inspector: Console Evaluation links in the Console should not show normally
https://bugs.webkit.org/show_bug.cgi?id=157483
Reviewed by Matt Baker.
- UserInterface/Models/CallFrame.js:
(WebInspector.CallFrame):
(WebInspector.CallFrame.prototype.get isConsoleEvaluation):
(WebInspector.CallFrame.fromDebuggerPayload):
(WebInspector.CallFrame.fromPayload):
Move console evaluation check to the constructor for consistency.
- UserInterface/Views/ConsoleMessageView.js:
(WebInspector.ConsoleMessageView.prototype._appendLocationLink):
- UserInterface/Views/StackTraceView.js:
(WebInspector.StackTraceView):
Only add CallFrameView elements if the corresponding CallFame is not a console evaluation.
- 7:07 PM Changeset in webkit [214092] by
-
- 2 edits in trunk/Source/WebKit2
Fix GTK build.
- UIProcess/InspectorServer/WebSocketServerConnection.h:
- 6:56 PM Changeset in webkit [214091] by
-
- 3 edits in trunk/Source/WebKit2
Fix GTK build.
- UIProcess/InspectorServer/WebSocketServerConnection.cpp:
(WebKit::WebSocketServerConnection::didReceiveSocketStreamData):
- UIProcess/InspectorServer/WebSocketServerConnection.h:
- 6:43 PM Changeset in webkit [214090] by
-
- 2 edits in trunk/Source/WebCore
Fix GTK build.
- platform/network/soup/SocketStreamHandleImplSoup.cpp:
(WebCore::SocketStreamHandleImpl::readBytes):
Changing RefPtr to Ref broke something.
For the record, EWS was orange so I couldn't see these build failures.
- 6:37 PM Changeset in webkit [214089] by
-
- 2 edits in trunk/Source/WebKit2
Turn off JavaScript Configuration File processing for Debug builds
https://bugs.webkit.org/show_bug.cgi?id=169799
Reviewed by Dean Jackson.
Change the default value for m_javaScriptConfigurationFileEnabled for Debug
builds to be the same as a Release build, that is false (off).
- UIProcess/WebProcessPool.h:
- 6:23 PM Changeset in webkit [214088] by
-
- 2 edits in trunk/Source/WebCore
Fix GTK build.
- platform/network/soup/SocketStreamHandleImplSoup.cpp:
(WebCore::SocketStreamHandleImpl::readBytes):
didFailToReceiveSocketStreamData needs a parameter.
- 5:51 PM Changeset in webkit [214087] by
-
- 2 edits in trunk/LayoutTests
activating webrtc tests on Release bots
https://bugs.webkit.org/show_bug.cgi?id=169775
Unreviewed.
Patch by Youenn Fablet <youenn@apple.com> on 2017-03-16
- 5:51 PM Changeset in webkit [214086] by
-
- 7 edits2 adds in trunk
WebGL: Improve index validation when using uint index values
https://bugs.webkit.org/show_bug.cgi?id=169798
Reviewed by Simon Fraser.
Source/WebCore:
Make sure that we test index validation with the correct type.
Also stop using -1 in WebGLBuffer to indicate non-existant values.
Test: fast/canvas/webgl/draw-elements-out-of-bounds-uint-index.html
- html/canvas/WebGL2RenderingContext.cpp:
(WebCore::WebGL2RenderingContext::validateIndexArrayConservative): Use optional<> and
unsigned values.
- html/canvas/WebGLBuffer.cpp: Use unsigned for maxIndex (they can't be negative)
and optional<> to indicate unknown value.
(WebCore::WebGLBuffer::getCachedMaxIndex):
(WebCore::WebGLBuffer::setCachedMaxIndex):
- html/canvas/WebGLBuffer.h:
- html/canvas/WebGLRenderingContext.cpp:
(WebCore::WebGLRenderingContext::validateIndexArrayConservative): Use optional<> and
unsigned values.
- html/canvas/WebGLRenderingContextBase.cpp:
(WebCore::WebGLRenderingContextBase::validateVertexAttributes): No need to check if
an unsigned value is less than zero.
LayoutTests:
- fast/canvas/webgl/draw-elements-out-of-bounds-uint-index-expected.txt: Added.
- fast/canvas/webgl/draw-elements-out-of-bounds-uint-index.html: Added.
- 5:51 PM Changeset in webkit [214085] by
-
- 2 edits in trunk/Source/JavaScriptCore
Fix exception scope verification failures in GenericArgumentsInlines.h.
https://bugs.webkit.org/show_bug.cgi?id=165012
Reviewed by Saam Barati.
- runtime/GenericArgumentsInlines.h:
(JSC::GenericArguments<Type>::defineOwnProperty):
- 5:47 PM Changeset in webkit [214084] by
-
- 23 edits in trunk
Improve the system tracing points
https://bugs.webkit.org/show_bug.cgi?id=169790
Reviewed by Zalan Bujtas.
Use a more cohesive set of system trace points that give a good overview of what
WebKit is doing. Added points for resource loading, render tree building, sync messages
to the web process, async image decode, WASM and fetching cookies.
Source/JavaScriptCore:
- wasm/WasmPlan.cpp:
(JSC::Wasm::Plan::run):
- wasm/js/WebAssemblyFunction.cpp:
(JSC::callWebAssemblyFunction):
Source/WebCore:
- loader/CookieJar.cpp:
(WebCore::cookies):
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::provisionalLoadStarted):
(WebCore::FrameLoader::checkLoadCompleteForThisFrame):
- loader/SubresourceLoader.cpp:
(WebCore::SubresourceLoader::willSendRequestInternal):
(WebCore::logResourceLoaded):
(WebCore::SubresourceLoader::didFinishLoading):
(WebCore::SubresourceLoader::didFail):
(WebCore::SubresourceLoader::didCancel):
- page/FrameView.cpp:
(WebCore::FrameView::paintContents):
- platform/graphics/ImageFrameCache.cpp:
(WebCore::ImageFrameCache::startAsyncDecodingQueue):
- platform/graphics/ios/DisplayRefreshMonitorIOS.mm:
(WebCore::DisplayRefreshMonitorIOS::requestRefreshCallback):
(WebCore::DisplayRefreshMonitorIOS::displayLinkFired):
- style/RenderTreeUpdater.cpp:
(WebCore::RenderTreeUpdater::commit):
Source/WebKit/mac:
- WebView/WebHTMLView.mm:
(-[WebHTMLView drawRect:]):
Source/WebKit2:
- UIProcess/ChildProcessProxy.h:
(WebKit::ChildProcessProxy::sendSync):
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::handleTouchEventSynchronously):
- UIProcess/mac/RemoteLayerTreeDrawingAreaProxy.mm:
(WebKit::RemoteLayerTreeDrawingAreaProxy::commitLayerTree):
(WebKit::RemoteLayerTreeDrawingAreaProxy::didRefreshDisplay):
- WebProcess/WebPage/mac/RemoteLayerTreeContext.mm:
(WebKit::RemoteLayerTreeContext::buildTransaction):
- WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.mm:
(WebKit::RemoteLayerTreeDrawingArea::didUpdate):
(WebKit::RemoteLayerTreeDrawingArea::BackingStoreFlusher::flush):
Source/WTF:
- wtf/SystemTracing.h:
Tools:
- Tracing/SystemTracePoints.plist:
- 5:23 PM Changeset in webkit [214083] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: REGRESSION (r213691): Saving DOM breakpoints broken after refactoring
https://bugs.webkit.org/show_bug.cgi?id=169779
Reviewed by Joseph Pecoraro.
Use correct method: _saveBreakpoints -> _saveDOMBreakpoints.
- UserInterface/Controllers/DOMDebuggerManager.js:
(WebInspector.DOMDebuggerManager.prototype.addDOMBreakpoint):
Remove check before saving to be consistent with similar code in
DebuggerManager and DOMDebuggerManager.
- 5:20 PM Changeset in webkit [214082] by
-
- 29 edits in trunk/Source/WebCore
RenderView::documentBeingDestroyed() needs a new name.
https://bugs.webkit.org/show_bug.cgi?id=166727
Reviewed by Andreas Kling.
Now that we destroy the render tree for documents going into the page cache, RenderView::documentBeingDestroyed()
is misleadingly named. Rename it to renderTreeBeingDestroyed() and fix all callers.
- page/FrameView.cpp:
(WebCore::FrameView::scheduleRelayoutOfSubtree):
- page/scrolling/ScrollingCoordinator.cpp:
(WebCore::ScrollingCoordinator::absoluteEventTrackingRegionsForFrame):
- rendering/CounterNode.cpp:
(WebCore::CounterNode::resetRenderers):
- rendering/ImageQualityController.cpp:
(WebCore::ImageQualityController::highQualityRepaintTimerFired):
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::willBeDestroyed):
(WebCore::canMergeContiguousAnonymousBlocks):
(WebCore::RenderBlock::removeChild):
- rendering/RenderBlockFlow.cpp:
(WebCore::RenderBlockFlow::willBeDestroyed):
(WebCore::RenderBlockFlow::removeChild):
- rendering/RenderBox.cpp:
(WebCore::RenderBox::removeFloatingOrPositionedChildFromBlockLists):
(WebCore::RenderBox::deleteLineBoxWrapper):
- rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::willBeDestroyed):
- rendering/RenderElement.cpp:
(WebCore::RenderElement::insertChildInternal):
(WebCore::RenderElement::removeChildInternal):
(WebCore::RenderElement::clearLayoutRootIfNeeded):
(WebCore::RenderElement::willBeDestroyed):
- rendering/RenderImage.cpp:
(WebCore::RenderImage::imageChanged):
(WebCore::RenderImage::notifyFinished):
- rendering/RenderInline.cpp:
(WebCore::RenderInline::willBeDestroyed):
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::removeChild):
(WebCore::RenderLayer::calculateClipRects):
- rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::notifyFlushRequired):
- rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::layerWillBeRemoved):
(WebCore::RenderLayerCompositor::fixedRootBackgroundLayerChanged):
- rendering/RenderLineBreak.cpp:
(WebCore::RenderLineBreak::deleteInlineBoxWrapper):
- rendering/RenderNamedFlowFragment.cpp:
(WebCore::RenderNamedFlowFragment::attachRegion):
- rendering/RenderObject.cpp:
(WebCore::RenderObject::resetFlowThreadStateOnRemoval):
(WebCore::RenderObject::willBeDestroyed):
(WebCore::RenderObject::destroyAndCleanupAnonymousWrappers):
- rendering/RenderObject.h:
(WebCore::RenderObject::renderTreeBeingDestroyed):
(WebCore::RenderObject::documentBeingDestroyed): Deleted.
- rendering/RenderQuote.cpp:
(WebCore::RenderQuote::detachQuote):
- rendering/RenderRegion.cpp:
(WebCore::RenderRegion::attachRegion):
- rendering/RenderReplaced.cpp:
(WebCore::RenderReplaced::willBeDestroyed):
- rendering/RenderRubyRun.cpp:
(WebCore::RenderRubyRun::removeChild):
- rendering/RenderTable.h:
(WebCore::RenderTable::setNeedsSectionRecalc):
- rendering/RenderText.cpp:
(WebCore::RenderText::removeAndDestroyTextBoxes):
- rendering/RenderVideo.cpp:
(WebCore::RenderVideo::updatePlayer):
- rendering/svg/RenderSVGResource.cpp:
(WebCore::RenderSVGResource::markForLayoutAndParentResourceInvalidation):
- rendering/svg/RenderSVGResourceContainer.cpp:
(WebCore::RenderSVGResourceContainer::markClientForInvalidation):
- rendering/svg/RenderSVGText.cpp:
(WebCore::RenderSVGText::subtreeChildWasAdded):
(WebCore::RenderSVGText::subtreeChildWillBeRemoved):
(WebCore::RenderSVGText::subtreeChildWasRemoved):
(WebCore::RenderSVGText::subtreeStyleDidChange):
- 5:11 PM Changeset in webkit [214081] by
-
- 7 edits2 deletes in branches/safari-603.1.30.0-branch/LayoutTests
Unreviewed test gardening.
LayoutTests/imported/w3c:
- web-platform-tests/html/browsers/origin/cross-origin-objects/cross-origin-objects-expected.txt:
LayoutTests:
- TestExpectations:
- compositing/canvas/accelerated-canvas-compositing-size-limit-expected.txt:
- pageoverlay/overlay-remove-reinsert-view-expected.txt:
- platform/mac-wk2/TestExpectations:
- workers/sab/sent-from-worker-transfer-expected.txt: Removed.
- workers/sab/sent-from-worker-transfer.html: Removed.
- 5:05 PM Changeset in webkit [214080] by
-
- 24 edits2 adds in trunk
Wrap legacy WebRTC API in runtime flag
https://bugs.webkit.org/show_bug.cgi?id=169646
Patch by Youenn Fablet <youenn@apple.com> on 2017-03-16
Reviewed by Alex Christensen.
Source/WebCore:
Test: webrtc/legacy-api.html
Adding a runtime flag for legacy API.
Making some WebIDL peer connection members runtime-enabled.
Adding a JS private getter on this flag so that overloaded operations behave as promise-based only if flag is turned off.
- Modules/mediastream/RTCPeerConnection.idl:
- Modules/mediastream/RTCPeerConnectionInternals.js:
- bindings/js/JSDOMGlobalObject.cpp:
(WebCore::isWebRTCLegacyAPIEnabled):
(WebCore::JSDOMGlobalObject::addBuiltinGlobals):
- bindings/js/WebCoreBuiltinNames.h:
- page/RuntimeEnabledFeatures.h:
(WebCore::RuntimeEnabledFeatures::webRTCLegacyAPIEnabled):
(WebCore::RuntimeEnabledFeatures::setWebRTCLegacyAPIEnabled):
Source/WebKit/mac:
- WebView/WebPreferenceKeysPrivate.h:
- WebView/WebPreferences.mm:
(+[WebPreferences initialize]):
(-[WebPreferences webRTCLegacyAPIEnabled]):
(-[WebPreferences setWebRTCLegacyAPIEnabled:]):
- WebView/WebPreferencesPrivate.h:
- WebView/WebView.mm:
(-[WebView _preferencesChanged:]):
Source/WebKit2:
Adding preference to legacy API.
- Shared/WebPreferencesDefinitions.h:
- UIProcess/API/C/WKPreferences.cpp:
(WKPreferencesSetWebRTCLegacyAPIEnabled):
(WKPreferencesGetWebRTCLegacyAPIEnabled):
- UIProcess/API/C/WKPreferencesRef.h:
- WebProcess/InjectedBundle/InjectedBundle.cpp:
(WebKit::InjectedBundle::overrideBoolPreferenceForTestRunner):
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::updatePreferences):
Tools:
- DumpRenderTree/mac/DumpRenderTree.mm:
(enableExperimentalFeatures):
- WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
- WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
(WTR::InjectedBundle::beginTesting):
- WebKitTestRunner/InjectedBundle/TestRunner.cpp:
(WTR::TestRunner::setWebRTCLegacyAPIEnabled):
- WebKitTestRunner/InjectedBundle/TestRunner.h:
LayoutTests:
- webrtc/legacy-api-expected.txt: Added.
- webrtc/legacy-api.html: Added.
- 4:51 PM Changeset in webkit [214079] by
-
- 2 edits in trunk/Source/JavaScriptCore
Array concat operation should check for length overflows.
https://bugs.webkit.org/show_bug.cgi?id=169796
<rdar://problem/31095276>
Reviewed by Keith Miller.
- runtime/ArrayPrototype.cpp:
(JSC::concatAppendOne):
(JSC::arrayProtoPrivateFuncConcatMemcpy):
- 4:30 PM Changeset in webkit [214078] by
-
- 14 edits1 move in trunk
Update the WKHTTPCookieStore API to be simpler and add observers.
<rdar://problem/31096000> and https://bugs.webkit.org/show_bug.cgi?id=169776
Reviewed by Alex Christensen.
Source/WebKit2:
When reviewing the API internally we realized the NSHTTPCookieStorage model doesn't
necessarily fit perfectly, and that to handle partitioned cookies going forward we
need to be much simpler right now.
We also realized that we should implement the "cookie store changed" observer for
any clients that might be providing a cookie viewing API.
- UIProcess/API/APIHTTPCookieStore.cpp:
(API::HTTPCookieStore::~HTTPCookieStore):
(API::HTTPCookieStore::deleteCookie):
(API::APIWebCookieManagerProxyObserver::APIWebCookieManagerProxyObserver):
(API::HTTPCookieStore::registerObserver):
(API::HTTPCookieStore::unregisterObserver):
(API::HTTPCookieStore::cookiesDidChange):
(API::HTTPCookieStore::cookieManagerDestroyed):
(API::HTTPCookieStore::registerForNewProcessPoolNotifications):
(API::HTTPCookieStore::unregisterForNewProcessPoolNotifications):
(API::HTTPCookieStore::setCookies): Deleted.
(API::HTTPCookieStore::removeCookiesSinceDate): Deleted.
(API::HTTPCookieStore::setHTTPCookieAcceptPolicy): Deleted.
(API::HTTPCookieStore::getHTTPCookieAcceptPolicy): Deleted.
- UIProcess/API/APIHTTPCookieStore.h:
- UIProcess/API/Cocoa/WKHTTPCookieStore.h:
- UIProcess/API/Cocoa/WKHTTPCookieStore.mm:
(WKHTTPCookieStoreObserver::WKHTTPCookieStoreObserver):
(-[WKHTTPCookieStore dealloc]):
(-[WKHTTPCookieStore allCookies:]):
(-[WKHTTPCookieStore addObserver:]):
(-[WKHTTPCookieStore removeObserver:]):
(-[WKHTTPCookieStore fetchCookies:]): Deleted.
(-[WKHTTPCookieStore fetchCookiesForURL:completionHandler:]): Deleted.
(-[WKHTTPCookieStore setCookies:forURL:mainDocumentURL:completionHandler:]): Deleted.
(-[WKHTTPCookieStore removeCookiesSinceDate:completionHandler:]): Deleted.
(-[WKHTTPCookieStore setCookieAcceptPolicy:completionHandler:]): Deleted.
(kitCookiePolicyToNSCookiePolicy): Deleted.
(-[WKHTTPCookieStore fetchCookieAcceptPolicy:]): Deleted.
- UIProcess/Cocoa/WebProcessPoolCocoa.mm:
(WebKit::WebProcessPool::platformInitializeNetworkProcess):
- UIProcess/WebCookieManagerProxy.cpp:
(WebKit::WebCookieManagerProxy::~WebCookieManagerProxy):
(WebKit::WebCookieManagerProxy::processPoolDestroyed):
(WebKit::WebCookieManagerProxy::registerObserver):
(WebKit::WebCookieManagerProxy::unregisterObserver):
(WebKit::WebCookieManagerProxy::cookiesDidChange):
(WebKit::WebCookieManagerProxy::setCookieObserverCallback): Deleted.
- UIProcess/WebCookieManagerProxy.h:
(WebKit::WebCookieManagerProxy::Observer::~Observer):
Add the ability for interested clients to listen for the creation of new WebProcessPools,
which is needed by APIHTTPCookieStore:
- UIProcess/WebProcessPool.cpp:
(WebKit::generateListenerIdentifier):
(WebKit::processPoolCreationListenerFunctionMap):
(WebKit::WebProcessPool::registerProcessPoolCreationListener):
(WebKit::WebProcessPool::unregisterProcessPoolCreationListener):
(WebKit::WebProcessPool::create):
- UIProcess/WebProcessPool.h:
- UIProcess/WebsiteData/WebsiteDataStore.cpp:
(WebKit::WebsiteDataStore::processPoolForCookieStorageNotifications):
(WebKit::WebsiteDataStore::isAssociatedProcessPool):
(WebKit::WebsiteDataStore::processPools):
- UIProcess/WebsiteData/WebsiteDataStore.h:
Tools:
- TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
- TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStore.mm: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStorage.mm.
(-[CookieObserver cookiesDidChangeInCookieStore:]):
(TEST): Also test delete and observers.
- 4:19 PM Changeset in webkit [214077] by
-
- 4 edits in trunk/Source/WebInspectorUI
Web Inspector: add "Save Selected" context menu item to Console
https://bugs.webkit.org/show_bug.cgi?id=151837
Reviewed by Joseph Pecoraro.
- Localizations/en.lproj/localizedStrings.js:
- UserInterface/Base/Main.js:
(WebInspector.saveDataToFile):
Allow data to be saved without a provided URL. It will default to localized "Untitled".
- UserInterface/Views/LogContentView.js:
(WebInspector.LogContentView.prototype._handleContextMenuEvent):
- 4:11 PM Changeset in webkit [214076] by
-
- 3 edits in trunk/Source/WebInspectorUI
Web Inspector: RTL: selected frame indicator is not positioned correctly
https://bugs.webkit.org/show_bug.cgi?id=169763
Reviewed by Matt Baker.
- UserInterface/Views/RenderingFrameTimelineOverviewGraph.js:
(WebInspector.RenderingFrameTimelineOverviewGraph.prototype._updateFrameMarker):
(WebInspector.RenderingFrameTimelineOverviewGraph.prototype._mouseClicked):
Treat the current mouse position (event.pageX) as a negative value when in RTL, meaning that
the delta movement from the starting position is flipped.
- UserInterface/Views/TimelineRuler.css:
(body[dir=ltr] .timeline-ruler > .header > .divider,):
(body[dir=rtl] .timeline-ruler > .header > .divider,):
(.timeline-ruler > .header > .divider):
(.timeline-ruler > .header > .divider > .label):
(body[dir=ltr] .timeline-ruler > .header > .divider > .label):
(body[dir=rtl] .timeline-ruler > .header > .divider > .label):
(.timeline-ruler > .markers > .divider):
(.timeline-ruler > .markers > .marker):
(body[dir=ltr] .timeline-ruler > .markers > .marker):
(body[dir=rtl] .timeline-ruler > .markers > .marker):
(.timeline-ruler > .markers > .marker::before):
(body[dir=ltr] .timeline-ruler > .markers > .marker::before):
(body[dir=rtl] .timeline-ruler > .markers > .marker::before):
(body[dir=ltr] .timeline-ruler > .markers > .marker.current-time):
(body[dir=rtl] .timeline-ruler > .markers > .marker.current-time):
(.timeline-ruler > .markers > .marker.current-time::before):
(.timeline-ruler > .markers > .marker.current-time): Deleted.
(.timeline-ruler > .selection-handle):
(body[dir=ltr] .timeline-ruler > .selection-handle.left):
(body[dir=rtl] .timeline-ruler > .selection-handle.left):
(body[dir=ltr] .timeline-ruler > .selection-handle.right):
(body[dir=rtl] .timeline-ruler > .selection-handle.right):
Drive-by: add CSS variable for clarity.
- 3:53 PM Changeset in webkit [214075] by
-
- 14 edits in trunk/LayoutTests
Rebase webrtc tests
https://bugs.webkit.org/show_bug.cgi?id=169791
Unreviewed.
Patch by Youenn Fablet <youenn@apple.com> on 2017-03-16
- TestExpectations:
- fast/mediastream/MediaStream-add-remove-tracks-expected.txt:
- fast/mediastream/MediaStreamTrack-expected.txt:
- fast/mediastream/MediaStreamTrack-onended-expected.txt:
- fast/mediastream/RTCPeerConnection-addIceCandidate-expected.txt:
- fast/mediastream/RTCPeerConnection-events-expected.txt:
- fast/mediastream/RTCPeerConnection-media-setup-single-dialog-expected.txt:
- fast/mediastream/RTCPeerConnection-media-setup-two-dialogs-expected.txt:
- fast/mediastream/RTCPeerConnection-remotely-assigned-transceiver-mid-expected.txt:
- fast/mediastream/RTCPeerConnection-setLocalDescription-offer-expected.txt:
- fast/mediastream/RTCPeerConnection-setRemoteDescription-offer-expected.txt:
- fast/mediastream/RTCPeerConnection-statsSelector-expected.txt:
- platform/mac/TestExpectations:
- 3:32 PM Changeset in webkit [214074] by
-
- 18 edits6 copies43 adds in trunk
[WebCrypto] Support SPKI/PKCS8 for Elliptic Curve
https://bugs.webkit.org/show_bug.cgi?id=169318
<rdar://problem/31081956>
Reviewed by Brent Fulgham.
LayoutTests/imported/w3c:
- web-platform-tests/WebCryptoAPI/import_export/ec_importKey.worker-expected.txt:
- web-platform-tests/WebCryptoAPI/import_export/test_ec_importKey-expected.txt:
Source/WebCore:
This patch adds SPKI/PKCS8 support for Elliptic Curve cryptos. We can now import/export
SPKI/PKCS8 Elliptic Curve keys after this change. Few things to note: 1) This patch
implements a loose DER encoder/decoder for hacking the underlying CommonCrypto library.
2) It only permits id-ecPublicKey as the AlgorithmIdentifier following OpenSSL/Chrome(BoringSSL).
3) It follows OpenSSL/Chrome(BoringSSL) to replace ECParameters in ECPrivateKey with custom
tags. Hence, we should fully comply with OpenSSL/Chrome(BoringSSL).
Tests: crypto/subtle/ec-import-jwk-key-export-pkcs8-key.html
crypto/subtle/ec-import-jwk-key-export-spki-key.html
crypto/subtle/ec-import-pkcs8-key-export-jwk-key.html
crypto/subtle/ec-import-pkcs8-key-export-pkcs8-key-p256.html
crypto/subtle/ec-import-pkcs8-key-export-pkcs8-key-p384.html
crypto/subtle/ec-import-raw-key-export-spki-key.html
crypto/subtle/ec-import-spki-key-export-jwk-key.html
crypto/subtle/ec-import-spki-key-export-raw-key.html
crypto/subtle/ec-import-spki-key-export-spki-key-p256.html
crypto/subtle/ec-import-spki-key-export-spki-key-p384.html
crypto/subtle/ecdh-generate-export-key-spki-p256.html
crypto/subtle/ecdh-generate-export-key-spki-p384.html
crypto/subtle/ecdh-generate-export-pkcs8-p256.html
crypto/subtle/ecdh-generate-export-pkcs8-p384.html
crypto/subtle/ecdh-import-pkcs8-key-p256.html
crypto/subtle/ecdh-import-pkcs8-key-p384.html
crypto/subtle/ecdh-import-spki-key-p256.html
crypto/subtle/ecdh-import-spki-key-p384.html
crypto/workers/subtle/ec-generate-export-pkcs8-key.html
crypto/workers/subtle/ec-generate-export-spki-key.html
crypto/workers/subtle/ec-import-pkcs8-key.html
crypto/workers/subtle/ec-import-spki-key.html
- WebCore.xcodeproj/project.pbxproj:
- crypto/algorithms/CryptoAlgorithmECDH.cpp:
(WebCore::CryptoAlgorithmECDH::importKey):
(WebCore::CryptoAlgorithmECDH::exportKey):
- crypto/gnutls/CryptoKeyECGnuTLS.cpp:
(WebCore::CryptoKeyEC::platformExportRaw):
(WebCore::CryptoKeyEC::platformImportSpki):
(WebCore::CryptoKeyEC::platformExportSpki):
(WebCore::CryptoKeyEC::platformImportPkcs8):
(WebCore::CryptoKeyEC::platformExportPkcs8):
(WebCore::CryptoKeyEC::exportRaw): Deleted.
- crypto/keys/CryptoKeyEC.cpp:
(WebCore::CryptoKeyEC::importSpki):
(WebCore::CryptoKeyEC::importPkcs8):
(WebCore::CryptoKeyEC::exportRaw):
(WebCore::CryptoKeyEC::exportSpki):
(WebCore::CryptoKeyEC::exportPkcs8):
- crypto/keys/CryptoKeyEC.h:
- crypto/mac/CommonCryptoDERUtilities.h: Added.
(WebCore::bytesUsedToEncodedLength):
(WebCore::extraBytesNeededForEncodedLength):
(WebCore::addEncodedASN1Length):
(WebCore::bytesNeededForEncodedLength):
- crypto/mac/CryptoKeyECMac.cpp:
(WebCore::compareBytes):
(WebCore::CryptoKeyEC::platformExportRaw):
(WebCore::CryptoKeyEC::platformImportJWKPrivate):
(WebCore::getOID):
(WebCore::CryptoKeyEC::platformImportSpki):
(WebCore::CryptoKeyEC::platformExportSpki):
(WebCore::CryptoKeyEC::platformImportPkcs8):
(WebCore::CryptoKeyEC::platformExportPkcs8):
(WebCore::CryptoKeyEC::exportRaw): Deleted.
Enlarge the robust of exportRaw.
- crypto/mac/CryptoKeyRSAMac.cpp:
(WebCore::CryptoKeyRSA::exportSpki):
(WebCore::CryptoKeyRSA::exportPkcs8):
Enhance the implementation.
(WebCore::bytesUsedToEncodedLength): Deleted.
(WebCore::bytesNeededForEncodedLength): Deleted.
(WebCore::addEncodedASN1Length): Deleted.
Moved to CommonCryptoDERUtilities.h.
LayoutTests:
- crypto/subtle/ec-export-key-malformed-parameters-expected.txt:
- crypto/subtle/ec-export-key-malformed-parameters.html:
- crypto/subtle/ec-import-jwk-key-export-jwk-key-private-expected.txt:
- crypto/subtle/ec-import-jwk-key-export-jwk-key-private.html:
- crypto/subtle/ec-import-jwk-key-export-pkcs8-key-expected.txt: Added.
- crypto/subtle/ec-import-jwk-key-export-pkcs8-key.html: Added.
- crypto/subtle/ec-import-jwk-key-export-spki-key-expected.txt: Added.
- crypto/subtle/ec-import-jwk-key-export-spki-key.html: Added.
- crypto/subtle/ec-import-key-malformed-parameters-expected.txt:
- crypto/subtle/ec-import-key-malformed-parameters.html:
- crypto/subtle/ec-import-pkcs8-key-export-jwk-key-expected.txt: Added.
- crypto/subtle/ec-import-pkcs8-key-export-jwk-key.html: Added.
- crypto/subtle/ec-import-pkcs8-key-export-pkcs8-key-p256-expected.txt: Added.
- crypto/subtle/ec-import-pkcs8-key-export-pkcs8-key-p256.html: Added.
- crypto/subtle/ec-import-pkcs8-key-export-pkcs8-key-p384-expected.txt: Added.
- crypto/subtle/ec-import-pkcs8-key-export-pkcs8-key-p384.html: Added.
- crypto/subtle/ec-import-raw-key-export-spki-key-expected.txt: Added.
- crypto/subtle/ec-import-raw-key-export-spki-key.html: Added.
- crypto/subtle/ec-import-spki-key-export-jwk-key-expected.txt: Added.
- crypto/subtle/ec-import-spki-key-export-jwk-key.html: Added.
- crypto/subtle/ec-import-spki-key-export-raw-key-expected.txt: Added.
- crypto/subtle/ec-import-spki-key-export-raw-key.html: Added.
- crypto/subtle/ec-import-spki-key-export-spki-key-p256-expected.txt: Added.
- crypto/subtle/ec-import-spki-key-export-spki-key-p256.html: Added.
- crypto/subtle/ec-import-spki-key-export-spki-key-p384-expected.txt: Added.
- crypto/subtle/ec-import-spki-key-export-spki-key-p384.html: Added.
- crypto/subtle/ecdh-generate-export-key-spki-p256-expected.txt: Added.
- crypto/subtle/ecdh-generate-export-key-spki-p256.html: Added.
- crypto/subtle/ecdh-generate-export-key-spki-p384-expected.txt: Added.
- crypto/subtle/ecdh-generate-export-key-spki-p384.html: Added.
- crypto/subtle/ecdh-generate-export-pkcs8-p256-expected.txt: Added.
- crypto/subtle/ecdh-generate-export-pkcs8-p256.html: Added.
- crypto/subtle/ecdh-generate-export-pkcs8-p384-expected.txt: Added.
- crypto/subtle/ecdh-generate-export-pkcs8-p384.html: Added.
- crypto/subtle/ecdh-import-pkcs8-key-p256-expected.txt: Added.
- crypto/subtle/ecdh-import-pkcs8-key-p256.html: Added.
- crypto/subtle/ecdh-import-pkcs8-key-p384-expected.txt: Added.
- crypto/subtle/ecdh-import-pkcs8-key-p384.html: Added.
- crypto/subtle/ecdh-import-spki-key-p256-expected.txt: Added.
- crypto/subtle/ecdh-import-spki-key-p256.html: Added.
- crypto/subtle/ecdh-import-spki-key-p384-expected.txt: Added.
- crypto/subtle/ecdh-import-spki-key-p384.html: Added.
- crypto/workers/subtle/ec-generate-export-pkcs8-key-expected.txt: Added.
- crypto/workers/subtle/ec-generate-export-pkcs8-key.html: Added.
- crypto/workers/subtle/ec-generate-export-spki-key-expected.txt: Added.
- crypto/workers/subtle/ec-generate-export-spki-key.html: Added.
- crypto/workers/subtle/ec-import-pkcs8-key-expected.txt: Added.
- crypto/workers/subtle/ec-import-pkcs8-key.html: Added.
- crypto/workers/subtle/ec-import-spki-key-expected.txt: Added.
- crypto/workers/subtle/ec-import-spki-key.html: Added.
- crypto/workers/subtle/resources/ec-generate-export-pkcs8-key.js: Added.
- crypto/workers/subtle/resources/ec-generate-export-spki-key.js: Added.
- crypto/workers/subtle/resources/ec-import-pkcs8-key.js: Added.
- crypto/workers/subtle/resources/ec-import-spki-key.js: Added.
- 3:15 PM Changeset in webkit [214073] by
-
- 6 edits in trunk/Source/WebCore
Don't use an optional for didReceiveSocketStreamData's length
https://bugs.webkit.org/show_bug.cgi?id=169699
Reviewed by Brady Eidson.
Rather than sending a message with an optional length, send a message with a length
and send a different message if the receiving of bytes failed.
No new tests (no behavior change).
- Modules/websockets/WebSocketChannel.cpp:
(WebCore::WebSocketChannel::didReceiveSocketStreamData):
- Modules/websockets/WebSocketChannel.h:
- platform/network/SocketStreamHandleClient.h:
- platform/network/cf/SocketStreamHandleImplCFNet.cpp:
(WebCore::SocketStreamHandleImpl::readStreamCallback):
- platform/network/soup/SocketStreamHandleImplSoup.cpp:
(WebCore::SocketStreamHandleImpl::readBytes):
- 3:14 PM Changeset in webkit [214072] by
-
- 5 edits2 adds in trunk
Simple line layout: Extend webkit-hyphenate-limit-lines to cover subsequent words.
https://bugs.webkit.org/show_bug.cgi?id=169631
Reviewed by Antti Koivisto.
Source/WebCore:
This patch extends webkit-hyphenate-limit-lines to cover separate words across multiple lines.
Example:
webkit-hyphenate-limit-lines: 1;
"if this line wraps at foo-
bar, the next line should
not hyphenate at all. How-
ever the line after that
could."
Test: fast/text/simple-line-layout-hyphenation-limit-lines-accross-words.html
- rendering/SimpleLineLayout.cpp:
(WebCore::SimpleLineLayout::LineState::setHyphenationDisabled):
(WebCore::SimpleLineLayout::LineState::isHyphenationDisabled):
(WebCore::SimpleLineLayout::updateLineConstrains):
(WebCore::SimpleLineLayout::hyphenPositionForFragment):
(WebCore::SimpleLineLayout::splitFragmentToFitLine):
(WebCore::SimpleLineLayout::createLineRuns):
(WebCore::SimpleLineLayout::createTextRuns):
- rendering/SimpleLineLayoutTextFragmentIterator.h:
(WebCore::SimpleLineLayout::TextFragmentIterator::TextFragment::hasHyphen):
(WebCore::SimpleLineLayout::TextFragmentIterator::TextFragment::splitWithHyphen):
(WebCore::SimpleLineLayout::TextFragmentIterator::TextFragment::wrappingWithHyphenCounter): Deleted.
LayoutTests:
- fast/text/simple-line-layout-hyphenation-limit-lines-accross-words-expected.html: Added.
- fast/text/simple-line-layout-hyphenation-limit-lines-accross-words.html: Added.
- 2:53 PM Changeset in webkit [214071] by
-
- 8 edits in trunk/Source/JavaScriptCore
The new array with spread operation needs to check for length overflows.
https://bugs.webkit.org/show_bug.cgi?id=169780
<rdar://problem/31072182>
Reviewed by Filip Pizlo.
- dfg/DFGOperations.cpp:
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compileNewArrayWithSpread):
- ftl/FTLLowerDFGToB3.cpp:
(JSC::FTL::DFG::LowerDFGToB3::compileNewArrayWithSpread):
- ftl/FTLOperations.cpp:
(JSC::FTL::operationMaterializeObjectInOSR):
- llint/LLIntSlowPaths.cpp:
- runtime/CommonSlowPaths.cpp:
(JSC::SLOW_PATH_DECL):
- runtime/JSGlobalObject.cpp:
- 2:49 PM Changeset in webkit [214070] by
-
- 4 edits2 adds in trunk/Source/WebKit2
[iOS WK2] Web Automation: implement platform methods for simulating keyboard events
https://bugs.webkit.org/show_bug.cgi?id=169487
<rdar://problem/28360564>
Reviewed by Joseph Pecoraro.
Reimplement platformSimulateKey{Stroke, Sequence} to simulate events coming from UIKit.
These events are sent directly into WebCore without going through the keyboard system,
since we don't need to show the keyboard when simulating keystrokes. For example, the
keystrokes may not be representable given the current keyboard layout and system language.
- UIProcess/Automation/WebAutomationSession.cpp:
- UIProcess/Automation/WebAutomationSession.h:
Un-stub implementations that now exist for iOS.
- UIProcess/Automation/ios/WebAutomationSessionIOS.mm: Added.
(WebKit::WebAutomationSession::sendSynthesizedEventsToPage): Added.
This is similar to the Mac version, but it sends events directly into WebPageProxy
instead of sending them to the NSWindow containing the WebView.
(WebKit::WebAutomationSession::platformSimulateKeyStroke):
Use a somewhat different strategy for determining the charCode/keyCode since we cannot
rely on the system keyboard / input manager to generate and deliver real key events.
Compared to the Mac platform method, this requires setting up fewer fields and does
not use AppKit's current modifier state to determine the effect of sticky modifiers.
(WebKit::WebAutomationSession::platformSimulateKeySequence):
This is almost verbatim from the Mac platform method but uses a different event class.
- WebKit2.xcodeproj/project.pbxproj: Add new file.
- 2:19 PM Changeset in webkit [214069] by
-
- 14 edits3 adds in trunk
FTL should support global and eval code
https://bugs.webkit.org/show_bug.cgi?id=169656
Reviewed by Geoffrey Garen and Saam Barati.
JSTests:
Added basic performance tests of global and eval code. These tests will run a lot faster in with
the FTL because of the object allocation.
- microbenchmarks/eval-code-ftl-reentry.js: Added.
- microbenchmarks/eval-code-ftl.js: Added.
- microbenchmarks/global-code-ftl.js: Added.
- stress/arith-log-on-various-types.js: This was a flaky fail with concurrent JIT, so I stopped running it with concurrent JIT. The failure was its assertion about how many times something gets compiled.
Source/JavaScriptCore:
Turned off the restriction against global and eval code running in the FTL, and then fixed all of
the things that didn't work.
This is a big speed-up on microbenchmarks that I wrote for this patch. One of the reasons why we
hadn't done this earlier is that we've never seen a benchmark that needed it. Global and eval
code rarely gets FTL-hot. Still, this seems like possibly a small JetStream speed-up.
- dfg/DFGJITCode.cpp:
(JSC::DFG::JITCode::setOSREntryBlock): I outlined this for better debugging.
- dfg/DFGJITCode.h:
(JSC::DFG::JITCode::setOSREntryBlock): Deleted.
- dfg/DFGNode.h:
(JSC::DFG::Node::isSemanticallySkippable): It turns out that global code often has InvalidationPoints before LoopHints. They are also skippable from the standpoint of OSR entrypoint analysis.
- dfg/DFGOperations.cpp: Don't do any normal compiles of global code - just do OSR compiles.
- ftl/FTLCapabilities.cpp: Enable FTL for global and eval code.
(JSC::FTL::canCompile):
- ftl/FTLCompile.cpp: Just debugging clean-ups.
(JSC::FTL::compile):
- ftl/FTLJITFinalizer.cpp: Implement finalize() and ensure that we only do things with the entrypoint buffer if we have one. We won't have one for eval code that we aren't OSR entering into.
(JSC::FTL::JITFinalizer::finalize):
(JSC::FTL::JITFinalizer::finalizeFunction):
(JSC::FTL::JITFinalizer::finalizeCommon):
- ftl/FTLJITFinalizer.h:
- ftl/FTLLink.cpp: When entering a function normally, we need the "entrypoint" to put the arity check code. Global and eval code don't need this.
(JSC::FTL::link):
- ftl/FTLOSREntry.cpp: Fix a dataLog statement.
(JSC::FTL::prepareOSREntry):
- ftl/FTLOSRExitCompiler.cpp: Remove dead code that happened to assert that we're exiting from a function.
(JSC::FTL::compileStub):
- 2:10 PM Changeset in webkit [214068] by
-
- 2 edits in trunk/Source/JavaScriptCore
WebAssembly: function-tests/load-offset.js fails on ARM64
https://bugs.webkit.org/show_bug.cgi?id=169724
Reviewed by Keith Miller.
We need to use the two source version of Add64 to create a Wasm address with the
other source the first child.
- b3/B3LowerToAir.cpp:
(JSC::B3::Air::LowerToAir::lower):
- 1:55 PM Changeset in webkit [214067] by
-
- 2 edits in trunk/Tools
Fix quotes around --pretty format git flag.
https://bugs.webkit.org/show_bug.cgi?id=169712
Patch by Kocsen Chung <Kocsen Chung> on 2017-03-16
Reviewed by Ryosuke Niwa.
Remove double quotes from command list element '--pretty="format:%ct"' since it will cause
subprocess to not work as expected.
Additionally, take advantage ofgit -Cflag.
- Scripts/webkitpy/common/checkout/scm/git.py:
(Git.native_revision):
Take advantage ofgit -Cflag.
(Git.timestamp_of_native_revision):
Take advantage ofgit -Cflag and remove double quotes from git formatter.
We know this works fromcommitter_email_for_revision()function.
- 1:53 PM Changeset in webkit [214066] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: RTL: filter mode icon in Debugger sidebar is misaligned
https://bugs.webkit.org/show_bug.cgi?id=169766
Reviewed by Matt Baker.
- UserInterface/Views/FilterBar.css:
(.filter-bar > .navigation-bar > .item):
(body[dir=ltr] .filter-bar > .navigation-bar > .item):
(body[dir=rtl] .filter-bar > .navigation-bar > .item):
- 1:53 PM Changeset in webkit [214065] by
-
- 15 edits8 adds in trunk/Websites/perf.webkit.org
Add the file uploading capability to the perf dashboard.
https://bugs.webkit.org/show_bug.cgi?id=169737
Reviewed by Chris Dumez.
Added /privileged-api/upload-file to upload a file, and /api/uploaded-file/ to download the file
and retrieve its meta data based on its SHA256. We treat two files with the identical SHA256 as
identical since anyone who can upload a file using this mechanism can execute arbitrary code in
our bots anyway. This is important for avoiding uploading a large darwinup roots multiple times
to the server, saving both user's time/bandwidth and server's disk space.
- config.json: Added uploadDirectory, uploadFileLimitInMB, and uploadUserQuotaInMB as options.
- init-database.sql: Added uploaded_files table.
- public/api/uploaded-file.php: Added.
(main): /api/uploaded-file/N would download uploaded_file with id=N. /api/uploaded-file/?sha256=X
would return the meta data for uploaded_file with sha256=X.
(stream_file_content): Streams the file content in 64KB chunks. We support Range & If-Range HTTP
request headers so that browsers can pause and resume downloading of a large root file.
(parse_range_header): Parses Range HTTP request header.
- public/include/json-header.php:
(remote_user_name): Use the default argument of NULL.
- public/include/manifest-generator.php:
(ManifestGenerator::generate): Include the maximum upload size in the manifest file to let the
frontend code preemptively check the file size before attempting to submit a file.
- public/include/uploaded-file-helpers.php: Added.
(format_uploaded_file):
(uploaded_file_path_for_row):
- public/privileged-api/upload-file-form.html: Added. For debugging purposes.
(fetchCSRFfToken):
(upload):
- public/privileged-api/upload-file.php: Added.
(main):
(query_total_file_size):
(create_uploaded_file_from_form_data):
- public/shared/common-remote.js:
(CommonRemoteAPI.prototype.postFormData): Added.
(CommonRemoteAPI.prototype.postFormDataWithStatus): Added.
(CommonRemoteAPI.prototype.sendHttpRequestWithFormData): Added.
(CommonRemoteAPI.prototype._asJSON): Throw an exception instead of calling a non-existent reject.
- public/v3/models/uploaded-file.js: Added.
(UploadedFile): Added.
(UploadedFile.uploadFile): Added.
(UploadedFile.fetchUnloadedFileWithIdenticalHash): Added. Finds the file with the same SHA256 in
the server to avoid uploading a large custom root multiple times.
(UploadedFile._computeSHA256Hash): Added.
- public/v3/privileged-api.js:
(PrivilegedAPI.prototype.sendRequest): Added the options dictionary as a third argument. For now,
only support useFormData boolean.
- public/v3/remote.js:
(BrowserRemoteAPI.prototype.sendHttpRequestWithFormData): Added.
- server-tests/api-manifest.js: Updated per the inclusion of fileUploadSizeLimit in the manifest.
- server-tests/api-uploaded-file.js: Added.
- server-tests/privileged-api-upload-file-tests.js: Added.
- server-tests/resources/temporary-file.js: Added.
(TemporaryFile): Added. A helper class for creating a temporary file to upload.
(TemporaryFile.makeTemporaryFileOfSizeInMB):
(TemporaryFile.makeTemporaryFile):
(TemporaryFile.inject):
- server-tests/resources/test-server.conf: Set upload_max_filesize and post_max_size for testing.
- server-tests/resources/test-server.js:
(TestServer.prototype.testConfig): Use uploadFileLimitInMB and uploadUserQuotaInMB of 2MB and 5MB.
(TestServer.prototype._ensureDataDirectory): Create a directory to store uploaded files inside
the data directory. In a production server, we can place it outside ServerRoot / DocumentRoot.
(TestServer.prototype.cleanDataDirectory): Delete the aforementioned directory as needed.
- tools/js/database.js:
(tableToPrefixMap): Added uploaded_files.
- tools/js/remote.js:
(NodeRemoteAPI.prototype.sendHttpRequest): Added a dictionary to specify request headers and
a callback to process the response as arguments. Fixed the bug that any 2xx code other than 200
was resulting in a rejected promise. Also include the response headers in the result for tests.
Finally, when content is a function, call that instead of writing the content since FormData
requires a custom logic.
(NodeRemoteAPI.prototype.sendHttpRequestWithFormData): Added.
- tools/js/v3-models.js: Include uploaded-file.js.
- tools/run-tests.py:
(main): Add form-data as a new dependency.
- 1:50 PM Changeset in webkit [214064] by
-
- 5 edits1 delete in trunk/Source/WebInspectorUI
Web Inspector: Refactoring: remove DebuggerTreeElement class
https://bugs.webkit.org/show_bug.cgi?id=169697
Reviewed by Devin Rousso.
Remove unnecessary class DebuggerTreeElement from TreeElement class hierarchy.
ThesourceCodeLocationproperty on IssueMessage and Breakpoint (the debugger
objects) can be tested for generically using TreeElement.prototype.representedObject.
- UserInterface/Main.html:
Remove file.
- UserInterface/Views/BreakpointTreeElement.js:
- UserInterface/Views/IssueTreeElement.js:
Change base class to GeneralTreeElement.
- UserInterface/Views/DebuggerSidebarPanel.js:
(WebInspector.DebuggerSidebarPanel.prototype._addBreakpoint):
(WebInspector.DebuggerSidebarPanel.prototype._compareTreeElements):
(WebInspector.DebuggerSidebarPanel.prototype._addIssue):
(WebInspector.DebuggerSidebarPanel.prototype._compareDebuggerTreeElements): Deleted.
Renamed to just "_compareTreeElements".
- UserInterface/Views/DebuggerTreeElement.js: Removed.
- 1:42 PM Changeset in webkit [214063] by
-
- 6 edits in trunk
[mac-wk2 debug] LayoutTest webrtc/video-mute.html is timing out
https://bugs.webkit.org/show_bug.cgi?id=169758
Patch by Youenn Fablet <youenn@apple.com> on 2017-03-16
Reviewed by Eric Carlson.
Source/WebKit2:
Test is timing out due to the UIProcess requesting to disable/enable ICE candidate filtering
on a page whose preference is set to not enabling ICE candidate filtering.
Current fix is to act upon what UI process asks if the page preference is to enable ICE candidate filtering.
If ICE candidate filtering preference is disable for that page (WebKitTestRunner case), no disabling/enabling is done at all.
- UIProcess/UserMediaProcessManager.cpp:
(WebKit::UserMediaProcessManager::endedCaptureSession):
- WebProcess/WebPage/WebPage.cpp:
(WebKit::m_backgroundCPULimit):
(WebKit::m_backgroundCPULimit):
(WebKit::WebPage::disableICECandidateFiltering):
(WebKit::WebPage::enableICECandidateFiltering):
- WebProcess/WebPage/WebPage.h:
LayoutTests:
- 1:28 PM Changeset in webkit [214062] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: RTL: goto arrow for source locations is pointing wrong way in Timeline data grids
https://bugs.webkit.org/show_bug.cgi?id=169764
Reviewed by Matt Baker.
- UserInterface/Views/DataGrid.css:
(body[dir=rtl] .data-grid td .go-to-arrow):
- 12:06 PM Changeset in webkit [214061] by
-
- 12 edits in trunk
Clean up WKContentExtension API
https://bugs.webkit.org/show_bug.cgi?id=169772
Reviewed by Geoffrey Garen.
Source/WebKit2:
Based on feedback I have decided to do the following:
- Rename lookup to lookUp because look and up are two words.
- Change the parameter of removeContentExtension to a WKContentExtension* to match addContentExtension.
- Add an identifier property accessor to WKContentExtension.
- Change the order of the new error types. This wasn't exactly based on any feedback, but they look more organized now.
- UIProcess/API/Cocoa/WKContentExtension.h:
- UIProcess/API/Cocoa/WKContentExtension.mm:
(-[WKContentExtension identifier]):
- UIProcess/API/Cocoa/WKContentExtensionStore.h:
- UIProcess/API/Cocoa/WKContentExtensionStore.mm:
(toWKErrorCode):
(-[WKContentExtensionStore lookUpContentExtensionForIdentifier:completionHandler:]):
(-[WKContentExtensionStore lookupContentExtensionForIdentifier:completionHandler:]): Deleted.
- UIProcess/API/Cocoa/WKError.h:
- UIProcess/API/Cocoa/WKError.mm:
(localizedDescriptionForErrorCode):
- UIProcess/API/Cocoa/WKUserContentController.h:
- UIProcess/API/Cocoa/WKUserContentController.mm:
(-[WKUserContentController removeContentExtension:]):
- UIProcess/API/Cocoa/_WKUserContentExtensionStore.mm:
(toUserContentExtensionStoreError):
(-[_WKUserContentExtensionStore lookupContentExtensionForIdentifier:completionHandler:]):
Tools:
- TestWebKitAPI/Tests/WebKit2Cocoa/WKUserContentExtensionStore.mm:
(TEST_F):
(-[ContentExtensionDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
- 11:58 AM Changeset in webkit [214060] by
-
- 2 edits1 add1 delete in trunk/Source/WebCore
[GLib] Add SSLKeyGeneratorGLib.cpp
https://bugs.webkit.org/show_bug.cgi?id=169740
Reviewed by Sergio Villar Senin.
Move the getSupportedKeySizes() and signedPublicKeyAndChallengeString()
functions from TemporaryLinkStubs.cpp to SSLKeyGeneratorGLib.cpp. The
userIdleTime() function can be removed in this process since it's not
used anywhere anymore.
- PlatformGTK.cmake:
- platform/glib/SSLKeyGeneratorGLib.cpp: Renamed from Source/WebCore/platform/gtk/TemporaryLinkStubs.cpp.
(WebCore::getSupportedKeySizes):
(WebCore::signedPublicKeyAndChallengeString):
- 11:43 AM Changeset in webkit [214059] by
-
- 3 edits2 adds in trunk
Stay inside the continuation while searching for a candidate ancestor for insertion.
https://bugs.webkit.org/show_bug.cgi?id=169768
<rdar://problem/30959936>
Reviewed by David Hyatt.
Source/WebCore:
Test: fast/inline/continuation-crash-with-anon-ancestors.html
- rendering/RenderInline.cpp:
(WebCore::RenderInline::addChildToContinuation):
LayoutTests:
- fast/inline/continuation-crash-with-anon-ancestors-expected.txt: Added.
- fast/inline/continuation-crash-with-anon-ancestors.html: Added.
- 11:31 AM Changeset in webkit [214058] by
-
- 1 copy in tags/Safari-603.1.30.4.6
Tag Safari-603.1.30.4.6.
- 11:28 AM Changeset in webkit [214057] by
-
- 3 edits in branches/safari-603-branch/Source/WebKit/win
Merge r213846. rdar://problem/30983702
- 11:28 AM Changeset in webkit [214056] by
-
- 3 edits in branches/safari-603-branch/Source/WebKit/win
Merge r213737. rdar://problem/30983702
- 11:26 AM Changeset in webkit [214055] by
-
- 5 edits in branches/safari-603.1.30.4-branch/Source
Versioning
- 11:18 AM Changeset in webkit [214054] by
-
- 3 edits in branches/safari-603.1.30.4-branch/Source/WebKit/win
Merge r213846. rdar://problem/30983702
- 11:18 AM Changeset in webkit [214053] by
-
- 2 edits in branches/safari-603.1.30.4-branch/Source/WebCore
- 11:18 AM Changeset in webkit [214052] by
-
- 5 edits in branches/safari-603.1.30.4-branch/Source
Versioning.
- 11:01 AM QtWebKitSecurity edited by
- Removed info about 2.2.0 that is not the latest stable release for a … (diff)
- 10:31 AM Changeset in webkit [214051] by
-
- 2 edits in trunk/LayoutTests
Mark fast/mediacapturefromelement/CanvasCaptureMediaStream-request-frame-events.html as flaky.
https://bugs.webkit.org/show_bug.cgi?id=169719
Unreviewed test gardening.
- platform/mac-wk2/TestExpectations:
- 10:20 AM Changeset in webkit [214050] by
-
- 3 edits in trunk/LayoutTests
TestExpectations gardening for modern-media-controls tests.
Unreviewed test gardening.
- platform/mac-wk1/TestExpectations:
- platform/mac/TestExpectations:
- 10:20 AM Changeset in webkit [214049] by
-
- 3 edits in trunk/LayoutTests
Mark imported/w3c/web-platform-tests/IndexedDB/fire-success-event-exception.html as flaky.
https://bugs.webkit.org/show_bug.cgi?id=169760
Unreviewed test gardening.
- platform/ios-simulator-wk2/TestExpectations:
- platform/mac-wk2/TestExpectations:
- 10:19 AM Changeset in webkit [214048] by
-
- 3 edits in trunk/Source/WebInspectorUI
Web Inspector: RTL: add FindBanner support for RTL layout
https://bugs.webkit.org/show_bug.cgi?id=168723
Reviewed by Timothy Hatcher.
Due to the large number of CSS tricks used by this widget, adding RTL
support involves changing a large number of rules. The important parts:
- Use '.segmented.{previous,next}-result' instead of '.segmented.
{left,right}', this makes the style rules way less confusing for RTL.
- Flip icons so icons look like "< >" but actions are reversed.
- Get rid of the weird expanding button divider. This is impossible
to mirror with the existing adjacent sibling combinator, and it does
not match the system appearance. Just replace the mini-divider with a
full divider and remove related dynamic rules that trigger on :active.
- Always keep the button divider between next/previous on the rightmost
button, to avoid subtle differences between LTR and RTL.
- Fix some mistakes where we weren't using --border-color and also
didn't adjust the handcoded border color for the inactive window case.
- UserInterface/Views/FindBanner.css:
(.find-banner):
(body[dir=ltr] .find-banner > :first-child,):
(body[dir=ltr] .find-banner > :last-child,):
(.find-banner > input[type="search"]):
(body[dir=ltr] .find-banner > input[type="search"]):
(body[dir=rtl] .find-banner > input[type="search"]):
(.find-banner > button:active:not(:disabled)):
(.find-banner > button.segmented):
(.find-banner > button.segmented.previous-result):
(body[dir=ltr] .find-banner > button.segmented.previous-result):
(body[dir=rtl] .find-banner > button.segmented.previous-result):
(body[dir=ltr] .find-banner > button.segmented.previous-result > .glyph):
(body[dir=rtl] .find-banner > button.segmented.previous-result > .glyph):
(body[dir=ltr] .find-banner > button.segmented.previous-result:active:not(:disabled) > .glyph):
(body[dir=rtl] .find-banner > button.segmented.previous-result:active:not(:disabled) > .glyph):
(.find-banner > button.segmented.next-result):
(body[dir=ltr] .find-banner > button.segmented.next-result):
(body[dir=rtl] .find-banner > button.segmented.next-result):
(body[dir=ltr] .find-banner > button.segmented.next-result > .glyph):
(body[dir=rtl] .find-banner > button.segmented.next-result > .glyph):
(body[dir=ltr] .find-banner > button.segmented.next-result:active:not(:disabled) > .glyph):
(body[dir=rtl] .find-banner > button.segmented.next-result:active:not(:disabled) > .glyph):
(.find-banner.console-find-banner > input[type="search"]):
(body[dir=ltr] .find-banner.console-find-banner > input[type="search"]):
(body[dir=rtl] .find-banner.console-find-banner > input[type="search"]):
(body[dir=ltr] .find-banner.console-find-banner > input[type="search"]::-webkit-textfield-decoration-container):
(body[dir=rtl] .find-banner.console-find-banner > input[type="search"]::-webkit-textfield-decoration-container):
(.find-banner > :first-child): Deleted.
(.find-banner > :last-child): Deleted.
(.find-banner > button.segmented.left): Deleted.
(.find-banner > button:not(:active).segmented.right:before): Deleted.
(.find-banner > button.segmented.left:active + button.segmented.right,): Deleted.
(.find-banner > button.segmented.left:active + button.segmented.right:before): Deleted.
(.find-banner > button.segmented.left > .glyph): Deleted.
(.find-banner > button.segmented.left:active:not(:disabled) > .glyph): Deleted.
(.find-banner > button.segmented.right): Deleted.
(.find-banner > button.segmented.right > .glyph): Deleted.
(.find-banner > button.segmented.right:active:not(:disabled) > .glyph): Deleted.
(.find-banner.console-find-banner > input[type="search"]::-webkit-textfield-decoration-container): Deleted.
- UserInterface/Views/FindBanner.js:
(WebInspector.FindBanner):
Change left and right to logical names for the buttons, and inline
some style classes with single uses.
- 10:16 AM Changeset in webkit [214047] by
-
- 3 edits2 adds in trunk/LayoutTests
Update test fast/events/pageshow-pagehide-on-back-cached-with-frames.html to ensure
that pageshow events are dispatched to frames in post-order traversal
<https://bugs.webkit.org/show_bug.cgi?id=169682>
Reviewed by Brady Eidson.
- fast/events/pageshow-pagehide-on-back-cached-with-frames-expected.txt:
- fast/events/pageshow-pagehide-on-back-cached-with-frames.html:
- fast/events/resources/pageshow-pagehide-subframe-cachable-2.html: Added.
- fast/events/resources/pageshow-pagehide-subsubframe-cachable-2.html: Added.
- 10:12 AM Changeset in webkit [214046] by
-
- 3 edits in trunk/Tools
webktpy: Fix device regular expression for parsing simctl output
https://bugs.webkit.org/show_bug.cgi?id=169757
Reviewed by Alex Christensen.
If a device is unavailable, the changes in r213164 mean that the
name of the device will consume the UDID and return the state as
the device UDID and the availability string as the device state.
- Scripts/webkitpy/xcode/simulator.py:
(Simulator): Make UDID regular expression more strict.
- Scripts/webkitpy/xcode/simulator_unittest.py: Test an unavailable device.
- 9:49 AM Changeset in webkit [214045] by
-
- 20 edits4 adds in trunk/Source
Add FIXMEs to update WebRTC
https://bugs.webkit.org/show_bug.cgi?id=169735
Reviewed by Youenn Fablet.
Source/JavaScriptCore:
- runtime/CommonIdentifiers.h: Add RTCIceTransport.
Source/WebCore:
Rearrange order of methods and properties based on the 13 March 2017
version of the WebRTC spec.
- CMakeLists.txt: Add RTCIceTransport and RTCIceTransportState.
- DerivedSources.make:
- Modules/mediastream/RTCDTMFSender.idl:
- Modules/mediastream/RTCDTMFToneChangeEvent.idl:
- Modules/mediastream/RTCDataChannelEvent.idl:
- Modules/mediastream/RTCIceCandidate.idl:
- Modules/mediastream/RTCIceCandidateEvent.idl:
- Modules/mediastream/RTCIceServer.idl:
- Modules/mediastream/RTCIceTransport.cpp: Added.
- Modules/mediastream/RTCIceTransport.idl: Added.
- Modules/mediastream/RTCIceTransport.h: Minor update to rename state to transportState.
(WebCore::RTCIceTransport::state):
(WebCore::RTCIceTransport::setState):
(WebCore::RTCIceTransport::transportState): Deleted.
(WebCore::RTCIceTransport::setTransportState): Deleted.
- Modules/mediastream/RTCIceTransportState.h: Added.
- Modules/mediastream/RTCIceTransportState.idl: Added.
- Modules/mediastream/RTCPeerConnection.h:
- Modules/mediastream/RTCPeerConnection.idl:
- Modules/mediastream/RTCRtpReceiver.idl:
- Modules/mediastream/RTCRtpSender.idl:
- Modules/mediastream/RTCRtpTransceiver.idl:
- Modules/mediastream/RTCStatsReport.idl:
- WebCore.xcodeproj/project.pbxproj:
- Modules/mediastream/MediaEndpointPeerConnection.cpp:
(WebCore::MediaEndpointPeerConnection::iceTransportStateChanged): Refactor.
- 9:09 AM Changeset in webkit [214044] by
-
- 14 edits2 copies6 adds in trunk
Improve WebRTC track enabled support
https://bugs.webkit.org/show_bug.cgi?id=169727
Patch by Youenn Fablet <youenn@apple.com> on 2017-03-16
Reviewed by Alex Christensen.
Source/WebCore:
Tests: webrtc/peer-connection-audio-mute2.html
webrtc/peer-connection-remote-audio-mute.html
webrtc/video-remote-mute.html
Making sure muted/disabled sources produce silence/black frames.
For outgoing audio/video sources, this should be done by the actual a/v providers.
We keep this filtering here until we are sure they implement that.
- platform/audio/mac/AudioSampleDataSource.mm:
(WebCore::AudioSampleDataSource::pullAvalaibleSamplesAsChunks): Ensuring disabled audio tracks send silence.
Used for outgoing webrtc tracks.
- platform/mediastream/mac/MockRealtimeAudioSourceMac.mm:
(WebCore::MockRealtimeAudioSourceMac::render): Ditto.
- platform/mediastream/mac/RealtimeIncomingAudioSource.cpp:
(WebCore::RealtimeIncomingAudioSource::OnData): Ditto.
- platform/mediastream/mac/RealtimeIncomingVideoSource.cpp:
(WebCore::RealtimeIncomingVideoSource::pixelBufferFromVideoFrame): Generating black frames if muted.
(WebCore::RealtimeIncomingVideoSource::OnFrame):
- platform/mediastream/mac/RealtimeIncomingVideoSource.h:
- platform/mediastream/mac/RealtimeOutgoingVideoSource.cpp:
(WebCore::RealtimeOutgoingVideoSource::videoSampleAvailable): Ensuring we quit after sending black frame.
LayoutTests:
- TestExpectations:
- webrtc/audio-peer-connection-webaudio.html:
- webrtc/peer-connection-audio-mute-expected.txt:
- webrtc/peer-connection-audio-mute.html:
- webrtc/peer-connection-audio-mute2-expected.txt: Added.
- webrtc/peer-connection-audio-mute2.html: Added.
- webrtc/peer-connection-remote-audio-mute-expected.txt: Added.
- webrtc/peer-connection-remote-audio-mute.html: Added.
- webrtc/video-mute-expected.txt:
- webrtc/video-mute.html:
- webrtc/video-remote-mute-expected.txt: Added.
- webrtc/video-remote-mute.html: Added.
- 8:23 AM Changeset in webkit [214043] by
-
- 3 edits in trunk/Source/WebCore
LibWebRTC outgoing source should be thread safe refcounted
https://bugs.webkit.org/show_bug.cgi?id=169726
Patch by Youenn Fablet <youenn@apple.com> on 2017-03-16
Reviewed by Alex Christensen.
Preventive fix.
Also fixing the size of the buffer for the audio source as its reserved size is byte count.
- platform/mediastream/mac/RealtimeOutgoingAudioSource.h:
- platform/mediastream/mac/RealtimeOutgoingVideoSource.h:
- 8:21 AM Changeset in webkit [214042] by
-
- 15 edits in trunk/Source/WebCore
MediaStreamTrack remote() no longer exists
https://bugs.webkit.org/show_bug.cgi?id=169734
Patch by Youenn Fablet <youenn@apple.com> on 2017-03-16
Reviewed by Alex Christensen.
Removing MediaStreamTrack remote.
Removing RealtimeMediaSource::remote as isCaptureSource which is closer to its use in MediaStreamPrivate to
detect whether sources are capture sources or not.
- Modules/mediastream/MediaStream.cpp:
(WebCore::MediaStream::mediaState):
- platform/mediastream/MediaStreamPrivate.cpp:
(WebCore::MediaStreamPrivate::hasCaptureVideoSource):
(WebCore::MediaStreamPrivate::hasCaptureAudioSource):
(WebCore::MediaStreamPrivate::hasLocalVideoSource): Deleted.
(WebCore::MediaStreamPrivate::hasLocalAudioSource): Deleted.
- platform/mediastream/MediaStreamPrivate.h:
- Modules/mediastream/MediaStreamTrack.cpp:
(WebCore::MediaStreamTrack::stopProducingData):
(WebCore::MediaStreamTrack::remote): Deleted.
- Modules/mediastream/MediaStreamTrack.h:
- Modules/mediastream/MediaStreamTrack.idl:
- Modules/webaudio/MediaStreamAudioSource.h:
- platform/mediastream/MediaStreamPrivate.cpp:
(WebCore::MediaStreamPrivate::hasLocalVideoSource):
(WebCore::MediaStreamPrivate::hasLocalAudioSource):
- platform/mediastream/MediaStreamTrackPrivate.cpp:
(WebCore::MediaStreamTrackPrivate::isCaptureTrack):
(WebCore::MediaStreamTrackPrivate::remote): Deleted.
- platform/mediastream/MediaStreamTrackPrivate.h:
- platform/mediastream/RealtimeMediaSource.cpp:
(WebCore::RealtimeMediaSource::reset):
- platform/mediastream/RealtimeMediaSource.h:
(WebCore::RealtimeMediaSource::isCaptureSource):
(WebCore::RealtimeMediaSource::remote): Deleted.
(WebCore::RealtimeMediaSource::setRemote): Deleted.
- platform/mediastream/mac/AVMediaCaptureSource.h:
- platform/mock/MockRealtimeAudioSource.h:
- platform/mock/MockRealtimeVideoSource.h:
- 6:52 AM Changeset in webkit [214041] by
-
- 2 edits in trunk/Source/JavaScriptCore
Unreviewed, copy m_numberOfArgumentsToSkip
https://bugs.webkit.org/show_bug.cgi?id=164582
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::CodeBlock):
- 6:24 AM Changeset in webkit [214040] by
-
- 4 edits in trunk/Source/JavaScriptCore
Unreviewed, fix numParameter() - 1 OSRExit materialization
https://bugs.webkit.org/show_bug.cgi?id=164582
When materializing rest parameters, we rely on that numParameter() - 1 equals to
the numberOfArgumentsToSkip. But this assumption is broken in r214029.
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::finishCreation):
- bytecode/CodeBlock.h:
(JSC::CodeBlock::numberOfArgumentsToSkip):
- ftl/FTLOperations.cpp:
(JSC::FTL::operationMaterializeObjectInOSR):
- 6:13 AM Changeset in webkit [214039] by
-
- 3 edits2 adds in trunk
[css-grid] Crash on debug removing a positioned child
https://bugs.webkit.org/show_bug.cgi?id=169739
Reviewed by Sergio Villar Senin.
Source/WebCore:
When we add or remove a positioned item we don't need to mark
the grid as dirty, because positioned items do not affect the layout
of the grid at all.
This was causing a crash when a positioned item was removed
after a layout. As after the positioned item was removed,
the method RenderGrid::layoutBlock() was not called,
so when the grid was repainted we got a crash.
Test: fast/css-grid-layout/grid-crash-remove-positioned-item.html
- rendering/RenderGrid.cpp:
(WebCore::RenderGrid::addChild): Add early return to avoid marking
the grid as dirty for positioned grid items.
(WebCore::RenderGrid::removeChild): Ditto.
LayoutTests:
Add new test that checks that adding and removing a positioned grid item
doesn't cause any crashes.
- fast/css-grid-layout/grid-crash-remove-positioned-item-expected.txt: Added.
- fast/css-grid-layout/grid-crash-remove-positioned-item.html: Added.
- 5:58 AM Changeset in webkit [214038] by
-
- 19 edits1 add in trunk
[ESnext] Implement Object Spread
https://bugs.webkit.org/show_bug.cgi?id=167963
Patch by Caio Lima <Caio Lima> on 2017-03-16
Reviewed by Yusuke Suzuki.
JSTests:
- stress/object-spread.js: Added.
(let.assert):
(assert.sameValue):
(let.o.get a):
(let.obj.get c):
(cthulhu.get x):
(let.obj.set c):
(calls.o.get z):
(calls.o.get a):
(try.let.obj.get foo):
(get calls):
Source/JavaScriptCore:
This patch implements ECMA262 stage 3 Object Spread proposal [1].
It's implemented using CopyDataProperties to copy all enumerable keys
from object being spreaded.
It's also fixing CopyDataProperties that was using
Object.getOwnPropertyNames to list all keys to be copied, and now is
using Relect.ownKeys.
[1] - https://github.com/sebmarkbage/ecmascript-rest-spread
- builtins/GlobalOperations.js:
(globalPrivate.copyDataProperties):
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::setConstantIdentifierSetRegisters):
- bytecode/UnlinkedCodeBlock.h:
(JSC::UnlinkedCodeBlock::addSetConstant):
- bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::emitLoad):
- bytecompiler/BytecodeGenerator.h:
- bytecompiler/NodesCodegen.cpp:
(JSC::PropertyListNode::emitBytecode):
(JSC::ObjectPatternNode::bindValue):
(JSC::ObjectSpreadExpressionNode::emitBytecode):
- parser/ASTBuilder.h:
(JSC::ASTBuilder::createObjectSpreadExpression):
(JSC::ASTBuilder::createProperty):
- parser/NodeConstructors.h:
(JSC::PropertyNode::PropertyNode):
(JSC::ObjectSpreadExpressionNode::ObjectSpreadExpressionNode):
- parser/Nodes.h:
(JSC::ObjectSpreadExpressionNode::expression):
- parser/Parser.cpp:
(JSC::Parser<LexerType>::parseProperty):
- parser/SyntaxChecker.h:
(JSC::SyntaxChecker::createObjectSpreadExpression):
(JSC::SyntaxChecker::createProperty):
- runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::init):
- runtime/JSGlobalObjectFunctions.cpp:
(JSC::privateToObject): Deleted.
- runtime/JSGlobalObjectFunctions.h:
LayoutTests:
- js/parser-syntax-check-expected.txt:
- js/script-tests/parser-syntax-check.js:
- 4:59 AM Changeset in webkit [214037] by
-
- 5 edits in trunk
[WebRTC] SDP sess-id in the "o=" line should be a value between 0 and LLONG_MAX.
https://bugs.webkit.org/show_bug.cgi?id=169681
Reviewed by Alejandro G. Castro.
Source/WebCore:
Use an int64_t type for storing sess-id and ensure that the value generated is always between 0 and LLONG_MAX (263-1).
To the JS world (sdp.js) we pass and read this value as a string type.
The JS world (sdp.js) was already using a string type for sess-id.
This caused a bug when reading the sess-id value at configurationFromJSON(): no value was obtained because a numeric type was expected.
So, after this patch, sess-id is passed and read as a string from sdp.js, and converted to an int64_t type for internal use.
This way we also avoid a rounding problem that happens with values near LLONG_MAX when converting from int64_t to double when passed to the JS world,
and that could cause that we end passing a number bigger than LLONG_MAX to sdp.js.
- Modules/mediastream/SDPProcessor.cpp:
(WebCore::configurationFromJSON):
(WebCore::configurationToJSON):
- platform/mediastream/MediaEndpointSessionConfiguration.h:
(WebCore::MediaEndpointSessionConfiguration::sessionId):
(WebCore::MediaEndpointSessionConfiguration::setSessionId):
(WebCore::MediaEndpointSessionConfiguration::MediaEndpointSessionConfiguration):
LayoutTests:
Check that the generated sess-id value its between the limits before validating it.
This is covered by the tests fast/mediastream/RTCPeerConnection-inspect-answer.html
and fast/mediastream/RTCPeerConnection-inspect-offer.html.
Both tests will fail if the sess-id value generated is not within the limits.
- fast/mediastream/resources/sdp-utils.js:
(printComparableSessionDescription):
- 4:55 AM Changeset in webkit [214036] by
-
- 3 edits1 copy1 add2 deletes in trunk/Source/WTF
[UNIX] Implement currentSearchLocaleID() and currentTextBreakLocaleID()
https://bugs.webkit.org/show_bug.cgi?id=169745
Reviewed by Yusuke Suzuki.
Add a common implementation for Unix based ports using setlocale.
- wtf/PlatformGTK.cmake:
- wtf/PlatformJSCOnly.cmake:
- wtf/text/gtk/TextBreakIteratorInternalICUGtk.cpp: Removed.
- wtf/text/unix/TextBreakIteratorInternalICUUnix.cpp: Renamed from Source/WTF/wtf/text/jsconly/TextBreakIteratorInternalICUJSCOnly.cpp.
(WTF::currentSearchLocaleID):
(WTF::currentTextBreakLocaleID):
- 2:57 AM Changeset in webkit [214035] by
-
- 3 edits in trunk/Source/WTF
[GLIB] MainThread implementation is not GTK+ specific
https://bugs.webkit.org/show_bug.cgi?id=169736
Reviewed by Yusuke Suzuki.
It's implemented in MainThreadGLib.cpp for glib based ports, so ifdefs in MainThread should not be
PLATFORM(GTK) but USE(GLIB).
- wtf/MainThread.cpp:
- wtf/MainThread.h:
- 1:40 AM Changeset in webkit [214034] by
-
- 4 edits in trunk/Source/WebKit2
Fix uninitialized public members in Webkit2/UIProcess/API/gtk
https://bugs.webkit.org/show_bug.cgi?id=169602
Reviewed by Michael Catanzaro.
Found by Coverity scan.
- UIProcess/API/gtk/WebKitMimeInfo.cpp:
- UIProcess/API/gtk/WebKitSettings.cpp:
- UIProcess/API/gtk/WebKitWebViewBase.cpp:
- 12:51 AM Changeset in webkit [214033] by
-
- 2 edits in trunk/Source/WebKit2
Unreviewed follow-up to r213787. Move the DatabaseProcess build targets
to the top of WebKit2_SOURCES list in order to maintain the alphabetical
order.
- CMakeLists.txt:
