⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Mar 21, 2017:

8:49 PM Changeset in webkit [214241] by Simon Fraser
  • 2 edits in trunk/Source/WebCore

Make non-decoded image flashing less intrusive
​https://bugs.webkit.org/show_bug.cgi?id=169942

Reviewed by Said Abou-Hallawa.

When compositing borders are enabled, we paint yellow for images that paint but don't yet have a decoded
frame. Give this yellow 50% alpha to make it less intrusive

Also log to the images log channel when we destroy decoded data.

  • platform/graphics/BitmapImage.cpp:

(WebCore::BitmapImage::destroyDecodedData):
(WebCore::BitmapImage::draw):

6:55 PM Changeset in webkit [214240] by mark.lam@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

The DFG Integer Check Combining phase should force an OSR exit for CheckInBounds on a negative constant min bound.
​https://bugs.webkit.org/show_bug.cgi?id=169933
<rdar://problem/31105125>

Reviewed by Filip Pizlo and Geoffrey Garen.

Also fixed the bit-rotted RangeKey::dump() function.

  • dfg/DFGIntegerCheckCombiningPhase.cpp:

(JSC::DFG::IntegerCheckCombiningPhase::handleBlock):

6:44 PM Changeset in webkit [214239] by mrajca@apple.com
  • 5 edits
    1 add in trunk

Loosen audio playback restrictions when the volume is 0.
​https://bugs.webkit.org/show_bug.cgi?id=169897

Reviewed by Eric Carlson.

Source/WebCore:

Added API tests.

  • html/MediaElementSession.cpp:

(WebCore::MediaElementSession::playbackPermitted):

Tools:

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/Tests/WebKit2/autoplay-zero-volume-check.html: Added.
  • TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:

(TEST):

6:03 PM WikiProcessors edited by trac
(diff)
6:03 PM WikiPageNames edited by trac
(diff)
6:03 PM WikiNewPage created by trac
6:03 PM WikiMacros edited by trac
(diff)
6:03 PM WikiHtml edited by trac
(diff)
6:03 PM WikiFormatting edited by trac
(diff)
6:03 PM WikiDeletePage edited by trac
(diff)
6:03 PM TracWorkflow edited by trac
(diff)
6:03 PM TracWiki edited by trac
(diff)
6:03 PM TracUpgrade edited by trac
(diff)
6:03 PM TracUnicode edited by trac
(diff)
6:03 PM TracTimeline edited by trac
(diff)
6:03 PM TracTicketsCustomFields edited by trac
(diff)
6:03 PM WikiRestructuredTextLinks edited by trac
(diff)
6:03 PM TracTickets edited by trac
(diff)
6:03 PM TracSyntaxColoring edited by trac
(diff)
6:03 PM TracSupport edited by trac
(diff)
6:03 PM TracStandalone edited by trac
(diff)
6:03 PM TracSearch edited by trac
(diff)
6:03 PM TracRss edited by trac
(diff)
6:03 PM TracRoadmap edited by trac
(diff)
6:03 PM TracRevisionLog edited by trac
(diff)
6:03 PM TracRepositoryAdmin edited by trac
(diff)
6:03 PM TracReports edited by trac
(diff)
6:03 PM TracQuery edited by trac
(diff)
6:03 PM TracPlugins edited by trac
(diff)
6:03 PM TracPermissions edited by trac
(diff)
6:03 PM TracNotification edited by trac
(diff)
6:03 PM TracNavigation edited by trac
(diff)
6:03 PM TracModWSGI edited by trac
(diff)
6:03 PM TracModPython edited by trac
(diff)
6:03 PM TracLogging edited by trac
(diff)
6:03 PM TracLinks edited by trac
(diff)
6:03 PM TracInterfaceCustomization edited by trac
(diff)
6:03 PM WikiRestructuredText edited by trac
(diff)
6:03 PM TracInstall edited by trac
(diff)
6:03 PM TracIni edited by trac
(diff)
6:03 PM TracImport edited by trac
(diff)
6:03 PM TracGuide edited by trac
(diff)
6:03 PM TracFineGrainedPermissions edited by trac
(diff)
6:03 PM TracFastCgi edited by trac
(diff)
6:03 PM TracEnvironment edited by trac
(diff)
6:03 PM TracChangeset edited by trac
(diff)
6:03 PM TracChangeLog created by trac
6:03 PM TracCgi edited by trac
(diff)
6:03 PM TracBrowser edited by trac
(diff)
6:03 PM TracBatchModify created by trac
6:03 PM TracBackup edited by trac
(diff)
6:03 PM TracAdmin edited by trac
(diff)
6:03 PM TracAccessibility edited by trac
(diff)
6:03 PM TicketQuery created by trac
6:03 PM PageTemplates edited by trac
(diff)
6:03 PM InterWiki edited by trac
(diff)
6:03 PM InterTrac edited by trac
(diff)
6:03 PM CamelCase edited by trac
(diff)
5:45 PM Changeset in webkit [214238] by aakash_jain@apple.com
  • 3 edits in trunk/Tools

EWS fails to parse_bug_id_from_attachment_page after bugzilla upgrade
​https://bugs.webkit.org/show_bug.cgi?id=169937
<rdar://problem/31181859>

Reviewed by Alexey Proskuryakov.

  • Scripts/webkitpy/common/net/bugzilla/bugzilla.py:

(Bugzilla._parse_bug_id_from_attachment_page): Since rel tag is no longer present, parsing the bug id from bug_title.

  • Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py: Fixed unit test.
5:08 PM Changeset in webkit [214237] by beidson@apple.com
  • 5 edits in trunk

Disable all virtual tables.
<rdar://problem/31081972> and ​https://bugs.webkit.org/show_bug.cgi?id=169928
Source/WebCore:

Reviewed by Jer Noble.

No new tests (Covered by changes to existing test).

  • Modules/webdatabase/DatabaseAuthorizer.cpp:

(WebCore::DatabaseAuthorizer::createVTable):
(WebCore::DatabaseAuthorizer::dropVTable):

LayoutTests:

Reviewed by Jer Noble.

  • storage/websql/test-authorizer-expected.txt:
  • storage/websql/test-authorizer.js:

(createStatementsCallback):

5:06 PM Changeset in webkit [214236] by jmarcell@apple.com
  • 6 edits in branches/safari-603-branch/Source/WebCore

Merge r214014. rdar://problem/30921815

4:40 PM Changeset in webkit [214235] by andersca@apple.com
  • 9 edits in trunk/Source

Remove bogus availability annotations from DOM SPI headers.
rdar://problem/31015675

Rubber-stamped by Dan Bernstein.

Source/WebCore:

  • platform/cocoa/WebKitAvailability.h:

Remove NSi_9876_5 #define.

Source/WebKit/mac:

  • DOM/DOMHTMLMediaElement.h:
  • DOM/DOMHTMLVideoElement.h:
  • DOM/DOMMediaError.h:
  • DOM/DOMTextEvent.h:
  • DOM/DOMTimeRanges.h:
  • DOM/DOMTokenList.h:
4:02 PM Changeset in webkit [214234] by jmarcell@apple.com
  • 5 edits in branches/safari-603-branch/Source

Versioning.

3:33 PM Changeset in webkit [214233] by aakash_jain@apple.com
  • 2 edits in trunk/Tools

ews should indicate in logs when it fails to parse_bug_id_from_attachment_page
​https://bugs.webkit.org/show_bug.cgi?id=169927

Reviewed by Alexey Proskuryakov.

  • Scripts/webkitpy/common/net/bugzilla/bugzilla.py:

(Bugzilla._parse_bug_id_from_attachment_page): Added log statement.

2:39 PM Changeset in webkit [214232] by Alan Bujtas
  • 3 edits
    2 adds in trunk

2017-03-21 Zalan Bujtas <Alan Bujtas>

Tear down descendant renderers when <slot>'s display value is set to no "contents".
​https://bugs.webkit.org/show_bug.cgi?id=169921
<rdar://problem/30336417>

Reviewed by Antti Koivisto.

Since "display: contents" does not generate a renderer, when an element's display value is
changed to something other than "contents", we not only create a renderer but also reparent its descendant
subtree (e.g from slot's parent to the newly constructed slot renderer). During this reparenting, we
need to tear down the descendant subtree tree and build it up again to reflect the new rendering context.

Test: fast/shadow-dom/slot-with-continuation-descendants.html

  • style/RenderTreeUpdater.cpp: (WebCore::RenderTreeUpdater::updateElementRenderer):
2:25 PM Changeset in webkit [214231] by Wenson Hsieh
  • 9 edits in trunk/Source

Teach TextIndicator to estimate the background color of the given Range
​https://bugs.webkit.org/show_bug.cgi?id=169869
<rdar://problem/31127272>

Reviewed by Anders Carlsson and Simon Fraser.

Source/WebCore:

Introduces a simple heuristic to compute a background color that is appropriate to use as a border surrounding
the snapshot of the given Range. This work is only carried out if TextIndicatorOptionComputeEstimatedBackgroundColor
is specified. The details of how this background color is estimated (as well as when to fall back) can be improved
in several ways (one idea is to sample colors along the edge of the snapshot). For the time being, this patch
naively walks up the render tree in search of enclosing parent renderers that have background colors. If any
renderers have a style that is deemed too complex to capture in a single background color, then fall back to the
base document background color; otherwise, the estimated background color is the result of blending these
background colors together.

  • page/TextIndicator.cpp:

(WebCore::styleContainsComplexBackground):

Bail out of the background color codepath if the renderer has backdrop filters, has a background image, or uses
a non-normal blend mode.

(WebCore::fallbackBackgroundColorForTextSelection):
(WebCore::estimatedBackgroundColorForRange):
(WebCore::initializeIndicator):

  • page/TextIndicator.h:

Source/WebKit/mac:

Plumb the estimated background color for WebKit1 clients through a new property in WebUITextIndicatorData.

  • WebView/WebView.mm:

(-[WebUITextIndicatorData initWithImage:textIndicatorData:scale:]):
(-[WebUITextIndicatorData dealloc]):

  • WebView/WebViewPrivate.h:

Source/WebKit2:

Send the estimated background color over XPC, and adopt TextIndicatorOptionComputeEstimatedBackgroundColor when
snapshotting after performing an edit data interaction.

  • Shared/WebCoreArgumentCoders.cpp:

(IPC::ArgumentCoder<TextIndicatorData>::encode):
(IPC::ArgumentCoder<TextIndicatorData>::decode):

  • WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::didConcludeEditDataInteraction):

2:08 PM Changeset in webkit [214230] by Chris Dumez
  • 4 edits in trunk/Source/WebKit2

[WK2] Call processDidCrash() right away when terminating a process that exceeded background CPU limit
​https://bugs.webkit.org/show_bug.cgi?id=169573
<rdar://problem/30960968>

Reviewed by Andreas Kling.

Call processDidCrash() right away when terminating a process that exceeded background CPU limit
and let the client decide when to reload the content.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::reattachToWebProcess):
(WebKit::WebPageProxy::dispatchActivityStateChange):
(WebKit::WebPageProxy::terminateProcess):

  • UIProcess/WebPageProxy.h:
  • UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::didExceedBackgroundCPULimit):

1:52 PM Changeset in webkit [214229] by clopez@igalia.com
  • 3 edits in trunk/LayoutTests

[GTK][Wayland] Enable WebGL, 3D and compositing layout tests
​https://bugs.webkit.org/show_bug.cgi?id=71849

Unreviewed test gardening.

  • platform/gtk-wayland/TestExpectations: Add the diff of native Wayland compared to Xvfb.
  • platform/gtk/TestExpectations: This two tests seem flaky.
12:49 PM Changeset in webkit [214228] by jmarcell@apple.com
  • 2 edits in tags/Safari-604.1.13/Source/WebKit2

Merge r214179. rdar://problem/31030944

12:45 PM Changeset in webkit [214227] by jer.noble@apple.com
  • 3 edits in trunk/Source/WebCore

Crash in WebCore: WebCore::CARingBuffer::getCurrentFrameBounds + 28
​https://bugs.webkit.org/show_bug.cgi?id=169887
<rdar://problem/23648082>

Reviewed by Eric Carlson.

Because AudioSourceProviderAVFObjC::prepareCallback() can concievably be called after the AudioSourceProviderAVFObjC
it refers to has been destroyed, add an extra layer of indirection between the tap and the provider, and invalidate
that level of indirection before the AudioSourceProviderAVFObjC is destroyed.

  • platform/graphics/avfoundation/AudioSourceProviderAVFObjC.h:
  • platform/graphics/avfoundation/AudioSourceProviderAVFObjC.mm:

(WebCore::AudioSourceProviderAVFObjC::initCallback):
(WebCore::AudioSourceProviderAVFObjC::finalizeCallback):
(WebCore::AudioSourceProviderAVFObjC::prepareCallback):
(WebCore::AudioSourceProviderAVFObjC::unprepareCallback):
(WebCore::AudioSourceProviderAVFObjC::processCallback):

11:18 AM Changeset in webkit [214226] by Simon Fraser
  • 2 edits in trunk/Source/WebCore

Remove logging left in by mistake.

  • rendering/RenderNamedFlowThread.cpp:

(WebCore::RenderNamedFlowThread::willBeDestroyed):

9:54 AM Changeset in webkit [214225] by ddkilzer@apple.com
  • 2 edits
    1 delete in trunk/Websites/bugs.webkit.org

Commit local changes for Bugzilla 5.0.3

  • images/favicon.ico: Update favicon from Dec 11, 2015.
  • data/params.json: Deleted.
9:27 AM Changeset in webkit [214224] by ddkilzer@apple.com
  • 597 edits
    3 moves
    189 adds
    35 deletes in trunk/Websites/bugs.webkit.org

Upgrade to Bugzilla 5.0.3.

8:52 AM Changeset in webkit [214223] by clopez@igalia.com
  • 3 edits
    199 adds in trunk/LayoutTests

[GTK] Enable WebGL, 3D and compositing layout tests
​https://bugs.webkit.org/show_bug.cgi?id=71849

Unreviewed test gardeninng.

  • http/tests/webgl/1.0.2/origin-clean-conformance-expected.txt: Rebaseline after r208049.
  • platform/gtk/TestExpectations: Mark new expected failures.
  • platform/gtk/compositing/animation/state-at-end-event-transform-layer-expected.png: Added. Rebaselined.
  • platform/gtk/compositing/animation/state-at-end-event-transform-layer-expected.txt: Added. Rebaselined.
  • platform/gtk/compositing/backing/backface-visibility-in-3dtransformed-expected.txt: Added. Rebaselined.
  • platform/gtk/compositing/backing/child-layer-no-backing-expected.txt: Added. Rebaselined.
  • platform/gtk/compositing/backing/inline-block-no-backing-expected.txt: Added. Rebaselined.
  • platform/gtk/compositing/backing/no-backing-for-clip-expected.txt: Added. Rebaselined.
  • platform/gtk/compositing/backing/no-backing-for-clip-overhang-expected.txt: Added. Rebaselined.
  • platform/gtk/compositing/backing/no-backing-for-clip-overlap-expected.txt: Added. Rebaselined.
  • platform/gtk/compositing/backing/replaced-child-no-backing-expected.txt: Added. Rebaselined.
  • platform/gtk/compositing/color-matching/image-color-matching-expected.png: Added. Rebaselined.
  • platform/gtk/compositing/color-matching/image-color-matching-expected.txt: Added. Rebaselined.
  • platform/gtk/compositing/color-matching/pdf-image-match-expected.png: Added. Rebaselined.
  • platform/gtk/compositing/color-matching/pdf-image-match-expected.txt: Added. Rebaselined.
  • platform/gtk/compositing/compositing-visible-descendant-expected.png: Added. Rebaselined.
  • platform/gtk/compositing/compositing-visible-descendant-expected.txt: Added. Rebaselined.
  • platform/gtk/compositing/direct-image-compositing-expected.png: Added. Rebaselined.
  • platform/gtk/compositing/direct-image-compositing-expected.txt: Added. Rebaselined.
  • platform/gtk/compositing/generated-content-expected.png: Added. Rebaselined.
  • platform/gtk/compositing/generated-content-expected.txt: Added. Rebaselined.
  • platform/gtk/compositing/geometry/abs-position-inside-opacity-expected.png: Added. Rebaselined.
  • platform/gtk/compositing/geometry/abs-position-inside-opacity-expected.txt: Added. Rebaselined.
  • platform/gtk/compositing/geometry/clipping-foreground-expected.png: Added. Rebaselined.
  • platform/gtk/compositing/geometry/clipping-foreground-expected.txt: Added. Rebaselined.
  • platform/gtk/compositing/geometry/composited-html-size-expected.png: Added. Rebaselined.
  • platform/gtk/compositing/geometry/composited-html-size-expected.txt: Added. Rebaselined.
  • platform/gtk/compositing/geometry/composited-in-columns-expected.png: Added. Rebaselined.
  • platform/gtk/compositing/geometry/composited-in-columns-expected.txt: Added. Rebaselined.
  • platform/gtk/compositing/geometry/fixed-in-composited-expected.png: Added. Rebaselined.
  • platform/gtk/compositing/geometry/fixed-in-composited-expected.txt: Added. Rebaselined.
  • platform/gtk/compositing/geometry/fixed-position-expected.png: Added. Rebaselined.
  • platform/gtk/compositing/geometry/fixed-position-expected.txt: Added. Rebaselined.
  • platform/gtk/compositing/geometry/horizontal-scroll-composited-expected.png: Added. Rebaselined.
  • platform/gtk/compositing/geometry/horizontal-scroll-composited-expected.txt: Added. Rebaselined.
  • platform/gtk/compositing/geometry/layer-due-to-layer-children-deep-expected.png: Added. Rebaselined.
  • platform/gtk/compositing/geometry/layer-due-to-layer-children-deep-expected.txt: Added. Rebaselined.
  • platform/gtk/compositing/geometry/layer-due-to-layer-children-expected.png: Added. Rebaselined.
  • platform/gtk/compositing/geometry/layer-due-to-layer-children-expected.txt: Added. Rebaselined.
  • platform/gtk/compositing/geometry/outline-change-expected.png: Added. Rebaselined.
  • platform/gtk/compositing/geometry/outline-change-expected.txt: Added. Rebaselined.
  • platform/gtk/compositing/geometry/partial-layout-update-expected.png: Added. Rebaselined.
  • platform/gtk/compositing/geometry/partial-layout-update-expected.txt: Added. Rebaselined.
  • platform/gtk/compositing/geometry/root-layer-update-expected.png: Added. Rebaselined.
  • platform/gtk/compositing/geometry/root-layer-update-expected.txt: Added. Rebaselined.
  • platform/gtk/compositing/geometry/transfrom-origin-on-zero-size-layer-expected.png: Added. Rebaselined.
  • platform/gtk/compositing/geometry/transfrom-origin-on-zero-size-layer-expected.txt: Added. Rebaselined.
  • platform/gtk/compositing/geometry/vertical-scroll-composited-expected.png: Added. Rebaselined.
  • platform/gtk/compositing/geometry/vertical-scroll-composited-expected.txt: Added. Rebaselined.
  • platform/gtk/compositing/geometry/video-fixed-scrolling-expected.png: Added. Rebaselined.
  • platform/gtk/compositing/geometry/video-fixed-scrolling-expected.txt: Added. Rebaselined.
  • platform/gtk/compositing/geometry/video-opacity-overlay-expected.png: Added. Rebaselined.
  • platform/gtk/compositing/geometry/video-opacity-overlay-expected.txt: Added. Rebaselined.
  • platform/gtk/compositing/iframes/composited-iframe-alignment-expected.png: Added. Rebaselined.
  • platform/gtk/compositing/iframes/composited-iframe-alignment-expected.txt: Added. Rebaselined.
  • platform/gtk/compositing/iframes/iframe-copy-on-scroll-expected.png: Added. Rebaselined.
  • platform/gtk/compositing/iframes/iframe-copy-on-scroll-expected.txt: Added. Rebaselined.
  • platform/gtk/compositing/iframes/iframe-in-composited-layer-expected.png: Added. Rebaselined.
  • platform/gtk/compositing/iframes/iframe-in-composited-layer-expected.txt: Added. Rebaselined.
  • platform/gtk/compositing/iframes/invisible-nested-iframe-show-expected.txt: Added. Rebaselined.
  • platform/gtk/compositing/iframes/resizer-expected.txt: Added. Rebaselined.
  • platform/gtk/compositing/images/direct-image-background-color-expected.png: Added. Rebaselined.
  • platform/gtk/compositing/images/direct-image-background-color-expected.txt: Added. Rebaselined.
  • platform/gtk/compositing/layer-creation/fixed-position-scroll-expected.png: Added. Rebaselined.
  • platform/gtk/compositing/layer-creation/fixed-position-scroll-expected.txt: Added. Rebaselined.
  • platform/gtk/compositing/layer-creation/overlap-animation-container-expected.txt: Added. Rebaselined.
  • platform/gtk/compositing/layer-creation/overlap-animation-expected.txt: Added. Rebaselined.
  • platform/gtk/compositing/layer-creation/will-change-layer-creation-expected.txt: Added. Rebaselined.
  • platform/gtk/compositing/layer-creation/will-change-on-normal-flow-content-expected.txt: Added. Rebaselined.
  • platform/gtk/compositing/layers-inside-overflow-scroll-expected.png: Added. Rebaselined.
  • platform/gtk/compositing/layers-inside-overflow-scroll-expected.txt: Added. Rebaselined.
  • platform/gtk/compositing/masks/direct-image-mask-expected.png: Added. Rebaselined.
  • platform/gtk/compositing/masks/direct-image-mask-expected.txt: Added. Rebaselined.
  • platform/gtk/compositing/masks/masked-ancestor-expected.png: Added. Rebaselined.
  • platform/gtk/compositing/masks/masked-ancestor-expected.txt: Added. Rebaselined.
  • platform/gtk/compositing/masks/multiple-masks-expected.png: Added. Rebaselined.
  • platform/gtk/compositing/masks/multiple-masks-expected.txt: Added. Rebaselined.
  • platform/gtk/compositing/masks/simple-composited-mask-expected.png: Added. Rebaselined.
  • platform/gtk/compositing/masks/simple-composited-mask-expected.txt: Added. Rebaselined.
  • platform/gtk/compositing/media-controls-bar-appearance-expected.txt: Added. Rebaselined.
  • platform/gtk/compositing/overflow/composited-scrolling-creates-a-stacking-container-expected.txt: Added. Rebaselined.
  • platform/gtk/compositing/overflow/composited-scrolling-paint-phases-expected.txt: Added. Rebaselined.
  • platform/gtk/compositing/overflow/fixed-position-ancestor-clip-expected.png: Added. Rebaselined.
  • platform/gtk/compositing/overflow/fixed-position-ancestor-clip-expected.txt: Added. Rebaselined.
  • platform/gtk/compositing/overflow/nested-scrolling-expected.png: Added. Rebaselined.
  • platform/gtk/compositing/overflow/nested-scrolling-expected.txt: Added. Rebaselined.
  • platform/gtk/compositing/overflow/overflow-compositing-descendant-expected.png: Added. Rebaselined.
  • platform/gtk/compositing/overflow/overflow-compositing-descendant-expected.txt: Added. Rebaselined.
  • platform/gtk/compositing/overflow/overflow-positioning-expected.png: Added. Rebaselined.
  • platform/gtk/compositing/overflow/overflow-positioning-expected.txt: Added. Rebaselined.
  • platform/gtk/compositing/overflow/overflow-scroll-expected.png: Added. Rebaselined.
  • platform/gtk/compositing/overflow/overflow-scroll-expected.txt: Added. Rebaselined.
  • platform/gtk/compositing/overflow/parent-overflow-expected.png: Added. Rebaselined.
  • platform/gtk/compositing/overflow/parent-overflow-expected.txt: Added. Rebaselined.
  • platform/gtk/compositing/overflow/remove-overflow-crash2-expected.png: Added. Rebaselined.
  • platform/gtk/compositing/overflow/remove-overflow-crash2-expected.txt: Added. Rebaselined.
  • platform/gtk/compositing/overflow/scroll-ancestor-update-expected.png: Added. Rebaselined.
  • platform/gtk/compositing/overflow/scroll-ancestor-update-expected.txt: Added. Rebaselined.
  • platform/gtk/compositing/overflow/scrollbar-painting-expected.png: Added. Rebaselined.
  • platform/gtk/compositing/overflow/scrollbar-painting-expected.txt: Added. Rebaselined.
  • platform/gtk/compositing/overflow/theme-affects-visual-overflow-expected.png: Added. Rebaselined.
  • platform/gtk/compositing/overflow/theme-affects-visual-overflow-expected.txt: Added. Rebaselined.
  • platform/gtk/compositing/reflections/reflection-in-composited-expected.png: Added. Rebaselined.
  • platform/gtk/compositing/reflections/reflection-in-composited-expected.txt: Added. Rebaselined.
  • platform/gtk/compositing/repaint/become-overlay-composited-layer-expected.png: Added. Rebaselined.
  • platform/gtk/compositing/repaint/become-overlay-composited-layer-expected.txt: Added. Rebaselined.
  • platform/gtk/compositing/repaint/composited-document-element-expected.png: Added. Rebaselined.
  • platform/gtk/compositing/repaint/composited-document-element-expected.txt: Added. Rebaselined.
  • platform/gtk/compositing/repaint/content-into-overflow-expected.png: Added. Rebaselined.
  • platform/gtk/compositing/repaint/content-into-overflow-expected.txt: Added. Rebaselined.
  • platform/gtk/compositing/repaint/layer-repaint-expected.png: Added. Rebaselined.
  • platform/gtk/compositing/repaint/layer-repaint-expected.txt: Added. Rebaselined.
  • platform/gtk/compositing/repaint/layer-repaint-rects-expected.png: Added. Rebaselined.
  • platform/gtk/compositing/repaint/layer-repaint-rects-expected.txt: Added. Rebaselined.
  • platform/gtk/compositing/repaint/newly-composited-on-scroll-expected.png: Added. Rebaselined.
  • platform/gtk/compositing/repaint/newly-composited-on-scroll-expected.txt: Added. Rebaselined.
  • platform/gtk/compositing/repaint/opacity-between-absolute-expected.png: Added. Rebaselined.
  • platform/gtk/compositing/repaint/opacity-between-absolute-expected.txt: Added. Rebaselined.
  • platform/gtk/compositing/repaint/opacity-between-absolute2-expected.png: Added. Rebaselined.
  • platform/gtk/compositing/repaint/opacity-between-absolute2-expected.txt: Added. Rebaselined.
  • platform/gtk/compositing/repaint/overflow-into-content-expected.png: Added. Rebaselined.
  • platform/gtk/compositing/repaint/overflow-into-content-expected.txt: Added. Rebaselined.
  • platform/gtk/compositing/rtl/rtl-iframe-absolute-expected.txt: Added. Rebaselined.
  • platform/gtk/compositing/rtl/rtl-iframe-relative-expected.txt: Added. Rebaselined.
  • platform/gtk/compositing/rtl/rtl-overflow-scrolling-expected.txt: Added. Rebaselined.
  • platform/gtk/compositing/rtl/rtl-scrolling-with-transformed-descendants-expected.txt: Added. Rebaselined.
  • platform/gtk/compositing/self-painting-layers-expected.png: Added. Rebaselined.
  • platform/gtk/compositing/self-painting-layers-expected.txt: Added. Rebaselined.
  • platform/gtk/compositing/shadows/shadow-drawing-expected.png: Added. Rebaselined.
  • platform/gtk/compositing/shadows/shadow-drawing-expected.txt: Added. Rebaselined.
  • platform/gtk/compositing/sibling-positioning-expected.png: Added. Rebaselined.
  • platform/gtk/compositing/sibling-positioning-expected.txt: Added. Rebaselined.
  • platform/gtk/compositing/text-on-large-layer-expected.png: Added. Rebaselined.
  • platform/gtk/compositing/text-on-large-layer-expected.txt: Added. Rebaselined.
  • platform/gtk/compositing/tiling/huge-layer-add-remove-child-expected.txt: Added. Rebaselined.
  • platform/gtk/compositing/tiling/visiblerect-accumulated-offset-expected.png: Added. Rebaselined.
  • platform/gtk/compositing/tiling/visiblerect-accumulated-offset-expected.txt: Added. Rebaselined.
  • platform/gtk/compositing/visibility/layer-visible-content-expected.txt: Added. Rebaselined.
  • platform/gtk/compositing/webgl/webgl-background-color-expected.png: Added. Rebaselined.
  • platform/gtk/compositing/webgl/webgl-background-color-expected.txt: Added. Rebaselined.
  • platform/gtk/compositing/webgl/webgl-nonpremultiplied-blend-expected.png: Added. Rebaselined.
  • platform/gtk/compositing/webgl/webgl-nonpremultiplied-blend-expected.txt: Added. Rebaselined.
  • platform/gtk/css3/blending/background-blend-mode-default-value-expected.png: Added. Rebaselined.
  • platform/gtk/css3/blending/background-blend-mode-default-value-expected.txt: Added. Rebaselined.
  • platform/gtk/css3/blending/background-blend-mode-different-image-formats-expected.png: Added. Rebaselined.
  • platform/gtk/css3/blending/background-blend-mode-different-image-formats-expected.txt: Added. Rebaselined.
  • platform/gtk/css3/blending/background-blend-mode-gif-color-2-expected.png: Added. Rebaselined.
  • platform/gtk/css3/blending/background-blend-mode-gif-color-2-expected.txt: Added. Rebaselined.
  • platform/gtk/css3/blending/background-blend-mode-gif-color-expected.png: Added. Rebaselined.
  • platform/gtk/css3/blending/background-blend-mode-gif-color-expected.txt: Added. Rebaselined.
  • platform/gtk/css3/blending/background-blend-mode-image-color-expected.png: Added. Rebaselined.
  • platform/gtk/css3/blending/background-blend-mode-image-color-expected.txt: Added. Rebaselined.
  • platform/gtk/css3/blending/background-blend-mode-image-image-expected.png: Added. Rebaselined.
  • platform/gtk/css3/blending/background-blend-mode-image-image-expected.txt: Added. Rebaselined.
  • platform/gtk/css3/blending/background-blend-mode-single-layer-no-blending-expected.png: Added. Rebaselined.
  • platform/gtk/css3/blending/background-blend-mode-single-layer-no-blending-expected.txt: Added. Rebaselined.
  • platform/gtk/css3/blending/blend-mode-background-expected.png: Added. Rebaselined.
  • platform/gtk/css3/blending/blend-mode-background-expected.txt: Added. Rebaselined.
  • platform/gtk/css3/blending/blend-mode-isolation-flags-remove-non-stacking-context-blending-expected.png: Added. Rebaselined.
  • platform/gtk/css3/blending/blend-mode-isolation-flags-remove-non-stacking-context-blending-expected.txt: Added. Rebaselined.
  • platform/gtk/css3/blending/blend-mode-isolation-flags-remove-stacking-context-blending-expected.png: Added. Rebaselined.
  • platform/gtk/css3/blending/blend-mode-isolation-flags-remove-stacking-context-blending-expected.txt: Added. Rebaselined.
  • platform/gtk/css3/blending/svg-blend-layer-blend-expected.png: Added. Rebaselined.
  • platform/gtk/css3/blending/svg-blend-layer-blend-expected.txt: Added. Rebaselined.
  • platform/gtk/css3/blending/svg-blend-layer-filter-expected.png: Added. Rebaselined.
  • platform/gtk/css3/blending/svg-blend-layer-filter-expected.txt: Added. Rebaselined.
  • platform/gtk/css3/blending/svg-blend-layer-mask-expected.png: Added. Rebaselined.
  • platform/gtk/css3/blending/svg-blend-layer-mask-expected.txt: Added. Rebaselined.
  • platform/gtk/css3/blending/svg-blend-layer-opacity-expected.png: Added. Rebaselined.
  • platform/gtk/css3/blending/svg-blend-layer-opacity-expected.txt: Added. Rebaselined.
  • platform/gtk/css3/blending/svg-blend-layer-shadow-expected.png: Added. Rebaselined.
  • platform/gtk/css3/blending/svg-blend-layer-shadow-expected.txt: Added. Rebaselined.
  • platform/gtk/css3/blending/svg-blend-multiply-alpha-expected.png: Added. Rebaselined.
  • platform/gtk/css3/blending/svg-blend-multiply-alpha-expected.txt: Added. Rebaselined.
  • platform/gtk/css3/blending/svg-blend-normal-expected.png: Added. Rebaselined.
  • platform/gtk/css3/blending/svg-blend-normal-expected.txt: Added. Rebaselined.
  • platform/gtk/css3/blending/svg-blend-plus-darker-expected.png: Added. Rebaselined.
  • platform/gtk/css3/blending/svg-blend-plus-darker-expected.txt: Added. Rebaselined.
  • platform/gtk/css3/blending/svg-blend-plus-lighter-expected.png: Added. Rebaselined.
  • platform/gtk/css3/blending/svg-blend-plus-lighter-expected.txt: Added. Rebaselined.
  • platform/gtk/fast/canvas/webgl/css-webkit-canvas-expected.png: Added. Rebaselined.
  • platform/gtk/fast/canvas/webgl/css-webkit-canvas-expected.txt: Added. Rebaselined.
  • platform/gtk/fast/canvas/webgl/css-webkit-canvas-repaint-expected.png: Added. Rebaselined.
  • platform/gtk/fast/canvas/webgl/css-webkit-canvas-repaint-expected.txt: Added. Rebaselined.
7:34 AM Changeset in webkit [214222] by Manuel Rego Casasnovas
  • 2 edits in trunk/Websites/planet.webkit.org

[Planet WebKit] Use HTTPS instead of HTTP for Igalia blog

Unreviewed patch just updating the Igalia WebKit blog configuration.

  • config.ini:
7:12 AM Changeset in webkit [214221] by Carlos Garcia Campos
  • 2 edits in trunk/LayoutTests

Unreviewed GTK+ gardening. Remove expectations for imported/w3c/web-platform-tests/XMLHttpRequest/setrequestheader-content-type.htm.

It no longer works with current version of wptserve and it's already skipped globally.

  • platform/gtk/TestExpectations:
4:42 AM Changeset in webkit [214220] by Csaba Osztrogonác
  • 2 edits in trunk/Source/JavaScriptCore

[ARM] Add missing MacroAssembler functions after r214187
​https://bugs.webkit.org/show_bug.cgi?id=169912

Reviewed by Yusuke Suzuki.

  • assembler/MacroAssemblerARM.h:

(JSC::MacroAssemblerARM::loadFloat):
(JSC::MacroAssemblerARM::storeFloat):

4:31 AM Changeset in webkit [214219] by Yusuke Suzuki
  • 25 edits
    3 adds in trunk

[JSC] Optimize Number.prototype.toString on Int32 / Int52 / Double
​https://bugs.webkit.org/show_bug.cgi?id=167454

Reviewed by Saam Barati.

JSTests:

  • stress/number-to-string-abstract-operation.js: Added.

(shouldBe):
(int32ToString):
(shouldBe.int32ToString.new.Number.int52ToString):
(shouldBe.int32ToString.new.Number):
(shouldBe.doubleToString):

  • stress/number-to-string-radix.js: Added.

(shouldBe):
(int32ToString):
(shouldBe.int32ToString.new.Number.int52ToString):
(shouldBe.int32ToString.new.Number):
(shouldBe.doubleToString):

  • stress/number-to-string.js: Added.

(shouldBe):
(int32ToString):
(shouldBe.int32ToString.new.Number.int52ToString):
(shouldBe.int32ToString.new.Number):
(shouldBe.doubleToString):

Source/JavaScriptCore:

This patch improves Number.toString(radix) performance
by introducing NumberToStringWithRadix DFG node. It directly
calls the operation and it always returns String.

baseline patched

stanford-crypto-sha256-iterative 45.130+-0.928 44.032+-1.184 might be 1.0250x faster

4:16 AM Changeset in webkit [214218] by Yusuke Suzuki
  • 5 edits in trunk/Source/JavaScriptCore

[JSC] Add JSPromiseDeferred::reject(ExecState*, Exception*) interface
​https://bugs.webkit.org/show_bug.cgi?id=169908

Reviewed by Sam Weinig.

To avoid calling reject(ExecState*, JSValue) with Exception* accidentally,
we add a new interface reject(ExecState*, Exception*).
Such an interface is already added in DOMPromise in WebCore.

  • runtime/JSInternalPromiseDeferred.cpp:

(JSC::JSInternalPromiseDeferred::reject):

  • runtime/JSInternalPromiseDeferred.h:
  • runtime/JSPromiseDeferred.cpp:

(JSC::JSPromiseDeferred::reject):

  • runtime/JSPromiseDeferred.h:
2:43 AM Changeset in webkit [214217] by Carlos Garcia Campos
  • 2 edits in trunk/LayoutTests

Unreviewed GTK+ gardening. Remove duplicated entry.

  • platform/gtk/TestExpectations:
2:12 AM Changeset in webkit [214216] by Carlos Garcia Campos
  • 2 edits in trunk/LayoutTests

Unreviewed GTK+ gardening. Mark more tests that are failing.

  • platform/gtk/TestExpectations:
2:11 AM Changeset in webkit [214215] by commit-queue@webkit.org
  • 9 edits
    8 adds in trunk

[GTK] Add function webkit_dom_element_get_bounding_client_rect
​https://bugs.webkit.org/show_bug.cgi?id=163892

Patch by Aidan Holm <​aidanholm+webkit@gmail.com> on 2017-03-21
Reviewed by Carlos Garcia Campos.

Wrap WebCore::ClientRect as WebKitDOMClientRect.
Wrap WebCore::ClientRectList as WebKitDOMClientRectList.
Implement webkit_dom_element_get_bounding_client_rect().
Implement webkit_dom_element_get_client_rects().

  • PlatformGTK.cmake:
  • WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMClientRect.cpp: Added.
  • WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMClientRectList.cpp: Added.

(WebKit::kit):
(WebKit::core):
(WebKit::wrapClientRect):
(webkit_dom_client_rect_finalize):
(webkit_dom_client_rect_get_property):
(webkit_dom_client_rect_constructed):
(webkit_dom_client_rect_class_init):
(webkit_dom_client_rect_init):
(webkit_dom_client_rect_get_top):
(webkit_dom_client_rect_get_right):
(webkit_dom_client_rect_get_bottom):
(webkit_dom_client_rect_get_left):
(webkit_dom_client_rect_get_width):
(webkit_dom_client_rect_get_height):

  • WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMClientRect.h: Added.
  • WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMClientRectPrivate.h: Added.
  • WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMClientRectList.h: Added.
  • WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMClientRectListPrivate.h: Added.
  • WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMElement.cpp:

(webkit_dom_element_get_property):
(webkit_dom_element_class_init):
(webkit_dom_element_get_scroll_height):
(webkit_dom_element_get_bounding_client_rect):
(webkit_dom_element_get_client_rects):

  • WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMElement.h:
  • WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMPrivate.cpp:

(WebKit::wrap):

  • WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMPrivate.h:
  • WebProcess/InjectedBundle/API/gtk/DOM/docs/webkitdomgtk-4.0-sections.txt:
  • WebProcess/InjectedBundle/API/gtk/DOM/webkitdom.h:
  • WebProcess/InjectedBundle/API/gtk/DOM/webkitdomautocleanups.h:
  • WebProcess/InjectedBundle/API/gtk/DOM/webkitdomdefines.h:
1:59 AM Changeset in webkit [214214] by Carlos Garcia Campos
  • 2 edits in trunk/LayoutTests

Unreviewed GTK+ gardening. Mark several tests as failing and skip others.

  • platform/gtk/TestExpectations:
1:34 AM Changeset in webkit [214213] by commit-queue@webkit.org
  • 3 edits in trunk/Source/JavaScriptCore

[jsc] MacroAssemblerMIPS: implement the branchPtr(RelationalCondition, BaseIndex, RegisterID) overload.
​https://bugs.webkit.org/show_bug.cgi?id=169717

Patch by Zan Dobersek <​zdobersek@igalia.com> on 2017-03-21
Reviewed by Yusuke Suzuki.

  • assembler/MacroAssembler.h: Expose branchPtr() on MIPS as well.
  • assembler/MacroAssemblerMIPS.h:

(JSC::MacroAssemblerMIPS::branchPtr): Added.

12:50 AM Changeset in webkit [214212] by jonlee@apple.com
  • 34 edits
    7 copies
    1 move
    5 deletes in trunk/Source/WebCore

Clean up RTCSdpType, RTC enums and headers
​https://bugs.webkit.org/show_bug.cgi?id=169741

Reviewed by Youenn Fablet.

Convert to RTCSdpType.

  • Modules/mediastream/MediaEndpointPeerConnection.cpp:
  • Modules/mediastream/MediaEndpointPeerConnection.h:
  • Modules/mediastream/MediaEndpointSessionDescription.cpp:
  • Modules/mediastream/MediaEndpointSessionDescription.h:
  • Modules/mediastream/PeerConnectionBackend.cpp:
  • Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp:

Convert SDP argument to lvalue.

  • Modules/mediastream/RTCSessionDescription.cpp:
  • Modules/mediastream/RTCSessionDescription.h:
  • Modules/mediastream/RTCSessionDescription.idl:

Keep RTC enum IDLs above platform. Move the C++ enum headers into platform.

  • Modules/mediastream/RTCEnums.h: Removed.
  • Modules/mediastream/RTCIceConnectionState.h: Removed.
  • Modules/mediastream/RTCIceGatheringState.h: Removed.
  • Modules/mediastream/RTCIceTransportState.h: Removed.
  • Modules/mediastream/RTCSignalingState.h: Removed.
  • platform/mediastream/PeerConnectionStates.h: Remove from .xcodeproj. Move enums to separate headers.
  • platform/mediastream/RTCBundlePolicy.h:
  • platform/mediastream/RTCIceConnectionState.h:
  • platform/mediastream/RTCIceGatheringState.h:
  • platform/mediastream/RTCIceTransportPolicy.h:
  • platform/mediastream/RTCIceTransportState.h:
  • platform/mediastream/RTCRtpTransceiverDirection.h: Renamed from Source/WebCore/Modules/mediastream/RTCRtpTransceiverDirection.h.
  • platform/mediastream/RTCSdpType.h:
  • platform/mediastream/RTCSignalingState.h:

Move RtpTransceiverDirection out to a separate IDL.

  • Modules/mediastream/RTCPeerConnection.idl:
  • Modules/mediastream/RTCRtpTransceiver.cpp:
  • Modules/mediastream/RTCRtpTransceiver.h:
  • WebCore.xcodeproj/project.pbxproj:

Replace RTCEnums include with specific headers per enum.

  • Modules/mediastream/PeerConnectionBackend.h:
  • Modules/mediastream/RTCConfiguration.h:
  • Modules/mediastream/RTCIceTransport.h:
  • Modules/mediastream/RTCPeerConnection.cpp:

(WebCore::RTCPeerConnection::completeAddTransceiver): Remove unneeded static_cast.

  • Modules/mediastream/RTCPeerConnection.h:
  • Modules/mediastream/RTCRtpTransceiver.h:
  • platform/mediastream/MediaEndpoint.h:
  • platform/mediastream/MediaEndpointConfiguration.h:
  • platform/mock/MockMediaEndpoint.h:

Clean up license.

  • Modules/mediastream/libwebrtc/LibWebRTCDataChannelHandler.h:
  • Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.h:
  • Modules/mediastream/libwebrtc/LibWebRTCPeerConnectionBackend.h:

Modernize header to use #pragma once.

  • platform/mediastream/RTCDTMFSenderHandler.h:
  • platform/mediastream/RTCDTMFSenderHandlerClient.h:
  • platform/mediastream/RTCIceCandidateDescriptor.h:
  • platform/mediastream/RTCPeerConnectionHandlerClient.h:
  • platform/mediastream/RTCSessionDescriptionDescriptor.h:
  • platform/mediastream/RTCSessionDescriptionRequest.h:
  • platform/mediastream/RTCVoidRequest.h:
  • platform/mock/RTCNotifiersMock.h:

Mar 20, 2017:

11:07 PM Changeset in webkit [214211] by jonlee@apple.com
  • 2 edits in trunk/LayoutTests/imported/w3c

Update progression in wpt test for WebRTC.

  • web-platform-tests/webrtc/rtcpeerconnection/rtcpeerconnection-constructor-expected.txt:
8:27 PM Changeset in webkit [214210] by webkit@devinrousso.com
  • 5 edits in trunk/Source/WebInspectorUI

Web Inspector: RTL: minor layout issues in Breakpoint Editor popover
​https://bugs.webkit.org/show_bug.cgi?id=169765

Reviewed by Brian Burg.

  • UserInterface/Controllers/BreakpointPopoverController.js:

(WebInspector.BreakpointPopoverController.prototype._createPopoverContent):
Fix typo.

  • UserInterface/Views/BreakpointActionView.css:

(body[dir=ltr] .breakpoint-action-button-container):
(body[dir=rtl] .breakpoint-action-button-container):
(:matches(.breakpoint-action-append-button, .breakpoint-action-remove-button)):
(body[dir=ltr] :matches(.breakpoint-action-append-button, .breakpoint-action-remove-button)):
(body[dir=rtl] :matches(.breakpoint-action-append-button, .breakpoint-action-remove-button)):
(.breakpoint-action-block-body > .description):
(body[dir=ltr] .breakpoint-action-block-body > .description):
(body[dir=rtl] .breakpoint-action-block-body > .description):
(.breakpoint-action-block-body > input):
(.breakpoint-action-button-container): Deleted.
(.breakpoint-action-append-button, .breakpoint-action-remove-button): Deleted.

  • UserInterface/Views/BreakpointActionView.js:

(WebInspector.BreakpointActionView.prototype._updateBody):
Manually apply dir="ltr" to the description element to force proper rendering.

  • UserInterface/Views/BreakpointPopoverController.css:

(.popover .edit-breakpoint-popover-content):
(.popover .edit-breakpoint-popover-content > table > tr > th):
(#edit-breakpoint-popover-ignore):
(body[dir=ltr] :matches(#edit-breakpoint-popover-ignore, #edit-breakpoint-popover-auto-continue)):
(body[dir=rtl] :matches(#edit-breakpoint-popover-ignore, #edit-breakpoint-popover-auto-continue)):
(#edit-breakpoint-popoover-auto-continue): Deleted.

8:16 PM Changeset in webkit [214209] by jonlee@apple.com
  • 8 edits
    2 adds in trunk

Add iceCandidatePoolSize to RTCConfiguration
​https://bugs.webkit.org/show_bug.cgi?id=169866

Reviewed by Youenn Fablet.

Source/WebCore:

Test: webrtc/rtcconfiguration-icecandidatepoolsize.html

  • Modules/mediastream/RTCConfiguration.h:
  • Modules/mediastream/RTCConfiguration.idl: Add iceCandidatePoolSize.
  • Modules/mediastream/RTCPeerConnection.cpp:

(WebCore::RTCPeerConnection::setConfiguration):

  • Modules/mediastream/libwebrtc/LibWebRTCPeerConnectionBackend.cpp:

(WebCore::configurationFromMediaEndpointConfiguration): Set the size in libwebrtc.

  • platform/mediastream/MediaEndpointConfiguration.cpp:

(WebCore::MediaEndpointConfiguration::MediaEndpointConfiguration):

  • platform/mediastream/MediaEndpointConfiguration.h:

LayoutTests:

  • webrtc/rtcconfiguration-icecandidatepoolsize-expected.txt: Added.
  • webrtc/rtcconfiguration-icecandidatepoolsize.html: Added.
7:55 PM Changeset in webkit [214208] by Nikita Vasilyev
  • 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Icon next to "An error occurred..." message changes size when Inspector window is resized
​https://bugs.webkit.org/show_bug.cgi?id=169901

Reviewed by Brian Burg.

  • UserInterface/Views/Main.css:

(.message-text-view.error::before):

7:51 PM Changeset in webkit [214207] by jonlee@apple.com
  • 2 edits in trunk/Source/WebCore

Follow-up on comments for bug 169664
​https://bugs.webkit.org/show_bug.cgi?id=169709

Reviewed by Youenn Fablet.

  • Modules/mediastream/MediaEndpointPeerConnection.cpp:

(WebCore::deriveAggregatedIceConnectionState): Update deriveAggregatedIceConnectionState.
(WebCore::MediaEndpointPeerConnection::iceTransportStateChanged): Set a capacity and used
uncheckedAppend.

7:15 PM Changeset in webkit [214206] by rniwa@webkit.org
  • 2 edits in trunk/Websites/perf.webkit.org

Delete another function that was supposed to be removed in the previous commit.

  • public/v3/models/build-request.js:

(BuildRequest.cachedRequestsForTriggerableID): Deleted.

7:13 PM Changeset in webkit [214205] by rniwa@webkit.org
  • 3 edits in trunk/Websites/perf.webkit.org

Modernize BuildRequestQueuePage
​https://bugs.webkit.org/show_bug.cgi?id=169903

Reviewed by Antti Koivisto.

Modernized the code for /v3/#/analysis/queue.

  • public/v3/models/build-request.js:

(BuildRequest.fetchTriggerables): Deleted since the manifest JSON now contains all the triggerables.

  • public/v3/pages/build-request-queue-page.js:

(BuildRequestQueuePage): Deleted this._triggerables. Added this._buildRequestsByTriggerable.
(BuildRequestQueuePage.prototype.open): Modernized the code.
(BuildRequestQueuePage.prototype.render): Ditto.
(BuildRequestQueuePage.prototype._constructBuildRequestTable): Ditto.

7:04 PM Changeset in webkit [214204] by Simon Fraser
  • 6 edits in trunk

Add a system trace point for memory warning handling
​https://bugs.webkit.org/show_bug.cgi?id=169893

Reviewed by Zalan Bujtas.

Source/WebCore:

Add a TraceScope for low memory handling, which logs 'critical' and 'synchronous'.

  • page/MemoryRelease.cpp:

(WebCore::releaseMemory):

Source/WTF:

Make it possible to pass data to the Begin trace point.

  • wtf/SystemTracing.h:

(WTF::TraceScope::TraceScope):

Tools:

Describe the new trace points.

  • Tracing/SystemTracePoints.plist:
7:04 PM Changeset in webkit [214203] by Simon Fraser
  • 8 edits in trunk/Source/WebCore

Optimize packing of Document and superclass data members
​https://bugs.webkit.org/show_bug.cgi?id=169880

Reviewed by Antti Koivisto.

Move data members around to optimize packing in SecurityContext, SuspendableTimer and Document.
This saves as few hundred bytes on Document.

Padding detected via Tools/Scripts/dump-class-layout

  • dom/Document.cpp:

(WebCore::Document::Document):

  • dom/Document.h:
  • dom/ScriptExecutionContext.h:
  • dom/SecurityContext.cpp:

(WebCore::SecurityContext::SecurityContext):

  • dom/SecurityContext.h:
  • page/SuspendableTimer.cpp:

(WebCore::SuspendableTimer::SuspendableTimer):

  • page/SuspendableTimer.h:
6:19 PM Changeset in webkit [214202] by rniwa@webkit.org
  • 12 edits
    1 move
    1 add in trunk/Websites/perf.webkit.org

Charts page show an inconsistent list of revisions for Git and Subversion
​https://bugs.webkit.org/show_bug.cgi?id=169888

Reviewed by Andreas Kling.

With Git, CommitLogViewer was showing the list of revisions including the starting hash,
which was the last data point's revision instead of all revisions after the last data point.

Fixed the bug by always specifying the revision at the last data point in both Subversion
and Git and then making /api/commits/<repository>/?from=X&to=Y exclude the first revision.
For clarity, "from" and "to" query parameters have been renamed to "precedingRevision" and
"lastRevision" respectively.

We also no longer adds 1 to the starting revision of Subversion-like starting revisions. e.g.
when the last data point was at r1234, new data point is at r1250, the label is now "r1234-r1250"
instead of "r1235-r1250".

  • browser-tests/chart-revision-range-tests.js: Fixed the tests since revisionList no longer

specifies from/to revisions.

  • browser-tests/commit-log-viewer-tests.js: Added. Added tests for CommitLogViewer.
  • browser-tests/index.html: Include the new test. Also use a local copy of mocha.js/css.
  • public/api/commits.php:

(main): Renamed "from" and "to" query parameters.

  • public/include/commit-log-fetcher.php:

(CommitLogFetcher::fetch_between): Added a check that commit time should either be specified
in both rows or not specified in either. Also reject when before_first_revision is identical
or after last_revision instead of re-ordering them since it no longer makes sense to do so with
new query parameter names.

  • public/v3/components/base.js:

(ComponentBase._addContentToElement): Use Array.isArray instead of instanceof. It's resilient
againt realm (global object) differences.

  • public/v3/components/chart-pane-base.js:

(ChartPaneBase.prototype._updateCommitLogViewer): No longer calls enqueueToRender on this since
CommitLogViewer does that on its own now.
(ChartPaneBase.prototype.render): Juse use this._openRepository instead of relying on CommitLogViewer
to remember which repository is current. This was the only use of currentRepository.

  • public/v3/components/commit-log-viewer.js:

(CommitLogViewer):
(CommitLogViewer.prototype.currentRepository): Deleted.
(CommitLogViewer.prototype.view):
(CommitLogViewer.prototype._fetchCommitLogs): Modernized and extracted from view to make it lazy.
Call fetchForSingleRevision when precedingRevision is not specified or it's identical to lastRevision
since the generic JSON API no longer supports being called with the identical revisions.
(CommitLogViewer.prototype.render): Modernized & simplified the code.
(CommitLogViewer.prototype._renderCommitList): Extracted from render to make it lazy.
(CommitLogViewer.htmlTemplate): Add ID on caption & tbody so that they're more easily addressable.
(CommitLogViewer.cssTemplate):

  • public/v3/models/commit-log.js:

(CommitLog.prototype.diff): No longer includes from/to revisions in the result. Also avoid adding
1 to a Subversion-like starting revision for creating the label. See above. But we still do this
for forming URLs due to the way tools like Trac work with Subversion revisions.
(CommitLog.fetchBetweenRevisions): Rewritten using DataModel.prototype.cachedFetch with FIXME for
what this function is supposed to be doing.
(CommitLog._cachedCommitLogs): Deleted.
(CommitLog.fetchForSingleRevision): Added.
(CommitLog._constructFromRawData): Added.

  • public/v3/models/data-model.js:

(DataModelObject.cachedFetch): Don't parse query values as an integer. Just URL-escape them.

  • public/v3/remote.js:

(BrowserRemoteAPI.prototype.sendHttpRequest): Fixed a typo.

  • server-tests/api-commits-tests.js: Renamed from api-commits.js. Updated the existing tests to

use new query parameters and added more test cases.

  • unit-tests/commit-log-tests.js: Updated the test cases now that CommitLog.prototype.diff no longer

includes from/to values. They're computed in ChartRevisionRange instead.

6:13 PM Changeset in webkit [214201] by achristensen@apple.com
  • 8 edits in trunk

WebPageProxy DecidePolicyForNavigationAction and DecidePolicyForResponseSync should be Delayed reply messages
​https://bugs.webkit.org/show_bug.cgi?id=167183
<rdar://problem/30203539>

Reviewed by Andy Estes.

Source/WebKit2:

Before this patch, the WKNavigationDelegate's decidePolicyForNavigationAction must synchronously call the decisionHandler.
If it stores the decisionHandler and calls it after decidePolicyForNavigationAction returns, we can get incorrect behavior.
This can be seen when the _WKWebsitePolicies given to the decisionHandler had no effect.
Now, we will have the WebProcess waiting on the UIProcess to respond to the Delayed reply before continuing.
This will not be a regression because currently everybody is either calling the decisionHandler immediately or getting incorrect behavior,
and the behavior will be the same if the decisionHandler is called immediately. It is possible that we could make the WebProcess
not wait on the response, but we would need to make WebCore's loading truly asynchronous first
(getting rid of ResourceHandleClient's synchronous methods).

Covered by making an API test asynchronously call the decisionHandler.

  • UIProcess/API/C/WKPage.cpp:

(WKPageSetPageNavigationClient):

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::receivedPolicyDecision):
(WebKit::WebPageProxy::decidePolicyForNavigationAction):
(WebKit::WebPageProxy::decidePolicyForResponseSync):

  • UIProcess/WebPageProxy.h:
  • UIProcess/WebPageProxy.messages.in:
  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::dispatchDecidePolicyForResponse):
(WebKit::WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):

Tools:

  • TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:

(-[WebsitePoliciesDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]):

6:10 PM Changeset in webkit [214200] by jmarcell@apple.com
  • 1 copy in tags/Safari-603.2.1

Tag Safari-603.2.1.

6:01 PM Changeset in webkit [214199] by Nikita Vasilyev
  • 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Clicking on Clear Network Items icon throws an exception if timing popover is visible
​https://bugs.webkit.org/show_bug.cgi?id=169852
<rdar://problem/31132652>

Reviewed by Joseph Pecoraro.

  • UserInterface/Views/ResourceTimelineDataGridNode.js:

(WebInspector.ResourceTimelineDataGridNode.prototype._mouseoverRecordBar):
(WebInspector.ResourceTimelineDataGridNode):

5:46 PM Changeset in webkit [214198] by Nikita Vasilyev
  • 2 edits in trunk/Source/WebInspectorUI

REGRESSION (r187873): Web Inspector: When resizing, prevent DataGrid columns from collapsing entirely
​https://bugs.webkit.org/show_bug.cgi?id=169899

Reviewed by Joseph Pecoraro.

  • UserInterface/Views/DataGrid.js:

(WebInspector.DataGrid.prototype.resizerDragging):
leftMinimum and rightMaximum variables were always NaN because this.ColumnResizePadding is undefined.

5:19 PM Changeset in webkit [214197] by achristensen@apple.com
  • 2 edits in trunk/Source/WebKit2

Fix GTK build after r214190
​https://bugs.webkit.org/show_bug.cgi?id=169885

  • UIProcess/InspectorServer/WebSocketServerConnection.cpp:

(WebKit::WebSocketServerConnection::sendWebSocketMessage):
(WebKit::WebSocketServerConnection::sendHTTPResponseHeader):
(WebKit::WebSocketServerConnection::sendRawData):
Finish renaming send to sendData.

5:14 PM Changeset in webkit [214196] by Matt Baker
  • 3 edits in trunk/Source/WebInspectorUI

Web Inspector: Pseudo-class markers overlap DOM breakpoints and disclosure triangle
​https://bugs.webkit.org/show_bug.cgi?id=169850
<rdar://problem/31132335>

Reviewed by Joseph Pecoraro.

DOMTreeContentView should always have at least 7px of gutter space to
accomodate pseudo-class markers. When DOM breakpoints are visible the
gutter size is increased so breakpoints and markers do not overlap.

  • UserInterface/Views/DOMTreeContentView.css:

(.content-view.dom-tree .tree-outline.dom):
(.content-view.dom-tree.show-gutter .tree-outline.dom):
(body[dir=ltr] .content-view.dom-tree .tree-outline.dom):
(body[dir=rtl] .content-view.dom-tree .tree-outline.dom):
(body[dir=ltr] .content-view.dom-tree.show-gutter .tree-outline.dom): Deleted.
(body[dir=rtl] .content-view.dom-tree.show-gutter .tree-outline.dom): Deleted.

  • UserInterface/Views/DOMTreeOutline.css:

(.content-view.dom-tree.show-gutter .tree-outline.dom):
Change pseudo-class marker indent when showing DOM breakpoint gutter.
(body[dir=ltr] .tree-outline.dom li.pseudo-class-enabled > .selection-area::before):
Drive-by fix: copy paste error.

4:47 PM Changeset in webkit [214195] by Chris Dumez
  • 4 edits
    2 adds in trunk

Suspend media playback in background tabs
​https://bugs.webkit.org/show_bug.cgi?id=169883
<rdar://problem/28056151>

Reviewed by Eric Carlson.

Source/WebCore:

Suspend media playback in background tabs to save battery
except in cases where we cannot (e.g. PiP, AirPlay).

Test: media/media-playback-page-visibility.html

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::visibilityStateChanged):
When page visibility state changes, begin / end media session
interruption with reason PlatformMediaSession::EnteringBackground.
This reason was already used on iOS when the application enters
or exist background. HTMLMediaElement::shouldOverrideBackgroundPlaybackRestriction()
takes care of preventing interruption in case of AirPlay or PiP.

LayoutTests:

Add layout test coverage.

  • media/media-playback-page-visibility-expected.txt: Added.
  • media/media-playback-page-visibility.html: Added.
4:07 PM Changeset in webkit [214194] by dbates@webkit.org
  • 5 edits in trunk

Prevent new navigations from onbeforeunload handler
​https://bugs.webkit.org/show_bug.cgi?id=169891
<rdar://problem/31155736>

Reviewed by Ryosuke Niwa.

Source/WebCore:

Ensure that all navigations initiated from an onbeforeunload handler are disallowed
regardless of how they were scheduled. Such navigations go against the expectation
of a user.

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::isNavigationAllowed): Added.
(WebCore::FrameLoader::loadURL): Modified code to call FrameLoader::isNavigationAllowed().
(WebCore::FrameLoader::loadWithDocumentLoader): Ditto.
(WebCore::FrameLoader::stopAllLoaders): Ditto.

  • loader/FrameLoader.h:

LayoutTests:

Update test to ensure that we disallow navigation initiated via a DOM click event from
an onbeforeunload handler.

  • fast/events/before-unload-forbidden-navigation.html:
3:36 PM Changeset in webkit [214193] by rniwa@webkit.org
  • 5 edits
    1 move in trunk/Websites/perf.webkit.org

Fix os-build-fetcher.js and subprocess.js to make them work
​https://bugs.webkit.org/show_bug.cgi?id=169844

Reviewed by Antti Koivisto.

The script added in r213976 has a bug that it can execute commands to fetch subcommits in parallel.
Some commands to poll the lsit of system components is not desirable to be ran in parallel.

  • server-tests/resources/mock-subprocess.js:

(MockSubprocess): Use const declaration.
(MockSubprocess.resetAndWaitForInvocation): Added.
(MockSubprocess.waitForInvocation): Renamed from waitingForInvocation. A function name must be a verb.
See ​https://webkit.org/code-style-guidelines/#names-verb
(MockSubprocess.reset): Set invocations.length to 0 so that tests can store a reference to the array
regardless of whether reset is called or when it's called.

  • server-tests/tools-os-build-fetcher-tests.js: Updated tests per the code change. Most of codes now

expect each command to be ran seprately. e.g. if there were two commands to run, instead of expecting
them to be both ran, and resolving invocation promises, we'd wait for one command to run, resolve,
its subcommand to run, and then move onto the second top-level command. Also use a local reference
to MockSubprocess.invocations instead of using the fully qualified name.

  • tools/js/os-build-fetcher.js:

(mapInSerialPromiseChain): Added. Calling a closure that returns a promise on each item in an array
in serial (not asynchronous) is a very common pattern in this class.
(OSBuildFetcher.fetchAndReportAllInOrder): Added.
(OSBuildFetcher.prototype.fetchAndReportNewBuilds): Log what the number of builds being submitted.
(OSBuildFetcher.prototype._fetchAvailableBuilds): Fixed the main bug. Using Promise.all would result
in each top-level command to be execued in parallel. Since each subcommand is executed as soon as
its parent command is executed, this results in commands to be executed in parallel.
Added a whole bunch of logging so that we can at least detect a bug like this in the future.
(OSBuildFetcher.prototype._commitsForAvailableBuilds): Cleanup the coding style.
(OSBuildFetcher.prototype._addSubCommitsForBuild): Use mapInSerialPromiseChain. Tightened the assertion
about the content returned by a subcommand.

  • tools/js/subprocess.js: Fixed the bug that we were importing require('child_process').ChildProcess.

execFile is defined on require('child_process') itself.
(Subprocess.prototype.execute): Fixed a typo. this._childProcess doesn't exist.
(Subprocess):

  • tools/sync-os-versions.js: Renamed from tools/pull-os-versions.js.

(syncLoop): Cleaned up the coding style a little. Also added logging about how long we're about to sleep.

2:33 PM Changeset in webkit [214192] by Jonathan Bedard
  • 4 edits in trunk/Tools

webkitpy: Work around simctl launch returning dead processes
​https://bugs.webkit.org/show_bug.cgi?id=169878

Reviewed by Daniel Bates.

simctl launch will sometimes give the PID of a process which has just been terminated.
To work around this, we will always check if the returned PID is of a process which is
still running.

  • Scripts/webkitpy/port/simulator_process.py:

(SimulatorProcess.Popen.init): Accept device argument.
(SimulatorProcess.Popen.poll): Call device.poll().
(SimulatorProcess._start): Pass device into Popen object.

  • Scripts/webkitpy/xcode/device.py:

(Device.poll): Added.

  • Scripts/webkitpy/xcode/simulated_device.py:

(SimulatedDevice.install_app): Change attempts to timeout.
(SimulatedDevice.launch_app): Check that the process being returned is active, use a
timeout instead of attempts.
(SimulatedDevice):
(SimulatedDevice.poll): Added.

1:09 PM Changeset in webkit [214191] by Ryan Haddad
  • 2 edits in branches/safari-603.1.30.0-branch/LayoutTests

Merge r209999.

1:05 PM Changeset in webkit [214190] by achristensen@apple.com
  • 7 edits in trunk/Source/WebCore

Prepare SocketStreamHandle for being created from WK2
​https://bugs.webkit.org/show_bug.cgi?id=169885

Reviewed by Andy Estes.

No change in behavior.

  • Modules/websockets/WebSocketChannel.cpp:

(WebCore::WebSocketChannel::didOpenSocketStream):
(WebCore::WebSocketChannel::sendFrame):
Rename send to sendData to prevent name collisions with IPC::MessageSender::send.

  • platform/network/SocketStreamHandle.cpp:

(WebCore::SocketStreamHandle::sendData):
(WebCore::SocketStreamHandle::send): Deleted.

  • platform/network/SocketStreamHandle.h:
  • platform/network/cf/SocketStreamHandleImpl.h:
  • platform/network/curl/SocketStreamHandleImpl.h:
  • platform/network/soup/SocketStreamHandleImpl.h:

Make platformSend and platformClose public so I can call them from IPC proxies.

12:50 PM Changeset in webkit [214189] by aestes@apple.com
  • 4 edits
    3 adds in trunk

[QuickLook] Subresources should be in the same origin as the main document
​https://bugs.webkit.org/show_bug.cgi?id=169868
<rdar://problem/29898214>

Reviewed by Daniel Bates.

Source/WebCore:

Prior to this change, QuickLook documents were placed in a unique origin, which meant all
subresources were loaded as cross-origin requests. This prevented XMLHttpRequests to the
QuickLook custom protocol, since cross-origin XHRs must be made to a protocol that
understands CORS.

Instead of a unique origin, we now create an origin for QuickLook documents from the preview
response URL (an x-apple-ql-id: URL), which will allow QuickLook to make same-origin XHRs by
using a URL with the same scheme and host as the preview response URL.

Test: http/tests/quicklook/same-origin-xmlhttprequest-allowed.html

  • dom/Document.cpp:

(WebCore::Document::applyQuickLookSandbox):

LayoutTests:

  • http/tests/quicklook/resources/same-origin-xmlhttprequest-allowed.rtf: Added.
  • http/tests/quicklook/resources/tap-run-test-hyperlink.js:

(runTest):

  • http/tests/quicklook/same-origin-xmlhttprequest-allowed-expected.txt: Added.
  • http/tests/quicklook/same-origin-xmlhttprequest-allowed.html: Added.
12:46 PM Changeset in webkit [214188] by jiewen_tan@apple.com
  • 2 edits in trunk/Source/WebCore

window.crypto.getRandomValues() uses the insecure RC4 RNG
​https://bugs.webkit.org/show_bug.cgi?id=169623
<rdar://problem/31044229>

Reviewed by Brent Fulgham.

This patch replaces the RC4 RNG with one based on AES-CTR.

No change of behavior.

  • page/Crypto.cpp:

(WebCore::Crypto::getRandomValues):

11:58 AM Changeset in webkit [214187] by fpizlo@apple.com
  • 9 edits in trunk/Source/JavaScriptCore

Graph coloring should use coalescable moves when spilling
​https://bugs.webkit.org/show_bug.cgi?id=169820

Reviewed by Michael Saboff.

This makes our graph coloring register allocator use a new family of move instructions when
spilling both operands of the move. It's a three-operand move:

Move (src), (dst), %scratch

Previously, if both operands got spilled, we would emit a new instruction to load or store that
spill slot. But this made it hard for allocateStack to see that the two spill locations are
coalescable. This new kind of instruction makes it obvious that it's a coalescable move.

This change implements the coalescing of spill slots inside allocateStack.

This is an outrageous speed-up on the tsf_ir_speed benchmark from ​http://filpizlo.com/tsf/. This
is an interesting benchmark because it has a super ugly interpreter loop with ~20 live variables
carried around the loop back edge. This change makes that interpreter run 5x faster.

This isn't a speed-up on any other benchmarks. It also doesn't regress anything. Compile time is
neither progressed or regressed, since the coalescing is super cheap, and this does not add any
significant new machinery to the register allocator (it's just a small change to spill codegen).
Overall on our wasm benchmarks, this is a 16% throughput progression.

  • assembler/MacroAssembler.h:

(JSC::MacroAssembler::move):
(JSC::MacroAssembler::move32):
(JSC::MacroAssembler::moveFloat):
(JSC::MacroAssembler::moveDouble):

  • b3/air/AirAllocateRegistersByGraphColoring.cpp:

(JSC::B3::Air::allocateRegistersByGraphColoring):

  • b3/air/AirAllocateStack.cpp:

(JSC::B3::Air::allocateStack):

  • b3/air/AirInst.cpp:

(JSC::B3::Air::Inst::hasEarlyDef):
(JSC::B3::Air::Inst::hasLateUseOrDef):
(JSC::B3::Air::Inst::needsPadding):

  • b3/air/AirInst.h:
  • b3/air/AirOpcode.opcodes:
  • b3/air/AirPadInterference.cpp:

(JSC::B3::Air::padInterference):

  • runtime/Options.h:
11:51 AM Changeset in webkit [214186] by matthew_hanson@apple.com
  • 3 edits in branches/safari-603-branch/LayoutTests

Merge r214096.

11:51 AM Changeset in webkit [214185] by matthew_hanson@apple.com
  • 2 edits in branches/safari-603-branch/LayoutTests

Merge r214095.

11:51 AM Changeset in webkit [214184] by matthew_hanson@apple.com
  • 1 edit
    3 adds in branches/safari-603-branch/LayoutTests

Merge r214094.

11:51 AM Changeset in webkit [214183] by matthew_hanson@apple.com
  • 7 edits
    2 deletes in branches/safari-603-branch/LayoutTests

Merge r214081.

11:43 AM Changeset in webkit [214182] by matthew_hanson@apple.com
  • 3 edits in branches/safari-603-branch/LayoutTests

Merge r213953. rdar://problem/31049771

11:43 AM Changeset in webkit [214181] by matthew_hanson@apple.com
  • 2 edits in branches/safari-603-branch/Source/WebCore

Merge r213949. rdar://problem/31049771

11:40 AM Changeset in webkit [214180] by matthew_hanson@apple.com
  • 9 edits
    2 adds in branches/safari-603-branch

Merge r213253. rdar://problem/30773140

11:30 AM Changeset in webkit [214179] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

Fix a paste-o in WebPaymentCoordinatorProxy::platformCompletePaymentSession
​https://bugs.webkit.org/show_bug.cgi?id=169881
rdar://problem/31030944

Reviewed by Dan Bernstein.

Don't always pass PKPaymentAuthorizationStatusFailure to the completion handler.

  • UIProcess/ApplePay/cocoa/WebPaymentCoordinatorProxyCocoa.mm:

(WebKit::WebPaymentCoordinatorProxy::platformCompletePaymentSession):

10:55 AM Changeset in webkit [214178] by eric.carlson@apple.com
  • 17 edits in trunk

[MediaStream] Respect constraints passed to getUserMedia
​https://bugs.webkit.org/show_bug.cgi?id=169870
<rdar://problem/31138936>

Reviewed by Youenn Fablet and Jer Noble.
Source/WebCore:

Remember the fitness score calculated when evaluating constraints passed to getUserMedia, so
the best device is chosen when more than one device supports the constraints. Register two
mock video and two mock audio devices with different capabilities so these changes can
be tested.

No new tests, existing tests updated.

  • platform/mediastream/RealtimeMediaSource.cpp:

(WebCore::RealtimeMediaSource::selectSettings): Store fitness score in m_fitnessScore.

  • platform/mediastream/RealtimeMediaSource.h:
  • platform/mediastream/mac/MockRealtimeAudioSourceMac.h:
  • platform/mediastream/mac/MockRealtimeAudioSourceMac.mm:

(WebCore::MockRealtimeAudioSource::create): Don't assume sampleRate is 44.1K
(WebCore::MockRealtimeAudioSourceMac::emitSampleBuffers): Use sampleRate() instead of m_sampleRate.
(WebCore::MockRealtimeAudioSourceMac::reconfigure): Ditto.
(WebCore::MockRealtimeAudioSourceMac::render): Ditto.
(WebCore::MockRealtimeAudioSourceMac::applySampleRate): Ditto.

  • platform/mock/MockRealtimeAudioSource.cpp:

(WebCore::MockRealtimeAudioSource::updateSettings): Don't assume sampleRate is 44.1K
(WebCore::MockRealtimeAudioSource::initializeCapabilities): Support a range of sample rates.
(WebCore::MockRealtimeAudioSource::startProducingData): Initialize sampleRate if it hasn't
already been set.

  • platform/mock/MockRealtimeMediaSource.cpp:

(WebCore::MockRealtimeMediaSource::audioDevices): Return an array of devices.
(WebCore::MockRealtimeMediaSource::videoDevices): Ditto.
(WebCore::MockRealtimeMediaSource::MockRealtimeMediaSource):
(WebCore::MockRealtimeMediaSource::mockAudioSourcePersistentID): Deleted.
(WebCore::MockRealtimeMediaSource::mockVideoSourcePersistentID): Deleted.
(WebCore::MockRealtimeMediaSource::mockAudioSourceName): Deleted.
(WebCore::MockRealtimeMediaSource::mockVideoSourceName): Deleted.
(WebCore::MockRealtimeMediaSource::audioDeviceInfo): Deleted.
(WebCore::MockRealtimeMediaSource::videoDeviceInfo): Deleted.

  • platform/mock/MockRealtimeMediaSource.h:
  • platform/mock/MockRealtimeMediaSourceCenter.cpp:

(WebCore::MockRealtimeMediaSourceCenter::validateRequestConstraints):
(WebCore::MockRealtimeMediaSourceCenter::createMediaStream):
(WebCore::MockRealtimeMediaSourceCenter::getMediaStreamDevices):

  • platform/mock/MockRealtimeVideoSource.cpp:

(WebCore::MockRealtimeVideoSource::MockRealtimeVideoSource):

LayoutTests:

  • fast/mediastream/MediaDevices-enumerateDevices-expected.txt:
  • fast/mediastream/MediaDevices-getUserMedia-expected.txt:
  • fast/mediastream/MediaDevices-getUserMedia.html:
  • fast/mediastream/MediaStream-video-element-expected.txt:
  • fast/mediastream/MediaStreamTrack-getCapabilities-expected.txt:
10:51 AM Changeset in webkit [214177] by mitz@apple.com
  • 5 edits in trunk/Source/WebKit

[Xcode] Incremental builds of WebKitLegacy are slow because of the Postprocess Headers phase
​https://bugs.webkit.org/show_bug.cgi?id=169861

Reviewed by Sam Weinig.

Source/WebKit:

  • WebKit.xcodeproj/project.pbxproj: Specified that the Postprocess Headers script build phase has the Headers and PrivateHeaders directories as its inputs and a timestamp file as its output.

Source/WebKit/mac:

  • MigrateHeaders.make: Touch the PrivateHeaders directory when migrating a header into it.
  • postprocess-headers.sh: Preserve the timestamp on the headers directories. Write out the timestamp file used by the Xcode project to determine whether to run the script.
10:49 AM Changeset in webkit [214176] by jmarcell@apple.com
  • 7 edits in trunk/Source

Versioning.

10:47 AM Changeset in webkit [214175] by jmarcell@apple.com
  • 1 copy in tags/Safari-604.1.13

Tag Safari-604.1.13.

10:32 AM Changeset in webkit [214174] by Wenson Hsieh
  • 7 edits in trunk/Source

TextIndicator should support a mode where selection rects are used to size the snapshot
​https://bugs.webkit.org/show_bug.cgi?id=169845
<rdar://problem/31127818>

Reviewed by Beth Dakin.

Source/WebCore:

Adds TextIndicator support in iOS for using the would-be selection rects of a given range to determine
snapshotting bounds. See below changes for more details.

  • dom/Range.cpp:

(WebCore::Range::collectSelectionRectsWithoutUnionInteriorLines):
(WebCore::Range::collectSelectionRects):

Mark these helper methods as const.

  • dom/Range.h:
  • page/TextIndicator.cpp:

(WebCore::getSelectionRectsForRange):
(WebCore::initializeIndicator):

If TextIndicatorOptionUseSelectionRectForSizing is enabled, then compute selection rects and set the text rects
to be the resulting selection rects. These are in document coordinates.

  • page/TextIndicator.h:

Source/WebKit2:

Adopt the new TextIndicatorOptionUseSelectionRectForSizing flag when generating an edit data interaction snapshot.

  • WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::didConcludeEditDataInteraction):

10:28 AM Changeset in webkit [214173] by Simon Fraser
  • 42 edits in trunk/Source/WebCore

Move code out of renderer destructors into willBeDestroyed()
​https://bugs.webkit.org/show_bug.cgi?id=169650

Reviewed by Antti Koivisto.

This is done for four reasons. First, code in willBeDestroyed() is able to call
virtual functions on derived classes. Second, this code will run before we've destroyed
the renderer's rareData, so can safely access it. Third, RenderWidget is special, and can have
its lifetime extended via manual ref-counting, and we want all cleanup to complete
before it goes into this weird zombie state. Fourth, in a shiny future where we have
ref-counted RenderObjects, we want cleanup code to be run explicitly and not tied
to object lifetime, and this is a step in that direction.

For all classes that derive from RenderObject, move code from the destructor into
willBeDestroyed(). New willBeDestroyed() implementations must call the base class.

RenderBlock and RenderBlockFlow are special; RenderBlockFlow::willBeDestroyed()
skips over RenderBlock::willBeDestroyed(), but they both need to run some code, which
I moved into RenderBlock::blockWillBeDestroyed().

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::~RenderBlock):
(WebCore::RenderBlock::willBeDestroyed):
(WebCore::RenderBlock::blockWillBeDestroyed):

  • rendering/RenderBlock.h:
  • rendering/RenderBlockFlow.cpp:

(WebCore::RenderBlockFlow::~RenderBlockFlow):
(WebCore::RenderBlockFlow::willBeDestroyed):

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::~RenderBox):
(WebCore::RenderBox::willBeDestroyed):

  • rendering/RenderBox.h:
  • rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::~RenderBoxModelObject):

  • rendering/RenderCounter.cpp:

(WebCore::RenderCounter::~RenderCounter):
(WebCore::RenderCounter::willBeDestroyed):

  • rendering/RenderCounter.h:
  • rendering/RenderElement.cpp:

(WebCore::RenderElement::~RenderElement):
(WebCore::RenderElement::willBeDestroyed):

  • rendering/RenderEmbeddedObject.cpp:

(WebCore::RenderEmbeddedObject::~RenderEmbeddedObject):
(WebCore::RenderEmbeddedObject::willBeDestroyed):

  • rendering/RenderEmbeddedObject.h:
  • rendering/RenderImage.cpp:

(WebCore::RenderImage::~RenderImage):
(WebCore::RenderImage::willBeDestroyed):

  • rendering/RenderImage.h:
  • rendering/RenderLayerModelObject.cpp:

(WebCore::RenderLayerModelObject::~RenderLayerModelObject):
(WebCore::RenderLayerModelObject::willBeDestroyed):

  • rendering/RenderLayerModelObject.h:
  • rendering/RenderLineBreak.cpp:

(WebCore::RenderLineBreak::~RenderLineBreak):
(WebCore::RenderLineBreak::willBeDestroyed):

  • rendering/RenderLineBreak.h:
  • rendering/RenderListBox.cpp:

(WebCore::RenderListBox::~RenderListBox):
(WebCore::RenderListBox::willBeDestroyed):

  • rendering/RenderListBox.h:
  • rendering/RenderListItem.cpp:

(WebCore::RenderListItem::~RenderListItem):
(WebCore::RenderListItem::willBeDestroyed):

  • rendering/RenderListItem.h:
  • rendering/RenderListMarker.cpp:

(WebCore::RenderListMarker::~RenderListMarker):
(WebCore::RenderListMarker::willBeDestroyed):

  • rendering/RenderListMarker.h:
  • rendering/RenderMenuList.cpp:

(WebCore::RenderMenuList::~RenderMenuList):
(WebCore::RenderMenuList::willBeDestroyed):

  • rendering/RenderMenuList.h:
  • rendering/RenderNamedFlowThread.cpp:

(WebCore::RenderNamedFlowThread::~RenderNamedFlowThread):
(WebCore::RenderNamedFlowThread::willBeDestroyed):

  • rendering/RenderNamedFlowThread.h:
  • rendering/RenderObject.cpp:

(WebCore::RenderObject::willBeDestroyed):

  • rendering/RenderQuote.cpp:

(WebCore::RenderQuote::~RenderQuote):
(WebCore::RenderQuote::willBeDestroyed):

  • rendering/RenderQuote.h:
  • rendering/RenderSearchField.cpp:

(WebCore::RenderSearchField::~RenderSearchField):
(WebCore::RenderSearchField::willBeDestroyed):

  • rendering/RenderSearchField.h:
  • rendering/RenderSnapshottedPlugIn.cpp:

(WebCore::RenderSnapshottedPlugIn::~RenderSnapshottedPlugIn):
(WebCore::RenderSnapshottedPlugIn::willBeDestroyed):

  • rendering/RenderSnapshottedPlugIn.h:
  • rendering/RenderText.cpp:

(WebCore::RenderText::~RenderText):
(WebCore::RenderText::willBeDestroyed):

  • rendering/RenderTextControlMultiLine.cpp:

(WebCore::RenderTextControlMultiLine::~RenderTextControlMultiLine):
(WebCore::RenderTextControlMultiLine::willBeDestroyed):

  • rendering/RenderTextControlMultiLine.h:
  • rendering/RenderVideo.cpp:

(WebCore::RenderVideo::~RenderVideo):
(WebCore::RenderVideo::willBeDestroyed):

  • rendering/RenderVideo.h:
  • rendering/RenderWidget.h:
  • rendering/svg/RenderSVGImage.cpp:

(WebCore::RenderSVGImage::~RenderSVGImage):
(WebCore::RenderSVGImage::willBeDestroyed):

  • rendering/svg/RenderSVGImage.h:
  • rendering/svg/RenderSVGResourceContainer.cpp:

(WebCore::RenderSVGResourceContainer::~RenderSVGResourceContainer):
(WebCore::RenderSVGResourceContainer::willBeDestroyed):

10:11 AM Changeset in webkit [214172] by Jonathan Bedard
  • 2 edits in trunk/Tools

buildbot: run-webkit-tests should display test failures and run exceptions differently
​https://bugs.webkit.org/show_bug.cgi?id=169793
<rdar://problem/30987863>

Reviewed by Alexey Proskuryakov.

  • BuildSlaveSupport/build.webkit.org-config/master.cfg:

(RunWebKitTests.evaluateCommand): Return EXCEPTION when run-webkit-tests returns with a code of 254.

9:46 AM Changeset in webkit [214171] by Ryan Haddad
  • 2 edits in trunk/LayoutTests

Mark imported/w3c/web-platform-tests/XMLHttpRequest/timeout-multiple-fetches.html as flaky.
​https://bugs.webkit.org/show_bug.cgi?id=169637

Unreviewed test gardening.

  • platform/mac/TestExpectations:
8:40 AM Changeset in webkit [214170] by jonlee@apple.com
  • 12 edits in trunk/Source/WebCore

Mark differences in media stream implementation
​https://bugs.webkit.org/show_bug.cgi?id=169873

Reviewed by Eric Carlson.

Rearrange IDL and add comments based on 05 February 2017 Editor's Draft of Media
Capture and Streams spec.

  • Modules/mediastream/DOMURLMediaStream.idl:
  • Modules/mediastream/MediaDeviceInfo.idl:
  • Modules/mediastream/MediaDevices.idl:
  • Modules/mediastream/MediaStream.idl:
  • Modules/mediastream/MediaStreamEvent.idl:
  • Modules/mediastream/MediaStreamTrack.idl:
  • Modules/mediastream/MediaStreamTrackEvent.idl:
  • Modules/mediastream/MediaTrackConstraints.idl:
  • Modules/mediastream/MediaTrackSupportedConstraints.idl:
  • Modules/mediastream/NavigatorMediaDevices.idl:
  • Modules/mediastream/NavigatorUserMedia.idl:
5:02 AM Changeset in webkit [214169] by pvollan@apple.com
  • 8 edits in trunk/Source/WebCore

Use CopyFontDescriptorWithStrokeForStyle to get correct stroke width for captions.
​https://bugs.webkit.org/show_bug.cgi?id=169674

Reviewed by Eric Carlson.

Use the MediaAccessibility function MACopyFontDescriptorWithStrokeForStyle to get
correct video captions stroke width from a given font size.

  • html/shadow/MediaControlElements.cpp:

(WebCore::MediaControlTextTrackContainerElement::updateTextStrokeStyle):
(WebCore::MediaControlTextTrackContainerElement::updateTimerFired):

  • html/shadow/MediaControlElements.h:
  • page/CaptionUserPreferences.h:

(WebCore::CaptionUserPreferences::captionStrokeWidth):

  • page/CaptionUserPreferencesMediaAF.cpp:

(WebCore::CaptionUserPreferencesMediaAF::captionStrokeWidth):
(WebCore::CaptionUserPreferencesMediaAF::captionsTextEdgeCSS):
(WebCore::CaptionUserPreferencesMediaAF::strokeWidth): Deleted.

  • page/CaptionUserPreferencesMediaAF.h:
  • platform/cf/MediaAccessibilitySoftLink.cpp:
  • platform/cf/MediaAccessibilitySoftLink.h:
3:01 AM Changeset in webkit [214168] by Carlos Garcia Campos
  • 1 copy in releases/WebKitGTK/webkit-2.16.0

WebKitGTK+ 2.16.0

3:01 AM Changeset in webkit [214167] by Carlos Garcia Campos
  • 4 edits in releases/WebKitGTK/webkit-2.16

Unreviewed. Update OptionsGTK.cmake and NEWS for 2.16.0 release.

.:

  • Source/cmake/OptionsGTK.cmake: Bump version numbers.

Source/WebKit2:

  • gtk/NEWS: Add release notes for 2.16.0.
2:19 AM WebKitGTK/2.16.x edited by Carlos Garcia Campos
(diff)
2:18 AM Changeset in webkit [214166] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.16/Source/WebCore/platform/gtk/po

Update Ukrainian translation
​https://bugs.webkit.org/show_bug.cgi?id=169812

Patch by Yuri Chornoivan <​yurchor@ukr.net> on 2017-03-18
Rubber-stamped by Michael Catanzaro.

  • uk.po:
2:18 AM Changeset in webkit [214165] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.16/Source/WebCore/platform/gtk/po

Merge r213855 - Updated Swedish translation
​https://bugs.webkit.org/show_bug.cgi?id=169549

Patch by Josef Andersson <​l10nl18nsweja@gmail.com> on 2017-03-13
Rubber-stamped by Michael Catanzaro.

  • sv.po:
2:18 AM Changeset in webkit [214164] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.16/Source/WebKit2

Merge r214163 - Unreviewed. Add missing types to WebKitAutocleanups.

  • UIProcess/API/gtk/WebKitAutocleanups.h:
2:15 AM Changeset in webkit [214163] by Carlos Garcia Campos
  • 2 edits in trunk/Source/WebKit2

Unreviewed. Add missing types to WebKitAutocleanups.

  • UIProcess/API/gtk/WebKitAutocleanups.h:
1:47 AM Changeset in webkit [214162] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

[Cairo] Ensure depth and stencil renderbuffers are created on GLESv2
​https://bugs.webkit.org/show_bug.cgi?id=166643

Patch by Emanuele Aina <Emanuele Aina> on 2017-03-20
Reviewed by Darin Adler.

If the gfx device doesn't support GL_OES_packed_depth_stencil, the
separate depth and stencil buffers are not generated.

Copy what GraphicsContext3DEfl used to do and apply it in
GraphicsContext3DCairo.

The Intel gfx driver seem to tolerate unbound renderbuffers, but
enabling debugging in Mesa yields an error:

$ MESA_DEBUG=1 \

MESA_EXTENSION_OVERRIDE=-GL_OES_packed_depth_stencil
./bin/MiniBrowser ​http://webglsamples.org/aquarium/aquarium.html

Mesa: User error: GL_INVALID_OPERATION in glRenderbufferStorage(no renderbuffer bound)

  • platform/graphics/GraphicsContext3D.h:
  • platform/graphics/cairo/GraphicsContext3DCairo.cpp:

(WebCore::GraphicsContext3D::GraphicsContext3D):
Ensure separate depth and stencil renderbuffers are created.
(WebCore::GraphicsContext3D::~GraphicsContext3D):
Ensure separate depth and stencil renderbuffers are released.

Note: See TracTimeline for information about the timeline view.