⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Mar 24, 2017:

11:50 PM Changeset in webkit [214394] by mmaxfield@apple.com
  • 9 edits
    3 copies
    1 add in trunk

Add font-optical-sizing to CSSComputedStyleDeclaration
​https://bugs.webkit.org/show_bug.cgi?id=170083

Reviewed by Joseph Pecoraro.

Source/WebCore:

Covered by existing tests.

  • css/CSSComputedStyleDeclaration.cpp:

LayoutTests:

  • fast/css/getComputedStyle/computed-style-expected.txt:
  • fast/css/getComputedStyle/computed-style-font-family-expected.txt:
  • fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • fast/css/getComputedStyle/resources/property-names.js:
  • fast/text/variations/optical-sizing-expected.txt:
  • fast/text/variations/optical-sizing.html:
  • platform/mac-elcapitan/fast/css/getComputedStyle/computed-style-expected.txt: Added.
  • platform/mac-elcapitan/fast/css/getComputedStyle/computed-style-font-family-expected.txt: Added.
  • platform/mac-elcapitan/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: Added.
10:34 PM Changeset in webkit [214393] by mark.lam@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Add some instrumentation in Heap::resumeThePeriphery() to help debug an issue.
​https://bugs.webkit.org/show_bug.cgi?id=170086
<rdar://problem/31253673>

Reviewed by Saam Barati.

Adding some instrumentation in Heap::resumeThePeriphery() to dump some Heap state
just before we RELEASE_ASSERT_NOT_REACHED.

  • heap/Heap.cpp:

(JSC::Heap::resumeThePeriphery):

6:13 PM Changeset in webkit [214392] by dbates@webkit.org
  • 6 edits in trunk/Source/WebCore

media/restore-from-page-cache.html causes NoEventDispatchAssertion::isEventAllowedInMainThread() assertion failure
​https://bugs.webkit.org/show_bug.cgi?id=170087
<rdar://problem/31254822>

Reviewed by Simon Fraser.

Reduce the scope of code that should never dispatch DOM events so as to allow updating contents size
after restoring a page from the page cache.

In r214014 we instantiate a NoEventDispatchAssertion in FrameLoader::commitProvisionalLoad()
around the call to CachedPage::restore() to assert when a DOM event is dispatched during
page restoration as such events can cause re-entrancy into the page cache. As it turns out
it is sufficient to ensure that no DOM events are dispatched after restoring all cached frames
as opposed to after CachedPage::restore() returns.

Also rename Document::enqueue{Pageshow, Popstate}Event() to dispatch{Pageshow, Popstate}Event(),
respectively, since they synchronously dispatch events :(. We hope in the future to make them
asynchronously dispatch events.

  • dom/Document.cpp:

(WebCore::Document::implicitClose): Update for renaming.
(WebCore::Document::statePopped): Ditto.
(WebCore::Document::dispatchPageshowEvent): Renamed; formerly named enqueuePageshowEvent().
(WebCore::Document::dispatchPopstateEvent): Renamed; formerly named enqueuePopstateEvent().
(WebCore::Document::enqueuePageshowEvent): Deleted.
(WebCore::Document::enqueuePopstateEvent): Deleted.

  • dom/Document.h:
  • history/CachedPage.cpp:

(WebCore::firePageShowAndPopStateEvents): Moved logic from FrameLoader::didRestoreFromCachedPage() to here.
(WebCore::CachedPage::restore): Modified to call firePageShowAndPopStateEvents().

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::commitProvisionalLoad): Removed use of NoEventDispatchAssertion RAII object. We
will instantiate it in CachedPage::restore() with a smaller scope.
(WebCore::FrameLoader::didRestoreFromCachedPage): Deleted; moved logic from here to WebCore::firePageShowAndPopStateEvents().

  • loader/FrameLoader.h:
6:04 PM Changeset in webkit [214391] by Simon Fraser
  • 2 edits in trunk/Source/WebKit2

[iOS WK2] Move from a pre-commit handler to dispatch_async for visible content rect updates
​https://bugs.webkit.org/show_bug.cgi?id=170091
rdar://problem/30682584

Reviewed by Tim Horton.

[CATransaction addCommitHandler:forPhase:] is sometimes not called when running inside another
commit callback (rdar://problem/31253952), and we don't yet have a reliable way to detect this.

So dispatch_async() to postpone the call to [CATransaction addCommitHandler:forPhase:] to a known-
good time.

  • UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _scheduleVisibleContentRectUpdateAfterScrollInView:]):

5:39 PM Changeset in webkit [214390] by Ryan Haddad
  • 2 edits in trunk/LayoutTests

Consolidate TestExpectations for media/restore-from-page-cache.html.

Unreviewed test gardening.

  • platform/mac/TestExpectations:
5:12 PM Changeset in webkit [214389] by wilander@apple.com
  • 2 edits in trunk/Source/WebKit2

Re-enable the network process' keychain access to fix client certificate authentication
​https://bugs.webkit.org/show_bug.cgi?id=170074
<rdar://problem/31095987>

Reviewed by Brent Fulgham.

  • NetworkProcess/mac/com.apple.WebKit.NetworkProcess.sb.in:

Reverted remaining change from
​https://trac.webkit.org/changeset/208702/webkit and
​https://trac.webkit.org/changeset/208707/webkit.

5:10 PM Changeset in webkit [214388] by Ryan Haddad
  • 15 edits
    2 deletes in trunk

Unreviewed, rolling out r214361.

This change caused flakiness in http/tests/preload tests.

Reverted changeset:

"Add a warning for unused link preloads."
​https://bugs.webkit.org/show_bug.cgi?id=165670
​http://trac.webkit.org/changeset/214361

4:43 PM Changeset in webkit [214387] by Nikita Vasilyev
  • 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Adding a WebSocket message may change the currently selected resource
​https://bugs.webkit.org/show_bug.cgi?id=170036
<rdar://problem/31231463>

Reviewed by Joseph Pecoraro.

Calling increaseSize on a resource may cause a WebInspector.TimelineDataGrid#TimelineDataGrid#_refreshDirtyDataGridNodes call.
Make sure _refreshDirtyDataGridNodes preserves selection of a treeElement.

  • UserInterface/Views/TimelineDataGrid.js:

(WebInspector.TimelineDataGrid.prototype._refreshDirtyDataGridNodes):
Re-attaching treeElement causes it to lose selection. Select it again after re-attaching.

4:32 PM Changeset in webkit [214386] by graouts@webkit.org
  • 9 edits
    2 moves
    2 adds in trunk

[Modern Media Controls] Remove placard icon if height is compressed
​https://bugs.webkit.org/show_bug.cgi?id=167935
<rdar://problem/30397128>

Reviewed by Dean Jackson.

Source/WebCore:

We make the addition of certain Placard children conditional on the placard's metrics. Whenever the
media controls metrics changes, the placard, if any, is set to have the same metrics and layout() is
called where we ensure that there is enough space, per designs, to have the icon, description and even
the title visible. We also make some CSS improvements to guarantee that the description is laid out on
two lines at most and that both text labels are trimmed elegantly with an ellipsis shold the width be
insufficient to display the whole text.

Since we would have needed to have more width/height setter overrides to trigger layout, we now make
LayoutNode trigger layout() directly and remove the need for subclasses to do this on a per-class basis.
We also make layout() a method that can be called safely anytime as it's now no longer part of the DOM
commit step, a new commit() method is used instead of that.

Tests: media/modern-media-controls/layout-node/node-made-dirty-during-commit.html

media/modern-media-controls/media-controls/media-controls-placard-compressed-metrics.html

  • Modules/modern-media-controls/controls/layout-node.js:

(LayoutNode.prototype.set width):
(LayoutNode.prototype.set height):
Trigger a call to layout() anytime "width" or "height" is set on any LayoutNode.

(LayoutNode.prototype.layout):
(LayoutNode.prototype.commit):
(performScheduledLayout):
Make layout() an empty method that subclasses can override easily outside of the DOM commit cycle,
its previous implementation is now called "commit()" which is a more accurate name.

  • Modules/modern-media-controls/controls/media-controls.js:

(MediaControls.prototype.get placard):
(MediaControls.prototype.get showsPlacard):
(MediaControls.prototype.showPlacard):
(MediaControls.prototype.hidePlacard):
(MediaControls.prototype.layout):
(MediaControls.prototype.get width): Deleted.
(MediaControls.prototype.set width): Deleted.
Add a "placard" property to make it simpler to reference the placard instead of making assumptions in
several places in that class on the children order. Anytime we run a layout or show the placard, ensure
that the placard metrics are synced with the media controls metrics.

  • Modules/modern-media-controls/controls/placard.css:

(.placard .container):
(.placard .title,):
(.placard .description):
We now ensure that both the title and description are trimmed with an ellipsis when we run out of space
to display them fully.

  • Modules/modern-media-controls/controls/placard.js:

(Placard.):
(Placard.prototype.layout):
We add new constraints to only show the icon, title and description if the placard is tall and wide enough.

  • Modules/modern-media-controls/controls/slider.js:

(Slider.prototype.get width): Deleted.
(Slider.prototype.set width): Deleted.
Removed custom "width" getters and setters now we can just override layout() in case node metrics change.

  • Modules/modern-media-controls/controls/time-control.js:

(TimeControl.prototype.set useSixDigitsForTimeLabels):
(TimeControl.prototype.layout):
(TimeControl.prototype.get width): Deleted.
(TimeControl.prototype.set width): Deleted.
(TimeControl.prototype._availableWidthHasChanged): Deleted.
Removed custom "width" getters and setters now we can just override layout() in case node metrics change.

  • Modules/modern-media-controls/media/media-controller.js:

(MediaController):
Ensure we flush pending updates at construction time so that we match the size of the media controls right
at the first media layout.

LayoutTests:

We add a new test to check that the various designed constraints to toggle display of a placard's
icon, title and description are honored. Also, due to the old layout() method now being called
"commit()", we refactor a relevant test.

  • media/modern-media-controls/layout-node/node-made-dirty-during-commit-expected.txt: Added.
  • media/modern-media-controls/layout-node/node-made-dirty-during-commit.html: Added.
  • media/modern-media-controls/media-controls/media-controls-placard-compressed-metrics-expected.txt: Added.
  • media/modern-media-controls/media-controls/media-controls-placard-compressed-metrics.html: Added.
4:27 PM Changeset in webkit [214385] by eric.carlson@apple.com
  • 16 edits in trunk

[MediaStream] "ideal" constraints passed to getUserMedia should affect fitness score
​https://bugs.webkit.org/show_bug.cgi?id=170056

Reviewed by Youenn Fablet.

Source/WebCore:

Include the fitness score calculated for ideal constraints in the calculation of a capture
overall device fitness score.

No new tests, existing tests updated.

  • platform/mediastream/MediaConstraints.cpp:

(WebCore::StringConstraint::fitnessDistance): Drive-by fix: return early if ideal is empty,
not exact.

  • platform/mediastream/RealtimeMediaSource.cpp:

(WebCore::RealtimeMediaSource::supportsSizeAndFrameRate): Return fitness distance.
(WebCore::RealtimeMediaSource::selectSettings): Include the fitness distance of supported
ideal constraints.
(WebCore::RealtimeMediaSource::supportsConstraint): New.
(WebCore::RealtimeMediaSource::applyConstraints):

  • platform/mediastream/RealtimeMediaSource.h:
  • platform/mock/MockRealtimeMediaSourceCenter.cpp:

(WebCore::MockRealtimeMediaSourceCenter::validateRequestConstraints): Sort candidate sources
by their fitness score.

  • platform/mock/MockRealtimeVideoSource.cpp:

(WebCore::MockRealtimeVideoSource::initializeCapabilities): Each video source should support
one facing mode, not both.

Source/WebKit2:

  • UIProcess/UserMediaPermissionRequestManagerProxy.cpp:

(WebKit::UserMediaPermissionRequestManagerProxy::requestUserMediaPermissionForFrame): When
short-circuiting the user prompt because the page is already authorized, return the first
audio and/or video device because so the page gets the one with the best fitness distance.

LayoutTests:

  • fast/mediastream/MediaStream-video-element-displays-buffer-expected.txt:
  • fast/mediastream/MediaStream-video-element-displays-buffer.html:
  • fast/mediastream/MediaStreamTrack-getCapabilities-expected.txt:
  • fast/mediastream/apply-constraints-advanced-expected.txt:
  • fast/mediastream/apply-constraints-advanced.html:
  • fast/mediastream/apply-constraints-video-expected.txt:
  • fast/mediastream/apply-constraints-video.html:
4:25 PM Changeset in webkit [214384] by jfbastien@apple.com
  • 22 edits
    3 copies in trunk/Source

WebAssembly: store state in TLS instead of on VM
​https://bugs.webkit.org/show_bug.cgi?id=169611

Reviewed by Filip Pizlo.

Source/JavaScriptCore:

Using thread-local storage instead of VM makes code more position
independent. We used to store the WebAssembly top Instance (the
latest one in the call stack) on VM, now we instead store it in
TLS. This top Instance is used to access a bunch of state such as
Memory location, size, table (for call_indirect), etc.

Instead of calling it "top", which is confusing, we now just call
it WasmContext.

Making the code PIC means future patches will be able to
postMessage and structured clone into IDB without having to
recompile the code. This wasn't possible before because we
hard-coded the address of VM at compilation time. That doesn't
work between workers, and doesn't work across reloads (which IDB
is intended to do).

It'll also potentially make code faster once we start tuning
what's in TLS, what's in which of the 4 free slots, and what's in
pinned registers. I'm leaving this tuning for later because
there's lower lying fruit for us to pick.

  • CMakeLists.txt:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • assembler/AbstractMacroAssembler.h:
  • assembler/AllowMacroScratchRegisterUsageIf.h: Copied from assembler/AllowMacroScratchRegisterUsage.h.

(JSC::AllowMacroScratchRegisterUsageIf::AllowMacroScratchRegisterUsageIf):
(JSC::AllowMacroScratchRegisterUsageIf::~AllowMacroScratchRegisterUsageIf):

  • assembler/MacroAssembler.h:

(JSC::MacroAssembler::storeToTLSPtr): we previously didn't have
the code required to store to TLS, only to load

  • assembler/MacroAssemblerARM64.h:

(JSC::MacroAssemblerARM64::loadFromTLSPtrNeedsMacroScratchRegister):
(JSC::MacroAssemblerARM64::storeToTLS32):
(JSC::MacroAssemblerARM64::storeToTLS64):
(JSC::MacroAssemblerARM64::storeToTLSPtrNeedsMacroScratchRegister):

  • assembler/MacroAssemblerX86Common.h:

(JSC::MacroAssemblerX86Common::loadFromTLSPtrNeedsMacroScratchRegister):
(JSC::MacroAssemblerX86Common::storeToTLS32):
(JSC::MacroAssemblerX86Common::storeToTLSPtrNeedsMacroScratchRegister):

  • assembler/MacroAssemblerX86_64.h:

(JSC::MacroAssemblerX86_64::loadFromTLS64): was loading 32-bit instead of 64-bit
(JSC::MacroAssemblerX86_64::storeToTLS64):

  • assembler/X86Assembler.h:

(JSC::X86Assembler::movl_rm):
(JSC::X86Assembler::movq_rm):

  • b3/testb3.cpp:

(JSC::B3::testFastTLSLoad):
(JSC::B3::testFastTLSStore):
(JSC::B3::run):

  • jit/AssemblyHelpers.h:

(JSC::AssemblyHelpers::loadWasmContext):
(JSC::AssemblyHelpers::storeWasmContext):
(JSC::AssemblyHelpers::loadWasmContextNeedsMacroScratchRegister):
(JSC::AssemblyHelpers::storeWasmContextNeedsMacroScratchRegister):

  • jit/Repatch.cpp:

(JSC::webAssemblyOwner):

  • jit/ThunkGenerators.cpp:

(JSC::throwExceptionFromWasmThunkGenerator):

  • runtime/Options.h:
  • runtime/VM.cpp:

(JSC::VM::VM):

  • runtime/VM.h:
  • wasm/WasmB3IRGenerator.cpp:

(JSC::Wasm::loadWasmContext):
(JSC::Wasm::storeWasmContext):
(JSC::Wasm::B3IRGenerator::B3IRGenerator):
(JSC::Wasm::getMemoryBaseAndSize):
(JSC::Wasm::restoreWebAssemblyGlobalState):
(JSC::Wasm::createJSToWasmWrapper):
(JSC::Wasm::parseAndCompile):

  • wasm/WasmBinding.cpp:

(JSC::Wasm::materializeImportJSCell):
(JSC::Wasm::wasmToJs):
(JSC::Wasm::wasmToWasm):

  • wasm/WasmContext.cpp: Added.

(JSC::loadWasmContext):
(JSC::storeWasmContext):

  • wasm/WasmContext.h: Added. Replaces "top" JSWebAssemblyInstance.
  • wasm/js/WebAssemblyFunction.cpp:

(JSC::callWebAssemblyFunction):

  • wasm/js/WebAssemblyInstanceConstructor.h:

Source/WTF:

  • wtf/FastTLS.h: reserve one key for WebAssembly, delete a bunch

of dead code which clang couldn't compile (it's valid GCC assembly
which LLVM dislikes).

4:16 PM Changeset in webkit [214383] by dino@apple.com
  • 5 edits in trunk

Serialization of custom props in longhand should be "" not value of shorthand
​https://bugs.webkit.org/show_bug.cgi?id=167699
<rdar://problem/30324200>

Reviewed by Sam Weinig.

Source/WebCore:

​https://www.w3.org/TR/css-variables/#variables-in-shorthands says
"Pending-substitution values must be serialized as the empty string, if
an API allows them to be observed."

We were returning the cssText instead.

Test: fast/css/variables/rule-property-get.html has been updated.

  • css/StyleProperties.cpp:

(WebCore::StyleProperties::getPropertyValue): Return the empty string
if we're a pending substitution value.

LayoutTests:

  • fast/css/variables/rule-property-get-expected.html:
  • fast/css/variables/rule-property-get.html:
4:09 PM Changeset in webkit [214382] by Wenson Hsieh
  • 2 edits in trunk/Source/WebCore

Unreviewed, fix the ToT build on the latest SDK.

Add deprecated declaration guards around two synchronous UIItemProvider methods in WebItemProviderPasteboard.
<rdar://problem/30451096> tracks adoption of the asynchronous versions of these methods.

  • platform/ios/WebItemProviderPasteboard.mm:

(-[WebItemProviderPasteboard dataForPasteboardType:inItemSet:]):
(-[WebItemProviderPasteboard _tryToCreateAndAppendObjectOfClass:toArray:usingProvider:]):

3:10 PM Changeset in webkit [214381] by graouts@webkit.org
  • 11 edits
    2 adds in trunk

[Modern Media Controls] Captions don't move with the appearance of the inline controls
​https://bugs.webkit.org/show_bug.cgi?id=170051
<rdar://problem/30754428>

Reviewed by Dean Jackson.

Source/WebCore:

We now size the captions container to account for the controls bar height when visible. To do this,
we use CSS variables to specify the height of the controls bar in default inline mode, compact inline
mode and fullscreen mode.

Test: media/modern-media-controls/tracks-support/tracks-support-captions-offset-with-controls-bar.html

  • Modules/modern-media-controls/controls/controls-bar.js:

(ControlsBar.prototype.set faded):
Notify the hosting MediaControls that the "faded" property changed.

  • Modules/modern-media-controls/controls/ios-inline-media-controls.css:

(.media-controls.ios.inline > .controls-bar):
Use the new --inline-controls-bar-height CSS variable to specify the inline bar height.

  • Modules/modern-media-controls/controls/macos-compact-inline-media-controls.css:

(.media-controls.mac.inline.compact > .controls-bar):
Use the new --inline-compact-controls-bar-height CSS variable to specify the inline bar height.

  • Modules/modern-media-controls/controls/macos-fullscreen-media-controls.css:

(.media-controls.mac.fullscreen > .controls-bar):
Use the new --fullscreen-controls-bar-height CSS variable to specify the inline bar height.

  • Modules/modern-media-controls/controls/macos-inline-media-controls.css:

(.media-controls.mac.inline > .controls-bar):
Use the new --inline-controls-bar-height CSS variable to specify the inline bar height.

  • Modules/modern-media-controls/controls/media-controls.css:

(*):
Specify new CSS variables for the various controls bar heights.

  • Modules/modern-media-controls/controls/media-controls.js:

(MediaControls.prototype.controlsBarFadedStateDidChange):
Notify the delegate of a controls bar "faded" property change.

  • Modules/modern-media-controls/controls/text-tracks.css:

(video::-webkit-media-text-track-container):
(video::-webkit-media-text-track-container.visible-controls-bar):
(video::-webkit-media-text-track-container.visible-controls-bar.compact-controls-bar):
(video::-webkit-media-text-track-display):
Shorten the height of the captions container when the controls bar is visible. We also
fix a couple of prefixed properties that didn't need to be.

  • Modules/modern-media-controls/media/media-controller.js:

(MediaController.prototype.controlsBarFadedStateDidChange):
(MediaController.prototype._updateControlsIfNeeded):
(MediaController.prototype._updateTextTracksClassList):
(MediaController):
Ensure we reflect the "faded" state of the controls bar on the captions container using
a CSS class, as well as whether the controls bar mode is compact.

LayoutTests:

Add a new test, which would have previously failed, where we check that we account for the controls bar height
when showing captions with the controls bar visible.

  • media/modern-media-controls/tracks-support/tracks-support-captions-offset-with-controls-bar-expected.txt: Added.
  • media/modern-media-controls/tracks-support/tracks-support-captions-offset-with-controls-bar.html: Added.
3:09 PM Changeset in webkit [214380] by jfbastien@apple.com
  • 14 edits in trunk/Source/JavaScriptCore

WebAssembly: spec-tests/memory.wast.js fails in debug
​https://bugs.webkit.org/show_bug.cgi?id=169794

Reviewed by Keith Miller.

The failure was due to empty memories (with maximum size 0). Those
only occur in tests and in code that's trying to trip us. This
patch adds memory mode "none" which represents no memory. It can
work with either bounds checked or signaling code because it never
contains loads and stores.

The spec tests which were failing did the following:

(module (memory (data)) (func (export "memsize") (result i32) (current_memory)))
(assert_return (invoke "memsize") (i32.const 0))
(module (memory (data "")) (func (export "memsize") (result i32) (current_memory)))
(assert_return (invoke "memsize") (i32.const 0))
(module (memory (data "x")) (func (export "memsize") (result i32) (current_memory)))
(assert_return (invoke "memsize") (i32.const 1))

  • wasm/WasmB3IRGenerator.cpp:

(JSC::Wasm::B3IRGenerator::memoryKind):

  • wasm/WasmMemory.cpp:

(JSC::Wasm::tryGetFastMemory):
(JSC::Wasm::releaseFastMemory):
(JSC::Wasm::Memory::Memory):
(JSC::Wasm::Memory::createImpl):
(JSC::Wasm::Memory::create):
(JSC::Wasm::Memory::grow):
(JSC::Wasm::Memory::makeString):

  • wasm/WasmMemory.h:
  • wasm/WasmMemoryInformation.cpp:

(JSC::Wasm::MemoryInformation::MemoryInformation):

  • wasm/js/JSWebAssemblyCodeBlock.cpp:

(JSC::JSWebAssemblyCodeBlock::isSafeToRun):

  • wasm/js/JSWebAssemblyModule.cpp:

(JSC::JSWebAssemblyModule::codeBlock):
(JSC::JSWebAssemblyModule::finishCreation):

  • wasm/js/JSWebAssemblyModule.h:

(JSC::JSWebAssemblyModule::codeBlock):
(JSC::JSWebAssemblyModule::codeBlockFor):

2:57 PM Changeset in webkit [214379] by Simon Fraser
  • 4 edits in trunk/Source/WebKit2

Make UI-side compositing on macOS a bit more usable
​https://bugs.webkit.org/show_bug.cgi?id=170073

Reviewed by Tim Horton.

Mach port as layer contents doesn't work on macOS, so don't use it there.

Also remove two assertions that hit with UI-side compositing in MiniBrowser.

  • UIProcess/DrawingAreaProxy.cpp:

(WebKit::DrawingAreaProxy::createFence):

  • UIProcess/mac/PageClientImpl.mm:

(WebKit::PageClientImpl::requestScroll):

  • UIProcess/mac/RemoteLayerTreeHost.mm:

(WebKit::RemoteLayerTreeHost::updateLayerTree):

2:46 PM Changeset in webkit [214378] by Brent Fulgham
  • 9 edits
    11 copies in trunk

Handle recursive calls to ProcessingInstruction::checkStyleSheet
​https://bugs.webkit.org/show_bug.cgi?id=169982
<rdar://problem/31083051>

Reviewed by Antti Koivisto.

Source/WebCore:

See if we triggered a recursive load of the stylesheet during the 'beforeload'
event handler. If so, reset to a valid state before completing the load.

We should also check after 'beforeload' that we were not disconnected from (or
moved to a new) document.

I also looked for other cases of this pattern and fixed them, too.

Tests: fast/dom/beforeload/image-removed-during-before-load.html
fast/dom/beforeload/recursive-css-pi-before-load.html
fast/dom/beforeload/recursive-link-before-load.html
fast/dom/beforeload/recursive-xsl-pi-before-load.html

  • dom/ProcessingInstruction.cpp:

(WebCore::ProcessingInstruction::clearExistingCachedSheet): Added.
(WebCore::ProcessingInstruction::checkStyleSheet): Prevent recursive calls into
this function during 'beforeload' handling. Also, safely handle the case where
the element was disconnected in the 'beforeload' handler (similar to what
we do in HTMLLinkElement).
(WebCore::ProcessingInstruction::setCSSStyleSheet): Drive-by Fix: Protect the
current document to match what we do in setXSLStyleSheet.

  • dom/ProcessingInstruction.h:
  • html/HTMLLinkElement.cpp:

(WebCore::HTMLLinkElement::process): Prevent recursive calls into
this function during 'beforeload' handling.

  • html/HTMLLinkElement.h:
  • loader/ImageLoader.cpp:

(WebCore::ImageLoader::dispatchPendingBeforeLoadEvent): safely handle the case where
the element was disconnected in the 'beforeload' handler (similar to what
we do in HTMLLinkElement).

  • style/StyleScope.cpp:

(WebCore::Style::Scope::hasPendingSheet): Added.

  • style/StyleScope.h:

LayoutTests:

  • fast/dom/beforeload/image-removed-during-before-load-expected.txt: Copied from LayoutTests/fast/dom/beforeload/image-removed-during-before-load-expected.txt.
  • fast/dom/beforeload/image-removed-during-before-load.html: Copied from LayoutTests/fast/dom/beforeload/image-removed-during-before-load.html.
  • fast/dom/beforeload/recursive-css-pi-before-load-expected.txt: Copied from LayoutTests/fast/dom/beforeload/recursive-css-pi-before-load-expected.txt.
  • fast/dom/beforeload/recursive-css-pi-before-load.html: Copied from LayoutTests/fast/dom/beforeload/recursive-css-pi-before-load.html.
  • fast/dom/beforeload/recursive-link-before-load-expected.txt: Copied from LayoutTests/fast/dom/beforeload/recursive-link-before-load-expected.txt.
  • fast/dom/beforeload/recursive-link-before-load.html: Copied from LayoutTests/fast/dom/beforeload/recursive-link-before-load.html.
  • fast/dom/beforeload/recursive-xsl-pi-before-load-expected.txt: Copied from LayoutTests/fast/dom/beforeload/recursive-xsl-pi-before-load-expected.txt.
  • fast/dom/beforeload/recursive-xsl-pi-before-load.html: Copied from LayoutTests/fast/dom/beforeload/recursive-xsl-pi-before-load.html.
  • fast/dom/beforeload/resources/content.xhtml: Copied from LayoutTests/fast/dom/beforeload/resources/content.xhtml.
  • fast/dom/beforeload/resources/pass.css: Copied from LayoutTests/fast/dom/beforeload/resources/pass.css.
  • fast/dom/beforeload/resources/test.xsl: Copied from LayoutTests/fast/dom/beforeload/resources/test.xsl.
2:23 PM Changeset in webkit [214377] by commit-queue@webkit.org
  • 5 edits in trunk/Tools

webkitpy should be able to run API tests
​https://bugs.webkit.org/show_bug.cgi?id=170028

Patch by Srinivasan Vijayaraghavan <​svijayaraghavan@apple.com> on 2017-03-24
Reviewed by Alexey Proskuryakov.

  • Scripts/webkitpy/common/config/ports.py:

(DeprecatedPort.run_api_tests_command): Added.

  • Scripts/webkitpy/port/base.py:

(Port.api_results_directory): Added.

  • Scripts/webkitpy/tool/steps/runtests.py:

(RunTests.run): Check if we should be running API tests.
(RunTests._run_api_tests): Generate script to run API tests with json output.

  • Scripts/webkitpy/tool/steps/steps_unittest.py: Unit tests.
2:14 PM Changeset in webkit [214376] by achristensen@apple.com
  • 2 edits in trunk/Source/WebKit2

Fix assertions after r214358.
​https://bugs.webkit.org/show_bug.cgi?id=169167

  • UIProcess/API/APIContentExtensionStore.cpp:

(API::ContentExtensionStore::compileContentExtension):
AtomicString::init must be called for the first time from the main thread.
We were calling it for the first time from a non-main thread sometimes.
Call it from the main thread before initiating compiling on another thread.

2:13 PM Changeset in webkit [214375] by beidson@apple.com
  • 7 edits
    5 adds in trunk

A null compound index value crashes the Databases process.
<rdar://problem/30499831> and ​https://bugs.webkit.org/show_bug.cgi?id=170000

Reviewed by Alex Christensen.

Source/WebCore:

Test: storage/indexeddb/modern/single-entry-index-invalid-key-crash.html

  • bindings/js/IDBBindingUtilities.cpp:

(WebCore::createKeyPathArray): Fix the bug by rejecting arrays with any invalid keys in them.

Add some logging:

  • Modules/indexeddb/IDBKeyPath.cpp:

(WebCore::loggingString):

  • Modules/indexeddb/IDBKeyPath.h:
  • Modules/indexeddb/IDBObjectStore.cpp:

(WebCore::IDBObjectStore::createIndex):

  • Modules/indexeddb/shared/IDBIndexInfo.cpp:

(WebCore::IDBIndexInfo::loggingString):

LayoutTests:

  • storage/indexeddb/modern/resources/single-entry-index-invalid-key-crash.js: Added.
  • storage/indexeddb/modern/single-entry-index-invalid-key-crash-expected.txt: Added.
  • storage/indexeddb/modern/single-entry-index-invalid-key-crash-private-expected.txt: Added.
  • storage/indexeddb/modern/single-entry-index-invalid-key-crash-private.html: Added.
  • storage/indexeddb/modern/single-entry-index-invalid-key-crash.html: Added.
1:56 PM Changeset in webkit [214374] by mark.lam@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

Array memcpy'ing fast paths should check if we're having a bad time if they cannot handle it.
​https://bugs.webkit.org/show_bug.cgi?id=170064
<rdar://problem/31246098>

Reviewed by Geoffrey Garen.

  • runtime/ArrayPrototype.cpp:

(JSC::arrayProtoPrivateFuncConcatMemcpy):

  • runtime/JSArray.cpp:

(JSC::JSArray::fastSlice):

1:51 PM Changeset in webkit [214373] by Ryan Haddad
  • 2 edits in trunk/LayoutTests

Skip svg/animations/animations-paused-when-inserted-in-hidden-document* tests on ios-simulator.
​https://bugs.webkit.org/show_bug.cgi?id=170068

Unreviewed test gardening.

  • platform/ios-simulator/TestExpectations:
1:51 PM Changeset in webkit [214372] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

Add JSON results for API tests
​https://bugs.webkit.org/show_bug.cgi?id=170021

Patch by Srinivasan Vijayaraghavan <​svijayaraghavan@apple.com> on 2017-03-24
Reviewed by Alexey Proskuryakov.

  • Scripts/run-api-tests:

(runTestsBySuite): Appends failures and timeouts to JSON data.
(writeJsonDataIfApplicable): Writes JSON data to a file.

1:46 PM Changeset in webkit [214371] by webkit@devinrousso.com
  • 4 edits in trunk/Source/WebInspectorUI

Web Inspector: add context menu item to log content of WebSocket frame
​https://bugs.webkit.org/show_bug.cgi?id=169945

Reviewed by Joseph Pecoraro.

  • Localizations/en.lproj/localizedStrings.js:
  • UserInterface/Views/WebSocketContentView.js:

(WebInspector.WebSocketContentView):
(WebInspector.WebSocketContentView.prototype.addFrame):
(WebInspector.WebSocketContentView.prototype._addRow):
Rework the way CSS classes are applied so the isOutgoing and isText flags can also be passed
to the WebSocketDataGridNode. This is necessary because a non-text frame shouldn't be able
to be logged to the console.

  • UserInterface/Views/WebSocketDataGridNode.js:

(WebInspector.WebSocketDataGridNode.prototype.appendContextMenuItems):

1:45 PM Changeset in webkit [214370] by Ryan Haddad
  • 3 edits in trunk/Source/WTF

Unreviewed, rolling out r214351.

This change caused API test
WebKit1.DidCreateJavaScriptContextBackForwardCacheTest to
fail.

Reverted changeset:

"Make inactive web processes behave as though under memory
pressure."
​https://bugs.webkit.org/show_bug.cgi?id=170042
​http://trac.webkit.org/changeset/214351

1:39 PM Changeset in webkit [214369] by Ryan Haddad
  • 10 edits
    11 deletes in trunk

Unreviewed, rolling out r214360.

This change caused 20+ LayoutTest failures.

Reverted changeset:

"Handle recursive calls to
ProcessingInstruction::checkStyleSheet"
​https://bugs.webkit.org/show_bug.cgi?id=169982
​http://trac.webkit.org/changeset/214360

12:43 PM Changeset in webkit [214368] by commit-queue@webkit.org
  • 4 edits in trunk

Add support for qpSum in WebRTC stats
​https://bugs.webkit.org/show_bug.cgi?id=170060

Patch by Youenn Fablet <​youenn@apple.com> on 2017-03-24
Reviewed by Eric Carlson.

Source/WebCore:

  • Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp:

(WebCore::fillRTCRTPStreamStats): exposing libwebrtc qpSum value.

LayoutTests:

  • webrtc/video-stats.html:
12:41 PM Changeset in webkit [214367] by Lucas Forschler
  • 2 edits in trunk/Tools

update committer_auth.py to be python 2.7 compliant
​https://bugs.webkit.org/show_bug.cgi?id=170063

Reviewed by Alexey Proskuryakov.

  • BuildSlaveSupport/build.webkit.org-config/committer_auth.py:

(CommitterAuth.authenticate):

convert e.message to e.args[0]

12:36 PM Changeset in webkit [214366] by webkit@devinrousso.com
  • 2 edits in trunk/Source/WebInspectorUI

Web Inspector: allow users to click links in inline/user-agent styles
​https://bugs.webkit.org/show_bug.cgi?id=170054

Reviewed by Joseph Pecoraro.

  • UserInterface/Views/CSSStyleDeclarationTextEditor.js:

(WebInspector.CSSStyleDeclarationTextEditor.prototype.set style):
(WebInspector.CSSStyleDeclarationTextEditor.prototype._updateJumpToSymbolTrackingMode):
(WebInspector.CSSStyleDeclarationTextEditor.prototype.tokenTrackingControllerHighlightedRangeWasClicked):
(WebInspector.CSSStyleDeclarationTextEditor.prototype.tokenTrackingControllerNewHighlightCandidate):
Always enable the token tracking controller, but only act on hovered/clicked token if it is
a link or the owner style declaration has a source code location (for jumping to the Resource).

12:34 PM Changeset in webkit [214365] by dbates@webkit.org
  • 6 edits
    2 adds in trunk

Prevent new navigations during document unload
​https://bugs.webkit.org/show_bug.cgi?id=169934
<rdar://problem/31247584>

Reviewed by Chris Dumez.

Source/WebCore:

Similar to our policy of preventing new navigations from onbeforeunload handlers
we should prevent new navigations that are initiated during the document unload
process.

The significant part of this change is the instantiation of the RAII object NavigationDisabler
in Document::prepareForDestruction(). The rest of this change just renames class
NavigationDisablerForBeforeUnload to NavigationDisabler now that this RAII class is
used to prevent navigation from both onbeforeunload event handlers and when unloading
a document.

Test: fast/frames/frame-unload-navigate-and-setTimeout-assert-fail.html

  • dom/Document.cpp:

(WebCore::Document::prepareForDestruction): Disable new navigations when disconnecting
subframes. Also assert that the document is not in the page cache before we fall off
the end of the function.

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::isNavigationAllowed): Update for renaming below.
(WebCore::FrameLoader::shouldClose): Ditto.

  • loader/NavigationScheduler.cpp:

(WebCore::NavigationScheduler::shouldScheduleNavigation): Ditto.

  • loader/NavigationScheduler.h:

(WebCore::NavigationDisabler::NavigationDisabler): Renamed class; formerly named NavigationDisablerForBeforeUnload.
(WebCore::NavigationDisabler::~NavigationDisabler): Ditto.
(WebCore::NavigationDisabler::isNavigationAllowed): Ditto.
(WebCore::NavigationDisablerForBeforeUnload::NavigationDisablerForBeforeUnload): Deleted.
(WebCore::NavigationDisablerForBeforeUnload::~NavigationDisablerForBeforeUnload): Deleted.
(WebCore::NavigationDisablerForBeforeUnload::isNavigationAllowed): Deleted.

LayoutTests:

Add a test to ensure that we do not cause an assertion fail when calling setTimeout
after starting a navigation from an onunload event handler.

  • fast/frames/frame-unload-navigate-and-setTimeout-assert-fail-expected.txt: Added.
  • fast/frames/frame-unload-navigate-and-setTimeout-assert-fail.html: Added.
12:01 PM Changeset in webkit [214364] by mmaxfield@apple.com
  • 12 edits
    2 adds in trunk

Implement font-optical-sizing
​https://bugs.webkit.org/show_bug.cgi?id=168895

Reviewed by Dean Jackson.

Source/WebCore:

Upon advice from Microsoft, the only input to optical sizing is just the
font-size computed value. It is implemented by setting the 'opsz' font
variation axis. Because the propery has such a simple grammar, the
implementation is quite straightforward.

Test: fast/text/variations/optical-sizing.html

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::ComputedStyleExtractor::propertyValue):

  • css/CSSPrimitiveValueMappings.h:

(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore::CSSPrimitiveValue::operator FontOpticalSizing):

  • css/CSSProperties.json:
  • css/parser/CSSParserFastPaths.cpp:

(WebCore::CSSParserFastPaths::isValidKeywordPropertyAndValue):
(WebCore::CSSParserFastPaths::isKeywordPropertyID):

  • platform/graphics/FontCache.h:

(WebCore::FontDescriptionKey::makeFlagsKey):

  • platform/graphics/FontDescription.h:

(WebCore::FontDescription::opticalSizing):
(WebCore::FontDescription::setOpticalSizing):
(WebCore::FontDescription::operator==):
(WebCore::FontCascadeDescription::initialOpticalSizing):

  • platform/graphics/cocoa/FontCacheCoreText.cpp:

(WebCore::preparePlatformFont):
(WebCore::fontWithFamily):
(WebCore::FontCache::createFontPlatformData):
(WebCore::FontCache::systemFallbackForCharacters):

  • platform/graphics/mac/FontCustomPlatformData.cpp:

(WebCore::FontCustomPlatformData::fontPlatformData):

  • platform/text/TextFlags.h:

LayoutTests:

  • fast/text/variations/optical-sizing-expected.txt: Added.
  • fast/text/variations/optical-sizing.html: Added.
12:01 PM Changeset in webkit [214363] by commit-queue@webkit.org
  • 1 edit
    3 adds in trunk/Tools

webkitpy: Parse JSON results from run-api-tests
​https://bugs.webkit.org/show_bug.cgi?id=170062

Patch by Srinivasan Vijayaraghavan <​svijayaraghavan@apple.com> on 2017-03-24
Reviewed by Alexey Proskuryakov.

  • Scripts/webkitpy/common/net/apitestresults.py: Added.

(APITestResults): Structure to represent API test results.
(APITestResults.init):
(APITestResults.intersection): Return the failures common to both sets of results.
(APITestResults.results_from_string): Create an APITestResults object from a JSON results string.
(APITestResults.equals): Return True if both results were the same.
(APITestResults.is_subset): Return True if failing tests are a subset of the other failing tests.
(APITestResults.all_passed): Return True if everything passed.
(APITestResults.failing_tests): List of tests that didn't pass.
(APITestResults.did_exceed_test_failure_limit): Always False.

  • Scripts/webkitpy/common/net/apitestresults_unittest.py: Added.

(APITestResultsTest): Unit tests.

  • Scripts/webkitpy/tool/bot/apitestresultsreader.py: Added.

(APITestResultsReader): Read contents of JSON results file.

11:56 AM Changeset in webkit [214362] by Chris Dumez
  • 7 edits
    1 copy in trunk/Source

Unreviewed, rolling out r214329.

Significantly regressed Speedometer

Reverted changeset:

"window.crypto.getRandomValues() uses the insecure RC4 RNG"
​https://bugs.webkit.org/show_bug.cgi?id=169623
​http://trac.webkit.org/changeset/214329

11:41 AM Changeset in webkit [214361] by yoav@yoav.ws
  • 15 edits
    2 adds in trunk

Add a warning for unused link preloads.
​https://bugs.webkit.org/show_bug.cgi?id=165670

Reviewed by Youenn Fablet.

Source/WebCore:

This patch adds a warning message, to warn developers that are using
link preloads in cases where the downloaded resource is likely to
remain unused.

Test: http/tests/preload/unused_preload_warning.html

  • dom/Document.cpp:

(WebCore::Document::prepareForDestruction): Stop the timer once the document is destructed.

  • loader/LinkPreloadResourceClients.h: Add shouldMarkAsReferenced overides for the LinkPreloadResourceClient classes.
  • loader/cache/CachedResource.cpp:

(WebCore::CachedResource::addClientToSet): Make sure LinkPreloadResourceClients don't set resource to be referenced.

  • loader/cache/CachedResourceClient.h:

(WebCore::CachedResourceClient::shouldMarkAsReferenced): Make sure that ResourceClients mark preloads as referenced by default.

  • loader/cache/CachedResourceLoader.cpp:

(WebCore::CachedResourceLoader::CachedResourceLoader): Initialize timer.
(WebCore::CachedResourceLoader::~CachedResourceLoader): Stop timer.
(WebCore::CachedResourceLoader::warnUnusedPreloads): Iterate over m_preloads and issue a warning for non-referenced preloads.
(WebCore::CachedResourceLoader::documentDidFinishLoadEvent): Trigger a timer if preloads weren't cleared at load time.
(WebCore::CachedResourceLoader::warnUnusedPreloads): Triggered by the timer, and called CachedResourceLoader::warnUnusedPreloads.
(WebCore::CachedResourceLoader::stopUnusedPreloadsTimer): Stop the timer.

LayoutTests:

This adds a test for the unused preload warning, and adapts some of the other preload tests,
to avoid warnings.

  • http/tests/preload/download_resources-expected.txt: Changed.
  • http/tests/preload/download_resources.html: Added references to preloaded resources.
  • http/tests/preload/onerrer_event-expected.txt: Changed.
  • http/tests/preload/onerror_event.html: Added references to preloaded resources.
  • http/tests/preload/onload_event.html: Added references to preloaded resources.
  • http/tests/preload/resources/single_download_preload.html: Deflaked.
  • http/tests/preload/unused_preload_warning-expected.txt: Added.
  • http/tests/preload/unused_preload_warning.html: Added.
11:39 AM Changeset in webkit [214360] by Brent Fulgham
  • 10 edits
    11 adds in trunk

Handle recursive calls to ProcessingInstruction::checkStyleSheet
​https://bugs.webkit.org/show_bug.cgi?id=169982
<rdar://problem/31083051>

Reviewed by Antti Koivisto.

Source/WebCore:

See if we triggered a recursive load of the stylesheet during the 'beforeload'
event handler. If so, reset to a valid state before completing the load.

We should also check after 'beforeload' that we were not disconnected from (or
moved to a new) document.

I also looked for other cases of this pattern and fixed them.

Tests: fast/dom/beforeload/image-removed-during-before-load.html

fast/dom/beforeload/recursive-css-pi-before-load.html
fast/dom/beforeload/recursive-link-before-load.html
fast/dom/beforeload/recursive-xsl-pi-before-load.html

  • dom/ProcessingInstruction.cpp:

(WebCore::ProcessingInstruction::clearExistingCachedSheet): Added.
(WebCore::ProcessingInstruction::checkStyleSheet): Reset to valid state
if necessary after the 'beforeload' handler. Also, safely handle the case where
the element was disconnected in the 'beforeload' handler (similar to what
we do in HTMLLinkElement).
(WebCore::ProcessingInstruction::setCSSStyleSheet): Drive-by Fix: Protect the
current document to match what we do in setXSLStyleSheet.

  • dom/ProcessingInstruction.h:
  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::selectMediaResource): Safely handle the case where
the element was disconnected in the 'beforeload' handler.
(WebCore::HTMLMediaElement::selectNextSourceChild): Ditto.

  • loader/ImageLoader.cpp:

(WebCore::ImageLoader::dispatchPendingBeforeLoadEvent): Ditto.

LayoutTests:

  • fast/dom/beforeload/image-removed-during-before-load-expected.txt: Added.
  • fast/dom/beforeload/image-removed-during-before-load.html: Added.
  • fast/dom/beforeload/recursive-css-pi-before-load-expected.txt: Added.
  • fast/dom/beforeload/recursive-css-pi-before-load.html: Added.
  • fast/dom/beforeload/recursive-link-before-load-expected.txt: Added.
  • fast/dom/beforeload/recursive-link-before-load.html: Added.
  • fast/dom/beforeload/recursive-xsl-pi-before-load-expected.txt: Added.
  • fast/dom/beforeload/recursive-xsl-pi-before-load.html: Added.
  • fast/dom/beforeload/resources/content.xhtml: Added.
  • fast/dom/beforeload/resources/pass.css: Added.
  • fast/dom/beforeload/resources/test.xsl: Added.
11:23 AM Changeset in webkit [214359] by mmaxfield@apple.com
  • 25 edits
    4 adds in trunk

font-style needs a new CSSValue to make CSSRule.cssText work correctly
​https://bugs.webkit.org/show_bug.cgi?id=169258

Reviewed by David Hyatt.

Source/WebCore:

With variation fonts, font-style's value can't be captured in a CSSPrimitiveValue (nor any other subclass
off CSSValue) any more. Instead, we need to create two new CSSValues which represent the grammar that font-
style and it's associated @font-face descriptor accept.

The grammar of the font-style property is "normal | italic | oblique [ <<angle>> ]?"
The grammar of the font-style descriptor is "normal | italic | oblique [ <<angle>> | <<angle>> <<angle>> ]?"

We currently still support numbers in place of the <<angle>> value (contrary to the spec). We will remove
this support in ​https://bugs.webkit.org/show_bug.cgi?id=169357.

Tests: fast/text/font-selection-font-face-parse.html:

fast/text/font-style-parse.html:

  • CMakeLists.txt:
  • WebCore.xcodeproj/project.pbxproj:
  • css/CSSAllInOne.cpp:
  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::fontStyleFromStyle):
(WebCore::fontShorthandValueForSelectionProperties):

  • css/CSSFontFace.cpp:

(WebCore::calculateWeightRange):
(WebCore::calculateStretchRange):
(WebCore::calculateItalicRange):

  • css/CSSFontFaceSet.cpp:

(WebCore::computeFontSelectionRequest):
(WebCore::CSSFontFaceSet::matchingFaces):
(WebCore::calculateWeightValue): Deleted.
(WebCore::calculateStretchValue): Deleted.
(WebCore::calculateStyleValue): Deleted.

  • css/CSSFontFaceSet.h:
  • css/CSSFontSelector.cpp:

(WebCore::CSSFontSelector::addFontFaceRule):

  • css/CSSFontStyleRangeValue.cpp: Added.

(WebCore::CSSFontStyleRangeValue::customCSSText):
(WebCore::CSSFontStyleRangeValue::equals):

  • css/CSSFontStyleRangeValue.h: Added.
  • css/CSSFontStyleValue.cpp: Added.

(WebCore::CSSFontStyleValue::customCSSText):
(WebCore::CSSFontStyleValue::equals):

  • css/CSSFontStyleValue.h: Added.
  • css/CSSFontValue.cpp:

(WebCore::CSSFontValue::customCSSText):

  • css/CSSFontValue.h:
  • css/CSSValue.cpp:

(WebCore::CSSValue::equals):
(WebCore::CSSValue::cssText):
(WebCore::CSSValue::destroy):

  • css/CSSValue.h:

(WebCore::CSSValue::isFontStyleValue):
(WebCore::CSSValue::isFontStyleRangeValue):

  • css/FontFace.cpp:

(WebCore::FontFace::style):
(WebCore::FontFace::weight):
(WebCore::FontFace::stretch):

  • css/StyleBuilderConverter.h:

(WebCore::StyleBuilderConverter::convertFontWeightFromValue):
(WebCore::StyleBuilderConverter::convertFontStretchFromValue):
(WebCore::StyleBuilderConverter::convertFontStyleFromValue):
(WebCore::StyleBuilderConverter::convertFontWeight):
(WebCore::StyleBuilderConverter::convertFontStretch):
(WebCore::StyleBuilderConverter::convertFontStyle):

  • css/parser/CSSPropertyParser.cpp:

(WebCore::consumeFontStyle):
(WebCore::consumeFontStyleRange):
(WebCore::CSSPropertyParser::consumeSystemFont):
(WebCore::CSSPropertyParser::consumeFont):

  • svg/SVGFontFaceElement.cpp:

(WebCore::SVGFontFaceElement::parseAttribute):

LayoutTests:

Update tests' expected results.

  • fast/text/font-selection-font-face-parse-expected.txt:
  • fast/text/font-selection-font-face-parse.html:
  • fast/text/font-style-parse-expected.txt:
  • fast/text/font-style-parse.html:
  • platform/mac-elcapitan/fast/text/font-selection-font-face-parse-expected.txt:
  • svg/css/getComputedStyle-basic-expected.txt:
11:17 AM Changeset in webkit [214358] by achristensen@apple.com
  • 5 edits in trunk

REGRESSION: Content Blocker: Blocking "a[href*=randomString]" doesn't work
​https://bugs.webkit.org/show_bug.cgi?id=169167

Reviewed by Simon Fraser.

Source/WebCore:

When testing content extensions, we have always called an API function that internally
has called AtomicString::init somewhere before we start compiling the content extension.
On iOS, though, we call [_WKUserContentExtensionStore compileContentExtensionForIdentifier:...]
without having already called anything that calls AtomicString::init. The new CSS parser is now
failing to parse some selectors because CSSSelectorParser::defaultNamespace is returning starAtom,
which is a null atomic string before AtomicString::init is called.

Covered by a new API test.

  • contentextensions/ContentExtensionParser.cpp:

(WebCore::ContentExtensions::isValidCSSSelector):
(WebCore::ContentExtensions::loadAction):
(WebCore::ContentExtensions::isValidSelector): Deleted.

  • contentextensions/ContentExtensionParser.h:

Call AtomicString::init before checking if a css selector is valid.

Tools:

  • TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:

(TestWebKitAPI::TEST_F):
Test an example of a selector that was incorrectly determined to be invalid.

11:01 AM Changeset in webkit [214357] by commit-queue@webkit.org
  • 14 edits
    6 adds in trunk

Add libwebrtc backend support for RTCRtpSender::replaceTrack
​https://bugs.webkit.org/show_bug.cgi?id=169841

Patch by Youenn Fablet <​youenn@apple.com> on 2017-03-24
Reviewed by Alex Christensen.

Source/WebCore:

Tests: webrtc/audio-replace-track.html

webrtc/video-replace-track.html

Adding support for replaceTrack for audio and video sources.
Replacing tracks will always succeed for audio sources.
For video tracks, it will only succeed if the video resolution is not greater.
LibWebRTCPeerConnectionBackend will delegate the track replacing by replacing the source of the outgoing sources with the source wrapped in the replacing track.

Video test is not fully passing as size constraints for mock video sources are not providing the right video stream resolution.

  • Modules/mediastream/RTCRtpSender.cpp:

(WebCore::RTCRtpSender::replaceTrack):

  • Modules/mediastream/RTCRtpSender.h:
  • Modules/mediastream/RTCRtpSender.idl:
  • Modules/mediastream/libwebrtc/LibWebRTCPeerConnectionBackend.cpp:

(WebCore::LibWebRTCPeerConnectionBackend::replaceTrack):

  • Modules/mediastream/libwebrtc/LibWebRTCPeerConnectionBackend.h:
  • platform/mediastream/mac/RealtimeOutgoingAudioSource.cpp:

(WebCore::RealtimeOutgoingAudioSource::setSource):

  • platform/mediastream/mac/RealtimeOutgoingAudioSource.h:
  • platform/mediastream/mac/RealtimeOutgoingVideoSource.cpp:

(WebCore::RealtimeOutgoingVideoSource::setSource):

  • platform/mediastream/mac/RealtimeOutgoingVideoSource.h:
  • platform/mock/MockRealtimeVideoSource.cpp:

(WebCore::MockRealtimeVideoSource::drawText):
(WebCore::MockRealtimeVideoSource::generateFrame):

LayoutTests:

  • webrtc/audio-replace-track-expected.txt: Added.
  • webrtc/audio-replace-track.html: Added.
  • webrtc/video-replace-track-expected.txt: Added.
  • webrtc/video-replace-track.html: Added.
  • webrtc/video-replace-track-to-null-expected.txt: Added.
  • webrtc/video-replace-track-to-null.html: Added.
10:46 AM Changeset in webkit [214356] by jonlee@apple.com
  • 2 edits in trunk/Source/WebCore

Remove comment from RTCStatsReport.idl to convert ssrc to DOMString.
Unreviewed.

Latest available Editor's Draft of WebRTC Statistics API is from 14 December 2016,
but since then, in ​https://github.com/w3c/webrtc-stats/pull/157, it was changed to become
unsigned long.

  • Modules/mediastream/RTCStatsReport.idl:
10:20 AM Changeset in webkit [214355] by Ryan Haddad
  • 3 edits in trunk/LayoutTests

Update TestExpectations for media/restore-from-page-cache.html.

Unreviewed test gardening.

  • platform/mac-wk2/TestExpectations:
  • platform/mac/TestExpectations:
10:18 AM Changeset in webkit [214354] by webkit@devinrousso.com
  • 12 edits
    1 copy
    1 add in trunk/Source/WebInspectorUI

Web Inspector: Indicate whether a WebSocket connection is open or close
​https://bugs.webkit.org/show_bug.cgi?id=168948

Reviewed by Joseph Pecoraro.

  • Localizations/en.lproj/localizedStrings.js:
  • UserInterface/Main.html:

Added WebSocketResourceTreeElement.js and SpanningDataGridNode.js.

  • UserInterface/Views/WebSocketContentView.js:

(WebInspector.WebSocketContentView):
(WebInspector.WebSocketContentView.prototype.shown):
(WebInspector.WebSocketContentView.prototype.hidden):
(WebInspector.WebSocketContentView.prototype._updateState):
Listen to changes in the readyState and add a SpanningDataGridNode when the current state
becomes Closed.

  • UserInterface/Views/WebSocketResourceTreeElement.js: Added.

(WebInspector.WebSocketResourceTreeElement.prototype.onattach):
(WebInspector.WebSocketResourceTreeElement.prototype.ondetach):
(WebInspector.WebSocketResourceTreeElement.prototype._updateConnectionStatus):
Listen to changes in the readyState and add/remove the status element depending on the
current state:

  • Closed: show no status indicator
  • Connecting: show a small circle with a yellow color
  • Open: show a small circle with a green color
  • UserInterface/Views/ResourceTreeElement.css:

(.item.resource.resource-type-websocket .status > div):
(.item.resource.resource-type-websocket:not(.selected) .status .open):
(.tree-outline:not(:focus, .force-focus) .item.resource.resource-type-websocket.selected .status .open):
(body:matches(.window-inactive, .window-docked-inactive) .item.resource.resource-type-websocket.selected .status .open):
(.item.resource.resource-type-websocket:not(.selected) .status .connecting):
(.tree-outline:not(:focus, .force-focus) .item.resource.resource-type-websocket.selected .status .connecting):
(body:matches(.window-inactive, .window-docked-inactive) .item.resource.resource-type-websocket.selected .status .connecting):

  • UserInterface/Views/FrameTreeElement.js:

(WebInspector.FrameTreeElement):
Use WebSocketResourceTreeElement as the constructor for WebSocket resources.

  • UserInterface/Views/SpanningDataGridNode.js: Added.

(WebInspector.SpanningDataGridNode.prototype.createCells):
Creates a single cell that spans all the columns (via CSS colspan) of the parent DataGrid.

  • UserInterface/Views/DataGrid.css:

(.data-grid td.spanning):
Center content of spanning nodes and prevent user interaction.

  • UserInterface/Views/DataGridNode.js:

(WebInspector.DataGridNode.prototype.createCell):
Add additional checks so that a DataGridNode can be created with a column identifier that is
not in the DataGrid. This is used by SpanningGridDataNode, as it shouldn't match one single
column in the DataGrid since it spans them all.

  • UserInterface/Views/GeneralTreeElement.js:

(WebInspector.GeneralTreeElement.prototype.ondetach):

  • UserInterface/Views/BreakpointTreeElement.js:

(WebInspector.BreakpointTreeElement.prototype.ondetach):

  • UserInterface/Views/DOMBreakpointTreeElement.js:

(WebInspector.DOMBreakpointTreeElement.prototype.ondetach):

  • UserInterface/Views/XHRBreakpointTreeElement.js:

(WebInspector.XHRBreakpointTreeElement.prototype.ondetach):
Add ondetach function (with super calls) for future use.

10:11 AM Changeset in webkit [214353] by Carlos Garcia Campos
  • 2 edits in trunk/LayoutTests

Unreviewed GTK+ gardening. Mark webrtc/video-stats.html as failing.

  • platform/gtk/TestExpectations:
10:03 AM Changeset in webkit [214352] by Jonathan Bedard
  • 2 edits in trunk/Tools

Increase timeout for booting simulators.
<rdar://problem/31080009>

Unreviewed infrastructure fix.

  • Scripts/webkitpy/xcode/simulator.py:

(Simulator.wait_until_device_is_booted): Increase timeout.
(Simulator.wait_until_device_is_in_state): Increase timeout.

9:45 AM Changeset in webkit [214351] by akling@apple.com
  • 3 edits in trunk/Source/WTF

Make inactive web processes behave as though under memory pressure.
<​https://webkit.org/b/170042>

Reviewed by Antti Koivisto.

Once a web process becomes inactive, let's try to reduce its impact
on memory usage by treating it as if it's under memory pressure until
it becomes active.

  • wtf/MemoryPressureHandler.cpp:

(WTF::MemoryPressureHandler::setProcessState):
(WTF::MemoryPressureHandler::isUnderMemoryPressure):

  • wtf/MemoryPressureHandler.h:

(WTF::MemoryPressureHandler::isUnderMemoryPressure): Deleted.

9:32 AM Changeset in webkit [214350] by commit-queue@webkit.org
  • 5 edits
    4 adds in trunk

Add support for DataChannel and MediaStreamTrack stats
​https://bugs.webkit.org/show_bug.cgi?id=170031

Patch by Youenn Fablet <​youenn@apple.com> on 2017-03-24
Reviewed by Eric Carlson.

Source/WebCore:

Tests: webrtc/datachannel/datachannel-stats.html

webrtc/video-mediastreamtrack-stats.html

Exposing libwebrtc stats through WebRTC stats API, gathered for data channel and media stream tracks.

  • Modules/mediastream/RTCStatsReport.h:

(WebCore::RTCStatsReport::MediaStreamTrackStats::MediaStreamTrackStats):
(WebCore::RTCStatsReport::DataChannelStats::DataChannelStats):

  • Modules/mediastream/RTCStatsReport.idl:
  • Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp:

(WebCore::fillRTCMediaStreamTrackStats):
(WebCore::fillRTCDataChannelStats):
(WebCore::LibWebRTCMediaEndpoint::StatsCollector::OnStatsDelivered):

LayoutTests:

  • webrtc/datachannel/datachannel-stats-expected.txt: Added.
  • webrtc/datachannel/datachannel-stats.html: Added.
  • webrtc/video-mediastreamtrack-stats-expected.txt: Added.
  • webrtc/video-mediastreamtrack-stats.html: Added.
9:27 AM Changeset in webkit [214349] by Chris Dumez
  • 3 edits in trunk/LayoutTests

Extend svg/animations/animations-paused-disconnected-iframe.html
​https://bugs.webkit.org/show_bug.cgi?id=170035

Reviewed by Andreas Kling.

Extend svg/animations/animations-paused-disconnected-iframe.html to cover more things.

  • svg/animations/animations-paused-disconnected-iframe-expected.txt:
  • svg/animations/animations-paused-disconnected-iframe.html:
9:25 AM Changeset in webkit [214348] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

Fix framesEncoded/framesDecoded RTC stats
​https://bugs.webkit.org/show_bug.cgi?id=170024

Patch by Youenn Fablet <​youenn@apple.com> on 2017-03-24
Reviewed by Eric Carlson.

Source/WebCore:

Test: webrtc/video-stats.html

Adding access to these fields now that they are available.

  • Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp:

(WebCore::fillInboundRTPStreamStats):
(WebCore::fillOutboundRTPStreamStats):

LayoutTests:

  • webrtc/video-stats-expected.txt: Added.
  • webrtc/video-stats.html: Added.
7:55 AM Changeset in webkit [214347] by Carlos Garcia Campos
  • 2 edits in trunk/Tools

Unreviewed. Fix GTK+ test /webkit2/WebKitWebView/javascript-dialogs after r214277.

Since r214277 beforeunload events are not fired unless there's some user interaction, so we need to simulate it
in our unit tests to work.

  • TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp:

(testWebViewJavaScriptDialogs):

7:33 AM Changeset in webkit [214346] by Carlos Garcia Campos
  • 2 edits in trunk/Source/WebCore

Unreviewed. Fix GTK+ test /webkit2/WebKitWebView/default-menu after r214244.

Fix mnemonic string of contextMenuItemTagOpenAudioInNewWindow() that I copy pasted from
contextMenuItemTagOpenVideoInNewWindow().

  • platform/LocalizedStrings.cpp:

(WebCore::contextMenuItemTagOpenAudioInNewWindow):

7:30 AM Changeset in webkit [214345] by Yusuke Suzuki
  • 3 edits
    1 add in trunk

[JSC] Use jsNontrivialString agressively for ToString(Int52)
​https://bugs.webkit.org/show_bug.cgi?id=170002

Reviewed by Sam Weinig.

JSTests:

  • stress/to-string-int52.js: Added.

(shouldBe):
(toString10):
(expected):

Source/JavaScriptCore:

We use the same logic used for Int32 to use jsNontvirialString.
After single character check, produced string is always longer than 1.
Thus, we can use jsNontrivialString.

  • runtime/NumberPrototype.cpp:

(JSC::int52ToString):

6:59 AM Changeset in webkit [214344] by Carlos Garcia Campos
  • 2 edits in trunk/LayoutTests

Unreviewed GTK+ gardening. Mark media/video-load-require-user-gesture.html as failing after r214338.

  • platform/gtk/TestExpectations:
6:30 AM Changeset in webkit [214343] by Carlos Garcia Campos
  • 2 edits
    3 adds in trunk/LayoutTests

Unreviewed GTK+ gardening. Rebaseline http/tests/inspector/network/fetch-response-body.html/xhr-response-body.html after r214338.

We are now getting the right application/json for a file data.json. The soup network backend tries to gess the
mime type from the extension when sniffing is not allowed and the mime type is not known. See bug
webkit.org/b/168299, that was added actually to fix these tests, but at that time we also failed to guess the
mime type and returned application/octet-stream.

  • platform/gtk/TestExpectations:
  • platform/gtk/http/tests/inspector/network/fetch-response-body-expected.txt: Added.
  • platform/gtk/http/tests/inspector/network/xhr-response-body-expected.txt: Added.
6:22 AM WebKitGTK/2.16.x edited by Michael Catanzaro
(diff)
6:19 AM Changeset in webkit [214342] by Carlos Garcia Campos
  • 1 edit
    1 add in trunk/LayoutTests

Unreviewed GTK+ gardening. Rebaseline fast/dom/HTMLAnchorElement/anchor-file-blob-convert-to-download.html after r214338.

We are now getting a MIME type for otf files.

  • platform/gtk/fast/dom/HTMLAnchorElement/anchor-file-blob-convert-to-download-expected.txt: Added.
5:50 AM Changeset in webkit [214341] by Carlos Garcia Campos
  • 2 edits in trunk/Source/WebCore

[GStreamer] MediaPlayerPrivateGStreamerOwr shouldn't be the default engine
​https://bugs.webkit.org/show_bug.cgi?id=170049

Reviewed by Žan Doberšek.

This is causing several media tests to fail after r214338. When trying to load something like this:

​http://127.0.0.1:8000/media/resources/serve-video.php?name=../../../../media/content/silence.wav&type=audio/wav&content-length=no&icy-data=yes

since r214338, the content type is known and inferred from the extension in this case, what ends up calling
nextMediaEngine() in MediaPlayer::loadWithNextMediaEngine. That returns the first registered media engine, that
is Owr that doesn't know how to load that and fails.

Fixes: http/tests/media/media-play-stream-chunked-icy.html

http/tests/media/media-seeking-no-ranges-server.html
http/tests/media/video-auth.html
http/tests/media/video-play-stall-before-meta-data.html
http/tests/security/contentSecurityPolicy/audio-redirect-allowed.html
http/tests/security/contentSecurityPolicy/audio-redirect-allowed2.html
http/tests/security/contentSecurityPolicy/audio-redirect-blocked.html
http/tests/security/contentSecurityPolicy/video-redirect-allowed.html
http/tests/security/contentSecurityPolicy/video-redirect-allowed2.html
http/tests/security/contentSecurityPolicy/video-redirect-blocked.html

  • platform/graphics/MediaPlayer.cpp:

(WebCore::buildMediaEnginesVector):

5:01 AM Changeset in webkit [214340] by pvollan@apple.com
  • 6 edits in trunk

Text stroke is sometimes clipped on video captions.
​https://bugs.webkit.org/show_bug.cgi?id=170006

Reviewed by Eric Carlson.

Source/WebCore:

Set 'overflow' property to 'visible' on cue element to avoid clipping of text stroke.

Updated test media/track/track-css-stroke-cues.html.

  • html/track/TextTrackCueGeneric.cpp:

(WebCore::TextTrackCueGenericBoxElement::applyCSSProperties):

  • html/track/VTTCue.cpp:

(WebCore::VTTCueBox::applyCSSProperties):

LayoutTests:

  • media/track/track-css-stroke-cues-expected.txt:
  • media/track/track-css-stroke-cues.html:
1:26 AM Changeset in webkit [214339] by Carlos Garcia Campos
  • 1 edit
    3 adds in trunk/Source/ThirdParty

Unreviewed. Fix the build after r214338.

Add missing files I forgot to git add again.

  • xdgmime/CMakeLists.txt: Added.
  • xdgmime/README: Added.
  • xdgmime/README.webkit: Added.
1:21 AM Changeset in webkit [214338] by Carlos Garcia Campos
  • 27 edits
    1 move
    1 add in trunk

[GTK] Add MIMETypeRegistry implementation using xdgmime and remove the GTK+ one
​https://bugs.webkit.org/show_bug.cgi?id=170001

Reviewed by Michael Catanzaro.

.:

  • Source/CMakeLists.txt: Compile xdgmime if USE_XDGMIME is ON.
  • Source/cmake/OptionsGTK.cmake: Set USE_XDGMIME to ON.

Source/ThirdParty:

Add xdgmime to ThirdParty.

  • xdgmime/CMakeLists.txt: Added.
  • xdgmime/README: Added.
  • xdgmime/README.webkit: Added.
  • xdgmime/src/xdgmime.c: Added.
  • xdgmime/src/xdgmime.h: Added.
  • xdgmime/src/xdgmimealias.c: Added.
  • xdgmime/src/xdgmimealias.h: Added.
  • xdgmime/src/xdgmimecache.c: Added.
  • xdgmime/src/xdgmimecache.h: Added.
  • xdgmime/src/xdgmimeglob.c: Added.
  • xdgmime/src/xdgmimeglob.h: Added.
  • xdgmime/src/xdgmimeicon.c: Added.
  • xdgmime/src/xdgmimeicon.h: Added.
  • xdgmime/src/xdgmimeint.c: Added.
  • xdgmime/src/xdgmimeint.h: Added.
  • xdgmime/src/xdgmimemagic.c: Added.
  • xdgmime/src/xdgmimemagic.h: Added.
  • xdgmime/src/xdgmimeparent.c: Added.
  • xdgmime/src/xdgmimeparent.h: Added.

Source/WebCore:

The XDG implementation could be used by any port where shared-mime-info is expected to be available. It also
improves the current GTK+ implementation that is based on a very small map of mime types and extensions.

  • CMakeLists.txt:
  • PlatformGTK.cmake:
  • platform/xdg/MIMETypeRegistryXdg.cpp: Renamed from Source/WebCore/platform/gtk/MIMETypeRegistryGtk.cpp.

(WebCore::MIMETypeRegistry::getMIMETypeForExtension):
(WebCore::MIMETypeRegistry::getPreferredExtensionForMIMEType):

Tools:

Ignore style of xdgmime sources.

  • Scripts/webkitpy/tool/steps/checkstyle.py:

LayoutTests:

Remove platform specific expectations of two test because now we do the same as other wk2 ports.

  • platform/gtk/TestExpectations:
1:07 AM Changeset in webkit [214337] by Carlos Garcia Campos
  • 1 edit
    18 adds in trunk/Source/ThirdParty

Unreviewed. Add stubs for xdgmime sources to ThirdParty.

This is in preparation for bug #170001, to try to bypass the SVN hook that doesn't allow to commit source files
containing tabs. I'm committing empty files, so that once those files are known by SVN I can set the
allow-tabs property and then commit the actual contents.

  • xdgmime/src/xdgmime.c: Added.
  • xdgmime/src/xdgmime.h: Added.
  • xdgmime/src/xdgmimealias.c: Added.
  • xdgmime/src/xdgmimealias.h: Added.
  • xdgmime/src/xdgmimecache.c: Added.
  • xdgmime/src/xdgmimecache.h: Added.
  • xdgmime/src/xdgmimeglob.c: Added.
  • xdgmime/src/xdgmimeglob.h: Added.
  • xdgmime/src/xdgmimeicon.c: Added.
  • xdgmime/src/xdgmimeicon.h: Added.
  • xdgmime/src/xdgmimeint.c: Added.
  • xdgmime/src/xdgmimeint.h: Added.
  • xdgmime/src/xdgmimemagic.c: Added.
  • xdgmime/src/xdgmimemagic.h: Added.
  • xdgmime/src/xdgmimeparent.c: Added.
  • xdgmime/src/xdgmimeparent.h: Added.

Mar 23, 2017:

10:31 PM Changeset in webkit [214336] by Yusuke Suzuki
  • 3 edits in trunk/Source/JavaScriptCore

[JSC] Use WeakRandom for SamplingProfiler interval fluctuation
​https://bugs.webkit.org/show_bug.cgi?id=170045

Reviewed by Mark Lam.

It is unnecessary to use cryptographicallyRandomNumber for SamplingProfiler
interval fluctuation. Use WeakRandom instead.

  • runtime/SamplingProfiler.cpp:

(JSC::SamplingProfiler::SamplingProfiler):
(JSC::SamplingProfiler::timerLoop):

  • runtime/SamplingProfiler.h:
10:14 PM Changeset in webkit [214335] by jonlee@apple.com
  • 2 edits in trunk/Source/WebCore

Update createDataChannel on RTCPeerConnection
​https://bugs.webkit.org/show_bug.cgi?id=170044

Reviewed by Youenn Fablet.

  • Modules/mediastream/RTCPeerConnection.idl: Change label to USVString.
9:53 PM Changeset in webkit [214334] by mark.lam@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Array.prototype.splice behaves incorrectly when the VM is "having a bad time".
​https://bugs.webkit.org/show_bug.cgi?id=170025
<rdar://problem/31228679>

Reviewed by Saam Barati.

  • runtime/ArrayPrototype.cpp:

(JSC::copySplicedArrayElements):
(JSC::arrayProtoFuncSplice):

8:20 PM Changeset in webkit [214333] by Antti Koivisto
  • 15 edits
    2 deletes in trunk

Revert r213712, caused iPad PLT regression
​https://bugs.webkit.org/show_bug.cgi?id=170040

Unreviewed.

Source/WebCore:

A few subtests have big regressions.

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::pseudoStyleRulesForElement):

  • dom/Document.cpp:

(WebCore::Document::resolveStyle):
(WebCore::Document::updateLayoutIgnorePendingStylesheets):
(WebCore::Document::shouldScheduleLayout):
(WebCore::Document::didRemoveAllPendingStylesheet):

  • dom/Document.h:

(WebCore::Document::didLayoutWithPendingStylesheets):
(WebCore::Document::hasNodesWithPlaceholderStyle):
(WebCore::Document::setHasNodesWithPlaceholderStyle):
(WebCore::Document::hasNodesWithNonFinalStyle): Deleted.
(WebCore::Document::setHasNodesWithNonFinalStyle): Deleted.

  • html/HTMLFrameSetElement.cpp:

(WebCore::HTMLFrameSetElement::rendererIsNeeded):

  • page/FrameView.cpp:

(WebCore::FrameView::qualifiesAsVisuallyNonEmpty):
(WebCore::FrameView::fireLayoutRelatedMilestonesIfNeeded):

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::paintContents):

  • rendering/RenderLayer.cpp:

(WebCore::shouldSuppressPaintingLayer):

  • rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::changeRequiresRepaint):

  • rendering/style/RenderStyle.h:

(WebCore::RenderStyle::isPlaceholderStyle):
(WebCore::RenderStyle::setIsPlaceholderStyle):
(WebCore::RenderStyle::isNotFinal): Deleted.
(WebCore::RenderStyle::setIsNotFinal): Deleted.

  • rendering/style/StyleRareNonInheritedData.cpp:

(WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):
(WebCore::StyleRareNonInheritedData::operator==):

  • rendering/style/StyleRareNonInheritedData.h:
  • style/StyleScope.cpp:

(WebCore::Style::Scope::analyzeStyleSheetChange):
(WebCore::Style::Scope::updateActiveStyleSheets):

  • style/StyleTreeResolver.cpp:

(WebCore::Style::makePlaceholderStyle):
(WebCore::Style::TreeResolver::styleForElement):
(WebCore::Style::TreeResolver::resolveElement):

LayoutTests:

  • http/tests/incremental/stylesheet-body-incremental-rendering-expected.html: Removed.
  • http/tests/incremental/stylesheet-body-incremental-rendering.html: Removed.
7:28 PM Changeset in webkit [214332] by ddkilzer@apple.com
  • 2 edits in trunk/Websites/bugs.webkit.org

Fix Apache::SizeLimit unshared size limit in mod_perl.pl for bugs.webkit.org
<​https://webkit.org/b/169926>

Reviewed by Brent Fulgham.

  • mod_perl.pl: Update syntax for setting unshared size

limit, and bump it up another 100 Mb so children don't
respawn as quickly.

6:43 PM Changeset in webkit [214331] by Wenson Hsieh
  • 6 edits
    1 add in trunk

Dragging on a large image should not revert to a file icon if data interaction is enabled
​https://bugs.webkit.org/show_bug.cgi?id=170018
<rdar://problem/31184508>

Reviewed by Tim Horton.

Source/WebCore:

If data interaction is enabled, don't fall back to showing a file icon when initiating a drag on an image element.

New API tests: DataInteractionTests.LargeImageToTargetDiv

DataInteractionTests.AttachmentElementItemProviders

  • page/DragController.cpp:

(WebCore::DragController::doImageDrag):
(WebCore::DragController::shouldUseCachedImageForDragImage):

  • page/DragController.h:

Tools:

Add new tests for data interaction. LargeImageToTargetDiv verifies the change made in this patch, while
AttachmentElementItemProviders was a test that was previously removed due to <rdar://problem/31038797>.

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/Tests/WebKit2Cocoa/large-red-square.png: Added.
  • TestWebKitAPI/Tests/ios/DataInteractionTests.mm:

(TestWebKitAPI::TEST):

6:40 PM Changeset in webkit [214330] by commit-queue@webkit.org
  • 9 edits
    3 adds in trunk/Source/WebCore

Rename RTCIceCandidateEvent to RTCPeerConnectionIceEvent
​https://bugs.webkit.org/show_bug.cgi?id=169981

Patch by Youenn Fablet <​youenn@apple.com> on 2017-03-23
Reviewed by Eric Carlson.

  • CMakeLists.txt:
  • DerivedSources.make:
  • Modules/mediastream/MediaEndpointPeerConnection.cpp:
  • Modules/mediastream/PeerConnectionBackend.cpp:

(WebCore::PeerConnectionBackend::fireICECandidateEvent):
(WebCore::PeerConnectionBackend::doneGatheringCandidates):

  • Modules/mediastream/RTCPeerConnection.cpp:
  • Modules/mediastream/RTCPeerConnectionIceEvent.cpp: Renamed from Source/WebCore/Modules/mediastream/RTCIceCandidateEvent.cpp.

(WebCore::RTCPeerConnectionIceEvent::create):
(WebCore::RTCPeerConnectionIceEvent::RTCPeerConnectionIceEvent):
(WebCore::RTCPeerConnectionIceEvent::~RTCPeerConnectionIceEvent):
(WebCore::RTCPeerConnectionIceEvent::candidate):
(WebCore::RTCPeerConnectionIceEvent::eventInterface):

  • Modules/mediastream/RTCPeerConnectionIceEvent.h: Renamed from Source/WebCore/Modules/mediastream/RTCIceCandidateEvent.h.
  • Modules/mediastream/RTCPeerConnectionIceEvent.idl: Renamed from Source/WebCore/Modules/mediastream/RTCIceCandidateEvent.idl.
  • WebCore.xcodeproj/project.pbxproj:
  • dom/EventNames.in:
6:36 PM Changeset in webkit [214329] by Michael Catanzaro
  • 7 edits
    1 delete in trunk/Source

window.crypto.getRandomValues() uses the insecure RC4 RNG
​https://bugs.webkit.org/show_bug.cgi?id=169623

Reviewed by Alex Christensen.

Source/WebCore:

  • PlatformMac.cmake:
  • WebCore.xcodeproj/project.pbxproj:
  • crypto/CryptoKey.cpp:

(WebCore::CryptoKey::randomData): Use this on Mac now.

  • crypto/mac/CryptoKeyMac.cpp: Removed.
  • page/Crypto.cpp:

(WebCore::Crypto::getRandomValues): Rollout r214188.

Source/WTF:

Remove the RC4 random generator in favor of using OS randomness for now. This is basically
a merge of ​https://codereview.chromium.org/1431233002 from Blink, original author "eroman".

  • wtf/CryptographicallyRandomNumber.cpp:

(WTF::cryptographicallyRandomNumber):
(WTF::cryptographicallyRandomValues):
(): Deleted.

5:07 PM Changeset in webkit [214328] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

Update WinCairoRequirements.zip
​https://bugs.webkit.org/show_bug.cgi?id=169950

Patch by Fujii Hironori <Fujii Hironori> on 2017-03-23
Reviewed by Alex Christensen.

  • Scripts/update-webkit-wincairo-libs: Replace $winCairoLibsURL.
4:51 PM Changeset in webkit [214327] by Chris Dumez
  • 3 edits
    2 adds in trunk

SVG animations are not paused when their <svg> element is removed from the document
​https://bugs.webkit.org/show_bug.cgi?id=170030
<rdar://problem/31230252>

Reviewed by Dean Jackson.

Source/WebCore:

SVG animations were not paused when their <svg> element was removed from the document.
This patch fixes the issue.

Test: svg/animations/animations-paused-when-removed-from-document.html

  • svg/SVGSVGElement.cpp:

(WebCore::SVGSVGElement::insertedInto):
(WebCore::SVGSVGElement::removedFrom):

LayoutTests:

Add layout test coverage.

  • svg/animations/animations-paused-when-removed-from-document-expected.txt: Added.
  • svg/animations/animations-paused-when-removed-from-document.html: Added.
4:42 PM Changeset in webkit [214326] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Cache type is not styled correctly in Timelines tab
​https://bugs.webkit.org/show_bug.cgi?id=170032

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2017-03-23
Reviewed by Matt Baker.

  • UserInterface/Views/NetworkGridContentView.css:

(.content-view:matches(.network, .network-grid) > .data-grid .cache-type):
(.content-view:matches(.network, .network-grid) > .data-grid:matches(:focus, .force-focus) tr.selected .cache-type):
(.content-view.network-grid > .data-grid .cache-type): Deleted.
(.content-view.network-grid > .data-grid:matches(:focus, .force-focus) tr.selected .cache-type): Deleted.
The different network grids have different class names. Handle both.

4:30 PM Changeset in webkit [214325] by jmarcell@apple.com
  • 2 edits in tags/Safari-604.1.14/Source/WebCore

Merge r214310. rdar://problem/31225378

4:14 PM Changeset in webkit [214324] by mmaxfield@apple.com
  • 9 edits in trunk

font shorthand should accept variation values
​https://bugs.webkit.org/show_bug.cgi?id=168998

Reviewed by Simon Fraser.

Source/WebCore:

The CSS Fonts 4 spec has stabilized as to which variation values are allowed in
the font shorthand property. Weights are allowed because a 0 weight is considered
as a parse error, so there is no conflict with a unitless font-size of 0.
font-style accepts angles, so there is no conflict there. However, font-stretch
accepts percentages, which are also accepted by font-size, which means the newly
extended grammar for font-stretch can't be accepted in the shorthand.

Tests: fast/text/font-style-parse.html

fast/text/font-weight-parse.html

  • css/parser/CSSPropertyParser.cpp:

(WebCore::consumeFontWeight):
(WebCore::consumeFontStyle):
(WebCore::CSSPropertyParser::consumeFont):
(WebCore::consumeFontWeightCSS21): Deleted.

  • css/parser/CSSPropertyParserHelpers.cpp:

(WebCore::CSSPropertyParserHelpers::consumeFontWeightNumber):

  • css/parser/CSSPropertyParserHelpers.h:

LayoutTests:

  • fast/text/font-style-parse-expected.txt:
  • fast/text/font-style-parse.html:
  • fast/text/font-weight-parse-expected.txt:
  • fast/text/font-weight-parse.html:
3:53 PM Changeset in webkit [214323] by Yusuke Suzuki
  • 3 edits
    1 add in trunk

[JSC][DFG] Make addShouldSpeculateAnyInt more conservative to avoid regression caused by Double <-> Int52 conversions
​https://bugs.webkit.org/show_bug.cgi?id=169998

Reviewed by Saam Barati.

JSTests:

  • microbenchmarks/int52-back-and-forth.js: Added.

(shouldBe):
(num):

Source/JavaScriptCore:

Double <-> Int52 and JSValue <-> Int52 conversions are not so cheap. Thus, Int52Rep is super carefully emitted.
We make addShouldSpeculateAnyInt more conservative to avoid regressions caused by the above conversions.
We select ArithAdd(Int52, Int52) only when this calculation is beneficial compared to added Int52Rep conversions.

This patch tighten the conditions of addShouldSpeculateAnyInt.

  1. Honor DoubleConstant.

When executing imaging-darkroom, we have a thing like that,

132:< 2:loc36> DoubleConstant(Double|UseAsOther, AnyIntAsDouble, Double: 4607182418800017408, 1.000000, bc#114)
1320:< 1:loc38> Int52Rep(Check:Int32:@82, Int52|PureInt, Int32, Exits, bc#114)
1321:< 1:loc39> Int52Constant(Int52|PureInt, Boolint32Nonboolint32Int52, Double: 4607182418800017408, 1.000000, bc#114)
133:<!3:loc39> ArithSub(Int52Rep:@1320<Int52>, Int52Rep:@1321<Int52>, Int52|MustGen, Int52, CheckOverflow, Exits, bc#114)

The LHS of ArithSub says predicting Boolint32, and the rhs says AnyIntAsDouble. Thus we select ArithSub(Int52, Int52) instead
of ArithSub(Double, Double). However, it soon causes OSR exits. In imaging-darkroom, LHS's Int32 prediction will be broken.
While speculating Int32 in the above situation is reasonable approach since the given LHS says predicting Int32, this causes
severe performance regression.

Previously, we always select ArithSub(Double, Double). So accidentally, we do not encounter this misprediction issue.

One thing can be found that we have DoubleConstant in the RHS. It means that we have 1.0 instead of 1 in the code.
We can see the code like lhs - 1.0 instead of lhs - 1 in imaging-darkroom. It offers good information that lhs and
the resulting value would be double. Handling the above ArithSub in double seems more appropriate rather than handling
it in Int52.

So, in this patch, we honor DoubleConstant. If we find DoubleConstant on one operand, we give up selecting
Arith[Sub,Add](Int52, Int52). This change removes OSR exits occurr in imaging-darkroom right now.

  1. Two Int52Rep(Double) conversions are not desirable.

We allow AnyInt ArithAdd only when the one operand of the binary operation should be speculated AnyInt. It is a bit conservative
decision. This is because Double to Int52 conversion is not so cheap. Frequent back-and-forth conversions between Double and Int52
rather hurt the performance. If the one operand of the operation is already Int52, the cost for constructing ArithAdd becomes
cheap since only one Double to Int52 conversion could be required.
This recovers some regression in assorted tests while keeping kraken crypto improvements.

  1. Avoid frequent Int52 to JSValue conversions.

Int52 to JSValue conversion is not so cheap. Thus, we would like to avoid such situations. So, in this patch, we allow
Arith(Int52, Int52) with AnyIntAsDouble operand only when the node is used as number. By doing so, we avoid the case like,
converting Int52, performing ArithAdd, and soon converting back to JSValue.

The above 3 changes recover the regression measured in microbenchmarks/int52-back-and-forth.js and assorted benchmarks.
And still it keeps kraken crypto improvements.

baseline patched

imaging-darkroom 201.112+-3.192 189.532+-2.883 definitely 1.0611x faster
stanford-crypto-pbkdf2 103.953+-2.325 100.926+-2.396 might be 1.0300x faster
stanford-crypto-sha256-iterative 35.103+-1.071 ? 36.049+-1.143 ? might be 1.0270x slower

  • dfg/DFGGraph.h:

(JSC::DFG::Graph::addShouldSpeculateAnyInt):

3:40 PM Changeset in webkit [214322] by Chris Dumez
  • 8 edits
    4 adds in trunk

SVG animations are not paused when inserted into a hidden page
​https://bugs.webkit.org/show_bug.cgi?id=170026
<rdar://problem/31228704>

Reviewed by Andreas Kling.

Source/WebCore:

SVG animations were not paused when inserted into a hidden page. We would pause
animations in a page when the page becomes hidden. However, new animations
inserted in the page after this point would start, despite the page being
hidden.

Tests:

  • svg/animations/animations-paused-when-inserted-in-hidden-document.html
  • svg/animations/animations-paused-when-inserted-in-hidden-document2.html
  • dom/Document.cpp:

(WebCore::Document::accessSVGExtensions):

  • svg/SVGDocumentExtensions.cpp:

(WebCore::SVGDocumentExtensions::SVGDocumentExtensions):
(WebCore::SVGDocumentExtensions::addTimeContainer):
(WebCore::reportMessage):

  • svg/SVGDocumentExtensions.h:
  • testing/Internals.cpp:

(WebCore::Internals::areSVGAnimationsPaused):

  • testing/Internals.h:
  • testing/Internals.idl:

LayoutTests:

Add layout test coverage.

  • svg/animations/animations-paused-when-inserted-in-hidden-document-expected.txt: Added.
  • svg/animations/animations-paused-when-inserted-in-hidden-document.html: Added.
  • svg/animations/animations-paused-when-inserted-in-hidden-document2-expected.txt: Added.
  • svg/animations/animations-paused-when-inserted-in-hidden-document2.html: Added.
3:39 PM Changeset in webkit [214321] by Michael Catanzaro
  • 5 edits
    5 copies in trunk

Rolled over to ChangeLog-2017-03-23

3:21 PM Changeset in webkit [214320] by akling@apple.com
  • 10 edits in trunk/Source

Let the UI process do memory kills and replace crashes with diagnostic logging.
<​https://webkit.org/b/170016>
<rdar://problem/31091292>

Reviewed by Chris Dumez.

Source/WebCore:

Remove the memory kill code from WebCore that just crashes in favor of controlled
teardown from UI process side in WebKit2.

  • page/DiagnosticLoggingKeys.cpp:

(WebCore::DiagnosticLoggingKeys::simulatedProcessCrashKey):
(WebCore::DiagnosticLoggingKeys::exceededActiveMemoryLimitKey):
(WebCore::DiagnosticLoggingKeys::exceededInactiveMemoryLimitKey):
(WebCore::DiagnosticLoggingKeys::exceededBackgroundCPULimitKey):

  • page/DiagnosticLoggingKeys.h:
  • page/MemoryRelease.cpp:

(WebCore::didExceedMemoryLimitAndFailedToRecover): Deleted.

  • page/MemoryRelease.h:

Source/WebKit2:

Have the WebProcess memory kill callback send a notification to the UI process
instead of outright crashing. The UI process then sends a diagnostic logging message
before carefully taking down the web process.

Also add drive-by diagnostic logging for background CPU limit kills.

  • UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::simulateProcessCrash):
(WebKit::WebProcessProxy::didExceedActiveMemoryLimit):
(WebKit::WebProcessProxy::didExceedInactiveMemoryLimit):
(WebKit::WebProcessProxy::didExceedBackgroundCPULimit):

  • UIProcess/WebProcessProxy.h:
  • UIProcess/WebProcessProxy.messages.in:
  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::initializeWebProcess):

2:54 PM Changeset in webkit [214319] by Yusuke Suzuki
  • 5 edits in trunk/Source/JavaScriptCore

[JSC] MachineThreads does not consider situation that one thread has multiple VMs
​https://bugs.webkit.org/show_bug.cgi?id=169819

Reviewed by Mark Lam.

The Linux port of PlatformThread suspend/resume mechanism relies on having a thread
specific singleton thread data, and was relying on MachineThreads::Thread to be this
thread specific singleton. But because MachineThreads::Thread is not a thread specific
singleton, we can get a deadlock in the GTK port's DatabaseProcess.

This patch fixes this issue by moving per thread data from MachineThreads::Thread to
MachineThreads::ThreadData, where there will only be one instance of
MachineThreads::ThreadData per thread. Each MachineThreads::Thread will now point to
the same MachineThreads::ThreadData for any given thread.

  • heap/MachineStackMarker.cpp:

(pthreadSignalHandlerSuspendResume):
(JSC::threadData):
(JSC::MachineThreads::Thread::Thread):
(JSC::MachineThreads::Thread::createForCurrentThread):
(JSC::MachineThreads::Thread::operator==):
(JSC::MachineThreads::ThreadData::ThreadData):
(JSC::MachineThreads::ThreadData::~ThreadData):
(JSC::MachineThreads::ThreadData::suspend):
(JSC::MachineThreads::ThreadData::resume):
(JSC::MachineThreads::ThreadData::getRegisters):
(JSC::MachineThreads::ThreadData::Registers::stackPointer):
(JSC::MachineThreads::ThreadData::Registers::framePointer):
(JSC::MachineThreads::ThreadData::Registers::instructionPointer):
(JSC::MachineThreads::ThreadData::Registers::llintPC):
(JSC::MachineThreads::ThreadData::freeRegisters):
(JSC::MachineThreads::ThreadData::captureStack):
(JSC::MachineThreads::tryCopyOtherThreadStacks):
(JSC::MachineThreads::Thread::~Thread): Deleted.
(JSC::MachineThreads::Thread::suspend): Deleted.
(JSC::MachineThreads::Thread::resume): Deleted.
(JSC::MachineThreads::Thread::getRegisters): Deleted.
(JSC::MachineThreads::Thread::Registers::stackPointer): Deleted.
(JSC::MachineThreads::Thread::Registers::framePointer): Deleted.
(JSC::MachineThreads::Thread::Registers::instructionPointer): Deleted.
(JSC::MachineThreads::Thread::Registers::llintPC): Deleted.
(JSC::MachineThreads::Thread::freeRegisters): Deleted.
(JSC::MachineThreads::Thread::captureStack): Deleted.

  • heap/MachineStackMarker.h:

(JSC::MachineThreads::Thread::operator!=):
(JSC::MachineThreads::Thread::suspend):
(JSC::MachineThreads::Thread::resume):
(JSC::MachineThreads::Thread::getRegisters):
(JSC::MachineThreads::Thread::freeRegisters):
(JSC::MachineThreads::Thread::captureStack):
(JSC::MachineThreads::Thread::platformThread):
(JSC::MachineThreads::Thread::stackBase):
(JSC::MachineThreads::Thread::stackEnd):

  • runtime/SamplingProfiler.cpp:

(JSC::FrameWalker::isValidFramePointer):

  • runtime/VMTraps.cpp:

(JSC::findActiveVMAndStackBounds):

2:45 PM Changeset in webkit [214318] by clopez@igalia.com
  • 2 edits in trunk/Tools

buildbot: Fix mixing of tabs and spaces after r214172
​https://bugs.webkit.org/show_bug.cgi?id=169793

Unreviewed.

  • BuildSlaveSupport/build.webkit.org-config/master.cfg:

(RunWebKitTests.evaluateCommand):

2:07 PM Changeset in webkit [214317] by commit-queue@webkit.org
  • 7 edits in trunk/Source/WebCore

Clean RTCPeerConnection.idl after bug 169978
​https://bugs.webkit.org/show_bug.cgi?id=169989

Patch by Youenn Fablet <​youenn@apple.com> on 2017-03-23
Reviewed by Eric Carlson.

No change of behavior.
Moving addTransceiver to overloaded method to union type to match spec.
Refactoring RTCRtpSender to take a String&&.

  • Modules/mediastream/MediaEndpointPeerConnection.cpp:

(WebCore::MediaEndpointPeerConnection::setRemoteDescriptionTask):

  • Modules/mediastream/RTCPeerConnection.cpp:

(WebCore::RTCPeerConnection::addTransceiver):
(WebCore::RTCPeerConnection::completeAddTransceiver):

  • Modules/mediastream/RTCPeerConnection.h:
  • Modules/mediastream/RTCPeerConnection.idl: Cosmetic changes except for addTransceiver.
  • Modules/mediastream/RTCRtpSender.cpp:

(WebCore::RTCRtpSender::create):
(WebCore::RTCRtpSender::RTCRtpSender):

  • Modules/mediastream/RTCRtpSender.h:
1:57 PM Changeset in webkit [214316] by Chris Dumez
  • 1 edit
    4 adds in trunk/LayoutTests

Add a test to make sure SVG animations are paused in detached iframes
​https://bugs.webkit.org/show_bug.cgi?id=170020

Reviewed by Antti Koivisto.

  • svg/animations/animations-paused-disconnected-iframe-expected.txt: Added.
  • svg/animations/animations-paused-disconnected-iframe.html: Added.
  • svg/animations/resources/frame-with-svg-animation.html: Added.
  • svg/animations/resources/grandchild-frame-with-svg-animation.html: Added.
1:56 PM Changeset in webkit [214315] by rniwa@webkit.org
  • 3 edits in trunk/Websites/perf.webkit.org

Share more code between ManifestGenerator and /api/triggerables
​https://bugs.webkit.org/show_bug.cgi?id=169993

Reviewed by Chris Dumez.

Shared the code to fetch the list of triggerables from the database between ManifestGenerator
and /api/triggerables.

  • public/api/triggerables.php:

(main):

  • public/include/manifest-generator.php:

(ManifestGenerator::fetch_triggerables): Extracted as a static function. Also include the ID
in the triggerable data.

1:54 PM Changeset in webkit [214314] by rniwa@webkit.org
  • 5 edits in trunk/Websites/perf.webkit.org

create-test-group should allow a different set of repositories to be used in each configuration
​https://bugs.webkit.org/show_bug.cgi?id=169992

Rubber-stamped by Antti Koivisto.

Added the support for new POST parameter, revisionSets, to /privileged-api/create-test-group.
This new parameter now specifies an array of repository id to revision dictionaries, and allows
different set of repositories' revisions to be specified in each dictionary.

We keep the old API for v2 UI and detect-changes.js compatibility for now.

  • public/privileged-api/create-test-group.php:

(main):
(commit_sets_from_revision_sets): Added.
(ensure_commit_sets): Only fetch the top-level repository per r213788 and r213976.

  • public/v3/models/test-group.js:

(TestGroup.createAndRefetchTestGroups): Use the newly added revisionSets parameter instead of
the now depreacted commitSets parameter.

  • public/v3/pages/analysis-task-page.js:

(AnalysisTaskPage.prototype._createTestGroupAfterVerifyingCommitSetList): Simplified this code
by simply verifying the consistency of commit sets now that createAndRefetchTestGroups takes
an array of commit sets instead of a dictionary of repository name to a list of revisions.

  • server-tests/privileged-api-create-test-group-tests.js: Added test cases for new parameter.
1:31 PM Changeset in webkit [214313] by mark.lam@apple.com
  • 10 edits
    1 add in trunk

Clients of JSArray::tryCreateForInitializationPrivate() should do their own null checks.
​https://bugs.webkit.org/show_bug.cgi?id=169783

Reviewed by Saam Barati.

JSTests:

  • stress/regress-169783.js: Added.

Source/JavaScriptCore:

Fixed clients of tryCreateForInitializationPrivate() to do a null check and throw
an OutOfMemoryError if allocation fails, or RELEASE_ASSERT that the allocation
succeeds.

  • dfg/DFGOperations.cpp:
  • ftl/FTLOperations.cpp:

(JSC::FTL::operationMaterializeObjectInOSR):

  • runtime/ArrayPrototype.cpp:

(JSC::arrayProtoFuncSplice):

  • runtime/CommonSlowPaths.cpp:

(JSC::SLOW_PATH_DECL):

  • runtime/JSArray.cpp:

(JSC::JSArray::tryCreateForInitializationPrivate):
(JSC::JSArray::fastSlice):

  • runtime/JSArray.h:

(JSC::constructArray):
(JSC::constructArrayNegativeIndexed):

  • runtime/RegExpMatchesArray.cpp:

(JSC::createEmptyRegExpMatchesArray):

  • runtime/RegExpMatchesArray.h:

(JSC::createRegExpMatchesArray):

1:20 PM Changeset in webkit [214312] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Add logging in case libwebrtc.dylib cannot be opened
​https://bugs.webkit.org/show_bug.cgi?id=170017

Patch by Youenn Fablet <​youenn@apple.com> on 2017-03-23
Reviewed by Geoffrey Garen.

No change of behavior.

  • platform/mediastream/libwebrtc/LibWebRTCProvider.cpp:

(WebCore::LibWebRTCProvider::webRTCAvailable):

12:56 PM Changeset in webkit [214311] by dbates@webkit.org
  • 3 edits in trunk/LayoutTests

REGRESSION (r214047): LayoutTest fast/events/pageshow-pagehide-on-back-cached-with-frames.html is a flaky failure
​https://bugs.webkit.org/show_bug.cgi?id=169834

Reviewed by Alexey Proskuryakov.

Ensure that the subframes are loaded in a consistent order between test runs.

Currently the test fast/events/pageshow-pagehide-on-back-cached-with-frames.html assumes
that subframes will load in tree order. This assumption is incorrect. Therefore, we need
to explicitly manage the loading of the subframes to ensure this invariant.

  • fast/events/pageshow-pagehide-on-back-cached-with-frames-expected.txt:
  • fast/events/pageshow-pagehide-on-back-cached-with-frames.html:
12:53 PM Changeset in webkit [214310] by jiewen_tan@apple.com
  • 2 edits in trunk/Source/WebCore

Unreviewed, a speculative build fix
<rdar://problem/31225378>

  • crypto/CommonCryptoUtilities.h:
12:06 PM Changeset in webkit [214309] by beidson@apple.com
  • 4 edits
    2 adds in trunk

WebSQL databases should not openable in private browsing.
<rdar://problem/30383335> and ​https://bugs.webkit.org/show_bug.cgi?id=170013

Reviewed by Alex Christensen.

Source/WebCore:

Test: storage/websql/private-browsing-open-disabled.html

  • Modules/webdatabase/DatabaseManager.cpp:

(WebCore::DatabaseManager::openDatabaseBackend):
(WebCore::DatabaseManager::tryToOpenDatabaseBackend): Throw an exception if in private browsing.

  • Modules/webdatabase/DatabaseManager.h:

LayoutTests:

  • storage/websql/private-browsing-open-disabled-expected.txt: Added.
  • storage/websql/private-browsing-open-disabled.html: Added.
11:47 AM Changeset in webkit [214308] by Nikita Vasilyev
  • 3 edits in trunk/Source/WebInspectorUI

Web Inspector: Editing local storage keys/values starts with truncated strings
​https://bugs.webkit.org/show_bug.cgi?id=169896

Reviewed by Brian Burg.

  • UserInterface/Views/DataGrid.css:

(.data-grid td.editing > div):

  • UserInterface/Views/DataGrid.js:

(WebInspector.DataGrid.prototype._editingCancelled):
div.cell-content is removed because the <td> itself is contenteditable (using -webkit-user-modify:read-write-plaintext-only),
not the inner div.cell-content. Re-create div.cell-content after commiting (by pressing Enter) or canceling (by pressing Esc)
since it may get removed while editing.

11:45 AM Changeset in webkit [214307] by Ryan Haddad
  • 2 edits in trunk/LayoutTests

Remove pass expectation for fast/forms/range/range-remove-on-drag.html as it relies on touch events.

Unreviewed test gardening.

  • platform/ios-simulator-wk2/TestExpectations:
11:22 AM Changeset in webkit [214306] by clopez@igalia.com
  • 2 edits in trunk/LayoutTests

[GTK] Mark compositing and css3/blending tests asserting on debug builds.

Unreviewed test gardening.

  • platform/gtk/TestExpectations:
11:15 AM Changeset in webkit [214305] by dino@apple.com
  • 2 edits in trunk/Source/WebCore

NeverDestroyed<MediaQueryEvaluator> must explicitly construct with a String
​https://bugs.webkit.org/show_bug.cgi?id=169987
<rdar://problem/31211087>

Reviewed by Alex Christensen.

CSSDefaultStyleSheets creates a static MediaQueryEvaluator, but thanks
to the template magic of NeverDestroyed, it was converting the char*
argument into a bool, and calling the wrong constructor.

Unfortunately this is difficult to test because it only affects
the default UA style sheets, and they currently don't have
and @media rules (which would always evaluate to true given
the bug). I don't want to put in a useless rule just to check
if the bug is fixed. When one is added for bug 168447, this change
will be exercised.

  • css/CSSDefaultStyleSheets.cpp: Explicitly construct with a String

rather than a char*.
(WebCore::screenEval):
(WebCore::printEval):

9:13 AM Changeset in webkit [214304] by jmarcell@apple.com
  • 7 edits in trunk/Source

Versioning.

9:03 AM Changeset in webkit [214303] by jmarcell@apple.com
  • 1 copy in tags/Safari-604.1.14

Tag Safari-604.1.14.

8:54 AM Changeset in webkit [214302] by eric.carlson@apple.com
  • 7 edits in trunk/Source/WebCore

[MediaStream] Make mock video source work on iOS
​https://bugs.webkit.org/show_bug.cgi?id=169923

Reviewed by Youenn Fablet.

Generate IOSurface-backed CVPixelBuffers. Allocate them from a
CVPixelBufferPool for efficiency.

No new tests, no functional change.

  • platform/cocoa/CoreVideoSoftLink.cpp:
  • platform/cocoa/CoreVideoSoftLink.h:
  • platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.mm:

(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::videoTransformationMatrix):

  • platform/mediastream/mac/MockRealtimeVideoSourceMac.h:
  • platform/mediastream/mac/MockRealtimeVideoSourceMac.mm:

(WebCore::MockRealtimeVideoSourceMac::pixelBufferFromCGImage):
(WebCore::MockRealtimeVideoSourceMac::applySize):

  • platform/mock/MockRealtimeVideoSource.h:
4:37 AM WebKitGTK/2.16.x edited by sergio@webkit.org
(diff)
4:33 AM Changeset in webkit [214301] by timothy_horton@apple.com
  • 2 edits in trunk/Source/WebKit2

Test DataDetectors supported schemes in lowercase
​https://bugs.webkit.org/show_bug.cgi?id=169994
<rdar://problem/30788920>

Reviewed by Wenson Hsieh.

  • UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView _actionForLongPress]):
(-[WKContentView _interactionShouldBeginFromPreviewItemController:forPosition:]):
Lower-case the scheme before looking in tapAndHoldSchemes, which is
guaranteed to be in lower-case. WebCore already does this in places
that it confers with tapAndHoldSchemes.

4:30 AM WebKitGTK/2.16.x edited by sergio@webkit.org
(diff)
2:25 AM Changeset in webkit [214300] by commit-queue@webkit.org
  • 3 edits in trunk/Source/JavaScriptCore

[jsc] Add MacroAssemblerMIPS::storeFence()
​https://bugs.webkit.org/show_bug.cgi?id=169705

Patch by Guillaume Emont <​guijemont@igalia.com> on 2017-03-23
Reviewed by Yusuke Suzuki.

There doesn't seem to be anything more fine grained than "sync" that
guarantees that all memory operations following it are going to happen
after all stores before it, so we just use sync.

  • assembler/MIPSAssembler.h:

(JSC::MIPSAssembler::sync): Added a FIXME about SYNC_MB.

  • assembler/MacroAssemblerMIPS.h:

(JSC::MacroAssemblerMIPS::storeFence): Added.

2:10 AM Changeset in webkit [214299] by tpopela@redhat.com
  • 7 edits in trunk/Source/WTF

Fix uninitialized public members in WTF
​https://bugs.webkit.org/show_bug.cgi?id=169676

Reviewed by Michael Catanzaro.

Found by Coverity scan.

  • wtf/Bag.h:
  • wtf/HashTable.h:
  • wtf/HashTraits.h:
  • wtf/Insertion.h:
  • wtf/OrderMaker.h:
  • wtf/ParallelJobsGeneric.h:
12:38 AM Changeset in webkit [214298] by Carlos Garcia Campos
  • 2 edits in trunk/LayoutTests

Unreviewed GTK+ gardening. Mark webrtc/connection-state.html as failing.

  • platform/gtk/TestExpectations:
Note: See TracTimeline for information about the timeline view.