⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Apr 2, 2017:

11:51 PM Changeset in webkit [214733] by Carlos Garcia Campos
  • 7 edits in releases/WebKitGTK/webkit-2.16

Merge r213850 - [JSC] It should be possible create a label named let when parsing Statement in non strict mode
​https://bugs.webkit.org/show_bug.cgi?id=168684

Patch by Caio Lima <Caio Lima> on 2017-03-13
Reviewed by Saam Barati.

JSTests:

  • ChakraCore/test/LetConst/DeclOutofBlock.baseline-jsc:

Source/JavaScriptCore:

This patch is fixing a Parser bug to allow define a label named
let in sloppy mode when parsing a Statement.

  • parser/Parser.cpp:

(JSC::Parser<LexerType>::parseStatement):

LayoutTests:

  • js/let-syntax-expected.txt:
  • js/script-tests/let-syntax.js:

(shouldNotHaveSyntaxErrorSloopyOnly):

10:41 PM Changeset in webkit [214732] by Carlos Garcia Campos
  • 3 edits in trunk/Source/JavaScriptCore

Share implementation of JSRunLoopTimer::timerDidFire
​https://bugs.webkit.org/show_bug.cgi?id=170392

Reviewed by Michael Catanzaro.

The code is cross-platform but it's duplicated in CF and GLib implementations, it could be shared instead.

  • runtime/JSRunLoopTimer.cpp:

(JSC::JSRunLoopTimer::timerDidFire): Move common implementation here.
(JSC::JSRunLoopTimer::setRunLoop): Use timerDidFireCallback.
(JSC::JSRunLoopTimer::timerDidFireCallback): Call JSRunLoopTimer::timerDidFire().

  • runtime/JSRunLoopTimer.h:
8:30 PM Changeset in webkit [214731] by ap@apple.com
  • 2 edits in trunk/LayoutTests

Remove accidentally added DumpJSConsoleLogInStdErr from http/tests/fetch/fetch-in-worker-crash.html expectation.

8:13 PM Changeset in webkit [214730] by ap@apple.com
  • 4 edits in trunk

Build fix for
Add missing text styles
​https://bugs.webkit.org/show_bug.cgi?id=170295

Source/WebCore:

  • rendering/RenderThemeIOS.mm:

(WebCore::RenderThemeIOS::cachedSystemFontDescription):
(WebCore::RenderThemeIOS::updateCachedSystemFontDescription):

LayoutTests:

  • platform/ios/ios/fast/text/opticalFontWithTextStyle-expected.txt:
7:50 PM Changeset in webkit [214729] by jmarcell@apple.com
  • 2 edits in branches/safari-603-branch/Source/WebKit2

Cherry-pick r214559. rdar://problem/31371683

6:26 PM Changeset in webkit [214728] by ap@apple.com
  • 6 edits in trunk/LayoutTests

Fix lint errors.

  • TestExpectations:
  • platform/ios-wk1/TestExpectations:
  • platform/ios-wk2/TestExpectations:
  • platform/ios/TestExpectations:
  • platform/mac-wk1/TestExpectations:
11:55 AM Changeset in webkit [214727] by ap@apple.com
  • 2 edits in trunk/LayoutTests

Mark http/tests/fetch/fetch-in-worker-crash.html and imported/w3c/web-platform-tests/fetch/api/cors/cors-preflight-status.html as flaky.

For ​https://bugs.webkit.org/show_bug.cgi?id=170395
rdar://problem/30975761, rdar://problem/31394017

Apr 1, 2017:

10:39 PM Changeset in webkit [214726] by Alan Bujtas
  • 2 edits in trunk/Source/WebCore

Long Arabic text in ContentEditable with css white-space=pre hangs Safari
​https://bugs.webkit.org/show_bug.cgi?id=170245

Reviewed by Myles C. Maxfield.

While searching for mid-word break, we measure the text by codepoints in a loop until the accumulated width > available width.
When we see that the accumulated width for the individual codepoints overflows, we join the codepoints and re-measure them.
These 2 widths could be considerably different for number of reasons (ligatures is a prime example). When we figure that
the run still fits, we go back to the main loop (since we are not supposed to wrap the line here) and take the next codepoint.
However this time we start the measurement from the last whitespace, so we end up remeasuring a potentially long chuck of text
until we hit the wrapping point. This is way too expensive.
This patch changes the logic so that we just go back to measuring individual codepoints until we hit the constrain again.

Covered by existing tests.

  • rendering/line/BreakingContext.h:

(WebCore::BreakingContext::handleText): canUseSimpleFontCodePath() is just to mitigate the potential risk of regression and
complex text is more likely to fall into this category.

10:28 PM Changeset in webkit [214725] by pvollan@apple.com
  • 1 edit
    2 adds in trunk/LayoutTests

Add test for expected fallback behavior between stroke-width and -webkit-text-stroke-width.
​https://bugs.webkit.org/show_bug.cgi?id=169466

Reviewed by Jon Lee.

Now that we have added support for stroke-width, we should have a test for expected fallback behavior between
stroke-width and -webkit-text-stroke-width. Currently, stroke-width is always preferred, also when inherited,
and when -webkit-text-stroke-width is declared inline. When stroke-width is not specified, we fall back to
-webkit-text-stroke-width.

  • fast/css/stroke-width-fallback-expected.html: Added.
  • fast/css/stroke-width-fallback.html: Added.
10:28 PM Changeset in webkit [214724] by jonlee@apple.com
  • 9 edits in trunk

Add missing text styles
​https://bugs.webkit.org/show_bug.cgi?id=170295
rdar://problem/30219503

Reviewed by Dean Jackson.

Source/WebCore:

Updated existing test to include new text styles.

  • css/CSSValueKeywords.in: Add title0 and title4.
  • platform/spi/cocoa/CoreTextSPI.h:
  • rendering/RenderThemeIOS.mm:

(WebCore::RenderThemeIOS::cachedSystemFontDescription):
(WebCore::RenderThemeIOS::updateCachedSystemFontDescription):

Source/WebInspectorUI:

  • UserInterface/Models/CSSKeywordCompletions.js: Update keyword completions

LayoutTests:

  • platform/ios/ios/fast/text/opticalFontWithTextStyle.html: Update test to include title0 and title4.
9:53 PM Changeset in webkit [214723] by mitz@apple.com
  • 5 edits in trunk/Source

[iOS] <input type=file> label should be specified using plural rules
​https://bugs.webkit.org/show_bug.cgi?id=170388

Reviewed by Alexey Proskuryakov.

Source/WebCore:

  • English.lproj/Localizable.strings: Updated using update-webkit-localizable-strings.
  • English.lproj/Localizable.stringsdict: Added an entry for the new key "%lu photo(s) and %lu video(s)", with plural rules covering all the different combinations in English. Other localizations may specify additional combinations as needed.

Source/WebKit2:

  • UIProcess/ios/forms/WKFileUploadPanel.mm:

(-[WKFileUploadPanel _processMediaInfoDictionaries:atIndex:processedResults:processedImageCount:processedVideoCount:successBlock:failureBlock:]):

Instead of calling -_displayStringForPhotos:videos:, use
+[NSString localizedStringWithFormat:] with the new format string "%lu photo(s) and
%lu video(s)" for which there are plural rules.

(-[WKFileUploadPanel _displayStringForPhotos:videos:]): Deleted.

6:56 PM Changeset in webkit [214722] by ap@apple.com
  • 4 edits in trunk

Rolling back <​https://trac.webkit.org/r214697>, as it made WebKit2.DataDetectionReferenceDate time out.

Was REGRESSION (r202472): Data Detection overwrites existing links in detected ranges
​https://bugs.webkit.org/show_bug.cgi?id=170365

Source/WebCore:

  • editing/cocoa/DataDetection.mm:

(WebCore::searchForLinkRemovingExistingDDLinks):

Tools:

  • TestWebKitAPI/Tests/WebKit2Cocoa/DataDetection.mm:
5:55 PM Changeset in webkit [214721] by Chris Dumez
  • 10 edits
    3 adds in trunk

We should pause silent WebAudio rendering in background tabs
​https://bugs.webkit.org/show_bug.cgi?id=170299
<rdar://problem/31289132>

Reviewed by Eric Carlson.

Source/WebCore:

We should pause silent WebAudio rendering in background tabs since it uses CPU and is
not observable by the user. Such silent WebAudio rendering seems to be used by
doubleclick ads.

Test: webaudio/silent-audio-interrupted-in-background.html

  • Modules/webaudio/AudioContext.cpp:

(WebCore::AudioContext::lazyInitialize):
(WebCore::AudioContext::uninitialize):
Have AudioContext register / unregister itself with the Document to get
visibility change notifications, similarly to what HTMLMediaElement was
already doing.

(WebCore::AudioContext::visibilityStateChanged):
Begin / End session interruption whenever the page visiblity changes.

  • Modules/webaudio/AudioContext.h:
  • WebCore.xcodeproj/project.pbxproj:
  • dom/Document.cpp:

(WebCore::Document::registerForVisibilityStateChangedCallbacks):
(WebCore::Document::unregisterForVisibilityStateChangedCallbacks):
(WebCore::Document::visibilityStateChanged):

  • dom/Document.h:
  • dom/Element.h:
  • dom/VisibilityChangeClient.h: Added.

(WebCore::VisibilityChangeClient::~VisibilityChangeClient):

  • html/HTMLMediaElement.h:

Introduce a new VisibilityChangeClient interface and have both AudioContext
and HTMLMediaElement subclass it. Previously, the visibilityStateChanged()
function was on Element but this prevented AudioContext from registering
itself since AudioContext is not an Element.

LayoutTests:

Add layout test coverage.

  • webaudio/silent-audio-interrupted-in-background-expected.txt: Added.
  • webaudio/silent-audio-interrupted-in-background.html: Added.
5:17 PM Changeset in webkit [214720] by mitz@apple.com
  • 4 edits in trunk/Source/WebCore

[Cocoa] A couple of UI strings use three periods instead of an ellipsis
​https://bugs.webkit.org/show_bug.cgi?id=170386

Reviewed by Tim Horton.

  • English.lproj/Localizable.strings: Updated using update-webkit-localizable-strings.
  • platform/LocalizedStrings.cpp:

(WebCore::mediaElementLoadingStateText): Changed "Loading..." to "Loading…".

  • platform/cocoa/LocalizedStringsCocoa.mm:

(WebCore::contextMenuItemTagStyles): Changed "Styles..." to "Styles…".

5:03 PM Changeset in webkit [214719] by mitz@apple.com
  • 4 edits in trunk/Source

Localizable strings files are out of date
​https://bugs.webkit.org/show_bug.cgi?id=170383

Reviewed by Tim Horton.

Ran update-webkit-localizable-strings.

Source/WebCore:

  • English.lproj/Localizable.strings:

Source/WebInspectorUI:

  • Localizations/en.lproj/localizedStrings.js:
3:57 PM Changeset in webkit [214718] by mitz@apple.com
  • 5 edits in trunk/Source

[Xcode] In engineering builds, linker warns about libwebrtc.dylib’s install name being invalid
​https://bugs.webkit.org/show_bug.cgi?id=170385

Reviewed by Tim Horton.

Source/WebCore:

  • Configurations/DebugRelease.xcconfig: Set WK_RELOCATABLE_FRAMEWORKS to YES like we do in some other projects’ DebugRelease.xcconfig. Engineering builds are always relocatable.
  • Configurations/WebCore.xcconfig: When WebCore is relocatable, tell the linker that it’s not going to be in the shared cache, even if its install name implies that it might be.

Source/WebKit2:

  • Configurations/WebKit.xcconfig: When WebKit is relocatable, tell the linker that it’s not going to be in the shared cache, even if its install name implies that it might be.
5:48 AM Changeset in webkit [214717] by Csaba Osztrogonác
  • 2 edits in trunk/Tools

Mac cmake buildfix after 214586.
​https://bugs.webkit.org/show_bug.cgi?id=170381

Unreviewed speculative buildfix.

  • WebKitTestRunner/PlatformMac.cmake:
5:35 AM Changeset in webkit [214716] by Csaba Osztrogonác
  • 2 edits in trunk/Source/WTF

Mac cmake buildfix after 214586.
​https://bugs.webkit.org/show_bug.cgi?id=170381

Unreviewed.

  • wtf/BlockPtr.h:
3:25 AM Changeset in webkit [214715] by Csaba Osztrogonác
  • 2 edits in trunk/Tools

Unreviewed speculative Mac cmake buildfix after r214586, just for fun.
​https://bugs.webkit.org/show_bug.cgi?id=161675

  • WebKitTestRunner/PlatformMac.cmake:
1:14 AM Changeset in webkit [214714] by gskachkov@gmail.com
  • 3 edits
    1 add in trunk

Object with numerical keys with gaps gets filled by NaN values
​https://bugs.webkit.org/show_bug.cgi?id=164412

Reviewed by Mark Lam.

This patch fixes issue when object have two properties
with name as number. The issue appears when during invoking
convertDoubleToArrayStorage, array is filled by pNaN and
method converting it to real NaN. This happeneds because a
pNaN in a Double array is a hole, and Double arrays cannot
have NaN values. To fix issue we need to check value and
clear it if it pNaN.

Source/JavaScriptCore:

  • runtime/JSObject.cpp:

(JSC::JSObject::convertDoubleToArrayStorage):

JSTests:

  • stress/object-number-properties.js: Added.
12:47 AM Changeset in webkit [214713] by ap@apple.com
  • 12 edits in trunk

Rolling back ​http://trac.webkit.org/r214663 - memory corruption

Source/WebCore:

  • Modules/streams/ReadableByteStreamInternals.js:

(cloneArrayBuffer):

  • bindings/js/JSDOMGlobalObject.cpp:

(WebCore::JSDOMGlobalObject::addBuiltinGlobals):

  • bindings/js/StructuredClone.cpp:

(WebCore::structuredCloneArrayBuffer):
(WebCore::cloneArrayBufferImpl): Deleted.
(WebCore::cloneArrayBuffer): Deleted.

  • bindings/js/StructuredClone.h:
  • bindings/js/WebCoreBuiltinNames.h:
  • testing/Internals.cpp:

(WebCore::markerTypeFrom):
(WebCore::Internals::resetToConsistentState):
(WebCore::Internals::isLoadingFromMemoryCache):
(WebCore::Internals::setImageFrameDecodingDuration):
(WebCore::deferredStyleRulesCountForList):
(WebCore::deferredGroupRulesCountForList):
(WebCore::deferredKeyframesRulesCountForList):
(WebCore::Internals::eventThrottlingBehaviorOverride):
(WebCore::Internals::enableMockSpeechSynthesizer):
(WebCore::Internals::rangeForDictionaryLookupAtLocation):
(WebCore::Internals::nodesFromRect):
(WebCore::Internals::layerIDForElement):
(WebCore::Internals::setElementUsesDisplayListDrawing):
(WebCore::Internals::setElementTracksDisplayListReplay):
(WebCore::Internals::styleRecalcCount):
(WebCore::Internals::compositingUpdateCount):
(WebCore::Internals::setCaptionDisplayMode):
(WebCore::Internals::endMediaSessionInterruption):
(WebCore::Internals::postRemoteControlCommand):
(WebCore::appendOffsets):
(WebCore::Internals::scrollSnapOffsets):
(WebCore::Internals::setShowAllPlugins):
(WebCore::Internals::cloneArrayBuffer): Deleted.

  • testing/Internals.h:
  • testing/Internals.idl:

LayoutTests:

  • streams/readable-stream-byob-request-expected.txt:
  • streams/readable-stream-byob-request.js:

(self.importScripts.test): Deleted.

Note: See TracTimeline for information about the timeline view.