Timeline

Apr 20, 2017:

11:08 PM Changeset in webkit [215606] by Konstantin Tokarev

• 29 edits in trunk

[cmake] Define FORWARDING_HEADERS_DIR in WebKitFS and use it everywhere
​https://bugs.webkit.org/show_bug.cgi?id=171071

Reviewed by Michael Catanzaro.

"${DERIVED_SOURCES_DIR}/ForwardingHeaders" path occurs very often in the
build system files. GTK-specifc FORWARDING_HEADERS_DIR variable should
be available for all ports.

.:

• Source/cmake/OptionsGTK.cmake:
• Source/cmake/WebKitFS.cmake:
• Source/cmake/WebKitMacros.cmake:

Source/JavaScriptCore:

• CMakeLists.txt:
• PlatformWin.cmake:

Source/ThirdParty/ANGLE:

• CMakeLists.txt:

Source/WebCore:

• CMakeLists.txt:
• PlatformMac.cmake:
• PlatformWin.cmake:
• PlatformWinCairo.cmake:

Source/WebKit:

• CMakeLists.txt:
• PlatformMac.cmake:
• PlatformWin.cmake:

Source/WebKit2:

• CMakeLists.txt:
• PlatformMac.cmake:

Tools:

• DumpRenderTree/PlatformMac.cmake:
• MiniBrowser/mac/CMakeLists.txt:
• MiniBrowser/win/CMakeLists.txt:
• TestWebKitAPI/PlatformJSCOnly.cmake:
• TestWebKitAPI/PlatformMac.cmake:
• TestWebKitAPI/PlatformWin.cmake:
• WebKitTestRunner/PlatformMac.cmake:

11:04 PM Changeset in webkit [215605] by commit-queue@webkit.org

• 14 edits
  3 deletes in trunk

Unreviewed, rolling out r215597.
​https://bugs.webkit.org/show_bug.cgi?id=171102

Made all tests crash under GuardMalloc (Requested by ap on
#webkit).

Reverted changeset:

"Expose obscured insets to web content (as "safe area
insets")"
​https://bugs.webkit.org/show_bug.cgi?id=171013
​http://trac.webkit.org/changeset/215597

10:36 PM Changeset in webkit [215604] by dino@apple.com

• 1 edit in trunk/Source/WebCore/features.json

Fix typo

10:34 PM Changeset in webkit [215603] by dino@apple.com

• 2 edits in trunk/Source/WebCore

Add Web Sharing to the features under consideration.

• features.json:

10:20 PM Changeset in webkit [215602] by dino@apple.com

• 2 edits in trunk/Source/WebCore

Add Scroll Anchoring to features under consideration.

• features.json:

8:38 PM Changeset in webkit [215601] by Konstantin Tokarev

• 8 edits in trunk/Source

Remove unused lamda captures
​https://bugs.webkit.org/show_bug.cgi?id=171098

Reviewed by Yusuke Suzuki.

Source/JavaScriptCore:

• bytecompiler/NodesCodegen.cpp:

(JSC::ArrayNode::emitBytecode):

• ftl/FTLState.cpp:

(JSC::FTL::State::State):

• wasm/WasmB3IRGenerator.cpp:

Source/WebCore:

• Modules/indexeddb/server/SQLiteIDBBackingStore.cpp:

(WebCore::IDBServer::SQLiteIDBBackingStore::getOrEstablishDatabaseInfo):

• Modules/indexeddb/server/UniqueIDBDatabase.cpp:

(WebCore::IDBServer::UniqueIDBDatabase::activateTransactionInBackingStore):

• loader/ResourceLoadStatisticsStore.cpp:

(WebCore::ResourceLoadStatisticsStore::createEncoderFromData):
(WebCore::ResourceLoadStatisticsStore::readDataFromDecoder):

7:08 PM Changeset in webkit [215600] by Yusuke Suzuki

• 6 edits
  1 add in trunk

[JSC][FTL] FTL should support Arrayify
​https://bugs.webkit.org/show_bug.cgi?id=169596

Reviewed by Saam Barati.

JSTests:

• stress/arrayify.js: Added.

(arrayifyInt32):
(arrayifyDouble):
(arrayifyContiguous):

Source/JavaScriptCore:

This patch simply expands the coverage of FTL by supporting Arrayify.
While ArrayifyToStructure is already supported, Arrayify is not supported
in FTL. While supporting Arrayify in FTL itself does not offer so much
performance difference from DFG's one, no FTL support for Arrayify
prevents us applying FTL to the code including Arrayify.

• dfg/DFGArrayMode.cpp:

(JSC::DFG::toIndexingShape):

• dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::jumpSlowForUnwantedArrayMode):

• ftl/FTLCapabilities.cpp:

(JSC::FTL::canCompile):

• ftl/FTLLowerDFGToB3.cpp:

(JSC::FTL::DFG::LowerDFGToB3::compileNode):
(JSC::FTL::DFG::LowerDFGToB3::compileArrayify):
(JSC::FTL::DFG::LowerDFGToB3::compileCheckArray):
(JSC::FTL::DFG::LowerDFGToB3::isArrayTypeForArrayify):
(JSC::FTL::DFG::LowerDFGToB3::isArrayTypeForCheckArray):
(JSC::FTL::DFG::LowerDFGToB3::compileArrayifyToStructure): Deleted.
(JSC::FTL::DFG::LowerDFGToB3::isArrayType): Deleted.

6:49 PM Changeset in webkit [215599] by Joseph Pecoraro

• 3 edits in trunk/Tools

Test262 bot does not go red with failures
​https://bugs.webkit.org/show_bug.cgi?id=171044

Reviewed by Aakash Jain.

The piped output of run-jsc-stress-tests is different from
its non-piped output. Switch to parsing the correct output.

• BuildSlaveSupport/build.webkit.org-config/master.cfg:

(RunTest262Tests.countFailures):
Just count the number of lines that start with "FAIL:".

• BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:

(RunTest262TestsTest.test_no_regressions_output):
(test_failure_output):
(test_failures_output):
Updated tests with new sample output produced partially from bots and
locally. In cases of failure the return code of run-jsc-stress-tests
is still 0 so update the expected return code in the tests.

6:02 PM Changeset in webkit [215598] by beidson@apple.com

• 5 edits in trunk

WebContent process becomes unresponsive after returning nil from async version of -webView:createWebViewWithConfiguration:...
<rdar://problem/31739023> and ​https://bugs.webkit.org/show_bug.cgi?id=171090

Reviewed by Andy Estes.

Source/WebKit2:

• UIProcess/Cocoa/UIDelegate.mm:

(WebKit::UIDelegate::UIClient::createNewPageCommon): Handle the perfectly valid "nil webView" case correctly.

Tools:

• TestWebKitAPI/Tests/WebKit2/open-and-close-window.html:
• TestWebKitAPI/Tests/WebKit2Cocoa/OpenAndCloseWindow.mm:

(resetToConsistentState):
(-[OpenAndCloseWindowUIDelegate webViewDidClose:]):
(-[OpenAndCloseWindowUIDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
(TEST):
(-[OpenAndCloseWindowUIDelegateAsync _webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:completionHandler:]):

6:00 PM Changeset in webkit [215597] by timothy_horton@apple.com

• 14 edits
  12 adds in trunk

Expose obscured insets to web content (as "safe area insets")
​https://bugs.webkit.org/show_bug.cgi?id=171013
<rdar://problem/31564652>

Reviewed by Wenson Hsieh and Dave Hyatt.

Tests: fast/css/variables/constants/invalid-constant-name-fallback.html

fast/css/variables/constants/ios/safe-area-inset-set.html
fast/css/variables/constants/safe-area-inset-cannot-override.html
fast/css/variables/constants/safe-area-inset-zero.html

• CMakeLists.txt:
• WebCore.xcodeproj/project.pbxproj:
• css/CSSValueKeywords.in:
• css/CSSVariableData.cpp:

(WebCore::CSSVariableData::checkVariablesForCyclesWithRange):
(WebCore::CSSVariableData::resolveTokenRange):

• css/parser/CSSVariableParser.cpp:

(WebCore::isValidConstantName):
(WebCore::classifyBlock):
(WebCore::isValidConstantReference):
Add a constant() function, which takes both custom properties and
arbitrary idents which are looked up in ConstantPropertyMap, allowing
fallback from the arbitrary, UA-defined idents to custom properties.

• dom/ConstantPropertyMap.cpp: Added.

(WebCore::ConstantPropertyMap::ConstantPropertyMap):
(WebCore::ConstantPropertyMap::values):
(WebCore::ConstantPropertyMap::nameForProperty):
(WebCore::ConstantPropertyMap::setValueForProperty):
(WebCore::ConstantPropertyMap::buildValues):
(WebCore::variableDataForSafeAreaInset):
(WebCore::ConstantPropertyMap::didChangeObscuredInsets):

• dom/ConstantPropertyMap.h: Added.

Keep a mapping of UA-defined "constants", which can be looked up
from CSS via the aforementioned function. For now, this mapping
includes only safe-area-inset-{top, right, bottom, left}, which
expose the obscured insets (now that they can be painted into via
the viewport parameter clip-to-safe-area-inset=no).

• dom/Document.cpp:

(WebCore::Document::Document):
(WebCore::Document::didChangeObscuredInsets):

• dom/Document.h:

(WebCore::Document::constantProperties):

• page/Page.cpp:

(WebCore::Page::setObscuredInsets):

• page/Page.h:

(WebCore::Page::setObscuredInsets): Deleted.
Make setObscuredInsets and related storage not iOS-specific, though
nothing from the other platforms yet calls this code.

• style/StyleResolveForDocument.cpp:

(WebCore::Style::resolveForDocument):
Grab the constant properties from ConstantPropertyMap and plop them into
the CustomPropertyValueMap. Constant properties aren't allowed to start
with --, and variable properties must, so there is no opportunity here
for exposing things to var() (or allowing custom properties to override
UA-defined constant properties).

• TestExpectations:
• fast/css/variables/constants/invalid-constant-name-fallback-expected.html: Added.
• fast/css/variables/constants/invalid-constant-name-fallback.html: Added.
• fast/css/variables/constants/ios/safe-area-inset-set-expected.html: Added.
• fast/css/variables/constants/ios/safe-area-inset-set.html: Added.
• fast/css/variables/constants/safe-area-inset-cannot-override-expected.html: Added.
• fast/css/variables/constants/safe-area-inset-cannot-override.html: Added.
• fast/css/variables/constants/safe-area-inset-zero-expected.html: Added.
• fast/css/variables/constants/safe-area-inset-zero.html: Added.
• platform/ios-wk2/TestExpectations:

5:30 PM Changeset in webkit [215596] by mark.lam@apple.com

• 3 edits
  1 add in trunk

virtualThunkFor() needs to materialize its of tagMaskRegister for tail calls.
​https://bugs.webkit.org/show_bug.cgi?id=171079
<rdar://problem/31684756>

Reviewed by Saam Barati.

JSTests:

• stress/regress-171079.js: Added.

Source/JavaScriptCore:

This is needed because tail calls would restore callee saved registers (and
therefore, potentially clobber the tag registers) before jumping to the thunk.

• jit/ThunkGenerators.cpp:

(JSC::virtualThunkFor):

5:20 PM Changeset in webkit [215595] by mark.lam@apple.com

• 2 edits in trunk/Source/JavaScriptCore

Build fix after r215592.
​https://bugs.webkit.org/show_bug.cgi?id=171088

Not reviewed.

• assembler/MacroAssemblerPrinter.h:

5:00 PM Changeset in webkit [215594] by Wenson Hsieh

• 2 edits in trunk/Tools

[ios-simulator] PositionInformationTests API tests are timing out
​https://bugs.webkit.org/show_bug.cgi?id=171089

Rubber-stamped by Tim Horton.

Addresses failures observed in the new position information tests added in r215573 by only running them if the
DATA_INTERACTION feature flag is enabled.

• TestWebKitAPI/Tests/ios/PositionInformationTests.mm:

4:55 PM Changeset in webkit [215593] by jmarcell@apple.com

• 2 edits in tags/Safari-604.1.18/Source/ThirdParty/ANGLE

Cherry-pick r215527. rdar://problem/31714717

4:55 PM Changeset in webkit [215592] by mark.lam@apple.com

• 14 edits in trunk/Source/JavaScriptCore

Update the MASM probe to only take 1 arg instead of 2 (in addition to the callback function).
​https://bugs.webkit.org/show_bug.cgi?id=171088

Reviewed by Michael Saboff and Saam Barati.

Experience shows that we never use the 2nd arg. So, let's remove it to reduce
the footprint at each probe site.

Also fix the MacroAssembler::print() function so that it is a no-op when
!ENABLE(MASM_PROBE). This will allow us to have print() statements in JIT code
without a lot of #if ENABLE(MASM_PROBE)s later.

• assembler/AbstractMacroAssembler.h:
• assembler/MacroAssembler.cpp:

(JSC::stdFunctionCallback):
(JSC::MacroAssembler::probe):

• assembler/MacroAssembler.h:
• assembler/MacroAssemblerARM.cpp:

(JSC::MacroAssemblerARM::probe):

• assembler/MacroAssemblerARM.h:
• assembler/MacroAssemblerARM64.cpp:

(JSC::MacroAssemblerARM64::probe):

• assembler/MacroAssemblerARM64.h:
• assembler/MacroAssemblerARMv7.cpp:

(JSC::MacroAssemblerARMv7::probe):

• assembler/MacroAssemblerARMv7.h:
• assembler/MacroAssemblerPrinter.cpp:

(JSC::MacroAssemblerPrinter::printCallback):

• assembler/MacroAssemblerPrinter.h:

(JSC::MacroAssemblerPrinter::print):
(JSC::MacroAssembler::print):

• assembler/MacroAssemblerX86Common.cpp:

(JSC::MacroAssemblerX86Common::probe):

• assembler/MacroAssemblerX86Common.h:

4:53 PM Changeset in webkit [215591] by Ryan Haddad

• 2 edits in trunk/LayoutTests

Mark media/modern-media-controls/tracks-support/tracks-support-click-track-in-panel.html as flaky.
​https://bugs.webkit.org/show_bug.cgi?id=169109

Unreviewed test gardening.

• platform/mac/TestExpectations:

4:53 PM Changeset in webkit [215590] by Ryan Haddad

• 2 edits in trunk/LayoutTests

Mark imported/w3c/web-platform-tests/WebCryptoAPI/sign_verify/ecdsa.worker.html as flaky.
​https://bugs.webkit.org/show_bug.cgi?id=170921

Unreviewed test gardening.

• TestExpectations:

4:50 PM Changeset in webkit [215589] by mitz@apple.com

• 2 edits in trunk/Source/WebKit2

Disable header postprocessing when building for Sierra

Absolutely rubber-stamped by Anders Carlsson.

• Configurations/WebKit.xcconfig:

4:49 PM Changeset in webkit [215588] by andersca@apple.com

• 2 edits in trunk/Source/WebCore

Remove one use of toPaymentAuthorizationStatus
​https://bugs.webkit.org/show_bug.cgi?id=171086

Reviewed by Tim Horton.

Just switch on the individual ApplePaySession::STATUS_ values.

• Modules/applepay/ApplePaySession.cpp:

(WebCore::ApplePaySession::completeShippingMethodSelection):

4:42 PM Changeset in webkit [215587] by mrajca@apple.com

• 9 edits
  1 add in trunk

Cocoa: add private API for suppressing first responder changes
​https://bugs.webkit.org/show_bug.cgi?id=171069
<rdar://problem/31658967>

Reviewed by Tim Horton.

Some clients may not want the web view to be programmatically made the first responder
and invoking -makeFirstResponder: unconditionally posts 'first responder did change'
notifications.

Added API test.

• UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _setShouldSuppressFirstResponderChanges:]):

• UIProcess/API/Cocoa/WKWebViewPrivate.h:
• UIProcess/Cocoa/WebViewImpl.h:
• UIProcess/Cocoa/WebViewImpl.mm:

(WebKit::WebViewImpl::setShouldSuppressFirstResponderChanges):

• UIProcess/PageClient.h:
• UIProcess/mac/PageClientImpl.h:
• UIProcess/mac/PageClientImpl.mm:

(WebKit::PageClientImpl::makeFirstResponder):

4:27 PM Changeset in webkit [215586] by beidson@apple.com

• 2 edits in trunk/Tools

Skip WebKit2.OpenAndCloseWindowAsyncCallbackException for now.
​https://bugs.webkit.org/show_bug.cgi?id=171083

Unreviewed.

• TestWebKitAPI/Tests/WebKit2Cocoa/OpenAndCloseWindow.mm:

4:11 PM Changeset in webkit [215585] by commit-queue@webkit.org

• 15 edits
  2 adds in trunk/Source

[WinCairo] Fix build break after updating ANGLE
​https://bugs.webkit.org/show_bug.cgi?id=170980

Patch by Fujii Hironori <Fujii Hironori> on 2017-04-20
Reviewed by Brent Fulgham.

Source/ThirdParty/ANGLE:

• CMakeLists.txt: Added some new source files.
• PlatformMac.cmake: Ditto.
• PlatformWin.cmake: Ditto. Remove a macro 'ANGLE_WEBKIT_WIN'

because SoftLinking is not used anymore.

• src/third_party/systeminfo/: Restored.

Source/WebCore:

By stopping using SoftLinking for ANGLE, some changes are needed
for WebCore and WebKit.

• Define a macro 'GL_GLEXT_PROTOTYPES' before #include <GLES2/gl2.h> or <GLES2/gl2ext.h>.
• Link libEGL import library explicitly.

• PlatformWin.cmake: Link libEGL to WebCore.
• platform/graphics/PlatformDisplay.cpp:

(WebCore::PlatformDisplay::initializeEGLDisplay): Removed the code for SoftLinking.

• platform/graphics/GLContext.cpp: Define GL_GLEXT_PROTOTYPES.
• platform/graphics/egl/GLContextEGL.cpp: Ditto.
• platform/graphics/opengl/Extensions3DOpenGLCommon.cpp: Ditto.
• platform/graphics/opengl/Extensions3DOpenGLES.h: Ditto.
• platform/graphics/opengl/TemporaryOpenGLSetting.cpp: Ditto.
• platform/graphics/texmap/TextureMapperGC3DPlatformLayer.cpp: Ditto.

Source/WebKit/win:

• WebCoreSupport/AcceleratedCompositingContext.cpp: Define GL_GLEXT_PROTOTYPES.

4:09 PM Changeset in webkit [215584] by Matt Baker

• 16 edits
  2 copies
  2 adds in trunk

Web Inspector: Add regular expression support to XHR breakpoints
​https://bugs.webkit.org/show_bug.cgi?id=170099
<rdar://problem/31558082>

Reviewed by Joseph Pecoraro.

Source/JavaScriptCore:

• inspector/protocol/DOMDebugger.json:

New optional isRegex parameter denotes whether url contains
a regular expression.

Source/WebCore:

• inspector/InspectorDOMDebuggerAgent.cpp:

(WebCore::InspectorDOMDebuggerAgent::setXHRBreakpoint):
(WebCore::InspectorDOMDebuggerAgent::willSendXMLHttpRequest):
Use ContentSearchUtilities for both Text and RegularExpression breakpoints.

• inspector/InspectorDOMDebuggerAgent.h:

Associate XHR breakpoint with a type.

Source/WebInspectorUI:

• Localizations/en.lproj/localizedStrings.js:

New strings for the Add XHR Breakpoint popover.

• UserInterface/Controllers/DOMDebuggerManager.js:

(WebInspector.DOMDebuggerManager):
(WebInspector.DOMDebuggerManager.prototype.addXHRBreakpoint):
Update for new XHRBreakpoint constructor.
(WebInspector.DOMDebuggerManager.prototype._updateXHRBreakpoint):
Set isRegex flag.

• UserInterface/Main.html:

New files for CodeMirror mode and breakpoint popover.

• UserInterface/Models/XHRBreakpoint.js:

Breakpoint can be of type Text or RegularExpression.
(WebInspector.XHRBreakpoint):
(WebInspector.XHRBreakpoint.prototype.get type):
(WebInspector.XHRBreakpoint.prototype.get serializableInfo):

• UserInterface/Views/CodeMirrorRegexMode.css: Added.

(.cm-s-default .cm-regex-character-set):
(.cm-s-default .cm-regex-character-set-negate):
(.cm-s-default :matches(.cm-regex-escape, .cm-regex-escape-2, .cm-regex-escape-3)):
(.cm-s-default :matches(.cm-regex-group, .cm-regex-lookahead)):
(.cm-s-default .cm-regex-quantifier):
(.cm-s-default :matches(.cm-regex-literal, .cm-regex-special, .cm-regex-backreference)):
Colors for regular expression syntax highlighting. The regex mode emits
more class names than we have separate colors for, allowing for further
customization in the future.

• UserInterface/Views/CodeMirrorRegexMode.js: Added.

(characterSetTokenizer):
(consumeEscapeSequence):
(tokenBase):
New CodeMirror mode for highlighting "text/x-regex" content.

• UserInterface/Views/DebuggerSidebarPanel.js:

Use new popover type for creating XHR breakpoints.
(WebInspector.DebuggerSidebarPanel.prototype._addXHRBreakpointButtonClicked):
(WebInspector.DebuggerSidebarPanel.prototype.willDismissPopover):
(WebInspector.DebuggerSidebarPanel):

• UserInterface/Views/XHRBreakpointPopover.css: Added.

(.popover .xhr-breakpoint-content):
(.popover .xhr-breakpoint-content > .editor-wrapper):
(.popover .xhr-breakpoint-content > .editor-wrapper > .editor):
(body[dir=ltr] .popover .xhr-breakpoint-content > .editor-wrapper > .editor):
(body[dir=rtl] .popover .xhr-breakpoint-content > .editor-wrapper > .editor):
(.popover .xhr-breakpoint-content > .editor-wrapper > .editor > .CodeMirror):
(.popover .xhr-breakpoint-content > .editor-wrapper > .editor > .CodeMirror-scroll):
Styles for new popover.

• UserInterface/Views/XHRBreakpointPopover.js: Added.

New popover class. Includes a picker for selecting breakpoint type
(Text or RegularExpression), and has an improved popover caption. Input
field style and placeholder text changes based on the breakpoint type.

(WebInspector.XHRBreakpointPopover):
(WebInspector.XHRBreakpointPopover.prototype.get result):
(WebInspector.XHRBreakpointPopover.prototype.get type):
(WebInspector.XHRBreakpointPopover.prototype.get value):
(WebInspector.XHRBreakpointPopover.prototype.show.addOption):
(WebInspector.XHRBreakpointPopover.prototype.show):
(WebInspector.XHRBreakpointPopover.prototype._createEditor):
(WebInspector.XHRBreakpointPopover.prototype._updateEditor):
(WebInspector.XHRBreakpointPopover.prototype._presentOverTargetElement):

• UserInterface/Views/XHRBreakpointTreeElement.js:

(WebInspector.XHRBreakpointTreeElement):
Differentiate breakpoint type by enclosing subtitle in either double quotes
or regex-literal delimiters, depending on the type of breakpoint.

LayoutTests:

Update tests and expectations for new XHR breakpoint type.

• inspector/dom-debugger/xhr-breakpoints-expected.txt:
• inspector/dom-debugger/xhr-breakpoints.html:

4:09 PM Changeset in webkit [215583] by eric.carlson@apple.com

• 2 edits in trunk/Source/WebCore

[MediaStream] Cleanup and simplify CoreAudioCaptureSource
​https://bugs.webkit.org/show_bug.cgi?id=171064

There is no need for a mutex to guard against internal state changes because we
don't currently change configuration after the audio unit is allocated. Once
we do support reconfiguration on the fly, we can just stop the output unit before
changing configuration because the I/O proc isn't called if the output unit
is stopped, and AudioOutputUnitStop blocks until the audio device has stopped.

Reviewed by Jer Noble.

• platform/mediastream/mac/CoreAudioCaptureSource.cpp:

(WebCore::CoreAudioCaptureSource::~CoreAudioCaptureSource): Call cleanupAudioUnits
instead of duplicating logic.
(WebCore::CoreAudioCaptureSource::preferredIOBufferDuration): Change preferred
duration from 20ms to 40ms.
(WebCore::CoreAudioCaptureSource::configureMicrophoneProc): Set mSampleRate to the
preferred sample rate if it is 0.
(WebCore::CoreAudioCaptureSource::configureSpeakerProc): Ditto.
(WebCore::CoreAudioCaptureSource::provideSpeakerData): Only increment counter and
check timestamps in debug builds.
(WebCore::CoreAudioCaptureSource::processMicrophoneSamples): Ditto.
(WebCore::CoreAudioCaptureSource::cleanupAudioUnits): We only need the audio unit
name in debug builds.
(WebCore::CoreAudioCaptureSource::setupAudioUnits): Ditto. No more internal state
lock. Don't try to get the default input device on iOS.
(WebCore::CoreAudioCaptureSource::startProducingData): No more internal state lock.
Assert if not called on the main thread.
(WebCore::CoreAudioCaptureSource::stopProducingData): Ditto.
(WebCore::CoreAudioCaptureSource::suspend): Ditto.
(WebCore::CoreAudioCaptureSource::resume): Ditto.

• platform/mediastream/mac/CoreAudioCaptureSource.h:

3:23 PM Changeset in webkit [215582] by eric.carlson@apple.com

• 7 edits in trunk/Source

[MediaStream iOS] Hold process assertion while media capture is active
​https://bugs.webkit.org/show_bug.cgi?id=171017
<rdar://problem/31719177>

Reviewed by Dean Jackson.

Source/WebCore:

• page/ActivityState.h: Add IsCapturingMedia flag.

• page/Page.cpp:

(WebCore::Page::updateTimerThrottlingState): Enable timer throttling when capture is active
like we do when playing audio.
(WebCore::Page::setActivityState): Ditto.

• page/PerformanceMonitor.cpp:

(WebCore::PerformanceMonitor::updateProcessStateForMemoryPressure): A process is active when
capturing media, as it is when playing audio.

Source/WebKit2:

• UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::updateActivityState): Update IsCapturingMedia when necessary.
(WebKit::WebPageProxy::updateThrottleState): Hold a token when capture is active.
(WebKit::WebPageProxy::setMuted): Capture state may change when the page is muted,
so pass IsCapturingMedia to activityStateDidChange.
(WebKit::WebPageProxy::isPlayingMediaDidChange): Ditto.

• WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::updateThrottleState): Don't allow page suppression when capture
is active.

3:06 PM Changeset in webkit [215581] by Wenson Hsieh

• 5 edits
  2 adds in trunk

Inline anchor elements cannot be dragged when starting the drag from a block descendant
​https://bugs.webkit.org/show_bug.cgi?id=171062
<rdar://problem/31697835>

Reviewed by Tim Horton.

Source/WebCore:

Tweaks DragController::draggableElement to traverse the DOM instead of the render tree when finding a draggable
element. This prevents us from skipping elements that are in the DOM ancestor chain, but appear as siblings to
the hit-tested node's renderer in the render tree.

There was also previously a check to ensure that we skip anonymous RenderObjects while traversing up the chain,
but this is no longer necessary fter this change, since all the elements we traverse in the DOM should have
renderers that are not anonymous.

Test: fast/events/drag-and-drop-link-containing-block.html

• page/DragController.cpp:

(WebCore::DragController::draggableElement):

LayoutTests:

Adds a new test on WK1 Mac to verify that link dragging succeeds when the link's anchor element is inline and
the drag is started from a block element under the link.

• fast/events/drag-and-drop-link-containing-block-expected.txt: Added.
• fast/events/drag-and-drop-link-containing-block.html: Added.
• platform/ios/TestExpectations:
• platform/mac-wk2/TestExpectations:

Skip the test on iOS and Mac WK2.

2:56 PM Changeset in webkit [215580] by Michael Catanzaro

• 2 edits in trunk/Source/WebCore

-Wformat warning on HistoryController.cpp:295:5
​https://bugs.webkit.org/show_bug.cgi?id=171028

Reviewed by Daniel Bates.

Need to cast WebCore::FrameLoadType to int before using it in printf.

• loader/HistoryController.cpp:

(WebCore::HistoryController::goToItem):

2:42 PM Changeset in webkit [215579] by pvollan@apple.com

• 3 edits in trunk/Source/WebCore

The toleranceBefore parameter in the AVPlayerItem method seekToTime should not be negative.
​https://bugs.webkit.org/show_bug.cgi?id=171063

Reviewed by Eric Carlson.

The AVPlayerItem method seekToTime will throw an exception if toleranceBefore is negative.

No new tests since the change is a sanity check.

• html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::seekTask):

• platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:

(WebCore::MediaPlayerPrivateAVFoundationObjC::seekToTime):

2:30 PM Changeset in webkit [215578] by andersca@apple.com

• 2 edits in trunk/Source/WebKit2

Fix build.

• UIProcess/ApplePay/cocoa/WebPaymentCoordinatorProxyCocoa.mm:

(WebKit::WebPaymentCoordinatorProxy::platformCompletePaymentSession):

1:53 PM Changeset in webkit [215577] by beidson@apple.com

• 4 edits in trunk

Add CompletionHandlerCallChecker to SPI added in r215545.
​https://bugs.webkit.org/show_bug.cgi?id=171067

Reviewed by Dan Bernstein.

Source/WebKit2:

• UIProcess/Cocoa/UIDelegate.mm:

(WebKit::UIDelegate::UIClient::createNewPageCommon):

Tools:

• TestWebKitAPI/Tests/WebKit2Cocoa/OpenAndCloseWindow.mm:

(TEST):
(-[OpenAndCloseWindowUIDelegateAsync _webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:completionHandler:]):

1:52 PM Changeset in webkit [215576] by andersca@apple.com

• 8 edits in trunk/Source

Replace isFinalStateStatus with isFinalStateResult
​https://bugs.webkit.org/show_bug.cgi?id=171072
rdar://problem/31589635

Reviewed by Tim Horton.

Source/WebCore:

This will let us get rid of some of the status enum declarations.

• Modules/applepay/ApplePaySession.cpp:

(WebCore::ApplePaySession::completePayment):

• Modules/applepay/PaymentAuthorizationStatus.h:

(WebCore::isFinalStateStatus): Deleted.

• Modules/applepay/PaymentCoordinator.cpp:

(WebCore::PaymentCoordinator::completePaymentSession):

• Modules/applepay/PaymentRequest.cpp:

(WebCore::isFinalStateResult):

• Modules/applepay/PaymentRequest.h:

Source/WebKit2:

• UIProcess/ApplePay/WebPaymentCoordinatorProxy.cpp:

(WebKit::WebPaymentCoordinatorProxy::completePaymentSession):

1:14 PM Changeset in webkit [215575] by Brent Fulgham

• 2 edits in trunk/Source/WebCore

[Win] REGRESSION(r215486): Windows Release build is broken
​https://bugs.webkit.org/show_bug.cgi?id=171024
<rdar://problem/31722618>

Reviewed by Mark Lam.

Add missing include needed for clean Release build on Windows (proper
fix found by Fujii Hironori).

• bindings/js/JSDOMGlobalObject.h:

1:09 PM Changeset in webkit [215574] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebCore

CachedImage should cancel loading images for unsupported/unknown types
​https://bugs.webkit.org/show_bug.cgi?id=170697

Patch by Said Abou-Hallawa <​sabouhallawa@apple.com> on 2017-04-20
Reviewed by Youenn Fablet.

Currently when the image decoder detects an error with the incoming encoded
data of an image, we mark the image to be a broken image. But the network
process keeps feeding the web process with the rest of the data. We should
cancel loading the rest of the data to save network bandwidth and CPU time
loading and processing useless data.

• loader/cache/CachedImage.cpp:

(WebCore::CachedImage::addIncrementalDataBuffer):
(WebCore::CachedImage::finishLoading):

12:59 PM Changeset in webkit [215573] by Wenson Hsieh

• 8 edits
  4 adds in trunk

[WK2] -[WKContentView doAfterPositionInformationUpdate:atPosition:] should be robust against synchronous reentrancy
​https://bugs.webkit.org/show_bug.cgi?id=170922
<rdar://problem/31634990>

Reviewed by Tim Horton.

Source/WebKit2:

Refactors part of the asynchronous position information mechanism introduced in
<​https://trac.webkit.org/changeset/215171>, and introduces infrastructure for unit testing UI-side position
information requests.

_invokeAndRemovePendingHandlersValidForCurrentPositionInformation is a helper method on WKContentView
responsible for invoking queued position information handlers after receiving a position information response
from the web process. Previously, this method would iterate over the list of pending callbacks and invoke all
callbacks whose requests are satisfied by the incoming position information update, saving the indices of these
handled callbacks in the process. At the end, it would then remove callbacks at these indices from the array of
pending callbacks. This is problematic when a synchronous position update (via
ensurePositionInformationIsUpToDate:) is triggered from within one of these callbacks, since
_invokeAndRemovePendingHandlersValidForCurrentPositionInformation will be called from within itself, and then we
will attempt to remove a callback at the same index twice.

To fix this, we change the array of pending position information handlers to be an array of optionals instead.
When invoking and removing pending handlers after a position information response arrives, we now mark callbacks
as handled by setting them to std::nullopt. Then, when the top-level invocation to
_invokeAndRemovePendingHandlersValidForCurrentPositionInformation is finished, we remove all marked handlers
from the pending vector.

Covered by 6 new unit tests:

• PositionInformationTests.FindDraggableLinkAtPosition
• PositionInformationTests.RequestDraggableLinkAtPosition
• PositionInformationTests.FindDraggableLinkAtDifferentPositionWithinRequestBlock
• PositionInformationTests.FindDraggableLinkAtSamePositionWithinRequestBlock
• PositionInformationTests.RequestDraggableLinkAtSamePositionWithinRequestBlock
• PositionInformationTests.RequestDraggableLinkAtDifferentPositionWithinRequestBlock

• UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView draggableElementAtPosition:]):
(-[WKWebView requestDraggableElementAtPosition:completionBlock:]):

Uses WKContentView's position information request helpers to search for draggable elements on the page. There
are both synchronous and asynchronous versions of this, both of which retrieve a _WKDraggableElementInfo.

• UIProcess/API/Cocoa/WKWebViewPrivate.h:
• UIProcess/API/Cocoa/_WKDraggableElementInfo.h: Added.
• UIProcess/API/Cocoa/_WKDraggableElementInfo.mm: Added.

Exposes what elements are draggable at a given position as SPI (only for use in testing code, at the moment).

(-[_WKDraggableElementInfo initWithInteractionInformationAtPosition:]):
(-[_WKDraggableElementInfo copyWithZone:]):

• UIProcess/API/Cocoa/_WKDraggableElementInfoInternal.h: Added.
• UIProcess/ios/WKContentViewInteraction.h:
• UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView currentPositionInformation]):
(-[WKContentView doAfterPositionInformationUpdate:forRequest:]):
(-[WKContentView _invokeAndRemovePendingHandlersValidForCurrentPositionInformation]):

• WebKit2.xcodeproj/project.pbxproj:

Tools:

Adds six new unit tests for retrieving interaction information at a given position in the UI process. See
WebKit2 ChangeLog for more details.

• TestWebKitAPI/Tests/ios/PositionInformationTests.mm:

(-[_WKDraggableElementInfo expectToBeLink:image:atPoint:]):
(TestWebKitAPI::TEST):
(TestWebKitAPI::expectCGPointsToBeEqual): Deleted.

12:45 PM Changeset in webkit [215572] by commit-queue@webkit.org

• 8 edits
  2 adds in trunk

AX: Modern Media Controls Timeline slider should be operable
​https://bugs.webkit.org/show_bug.cgi?id=170250

Patch by Aaron Chu <​aaron_chu@apple.com> on 2017-04-20
Reviewed by Antoine Quint.

Source/WebCore:

Added a "change" event listener and aria-valuetext to the slider so that when a
VoiceOver user operates the timeline control, VO speaks the updated timestamp

Test: media/modern-media-controls/scrubber/scrubber-has-correct-ax-label.html

• English.lproj/modern-media-controls-localized-strings.js:
• Modules/modern-media-controls/controls/scrubber.js:

(Scrubber.prototype.set inputAccessibleLabel):
(Scrubber.prototype._formatTime):

• Modules/modern-media-controls/controls/slider.js:

(Slider.prototype.handleEvent):
(Slider.prototype._handleInputEvent): Deleted.

• Modules/modern-media-controls/controls/time-control.js:

(TimeControl.prototype.updateScrubberLabel):

• Modules/modern-media-controls/controls/time-label.js:

(TimeLabel.prototype.commitProperty):
(TimeLabel.prototype._formattedTime):

• Modules/modern-media-controls/main.js:

(formatTimeByUnit):
(unitizeTime):

LayoutTests:

• media/modern-media-controls/scrubber/scrubber-has-correct-ax-label-expected.txt: Added.
• media/modern-media-controls/scrubber/scrubber-has-correct-ax-label.html: Added.

12:44 PM Changeset in webkit [215571] by weinig@apple.com

• 4 edits
  1 add in trunk/Source/WTF

Move notFound into its own file
​https://bugs.webkit.org/show_bug.cgi?id=170972

Reviewed by Zalan Bujtas.

It is odd to require including <wtf/Vector.h> just to use WTF::notFound.
This is not causing any current problems, but does in few changes I have
queued up.

• WTF.xcodeproj/project.pbxproj:
• wtf/NotFound.h: Added.
• wtf/Vector.h:
• wtf/text/StringCommon.h:

12:39 PM Changeset in webkit [215570] by aestes@apple.com

• 2 edits in trunk/Source/WebCore

Fix indentation in AVKitSPI.h
​https://bugs.webkit.org/show_bug.cgi?id=171066

Reviewed by Jer Noble.

• platform/spi/cocoa/AVKitSPI.h:

12:34 PM Changeset in webkit [215569] by andersca@apple.com

• 2 edits in trunk/Source/WebKit2

Fix a PassKit function declaration typo
​https://bugs.webkit.org/show_bug.cgi?id=171068
rdar://problem/31635008

Reviewed by Tim Horton.

• UIProcess/ApplePay/cocoa/WebPaymentCoordinatorProxyCocoa.mm:

(WebKit::WebPaymentCoordinatorProxy::platformCanMakePaymentsWithActiveCard):

12:22 PM Changeset in webkit [215568] by jer.noble@apple.com

• 16 edits in trunk/Source

[MediaCapture] gUM() with CoreAudio fails if capturing audio in the UIProcess.
​https://bugs.webkit.org/show_bug.cgi?id=171021

Reviewed by Eric Carlson.

Source/WebCore:

Refactor the creation of RealtimeMediaSources to take a persistent device ID rather
than a CaptureDevice directly. This allows WebKit2 to iterate devices in the UIProcess
rather than the WebProcess.

• platform/mediastream/RealtimeMediaSource.h:
• platform/mediastream/mac/AVAudioCaptureSource.mm:
• platform/mediastream/mac/AVVideoCaptureSource.mm:
• platform/mediastream/mac/CoreAudioCaptureSource.cpp:

(WebCore::CoreAudioCaptureSource::create):
(WebCore::CoreAudioCaptureSource::CoreAudioCaptureSource):

• platform/mediastream/mac/CoreAudioCaptureSource.h:
• platform/mediastream/mac/RealtimeMediaSourceCenterMac.cpp:

(WebCore::RealtimeMediaSourceCenterMac::createMediaStream):
(WebCore::RealtimeMediaSourceCenterMac::bestSourcesForTypeAndConstraints):

• platform/mock/MockRealtimeAudioSource.cpp:
• platform/mock/MockRealtimeVideoSource.cpp:

Source/WebKit2:

Pass a deviceID rather than a CaptureDevice across the process boundary.

• Shared/WebCoreArgumentCoders.h:
• UIProcess/Cocoa/UserMediaCaptureManagerProxy.cpp:

(WebKit::UserMediaCaptureManagerProxy::createMediaSourceForCaptureDeviceWithConstraints):

• UIProcess/Cocoa/UserMediaCaptureManagerProxy.h:
• UIProcess/Cocoa/UserMediaCaptureManagerProxy.messages.in:
• WebProcess/cocoa/UserMediaCaptureManager.cpp:

(WebKit::UserMediaCaptureManager::createMediaSourceForCaptureDeviceWithConstraints):

• WebProcess/cocoa/UserMediaCaptureManager.h:

12:13 PM Changeset in webkit [215567] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebKit2

Fix assertions in webProcessProxyFromConnection
​https://bugs.webkit.org/show_bug.cgi?id=171025
<rdar://problem/31184073>

Patch by Alex Christensen <​achristensen@webkit.org> on 2017-04-20
Reviewed by Brady Eidson.

• UIProcess/WebProcessPool.cpp:

(WebKit::webProcessProxyFromConnection):
If we have a Connection, then we have a valid process attached to that connection,
unless it's a Connection to a different type of child process.
Calling ChildProcessProxy::connection on other web processes that are in State::Launching,
then we get an assertion. Luckily, ChildProcessProxy::hasConnection was introduced in r210861
for this reason.

11:23 AM Changeset in webkit [215566] by timothy_horton@apple.com

• 14 edits in trunk/Source/WebCore

Make it possible to request the non-expanded scrollbar width from ScrollbarTheme
​https://bugs.webkit.org/show_bug.cgi?id=171047

Reviewed by Sam Weinig.

No new tests, new behavior is not exposed in any way.

• platform/ScrollTypes.h:
• platform/ScrollbarTheme.h:

(WebCore::ScrollbarTheme::scrollbarThickness):

• platform/gtk/ScrollbarThemeGtk.cpp:

(WebCore::ScrollbarThemeGtk::scrollbarThickness):

• platform/gtk/ScrollbarThemeGtk.h:
• platform/ios/ScrollbarThemeIOS.h:
• platform/ios/ScrollbarThemeIOS.mm:

(WebCore::ScrollbarThemeIOS::scrollbarThickness):

• platform/mac/ScrollbarThemeMac.h:
• platform/mac/ScrollbarThemeMac.mm:

(WebCore::ScrollbarThemeMac::scrollbarThickness):

• platform/mock/ScrollbarThemeMock.cpp:

(WebCore::ScrollbarThemeMock::scrollbarThickness):

• platform/mock/ScrollbarThemeMock.h:
• platform/win/ScrollbarThemeWin.cpp:

(WebCore::ScrollbarThemeWin::scrollbarThickness):

• platform/win/ScrollbarThemeWin.h:
• rendering/RenderScrollbarTheme.h:

On Mac, when the scrollbar is hovered, it gets bigger.
Currently, scrollbarThickness always returns the big size.
It should be possible to request the smaller, "regular" scrollbar size as well.

10:55 AM Changeset in webkit [215565] by fpizlo@apple.com

• 40 edits
  6 adds in trunk

Optimize SharedArrayBuffer in the DFG+FTL
​https://bugs.webkit.org/show_bug.cgi?id=164108

Reviewed by Saam Barati.

JSTests:

Added a fairly comprehensive test of the intrinsics. This creates a function for each possible
combination of type and operation, and then first uses it nicely and then tries a bunch of
erroneous conditions like OOB.

• stress/SharedArrayBuffer-opt.js: Added.

(string_appeared_here.switch):
(string_appeared_here.str):
(runAtomic):
(shouldFail):
(Symbol):
(string_appeared_here.a.of.arrays.m.of.atomics):

• stress/SharedArrayBuffer.js:

Source/JavaScriptCore:

This adds atomics intrinsics to the DFG and wires them through to the DFG and FTL backends. This
was super easy in the FTL since B3 already has comprehensive atomic intrinsics, which are more
powerful than what we need right now. In the DFG backend, I went with an easy-to-write
implementation that just reduces everything to a weak CAS loop. It's very inefficient with
registers (it needs ~8) but it's the DFG backend, so it's not obvious how much we care.

To make the rare cases easy to handle, I refactored AtomicsObject.cpp so that the operations for
the slow paths can share code with the native functions.

This also fixes register handling in the X86 implementations of CAS, in the case that
expectedAndResult is not %rax. This also fixes the ARM64 implementation of branchWeakCAS.

I adapted the CascadeLock from WTF/benchmarks/ToyLocks.h as a microbenchmark of lock performance.
This benchmark performs 2.5x faster, in both the contended and uncontended case, thanks to this
change. It's still about 3x slower than native. I investigated this only a bit. I suspect that
the story will be different in asm.js code, which will get constant-folding of the typed array
backing store by virtue of how it uses lexically scoped variables as pointers to the heap arrays.
It's worth noting that the native lock I was comparing against, the very nicely-tuned
CascadeLock, is at the very high end of lock throughput under virtually all conditions
(uncontended, microcontended, held for a long time). I also compared to WTF::Lock and others, and
the only ones that performed better in this microbenchmark were spinlocks. I don't recommend
using those. So, when I say this is 3x slower than native, I really mean that it's 3x slower than
the fastest native lock that I have in my arsenal.

Also worth noting is that I experimented with exposing Atomics.yield(), which uses sched_yield,
as a way of testing if adding a yield loop to the JS cascadeLock would help. It does not help. I
did not investigate why.

• assembler/AbstractMacroAssembler.h:

(JSC::AbstractMacroAssembler::JumpList::append):

• assembler/CPU.h:

(JSC::is64Bit):
(JSC::is32Bit):

• b3/B3Common.h:

(JSC::B3::is64Bit): Deleted.
(JSC::B3::is32Bit): Deleted.

• b3/B3LowerToAir.cpp:

(JSC::B3::Air::LowerToAir::appendTrapping):
(JSC::B3::Air::LowerToAir::appendCAS):
(JSC::B3::Air::LowerToAir::appendGeneralAtomic):

• dfg/DFGAbstractInterpreterInlines.h:

(JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):

• dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::handleIntrinsicCall):

• dfg/DFGClobberize.h:

(JSC::DFG::clobberize):

• dfg/DFGDoesGC.cpp:

(JSC::DFG::doesGC):

• dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode):

• dfg/DFGNode.h:

(JSC::DFG::Node::hasHeapPrediction):
(JSC::DFG::Node::hasArrayMode):

• dfg/DFGNodeType.h:

(JSC::DFG::isAtomicsIntrinsic):
(JSC::DFG::numExtraAtomicsArgs):

• dfg/DFGPredictionPropagationPhase.cpp:
• dfg/DFGSSALoweringPhase.cpp:

(JSC::DFG::SSALoweringPhase::handleNode):

• dfg/DFGSafeToExecute.h:

(JSC::DFG::safeToExecute):

• dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::loadFromIntTypedArray):
(JSC::DFG::SpeculativeJIT::setIntTypedArrayLoadResult):
(JSC::DFG::SpeculativeJIT::compileGetByValOnIntTypedArray):
(JSC::DFG::SpeculativeJIT::getIntTypedArrayStoreOperand):
(JSC::DFG::SpeculativeJIT::compilePutByValForIntTypedArray):

• dfg/DFGSpeculativeJIT.h:

(JSC::DFG::SpeculativeJIT::callOperation):

• dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

• dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

• ftl/FTLAbstractHeapRepository.cpp:

(JSC::FTL::AbstractHeapRepository::decorateFencedAccess):
(JSC::FTL::AbstractHeapRepository::computeRangesAndDecorateInstructions):

• ftl/FTLAbstractHeapRepository.h:
• ftl/FTLCapabilities.cpp:

(JSC::FTL::canCompile):

• ftl/FTLLowerDFGToB3.cpp:

(JSC::FTL::DFG::LowerDFGToB3::compileNode):
(JSC::FTL::DFG::LowerDFGToB3::compileAtomicsReadModifyWrite):
(JSC::FTL::DFG::LowerDFGToB3::compileAtomicsIsLockFree):
(JSC::FTL::DFG::LowerDFGToB3::compileGetByVal):
(JSC::FTL::DFG::LowerDFGToB3::compilePutByVal):
(JSC::FTL::DFG::LowerDFGToB3::pointerIntoTypedArray):
(JSC::FTL::DFG::LowerDFGToB3::loadFromIntTypedArray):
(JSC::FTL::DFG::LowerDFGToB3::storeType):
(JSC::FTL::DFG::LowerDFGToB3::setIntTypedArrayLoadResult):
(JSC::FTL::DFG::LowerDFGToB3::getIntTypedArrayStoreOperand):
(JSC::FTL::DFG::LowerDFGToB3::vmCall):

• ftl/FTLOutput.cpp:

(JSC::FTL::Output::store):
(JSC::FTL::Output::store32As8):
(JSC::FTL::Output::store32As16):
(JSC::FTL::Output::atomicXchgAdd):
(JSC::FTL::Output::atomicXchgAnd):
(JSC::FTL::Output::atomicXchgOr):
(JSC::FTL::Output::atomicXchgSub):
(JSC::FTL::Output::atomicXchgXor):
(JSC::FTL::Output::atomicXchg):
(JSC::FTL::Output::atomicStrongCAS):

• ftl/FTLOutput.h:

(JSC::FTL::Output::store32):
(JSC::FTL::Output::store64):
(JSC::FTL::Output::storePtr):
(JSC::FTL::Output::storeFloat):
(JSC::FTL::Output::storeDouble):

• jit/JITOperations.h:
• runtime/AtomicsObject.cpp:

(JSC::atomicsFuncAdd):
(JSC::atomicsFuncAnd):
(JSC::atomicsFuncCompareExchange):
(JSC::atomicsFuncExchange):
(JSC::atomicsFuncIsLockFree):
(JSC::atomicsFuncLoad):
(JSC::atomicsFuncOr):
(JSC::atomicsFuncStore):
(JSC::atomicsFuncSub):
(JSC::atomicsFuncWait):
(JSC::atomicsFuncWake):
(JSC::atomicsFuncXor):
(JSC::operationAtomicsAdd):
(JSC::operationAtomicsAnd):
(JSC::operationAtomicsCompareExchange):
(JSC::operationAtomicsExchange):
(JSC::operationAtomicsIsLockFree):
(JSC::operationAtomicsLoad):
(JSC::operationAtomicsOr):
(JSC::operationAtomicsStore):
(JSC::operationAtomicsSub):
(JSC::operationAtomicsXor):

• runtime/AtomicsObject.h:

Source/WTF:

Made small changes as part of benchmarking the JS versions of these locks.

• benchmarks/LockSpeedTest.cpp:
• benchmarks/ToyLocks.h:
• wtf/Range.h:

(WTF::Range::dump):

LayoutTests:

Add a test of futex performance.

• workers/sab/cascade_lock-worker.js: Added.

(onmessage):

• workers/sab/cascade_lock.html: Added.
• workers/sab/worker-resources.js:

(cascadeLockSlow):
(cascadeLock):
(cascadeUnlock):

10:53 AM Changeset in webkit [215564] by jonlee@apple.com

• 8 edits in trunk

Update pip placard to "picture in picture"
​https://bugs.webkit.org/show_bug.cgi?id=171036
rdar://problem/30201536

Reviewed by Antoine Quint.

Source/WebCore:

Updated media/modern-media-controls/pip-placard/pip-placard.html

Update the text shown with the picture in picture placard.

• English.lproj/mediaControlsLocalizedStrings.js:
• English.lproj/modern-media-controls-localized-strings.js:
• Modules/mediacontrols/mediaControlsApple.js:

(Controller.prototype.updatePictureInPicturePlaceholder):

• Modules/modern-media-controls/controls/pip-placard.js:

(PiPPlacard):

LayoutTests:

• media/modern-media-controls/pip-placard/pip-placard-expected.txt: Updated expected results.
• media/modern-media-controls/pip-placard/pip-placard.html:

10:49 AM Changeset in webkit [215563] by Ryan Haddad

• 2 edits in trunk/LayoutTests

Mark two crypto/subtle/ecdsa LayoutTests as flaky.
​https://bugs.webkit.org/show_bug.cgi?id=171059

Unreviewed test gardening.

• TestExpectations:

10:49 AM Changeset in webkit [215562] by Ryan Haddad

• 2 edits in trunk/LayoutTests

Mark memory/memory-pressure-simulation.html as flaky.
​https://bugs.webkit.org/show_bug.cgi?id=170629

Unreviewed test gardening.

• platform/mac-wk2/TestExpectations:

9:46 AM Changeset in webkit [215561] by clopez@igalia.com

• 2 edits in trunk/LayoutTests

[GTK] Update layout tests expectations after r215556
​https://bugs.webkit.org/show_bug.cgi?id=170942

Unreviewed gardening.

• platform/gtk/TestExpectations:

9:16 AM Changeset in webkit [215560] by Dewei Zhu

• 2 edits in trunk/Source/WebKit/mac

Build fix to start using C++14.
​https://bugs.webkit.org/show_bug.cgi?id=171038

Reviewed by Alex Christensen.

Use 'c++14' instead of 'c++11' in order to use 'auto' in lambda.

• Configurations/WebKitLegacy.xcconfig:

8:55 AM Changeset in webkit [215559] by Brent Fulgham

• 2 edits in trunk/Source/WebKit2

[WK2][macOS] Allow iokit-get-properties for IOAudioControlValue
​https://bugs.webkit.org/show_bug.cgi?id=171020
<rdar://problem/30878974>

Reviewed by Alexey Proskuryakov.

• WebProcess/com.apple.WebProcess.sb.in: Add missing property name.

8:48 AM Changeset in webkit [215558] by commit-queue@webkit.org

• 7 edits
  2 adds in trunk

RTCPeerConnection is stopping its backend twice sometimes
​https://bugs.webkit.org/show_bug.cgi?id=171043

Patch by Youenn Fablet <​youenn@apple.com> on 2017-04-20
Reviewed by Eric Carlson.

Source/WebCore:

Test: webrtc/closing-peerconnection.html

Making sure we stop the backend only once.
Adding an internals API to close the peer connection so as to replicate frame disconnection.

• Modules/mediastream/RTCPeerConnection.cpp:

(WebCore::RTCPeerConnection::doClose):
(WebCore::RTCPeerConnection::doStop):

• Modules/mediastream/RTCPeerConnection.h:
• testing/Internals.cpp:

(WebCore::Internals::stopPeerConnection):

• testing/Internals.h:
• testing/Internals.idl:

LayoutTests:

• webrtc/closing-peerconnection-expected.txt: Added.
• webrtc/closing-peerconnection.html: Added.

5:57 AM Changeset in webkit [215557] by Antti Koivisto

• 2 edits in trunk/Source/WebCore

Increase large animation cutoff
​https://bugs.webkit.org/show_bug.cgi?id=171051
<rdar://problem/31731532>

Reviewed by Andreas Kling.

We currently switch to per-frame decoding if the animation is larger than 5MB. This is very
power-inefficient and such animations are now common. The cutoff originates from 2007 (r20069),
it is time update it.

Note that the normal low memory handling will still kill animation frames as needed.

• platform/graphics/BitmapImage.h:

Increase cutoff to 30MB. This is enough (with some room to spare) for animations on current
tumblr.com/search/aww.

Also remove the separate cutoff value for iOS.

3:24 AM Changeset in webkit [215556] by commit-queue@webkit.org

• 3 edits
  1 delete in trunk/Tools

[GTK][jhbuild] Update glib and glib-networking to the latest stable versions
​https://bugs.webkit.org/show_bug.cgi?id=170942

Patch by Xan Lopez <​xlopez@igalia.com> on 2017-04-20
Reviewed by Carlos Garcia Campos.

Update glib and glib-networking to the last stable releases. This
is needed to get working TLS certificate verification at all at
least in Fedora.

• gtk/install-dependencies: add libmount, needed for newer glib.
• gtk/jhbuild.modules: update glib and glib-networking to last

stable releases.

2:02 AM Changeset in webkit [215555] by zandobersek@gmail.com

• 2 edits in trunk/Source/WebCore

Register missing AES_CTR, ECDSA and HKDF algorithms in
GCrypt's CryptoAlgorithmRegistry implementation.

Rubber-stamped by Carlos Alberto Lopez Perez.

• crypto/gcrypt/CryptoAlgorithmRegistryGCrypt.cpp:

(WebCore::CryptoAlgorithmRegistry::platformRegisterAlgorithms):

1:48 AM Changeset in webkit [215554] by jdiggs@igalia.com

• 19 edits in trunk

[ATK] Implement support for DPub ARIA roles
​https://bugs.webkit.org/show_bug.cgi?id=170679

Reviewed by Chris Fleizach.

Source/WebCore:

Create two new WebCore AccessibilityRole values: TextGroup and ApplicationTextGroup.
These roles make it possible for platforms to distinguish groups which are primarily
intended to display textual content from groups which are primarily intended to hold
user-interface objects. Use these roles to fix the ATK mapping of DPub's groups, which
should be exposed as ATK_ROLE_SECTION; not ATK_ROLE_PANEL.

Modify the following WebCore AccessibilityRole mappings:

• doc-abstract changed to ApplicationTextGroupRole because this DPub ARIA role does not subclass the ARIA landmark role
• doc-biblioentry and doc-endnote changed to ListItemRole, because these DPub ARIA roles subclass the ARIA listitem role
• doc-notice and doc-tip changed to DocumentNoteRole because these DPub ARIA roles subclass the ARIA note role
• doc-pagebreak changed to SplitterRole because this DPub ARIA role subclasses the ARIA separator role

No new tests required: New test cases were added to xml-roles-exposed.html, and
the platform expectations for roles-exposed.html were updated to reflect the
correct mappings.

• accessibility/AccessibilityList.cpp:

(WebCore::AccessibilityList::determineAccessibilityRole):

• accessibility/AccessibilityNodeObject.cpp:

(WebCore::AccessibilityNodeObject::isGroup):
(WebCore::AccessibilityNodeObject::helpText):

• accessibility/AccessibilityObject.cpp:

(WebCore::AccessibilityObject::ariaTreeItemContent):
(WebCore::initializeRoleMap):
(WebCore::AccessibilityObject::computedRoleString):

• accessibility/AccessibilityObject.h:
• accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::helpText):
(WebCore::AccessibilityRenderObject::shouldFocusActiveDescendant):
(WebCore::AccessibilityRenderObject::determineAccessibilityRole):

• accessibility/atk/WebKitAccessibleWrapperAtk.cpp:

(webkitAccessibleGetAttributes):
(atkRole):
(roleIsTextType):

• accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:

(-[WebAccessibilityObjectWrapper determineIsAccessibilityElement]):
(-[WebAccessibilityObjectWrapper containsUnnaturallySegmentedChildren]):

• accessibility/mac/WebAccessibilityObjectWrapperMac.mm:

(createAccessibilityRoleMap):
(-[WebAccessibilityObjectWrapper subrole]):

Tools:

Add DPub ARIA landmark roles to roleToString().

• WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:

LayoutTests:

Update tests and expectations to reflect the modified WebCore Accessibility
role mappings, and the corresponding changes for the platforms.

• accessibility/gtk/xml-roles-exposed-expected.txt:
• accessibility/gtk/xml-roles-exposed.html:
• accessibility/roles-exposed.html:
• inspector/dom/getAccessibilityPropertiesForNode-expected.txt:
• platform/gtk/TestExpectations:
• platform/gtk/accessibility/roles-exposed-expected.txt:
• platform/mac/accessibility/roles-exposed-expected.txt:

Apr 19, 2017:

11:26 PM Changeset in webkit [215553] by Michael Catanzaro

• 3 edits in trunk/Source/ThirdParty

[GTK] ../../Source/ThirdParty/xdgmime/src/xdgmimecache.c:200:62: warning: pointer of type ‘void *’ used in arithmetic [-Wpointer-arith]
​https://bugs.webkit.org/show_bug.cgi?id=171026

Reviewed by Carlos Garcia Campos.

• xdgmime/README.webkit:
• xdgmime/src/xdgmimecache.c:

(cache_magic_matchlet_compare_to_data):

10:26 PM Changeset in webkit [215552] by commit-queue@webkit.org

• 6 edits in trunk

Remove WebKitTestRunner code for enabling features that are already enabled by default
​https://bugs.webkit.org/show_bug.cgi?id=171033

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2017-04-19
Reviewed by Ryosuke Niwa.

Source/WebKit2:

• WebProcess/InjectedBundle/InjectedBundle.cpp:

(WebKit::InjectedBundle::overrideBoolPreferenceForTestRunner):

Tools:

• WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:

(WTR::InjectedBundle::beginTesting):

• WebKitTestRunner/InjectedBundle/TestRunner.cpp:

(WTR::TestRunner::setShadowDOMEnabled): Deleted.
(WTR::TestRunner::setCustomElementsEnabled): Deleted.
(WTR::TestRunner::setFetchAPIEnabled): Deleted.
(WTR::TestRunner::setDownloadAttributeEnabled): Deleted.

• WebKitTestRunner/InjectedBundle/TestRunner.h:

9:36 PM Changeset in webkit [215551] by Brent Fulgham

• 4 edits in trunk/Source/WebKit/win

[Win] REGRESSION(r215486): Windows Release build is broken
​https://bugs.webkit.org/show_bug.cgi?id=171024
<rdar://problem/31722618>

Reviewed by Mark Lam.

Windows WebKit refers to a handful of JSC methods that are always
inline. We need to include 'HeapInlines.h' to get the implementation
of these methods.

• Plugins/PluginPackage.cpp:
• WebFrame.cpp:
• WebView.cpp:

8:40 PM Changeset in webkit [215550] by Ryan Haddad

• 2 edits in trunk/LayoutTests

Mark imported/w3c/web-platform-tests/WebCryptoAPI/derive_bits_keys/hkdf.worker.html as flaky.
​https://bugs.webkit.org/show_bug.cgi?id=170907

Unreviewed test gardening.

• platform/mac-wk2/TestExpectations:

8:40 PM Changeset in webkit [215549] by Ryan Haddad

• 2 edits in trunk/LayoutTests

Rebaseline imported/w3c/web-platform-tests/html/dom/reflection-embedded.html.

Unreviewed test gardening.

• platform/ios-wk2/imported/w3c/web-platform-tests/html/dom/reflection-embedded-expected.txt:

8:08 PM Changeset in webkit [215548] by commit-queue@webkit.org

• 18 edits
  2 copies in trunk

[Mac] Allow customizing H264 encoder
​https://bugs.webkit.org/show_bug.cgi?id=170829

Patch by Youenn Fablet <​youenn@apple.com> on 2017-04-19
Reviewed by Alex Christensen.

Source/JavaScriptCore:

• Configurations/FeatureDefines.xcconfig:

Source/ThirdParty/libwebrtc:

• Configurations/libwebrtc.xcconfig:
• Source/webrtc/sdk/objc/Framework/Classes/h264_video_toolbox_encoder.h:
• Source/webrtc/sdk/objc/Framework/Classes/h264_video_toolbox_encoder.mm:

(webrtc::H264VideoToolboxEncoder::ResetCompressionSession):
(webrtc::H264VideoToolboxEncoder::CreateCompressionSession): Default implementation, fixing memory leak for dictionary.

• Source/webrtc/sdk/objc/Framework/Classes/videotoolboxvideocodecfactory.cc:

Source/WebCore:

Using WebKitAdditions CreateCompressionSession if available.

• Configurations/FeatureDefines.xcconfig:
• WebCore.xcodeproj/project.pbxproj:
• platform/mediastream/libwebrtc/H264VideoToolBoxEncoder.h: Added.
• platform/mediastream/libwebrtc/H264VideoToolBoxEncoder.mm: Added.

(WebCore::H264VideoToolboxEncoder::CreateCompressionSession):

• platform/mediastream/libwebrtc/VideoToolBoxEncoderFactory.cpp:

(WebCore::VideoToolboxVideoEncoderFactory::CreateSupportedVideoEncoder):

Source/WebCore/PAL:

• Configurations/FeatureDefines.xcconfig:

Source/WebKit/mac:

• Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

• Configurations/FeatureDefines.xcconfig:
• WebKit2.xcodeproj/project.pbxproj:

Tools:

• TestWebKitAPI/Configurations/FeatureDefines.xcconfig:

7:29 PM Changeset in webkit [215547] by Ryan Haddad

• 2 edits in trunk/LayoutTests

Mark imported/w3c/web-platform-tests/XMLHttpRequest/getallresponseheaders-cl.htm as failing.
​https://bugs.webkit.org/show_bug.cgi?id=171031

Unreviewed test gardening.

• TestExpectations:

5:53 PM Changeset in webkit [215546] by eric.carlson@apple.com

• 3 edits in trunk/Source/WebCore

Another deadlock in CoreAudioCaptureSource
​https://bugs.webkit.org/show_bug.cgi?id=171001

Fix another regression introduced by r215201, plus make changes suggested
in the review of 170771.

Reviewed by Youenn Fablet.

• platform/mediastream/mac/CoreAudioCaptureSource.cpp:

(WebCore::CoreAudioCaptureSource::configureSpeakerProc): Assert if the lock is no held.
(WebCore::CoreAudioCaptureSource::provideSpeakerData): Don't reset the buffer.
(WebCore::CoreAudioCaptureSource::processMicrophoneSamples): Take the state lock. Don't
reset the buffer. No more microphone callbacks.
(WebCore::CoreAudioCaptureSource::stopProducingData): Return early if the io unit isn't
running. Drop the lock before calling setMuted to avoid another deadlock.
(WebCore::CoreAudioCaptureSource::addMicrophoneDataConsumer): Deleted.
(WebCore::CoreAudioCaptureSource::removeMicrophoneDataConsumer): Deleted.

• platform/mediastream/mac/CoreAudioCaptureSource.h:

5:43 PM Changeset in webkit [215545] by beidson@apple.com

• 10 edits in trunk

Add asynchronous equivalent of -[<WKUIDelegate> webView:createWebViewWithConfiguration:...].
<rdar://problem/30699851> and ​https://bugs.webkit.org/show_bug.cgi?id=171018

Reviewed by Tim Horton.

Source/WebKit2:

• UIProcess/API/APIUIClient.h:

(API::UIClient::createNewPageAsync):

• UIProcess/API/Cocoa/WKUIDelegatePrivate.h:

• UIProcess/Cocoa/UIDelegate.h:
• UIProcess/Cocoa/UIDelegate.mm:

(WebKit::UIDelegate::setDelegate):
(WebKit::UIDelegate::UIClient::createNewPageCommon):
(WebKit::UIDelegate::UIClient::createNewPage):
(WebKit::UIDelegate::UIClient::createNewPageAsync):

• UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::createNewPage):

• UIProcess/WebPageProxy.h:
• UIProcess/WebPageProxy.messages.in:

Tools:

• TestWebKitAPI/Tests/WebKit2Cocoa/OpenAndCloseWindow.mm:

(TEST):
(-[OpenAndCloseWindowUIDelegateAsync webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
(-[OpenAndCloseWindowUIDelegateAsync _webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:completionHandler:]):

4:48 PM Changeset in webkit [215544] by commit-queue@webkit.org

• 2 edits in trunk/Source/WTF

[Win] Activate streams API by default
​https://bugs.webkit.org/show_bug.cgi?id=171000

Patch by Youenn Fablet <​youenn@apple.com> on 2017-04-19
Reviewed by Brent Fulgham.

• wtf/FeatureDefines.h:

4:41 PM Changeset in webkit [215543] by Nikita Vasilyev

• 2 edits in trunk/Source/WebInspectorUI

REGRESSION (r209882): Web Inspector: Console's filter bar has text search field, but the next/previous buttons don't do anything
​https://bugs.webkit.org/show_bug.cgi?id=170556
<rdar://problem/31481755>

Reviewed by Matt Baker.

• UserInterface/Views/LogContentView.js:

(WebInspector.LogContentView.prototype.performSearch):
Update numberOfResults setter, which sets "disabled" attribute to false when numberOfResults > 0.

4:38 PM Changeset in webkit [215542] by Ryan Haddad

• 3 edits
  4 deletes in trunk/LayoutTests

Remove two tests after r215515.
​https://bugs.webkit.org/show_bug.cgi?id=171014

Unreviewed test gardening.

LayoutTests/imported/w3c:

• web-platform-tests/fetch/api/basic/scheme-about.worker-expected.txt: Removed.
• web-platform-tests/fetch/api/basic/scheme-about.worker.html: Removed.
• web-platform-tests/user-timing/clear_one_measure.worker-expected.txt: Removed.
• web-platform-tests/user-timing/clear_one_measure.worker.html: Removed.

LayoutTests:

• TestExpectations:

4:30 PM Changeset in webkit [215541] by andersca@apple.com

• 21 edits in trunk/Source

Stop using deprecated APIs, part 3
​https://bugs.webkit.org/show_bug.cgi?id=171003
rdar://problem/31589635
Source/WebCore:

rdar://problem/31589635

Reviewed by Tim Horton.

• Modules/applepay/ApplePaySession.cpp:

(WebCore::convertAndValidate):
The status member variable has been removed from ApplePayShippingMethodUpdate.

(WebCore::ApplePaySession::completeShippingMethodSelection):
If status is not STATUS_SUCCESS, cancel the payment session.

(WebCore::ApplePaySession::canSuspendForDocumentSuspension):
(WebCore::ApplePaySession::canBegin):
(WebCore::ApplePaySession::canAbort):
(WebCore::ApplePaySession::canCancel):
(WebCore::ApplePaySession::canCompleteShippingMethodSelection):
(WebCore::ApplePaySession::canCompleteShippingContactSelection):
(WebCore::ApplePaySession::canCompletePaymentMethodSelection):
(WebCore::ApplePaySession::canCompletePayment):
(WebCore::ApplePaySession::isFinalState):
Add State::CancelRequested.

• Modules/applepay/ApplePayShippingMethodUpdate.h:
• Modules/applepay/ApplePayShippingMethodUpdate.idl:

Remove status.

• Modules/applepay/PaymentCoordinator.cpp:

(WebCore::PaymentCoordinator::cancelPaymentSession):
Call through to the client.

• Modules/applepay/PaymentCoordinator.h:
• Modules/applepay/PaymentCoordinatorClient.h:

Add cancelPaymentSession().

• Modules/applepay/PaymentRequest.h:

Remove status.

• loader/EmptyClients.cpp:

Add new client member function.

Source/WebKit/mac:

Reviewed by Tim Horton.

• WebCoreSupport/WebPaymentCoordinatorClient.h:
• WebCoreSupport/WebPaymentCoordinatorClient.mm:

(WebPaymentCoordinatorClient::cancelPaymentSession):
Update for WebCore changes.

Source/WebKit2:

Reviewed by Tim Horton.

• Shared/Cocoa/WebCoreArgumentCodersCocoa.mm:

(IPC::ArgumentCoder<WebCore::ShippingMethodUpdate>::encode):
(IPC::ArgumentCoder<WebCore::ShippingMethodUpdate>::decode):
Don't encode/decode status.

• UIProcess/ApplePay/WebPaymentCoordinatorProxy.cpp:

(WebKit::WebPaymentCoordinatorProxy::cancelPaymentSession):
Hide the UI and report back.

• UIProcess/ApplePay/WebPaymentCoordinatorProxy.h:

Add new member.

• UIProcess/ApplePay/WebPaymentCoordinatorProxy.messages.in:

Add new message.

• UIProcess/ApplePay/cocoa/WebPaymentCoordinatorProxyCocoa.mm:

(WebKit::WebPaymentCoordinatorProxy::platformCompleteShippingMethodSelection):
Always pass success in the old code path. Stop using the deprecated method.

• WebProcess/ApplePay/WebPaymentCoordinator.cpp:

(WebKit::WebPaymentCoordinator::cancelPaymentSession):
Send a message to the UI process.

• WebProcess/ApplePay/WebPaymentCoordinator.h:

Add new member.

4:27 PM Changeset in webkit [215540] by Ryan Haddad

• 12 edits in trunk/LayoutTests

Rebaseline tests after r215515.
​https://bugs.webkit.org/show_bug.cgi?id=171014

Unreviewed test gardening.

LayoutTests/imported/w3c:

• web-platform-tests/XMLHttpRequest/getallresponseheaders-cl-expected.txt:
• web-platform-tests/fetch/api/redirect/redirect-count-expected.txt:
• web-platform-tests/fetch/api/redirect/redirect-count-worker-expected.txt:
• web-platform-tests/fetch/api/redirect/redirect-location-expected.txt:
• web-platform-tests/fetch/api/redirect/redirect-location-worker-expected.txt:
• web-platform-tests/html/webappapis/timers/negative-settimeout-expected.txt:

LayoutTests:

• TestExpectations:
• platform/ios-wk2/imported/w3c/web-platform-tests/html/dom/reflection-embedded-expected.txt:
• platform/ios/imported/w3c/web-platform-tests/html/browsers/browsing-the-web/history-traversal/persisted-user-state-restoration/scroll-restoration-fragment-scrolling-cross-origin-expected.txt:
• platform/ios/imported/w3c/web-platform-tests/html/dom/reflection-embedded-expected.txt:

4:23 PM Changeset in webkit [215539] by msaboff@apple.com

• 2 edits in trunk/Source/JavaScriptCore

Tune GC related JSC options for iOS
​https://bugs.webkit.org/show_bug.cgi?id=171019

Reviewed by Mark Lam.

Always set these GC options on iOS.

• runtime/Options.cpp:

(JSC::overrideDefaults):

4:21 PM Changeset in webkit [215538] by ddkilzer@apple.com

• 2 edits in trunk/Source/WTF

Vector.h: error: 'auto' not allowed in lambda parameter
<​https://webkit.org/b/171010>
<rdar://problem/31716076>

Reviewed by Saam Barati.

• wtf/Vector.h:

(WTF::removeRepeatedElements): Replace 'auto' with a specific
type, 'T', based on a Vector<> template type.

4:13 PM Changeset in webkit [215537] by eric.carlson@apple.com

• 12 edits in trunk/Source

[MediaStream] Limit capture to one tab at a time
​https://bugs.webkit.org/show_bug.cgi?id=171009

Reviewed by Jon Lee.

Source/WebCore:

No new tests yet, filed bug 171011.

• Modules/mediastream/MediaStreamTrack.cpp:

(WebCore::MediaStreamTrack::stopTrack): Drive-by fix: renamed from stopProducingData
because stopProducingData is a method in RealtimeMediaSource that does something different.
(WebCore::MediaStreamTrack::stop): Call stopTrack.
(WebCore::MediaStreamTrack::stopProducingData): Deleted.

• Modules/mediastream/MediaStreamTrack.h:
• Modules/mediastream/MediaStreamTrack.idl:

• Modules/mediastream/RTCRtpSender.cpp:

(WebCore::RTCRtpSender::replaceTrack): Update for rename.

• platform/mediastream/MediaStreamPrivate.cpp:

(WebCore::MediaStreamPrivate::muted): Drive-by fix: a track that has ended but
which is not muted will never produce data.

Source/WebKit2:

• UIProcess/UserMediaPermissionRequestManagerProxy.cpp:

(WebKit::UserMediaPermissionRequestManagerProxy::stopCapture): Deleted, not used.

• UIProcess/UserMediaPermissionRequestManagerProxy.h:

• UIProcess/UserMediaProcessManager.cpp:

(WebKit::UserMediaProcessManager::willEnableMediaStreamInPage): Mute media streams
on other pages.
(WebKit::UserMediaProcessManager::willCreateMediaStream): Call willEnableMediaStreamInPage.

• UIProcess/UserMediaProcessManager.h:

• UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::setMuted): If media streams in the page will be unmuted, call
willEnableMediaStreamInPage so streams in other pages are muted first.

3:43 PM Changeset in webkit [215536] by beidson@apple.com

• 6 edits
  1 add in trunk

REGRESSION (r213168): An extra Web Content process is spun up on launch and is never closed.
<rdar://problem/30774839> and ​https://bugs.webkit.org/show_bug.cgi?id=171002

Reviewed by Alex Christensen.

Source/WebKit2:

The original change unnecessarily avoided using the initial warmed process if an explicit
data store was set on the new WKWebView.

Fixing that fixes the regression.

• UIProcess/API/Cocoa/WKProcessPool.mm:

(-[WKProcessPool _webProcessCount]):

• UIProcess/API/Cocoa/WKProcessPoolPrivate.h:

• UIProcess/WebProcessPool.cpp:

(WebKit::WebProcessPool::createWebPage):

Tools:

• TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
• TestWebKitAPI/Tests/WebKit2Cocoa/InitialWarmedProcessUsed.mm: Added.

3:27 PM Changeset in webkit [215535] by achristensen@apple.com

• 3 edits
  2 adds in trunk

Parsing large XML strings fails
​https://bugs.webkit.org/show_bug.cgi?id=170999
<rdar://problem/17336267>

Reviewed by Brady Eidson.

Source/WebCore:

Test: fast/dom/xml-large.html

• xml/parser/XMLDocumentParserLibxml2.cpp:

(WebCore::XMLParserContext::createStringParser):
(WebCore::XMLParserContext::createMemoryParser):
Allow huge XML strings. They work fine in Chrome and Firefox.

LayoutTests:

• fast/dom/xml-large-expected.txt: Added.
• fast/dom/xml-large.html: Added.

3:06 PM Changeset in webkit [215534] by Ryan Haddad

• 4 edits
  1 delete in trunk/Source/WTF

Unreviewed, rolling out r215518.

This change appears to have broken the Windows build.

Reverted changeset:

"Move notFound into its own file"
​https://bugs.webkit.org/show_bug.cgi?id=170972
​http://trac.webkit.org/changeset/215518

3:05 PM Changeset in webkit [215533] by jfbastien@apple.com

• 12 edits in trunk/Source/JavaScriptCore

WebAssembly: fast memory cleanups
​https://bugs.webkit.org/show_bug.cgi?id=170909

Reviewed by Saam Barati.

• b3/B3LowerToAir.cpp: correct comment, and make wasm-independent

(JSC::B3::Air::LowerToAir::lower):

• b3/B3Procedure.h:
• b3/B3Validate.cpp:
• b3/B3Value.cpp:

(JSC::B3::Value::effects):

• b3/B3WasmBoundsCheckValue.cpp: have the creator pass in a

maximum, so we don't have to know so much about wasm here
(JSC::B3::WasmBoundsCheckValue::WasmBoundsCheckValue):
(JSC::B3::WasmBoundsCheckValue::cloneImpl):
(JSC::B3::WasmBoundsCheckValue::dumpMeta):

• b3/B3WasmBoundsCheckValue.h:

(JSC::B3::WasmBoundsCheckValue::boundsType):
(JSC::B3::WasmBoundsCheckValue::bounds):

• b3/air/AirCode.h:
• b3/air/AirCustom.h:

(JSC::B3::Air::WasmBoundsCheckCustom::generate):

• b3/testb3.cpp:

(JSC::B3::testWasmBoundsCheck):

• wasm/WasmB3IRGenerator.cpp:

(JSC::Wasm::B3IRGenerator::B3IRGenerator):
(JSC::Wasm::B3IRGenerator::emitCheckAndPreparePointer):
(JSC::Wasm::createJSToWasmWrapper): remove dead code

• wasm/WasmMemory.cpp: don't GC if no memory could possibly be free'd

(JSC::Wasm::Memory::initializePreallocations): verbose-only code,
and copy-pasta bug

2:58 PM Changeset in webkit [215532] by Chris Fleizach

• 7 edits in trunk

AX: <hr> should use a different role description than interactive separators
​https://bugs.webkit.org/show_bug.cgi?id=170317
<rdar://problem/31363024>

Reviewed by Joanmarie Diggs.

Source/WebCore:

Users are confused with WebKit's accessibility description of separators.
We should call these what they are, horizontal rules.

Updated test: accessibility/mac/hr-element-expected.txt

• English.lproj/Localizable.strings:
• accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::orientation):

• platform/cocoa/LocalizedStringsCocoa.mm:

(WebCore::AXHorizontalRuleDescriptionText):

LayoutTests:

• accessibility/mac/hr-element-expected.txt:
• accessibility/mac/hr-element.html:

2:51 PM Changeset in webkit [215531] by mark.lam@apple.com

• 6 edits
  1 add in trunk

B3StackmapSpecial should handle when stackmap values are not recoverable from a Def'ed arg.
​https://bugs.webkit.org/show_bug.cgi?id=170973
<rdar://problem/30318657>

Reviewed by Filip Pizlo.

JSTests:

• stress/regress-170973.js: Added.

Source/JavaScriptCore:

In the event of an arithmetic overflow on a binary sub instruction (where the
result register is same as one of the operand registers), the CheckSub FTL
operation will try to recover the original value in the clobbered result register.

This recover is done by adding the other operand value to the result register.
However, this recovery method only works if the width of the original value in
the result register is less or equal to the width of the expected result. If the
width of the original operand value (e.g. a JSInt32) is wider than the result
(e.g. a machine Int32), then the sub operation would have zero extended the
result and cleared the upper 32-bits of the result register. Recovery by adding
back the other operand will not restore the JSValue tag in the upper word.

This poses a problem if the stackmap value for the operand relies on that same
clobbered register.

The fix is to detect this potential scenario (i.e. width of the Def's arg < width
of a stackmap value). If this condition is detected, we'll declare the stackmap
value to be LateColdUse to ensure that the register allocator gives it a
different register if needed so that it's not dependent on the clobbered register.

• b3/B3CheckSpecial.cpp:

(JSC::B3::CheckSpecial::forEachArg):

• b3/B3PatchpointSpecial.cpp:

(JSC::B3::PatchpointSpecial::forEachArg):

• b3/B3StackmapSpecial.cpp:

(JSC::B3::StackmapSpecial::forEachArgImpl):

• b3/B3StackmapSpecial.h:

2:30 PM Changeset in webkit [215530] by andersca@apple.com

• 12 edits in trunk/Source

Rename cancelPayment to cancelPaymentSession
​https://bugs.webkit.org/show_bug.cgi?id=171007

Reviewed by Tim Horton.

Source/WebCore:

• Modules/applepay/ApplePaySession.cpp:

(WebCore::ApplePaySession::didCancelPaymentSession):
(WebCore::ApplePaySession::didCancelPayment): Deleted.

• Modules/applepay/ApplePaySession.h:
• Modules/applepay/PaymentCoordinator.cpp:

(WebCore::PaymentCoordinator::didCancelPaymentSession):
(WebCore::PaymentCoordinator::didCancelPayment): Deleted.

• Modules/applepay/PaymentCoordinator.h:

Source/WebKit2:

• UIProcess/ApplePay/WebPaymentCoordinatorProxy.cpp:

(WebKit::WebPaymentCoordinatorProxy::showPaymentUI):
(WebKit::WebPaymentCoordinatorProxy::didCancelPaymentSession):
(WebKit::WebPaymentCoordinatorProxy::didCancelPayment): Deleted.

• UIProcess/ApplePay/WebPaymentCoordinatorProxy.h:
• UIProcess/ApplePay/cocoa/WebPaymentCoordinatorProxyCocoa.mm:

(-[WKPaymentAuthorizationViewControllerDelegate paymentAuthorizationViewControllerDidFinish:]):

• WebProcess/ApplePay/WebPaymentCoordinator.cpp:

(WebKit::WebPaymentCoordinator::didCancelPaymentSession):
(WebKit::WebPaymentCoordinator::didCancelPayment): Deleted.

• WebProcess/ApplePay/WebPaymentCoordinator.h:
• WebProcess/ApplePay/WebPaymentCoordinator.messages.in:

2:00 PM Changeset in webkit [215529] by mitz@apple.com

• 8 copies
  1 add in releases/Apple/Safari Technology Preview 28

Added a tag for Safari Technology Preview release 28.

1:22 PM Changeset in webkit [215528] by commit-queue@webkit.org

• 3 edits in trunk/Source/WebCore

ASAN Crash running LayoutTests/inspector/worker tests
​https://bugs.webkit.org/show_bug.cgi?id=170967
<rdar://problem/31256437>

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2017-04-19
Reviewed by Alex Christensen.

• workers/WorkerMessagingProxy.h:
• workers/WorkerMessagingProxy.cpp:

(WebCore::WorkerMessagingProxy::WorkerMessagingProxy):
(WebCore::WorkerMessagingProxy::workerGlobalScopeDestroyedInternal):
Make the MessagingProxy thread safe ref counted. Since it used to
delete itself, turn this into a ref (implicit on construction)
and deref (replacing delete this).

(WebCore::WorkerMessagingProxy::postMessageToPageInspector):
When dispatching have the lambda implicitly ref/deref with the
lambda to keep the proxy alive while a lambda is queued.

1:20 PM Changeset in webkit [215527] by Ryan Haddad

• 2 edits in trunk/Source/ThirdParty/ANGLE

Remove executable property from a header file.

• include/KHR/khrplatform.h: Removed property svn:executable.

1:03 PM Changeset in webkit [215526] by jfbastien@apple.com

• 8 edits
  1 delete in trunk

Unreviewed, rolling out r215520.

Broke Debian 8

Reverted changeset:

"[INTL] Implement Intl.DateTimeFormat.prototype.formatToParts"
​https://bugs.webkit.org/show_bug.cgi?id=169458
​http://trac.webkit.org/changeset/215520

12:38 PM Changeset in webkit [215525] by jfbastien@apple.com

• 4 edits
  2 adds in trunk

WebAssembly: limit slow memories
​https://bugs.webkit.org/show_bug.cgi?id=170825

Reviewed by Saam Barati.

JSTests:

• wasm.yaml:
• wasm/stress/oom.js: Added.

(try.true.WebAssemblyMemoryMode):
(catch):

Source/JavaScriptCore:

We limits the number of fast memories, partly because ASLR. The
code then falls back to slow memories. It first tries to virtually
allocated any declared maximum (and in there, physically the
initial), and if that fails it tries to physically allocate the
initial without any extra.

This can still be used to cause a bunch of virtual
allocation. This patch imposes soft limit on slow memories as
well. The total virtual maximum for slow memories is set at the
same (theoretical) value as that for fast memories.

Anything exceeding that limit causes allocation/grow to fail.

• wasm/WasmMemory.cpp:

12:11 PM Changeset in webkit [215524] by Brent Fulgham

• 2 edits in trunk/Tools

[WK2] Run tests with ResourceLoadStatistics enabled
​https://bugs.webkit.org/show_bug.cgi?id=170952

Reviewed by Andy Estes.

Excercise the load statistics code during tests.

• WebKitTestRunner/cocoa/TestControllerCocoa.mm:

(WTR::initializeWebViewConfiguration):

11:57 AM Changeset in webkit [215523] by commit-queue@webkit.org

• 2 edits in trunk/Tools

close_fds should be set to False on Windows.
​https://bugs.webkit.org/show_bug.cgi?id=170838

Patch by Bill Ming <​mbbill@gmail.com> on 2017-04-19
Reviewed by Brent Fulgham.

• Scripts/webkitpy/common/system/executive.py:

(Executive._should_close_fds):

11:25 AM Changeset in webkit [215522] by jfbastien@apple.com

• 2 edits in trunk/Source/JavaScriptCore

Cannot compile JavaScriptCore/runtime/VMTraps.cpp on FreeBSD because std::pair has a non-trivial copy constructor
​https://bugs.webkit.org/show_bug.cgi?id=170875

Reviewed by Mark Lam.

WTF::ExpectedDetail::ConstexprBase doesn't have a user-defined
copy constructor, and its implicitly-defined copy constructor is
deleted because the default std::pair implementation on FreeBSD
has a non-trivial copy constructor. /usr/include/c++/v1/config
says _LIBCPP_TRIVIAL_PAIR_COPY_CTOR is disabled in order to keep
ABI compatibility:
​https://svnweb.freebsd.org/changeset/base/261801.

That's a huge bummer, and I'm not a fan of broken stdlibs, but in
this case it's pretty nice to have a custom named type anyways and
costs nothing.

• runtime/VMTraps.cpp:

(JSC::findActiveVMAndStackBounds):
(JSC::handleSigusr1):
(JSC::handleSigtrap):

11:17 AM Changeset in webkit [215521] by ddkilzer@apple.com

• 6 edits
  1 add in trunk

Stop using strcpy() in WebKit::EnvironmentUtilities::stripValuesEndingWithString()
<​https://webkit.org/b/170994>
<rdar://problem/29889932>

Reviewed by Brent Fulgham.

Source/WebKit2:

• Platform/unix/EnvironmentUtilities.cpp:

(WebKit::EnvironmentUtilities::stripValuesEndingWithString):
Switch from using strcpy() to strlcpy(). Also switch from using
strstr() to strnstr().

• Platform/unix/EnvironmentUtilities.h: Switch to #pragma once.

(WebKit::EnvironmentUtilities::stripValuesEndingWithString):
Export function for testing.

• WebKit2.xcodeproj/project.pbxproj:

(EnvironmentUtilitiesTest.h): Make header private for testing.

Tools:

• TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:

(EnvironmentUtilitiesTest.cpp): Add to TestWebKitAPILibrary
target.

• TestWebKitAPI/Tests/WebKit2/EnvironmentUtilitiesTest.cpp: Add.

(TestWebKitAPI::strip): Helper method to set/get environment
variable for testing.
(TestWebKitAPI::WebKit2_StripValuesEndingWithString_Test): Add
tests.

11:08 AM Changeset in webkit [215520] by commit-queue@webkit.org

• 8 edits
  1 add in trunk

[INTL] Implement Intl.DateTimeFormat.prototype.formatToParts
​https://bugs.webkit.org/show_bug.cgi?id=169458

Patch by Andy VanWagoner <​thetalecrafter@gmail.com> on 2017-04-19
Reviewed by JF Bastien.

Source/JavaScriptCore:

Use udat_formatForFields to iterate through the parts of a formatted date string.

• icu/unicode/udat.h: Update to 55.1.
• icu/unicode/ufieldpositer.h: Added from 55.1.
• runtime/IntlDateTimeFormat.cpp:

(JSC::IntlDateTimeFormat::partTypeString): Convert UDateFormatField to string.
(JSC::IntlDateTimeFormat::formatToParts): Return parts of formatted date string.

• runtime/IntlDateTimeFormat.h:
• runtime/IntlDateTimeFormatPrototype.cpp:

(JSC::IntlDateTimeFormatPrototypeFuncFormatToParts): Add prototype function formatToParts.

LayoutTests:

Add tests for formatToParts

• js/intl-datetimeformat-expected.txt:
• js/script-tests/intl-datetimeformat.js:

11:02 AM Changeset in webkit [215519] by jfbastien@apple.com

• 2 edits
  1 add in trunk/Tools

WebAssembly: add script which can import GCC torture tests
​https://bugs.webkit.org/show_bug.cgi?id=170740

Reviewed by Saam Barati.

Add a script which can import the GCC torture tests and create a
yaml file to run them as part of jsc's WebAssembly regression
tests.

This patch doesn't commit the tests themselves because they're
licensed differently.

• Scripts/run-jsc-stress-tests: learn how to run

Emscripten-generated .js+.wasm files, and do a bit of cleanup on
the options because WebAssembly is enabled by default.

• Scripts/update-wasm-gcc-torture.py: Added.

(parse_args):
(update_lkgr):
(untar_torture):
(list_js_files):
(waterfall_known_failures):
(create_yaml):
(main):

10:57 AM Changeset in webkit [215518] by commit-queue@webkit.org

• 4 edits
  1 add in trunk/Source/WTF

Move notFound into its own file
​https://bugs.webkit.org/show_bug.cgi?id=170972

Patch by Sam Weinig <​sam@webkit.org> on 2017-04-19
Reviewed by Zalan Bujtas.

It is odd to require including <wtf/Vector.h> just to use WTF::notFound.
This is not causing any current problems, but does in few changes I have
queued up.

• WTF.xcodeproj/project.pbxproj:
• wtf/NotFound.h: Added.
• wtf/Vector.h:
• wtf/text/StringCommon.h:

10:12 AM Changeset in webkit [215517] by jfbastien@apple.com

• 4 edits
  2 adds in trunk

WebAssembly: don't expose any WebAssembly JS object if JIT is off
​https://bugs.webkit.org/show_bug.cgi?id=170782

Reviewed by Saam Barati.

JSTests:

• wasm.yaml:
• wasm/noJIT/noJIT.js: Added.

Source/JavaScriptCore:

It's unexpected that we expose the global WebAssembly object if no
JIT is present because it can't be used to compile or
instantiate. Other APIs such as Memory should also be Inaccessible
in those circumstances.

Also ensure that we don't pre-allocate fast memories if
WebAssembly won't be used, and don't mark our intention to use a
fast TLS slot for WebAssembly.

• runtime/Options.cpp:

(JSC::recomputeDependentOptions):

9:49 AM Changeset in webkit [215516] by Yusuke Suzuki

• 5 edits in trunk/Source/JavaScriptCore

r211670 broke double to int conversion.
​https://bugs.webkit.org/show_bug.cgi?id=170961

Reviewed by Mark Lam.

In this patch, we take a template parameter way.
While it reduces duplicate code, it effectively produces
optimized code for operationToInt32SensibleSlow,
and fixes kraken pbkdf2 regression on Linux.

And this patch also fixes undefined behavior by changing
int32_t to uint32_t. If exp is 31, missingOne is 1 << 31,
INT32_MIN. Thus missingOne - 1 will cause int32_t overflow,
and it is an undefined behavior.

• runtime/MathCommon.cpp:

(JSC::operationToInt32SensibleSlow):

• runtime/MathCommon.h:

(JSC::toInt32Internal):
(JSC::toInt32):

9:32 AM Changeset in webkit [215515] by Ryan Haddad

• 55 edits
  4 copies
  40 moves
  1129 adds
  42 deletes in trunk

LayoutTests/imported/w3c:
Adding wpt tools

Import web-platform-tests/tools
​https://bugs.webkit.org/show_bug.cgi?id=170718

Patch by Youenn Fablet <​youenn@apple.com> on 2017-04-19
Reviewed by Alex Christensen.

• resources/TestRepositories:
• resources/import-expectations.json:
• resources/resource-files.json:
• resources/web-platform-tests-modules.json: Removed.
• web-platform-tests/.gitignore:
• web-platform-tests/XMLHttpRequest/XMLHttpRequest-withCredentials.any.worker-expected.txt: Added.
• web-platform-tests/XMLHttpRequest/XMLHttpRequest-withCredentials.any.worker.html: Copied from LayoutTests/imported/w3c/web-platform-tests/XMLHttpRequest/XMLHttpRequest-withCredentials.worker.html.
• web-platform-tests/XMLHttpRequest/XMLHttpRequest-withCredentials.worker-expected.txt: Removed.
• web-platform-tests/XMLHttpRequest/getallresponseheaders-cl-expected.txt:
• web-platform-tests/XMLHttpRequest/responsetype-expected.txt:
• web-platform-tests/XMLHttpRequest/send-usp.any.worker-expected.txt: Renamed from LayoutTests/imported/w3c/web-platform-tests/XMLHttpRequest/send-usp.worker-expected.txt.
• web-platform-tests/XMLHttpRequest/send-usp.any.worker.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/XMLHttpRequest/send-usp.worker.html.
• web-platform-tests/XMLHttpRequest/send-usp.worker.js: Removed.
• web-platform-tests/XMLHttpRequest/timeout-sync-expected.txt:
• web-platform-tests/dom/nodes/Document-contentType/contentType/contenttype_datauri_01-expected.txt:
• web-platform-tests/dom/nodes/Document-contentType/contentType/contenttype_datauri_02-expected.txt:
• web-platform-tests/fetch/api/basic/accept-header.any-expected.txt:
• web-platform-tests/fetch/api/basic/accept-header.any.worker-expected.txt: Added.
• web-platform-tests/fetch/api/basic/accept-header.any.worker.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/fetch/api/basic/accept-header.worker.html.
• web-platform-tests/fetch/api/basic/accept-header.worker-expected.txt: Removed.
• web-platform-tests/fetch/api/basic/mode-same-origin.any-expected.txt:
• web-platform-tests/fetch/api/basic/mode-same-origin.any.worker-expected.txt: Added.
• web-platform-tests/fetch/api/basic/mode-same-origin.any.worker.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/fetch/api/basic/mode-same-origin.worker.html.
• web-platform-tests/fetch/api/basic/mode-same-origin.worker-expected.txt: Removed.
• web-platform-tests/fetch/api/basic/referrer.any-expected.txt:
• web-platform-tests/fetch/api/basic/referrer.any.worker-expected.txt: Added.
• web-platform-tests/fetch/api/basic/referrer.any.worker.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/fetch/api/basic/referrer.worker.html.
• web-platform-tests/fetch/api/basic/referrer.worker-expected.txt: Removed.
• web-platform-tests/fetch/api/basic/request-forbidden-headers.any-expected.txt:
• web-platform-tests/fetch/api/basic/request-forbidden-headers.any.worker-expected.txt: Added.
• web-platform-tests/fetch/api/basic/request-forbidden-headers.any.worker.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/fetch/api/basic/request-forbidden-headers.worker.html.
• web-platform-tests/fetch/api/basic/request-forbidden-headers.worker-expected.txt: Removed.
• web-platform-tests/fetch/api/basic/request-head.any.worker-expected.txt: Added.
• web-platform-tests/fetch/api/basic/request-head.any.worker.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/fetch/api/basic/request-head.worker.html.
• web-platform-tests/fetch/api/basic/request-head.worker-expected.txt: Removed.
• web-platform-tests/fetch/api/basic/request-headers.any-expected.txt:
• web-platform-tests/fetch/api/basic/request-headers.any.worker-expected.txt: Added.
• web-platform-tests/fetch/api/basic/request-headers.any.worker.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/fetch/api/basic/request-headers.worker.html.
• web-platform-tests/fetch/api/basic/request-headers.worker-expected.txt: Removed.
• web-platform-tests/fetch/api/basic/request-referrer-redirected-worker-expected.txt:
• web-platform-tests/fetch/api/basic/request-referrer.any-expected.txt:
• web-platform-tests/fetch/api/basic/request-referrer.any.worker-expected.txt: Added.
• web-platform-tests/fetch/api/basic/request-referrer.any.worker.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/fetch/api/basic/request-referrer.worker.html.
• web-platform-tests/fetch/api/basic/request-referrer.worker-expected.txt: Removed.
• web-platform-tests/fetch/api/basic/request-upload.any-expected.txt:
• web-platform-tests/fetch/api/basic/request-upload.any.worker-expected.txt: Added.
• web-platform-tests/fetch/api/basic/request-upload.any.worker.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/fetch/api/basic/request-upload.worker.html.
• web-platform-tests/fetch/api/basic/request-upload.worker-expected.txt: Removed.
• web-platform-tests/fetch/api/basic/scheme-about.any.worker-expected.txt: Added.
• web-platform-tests/fetch/api/basic/scheme-about.any.worker.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/fetch/api/basic/scheme-data.worker.html.
• web-platform-tests/fetch/api/basic/scheme-about.worker-expected.txt:
• web-platform-tests/fetch/api/basic/scheme-data.any.worker-expected.txt: Added.
• web-platform-tests/fetch/api/basic/scheme-data.any.worker.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/fetch/api/basic/stream-response.worker.html.
• web-platform-tests/fetch/api/basic/scheme-data.worker-expected.txt: Removed.
• web-platform-tests/fetch/api/basic/stream-response.any-expected.txt:
• web-platform-tests/fetch/api/basic/stream-response.any.worker-expected.txt: Added.
• web-platform-tests/fetch/api/basic/stream-response.any.worker.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/fetch/api/cors/cors-basic.worker.html.
• web-platform-tests/fetch/api/basic/stream-response.worker-expected.txt: Removed.
• web-platform-tests/fetch/api/cors/cors-basic.any-expected.txt:
• web-platform-tests/fetch/api/cors/cors-basic.any.worker-expected.txt: Added.
• web-platform-tests/fetch/api/cors/cors-basic.any.worker.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/fetch/api/cors/cors-cookies.worker.html.
• web-platform-tests/fetch/api/cors/cors-basic.worker-expected.txt: Removed.
• web-platform-tests/fetch/api/cors/cors-cookies.any-expected.txt:
• web-platform-tests/fetch/api/cors/cors-cookies.any.worker-expected.txt: Added.
• web-platform-tests/fetch/api/cors/cors-cookies.any.worker.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/fetch/api/cors/cors-no-preflight.worker.html.
• web-platform-tests/fetch/api/cors/cors-cookies.worker-expected.txt: Removed.
• web-platform-tests/fetch/api/cors/cors-no-preflight.any-expected.txt:
• web-platform-tests/fetch/api/cors/cors-no-preflight.any.worker-expected.txt: Added.
• web-platform-tests/fetch/api/cors/cors-no-preflight.any.worker.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/fetch/api/cors/cors-origin.worker.html.
• web-platform-tests/fetch/api/cors/cors-no-preflight.worker-expected.txt: Removed.
• web-platform-tests/fetch/api/cors/cors-origin.any-expected.txt:
• web-platform-tests/fetch/api/cors/cors-origin.any.worker-expected.txt: Added.
• web-platform-tests/fetch/api/cors/cors-origin.any.worker.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/fetch/api/cors/cors-preflight-redirect.worker.html.
• web-platform-tests/fetch/api/cors/cors-origin.worker-expected.txt: Removed.
• web-platform-tests/fetch/api/cors/cors-preflight-redirect.any-expected.txt:
• web-platform-tests/fetch/api/cors/cors-preflight-redirect.any.worker-expected.txt: Added.
• web-platform-tests/fetch/api/cors/cors-preflight-redirect.any.worker.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/fetch/api/cors/cors-preflight-referrer.worker.html.
• web-platform-tests/fetch/api/cors/cors-preflight-redirect.worker-expected.txt: Removed.
• web-platform-tests/fetch/api/cors/cors-preflight-referrer.any-expected.txt:
• web-platform-tests/fetch/api/cors/cors-preflight-referrer.any.worker-expected.txt: Added.
• web-platform-tests/fetch/api/cors/cors-preflight-referrer.any.worker.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/fetch/api/cors/cors-preflight-star.worker.html.
• web-platform-tests/fetch/api/cors/cors-preflight-referrer.worker-expected.txt: Removed.
• web-platform-tests/fetch/api/cors/cors-preflight-star.any-expected.txt:
• web-platform-tests/fetch/api/cors/cors-preflight-star.any.worker-expected.txt: Added.
• web-platform-tests/fetch/api/cors/cors-preflight-star.any.worker.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/fetch/api/cors/cors-preflight-status.worker.html.
• web-platform-tests/fetch/api/cors/cors-preflight-star.worker-expected.txt: Removed.
• web-platform-tests/fetch/api/cors/cors-preflight-status.any-expected.txt:
• web-platform-tests/fetch/api/cors/cors-preflight-status.any.worker-expected.txt: Added.
• web-platform-tests/fetch/api/cors/cors-preflight-status.any.worker.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/fetch/api/cors/cors-preflight.worker.html.
• web-platform-tests/fetch/api/cors/cors-preflight-status.worker-expected.txt: Removed.
• web-platform-tests/fetch/api/cors/cors-preflight.any-expected.txt:
• web-platform-tests/fetch/api/cors/cors-preflight.any.worker-expected.txt: Added.
• web-platform-tests/fetch/api/cors/cors-preflight.any.worker.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/fetch/api/cors/cors-redirect-credentials.worker.html.
• web-platform-tests/fetch/api/cors/cors-preflight.worker-expected.txt: Removed.
• web-platform-tests/fetch/api/cors/cors-redirect-credentials.any-expected.txt:
• web-platform-tests/fetch/api/cors/cors-redirect-credentials.any.worker-expected.txt: Added.
• web-platform-tests/fetch/api/cors/cors-redirect-credentials.any.worker.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/fetch/api/cors/cors-redirect-preflight.worker.html.
• web-platform-tests/fetch/api/cors/cors-redirect-credentials.worker-expected.txt: Removed.
• web-platform-tests/fetch/api/cors/cors-redirect-preflight.any-expected.txt:
• web-platform-tests/fetch/api/cors/cors-redirect-preflight.any.worker-expected.txt: Added.
• web-platform-tests/fetch/api/cors/cors-redirect-preflight.any.worker.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/fetch/api/cors/cors-redirect.worker.html.
• web-platform-tests/fetch/api/cors/cors-redirect-preflight.worker-expected.txt: Removed.
• web-platform-tests/fetch/api/cors/cors-redirect.any-expected.txt:
• web-platform-tests/fetch/api/cors/cors-redirect.any.worker-expected.txt: Added.
• web-platform-tests/fetch/api/cors/cors-redirect.any.worker.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/fetch/api/credentials/authentication-basic.worker.html.
• web-platform-tests/fetch/api/cors/cors-redirect.worker-expected.txt: Removed.
• web-platform-tests/fetch/api/credentials/authentication-basic.any-expected.txt:
• web-platform-tests/fetch/api/credentials/authentication-basic.any.worker-expected.txt: Added.
• web-platform-tests/fetch/api/credentials/authentication-basic.any.worker.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/fetch/api/credentials/cookies.worker.html.
• web-platform-tests/fetch/api/credentials/authentication-basic.worker-expected.txt: Removed.
• web-platform-tests/fetch/api/credentials/cookies.any-expected.txt:
• web-platform-tests/fetch/api/credentials/cookies.any.worker-expected.txt: Added.
• web-platform-tests/fetch/api/credentials/cookies.any.worker.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/fetch/api/headers/historical.worker.html.
• web-platform-tests/fetch/api/credentials/cookies.worker-expected.txt: Removed.
• web-platform-tests/fetch/api/headers/historical.any.worker-expected.txt: Added.
• web-platform-tests/fetch/api/headers/historical.any.worker.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/hr-time/basic.worker.html.
• web-platform-tests/fetch/api/headers/historical.worker-expected.txt: Removed.
• web-platform-tests/fetch/api/redirect/redirect-count-expected.txt:
• web-platform-tests/fetch/api/redirect/redirect-count-worker-expected.txt:
• web-platform-tests/fetch/api/redirect/redirect-location-expected.txt:
• web-platform-tests/fetch/api/redirect/redirect-location-worker-expected.txt:
• web-platform-tests/fetch/api/request/request-cache-only-if-cached-expected.txt: Copied from LayoutTests/platform/mac/imported/w3c/web-platform-tests/fetch/api/request/request-cache-only-if-cached-expected.txt.
• web-platform-tests/fetch/http-cache/partial-expected.txt:
• web-platform-tests/hr-time/basic.any.worker-expected.txt: Added.
• web-platform-tests/hr-time/basic.any.worker.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/hr-time/monotonic-clock.worker.html.
• web-platform-tests/hr-time/basic.worker-expected.txt: Removed.
• web-platform-tests/hr-time/basic.worker.js: Removed.
• web-platform-tests/hr-time/monotonic-clock.any.worker-expected.txt: Added.
• web-platform-tests/hr-time/monotonic-clock.any.worker.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/html/dom/self-origin.worker.html.
• web-platform-tests/hr-time/monotonic-clock.worker-expected.txt: Removed.

Tools:
Import web-platform-tests/tools
​https://bugs.webkit.org/show_bug.cgi?id=170718

Patch by Youenn Fablet <​youenn@apple.com> on 2017-04-19
Reviewed by Alex Christensen.

• Scripts/webkitpy/layout_tests/servers/web_platform_test_launcher.py:

(main):

• Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:

(WebPlatformTestServer.ports_to_forward):
(WebPlatformTestServer._prepare_config):
(WebPlatformTestServer._install_modules): Deleted.

• Scripts/webkitpy/w3c/test_importer.py:

(TestImporter.write_html_files_for_templated_js_tests):

LayoutTests:
Import web-platform-tests/tools
​https://bugs.webkit.org/show_bug.cgi?id=170718

Patch by Youenn Fablet <​youenn@apple.com> on 2017-04-19
Reviewed by Alex Christensen.

• TestExpectations:
• platform/mac-wk1/imported/w3c/web-platform-tests/fetch/api/cors/cors-basic.any-expected.txt: Added.
• platform/mac-wk1/imported/w3c/web-platform-tests/fetch/api/cors/cors-basic.any.worker-expected.txt: Added.
• platform/mac-wk1/imported/w3c/web-platform-tests/fetch/api/cors/cors-no-preflight.any-expected.txt: Added.
• platform/mac-wk1/imported/w3c/web-platform-tests/fetch/api/cors/cors-no-preflight.any.worker-expected.txt: Added.
• platform/mac-wk1/imported/w3c/web-platform-tests/fetch/api/cors/cors-origin.any-expected.txt: Added.
• platform/mac-wk1/imported/w3c/web-platform-tests/fetch/api/cors/cors-origin.any.worker-expected.txt: Added.
• platform/mac-wk1/imported/w3c/web-platform-tests/fetch/api/request/request-cache-only-if-cached-expected.txt: Renamed from LayoutTests/platform/mac/imported/w3c/web-platform-tests/fetch/api/request/request-cache-only-if-cached-expected.txt.
• tests-options.json:

9:17 AM Changeset in webkit [215514] by Brent Fulgham

• 2 edits in trunk/Source/WebCore

[iOS, macOS] Guard against passing nullptr to vImagePremultiplyData
​https://bugs.webkit.org/show_bug.cgi?id=170912
<rdar://problem/30565800>

Reviewed by Brady Eidson.

• platform/graphics/cg/ImageBufferDataCG.cpp:

(WebCore::affineWarpBufferData): Assert if we passed nullptr buffers.
(WebCore::transferData): Ditto.
(WebCore::ImageBufferData::getData): Check for nullptr data member and avoid passing to vImage routines.
(WebCore::ImageBufferData::putData): Ditto.

9:14 AM Changeset in webkit [215513] by hyatt@apple.com

• 2 edits in trunk/Source/WebCore

Remove bogus assert for :not.
​https://bugs.webkit.org/show_bug.cgi?id=170995
<rdar://problem/29693115>

Reviewed by Zalan Bujtas.

• css/parser/CSSSelectorParser.cpp:

8:51 AM Changeset in webkit [215512] by eric.carlson@apple.com

• 2 edits in trunk/Source/WebKit2

Provide a way for clients to unmute a media stream.
​https://bugs.webkit.org/show_bug.cgi?id=170855
<rdar://problem/31656855>

Unreviewed, fix a typo missed in the review of r215420.

• UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _setPageMuted:]):

8:20 AM Changeset in webkit [215511] by jmarcell@apple.com

• 7 edits in trunk/Source

Versioning.

8:15 AM Changeset in webkit [215510] by jmarcell@apple.com

• 1 copy in tags/Safari-604.1.18

Tag Safari-604.1.18.

7:57 AM Changeset in webkit [215509] by graouts@webkit.org

• 11 edits in trunk/Source/WebCore

[Modern Media Controls] Allow non-PNG resources
​https://bugs.webkit.org/show_bug.cgi?id=170992
<rdar://problem/31706590>

Reviewed by Dean Jackson.

Instead of passing in a name and a platform to MediaControlsHost::base64StringForIconAndPlatform(),
we now pass in a name and a type to MediaControlsHost::base64StringForIconNameAndType(). We've removed
the need to provide a platform by copying the resources directly under "Resources/modern-media-controls"
insted of "Resources/modern-media-controls/platform-name-here", and now we provide a type so that it
may be passed down to -[NSBundle pathForResource:ofType:inDirectory:].

• Modules/mediacontrols/MediaControlsHost.cpp:

(WebCore::MediaControlsHost::base64StringForIconNameAndType):
(WebCore::MediaControlsHost::base64StringForIconAndPlatform): Deleted.

• Modules/mediacontrols/MediaControlsHost.h:
• Modules/mediacontrols/MediaControlsHost.idl:
• Modules/modern-media-controls/controls/icon-service.js:

(const.iconService.new.IconService.prototype.imageForIconNameAndLayoutTraits):

• WebCore.xcodeproj/project.pbxproj:
• rendering/RenderTheme.h:

(WebCore::RenderTheme::mediaControlsBase64StringForIconNameAndType):
(WebCore::RenderTheme::mediaControlsBase64StringForIconAndPlatform): Deleted.

• rendering/RenderThemeIOS.h:
• rendering/RenderThemeIOS.mm:

(WebCore::RenderThemeIOS::mediaControlsBase64StringForIconNameAndType):
(WebCore::RenderThemeIOS::mediaControlsBase64StringForIconAndPlatform): Deleted.

• rendering/RenderThemeMac.h:
• rendering/RenderThemeMac.mm:

(WebCore::RenderThemeMac::mediaControlsBase64StringForIconNameAndType):
(WebCore::RenderThemeMac::mediaControlsBase64StringForIconAndPlatform): Deleted.

6:00 AM Changeset in webkit [215508] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebKit2

[GTK] WebKitAutocleanups.h regression in v2.16.1 release
​https://bugs.webkit.org/show_bug.cgi?id=170987

Patch by Adrian Perez de Castro <Adrian Perez de Castro> on 2017-04-19
Reviewed by Carlos Garcia Campos.

• UIProcess/API/gtk/WebKitAutocleanups.h: Remove stray semicolon.

5:15 AM Changeset in webkit [215507] by Antti Koivisto

• 3 edits
  2 adds in trunk

Avoid repaints for invisible animations on tumblr.com/search/aww
​https://bugs.webkit.org/show_bug.cgi?id=170986
<rdar://problem/28644580>

Reviewed by Andreas Kling.

Source/WebCore:

Test: fast/repaint/mutate-non-visible.html

• rendering/style/RenderStyle.cpp:

(WebCore::requiresPainting):
(WebCore::RenderStyle::changeRequiresRepaint):

If an element is invisible it does not require repaint even if something else changes.

LayoutTests:

• fast/repaint/mutate-non-visible-expected.txt: Added.
• fast/repaint/mutate-non-visible.html: Added.

1:41 AM Changeset in webkit [215506] by dino@apple.com

• 2 edits in trunk/Source/WebCore

Non-muxable GPUs shouldn't allow offline rendering
​https://bugs.webkit.org/show_bug.cgi?id=170984
<rdar://problem/31614406>

Reviewed by Myles Maxfield.

Setting the kCGLPFAAllowOfflineRenderers flag doesn't do any
harm on devices that only have one GPU. It's also what we
want on devices that can mux between GPUs. However, we were
also setting it unconditionally on devices with multiple
GPUs that have issues muxing.

• platform/graphics/mac/GraphicsContext3DMac.mm:

(WebCore::setPixelFormat): Add a test for hasMuxableGPU.

12:42 AM Changeset in webkit [215505] by rniwa@webkit.org

• 2 edits in trunk/Websites/perf.webkit.org

Another build fix after r215061. Clear TriggerableRepositoryGroup's static map in each iteration.

• tools/sync-buildbot.js:

(syncLoop):