Timeline

Apr 26, 2017:

11:21 PM Changeset in webkit [215858] by mitz@apple.com

• 2 edits in trunk/Source/WebCore

Reverted r215774.

It was not doing what it was intended to do and was inappropriate for WebCore.

• WebCore.xcodeproj/project.pbxproj:

10:55 PM Changeset in webkit [215857] by sbarati@apple.com

• 2 edits in trunk/Tools

Add some more testing modes for Wasm tests now that we have tier up
​https://bugs.webkit.org/show_bug.cgi?id=171360

Reviewed by Keith Miller.

Lets enable the FTL on all Wasm tests. Let's also run each
test with and without CJIT.

• Scripts/run-jsc-stress-tests:

10:45 PM Changeset in webkit [215856] by Chris Dumez

• 2 edits
  1 delete in trunk/LayoutTests

Unreviewed, remove unnecessary expected result in platform/ios-wk2

• platform/ios-wk2/imported/w3c/web-platform-tests/html/dom/reflection-embedded-expected.txt: Removed.
• platform/ios/imported/w3c/web-platform-tests/html/dom/reflection-embedded-expected.txt:

10:12 PM Changeset in webkit [215855] by commit-queue@webkit.org

• 6 edits in trunk

Web Inspector: Uint8ClampedArray should be treated like an array, not an object
​https://bugs.webkit.org/show_bug.cgi?id=171364
<rdar://problem/10873037>

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2017-04-26
Reviewed by Sam Weinig.

Source/JavaScriptCore:

• inspector/JSInjectedScriptHost.cpp:

(Inspector::JSInjectedScriptHost::subtype):
Treat Uint8ClampedArray (like other Typed Arrays) as an array.

LayoutTests:

• inspector/model/remote-object-expected.txt:
• inspector/model/remote-object.html:
• platform/mac/inspector/model/remote-object-expected.txt:

Test a Uint8ClampedArray is treated like an array.

8:38 PM Changeset in webkit [215854] by sbarati@apple.com

• 14 edits
  1 add in trunk

Print Wasm function index in stack trace
​https://bugs.webkit.org/show_bug.cgi?id=171349

Reviewed by JF Bastien.

JSTests:

• wasm/function-tests/stack-trace.js: Added.

(import.Builder.from.string_appeared_here.assert):
(let.imp):

• wasm/function-tests/trap-after-cross-instance-call.js:

(wasmFrameCountFromError):

• wasm/function-tests/trap-load-2.js:

(wasmFrameCountFromError):

• wasm/function-tests/trap-load.js:

(wasmFrameCountFromError):

Source/JavaScriptCore:

This patch prints a Callee's index in the function index
space in Error.stack.

This will lead to stack traces that have lines of text like:
wasm function index: 4@[wasm code]

We don't ascribe indices to everything in wasm. Specifically, the
Wasm->JS call stub callee does not get a name, and neither does
the JS -> Wasm entrypoint.

• interpreter/Interpreter.cpp:

(JSC::GetStackTraceFunctor::operator()):

• interpreter/StackVisitor.cpp:

(JSC::StackVisitor::readNonInlinedFrame):
(JSC::StackVisitor::Frame::functionName):

• interpreter/StackVisitor.h:

(JSC::StackVisitor::Frame::wasmFunctionIndex):

• runtime/StackFrame.cpp:

(JSC::StackFrame::functionName):

• runtime/StackFrame.h:

(JSC::StackFrame::StackFrame):
(JSC::StackFrame::wasm):
(JSC::StackFrame::hasBytecodeOffset):
(JSC::StackFrame::bytecodeOffset):

• wasm/WasmBBQPlanInlines.h:

(JSC::Wasm::BBQPlan::initializeCallees):

• wasm/WasmCallee.cpp:

(JSC::Wasm::Callee::Callee):

• wasm/WasmCallee.h:

(JSC::Wasm::Callee::create):
(JSC::Wasm::Callee::index):

• wasm/WasmOMGPlan.cpp:

(JSC::Wasm::OMGPlan::work):

7:57 PM Changeset in webkit [215853] by keith_miller@apple.com

• 6 edits in trunk/Source/JavaScriptCore

Follow up to r215843
​https://bugs.webkit.org/show_bug.cgi?id=171361

Reviewed by Saam Barati.

This patch fixes some style comments Saam didn't get a chance to
request before I landed: ​https://bugs.webkit.org/show_bug.cgi?id=170134.

It renames Wasm::CodeBlock::m_wasmEntrypoints to
m_wasmIndirectCallEntrypoints, as well as fixes some copyrights and
indentation.

• wasm/WasmBBQPlan.cpp:
• wasm/WasmCodeBlock.cpp:

(JSC::Wasm::CodeBlock::CodeBlock):

• wasm/WasmCodeBlock.h:

(JSC::Wasm::CodeBlock::wasmEntrypointLoadLocationFromFunctionIndexSpace):

• wasm/WasmOMGPlan.cpp:

(JSC::Wasm::OMGPlan::work):

• wasm/WasmTierUpCount.h:

(JSC::Wasm::TierUpCount::TierUpCount):
(JSC::Wasm::TierUpCount::loopDecrement):
(JSC::Wasm::TierUpCount::functionEntryDecrement):
(JSC::Wasm::TierUpCount::shouldStartTierUp):
(JSC::Wasm::TierUpCount::count):

7:28 PM Changeset in webkit [215852] by sbarati@apple.com

• 10 edits
  2 adds in trunk

ASSERTION FAILED: inIndex != notFound in JSC::invalidParameterInSourceAppender()
​https://bugs.webkit.org/show_bug.cgi?id=170924
<rdar://problem/31721052>

Reviewed by Mark Lam.

JSTests:

• stress/error-message-for-function-base-not-found.js: Added.

(assert):
(throw.new.Error):

• stress/error-messages-for-in-operator-should-not-crash.js: Added.

(catch):

LayoutTests/imported/w3c:

• web-platform-tests/css-timing-1/cubic-bezier-timing-functions-output-expected.txt:
• web-platform-tests/css-timing-1/frames-timing-functions-output-expected.txt:
• web-platform-tests/css-timing-1/step-timing-functions-output-expected.txt:

Source/JavaScriptCore:

The error message handler for "in" was searching for the literal
string "in". However, our parser incorrectly allows escaped characters
to be part of keywords. So this is parsed as "in" in JSC: "i\u006E".
It should not be parsed that way. I opened ​https://bugs.webkit.org/show_bug.cgi?id=171310
to address this issue.

Regardless, the error message handlers should handle unexpected text gracefully.
All functions that try to augment error messages with the goal of
providing a more textual context for the error message should use
the original error message instead of crashing when they detect
unexpected text.

This patch also changes the already buggy code that tries to find
the base of a function call. That could would fail for code like this:
"zoo.bar("/abc\)*/");". See ​https://bugs.webkit.org/show_bug.cgi?id=146304
It would think that the base is "z". However, the algorithm that tries
to find the base can often tell when it fails, and when it does, it should
happily return the approximate text error message instead of thinking
that the base is "z".

• runtime/ExceptionHelpers.cpp:

(JSC::functionCallBase):
(JSC::notAFunctionSourceAppender):
(JSC::invalidParameterInSourceAppender):

LayoutTests:

• js/let-syntax-expected.txt:

6:26 PM Changeset in webkit [215851] by Said Abou-Hallawa

• 2 edits in trunk/Source/WebCore

Attempt to fix a PLT regression.
<rdar://problem/31826998>

Unreviewed.

Disable passing the TypeIdentifierHint to CGImageSourceCreateIncremental()
on iOS for now.

• platform/graphics/cg/ImageDecoderCG.cpp:

(WebCore::ImageDecoder::ImageDecoder):

6:17 PM Changeset in webkit [215850] by jdiggs@igalia.com

• 3 edits
  2 adds in trunk

[ATK] ARIA buttons which have a popup should be ATK_ROLE_PUSH_BUTTON; not ATK_ROLE_COMBO_BOX
​https://bugs.webkit.org/show_bug.cgi?id=171182

Reviewed by Chris Fleizach.

Source/WebCore:

Test: accessibility/gtk/button-with-aria-haspopup-is-not-a-combobox.html

WebCore Accessibility assigns PopUpButtonRole to collapsed select elements,
which the ATK code correctly maps to ATK_ROLE_COMBO_BOX. It turns out that
WebCore Accessibility also maps the ARIA button role to PopUpButtonRole if
it also has aria-haspopup. Add a check to atkRole() so that the latter case
is mapped to ATK_ROLE_PUSH_BUTTON.

• accessibility/atk/WebKitAccessibleWrapperAtk.cpp:

(atkRole):

LayoutTests:

• accessibility/gtk/button-with-aria-haspopup-is-not-a-combobox-expected.txt: Added.
• accessibility/gtk/button-with-aria-haspopup-is-not-a-combobox.html: Added.

6:03 PM Changeset in webkit [215849] by timothy_horton@apple.com

• 7 edits
  2 adds in trunk

Should not drag x-apple-data-detectors links
​https://bugs.webkit.org/show_bug.cgi?id=171352
<rdar://problem/31309081>

Reviewed by Beth Dakin.

Test: fast/events/do-not-drag-and-drop-data-detectors-link.html

These links are only meaningful in the context of the original document,
so they should not be draggable.

• editing/cocoa/DataDetection.h:
• editing/cocoa/DataDetection.mm:

(WebCore::DataDetection::dataDetectorURLProtocol):
(WebCore::DataDetection::isDataDetectorURL):

• page/DragController.cpp:

(WebCore::isDraggableLink):
Disallow dragging of <a href="x-apple-data-detectors://..."> links.

• fast/events/do-not-drag-and-drop-data-detectors-link-expected.txt: Added.
• fast/events/do-not-drag-and-drop-data-detectors-link.html: Added.

6:01 PM Changeset in webkit [215848] by timothy_horton@apple.com

• 8 edits
  2 deletes in trunk

Revert accidentally smushed commit.

• editing/cocoa/DataDetection.h:
• editing/cocoa/DataDetection.mm:

(WebCore::DataDetection::dataDetectorURLProtocol): Deleted.
(WebCore::DataDetection::isDataDetectorURL): Deleted.

• page/DragController.cpp:

(WebCore::isDraggableLink):

• platform/mac/DragImageMac.mm:

(WebCore::createDragImageForLink):

• TestExpectations:
• fast/events/do-not-drag-and-drop-data-detectors-link-expected.txt: Removed.
• fast/events/do-not-drag-and-drop-data-detectors-link.html: Removed.
• platform/mac/TestExpectations:

5:53 PM Changeset in webkit [215847] by timothy_horton@apple.com

• 8 edits
  2 adds in trunk

Should not drag x-apple-data-detectors links
​https://bugs.webkit.org/show_bug.cgi?id=171352
<rdar://problem/31309081>

Reviewed by Beth Dakin.

Test: fast/events/do-not-drag-and-drop-data-detectors-link.html

These links are only meaningful in the context of the original document,
so they should not be draggable.

• editing/cocoa/DataDetection.h:
• editing/cocoa/DataDetection.mm:

(WebCore::DataDetection::dataDetectorURLProtocol):
(WebCore::DataDetection::isDataDetectorURL):

• page/DragController.cpp:

(WebCore::isDraggableLink):
Disallow dragging of <a href="x-apple-data-detectors://..."> links.

• fast/events/do-not-drag-and-drop-data-detectors-link-expected.txt: Added.
• fast/events/do-not-drag-and-drop-data-detectors-link.html: Added.

5:15 PM Changeset in webkit [215846] by aakash_jain@apple.com

• 2 edits in trunk/Tools

JSC EWS Patch Relevance skips few JSC scripts
​https://bugs.webkit.org/show_bug.cgi?id=171351

Reviewed by Alexey Proskuryakov.

• Scripts/webkitpy/tool/steps/checkpatchrelevance.py:

(CheckPatchRelevance): Added few jsc related scripts.

5:12 PM Changeset in webkit [215845] by achristensen@apple.com

• 2 edits in trunk/Source/WebCore

REGRESSION (r215686): ASSERTION FAILED: data seen with webarchive/loading tests
​https://bugs.webkit.org/show_bug.cgi?id=171340

Reviewed by Brady Eidson.

This fixes a flaky assertion in webarchive/loading/missing-data.html

• platform/cf/SharedBufferCF.cpp:

(WebCore::SharedBuffer::append):
If there's no CFDataRef, there's no need to append data.
This happens sometimes.

5:10 PM Changeset in webkit [215844] by jmarcell@apple.com

• 7 edits in tags/Safari-604.1.18.1/Source

Versioning.

4:55 PM Changeset in webkit [215843] by keith_miller@apple.com

• 34 edits
  6 copies
  1 move
  4 adds in trunk

WebAssembly: Implement tier up
​https://bugs.webkit.org/show_bug.cgi?id=170134

Reviewed by Filip Pizlo.

JSTests:

• wasm/function-tests/trap-after-cross-instance-call.js:
• wasm/tier-up/js-to-wasm.js: Added.

(async.test):

• wasm/tier-up/wasm-to-wasm.js: Added.

(async.test):

Source/JavaScriptCore:

This patch implements tier up for wasm functions. Unlike with JS
code, wasm code needs to be able to tier up concurrently with the
running code. Since JS code is synchronous we can always link on
the running thread, wasm, however, can run the same code on more
than one thread. In order to make patching work correctly, we need
to ensure that all patches of callsites are aligned. On ARM we get
this for free since every call is a near call. On X86 we ensure
that the 32-bit relative offset is 32-bit aligned.

This patch also modifies how Wasm::Plan works. Now Plan is a
abstract super class and there are two subclasses, which
correspond to the different tiers of our wasm engine. The first,
Build Bytecode Quickly (BBQ) tier, roughly does what the old plan
code did before. The new tier, Optimized Machine code Generation
(OMG), can be called at any point by BBQ code and compiles exactly
one function. Once an OMGPlan finishes it will link it's code
internally then reset the instruction cache of all running wasm
threads, via, a ThreadMessage. Once the instruction caches have
been reset all the other functions will be patched to call the new
code.

• JavaScriptCore.xcodeproj/project.pbxproj:
• assembler/AbstractMacroAssembler.h:

(JSC::AbstractMacroAssembler::ensureCacheLineSpace):

• assembler/CodeLocation.h:

(JSC::CodeLocationThreadSafeNearCall::CodeLocationThreadSafeNearCall):

• assembler/MacroAssemblerARM64.h:

(JSC::MacroAssemblerARM64::threadSafePatchableNearCall):

• assembler/MacroAssemblerX86Common.h:

(JSC::MacroAssemblerX86Common::threadSafeNearCall):

• assembler/MacroAssemblerX86_64.h:

(JSC::MacroAssemblerX86_64::threadSafePatchableNearCall):

• b3/air/AirEmitShuffle.cpp:

(JSC::B3::Air::ShufflePair::inst):
(JSC::B3::Air::ShufflePair::opcode): Deleted.

• b3/air/AirEmitShuffle.h:
• jsc.cpp:

(functionTestWasmModuleFunctions):

• runtime/JSLock.cpp:

(JSC::JSLock::didAcquireLock):

• runtime/Options.h:
• wasm/WasmB3IRGenerator.cpp:

(JSC::Wasm::B3IRGenerator::materializeWasmContext):
(JSC::Wasm::B3IRGenerator::B3IRGenerator):
(JSC::Wasm::B3IRGenerator::constant):
(JSC::Wasm::B3IRGenerator::emitTierUpCheck):
(JSC::Wasm::B3IRGenerator::addLoop):
(JSC::Wasm::B3IRGenerator::addTopLevel):
(JSC::Wasm::B3IRGenerator::addBlock):
(JSC::Wasm::createJSToWasmWrapper):
(JSC::Wasm::parseAndCompile):

• wasm/WasmB3IRGenerator.h:
• wasm/WasmBBQPlan.cpp: Copied from Source/JavaScriptCore/wasm/WasmPlan.cpp.

(JSC::Wasm::BBQPlan::BBQPlan):
(JSC::Wasm::BBQPlan::stateString):
(JSC::Wasm::BBQPlan::moveToState):
(JSC::Wasm::BBQPlan::parseAndValidateModule):
(JSC::Wasm::BBQPlan::prepare):
(JSC::Wasm::BBQPlan::ThreadCountHolder::ThreadCountHolder):
(JSC::Wasm::BBQPlan::ThreadCountHolder::~ThreadCountHolder):
(JSC::Wasm::BBQPlan::compileFunctions):
(JSC::Wasm::BBQPlan::complete):
(JSC::Wasm::BBQPlan::work):

• wasm/WasmBBQPlan.h: Copied from Source/JavaScriptCore/wasm/WasmPlan.h.
• wasm/WasmBBQPlanInlines.h: Copied from Source/JavaScriptCore/wasm/WasmPlanInlines.h.

(JSC::Wasm::BBQPlan::initializeCallees):

• wasm/WasmBinding.cpp:

(JSC::Wasm::wasmToWasm):

• wasm/WasmCallee.h:

(JSC::Wasm::Callee::entrypoint):

• wasm/WasmCodeBlock.cpp:

(JSC::Wasm::CodeBlock::CodeBlock):

• wasm/WasmCodeBlock.h:

(JSC::Wasm::CodeBlock::jsEntrypointCalleeFromFunctionIndexSpace):
(JSC::Wasm::CodeBlock::wasmEntrypointCalleeFromFunctionIndexSpace):
(JSC::Wasm::CodeBlock::wasmEntrypointLoadLocationFromFunctionIndexSpace):
(JSC::Wasm::CodeBlock::tierUpCount):
(JSC::Wasm::CodeBlock::mode):

• wasm/WasmFormat.h:

(JSC::Wasm::CallableFunction::CallableFunction):
(JSC::Wasm::CallableFunction::offsetOfWasmEntrypointLoadLocation):

• wasm/WasmMachineThreads.cpp: Copied from Source/JavaScriptCore/wasm/WasmPlanInlines.h.

(JSC::Wasm::wasmThreads):
(JSC::Wasm::startTrackingCurrentThread):
(JSC::Wasm::resetInstructionCacheOnAllThreads):

• wasm/WasmMachineThreads.h: Copied from Source/JavaScriptCore/wasm/WasmCallee.h.
• wasm/WasmModule.cpp:

(JSC::Wasm::makeValidationResult):
(JSC::Wasm::makeValidationCallback):
(JSC::Wasm::Module::validateSync):
(JSC::Wasm::Module::validateAsync):

• wasm/WasmModule.h:

(JSC::Wasm::Module::codeBlockFor):

• wasm/WasmOMGPlan.cpp: Added.

(JSC::Wasm::OMGPlan::OMGPlan):
(JSC::Wasm::OMGPlan::work):
(JSC::Wasm::runOMGPlanForIndex):

• wasm/WasmOMGPlan.h: Copied from Source/JavaScriptCore/wasm/WasmPlanInlines.h.
• wasm/WasmPlan.cpp:

(JSC::Wasm::Plan::Plan):
(JSC::Wasm::Plan::runCompletionTasks):
(JSC::Wasm::Plan::addCompletionTask):
(JSC::Wasm::Plan::waitForCompletion):
(JSC::Wasm::Plan::tryRemoveVMAndCancelIfLast):
(JSC::Wasm::Plan::fail):
(JSC::Wasm::Plan::stateString): Deleted.
(JSC::Wasm::Plan::moveToState): Deleted.
(JSC::Wasm::Plan::parseAndValidateModule): Deleted.
(JSC::Wasm::Plan::prepare): Deleted.
(JSC::Wasm::Plan::ThreadCountHolder::ThreadCountHolder): Deleted.
(JSC::Wasm::Plan::ThreadCountHolder::~ThreadCountHolder): Deleted.
(JSC::Wasm::Plan::compileFunctions): Deleted.
(JSC::Wasm::Plan::complete): Deleted.

• wasm/WasmPlan.h:

(JSC::Wasm::Plan::exports): Deleted.
(JSC::Wasm::Plan::internalFunctionCount): Deleted.
(JSC::Wasm::Plan::takeModuleInformation): Deleted.
(JSC::Wasm::Plan::takeCallLinkInfos): Deleted.
(JSC::Wasm::Plan::takeWasmToWasmExitStubs): Deleted.
(JSC::Wasm::Plan::hasWork): Deleted.
(JSC::Wasm::Plan::hasBeenPrepared): Deleted.

• wasm/WasmTierUpCount.h: Renamed from Source/JavaScriptCore/wasm/WasmPlanInlines.h.

(JSC::Wasm::TierUpCount::TierUpCount):
(JSC::Wasm::TierUpCount::loopDecrement):
(JSC::Wasm::TierUpCount::functionEntryDecrement):
(JSC::Wasm::TierUpCount::shouldStartTierUp):
(JSC::Wasm::TierUpCount::count):

• wasm/WasmWorklist.cpp:
• wasm/WasmWorklist.h:

(JSC::Wasm::Worklist::nextTicket):

• wasm/js/JSWebAssemblyCodeBlock.cpp:
• wasm/js/JSWebAssemblyCodeBlock.h:

(JSC::JSWebAssemblyCodeBlock::wasmEntrypointLoadLocationFromFunctionIndexSpace):
(JSC::JSWebAssemblyCodeBlock::wasmToJsCallStubForImport):
(JSC::JSWebAssemblyCodeBlock::wasmEntrypointCalleeFromFunctionIndexSpace): Deleted.

• wasm/js/JSWebAssemblyTable.cpp:

(JSC::JSWebAssemblyTable::setFunction):

• wasm/js/WebAssemblyFunction.cpp:

(JSC::WebAssemblyFunction::create):
(JSC::WebAssemblyFunction::WebAssemblyFunction):

• wasm/js/WebAssemblyFunction.h:

(JSC::WebAssemblyFunction::signatureIndex):
(JSC::WebAssemblyFunction::wasmEntrypointLoadLocation):
(JSC::WebAssemblyFunction::callableFunction):
(JSC::WebAssemblyFunction::offsetOfWasmEntrypointLoadLocation):
(JSC::WebAssemblyFunction::wasmEntrypoint): Deleted.
(JSC::WebAssemblyFunction::offsetOfWasmEntrypoint): Deleted.

• wasm/js/WebAssemblyModuleRecord.cpp:

(JSC::WebAssemblyModuleRecord::link):
(JSC::WebAssemblyModuleRecord::evaluate):

• wasm/js/WebAssemblyPrototype.cpp:

(JSC::webAssemblyValidateFunc):

• wasm/js/WebAssemblyWrapperFunction.cpp:

(JSC::WebAssemblyWrapperFunction::WebAssemblyWrapperFunction):
(JSC::WebAssemblyWrapperFunction::create):

• wasm/js/WebAssemblyWrapperFunction.h:

(JSC::WebAssemblyWrapperFunction::signatureIndex):
(JSC::WebAssemblyWrapperFunction::wasmEntrypointLoadLocation):
(JSC::WebAssemblyWrapperFunction::callableFunction):
(JSC::WebAssemblyWrapperFunction::wasmEntrypoint): Deleted.

4:52 PM Changeset in webkit [215842] by Ryan Haddad

• 4 edits in trunk

Unreviewed, rolling out r215814.

The LayoutTest for this change is failing on ios-simulator and
is flaky on macOS.

Reverted changeset:

"Response.blob() does not set the content-type based on the
header value."
​https://bugs.webkit.org/show_bug.cgi?id=170849
​http://trac.webkit.org/changeset/215814

4:48 PM Changeset in webkit [215841] by commit-queue@webkit.org

• 3 edits in trunk/Tools

Test importer should delete obsolete files based on w3c-import.log
​https://bugs.webkit.org/show_bug.cgi?id=171348

Patch by Youenn Fablet <​youenn@apple.com> on 2017-04-26
Reviewed by Chris Dumez.

• Scripts/webkitpy/w3c/test_importer.py:

(TestImporter.do_import): Removing dangling -expected.txt files in regular import mode.
(TestImporter.remove_deleted_files): Fixing according w3c-import.log current format.

• Scripts/webkitpy/w3c/test_importer_unittest.py:

(test_remove_obsolete_content):

4:33 PM Changeset in webkit [215840] by Wenson Hsieh

• 21 edits in trunk/Source

WebItemProviderPasteboard should not synchronously load provided data
​https://bugs.webkit.org/show_bug.cgi?id=171341
<rdar://problem/31614010>

Reviewed by Tim Horton.

Source/WebCore:

Refactors WebItemProviderPasteboard to not require asynchronously loading item provider data. To accomplish this,
we ensure that before performing data interaction, the UTI type that the data operation target should consume is
propagated to the UI process prior to the web process receiving the signal from the UI process to begin the
data operation itself. This information is sent via WebPlatformStrategies::updatePreferredTypeIdentifiers, a new
pasteboard helper function.

• page/DragController.cpp:

(WebCore::DragController::DragController):
(WebCore::dragIsHandledByDocument):
(WebCore::DragController::performDragOperation):
(WebCore::DragController::dragEnteredOrUpdated):
(WebCore::DragController::updatePreferredTypeIdentifiersForDragHandlingMethod):
(WebCore::DragController::tryDocumentDrag):

Give DragHandlingMethod a richer representation of what type of action will be performed. DragController::
updatePreferredTypeIdentifiersForDragHandlingMethod uses this to determine what kinds of UTIs are acceptable for
the current drop session.

• page/DragController.h:

(WebCore::DragController::documentIsHandlingNonDefaultDrag):

• page/mac/DragControllerMac.mm:

(WebCore::DragController::updatePreferredTypeIdentifiersForDragHandlingMethod):

Updates the data interaction pasteboard's list of preferred type identifiers it should load upon data operation.

• platform/DragData.h:
• platform/PasteboardStrategy.h:
• platform/PlatformPasteboard.h:
• platform/ios/AbstractPasteboard.h:
• platform/ios/PlatformPasteboardIOS.mm:

(WebCore::PlatformPasteboard::updatePreferredTypeIdentifiers):

• platform/ios/WebItemProviderPasteboard.mm:

Introduce _preferredTypeIdentifiers, which -doAfterLoadingProvidedContentIntoFileURLs: uses as a hint when
determining which UTI to load for an item provider. In the absence of preferred type identifiers, the default
behavior is to use the highest fidelity type adhering to "public.content".

(-[WebItemProviderPasteboard init]):
(-[WebItemProviderPasteboard updatePreferredTypeIdentifiers:]):
(-[WebItemProviderPasteboard setItemProviders:]):
(-[WebItemProviderPasteboard dataForPasteboardType:inItemSet:]):
(-[WebItemProviderPasteboard valuesForPasteboardType:inItemSet:]):

Remove calls to -createObjectOfClass: and -copyDataRepresentation:. Instead, rely solely on the loaded file URL
to read and initialize data and objects from the pasteboard.

(-[WebItemProviderPasteboard doAfterLoadingProvidedContentIntoFileURLs:]):
(-[WebItemProviderPasteboard _tryToCreateObjectOfClass:usingProvider:]): Deleted.

• platform/mac/DragDataMac.mm:

(WebCore::DragData::updatePreferredTypeIdentifiers):

Source/WebKit/mac:

Adds client-layer plumbing for updatePreferredTypeIdentifiers. See WebCore ChangeLog for more details.

• WebCoreSupport/WebPlatformStrategies.h:
• WebCoreSupport/WebPlatformStrategies.mm:

(WebPlatformStrategies::updatePreferredTypeIdentifiers):

Source/WebKit2:

Adds plumbing for updatePreferredTypeIdentifiers through the WebPasteboardProxy. This allows the web process to
signal to the UI process what UTIs the current drop target should accept and load. See WebCore ChangeLog for more
details.

• UIProcess/Cocoa/WebPasteboardProxyCocoa.mm:

(WebKit::WebPasteboardProxy::updatePreferredTypeIdentifiers):

• UIProcess/WebPasteboardProxy.h:
• UIProcess/WebPasteboardProxy.messages.in:
• WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:

(WebKit::WebPlatformStrategies::updatePreferredTypeIdentifiers):

• WebProcess/WebCoreSupport/WebPlatformStrategies.h:

4:33 PM Changeset in webkit [215839] by Ryan Haddad

• 2 edits in trunk/LayoutTests

Re-baseline inspector/dom/getAccessibilityPropertiesForNode.html after r215821
​https://bugs.webkit.org/show_bug.cgi?id=171346

Unreviewed test gardening.

Patch by Matt Lewis <Matt Lewis> on 2017-04-26

• inspector/dom/getAccessibilityPropertiesForNode-expected.txt:

4:28 PM Changeset in webkit [215838] by Jonathan Bedard

• 2 edits in trunk/Tools

REGRESSION (r213926): We're sometimes trying to start WebKitTestRunner without proper DYLD variables
<rdar://problem/31816459>

Unreviewed infrastructure fix.

Some of our iOS Simulator bots are slow and will register crashes due to an incorrect
DYLD_FRAMEWORK_PATH when installing an app.

• Scripts/webkitpy/port/ios.py:

(IOSPort.setup_test_run): Pass DYLD_FRAMEWORK_PATH to app on install.

4:26 PM Changeset in webkit [215837] by jdiggs@igalia.com

• 11 edits
  4 adds in trunk

[ATK] Elements with a defined, non-false value for aria-current should expose ATK_STATE_ACTIVE
​https://bugs.webkit.org/show_bug.cgi?id=171163

Reviewed by Chris Fleizach.

Source/WebCore:

Add ATK_STATE_ACTIVE to the state set of elements which have a valid, non-false
value for aria-current, expose the value of via the "current" AtkObject attribute,
and emit state-change notifications when the value of aria-current changes from
non-false to false, or vice versa.

Tests: accessibility/gtk/aria-current-changed-notification.html

accessibility/gtk/aria-current.html

• accessibility/AXObjectCache.cpp:

(WebCore::AXObjectCache::handleAttributeChanged):

• accessibility/AXObjectCache.h:
• accessibility/AccessibilityObject.cpp:

(WebCore::AccessibilityObject::supportsARIACurrent):
(WebCore::AccessibilityObject::ariaCurrentValue):

• accessibility/AccessibilityObject.h:
• accessibility/atk/AXObjectCacheAtk.cpp:

(WebCore::AXObjectCache::postPlatformNotification):

• accessibility/atk/WebKitAccessibleWrapperAtk.cpp:

(webkitAccessibleGetAttributes):
(setAtkStateSetFromCoreObject):

• accessibility/mac/WebAccessibilityObjectWrapperMac.mm:

(-[WebAccessibilityObjectWrapper accessibilityAttributeValue:]): Moved code returning
string value for aria-current into AccessibilityObject:ariaCurrentValue().

Tools:

Add support for state-change notifications for ATK_STATE_ACTIVE.

• WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:

LayoutTests:

• accessibility/gtk/aria-current-changed-notification-expected.txt: Added.
• accessibility/gtk/aria-current-changed-notification.html: Added.
• accessibility/gtk/aria-current-expected.txt: Added.
• accessibility/gtk/aria-current.html: Added.

4:11 PM Changeset in webkit [215836] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebKit2

Unauthenticated CORS preflight requests should not use client certificates
​https://bugs.webkit.org/show_bug.cgi?id=171298

Patch by Youenn Fablet <​youenn@apple.com> on 2017-04-26
Reviewed by Alex Christensen.

• NetworkProcess/cocoa/NetworkSessionCocoa.mm:

(WebKit::NetworkSessionCocoa::NetworkSessionCocoa): Ensuring that session dedicated to requests that do not want to use credentials do not look for client credentials.

4:09 PM Changeset in webkit [215835] by Wenson Hsieh

• 5 edits in trunk/Source/WebCore

WebItemProviderPasteboard should fetch preloaded assets from disk when possible
​https://bugs.webkit.org/show_bug.cgi?id=171320
<rdar://problem/31614010>

Reviewed by Tim Horton.

Adds a mechanism to WebItemProviderPasteboard to remember the temporary file URLs of assets it has loaded using
doAfterLoadingProvidedContentIntoFileURLs:. When retrieving data from the pasteboard, we then see if we can
first fetch serialized data straight from disk instead of having to go through the item provider in both
-dataForPasteboardType:inItemSet: and -valuesForPasteboardType:inItemSet:.

See below annotations for more detail.

• platform/ios/AbstractPasteboard.h:
• platform/ios/PlatformPasteboardIOS.mm:

(WebCore::PlatformPasteboard::filenamesForDataInteraction):

• platform/ios/WebItemProviderPasteboard.h:
• platform/ios/WebItemProviderPasteboard.mm:

Introduces _typeToFileURLMaps, an array of dictionaries. A dictionary at the ith index of this array represents
a mapping of UTIs to loaded temo file URLs for the ith UIItemProvider in the _itemProviders array. Before data
interaction is performed, all entries in this array will be empty.

(-[WebItemProviderPasteboard init]):
(-[WebItemProviderPasteboard setItemProviders:]):
(-[WebItemProviderPasteboard _preLoadedDataConformingToType:forItemProviderAtIndex:]):
(-[WebItemProviderPasteboard dataForPasteboardType:inItemSet:]):
(-[WebItemProviderPasteboard valuesForPasteboardType:inItemSet:]):

Consult any loaded assets on disk before hitting UIItemProviders via the new
-_preLoadedDataConformingToType:forItemProviderAtIndex: helper method.

(-[WebItemProviderPasteboard _tryToCreateObjectOfClass:usingProvider:]):
(-[WebItemProviderPasteboard fileURLsForDataInteraction]):

Traverse _typeToFileURLMaps to collect all file URLs.

(-[WebItemProviderPasteboard doAfterLoadingProvidedContentIntoFileURLs:]):

Refactored to populate and set _typeToFileURLMaps when loading completes, rather than an array of file URLs.

(-[WebItemProviderPasteboard _tryToCreateAndAppendObjectOfClass:toArray:usingProvider:]): Deleted.
(-[WebItemProviderPasteboard filenamesForDataInteraction]): Deleted.

Correct an erroneously named method (replaces filenames with fileURLs).

3:36 PM Changeset in webkit [215834] by eric.carlson@apple.com

• 2 edits in trunk/Source/WebKit2

The current page is given a muted state when starting a media stream on iOS.
​https://bugs.webkit.org/show_bug.cgi?id=171290
<rdar://problem/31821427>

Reviewed by Jer Noble.

• UIProcess/UserMediaProcessManager.cpp:

(WebKit::UserMediaProcessManager::willEnableMediaStreamInPage): Don't mute the current
page on iOS either, that will prevent the new media stream from playing.

3:04 PM Changeset in webkit [215833] by commit-queue@webkit.org

• 4 edits in trunk/LayoutTests

LayoutTest webrtc/datachannel/bufferedAmountLowThreshold.html is a flaky failure
​https://bugs.webkit.org/show_bug.cgi?id=170701

Patch by Youenn Fablet <​youenn@apple.com> on 2017-04-26
Reviewed by Eric Carlson.

• platform/mac-wk1/TestExpectations: Removing flaky expectation.
• webrtc/datachannel/bufferedAmountLowThreshold-expected.txt:
• webrtc/datachannel/bufferedAmountLowThreshold.html:

3:01 PM Changeset in webkit [215832] by commit-queue@webkit.org

• 7 edits in trunk/Source/WebCore

LayoutTest webrtc/datachannel/basic.html is a flaky crash
​https://bugs.webkit.org/show_bug.cgi?id=170154
<rdar://problem/31288423>

Patch by Youenn Fablet <​youenn@apple.com> on 2017-04-26
Reviewed by Geoffrey Garen.

Before the patch, we are setting the channel handler client to null and then unregistering from observer to
libwebrtc data channel. Since this happens in two different threads, there might be a timing issue.

Removing this risk by first unregistering (done synchronously on the other thread), before setting client to null.
Made some clean-up related refactoring.

• Modules/mediastream/RTCDataChannel.cpp:

(WebCore::RTCDataChannel::create):
(WebCore::RTCDataChannel::close):

• Modules/mediastream/libwebrtc/LibWebRTCDataChannelHandler.cpp:

(WebCore::LibWebRTCDataChannelHandler::setClient):
(WebCore::LibWebRTCDataChannelHandler::close):

• Modules/mediastream/libwebrtc/LibWebRTCDataChannelHandler.h:
• platform/mediastream/RTCDataChannelHandler.h:
• platform/mock/RTCDataChannelHandlerMock.cpp:

(WebCore::RTCDataChannelHandlerMock::setClient):

• platform/mock/RTCDataChannelHandlerMock.h:

2:40 PM Changeset in webkit [215831] by commit-queue@webkit.org

• 9 edits in trunk/Source

Make user script injection more robust
​https://bugs.webkit.org/show_bug.cgi?id=171339
<rdar://problem/30643691>

Patch by Alex Christensen <​achristensen@webkit.org> on 2017-04-26
Reviewed by Geoffrey Garen.

Source/WebCore:

• loader/EmptyClients.cpp:
• page/Frame.cpp:

(WebCore::Frame::injectUserScripts):

• page/UserContentController.cpp:

(WebCore::UserContentController::forEachUserScript):
(WebCore::UserContentController::forEachUserStyleSheet):
(WebCore::UserContentController::forEachUserMessageHandler):

• page/UserContentController.h:
• page/UserContentProvider.h:

Source/WebKit2:

• WebProcess/UserContent/WebUserContentController.cpp:

(WebKit::WebUserContentController::forEachUserScript):
(WebKit::WebUserContentController::forEachUserStyleSheet):
(WebKit::WebUserContentController::forEachUserMessageHandler):

• WebProcess/UserContent/WebUserContentController.h:

1:52 PM Changeset in webkit [215830] by Alan Bujtas

• 6 edits in trunk/Source

RTL: recent searches popover is displayed in incorrect location
​https://bugs.webkit.org/show_bug.cgi?id=171338
<rdar://problem/31377807>

Reviewed by Dean Jackson.

Source/WebCore:

Compute the absolute coordinates for the popup the same way we do for the select dropdown.

• rendering/RenderSearchField.cpp:

(WebCore::RenderSearchField::showPopup):

Source/WebKit/mac:

Add RTL support for the pop-under branch.

• WebCoreSupport/PopupMenuMac.mm:

(PopupMenuMac::show):

Source/WebKit2:

Add RTL support for the pop-under branch.

• UIProcess/mac/WebPopupMenuProxyMac.mm:

(WebKit::WebPopupMenuProxyMac::showPopupMenu):

1:35 PM Changeset in webkit [215829] by commit-queue@webkit.org

• 4 edits
  6 adds in trunk

Restrict WebKit image formats to a known whitelist
​https://bugs.webkit.org/show_bug.cgi?id=170700

Patch by Said Abou-Hallawa <​sabouhallawa@apple.com> on 2017-04-26
Reviewed by Tim Horton.

Source/WebCore:

If the image format is not supported, the load should be canceled and the
image is marked a broken image.

Test: fast/images/image-formats-support.html

• loader/cache/CachedImage.cpp:

(WebCore::CachedImage::addIncrementalDataBuffer):
(WebCore::CachedImage::setImageDataBuffer):
(WebCore::CachedImage::finishLoading):

• loader/cache/CachedImage.h:

LayoutTests:

• fast/images/image-formats-support-expected.txt: Added.
• fast/images/image-formats-support.html: Added.
• fast/images/resources/100x100-red-psd-renamed.png: Added.
• fast/images/resources/100x100-red-tga-renamed.png: Added.
• fast/images/resources/100x100-red.psd: Added.
• fast/images/resources/100x100-red.tga: Added.

1:24 PM Changeset in webkit [215828] by jmarcell@apple.com

• 2 edits in tags/Safari-604.1.18.1/Source/WebCore

Cherry-pick 674c09519f93fe01f4a54b4b987b72cf3e13f62c.

1:23 PM Changeset in webkit [215827] by jmarcell@apple.com

• 2 edits in tags/Safari-604.1.18.1/Source/WebCore

Cherry-pick be0489fa24a2bb4c3ba95d5fc98cbbe72a5108a4.

1:23 PM Changeset in webkit [215826] by jmarcell@apple.com

• 2 edits in tags/Safari-604.1.18.1/Source/WebKit2

Cherry-pick 6259a37cc6ee5e811df5a2d8c043ef0c9a2929bd
358c01809a1fefdd4606930f09b5acc8b8a007ed. rdar://problem/31827095

1:23 PM Changeset in webkit [215825] by jmarcell@apple.com

• 8 edits
  4 adds in tags/Safari-604.1.18.1

Cherry-pick 9000840c460a566350f3532112bb13e684062b6f. rdar://problem/31634990

1:23 PM Changeset in webkit [215824] by Jonathan Bedard

• 3 edits in trunk/Tools

webkitpy: Teardown iOS Simulators on exit if managed Simulators are still running
​https://bugs.webkit.org/show_bug.cgi?id=171293

Reviewed by Aakash Jain.

We should make an effort to teardown simulators which we booted even when an exception is
thrown while booting. Make some IOSSimulatorPort functions into static methods and register
one of these functions to be run at exit to ensure any devices webkitpy is managing gets
torn down.

• Scripts/webkitpy/layout_tests/controllers/manager.py:

(Manager._set_up_run): Rely on exit handlers to teardown, not exceptions.

• Scripts/webkitpy/port/ios_simulator.py:

(IOSSimulatorPort._teardown_managed_simulators): Function run on exit which will kill all
iOS simulators and teardown and managed devices.
(IOSSimulatorPort._create_simulators): Register teardown function.
(IOSSimulatorPort.clean_up_test_run): Move device teardown to _teardown_managed_simulators.
(IOSSimulatorPort._remove_device): Deleted.

1:09 PM Changeset in webkit [215823] by commit-queue@webkit.org

• 2 edits in trunk/LayoutTests

Mark swipe/main-frame-pinning-requirement.html as a flaky failure on mac-wk2.
​https://bugs.webkit.org/show_bug.cgi?id=170484

Patch by Matt Lewis <Matt Lewis> on 2017-04-26
Reviewed by Alexey Proskuryakov.

• platform/mac-wk2/TestExpectations:

12:38 PM Changeset in webkit [215822] by Chris Dumez

• 17 edits
  1 copy
  2 moves
  57 adds
  1 delete in trunk/LayoutTests

Re-sync html/browsers/the-window-object web-platform-tests from upstream
​https://bugs.webkit.org/show_bug.cgi?id=171313

Reviewed by Alex Christensen.

LayoutTests/imported/w3c:

• resources/import-expectations.json:
• web-platform-tests/common/PrefixedPostMessage.js: Added.

(PrefixedMessage):
(PrefixedMessage.prototype.url):
(PrefixedMessage.prototype.onMessage):
(PrefixedMessageTest):
(PrefixedMessageResource):
(PrefixedMessageResource.prototype.postToOpener):

• web-platform-tests/html/browsers/the-window-object/accessing-other-browsing-contexts/w3c-import.log:
• web-platform-tests/html/browsers/the-window-object/apis-for-creating-and-navigating-browsing-contexts-by-name/non_automated/w3c-import.log:
• web-platform-tests/html/browsers/the-window-object/apis-for-creating-and-navigating-browsing-contexts-by-name/open-features-negative-innerwidth-innerheight-expected.txt: Added.
• web-platform-tests/html/browsers/the-window-object/apis-for-creating-and-navigating-browsing-contexts-by-name/open-features-negative-innerwidth-innerheight.html: Added.
• web-platform-tests/html/browsers/the-window-object/apis-for-creating-and-navigating-browsing-contexts-by-name/open-features-negative-screenx-screeny-expected.txt: Added.
• web-platform-tests/html/browsers/the-window-object/apis-for-creating-and-navigating-browsing-contexts-by-name/open-features-negative-screenx-screeny.html: Added.
• web-platform-tests/html/browsers/the-window-object/apis-for-creating-and-navigating-browsing-contexts-by-name/open-features-negative-top-left-expected.txt: Added.
• web-platform-tests/html/browsers/the-window-object/apis-for-creating-and-navigating-browsing-contexts-by-name/open-features-negative-top-left.html: Added.
• web-platform-tests/html/browsers/the-window-object/apis-for-creating-and-navigating-browsing-contexts-by-name/open-features-negative-width-height-expected.txt: Added.
• web-platform-tests/html/browsers/the-window-object/apis-for-creating-and-navigating-browsing-contexts-by-name/open-features-negative-width-height.html: Added.
• web-platform-tests/html/browsers/the-window-object/apis-for-creating-and-navigating-browsing-contexts-by-name/open-features-non-integer-height-expected.txt: Added.
• web-platform-tests/html/browsers/the-window-object/apis-for-creating-and-navigating-browsing-contexts-by-name/open-features-non-integer-height.html: Added.
• web-platform-tests/html/browsers/the-window-object/apis-for-creating-and-navigating-browsing-contexts-by-name/open-features-non-integer-innerheight-expected.txt: Added.
• web-platform-tests/html/browsers/the-window-object/apis-for-creating-and-navigating-browsing-contexts-by-name/open-features-non-integer-innerheight.html: Added.
• web-platform-tests/html/browsers/the-window-object/apis-for-creating-and-navigating-browsing-contexts-by-name/open-features-non-integer-innerwidth-expected.txt: Added.
• web-platform-tests/html/browsers/the-window-object/apis-for-creating-and-navigating-browsing-contexts-by-name/open-features-non-integer-innerwidth.html: Added.
• web-platform-tests/html/browsers/the-window-object/apis-for-creating-and-navigating-browsing-contexts-by-name/open-features-non-integer-left-expected.txt: Added.
• web-platform-tests/html/browsers/the-window-object/apis-for-creating-and-navigating-browsing-contexts-by-name/open-features-non-integer-left.html: Added.
• web-platform-tests/html/browsers/the-window-object/apis-for-creating-and-navigating-browsing-contexts-by-name/open-features-non-integer-screenx-expected.txt: Added.
• web-platform-tests/html/browsers/the-window-object/apis-for-creating-and-navigating-browsing-contexts-by-name/open-features-non-integer-screenx.html: Added.
• web-platform-tests/html/browsers/the-window-object/apis-for-creating-and-navigating-browsing-contexts-by-name/open-features-non-integer-screeny-expected.txt: Added.
• web-platform-tests/html/browsers/the-window-object/apis-for-creating-and-navigating-browsing-contexts-by-name/open-features-non-integer-screeny.html: Added.
• web-platform-tests/html/browsers/the-window-object/apis-for-creating-and-navigating-browsing-contexts-by-name/open-features-non-integer-top-expected.txt: Added.
• web-platform-tests/html/browsers/the-window-object/apis-for-creating-and-navigating-browsing-contexts-by-name/open-features-non-integer-top.html: Added.
• web-platform-tests/html/browsers/the-window-object/apis-for-creating-and-navigating-browsing-contexts-by-name/open-features-non-integer-width-expected.txt: Added.
• web-platform-tests/html/browsers/the-window-object/apis-for-creating-and-navigating-browsing-contexts-by-name/open-features-non-integer-width.html: Added.
• web-platform-tests/html/browsers/the-window-object/apis-for-creating-and-navigating-browsing-contexts-by-name/open-features-tokenization-innerheight-innerwidth-expected.txt: Added.
• web-platform-tests/html/browsers/the-window-object/apis-for-creating-and-navigating-browsing-contexts-by-name/open-features-tokenization-innerheight-innerwidth.html: Added.
• web-platform-tests/html/browsers/the-window-object/apis-for-creating-and-navigating-browsing-contexts-by-name/open-features-tokenization-noopener-expected.txt: Added.
• web-platform-tests/html/browsers/the-window-object/apis-for-creating-and-navigating-browsing-contexts-by-name/open-features-tokenization-noopener.html: Added.
• web-platform-tests/html/browsers/the-window-object/apis-for-creating-and-navigating-browsing-contexts-by-name/open-features-tokenization-screenx-screeny-expected.txt: Added.
• web-platform-tests/html/browsers/the-window-object/apis-for-creating-and-navigating-browsing-contexts-by-name/open-features-tokenization-screenx-screeny.html: Added.
• web-platform-tests/html/browsers/the-window-object/apis-for-creating-and-navigating-browsing-contexts-by-name/open-features-tokenization-top-left-expected.txt: Added.
• web-platform-tests/html/browsers/the-window-object/apis-for-creating-and-navigating-browsing-contexts-by-name/open-features-tokenization-top-left.html: Added.
• web-platform-tests/html/browsers/the-window-object/apis-for-creating-and-navigating-browsing-contexts-by-name/open-features-tokenization-width-height-expected.txt: Added.
• web-platform-tests/html/browsers/the-window-object/apis-for-creating-and-navigating-browsing-contexts-by-name/open-features-tokenization-width-height.html: Added.
• web-platform-tests/html/browsers/the-window-object/apis-for-creating-and-navigating-browsing-contexts-by-name/resources/message-opener.html: Added.
• web-platform-tests/html/browsers/the-window-object/apis-for-creating-and-navigating-browsing-contexts-by-name/resources/w3c-import.log:
• web-platform-tests/html/browsers/the-window-object/apis-for-creating-and-navigating-browsing-contexts-by-name/w3c-import.log:
• web-platform-tests/html/browsers/the-window-object/garbage-collection-and-browsing-contexts/non-automated/w3c-import.log:
• web-platform-tests/html/browsers/the-window-object/garbage-collection-and-browsing-contexts/w3c-import.log:
• web-platform-tests/html/browsers/the-window-object/named-access-on-the-window-object/w3c-import.log:
• web-platform-tests/html/browsers/the-window-object/security-window/w3c-import.log:
• web-platform-tests/html/browsers/the-window-object/support/w3c-import.log:
• web-platform-tests/html/browsers/the-window-object/w3c-import.log:
• web-platform-tests/html/browsers/the-window-object/window-indexed-properties-expected.txt:
• web-platform-tests/html/browsers/the-window-object/window-indexed-properties-strict.html:
• web-platform-tests/html/browsers/the-window-object/window-indexed-properties.html:

LayoutTests:

• tests-options.json:

12:30 PM Changeset in webkit [215821] by jdiggs@igalia.com

• 9 edits
  2 adds in trunk

[ATK] Implement support for new ARIA 1.1 values of aria-haspopup
​https://bugs.webkit.org/show_bug.cgi?id=171164

Reviewed by Chris Fleizach.

Source/WebCore:

In ARIA 1.1, aria-haspopup's value type changed from true/false to a token.
Values: true, false (default, unless it's a combobox), dialog, grid, listbox
(default for combobox), menu, and tree. Any value of aria-haspopup that is
not included in the list of allowed values, including an empty string, must
be treated as if the value false had been provided.

Add AccessibilityObject::ariaPopupValue() to validate the value, handle implicit
values, and give platform assistive technologies a means to access that value.

If there is a valid, non-false value of aria-haspopup, include ATK_STATE_HAS_POPUP
in the AtkStateSet. Lastly, expose the value (rather than true/false) via the "haspop"
AtkObject attribute.

Test: accessibility/gtk/aria-haspopup.html

• accessibility/AccessibilityObject.h:

(WebCore::AccessibilityObject::ariaPopupValue):
(WebCore::AccessibilityObject::supportsARIAHasPopup):

• accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::ariaHasPopup):

• accessibility/AccessibilityRenderObject.h:
• accessibility/atk/WebKitAccessibleWrapperAtk.cpp:

(webkitAccessibleGetAttributes):
(setAtkStateSetFromCoreObject):

Tools:

hasPopup() should return whether or not ATK_STATE_HAS_POPUP is in the
AtkStateSet; not what is found in the AtkObject's attributes.

• WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:

(WTR::AccessibilityUIElement::hasPopup):

LayoutTests:

In addition to the new test, update xml-roles-exposed.html's expectations
because the implicit value of aria-haspopup for the combobox role is now
listbox, and that value should be exposed via an AtkObject attribute.

• accessibility/gtk/aria-haspopup-expected.txt: Added.
• accessibility/gtk/aria-haspopup.html: Added.
• accessibility/gtk/xml-roles-exposed-expected.txt:

12:03 PM Changeset in webkit [215820] by Simon Fraser

• 5 edits in trunk/LayoutTests

http/tests/frame-throttling tests failing on iOS
​https://bugs.webkit.org/show_bug.cgi?id=171314
rdar://problem/31691134

Reviewed by Chris Dumez.

The tests use UIHelper.activateAt(), which in DumpRenderTree dispatches mouse events via EventSender, and in iOS WK2 uses
UIScriptController to dispatch touch events. The former just use standard hit testing, which works fine.
The latter go via Frame::qualifyingNodeAtViewportLocation(), which calls ancestorRespondingToClickEvents()
and does area hit testing, and this fails to find anything clickable inside the <iframe>s.

Fix by putting a div with an onlick handler inside the iframes, and adjusting the click
locations.

• http/tests/frame-throttling/raf-throttle-in-cross-origin-subframe.html:
• http/tests/frame-throttling/resources/requestAnimationFrame-frame.html:
• http/tests/frame-throttling/resources/timer-throttling-frame.html:
• http/tests/frame-throttling/timer-throttle-in-cross-origin-subframe.html:

12:01 PM Changeset in webkit [215819] by achristensen@apple.com

• 2 edits in trunk/Source/WebCore

Fix CMake build.

• PlatformMac.cmake:

11:46 AM Changeset in webkit [215818] by keith_miller@apple.com

• 3 edits in trunk/Source/WTF

LocklessBag needs a destructor
​https://bugs.webkit.org/show_bug.cgi?id=171334

Reviewed by Mark Lam.

Currently, if the bag is destructed any remaining nodes in the bag will
be leaked.

• wtf/LocklessBag.h:

(WTF::LocklessBag::consumeAll):
(WTF::LocklessBag::~LocklessBag):

• wtf/threads/Signals.cpp:

(WTF::jscSignalHandler):
(WTF::installSignalHandler):

11:28 AM Changeset in webkit [215817] by commit-queue@webkit.org

• 2 edits in trunk/Source/WTF

[ARM] Enable GCC visibility
​https://bugs.webkit.org/show_bug.cgi?id=171296

Patch by Don Olmstead <​don.olmstead@am.sony.com> on 2017-04-26
Reviewed by Michael Catanzaro.

• wtf/Platform.h:

11:22 AM Changeset in webkit [215816] by Antti Koivisto

• 12 edits in trunk/Source

Enable expired-only reload policy on Mac and iOS
​https://bugs.webkit.org/show_bug.cgi?id=171264
<rdar://problem/31807637>

Reviewed by Andreas Kling.

Source/WebCore:

Limit the behavior to http and data URLs (where we explicitly know about expiration).

• html/HTMLLinkElement.cpp:

(WebCore::HTMLLinkElement::setCSSStyleSheet):

• loader/FrameLoader.cpp:

(WebCore::FrameLoader::subresourceCachePolicy):

Pass the URL so we can test for protocol.

• loader/FrameLoader.h:
• loader/NavigationAction.cpp:

(WebCore::navigationType):

Test for reload navigation type correctly.

• loader/cache/CachedResource.cpp:

(WebCore::CachedResource::load):

• loader/cache/CachedResourceLoader.cpp:

(WebCore::CachedResourceLoader::determineRevalidationPolicy):
(WebCore::CachedResourceLoader::cachePolicy):

• loader/cache/CachedResourceLoader.h:

Source/WebKit2:

Enable the reload policy where only expired subresources are revalidated on Mac and iOS.
The behavor is enabled in Safari and for other clients based on SDK version check.

• UIProcess/API/C/WKPage.cpp:

(WKPageReload):

• UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView reload]):

• UIProcess/Cocoa/VersionChecks.h:

11:17 AM Changeset in webkit [215815] by jmarcell@apple.com

• 1 copy in tags/Safari-604.1.18.1

New tag.

11:14 AM Changeset in webkit [215814] by commit-queue@webkit.org

• 4 edits in trunk

Response.blob() does not set the content-type based on the header value.
​https://bugs.webkit.org/show_bug.cgi?id=170849

Patch by WebKit Contributor <​webkitcontrib@gmail.com> on 2017-04-26
Reviewed by Alex Christensen.

LayoutTests/imported/w3c:

• web-platform-tests/fetch/api/response/response-consume-expected.txt:

Source/WebCore:

The Fetch API specification requires setting the blob contentType
using the Content-Type header value, if present. Previously the
FetchResponse class only called updateContentType() when first
created even though all the headers were not available. Call
updateContentType() again after the headers are populated.

This change allows WebKit to pass the "Consume response's body: from
fetch to blob" case in the WPT response-consume.html test.

Test: ​http://w3c-test.org/fetch/api/response/response-consume.html

• Modules/fetch/FetchResponse.cpp:

(WebCore::FetchResponse::BodyLoader::didReceiveResponse): Modified to
call FetchBodyOwner::updateContentType() after filling m_headers.

11:11 AM Changeset in webkit [215813] by commit-queue@webkit.org

• 2 edits in trunk/LayoutTests

Removing Flaky timeout expectation for swipe/main-frame-pinning-requirement.html.
​https://bugs.webkit.org/show_bug.cgi?id=161887

Patch by Matt Lewis <Matt Lewis> on 2017-04-26
Reviewed by Tim Horton.

• platform/mac-wk2/TestExpectations:

11:03 AM Changeset in webkit [215812] by aestes@apple.com

• 2 edits in trunk/Source/WebCore

Try to fix the macOS Sierra build.

• platform/mac/WebVideoFullscreenInterfaceMac.mm:

10:51 AM Changeset in webkit [215811] by aestes@apple.com

• 16 edits in trunk/Source

[macOS] Add picture-in-picture support to WebPlaybackControlsManager
​https://bugs.webkit.org/show_bug.cgi?id=171328
<rdar://problem/29875010>

Reviewed by Jer Noble.

Source/WebCore:

• platform/cocoa/WebPlaybackSessionModel.h:
• platform/cocoa/WebPlaybackSessionModelMediaElement.h:
• platform/cocoa/WebPlaybackSessionModelMediaElement.mm:

(WebCore::WebPlaybackSessionModelMediaElement::togglePictureInPicture): If the media element
is currently in PiP fullscreen mode, exit fullscreen. Otherwise, enter PiP fullscreen mode.

• platform/mac/WebPlaybackControlsManager.h:
• platform/mac/WebPlaybackControlsManager.mm:

(-[WebPlaybackControlsManager canTogglePictureInPicture]): Added. Returns YES if
-allowsPictureInPicturePlayback returns YES.
(-[WebPlaybackControlsManager togglePictureInPicture]): Added. Calls
WebPlaybackSessionModel::togglePictureInPicture().

• platform/mac/WebVideoFullscreenInterfaceMac.mm:

(WebCore::WebVideoFullscreenInterfaceMac::enterFullscreen): Added a call to
-[WebPlaybackControlsManager setPictureInPictureActive:YES].
(WebCore::WebVideoFullscreenInterfaceMac::exitFullscreen): Added a call to
-[WebPlaybackControlsManager setPictureInPictureActive:NO].
(WebCore::WebVideoFullscreenInterfaceMac::exitFullscreenWithoutAnimationToMode): Ditto.

• platform/spi/cocoa/AVKitSPI.h: Declared new SPI on AVTouchBarPlaybackControlsControlling.

Source/WebKit2:

• UIProcess/Cocoa/WebPlaybackSessionManagerProxy.h:
• UIProcess/Cocoa/WebPlaybackSessionManagerProxy.mm:

(WebKit::WebPlaybackSessionModelContext::togglePictureInPicture): Added. Calls
WebPlaybackSessionManagerProxy::togglePictureAndPicture().
(WebKit::WebPlaybackSessionManagerProxy::togglePictureInPicture): Added. Sends
TogglePictureInPicture to WebPlaybackSessionManager.

• UIProcess/Cocoa/WebViewImpl.mm:

(WebKit::WebViewImpl::updateMediaTouchBar): Called
-[WebPlaybackControlsManager setAllowsPictureInPicturePlayback:YES] if
WebPreferences::allowsPictureInPictureMediaPlayback() is true.

• WebProcess/cocoa/WebPlaybackSessionManager.h:
• WebProcess/cocoa/WebPlaybackSessionManager.messages.in:
• WebProcess/cocoa/WebPlaybackSessionManager.mm:

(WebKit::WebPlaybackSessionManager::togglePictureInPicture): Added. Sets a
UserGestureIndicator and calls WebPlaybackSessionModel::togglePictureInPicture().

10:41 AM Changeset in webkit [215810] by caitp@igalia.com

• 2 edits in trunk/Source/JavaScriptCore

[JSC] fix RETURN_IF_EXCEPTION() placement in ownPropertyKeys()
​https://bugs.webkit.org/show_bug.cgi?id=171330

Reviewed by Mark Lam.

Ensure RETURN_IF_EXCEPTION() following invokation of the
filterPropertyIfNeeded() lambda.

• runtime/ObjectConstructor.cpp:

(JSC::ownPropertyKeys):

10:34 AM Changeset in webkit [215809] by dino@apple.com

• 8 edits
  2 adds in trunk

[Color] Make gradients work with ExtendedColors
​https://bugs.webkit.org/show_bug.cgi?id=171315
<rdar://problems/31830177>

Reviewed by Antoine Quint.

Source/WebCore:

Allow gradients to hold Color objects, and thus
handle ExtendedColor. Implement the backend for
CoreGraphics.

Test: css3/color/gradients.html

• platform/graphics/Gradient.cpp:

(WebCore::Gradient::addColorStop): Just copy the Color now.
(WebCore::compareStops): Handle rename of stop to offset.
(WebCore::Gradient::hasAlpha): Use Color's helper.

• platform/graphics/Gradient.h:

(WebCore::Gradient::ColorStop::ColorStop): Rename stop
to offset, and store a Color rather than four floating
point values.

• platform/graphics/cairo/GradientCairo.cpp:

(WebCore::Gradient::platformGradient):

• platform/graphics/cg/GradientCG.cpp:

(WebCore::Gradient::platformGradient): Use the CG method
that can handle CGColorRefs with ColorSpace values, and
pass the Extended sRGB space which should be no change for
all existing gradients but also handle ColorSpaces like
Display P3.

• platform/graphics/win/GradientDirect2D.cpp:

(WebCore::Gradient::generateGradient):

• svg/SVGGradientElement.cpp:

(WebCore::SVGGradientElement::buildStops):

LayoutTests:

Test for gradients using the color() syntax. Unfortunately,
due to rounding errors, we can't use a ref test for some
transparent colors, so comment them out for the moment.
These can be re-enabled when we can specify a tolerance
value for image comparison in the testing framework.

• css3/color/gradients-expected.html: Added.
• css3/color/gradients.html: Added.

10:22 AM Changeset in webkit [215808] by timothy_horton@apple.com

• 2 edits in trunk/Source/WebKit2

WebKit calls AppKit NSCell API from a background queue
​https://bugs.webkit.org/show_bug.cgi?id=171318
<rdar://problem/31798317>

Reviewed by Anders Carlsson.

• UIProcess/mac/ServicesController.mm:

(WebKit::ServicesController::refreshExistingServices):
Synchronously bounce to the main thread to do non-thread-safe NSCell related work.

10:08 AM Changeset in webkit [215807] by achristensen@apple.com

• 6 edits
  1 move in trunk

Encoded filename should be decoded for WKContentExtension.identifier
​https://bugs.webkit.org/show_bug.cgi?id=171316

Reviewed by Andy Estes.

Source/WebCore:

• platform/FileSystem.h:

Source/WebKit2:

• UIProcess/API/APIContentExtensionStore.cpp:

(API::createExtension):
(API::ContentExtensionStore::lookupContentExtension):
(API::ContentExtensionStore::getAvailableContentExtensionIdentifiers):

Tools:

• TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
• TestWebKitAPI/Tests/WebKit2Cocoa/WKContentExtensionStore.mm: Copied from Tools/TestWebKitAPI/Tests/WebKit2Cocoa/WKUserContentExtensionStore.mm.

(TEST_F):

• TestWebKitAPI/Tests/WebKit2Cocoa/WKUserContentExtensionStore.mm: Removed.

9:54 AM Changeset in webkit [215806] by commit-queue@webkit.org

• 3 edits in trunk/Source/WebCore

Fix typo in RenderFrameBase
​https://bugs.webkit.org/show_bug.cgi?id=171324

Patch by Frederic Wang <​fwang@igalia.com> on 2017-04-26
Reviewed by Zalan Bujtas.

No new tests, behavior unchanged.

• rendering/RenderFrameBase.cpp:

(WebCore::RenderFrameBase::layoutWithFlattening):
(WebCore::RenderFrameBase::performLayoutWithFlattening):
(WebCore::RenderFrameBase::peformLayoutWithFlattening): Deleted.

• rendering/RenderFrameBase.h:

9:34 AM Changeset in webkit [215805] by Alan Bujtas

• 3 edits
  2 adds in trunk

Forced page break on :after triggers infinite loop in column balancing
​https://bugs.webkit.org/show_bug.cgi?id=171309
rdar://problem/26285884

Reviewed by David Hyatt.

Source/WebCore:

Stop trying to balance the columns when the forced page breaks >= the number of
columns even when this number is 1. Content will always overflow to the next page.
see ​https://chromium.googlesource.com/chromium/src/+/fbbebf38cefb2712c912581eccb046ef363ec84e%5E%21/#F2

Test: fast/multicol/infinite-loop-when-forced-break.html

• rendering/RenderMultiColumnSet.cpp:

(WebCore::RenderMultiColumnSet::calculateBalancedHeight):

LayoutTests:

• fast/multicol/infinite-loop-when-forced-break-expected.txt: Added.
• fast/multicol/infinite-loop-when-forced-break.html: Added.

9:24 AM Changeset in webkit [215804] by Said Abou-Hallawa

• 2 edits in trunk/Source/WebCore

Attempt to fix a PLT regression.

Unreviewed.

Disable async decoding for large images till the flickering bug wk170640
is fixed.

• platform/graphics/BitmapImage.cpp:

(WebCore::BitmapImage::shouldUseAsyncDecodingForLargeImages):

9:13 AM Changeset in webkit [215803] by Ryan Haddad

• 4 edits
  6 deletes in trunk

Unreviewed, rolling out r215767.

The LayoutTest for this change is a flaky failure.

Reverted changeset:

"Restrict WebKit image formats to a known whitelist"
​https://bugs.webkit.org/show_bug.cgi?id=170700
​http://trac.webkit.org/changeset/215767

8:58 AM Changeset in webkit [215802] by hyatt@apple.com

• 4 edits in trunk/Source/WebCore

Improve wavy underline rendering
​https://bugs.webkit.org/show_bug.cgi?id=171281

Reviewed by Sam Weinig.

Change wavy underline rendering to use font size instead of stroke
thickness as a way to tune it. Cut the extra offset from 2 to 1.
Change the parameters to make the line flatter and to make the proportion
of the wave that renders underneath a glyph the same.

• rendering/TextDecorationPainter.cpp:

(WebCore::strokeWavyTextDecoration):
(WebCore::TextDecorationPainter::paintTextDecoration):

• style/InlineTextBoxStyle.cpp:

(WebCore::getWavyStrokeParameters):
(WebCore::visualOverflowForDecorations):

• style/InlineTextBoxStyle.h:

(WebCore::wavyOffsetFromDecoration):

8:55 AM Changeset in webkit [215801] by commit-queue@webkit.org

• 6 edits in trunk/Source/WebKit2

Move mediaCaptureEnabled from WKWebViewConfiguration to WKPreferences
​https://bugs.webkit.org/show_bug.cgi?id=171294

Patch by Andrew Gold <​agold@apple.com> on 2017-04-26
Reviewed by Eric Carlson.

Since we now want the ability to toggle this setting dynamically, I have
moved it from WKWebViewConfiguration to WKPreferences.

• UIProcess/API/Cocoa/WKPreferences.mm:

(-[WKPreferences _mediaStreamEnabled]):
(-[WKPreferences _setMediaStreamEnabled:]):

• UIProcess/API/Cocoa/WKPreferencesPrivate.h:
• UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _initializeWithConfiguration:]): No longer set mediaStream enabled from
the configuration.

• UIProcess/API/Cocoa/WKWebViewConfiguration.mm:

(-[WKWebViewConfiguration copyWithZone:]):
(-[WKWebViewConfiguration _mediaStreamEnabled]): Deleted.
(-[WKWebViewConfiguration _setMediaStreamEnabled:]): Deleted.

• UIProcess/API/Cocoa/WKWebViewConfigurationPrivate.h:

8:34 AM Changeset in webkit [215800] by svillar@igalia.com

• 8 edits in trunk

[css-grid] Remove most of the usage of SizingOperation
​https://bugs.webkit.org/show_bug.cgi?id=171225

Reviewed by Darin Adler.

Source/WebCore:

SizingOperation was added as a way to modify the behaviour of the track sizing algorithm
with the specifics for intrinsic size computations. The problem is that although intrinsic
size computation does imply indefinite sizes, the opposite is not always true. For example,
a grid container with height:auto would compute the row sizes with an indefinite size but is
not part of the intrinsic size (preferred widths) computation.

That's why it was wrongly used in some parts of the current code, in most of the cases is
more than enough to check whether the available space is indefinite or not. In order to do
that we have to keep both available sizes (height & width) around all the time to properly
support orthogonal flows.

This change does not imply any change in behaviour.

• rendering/GridTrackSizingAlgorithm.cpp:

(WebCore::GridTrackSizingAlgorithm::setAvailableSpace):
(WebCore::GridTrackSizingAlgorithm::computeTrackBasedSize):
(WebCore::GridTrackSizingAlgorithm::initialBaseSize):
(WebCore::GridTrackSizingAlgorithm::initialGrowthLimit):
(WebCore::GridTrackSizingAlgorithm::sizeTrackToFitNonSpanningItem):
(WebCore::GridTrackSizingAlgorithm::increaseSizesToAccommodateSpanningItems):
(WebCore::GridTrackSizingAlgorithm::assumedRowsSizeForOrthogonalChild):
(WebCore::GridTrackSizingAlgorithm::gridAreaBreadthForChild):
(WebCore::GridTrackSizingAlgorithm::gridTrackSize):
(WebCore::IndefiniteSizeStrategy::findUsedFlexFraction):
(WebCore::IndefiniteSizeStrategy::recomputeUsedFlexFractionIfNeeded):
(WebCore::GridTrackSizingAlgorithm::initializeTrackSizes):
(WebCore::GridTrackSizingAlgorithm::setup):
(WebCore::GridTrackSizingAlgorithm::reset):

• rendering/GridTrackSizingAlgorithm.h:

(WebCore::GridTrackSizingAlgorithmStrategy::availableSpace):

• rendering/RenderGrid.cpp:

(WebCore::RenderGrid::availableSpaceForGutters):
(WebCore::RenderGrid::computeTrackBasedLogicalHeight):
(WebCore::RenderGrid::computeTrackSizesForDefiniteSize):
(WebCore::RenderGrid::layoutBlock):
(WebCore::RenderGrid::gridGap):
(WebCore::RenderGrid::guttersSize):
(WebCore::RenderGrid::computeIntrinsicLogicalWidths):
(WebCore::RenderGrid::computeTrackSizesForIndefiniteSize):
(WebCore::RenderGrid::computeAutoRepeatTracksCount):
(WebCore::RenderGrid::placeItemsOnGrid):
(WebCore::RenderGrid::trackSizesForComputedStyle):
(WebCore::RenderGrid::applyStretchAlignmentToTracksIfNeeded):
(WebCore::RenderGrid::offsetAndBreadthForPositionedChild):
(WebCore::RenderGrid::populateGridPositionsForDirection):
(WebCore::RenderGrid::columnAxisOffsetForChild):
(WebCore::RenderGrid::rowAxisOffsetForChild):
(WebCore::RenderGrid::gridGapForDirection): Deleted.

• rendering/RenderGrid.h:

LayoutTests:

Added a new test case which was working correctly but that was not properly tested before.

• fast/css-grid-layout/grid-track-sizing-with-percentages-and-orthogonal-flows-expected.txt:
• fast/css-grid-layout/grid-track-sizing-with-percentages-and-orthogonal-flows.html:

7:56 AM Changeset in webkit [215799] by caitp@igalia.com

• 5 edits in trunk

[JSC] Object.keys() must discard property names with no PropertyDescriptor
​https://bugs.webkit.org/show_bug.cgi?id=171291

Reviewed by Yusuke Suzuki.

JSTests:

• es6/Proxy_ownKeys_duplicates.js:
• stress/proxy-own-keys.js:

(let.handler.getOwnPropertyDescriptor):
(let.handler.ownKeys):

Source/JavaScriptCore:

Proxy objects can produce an arbitrary list of property names from the
"ownKeys" trap, however the Object.keys() algorithm is required to
discard names which do not have a PropertyDescriptor. This also
applies to other uses of the EnumerableOwnProperties() algorithm
(​https://tc39.github.io/ecma262/#sec-enumerableownproperties)

Related to ​https://bugs.chromium.org/p/v8/issues/detail?id=6290

• runtime/ObjectConstructor.cpp:

(JSC::ownPropertyKeys):

6:34 AM Changeset in webkit [215798] by Yusuke Suzuki

• 3 edits in trunk/Source/WTF

sendMessageScoped's signal handler calls LocklessBag::consumeAll, which causes heap deallocation in signal handler and leads deadlock
​https://bugs.webkit.org/show_bug.cgi?id=171319

Reviewed by Keith Miller.

In sendMessageScoped, we call LocklessBag<SignalHandler>::consumeAll thread->threadMessages().consumeAll().
In LocklessBag::consumeAll, we call delete on Nodes.
The problem is that this is called under the context of signal handler. Thus, when calling this, the original
thread may hold the lock in bmalloc. In that case, this delete call attempts to lock the heap lock recursively,
and causes deadlock.

Instead, this patch transfers the LocklessBag's Node to the sender thread. And the sender thread deletes it instead.

• wtf/LocklessBag.h:

(WTF::LocklessBag::consumeAllWithNode):

• wtf/ThreadMessage.cpp:

(WTF::ThreadMessageData::ThreadMessageData):
(WTF::sendMessageScoped):

1:50 AM Changeset in webkit [215797] by commit-queue@webkit.org

• 3 edits in trunk/Source/WebCore

Remove Document::*FrameElementsShouldIgnoreScrolling
​https://bugs.webkit.org/show_bug.cgi?id=171271

Patch by Frederic Wang <​fwang@igalia.com> on 2017-04-26
Reviewed by Chris Dumez.

setFrameElementsShouldIgnoreScrolling and frameElementsShouldIgnoreScrolling were
introduced bug 23072 in order to work around a bug in the Dictionary application.
However, this was removed in bug 132095 and hence the functions are no longer necessary.

No new tests.

• dom/Document.h:

(WebCore::Document::setFrameElementsShouldIgnoreScrolling): Deleted.
(WebCore::Document::frameElementsShouldIgnoreScrolling): Deleted.

• html/HTMLFrameElementBase.cpp:

(WebCore::HTMLFrameElementBase::parseAttribute):

12:40 AM Changeset in webkit [215796] by zandobersek@gmail.com

• 2 edits in trunk/Source/WebCore

[GCrypt] CryptoKeyRSA: implement create(), keySizeInBits(), buildAlgorithm(), exportData()
​https://bugs.webkit.org/show_bug.cgi?id=171213

Reviewed by Michael Catanzaro.

CryptoKeyRSA::create() validates the specified key type along with the
provided data. If everything is OK, it then proceeds to build the key
of the appropriate type through an s-expression that is constructed with
the necessary data. We don't currently support creating private keys
with any additional prime information (apart from p and q).

CryptoKeyRSA::keySizeInBits() calls the helper getRSAModulusLength()
function that find the modulus MPI in the key s-expression and returns
the modulus data length in bits.

CryptoKeyRSA::buildAlgorithm() returns KeyAlgorithm that's constructed
from the appropriate name, this key's modulus length, and this key's
public exponent data. It also specifies the hash if there is such a
restriction for this key.

CryptoKeyRSA::exportData() returns a properly-constructed
CryptoKeyDataRSAComponents object. The public modulus and exponent are
used in case the key is public. If the key is private, the secret
exponent and the p and q prime numbers are retrieved in MPI format.
They're then used to calculate the dp, dq and qi parameters that are
exported in the JWK format. Note that libgcrypt internally switches
the p and q prime numbers such that p < q, but the Web Crypto
specification and the dependant RFCs expect that q < p. We address
this by simply switching the roles of the two primes and follow the
usual q < p assumption when exporting the primes and computing the
dependant exponents and coefficients.

No new tests -- existing ones cover this but don't work yet due to missing
RSA-related CryptoAlgorithm implementations.

• crypto/gcrypt/CryptoKeyRSAGCrypt.cpp:

(WebCore::getRSAModulusLength):
(WebCore::getParameterMPIData):
(WebCore::getRSAKeyParameter):
(WebCore::CryptoKeyRSA::create):
(WebCore::CryptoKeyRSA::keySizeInBits):
(WebCore::CryptoKeyRSA::buildAlgorithm):
(WebCore::CryptoKeyRSA::exportData):

Apr 25, 2017:

11:39 PM Changeset in webkit [215795] by Nikita Vasilyev

• 2 edits in trunk/Source/WebInspectorUI

REGRESSION (r209882): Web Inspector: Command-G does not work in the console
​https://bugs.webkit.org/show_bug.cgi?id=170555
<rdar://problem/31481247>

Reviewed by Brian Burg.

Command-G didn't work in the console when the console content view was in focus. It only
worked when the search input field was focused.

• UserInterface/Views/LogContentView.js:

(WebInspector.LogContentView.prototype.findBannerRevealPreviousResult):
(WebInspector.LogContentView.prototype.highlightPreviousSearchMatch): Added.
(WebInspector.LogContentView.prototype.findBannerRevealNextResult):
(WebInspector.LogContentView.prototype.highlightNextSearchMatch): Added.
Re-introduce highlightPreviousSearchMatch and highlightNextSearchMatch methods that were
removed in r209882.

11:38 PM Changeset in webkit [215794] by commit-queue@webkit.org

• 5 edits in trunk/LayoutTests

[mac-wk1 Debug] LayoutTest http/tests/inspector/network/resource-sizes-network.html is a flaky failure
​https://bugs.webkit.org/show_bug.cgi?id=170953

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2017-04-25
Reviewed by Brian Burg.

• http/tests/inspector/network/resource-sizes-disk-cache.html:
• http/tests/inspector/network/resource-sizes-network.html:

Read the entire data to ensure the load is complete before we notify the frontend.

• platform/mac-wk1/TestExpectations:
• platform/mac-wk2/TestExpectations:

Unflake these tests, they should be more reliable now.

11:35 PM Changeset in webkit [215793] by commit-queue@webkit.org

• 4 edits in trunk/Source/WebInspectorUI

Web Inspector: Network Tab - Sorting by Priority Column hides all rows in the datagrid (uncaught exception)
​https://bugs.webkit.org/show_bug.cgi?id=171312
<rdar://problem/31828554>

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2017-04-25
Reviewed by Brian Burg.

• UserInterface/Models/Resource.js:

(WebInspector.Resource.comparePriority):
Provide a helper for compariting NetworkPriority enum values.

• UserInterface/Views/NetworkGridContentView.js:

(WebInspector.NetworkGridContentView):
(WebInspector.NetworkGridContentView.prototype.dataGridSortComparator):

• UserInterface/Views/NetworkTimelineView.js:

(WebInspector.NetworkTimelineView.prototype.dataGridSortComparator):
Custom sort handler for priority.

10:18 PM Changeset in webkit [215792] by commit-queue@webkit.org

• 2 edits in trunk/Source/JavaScriptCore

Unhandled enumeration values in IntlDateTimeFormat.cpp
​https://bugs.webkit.org/show_bug.cgi?id=171241

Patch by Andy VanWagoner <​thetalecrafter@gmail.com> on 2017-04-25
Reviewed by JF Bastien.

Added some missing cases of the UDateFormatField to partTypeString,
and made them conditional to the ICU version that added them.
This should remove the warnings that appear on platform builds using the
newer system ICU headers.

• runtime/IntlDateTimeFormat.cpp:

(JSC::IntlDateTimeFormat::partTypeString):

9:31 PM Changeset in webkit [215791] by jiewen_tan@apple.com

• 2 edits in trunk/Source/WebCore

[WebCrypto] Enhance ways to convert an ECDSA signature binary into DER format
​https://bugs.webkit.org/show_bug.cgi?id=171287
<rdar://problem/31735332>

Reviewed by Brent Fulgham.

Covered by existing tests.

• crypto/mac/CryptoAlgorithmECDSAMac.cpp:

(WebCore::verifyECDSA):

9:27 PM Changeset in webkit [215790] by achristensen@apple.com

• 7 edits
  1 add in trunk

REGRESSION(206450): WebKit2PlatformMouseEvent m_modifierFlags not set
​https://bugs.webkit.org/show_bug.cgi?id=171297
<rdar://problem/31530719>

Reviewed by Geoffrey Garen.

Source/WebKit2:

• Shared/WebEventConversion.cpp:

(WebKit::WebKit2PlatformMouseEvent::WebKit2PlatformMouseEvent):

Tools:

• TestWebKitAPI/PlatformWebView.h:
• TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
• TestWebKitAPI/Tests/WebKit2/EventModifiers.cpp: Added.

(TestWebKitAPI::didFinishLoadForFrame):
(TestWebKitAPI::mouseDidMoveOverElement):
(TestWebKitAPI::setClients):
(TestWebKitAPI::TEST):

• TestWebKitAPI/mac/PlatformWebViewMac.mm:

(TestWebKitAPI::PlatformWebView::simulateRightClick):
(TestWebKitAPI::PlatformWebView::simulateMouseMove):

9:27 PM Changeset in webkit [215789] by Nikita Vasilyev

• 2 edits in trunk/Source/WebInspectorUI

REGRESSION (r214863): Web Inspector: Uncaught Exception when losing focus from a selector field
​https://bugs.webkit.org/show_bug.cgi?id=171254
<rdar://problem/31813959>

Reviewed by Joseph Pecoraro.

The event.relatedTarget of a blur event contains the element where focus moved to.
In some cases this can be null, such as if the user leaves the application window.
For example Command+Tab to switch to another application.

• UserInterface/Views/CSSStyleDeclarationSection.js:

(WebInspector.CSSStyleDeclarationSection.prototype._handleSelectorPaste):

9:24 PM Changeset in webkit [215788] by commit-queue@webkit.org

• 4 edits in trunk/LayoutTests

fast/mediastream/RTCPeerConnection-icecandidate-event.html is flaky
​https://bugs.webkit.org/show_bug.cgi?id=171242

Patch by Youenn Fablet <​youenn@apple.com> on 2017-04-25
Reviewed by Alex Christensen.

• TestExpectations:
• fast/mediastream/RTCPeerConnection-icecandidate-event-expected.txt:
• fast/mediastream/RTCPeerConnection-icecandidate-event.html: Updating test to be more deterministic.

7:26 PM Changeset in webkit [215787] by Brent Fulgham

• 5 edits
  2 adds in trunk

Relax the event firing ASSERT for Attr changes
​https://bugs.webkit.org/show_bug.cgi?id=171236
<rdar://problem/30516349>

Reviewed by Dean Jackson.

Source/WebCore:

The assertions added in Bug 167318 were overly strict, and trigger for valid behavior.
Relax the assertion preventing event dispatch for the case of Attr elements at the
end of childrenChanged.

Test: fast/dom/HTMLLinkElement/event-while-removing-attribute.html

• dom/Attr.cpp:

(WebCore::Attr::childrenChanged):

LayoutTests:

• fast/dom/HTMLLinkElement/event-while-removing-attribute-expected.txt: Added.
• fast/dom/HTMLLinkElement/event-while-removing-attribute.html: Added.

7:16 PM Changeset in webkit [215786] by Wenson Hsieh

• 2 edits in trunk/Source/WebKit2

Unreviewed, speculative build fix

• UIProcess/API/Cocoa/WKUIDelegatePrivate.h:

For the time being, remove all references to UIItemProviders from this private header.
This should be fixed to use unavailability macros in a followup. See <rdar://problem/31827095>.

7:02 PM Changeset in webkit [215785] by Wenson Hsieh

• 4 edits in trunk/Tools

Unreviewed, temporarily disable the data interaction unit tests.

The API around data interaction will change significantly in the near future, and
these tests will begin to fail. These will be reenabled once the bots are on an SDK
that supports the updated data interaction API.

• TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
• TestWebKitAPI/ios/DataInteractionSimulator.h:
• TestWebKitAPI/ios/DataInteractionSimulator.mm:

6:53 PM Changeset in webkit [215784] by Brent Fulgham

• 7 edits
  3 adds in trunk

Limit allowed size of document.title to avoid locking WebKit clients
​https://bugs.webkit.org/show_bug.cgi?id=165113
<rdar://problem/28324389>

Reviewed by Darin Adler.

Source/WebKit/mac:

When a web application attempts to set an extremely long title, truncate the
title to a more reasonable size.

We do this at at the presentation layer, rather than in the DOM, so that we do
not affect script function. Instead, we merely limit display to a level that is
reasonable for normal GUI widgets. Anything else needs to be truncated in the UI
layer, so it is a waste of effort to send across IPC.

• WebCoreSupport/WebFrameLoaderClient.h:
• WebCoreSupport/WebFrameLoaderClient.mm:

(WebFrameLoaderClient::dispatchDidReceiveTitle):

Source/WebKit2:

When a web application attempts to set an extremely long title, truncate the
title to a more reasonable size.

We do this at at the presentation layer, rather than in the DOM, so that we do
not affect script function. Instead, we merely limit display to a level that is
reasonable for normal GUI widgets. Anything else needs to be truncated in the UI
layer, so it is a waste of effort to send across IPC.

• WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::dispatchDidReceiveTitle):

• WebProcess/WebCoreSupport/WebFrameLoaderClient.h:

Tools:

• TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add new files.
• TestWebKitAPI/Tests/WebKit2/LimitTitleSize.cpp: Added.
• TestWebKitAPI/Tests/WebKit2/set-long-title.html: Added.
• TestWebKitAPI/Tests/mac/LimitTitleSize.mm: Added.

6:45 PM Changeset in webkit [215783] by dino@apple.com

• 2 edits in trunk/LayoutTests

REGRESSION (r214129): fast/media/mq-prefers-reduced-motion.html fails
​https://bugs.webkit.org/show_bug.cgi?id=171303
<rdar://problem/31434879>

Reviewed by Brent Fulgham.

This particular test was calling notifyDone() from within
a callback triggered by the UIScriptController script, which
meant that by the time the controller tried to call its callback,
the test had finished.

• fast/media/mq-prefers-reduced-motion-matchMedia.html: Make sure

notifyDone is called after both the callback-like functions have
triggered.

6:22 PM Changeset in webkit [215782] by wilander@apple.com

• 21 edits
  1 copy
  1 add in trunk

Resource Load Statistics: Introduce shorter time-to-live for cookie partition whitelisting
​https://bugs.webkit.org/show_bug.cgi?id=171295
<rdar://problem/31823818>

Reviewed by Brent Fulgham.

Source/WebCore:

Test: http/tests/loading/resourceLoadStatistics/partitioned-and-unpartitioned-cookie-with-partitioning-timeout.html

• loader/ResourceLoadObserver.cpp:

(WebCore::reduceTimeResolutionToOneDay): Deleted.
(WebCore::reduceTimeResolution):

Changed name to no longer lock this to a specific resolution.

(WebCore::ResourceLoadObserver::logUserInteractionWithReducedTimeResolution):

Now calls WebCore::reduceTimeResolution().

(WebCore::ResourceLoadObserver::setTimeToLiveCookiePartitionFree):

Added for testing purposes.

(WebCore::ResourceLoadObserver::fireShouldPartitionCookiesHandler):

Added for testing purposes.

• loader/ResourceLoadObserver.h:
• loader/ResourceLoadStatisticsStore.cpp:

(WebCore::shouldPartitionCookies):

Static inline convenience function.

(WebCore::ResourceLoadStatisticsStore::fireShouldPartitionCookiesHandler):

Now decides whether a domain should get partitioned cookies
based on timeToLiveCookiePartitionFree.
Removed clearFirst parameter since it's not needed here
and it introduced complexity in keeping the store and the
network process cache in sync.

(WebCore::ResourceLoadStatisticsStore::setTimeToLiveCookiePartitionFree):

Added for testing purposes.

• loader/ResourceLoadStatisticsStore.h:

Source/WebKit2:

• UIProcess/API/C/WKResourceLoadStatisticsManager.cpp:

(WKResourceLoadStatisticsManagerSetTimeToLiveCookiePartitionFree):
(WKResourceLoadStatisticsManagerFireShouldPartitionCookiesHandler):
(WKResourceLoadStatisticsManagerFireShouldPartitionCookiesHandlerForOneDomain):

Changes and additions to test infrastructure.

• UIProcess/API/C/WKResourceLoadStatisticsManager.h:
• UIProcess/WebResourceLoadStatisticsManager.cpp:

(WebKit::WebResourceLoadStatisticsManager::setTimeToLiveCookiePartitionFree):
(WebKit::WebResourceLoadStatisticsManager::fireShouldPartitionCookiesHandler):
(WebKit::WebResourceLoadStatisticsManager::fireShouldPartitionCookiesHandlerForOneDomain):
(WebKit::WebResourceLoadStatisticsManager::resetToConsistentState):

Changes and additions to test infrastructure.

• UIProcess/WebResourceLoadStatisticsManager.h:
• UIProcess/WebResourceLoadStatisticsStore.cpp:

(WebKit::WebResourceLoadStatisticsStore::resourceLoadStatisticsUpdated):

No longer sends a boolean parameter to
WebCore::ResourceLoadStatisticsStore::fireShouldPartitionCookiesHandler().

Tools:

• WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
• WebKitTestRunner/InjectedBundle/TestRunner.cpp:

(WTR::TestRunner::setStatisticsTimeToLiveCookiePartitionFree):
(WTR::TestRunner::statisticsFireShouldPartitionCookiesHandler):
(WTR::TestRunner::statisticsFireShouldPartitionCookiesHandlerForOneDomain):

• WebKitTestRunner/InjectedBundle/TestRunner.h:
• WebKitTestRunner/TestController.cpp:

(WTR::TestController::setStatisticsTimeToLiveCookiePartitionFree):
(WTR::TestController::statisticsFireShouldPartitionCookiesHandler):
(WTR::TestController::statisticsFireShouldPartitionCookiesHandlerForOneDomain):

• WebKitTestRunner/TestController.h:
• WebKitTestRunner/TestInvocation.cpp:

(WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):

LayoutTests:

• http/tests/loading/resourceLoadStatistics/partitioned-and-unpartitioned-cookie-deletion.html:

Changed a TestRunner function name to
statisticsFireShouldPartitionCookiesHandlerForOneDomain().

• http/tests/loading/resourceLoadStatistics/partitioned-and-unpartitioned-cookie-with-partitioning-timeout-expected.txt: Added.
• http/tests/loading/resourceLoadStatistics/partitioned-and-unpartitioned-cookie-with-partitioning-timeout.html: Added.
• http/tests/loading/resourceLoadStatistics/partitioned-cookies-with-and-without-user-interaction.html:

Changed a TestRunner function name to
statisticsFireShouldPartitionCookiesHandlerForOneDomain().

6:11 PM Changeset in webkit [215781] by matthew_hanson@apple.com

• 5 edits in branches/safari-603-branch/Source

Versioning.

6:11 PM Changeset in webkit [215780] by Simon Fraser

• 2 edits in trunk/Source/WebKit2

REGRESSION (r213719): WebGL content on cubeslam.com is 1/4 expected size
​https://bugs.webkit.org/show_bug.cgi?id=171300
rdar://problem/31051538

Reviewed by Dean Jackson.

Propagating the contentsScale to the UI process for canvas content layers causes
scaling issues, so don't do it for contents-provided layers.

No test because WebGL can't be tested in the iOS simulator.

• WebProcess/WebPage/mac/PlatformCALayerRemote.cpp:

(WebKit::PlatformCALayerRemote::PlatformCALayerRemote):

5:57 PM Changeset in webkit [215779] by commit-queue@webkit.org

• 49 edits
  13 deletes in trunk

Unreviewed, rolling out r215476.
​https://bugs.webkit.org/show_bug.cgi?id=171304

"It broke JSBench" (Requested by saamyjoon on #webkit).

Reverted changeset:

"[ES6]. Implement Annex B.3.3 function hoisting rules for
eval"
​https://bugs.webkit.org/show_bug.cgi?id=163208
​http://trac.webkit.org/changeset/215476

5:52 PM Changeset in webkit [215778] by beidson@apple.com

• 6 edits in trunk/Source/WebKit2

Update WebProcess(Pool) to assume there's always a WebsiteDataStore
​https://bugs.webkit.org/show_bug.cgi?id=171299

Reviewed by Alex Christensen.

• UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::reattachToWebProcess):

• UIProcess/WebProcessPool.cpp:

(WebKit::WebProcessPool::createNewWebProcess):
(WebKit::WebProcessPool::warmInitialProcess):
(WebKit::WebProcessPool::createNewWebProcessRespectingProcessCountLimit):
(WebKit::WebProcessPool::createWebPage):

• UIProcess/WebProcessPool.h:
• UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::create):
(WebKit::WebProcessProxy::WebProcessProxy):
(WebKit::m_userMediaCaptureManagerProxy):

• UIProcess/WebProcessProxy.h:

(WebKit::WebProcessProxy::websiteDataStore):

5:52 PM Changeset in webkit [215777] by sbarati@apple.com

• 19 edits
  5 adds in trunk

JSArray::isArrayPrototypeIteratorProtocolFastAndNonObservable is wrong because it does not do the necessary checks on the base object
​https://bugs.webkit.org/show_bug.cgi?id=171150
<rdar://problem/31771880>

Reviewed by Sam Weinig.

JSTests:

• stress/spread-optimized-properly.js: Added.

(assert):
(test):
(shallowEq):
(makeArrayIterator):
(test.bar):
(test.callback):
(test.arr.proto.Symbol.iterator):
(test.arr.Symbol.iterator):
(test.get bar):
(test.hackedNext):
(test.test):
(test.):

Source/JavaScriptCore:

This patch fixes a huge oversight from the patch that introduced
op_spread/Spread. The original patch did not account for the
base object having Symbol.iterator or getters that could
change the iterator protocol. This patch fixes the oversight both
in the C code, as well as the DFG/FTL backends. We only perform
the memcpy version of spread if we've proven that it's guaranteed
to be side-effect free (no indexed getters), and if the iterator
protocol is guaranteed to be the original protocol. To do this, we
must prove that:

1. The protocol on Array.prototype hasn't changed (this is the same as the

introductory patch for op_spread).

2. The base object's proto is Array.prototype
3. The base object does not have indexed getters
4. The base object does not have Symbol.iterator property.

• dfg/DFGGraph.cpp:

(JSC::DFG::Graph::canDoFastSpread):

• dfg/DFGGraph.h:
• dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileSpread):

• ftl/FTLLowerDFGToB3.cpp:

(JSC::FTL::DFG::LowerDFGToB3::compileSpread):

• runtime/JSArray.cpp:

(JSC::JSArray::isIteratorProtocolFastAndNonObservable):

• runtime/JSArray.h:
• runtime/JSArrayInlines.h:

(JSC::JSArray::isIteratorProtocolFastAndNonObservable): Deleted.

• runtime/JSGlobalObject.h:
• runtime/JSGlobalObjectInlines.h:

(JSC::JSGlobalObject::isArrayPrototypeIteratorProtocolFastAndNonObservable):
(JSC::JSGlobalObject::isArrayIteratorProtocolFastAndNonObservable): Deleted.

Source/WebCore:

This patch moves the sequence converters to use the now fixed
JSArray::isArrayPrototypeIteratorProtocolFastAndNonObservable test
inside JSC.

This patch also fixes a few bugs:

1. Converting to a sequence of numbers must prove that the JSArray

is filled only with Int32/Double. If there is a chance the array
contains objects, the conversion to a numeric IDLType can be observable
(via valueOf()), and can change the iterator protocol.

2. There are other conversions that can have side effects a-la valueOf().

This patch introduces a new static constant in the various Converter
classes that tell the sequence converter if the conversion operation
can have JS side effects. If it does have side effects, we fall back to
the generic conversion that uses the iterator protocol. If not, we can
do a faster version that iterates over each element of the array,
reading it directly, and converting it.

Tests: js/sequence-iterator-protocol-2.html

js/sequence-iterator-protocol.html

• bindings/js/JSDOMConvertAny.h: Does not have side effects.
• bindings/js/JSDOMConvertBase.h: We pessimistically assume inside DefaultConverter that converions have side effects.
• bindings/js/JSDOMConvertBoolean.h: Does not have side effects.
• bindings/js/JSDOMConvertCallbacks.h: Does not have side effects.
• bindings/js/JSDOMConvertObject.h: Does not have side effects.
• bindings/js/JSDOMConvertSequences.h:

(WebCore::Detail::NumericSequenceConverter::convert):
(WebCore::Detail::SequenceConverter::convert):

LayoutTests:

• js/sequence-iterator-protocol-2-expected.txt: Added.
• js/sequence-iterator-protocol-2.html: Added.
• js/sequence-iterator-protocol-expected.txt: Added.
• js/sequence-iterator-protocol.html: Added.

5:42 PM Changeset in webkit [215776] by Ryan Haddad

• 2 edits in trunk/LayoutTests

Mark media/modern-media-controls/pip-support/pip-support-click.html as flaky.
​https://bugs.webkit.org/show_bug.cgi?id=165311

Unreviewed test gardening.

• platform/mac/TestExpectations:

5:39 PM Changeset in webkit [215775] by msaboff@apple.com

• 4 edits in trunk/Source

Call bmalloc scavenger first when handling a memory pressure event
​https://bugs.webkit.org/show_bug.cgi?id=171289

Reviewed by Geoffrey Garen.

Source/bmalloc:

Registered a critical memory pressure handler. We add this handler in addition to the
call to release bmalloc memory in the WebCore releaseMemory handler for the case of
JSC API users that don't use WebCore. When both handlers are in the process, it is
basically a race. One will win, but the loser won't do any more work, so it is harmless.

• bmalloc/Heap.cpp:

(bmalloc::Heap::Heap):

Source/WebCore:

Let bmalloc free any pages to the OS that it can before doing anything else.

• page/MemoryRelease.cpp:

(WebCore::releaseMemory):

5:38 PM Changeset in webkit [215774] by dino@apple.com

• 2 edits in trunk/Source/WebCore

Skip WebKitAdditions for Safari Technology Preview media controls
​https://bugs.webkit.org/show_bug.cgi?id=171302
<rdar://problem/31823256>

Reviewed by Simon Fraser.

Safari Technology Preview should use the same controls
as OpenSource.

• WebCore.xcodeproj/project.pbxproj:

5:16 PM Changeset in webkit [215773] by Ryan Haddad

• 2 edits in trunk/LayoutTests

Mark http/tests/security/contentSecurityPolicy/1.1/module-scriptnonce-invalidnonce.html as flaky.
​https://bugs.webkit.org/show_bug.cgi?id=171301

Unreviewed test gardening.

• platform/ios-wk2/TestExpectations:

5:07 PM Changeset in webkit [215772] by Ryan Haddad

• 8 edits in trunk

Unreviewed, rolling out r215730.

The LayoutTest for this change is a flaky timeout on mac-wk1
debug.

Reverted changeset:

"Enable expired-only reload policy on Mac and iOS"
​https://bugs.webkit.org/show_bug.cgi?id=171264
​http://trac.webkit.org/changeset/215730

5:02 PM Changeset in webkit [215771] by mrajca@apple.com

• 17 edits in trunk

Indicate presence of audio when handling autoplay events.
​https://bugs.webkit.org/show_bug.cgi?id=171227

Reviewed by Alex Christensen.

Source/WebCore:

Added API tests.

• html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::handleAutoplayEvent):
(WebCore::HTMLMediaElement::playInternal):
(WebCore::HTMLMediaElement::mediaPlayerTimeChanged):
(WebCore::HTMLMediaElement::stopWithoutDestroyingMediaPlayer):
(WebCore::HTMLMediaElement::userDidInterfereWithAutoplay):
(WebCore::HTMLMediaElement::setPlaybackWithoutUserGesture):

• html/HTMLMediaElement.h:
• page/AutoplayEvent.h:
• page/ChromeClient.h:

Source/WebKit2:

• UIProcess/API/APIUIClient.h:

(API::UIClient::handleAutoplayEvent):

• UIProcess/API/C/WKPage.cpp:

(WKPageSetPageUIClient):

• UIProcess/API/C/WKPageUIClient.h:
• UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::handleAutoplayEvent):

• UIProcess/WebPageProxy.h:
• UIProcess/WebPageProxy.messages.in:
• WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::handleAutoplayEvent):

• WebProcess/WebCoreSupport/WebChromeClient.h:

4:50 PM Changeset in webkit [215770] by mark.lam@apple.com

• 1 edit
  1 move in trunk/JSTests

[Follow up] Array.prototype.slice() should ensure that end >= begin.
​https://bugs.webkit.org/show_bug.cgi?id=170989
<rdar://problem/31705652>

Not reviewed.

Follow up to rename a test file that was accidentally named wrongly.

• stress/regress-170989.js: Copied from JSTests/stress/regress-170989.patch.
• stress/regress-170989.patch: Removed.

4:49 PM Changeset in webkit [215769] by aakash_jain@apple.com

• 2 edits in trunk/Source/WebCore

WebCore.framework should restrict allowable_clients
​https://bugs.webkit.org/show_bug.cgi?id=171260

Reviewed by Alexey Proskuryakov.

• Configurations/WebCore.xcconfig: Adding allowable_client to all platform, in order to restrict WebCore

from being directly linked on any platform.
Moved WebKitLegacy and WebCoreTestSupport to OTHER_LDFLAGS_BASE.
Removed WebKit2 as allowable_client from mac.
Added iTunesU, Casablanca and Remote to OTHER_LDFLAGS_BASE_ios for iTunes related projects.
Added WebKit, TVBooks, DumpRenderTree, WebKitTestRunner and TestWebKitAPI to OTHER_LDFLAGS_BASE_ios.

4:45 PM Changeset in webkit [215768] by mark.lam@apple.com

• 3 edits
  1 add in trunk

Array.prototype.slice() should ensure that end >= begin.
​https://bugs.webkit.org/show_bug.cgi?id=170989
<rdar://problem/31705652>

Reviewed by Saam Barati.

JSTests:

• stress/regress-170989.patch: Added.

Source/JavaScriptCore:

• runtime/ArrayPrototype.cpp:

(JSC::arrayProtoFuncSlice):

3:23 PM Changeset in webkit [215767] by commit-queue@webkit.org

• 4 edits
  6 adds in trunk

Restrict WebKit image formats to a known whitelist
​https://bugs.webkit.org/show_bug.cgi?id=170700

Patch by Said Abou-Hallawa <​sabouhallawa@apple.com> on 2017-04-25
Reviewed by Tim Horton.

Source/WebCore:

If the image format is not supported, the load should be canceled and the
image is marked a broken image.

Test: fast/images/image-formats-support.html

• loader/cache/CachedImage.cpp:

(WebCore::CachedImage::addIncrementalDataBuffer):
(WebCore::CachedImage::setImageDataBuffer):
(WebCore::CachedImage::finishLoading):

• loader/cache/CachedImage.h:

LayoutTests:

• fast/images/image-formats-support-expected.txt: Added.
• fast/images/image-formats-support.html: Added.
• fast/images/resources/100x100-red-psd-renamed.png: Added.
• fast/images/resources/100x100-red-tga-renamed.png: Added.
• fast/images/resources/100x100-red.psd: Added.
• fast/images/resources/100x100-red.tga: Added.

2:46 PM Changeset in webkit [215766] by commit-queue@webkit.org

• 6 edits in trunk/Source

[Win] Use Clang's has_declspec_attribute for export macros
​https://bugs.webkit.org/show_bug.cgi?id=171240

Patch by Don Olmstead <​don.olmstead@am.sony.com> on 2017-04-25
Reviewed by Alex Christensen.

Source/JavaScriptCore:

• runtime/JSExportMacros.h:

Source/WTF:

• wtf/Compiler.h:
• wtf/ExportMacros.h:
• wtf/Platform.h:

2:45 PM Changeset in webkit [215765] by timothy_horton@apple.com

• 2 edits in trunk/LayoutTests

Deduplicate some lines in the toplevel TestExpectations

• TestExpectations:

Remove a duplicate line and consolidate another.

2:41 PM Changeset in webkit [215764] by Chris Dumez

• 1 edit
  2 adds in trunk/LayoutTests

Element.dataset.name incorrectly returns undefined
​https://bugs.webkit.org/show_bug.cgi?id=161454
<rdar://problem/31818563>

Reviewed by Mark Lam.

Add layout test for JS caching bug on DOMStringMap that was fixed as part
of a large named property getter refactoring in r210667.

• fast/dom/dataset-caching-bug-expected.txt: Added.
• fast/dom/dataset-caching-bug.html: Added.

2:36 PM Changeset in webkit [215763] by timothy_horton@apple.com

• 2 edits in trunk/Tools

Try to fix the WKTR build after r215758

• Scripts/build-webkittestrunner:

2:23 PM Changeset in webkit [215762] by keith_miller@apple.com

• 2 edits in trunk/Source/WTF

Our signal handler shouldn't print when sigaction succeeds
​https://bugs.webkit.org/show_bug.cgi?id=171286

Reviewed by Michael Saboff.

It turns out !result is not the same as !!result.

• wtf/threads/Signals.cpp:

(WTF::jscSignalHandler):

2:21 PM Changeset in webkit [215761] by sbarati@apple.com

• 2 edits in trunk/Source/JavaScriptCore

Unreviewed. Attempt armv7k build fix after r215720

I think we're just missing an include for the definition of ExecState::r().

• runtime/JSFixedArray.cpp:

2:21 PM Changeset in webkit [215760] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebCore

CoreAudioCaptureSource::suspend is asserting too often
​https://bugs.webkit.org/show_bug.cgi?id=171285

Patch by Youenn Fablet <​youenn@apple.com> on 2017-04-25
Reviewed by Eric Carlson.

No change of behavior.

• platform/mediastream/mac/CoreAudioCaptureSource.cpp:

(WebCore::CoreAudioCaptureSource::suspend): Moving the assertion to where it might be useful.

2:15 PM Changeset in webkit [215759] by dbates@webkit.org

• 4 edits in trunk/Source/WebCore

Use an OptionSet for compositing reasons bitmask
​https://bugs.webkit.org/show_bug.cgi?id=171153

Reviewed by Simon Fraser.

We should make use of OptionSet to represent the bitmask of the reasons a layer
was composited instead of using an integer and bitwise operations.

• inspector/InspectorLayerTreeAgent.cpp:

(WebCore::InspectorLayerTreeAgent::reasonsForCompositingLayer):

• rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::reasonsForCompositing):
(WebCore::RenderLayerCompositor::logReasonsForCompositing): Also fix code style issues;
an else-if statement should be written as an if-statement when the prior if-statement
concludes with a return statement.

• rendering/RenderLayerCompositor.h:

2:14 PM Changeset in webkit [215758] by dbates@webkit.org

• 34 edits
  12 deletes in trunk/Tools

Remove more EFL code
​https://bugs.webkit.org/show_bug.cgi?id=171288

Rubber-stamped by Simon Fraser.

The EFL port is no longer in the WebKit OpenSource Project repository. Remove more code
that was part of the EFL port.

• CMakeLists.txt:
• DumpRenderTree/AccessibilityController.h:
• DumpRenderTree/AccessibilityUIElement.cpp:

(AccessibilityUIElement::getJSClass):

• DumpRenderTree/AccessibilityUIElement.h:
• DumpRenderTree/DumpRenderTree.h:
• DumpRenderTree/cairo/PixelDumpSupportCairo.h:
• ImageDiff/efl/ImageDiff.cpp: Removed.
• MiniBrowser/efl/CMakeLists.txt: Removed.
• MiniBrowser/efl/main.c: Removed.
• Scripts/build-dumprendertree:
• Scripts/build-jsc:
• Scripts/build-webkit:
• Scripts/build-webkittestrunner:
• Scripts/run-minibrowser:
• Scripts/update-webkit-libs-jhbuild:
• Scripts/update-webkitefl-libs: Removed.
• Scripts/webkitdirs.pm:

(argumentsForConfiguration):
(extractNonMacOSHostConfiguration):
(executableProductDir):
(builtDylibPathForName):
(determinePortName):
(launcherPath):
(launcherName):
(getJhbuildPath):
(wrapperPrefixIfNeeded):
(generateBuildSystemFromCMakeProject):
(buildCMakeProjectOrExit):
(isEfl): Deleted.

• Scripts/webkitperl/FeatureList.pm:
• Scripts/webkitperl/webkitdirs_unittest/extractNonMacOSHostConfiguration.pl:
• Scripts/webkitpy/common/config/ports.py:

(DeprecatedPort.port):
(GtkWK2Port.run_webkit_tests_command):
(EflWK2Port): Deleted.
(EflWK2Port.build_webkit_command): Deleted.

• Scripts/webkitpy/port/builders.py:
• Scripts/webkitpy/port/efl.py: Removed.
• Scripts/webkitpy/port/efl_unittest.py: Removed.
• Scripts/webkitpy/port/factory.py:

(platform_options):
(PortFactory):

• Scripts/webkitpy/style/checkers/test_expectations_unittest.py:

(TestExpectationsTestCase.test_determine_port_from_expectations_path):

• Scripts/webkitpy/tool/commands/rebaseline_unittest.py:

(TestRebaselineTest.test_baseline_directory):
(TestRebaselineExpectations.test_rebaseline_expectations):

• TestWebKitAPI/PlatformEfl.cmake: Removed.
• TestWebKitAPI/PlatformWebView.h:
• TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:

(TestWebKitAPI::TEST):

• TestWebKitAPI/Tests/WebKit2/efl/WKViewClientWebProcessCallbacks.cpp: Removed.
• TestWebKitAPI/Tests/WebKit2/efl/WKViewClientWebProcessCallbacks_Bundle.cpp: Removed.
• TestWebKitAPI/Tests/WebKit2/efl/WKViewScrollTo.cpp: Removed.
• TestWebKitAPI/Tests/WebKit2/efl/scrollTo.html: Removed.
• TestWebKitAPI/efl/InjectedBundleController.cpp: Removed.
• TestWebKitAPI/efl/PlatformUtilities.cpp: Removed.
• TestWebKitAPI/efl/PlatformWebView.cpp: Removed.
• TestWebKitAPI/efl/main.cpp: Removed.
• WebKitTestRunner/EventSenderProxy.h:
• WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
• WebKitTestRunner/InjectedBundle/AccessibilityController.h:
• WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
• WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
• WebKitTestRunner/InjectedBundle/EventSendingController.cpp:

(WTR::EventSendingController::contextClick):

• WebKitTestRunner/InjectedBundle/TestRunner.h:
• WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:

(WTR::AccessibilityNotificationHandler::setNotificationFunctionCallback):
(WTR::AccessibilityNotificationHandler::removeAccessibilityNotificationHandler):

• WebKitTestRunner/InjectedBundle/efl/ActivateFontsEfl.cpp: Removed.
• WebKitTestRunner/InjectedBundle/efl/FontManagement.cpp: Removed.
• WebKitTestRunner/InjectedBundle/efl/FontManagement.h: Removed.
• WebKitTestRunner/InjectedBundle/efl/InjectedBundleEfl.cpp: Removed.
• WebKitTestRunner/InjectedBundle/efl/TestRunnerEfl.cpp: Removed.
• WebKitTestRunner/PlatformEfl.cmake: Removed.
• WebKitTestRunner/PlatformWebView.h:
• WebKitTestRunner/TestController.cpp:

(WTR::TestController::resetStateToConsistentValues):

• WebKitTestRunner/efl/EventSenderProxyEfl.cpp: Removed.
• WebKitTestRunner/efl/PlatformWebViewEfl.cpp: Removed.
• WebKitTestRunner/efl/TestControllerEfl.cpp: Removed.
• WebKitTestRunner/efl/main.cpp: Removed.
• efl/install-dependencies: Removed.
• efl/jhbuild-optional.modules: Removed.
• efl/jhbuild.modules: Removed.
• efl/jhbuildrc: Removed.
• efl/patches/evas-fix-build-with-giflib5.patch: Removed.
• efl/patches/fontconfig-C-11-requires-a-space-between-literal-and-identifier.patch: Removed.
• efl/patches/gst-libav.patch: Removed.
• efl/patches/gst-plugins-base-rtp-rtcpbuffer-fix-typo-in-enum.patch: Removed.
• efl/patches/gst-plugins-good-Revert-qtdemux-expose-streams-with-first-moof-for-fr.patch: Removed.
• efl/patches/gst-plugins-good-use-the-tfdt-decode-time.patch: Removed.
• efl/patches/openwebrtc-gst-plugins-clang-warning-fix.patch: Removed.
• gtk/manifest.txt.in:

2:12 PM Changeset in webkit [215757] by Nikita Vasilyev

• 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Open the new bug page in the new tab
​https://bugs.webkit.org/show_bug.cgi?id=171253

Reviewed by Joseph Pecoraro.

• UserInterface/Debug/UncaughtExceptionReporter.js:

(createErrorSheet):

1:58 PM Changeset in webkit [215756] by mmaxfield@apple.com

• 5 edits
  2 adds in trunk

Supplementary Multilingual Plane Complex Scripts Rendered Incorrectly
​https://bugs.webkit.org/show_bug.cgi?id=171272
<rdar://problem/30966764>

Reviewed by Zalan Bujtas.

Source/WebCore:

These scripts need to take the complex text codepath.

Test: fast/text/kaithi.html

• platform/graphics/FontCascade.cpp:

(WebCore::FontCascade::characterRangeCodePath):

LayoutTests:

• fast/text/kaithi-expected.html: Added.
• fast/text/kaithi.html: Added.
• platform/ios/TestExpectations:
• platform/mac/TestExpectations:

1:38 PM Changeset in webkit [215755] by commit-queue@webkit.org

• 6 edits in trunk/Source/WebInspectorUI

Web Inspector: "Space" localized string is not loaded in combined and minified builds
​https://bugs.webkit.org/show_bug.cgi?id=171283
<rdar://problem/30871371>

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2017-04-25
Reviewed by Brian Burg.

In combined and minified builds, the document.write() to load the
localized strings script doesn't happen before the KeyboardShortcut
global code in Main.js evaluates, so there is no UIString because
window.localizedStrings hasn't populated yet. Since this is the only
instance, populate the display UIString lazily and provide warnings
in minified builds if this happens.

• UserInterface/Base/LoadLocalizedStrings.js:

(WebInspector.UIString):
Provide a warning if a UIString was attempted before the strings have loaded.

• UserInterface/Base/Main.js:

(WebInspector.loaded):
For this rare instance, populate the display name of the string when we are
sure strings have loaded.

• UserInterface/Models/KeyboardShortcut.js:

Revert the UIString here, but note that it will be populated later.

• UserInterface/Models/Resource.js:

(WebInspector.Resource.prototype.setCachedResponseBodySize):

• UserInterface/Views/DOMTreeElement.js:

(WebInspector.DOMTreeElement.prototype._statusImageContextmenu):
Address console.asserts not ending in semicolon warnings produced during
optimized builds. Without semicolons they are not stripped.

1:33 PM Changeset in webkit [215754] by clopez@igalia.com

• 2 edits in trunk/Source/WebCore

[GTK] Revert r215745 (especulative build fix) after r215752.
​https://bugs.webkit.org/show_bug.cgi?id=170842

Unreviewed.

• platform/graphics/harfbuzz/HarfBuzzShaper.cpp:

(WebCore::normalizeCharacters):

1:26 PM Changeset in webkit [215753] by dbates@webkit.org

• 35 edits
  1 copy
  1 add in trunk

[Cocoa][Win] Enable of X-Content-Type-Options: nosniff header
​https://bugs.webkit.org/show_bug.cgi?id=136452
<rdar://problem/23412620>

Reviewed by Brent Fulgham.

.:

Enable X-Content-Type-Options: nosniff on Mac, iOS and Windows platforms.

• Source/cmake/OptionsMac.cmake:
• Source/cmake/OptionsWin.cmake:

LayoutTests/imported/w3c:

Update expected results now we support X-Content-Type-Options: nosniff.

• web-platform-tests/fetch/nosniff/parsing-nosniff-expected.txt:
• web-platform-tests/fetch/nosniff/script-expected.txt:
• web-platform-tests/fetch/nosniff/stylesheet-expected.txt:

Source/JavaScriptCore:

Enable X-Content-Type-Options: nosniff on Mac, iOS and Windows platforms.

• Configurations/FeatureDefines.xcconfig:

Source/WebCore:

Enable support for X-Content-Type-Options: nosniff on Mac, iOS and Windows.

Additionally, honor X-Content-Type-Options: nosniff header for stylesheets as per
<​https://fetch.spec.whatwg.org/#should-response-to-request-be-blocked-due-to-nosniff%3F> (30 March 2017).

Test: http/tests/security/contentTypeOptions/nosniff-dynamic-script-blocked.html

• Configurations/FeatureDefines.xcconfig:
• css/StyleSheetContents.cpp:

(WebCore::StyleSheetContents::parseAuthorStyleSheet): Log an error if the stylesheet
has the nosniff header and does not have a valid MIME type. Also update code for
renaming of MIMETypeCheck to MIMETypeCheckHint.
(WebCore::StyleSheetContents::notifyLoadedSheet): If the stylesheet is blocked by
nosniff then consider it analogous to a load error so that we dispatch a DOM error
event at the <style>/<link> element.

• dom/LoadableClassicScript.cpp:

(WebCore::LoadableClassicScript::notifyFinished): Modified the wording of the error
message when a script is disallowed by nosniff so as to more closely match the
wording used when a stylesheet is disallowed by nonsniff.

• loader/cache/CachedCSSStyleSheet.cpp:

(WebCore::CachedCSSStyleSheet::sheetText): Update for renaming of MIMETypeCheck
to MIMETypeCheckHint.
(WebCore::CachedCSSStyleSheet::responseMIMEType): Added.
(WebCore::CachedCSSStyleSheet::mimeTypeAllowedByNosniff): Added.
(WebCore::CachedCSSStyleSheet::canUseSheet): Modified to check if the X-Content-Type-Options: nosniff
header is in the HTTP response for the stylesheet. If it is then we can only use the stylesheet
if its content-type is "text/css". Otherwise, apply the existing criterion for determining whether
to to use the stylesheet.

• loader/cache/CachedCSSStyleSheet.h: Rename MIMETypeCheck to MIMETypeCheckHint to better

describe its purpose as a hint as to whether to enforce MIME type checking for the stylesheet.
Processing of the HTTP header X-Content-Type-Options takes precedence over this hint.

• loader/cache/CachedScript.h: Make mimeType() private.

Source/WebCore/PAL:

Enable X-Content-Type-Options: nosniff on Mac, iOS and Windows platforms.

• Configurations/FeatureDefines.xcconfig:

Source/WebKit/mac:

Enable X-Content-Type-Options: nosniff on Mac, iOS and Windows platforms.

• Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

Enable X-Content-Type-Options: nosniff on Mac, iOS and Windows platforms.

• Configurations/FeatureDefines.xcconfig:

Tools:

Enable X-Content-Type-Options: nosniff on Mac, iOS and Windows platforms.

• Scripts/webkitperl/FeatureList.pm: Also do not enable nosniff on EFL

as the EFL port is no longer in the WebKit OpenSource repository.

• TestWebKitAPI/Configurations/FeatureDefines.xcconfig:

LayoutTests:

Unskip nosniff tests on Mac, iOS and Windows and update expected results now that
we support X-Content-Type-Options: nosniff.

Merge Blink test from <​https://src.chromium.org/viewvc/blink?revision=168570&view=revision>.

• TestExpectations: Unskip all nosniff tests except imported/w3c/web-platform-tests/fetch/nosniff/importscripts.html.

We need to fix <​https://bugs.webkit.org/show_bug.cgi?id=171248> before we can unskip it.
When running the nosniff Web Platform Tests (WPT) dump console messages to standard error
to avoid a difference of console message ordering due to the non-determinism of the WPT
tests from affecting the matching of the expected result.

• http/tests/security/contentTypeOptions/nosniff-dynamic-script-blocked-expected.txt: Added.
• http/tests/security/contentTypeOptions/nosniff-dynamic-script-blocked.html: Copied from LayoutTests/http/tests/security/contentTypeOptions/nosniff-script-blocked.html.
• http/tests/security/contentTypeOptions/nosniff-script-blocked-expected.txt: Update expected result.
• http/tests/security/contentTypeOptions/nosniff-script-blocked.html: Substitute the not executable

MIME type "text/xx-javascript" for "text/x-javascript" as the latter is an acceptable MIME type for
JavaScript scripts as per the Fetch standard, <​https://html.spec.whatwg.org/multipage/scripting.html#javascript-mime-type> (30 March 2017).

• http/tests/security/contentTypeOptions/nosniff-script-without-content-type-blocked-expected.txt: Update

expected result.

• platform/gtk/TestExpectations: Skip the nosniff tests as GTK does not enable ENABLE(NOSNIFF).
• platform/ios/TestExpectations: Unskip nosniff tests.
• platform/mac/TestExpectations: Ditto.
• platform/win/TestExpectations: Ditto.
• platform/wk2/TestExpectations: Ditto.

1:22 PM Changeset in webkit [215752] by mmaxfield@apple.com

• 2 edits in trunk/Source/WebCore

[GTK] Build fix after r215737
​https://bugs.webkit.org/show_bug.cgi?id=170842

Unreviewed.

No new tests because there is no behavior change.

• platform/graphics/FontCascade.h:

(WebCore::FontCascade::treatAsZeroWidthSpace):
(WebCore::FontCascade::treatAsZeroWidthSpaceInComplexScript):

12:37 PM Changeset in webkit [215751] by Wenson Hsieh

• 2 edits in trunk/Source/WebCore

Remove an unnecessary -respondsToSelector: check after r215724

Rubber-stamped by Tim Horton.

Addresses review feedback from <​https://bugs.webkit.org/show_bug.cgi?id=171156>. -[NSURL _title]
will always for builds that need to access it.

• platform/ios/PlatformPasteboardIOS.mm:

(WebCore::PlatformPasteboard::readURL):

12:20 PM Changeset in webkit [215750] by Antti Koivisto

• 3 edits in trunk/Source/WebCore

REGRESSION (r215469): [ios-simulator-wk2] LayoutTest compositing/animation/animation-backing.html is a flaky failure
​https://bugs.webkit.org/show_bug.cgi?id=171060
<rdar://problem/31771174>

Reviewed by Simon Fraser.

Accelerated transform animations move underlying layers without invalidating GraphicsLayers.
To update tile coverage we need to commit such subtrees even if there are not other changes.

• platform/graphics/ca/GraphicsLayerCA.cpp:

(WebCore::GraphicsLayerCA::GraphicsLayerCA):
(WebCore::GraphicsLayerCA::needsCommit):

Commit subtrees with accelerated transform animations.
Factor into a function.

(WebCore::GraphicsLayerCA::recursiveCommitChanges):

Track if descendants had any accelerated transform animations after commit.

• platform/graphics/ca/GraphicsLayerCA.h:

(WebCore::GraphicsLayerCA::hasDescendantsWithRunningTransformAnimations):
(WebCore::GraphicsLayerCA::setHasDescendantsWithRunningTransformAnimations):

12:15 PM Changeset in webkit [215749] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebInspectorUI

Web Inspector: TypeError:​ sourceCodeLocation.populateLiveDisplayLocationTooltip is not a function
​https://bugs.webkit.org/show_bug.cgi?id=171259

Patch by Fujii Hironori <Fujii Hironori> on 2017-04-25
Reviewed by Joseph Pecoraro.

The first argument of WebInspector.createSourceCodeLocationLink
should be SourceCodeLocation type.

• UserInterface/Views/TimelineDataGridNode.js:

(WebInspector.TimelineDataGridNode.prototype.createCellContent):
Pass 'callFrame.sourceCodeLocation' instead of 'value' to the
first argument.

12:04 PM Changeset in webkit [215748] by mark.lam@apple.com

• 6 edits
  1 add in trunk

Local CSE wrongly CSEs array accesses with different result types.
​https://bugs.webkit.org/show_bug.cgi?id=170990
<rdar://problem/31705945>

Reviewed by Saam Barati.

JSTests:

• stress/regress-170990.js: Added.

Source/JavaScriptCore:

The fix is to use different LocationKind enums for the different type of array
result types. This makes the HeapLocation values different based on the result
types, and allows CSE to discern between them.

• dfg/DFGCSEPhase.cpp:
• dfg/DFGClobberize.h:

(JSC::DFG::clobberize):

• dfg/DFGHeapLocation.cpp:

(WTF::printInternal):

• dfg/DFGHeapLocation.h:

(JSC::DFG::indexedPropertyLocForResultType):

11:42 AM Changeset in webkit [215747] by mark.lam@apple.com

• 3 edits in trunk/Source/JavaScriptCore

Make DFG SpeculatedType dumps easier to read.
​https://bugs.webkit.org/show_bug.cgi?id=171280

Reviewed by Saam Barati.

Adding a pretty printer to insert |s between each type string and changing the
dumped strings to match the SpeculatedType names case-wise.

• bytecode/SpeculatedType.cpp:

(JSC::PrettyPrinter::PrettyPrinter):
(JSC::PrettyPrinter::print):
(JSC::dumpSpeculation):

• bytecode/SpeculatedType.h:

11:22 AM Changeset in webkit [215746] by eric.carlson@apple.com

• 2 edits in trunk/Source/WebCore

[MediaStream macOS] Unable to apply frameRate constraint
​https://bugs.webkit.org/show_bug.cgi?id=171279

Reviewed by Youenn Fablet.

No new tests, this doesn't affect the mock capture devices.

• platform/mediastream/mac/AVVideoCaptureSource.mm:

(WebCore::AVVideoCaptureSource::supportsSizeAndFrameRate): Cast frame rate
ranges to int before comparing.

11:21 AM Changeset in webkit [215745] by clopez@igalia.com

• 2 edits in trunk/Source/WebCore

[GTK] Build fix after r215737
​https://bugs.webkit.org/show_bug.cgi?id=170842

Unreviewed.

• platform/graphics/harfbuzz/HarfBuzzShaper.cpp:

(WebCore::normalizeCharacters):

10:44 AM Changeset in webkit [215744] by zandobersek@gmail.com

• 2 edits in trunk/Tools

Unreviewed follow-up to r215739 and r215740.

• gtk/jhbuild.modules: List the libgcrypt patch that has to be applied.

This (and r215740) was supposed to land in r215739, but I managed to
specify the previous version of the patch.

10:36 AM Changeset in webkit [215743] by jfbastien@apple.com

• 2 edits in trunk/Source/JavaScriptCore

lowerStackArgs: check Arg::addr.isValidForm when falling back to SP offsets
​https://bugs.webkit.org/show_bug.cgi?id=171278

Reviewed by Filip Pizlo.

lowerStackArgs checked that the FP offsets it tries to generate
are valid form, but didn't check that the fallback was valid
form. This lead to stackAddr's assertion being dead, and the
MaroAssembler asserting way later on move / add when handed a huge
immediate.

• b3/air/AirArg.cpp:

(JSC::B3::Air::Arg::stackAddrImpl):

10:14 AM Changeset in webkit [215742] by matthew_hanson@apple.com

• 1 copy in tags/Safari-603.2.5

Tag Safari-603.2.5.

10:05 AM Changeset in webkit [215741] by wilander@apple.com

• 19 edits in trunk/Source

Resource Load Statistics: Clear network process cache when clearing store
​https://bugs.webkit.org/show_bug.cgi?id=171256
<rdar://problem/31802347>

Reviewed by Brent Fulgham.

Source/WebCore:

Test that covers this code:
http/tests/loading/resourceLoadStatistics/clear-in-memory-and-persistent-store.html

• loader/ResourceLoadObserver.cpp:

(WebCore::ResourceLoadObserver::clearInMemoryStore):

Better name.

(WebCore::ResourceLoadObserver::logUserInteraction):

Now passes on the boolean parameter clearFirst to
ResourceLoadStatisticsStore::fireShouldPartitionCookiesHandler().

(WebCore::ResourceLoadObserver::fireShouldPartitionCookiesHandler):

Now takes and passes on the boolean parameter clearFirst to
ResourceLoadStatisticsStore::fireShouldPartitionCookiesHandler().

(WebCore::ResourceLoadObserver::statisticsStore): Deleted.

This getter violated abstraction. The way it was used
is now solved through dedicated functions.

• loader/ResourceLoadObserver.h:
• loader/ResourceLoadStatisticsStore.cpp:

(WebCore::ResourceLoadStatisticsStore::readDataFromDecoder):

Now passes on the boolean parameter clearFirst to
ResourceLoadStatisticsStore::fireShouldPartitionCookiesHandler().

(WebCore::ResourceLoadStatisticsStore::clearInMemory):

Better name.
Now triggers clearing of the associated network process cache.

(WebCore::ResourceLoadStatisticsStore::clearInMemoryAndPersistent):

Now calls clearInMemory().

(WebCore::ResourceLoadStatisticsStore::setShouldPartitionCookiesCallback):

Now expects a handler with the boolean parameter clearFirst.

(WebCore::ResourceLoadStatisticsStore::fireShouldPartitionCookiesHandler):

Now takes and passes on the boolean parameter clearFirst to
m_shouldPartitionCookiesForDomainsHandler().

• loader/ResourceLoadStatisticsStore.h:

(WebCore::ResourceLoadStatisticsStore::clear): Deleted.

• platform/network/NetworkStorageSession.h:

NetworkStorageSession::setShouldPartitionCookiesForHosts() now
takes the boolean parameter clearFirst.

• platform/network/cf/NetworkStorageSessionCFNet.cpp:

(WebCore::NetworkStorageSession::setShouldPartitionCookiesForHosts):

Now clears m_topPrivatelyControlledDomainsForCookiePartitioning
if the boolean parameter clearFirst is true.

Source/WebKit2:

• NetworkProcess/NetworkProcess.cpp:

(WebKit::NetworkProcess::shouldPartitionCookiesForTopPrivatelyOwnedDomains):

Now takes and passes on the boolean parameter clearFirst to
WebCore::NetworkStorageSession::setShouldPartitionCookiesForHosts().

• NetworkProcess/NetworkProcess.h:
• NetworkProcess/NetworkProcess.messages.in:

The message ShouldPartitionCookiesForTopPrivatelyOwnedDomains now
takes the boolean parameter clearFirst.

• UIProcess/Network/NetworkProcessProxy.cpp:

(WebKit::NetworkProcessProxy::shouldPartitionCookiesForTopPrivatelyOwnedDomains):

Now takes and passes on the boolean parameter clearFirst to
Messages::NetworkProcess::ShouldPartitionCookiesForTopPrivatelyOwnedDomains.

• UIProcess/Network/NetworkProcessProxy.h:
• UIProcess/Network/NetworkProcessProxy.messages.in:

The message ShouldPartitionCookiesForTopPrivatelyOwnedDomains now
takes the boolean parameter clearFirst.

• UIProcess/WebResourceLoadStatisticsManager.cpp:

(WebKit::WebResourceLoadStatisticsManager::fireShouldPartitionCookiesHandler):

Now uses the boolean parameter clearFirst when calling
WebCore::ResourceLoadObserver::fireShouldPartitionCookiesHandler().

(WebKit::WebResourceLoadStatisticsManager::clearInMemoryAndPersistentStore):

No longer uses the deleted store getter.

(WebKit::WebResourceLoadStatisticsManager::resetToConsistentState):

No longer uses the deleted store getter.

• UIProcess/WebResourceLoadStatisticsStore.cpp:

(WebKit::WebResourceLoadStatisticsStore::resourceLoadStatisticsUpdated):

No sends the boolean parameter clearFirst to
ResourceLoadStatisticsStore::fireShouldPartitionCookiesHandler().

(WebKit::WebResourceLoadStatisticsStore::registerSharedResourceLoadObserver):

Now expects a handler with the boolean parameter clearFirst.

(WebKit::WebResourceLoadStatisticsStore::readDataFromDiskIfNeeded):

• UIProcess/WebResourceLoadStatisticsStore.h:

Now uses the new WebCore::ResourceLoadObserver::clearInMemoryStore().

• UIProcess/WebsiteData/WebsiteDataStore.cpp:

(WebKit::WebsiteDataStore::shouldPartitionCookiesForTopPrivatelyOwnedDomains):

Now takes and passes on the boolean parameter clearFirst in its
message to the network process.

(WebKit::WebsiteDataStore::registerSharedResourceLoadObserver):

Now expects a handler with the boolean parameter clearFirst.

• UIProcess/WebsiteData/WebsiteDataStore.h:

10:01 AM Changeset in webkit [215740] by zandobersek@gmail.com

• 1 edit
  1 add in trunk/Tools

Unreviewed follow-up to r215739.

• gtk/patches/libgcrypt-use-only-dev-urandom-for-testing.patch: Add the missing

libgcrypt patch that enforces the use of /dev/urandom.

9:45 AM Changeset in webkit [215739] by zandobersek@gmail.com

• 2 edits in trunk/Tools

[GTK] Add libgpg-error, libgcrypt libraries to JHBuild
​https://bugs.webkit.org/show_bug.cgi?id=171270

Reviewed by Michael Catanzaro.

• gtk/jhbuild.modules: Add the latest stable versions of libgpg-error and libgcrypt

libraries to the webkitgtk-testing-dependencies metamodule. This will help people
that use systems that don't yet provide libgcrypt >= 1.7.0.

9:36 AM Changeset in webkit [215738] by Ryan Haddad

• 2 edits in trunk/LayoutTests

Mark http/tests/inspector/network/resource-sizes-disk-cache.html as flaky.
​https://bugs.webkit.org/show_bug.cgi?id=170971

Unreviewed test gardening.

• platform/mac-wk2/TestExpectations:

9:35 AM Changeset in webkit [215737] by mmaxfield@apple.com

• 6 edits
  1 add in trunk

Add performance test for FontCache::systemFallbackForCharacters()
​https://bugs.webkit.org/show_bug.cgi?id=170842

Reviewed by Tim Horton.

PerformanceTests:

• Layout/word-joiner.html: Added.

Source/WebCore:

No new tests because there is no behavior change.

• platform/graphics/FontCascade.h:

(WebCore::FontCascade::treatAsZeroWidthSpace):
(WebCore::FontCascade::treatAsZeroWidthSpaceInComplexScript): Deleted.

• platform/graphics/WidthCache.h:

(WebCore::WidthCache::add):
(WebCore::WidthCache::addSlowCase):

Source/WTF:

• wtf/unicode/CharacterNames.h:

9:29 AM Changeset in webkit [215736] by Chris Dumez

• 11 edits
  3 adds in trunk

Content-Disposition header filename is ignored when 'download' attribute is specified in HTML
​https://bugs.webkit.org/show_bug.cgi?id=171239
<rdar://problem/31789855>

Reviewed by Alex Christensen.

Source/WebCore:

Add isAttachmentWithFilename() utility method to ResourceResponse to implement:

• ​https://html.spec.whatwg.org/#as-a-download (Step 2)

Test: http/tests/download/anchor-download-attribute-content-disposition.html

• platform/network/ResourceResponseBase.cpp:

(WebCore::ResourceResponseBase::isAttachmentWithFilename):

• platform/network/ResourceResponseBase.h:

Source/WebKit2:

Content-Disposition header filename is ignored when 'download' attribute is specified in HTML.
This is not as per HTML specification:

• ​https://html.spec.whatwg.org/#as-a-download (Step 2)

Content-Disposition header filename is supposed to override the value of the download attribute.

Firefox and Chrome follow the specification.

• NetworkProcess/NetworkProcess.cpp:

(WebKit::NetworkProcess::findPendingDownloadLocation):

• UIProcess/Downloads/DownloadProxy.cpp:

(WebKit::DownloadProxy::didReceiveResponse):

LayoutTests:

• http/tests/security/anchor-download-allow-sameorigin.html:

Stop using attachment.php as resource for this download attribute test because attachment.php
returns a Content-Disposition header with a filename. Given the behavior change in this patch,
this resource is no longer suitable for testing the download attribute.

• http/tests/download/anchor-download-attribute-content-disposition-expected.txt: Added.
• http/tests/download/anchor-download-attribute-content-disposition.html: Added.
• http/tests/download/resources/content-disposition-pass.php: Added.

Add layout test coverage.

• platform/ios-wk2/TestExpectations:
• platform/mac-wk1/TestExpectations:
• platform/win/TestExpectations:

Skip new test on platforms where the download attribute is not supported.

9:10 AM Changeset in webkit [215735] by clopez@igalia.com

• 2 edits in trunk/Tools

[GTK] Improve an unit test for the JHBuild wrapper.
​https://bugs.webkit.org/show_bug.cgi?id=168036

Unreviewed follow-up patch after r215727

• Scripts/webkitpy/port/base_unittest.py:

(test_jhbuild_wrapper): Improve the unit test by ensuring the directory
wasn't there before calling MockFileSystem.maybe_make_directory(), and
also that it exists after calling it.

9:03 AM Changeset in webkit [215734] by Ryan Haddad

• 1 edit
  3 adds in trunk/LayoutTests

Rebaseline fast/canvas/canvas-crash.html for ios-simulator.
​https://bugs.webkit.org/show_bug.cgi?id=171238

Unreviewed test gardening.

• platform/ios-simulator/fast/canvas/canvas-crash-expected.txt: Added.

8:36 AM Changeset in webkit [215733] by Yusuke Suzuki

• 2 edits in trunk/JSTests

WebAssembly: exporting a property with a name that's a number doesn't work
​https://bugs.webkit.org/show_bug.cgi?id=168857

Reviewed by JF Bastien.

r213453 allows Wasm instances to expose indexed properties. We activate the tests.

• wasm/js-api/test_Instance.js:

(ExportedNumber):

8:24 AM Changeset in webkit [215732] by Carlos Garcia Campos

• 6 edits
  2 adds in trunk/Source

[GTK] Add WebKitInspectorWindow to create inspector windows from local and remote inspector
​https://bugs.webkit.org/show_bug.cgi?id=171261

Reviewed by Michael Catanzaro.

Source/WebCore/platform/gtk/po:

Remove WebInspectorProxyGtk.cpp and RemoteWebInspectorProxyGtk.cpp from POTFILES.in and add WebKitInspectorWindow.cpp.

• POTFILES.in:

Source/WebKit2:

The code is currently duplicated in WebInspectorProxyGtk.cpp and RemoteWebInspectorProxyGtk.cpp. We can simplify
it by using a common widget in both places.
This patch also fixes the build when using GTK+ < 3.16.

• PlatformGTK.cmake:
• UIProcess/gtk/RemoteWebInspectorProxyGtk.cpp:

(WebKit::RemoteWebInspectorProxy::updateWindowTitle):
(WebKit::RemoteWebInspectorProxy::platformCreateFrontendPageAndWindow):

• UIProcess/gtk/WebInspectorProxyGtk.cpp:

(WebKit::WebInspectorProxy::createInspectorWindow):
(WebKit::WebInspectorProxy::updateInspectorWindowTitle):

• UIProcess/gtk/WebKitInspectorWindow.cpp: Added.

(webkit_inspector_window_class_init):
(webkit_inspector_window_init):
(webkitInspectorWindowNew):
(webkitInspectorWindowSetSubtitle):

• UIProcess/gtk/WebKitInspectorWindow.h: Added.

7:15 AM Changeset in webkit [215731] by zandobersek@gmail.com

• 2 edits in trunk/Source/JavaScriptCore

[aarch64] moveConditionally32(), moveConditionallyTest32() should move from/to 64-bit registers
​https://bugs.webkit.org/show_bug.cgi?id=170891

Reviewed by Saam Barati.

moveConditionally32() and moveConditionallyTest32() operations in
MacroAssemblerARM64 properly perform comparisons and tests on 32-bit
values, but end up performing the moves from and to 32-bit registers.

Move operations should instead be done on 64-bit registers, just like
on the X86_64 platform. This is achieved by specifying 64 as the data
size for the csel instructions.

• assembler/MacroAssemblerARM64.h:

(JSC::MacroAssemblerARM64::moveConditionally32):
(JSC::MacroAssemblerARM64::moveConditionallyTest32):

7:14 AM Changeset in webkit [215730] by Antti Koivisto

• 8 edits in trunk

Enable expired-only reload policy on Mac and iOS
​https://bugs.webkit.org/show_bug.cgi?id=171264
<rdar://problem/31807637>

Reviewed by Andreas Kling.

Source/WebCore:

• loader/NavigationAction.cpp:

(WebCore::navigationType):

Test for reload navigation type correctly.

Source/WebKit2:

Enable the reload policy where only expired subresources are revalidated on Mac and iOS.
The behavor is enabled in Safari and for other clients based on SDK version check.

• UIProcess/API/C/WKPage.cpp:

(WKPageReload):

• UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView reload]):

• UIProcess/Cocoa/VersionChecks.h:

LayoutTests:

• fast/loader/display-image-unset-can-block-image-and-can-reload-in-place.html:

WebKitDisplayImages preference blocks loads, it does not prevent images already in memory cache from displaying.
Modify the test to clear the memory cache so it still tests what it is supposed to.

5:35 AM Changeset in webkit [215729] by magomez@igalia.com

• 9 edits in trunk/Source/WebCore

Image decoders must have private constructors to avoid refcount misuse: ASSERTION FAILED: m_deletionHasBegun when destroying ImageDecoder
​https://bugs.webkit.org/show_bug.cgi?id=171211

Reviewed by Carlos Garcia Campos.

Add a create method to each of the decoders and set their constructors as private. Change
ICOImageDecoder to store its internal PNG decoders as RefPtr and use the new create method, and
change ImageDecoder to use the create methods as well.

Covered by existent tests.

• platform/image-decoders/ImageDecoder.cpp:

(WebCore::ImageDecoder::create):

• platform/image-decoders/bmp/BMPImageDecoder.h:
• platform/image-decoders/gif/GIFImageDecoder.h:
• platform/image-decoders/ico/ICOImageDecoder.cpp:

(WebCore::ICOImageDecoder::decodeAtIndex):

• platform/image-decoders/ico/ICOImageDecoder.h:
• platform/image-decoders/jpeg/JPEGImageDecoder.h:
• platform/image-decoders/png/PNGImageDecoder.h:
• platform/image-decoders/webp/WEBPImageDecoder.h:

5:16 AM Changeset in webkit [215728] by mmaxfield@apple.com

• 2 edits in trunk/Source/WebCore

Build fix

Unreviewed.

No new tests because there is no behavior change.

• crypto/mac/SerializedCryptoKeyWrapMac.mm:

(WebCore::wrapSerializedCryptoKey):
(WebCore::unwrapSerializedCryptoKey):

3:48 AM Changeset in webkit [215727] by clopez@igalia.com

• 5 edits
  1 delete in trunk/Tools

[GTK] ImageDiff should be run by jhbuild-wrapper in case of using jhbuild
​https://bugs.webkit.org/show_bug.cgi?id=168036

Reviewed by Michael Catanzaro.

Call ImageDiff with the JHBuild wrapper if we should use it.
Also add some unit tests for the JHBuild wrapper feature.

• Scripts/webkitpy/port/base.py:

(Port._should_use_jhbuild): Use self._filesystem instead of os.path to allow mock testing.

• Scripts/webkitpy/port/base_unittest.py:

(test_jhbuild_wrapper): Add a test for port._should_use_jhbuild()

• Scripts/webkitpy/port/image_diff.py:

(ImageDiffer._start): The actual fix, use the wrapper if we should.

• Scripts/webkitpy/port/image_diff_unittest.py: Removed. This two tests are now integrated in port_testcase
• Scripts/webkitpy/port/port_testcase.py:

(PortTestCase):
(PortTestCase.test_diff_image): Test the command with wrapper and without it.
(PortTestCase.test_diff_image_passed): Moved from image_diff_unittest.py
(PortTestCase.test_diff_image_failed): Moved from image_diff_unittest.py

1:46 AM Changeset in webkit [215726] by fred.wang@free.fr

• 5 edits
  123 adds in trunk/LayoutTests

Import W3C tests for the CSSOM View module
​https://bugs.webkit.org/show_bug.cgi?id=171215

Patch by Frederic Wang <​fwang@igalia.com> on 2017-04-25
Reviewed by Youenn Fablet.

LayoutTests/imported/w3c:

This patch imports "cssom-view" test suite from WPT repo:
​https://github.com/w3c/web-platform-tests/tree/master/cssom-view

• resources/import-expectations.json:
• resources/resource-files.json:
• web-platform-tests/cssom-view/CaretPosition-001-expected.txt: Added.
• web-platform-tests/cssom-view/CaretPosition-001.html: Added.
• web-platform-tests/cssom-view/HTMLBody-ScrollArea_quirksmode-expected.txt: Added.
• web-platform-tests/cssom-view/HTMLBody-ScrollArea_quirksmode.html: Added.
• web-platform-tests/cssom-view/MediaQueryList-001-expected.txt: Added.
• web-platform-tests/cssom-view/MediaQueryList-001.html: Added.
• web-platform-tests/cssom-view/MediaQueryList-with-empty-string-expected.txt: Added.
• web-platform-tests/cssom-view/MediaQueryList-with-empty-string.html: Added.
• web-platform-tests/cssom-view/OWNERS: Added.
• web-platform-tests/cssom-view/Screen-pixelDepth-Screen-colorDepth001-expected.txt: Added.
• web-platform-tests/cssom-view/Screen-pixelDepth-Screen-colorDepth001.html: Added.
• web-platform-tests/cssom-view/cssom-getBoundingClientRect-001-expected.txt: Added.
• web-platform-tests/cssom-view/cssom-getBoundingClientRect-001.html: Added.
• web-platform-tests/cssom-view/cssom-getBoundingClientRect-002.html: Added.
• web-platform-tests/cssom-view/cssom-getClientRects-expected.txt: Added.
• web-platform-tests/cssom-view/cssom-getClientRects.html: Added.
• web-platform-tests/cssom-view/cssom-view-img-attributes-001-expected.txt: Added.
• web-platform-tests/cssom-view/cssom-view-img-attributes-001.html: Added.
• web-platform-tests/cssom-view/cssom-view-window-screen-interface-expected.txt: Added.
• web-platform-tests/cssom-view/cssom-view-window-screen-interface.html: Added.
• web-platform-tests/cssom-view/cssom-view/media-query-list-interface.xht: Added.
• web-platform-tests/cssom-view/cssom-view/w3c-import.log: Added.
• web-platform-tests/cssom-view/cssom-view/window-interface-expected.txt: Added.
• web-platform-tests/cssom-view/cssom-view/window-interface.xht: Added.
• web-platform-tests/cssom-view/elementFromPoint-001-expected.txt: Added.
• web-platform-tests/cssom-view/elementFromPoint-001.html: Added.
• web-platform-tests/cssom-view/elementFromPoint-expected.txt: Added.
• web-platform-tests/cssom-view/elementFromPoint.html: Added.
• web-platform-tests/cssom-view/elementFromPosition-expected.txt: Added.
• web-platform-tests/cssom-view/elementFromPosition.html: Added.
• web-platform-tests/cssom-view/elementScroll-expected.txt: Added.
• web-platform-tests/cssom-view/elementScroll.html: Added.
• web-platform-tests/cssom-view/elementsFromPoint.html: Added.
• web-platform-tests/cssom-view/historical-expected.txt: Added.
• web-platform-tests/cssom-view/historical.html: Added.
• web-platform-tests/cssom-view/htmlelement-offset-width-001-expected.txt: Added.
• web-platform-tests/cssom-view/htmlelement-offset-width-001.html: Added.
• web-platform-tests/cssom-view/iframe.html: Added.
• web-platform-tests/cssom-view/matchMedia-expected.txt: Added.
• web-platform-tests/cssom-view/matchMedia.xht: Added.
• web-platform-tests/cssom-view/matchMediaAddListener-expected.txt: Added.
• web-platform-tests/cssom-view/matchMediaAddListener.html: Added.
• web-platform-tests/cssom-view/mouseEvent-expected.txt: Added.
• web-platform-tests/cssom-view/mouseEvent.html: Added.
• web-platform-tests/cssom-view/negativeMargins-expected.txt: Added.
• web-platform-tests/cssom-view/negativeMargins.html: Added.
• web-platform-tests/cssom-view/offsetParent_element_test-expected.txt: Added.
• web-platform-tests/cssom-view/offsetParent_element_test.html: Added.
• web-platform-tests/cssom-view/scrollWidthHeight-expected.txt: Added.
• web-platform-tests/cssom-view/scrollWidthHeight.xht: Added.
• web-platform-tests/cssom-view/scrollWidthHeightWhenNotScrollable-expected.txt: Added.
• web-platform-tests/cssom-view/scrollWidthHeightWhenNotScrollable.xht: Added.
• web-platform-tests/cssom-view/scrolling-no-browsing-context-expected.txt: Added.
• web-platform-tests/cssom-view/scrolling-no-browsing-context.html: Added.
• web-platform-tests/cssom-view/scrolling-quirks-vs-nonquirks-expected.txt: Added.
• web-platform-tests/cssom-view/scrolling-quirks-vs-nonquirks.html: Added.
• web-platform-tests/cssom-view/scrollingElement.html: Added.
• web-platform-tests/cssom-view/support/1x1-green.png: Added.
• web-platform-tests/cssom-view/support/1x1-lime.png: Added.
• web-platform-tests/cssom-view/support/1x1-maroon.png: Added.
• web-platform-tests/cssom-view/support/1x1-navy.png: Added.
• web-platform-tests/cssom-view/support/1x1-red.png: Added.
• web-platform-tests/cssom-view/support/1x1-white.png: Added.
• web-platform-tests/cssom-view/support/60x60-gg-rr.png: Added.
• web-platform-tests/cssom-view/support/60x60-green.png: Added.
• web-platform-tests/cssom-view/support/60x60-red.png: Added.
• web-platform-tests/cssom-view/support/README: Added.
• web-platform-tests/cssom-view/support/a-green.css: Added.

(.a):

• web-platform-tests/cssom-view/support/b-green.css: Added.

(.b):

• web-platform-tests/cssom-view/support/c-red.css: Added.

(.c):

• web-platform-tests/cssom-view/support/cat.png: Added.
• web-platform-tests/cssom-view/support/import-green.css: Added.

(.import):

• web-platform-tests/cssom-view/support/import-red.css: Added.

(.import):

• web-platform-tests/cssom-view/support/pattern-grg-rgr-grg.png: Added.
• web-platform-tests/cssom-view/support/pattern-grg-rrg-rgg.png: Added.
• web-platform-tests/cssom-view/support/pattern-rgr-grg-rgr.png: Added.
• web-platform-tests/cssom-view/support/pattern-tr.png: Added.
• web-platform-tests/cssom-view/support/ruler-h-50%.png: Added.
• web-platform-tests/cssom-view/support/ruler-h-50px.png: Added.
• web-platform-tests/cssom-view/support/ruler-v-100px.png: Added.
• web-platform-tests/cssom-view/support/ruler-v-50px.png: Added.
• web-platform-tests/cssom-view/support/square-purple.png: Added.
• web-platform-tests/cssom-view/support/square-teal.png: Added.
• web-platform-tests/cssom-view/support/square-white.png: Added.
• web-platform-tests/cssom-view/support/support/README: Added.
• web-platform-tests/cssom-view/support/support/swatch-green.png: Added.
• web-platform-tests/cssom-view/support/support/swatch-red.png: Added.
• web-platform-tests/cssom-view/support/support/w3c-import.log: Added.
• web-platform-tests/cssom-view/support/swatch-blue.png: Added.
• web-platform-tests/cssom-view/support/swatch-green.png: Added.
• web-platform-tests/cssom-view/support/swatch-lime.png: Added.
• web-platform-tests/cssom-view/support/swatch-orange.png: Added.
• web-platform-tests/cssom-view/support/swatch-red.png: Added.
• web-platform-tests/cssom-view/support/swatch-teal.png: Added.
• web-platform-tests/cssom-view/support/swatch-white.png: Added.
• web-platform-tests/cssom-view/support/swatch-yellow.png: Added.
• web-platform-tests/cssom-view/support/test-bl.png: Added.
• web-platform-tests/cssom-view/support/test-br.png: Added.
• web-platform-tests/cssom-view/support/test-inner-half-size.png: Added.
• web-platform-tests/cssom-view/support/test-outer.png: Added.
• web-platform-tests/cssom-view/support/test-tl.png: Added.
• web-platform-tests/cssom-view/support/test-tr.png: Added.
• web-platform-tests/cssom-view/support/w3c-import.log: Added.
• web-platform-tests/cssom-view/ttwf-js-cssomview-getclientrects-length-expected.txt: Added.
• web-platform-tests/cssom-view/ttwf-js-cssomview-getclientrects-length.html: Added.
• web-platform-tests/cssom-view/ttwf-scrollintoview-expected.txt: Added.
• web-platform-tests/cssom-view/ttwf-scrollintoview.html: Added.
• web-platform-tests/cssom-view/w3c-import.log: Added.
• web-platform-tests/cssom-view/window-screen-height-expected.txt: Added.
• web-platform-tests/cssom-view/window-screen-height-immutable-expected.txt: Added.
• web-platform-tests/cssom-view/window-screen-height-immutable.html: Added.
• web-platform-tests/cssom-view/window-screen-height.html: Added.
• web-platform-tests/cssom-view/window-screen-width-expected.txt: Added.
• web-platform-tests/cssom-view/window-screen-width-immutable-expected.txt: Added.
• web-platform-tests/cssom-view/window-screen-width-immutable.html: Added.
• web-platform-tests/cssom-view/window-screen-width.html: Added.

LayoutTests:

• TestExpectations: Skip some completely failing CSSOM View tests.
• platform/ios-simulator/imported/w3c/web-platform-tests/cssom-view/Screen-pixelDepth-Screen-colorDepth001-actual.txt: Added. Add an expectation for iOS simulator, differing from other platform.
• platform/ios-simulator/imported/w3c/web-platform-tests/cssom-view/scrolling-quirks-vs-nonquirks-expected.txt: Added. Ditto.

12:41 AM Changeset in webkit [215725] by commit-queue@webkit.org

• 1 edit
  1 add in trunk/Source/WebCore/platform/gtk/po

[GTK] Add po/Makevars
​https://bugs.webkit.org/show_bug.cgi?id=170012

Patch by Piotr Drąg <​piotrdrag@gmail.com> on 2017-04-25
Reviewed by Carlos Garcia Campos.

• Makevars: Added so we can switch ​https://l10n.gnome.org/module/webkit/ from intltool to pure gettext and get WEB_UI_STRING* strings extracted.

12:00 AM Changeset in webkit [215724] by Wenson Hsieh

• 24 edits in trunk

Support reading NSURL titles from the pasteboard when performing data interaction
​https://bugs.webkit.org/show_bug.cgi?id=171156
<rdar://problem/31356937>

Reviewed by Tim Horton.

Source/WebCore:

Support reading link titles from the pasteboard when performing data interaction. To do this, we refactor
Pasteboard::readURL to take in an additional String& title which is ultimately plumbed to the PlatformPasteboard
where it is set to the value of -[NSURL _title].

Test: DataInteractionTests.ExternalSourceTitledNSURL.

• editing/FrameSelection.h:
• editing/ios/EditorIOS.mm:

(WebCore::Editor::WebContentReader::readURL):

• page/DragController.cpp:

(WebCore::DragController::performDragOperation):
(WebCore::DragController::concludeEditDrag):

Move calls to clearDragCaret() out of concludeEditDrag and into the call site, in performDragOperation after
attempting to concludeEditDrag. This is done so that if the WebEditorClient queries whether the drag caret is
in richly editable content for the purposes of generating a document fragment to insert, the answer will not
always be false as a drop is occurring.

• platform/PasteboardStrategy.h:
• platform/PlatformPasteboard.h:
• platform/ios/PasteboardIOS.mm:

(WebCore::Pasteboard::respectsUTIFidelities):
(WebCore::Pasteboard::readString):

• platform/ios/PlatformPasteboardIOS.mm:

(WebCore::PlatformPasteboard::readURL):

Source/WebKit/mac:

Add a new WK1 SPI property, -[WebFrame hasRichlyEditableDragCaret].

• WebCoreSupport/WebPlatformStrategies.h:
• WebCoreSupport/WebPlatformStrategies.mm:

(WebPlatformStrategies::readURLFromPasteboard):

• WebView/WebFrame.mm:

(-[WebFrame hasRichlyEditableDragCaret]):

• WebView/WebFramePrivate.h:

Source/WebKit2:

Adjust for interface changes in WebCore to support plumbing the title of an NSURL from the platform pasteboard
back to WebCore. Additionally, implement WebEditorClient::hasRichlyEditableSelection (which previously returned
false) to check whether the current selection is richly editable, or the drop caret is in richly editable content.
See WebCore ChangeLog for more details.

• UIProcess/Cocoa/WebPasteboardProxyCocoa.mm:

(WebKit::WebPasteboardProxy::readURLFromPasteboard):

• UIProcess/WebPasteboardProxy.h:
• UIProcess/WebPasteboardProxy.messages.in:
• WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:

(WebKit::WebPlatformStrategies::readURLFromPasteboard):

• WebProcess/WebCoreSupport/WebPlatformStrategies.h:
• WebProcess/WebCoreSupport/ios/WebEditorClientIOS.mm:

(WebKit::WebEditorClient::hasRichlyEditableSelection):

• WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::hasRichlyEditableSelection):

• WebProcess/WebPage/WebPage.h:

Tools:

Adds a new unit test, DataInteractionTests.ExternalSourceTitledNSURL.

• TestWebKitAPI/Tests/ios/DataInteractionTests.mm:

(TestWebKitAPI::TEST):