Context Navigation

← Previous Period
Next Period →

Timeline

May 10, 2017:

9:53 PM Changeset in webkit [216652] by timothy_horton@apple.com

2 edits in trunk/Source/WebKit2

Null deref in WebPage::dictionaryPopupInfoForRange
https://bugs.webkit.org/show_bug.cgi?id=171959
<rdar://problem/20886282>

Reviewed by Beth Dakin.

WebProcess/WebPage/mac/WebPageMac.mm:

(WebKit::WebPage::dictionaryPopupInfoForRange):
Speculative fix for non-reproducible crash when the startContainer of
the range is in an anonymous node.

9:23 PM Changeset in webkit [216651] by rniwa@webkit.org

2 edits in trunk/Websites/perf.webkit.org

Another build fix after r215633 to make the bar graphs render even when the confidence intervals aren't available.

public/v3/components/bar-graph-group.js:

(BarGraphGroup.prototype._computeRange):

9:22 PM Changeset in webkit [216650] by eric.carlson@apple.com

2 edits in trunk/Source/WebCore

[MediaStream] CoreAudioCaptureSource claims to never be muted
https://bugs.webkit.org/show_bug.cgi?id=171946
<rdar://problem/32111991>

Reviewed by Jer Noble.

platform/mediastream/mac/CoreAudioCaptureSource.cpp:

(WebCore::CoreAudioCaptureSource::stopProducingData): Set m_muted to true.

9:06 PM Changeset in webkit [216649] by rniwa@webkit.org

2 edits in trunk/Websites/perf.webkit.org

Build fix after r215633.

public/v3/models/test-group.js:

(TestGroup.prototype._computeRequestedCommitSets):
(TestGroup.prototype.requestsForCommitSet):

7:58 PM Changeset in webkit [216648] by matthew_hanson@apple.com

1 copy in tags/Safari-603.3.1

Tag Safari-603.3.1.

7:32 PM Changeset in webkit [216647] by rniwa@webkit.org

12 edits
2 adds in trunk/Websites/perf.webkit.org

Add API to upload a patched build for a custom A/B testing
https://bugs.webkit.org/show_bug.cgi?id=171956

Reviewed by Chris Dumez.

Added /api/upload-root to upload a root file, the build product of a patch associated with a commit set.

Extracted more functions out of privileged-api/upload-file.php to uploaded-file-helpers.php to share code
with /api/upload-root.php.

public/api/upload-root.php: Added.

(main):
(compute_commit_set_items_to_update): Find the list of commit set items to associate this root with.
A root can be associated with multiple repositories and there fore commit set items; e.g. if a software
is built from multiple repositories and there is a patch associated with one of them, the built product
must be associated with all those repositories.

public/include/build-requests-fetcher.php:

(BuildRequestsFetcher::fetch_commits_for_set_if_needed): Include the root file is there is one.

public/include/json-header.php:

(validate_arguments): Added the support for validating json string.
(verify_slave): Return the slave ID found.

public/include/uploaded-file-helpers.php:

(validate_uploaded_file): Extracted from /privileged-api/upload-file to be shared with /api/upload-root.
(query_total_file_size): Ditto.
(create_uploaded_file_from_form_data): Ditto.
(upload_file_in_transaction): Ditto. Takes a lambda to do the extra work inside the transaction.

public/privileged-api/upload-file.php:

(main):

public/v3/models/build-request.js:

(BuildRequest.constructBuildRequestsFromData): Resolve the rootFIle of each commit set item.

public/v3/models/commit-set.js:

(CommitSet): Added _repositoryToRootMap and _allRootFiles as instance variables.
(CommitSet.prototype.updateSingleton): Added. Previously, each commit set's states never changed after
its creation. After this patch, each item can be newly associated with a root so we must update its
_repositoryToRootMap and _allRootFiles. For simplicity, we update all states.
(CommitSet.prototype._updateFromObject): Extracted from the constructor.
(CommitSet.prototype.allRootFiles): Added. Includes custom roots and roots created for patches.
(CommitSet.prototype.rootForRepository): Added.
(CommitSet.prototype.equals): Fixed the bug that we were comparing _repositoryToPatchMap to
_repositoryToCommitMap, and added a check for _repositoryToRootMap.

public/v3/models/test-group.js:

(TestGroup.prototype.task): Added.
(TestGroup.createWithTask):
(TestGroup.createWithCustomConfiguration):
(TestGroup.createAndRefetchTestGroups):
(TestGroup._fetchTestGroupsForTask): Deleted. Now fetchForTask takes a boolean argument: ignoreCache.
(TestGroup.findAllByTask): Added.
(TestGroup.fetchForTask): Renamed from fetchByTask.

public/v3/pages/analysis-task-page.js:

(AnalysisTaskPage.prototype._fetchRelatedInfoForTaskId):

server-tests/api-build-requests-tests.js:

server-tests/api-upload-root-tests.js: Added. Added tests for /api/upload-root.

(makeReport): Added.
(addSlaveAndCreateRootFile): Added.
(createTestGroupWihPatch): Added.

server-tests/privileged-api-create-test-group-tests.js:

server-tests/resources/mock-data.js:

(MockData.sharedRepositoryId): Added.
(MockData.addMockData): Added "Shared" repository along with commits.

7:26 PM Changeset in webkit [216646] by rniwa@webkit.org

1 edit
1 add
1 delete in trunk/Websites/perf.webkit.org

Rename server-tests/api-update-triggerable.js to server-tests/api-update-triggerable-tests.js
https://bugs.webkit.org/show_bug.cgi?id=171905

Reviewed by Chris Dumez.

server-tests/api-update-triggerable-tests.js: Renamed from server-tests/api-update-triggerable.js.

6:51 PM Changeset in webkit [216645] by jer.noble@apple.com

2 edits in trunk/Source/WebCore

RELEASE_ASSERT at WebAudioSourceProviderAVFObjC::provideInput()
https://bugs.webkit.org/show_bug.cgi?id=171711

Reviewed by Youenn Fablet.

Before iterating over the channels in either the WebAudioBufferList or the AudioBus, ensure
we don't walk over the end of either by only iterating over the minimum length of either.
Also, when the internal format of WebAudioSourceProviderAVFObjC changes, notify the
MediaStreamAudioSourceNode that the number of channels and sample rate have changed.

platform/mediastream/mac/WebAudioSourceProviderAVFObjC.mm:

(WebCore::WebAudioSourceProviderAVFObjC::provideInput):
(WebCore::WebAudioSourceProviderAVFObjC::prepare):

5:56 PM Changeset in webkit [216644] by Matt Lewis

2 edits in trunk/LayoutTests

Marked fast/animation/request-animation-frame-time-unit.html as flaky.
https://bugs.webkit.org/show_bug.cgi?id=171957

Unreviewed test gardening.

platform/ios-wk2/TestExpectations:

5:33 PM Changeset in webkit [216643] by aestes@apple.com

8 edits in trunk

REGRESSION (r167845): ASSERT(!m_renderView.needsLayout()) in svg/custom/bug79798.html
https://bugs.webkit.org/show_bug.cgi?id=132297

Reviewed by Simon Fraser.

Source/WebCore:

We don't know why m_renderView needs layout in this case, but we know that we don't need to
assert if the client hasn't set the ScrollableInnerFrameTrigger compositing trigger.

rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::requiresCompositingForScrollableFrame):

LayoutTests:

http/tests/navigation/keyboard-events-during-provisional-navigation-expected.txt:
http/tests/navigation/keyboard-events-during-provisional-subframe-navigation-expected.txt:
http/tests/navigation/resources/keyboard-events-test.js:

(runTest):

platform/ios-wk2/TestExpectations:
platform/wk2/TestExpectations:

5:32 PM Changeset in webkit [216642] by Ryan Haddad

2 edits in trunk/Source/WebCore

Unreviewed, rolling out r216630.

This change caused assertion failures with webrtc LayoutTests.

Reverted changeset:

"RELEASE_ASSERT at
WebAudioSourceProviderAVFObjC::provideInput()"
https://bugs.webkit.org/show_bug.cgi?id=171711
http://trac.webkit.org/changeset/216630

5:29 PM Changeset in webkit [216641] by weinig@apple.com

63 edits
11 deletes in trunk

Remove support for legacy Notifications
https://bugs.webkit.org/show_bug.cgi?id=171487

Reviewed by Jon Lee.

Source/JavaScriptCore:

Configurations/FeatureDefines.xcconfig:

Remove definition of ENABLE_LEGACY_NOTIFICATIONS.

Source/WebCore:

CMakeLists.txt:
WebCore.xcodeproj/project.pbxproj:

Remove files.

Configurations/FeatureDefines.xcconfig:

Remove definition of ENABLE_LEGACY_NOTIFICATIONS.

DerivedSources.make:

Remove IDL files.

Modules/notifications/DOMWindowNotifications.cpp: Removed.
Modules/notifications/DOMWindowNotifications.h: Removed.
Modules/notifications/DOMWindowNotifications.idl: Removed.
Modules/notifications/NotificationCenter.cpp: Removed.
Modules/notifications/NotificationCenter.h: Removed.
Modules/notifications/NotificationCenter.idl: Removed.
Modules/notifications/NotificationClient.h:
Modules/notifications/NotificationController.cpp:
Modules/notifications/NotificationController.h:
Modules/notifications/WorkerGlobalScopeNotifications.cpp: Removed.
Modules/notifications/WorkerGlobalScopeNotifications.h: Removed.
Modules/notifications/WorkerGlobalScopeNotifications.idl: Removed.
Modules/notifications/Notification.idl:
Modules/notifications/Notification.cpp:
Modules/notifications/Notification.h:
dom/EventTargetFactory.in:
page/DOMWindow.cpp:
workers/WorkerThread.h:

Remove code legacy Notification code. Replace use of NotificationCenter with direct
calls to the NotificationClient.

Source/WebCore/PAL:

Configurations/FeatureDefines.xcconfig:

Remove definition of ENABLE_LEGACY_NOTIFICATIONS.

Source/WebKit/mac:

Configurations/FeatureDefines.xcconfig:
WebCoreSupport/WebNotificationClient.h:
WebCoreSupport/WebNotificationClient.mm:
WebView/WebNotification.mm:
WebView/WebNotificationInternal.h:
WebView/WebView.mm:

(-[WebView _commonInitializationWithFrameName:groupName:]):
(-[WebView _notificationIDForTesting:]):
Remove legacy notification specific code.

Source/WebKit/win:

WebCoreSupport/WebChromeClient.cpp:

(WebChromeClient::WebChromeClient):

WebCoreSupport/WebChromeClient.h:
WebCoreSupport/WebDesktopNotificationsDelegate.cpp:
WebCoreSupport/WebDesktopNotificationsDelegate.h:

Remove legacy notification specific code.

Source/WebKit2:

Configurations/FeatureDefines.xcconfig:
Shared/WebProcessCreationParameters.cpp:
Shared/WebProcessCreationParameters.h:
UIProcess/WebProcessPool.cpp:
WebProcess/InjectedBundle/InjectedBundle.cpp:
WebProcess/Notifications/NotificationPermissionRequestManager.cpp:
WebProcess/Notifications/NotificationPermissionRequestManager.h:
WebProcess/Notifications/WebNotificationManager.cpp:
WebProcess/Notifications/WebNotificationManager.h:
WebProcess/WebCoreSupport/WebNotificationClient.cpp:
WebProcess/WebCoreSupport/WebNotificationClient.h:
WebProcess/WebPage/WebPage.cpp:
WebProcess/WebProcess.cpp:

Remove legacy notification specific code.

Source/WTF:

wtf/FeatureDefines.h:

Remove definition of ENABLE_LEGACY_NOTIFICATIONS.

Tools:

DumpRenderTree/win/DRTDesktopNotificationPresenter.cpp:

(DRTDesktopNotificationPresenter::checkNotificationPermission):

Scripts/webkitperl/FeatureList.pm:
TestWebKitAPI/Configurations/FeatureDefines.xcconfig:

Remove use and definition of ENABLE_LEGACY_NOTIFICATIONS.

LayoutTests:

Remove fast/notifications/. It was skipped on all platforms and use legacy Notifications API.
Remove http/notifications/legacy. It tested the legacy API.
Update two tests in fast/history to use the non-legacy API to test page cache + notifications.
Update TestExpectations for removals.

TestExpectations:
platform/gtk/TestExpectations:
platform/ios/TestExpectations:
platform/mac/TestExpectations:
platform/win/TestExpectations:
fast/history/page-cache-notification-non-suspendable.html:
fast/history/page-cache-notification-suspendable.html:
fast/notifications: Removed.
fast/notifications/notification-after-close-expected.txt: Removed.
fast/notifications/notification-after-close.html: Removed.
fast/notifications/notification-permisssion-deletable-expected.txt: Removed.
fast/notifications/notification-permisssion-deletable.html: Removed.
fast/notifications/notifications-cancel-request-permission-expected.txt: Removed.
fast/notifications/notifications-cancel-request-permission.html: Removed.
fast/notifications/notifications-check-permission-expected.txt: Removed.
fast/notifications/notifications-check-permission.html: Removed.
fast/notifications/notifications-click-event-expected.txt: Removed.
fast/notifications/notifications-click-event-focus-expected.txt: Removed.
fast/notifications/notifications-click-event-focus.html: Removed.
fast/notifications/notifications-click-event.html: Removed.
fast/notifications/notifications-constructor-request-permission-expected.txt: Removed.
fast/notifications/notifications-constructor-request-permission.html: Removed.
fast/notifications/notifications-constructor-with-permission-expected.txt: Removed.
fast/notifications/notifications-constructor-with-permission.html: Removed.
fast/notifications/notifications-constructor-without-permission-expected.txt: Removed.
fast/notifications/notifications-constructor-without-permission.html: Removed.
fast/notifications/notifications-display-close-events-expected.txt: Removed.
fast/notifications/notifications-display-close-events.html: Removed.
fast/notifications/notifications-document-close-crash-expected.txt: Removed.
fast/notifications/notifications-document-close-crash.html: Removed.
fast/notifications/notifications-event-stop-propagation-expected.txt: Removed.
fast/notifications/notifications-event-stop-propagation.html: Removed.
fast/notifications/notifications-multi-events-expected.txt: Removed.
fast/notifications/notifications-multi-events.html: Removed.
fast/notifications/notifications-no-icon-expected.txt: Removed.
fast/notifications/notifications-no-icon.html: Removed.
fast/notifications/notifications-permission-expected.txt: Removed.
fast/notifications/notifications-permission.html: Removed.
fast/notifications/notifications-replace-expected.txt: Removed.
fast/notifications/notifications-replace.html: Removed.
fast/notifications/notifications-request-permission-expected.txt: Removed.
fast/notifications/notifications-request-permission-optional-expected.txt: Removed.
fast/notifications/notifications-request-permission-optional.html: Removed.
fast/notifications/notifications-request-permission.html: Removed.
fast/notifications/notifications-rtl-expected.txt: Removed.
fast/notifications/notifications-rtl.html: Removed.
fast/notifications/notifications-sandbox-permission-expected.txt: Removed.
fast/notifications/notifications-sandbox-permission.html: Removed.
fast/notifications/notifications-window-close-crash-expected.txt: Removed.
fast/notifications/notifications-window-close-crash.html: Removed.
fast/notifications/notifications-with-permission-expected.txt: Removed.
fast/notifications/notifications-with-permission.html: Removed.
fast/notifications/notifications-without-permission-expected.txt: Removed.
fast/notifications/notifications-without-permission.html: Removed.
fast/notifications/request-notification-permission-while-reloading-expected.txt: Removed.
fast/notifications/request-notification-permission-while-reloading.html: Removed.
fast/notifications/resources: Removed.
fast/notifications/resources/notifications-cancel-request-permission.html: Removed.
fast/notifications/resources/notifications-iframe.html: Removed.
http/tests/notifications/legacy: Removed.
http/tests/notifications/legacy/double-show-expected.txt: Removed.
http/tests/notifications/legacy/double-show.html: Removed.
http/tests/notifications/legacy/events-expected.txt: Removed.
http/tests/notifications/legacy/events.html: Removed.
http/tests/notifications/legacy/notification-request-permission-then-navigate-expected.txt: Removed.
http/tests/notifications/legacy/notification-request-permission-then-navigate.html: Removed.
http/tests/notifications/legacy/request-expected.txt: Removed.
http/tests/notifications/legacy/request-no-callback-expected.txt: Removed.
http/tests/notifications/legacy/request-no-callback.html: Removed.
http/tests/notifications/legacy/request.html: Removed.
http/tests/notifications/legacy/resources: Removed.
http/tests/notifications/legacy/resources/notify-opener-done.html: Removed.
http/tests/notifications/legacy/resources/request-permission-then-navigate.html: Removed.
http/tests/notifications/legacy/show-expected.txt: Removed.
http/tests/notifications/legacy/show.html: Removed.
http/tests/notifications/legacy/window-show-on-click-expected.txt: Removed.
http/tests/notifications/legacy/window-show-on-click.html: Removed.

5:25 PM Changeset in webkit [216640] by Ryan Haddad

2 edits in trunk/LayoutTests

Mark media/modern-media-controls/media-controller/media-controller-auto-hide-mouse-enter-and-mouse-leave.html as flaky.
https://bugs.webkit.org/show_bug.cgi?id=169876

Unreviewed test gardening.

platform/mac/TestExpectations:

5:20 PM Changeset in webkit [216639] by Ryan Haddad

2 edits in trunk/LayoutTests

Mark inspector/protocol/inspector-backend-invocation-return-value.html as flaky.
https://bugs.webkit.org/show_bug.cgi?id=168146

Unreviewed test gardening.

platform/mac/TestExpectations:

4:48 PM Changeset in webkit [216638] by mark.lam@apple.com

10 edits in trunk

Unreviewed, rolling out r216635.
https://bugs.webkit.org/show_bug.cgi?id=171953

"Some worker tests are failing". (Requested by mlam on #webkit).

Reverted changeset:

"WorkerThread::stop() should call
scheduleExecutionTermination() last."
https://bugs.webkit.org/show_bug.cgi?id=171775
http://trac.webkit.org/changeset/216635

Patch by Commit Queue <commit-queue@webkit.org> on 2017-05-10

4:43 PM Changeset in webkit [216637] by mark.lam@apple.com

2 edits in trunk/Source/JavaScriptCore

Crash in JavaScriptCore GC when using JSC on dispatch queues (thread_get_state returns NULL stack pointer).
https://bugs.webkit.org/show_bug.cgi?id=160337
<rdar://problem/27611733>

Not reviewed.

Updated a comment per Geoff's suggestion.

heap/MachineStackMarker.cpp:

(JSC::MachineThreads::tryCopyOtherThreadStack):

4:39 PM Changeset in webkit [216636] by matthew_hanson@apple.com

8 edits in branches/safari-603-branch/Source

Cherry-pick r214320. rdar://problem/32057095

4:22 PM Changeset in webkit [216635] by mark.lam@apple.com

10 edits in trunk

WorkerThread::stop() should call scheduleExecutionTermination() last.
https://bugs.webkit.org/show_bug.cgi?id=171775
<rdar://problem/30975761>

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

Increased the number of frames captured in VM::nativeStackTraceOfLastThrow()
from 25 to 100. From experience, I found that 25 is sometimes not sufficient
for our debugging needs.

Also added VM::throwingThread() to track which thread an exception was thrown in.
This may be useful if the client is entering the VM from different threads.

runtime/ExceptionScope.cpp:

(JSC::ExceptionScope::unexpectedExceptionMessage):
(JSC::ExceptionScope::releaseAssertIsTerminatedExecutionException):

runtime/ExceptionScope.h:

(JSC::ExceptionScope::exception):
(JSC::ExceptionScope::unexpectedExceptionMessage):

runtime/VM.cpp:

(JSC::VM::throwException):

runtime/VM.h:

(JSC::VM::throwingThread):
(JSC::VM::clearException):

Source/WebCore:

Currently, WorkerThread::stop() calls scheduleExecutionTermination() to terminate
JS execution first, followed by posting a cleanup task to the worker, and lastly,
it invokes terminate() on the WorkerRunLoop.

As a result, before run loop is terminate, the worker thread may observe the
TerminatedExecutionException in JS code, bail out, see another JS task to run,
re-enters the VM to run said JS code, and fails with an assertion due to the
TerminatedExecutionException still being pending on VM entry.

WorkerRunLoop::Task::performTask() already has a check to only allow a task to
run if and only if !runLoop.terminated() and the task is not a clean up task.
We'll fix the above race by ensuring that having WorkerThread::stop() terminate
the run loop before it scheduleExecutionTermination() which throws the
TerminatedExecutionException. This way, by the time JS code unwinds out of the
VM due to the TerminatedExecutionException, runLoop.terminated() is guaranteed
to be true and thereby prevents re-entry into the VM.

This issue is covered by an existing test that I just unskipped in TestExpectations.

bindings/js/JSDOMPromiseDeferred.cpp:

(WebCore::DeferredPromise::callFunction):

workers/WorkerThread.cpp:

(WebCore::WorkerThread::stop):

LayoutTests:

TestExpectations:

4:05 PM Changeset in webkit [216634] by timothy_horton@apple.com

12 edits in trunk

Add an experimental feature flag for viewport-fit
https://bugs.webkit.org/show_bug.cgi?id=171948
<rdar://problem/31995518>

Reviewed by Simon Fraser.

Shared/WebPreferencesDefinitions.h:
WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::updatePreferences):
Add an experimental feature flag.

dom/ViewportArguments.cpp:

(WebCore::setViewportFeature):

page/Settings.in:

Disable parsing of viewport-fit if the experimental feature is disabled.

fast/css/variables/constants/ios/safe-area-inset-set-expected.html:
fast/css/variables/constants/ios/safe-area-inset-set.html:
fast/viewport/ios/viewport-fit-auto.html:
fast/viewport/ios/viewport-fit-contain.html:
fast/viewport/ios/viewport-fit-cover.html:

3:57 PM Changeset in webkit [216633] by Matt Lewis

2 edits in trunk/LayoutTests

Marked fast/hidpi/filters-and-image-buffer-resolution.html as flaky.
https://bugs.webkit.org/show_bug.cgi?id=171951

Unreviewed test gardening.

platform/ios-wk2/TestExpectations:

3:25 PM Changeset in webkit [216632] by Chris Dumez

19 edits in trunk/Source

Simplify relationship between Attr and Element now that Attr is childless
https://bugs.webkit.org/show_bug.cgi?id=171909

Reviewed by Ryosuke Niwa.

Source/WebCore:

Simplify relationship between Attr and Element now that Attr is childless
after r216259.

No new tests, no Web facing behavior change.

dom/Attr.cpp:

(WebCore::Attr::setValue):
Attr::setValue() was only called by Element::setAttributeInternal() to make sure
we updated the Attr node's Text child. However, now that Attr has no Text child,
Element no longer needs to update the Attr node's value.
Attr::setValueForBindings() was thus renamed to setValue(). Its implementation
was also simplified by calling Element::setAttribute() on its ownerElement, if
it has one, instead of duplicating a bunch of code from Element::setAttributeInternal().

(WebCore::Attr::setNodeValue):
Call setValue() instead of setValueForBindings() now that it has been renamed.

dom/Attr.h:
dom/Attr.idl:

Rename valueForBindings / setValueForBindings to value / setValue.

dom/Document.h:

Split shouldInvalidateNodeListAndCollectionCaches() into 2 methods, one taking an Attr name
and another that does not. There are now 2 calls sites instead of one, so we no longer need
to branch in this function.

dom/Element.cpp:

(WebCore::Element::setAttributeInternal):
Drop code calling Attr::setValue() on the Attr node since Attr::setValue() was only
duplicating logic from Element::setAttributeInternal() after r216259. There is nothing
on Attr that needs updating when an element attribute gets updated.

(WebCore::Element::attributeChanged):
Call the new invalidateNodeListAndCollectionCachesInAncestorsForAttribute(). This
is the only call site that passes an attribute name.

dom/Node.cpp:

(WebCore::Document::shouldInvalidateNodeListAndCollectionCaches):
(WebCore::Document::shouldInvalidateNodeListAndCollectionCachesForAttribute):
Split into 2 to avoid branching, as explained above.

(WebCore::Node::invalidateNodeListAndCollectionCachesInAncestors):
(WebCore::Node::invalidateNodeListAndCollectionCachesInAncestorsForAttribute):

invalidateNodeListAndCollectionCachesInAncestors() used to invalidate childNodeLists if the Node was an attribute node. Drop this as this is no longer needed as of r216259.
After the change to Attr::setValue(), call sites for invalidateNodeListAndCollectionCachesInAncestors() either had no parameters, or both parameters present and non-null. There is therefore no longer any need to handle having an attrName but no attributeOwnerElement. To make this obvious, I split this into 2 methods: invalidateNodeListAndCollectionCachesInAncestors() and invalidateNodeListAndCollectionCachesInAncestorsForAttribute(attrName). We no longer need the attributeOwnerElement parameter as it was only used to exit early.

dom/Node.h:

Source/WebKit/mac:

Build fix.

DOM/DOMAttr.mm:

(-[DOMAttr value]):
(-[DOMAttr setValue:]):

3:23 PM Changeset in webkit [216631] by Antti Koivisto

6 edits
2 adds in trunk

REGRESSION (r207372) Visibility property is not inherited when used in an animation
https://bugs.webkit.org/show_bug.cgi?id=171883
<rdar://problem/32086550>

Reviewed by Simon Fraser.

Source/WebCore:

The problem here is that our animation code is tied to renderers. We don't have renderers during
the initial style resolution so animations are not applied yet. When constructing renderers we set
their style to the initial animated style but this step can't implement inheritance.

Normally this is invisible as the first animation frame will immediately inherit the style correctly.
However in this case the animation is discrete and the first frame is the same as the initial state.
With r207372 we optimize the descendant style change away.

This patch fixes the problem by tracking that the renderer has initial animated style and inheriting
it to descendants during next style resolution even if it doesn't change.

Test: animations/animation-initial-inheritance.html

rendering/RenderElement.cpp:

(WebCore::RenderElement::RenderElement):

rendering/RenderElement.h:

(WebCore::RenderElement::hasInitialAnimatedStyle):
(WebCore::RenderElement::setHasInitialAnimatedStyle):

style/RenderTreeUpdater.cpp:

(WebCore::RenderTreeUpdater::createRenderer):

Set a bit on renderer indicating it has initial animated style.

style/StyleTreeResolver.cpp:

(WebCore::Style::TreeResolver::createAnimatedElementUpdate):

Return at least 'Inherit' for style change when updating renderer with initial animated style.

LayoutTests:

animations/animation-initial-inheritance-expected.html: Added.
animations/animation-initial-inheritance.html: Added.

3:03 PM Changeset in webkit [216630] by jer.noble@apple.com

2 edits in trunk/Source/WebCore

RELEASE_ASSERT at WebAudioSourceProviderAVFObjC::provideInput()
https://bugs.webkit.org/show_bug.cgi?id=171711

Reviewed by Youenn Fablet.

platform/mediastream/mac/WebAudioSourceProviderAVFObjC.mm:

(WebCore::WebAudioSourceProviderAVFObjC::provideInput):
(WebCore::WebAudioSourceProviderAVFObjC::prepare):

3:01 PM Changeset in webkit [216629] by BJ Burg

3 edits in trunk/Source/WebInspectorUI

Web Inspector: RTL: in Timelines > JavaScript & Events, digits for timer and animation frame number are not localized
https://bugs.webkit.org/show_bug.cgi?id=171818

Reviewed by Joseph Pecoraro.

These numbers need to be formatted with %d, not %s.

Localizations/en.lproj/localizedStrings.js:
UserInterface/Models/ScriptTimelineRecord.js:

(WebInspector.ScriptTimelineRecord.EventType.displayName):

2:59 PM Changeset in webkit [216628] by BJ Burg

10 edits in trunk/Source/WebInspectorUI

Web Inspector: remove dead code for switching Toolbar display options
https://bugs.webkit.org/show_bug.cgi?id=170738

Reviewed by Joseph Pecoraro.

Localizations/en.lproj/localizedStrings.js:
UserInterface/Base/Main.js:

(WebInspector.contentLoaded):

UserInterface/Views/ButtonToolbarItem.css:

(.toolbar .item.button > .glyph):
(.toolbar .item.button > .label):
(.toolbar.icon-and-label-vertical .item.button): Deleted.
(.toolbar.icon-and-label-horizontal .item.button): Deleted.
(.toolbar.small-size .item.button > .glyph): Deleted.
(.toolbar.label-only .item.button > .glyph): Deleted.
(.toolbar.label-only .item.activate.button.activated > .label): Deleted.
(.toolbar.icon-and-label-horizontal .item.button > .label): Deleted.
(.toolbar.icon-only .item.button > .label): Deleted.

UserInterface/Views/ControlToolbarItem.css:

(.toolbar .item.control):
(.toolbar:matches(.icon-and-label-horizontal, .icon-only) .item.control): Deleted.

UserInterface/Views/DashboardContainerView.css:

(.toolbar .dashboard-container):
(.toolbar.icon-and-label-vertical:matches(.small-size, .normal-size) .dashboard-container): Deleted.
(.toolbar.label-only .dashboard-container,): Deleted.
(.toolbar.normal-size:matches(.icon-only, .icon-and-label-vertical, .icon-and-label-horizontal) .dashboard-container): Deleted.
(.toolbar.label-only .dashboard-container .advance-arrow): Deleted.
(body[dir=ltr] .toolbar.label-only .dashboard-container .advance-arrow): Deleted.
(body[dir=rtl] .toolbar.label-only .dashboard-container .advance-arrow): Deleted.

UserInterface/Views/DefaultDashboardView.css:

(.toolbar .dashboard.default > .item):
(.toolbar.label-only .dashboard.default > .item,): Deleted.
(.toolbar.normal-size:matches(.icon-only, .icon-and-label-vertical, .icon-and-label-horizontal) .dashboard.default > .item): Deleted.

UserInterface/Views/ReplayDashboardView.css:

(.toolbar .dashboard.replay .item.button > .glyph):
(.toolbar.label-only .dashboard.replay .item.button > .glyph): Deleted.

UserInterface/Views/Toolbar.css:

(.toolbar .control-section):
(.toolbar:matches(.icon-and-label-horizontal.small-size, .icon-only.small-size, .label-only) .control-section): Deleted.

UserInterface/Views/Toolbar.js:

(WebInspector.Toolbar):
(WebInspector.Toolbar.prototype.layout):
(WebInspector.Toolbar.prototype.get displayMode): Deleted.
(WebInspector.Toolbar.prototype.set displayMode): Deleted.
(WebInspector.Toolbar.prototype.get sizeMode): Deleted.
(WebInspector.Toolbar.prototype.set sizeMode): Deleted.
(WebInspector.Toolbar.prototype._handleContextMenuEvent): Deleted.
(WebInspector.Toolbar.prototype._changeDisplayMode): Deleted.
(WebInspector.Toolbar.prototype._toggleSmallIcons): Deleted.

2:59 PM Changeset in webkit [216627] by matthew_hanson@apple.com

1 edit in branches/safari-603-branch/Source/WebCore/ChangeLog

Fix order of merge from r212528. rdar://problem/31153819

2:59 PM Changeset in webkit [216626] by matthew_hanson@apple.com

2 edits in branches/safari-603-branch/Source/WebCore

Fix order of merge from r212528

2:57 PM Changeset in webkit [216625] by fpizlo@apple.com

2 edits in trunk/Source/WebCore

GCController.cpp's collect() should be Async
https://bugs.webkit.org/show_bug.cgi?id=171708

Reviewed by Saam Barati and Geoffrey Garen.

No new tests because no change in behavior.

This is one step towards not requesting sync GCs in WebCore. I'm landing this incrementally to
make bisecting super easy.

This is a ~7% JetStream iOS "regression", because JetStream has a bug where it allows trunk
to sneakily hide GC work between when JetStream measures time. After this change, we are no
longer trying to be sneaky.

bindings/js/GCController.cpp:

(WebCore::collect):

2:34 PM Changeset in webkit [216624] by Matt Lewis

2 edits in trunk/LayoutTests

Marked transitions/extra-transition.html as flaky.
https://bugs.webkit.org/show_bug.cgi?id=171947

Unreviewed test gardening.

platform/mac-wk2/TestExpectations:

2:31 PM Changeset in webkit [216623] by jer.noble@apple.com

2 edits in trunk/Source/WebCore

CoreAudioCaptureSource reports 3 or 5 channel audio output; actually only mono
https://bugs.webkit.org/show_bug.cgi?id=171940

Reviewed by Eric Carlson.

Asking for the Input VPIO stream format will return the internal mic format, before processing. Instead
ask for the input bus's output format, which is post processing, which will return the correct number
of channels (one).

platform/mediastream/mac/CoreAudioCaptureSource.cpp:

(WebCore::CoreAudioSharedUnit::configureMicrophoneProc):

2:23 PM Changeset in webkit [216622] by matthew_hanson@apple.com

23 edits in branches/safari-603-branch/Source

Additional ENABLE_STREAMS cleanup

2:23 PM Changeset in webkit [216621] by matthew_hanson@apple.com

46 edits in branches/safari-603-branch

Cherry-pick r215429. rdar://problem/32057106

2:23 PM Changeset in webkit [216620] by matthew_hanson@apple.com

10 edits in branches/safari-603-branch

Cherry-pick r215250. rdar://problem/32057106

2:14 PM Changeset in webkit [216619] by Ryan Haddad

6 edits
2 deletes in trunk

Unreviewed, rolling out r216591.

This change broke an internal build.

Reverted changeset:

"REGRESSION (r207372) Visibility property is not inherited
when used in an animation"
https://bugs.webkit.org/show_bug.cgi?id=171883
http://trac.webkit.org/changeset/216591

2:11 PM Changeset in webkit [216618] by Ryan Haddad

2 edits in trunk/LayoutTests

Unreviewed, remove TestExpectation for a test that was removed in r216259.

platform/mac/TestExpectations:

2:02 PM Changeset in webkit [216617] by Matt Lewis

2 edits in trunk/LayoutTests

Marked perf/class-list-remove.html as flaky.
https://bugs.webkit.org/show_bug.cgi?id=171945

Unreviewed test gardening.

platform/ios-wk2/TestExpectations:

1:52 PM Changeset in webkit [216616] by achristensen@apple.com

2 edits in trunk/Source/WebKit2

Include headers in WebKit.h
https://bugs.webkit.org/show_bug.cgi?id=171943

Reviewed by Dan Bernstein.

Shared/API/Cocoa/WebKit.h:

1:50 PM Changeset in webkit [216615] by Chris Dumez

6 edits in trunk/Source/WebCore

Drop custom bindings code now window.open()
https://bugs.webkit.org/show_bug.cgi?id=171933

Reviewed by Geoffrey Garen.

Drop custom bindings code now window.open() as it is not doing anything special.

bindings/js/JSDOMWindowCustom.cpp:

(WebCore::JSDOMWindow::open): Deleted.

page/DOMWindow.cpp:

(WebCore::DOMWindow::open):

page/DOMWindow.h:
page/DOMWindow.idl:
testing/Internals.cpp:

(WebCore::Internals::openDummyInspectorFrontend):

1:44 PM Changeset in webkit [216614] by aestes@apple.com

3 edits in trunk/LayoutTests

r216599 accidentally included two copies of the new layout test and expected result
https://bugs.webkit.org/show_bug.cgi?id=171938

Unreviewed.

http/tests/navigation/keyboard-events-during-provisional-subframe-navigation-expected.txt:
http/tests/navigation/keyboard-events-during-provisional-subframe-navigation.html:

1:41 PM Changeset in webkit [216613] by Ryan Haddad

2 edits in trunk/LayoutTests

Skip http/tests/navigation/keyboard-events-during-provisional-subframe-navigation.html on ios-simulator.
https://bugs.webkit.org/show_bug.cgi?id=171880

Unreviewed test gardening.

This test times out on ios-simulator because it relies on eventSender.keyDown.

platform/ios/TestExpectations:

1:29 PM Changeset in webkit [216612] by timothy_horton@apple.com

16 edits in trunk/Source/WebKit2

Disable block selection for dynamic selection granularity
https://bugs.webkit.org/show_bug.cgi?id=171908
<rdar://problem/32098024>

Reviewed by Enrica Casucci.

UIProcess/API/Cocoa/WKWebViewConfiguration.mm:

(-[WKWebViewConfiguration init]):
(-[WKWebViewConfiguration copyWithZone:]):
(-[WKWebViewConfiguration _allowsBlockSelection]):
(-[WKWebViewConfiguration _setAllowsBlockSelection:]):

UIProcess/API/Cocoa/WKWebViewConfigurationPrivate.h:

Add a private configuration parameter to re-enable block selection.

Shared/WebPageCreationParameters.cpp:

(WebKit::WebPageCreationParameters::encode):
(WebKit::WebPageCreationParameters::decode):

Shared/WebPageCreationParameters.h:
UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _allowsBlockSelection]):

UIProcess/API/Cocoa/WKWebViewInternal.h:
UIProcess/Cocoa/VersionChecks.h:
UIProcess/PageClient.h:
UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::creationParameters):

UIProcess/ios/PageClientImplIOS.h:
UIProcess/ios/PageClientImplIOS.mm:

(WebKit::PageClientImpl::allowsBlockSelection):

WebProcess/WebPage/WebPage.cpp:
WebProcess/WebPage/WebPage.h:

Plumb allowsBlockSelection through from WKWebViewConfiguration to WebPage.

UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView setupInteraction]):
(-[WKContentView useSelectionAssistantWithGranularity:]):
(-[WKContentView _startAssistingKeyboard]):
(-[WKContentView _stopAssistingKeyboard]):
(toUIWebSelectionMode): Deleted.
(-[WKContentView useSelectionAssistantWithMode:]): Deleted.
Stop needlessly converting to UIWebSelectionMode.

WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::shouldSwitchToBlockModeForHandle):
Don't switch to block selection unless allowsBlockSelection is set.

1:26 PM Changeset in webkit [216611] by timothy_horton@apple.com

16 edits in trunk

Add an experimental feature flag for constant properties
https://bugs.webkit.org/show_bug.cgi?id=171913
<rdar://problem/31995518>

Reviewed by Ryosuke Niwa.

css/parser/CSSParser.cpp:

(WebCore::CSSParserContext::CSSParserContext):
(WebCore::operator==):

css/parser/CSSParserImpl.cpp:

(WebCore::CSSParserImpl::consumeCustomPropertyValue):

css/parser/CSSParserMode.h:
css/parser/CSSPropertyParser.cpp:

(WebCore::CSSPropertyParser::parseValueStart):

css/parser/CSSVariableParser.cpp:

(WebCore::classifyBlock):
(WebCore::isValidVariableReference):
(WebCore::isValidConstantReference):
(WebCore::classifyVariableRange):
(WebCore::CSSVariableParser::containsValidVariableReferences):
(WebCore::CSSVariableParser::parseDeclarationValue):

css/parser/CSSVariableParser.h:

Plumb the experimental feature flag down into CSSVariableParser by way
of CSSParserContext.

page/Settings.in:

Shared/WebPreferencesDefinitions.h:
WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::updatePreferences):
Add an experimental feature flag.

fast/css/variables/constants/invalid-constant-name-fallback.html:
fast/css/variables/constants/ios/safe-area-inset-set.html:
fast/css/variables/constants/safe-area-inset-cannot-override.html:
fast/css/variables/constants/safe-area-inset-zero.html:

1:16 PM Changeset in webkit [216610] by dino@apple.com

2 edits in trunk/Source/WebKit2

Disable WebGL2 by default
https://bugs.webkit.org/show_bug.cgi?id=171894
<rdar://problem/32089917>

Reviewed by Tim Horton.

Some WASM and WebGL2 content is failing because it
detects our WebGL2RenderingContext, but doesn't realise
that we don't implement enough of it to be useful.

Shared/WebPreferencesDefinitions.h:

1:07 PM Changeset in webkit [216609] by Matt Lewis

2 edits in trunk/LayoutTests

Marked media/track/track-cue-rendering-on-resize.html as flaky.
https://bugs.webkit.org/show_bug.cgi?id=171939

Unreviewed test gardening.

platform/mac-wk2/TestExpectations:

1:07 PM Changeset in webkit [216608] by mark.lam@apple.com

2 edits in trunk/Source/JavaScriptCore

Crash in JavaScriptCore GC when using JSC on dispatch queues (thread_get_state returns NULL stack pointer).
https://bugs.webkit.org/show_bug.cgi?id=160337
<rdar://problem/27611733>

Reviewed by Filip Pizlo and Geoffrey Garen.

This is a workaround for <rdar://problem/27607384>. During thread initialization,
for some target platforms, thread state is momentarily set to 0 before being
filled in with the target thread's real register values. As a result, there's
a race condition that may result in us getting a null stackPointer during a GC scan.
This issue may manifest with workqueue threads where the OS may choose to recycle
a thread for an expired task.

The workaround is simply to indicate that there's nothing to copy and return.
This is correct because we will only ever observe a null pointer during thread
initialization. Hence, by definition, there's nothing there that we need to scan
yet, and therefore, nothing that needs to be copied.

heap/MachineStackMarker.cpp:

(JSC::MachineThreads::tryCopyOtherThreadStack):

12:52 PM Changeset in webkit [216607] by Chris Dumez

2 edits in trunk/Source/WebCore

REGRESSION (r206960): Possible null pointer dereference under DOMSelection::getRangeAt()
https://bugs.webkit.org/show_bug.cgi?id=171925
<rdar://problem/29931223>

Reviewed by Wenson Hsieh.

We have evidence that selection().firstRange() can return null in DOMSelection::getRangeAt().
When this happens, we now throw an INDEX_SIZE_ERR instead of dereferencing it.

I believe this can happen if the VisibleSelection is orphaned but not none, because
rangeCount() only checks for isNone() but VisibleSelection::firstRange() can return null
if isNoneOrOrphaned().

No new tests, I do not know how to reproduce.

page/DOMSelection.cpp:

(WebCore::DOMSelection::getRangeAt):

12:41 PM Changeset in webkit [216606] by Ryan Haddad

2 edits in trunk/LayoutTests

Mark imported/w3c/web-platform-tests/dom/nodes/ParentNode-querySelector-All tests as flaky.
https://bugs.webkit.org/show_bug.cgi?id=171937

Unreviewed test gardening.

platform/mac-wk1/TestExpectations:

12:34 PM Changeset in webkit [216605] by Ryan Haddad

2 edits in branches/safari-603-branch/LayoutTests

Unreviewed test gardening.

platform/ios-simulator/TestExpectations:

12:29 PM Changeset in webkit [216604] by Matt Lewis

2 edits in trunk/LayoutTests

Marked tiled-drawing/scrolling/fast-scroll-select-latched-mainframe.html as flaky.
https://bugs.webkit.org/show_bug.cgi?id=171935

Unreviewed test gardening.

platform/mac-wk2/TestExpectations:

12:24 PM Changeset in webkit [216603] by mrajca@apple.com

2 edits in trunk/Source/WebCore

DumpRenderTree crashed in com.apple.WebCore: std::optional<WTF::MediaTime>::operator-> + 71 :: CRASHING TEST: fullscreen/video-controls-timeline.html
https://bugs.webkit.org/show_bug.cgi?id=171932

Reviewed by Eric Carlson.

Explicitly initialize m_playbackWithoutUserGesture to "None".

html/HTMLMediaElement.h:

11:53 AM Changeset in webkit [216602] by commit-queue@webkit.org

2 edits in trunk/Source/WebInspectorUI

Web Inspector: Copy to clipboard fails via InspectorFrontendHostStub
https://bugs.webkit.org/show_bug.cgi?id=171907

Patch by Ross Kirsling <Ross Kirsling> on 2017-05-10
Reviewed by Joseph Pecoraro.

UserInterface/Base/InspectorFrontendHostStub.js:

(WebInspector.InspectorFrontendHostStub.prototype.copyText):
Actually make a text selection before attempting to copy to clipboard.

11:43 AM Changeset in webkit [216601] by matthew_hanson@apple.com

11 edits
7 adds in branches/safari-603-branch

Cherry-pick r216352. rdar://problem/32057098

11:43 AM Changeset in webkit [216600] by matthew_hanson@apple.com

16 edits
6 adds in branches/safari-603-branch

Cherry-pick r211379. rdar://problem/32057099

11:30 AM Changeset in webkit [216599] by aestes@apple.com

8 edits
2 adds in trunk

Keyboard input suppression should extend to subframes
https://bugs.webkit.org/show_bug.cgi?id=171880
<rdar://problem/31201793>

Reviewed by Ryosuke Niwa.

Source/WebCore:

Test: http/tests/navigation/keyboard-events-during-provisional-subframe-navigation.html

dom/EventDispatcher.cpp:

(WebCore::shouldSuppressEventDispatchInDOM): Changed to call shouldSuppressKeyboardInput()
on the main frame's loader.

editing/Editor.cpp:

(WebCore::Editor::shouldInsertText): Ditto.

LayoutTests:

http/tests/navigation/keyboard-events-during-provisional-navigation-expected.txt:
http/tests/navigation/keyboard-events-during-provisional-navigation.html:
http/tests/navigation/keyboard-events-during-provisional-subframe-navigation-expected.txt: Copied from LayoutTests/http/tests/navigation/keyboard-events-during-provisional-navigation-expected.txt.
http/tests/navigation/keyboard-events-during-provisional-subframe-navigation.html: Copied from LayoutTests/http/tests/navigation/keyboard-events-during-provisional-navigation.html.
http/tests/navigation/resources/keyboard-events-after-navigation.html:
http/tests/navigation/resources/keyboard-events-test.js:

(runTest):
(waitForProvisionalNavigation.xhr.onreadystatechange):
(waitForProvisionalNavigation):

11:22 AM Changeset in webkit [216598] by jfbastien@apple.com

3 edits
1 add in trunk/JSTests

WebAssemby: builder doesn't do Memory section maximum correctly
https://bugs.webkit.org/show_bug.cgi?id=171931

Reviewed by Keith Miller.

wasm/Builder.js:

(export.default.Builder.prototype._registerSectionBuilders.const.section.in.WASM.description.section.switch.section.case.string_appeared_here.this.section):

wasm/Builder_WebAssemblyBinary.js:

(const.emitters.Memory):

wasm/function-tests/memory-grow-invalid.js: Added.

11:15 AM Changeset in webkit [216597] by jfbastien@apple.com

19 edits
4 copies
3 adds in trunk

WebAssembly: support name section
JSTests:

https://bugs.webkit.org/show_bug.cgi?id=171263

Reviewed by Keith Miller.

wasm/function-tests/nameSection.js: Added.

(const.compile):

wasm/function-tests/nameSection.wasm: Added.
wasm/function-tests/stack-trace.js: Update format

Source/JavaScriptCore:

https://bugs.webkit.org/show_bug.cgi?id=171263

Reviewed by Keith Miller.

The name section is an optional custom section in the WebAssembly
spec. At least when debugging, developers expect to be able to use
this section to obtain intelligible stack traces, otherwise we
just number the wasm functions which is somewhat painful.

This patch parses this section, dropping its content eagerly on
error, and if there is a name section then backtraces use their
value instead of numbers. Otherwise we stick to numbers as before.

Note that the format of name sections changed in mid-February:

https://github.com/WebAssembly/design/pull/984

And binaryen was only updated in early March:

https://github.com/WebAssembly/binaryen/pull/933

CMakeLists.txt:
JavaScriptCore.xcodeproj/project.pbxproj:
interpreter/Interpreter.cpp:

(JSC::GetStackTraceFunctor::operator()):

interpreter/StackVisitor.cpp:

(JSC::StackVisitor::readNonInlinedFrame):
(JSC::StackVisitor::Frame::functionName):

interpreter/StackVisitor.h:

(JSC::StackVisitor::Frame::wasmFunctionIndexOrName):

runtime/StackFrame.cpp:

(JSC::StackFrame::functionName):

runtime/StackFrame.h:

(JSC::StackFrame::StackFrame):
(JSC::StackFrame::wasm):

wasm/WasmBBQPlanInlines.h:

(JSC::Wasm::BBQPlan::initializeCallees):

wasm/WasmCallee.cpp:

(JSC::Wasm::Callee::Callee):

wasm/WasmCallee.h:

(JSC::Wasm::Callee::create):
(JSC::Wasm::Callee::indexOrName):

wasm/WasmFormat.cpp:

(JSC::Wasm::makeString):

wasm/WasmFormat.h:

(JSC::Wasm::isValidExternalKind):
(JSC::Wasm::isValidNameType):
(JSC::Wasm::NameSection::get):

wasm/WasmIndexOrName.cpp: Copied from Source/JavaScriptCore/wasm/WasmCallee.cpp.

(JSC::Wasm::IndexOrName::IndexOrName):
(JSC::Wasm::makeString):

wasm/WasmIndexOrName.h: Copied from Source/JavaScriptCore/wasm/WasmFormat.cpp.
wasm/WasmModuleInformation.h:
wasm/WasmModuleParser.cpp:
wasm/WasmName.h: Copied from Source/JavaScriptCore/wasm/WasmCallee.cpp.
wasm/WasmNameSectionParser.cpp: Added.
wasm/WasmNameSectionParser.h: Copied from Source/JavaScriptCore/wasm/WasmCallee.cpp.

(JSC::Wasm::NameSectionParser::NameSectionParser):

wasm/WasmOMGPlan.cpp:

(JSC::Wasm::OMGPlan::work):

wasm/WasmParser.h:

(JSC::Wasm::Parser<SuccessType>::consumeUTF8String):

10:30 AM Changeset in webkit [216596] by Matt Lewis

26 edits
2 deletes in trunk

Unreviewed, rolling out r216563.

Revision caused 2 api failures

Reverted changeset:

"[MediaStream] deviceId constraint doesn't work with
getUserMedia"
https://bugs.webkit.org/show_bug.cgi?id=171877
http://trac.webkit.org/changeset/216563

10:29 AM Changeset in webkit [216595] by jmarcell@apple.com

3 edits in branches/safari-603-branch/Source/WebCore

Cherry-pick r215102. rdar://problem/32057110

10:16 AM Changeset in webkit [216594] by Matt Lewis

3 edits in trunk/LayoutTests

Marked imported/w3c/web-platform-tests/webrtc/RTCPeerConnection-idl.html as flaky.
https://bugs.webkit.org/show_bug.cgi?id=171930

Unreviewed test gardening.

platform/ios-wk2/TestExpectations:
platform/mac-wk2/TestExpectations:

10:00 AM Changeset in webkit [216593] by fpizlo@apple.com

3 edits
3 adds in trunk

Null pointer dereference in WTF::RefPtr<WTF::StringImpl>::operator!() under slow_path_get_direct_pname
https://bugs.webkit.org/show_bug.cgi?id=171801

Reviewed by Michael Saboff.

JSTests:

These tests used to crash. The prefix and postfix tests cover different paths, except
postfix-ignored goes down the same path as prefix due to an optimization.

stress/for-in-postfix-ignored-index.js: Added.

(foo):

stress/for-in-postfix-index.js: Added.

(foo):

stress/for-in-prefix-index.js: Added.

(foo):

Source/JavaScriptCore:

This was a goofy oversight. The for-in optimization relies on the bytecode generator
to detect when the loop's index variable gets mutated. We forgot to have the hooks for
detecting this in prefix and postfix operations (++i and i++).

bytecompiler/NodesCodegen.cpp:

(JSC::PostfixNode::emitResolve):
(JSC::PrefixNode::emitResolve):

9:57 AM Changeset in webkit [216592] by commit-queue@webkit.org

5 edits in trunk/Source/WebCore

Refactor ScrollingCoordinator::setSynchronousScrollingReasons to accept a FrameView
https://bugs.webkit.org/show_bug.cgi?id=171923

Patch by Frederic Wang <fwang@igalia.com> on 2017-05-10
Reviewed by Simon Fraser.

Currently ScrollingCoordinator::setSynchronousScrollingReasons implementations assumes
SynchronousScrollingReasons apply to the main frame. This commit allows to specify
a FrameView in order to prepare support for fast scrolling of frames.

No new tests, no behavior changes.

page/scrolling/AsyncScrollingCoordinator.cpp:

(WebCore::AsyncScrollingCoordinator::setSynchronousScrollingReasons): Use the FrameView to
find the state node.
(WebCore::AsyncScrollingCoordinator::updateScrollLayerPosition): Rename this function
updateMainFrameScrollLayerPosition and use the specified FrameView.

page/scrolling/AsyncScrollingCoordinator.h: Add FrameView parameter.
page/scrolling/ScrollingCoordinator.cpp:

(WebCore::ScrollingCoordinator::updateSynchronousScrollingReasons): Remove the const since
AsyncScrollingCoordinator uses scrollLayerForFrameView. Pass the frameView to
setSynchronousScrollingReasons.

page/scrolling/ScrollingCoordinator.h:

(WebCore::ScrollingCoordinator::setSynchronousScrollingReasons): Add FrameView parameter.

9:50 AM Changeset in webkit [216591] by Antti Koivisto

6 edits
2 adds in trunk

REGRESSION (r207372) Visibility property is not inherited when used in an animation
https://bugs.webkit.org/show_bug.cgi?id=171883
<rdar://problem/32086550>

Reviewed by Simon Fraser.

Source/WebCore:

This patch fixes the problem by tracking that the renderer has initial animated style and inheriting
it to descendants during next style resolution even if it doesn't change.

Test: animations/animation-initial-inheritance.html

rendering/RenderElement.cpp:

(WebCore::RenderElement::RenderElement):

rendering/RenderElement.h:

(WebCore::RenderElement::hasInitialAnimatedStyle):
(WebCore::RenderElement::setHasInitialAnimatedStyle):

style/RenderTreeUpdater.cpp:

(WebCore::RenderTreeUpdater::createRenderer):

Set a bit on renderer indicating it has initial animated style.

style/StyleTreeResolver.cpp:

(WebCore::Style::TreeResolver::createAnimatedElementUpdate):

Return at least 'Inherit' for style change when updating renderer with initial animated style.

LayoutTests:

animations/animation-initial-inheritance-expected.html: Added.
animations/animation-initial-inheritance.html: Added.

9:44 AM Changeset in webkit [216590] by matthew_hanson@apple.com

2 edits in branches/safari-603-branch/Source/WebCore

Remove inadvertant change to ScrollView.h that was included in r216589.

Unreviewed build fix.

platform/ScrollView.h:

(WebCore::ScrollView::children):

9:34 AM Changeset in webkit [216589] by matthew_hanson@apple.com

14 edits
3 adds in branches/safari-603-branch

Cherry-pick r216279. rdar://problem/31967829

9:29 AM Changeset in webkit [216588] by pvollan@apple.com

3 edits in trunk/LayoutTests

LayoutTest http/tests/media/track-in-band-hls-metadata-crash.html is a flaky timeout
https://bugs.webkit.org/show_bug.cgi?id=167749

Reviewed by Eric Carlson.

This is a speculative fix of the test. I have not been able to reproduce the timeout.
When the test times out, the 'addtrack' event is never received. In case the event
was dispatched before we added the event listener, the event listener is added before
the video source is set. In case the test will continue to time out, a couple of
error event callbacks have been added to get more information. Also, video playback
will begin when the 'canplaythrough' event is received.

http/tests/media/track-in-band-hls-metadata-crash-expected.txt:
http/tests/media/track-in-band-hls-metadata-crash.html:

9:08 AM Changeset in webkit [216587] by matthew_hanson@apple.com

3 edits in branches/safari-603-branch/Source/WebCore

Cherry-pick r216131. rdar://problem/31967895

9:06 AM Changeset in webkit [216586] by mmaxfield@apple.com

4 edits in trunk/Source/WebCore

Tiny cleanup in Font::DerivedFonts
https://bugs.webkit.org/show_bug.cgi?id=171893

Reviewed by Jon Lee.

This variable was written to but never read.

No new tests because there is no behavior change.

css/CSSFontFaceSource.cpp:

(WebCore::CSSFontFaceSource::font):

platform/graphics/Font.cpp:

(WebCore::Font::verticalRightOrientationFont):
(WebCore::Font::uprightOrientationFont):
(WebCore::Font::smallCapsFont):
(WebCore::Font::noSynthesizableFeaturesFont):
(WebCore::Font::emphasisMarkFont):
(WebCore::Font::brokenIdeographFont):
(WebCore::Font::DerivedFonts::~DerivedFonts): Deleted.

platform/graphics/Font.h:

(WebCore::Font::DerivedFonts::DerivedFonts): Deleted.

7:50 AM Changeset in webkit [216585] by Michael Catanzaro

4 edits in trunk

Remove user agent quirk for Slack
https://bugs.webkit.org/show_bug.cgi?id=171869

Reviewed by Carlos Garcia Campos.

Source/WebCore:

The user agent quirk for Slack does not seem to be necessary anymore. I am able to use Slack
without difficulty using our default user agent.

platform/UserAgentQuirks.cpp:

(WebCore::urlRequiresChromeBrowser):

Tools:

Remove the corresponding test.

TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:

(TestWebKitAPI::TEST):

7:46 AM Changeset in webkit [216584] by Claudio Saavedra

2 edits in trunk/Source/WebKit2

[GTK] HTTP authentication dialog should focus on first input field
https://bugs.webkit.org/show_bug.cgi?id=151349

Reviewed by Michael Catanzaro.

Setting focus on a widget before it's mapped does nothing. Move
the call to the right place.

UIProcess/API/gtk/WebKitAuthenticationDialog.cpp:

(webkitAuthenticationDialogInitialize):
(webkitAuthenticationDialogMap):

7:31 AM Changeset in webkit [216583] by commit-queue@webkit.org

2 edits in trunk

[Win] Specify source file type when preprocessing IDL files
https://bugs.webkit.org/show_bug.cgi?id=171864

Patch by Don Olmstead <don.olmstead@am.sony.com> on 2017-05-10
Reviewed by Alex Christensen.

Source/cmake/OptionsCommon.cmake:

7:26 AM Changeset in webkit [216582] by Michael Catanzaro

5 edits in trunk/Source

[GTK] -Wmissing-field-initializers triggered by RemoteInspectorServer.cpp:128
https://bugs.webkit.org/show_bug.cgi?id=171273

Reviewed by Carlos Garcia Campos.

Source/JavaScriptCore:

inspector/remote/glib/RemoteInspectorGlib.cpp:
inspector/remote/glib/RemoteInspectorServer.cpp:

Source/WebKit2:

UIProcess/glib/RemoteInspectorClient.cpp:

(WebKit::RemoteInspectorClient::RemoteInspectorClient):

7:05 AM Changeset in webkit [216581] by hyungwook.lee@navercorp.com

2 edits in trunk/Source/WebCore

[GTK] Fix compile warnings in CryptoKeyECGCrypt.cpp
https://bugs.webkit.org/show_bug.cgi?id=171851

Reviewed by Alex Christensen.

crypto/gcrypt/CryptoKeyECGCrypt.cpp:

(WebCore::curveSize):
(WebCore::curveName):
(WebCore::uncompressedPointSizeForCurve):
(WebCore::uncompressedFieldElementSizeForCurve):

7:01 AM Changeset in webkit [216580] by commit-queue@webkit.org

3 edits
4 deletes in trunk

Remove some last remnants of the EFL port
https://bugs.webkit.org/show_bug.cgi?id=171922

Patch by Adrian Perez de Castro <Adrian Perez de Castro> on 2017-05-10
Reviewed by Antonio Gomes.

The EFL port is no more.

Source/PlatformEfl.cmake: Removed.

Source/JavaScriptCore:

PlatformEfl.cmake: Removed.
shell/PlatformEfl.cmake: Removed.

Source/WTF:

wtf/PlatformEfl.cmake: Removed.

5:35 AM Changeset in webkit [216579] by commit-queue@webkit.org

399 edits
2 adds
9 deletes in trunk

Unreviewed, rolling out r216578.
https://bugs.webkit.org/show_bug.cgi?id=171920

Broke the GTK+ build with Wayland enabled (Requested by KaL on
#webkit).

Reverted changeset:

"[GTK] Bump GTK+ and its dependencies in jhbuild"
https://bugs.webkit.org/show_bug.cgi?id=171918
http://trac.webkit.org/changeset/216578

4:53 AM Changeset in webkit [216578] by Carlos Garcia Campos

399 edits
9 adds
2 deletes in trunk

[GTK] Bump GTK+ and its dependencies in jhbuild
https://bugs.webkit.org/show_bug.cgi?id=171918

Reviewed by Carlos Alberto Lopez Perez.

Tools:

WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:

(WTR::initializeGtkSettings):

gtk/jhbuild.modules:
gtk/patches/gtk+-configure-fix-detecting-CUPS-2.x.patch: Removed.
gtk/patches/librsvg-2.36.1-bump-up-config.guess-to-support-aarch64.patch: Removed.

LayoutTests:

Rebaseline tests for new GTK+ versin.

platform/gtk/css1/box_properties/acid_test-expected.txt:
platform/gtk/css2.1/20110323/replaced-elements-001-expected.png:
platform/gtk/css2.1/20110323/replaced-elements-001-expected.txt:
platform/gtk/css2.1/t09-c5526c-display-00-e-expected.png:
platform/gtk/css2.1/t09-c5526c-display-00-e-expected.txt:
platform/gtk/css3/flexbox/button-expected.png:
platform/gtk/css3/flexbox/button-expected.txt:
platform/gtk/css3/selectors3/html/css3-modsel-161-expected.png:
platform/gtk/css3/selectors3/html/css3-modsel-161-expected.txt:
platform/gtk/css3/selectors3/html/css3-modsel-19b-expected.png:
platform/gtk/css3/selectors3/html/css3-modsel-19b-expected.txt:
platform/gtk/css3/selectors3/html/css3-modsel-23-expected.png:
platform/gtk/css3/selectors3/html/css3-modsel-23-expected.txt:
platform/gtk/css3/selectors3/html/css3-modsel-25-expected.png:
platform/gtk/css3/selectors3/html/css3-modsel-25-expected.txt:
platform/gtk/css3/selectors3/html/css3-modsel-69-expected.png:
platform/gtk/css3/selectors3/html/css3-modsel-69-expected.txt:
platform/gtk/css3/selectors3/html/css3-modsel-70-expected.png:
platform/gtk/css3/selectors3/html/css3-modsel-70-expected.txt:
platform/gtk/css3/selectors3/xhtml/css3-modsel-161-expected.png:
platform/gtk/css3/selectors3/xhtml/css3-modsel-161-expected.txt:
platform/gtk/css3/selectors3/xhtml/css3-modsel-19b-expected.png:
platform/gtk/css3/selectors3/xhtml/css3-modsel-19b-expected.txt:
platform/gtk/css3/selectors3/xhtml/css3-modsel-23-expected.png:
platform/gtk/css3/selectors3/xhtml/css3-modsel-23-expected.txt:
platform/gtk/css3/selectors3/xhtml/css3-modsel-25-expected.png:
platform/gtk/css3/selectors3/xhtml/css3-modsel-25-expected.txt:
platform/gtk/css3/selectors3/xhtml/css3-modsel-69-expected.png:
platform/gtk/css3/selectors3/xhtml/css3-modsel-69-expected.txt:
platform/gtk/css3/selectors3/xhtml/css3-modsel-70-expected.png:
platform/gtk/css3/selectors3/xhtml/css3-modsel-70-expected.txt:
platform/gtk/css3/selectors3/xml/css3-modsel-161-expected.png:
platform/gtk/css3/selectors3/xml/css3-modsel-161-expected.txt:
platform/gtk/css3/selectors3/xml/css3-modsel-19b-expected.png:
platform/gtk/css3/selectors3/xml/css3-modsel-19b-expected.txt:
platform/gtk/css3/selectors3/xml/css3-modsel-23-expected.png:
platform/gtk/css3/selectors3/xml/css3-modsel-23-expected.txt:
platform/gtk/css3/selectors3/xml/css3-modsel-25-expected.png:
platform/gtk/css3/selectors3/xml/css3-modsel-25-expected.txt:
platform/gtk/css3/selectors3/xml/css3-modsel-69-expected.png:
platform/gtk/css3/selectors3/xml/css3-modsel-69-expected.txt:
platform/gtk/css3/selectors3/xml/css3-modsel-70-expected.png:
platform/gtk/css3/selectors3/xml/css3-modsel-70-expected.txt:
platform/gtk/editing/pasteboard/4641033-expected.png:
platform/gtk/editing/pasteboard/4641033-expected.txt:
platform/gtk/editing/pasteboard/4944770-1-expected.png:
platform/gtk/editing/pasteboard/4944770-1-expected.txt:
platform/gtk/editing/pasteboard/4944770-2-expected.png:
platform/gtk/editing/pasteboard/4944770-2-expected.txt:
platform/gtk/editing/selection/3690703-2-expected.png:
platform/gtk/editing/selection/3690703-2-expected.txt:
platform/gtk/editing/selection/3690703-expected.png:
platform/gtk/editing/selection/3690703-expected.txt:
platform/gtk/editing/selection/3690719-expected.png:
platform/gtk/editing/selection/3690719-expected.txt:
platform/gtk/editing/selection/4397952-expected.png:
platform/gtk/editing/selection/4397952-expected.txt:
platform/gtk/editing/selection/5240265-expected.png:
platform/gtk/editing/selection/5240265-expected.txt:
platform/gtk/editing/selection/caret-before-select-expected.png:
platform/gtk/editing/selection/caret-before-select-expected.txt:
platform/gtk/editing/selection/replaced-boundaries-3-expected.png:
platform/gtk/editing/selection/replaced-boundaries-3-expected.txt:
platform/gtk/editing/selection/select-box-expected.png:
platform/gtk/editing/selection/select-box-expected.txt:
platform/gtk/editing/selection/select-element-paragraph-boundary-expected.png:
platform/gtk/editing/selection/select-element-paragraph-boundary-expected.txt:
platform/gtk/editing/selection/selection-button-text-expected.png:
platform/gtk/editing/selection/selection-button-text-expected.txt:
platform/gtk/fast/block/basic/011-expected.png:
platform/gtk/fast/block/basic/011-expected.txt:
platform/gtk/fast/block/float/float-avoidance-expected.png:
platform/gtk/fast/block/float/float-avoidance-expected.txt:
platform/gtk/fast/block/margin-collapse/103-expected.png:
platform/gtk/fast/block/margin-collapse/103-expected.txt:
platform/gtk/fast/block/positioning/inline-block-relposition-expected.png:
platform/gtk/fast/block/positioning/inline-block-relposition-expected.txt:
platform/gtk/fast/box-sizing/percentage-height-expected.png:
platform/gtk/fast/box-sizing/percentage-height-expected.txt:
platform/gtk/fast/css/continuationCrash-expected.png:
platform/gtk/fast/css/continuationCrash-expected.txt:
platform/gtk/fast/css/focus-ring-exists-for-search-field-expected.png:
platform/gtk/fast/css/focus-ring-exists-for-search-field-expected.txt:
platform/gtk/fast/css/input-search-padding-expected.png:
platform/gtk/fast/css/input-search-padding-expected.txt:
platform/gtk/fast/css/margin-top-bottom-dynamic-expected.png:
platform/gtk/fast/css/margin-top-bottom-dynamic-expected.txt:
platform/gtk/fast/css/non-standard-checkbox-size-expected.png:
platform/gtk/fast/css/non-standard-checkbox-size-expected.txt:
platform/gtk/fast/css/rtl-ordering-expected.png:
platform/gtk/fast/css/rtl-ordering-expected.txt:
platform/gtk/fast/css/text-input-with-webkit-border-radius-expected.png:
platform/gtk/fast/css/text-input-with-webkit-border-radius-expected.txt:
platform/gtk/fast/css/text-overflow-input-expected.png:
platform/gtk/fast/css/text-overflow-input-expected.txt:
platform/gtk/fast/css/text-transform-select-expected.png:
platform/gtk/fast/css/text-transform-select-expected.txt:
platform/gtk/fast/dom/HTMLInputElement/input-slider-update-expected.png:
platform/gtk/fast/dom/HTMLInputElement/input-slider-update-expected.txt:
platform/gtk/fast/dom/HTMLProgressElement/indeterminate-progress-001-expected.txt:
platform/gtk/fast/dom/HTMLProgressElement/native-progress-bar-expected.png:
platform/gtk/fast/dom/HTMLProgressElement/native-progress-bar-expected.txt:
platform/gtk/fast/dom/HTMLProgressElement/progress-bar-value-pseudo-element-expected.png:
platform/gtk/fast/dom/HTMLProgressElement/progress-bar-value-pseudo-element-expected.txt:
platform/gtk/fast/dom/HTMLProgressElement/progress-element-expected.png:
platform/gtk/fast/dom/HTMLProgressElement/progress-element-expected.txt:
platform/gtk/fast/dom/HTMLTableColElement/resize-table-using-col-width-expected.png:
platform/gtk/fast/dom/HTMLTableColElement/resize-table-using-col-width-expected.txt:
platform/gtk/fast/dom/HTMLTextAreaElement/reset-textarea-expected.png:
platform/gtk/fast/dom/HTMLTextAreaElement/reset-textarea-expected.txt:
platform/gtk/fast/dynamic/positioned-movement-with-positioned-children-expected.txt:
platform/gtk/fast/forms/001-expected.png:
platform/gtk/fast/forms/001-expected.txt:
platform/gtk/fast/forms/003-expected.png:
platform/gtk/fast/forms/003-expected.txt:
platform/gtk/fast/forms/004-expected.png:
platform/gtk/fast/forms/004-expected.txt:
platform/gtk/fast/forms/basic-buttons-expected.png:
platform/gtk/fast/forms/basic-buttons-expected.txt:
platform/gtk/fast/forms/basic-inputs-expected.png:
platform/gtk/fast/forms/basic-inputs-expected.txt:
platform/gtk/fast/forms/basic-selects-expected.png:
platform/gtk/fast/forms/basic-selects-expected.txt:
platform/gtk/fast/forms/blankbuttons-expected.png:
platform/gtk/fast/forms/blankbuttons-expected.txt:
platform/gtk/fast/forms/box-shadow-override-expected.png:
platform/gtk/fast/forms/box-shadow-override-expected.txt:
platform/gtk/fast/forms/button-align-expected.png:
platform/gtk/fast/forms/button-align-expected.txt:
platform/gtk/fast/forms/button-cannot-be-nested-expected.png:
platform/gtk/fast/forms/button-cannot-be-nested-expected.txt:
platform/gtk/fast/forms/button-default-title-expected.png:
platform/gtk/fast/forms/button-default-title-expected.txt:
platform/gtk/fast/forms/button-generated-content-expected.png:
platform/gtk/fast/forms/button-generated-content-expected.txt:
platform/gtk/fast/forms/button-inner-block-reuse-expected.png:
platform/gtk/fast/forms/button-inner-block-reuse-expected.txt:
platform/gtk/fast/forms/button-positioned-expected.png:
platform/gtk/fast/forms/button-positioned-expected.txt:
platform/gtk/fast/forms/button-sizes-expected.png:
platform/gtk/fast/forms/button-sizes-expected.txt:
platform/gtk/fast/forms/button-style-color-expected.png:
platform/gtk/fast/forms/button-style-color-expected.txt:
platform/gtk/fast/forms/button-table-styles-expected.png:
platform/gtk/fast/forms/button-table-styles-expected.txt:
platform/gtk/fast/forms/button-text-transform-expected.png:
platform/gtk/fast/forms/button-text-transform-expected.txt:
platform/gtk/fast/forms/button-white-space-expected.png:
platform/gtk/fast/forms/button-white-space-expected.txt:
platform/gtk/fast/forms/control-clip-expected.png:
platform/gtk/fast/forms/control-clip-expected.txt:
platform/gtk/fast/forms/control-clip-overflow-expected.png:
platform/gtk/fast/forms/control-clip-overflow-expected.txt:
platform/gtk/fast/forms/control-restrict-line-height-expected.png:
platform/gtk/fast/forms/control-restrict-line-height-expected.txt:
platform/gtk/fast/forms/disabled-select-change-index-expected.png:
platform/gtk/fast/forms/disabled-select-change-index-expected.txt:
platform/gtk/fast/forms/file/file-input-direction-expected.png:
platform/gtk/fast/forms/file/file-input-direction-expected.txt:
platform/gtk/fast/forms/file/file-input-disabled-expected.png:
platform/gtk/fast/forms/file/file-input-disabled-expected.txt:
platform/gtk/fast/forms/form-element-geometry-expected.png:
platform/gtk/fast/forms/form-element-geometry-expected.txt:
platform/gtk/fast/forms/formmove-expected.png:
platform/gtk/fast/forms/formmove-expected.txt:
platform/gtk/fast/forms/formmove2-expected.png:
platform/gtk/fast/forms/formmove2-expected.txt:
platform/gtk/fast/forms/formmove3-expected.png:
platform/gtk/fast/forms/formmove3-expected.txt:
platform/gtk/fast/forms/indeterminate-expected.png:
platform/gtk/fast/forms/indeterminate-expected.txt:
platform/gtk/fast/forms/input-appearance-height-expected.png:
platform/gtk/fast/forms/input-appearance-height-expected.txt:
platform/gtk/fast/forms/input-button-sizes-expected.png:
platform/gtk/fast/forms/input-button-sizes-expected.txt:
platform/gtk/fast/forms/input-first-letter-expected.png:
platform/gtk/fast/forms/input-first-letter-expected.txt:
platform/gtk/fast/forms/input-number-click-expected.txt: Added.
platform/gtk/fast/forms/input-value-expected.png:
platform/gtk/fast/forms/input-value-expected.txt:
platform/gtk/fast/forms/menulist-deselect-update-expected.png:
platform/gtk/fast/forms/menulist-deselect-update-expected.txt:
platform/gtk/fast/forms/menulist-narrow-width-expected.png:
platform/gtk/fast/forms/menulist-narrow-width-expected.txt:
platform/gtk/fast/forms/menulist-no-overflow-expected.png:
platform/gtk/fast/forms/menulist-no-overflow-expected.txt:
platform/gtk/fast/forms/menulist-restrict-line-height-expected.png:
platform/gtk/fast/forms/menulist-restrict-line-height-expected.txt:
platform/gtk/fast/forms/menulist-separator-painting-expected.png:
platform/gtk/fast/forms/menulist-separator-painting-expected.txt:
platform/gtk/fast/forms/menulist-style-color-expected.png:
platform/gtk/fast/forms/menulist-style-color-expected.txt:
platform/gtk/fast/forms/menulist-width-change-expected.png:
platform/gtk/fast/forms/menulist-width-change-expected.txt:
platform/gtk/fast/forms/number/number-appearance-rtl-expected.png:
platform/gtk/fast/forms/number/number-appearance-rtl-expected.txt:
platform/gtk/fast/forms/number/number-appearance-spinbutton-disabled-readonly-expected.png:
platform/gtk/fast/forms/number/number-appearance-spinbutton-disabled-readonly-expected.txt:
platform/gtk/fast/forms/number/number-appearance-spinbutton-layer-expected.png:
platform/gtk/fast/forms/number/number-appearance-spinbutton-layer-expected.txt:
platform/gtk/fast/forms/number/number-spinbutton-change-and-input-events-expected.txt: Added.
platform/gtk/fast/forms/number/number-spinbutton-click-in-iframe-expected.txt: Added.
platform/gtk/fast/forms/number/number-spinbutton-gets-disabled-or-readonly-expected.txt: Added.
platform/gtk/fast/forms/option-script-expected.png:
platform/gtk/fast/forms/option-script-expected.txt:
platform/gtk/fast/forms/option-strip-whitespace-expected.png:
platform/gtk/fast/forms/option-strip-whitespace-expected.txt:
platform/gtk/fast/forms/option-text-clip-expected.png:
platform/gtk/fast/forms/option-text-clip-expected.txt:
platform/gtk/fast/forms/placeholder-position-expected.png:
platform/gtk/fast/forms/placeholder-position-expected.txt:
platform/gtk/fast/forms/placeholder-pseudo-style-expected.png:
platform/gtk/fast/forms/placeholder-pseudo-style-expected.txt:
platform/gtk/fast/forms/range/input-appearance-range-expected.png:
platform/gtk/fast/forms/range/input-appearance-range-expected.txt:
platform/gtk/fast/forms/range/slider-padding-expected.png:
platform/gtk/fast/forms/range/slider-padding-expected.txt:
platform/gtk/fast/forms/range/slider-thumb-shared-style-expected.png:
platform/gtk/fast/forms/range/slider-thumb-shared-style-expected.txt:
platform/gtk/fast/forms/range/slider-transformed-expected.txt:
platform/gtk/fast/forms/range/thumbslider-no-parent-slider-expected.png:
platform/gtk/fast/forms/range/thumbslider-no-parent-slider-expected.txt:
platform/gtk/fast/forms/search-cancel-button-style-sharing-expected.png:
platform/gtk/fast/forms/search-cancel-button-style-sharing-expected.txt:
platform/gtk/fast/forms/search-display-none-cancel-button-expected.png:
platform/gtk/fast/forms/search-display-none-cancel-button-expected.txt:
platform/gtk/fast/forms/search-input-rtl-expected.png:
platform/gtk/fast/forms/search-input-rtl-expected.txt: Added.
platform/gtk/fast/forms/search-rtl-expected.png:
platform/gtk/fast/forms/search-rtl-expected.txt:
platform/gtk/fast/forms/search-styled-expected.png:
platform/gtk/fast/forms/search-styled-expected.txt:
platform/gtk/fast/forms/search/search-size-with-decorations-expected.png:
platform/gtk/fast/forms/search/search-size-with-decorations-expected.txt:
platform/gtk/fast/forms/searchfield-heights-expected.png:
platform/gtk/fast/forms/searchfield-heights-expected.txt:
platform/gtk/fast/forms/select-align-expected.png:
platform/gtk/fast/forms/select-align-expected.txt:
platform/gtk/fast/forms/select-background-none-expected.png:
platform/gtk/fast/forms/select-background-none-expected.txt:
platform/gtk/fast/forms/select-baseline-expected.png:
platform/gtk/fast/forms/select-baseline-expected.txt:
platform/gtk/fast/forms/select-change-listbox-to-popup-expected.png:
platform/gtk/fast/forms/select-change-listbox-to-popup-expected.txt:
platform/gtk/fast/forms/select-dirty-parent-pref-widths-expected.png:
platform/gtk/fast/forms/select-dirty-parent-pref-widths-expected.txt:
platform/gtk/fast/forms/select-disabled-appearance-expected.png:
platform/gtk/fast/forms/select-disabled-appearance-expected.txt:
platform/gtk/fast/forms/select-element-focus-ring-expected.png: Added.
platform/gtk/fast/forms/select-element-focus-ring-expected.txt:
platform/gtk/fast/forms/select-initial-position-expected.png:
platform/gtk/fast/forms/select-initial-position-expected.txt:
platform/gtk/fast/forms/select-non-native-rendering-direction-expected.png: Added.
platform/gtk/fast/forms/select-non-native-rendering-direction-expected.txt: Added.
platform/gtk/fast/forms/select-selected-expected.png:
platform/gtk/fast/forms/select-selected-expected.txt:
platform/gtk/fast/forms/select-style-expected.png:
platform/gtk/fast/forms/select-style-expected.txt:
platform/gtk/fast/forms/select-visual-hebrew-expected.png:
platform/gtk/fast/forms/select-visual-hebrew-expected.txt:
platform/gtk/fast/forms/select-writing-direction-natural-expected.png:
platform/gtk/fast/forms/select-writing-direction-natural-expected.txt:
platform/gtk/fast/forms/select/optgroup-rendering-expected.png:
platform/gtk/fast/forms/select/optgroup-rendering-expected.txt:
platform/gtk/fast/forms/selectlist-minsize-expected.png:
platform/gtk/fast/forms/selectlist-minsize-expected.txt:
platform/gtk/fast/forms/stuff-on-my-optgroup-expected.png:
platform/gtk/fast/forms/stuff-on-my-optgroup-expected.txt:
platform/gtk/fast/forms/targeted-frame-submission-expected.png:
platform/gtk/fast/forms/targeted-frame-submission-expected.txt:
platform/gtk/fast/forms/validation-message-appearance-expected.png:
platform/gtk/fast/forms/validation-message-appearance-expected.txt:
platform/gtk/fast/html/details-replace-summary-child-expected.png:
platform/gtk/fast/html/details-replace-summary-child-expected.txt:
platform/gtk/fast/html/details-replace-text-expected.png:
platform/gtk/fast/html/details-replace-text-expected.txt:
platform/gtk/fast/html/keygen-expected.png:
platform/gtk/fast/html/keygen-expected.txt:
platform/gtk/fast/inline/positionedLifetime-expected.png:
platform/gtk/fast/inline/positionedLifetime-expected.txt:
platform/gtk/fast/invalid/014-expected.png:
platform/gtk/fast/invalid/014-expected.txt:
platform/gtk/fast/overflow/scroll-nested-positioned-layer-in-overflow-expected.png:
platform/gtk/fast/overflow/scroll-nested-positioned-layer-in-overflow-expected.txt:
platform/gtk/fast/overflow/scrollRevealButton-expected.png:
platform/gtk/fast/overflow/scrollRevealButton-expected.txt:
platform/gtk/fast/parser/bad-xml-slash-expected.png:
platform/gtk/fast/parser/bad-xml-slash-expected.txt:
platform/gtk/fast/parser/document-write-option-expected.png:
platform/gtk/fast/parser/document-write-option-expected.txt:
platform/gtk/fast/repaint/search-field-cancel-expected.png:
platform/gtk/fast/repaint/search-field-cancel-expected.txt:
platform/gtk/fast/repaint/slider-thumb-drag-release-expected.png:
platform/gtk/fast/repaint/slider-thumb-drag-release-expected.txt:
platform/gtk/fast/replaced/replaced-breaking-expected.png:
platform/gtk/fast/replaced/replaced-breaking-expected.txt:
platform/gtk/fast/replaced/replaced-breaking-mixture-expected.png:
platform/gtk/fast/replaced/replaced-breaking-mixture-expected.txt:
platform/gtk/fast/replaced/three-selects-break-expected.png:
platform/gtk/fast/replaced/three-selects-break-expected.txt:
platform/gtk/fast/replaced/width100percent-button-expected.png:
platform/gtk/fast/replaced/width100percent-button-expected.txt:
platform/gtk/fast/replaced/width100percent-menulist-expected.png:
platform/gtk/fast/replaced/width100percent-menulist-expected.txt:
platform/gtk/fast/replaced/width100percent-searchfield-expected.png:
platform/gtk/fast/replaced/width100percent-searchfield-expected.txt:
platform/gtk/fast/scrolling/overflow-scrollable-after-back-expected.txt: Added.
platform/gtk/fast/table/append-cells2-expected.png:
platform/gtk/fast/table/append-cells2-expected.txt:
platform/gtk/fast/table/remove-td-display-none-expected.png:
platform/gtk/fast/table/remove-td-display-none-expected.txt:
platform/gtk/fast/text/international/bidi-menulist-expected.png:
platform/gtk/fast/text/international/bidi-menulist-expected.txt:
platform/gtk/fast/text/international/hindi-spacing-expected.png:
platform/gtk/fast/text/international/hindi-spacing-expected.txt:
platform/gtk/fast/text/international/pop-up-button-text-alignment-and-direction-expected.png:
platform/gtk/fast/text/international/pop-up-button-text-alignment-and-direction-expected.txt:
platform/gtk/fast/text/textIteratorNilRenderer-expected.png:
platform/gtk/fast/text/textIteratorNilRenderer-expected.txt:
platform/gtk/fast/text/whitespace/normal-after-nowrap-breaking-expected.png:
platform/gtk/fast/text/whitespace/normal-after-nowrap-breaking-expected.txt:
platform/gtk/http/tests/navigation/javascriptlink-frames-expected.png:
platform/gtk/http/tests/navigation/javascriptlink-frames-expected.txt:
platform/gtk/svg/custom/foreign-object-skew-expected.png:
platform/gtk/svg/custom/foreign-object-skew-expected.txt:
platform/gtk/svg/custom/inline-svg-in-xhtml-expected.png:
platform/gtk/svg/custom/inline-svg-in-xhtml-expected.txt:
platform/gtk/tables/mozilla/bugs/bug1188-expected.png:
platform/gtk/tables/mozilla/bugs/bug1188-expected.txt:
platform/gtk/tables/mozilla/bugs/bug1318-expected.png:
platform/gtk/tables/mozilla/bugs/bug1318-expected.txt:
platform/gtk/tables/mozilla/bugs/bug138725-expected.png:
platform/gtk/tables/mozilla/bugs/bug138725-expected.txt:
platform/gtk/tables/mozilla/bugs/bug18359-expected.png:
platform/gtk/tables/mozilla/bugs/bug18359-expected.txt:
platform/gtk/tables/mozilla/bugs/bug2479-2-expected.png:
platform/gtk/tables/mozilla/bugs/bug2479-2-expected.txt:
platform/gtk/tables/mozilla/bugs/bug2479-3-expected.png:
platform/gtk/tables/mozilla/bugs/bug2479-3-expected.txt:
platform/gtk/tables/mozilla/bugs/bug2479-4-expected.txt:
platform/gtk/tables/mozilla/bugs/bug26178-expected.png:
platform/gtk/tables/mozilla/bugs/bug26178-expected.txt:
platform/gtk/tables/mozilla/bugs/bug28928-expected.png:
platform/gtk/tables/mozilla/bugs/bug28928-expected.txt:
platform/gtk/tables/mozilla/bugs/bug29326-expected.png:
platform/gtk/tables/mozilla/bugs/bug29326-expected.txt:
platform/gtk/tables/mozilla/bugs/bug33855-expected.png:
platform/gtk/tables/mozilla/bugs/bug33855-expected.txt:
platform/gtk/tables/mozilla/bugs/bug39209-expected.png:
platform/gtk/tables/mozilla/bugs/bug39209-expected.txt:
platform/gtk/tables/mozilla/bugs/bug4382-expected.png:
platform/gtk/tables/mozilla/bugs/bug4382-expected.txt:
platform/gtk/tables/mozilla/bugs/bug4429-expected.png:
platform/gtk/tables/mozilla/bugs/bug4429-expected.txt:
platform/gtk/tables/mozilla/bugs/bug44505-expected.png:
platform/gtk/tables/mozilla/bugs/bug44505-expected.txt:
platform/gtk/tables/mozilla/bugs/bug4527-expected.png:
platform/gtk/tables/mozilla/bugs/bug4527-expected.txt:
platform/gtk/tables/mozilla/bugs/bug46368-1-expected.png:
platform/gtk/tables/mozilla/bugs/bug46368-1-expected.txt:
platform/gtk/tables/mozilla/bugs/bug46368-2-expected.png:
platform/gtk/tables/mozilla/bugs/bug46368-2-expected.txt:
platform/gtk/tables/mozilla/bugs/bug51037-expected.png:
platform/gtk/tables/mozilla/bugs/bug51037-expected.txt:
platform/gtk/tables/mozilla/bugs/bug51727-expected.png:
platform/gtk/tables/mozilla/bugs/bug51727-expected.txt:
platform/gtk/tables/mozilla/bugs/bug52505-expected.png:
platform/gtk/tables/mozilla/bugs/bug52505-expected.txt:
platform/gtk/tables/mozilla/bugs/bug52506-expected.png:
platform/gtk/tables/mozilla/bugs/bug52506-expected.txt:
platform/gtk/tables/mozilla/bugs/bug60749-expected.png:
platform/gtk/tables/mozilla/bugs/bug60749-expected.txt:
platform/gtk/tables/mozilla/bugs/bug68912-expected.png:
platform/gtk/tables/mozilla/bugs/bug68912-expected.txt:
platform/gtk/tables/mozilla/bugs/bug7342-expected.png:
platform/gtk/tables/mozilla/bugs/bug7342-expected.txt:
platform/gtk/tables/mozilla/bugs/bug92647-2-expected.png:
platform/gtk/tables/mozilla/bugs/bug92647-2-expected.txt:
platform/gtk/tables/mozilla/bugs/bug96334-expected.png:
platform/gtk/tables/mozilla/bugs/bug96334-expected.txt:
platform/gtk/tables/mozilla/collapsing_borders/bug41262-4-expected.png:
platform/gtk/tables/mozilla/collapsing_borders/bug41262-4-expected.txt:
platform/gtk/tables/mozilla/core/margins-expected.png:
platform/gtk/tables/mozilla/core/margins-expected.txt:
platform/gtk/tables/mozilla/dom/tableDom-expected.png:
platform/gtk/tables/mozilla/dom/tableDom-expected.txt:
platform/gtk/tables/mozilla/other/move_row-expected.png:
platform/gtk/tables/mozilla/other/move_row-expected.txt:
platform/gtk/tables/mozilla_expected_failures/bugs/bug1725-expected.png:
platform/gtk/tables/mozilla_expected_failures/bugs/bug1725-expected.txt:
platform/gtk/tables/mozilla_expected_failures/bugs/bug2479-5-expected.png:
platform/gtk/tables/mozilla_expected_failures/bugs/bug2479-5-expected.txt:
platform/gtk/tables/mozilla_expected_failures/bugs/bug58402-2-expected.png:
platform/gtk/tables/mozilla_expected_failures/bugs/bug58402-2-expected.txt:
platform/gtk/tables/mozilla_expected_failures/collapsing_borders/bug41262-5-expected.png:
platform/gtk/tables/mozilla_expected_failures/collapsing_borders/bug41262-5-expected.txt:
platform/gtk/tables/mozilla_expected_failures/collapsing_borders/bug41262-6-expected.png:
platform/gtk/tables/mozilla_expected_failures/collapsing_borders/bug41262-6-expected.txt:
platform/gtk/tables/mozilla_expected_failures/core/captions1-expected.png:
platform/gtk/tables/mozilla_expected_failures/core/captions1-expected.txt:
platform/gtk/tables/mozilla_expected_failures/core/captions2-expected.png:
platform/gtk/tables/mozilla_expected_failures/core/captions2-expected.txt:
platform/gtk/transforms/2d/zoom-menulist-expected.png:
platform/gtk/transforms/2d/zoom-menulist-expected.txt:

3:04 AM Changeset in webkit [216577] by commit-queue@webkit.org

2 edits in trunk/Tools

[Win] Set CMake args in build-webkit
https://bugs.webkit.org/show_bug.cgi?id=171436

Patch by Don Olmstead <don.olmstead@am.sony.com> on 2017-05-10
Reviewed by Per Arne Vollan.

Scripts/build-webkit:

1:16 AM Changeset in webkit [216576] by commit-queue@webkit.org

11 edits
1 add
3 deletes in trunk/Tools

ImageDiff: Add CG implementation for new ImageDiff
https://bugs.webkit.org/show_bug.cgi?id=170608

Reviewed Alex Christensen.

Patch by Carlos Garcia Campos <cgarcia@igalia.com> on 2017-05-10

DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
DumpRenderTree/win/ImageDiffCairo.cpp: Removed.
DumpRenderTree/win/ImageDiffWin.cpp: Removed.
ImageDiff/CMakeLists.txt:
ImageDiff/Cairo.cmake:
ImageDiff/ImageDiff.cpp:

(main):

ImageDiff/ImageDiff.xcodeproj/project.pbxproj:
ImageDiff/PlatformImage.cpp:
ImageDiff/PlatformImage.h:
ImageDiff/cairo/PlatformImageCairo.cpp:
ImageDiff/cg/ImageDiff.cpp: Removed.
ImageDiff/cg/PlatformImageCG.cpp: Added.

(ImageDiff::PlatformImage::createFromStdin):
(ImageDiff::PlatformImage::createFromDiffData):
(ImageDiff::PlatformImage::PlatformImage):
(ImageDiff::PlatformImage::~PlatformImage):
(ImageDiff::PlatformImage::width):
(ImageDiff::PlatformImage::height):
(ImageDiff::PlatformImage::rowBytes):
(ImageDiff::PlatformImage::hasAlpha):
(ImageDiff::PlatformImage::pixels):
(ImageDiff::PlatformImage::writeAsPNGToStdout):

1:04 AM Changeset in webkit [216575] by zandobersek@gmail.com

8 edits in trunk

Enable FTL JIT by default on AArch64
https://bugs.webkit.org/show_bug.cgi?id=144039

Reviewed by Yusuke Suzuki.

Source/cmake/OptionsWPE.cmake:
Source/cmake/WebKitFeatures.cmake: Set FTL as enabled by default

when targeting either WTF_CPU_X86_64 or WTF_CPU_ARM64.

Tools:

Scripts/build-jsc: Enable the FTL JIT option by default on ARM64.
Scripts/run-jsc-stress-tests: Unmark the ARM64 and Linux combination

as an unsupported FTL platform.

Scripts/webkitdirs.pm:

(isARM64): Returns 1 if the determined architecture is 'arm64'.

Scripts/webkitperl/FeatureList.pm: Enable FTL_JIT and WEBASSEMBLY on ARM64.

12:42 AM Changeset in webkit [216574] by svillar@igalia.com

6 edits in trunk

[css-grid] Remove Blink-specific code for handling orthogonal grid items
https://bugs.webkit.org/show_bug.cgi?id=171807

Reviewed by Darin Adler.

Source/WebCore:

This code was added in r203252 as part of a patch improving the handling of
{min|max}-content with orthogonal flows. The original code came from Blink which performs a
pre-layout of orthogonal boxes in FrameView. That is not true in the case of WebKit so we do
not need this code at all. Actually it was causing incorrect renderings in some tests.

I'm also removing an invalid return statement just after another return.

rendering/GridTrackSizingAlgorithm.cpp:

(WebCore::GridTrackSizingAlgorithmStrategy::minContentForChild):
(WebCore::GridTrackSizingAlgorithmStrategy::maxContentForChild):

LayoutTests:

Updated the expectations. They should now be compatible with Firefox and Chrome.

fast/css-grid-layout/grid-track-sizing-with-orthogonal-flows.html:
fast/css-grid-layout/grid-track-sizing-with-percentages-and-orthogonal-flows.html:
fast/css-grid-layout/repeating-layout-must-produce-the-same-results.html:

12:40 AM Changeset in webkit [216573] by jmarcell@apple.com

3 edits
2 adds in branches/safari-603-branch

Cherry-pick r216443. rdar://problem/31971375

12:40 AM Changeset in webkit [216572] by jmarcell@apple.com

3 edits
2 adds in branches/safari-603-branch

Cherry-pick r216159. rdar://problem/31971329

12:40 AM Changeset in webkit [216571] by jmarcell@apple.com

3 edits
2 adds in branches/safari-603-branch

Cherry-pick r216104. rdar://problem/32057088

12:40 AM Changeset in webkit [216570] by jmarcell@apple.com

6 edits
1 add in branches/safari-603-branch

Cherry-pick r215748. rdar://problem/31971413

12:40 AM Changeset in webkit [216569] by jmarcell@apple.com

4 edits
2 adds in branches/safari-603-branch

Cherry-pick r215197. rdar://problem/31971401

12:40 AM Changeset in webkit [216568] by jmarcell@apple.com

7 edits
5 adds in branches/safari-603-branch

Cherry-pick r214375. rdar://problem/32057082

12:40 AM Changeset in webkit [216567] by jmarcell@apple.com

2 edits in branches/safari-603-branch/Source/WebCore

Cherry-pick r213727. rdar://problem/32086123

12:22 AM Changeset in webkit [216566] by commit-queue@webkit.org

2 edits in trunk/Source/WTF

[Win] StaticStringImpl in HTMLNames.cpp aren't constructed
https://bugs.webkit.org/show_bug.cgi?id=171800

Patch by Fujii Hironori <Fujii Hironori> on 2017-05-10
Reviewed by Yusuke Suzuki.

Global variables of StaticStringImpl in HTMLNames.cpp aren't
constructed on Windows since Bug 171586. It seems that
reinterpret_cast prevents constexpr's compile time initialization
in VC++.

wtf/text/StringImpl.h:

(WTF::StringImplShape::StringImplShape): Added const char* and
const char16_t* members in the union. Do not use reinterpret_cast
in constexpr constructors.

May 9, 2017:

10:51 PM Changeset in webkit [216565] by zandobersek@gmail.com

2 edits in trunk/Source/WebCore

Unreviewed build fix.

platform/wpe/WidgetWPE.cpp:

(WebCore::Widget::paint): Add the missing SecurityOriginPaintPolicy parameter.

10:28 PM Changeset in webkit [216564] by commit-queue@webkit.org

6 edits in trunk/Source/WebInspectorUI

Web Inspector: Provide resource load error reason text in details sidebar
https://bugs.webkit.org/show_bug.cgi?id=171901
<rdar://problem/29850995>

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2017-05-09
Reviewed by Brian Burg.

Localizations/en.lproj/localizedStrings.js:
UserInterface/Controllers/FrameResourceManager.js:

(WebInspector.FrameResourceManager.prototype.resourceRequestDidFailLoading):

UserInterface/Models/Resource.js:

(WebInspector.Resource):
(WebInspector.Resource.prototype.get failureReasonText):
(WebInspector.Resource.prototype.markAsFailed):

UserInterface/Protocol/NetworkObserver.js:

(WebInspector.NetworkObserver.prototype.loadingFailed):
Include the error text we got from the backend. In most cases this should
be a localized error description.

UserInterface/Views/ResourceDetailsSidebarPanel.js:

(WebInspector.ResourceDetailsSidebarPanel.prototype.set resource):
(WebInspector.ResourceDetailsSidebarPanel.prototype._refreshErrorReason):
(WebInspector.ResourceDetailsSidebarPanel.prototype._refreshRequestAndResponse):
Include an Error field alongside the status code section when there was an error.

9:42 PM Changeset in webkit [216563] by eric.carlson@apple.com

26 edits
2 adds in trunk

[MediaStream] deviceId constraint doesn't work with getUserMedia
https://bugs.webkit.org/show_bug.cgi?id=171877
<rdar://problem/31899730>

Reviewed by Jer Noble.

Source/WebCore:

Test: fast/mediastream/get-user-media-device-id.html

Modules/mediastream/MediaConstraintsImpl.h:

(WebCore::MediaConstraintsData::MediaConstraintsData): Add a constructor that
takes a const MediaConstraints&.

Modules/mediastream/MediaDevicesEnumerationRequest.cpp:

(WebCore::MediaDevicesEnumerationRequest::topLevelDocumentOrigin): Don't return
NULL for the main frame so the origin matches that returned for a UserMediaRequest.

Modules/mediastream/UserMediaController.h:

(WebCore::UserMediaController::setDeviceIDHashSalt): Deleted, not used.
(WebCore::UserMediaController::deviceIDHashSalt): Deleted, not used.

Modules/mediastream/UserMediaRequest.cpp:

(WebCore::UserMediaRequest::allow): Add device ID hash salt parameter, set it on
constraints.

Modules/mediastream/UserMediaRequest.h:

platform/mediastream/MediaConstraints.h:
platform/mediastream/RealtimeMediaSource.cpp:

(WebCore::RealtimeMediaSource::fitnessDistance): ASSERT if called for DeviceId.
(WebCore::RealtimeMediaSource::selectSettings): Special case DeviceId because it
we have to hash the device ID before comparing, and because the DeviceId can't be
changed so it should never be added to the flattened constraints.

platform/mediastream/RealtimeMediaSourceSupportedConstraints.cpp:

(WebCore::RealtimeMediaSourceSupportedConstraints::nameForConstraint): Deleted, unused.
(WebCore::RealtimeMediaSourceSupportedConstraints::constraintFromName): Deleted, unused.

platform/mediastream/RealtimeMediaSourceSupportedConstraints.h:

platform/mediastream/mac/AVVideoCaptureSource.mm:
platform/mediastream/mac/RealtimeMediaSourceCenterMac.cpp:

(WebCore::RealtimeMediaSourceCenterMac::bestSourcesForTypeAndConstraints): Pass device
id, not empty string.

Source/WebKit2:

Shared/WebCoreArgumentCoders.cpp:

(IPC::ArgumentCoder<MediaConstraintsData>::encode): Encode deviceIDHashSalt.
(IPC::ArgumentCoder<MediaConstraintsData>::decode): Decode deviceIDHashSalt.

UIProcess/UserMediaPermissionCheckProxy.cpp:

(WebKit::UserMediaPermissionCheckProxy::UserMediaPermissionCheckProxy): Initialize
completion handler, frame ID, and security origins.
(WebKit::UserMediaPermissionCheckProxy::setUserMediaAccessInfo): Complete by calling
completion handler because we now sometimes request access info before calling gUM.
(WebKit::UserMediaPermissionCheckProxy::invalidate): Clear completion handler.

UIProcess/UserMediaPermissionCheckProxy.h:

UIProcess/UserMediaPermissionRequestManagerProxy.cpp:

(WebKit::FrameAuthorizationState::FrameAuthorizationState): Take security origins, not
UserMediaPermissionRequestProxy, so it can be constructed with a UserMediaPermissionCheckProxy.
(WebKit::FrameAuthorizationState::ensureSecurityOriginsAreEqual): Ditto. Clear has salt
when origins don't match.
(WebKit::UserMediaPermissionRequestManagerProxy::stateForRequest): Templatize.
(WebKit::UserMediaPermissionRequestManagerProxy::userMediaAccessWasDenied): Fix typo.
(WebKit::UserMediaPermissionRequestManagerProxy::userMediaAccessWasGranted): Ditto.
Don't set state for empty UIDs. Pass hash salt to web process.
(WebKit::UserMediaPermissionRequestManagerProxy::requestUserMediaPermissionForFrame):
The device ID hash salt is now required to validate constraints, so get it first.
(WebKit::UserMediaPermissionRequestManagerProxy::getUserMediaPermissionInfo): Helper
method used to get the device ID hash salt.
(WebKit::UserMediaPermissionRequestManagerProxy::enumerateMediaDevicesForFrame): Restructure
to use getUserMediaPermissionInfo.
(WebKit::UserMediaPermissionRequestManagerProxy::didCompleteUserMediaPermissionCheck): Deleted.

UIProcess/UserMediaPermissionRequestManagerProxy.h:

WebProcess/MediaStream/UserMediaPermissionRequestManager.cpp:

(WebKit::UserMediaPermissionRequestManager::userMediaAccessWasGranted): Add device ID
hash salt parameter.

WebProcess/MediaStream/UserMediaPermissionRequestManager.h:

WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::userMediaAccessWasGranted): Ditto.

WebProcess/WebPage/WebPage.h:
WebProcess/WebPage/WebPage.messages.in:

WebProcess/cocoa/UserMediaCaptureManager.cpp:

(WebKit::UserMediaCaptureManager::createCaptureSource): Use new MediaConstraintsData
constructor.

LayoutTests:

fast/mediastream/get-user-media-device-id-expected.txt: Added.
fast/mediastream/get-user-media-device-id.html: Added.

7:30 PM Changeset in webkit [216562] by commit-queue@webkit.org

2 edits in trunk/Source/WebInspectorUI

[GTK][Win] Web Inspector: Cann't open "Quick Open" dialog by pressing Ctrl+Shift+O
https://bugs.webkit.org/show_bug.cgi?id=171798

Patch by Fujii Hironori <Fujii Hironori> on 2017-05-09
Reviewed by Michael Catanzaro.

PC can't input the shortcut keys Command+Shift+O and Command+P.

UserInterface/Base/Main.js:

(WebInspector.contentLoaded): Use CommandOrControl instead of Command.

6:01 PM Changeset in webkit [216561] by fpizlo@apple.com

4 edits in trunk/Source/JavaScriptCore

JSInjectedScriptHost should get a copy of the boundArgs
https://bugs.webkit.org/show_bug.cgi?id=171897

Reviewed by Joseph Pecoraro.

The boundArgs array is very special - it cannot be mutated in any way. So, it makes sense
for the inspector to get a copy of it.

inspector/JSInjectedScriptHost.cpp:

(Inspector::JSInjectedScriptHost::getInternalProperties):

runtime/JSBoundFunction.cpp:

(JSC::JSBoundFunction::boundArgsCopy):

runtime/JSBoundFunction.h:

(JSC::JSBoundFunction::boundArgs):

5:33 PM Changeset in webkit [216560] by Matt Lewis

2 edits in trunk/LayoutTests

Mark webrtc/libwebrtc/release-while-setting-local-description.html as flaky.
https://bugs.webkit.org/show_bug.cgi?id=171899

Unreviewed test gardening.

platform/ios-wk2/TestExpectations:

5:21 PM Changeset in webkit [216559] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

Video fullscreen window level should be below status bar.
https://bugs.webkit.org/show_bug.cgi?id=171892
rdar://problem/31771707

Patch by Jeremy Jones <jeremyj@apple.com> on 2017-05-09
Reviewed by Jer Noble.

No new tests because it only affects platform window level.

Move the fullscreen window below the status bar, but above the input field window level.

platform/ios/WebVideoFullscreenInterfaceAVKit.mm:

(WebVideoFullscreenInterfaceAVKit::setupFullscreen):

5:13 PM WebKitGTK/2.16.x edited by Michael Catanzaro

Propose r215166 to make Gentoo happy (diff)

5:03 PM Changeset in webkit [216558] by mark.lam@apple.com

2 edits in trunk/Source/JavaScriptCore

Unindent some code in Watchdog::shouldTerminate().
https://bugs.webkit.org/show_bug.cgi?id=171896

Rubber stamped by Keith Miller.

I should have done this before I landed r213107, but I forgot. Unindenting it now.

runtime/Watchdog.cpp:

(JSC::Watchdog::shouldTerminate):

4:27 PM Changeset in webkit [216557] by Matt Lewis

2 edits in trunk/LayoutTests

Mark webrtc/audio-replace-track.html as flaky.
https://bugs.webkit.org/show_bug.cgi?id=171895

Unreviewed test gardening.

platform/mac-wk2/TestExpectations:

4:19 PM Changeset in webkit [216556] by Jonathan Bedard

8 edits in trunk/Tools

webkitpy: Remove unneeded crash log retrieval, refactor Darwin crash retrieval
https://bugs.webkit.org/show_bug.cgi?id=170857
<rdar://problem/31635373>

Reviewed by Aakash Jain.

Since LayoutTestRelay has been removed, iOS Simulators and Macs can use the same
code to search for crash logs.

Scripts/webkitpy/port/darwin.py:

(DarwinPort._get_crash_log): Moved from MacPort.

Scripts/webkitpy/port/darwin_testcase.py:

(DarwinTest.test_get_crash_log): Moved from MacTest.

Scripts/webkitpy/port/ios_device.py:

(IOSDevicePort._get_crash_log): Implement pass-through for iOS device, since iOS
devices must search for crash-logs remotely.

Scripts/webkitpy/port/ios_simulator.py:

(IOSSimulatorPort._get_crash_log): Deleted.

Scripts/webkitpy/port/ios_simulator_unittest.py:

(IOSSimulatorTest.test_get_crash_log): Deleted.

Scripts/webkitpy/port/mac.py:

(MacPort._get_crash_log): Moved to DarwinPort

Scripts/webkitpy/port/mac_unittest.py:

(MacTest.test_get_crash_log): Moved to DarwinTest.

4:14 PM Changeset in webkit [216555] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit2

Buffer media in NetworkProcess to reduce IPC overhead
https://bugs.webkit.org/show_bug.cgi?id=171834
<rdar://problem/31485485>

Patch by Alex Christensen <achristensen@webkit.org> on 2017-05-09
Reviewed by Jer Noble.

I have measured a significant CPU usage reduction when buffering media data in the NetworkProcess,
especially on arm64 processors. Buffering data in the NetworkProcess introduces no additional data
copies after r215686, and it reduces the number of messages sent from the NetworkProcess to the WebProcess,
each of which must also be forwarded to mediaserverd by AVFoundation. This reduces the number of messages
from thousands per second to a maximum of 20 per second. This adds 1/20 second additional latency in
media loading, which will probably not be noticed by most users. This also adds the possibility of large
allocations when decoding IPC messages in the WebProcess, and if that becomes the source of crashes we can
add a maximum buffered amount in addition to a maximum buffered time, but we are likely not to receive
so much data in 1/20 second to have problems allocating the buffer.

WebProcess/Network/WebLoaderStrategy.cpp:

(WebKit::maximumBufferingTime):
Buffer data in the NetworkProcess for up to 50ms before sending it to the WebProcess in one message.
This value is used in NetworkResourceLoader::didReceiveBuffer to append to m_bufferedData instead of
sending the small chunks immediately.

4:00 PM Changeset in webkit [216554] by dino@apple.com

3 edits in trunk/Source/WebKit/win

Fix Windows build.

Plugins/PluginView.h:
Plugins/PluginViewWin.cpp:

(WebCore::PluginView::paint):

3:53 PM Changeset in webkit [216553] by weinig@apple.com

14 edits
9 adds in trunk

LayoutTests/imported/w3c:
Implement Subresource Integrity (SRI)
https://bugs.webkit.org/show_bug.cgi?id=148363
<rdar://problem/18945879>

Reviewed by Youenn Fablet.

web-platform-tests/fetch/api/basic/integrity-expected.txt:
web-platform-tests/fetch/api/basic/integrity-worker-expected.txt:

Update results now that integrity is implemented.

Source/WebCore:
Implement Subresource Integrity (SRI) [Part 2 - Fetch]
https://bugs.webkit.org/show_bug.cgi?id=148363
<rdar://problem/18945879>

Reviewed by Youenn Fablet.

Tests: http/tests/subresource-integrity/sri-fetch-worker.html

http/tests/subresource-integrity/sri-fetch.html

loader/FetchOptions.h:
loader/ThreadableLoader.cpp:

(WebCore::ThreadableLoaderOptions::isolatedCopy):

loader/ThreadableLoader.h:
loader/WorkerThreadableLoader.cpp:

(WebCore::LoaderTaskOptions::LoaderTaskOptions):
Add integrity metadata to the fetch options, and fix the implementation of
ThreadableLoaderOptions::isolatedCopy to work correctly (it was missing isolated
copy derivedCachedDataTypesToRetrieve).

Modules/fetch/FetchRequest.cpp:

(WebCore::buildOptions):
(WebCore::FetchRequest::initializeOptions):

Modules/fetch/FetchRequest.h:

Switch to using the integrity metadata on the fetchOptions, removing the need to
store them directly on the internal request.

loader/DocumentThreadableLoader.cpp:

(WebCore::DocumentThreadableLoader::DocumentThreadableLoader):
(WebCore::DocumentThreadableLoader::didReceiveResponse):
(WebCore::DocumentThreadableLoader::didReceiveData):
(WebCore::DocumentThreadableLoader::didFinishLoading):
(WebCore::DocumentThreadableLoader::loadRequest):
(WebCore::DocumentThreadableLoader::reportIntegrityMetadataError):

loader/DocumentThreadableLoader.h:

Add a new flag, m_delayCallbacksForIntegrityCheck, which is used when integrity metadata
is present, so we can implement the 'wait' concept from the fetch spec, and delay informing
the clients until we have validated the integrity metadata.

LayoutTests:
Implement Subresource Integrity (SRI)
https://bugs.webkit.org/show_bug.cgi?id=148363
<rdar://problem/18945879>

Reviewed by Youenn Fablet.

Add tests for Subresource Integrity for Fetch based off the ones from Web
Platform Tests. Additional tests for more CORS combinations have been added.

http/tests/subresource-integrity/resources/crossorigin-anon-resource.txt: Added.
http/tests/subresource-integrity/resources/crossorigin-creds-resource.txt: Added.
http/tests/subresource-integrity/resources/crossorigin-ineligible-resource.txt: Added.
http/tests/subresource-integrity/resources/resource.txt: Added.
http/tests/subresource-integrity/sri-fetch-expected.txt: Added.
http/tests/subresource-integrity/sri-fetch-worker-expected.txt: Added.
http/tests/subresource-integrity/sri-fetch-worker.html: Added.
http/tests/subresource-integrity/sri-fetch.html: Added.
http/tests/subresource-integrity/sri-fetch.js: Added.

3:52 PM Changeset in webkit [216552] by Matt Lewis

2 edits in trunk/LayoutTests

Marked webrtc/captureCanvas-webrtc.html as flaky.
https://bugs.webkit.org/show_bug.cgi?id=170870

Unreviewed test gardening.

platform/mac-wk2/TestExpectations:

3:38 PM Changeset in webkit [216551] by msaboff@apple.com

2 edits in trunk/Source/JavaScriptCore

Cap the number of FTL compilation threads on iOS to 2
https://bugs.webkit.org/show_bug.cgi?id=171887

Reviewed by Filip Pizlo.

Set an iOS specific max of 2 threads.

runtime/Options.h:

3:35 PM Changeset in webkit [216550] by commit-queue@webkit.org

25 edits
2 deletes in trunk

Unreviewed, rolling out r216545.
https://bugs.webkit.org/show_bug.cgi?id=171889

Caused a test failure (Requested by eric_carlson on #webkit).

Reverted changeset:

"[MediaStream] deviceId constraint doesn't work with
getUserMedia"
https://bugs.webkit.org/show_bug.cgi?id=171877
http://trac.webkit.org/changeset/216545

3:30 PM Changeset in webkit [216549] by Alan Bujtas

6 edits
2 adds in trunk

resetFlowThreadContainingBlockAndChildInfoIncludingDescendants should not ignore RenderElement subtrees.
https://bugs.webkit.org/show_bug.cgi?id=171873
<rdar://problem/32004954>

Reviewed by Simon Fraser.

Source/WebCore:

Normally a RenderBlock's parent is another RenderBlock, but In some cases (e.g. tables) a RenderBlock can
have a non-RenderBlock(RenderBox) ancestor.
While updating the flow thread state on a subtree, we should descent into subtrees with RenderElement
roots and not just RenderBlocks so that we clear the state on the entire subtree.

Test: fast/multicol/crash-when-column-inside-table.html

rendering/RenderBlock.cpp:

(WebCore::RenderBlock::resetFlowThreadContainingBlockAndChildInfoIncludingDescendants):

rendering/RenderBlock.h:
rendering/RenderElement.cpp:

(WebCore::RenderElement::resetFlowThreadContainingBlockAndChildInfoIncludingDescendants):

rendering/RenderElement.h:

LayoutTests:

fast/multicol/crash-when-column-inside-table-expected.txt: Added.
fast/multicol/crash-when-column-inside-table.html: Added.

3:28 PM Changeset in webkit [216548] by Ryan Haddad

3 edits in trunk/LayoutTests

[iOS Simulator] Flaky failure LayoutTest/webrtc/libwebrtc/release-while-setting-local-description.html
https://bugs.webkit.org/show_bug.cgi?id=171742

Reviewed by Youenn Fablet.

Silence the console messages for unhandled rejections in this test.

webrtc/libwebrtc/release-while-setting-local-description-expected.txt:
webrtc/libwebrtc/release-while-setting-local-description.html:

3:27 PM Changeset in webkit [216547] by fpizlo@apple.com

2 edits in trunk/Source/JavaScriptCore

Heap::heap() should behave gracefully for null pointers
https://bugs.webkit.org/show_bug.cgi?id=171888
<rdar://problem/32005315>

Reviewed by Mark Lam.

Some callers of Heap::heap() can pass a null cell and they will behave gracefully if we
return a null Heap. So, let's do that.

This fixes a crash and it does not hurt performance. I'm seeing a possible 0.5% regression
with 74% probability. That's a neutral result by our usual 95% standard.

heap/HeapInlines.h:

(JSC::Heap::heap):

3:18 PM Changeset in webkit [216546] by BJ Burg

3 edits in trunk/Source/WebInspectorUI

Web Inspector: Assertion failed: Cannot select item with unexpected parent bar. (at NavigationBar.js:132)
https://bugs.webkit.org/show_bug.cgi?id=171885

Reviewed by Matt Baker.

This new assertion revealed a real misuse of the NavigationBar API.

UserInterface/Views/NavigationBar.js:

(WebInspector.NavigationBar.prototype.set selectedNavigationItem):
Improve this to be an assertion so it can be paused at using the debugger.

UserInterface/Views/TimelineTabContentView.js:

(WebInspector.TimelineTabContentView.prototype._changeViewMode):
We need to set a NavigationItem as the selected item, not its identifier.
Look up the corresponding item for the identifier that we received (the view mode).

3:06 PM Changeset in webkit [216545] by eric.carlson@apple.com

25 edits
2 adds in trunk

[MediaStream] deviceId constraint doesn't work with getUserMedia
https://bugs.webkit.org/show_bug.cgi?id=171877
<rdar://problem/31899730>

Reviewed by Jer Noble.

Source/WebCore:

Test: fast/mediastream/get-user-media-device-id.html

Modules/mediastream/MediaConstraintsImpl.h:

(WebCore::MediaConstraintsData::MediaConstraintsData): Add a constructor that
takes a const MediaConstraints&.

Modules/mediastream/MediaDevicesEnumerationRequest.cpp:

(WebCore::MediaDevicesEnumerationRequest::topLevelDocumentOrigin): Don't return
NULL for the main frame so the origin matches that returned for a UserMediaRequest.

Modules/mediastream/UserMediaController.h:

(WebCore::UserMediaController::setDeviceIDHashSalt): Deleted, not used.
(WebCore::UserMediaController::deviceIDHashSalt): Deleted, not used.

Modules/mediastream/UserMediaRequest.cpp:

(WebCore::UserMediaRequest::allow): Add device ID hash salt parameter, set it on
constraints.

Modules/mediastream/UserMediaRequest.h:

platform/mediastream/MediaConstraints.h:
platform/mediastream/RealtimeMediaSource.cpp:

platform/mediastream/RealtimeMediaSourceSupportedConstraints.cpp:

(WebCore::RealtimeMediaSourceSupportedConstraints::nameForConstraint): Deleted, unused.
(WebCore::RealtimeMediaSourceSupportedConstraints::constraintFromName): Deleted, unused.

platform/mediastream/RealtimeMediaSourceSupportedConstraints.h:

platform/mediastream/mac/AVVideoCaptureSource.mm:
platform/mediastream/mac/RealtimeMediaSourceCenterMac.cpp:

(WebCore::RealtimeMediaSourceCenterMac::bestSourcesForTypeAndConstraints): Pass device
id, not empty string.

Source/WebKit2:

Shared/WebCoreArgumentCoders.cpp:

(IPC::ArgumentCoder<MediaConstraintsData>::encode): Encode deviceIDHashSalt.
(IPC::ArgumentCoder<MediaConstraintsData>::decode): Decode deviceIDHashSalt.

UIProcess/UserMediaPermissionCheckProxy.cpp:

UIProcess/UserMediaPermissionCheckProxy.h:

UIProcess/UserMediaPermissionRequestManagerProxy.cpp:

UIProcess/UserMediaPermissionRequestManagerProxy.h:

WebProcess/MediaStream/UserMediaPermissionRequestManager.cpp:

(WebKit::UserMediaPermissionRequestManager::userMediaAccessWasGranted): Add device ID
hash salt parameter.

WebProcess/MediaStream/UserMediaPermissionRequestManager.h:

WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::userMediaAccessWasGranted): Ditto.

WebProcess/WebPage/WebPage.h:
WebProcess/WebPage/WebPage.messages.in:

WebProcess/cocoa/UserMediaCaptureManager.cpp:

(WebKit::UserMediaCaptureManager::createCaptureSource): Use new MediaConstraintsData
constructor.

LayoutTests:

fast/mediastream/get-user-media-device-id-expected.txt: Added.
fast/mediastream/get-user-media-device-id.html: Added.

2:52 PM Changeset in webkit [216544] by commit-queue@webkit.org

3 edits in trunk/Source/WebCore

[Modern Media Controls] Localized strings aren't loaded
https://bugs.webkit.org/show_bug.cgi?id=171884

Patch by Antoine Quint <Antoine Quint> on 2017-05-09
Reviewed by Dean Jackson.

Remove the extraneous file extension in the file name.

rendering/RenderThemeIOS.mm:

(WebCore::RenderThemeIOS::mediaControlsScript):

rendering/RenderThemeMac.mm:

(WebCore::RenderThemeMac::mediaControlsScript):

2:49 PM Changeset in webkit [216543] by Matt Lewis

3 edits in trunk/LayoutTests

Marked multiple test flaky.
https://bugs.webkit.org/show_bug.cgi?id=171886

Unreviewed test gardening.

platform/ios-wk2/TestExpectations:
platform/mac/TestExpectations:

2:40 PM Changeset in webkit [216542] by Chris Dumez

8 edits
3 adds in trunk

Introduce DocumentAndElementEventHandlers IDL interface
https://bugs.webkit.org/show_bug.cgi?id=171879

Reviewed by Simon Fraser and Ryosuke Niwa.

Source/WebCore:

Introduce DocumentAndElementEventHandlers IDL interface:

https://html.spec.whatwg.org/#documentandelementeventhandlers

This avoids duplication between Document.idl and Element.idl.

Also mark oncopy / oncut / onpaste EventHandlers as enumerable to match
the specification.

Test: fast/events/DocumentAndElementEventHandlers.html

CMakeLists.txt:
DerivedSources.make:
WebCore.xcodeproj/project.pbxproj:
dom/Document.idl:
dom/DocumentAndElementEventHandlers.idl: Added.
dom/Element.idl:

LayoutTests:

fast/events/DocumentAndElementEventHandlers-expected.txt: Added.
fast/events/DocumentAndElementEventHandlers.html: Added.

Add layout test coverage.

js/dom/dom-static-property-for-in-iteration-expected.txt:

Rebaseline now that those event handlers are enumerable.

2:35 PM Changeset in webkit [216541] by dino@apple.com

29 edits
5 adds in trunk

Restrict SVG filters to accessible security origins
https://bugs.webkit.org/show_bug.cgi?id=118689
<rdar://problem/27362159>

Reviewed by Brent Fulgham.

Source/WebCore:

Certain SVG filters should only be allowed to operate
on content that is has SecurityOrigin access to. Implement
this by including a flag in PaintInfo and LayerPaintingInfo,
and have RenderWidget make sure the documents have acceptable
SecurityOrigins as it goes to paint.

This could be used as the first step in a "safe painting"
strategy, allowing some content to be rendered into a
canvas or via the element() CSS function... but it is only
a small first step.

Test: http/tests/css/filters-on-iframes.html

page/FrameView.cpp:

(WebCore::FrameView::paintContents):

page/FrameView.h:
platform/ScrollView.cpp:

(WebCore::ScrollView::paint):

platform/ScrollView.h:
platform/Scrollbar.cpp:

(WebCore::Scrollbar::paint):

platform/Scrollbar.h:
platform/Widget.h:
platform/graphics/filters/FilterOperation.h:

(WebCore::FilterOperation::shouldBeRestrictedBySecurityOrigin):

platform/graphics/filters/FilterOperations.cpp:

(WebCore::FilterOperations::hasFilterThatShouldBeRestrictedBySecurityOrigin):

platform/graphics/filters/FilterOperations.h:
platform/mac/WidgetMac.mm:

(WebCore::Widget::paint):

rendering/FilterEffectRenderer.cpp:

(WebCore::FilterEffectRenderer::build):

rendering/FilterEffectRenderer.h:
rendering/PaintInfo.h:

(WebCore::PaintInfo::PaintInfo):

rendering/RenderLayer.cpp:

(WebCore::RenderLayer::paint):
(WebCore::RenderLayer::setupFilters):
(WebCore::RenderLayer::paintForegroundForFragmentsWithPhase):

rendering/RenderLayer.h:
rendering/RenderScrollbar.cpp:

(WebCore::RenderScrollbar::paint):

rendering/RenderScrollbar.h:
rendering/RenderWidget.cpp:

(WebCore::RenderWidget::paintContents):

Source/WebKit2:

Update parameter lists.

WebProcess/Plugins/PluginView.cpp:

(WebKit::PluginView::paint):

WebProcess/Plugins/PluginView.h:

LayoutTests:

Add a test that shows safe frames, unsafe frames, and
then a safe frame that itself has an unsafe frame, to
show that the security requirements are being forwarded
down the tree.

http/tests/css/filters-on-iframes-expected.html: Added.
http/tests/css/filters-on-iframes.html: Added.
http/tests/css/resources/blank.html: Added.
http/tests/css/resources/references-external.html: Added.
http/tests/css/resources/solid-red.html: Added.

2:21 PM Changeset in webkit [216540] by Chris Dumez

9 edits
2 adds in trunk

Move onanimation* EventHandlers to GlobalEventHandlers
https://bugs.webkit.org/show_bug.cgi?id=171874

Reviewed by Simon Fraser.

Source/WebCore:

Move onanimation* EventHandlers to GlobalEventHandlers to match the specification:

https://drafts.csswg.org/css-animations/#interface-globaleventhandlers-idl

We previously have those on Window and Element only. Firefox complies with the
specification.

Test: fast/css/onanimation-eventhandlers.html

dom/Element.idl:
dom/GlobalEventHandlers.idl:
page/DOMWindow.idl:

LayoutTests:

fast/css/onanimation-eventhandlers-expected.txt: Added.
fast/css/onanimation-eventhandlers.html: Added.

Add layout test coverage.

fast/dom/event-handler-attributes-expected.txt:
fast/dom/event-handler-attributes.html:
js/dom/dom-static-property-for-in-iteration-expected.txt:

Rebaseline existing tests to reflect behavior change.

2:04 PM Changeset in webkit [216539] by Matt Lewis

2 edits in trunk/LayoutTests

Fixed a typo in expectations file.
https://bugs.webkit.org/show_bug.cgi?id=162710

Unreviewed test gardening.

platform/mac-wk2/TestExpectations:

2:01 PM Changeset in webkit [216538] by Jon Davis

3 edits in trunk/PerformanceTests

[ARES6] Improved the running test indicator
https://bugs.webkit.org/show_bug.cgi?id=171400

Running tests show a triangle before the test title and the titles are white.

Reviewed by Joseph Pecoraro.

ARES-6/index.html:
ARES-6/styles.css:

(.test .running):
(.test .running:before):
(.test .indicator): Deleted.
(.test .indicator.running): Deleted.
(@keyframes test-running): Deleted.

1:58 PM Changeset in webkit [216537] by commit-queue@webkit.org

9 edits
2 copies
20 adds in trunk

Refresh webrtc WPT tests
https://bugs.webkit.org/show_bug.cgi?id=171878

Patch by Youenn Fablet <youenn@apple.com> on 2017-05-09
Reviewed by Eric Carlson.

LayoutTests/imported/w3c:

resources/import-expectations.json:
web-platform-tests/webrtc/OWNERS:
web-platform-tests/webrtc/RTCConfiguration-iceCandidatePoolSize-expected.txt: Added.
web-platform-tests/webrtc/RTCConfiguration-iceCandidatePoolSize.html: Added.
web-platform-tests/webrtc/RTCDataChannel-id-expected.txt: Added.
web-platform-tests/webrtc/RTCDataChannel-id.html: Added.
web-platform-tests/webrtc/RTCPeerConnection-canTrickleIceCandidates-expected.txt: Added.
web-platform-tests/webrtc/RTCPeerConnection-canTrickleIceCandidates.html: Added.
web-platform-tests/webrtc/RTCPeerConnection-constructor-expected.txt: Added.
web-platform-tests/webrtc/RTCPeerConnection-constructor.html: Added.
web-platform-tests/webrtc/RTCPeerConnection-createDataChannel-expected.txt: Added.
web-platform-tests/webrtc/RTCPeerConnection-createDataChannel.html: Added.
web-platform-tests/webrtc/RTCPeerConnection-iceGatheringState-expected.txt: Added.
web-platform-tests/webrtc/RTCPeerConnection-iceGatheringState.html: Added.
web-platform-tests/webrtc/RTCPeerConnection-idl-expected.txt: Added.
web-platform-tests/webrtc/RTCPeerConnection-idl.html: Added.
web-platform-tests/webrtc/RTCPeerConnection-setRemoteDescription-expected.txt: Added.
web-platform-tests/webrtc/RTCPeerConnection-setRemoteDescription.html: Added.
web-platform-tests/webrtc/datachannel-idlharness-expected.txt: Added.
web-platform-tests/webrtc/datachannel-idlharness.html: Added.
web-platform-tests/webrtc/getstats-expected.txt: Added.
web-platform-tests/webrtc/getstats.html: Added.
web-platform-tests/webrtc/interfaces-expected.txt: Added.
web-platform-tests/webrtc/interfaces.html: Added.
web-platform-tests/webrtc/no-media-call.html:
web-platform-tests/webrtc/promises-call.html:
web-platform-tests/webrtc/rtcpeerconnection/rtcpeerconnection-idl-expected.txt:
web-platform-tests/webrtc/simplecall.html:
web-platform-tests/webrtc/w3c-import.log:

Source/WebCore:

Tests: imported/w3c/web-platform-tests/webrtc/RTCConfiguration-iceCandidatePoolSize.html

imported/w3c/web-platform-tests/webrtc/RTCDataChannel-id.html
imported/w3c/web-platform-tests/webrtc/RTCPeerConnection-canTrickleIceCandidates.html
imported/w3c/web-platform-tests/webrtc/RTCPeerConnection-constructor.html
imported/w3c/web-platform-tests/webrtc/RTCPeerConnection-createDataChannel.html
imported/w3c/web-platform-tests/webrtc/RTCPeerConnection-iceGatheringState.html
imported/w3c/web-platform-tests/webrtc/RTCPeerConnection-idl.html
imported/w3c/web-platform-tests/webrtc/RTCPeerConnection-setRemoteDescription.html
imported/w3c/web-platform-tests/webrtc/datachannel-idlharness.html
imported/w3c/web-platform-tests/webrtc/getstats.html
imported/w3c/web-platform-tests/webrtc/interfaces.html

Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp:

(WebCore::LibWebRTCMediaEndpoint::createDataChannel): exiting early if libwebrtc is not creating a data channel.

1:48 PM Changeset in webkit [216536] by jfernandez@igalia.com

16 edits in trunk

space-evenly misbehaves with flexbox
https://bugs.webkit.org/show_bug.cgi?id=170445

Reviewed by David Hyatt.

Source/WebCore:

The CSS Box Alignment specification defines the <content-distribution>
set as some of the allowed values for the Content Distribution
properties, align-content and justify-content. The 'space-evenly' value
is not among the ones allowed for these properties according to the CSS
Flexible Box specification.

The CSS Flexbible box specification states that it must follow the CSS
Box Alignment specification, so this new value must be considered as
part of an upgraded level of the spec, which should be implemented
eventually.

Since we have already shipped an implementation of the new CSS Box
Alignment values for CSS Grid Layout, we need to implement it for
Flexbox as well.

No new tests, but several new test cases added.

rendering/RenderFlexibleBox.cpp:

(WebCore::initialJustifyContentOffset):
(WebCore::justifyContentSpaceBetweenChildren):
(WebCore::initialAlignContentOffset):
(WebCore::alignContentSpaceBetweenChildren):

LayoutTests:

Added test cases for the 'space-evenly' value for align-content and justify-content.

css3/flexbox/alignContent-applies-with-flexWrap-wrap-with-single-line-expected.txt:
css3/flexbox/alignContent-applies-with-flexWrap-wrap-with-single-line.html:
css3/flexbox/css-properties-expected.txt:
css3/flexbox/css-properties.html:
css3/flexbox/flex-justify-content-expected.txt:
css3/flexbox/flex-justify-content.html:
css3/flexbox/multiline-align-content-expected.txt:
css3/flexbox/multiline-align-content-horizontal-column-expected.txt:
css3/flexbox/multiline-align-content-horizontal-column.html:
css3/flexbox/multiline-align-content.html:
css3/flexbox/resources/flexbox.css:

(.align-content-space-around):
(.justify-content-space-around):

css3/flexbox/true-centering-expected.txt:
css3/flexbox/true-centering.html:

1:24 PM Changeset in webkit [216535] by Michael Catanzaro

3 edits in trunk/Source/WebCore

Avoid -Wformat warnings in RenderLayerCompositor.cpp and RenderLayerBacking.cpp
https://bugs.webkit.org/show_bug.cgi?id=171875

Reviewed by Simon Fraser.

rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::detachFromScrollingCoordinator):

rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::logLayerInfo):
(WebCore::RenderLayerCompositor::updateScrollCoordinatedLayer):

1:01 PM Changeset in webkit [216534] by Chris Dumez

3 edits in trunk/Source/WebCore

Drop custom bindings code for Window.location setter
https://bugs.webkit.org/show_bug.cgi?id=171846

Reviewed by Sam Weinig.

Drop custom bindings code for Window.location setter as the custom code was merely needed
to address a very old Mac widget that has long been fixed (rdar://problem/5695330).

No new tests, no Web-facing behavior change.

bindings/js/JSDOMWindowCustom.cpp:

(WebCore::JSDOMWindow::setLocation): Deleted.
Drop custom code.

page/DOMWindow.idl:

Align Window.location with https://html.spec.whatwg.org/#the-window-object:

Mark property as readonly.
Add [PutsForward=href] IDL extended attribute.

Also, we need to mark the atribute as nullable as this reflects our current implementation.
We currently return null if the associated Window does not have a frame. This does not match
the specification and we should update our implementation in the future to never return null.

12:27 PM Changeset in webkit [216533] by Ryan Haddad

8 edits
1 add in branches/safari-603-branch/Tools

Merge r213654. rdar://problem/32074957

12:15 PM Changeset in webkit [216532] by Matt Lewis

5 edits
2 deletes in trunk

Unreviewed, rolling out r216508.

The layout test enabled in this change is failing on Sierra.

Reverted changeset:

"Invalid MediaSource duration value should throw TyperError
instead of InvalidStateError"
https://bugs.webkit.org/show_bug.cgi?id=171653
http://trac.webkit.org/changeset/216508

11:44 AM Changeset in webkit [216531] by Michael Catanzaro

2 edits in trunk/Source/WebCore

Update Chrome and Firefox versions in user agent quirks
https://bugs.webkit.org/show_bug.cgi?id=171823

Reviewed by Carlos Alberto Lopez Perez.

platform/UserAgentQuirks.cpp:

(WebCore::UserAgentQuirks::stringForQuirk):
(WebCore::UserAgentQuirks::firefoxRevisionString):

11:42 AM Changeset in webkit [216530] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

RealtimeOutgoingAudioSource is crashing when given data with more than two channels
https://bugs.webkit.org/show_bug.cgi?id=171868

Patch by Youenn Fablet <youenn@apple.com> on 2017-05-09
Reviewed by Eric Carlson.

Manual testing.

platform/mediastream/mac/RealtimeOutgoingAudioSource.cpp:

(WebCore::libwebrtcAudioFormat): Capping the number of channels to 2.
(WebCore::RealtimeOutgoingAudioSource::audioSamplesAvailable):

11:34 AM Changeset in webkit [216529] by Matt Lewis

2 edits in trunk/LayoutTests

Marked media/element-containing-pip-video-going-into-fullscreen.html as flaky.
https://bugs.webkit.org/show_bug.cgi?id=162710

Unreviewed test gardening.

platform/mac-wk2/TestExpectations:

11:07 AM Changeset in webkit [216528] by Jonathan Bedard

3 edits in trunk/Tools

build ImageDiff with host SDK from Make
https://bugs.webkit.org/show_bug.cgi?id=171835

Reviewed by Alexey Proskuryakov.

ImageDiff should be built for the default SDK and default architecture when
the SDKROOT is set to either iOS device or iOS simulator. Check the
DO_NOT_BUILD_IMAGE_DIFF flag to skip the ImageDiff build.

ImageDiff/Makefile: Use Mac SDK when building for iOS Simulator or iOS device.
Makefile: Do not build ImageDiff if the DO_NOT_BUILD_IMAGE_DIFF flag is set.

11:05 AM Changeset in webkit [216527] by matthew_hanson@apple.com

5 edits
2 adds in branches/safari-603-branch

Cherry-pick r216431. rdar://problem/31971208

11:05 AM Changeset in webkit [216526] by matthew_hanson@apple.com

4 edits in branches/safari-603-branch/Source/JavaScriptCore

Cherry-pick r216309. rdar://problem/31971364

11:05 AM Changeset in webkit [216525] by matthew_hanson@apple.com

3 edits
2 adds in branches/safari-603-branch

Cherry-pick r216120. rdar://problem/31970955

11:05 AM Changeset in webkit [216524] by matthew_hanson@apple.com

6 edits
2 adds in branches/safari-603-branch

Cherry-pick r216096. rdar://problem/31971264

11:05 AM Changeset in webkit [216523] by matthew_hanson@apple.com

3 edits
2 adds in branches/safari-603-branch

Cherry-pick r216023. rdar://problem/31971371

11:05 AM Changeset in webkit [216522] by matthew_hanson@apple.com

3 edits
2 adds in branches/safari-603-branch

Cherry-pick r215971. rdar://problem/31971140

11:05 AM Changeset in webkit [216521] by matthew_hanson@apple.com

3 edits
1 add in branches/safari-603-branch

Cherry-pick r215596. rdar://problem/31971150

11:05 AM Changeset in webkit [216520] by matthew_hanson@apple.com

3 edits in branches/safari-603-branch/Source/WebCore

Cherry-pick r215528. rdar://problem/31971331

11:05 AM Changeset in webkit [216519] by matthew_hanson@apple.com

3 edits
1 add in branches/safari-603-branch

Cherry-pick r215351. rdar://problem/31631922

11:04 AM Changeset in webkit [216518] by matthew_hanson@apple.com

3 edits in branches/safari-603-branch/Source/WebCore

Cherry-pick r214554. rdar://problem/31971164

11:02 AM Changeset in webkit [216517] by mmaxfield@apple.com

3 edits
2 adds in trunk

font-stretch: normal selects expanded fonts instead of condensed fonts
https://bugs.webkit.org/show_bug.cgi?id=171838
<rdar://problem/31005481>

Reviewed by Jon Lee.

Source/WebCore:

CSS Fonts level 3 says: "If the value of ‘font-stretch’ is ‘normal’ or one of the condensed
values, narrower width values are checked first, then wider values."

CSS Fonts level 4 erroneously was incompatible with this, but was updated in
https://github.com/w3c/csswg-drafts/commit/4559389d183bbaaf3321af5ba1c924caa7c488bb
to be consistent with this.

Now, CSS Fonts level 4 states: "If the desired stretch value is less than or equal to100,
stretch values below the desired stretch value are checked in descending order followed by
stretch values above the desired stretch value in ascending order"

Test: fast/text/font-width-100.html

platform/graphics/FontSelectionAlgorithm.cpp:

LayoutTests:

fast/text/font-width-100-expected.html: Added.
fast/text/font-width-100.html: Added.

10:56 AM Changeset in webkit [216516] by jmarcell@apple.com

7 edits in branches/safari-604.1.21-branch/Source

Versioning.

10:36 AM Changeset in webkit [216515] by Matt Lewis

2 edits in trunk/LayoutTests

Mark storage/indexeddb/modern/idbtransaction-objectstore-failures.html as flaky.
https://bugs.webkit.org/show_bug.cgi?id=171862

Unreviewed test gardening.

platform/mac-wk2/TestExpectations:

10:34 AM Changeset in webkit [216514] by Matt Lewis

2 edits in trunk/Tools

Unreviewed, adding myself to contributors.json

Scripts/webkitpy/common/config/contributors.json:

10:15 AM Changeset in webkit [216513] by commit-queue@webkit.org

15 edits
5 adds in trunk

[Readable Streams API] Enable creation of ReadableStreamBYOBReader
https://bugs.webkit.org/show_bug.cgi?id=171665

Patch by Romain Bellessort <romain.bellessort@crf.canon.fr> on 2017-05-09
Reviewed by Youenn Fablet.
LayoutTests/imported/w3c:

Updated expectations.

web-platform-tests/streams/readable-byte-streams/general-expected.txt:
web-platform-tests/streams/readable-byte-streams/general.dedicatedworker-expected.txt:

Source/WebCore:

Enabled the creation of ReadableStreamBYOBReader.

Test: streams/readable-stream-byob-reader.html

CMakeLists.txt: Updated to support ReadableStreamBYOBReader.
DerivedSources.cpp: Updated to support ReadableStreamBYOBReader.
DerivedSources.make: Updated to support ReadableStreamBYOBReader.
Modules/streams/ReadableByteStreamInternals.js: Updated to support ReadableStreamBYOBReader.

(privateInitializeReadableStreamBYOBReader):
(isReadableStreamBYOBReader):

Modules/streams/ReadableStream.js: Updated to support ReadableStreamBYOBReader.

(getReader):

Modules/streams/ReadableStreamBYOBReader.idl: Added.
Modules/streams/ReadableStreamBYOBReader.js: Added.

(cancel): To be implemented.
(read): To be implemented.
(releaseLock): To be implemented.
(closed): To be implemented.

WebCore.xcodeproj/project.pbxproj: Updated to support ReadableStreamBYOBReader.
bindings/js/JSDOMGlobalObject.cpp: Updated to support ReadableStreamBYOBReader.

(WebCore::JSDOMGlobalObject::addBuiltinGlobals):

bindings/js/JSReadableStreamPrivateConstructors.cpp: Updated to support ReadableStreamBYOBReader.

(WebCore::constructJSReadableStreamReaderGeneric):
(WebCore::constructJSReadableStreamDefaultReader):
(WebCore::constructJSReadableStreamBYOBReader):
(WebCore::JSBuiltinReadableStreamBYOBReaderPrivateConstructor::initializeExecutable):
(WebCore::createReadableStreamBYOBReaderPrivateConstructor):

bindings/js/JSReadableStreamPrivateConstructors.h: Updated to support ReadableStreamBYOBReader.
bindings/js/WebCoreBuiltinNames.h: Updated to support ReadableStreamBYOBReader.

LayoutTests:

Added test to check the creation of ReadableStreamBYOBReader. Also check
that created object has the right methods and properties.

streams/readable-stream-byob-reader-expected.txt: Added.
streams/readable-stream-byob-reader.html: Added.
streams/readable-stream-byob-reader.js: Added.

10:11 AM Changeset in webkit [216512] by mark.lam@apple.com

2 edits in trunk/Source/WTF

Force StaticStringImpl constructor to use the constexpr versions of StringImplShape constructors.
https://bugs.webkit.org/show_bug.cgi?id=171861

Reviewed by Yusuke Suzuki.

This is strictly necessary for correctness of the StaticStringImpl implementation.
We force the constructor selection by adding an extra dummy argument to the
constexpr versions of the StringImplShape constructors to disambiguate them from
the non-constexpr versions.

wtf/text/StringImpl.h:

(WTF::StringImplShape::StringImplShape):
(WTF::StringImpl::StaticStringImpl::StaticStringImpl):

10:10 AM Changeset in webkit [216511] by commit-queue@webkit.org

36 edits in trunk

Print more properties in the output of scrolling trees
https://bugs.webkit.org/show_bug.cgi?id=171858

Patch by Frederic Wang <fwang@igalia.com> on 2017-05-09
Reviewed by Simon Fraser.

Source/WebCore:

No new tests, no behavior changes.

page/scrolling/ScrollingCoordinator.cpp: Implement << operator to print ScrollableAreaParameters.

(WebCore::operator<<):

page/scrolling/ScrollingCoordinator.h: Declare new << operator.
page/scrolling/ScrollingStateFrameScrollingNode.cpp: Print new properties.

(WebCore::ScrollingStateFrameScrollingNode::dumpProperties):

page/scrolling/ScrollingStateScrollingNode.cpp: ditto.

(WebCore::ScrollingStateScrollingNode::dumpProperties):

page/scrolling/ScrollingTreeScrollingNode.cpp: ditto.

(WebCore::ScrollingTreeScrollingNode::dumpProperties):

LayoutTests:

Update text expectations to include new properties.

fast/scrolling/ios/remove-scrolling-role-expected.txt:
fast/visual-viewport/tiled-drawing/zoomed-fixed-scrolled-down-expected.txt:
fast/visual-viewport/tiled-drawing/zoomed-fixed-scrolled-down-then-up-expected.txt:
fast/visual-viewport/tiled-drawing/zoomed-fixed-scrolling-layers-state-expected.txt:
tiled-drawing/scrolling/clamp-out-of-bounds-scrolls-expected.txt:
tiled-drawing/scrolling/fixed/absolute-inside-fixed-expected.txt:
tiled-drawing/scrolling/fixed/absolute-inside-out-of-view-fixed-expected.txt:
tiled-drawing/scrolling/fixed/fixed-in-overflow-expected.txt:
tiled-drawing/scrolling/fixed/fixed-position-out-of-view-expected.txt:
tiled-drawing/scrolling/fixed/fixed-position-out-of-view-negative-zindex-expected.txt:
tiled-drawing/scrolling/fixed/four-bars-expected.txt:
tiled-drawing/scrolling/fixed/four-bars-with-header-and-footer-expected.txt:
tiled-drawing/scrolling/fixed/four-bars-zoomed-expected.txt:
tiled-drawing/scrolling/fixed/negative-scroll-offset-expected.txt:
tiled-drawing/scrolling/fixed/negative-scroll-offset-in-view-expected.txt:
tiled-drawing/scrolling/fixed/nested-fixed-expected.txt:
tiled-drawing/scrolling/fixed/percentage-inside-fixed-expected.txt:
tiled-drawing/scrolling/frames/coordinated-frame-expected.txt:
tiled-drawing/scrolling/frames/coordinated-frame-gain-scrolling-ancestor-expected.txt:
tiled-drawing/scrolling/frames/coordinated-frame-in-fixed-expected.txt:
tiled-drawing/scrolling/frames/coordinated-frame-lose-scrolling-ancestor-expected.txt:
tiled-drawing/scrolling/frames/fixed-inside-frame-expected.txt:
tiled-drawing/scrolling/frames/remove-coordinated-frame-expected.txt:
tiled-drawing/scrolling/frames/scroll-region-after-frame-layout-expected.txt:
tiled-drawing/scrolling/scrolling-tree-after-scroll-expected.txt:
tiled-drawing/scrolling/scrolling-tree-slow-scrolling-expected.txt:
tiled-drawing/scrolling/sticky/negative-scroll-offset-expected.txt:
tiled-drawing/scrolling/sticky/sticky-horizontal-expected.txt:
tiled-drawing/scrolling/sticky/sticky-vertical-expected.txt:

9:51 AM Changeset in webkit [216510] by Chris Dumez

9 edits
2 adds in trunk

ontransitionend eventHandler should be in GlobalEventHandlers
https://bugs.webkit.org/show_bug.cgi?id=171836

Reviewed by Ryosuke Niwa.

Source/WebCore:

ontransitionend eventHandler should be in GlobalEventHandlers:

https://drafts.csswg.org/css-transitions/#interface-globaleventhandlers-idl

WebKit currently has in on Window and Element only. Firefox matches the specification.

Test: fast/css/ontransitionend-eventhandler.html

dom/Element.idl:
dom/GlobalEventHandlers.idl:
page/DOMWindow.idl:

LayoutTests:

fast/css/ontransitionend-eventhandler-expected.txt: Added.
fast/css/ontransitionend-eventhandler.html: Added.

Add layout test coverage.

fast/dom/event-handler-attributes-expected.txt:
fast/dom/event-handler-attributes.html:
js/dom/dom-static-property-for-in-iteration-expected.txt:

Rebaseline existing tests to reflect behavior change.

9:00 AM Changeset in webkit [216509] by nael.ouedraogo@crf.canon.fr

4 edits in trunk/Source/WebCore

MediaSource.readyState should use an IDL enum
https://bugs.webkit.org/show_bug.cgi?id=171672

Reviewed by Eric Carlson and Chris Dumez.

MediaSource.readyState should use an IDL enum as per specification
(https://www.w3.org/TR/2016/CR-media-source-20160503/#idl-def-ReadyState).

No new tests required since no behavior change.

Modules/mediasource/MediaSource.cpp:

(WebCore::toString):
(WebCore::MediaSource::MediaSource):
(WebCore::MediaSource::setPrivateAndOpen):
(WebCore::MediaSource::buffered):
(WebCore::MediaSource::setReadyState):
(WebCore::MediaSource::streamEndedWithError):
(WebCore::MediaSource::isOpen):
(WebCore::MediaSource::isClosed):
(WebCore::MediaSource::isEnded):
(WebCore::MediaSource::detachFromElement):
(WebCore::MediaSource::openIfInEndedState):
(WebCore::MediaSource::stop):
(WebCore::MediaSource::onReadyStateChange):

Modules/mediasource/MediaSource.h:
Modules/mediasource/MediaSource.idl:

8:58 AM Changeset in webkit [216508] by nael.ouedraogo@crf.canon.fr

5 edits
2 adds in trunk

Invalid MediaSource duration value should throw TyperError instead of InvalidStateError
https://bugs.webkit.org/show_bug.cgi?id=171653

Reviewed by Youenn Fablet.

Modify MediaSource::setDuration to throw a TypeError when duration value is invalid as per MSE specification
(https://www.w3.org/TR/2016/REC-media-source-20161117/#dom-mediasource-duration).

Update expectation of corresponding WPT test.

Source/WebCore:

Modules/mediasource/MediaSource.cpp:

(WebCore::MediaSource::setDuration):
(WebCore::MediaSource::setDurationInternal):

LayoutTests:

platform/gtk/TestExpectations:
platform/gtk/imported/w3c/web-platform-tests/media-source/mediasource-duration-boundaryconditions-expected.txt: Added.
platform/mac/TestExpectations:
platform/mac/imported/w3c/web-platform-tests/media-source/mediasource-duration-boundaryconditions-expected.txt: Added.

8:06 AM Changeset in webkit [216507] by Yusuke Suzuki

3 edits in trunk/Source/WebCore

Unreviewed, update binding-tests results
https://bugs.webkit.org/show_bug.cgi?id=166752

bindings/scripts/test/JS/JSTestNode.cpp:
bindings/scripts/test/JS/JSTestObj.cpp:

8:04 AM Changeset in webkit [216506] by Chris Dumez

3 edits in trunk/Source/WebCore

Update DocumentOrShadowRoot.idl to match specifications
https://bugs.webkit.org/show_bug.cgi?id=171845

Reviewed by Ryosuke Niwa.

Update DocumentOrShadowRoot.idl to match specifications:

No Web-facing behavior change. Things that do not match the specification were merely
annotated with FIXME comments.

dom/Document.idl:
dom/DocumentOrShadowRoot.idl:

7:53 AM Changeset in webkit [216505] by Jonathan Bedard

2 edits in trunk/Tools

REGRESSION: ImageDiff not building with make
https://bugs.webkit.org/show_bug.cgi?id=171788

Reviewed by Alex Christensen.

Makefile: Build ImageDiff for all platforms.

7:50 AM Changeset in webkit [216504] by commit-queue@webkit.org

4 edits in trunk/Tools

[Win] ImageDiff isn't built since Bug 168945
https://bugs.webkit.org/show_bug.cgi?id=171847

Patch by Fujii Hironori <Fujii Hironori> on 2017-05-09
Reviewed by Alex Christensen.

CMakeLists.txt: Add 'ImageDiff' sub-directory to build if WIN32.
ImageDiff/ImageDiff.cpp: Include some header files to fix compilation errors.
ImageDiff/PlatformWin.cmake: Define USE_CAIRO if WinCairo port.

6:00 AM Changeset in webkit [216503] by Yusuke Suzuki

2 edits in trunk/Source/WebCore

Unreviewed, attempt to fix macOS ports using ApplePay
https://bugs.webkit.org/show_bug.cgi?id=166752

bindings/scripts/CodeGeneratorJS.pm:

(GenerateImplementation):

5:38 AM Changeset in webkit [216502] by commit-queue@webkit.org

7 edits in trunk/Source

[Coordinated Graphics] Debug Visuals don't hide
https://bugs.webkit.org/show_bug.cgi?id=162704

Patch by Yoshiaki Jitsukawa <Yoshiaki.Jitsukawa@sony.com> on 2017-05-09
Reviewed by Žan Doberšek.

Source/WebCore:

platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp:

(WebCore::CoordinatedGraphicsLayer::setShowDebugBorder):
(WebCore::CoordinatedGraphicsLayer::setShowRepaintCounter):
(WebCore::CoordinatedGraphicsLayer::syncLayerState):
(WebCore::CoordinatedGraphicsLayer::setDebugBorder):
showDebugBorders() and showRepaintCounter() of CoordinatedGraphicsLayer should reflect
the "show" argument to the layer state.

platform/graphics/texmap/coordinated/CoordinatedGraphicsState.h:

(WebCore::DebugVisuals::DebugVisuals):
(WebCore::CoordinatedGraphicsLayerState::CoordinatedGraphicsLayerState):
To set the debug visuals of a layer, the visibility flags of the borders and the repaint
counters as well as the border width and color are needed. Thus a new bundle struct
DebugVisuals and its change flag debugVisualsChanged have been introduced in order to
send the information at once.

Source/WebKit2:

Shared/CoordinatedGraphics/CoordinatedGraphicsArgumentCoders.cpp:

(IPC::ArgumentCoder<CoordinatedGraphicsLayerState>::encode):
(IPC::ArgumentCoder<CoordinatedGraphicsLayerState>::decode):
(IPC::ArgumentCoder<DebugVisuals>::encode):
(IPC::ArgumentCoder<DebugVisuals>::decode):
The encoder and decoder for DebugVisuals have been added.

Shared/CoordinatedGraphics/CoordinatedGraphicsArgumentCoders.h:
Shared/CoordinatedGraphics/CoordinatedGraphicsScene.cpp:

(WebKit::CoordinatedGraphicsScene::setLayerState):
Update the debug visuals of a layer according to the DebugVisuals information
if the debugVisualsChanged flag is set to true.

5:17 AM Changeset in webkit [216501] by Yusuke Suzuki

59 edits
2 copies
1 move
4 adds in trunk

Handle IDLPromise<> properly
https://bugs.webkit.org/show_bug.cgi?id=166752

Reviewed by Youenn Fablet.

Source/JavaScriptCore:

Add JSPromise::resolve static function.
This applies Promise.resolve() conversion to a given value.

runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::init):
(JSC::JSGlobalObject::visitChildren):

runtime/JSGlobalObject.h:

(JSC::JSGlobalObject::promiseResolveFunction):

runtime/JSPromise.cpp:

(JSC::JSPromise::resolve):

runtime/JSPromise.h:

Source/WebCore:

This patch implements WebIDL Promise type conversion. According to the spec,
Promise takes a value and convert it to Promise by using Promise.resolve function.
We implement JSPromise::resolve in JSC and use it in JSDOMConvertPromise.

In conversion phase, we just convert the value to JSC::JSPromise* and hold it in
PromiseRejectionEvent. On the other hand, In this patch, we newly introduce a new
type DOMPromise and use it in RejectedPromiseTracker. And we also rename the previous
DOMPromise to DOMPromiseDeferred since it is corresponding to JSPromiseDeferred.
DOMPromise is DOMGuarded object. So it is strongly referenced from ScriptExecutionContext
and it is weakly referenced from the object itself. This is important since Strong<JSPromise>
reference in C++ object that has a wrapper (in this case, PromiseRejectionEvent) easily causes
cyclic reference. We hold it as DOMPromise instead of Strong<JSPromise> in RejectedPromiseTracker
to break the cyclic reference edge with weak reference.

In the meantime, we still use JSC::Strong<> in PromiseRejectionEvent. It leaks memory if promise
refers the wrapper object of PromiseRejectionEvent. CustomEvent also has the same problem.
This is a general problem that attribute any can create cyclic reference. And they should be
fixed in a different patch.

Currently, we do not take the following approach. e.g. There is C++ object that represents Promise.
And its wrapper object is JSPromise thing. When exposing the C++ object, it will be converted to a
wrapper object. We do not take this approach because PromiseRejectionEvent can take user-provided promise.
For example, users can create PromiseRejectionEvent in a form
new PromiseRejectionEvent("...", { promise: promise }). In this case, event.promise === promise
is required. And this is not suitable for the above C++ object model.

Large part of this patch is mechanical one to replace DOMPromise with DOMPromiseDeferred.

CMakeLists.txt:
Modules/applepay/ApplePaySession.cpp:
Modules/encryptedmedia/MediaKeySession.h:
Modules/encryptedmedia/MediaKeySystemAccess.h:
Modules/encryptedmedia/MediaKeys.h:
Modules/encryptedmedia/NavigatorEME.h:
Modules/fetch/DOMWindowFetch.h:
Modules/fetch/FetchBody.h:
Modules/fetch/FetchBodyConsumer.h:
Modules/fetch/FetchResponse.h:
Modules/fetch/WorkerGlobalScopeFetch.h:
Modules/mediastream/MediaDevices.h:
Modules/mediastream/MediaEndpointPeerConnection.cpp:

(WebCore::MediaEndpointPeerConnection::replaceTrack):
(WebCore::MediaEndpointPeerConnection::replaceTrackTask):

Modules/mediastream/MediaEndpointPeerConnection.h:
Modules/mediastream/MediaStreamTrack.cpp:

(WebCore::MediaStreamTrack::applyConstraints):

Modules/mediastream/MediaStreamTrack.h:
Modules/mediastream/PeerConnectionBackend.cpp:

(WebCore::PeerConnectionBackend::setLocalDescription):
(WebCore::PeerConnectionBackend::setRemoteDescription):
(WebCore::PeerConnectionBackend::addIceCandidate):

Modules/mediastream/PeerConnectionBackend.h:

(WebCore::PeerConnectionBackend::endOfIceCandidates):

Modules/mediastream/RTCPeerConnection.cpp:

(WebCore::RTCPeerConnection::queuedSetLocalDescription):
(WebCore::RTCPeerConnection::queuedSetRemoteDescription):
(WebCore::RTCPeerConnection::queuedAddIceCandidate):
(WebCore::RTCPeerConnection::enqueueReplaceTrackTask):
(WebCore::RTCPeerConnection::replaceTrack):

Modules/mediastream/RTCPeerConnection.h:
Modules/mediastream/RTCRtpSender.cpp:

(WebCore::RTCRtpSender::replaceTrack):

Modules/mediastream/RTCRtpSender.h:
Modules/mediastream/UserMediaRequest.cpp:

(WebCore::UserMediaRequest::start):
(WebCore::UserMediaRequest::UserMediaRequest):

Modules/mediastream/UserMediaRequest.h:
Modules/mediastream/libwebrtc/LibWebRTCPeerConnectionBackend.cpp:

(WebCore::LibWebRTCPeerConnectionBackend::replaceTrack):

Modules/mediastream/libwebrtc/LibWebRTCPeerConnectionBackend.h:
Modules/streams/ReadableStreamSource.h:

(WebCore::ReadableStreamSource::start):
(WebCore::ReadableStreamSource::pull):

Modules/webaudio/AudioContext.cpp:

(WebCore::AudioContext::addReaction):
(WebCore::AudioContext::setState):
(WebCore::AudioContext::suspend):
(WebCore::AudioContext::resume):
(WebCore::AudioContext::close):

Modules/webaudio/AudioContext.h:
WebCore.xcodeproj/project.pbxproj:
bindings/IDLTypes.h:
bindings/js/CachedModuleScriptLoaderClient.h:
bindings/js/JSBindingsAllInOne.cpp:
bindings/js/JSCustomElementRegistryCustom.cpp:
bindings/js/JSDOMConvertPromise.h:

(WebCore::Converter<IDLPromise<T>>::convert):
(WebCore::JSConverter<IDLPromise<T>>::convert):

bindings/js/JSDOMExceptionHandling.cpp:
bindings/js/JSDOMGlobalObject.cpp:
bindings/js/JSDOMGuardedObject.h:
bindings/js/JSDOMPromise.h:

(WebCore::DOMPromise::create):
(WebCore::DOMPromise::promise):
(WebCore::DOMPromise::DOMPromise):
(WebCore::DeferredPromise::create): Deleted.
(WebCore::DeferredPromise::resolve): Deleted.
(WebCore::DeferredPromise::resolveWithNewlyCreated): Deleted.
(WebCore::DeferredPromise::reject): Deleted.
(WebCore::DeferredPromise::resolveWithCallback): Deleted.
(WebCore::DeferredPromise::rejectWithCallback): Deleted.
(WebCore::DeferredPromise::DeferredPromise): Deleted.
(WebCore::DeferredPromise::deferred): Deleted.
(WebCore::DOMPromiseBase::DOMPromiseBase): Deleted.
(WebCore::DOMPromiseBase::operator=): Deleted.
(WebCore::DOMPromiseBase::reject): Deleted.
(WebCore::DOMPromiseBase::rejectType): Deleted.
(WebCore::DOMPromiseBase::promise): Deleted.
(WebCore::DOMPromise::resolve): Deleted.
(WebCore::DOMPromise<void>::resolve): Deleted.
(WebCore::callPromiseFunction): Deleted.
(WebCore::bindingPromiseFunctionAdapter): Deleted.

bindings/js/JSDOMPromiseDeferred.cpp: Renamed from Source/WebCore/bindings/js/JSDOMPromise.cpp.

(WebCore::DeferredPromise::promise):
(WebCore::DeferredPromise::callFunction):
(WebCore::DeferredPromise::reject):
(WebCore::rejectPromiseWithExceptionIfAny):
(WebCore::createDeferredPromise):
(WebCore::createRejectedPromiseWithTypeError):
(WebCore::parseAsJSON):
(WebCore::fulfillPromiseWithJSON):
(WebCore::fulfillPromiseWithArrayBuffer):

bindings/js/JSDOMPromiseDeferred.h: Copied from Source/WebCore/bindings/js/JSDOMPromise.h.

(WebCore::DeferredPromise::create):
(WebCore::DeferredPromise::resolve):
(WebCore::DeferredPromise::resolveWithNewlyCreated):
(WebCore::DeferredPromise::reject):
(WebCore::DeferredPromise::resolveWithCallback):
(WebCore::DeferredPromise::rejectWithCallback):
(WebCore::DeferredPromise::DeferredPromise):
(WebCore::DeferredPromise::deferred):
(WebCore::DOMPromiseDeferredBase::DOMPromiseDeferredBase):
(WebCore::DOMPromiseDeferredBase::operator=):
(WebCore::DOMPromiseDeferredBase::reject):
(WebCore::DOMPromiseDeferredBase::rejectType):
(WebCore::DOMPromiseDeferredBase::promise):
(WebCore::DOMPromiseDeferred::resolve):
(WebCore::DOMPromiseDeferred<void>::resolve):
(WebCore::callPromiseFunction):
(WebCore::bindingPromiseFunctionAdapter):

bindings/js/JSSubtleCryptoCustom.cpp:
bindings/js/JSWebGPUCommandBufferCustom.cpp:
bindings/js/JSWebKitSubtleCryptoCustom.cpp:
bindings/scripts/test/JS/JSTestPromiseRejectionEvent.cpp: Added.

(WebCore::convertDictionary<TestPromiseRejectionEvent::Init>):
(WebCore::JSTestPromiseRejectionEventPrototype::create):
(WebCore::JSTestPromiseRejectionEventPrototype::createStructure):
(WebCore::JSTestPromiseRejectionEventPrototype::JSTestPromiseRejectionEventPrototype):
(WebCore::JSTestPromiseRejectionEventConstructor::construct):
(WebCore::JSTestPromiseRejectionEventConstructor::prototypeForStructure):
(WebCore::JSTestPromiseRejectionEventConstructor::initializeProperties):
(WebCore::JSTestPromiseRejectionEventPrototype::finishCreation):
(WebCore::JSTestPromiseRejectionEvent::JSTestPromiseRejectionEvent):
(WebCore::JSTestPromiseRejectionEvent::finishCreation):
(WebCore::JSTestPromiseRejectionEvent::createPrototype):
(WebCore::JSTestPromiseRejectionEvent::prototype):
(WebCore::BindingCaller<JSTestPromiseRejectionEvent>::castForAttribute):
(WebCore::jsTestPromiseRejectionEventPromise):
(WebCore::jsTestPromiseRejectionEventPromiseGetter):
(WebCore::jsTestPromiseRejectionEventReason):
(WebCore::jsTestPromiseRejectionEventReasonGetter):
(WebCore::jsTestPromiseRejectionEventConstructor):
(WebCore::setJSTestPromiseRejectionEventConstructor):
(WebCore::JSTestPromiseRejectionEvent::getConstructor):
(WebCore::toJSNewlyCreated):
(WebCore::toJS):

bindings/scripts/test/JS/JSTestPromiseRejectionEvent.h: Added.

(WebCore::JSTestPromiseRejectionEvent::create):
(WebCore::JSTestPromiseRejectionEvent::createStructure):
(WebCore::JSTestPromiseRejectionEvent::wrapped):
(WebCore::toJS):
(WebCore::toJSNewlyCreated):

bindings/scripts/test/TestPromiseRejectionEvent.idl: Copied from Source/WebCore/bindings/js/CachedModuleScriptLoaderClient.h.
css/FontFace.h:
css/FontFaceSet.h:
dom/CustomElementRegistry.h:
dom/PromiseRejectionEvent.h:
dom/RejectedPromiseTracker.cpp:

(WebCore::UnhandledPromise::UnhandledPromise):
(WebCore::UnhandledPromise::callStack):
(WebCore::UnhandledPromise::promise):
(WebCore::RejectedPromiseTracker::promiseRejected):
(WebCore::RejectedPromiseTracker::promiseHandled):
(WebCore::RejectedPromiseTracker::reportUnhandledRejections):
(WebCore::RejectedPromiseTracker::reportRejectionHandled):
(WebCore::RejectedPromise::RejectedPromise): Deleted.
(WebCore::RejectedPromise::globalObject): Deleted.
(WebCore::RejectedPromise::promise): Deleted.

dom/RejectedPromiseTracker.h:
html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::rejectPendingPlayPromises):
(WebCore::HTMLMediaElement::resolvePendingPlayPromises):
(WebCore::HTMLMediaElement::play):

html/HTMLMediaElement.h:
platform/graphics/gpu/GPUCommandBuffer.h:
testing/Internals.h:

LayoutTests:

js/dom/promise-rejection-event-should-follow-webidl-promise-conversion-rule-expected.txt: Added.
js/dom/promise-rejection-event-should-follow-webidl-promise-conversion-rule.html: Added.

5:03 AM Changeset in webkit [216500] by zandobersek@gmail.com

1 edit
3007 adds in trunk/LayoutTests

Unreviewed. Landing the WPE layout test baselines.

Baseline filenames are omitted for brevity.

platform/wpe/TestExpectations: Added.
platform/wpe/animations/: Added.
platform/wpe/css1/: Added.
platform/wpe/css2.1/: Added.
platform/wpe/css3/: Added.
platform/wpe/fast/: Added.
platform/wpe/ietestcenter/: Added.
platform/wpe/js/: Added.
platform/wpe/scrollbars/: Added.
platform/wpe/security/: Added.
platform/wpe/sputnik/: Added.
platform/wpe/tables/: Added.
platform/wpe/transforms/: Added.
platform/wpe/transitions/: Added.

4:14 AM Changeset in webkit [216499] by Carlos Garcia Campos

1 copy in releases/WebKitGTK/webkit-2.14.7

WebKitGTK+ 2.14.7

4:09 AM Changeset in webkit [216498] by Carlos Garcia Campos

4 edits in releases/WebKitGTK/webkit-2.14

Unreviewed. Update OptionsGTK.cmake and NEWS for 2.14.7 release.

Source/cmake/OptionsGTK.cmake: Bump version numbers.

Source/WebKit2:

gtk/NEWS: Add release notes for 2.14.7.

4:07 AM Changeset in webkit [216497] by zandobersek@gmail.com

95 edits
130 adds in trunk

Upstream the WPE port
https://bugs.webkit.org/show_bug.cgi?id=171110

Reviewed by Alex Christensen.

webkit-dev thread:
https://lists.webkit.org/pipermail/webkit-dev/2017-April/028923.html

CMakeLists.txt: Add the WPE port identifier.
Source/cmake/FindLibGBM.cmake: Added.
Source/cmake/FindWPEBackend-mesa.cmake: Added.
Source/cmake/FindWPEBackend.cmake: Added.
Source/cmake/OptionsWPE.cmake: Added.

Source/JavaScriptCore:

PlatformWPE.cmake: Added.
shell/PlatformWPE.cmake: Added.

Source/ThirdParty/ANGLE:

include/EGL/eglplatform.h:

Allow building WPE on platforms that don't provide X11 libraries.

Source/WebCore:

webkit-dev thread:
https://lists.webkit.org/pipermail/webkit-dev/2017-April/028923.html

Existing files mostly changed to properly use PLATFORM(WPE) build guards.
In-file changes removed from this ChangeLog entry for brevity.

CMakeLists.txt:
PlatformWPE.cmake: Added.
accessibility/AccessibilityObject.h:
accessibility/wpe/AXObjectCacheWPE.cpp: Added.
accessibility/wpe/AccessibilityObjectWPE.cpp: Copied from Source/WebCore/platform/audio/glib/AudioBusGLib.cpp.
config.h:
crypto/keys/CryptoKeyEC.h:
crypto/keys/CryptoKeyRSA.h:
editing/Editor.cpp:
editing/Editor.h:
editing/wpe/EditorWPE.cpp: Added.
page/EventHandler.cpp:
page/wpe/EventHandlerWPE.cpp: Added.
platform/Cursor.h:
platform/DragData.h:
platform/DragImage.h:
platform/FileSystem.h:
platform/MainThreadSharedTimer.cpp:
platform/MainThreadSharedTimer.h:
platform/Pasteboard.h:
platform/PasteboardStrategy.h:
platform/PlatformPasteboard.h:
platform/SchemeRegistry.cpp:
platform/Widget.h:
platform/audio/glib/AudioBusGLib.cpp:
platform/glib/FileSystemGlib.cpp:
platform/graphics/ANGLEWebKitBridge.h:
platform/graphics/GLContext.cpp:
platform/graphics/GLContext.h:
platform/graphics/GraphicsContext3D.h:
platform/graphics/OpenGLESShims.h:
platform/graphics/PlatformDisplay.cpp:
platform/graphics/PlatformDisplay.h:
platform/graphics/egl/GLContextEGL.cpp:
platform/graphics/egl/GLContextEGL.h:
platform/graphics/egl/GLContextEGLWPE.cpp: Copied from Source/WebCore/platform/audio/glib/AudioBusGLib.cpp.
platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:
platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:
platform/graphics/wpe/IconWPE.cpp: Copied from Source/WebKit2/Shared/DrawingAreaInfo.h.
platform/graphics/wpe/ImageWPE.cpp: Copied from Source/WebKit2/Shared/DrawingAreaInfo.h.
platform/graphics/wpe/PlatformDisplayWPE.cpp: Added.
platform/graphics/wpe/PlatformDisplayWPE.h: Added.
platform/wpe/CursorWPE.cpp: Copied from Source/WebKit2/Shared/DrawingAreaInfo.h.
platform/wpe/LocalizedStringsWPE.cpp: Copied from Source/WebKit2/Shared/DrawingAreaInfo.h.
platform/wpe/PasteboardWPE.cpp: Added.
platform/wpe/PlatformKeyboardEventWPE.cpp: Copied from Source/WebKit2/Shared/DrawingAreaInfo.h.
platform/wpe/PlatformPasteboardWPE.cpp: Added.
platform/wpe/PlatformScreenWPE.cpp: Copied from Source/WebKit2/Shared/DrawingAreaInfo.h.
platform/wpe/RenderThemeWPE.cpp: Copied from Source/WebKit2/Shared/NativeWebWheelEvent.h.
platform/wpe/RenderThemeWPE.h: Copied from Source/WebKit2/Shared/DrawingAreaInfo.h.
platform/wpe/ScrollbarThemeWPE.cpp: Copied from Source/WebKit2/Shared/DrawingAreaInfo.h.
platform/wpe/ScrollbarThemeWPE.h: Copied from Source/WebKit2/Shared/DrawingAreaInfo.h.
platform/wpe/SoundWPE.cpp: Copied from Source/WebKit2/Shared/DrawingAreaInfo.h.
platform/wpe/ThemeWPE.cpp: Added.
platform/wpe/ThemeWPE.h: Copied from Source/WebKit2/Shared/DrawingAreaInfo.h.
platform/wpe/WidgetWPE.cpp: Copied from Source/WebKit2/Shared/DrawingAreaInfo.h.

Source/WebCore/PAL:

pal/PlatformWPE.cmake: Added.

Source/WebKit2:

webkit-dev thread:
https://lists.webkit.org/pipermail/webkit-dev/2017-April/028923.html

Existing files changed to properly use PLATFORM(WPE) build guards or other
WPE-specific additions (e.g. pasteboard support).
In-file changes removed from this ChangeLog entry for brevity.

Platform/IPC/glib/GSocketMonitor.cpp:
PlatformWPE.cmake: Added.
Scripts/generate-forwarding-headers.pl:
Shared/API/c/WKBase.h:
Shared/API/c/wpe/WKBaseWPE.h: Copied from Source/WebKit2/Shared/DrawingAreaInfo.h.
Shared/API/c/wpe/WebKit.h: Added.
Shared/CoordinatedGraphics/threadedcompositor/CompositingRunLoop.cpp:
Shared/CoordinatedGraphics/threadedcompositor/CompositingRunLoop.h:
Shared/CoordinatedGraphics/threadedcompositor/ThreadedCompositor.cpp:
Shared/CoordinatedGraphics/threadedcompositor/ThreadedCompositor.h:
Shared/DrawingAreaInfo.h:
Shared/NativeWebKeyboardEvent.h:
Shared/NativeWebMouseEvent.h:
Shared/NativeWebTouchEvent.h:
Shared/NativeWebWheelEvent.h:
Shared/WebCoreArgumentCoders.cpp:
Shared/WebCoreArgumentCoders.h:
Shared/WebPreferencesDefinitions.h:
Shared/wpe/NativeWebKeyboardEventWPE.cpp: Copied from Source/WebKit2/Shared/DrawingAreaInfo.h.
Shared/wpe/NativeWebMouseEventWPE.cpp: Copied from Source/WebKit2/Shared/DrawingAreaInfo.h.
Shared/wpe/NativeWebTouchEventWPE.cpp: Copied from Source/WebKit2/Shared/DrawingAreaInfo.h.
Shared/wpe/NativeWebWheelEventWPE.cpp: Copied from Source/WebKit2/Shared/DrawingAreaInfo.h.
Shared/wpe/ProcessExecutablePathWPE.cpp: Added.
Shared/wpe/WebEventFactory.cpp: Added.
Shared/wpe/WebEventFactory.h: Copied from Source/WebKit2/Shared/DrawingAreaInfo.h.
UIProcess/API/C/WKAPICast.h:
UIProcess/API/C/wpe/WKAPICastWPE.h: Copied from Source/WebKit2/Shared/DrawingAreaInfo.h.
UIProcess/API/C/wpe/WKView.cpp: Copied from Source/WebKit2/Shared/DrawingAreaInfo.h.
UIProcess/API/C/wpe/WKView.h: Copied from Source/WebKit2/Shared/NativeWebWheelEvent.h.
UIProcess/API/wpe/CompositingManagerProxy.cpp: Copied from Source/WebKit2/Shared/DrawingAreaInfo.h.
UIProcess/API/wpe/CompositingManagerProxy.h: Copied from Source/WebKit2/Shared/DrawingAreaInfo.h.
UIProcess/API/wpe/CompositingManagerProxy.messages.in: Added.
UIProcess/API/wpe/DrawingAreaProxyWPE.cpp: Added.
UIProcess/API/wpe/DrawingAreaProxyWPE.h: Copied from Source/WebKit2/Shared/NativeWebWheelEvent.h.
UIProcess/API/wpe/PageClientImpl.cpp: Added.
UIProcess/API/wpe/PageClientImpl.h: Added.
UIProcess/API/wpe/ScrollGestureController.cpp: Added.
UIProcess/API/wpe/ScrollGestureController.h: Copied from Source/WebKit2/Shared/DrawingAreaInfo.h.
UIProcess/API/wpe/WPEView.cpp: Added.
UIProcess/API/wpe/WPEView.h: Added.
UIProcess/API/wpe/WPEViewClient.cpp: Copied from Source/WebKit2/Shared/DrawingAreaInfo.h.
UIProcess/API/wpe/WPEViewClient.h: Copied from Source/WebKit2/Shared/DrawingAreaInfo.h.
UIProcess/API/wpe/WebKit2InspectorGResourceBundle.xml: Added.
UIProcess/ChildProcessProxy.cpp:
UIProcess/Launcher/ProcessLauncher.h:
UIProcess/Launcher/wpe/ProcessLauncherWPE.cpp: Added.
UIProcess/WebInspectorProxy.h:
UIProcess/WebPasteboardProxy.h:
UIProcess/WebPasteboardProxy.messages.in:
UIProcess/WebProcessPool.cpp:
UIProcess/wpe/TextCheckerWPE.cpp: Added.
UIProcess/wpe/WebInspectorProxyWPE.cpp: Added.
UIProcess/wpe/WebPageProxyWPE.cpp: Copied from Source/WebKit2/Shared/DrawingAreaInfo.h.
UIProcess/wpe/WebPasteboardProxyWPE.cpp: Copied from Source/WebKit2/Shared/DrawingAreaInfo.h.
UIProcess/wpe/WebPreferencesWPE.cpp: Copied from Source/WebKit2/Shared/CoordinatedGraphics/threadedcompositor/CompositingRunLoop.h.
UIProcess/wpe/WebProcessPoolWPE.cpp: Added.
WebKit2.xcodeproj/project.pbxproj:
WebKit2Prefix.h:
WebProcess/WebCoreSupport/WebEditorClient.cpp:
WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:
WebProcess/WebCoreSupport/WebPlatformStrategies.h:
WebProcess/WebCoreSupport/wpe/WebContextMenuClientWPE.cpp: Copied from Source/WebKit2/Shared/DrawingAreaInfo.h.
WebProcess/WebCoreSupport/wpe/WebEditorClientWPE.cpp: Added.
WebProcess/WebCoreSupport/wpe/WebPopupMenuWPE.cpp: Copied from Source/WebKit2/Shared/DrawingAreaInfo.h.
WebProcess/WebPage/CoordinatedGraphics/ThreadedCoordinatedLayerTreeHost.cpp:
WebProcess/WebPage/DrawingArea.cpp:
WebProcess/WebPage/WebPage.cpp:
WebProcess/WebPage/WebPage.h:
WebProcess/WebPage/wpe/CompositingManager.cpp: Copied from Source/WebKit2/Shared/DrawingAreaInfo.h.
WebProcess/WebPage/wpe/CompositingManager.h: Copied from Source/WebKit2/Shared/DrawingAreaInfo.h.
WebProcess/WebPage/wpe/DrawingAreaWPE.cpp: Added.
WebProcess/WebPage/wpe/DrawingAreaWPE.h: Added.
WebProcess/WebPage/wpe/WebInspectorUIWPE.cpp: Copied from Source/WebKit2/Shared/DrawingAreaInfo.h.
WebProcess/WebPage/wpe/WebInspectorWPE.cpp: Copied from Source/WebKit2/Shared/DrawingAreaInfo.h.
WebProcess/WebPage/wpe/WebPageWPE.cpp: Copied from Source/WebKit2/Shared/CoordinatedGraphics/threadedcompositor/CompositingRunLoop.h.
WebProcess/wpe/WebProcessMainWPE.cpp: Copied from Source/WebKit2/Shared/DrawingAreaInfo.h.
wpe/wpe-webkit.pc.in: Added.

Source/WTF:

wtf/Platform.h:
wtf/PlatformWPE.cmake: Added.
wtf/glib/RunLoopSourcePriority.h:

Tools:

webkit-dev thread:
https://lists.webkit.org/pipermail/webkit-dev/2017-April/028923.html

Add WPE support to various tooling scripts, TestWebKitAPI and WebKitTestRunner.
In-file changes removed from this ChangeLog entry for brevity.

BuildSlaveSupport/built-product-archive:
BuildSlaveSupport/test-result-archive:
CMakeLists.txt:
ImageDiff/PlatformWPE.cmake: Added.
Scripts/build-dumprendertree:
Scripts/build-webkit:
Scripts/build-webkittestrunner:
Scripts/update-webkit-libs-jhbuild:
Scripts/update-webkitwpe-libs: Added.
Scripts/webkitdirs.pm:
Scripts/webkitperl/FeatureList.pm:
Scripts/webkitpy/layout_tests/run_webkit_tests.py:
Scripts/webkitpy/port/factory.py:
Scripts/webkitpy/port/wpe.py: Added.
TestWebKitAPI/PlatformWPE.cmake: Added.
TestWebKitAPI/wpe/InjectedBundleControllerWPE.cpp: Copied from Source/WebKit2/Shared/DrawingAreaInfo.h.
TestWebKitAPI/wpe/PlatformUtilitiesWPE.cpp: Added.
TestWebKitAPI/wpe/main.cpp: Copied from Source/WebKit2/Shared/DrawingAreaInfo.h.
WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
WebKitTestRunner/InjectedBundle/AccessibilityController.h:
WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
WebKitTestRunner/InjectedBundle/TestRunner.cpp:
WebKitTestRunner/InjectedBundle/TestRunner.h:
WebKitTestRunner/InjectedBundle/wpe/AccessibilityControllerWPE.cpp: Added.
WebKitTestRunner/InjectedBundle/wpe/AccessibilityUIElementWPE.cpp: Added.
WebKitTestRunner/InjectedBundle/wpe/ActivateFontsWPE.cpp: Added.
WebKitTestRunner/InjectedBundle/wpe/InjectedBundleWPE.cpp: Copied from Source/WebKit2/Shared/DrawingAreaInfo.h.
WebKitTestRunner/InjectedBundle/wpe/TestRunnerWPE.cpp: Copied from Source/WebKit2/Shared/DrawingAreaInfo.h.
WebKitTestRunner/PlatformWPE.cmake: Added.
WebKitTestRunner/PlatformWebView.h:
WebKitTestRunner/TestController.cpp:
WebKitTestRunner/wpe/EventSenderProxyWPE.cpp: Added.
WebKitTestRunner/wpe/HeadlessViewBackend.cpp: Added.
WebKitTestRunner/wpe/HeadlessViewBackend.h: Copied from Source/WebKit2/Shared/CoordinatedGraphics/threadedcompositor/CompositingRunLoop.h.
WebKitTestRunner/wpe/PlatformWebViewWPE.cpp: Added.
WebKitTestRunner/wpe/TestControllerWPE.cpp: Added.
WebKitTestRunner/wpe/main.cpp: Copied from Source/WebKit2/Shared/DrawingAreaInfo.h.
jhbuild/jhbuild-wrapper:
wpe/generate-inspector-gresource-manifest.py: Added.
wpe/jhbuild.modules: Added.
wpe/jhbuildrc: Added.
wpe/patches/cairo-egl-device-create-for-egl-surface.patch: Added.
wpe/patches/fontconfig-C-11-requires-a-space-between-literal-and-identifier.patch: Added.
wpe/patches/freetype6-2.4.11-truetype-font-height-fix.patch: Added.
wpe/patches/gdate-suppress-string-format-literal-warning.patch: Added.
wpe/patches/glib-warning-fix.patch: Added.
wpe/patches/gst-plugins-bad-0001-dtls-port-to-OpenSSL-1.1.0.patch: Added.
wpe/patches/gst-plugins-bad-0002-dtlscertificate-Fix-error-checking-in-RSA_generate_k.patch: Added.
wpe/patches/gst-plugins-good-Revert-qtdemux-expose-streams-with-first-moof-for-fr.patch: Added.
wpe/patches/gst-plugins-good-use-the-tfdt-decode-time.patch: Added.
wpe/patches/gstreamer-typefind-Only-push-a-CAPS-event-downstream-if-the-.patch: Added.

3:21 AM Changeset in webkit [216496] by Carlos Garcia Campos

2 edits in releases/WebKitGTK/webkit-2.14/Source/WebCore

Merge r216343 - [GTK] Cannot sign in with new Google sign-in page
https://bugs.webkit.org/show_bug.cgi?id=171770

Reviewed by Carlos Garcia Campos.

Google's new authentication page does not work with the Firefox user
agent that's required to make various Google websites work. Special-case
accounts.google.com so that it receives our standard user agent.

platform/UserAgentQuirks.cpp:

(WebCore::isGoogle):
(WebCore::urlRequiresFirefoxBrowser):

3:21 AM Changeset in webkit [216495] by Carlos Garcia Campos

3 edits in releases/WebKitGTK/webkit-2.14

Merge r216139 - YouTube user agent quirk breaks new YouTube
https://bugs.webkit.org/show_bug.cgi?id=171603

Reviewed by Carlos Garcia Campos.

Source/WebCore:

Our user agent quirk to make YouTube 360 work breaks the new YouTube UI, causing it to
attempt to use the obsolete custom elements v0 API. WebKit only supports the v1 API. We
have to remove this quirk.

Note this does not affect Safari as Apple ports don't use our user agent quirks.

platform/UserAgentQuirks.cpp:

(WebCore::urlRequiresChromeBrowser):

Tools:

Remove the YouTube quirk test.

TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:

(TestWebKitAPI::TEST):

3:11 AM Changeset in webkit [216494] by Carlos Garcia Campos

6 edits in releases/WebKitGTK/webkit-2.14/Source/WebCore

Merge r215613 - Do not paint the border of the box if the dirty region does not intersect with border area
https://bugs.webkit.org/show_bug.cgi?id=170988

Reviewed by Simon Fraser.

No new tests, since there is no change in behavior.

platform/graphics/GeometryUtilities.cpp:

(WebCore::ellipseContainsPoint):
Checks if a point is within an ellipse.

platform/graphics/GeometryUtilities.h:

Replace header-guards with #pragma once.

platform/graphics/RoundedRect.cpp:

(WebCore::RoundedRect::contains):
Implemented to know the dirty rectangle intersects with rounded rectangle or not.

platform/graphics/RoundedRect.h:
rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::paintBorder):
When typing in decorated text box, the dirty rect generated only for the
inside of the text box, not for the decorations. So we can avoid the
calculations to draw borders if the inner border totally covers the
target surface. It will optimize the rendering process since we don't
have to render border decorations whenever we type somethings in side of
the text input element.

3:00 AM Changeset in webkit [216493] by Carlos Garcia Campos

2 edits in releases/WebKitGTK/webkit-2.14/Source/WebCore

Merge r216240 - [GStreamer] Do not report more errors after the first one
https://bugs.webkit.org/show_bug.cgi?id=171722

Reviewed by Xabier Rodriguez-Calvar.

We can receive several error messages for the same error from different elements. That's not expected by the
media source selection algorithm implementation. I don't know if didn't happen with previous versions of GST,
but since the upgrade to 1.10.4 several tests are failing because of this.

Fixes: media/video-error-does-not-exist.html

media/video-load-networkState.html
media/video-source-error.html
media/video-source-none-supported.html
media/video-source-moved.html

platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:

(WebCore::MediaPlayerPrivateGStreamer::handleMessage): Return early also when an error already occured.

2:59 AM Changeset in webkit [216492] by Carlos Garcia Campos

2 edits in releases/WebKitGTK/webkit-2.14/Source/WebCore

Merge r216239 - [GStreamer] Fix handling of gst errors in MediaPlayerPrivateGStreamer::handleMessage
https://bugs.webkit.org/show_bug.cgi?id=171721

Reviewed by Xabier Rodriguez-Calvar.

We are checking the GError only comparing the code, and ignoring the domain in some cases. Use g_error_matches()
in those cases instead of only checking the code.

platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:

(WebCore::MediaPlayerPrivateGStreamer::handleMessage):

2:58 AM Changeset in webkit [216491] by Carlos Garcia Campos

2 edits in releases/WebKitGTK/webkit-2.14/Source/WebCore

Merge r216067 - [GStreamer] Dailymotion live stream videos don't play
https://bugs.webkit.org/show_bug.cgi?id=170767

Reviewed by Sergio Villar Senin.

The video shows a message saying that an error occurred and nothing is played. There are actually several
problems with dailymotion. The main issue is that URLs are redirected by the server, and GStreamer needs to
know the redirected URL. Once GStreamer knows the redirected URL the error message no longer appears, the video
starts but it always stops after a few seconds. This is because the source receives an early EOS while still
downloading the fragments. The reason of the early EOS is because dailymotion sends a wrong Content-Length header,
something that is expected to happen and we correctly handle that case when receiving the data, by updating the
size accordingly if the bytes received are longer than the expected content length. This particular case
doesn't work well with GStreamer automatic EOS handling, which is the default. At some point, GStreamer detects
that the bytes received are at least the expected ones and emits a GST_EVENT_EOS that the GstUriDownloader
handles finishing the download early. We should always disable automatic EOS, since we know when EOS actually
happens and we already call gst_app_src_end_of_stream(). This patch also emits a GST_EVENT_CUSTOM_DOWNSTREAM_STICKY
event to let GStreamer know about the HTTP headers sent and received.

platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:

(webkit_web_src_init): Disable automatic EOS.
(webKitWebSrcGetProperty): Return the redirected URL in case of redirection.
(webKitWebSrcStart): Pass the ResourceRequest to the stream clients.
(webKitWebSrcQueryWithParent): Set the redirected URL in the query in case of redirection.
(webKitWebSrcSetUri): Clear also the redirected URL when setting a new URI.
(StreamingClient::StreamingClient): Use GRefPtr for the source and initialize the request too.
(StreamingClient::~StreamingClient): Remove explicit unref.
(StreamingClient::createReadBuffer):
(StreamingClient::handleResponseReceived): Initialize the redirected URL in case of redirection. Create and push
the HTTP headers event.
(StreamingClient::handleDataReceived):
(StreamingClient::handleNotifyFinished):
(CachedResourceStreamingClient::CachedResourceStreamingClient):
(CachedResourceStreamingClient::responseReceived):
(CachedResourceStreamingClient::accessControlCheckFailed):
(CachedResourceStreamingClient::loadFailed):
(ResourceHandleStreamingClient::ResourceHandleStreamingClient):
(ResourceHandleStreamingClient::didFail):
(ResourceHandleStreamingClient::wasBlocked):
(ResourceHandleStreamingClient::cannotShowURL):

2:58 AM Changeset in webkit [216490] by Carlos Garcia Campos

4 edits in releases/WebKitGTK/webkit-2.14/Source/WebCore

Merge r212349 - [GStreamer] Implement MediaPlayerPrivate::hasSingleSecurityOrigin()
https://bugs.webkit.org/show_bug.cgi?id=168322

Reviewed by Žan Doberšek.

It currently returns true unconditionally. Add resolved-location property to WebKitWebSourceGStreamer to track
the resolved url returned by the server and use that from MediaPlayerPrivate to check if there was a cross
origin redirection.

Fixes: http/tests/security/canvas-remote-read-remote-video-redirect.html

platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:

(WebCore::MediaPlayerPrivateGStreamer::hasSingleSecurityOrigin):

platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:
platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:

(webKitWebSrcFinalize):
(webKitWebSrcGetProperty):
(webKitWebSrcStart):
(webKitWebSrcQueryWithParent):
(webKitWebSrcGetUri):
(webKitWebSrcSetUri):
(StreamingClient::handleResponseReceived):
(ResourceHandleStreamingClient::wasBlocked):
(ResourceHandleStreamingClient::cannotShowURL):

2:58 AM Changeset in webkit [216489] by Carlos Garcia Campos

2 edits in releases/WebKitGTK/webkit-2.14/Source/WebCore

Merge r216065 - [GTK] Crash at WebCore::ResourceHandle::clearClient() when streaming live video from dailymotion
https://bugs.webkit.org/show_bug.cgi?id=169725

Reviewed by Michael Catanzaro.

Make ResourceHandleStreamingClient refcounted and add an invalidate method to do the cleanup in the networking
thread while keeping a reference.

platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:

(webKitWebSrcStop): Call invalidate before reseting client pointer.
(webKitWebSrcStart): Ditto.
(ResourceHandleStreamingClient::ResourceHandleStreamingClient): Remove all cleanup code after the run loop run call.
(ResourceHandleStreamingClient::~ResourceHandleStreamingClient): Just detach the thread.
(ResourceHandleStreamingClient::invalidate): Schedule a task on the networking thread to clean up and fiish the
run loop, protecting this.
(ResourceHandleStreamingClient::setDefersLoading): Protect this.
(ResourceHandleStreamingClient::didReceiveResponse): Do nothing if client was invalidated.
(ResourceHandleStreamingClient::didReceiveBuffer): Ditto.
(ResourceHandleStreamingClient::didFinishLoading): Ditto.

2:41 AM Changeset in webkit [216488] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

Fix property names in ScrollingTreeScrollingNode::dumpProperties
https://bugs.webkit.org/show_bug.cgi?id=171848

Patch by Frederic Wang <fwang@igalia.com> on 2017-05-09
Reviewed by Gyuyoung Kim.

No new tests, this function is only used for debugging purpose.

page/scrolling/ScrollingTreeScrollingNode.cpp:

(WebCore::ScrollingTreeScrollingNode::dumpProperties):

2:40 AM Changeset in webkit [216487] by Carlos Garcia Campos

3 edits in releases/WebKitGTK/webkit-2.14/Source/WebCore

Merge r215102 - REGRESSION(r204512): WebSocket errors with "Failed to send WebSocket frame." if too much data is sent
https://bugs.webkit.org/show_bug.cgi?id=170463

Reviewed by Michael Catanzaro.

This only reproduces when using WebSockets to communicate with an external server.
When communicating with a local server, CFWriteStreamWrite succeeds too reliably, so
CFWriteStreamCanAcceptBytes returns true, when sometimes it doesn't when communicating
across the real internet.

platform/network/cf/SocketStreamHandleImplCFNet.cpp:

(WebCore::SocketStreamHandleImpl::platformSendInternal):

platform/network/soup/SocketStreamHandleImplSoup.cpp:

(WebCore::SocketStreamHandleImpl::platformSendInternal):
Returning std::nullopt means there was an error, which is not true when the socket stream
is in a state where it cannot be written to because it is actively communicating.
Returning 0 means 0 new bytes were sent, so we will try again later.

2:00 AM Changeset in webkit [216486] by Carlos Garcia Campos

1 copy in releases/WebKitGTK/webkit-2.16.2

WebKitGTK+ 2.16.2

1:59 AM Changeset in webkit [216485] by Carlos Garcia Campos

4 edits in releases/WebKitGTK/webkit-2.16

Unreviewed. Update OptionsGTK.cmake and NEWS for 2.16.2 release.

Source/cmake/OptionsGTK.cmake: Bump version numbers.

Source/WebKit2:

gtk/NEWS: Add release notes for 2.16.2.

12:46 AM Changeset in webkit [216484] by Carlos Garcia Campos

6 edits in releases/WebKitGTK/webkit-2.16/Source

Merge r216483 - [GTK] Building Webkit2Gtk without OpenGL fails.
https://bugs.webkit.org/show_bug.cgi?id=170959

Reviewed by Žan Doberšek.

Source/WebCore:

platform/graphics/texmap/TextureMapperGC3DPlatformLayer.cpp:
platform/graphics/texmap/TextureMapperGC3DPlatformLayer.h:
platform/graphics/texmap/TextureMapperPlatformLayerBuffer.h:

Source/WebKit2:

UIProcess/gtk/HardwareAccelerationManager.cpp:

(WebKit::HardwareAccelerationManager::HardwareAccelerationManager):

12:45 AM Changeset in webkit [216483] by Carlos Garcia Campos

6 edits in trunk/Source

[GTK] Building Webkit2Gtk without OpenGL fails.
https://bugs.webkit.org/show_bug.cgi?id=170959

Reviewed by Žan Doberšek.

Source/WebCore:

platform/graphics/texmap/TextureMapperGC3DPlatformLayer.cpp:
platform/graphics/texmap/TextureMapperGC3DPlatformLayer.h:
platform/graphics/texmap/TextureMapperPlatformLayerBuffer.h:

Source/WebKit2:

UIProcess/gtk/HardwareAccelerationManager.cpp:

(WebKit::HardwareAccelerationManager::HardwareAccelerationManager):

12:37 AM Changeset in webkit [216482] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

[AppleWin] CaptureDeviceManager.cpp: error C2813: #import is not supported with /MP
https://bugs.webkit.org/show_bug.cgi?id=171849

Patch by Fujii Hironori <Fujii Hironori> on 2017-05-09
Reviewed by Per Arne Vollan.

platform/mediastream/CaptureDeviceManager.cpp: Replaced #import with #include.

12:15 AM Changeset in webkit [216481] by sbarati@apple.com

10 edits
2 adds in trunk/Source/JavaScriptCore

CallLinkInfos belonging to Wasm->JS stubs need to be informed when we clearCode() from all Executables
https://bugs.webkit.org/show_bug.cgi?id=171707
<rdar://problem/31891649>

Reviewed by Filip Pizlo.

This patch fixes a bug where a Wasm->JS IC call stub would go stale
and point into a CodeBlock no longer owned by any executable. The
problematic scenario is this:

We generate the call IC which has a branch on a callee check. This callee owns the Executable in question. If the branch succeeds, it will call code belonging to a particular CodeBlock associated with that Executable.

Heap::deleteAllCodeBlocks is called. This leads the Executable to clear its various CodeBlock references.

Wasm has no idea this happened, so now it has stale ICs that point into code from a CodeBlock no longer belonging to an Executable.

This patch fixes the bug by informing all JSWebAssemblyCodeBlocks to unlink
their CallLinkInfo when Heap::deleteAllCodeBlocks is called.

We track all JSWebAssemblyCodeBlocks by creating a new subspace for them.
This allows us to quickly iterate over the live JSWebAssemblyCodeBlocks in the
heap.

CMakeLists.txt:
JavaScriptCore.xcodeproj/project.pbxproj:
heap/Heap.cpp:

(JSC::Heap::deleteAllCodeBlocks):

heap/Subspace.h:
heap/SubspaceInlines.h:

(JSC::Subspace::forEachLiveCell):

runtime/VM.cpp:

(JSC::VM::VM):

runtime/VM.h:
wasm/js/JSWebAssemblyCodeBlock.cpp:

(JSC::JSWebAssemblyCodeBlock::clearJSCallICs):

wasm/js/JSWebAssemblyCodeBlock.h:

(JSC::JSWebAssemblyCodeBlock::createStructure): Deleted.
(JSC::JSWebAssemblyCodeBlock::functionImportCount): Deleted.
(JSC::JSWebAssemblyCodeBlock::module): Deleted.
(JSC::JSWebAssemblyCodeBlock::jsEntrypointCalleeFromFunctionIndexSpace): Deleted.
(JSC::JSWebAssemblyCodeBlock::wasmEntrypointLoadLocationFromFunctionIndexSpace): Deleted.
(JSC::JSWebAssemblyCodeBlock::wasmToJsCallStubForImport): Deleted.
(JSC::JSWebAssemblyCodeBlock::offsetOfImportWasmToJSStub): Deleted.
(JSC::JSWebAssemblyCodeBlock::codeBlock): Deleted.
(JSC::JSWebAssemblyCodeBlock::offsetOfImportStubs): Deleted.
(JSC::JSWebAssemblyCodeBlock::allocationSize): Deleted.
(JSC::JSWebAssemblyCodeBlock::importWasmToJSStub): Deleted.

wasm/js/JSWebAssemblyCodeBlockSubspace.cpp: Added.

(JSC::JSWebAssemblyCodeBlockSubspace::JSWebAssemblyCodeBlockSubspace):
(JSC::JSWebAssemblyCodeBlockSubspace::~JSWebAssemblyCodeBlockSubspace):
(JSC::JSWebAssemblyCodeBlockSubspace::finishSweep):
(JSC::JSWebAssemblyCodeBlockSubspace::destroy):

wasm/js/JSWebAssemblyCodeBlockSubspace.h: Added.

Note: See TracTimeline for information about the timeline view.

Download in other formats:

RSS Feed