Timeline
May 11, 2017:
- 11:58 PM Changeset in webkit [216736] by
-
- 12 edits6 adds in trunk/LayoutTests
[selectors4] :focus-within tests using shadow DOM don't pass on WK1
https://bugs.webkit.org/show_bug.cgi?id=170935
Reviewed by Youenn Fablet.
LayoutTests/imported/w3c:
The issue has been fixed modifying the tests upstream:
https://github.com/w3c/web-platform-tests/pull/5594
This patch updates "selectors4" Test Suite with the last changes
from WPT repository.
This means that this issue is fixed and at the same time some new tests
are being imported.
Two of the new imported tests are failing due to bug #47182,
anyway the -expected.txt files with FAIL messages are added.
- resources/import-expectations.json:
- web-platform-tests/css/selectors4/focus-display-none-001-expected.txt: Added.
- web-platform-tests/css/selectors4/focus-display-none-001.html: Added.
- web-platform-tests/css/selectors4/focus-within-009-expected.txt:
- web-platform-tests/css/selectors4/focus-within-009.html:
- web-platform-tests/css/selectors4/focus-within-010-expected.html: Added.
- web-platform-tests/css/selectors4/focus-within-010.html: Added.
- web-platform-tests/css/selectors4/focus-within-display-none-001-expected.txt: Added.
- web-platform-tests/css/selectors4/focus-within-display-none-001.html: Added.
- web-platform-tests/css/selectors4/focus-within-shadow-001.html:
- web-platform-tests/css/selectors4/focus-within-shadow-002.html:
- web-platform-tests/css/selectors4/focus-within-shadow-003.html:
- web-platform-tests/css/selectors4/focus-within-shadow-004.html:
- web-platform-tests/css/selectors4/focus-within-shadow-005.html:
- web-platform-tests/css/selectors4/w3c-import.log:
LayoutTests:
- platform/mac-wk1/TestExpectations: Remove tests as they're passing now.
- 11:32 PM Changeset in webkit [216735] by
-
- 2 edits1 copy68 adds5 deletes in trunk/PerformanceTests
Speedometer: Update the Ember.js TodoMVC to a more recent version
https://bugs.webkit.org/show_bug.cgi?id=171342
Patch by Addy Osmani <addyosmani@gmail.com> on 2017-05-11
Reviewed by Ryosuke Niwa.
Update the Ember TodoMVC app in Speedometer to latest
- Speedometer/resources/todomvc/architecture-examples/emberjs/assets/todomvc.css: Added.
- Speedometer/resources/todomvc/architecture-examples/emberjs/assets/todomvc.js: Added.
- Speedometer/resources/todomvc/architecture-examples/emberjs/assets/vendor.css: Renamed from PerformanceTests/Speedometer/resources/todomvc/architecture-examples/emberjs/bower_components/todomvc-common/base.css.
- Speedometer/resources/todomvc/architecture-examples/emberjs/assets/vendor.js: Added.
- Speedometer/resources/todomvc/architecture-examples/emberjs/bower.json: Removed.
- Speedometer/resources/todomvc/architecture-examples/emberjs/bower_components/ember-data/ember-data.js: Removed.
- Speedometer/resources/todomvc/architecture-examples/emberjs/bower_components/ember-localstorage-adapter/localstorage_adapter.js: Removed.
- Speedometer/resources/todomvc/architecture-examples/emberjs/bower_components/ember/ember.js: Removed.
- Speedometer/resources/todomvc/architecture-examples/emberjs/bower_components/handlebars/handlebars.js: Removed.
- Speedometer/resources/todomvc/architecture-examples/emberjs/bower_components/jquery/jquery.js: Removed.
- Speedometer/resources/todomvc/architecture-examples/emberjs/bower_components/todomvc-common/base.js: Removed.
- Speedometer/resources/todomvc/architecture-examples/emberjs/bower_components/todomvc-common/bg.png: Removed.
- Speedometer/resources/todomvc/architecture-examples/emberjs/crossdomain.xml: Added.
- Speedometer/resources/todomvc/architecture-examples/emberjs/index.html:
- Speedometer/resources/todomvc/architecture-examples/emberjs/js/app.js: Removed.
- Speedometer/resources/todomvc/architecture-examples/emberjs/js/controllers/todo_controller.js: Removed.
- Speedometer/resources/todomvc/architecture-examples/emberjs/js/controllers/todos_controller.js: Removed.
- Speedometer/resources/todomvc/architecture-examples/emberjs/js/helpers/pluralize.js: Removed.
- Speedometer/resources/todomvc/architecture-examples/emberjs/js/models/todo.js: Removed.
- Speedometer/resources/todomvc/architecture-examples/emberjs/js/router.js: Removed.
- Speedometer/resources/todomvc/architecture-examples/emberjs/js/views/edit_todo_view.js: Removed.
- Speedometer/resources/todomvc/architecture-examples/emberjs/js/views/todos_view.js: Removed.
- Speedometer/resources/todomvc/architecture-examples/emberjs/readme.md: Removed.
- Speedometer/resources/todomvc/architecture-examples/emberjs/robots.txt: Added.
- Speedometer/resources/todomvc/architecture-examples/emberjs/source/.bowerrc: Added.
- Speedometer/resources/todomvc/architecture-examples/emberjs/source/.editorconfig: Added.
- Speedometer/resources/todomvc/architecture-examples/emberjs/source/.ember-cli: Added.
- Speedometer/resources/todomvc/architecture-examples/emberjs/source/.gitignore: Added.
- Speedometer/resources/todomvc/architecture-examples/emberjs/source/.jshintrc: Added.
- Speedometer/resources/todomvc/architecture-examples/emberjs/source/.travis.yml: Added.
- Speedometer/resources/todomvc/architecture-examples/emberjs/source/.watchmanconfig: Added.
- Speedometer/resources/todomvc/architecture-examples/emberjs/source/README.md: Added.
- Speedometer/resources/todomvc/architecture-examples/emberjs/source/app/app.js: Added.
- Speedometer/resources/todomvc/architecture-examples/emberjs/source/app/components/.gitkeep: Added.
- Speedometer/resources/todomvc/architecture-examples/emberjs/source/app/components/todo-item.js: Added.
- Speedometer/resources/todomvc/architecture-examples/emberjs/source/app/components/todo-list.js: Added.
- Speedometer/resources/todomvc/architecture-examples/emberjs/source/app/controllers/active.js: Added.
- Speedometer/resources/todomvc/architecture-examples/emberjs/source/app/controllers/application.js: Added.
- Speedometer/resources/todomvc/architecture-examples/emberjs/source/app/controllers/completed.js: Added.
- Speedometer/resources/todomvc/architecture-examples/emberjs/source/app/helpers/gt.js: Added.
- Speedometer/resources/todomvc/architecture-examples/emberjs/source/app/helpers/pluralize.js: Added.
- Speedometer/resources/todomvc/architecture-examples/emberjs/source/app/index.html: Added.
- Speedometer/resources/todomvc/architecture-examples/emberjs/source/app/instance-initializers/global.js: Added.
- Speedometer/resources/todomvc/architecture-examples/emberjs/source/app/models/.gitkeep: Added.
- Speedometer/resources/todomvc/architecture-examples/emberjs/source/app/resolver.js: Added.
- Speedometer/resources/todomvc/architecture-examples/emberjs/source/app/router.js: Added.
- Speedometer/resources/todomvc/architecture-examples/emberjs/source/app/routes/.gitkeep: Added.
- Speedometer/resources/todomvc/architecture-examples/emberjs/source/app/routes/application.js: Added.
- Speedometer/resources/todomvc/architecture-examples/emberjs/source/app/services/memory.js: Added.
- Speedometer/resources/todomvc/architecture-examples/emberjs/source/app/services/repo.js: Added.
- Speedometer/resources/todomvc/architecture-examples/emberjs/source/app/styles/app.css: Added.
- Speedometer/resources/todomvc/architecture-examples/emberjs/source/app/templates/active.hbs: Added.
- Speedometer/resources/todomvc/architecture-examples/emberjs/source/app/templates/application.hbs: Added.
- Speedometer/resources/todomvc/architecture-examples/emberjs/source/app/templates/completed.hbs: Added.
- Speedometer/resources/todomvc/architecture-examples/emberjs/source/app/templates/components/.gitkeep: Added.
- Speedometer/resources/todomvc/architecture-examples/emberjs/source/app/templates/components/todo-item.hbs: Added.
- Speedometer/resources/todomvc/architecture-examples/emberjs/source/app/templates/components/todo-list.hbs: Added.
- Speedometer/resources/todomvc/architecture-examples/emberjs/source/app/templates/index.hbs: Added.
- Speedometer/resources/todomvc/architecture-examples/emberjs/source/bower.json: Added.
- Speedometer/resources/todomvc/architecture-examples/emberjs/source/config/environment.js: Added.
- Speedometer/resources/todomvc/architecture-examples/emberjs/source/ember-cli-build.js: Added.
- Speedometer/resources/todomvc/architecture-examples/emberjs/source/package.json: Added.
- Speedometer/resources/todomvc/architecture-examples/emberjs/source/public/crossdomain.xml: Added.
- Speedometer/resources/todomvc/architecture-examples/emberjs/source/public/robots.txt: Added.
- Speedometer/resources/todomvc/architecture-examples/emberjs/source/testem.js: Added.
- Speedometer/resources/todomvc/architecture-examples/emberjs/source/tests/.jshintrc: Added.
- Speedometer/resources/todomvc/architecture-examples/emberjs/source/tests/helpers/destroy-app.js: Added.
- Speedometer/resources/todomvc/architecture-examples/emberjs/source/tests/helpers/module-for-acceptance.js: Added.
- Speedometer/resources/todomvc/architecture-examples/emberjs/source/tests/helpers/resolver.js: Added.
- Speedometer/resources/todomvc/architecture-examples/emberjs/source/tests/helpers/start-app.js: Added.
- Speedometer/resources/todomvc/architecture-examples/emberjs/source/tests/index.html: Added.
- Speedometer/resources/todomvc/architecture-examples/emberjs/source/tests/integration/.gitkeep: Added.
- Speedometer/resources/todomvc/architecture-examples/emberjs/source/tests/test-helper.js: Added.
- Speedometer/resources/todomvc/architecture-examples/emberjs/source/tests/unit/.gitkeep: Added.
- Speedometer/resources/todomvc/architecture-examples/emberjs/source/vendor/.gitkeep: Added.
- Speedometer/resources/todomvc/architecture-examples/emberjs/source/vendor/base.css: Added.
- Speedometer/resources/todomvc/architecture-examples/emberjs/source/vendor/index.css: Added.
- Speedometer/resources/todomvc/architecture-examples/emberjs/test.html: Removed.
- Speedometer/resources/todomvc/architecture-examples/emberjs/testem.js: Added.
- Speedometer/resources/todomvc/architecture-examples/emberjs/tests/index.html: Added.
- 11:05 PM Changeset in webkit [216734] by
-
- 3 edits in trunk/Source/JavaScriptCore
Computing optionalDefArgWidth in CheckSpecial should not consider Scratch roles
https://bugs.webkit.org/show_bug.cgi?id=171962
Reviewed by Filip Pizlo.
The purpose of getting the result width is to get the width of
the result of the arithmetic. It does not care about that the
Check happens to define scratches.
- b3/B3CheckSpecial.cpp:
(JSC::B3::CheckSpecial::forEachArg):
- b3/testb3.cpp:
(JSC::B3::testCheckMul):
(JSC::B3::testCheckMulMemory):
(JSC::B3::testCheckMul64):
(JSC::B3::testCheckMulFold):
(JSC::B3::testCheckMulFoldFail):
(JSC::B3::testCheckMulArgumentAliasing64):
(JSC::B3::testCheckMulArgumentAliasing32):
(JSC::B3::testCheckMul64SShr):
- 11:04 PM Changeset in webkit [216733] by
-
- 4 edits in trunk/Source/JavaScriptCore
isValidForm for SimpleAddr should use ptr() instead of tmp()
https://bugs.webkit.org/show_bug.cgi?id=171992
Reviewed by Filip Pizlo.
Arg::tmp() asserts that its kind is Tmp. Inst::isValidForm for
SimpleAddr was using Arg::tmp() instead of ptr() to check
if the address Tmp isGP(). It should be using Arg::ptr() instead
of Arg::tmp() since Arg::ptr() is designed for SimpleAddr.
This patch also fixes an incorrect assertion in the ARM64
macro assembler. We were asserting various atomic ops were
only over 32/64 bit operations. However, the code was properly handling
8/16/32/64 bit ops. I changed the assertion to reflect what is
actually going on.
- assembler/ARM64Assembler.h:
(JSC::ARM64Assembler::ldar):
(JSC::ARM64Assembler::ldxr):
(JSC::ARM64Assembler::ldaxr):
(JSC::ARM64Assembler::stxr):
(JSC::ARM64Assembler::stlr):
(JSC::ARM64Assembler::stlxr):
- b3/air/opcode_generator.rb:
- b3/testb3.cpp:
(JSC::B3::testLoadAcq42):
(JSC::B3::testStoreRelAddLoadAcq32):
(JSC::B3::testStoreRelAddLoadAcq8):
(JSC::B3::testStoreRelAddFenceLoadAcq8):
(JSC::B3::testStoreRelAddLoadAcq16):
(JSC::B3::testStoreRelAddLoadAcq64):
(JSC::B3::testAtomicWeakCAS):
(JSC::B3::testAtomicStrongCAS):
(JSC::B3::testAtomicXchg):
- 10:50 PM Changeset in webkit [216732] by
-
- 1 edit38 adds in trunk/PerformanceTests
Speedometer: Add a React + Redux TodoMVC implementation
https://bugs.webkit.org/show_bug.cgi?id=171329
Patch by Addy Osmani <addyosmani@gmail.com> on 2017-05-11
Reviewed by Ryosuke Niwa.
Adds React and Redux TodoMVC implementation for Speedometer
- Speedometer/resources/todomvc/architecture-examples/react-redux/README.md: Added.
- Speedometer/resources/todomvc/architecture-examples/react-redux/dist/index.html: Added.
- Speedometer/resources/todomvc/architecture-examples/react-redux/dist/static/css/main.d43d2909.css: Added.
- Speedometer/resources/todomvc/architecture-examples/react-redux/dist/static/js/main.946269ff.js: Added.
- Speedometer/resources/todomvc/architecture-examples/react-redux/package.json: Added.
- Speedometer/resources/todomvc/architecture-examples/react-redux/public/index.html: Added.
- Speedometer/resources/todomvc/architecture-examples/react-redux/src/actions/index.js: Added.
- Speedometer/resources/todomvc/architecture-examples/react-redux/src/actions/index.spec.js: Added.
- Speedometer/resources/todomvc/architecture-examples/react-redux/src/components/Footer.js: Added.
- Speedometer/resources/todomvc/architecture-examples/react-redux/src/components/Footer.spec.js: Added.
- Speedometer/resources/todomvc/architecture-examples/react-redux/src/components/Header.js: Added.
- Speedometer/resources/todomvc/architecture-examples/react-redux/src/components/Header.spec.js: Added.
- Speedometer/resources/todomvc/architecture-examples/react-redux/src/components/MainSection.js: Added.
- Speedometer/resources/todomvc/architecture-examples/react-redux/src/components/MainSection.spec.js: Added.
- Speedometer/resources/todomvc/architecture-examples/react-redux/src/components/TodoItem.js: Added.
- Speedometer/resources/todomvc/architecture-examples/react-redux/src/components/TodoItem.spec.js: Added.
- Speedometer/resources/todomvc/architecture-examples/react-redux/src/components/TodoTextInput.js: Added.
- Speedometer/resources/todomvc/architecture-examples/react-redux/src/components/TodoTextInput.spec.js: Added.
- Speedometer/resources/todomvc/architecture-examples/react-redux/src/constants/ActionTypes.js: Added.
- Speedometer/resources/todomvc/architecture-examples/react-redux/src/constants/TodoFilters.js: Added.
- Speedometer/resources/todomvc/architecture-examples/react-redux/src/containers/App.js: Added.
- Speedometer/resources/todomvc/architecture-examples/react-redux/src/index.js: Added.
- Speedometer/resources/todomvc/architecture-examples/react-redux/src/reducers/index.js: Added.
- Speedometer/resources/todomvc/architecture-examples/react-redux/src/reducers/todos.js: Added.
- Speedometer/resources/todomvc/architecture-examples/react-redux/src/reducers/todos.spec.js: Added.
- Speedometer/resources/todomvc/architecture-examples/react-redux/yarn.lock: Added.
- 10:21 PM Changeset in webkit [216731] by
-
- 8 edits1 copy1 move1 add in trunk/Source/WTF
[Win] Implement memoryFootprint for Windows
https://bugs.webkit.org/show_bug.cgi?id=171693
Reviewed by Alex Christensen.
This patch implements memoryFootprint for Windows. In Windows, we calculate the size
of private working set. This can be done by enumerating private pages in working set.
And we also split MemoryFootprint.cpp to cocoa, linux, and win versions.
- WTF.xcodeproj/project.pbxproj:
- wtf/CMakeLists.txt:
- wtf/MallocPtr.h:
(WTF::MallocPtr::operator*):
(WTF::MallocPtr::operator->):
- wtf/PlatformGTK.cmake:
- wtf/PlatformJSCOnly.cmake:
- wtf/PlatformMac.cmake:
- wtf/PlatformWin.cmake:
- wtf/cocoa/MemoryFootprintCocoa.cpp: Copied from Source/WTF/wtf/MemoryFootprint.cpp.
(WTF::memoryFootprint):
- wtf/linux/MemoryFootprintLinux.cpp: Renamed from Source/WTF/wtf/MemoryFootprint.cpp.
(WTF::forEachLine):
(WTF::memoryFootprint):
- wtf/win/MemoryFootprintWin.cpp: Added.
(WTF::memoryFootprint):
- 10:02 PM Changeset in webkit [216730] by
-
- 12 edits in trunk/Source
Drop remaining uses of PassRefPtr in WebCore
https://bugs.webkit.org/show_bug.cgi?id=172013
Reviewed by Yusuke Suzuki.
Source/WebCore:
- bindings/js/ScriptController.cpp:
(WebCore::ScriptController::createRootObject):
- bindings/js/ScriptController.h:
- bindings/js/ScriptControllerMac.mm:
- bridge/objc/WebScriptObject.mm:
(WebCore::createJSWrapper):
(-[WebScriptObject _setImp:originRootObject:rootObject:]):
(-[WebScriptObject _setOriginRootObject:andRootObject:]):
(-[WebScriptObject _initWithJSObject:originRootObject:rootObject:]):
- bridge/objc/WebScriptObjectPrivate.h:
Source/WebKit/mac:
- Plugins/Hosted/NetscapePluginInstanceProxy.h:
- Plugins/Hosted/NetscapePluginInstanceProxy.mm:
(WebKit::NetscapePluginInstanceProxy::demarshalValueFromArray):
(WebKit::NetscapePluginInstanceProxy::createBindingsInstance):
- Plugins/Hosted/WebHostedNetscapePluginView.mm:
(-[WebHostedNetscapePluginView createPluginBindingsInstance:]):
Source/WebKit/win:
- Plugins/PluginView.cpp:
(WebCore::PluginView::bindingInstance):
- 9:32 PM Changeset in webkit [216729] by
-
- 7 edits in branches/safari-604.1.21-branch/Source
Versioning.
- 8:55 PM Changeset in webkit [216728] by
-
- 8 edits2 adds in trunk
RenderImageResource::hasImage is redundant and RenderImageResourceStyleImage's override is incorrect.
https://bugs.webkit.org/show_bug.cgi?id=172010
<rdar://problem/31086735>
Reviewed by Simon Fraser.
Source/WebCore:
RenderImageResourceStyleImage::hasImage() always returns true even when ::cachedImage()
returns nullptr (e.g. image is pending).
Remove it and use cachedImage() instead.
Test: fast/images/missing-content-image-crash.html
- html/HTMLImageElement.cpp:
(WebCore::HTMLImageElement::didAttachRenderers):
- rendering/RenderImage.cpp:
(WebCore::RenderImage::updateIntrinsicSizeIfNeeded):
(WebCore::RenderImage::isShowingMissingOrImageError):
(WebCore::RenderImage::hasNonBitmapImage):
(WebCore::RenderImage::paintReplaced):
(WebCore::RenderImage::paintIntoRect):
(WebCore::RenderImage::foregroundIsKnownToBeOpaqueInRect):
- rendering/RenderImageResource.h:
(WebCore::RenderImageResource::cachedImage):
(WebCore::RenderImageResource::hasImage): Deleted.
- rendering/RenderImageResourceStyleImage.h:
- rendering/svg/RenderSVGImage.cpp:
(WebCore::RenderSVGImage::paint):
- svg/SVGImageElement.cpp:
(WebCore::SVGImageElement::hasSingleSecurityOrigin):
(WebCore::SVGImageElement::didAttachRenderers):
LayoutTests:
- fast/images/missing-content-image-crash-expected.txt: Added.
- fast/images/missing-content-image-crash.html: Added.
- 8:41 PM Changeset in webkit [216727] by
-
- 1 edit31 adds in trunk/PerformanceTests
Speedometer: Add an ES2015 (Babel + Webpack) TodoMVC implementation
https://bugs.webkit.org/show_bug.cgi?id=171452
Patch by Addy Osmani <addyosmani@gmail.com> on 2017-05-11
Reviewed by Ryosuke Niwa.
Adds ES2015 Babel + Webpack TodoMVC implem
- Speedometer/resources/todomvc/vanilla-examples/es2015-babel-webpack/.babelrc: Added.
- Speedometer/resources/todomvc/vanilla-examples/es2015-babel-webpack/.eslintignore: Added.
- Speedometer/resources/todomvc/vanilla-examples/es2015-babel-webpack/dist/bundle.app.73bcc5d3c1d07180f0e3.js: Added.
- Speedometer/resources/todomvc/vanilla-examples/es2015-babel-webpack/dist/bundle.app.73bcc5d3c1d07180f0e3.js.map: Added.
- Speedometer/resources/todomvc/vanilla-examples/es2015-babel-webpack/dist/bundle.manifest.112bf70a7f3deebf1f93.js: Added.
- Speedometer/resources/todomvc/vanilla-examples/es2015-babel-webpack/dist/bundle.manifest.112bf70a7f3deebf1f93.js.map: Added.
- Speedometer/resources/todomvc/vanilla-examples/es2015-babel-webpack/dist/bundle.vendor.efaa3e0e20077c8e7471.js: Added.
- Speedometer/resources/todomvc/vanilla-examples/es2015-babel-webpack/dist/bundle.vendor.efaa3e0e20077c8e7471.js.map: Added.
- Speedometer/resources/todomvc/vanilla-examples/es2015-babel-webpack/dist/index.html: Added.
- Speedometer/resources/todomvc/vanilla-examples/es2015-babel-webpack/dist/styles.app.73bcc5d3c1d07180f0e3.css: Added.
- Speedometer/resources/todomvc/vanilla-examples/es2015-babel-webpack/dist/styles.app.73bcc5d3c1d07180f0e3.css.map: Added.
- Speedometer/resources/todomvc/vanilla-examples/es2015-babel-webpack/dist/styles.vendor.efaa3e0e20077c8e7471.css: Added.
- Speedometer/resources/todomvc/vanilla-examples/es2015-babel-webpack/dist/styles.vendor.efaa3e0e20077c8e7471.css.map: Added.
- Speedometer/resources/todomvc/vanilla-examples/es2015-babel-webpack/package.json: Added.
- Speedometer/resources/todomvc/vanilla-examples/es2015-babel-webpack/src/app.css: Added.
- Speedometer/resources/todomvc/vanilla-examples/es2015-babel-webpack/src/app.js: Added.
- Speedometer/resources/todomvc/vanilla-examples/es2015-babel-webpack/src/bootstrap.js: Added.
- Speedometer/resources/todomvc/vanilla-examples/es2015-babel-webpack/src/controller.js: Added.
- Speedometer/resources/todomvc/vanilla-examples/es2015-babel-webpack/src/controller.test.js: Added.
- Speedometer/resources/todomvc/vanilla-examples/es2015-babel-webpack/src/helpers.js: Added.
- Speedometer/resources/todomvc/vanilla-examples/es2015-babel-webpack/src/index.html: Added.
- Speedometer/resources/todomvc/vanilla-examples/es2015-babel-webpack/src/memory.js: Added.
- Speedometer/resources/todomvc/vanilla-examples/es2015-babel-webpack/src/model.js: Added.
- Speedometer/resources/todomvc/vanilla-examples/es2015-babel-webpack/src/store.js: Added.
- Speedometer/resources/todomvc/vanilla-examples/es2015-babel-webpack/src/template.js: Added.
- Speedometer/resources/todomvc/vanilla-examples/es2015-babel-webpack/src/todo.js: Added.
- Speedometer/resources/todomvc/vanilla-examples/es2015-babel-webpack/src/view.js: Added.
- Speedometer/resources/todomvc/vanilla-examples/es2015-babel-webpack/webpack.config.babel.js: Added.
- 8:18 PM Changeset in webkit [216726] by
-
- 7 edits2 adds in trunk
AX: Defer text changes until after the tree is clean if needed.
https://bugs.webkit.org/show_bug.cgi?id=171546
<rdar://problem/31934942>
Reviewed by Simon Fraser.
Source/WebCore:
While updating an accessibility object state, we might
trigger unintentional style updates. This style update could
end up destroying renderes that are still referenced by functions
on the callstack.
To avoid that, defer such changes and let AXObjectCache operate on a clean tree.
Test: accessibility/crash-when-render-tree-is-not-clean.html
- accessibility/AXObjectCache.cpp:
(WebCore::AXObjectCache::remove):
(WebCore::AXObjectCache::handleAttributeChanged):
(WebCore::AXObjectCache::labelChanged):
(WebCore::AXObjectCache::performDeferredCacheUpdate):
(WebCore::AXObjectCache::deferRecomputeIsIgnored):
(WebCore::AXObjectCache::deferTextChangedIfNeeded):
(WebCore::AXObjectCache::recomputeDeferredIsIgnored): Deleted.
(WebCore::AXObjectCache::deferTextChanged): Deleted.
- accessibility/AXObjectCache.h: Decouple different type of changes.
(WebCore::AXObjectCache::deferRecomputeIsIgnored):
(WebCore::AXObjectCache::deferTextChangedIfNeeded):
(WebCore::AXObjectCache::recomputeDeferredIsIgnored): Deleted.
(WebCore::AXObjectCache::deferTextChanged): Deleted.
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::deleteLines):
- rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlockFlow::createAndAppendRootInlineBox):
- rendering/RenderText.cpp:
(WebCore::RenderText::setText):
LayoutTests:
- accessibility/crash-when-render-tree-is-not-clean-expected.txt: Added.
- accessibility/crash-when-render-tree-is-not-clean.html: Added.
- 8:16 PM Changeset in webkit [216725] by
-
- 7 edits5 moves2 adds in trunk
Tools:
Allow WPT server to serve specific WebKit test
https://bugs.webkit.org/show_bug.cgi?id=171479
Patch by Youenn Fablet <youenn@apple.com> on 2017-05-11
Reviewed by Ryosuke Niwa.
Adding a new mount point to WPT server.
It points to LayoutTests/http/wpt folder and is triggered on "/WebKit" urls.
Updating the webkitpy infrastructure to launch WPT server and do test url mapping for LayoutTests/wpt tests.
- Scripts/webkitpy/layout_tests/controllers/manager.py:
(Manager.init):
(Manager._is_http_test):
(Manager._needs_web_platform_test):
(Manager._run_tests):
(Manager._is_web_platform_test): Deleted.
- Scripts/webkitpy/layout_tests/servers/web_platform_test_launcher.py:
(build_routes):
(main):
- Scripts/webkitpy/port/driver.py:
(Driver):
(Driver.is_webkit_specific_web_platform_test):
(Driver.test_to_uri):
(Driver._command_from_driver_input):
LayoutTests:
Allow WPT server to serve specific WebKit tests
https://bugs.webkit.org/show_bug.cgi?id=171479
Patch by Youenn Fablet <youenn@apple.com> on 2017-05-11
Reviewed by Ryosuke Niwa.
Moving tests to ensure they are correctly runned.
- http/wpt/fetch/fetch-as-blob-expected.txt: Renamed from LayoutTests/http/tests/fetch/fetch-as-blob-expected.txt.
- http/wpt/fetch/fetch-as-blob-worker-expected.txt: Renamed from LayoutTests/http/tests/fetch/fetch-as-blob-worker-expected.txt.
- http/wpt/fetch/fetch-as-blob-worker.html: Renamed from LayoutTests/http/tests/fetch/fetch-as-blob-worker.html.
- http/wpt/fetch/fetch-as-blob.html: Renamed from LayoutTests/http/tests/fetch/fetch-as-blob.html.
- http/wpt/fetch/fetch-as-blob.js: Renamed from LayoutTests/http/tests/fetch/fetch-as-blob.js.
(promise_test):
- 8:14 PM Changeset in webkit [216724] by
-
- 23 edits in trunk/Source/WebCore
Drop remaining uses of PassRefPtr under platform/
https://bugs.webkit.org/show_bug.cgi?id=172007
Reviewed by Geoffrey Garen.
- platform/graphics/wpe/ImageWPE.cpp:
(WebCore::Image::loadPlatformResource):
- platform/ios/LegacyTileGrid.h:
- platform/ios/LegacyTileGrid.mm:
(WebCore::LegacyTileGrid::tileForIndex):
(WebCore::LegacyTileGrid::tileForPoint):
- platform/ios/LegacyTileGridTile.h:
(WebCore::LegacyTileGridTile::create):
- platform/mediastream/RTCIceCandidateDescriptor.cpp:
(WebCore::RTCIceCandidateDescriptor::create):
- platform/mediastream/RTCIceCandidateDescriptor.h:
- platform/mediastream/RTCPeerConnectionHandlerClient.h:
- platform/mediastream/RTCSessionDescriptionDescriptor.cpp:
(WebCore::RTCSessionDescriptionDescriptor::create):
- platform/mediastream/RTCSessionDescriptionDescriptor.h:
- platform/mediastream/RTCSessionDescriptionRequest.h:
(WebCore::RTCSessionDescriptionRequest::extraData):
(WebCore::RTCSessionDescriptionRequest::setExtraData):
- platform/mediastream/RealtimeMediaSourceCenter.h:
- platform/mediastream/mac/RealtimeMediaSourceCenterMac.h:
- platform/mediastream/openwebrtc/RealtimeMediaSourceCenterOwr.cpp:
(WebCore::RealtimeMediaSourceCenterOwr::firstSource):
- platform/mediastream/openwebrtc/RealtimeMediaSourceCenterOwr.h:
- platform/mock/DeviceOrientationClientMock.cpp:
(WebCore::DeviceOrientationClientMock::setOrientation):
- platform/mock/DeviceOrientationClientMock.h:
- platform/mock/GeolocationClientMock.cpp:
(WebCore::GeolocationClientMock::setPosition):
- platform/mock/GeolocationClientMock.h:
- platform/mock/RTCNotifiersMock.cpp:
(WebCore::SessionRequestNotifier::SessionRequestNotifier):
(WebCore::SessionRequestNotifier::fire):
(WebCore::VoidRequestNotifier::VoidRequestNotifier):
- platform/mock/RTCNotifiersMock.h:
- platform/mock/TimerEventBasedMock.h:
(WebCore::TimerEventBasedMock::removeEvent):
(WebCore::TimerEvent::TimerEvent):
(WebCore::TimerEvent::timerFired):
- platform/mock/mediasource/MockMediaSourcePrivate.cpp:
(WebCore::MockSourceBufferPrivateHasAudio):
(WebCore::MockSourceBufferPrivateHasVideo):
- platform/wpe/RenderThemeWPE.h:
- 8:00 PM Changeset in webkit [216723] by
-
- 1 edit22 adds in trunk/PerformanceTests
Speedometer: Add an Inferno TodoMVC implementation
https://bugs.webkit.org/show_bug.cgi?id=171411
Patch by Addy Osmani <addyosmani@gmail.com> on 2017-05-11
Reviewed by Ryosuke Niwa.
Adds a Inferno implem of TodoMVC to Speedometer
- Speedometer/resources/todomvc/architecture-examples/inferno/dist/bundle.js: Added.
- Speedometer/resources/todomvc/architecture-examples/inferno/index.html: Added.
- Speedometer/resources/todomvc/architecture-examples/inferno/node_modules/todomvc-app-css/index.css: Added.
- Speedometer/resources/todomvc/architecture-examples/inferno/node_modules/todomvc-app-css/package.json: Added.
- Speedometer/resources/todomvc/architecture-examples/inferno/node_modules/todomvc-app-css/readme.md: Added.
- Speedometer/resources/todomvc/architecture-examples/inferno/node_modules/todomvc-common/base.css: Added.
- Speedometer/resources/todomvc/architecture-examples/inferno/node_modules/todomvc-common/base.js: Added.
- Speedometer/resources/todomvc/architecture-examples/inferno/node_modules/todomvc-common/package.json: Added.
- Speedometer/resources/todomvc/architecture-examples/inferno/node_modules/todomvc-common/readme.md: Added.
- Speedometer/resources/todomvc/architecture-examples/inferno/package.json: Added.
- Speedometer/resources/todomvc/architecture-examples/inferno/src/base.js: Added.
- Speedometer/resources/todomvc/architecture-examples/inferno/src/index.js: Added.
- Speedometer/resources/todomvc/architecture-examples/inferno/src/item.js: Added.
- Speedometer/resources/todomvc/architecture-examples/inferno/src/model.js: Added.
- Speedometer/resources/todomvc/architecture-examples/inferno/src/share.js: Added.
- Speedometer/resources/todomvc/architecture-examples/inferno/webpack.config.js: Added.
- 7:57 PM Changeset in webkit [216722] by
-
- 2 edits in trunk/Source/WebCore
[WPE] Stop using PassRefPtr in platform/graphics/wpe
https://bugs.webkit.org/show_bug.cgi?id=171977
Unreviewed build fix after r216702.
- platform/graphics/wpe/ImageWPE.cpp:
(WebCore::Image::loadPlatformResource):
- 7:55 PM Changeset in webkit [216721] by
-
- 1 edit50 adds in trunk/PerformanceTests
Speedometer: Add an Angular 2 (4.x) TodoMVC implementation
https://bugs.webkit.org/show_bug.cgi?id=171343
Patch by Addy Osmani <addyosmani@gmail.com> on 2017-05-11
Reviewed by Ryosuke Niwa.
Add a TodoMVC Angular 2 (4.x) implem for the benchmark
- Speedometer/resources/todomvc/architecture-examples/angular/.angular-cli.json: Added.
- Speedometer/resources/todomvc/architecture-examples/angular/.editorconfig: Added.
- Speedometer/resources/todomvc/architecture-examples/angular/README.md: Added.
- Speedometer/resources/todomvc/architecture-examples/angular/dist/assets/css/todomvc-app.css: Added.
- Speedometer/resources/todomvc/architecture-examples/angular/dist/assets/css/todomvc-common.css: Added.
- Speedometer/resources/todomvc/architecture-examples/angular/dist/favicon.ico: Added.
- Speedometer/resources/todomvc/architecture-examples/angular/dist/index.html: Added.
- Speedometer/resources/todomvc/architecture-examples/angular/dist/inline.b342d102ba4a53bf2002.bundle.js: Added.
- Speedometer/resources/todomvc/architecture-examples/angular/dist/main.779eb2f1ddbe23ac61c7.bundle.js: Added.
- Speedometer/resources/todomvc/architecture-examples/angular/dist/polyfills.2d45a4c73c85e24fe474.bundle.js: Added.
- Speedometer/resources/todomvc/architecture-examples/angular/dist/styles.d41d8cd98f00b204e980.bundle.css: Added.
- Speedometer/resources/todomvc/architecture-examples/angular/dist/vendor.b4be818cb6d8028f9192.bundle.js: Added.
- Speedometer/resources/todomvc/architecture-examples/angular/e2e/app.e2e-spec.ts: Added.
- Speedometer/resources/todomvc/architecture-examples/angular/e2e/app.po.ts: Added.
- Speedometer/resources/todomvc/architecture-examples/angular/e2e/tsconfig.e2e.json: Added.
- Speedometer/resources/todomvc/architecture-examples/angular/karma.conf.js: Added.
- Speedometer/resources/todomvc/architecture-examples/angular/package.json: Added.
- Speedometer/resources/todomvc/architecture-examples/angular/protractor.conf.js: Added.
- Speedometer/resources/todomvc/architecture-examples/angular/src/app/app.component.css: Added.
- Speedometer/resources/todomvc/architecture-examples/angular/src/app/app.component.html: Added.
- Speedometer/resources/todomvc/architecture-examples/angular/src/app/app.component.spec.ts: Added.
- Speedometer/resources/todomvc/architecture-examples/angular/src/app/app.component.ts: Added.
- Speedometer/resources/todomvc/architecture-examples/angular/src/app/app.module.ts: Added.
- Speedometer/resources/todomvc/architecture-examples/angular/src/app/todo-data.service.spec.ts: Added.
- Speedometer/resources/todomvc/architecture-examples/angular/src/app/todo-data.service.ts: Added.
- Speedometer/resources/todomvc/architecture-examples/angular/src/app/todo.spec.ts: Added.
- Speedometer/resources/todomvc/architecture-examples/angular/src/app/todo.ts: Added.
- Speedometer/resources/todomvc/architecture-examples/angular/src/assets/.gitkeep: Added.
- Speedometer/resources/todomvc/architecture-examples/angular/src/assets/css/todomvc-app.css: Added.
- Speedometer/resources/todomvc/architecture-examples/angular/src/assets/css/todomvc-common.css: Added.
- Speedometer/resources/todomvc/architecture-examples/angular/src/environments/environment.prod.ts: Added.
- Speedometer/resources/todomvc/architecture-examples/angular/src/environments/environment.ts: Added.
- Speedometer/resources/todomvc/architecture-examples/angular/src/favicon.ico: Added.
- Speedometer/resources/todomvc/architecture-examples/angular/src/index.html: Added.
- Speedometer/resources/todomvc/architecture-examples/angular/src/main.ts: Added.
- Speedometer/resources/todomvc/architecture-examples/angular/src/polyfills.ts: Added.
- Speedometer/resources/todomvc/architecture-examples/angular/src/styles.css: Added.
- Speedometer/resources/todomvc/architecture-examples/angular/src/test.ts: Added.
- Speedometer/resources/todomvc/architecture-examples/angular/src/tsconfig.app.json: Added.
- Speedometer/resources/todomvc/architecture-examples/angular/src/tsconfig.spec.json: Added.
- Speedometer/resources/todomvc/architecture-examples/angular/src/typings.d.ts: Added.
- Speedometer/resources/todomvc/architecture-examples/angular/tsconfig.json: Added.
- Speedometer/resources/todomvc/architecture-examples/angular/tslint.json: Added.
- 7:54 PM Changeset in webkit [216720] by
-
- 1 edit28 adds in trunk/PerformanceTests
Speedometer: Add a Vue.js TodoMVC implementation
https://bugs.webkit.org/show_bug.cgi?id=171325
Patch by Addy Osmani <addyosmani@gmail.com> on 2017-05-11
Reviewed by Ryosuke Niwa.
Adds a Vue.js TodoMVC implementation to Speedometer
- Speedometer/resources/todomvc/architecture-examples/vuejs-cli/.babelrc: Added.
- Speedometer/resources/todomvc/architecture-examples/vuejs-cli/.editorconfig: Added.
- Speedometer/resources/todomvc/architecture-examples/vuejs-cli/.eslintignore: Added.
- Speedometer/resources/todomvc/architecture-examples/vuejs-cli/.eslintrc.js: Added.
- Speedometer/resources/todomvc/architecture-examples/vuejs-cli/README.md: Added.
- Speedometer/resources/todomvc/architecture-examples/vuejs-cli/config/dev.env.js: Added.
- Speedometer/resources/todomvc/architecture-examples/vuejs-cli/config/index.js: Added.
- Speedometer/resources/todomvc/architecture-examples/vuejs-cli/config/prod.env.js: Added.
- Speedometer/resources/todomvc/architecture-examples/vuejs-cli/dist/index.html: Added.
- Speedometer/resources/todomvc/architecture-examples/vuejs-cli/dist/static/css/app.677b45842d9f8b96e5b23c18969233b7.css: Added.
- Speedometer/resources/todomvc/architecture-examples/vuejs-cli/dist/static/js/app.b0e835874bc8949670d1.js: Added.
- Speedometer/resources/todomvc/architecture-examples/vuejs-cli/dist/static/js/manifest.84b2b4fceb74ab1f91f3.js: Added.
- Speedometer/resources/todomvc/architecture-examples/vuejs-cli/dist/static/js/vendor.a52517c5aa98e7fbea2e.js: Added.
- Speedometer/resources/todomvc/architecture-examples/vuejs-cli/index.html: Added.
- Speedometer/resources/todomvc/architecture-examples/vuejs-cli/package.json: Added.
- Speedometer/resources/todomvc/architecture-examples/vuejs-cli/src/App.vue: Added.
- Speedometer/resources/todomvc/architecture-examples/vuejs-cli/src/components/Todos.vue: Added.
- Speedometer/resources/todomvc/architecture-examples/vuejs-cli/src/components/todo.css: Added.
- Speedometer/resources/todomvc/architecture-examples/vuejs-cli/src/main.js: Added.
- Speedometer/resources/todomvc/architecture-examples/vuejs-cli/yarn.lock: Added.
- 7:53 PM Changeset in webkit [216719] by
-
- 8 edits8 adds2 deletes in trunk/PerformanceTests
Speedometer: Update the vanilla JavaScript TodoMVC implem to a more recent version
https://bugs.webkit.org/show_bug.cgi?id=171306
Patch by Addy Osmani <addyosmani@gmail.com> on 2017-05-11
Reviewed by Ryosuke Niwa.
Update vanilla JS TodoMVC implementation to the latest.
- Speedometer/resources/todomvc/vanilla-examples/vanillajs/bower.json: Removed.
- Speedometer/resources/todomvc/vanilla-examples/vanillajs/bower_components/todomvc-common/base.css: Removed.
- Speedometer/resources/todomvc/vanilla-examples/vanillajs/bower_components/todomvc-common/base.js: Removed.
- Speedometer/resources/todomvc/vanilla-examples/vanillajs/bower_components/todomvc-common/bg.png: Removed.
- Speedometer/resources/todomvc/vanilla-examples/vanillajs/index.html:
- Speedometer/resources/todomvc/vanilla-examples/vanillajs/js/app.js:
- Speedometer/resources/todomvc/vanilla-examples/vanillajs/js/controller.js:
- Speedometer/resources/todomvc/vanilla-examples/vanillajs/js/helpers.js:
- Speedometer/resources/todomvc/vanilla-examples/vanillajs/js/model.js:
- Speedometer/resources/todomvc/vanilla-examples/vanillajs/js/store.js:
- Speedometer/resources/todomvc/vanilla-examples/vanillajs/js/template.js: Added.
- Speedometer/resources/todomvc/vanilla-examples/vanillajs/js/view.js:
- Speedometer/resources/todomvc/vanilla-examples/vanillajs/node_modules/todomvc-app-css/index.css: Added.
- Speedometer/resources/todomvc/vanilla-examples/vanillajs/node_modules/todomvc-common/base.css: Added.
- Speedometer/resources/todomvc/vanilla-examples/vanillajs/node_modules/todomvc-common/base.js: Added.
- Speedometer/resources/todomvc/vanilla-examples/vanillajs/package.json: Added.
- 7:52 PM Changeset in webkit [216718] by
-
- 1 edit22 adds in trunk/PerformanceTests
Speedometer: Add an ES2015 TodoMVC implementation
https://bugs.webkit.org/show_bug.cgi?id=171448
Patch by Addy Osmani <addyosmani@gmail.com> on 2017-05-11
Reviewed by Ryosuke Niwa.
Adds ES2015 TodoMVC implementation for Speedometer
- Speedometer/resources/todomvc/vanilla-examples/es2015/index.html: Added.
- Speedometer/resources/todomvc/vanilla-examples/es2015/node_modules/todomvc-app-css/index.css: Added.
- Speedometer/resources/todomvc/vanilla-examples/es2015/node_modules/todomvc-app-css/package.json: Added.
- Speedometer/resources/todomvc/vanilla-examples/es2015/node_modules/todomvc-app-css/readme.md: Added.
- Speedometer/resources/todomvc/vanilla-examples/es2015/node_modules/todomvc-common/base.css: Added.
- Speedometer/resources/todomvc/vanilla-examples/es2015/node_modules/todomvc-common/base.js: Added.
- Speedometer/resources/todomvc/vanilla-examples/es2015/node_modules/todomvc-common/package.json: Added.
- Speedometer/resources/todomvc/vanilla-examples/es2015/node_modules/todomvc-common/readme.md: Added.
- Speedometer/resources/todomvc/vanilla-examples/es2015/package.json: Added.
- Speedometer/resources/todomvc/vanilla-examples/es2015/src/.jshintrc: Added.
- Speedometer/resources/todomvc/vanilla-examples/es2015/src/app.js: Added.
- Speedometer/resources/todomvc/vanilla-examples/es2015/src/controller.js: Added.
- Speedometer/resources/todomvc/vanilla-examples/es2015/src/helpers.js: Added.
- Speedometer/resources/todomvc/vanilla-examples/es2015/src/model.js: Added.
- Speedometer/resources/todomvc/vanilla-examples/es2015/src/store.js: Added.
- Speedometer/resources/todomvc/vanilla-examples/es2015/src/template.js: Added.
- Speedometer/resources/todomvc/vanilla-examples/es2015/src/view.js: Added.
- 7:50 PM Changeset in webkit [216717] by
-
- 1 edit16 adds in trunk/PerformanceTests
Speedometer: Add an Elm TodoMVC implementation
https://bugs.webkit.org/show_bug.cgi?id=171464
Patch by Addy Osmani <addyosmani@gmail.com> on 2017-05-11
Reviewed by Ryosuke Niwa.
Speedometer: Add Elm TodoMVC implementation
- Speedometer/resources/todomvc/functional-prog-examples/elm/Todo.elm: Added.
- Speedometer/resources/todomvc/functional-prog-examples/elm/Todo/Task.elm: Added.
- Speedometer/resources/todomvc/functional-prog-examples/elm/dist/elm.js: Added.
- Speedometer/resources/todomvc/functional-prog-examples/elm/index.html: Added.
- Speedometer/resources/todomvc/functional-prog-examples/elm/node_modules/todomvc-app-css/index.css: Added.
- Speedometer/resources/todomvc/functional-prog-examples/elm/node_modules/todomvc-common/base.css: Added.
- Speedometer/resources/todomvc/functional-prog-examples/elm/node_modules/todomvc-common/base.js: Added.
- Speedometer/resources/todomvc/functional-prog-examples/elm/package.json: Added.
- Speedometer/resources/todomvc/functional-prog-examples/elm/readme.md: Added.
- 7:46 PM Changeset in webkit [216716] by
-
- 8 edits15 adds2 deletes in trunk/PerformanceTests
Speedometer: Update the Backbone.js implementation to a more recent library version
https://bugs.webkit.org/show_bug.cgi?id=171305
Patch by Addy Osmani <addyosmani@gmail.com> on 2017-05-11
Reviewed by Ryosuke Niwa.
Updates the Backbone.js TodoMVC implementation to latest
- Speedometer/resources/todomvc/architecture-examples/backbone/bower.json: Removed.
- Speedometer/resources/todomvc/architecture-examples/backbone/bower_components/backbone.localStorage/backbone.localStorage.js: Removed.
- Speedometer/resources/todomvc/architecture-examples/backbone/bower_components/jquery/jquery.js: Removed.
- Speedometer/resources/todomvc/architecture-examples/backbone/bower_components/todomvc-common/base.css: Removed.
- Speedometer/resources/todomvc/architecture-examples/backbone/bower_components/todomvc-common/base.js: Removed.
- Speedometer/resources/todomvc/architecture-examples/backbone/bower_components/todomvc-common/bg.png: Removed.
- Speedometer/resources/todomvc/architecture-examples/backbone/bower_components/underscore/underscore.js: Removed.
- Speedometer/resources/todomvc/architecture-examples/backbone/index.html:
- Speedometer/resources/todomvc/architecture-examples/backbone/js/app.js:
- Speedometer/resources/todomvc/architecture-examples/backbone/js/backbone.sync.js: Added.
- Speedometer/resources/todomvc/architecture-examples/backbone/js/collections/todos.js:
- Speedometer/resources/todomvc/architecture-examples/backbone/js/models/todo.js:
- Speedometer/resources/todomvc/architecture-examples/backbone/js/routers/router.js:
- Speedometer/resources/todomvc/architecture-examples/backbone/js/views/app-view.js:
- Speedometer/resources/todomvc/architecture-examples/backbone/js/views/todo-view.js:
- Speedometer/resources/todomvc/architecture-examples/backbone/node_modules/backbone/backbone.js: Renamed from PerformanceTests/Speedometer/resources/todomvc/architecture-examples/backbone/bower_components/backbone/backbone.js.
- Speedometer/resources/todomvc/architecture-examples/backbone/node_modules/jquery/dist/jquery.js: Added.
- Speedometer/resources/todomvc/architecture-examples/backbone/node_modules/todomvc-app-css/index.css: Added.
- Speedometer/resources/todomvc/architecture-examples/backbone/node_modules/todomvc-common/base.css: Added.
- Speedometer/resources/todomvc/architecture-examples/backbone/node_modules/todomvc-common/base.js: Added.
- Speedometer/resources/todomvc/architecture-examples/backbone/node_modules/underscore/underscore.js: Added.
- Speedometer/resources/todomvc/architecture-examples/backbone/package.json: Added.
- 7:45 PM Changeset in webkit [216715] by
-
- 1 edit22 adds in trunk/PerformanceTests
Speedometer: Add a Preact.js TodoMVC implementation
https://bugs.webkit.org/show_bug.cgi?id=171323
Patch by Addy Osmani <addyosmani@gmail.com> on 2017-05-11
Reviewed by Ryosuke Niwa.
Adds Preact.js TodoMVC implementation to Speedometer
- Speedometer/resources/todomvc/architecture-examples/preact/.babelrc: Added.
- Speedometer/resources/todomvc/architecture-examples/preact/README.md: Added.
- Speedometer/resources/todomvc/architecture-examples/preact/dist/app.js: Added.
- Speedometer/resources/todomvc/architecture-examples/preact/dist/index.html: Added.
- Speedometer/resources/todomvc/architecture-examples/preact/dist/todomvc-common/base.css: Added.
- Speedometer/resources/todomvc/architecture-examples/preact/dist/todomvc-common/base.js: Added.
- Speedometer/resources/todomvc/architecture-examples/preact/dist/todomvc.css: Added.
- Speedometer/resources/todomvc/architecture-examples/preact/package.json: Added.
- Speedometer/resources/todomvc/architecture-examples/preact/rollup.config.js: Added.
- Speedometer/resources/todomvc/architecture-examples/preact/src/app/footer.js: Added.
- Speedometer/resources/todomvc/architecture-examples/preact/src/app/index.js: Added.
- Speedometer/resources/todomvc/architecture-examples/preact/src/app/item.js: Added.
- Speedometer/resources/todomvc/architecture-examples/preact/src/app/model.js: Added.
- Speedometer/resources/todomvc/architecture-examples/preact/src/app/util.js: Added.
- Speedometer/resources/todomvc/architecture-examples/preact/src/index.html: Added.
- Speedometer/resources/todomvc/architecture-examples/preact/src/index.js: Added.
- Speedometer/resources/todomvc/architecture-examples/preact/webpack.config.babel.js: Added.
- 7:13 PM Changeset in webkit [216714] by
-
- 1 copy in tags/Safari-604.1.21.1
Tag Safari-604.1.21.1.
- 5:55 PM Changeset in webkit [216713] by
-
- 4 edits17 adds2 deletes in trunk/PerformanceTests
Speedometer: Update the jQuery implementation to a more recent library version
https://bugs.webkit.org/show_bug.cgi?id=171308
Patch by Addy Osmani <addyosmani@gmail.com> on 2017-05-11
Reviewed by Ryosuke Niwa.
Updates the jQuery implementation of TodoMVC to a more recent version
- Speedometer/resources/todomvc/architecture-examples/jquery/bower.json: Removed.
- Speedometer/resources/todomvc/architecture-examples/jquery/bower_components/handlebars/handlebars.js: Removed.
- Speedometer/resources/todomvc/architecture-examples/jquery/bower_components/jquery/jquery.js: Removed.
- Speedometer/resources/todomvc/architecture-examples/jquery/bower_components/todomvc-common/base.css: Removed.
- Speedometer/resources/todomvc/architecture-examples/jquery/bower_components/todomvc-common/base.js: Removed.
- Speedometer/resources/todomvc/architecture-examples/jquery/bower_components/todomvc-common/bg.png: Removed.
- Speedometer/resources/todomvc/architecture-examples/jquery/index.html:
- Speedometer/resources/todomvc/architecture-examples/jquery/js/app.js:
- Speedometer/resources/todomvc/architecture-examples/jquery/node_modules/handlebars/dist/handlebars.js: Added.
- Speedometer/resources/todomvc/architecture-examples/jquery/node_modules/jquery/dist/jquery.js: Added.
- Speedometer/resources/todomvc/architecture-examples/jquery/node_modules/todomvc-app-css/index.css: Added.
- Speedometer/resources/todomvc/architecture-examples/jquery/node_modules/todomvc-app-css/package.json: Added.
- Speedometer/resources/todomvc/architecture-examples/jquery/node_modules/todomvc-app-css/readme.md: Added.
- Speedometer/resources/todomvc/architecture-examples/jquery/node_modules/todomvc-common/base.css: Added.
- Speedometer/resources/todomvc/architecture-examples/jquery/node_modules/todomvc-common/base.js: Added.
- Speedometer/resources/todomvc/architecture-examples/jquery/node_modules/todomvc-common/package.json: Added.
- Speedometer/resources/todomvc/architecture-examples/jquery/node_modules/todomvc-common/readme.md: Added.
- Speedometer/resources/todomvc/architecture-examples/jquery/package.json: Added.
- Speedometer/resources/todomvc/architecture-examples/jquery/readme.md:
- 5:52 PM Changeset in webkit [216712] by
-
- 23 edits3 adds in trunk
[iOS] Unset active media capture source when stopped capturing
https://bugs.webkit.org/show_bug.cgi?id=171815
<rdar://problem/32117885>
Patch by Youenn Fablet <youenn@apple.com> on 2017-05-11
Reviewed by Eric Carlson.
Source/WebCore:
Test: platform/ios/mediastream/getUserMedia-single-capture.html
Introducing SingleSourceFactory template class to be used by capture factories for iOS.
This class ensures that only one source is active at a time.
Update all capture sources accordingly.
Ensure sources are no longer considered as active sources when being destroyed.
Add support for mock sources and introducing m_isProducingData for them as well.
Update WebRTC outgoing source classes to handle the case of replaced track and resetting the enabled/mute
state according the new source.
Update the way we handle timestamps for audio data. We now consider that we read/write as a flow.
This allows smooth audio track replacing.
- platform/mediastream/RealtimeMediaSource.h:
- platform/mediastream/mac/AVAudioCaptureSource.mm:
(WebCore::AVAudioCaptureSource::~AVAudioCaptureSource):
(WebCore::AVAudioCaptureSourceFactory::setActiveSource): Deleted.
- platform/mediastream/mac/AVVideoCaptureSource.mm:
(WebCore::AVVideoCaptureSource::~AVVideoCaptureSource):
(WebCore::AVVideoCaptureSourceFactory::setActiveSource): Deleted.
- platform/mediastream/mac/CoreAudioCaptureSource.cpp:
(WebCore::CoreAudioCaptureSource::~CoreAudioCaptureSource):
(WebCore::CoreAudioCaptureSource::stopProducingData):
(WebCore::CoreAudioCaptureSourceFactory::setActiveSource): Deleted.
- platform/mediastream/mac/RealtimeOutgoingAudioSource.cpp:
(WebCore::RealtimeOutgoingAudioSource::setSource):
(WebCore::RealtimeOutgoingAudioSource::audioSamplesAvailable):
(WebCore::RealtimeOutgoingAudioSource::pullAudioData):
- platform/mediastream/mac/RealtimeOutgoingAudioSource.h:
- platform/mediastream/mac/RealtimeOutgoingVideoSource.cpp:
(WebCore::RealtimeOutgoingVideoSource::setSource):
(WebCore::RealtimeOutgoingVideoSource::sourceMutedChanged):
(WebCore::RealtimeOutgoingVideoSource::sourceEnabledChanged):
- platform/mock/MockRealtimeAudioSource.cpp:
(WebCore::mockAudioCaptureSourceFactory):
(WebCore::MockRealtimeAudioSource::factory):
(WebCore::MockRealtimeAudioSource::~MockRealtimeAudioSource):
(WebCore::MockRealtimeAudioSource::startProducingData):
(WebCore::MockRealtimeAudioSource::stopProducingData):
- platform/mock/MockRealtimeAudioSource.h:
- platform/mock/MockRealtimeVideoSource.cpp:
(WebCore::mockVideoCaptureSourceFactory):
(WebCore::MockRealtimeVideoSource::factory):
(WebCore::MockRealtimeVideoSource::~MockRealtimeVideoSource):
(WebCore::MockRealtimeVideoSource::startProducingData):
(WebCore::MockRealtimeVideoSource::stopProducingData):
- platform/mock/MockRealtimeVideoSource.h:
(WebCore::MockRealtimeVideoSource::~MockRealtimeVideoSource): Deleted.
LayoutTests:
Improving the existing tests for better reliability and debugability.
Updating tests to use less webkitAudioContext.
- platform/ios/mediastream/getUserMedia-single-capture-expected.txt: Added.
- platform/ios/mediastream/getUserMedia-single-capture.html: Added.
- webrtc/audio-peer-connection-webaudio.html:
- webrtc/audio-replace-track-expected.txt:
- webrtc/audio-replace-track.html:
- webrtc/peer-connection-audio-mute.html:
- webrtc/peer-connection-audio-mute2.html:
- webrtc/peer-connection-remote-audio-mute.html:
- webrtc/peer-connection-remote-audio-mute2.html:
- webrtc/routines.js:
- webrtc/video-replace-track-expected.txt:
- webrtc/video-replace-track.html:
- 5:49 PM Changeset in webkit [216711] by
-
- 7 edits in trunk
[WKWebsiteDataStore removeDataOfTypes:...] doesn't work for IndexedDB if the data store has a custom IDB path.
<rdar://problem/30612463> and https://bugs.webkit.org/show_bug.cgi?id=171994
Reviewed by Andy Estes.
Informal review by Maureen Daum.
Source/WebKit2:
- DatabaseProcess/DatabaseProcess.cpp:
(WebKit::DatabaseProcess::deleteWebsiteData): Instead of accessing the m_idbServers set directly, make
the method call that creates the server on demand.
(WebKit::DatabaseProcess::deleteWebsiteDataForOrigins): Ditto.
- UIProcess/WebProcessPool.cpp:
(WebKit::WebProcessPool::ensureDatabaseProcessAndWebsiteDataStore): Not only create the DatabaseProcess if necessary,
but also notify it about the passed-in WebsiteDataStore.
(WebKit::WebProcessPool::getDatabaseProcessConnection):
(WebKit::WebProcessPool::ensureDatabaseProcess): Deleted.
- UIProcess/WebProcessPool.h:
(WebKit::WebProcessPool::sendToDatabaseProcessRelaunchingIfNecessary):
- UIProcess/WebsiteData/WebsiteDataStore.cpp:
(WebKit::WebsiteDataStore::fetchData):
(WebKit::WebsiteDataStore::removeData):
(WebKit::WebsiteDataStore::databaseProcessParameters):
Tools:
- TestWebKitAPI/Tests/WebKit2Cocoa/WebsiteDataStoreCustomPaths.mm:
(TEST):
- 5:47 PM Changeset in webkit [216710] by
-
- 2 edits in trunk/Source/WebKit2
Modern Media Controls shouldn't be an experimental feature
https://bugs.webkit.org/show_bug.cgi?id=172004
<rdar://problem/32146522>
Reviewed by Simon Fraser.
This is either always on or always off, so shouldn't
show up in an Experimental Features menu.
- Shared/WebPreferencesDefinitions.h: Move ModernMediaControlsEnabled
to a normal preference.
- 5:43 PM Changeset in webkit [216709] by
-
- 2 edits in trunk/Source/WebCore
Fix the iOS build
- platform/spi/mac/NSSpellCheckerSPI.h:
- 5:15 PM Changeset in webkit [216708] by
-
- 1 edit23 copies1 move50 adds9 deletes in trunk/PerformanceTests
Speedometer: Update the Flight.js implementation to a more recent library version
https://bugs.webkit.org/show_bug.cgi?id=171471
Patch by Addy Osmani <addyosmani@gmail.com> on 2017-05-11
Reviewed by Ryosuke Niwa.
Speedometer: Update FlightJS TodoMVC implementation
- Speedometer/resources/todomvc/dependency-examples/flight/.gitignore: Removed.
- Speedometer/resources/todomvc/dependency-examples/flight/.jshintrc: Removed.
- Speedometer/resources/todomvc/dependency-examples/flight/app/js/main.js: Removed.
- Speedometer/resources/todomvc/dependency-examples/flight/app/js/store.js: Removed.
- Speedometer/resources/todomvc/dependency-examples/flight/bower.json: Removed.
- Speedometer/resources/todomvc/dependency-examples/flight/bower_components/es5-shim/es5-shim.js: Removed.
- Speedometer/resources/todomvc/dependency-examples/flight/bower_components/flight/lib/compose.js: Removed.
- Speedometer/resources/todomvc/dependency-examples/flight/bower_components/flight/lib/index.js: Removed.
- Speedometer/resources/todomvc/dependency-examples/flight/bower_components/flight/lib/logger.js: Removed.
- Speedometer/resources/todomvc/dependency-examples/flight/bower_components/jquery/jquery.js: Removed.
- Speedometer/resources/todomvc/dependency-examples/flight/bower_components/todomvc-common/base.css: Removed.
- Speedometer/resources/todomvc/dependency-examples/flight/bower_components/todomvc-common/bg.png: Removed.
- Speedometer/resources/todomvc/dependency-examples/flight/flight/app/js/data/stats.js: Renamed from PerformanceTests/Speedometer/resources/todomvc/dependency-examples/flight/app/js/data/stats.js.
- Speedometer/resources/todomvc/dependency-examples/flight/flight/app/js/data/todos.js: Renamed from PerformanceTests/Speedometer/resources/todomvc/dependency-examples/flight/app/js/data/todos.js.
- Speedometer/resources/todomvc/dependency-examples/flight/flight/app/js/main.js: Added.
- Speedometer/resources/todomvc/dependency-examples/flight/flight/app/js/page/app.js: Renamed from PerformanceTests/Speedometer/resources/todomvc/dependency-examples/flight/app/js/app.js.
- Speedometer/resources/todomvc/dependency-examples/flight/flight/app/js/store.js: Added.
- Speedometer/resources/todomvc/dependency-examples/flight/flight/app/js/ui/main_selector.js: Renamed from PerformanceTests/Speedometer/resources/todomvc/dependency-examples/flight/app/js/ui/main_selector.js.
- Speedometer/resources/todomvc/dependency-examples/flight/flight/app/js/ui/new_item.js: Renamed from PerformanceTests/Speedometer/resources/todomvc/dependency-examples/flight/app/js/ui/new_item.js.
- Speedometer/resources/todomvc/dependency-examples/flight/flight/app/js/ui/stats.js: Renamed from PerformanceTests/Speedometer/resources/todomvc/dependency-examples/flight/app/js/ui/stats.js.
- Speedometer/resources/todomvc/dependency-examples/flight/flight/app/js/ui/todo_list.js: Renamed from PerformanceTests/Speedometer/resources/todomvc/dependency-examples/flight/app/js/ui/todo_list.js.
- Speedometer/resources/todomvc/dependency-examples/flight/flight/app/js/ui/toggle_all.js: Renamed from PerformanceTests/Speedometer/resources/todomvc/dependency-examples/flight/app/js/ui/toggle_all.js.
- Speedometer/resources/todomvc/dependency-examples/flight/flight/app/js/ui/with_filters.js: Renamed from PerformanceTests/Speedometer/resources/todomvc/dependency-examples/flight/app/js/ui/with_filters.js.
- Speedometer/resources/todomvc/dependency-examples/flight/flight/app/js/utils.js: Renamed from PerformanceTests/Speedometer/resources/todomvc/dependency-examples/flight/app/js/utils.js.
- Speedometer/resources/todomvc/dependency-examples/flight/flight/app/templates/stats.html: Renamed from PerformanceTests/Speedometer/resources/todomvc/dependency-examples/flight/app/templates/stats.html.
- Speedometer/resources/todomvc/dependency-examples/flight/flight/app/templates/todo.html: Renamed from PerformanceTests/Speedometer/resources/todomvc/dependency-examples/flight/app/templates/todo.html.
- Speedometer/resources/todomvc/dependency-examples/flight/flight/index.html: Renamed from PerformanceTests/Speedometer/resources/todomvc/dependency-examples/flight/index.html.
- Speedometer/resources/todomvc/dependency-examples/flight/flight/node_modules/depot/README.md: Added.
- Speedometer/resources/todomvc/dependency-examples/flight/flight/node_modules/depot/depot.js: Renamed from PerformanceTests/Speedometer/resources/todomvc/dependency-examples/flight/bower_components/depot/depot.js.
- Speedometer/resources/todomvc/dependency-examples/flight/flight/node_modules/depot/depot.min.js: Added.
- Speedometer/resources/todomvc/dependency-examples/flight/flight/node_modules/depot/package.json: Added.
- Speedometer/resources/todomvc/dependency-examples/flight/flight/node_modules/es5-shim/LICENSE: Added.
- Speedometer/resources/todomvc/dependency-examples/flight/flight/node_modules/es5-shim/es5-sham.js: Renamed from PerformanceTests/Speedometer/resources/todomvc/dependency-examples/flight/bower_components/es5-shim/es5-sham.js.
- Speedometer/resources/todomvc/dependency-examples/flight/flight/node_modules/es5-shim/es5-sham.min.js: Added.
- Speedometer/resources/todomvc/dependency-examples/flight/flight/node_modules/es5-shim/es5-shim.js: Added.
- Speedometer/resources/todomvc/dependency-examples/flight/flight/node_modules/es5-shim/es5-shim.min.js: Added.
- Speedometer/resources/todomvc/dependency-examples/flight/flight/node_modules/flight/LICENSE: Added.
- Speedometer/resources/todomvc/dependency-examples/flight/flight/node_modules/flight/index.js: Added.
- Speedometer/resources/todomvc/dependency-examples/flight/flight/node_modules/flight/lib/advice.js: Renamed from PerformanceTests/Speedometer/resources/todomvc/dependency-examples/flight/bower_components/flight/lib/advice.js.
- Speedometer/resources/todomvc/dependency-examples/flight/flight/node_modules/flight/lib/base.js: Renamed from PerformanceTests/Speedometer/resources/todomvc/dependency-examples/flight/bower_components/flight/lib/base.js.
- Speedometer/resources/todomvc/dependency-examples/flight/flight/node_modules/flight/lib/component.js: Renamed from PerformanceTests/Speedometer/resources/todomvc/dependency-examples/flight/bower_components/flight/lib/component.js.
- Speedometer/resources/todomvc/dependency-examples/flight/flight/node_modules/flight/lib/compose.js: Added.
- Speedometer/resources/todomvc/dependency-examples/flight/flight/node_modules/flight/lib/debug.js: Renamed from PerformanceTests/Speedometer/resources/todomvc/dependency-examples/flight/bower_components/flight/lib/debug.js.
- Speedometer/resources/todomvc/dependency-examples/flight/flight/node_modules/flight/lib/logger.js: Added.
- Speedometer/resources/todomvc/dependency-examples/flight/flight/node_modules/flight/lib/registry.js: Renamed from PerformanceTests/Speedometer/resources/todomvc/dependency-examples/flight/bower_components/flight/lib/registry.js.
- Speedometer/resources/todomvc/dependency-examples/flight/flight/node_modules/flight/lib/utils.js: Renamed from PerformanceTests/Speedometer/resources/todomvc/dependency-examples/flight/bower_components/flight/lib/utils.js.
- Speedometer/resources/todomvc/dependency-examples/flight/flight/node_modules/jquery/README.md: Added.
- Speedometer/resources/todomvc/dependency-examples/flight/flight/node_modules/jquery/dist/jquery.js: Added.
- Speedometer/resources/todomvc/dependency-examples/flight/flight/node_modules/jquery/dist/jquery.min.js: Added.
- Speedometer/resources/todomvc/dependency-examples/flight/flight/node_modules/jquery/package.json: Added.
- Speedometer/resources/todomvc/dependency-examples/flight/flight/node_modules/memorystorage/memorystorage.js: Added.
- Speedometer/resources/todomvc/dependency-examples/flight/flight/node_modules/requirejs-text/LICENSE: Added.
- Speedometer/resources/todomvc/dependency-examples/flight/flight/node_modules/requirejs-text/README.md: Added.
- Speedometer/resources/todomvc/dependency-examples/flight/flight/node_modules/requirejs-text/bower.json: Added.
- Speedometer/resources/todomvc/dependency-examples/flight/flight/node_modules/requirejs-text/package.json: Added.
- Speedometer/resources/todomvc/dependency-examples/flight/flight/node_modules/requirejs-text/text.js: Renamed from PerformanceTests/Speedometer/resources/todomvc/dependency-examples/flight/bower_components/requirejs-text/text.js.
- Speedometer/resources/todomvc/dependency-examples/flight/flight/node_modules/requirejs/README.md: Added.
- Speedometer/resources/todomvc/dependency-examples/flight/flight/node_modules/requirejs/package.json: Added.
- Speedometer/resources/todomvc/dependency-examples/flight/flight/node_modules/requirejs/require.js: Renamed from PerformanceTests/Speedometer/resources/todomvc/dependency-examples/flight/bower_components/requirejs/require.js.
- Speedometer/resources/todomvc/dependency-examples/flight/flight/node_modules/todomvc-app-css/index.css: Added.
- Speedometer/resources/todomvc/dependency-examples/flight/flight/node_modules/todomvc-app-css/package.json: Added.
- Speedometer/resources/todomvc/dependency-examples/flight/flight/node_modules/todomvc-app-css/readme.md: Added.
- Speedometer/resources/todomvc/dependency-examples/flight/flight/node_modules/todomvc-common/base.css: Added.
- Speedometer/resources/todomvc/dependency-examples/flight/flight/node_modules/todomvc-common/base.js: Renamed from PerformanceTests/Speedometer/resources/todomvc/dependency-examples/flight/bower_components/todomvc-common/base.js.
- Speedometer/resources/todomvc/dependency-examples/flight/flight/node_modules/todomvc-common/package.json: Added.
- Speedometer/resources/todomvc/dependency-examples/flight/flight/node_modules/todomvc-common/readme.md: Added.
- Speedometer/resources/todomvc/dependency-examples/flight/flight/package.json: Added.
- Speedometer/resources/todomvc/dependency-examples/flight/karma.conf.js: Removed.
- Speedometer/resources/todomvc/dependency-examples/flight/package.json: Removed.
- Speedometer/resources/todomvc/dependency-examples/flight/readme.md: Removed.
- Speedometer/resources/todomvc/dependency-examples/flight/test/.jshintrc: Removed.
- Speedometer/resources/todomvc/dependency-examples/flight/test/fixture/footer.html: Removed.
- Speedometer/resources/todomvc/dependency-examples/flight/test/fixture/new_todo.html: Removed.
- Speedometer/resources/todomvc/dependency-examples/flight/test/fixture/toggle_all.html: Removed.
- Speedometer/resources/todomvc/dependency-examples/flight/test/mock/datastore.js: Removed.
- Speedometer/resources/todomvc/dependency-examples/flight/test/spec/data/stats_spec.js: Removed.
- Speedometer/resources/todomvc/dependency-examples/flight/test/spec/data/todos_spec.js: Removed.
- Speedometer/resources/todomvc/dependency-examples/flight/test/spec/ui/new_item_spec.js: Removed.
- Speedometer/resources/todomvc/dependency-examples/flight/test/spec/ui/stats_spec.js: Removed.
- Speedometer/resources/todomvc/dependency-examples/flight/test/spec/ui/toggle_all_spec.js: Removed.
- Speedometer/resources/todomvc/dependency-examples/flight/test/test-main.js: Removed.
- 5:13 PM Changeset in webkit [216707] by
-
- 10 edits in trunk
Unreviewed, rolling out r216677.
Patch caused layout test crashes.
Reverted changeset:
"WorkerThread::stop() should call
scheduleExecutionTermination() last."
https://bugs.webkit.org/show_bug.cgi?id=171775
http://trac.webkit.org/changeset/216677
- 5:12 PM Changeset in webkit [216706] by
-
- 8 edits18 adds4 deletes in trunk/PerformanceTests
Speedometer: Update the AngularJS implementation to a more recent library version
https://bugs.webkit.org/show_bug.cgi?id=171307
Patch by Addy Osmani <addyosmani@gmail.com> on 2017-05-11
Reviewed by Ryosuke Niwa.
Updates the AngularJS implementation of TodoMVC to 1.4.x
- Speedometer/resources/todomvc/architecture-examples/angularjs/bower.json: Removed.
- Speedometer/resources/todomvc/architecture-examples/angularjs/bower_components/angular-mocks/angular-mocks.js: Removed.
- Speedometer/resources/todomvc/architecture-examples/angularjs/bower_components/angular/angular.js: Removed.
- Speedometer/resources/todomvc/architecture-examples/angularjs/bower_components/todomvc-common/base.css: Removed.
- Speedometer/resources/todomvc/architecture-examples/angularjs/bower_components/todomvc-common/base.js: Removed.
- Speedometer/resources/todomvc/architecture-examples/angularjs/bower_components/todomvc-common/bg.png: Removed.
- Speedometer/resources/todomvc/architecture-examples/angularjs/index.html:
- Speedometer/resources/todomvc/architecture-examples/angularjs/js/app.js:
- Speedometer/resources/todomvc/architecture-examples/angularjs/js/controllers/todoCtrl.js:
- Speedometer/resources/todomvc/architecture-examples/angularjs/js/directives/todoBlur.js: Removed.
- Speedometer/resources/todomvc/architecture-examples/angularjs/js/directives/todoEscape.js:
- Speedometer/resources/todomvc/architecture-examples/angularjs/js/directives/todoFocus.js:
- Speedometer/resources/todomvc/architecture-examples/angularjs/js/services/todoStorage.js:
- Speedometer/resources/todomvc/architecture-examples/angularjs/node_modules/angular-resource/angular-resource.js: Added.
- Speedometer/resources/todomvc/architecture-examples/angularjs/node_modules/angular-route/angular-route.js: Added.
- Speedometer/resources/todomvc/architecture-examples/angularjs/node_modules/angular/angular.js: Added.
- Speedometer/resources/todomvc/architecture-examples/angularjs/node_modules/todomvc-app-css/index.css: Added.
- Speedometer/resources/todomvc/architecture-examples/angularjs/node_modules/todomvc-app-css/package.json: Added.
- Speedometer/resources/todomvc/architecture-examples/angularjs/node_modules/todomvc-app-css/readme.md: Added.
- Speedometer/resources/todomvc/architecture-examples/angularjs/node_modules/todomvc-common/base.css: Added.
- Speedometer/resources/todomvc/architecture-examples/angularjs/node_modules/todomvc-common/base.js: Added.
- Speedometer/resources/todomvc/architecture-examples/angularjs/node_modules/todomvc-common/package.json: Added.
- Speedometer/resources/todomvc/architecture-examples/angularjs/node_modules/todomvc-common/readme.md: Added.
- Speedometer/resources/todomvc/architecture-examples/angularjs/package.json: Added.
- Speedometer/resources/todomvc/architecture-examples/angularjs/readme.md:
- Speedometer/resources/todomvc/architecture-examples/angularjs/test/config/testacular.conf.js: Removed.
- Speedometer/resources/todomvc/architecture-examples/angularjs/test/package.json: Removed.
- Speedometer/resources/todomvc/architecture-examples/angularjs/test/readme.md: Removed.
- Speedometer/resources/todomvc/architecture-examples/angularjs/test/unit/directivesSpec.js: Removed.
- Speedometer/resources/todomvc/architecture-examples/angularjs/test/unit/todoCtrlSpec.js: Removed.
- Speedometer/resources/todomvc/architecture-examples/angularjs/todomvc-index.html: Added.
- 5:04 PM Changeset in webkit [216705] by
-
- 11 edits in trunk
[CMake] Add HAVE check for regex.h
https://bugs.webkit.org/show_bug.cgi?id=171950
Patch by Don Olmstead <don.olmstead@am.sony.com> on 2017-05-11
Reviewed by Michael Catanzaro.
.:
- Source/cmake/OptionsCommon.cmake:
Source/JavaScriptCore:
- runtime/ConfigFile.cpp:
(JSC::ConfigFile::parse):
Source/ThirdParty:
- gtest/include/gtest/internal/gtest-port.h:
Source/WebCore:
No new tests. No change in behavior.
- WebCorePrefix.h:
- testing/js/WebCoreTestSupportPrefix.h:
Source/WTF:
- wtf/Platform.h:
- 4:55 PM Changeset in webkit [216704] by
-
- 8 edits in trunk/Source
Mail spins launching spell checker when typing
https://bugs.webkit.org/show_bug.cgi?id=171986
<rdar://problem/26305327>
Reviewed by Beth Dakin.
- platform/spi/mac/NSSpellCheckerSPI.h:
- WebView/WebView.mm:
(-[WebView setEditable:]):
Asynchronously pre-warm the spell checker when a WebView becomes editable.
- UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _setEditable:]):
- UIProcess/Cocoa/WebViewImpl.h:
- UIProcess/Cocoa/WebViewImpl.mm:
(WebKit::WebViewImpl::didBecomeEditable):
(WebKit::WebViewImpl::startObservingFontPanel): Deleted.
Asynchronously pre-warm the spell checker when a WKWebView becomes editable.
- 4:46 PM Changeset in webkit [216703] by
-
- 3 edits in trunk/Websites/perf.webkit.org
Remove the code for old syncing script configuration in BuildbotSyncer
https://bugs.webkit.org/show_bug.cgi?id=171963
Reviewed by Chris Dumez.
Removed the code for specifying {"root": ~}, {"rootOptions": [~]}, and {"rootsExcluding": [~]} in buildbot
properties in the syncing script's configurations since they are no longer used after r215061.
Also removed the support for using "arguments" as an alias to "properties", and updated the tests accordingly.
- tools/js/buildbot-syncer.js:
(BuildbotSyncer._parseRepositoryGroup): Removed the unused code.
(BuildbotSyncer._validateAndMergeConfig): Just allow string values in properties.
(BuildbotSyncer._validateAndMergeProperties): Deleted.
- unit-tests/buildbot-syncer-tests.js:
(sampleiOSConfig): Use "properties" instead of "arguments" to specify the buildbot properties.
(sampleiOSConfigWithExpansions): Ditto.
- 4:40 PM Changeset in webkit [216702] by
-
- 121 edits in trunk/Source
Stop using PassRefPtr in platform/graphics
https://bugs.webkit.org/show_bug.cgi?id=171977
Reviewed by Alex Christensen.
Source/WebCore:
Stop using PassRefPtr in platform/graphics.
- css/CSSCrossfadeValue.cpp:
(WebCore::CSSCrossfadeValue::image):
- css/CSSFilterImageValue.cpp:
(WebCore::CSSFilterImageValue::image):
- loader/cache/CachedImage.cpp:
(WebCore::CachedImage::brokenImage):
(WebCore::CachedImage::image):
(WebCore::CachedImage::imageForRenderer):
- page/PageSerializer.cpp:
(WebCore::PageSerializer::addImageToResources):
- platform/ScrollView.cpp:
(WebCore::ScrollView::paintPanScrollIcon):
- platform/graphics/CrossfadeGeneratedImage.cpp:
(WebCore::CrossfadeGeneratedImage::drawCrossfade):
- platform/graphics/FontPlatformData.h:
- platform/graphics/GraphicsContext.h:
- platform/graphics/Image.cpp:
(WebCore::Image::nullImage):
- platform/graphics/Image.h:
- platform/graphics/MediaPlayer.cpp:
(WebCore::MediaPlayer::createResourceLoader):
- platform/graphics/MediaPlayer.h:
- platform/graphics/Pattern.cpp:
(WebCore::Pattern::create):
(WebCore::Pattern::Pattern):
- platform/graphics/Pattern.h:
- platform/graphics/PlatformTextTrack.h:
(WebCore::PlatformTextTrack::create):
(WebCore::PlatformTextTrack::createOutOfBand):
(WebCore::PlatformTextTrack::captionMenuOffItem):
(WebCore::PlatformTextTrack::captionMenuAutomaticItem):
- platform/graphics/avfoundation/InbandMetadataTextTrackPrivateAVF.cpp:
(WebCore::InbandMetadataTextTrackPrivateAVF::create):
(WebCore::InbandMetadataTextTrackPrivateAVF::addDataCue):
- platform/graphics/avfoundation/InbandMetadataTextTrackPrivateAVF.h:
- platform/graphics/avfoundation/InbandTextTrackPrivateAVF.cpp:
(WebCore::InbandTextTrackPrivateAVF::processAttributedStrings):
- platform/graphics/avfoundation/MediaSelectionGroupAVFObjC.h:
- platform/graphics/avfoundation/MediaSelectionGroupAVFObjC.mm:
(WebCore::MediaSelectionOptionAVFObjC::create):
(WebCore::MediaSelectionGroupAVFObjC::create):
(WebCore::MediaSelectionGroupAVFObjC::updateOptions):
- platform/graphics/avfoundation/cf/InbandTextTrackPrivateAVCF.h:
(WebCore::InbandTextTrackPrivateAVCF::create):
- platform/graphics/avfoundation/cf/InbandTextTrackPrivateLegacyAVCF.h:
(WebCore::InbandTextTrackPrivateLegacyAVCF::create):
- platform/graphics/avfoundation/cf/WebCoreAVCFResourceLoader.cpp:
(WebCore::WebCoreAVCFResourceLoader::create):
- platform/graphics/avfoundation/cf/WebCoreAVCFResourceLoader.h:
- platform/graphics/avfoundation/objc/CDMSessionAVContentKeySession.h:
- platform/graphics/avfoundation/objc/CDMSessionAVContentKeySession.mm:
(WebCore::CDMSessionAVContentKeySession::generateKeyReleaseMessage):
- platform/graphics/avfoundation/objc/CDMSessionAVStreamSession.h:
- platform/graphics/avfoundation/objc/CDMSessionAVStreamSession.mm:
(WebCore::CDMSessionAVStreamSession::generateKeyReleaseMessage):
- platform/graphics/avfoundation/objc/InbandTextTrackPrivateAVFObjC.h:
(WebCore::InbandTextTrackPrivateAVFObjC::create):
- platform/graphics/avfoundation/objc/InbandTextTrackPrivateLegacyAVFObjC.h:
(WebCore::InbandTextTrackPrivateLegacyAVFObjC::create):
- platform/graphics/avfoundation/objc/OutOfBandTextTrackPrivateAVF.h:
(WebCore::OutOfBandTextTrackPrivateAVF::create):
- platform/graphics/avfoundation/objc/WebCoreAVFResourceLoader.h:
- platform/graphics/avfoundation/objc/WebCoreAVFResourceLoader.mm:
(WebCore::WebCoreAVFResourceLoader::create):
- platform/graphics/ca/GraphicsLayerCA.cpp:
(WebCore::GraphicsLayerCA::createPlatformCALayer):
(WebCore::GraphicsLayerCA::createPlatformCAAnimation):
(WebCore::GraphicsLayerCA::setContentsToPlatformLayer):
(WebCore::GraphicsLayerCA::replicatedLayerRoot):
(WebCore::GraphicsLayerCA::createAnimationFromKeyframes):
(WebCore::GraphicsLayerCA::appendToUncommittedAnimations):
(WebCore::GraphicsLayerCA::createBasicAnimation):
(WebCore::GraphicsLayerCA::createKeyframeAnimation):
(WebCore::GraphicsLayerCA::createSpringAnimation):
- platform/graphics/ca/GraphicsLayerCA.h:
(WebCore::GraphicsLayerCA::LayerPropertyAnimation::LayerPropertyAnimation):
- platform/graphics/ca/PlatformCAAnimation.h:
- platform/graphics/ca/cocoa/PlatformCAAnimationCocoa.h:
- platform/graphics/ca/cocoa/PlatformCAAnimationCocoa.mm:
(PlatformCAAnimationCocoa::create):
(PlatformCAAnimationCocoa::copy):
- platform/graphics/ca/win/AbstractCACFLayerTreeHost.h:
- platform/graphics/ca/win/CACFLayerTreeHost.cpp:
(WebCore::CACFLayerTreeHost::create):
(WebCore::CACFLayerTreeHost::addPendingAnimatedLayer):
- platform/graphics/ca/win/CACFLayerTreeHost.h:
- platform/graphics/ca/win/PlatformCAAnimationWin.cpp:
(PlatformCAAnimationWin::create):
(PlatformCAAnimationWin::copy):
- platform/graphics/ca/win/PlatformCAAnimationWin.h:
- platform/graphics/ca/win/PlatformCALayerWin.cpp:
(PlatformCALayerWin::addAnimationForKey):
- platform/graphics/ca/win/WKCACFViewLayerTreeHost.cpp:
(WebCore::WKCACFViewLayerTreeHost::create):
- platform/graphics/ca/win/WKCACFViewLayerTreeHost.h:
- platform/graphics/cairo/PatternCairo.cpp:
(WebCore::Pattern::createPlatformPattern):
- platform/graphics/cairo/PlatformContextCairo.cpp:
(WebCore::PlatformContextCairo::clipForPatternFilling):
- platform/graphics/cg/PDFDocumentImage.h:
- platform/graphics/cg/PatternCG.cpp:
(WebCore::Pattern::createPlatformPattern):
- platform/graphics/filters/FEDiffuseLighting.cpp:
(WebCore::FEDiffuseLighting::FEDiffuseLighting):
(WebCore::FEDiffuseLighting::create):
(WebCore::FEDiffuseLighting::lightSource):
- platform/graphics/filters/FEDiffuseLighting.h:
- platform/graphics/filters/FELighting.cpp:
(WebCore::FELighting::FELighting):
(WebCore::FELighting::drawLighting):
- platform/graphics/filters/FELighting.h:
- platform/graphics/filters/FESpecularLighting.cpp:
(WebCore::FESpecularLighting::FESpecularLighting):
(WebCore::FESpecularLighting::create):
(WebCore::FESpecularLighting::lightSource):
- platform/graphics/filters/FESpecularLighting.h:
- platform/graphics/filters/FETile.cpp:
(WebCore::FETile::platformApplySoftware):
- platform/graphics/filters/FilterEffect.cpp:
(WebCore::FilterEffect::asUnmultipliedImage):
(WebCore::FilterEffect::asPremultipliedImage):
- platform/graphics/filters/FilterEffect.h:
- platform/graphics/filters/FilterOperation.cpp:
(WebCore::ReferenceFilterOperation::setFilterEffect):
(WebCore::BasicColorMatrixFilterOperation::blend):
(WebCore::BasicComponentTransferFilterOperation::blend):
(WebCore::BlurFilterOperation::blend):
(WebCore::DropShadowFilterOperation::blend):
- platform/graphics/filters/FilterOperation.h:
(WebCore::FilterOperation::blend):
(WebCore::PassthroughFilterOperation::create):
(WebCore::ReferenceFilterOperation::create):
- platform/graphics/gpu/Texture.cpp:
(WebCore::Texture::create):
- platform/graphics/gpu/Texture.h:
- platform/graphics/gstreamer/AudioTrackPrivateGStreamer.h:
- platform/graphics/gstreamer/ImageGStreamer.h:
(WebCore::ImageGStreamer::createImage):
(WebCore::ImageGStreamer::image):
- platform/graphics/gstreamer/InbandMetadataTextTrackPrivateGStreamer.h:
(WebCore::InbandMetadataTextTrackPrivateGStreamer::create):
(WebCore::InbandMetadataTextTrackPrivateGStreamer::addGenericCue):
- platform/graphics/gstreamer/InbandTextTrackPrivateGStreamer.h:
(WebCore::InbandTextTrackPrivateGStreamer::create):
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::processTableOfContentsEntry):
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:
(WebCore::MediaPlayerPrivateGStreamerBase::paint):
- platform/graphics/gstreamer/VideoTrackPrivateGStreamer.h:
- platform/graphics/gstreamer/mse/MediaSourceClientGStreamerMSE.cpp:
(WebCore::MediaSourceClientGStreamerMSE::enqueueSample):
- platform/graphics/gstreamer/mse/MediaSourceClientGStreamerMSE.h:
- platform/graphics/gstreamer/mse/MediaSourceGStreamer.cpp:
- platform/graphics/gstreamer/mse/PlaybackPipeline.cpp:
(WebCore::PlaybackPipeline::enqueueSample):
- platform/graphics/gstreamer/mse/PlaybackPipeline.h:
- platform/graphics/gtk/ImageGtk.cpp:
(WebCore::loadImageFromGResource):
(WebCore::loadResourceSharedBuffer):
(WebCore::loadMissingImageIconFromTheme):
(WebCore::Image::loadPlatformResource):
- platform/graphics/harfbuzz/HarfBuzzFace.cpp:
(WebCore::FaceCacheEntry::create):
- platform/graphics/harfbuzz/HarfBuzzFace.h:
(WebCore::HarfBuzzFace::create):
- platform/graphics/mac/ImageMac.mm:
(WebCore::Image::loadPlatformResource):
- platform/graphics/opentype/OpenTypeMathData.h:
(WebCore::OpenTypeMathData::create):
- platform/graphics/texmap/BitmapTexture.h:
(WebCore::BitmapTexture::applyFilters):
- platform/graphics/texmap/BitmapTextureGL.cpp:
(WebCore::BitmapTextureGL::applyFilters):
- platform/graphics/texmap/BitmapTextureGL.h:
(WebCore::BitmapTextureGL::FilterInfo::FilterInfo):
- platform/graphics/texmap/GraphicsLayerTextureMapper.cpp:
(WebCore::GraphicsLayerTextureMapper::commitLayerChanges):
- platform/graphics/texmap/TextureMapper.cpp:
(WebCore::TextureMapper::acquireTextureFromPool):
- platform/graphics/texmap/TextureMapper.h:
- platform/graphics/texmap/TextureMapperGL.cpp:
(WebCore::TextureMapperGL::createTexture):
- platform/graphics/texmap/TextureMapperGL.h:
- platform/graphics/texmap/TextureMapperLayer.cpp:
(WebCore::TextureMapperLayer::paintIntoSurface):
(WebCore::commitSurface):
(WebCore::TextureMapperLayer::paintWithIntermediateSurface):
(WebCore::TextureMapperLayer::setBackingStore):
- platform/graphics/texmap/TextureMapperLayer.h:
- platform/graphics/texmap/TextureMapperTiledBackingStore.h:
(WebCore::TextureMapperTiledBackingStore::create):
- platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp:
(WebCore::CoordinatedGraphicsLayer::syncImageBacking):
- platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.h:
- platform/graphics/texmap/coordinated/CoordinatedImageBacking.cpp:
(WebCore::CoordinatedImageBacking::create):
(WebCore::CoordinatedImageBacking::CoordinatedImageBacking):
- platform/graphics/texmap/coordinated/CoordinatedImageBacking.h:
- platform/graphics/win/ImageWin.cpp:
(WebCore::Image::loadPlatformResource):
- platform/graphics/win/MediaPlayerPrivateFullscreenWindow.cpp:
(WebCore::MediaPlayerPrivateFullscreenWindow::setRootChildLayer):
- platform/graphics/win/MediaPlayerPrivateFullscreenWindow.h:
- platform/graphics/win/PatternDirect2D.cpp:
(WebCore::Pattern::createPlatformPattern):
- platform/graphics/win/SharedGDIObject.h:
(WebCore::SharedGDIObject::create):
- rendering/FilterEffectRenderer.cpp:
(WebCore::FilterEffectRenderer::build):
- rendering/RenderImageResource.cpp:
(WebCore::RenderImageResource::image):
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::drawPlatformResizerImage):
- rendering/svg/RenderSVGResourcePattern.cpp:
(WebCore::RenderSVGResourcePattern::buildPattern):
- svg/SVGFEDiffuseLightingElement.cpp:
(WebCore::SVGFEDiffuseLightingElement::setFilterEffectAttribute):
(WebCore::SVGFEDiffuseLightingElement::build):
- svg/SVGFESpecularLightingElement.cpp:
(WebCore::SVGFESpecularLightingElement::setFilterEffectAttribute):
(WebCore::SVGFESpecularLightingElement::build):
- svg/graphics/SVGImageCache.cpp:
(WebCore::SVGImageCache::imageForRenderer):
Source/WebKit/win:
Build fix.
- FullscreenVideoController.cpp:
(FullscreenVideoController::enterFullscreen):
- WebKitDLL.cpp:
(loadResourceIntoBuffer):
Source/WebKit2:
Build fix.
- Shared/CoordinatedGraphics/CoordinatedGraphicsScene.cpp:
(WebKit::CoordinatedGraphicsScene::createBackingStoreIfNeeded):
(WebKit::CoordinatedGraphicsScene::removeBackingStoreIfNeeded):
- Shared/WebCoreArgumentCoders.cpp:
(IPC::ArgumentCoder<Cursor>::decode):
- WebProcess/WebPage/CoordinatedGraphics/CompositingCoordinator.cpp:
(WebKit::CompositingCoordinator::createImageBackingIfNeeded):
- WebProcess/WebPage/CoordinatedGraphics/CompositingCoordinator.h:
- WebProcess/WebPage/mac/GraphicsLayerCARemote.cpp:
(WebKit::GraphicsLayerCARemote::createPlatformCALayer):
(WebKit::GraphicsLayerCARemote::createPlatformCAAnimation):
- WebProcess/WebPage/mac/GraphicsLayerCARemote.h:
- WebProcess/WebPage/mac/PlatformCAAnimationRemote.h:
- WebProcess/WebPage/mac/PlatformCAAnimationRemote.mm:
(WebKit::PlatformCAAnimationRemote::copy):
- 4:34 PM Changeset in webkit [216701] by
-
- 2 edits in trunk/Tools
REGRESSION(r216217): lldb_webkit.py no longer prints out a WTFString, StringImpl needs to handle StringImplShape change
https://bugs.webkit.org/show_bug.cgi?id=171989
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2017-05-11
Reviewed by Brian Burg.
- lldb/lldb_webkit.py:
(WTFStringImplProvider.get_data8):
(WTFStringImplProvider.get_data16):
m_data8 and m_data16 are now part of the superclass StringImplShape
instead of directly in StringImpl. So first get the shape by getting
index 0, and the data properties are the same offset within that.
- 4:33 PM Changeset in webkit [216700] by
-
- 2 edits in trunk/Source/WTF
Annotate Ref::ptr() with RETURNS_NONNULL
https://bugs.webkit.org/show_bug.cgi?id=171996
Reviewed by Andreas Kling.
Annotate Ref::ptr() with RETURNS_NONNULL as it can never return null.
- wtf/Ref.h:
(WTF::Ref::ptr): Deleted.
- 4:05 PM Changeset in webkit [216699] by
-
- 14 edits in trunk/Source/JavaScriptCore
Callers of JSString::unsafeView() should check exceptions
https://bugs.webkit.org/show_bug.cgi?id=171995
Reviewed by Mark Lam.
unsafeView() can throw OOME. So, callers of unsafeView() should check for exceptions before trying
to access the view.
Also, I made the functions surrounding unsafeView() take ExecState* not ExecState&, to comply with
the rest of JSC.
- dfg/DFGOperations.cpp:
- jsc.cpp:
(printInternal):
(functionDebug):
- runtime/ArrayPrototype.cpp:
(JSC::arrayProtoFuncJoin):
- runtime/FunctionConstructor.cpp:
(JSC::constructFunctionSkippingEvalEnabledCheck):
- runtime/IntlCollatorPrototype.cpp:
(JSC::IntlCollatorFuncCompare):
- runtime/JSGenericTypedArrayViewPrototypeFunctions.h:
(JSC::genericTypedArrayViewProtoFuncJoin):
- runtime/JSGlobalObjectFunctions.cpp:
(JSC::globalFuncParseFloat):
- runtime/JSONObject.cpp:
(JSC::JSONProtoFuncParse):
- runtime/JSString.cpp:
(JSC::JSString::getPrimitiveNumber):
(JSC::JSString::toNumber):
- runtime/JSString.h:
(JSC::JSString::getIndex):
(JSC::JSRopeString::unsafeView):
(JSC::JSRopeString::viewWithUnderlyingString):
(JSC::JSString::unsafeView):
(JSC::JSString::viewWithUnderlyingString):
- runtime/JSStringJoiner.h:
(JSC::JSStringJoiner::appendWithoutSideEffects):
(JSC::JSStringJoiner::append):
- runtime/ParseInt.h:
(JSC::toStringView):
- runtime/StringPrototype.cpp:
(JSC::stringProtoFuncRepeatCharacter):
(JSC::stringProtoFuncCharAt):
(JSC::stringProtoFuncCharCodeAt):
(JSC::stringProtoFuncIndexOf):
(JSC::stringProtoFuncNormalize):
- 4:03 PM Changeset in webkit [216698] by
-
- 3 edits in trunk/Source/WebKit2
Data loss when saving a PDF form where only radio buttons/checkboxes were modified
https://bugs.webkit.org/show_bug.cgi?id=171991
<rdar://problem/32115945>
Reviewed by Andy Estes.
- WebProcess/Plugins/PDF/PDFLayerControllerSPI.h:
- WebProcess/Plugins/PDF/PDFPlugin.mm:
(-[WKPDFLayerControllerDelegate didChangeAnnotationState]):
Mark the PDF as dirty (so we re-encode it when asked to save) if annotations
that only PDFKit knows about change.
- 3:31 PM Changeset in webkit [216697] by
-
- 2 edits in trunk/LayoutTests
Marked tiled-drawing/scrolling/fast-scroll-iframe-latched-mainframe.html as flaky.
https://bugs.webkit.org/show_bug.cgi?id=168937
Unreviewed test gardening.
- platform/mac-wk2/TestExpectations:
- 2:45 PM Changeset in webkit [216696] by
-
- 29 edits21 deletes in trunk
Remove Vibration API
https://bugs.webkit.org/show_bug.cgi?id=171766
Rubber-stamped by Alexey Proskuryakov.
.:
- Source/cmake/WebKitFeatures.cmake:
Source/WebCore:
- features.json:
Mark the Vibration API as removed.
- CMakeLists.txt:
- DerivedSources.cpp:
- Modules/vibration/NavigatorVibration.cpp: Removed.
- Modules/vibration/NavigatorVibration.h: Removed.
- Modules/vibration/NavigatorVibration.idl: Removed.
- Modules/vibration/Vibration.cpp: Removed.
- Modules/vibration/Vibration.h: Removed.
- Modules/vibration/VibrationClient.h: Removed.
- testing/Internals.cpp:
(WebCore::Internals::isVibrating): Deleted.
- testing/Internals.h:
- testing/Internals.idl:
Source/WebKit2:
- CMakeLists.txt:
- Shared/API/APIObject.h:
- Shared/API/c/WKBase.h:
- UIProcess/API/C/WKAPICast.h:
- UIProcess/API/C/WKPage.cpp:
(WKPageGetVibration): Deleted.
- UIProcess/API/C/WKPage.h:
- UIProcess/API/C/WKVibration.cpp: Removed.
- UIProcess/API/C/WKVibration.h: Removed.
- UIProcess/WebPageProxy.cpp:
(WebKit::m_weakPtrFactory):
(WebKit::WebPageProxy::resetState):
- UIProcess/WebPageProxy.h:
(WebKit::WebPageProxy::vibration): Deleted.
- UIProcess/WebVibrationProvider.cpp: Removed.
- UIProcess/WebVibrationProvider.h: Removed.
- UIProcess/WebVibrationProxy.cpp: Removed.
- UIProcess/WebVibrationProxy.h: Removed.
- UIProcess/WebVibrationProxy.messages.in: Removed.
- WebProcess/WebCoreSupport/WebVibrationClient.cpp: Removed.
- WebProcess/WebCoreSupport/WebVibrationClient.h: Removed.
- WebProcess/WebPage/WebPage.cpp:
Source/WTF:
- wtf/FeatureDefines.h:
Tools:
- Scripts/webkitperl/FeatureList.pm:
LayoutTests:
- platform/gtk/TestExpectations:
- platform/ios/TestExpectations:
- platform/mac/TestExpectations:
- platform/win/TestExpectations:
- platform/wpe/TestExpectations:
- vibration/cancelVibration-after-pagevisibility-changed-to-hidden-expected.txt: Removed.
- vibration/cancelVibration-after-pagevisibility-changed-to-hidden.html: Removed.
- vibration/cancelVibration-during-pattern-vibrating-expected.txt: Removed.
- vibration/cancelVibration-during-pattern-vibrating.html: Removed.
- vibration/navigator-vibration-expected.txt: Removed.
- vibration/navigator-vibration.html: Removed.
- 2:39 PM Changeset in webkit [216695] by
-
- 18 edits2 adds1 delete in trunk
WebGLRenderingContext should implement WebGLRenderingContextBase
https://bugs.webkit.org/show_bug.cgi?id=171961
<rdar://problem/32124920>
Reviewed by Sam Weinig.
Source/WebCore:
WebGLRenderingContext and WebGL2RenderingContext are both
defined to "implement" WebGLRenderingContextBase. However, we
were doing it via inheritance, which meant that some things
were not visible on the WebGLRenderingContext prototype.
Test: fast/canvas/webgl/constants-on-interface.html
- WebCore.xcodeproj/project.pbxproj: Move the Custom.cpp files
out of the GC-only area now they have real content.
- bindings/js/JSDocumentCustom.cpp: Handle the fact that we
don't use the base class from the bindings, so we need to
translate WebGL1 and WebGL2 contexts into the right JS classes.
(WebCore::JSDocument::getCSSCanvasContext):
- bindings/js/JSHTMLCanvasElementCustom.cpp:
(WebCore::JSHTMLCanvasElement::getContext):
- bindings/js/JSWebGL2RenderingContextCustom.cpp: Implement the
custom methods. In this case, we don't yet expose any
extensions for WebGL 2.
(WebCore::toJS):
(WebCore::JSWebGL2RenderingContext::getExtension):
- bindings/js/JSWebGLRenderingContextBaseCustom.cpp: Removed.
- bindings/js/JSWebGLRenderingContextCustom.cpp:
(WebCore::toJS):
(WebCore::JSWebGLRenderingContext::getExtension):
- html/canvas/WebGL2RenderingContext.h: Make some things public.
- html/canvas/WebGLRenderingContext.h: Ditto.
- html/canvas/WebGL2RenderingContext.idl: Use implements.
- html/canvas/WebGLRenderingContext.idl: Ditto.
- testing/Internals.cpp: This now takes a WebGLRenderingContext.
(WebCore::Internals::simulateWebGLContextChanged):
- testing/Internals.h:
- testing/Internals.idl:
LayoutTests:
New test to make sure constants from WebGLRenderingContextBase are
visible on the WebGLRenderingContext prototype.
Also, fix up some existing tests that were expecting to see
instances of WebGLRenderingContextBase.
- fast/canvas/webgl/constants-on-interface-expected.txt: Added.
- fast/canvas/webgl/constants-on-interface.html: Added.
- fast/canvas/webgl/gl-object-get-calls-expected.txt:
- fast/canvas/webgl/null-object-behaviour-expected.txt:
- fast/canvas/webgl/texImageTest-expected.txt:
- 1:58 PM Changeset in webkit [216694] by
-
- 2 edits in trunk/LayoutTests
Fixed typo errors in TestExpectations.
Unreviewed test gardening.
- platform/mac-wk2/TestExpectations:
- 1:55 PM Changeset in webkit [216693] by
-
- 2 edits in trunk/LayoutTests
Fixed typo errors in TestExpectations.
Unreviewed test gardening.
- platform/mac-wk2/TestExpectations:
- 1:52 PM Changeset in webkit [216692] by
-
- 4 edits in trunk/Source/WebInspectorUI
Web Inspector: RTL: "Elements > Styles - Rules" rule and media query headers should be left aligned
https://bugs.webkit.org/show_bug.cgi?id=171954
<rdar://problem/31961976>
Reviewed by Matt Baker.
- UserInterface/Views/CSSStyleDeclarationSection.css:
(.style-declaration-section > .header):
(.style-declaration-section.locked > .header > .locked-icon):
(.style-declaration-section > .header > .icon):
(.style-declaration-section > .header > textarea):
(.style-declaration-section.invalid-selector > .header > .icon):
(body[dir=ltr] .style-declaration-section > .header): Deleted.
(body[dir=rtl] .style-declaration-section > .header): Deleted.
(body[dir=ltr] .style-declaration-section.locked > .header > .locked-icon): Deleted.
(body[dir=rtl] .style-declaration-section.locked > .header > .locked-icon): Deleted.
(body[dir=ltr] .style-declaration-section > .header > .icon): Deleted.
(body[dir=rtl] .style-declaration-section > .header > .icon): Deleted.
(body[dir=ltr] .style-declaration-section > .header > textarea): Deleted.
(body[dir=rtl] .style-declaration-section > .header > textarea): Deleted.
Remove RTL rules.
- UserInterface/Views/CSSStyleDeclarationSection.js:
(WebInspector.CSSStyleDeclarationSection):
Set dir="ltr" so selector's textareas work correctly.
- UserInterface/Views/RulesStyleDetailsPanel.css:
(.sidebar > .panel.details.css-style .rules):
- 1:30 PM Changeset in webkit [216691] by
-
- 5 edits in trunk/Source
Fix a spelling mistake in ApplePayErrorCode
https://bugs.webkit.org/show_bug.cgi?id=171981
<rdar://problem/32136567>
Reviewed by Beth Dakin.
Source/WebCore:
- Modules/applepay/ApplePayError.idl:
- Modules/applepay/PaymentRequest.h:
Source/WebKit2:
- UIProcess/ApplePay/cocoa/WebPaymentCoordinatorProxyCocoa.mm:
(WebKit::toPKPaymentErrorCode):
(WebKit::toPKPaymentAuthorizationStatus):
- 1:04 PM Changeset in webkit [216690] by
-
- 7 edits1 add in trunk/Source
Resource Load Statistics: Enable configuration through preferences
https://bugs.webkit.org/show_bug.cgi?id=171949
<rdar://problem/31894518>
Reviewed by Alex Christensen.
Source/WebCore:
No new tests. Just an added setter.
- loader/ResourceLoadObserver.cpp:
(WebCore::ResourceLoadObserver::setReducedTimestampResolution):
Source/WebKit2:
- Shared/WebPreferencesDefinitions.h:
Added ResourceLoadStatisticsTimeToLiveUserInteraction,
ResourceLoadStatisticsTimeToLiveCookiePartitionFree, and
ResourceLoadStatisticsReducedTimestampResolution.
- UIProcess/Cocoa/WebResourceLoadStatisticsManagerCocoa.mm: Added.
(WebKit::WebResourceLoadStatisticsManager::registerUserDefaultsIfNeeded):
- UIProcess/WebResourceLoadStatisticsManager.h:
- UIProcess/WebResourceLoadStatisticsStore.cpp:
(WebKit::WebResourceLoadStatisticsStore::registerSharedResourceLoadObserver):
Now calls WebResourceLoadStatisticsManager::registerUserDefaultsIfNeeded().
- WebKit2.xcodeproj/project.pbxproj:
- 12:59 PM Changeset in webkit [216689] by
-
- 6 edits4 adds in trunk/Source/JavaScriptCore
Offer SPI to notify clients that GC has happened
https://bugs.webkit.org/show_bug.cgi?id=171980
Reviewed by Geoffrey Garen.
Sometimes when you're programming with weak references, it's most convenient if the GC tells
you when it finishes. This adds exactly such an API. This API is called at the *flip*: the
moment when the GC knows for sure which objects are dead and has definitely not allocated any
new objects or executed any JS code. The finalization part of the flip, which is where this
callback gets called, runs on the "main" thread - i.e. some thread that is attempting to
execute JS code and holds the JS lock. This will usually run as a side-effect of some
allocation or from the runloop.
This means, for example, that if you implemented a vector of weak references and registered a
callback to prune the vector of null weak references, then aside from the callback, nobody
would ever see a null weak reference in the vector.
- API/JSHeapFinalizerPrivate.cpp: Added.
(JSContextGroupAddHeapFinalizer):
(JSContextGroupRemoveHeapFinalizer):
- API/JSHeapFinalizerPrivate.h: Added.
- API/tests/testapi.c:
(heapFinalizer):
(testMarkingConstraintsAndHeapFinalizers):
(main):
(testMarkingConstraints): Deleted.
- CMakeLists.txt:
- JavaScriptCore.xcodeproj/project.pbxproj:
- heap/Heap.cpp:
(JSC::Heap::finalize):
(JSC::Heap::addHeapFinalizerCallback):
(JSC::Heap::removeHeapFinalizerCallback):
- heap/Heap.h:
- heap/HeapFinalizerCallback.cpp: Added.
(JSC::HeapFinalizerCallback::dump):
- heap/HeapFinalizerCallback.h: Added.
(JSC::HeapFinalizerCallback::HeapFinalizerCallback):
(JSC::HeapFinalizerCallback::operator==):
(JSC::HeapFinalizerCallback::operator!=):
(JSC::HeapFinalizerCallback::operator bool):
(JSC::HeapFinalizerCallback::run):
- 11:49 AM Changeset in webkit [216688] by
-
- 5 edits in trunk/Source/WebCore
Unify hasTouchScrollableOverflow/needsCompositedScrolling concepts
https://bugs.webkit.org/show_bug.cgi?id=171974
Patch by Frederic Wang <fwang@igalia.com> on 2017-05-11
Reviewed by Simon Fraser.
This commit moves the following pattern in a single RenderLayer::usesAcceleratedScrolling function:
#if PLATFORM(IOS)
...hasTouchScrollableOverflow()...
#else
...needsCompositedScrolling()...
#endif
No new tests, behavior unchanged.
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::usesAcceleratedScrolling): Introduce helper function.
- rendering/RenderLayer.h: Declare the function.
- rendering/RenderLayerBacking.cpp:
(WebCore::layerOrAncestorIsTransformedOrUsingCompositedScrolling): Use the new function.
(WebCore::RenderLayerBacking::updateConfiguration): Ditto.
- rendering/RenderLayerCompositor.cpp:
(WebCore::useCoordinatedScrollingForLayer): Ditto.
- 11:38 AM Changeset in webkit [216687] by
-
- 2 edits in trunk/LayoutTests
Marked imported/w3c/web-platform-tests/html/webappapis/timers/negative-settimeout.html as flaky.
https://bugs.webkit.org/show_bug.cgi?id=170699
Unreviewed test gardening.
- platform/mac-wk2/TestExpectations:
- 11:32 AM Changeset in webkit [216686] by
-
- 9 edits in trunk
[Readable Streams API] Implement ReadableStreamBYOBReader cancel()
https://bugs.webkit.org/show_bug.cgi?id=171919
Patch by Romain Bellessort <romain.bellessort@crf.canon.fr> on 2017-05-11
Reviewed by Youenn Fablet.
LayoutTests/imported/w3c:
Updated expectations.
- web-platform-tests/streams/readable-byte-streams/general-expected.txt:
- web-platform-tests/streams/readable-byte-streams/general.dedicatedworker-expected.txt:
Source/WebCore:
Implemented ReadableStreamBYOBReader cancel() method.
Added tests checking cancel().
- Modules/streams/ReadableStreamBYOBReader.js:
(cancel): Implemented.
- Modules/streams/ReadableStreamInternals.js:
(readableStreamError): Updated to support ReadableStreamBYOBReader case.
LayoutTests:
Added test cases to check cancel() behaviour.
- streams/readable-stream-byob-reader-expected.txt: Updated.
- streams/readable-stream-byob-reader.js: Updated.
- 11:18 AM Changeset in webkit [216685] by
-
- 2 edits in trunk/LayoutTests
Marked media/media-controls-clone-crash.html as flaky.
https://bugs.webkit.org/show_bug.cgi?id=171978
Unreviewed test gardening.
- platform/mac-wk2/TestExpectations:
- 11:01 AM Changeset in webkit [216684] by
-
- 4 edits in trunk/Source/JavaScriptCore
JSWeakCreate/Retain/Release should take a JSContextGroupRef and not a JSContextRef
https://bugs.webkit.org/show_bug.cgi?id=171979
Reviewed by Mark Lam.
Functions that don't execute arbitrary JS but just need access to the VM should take a
JSContextGroupRef, not a JSContextRef.
- API/JSWeakPrivate.cpp:
(JSWeakCreate):
(JSWeakRetain):
(JSWeakRelease):
- API/JSWeakPrivate.h:
- API/tests/testapi.c:
(testMarkingConstraints):
- 10:55 AM Changeset in webkit [216683] by
-
- 6 edits in trunk/Source/WebCore
Stop using PassRefPtr in WebGPU code
https://bugs.webkit.org/show_bug.cgi?id=171965
Reviewed by Alex Christensen.
Stop using PassRefPtr in WebGPU code.
- html/canvas/WebGPUDrawable.cpp:
(WebCore::WebGPUDrawable::WebGPUDrawable):
- html/canvas/WebGPURenderingContext.cpp:
(WebCore::WebGPURenderingContext::create):
(WebCore::WebGPURenderingContext::WebGPURenderingContext):
- html/canvas/WebGPURenderingContext.h:
- html/canvas/WebGPUTexture.cpp:
(WebCore::WebGPUTexture::createFromDrawableTexture):
(WebCore::WebGPUTexture::WebGPUTexture):
- html/canvas/WebGPUTexture.h:
- 10:31 AM Changeset in webkit [216682] by
-
- 3 edits in trunk/Source/WebCore
Name WebRTC Threads
https://bugs.webkit.org/show_bug.cgi?id=171975
Patch by Youenn Fablet <youenn@apple.com> on 2017-05-11
Reviewed by Eric Carlson.
No change of behavior.
- platform/mediastream/libwebrtc/LibWebRTCAudioModule.cpp:
(WebCore::LibWebRTCAudioModule::LibWebRTCAudioModule): Setting audio module thread name.
- platform/mediastream/libwebrtc/LibWebRTCProvider.cpp:
(WebCore::initializePeerConnectionFactoryAndThreads): Setting signaling and networking thread names.
- 10:14 AM Changeset in webkit [216681] by
-
- 7 edits in trunk
Web Inspector: Error trying to delete DOM breakpoints from the Debugger tab
https://bugs.webkit.org/show_bug.cgi?id=171970
<rdar://problem/32129262>
Reviewed by Brian Burg.
Source/WebInspectorUI:
In the Debugger sidebar, DOM breakpoints can be cleared from a DOM node
in two ways: by using the DOM node tree element's context menu, or by
pressing the delete key while the element is selected. Each method used
a different code path, and the latter had an error which caused it to fail.
Add a
removeDOMBreakpointsForNodemethod to DOMDebuggerManager to make
the operation convenient, and call it from both event handlers.
- UserInterface/Controllers/DOMBreakpointTreeController.js:
(WebInspector.DOMBreakpointTreeController.appendBreakpointContextMenuItems):
Use convenience method.
- UserInterface/Controllers/DOMDebuggerManager.js:
(WebInspector.DOMDebuggerManager.prototype.removeDOMBreakpointsForNode):
Helper function for removing all of a node's breakpoints.
- UserInterface/Views/DOMNodeTreeElement.js:
(WebInspector.DOMNodeTreeElement.prototype.ondelete):
Use convenience method.
LayoutTests:
Add test for DOMDebuggerManager.prototype.removeDOMBreakpointsForNode.
- inspector/dom-debugger/dom-breakpoints-expected.txt:
- inspector/dom-debugger/dom-breakpoints.html:
- 9:31 AM Changeset in webkit [216680] by
-
- 3 edits in trunk/LayoutTests
LayoutTest http/tests/media/track-in-band-hls-metadata-crash.html is a flaky timeout
https://bugs.webkit.org/show_bug.cgi?id=167749
Reviewed by Eric Carlson.
Revert parts of r216588. The position of the 'canplaythrough' event in the event sequence
is not always the same, causing flakiness. Stop listening to the 'canplaythrough' event,
this was introduced in r216588.
- http/tests/media/track-in-band-hls-metadata-crash-expected.txt:
- http/tests/media/track-in-band-hls-metadata-crash.html:
- 9:29 AM Changeset in webkit [216679] by
-
- 14 edits in trunk/Source/WebCore
Stop using PassRefPtr in platform/audio
https://bugs.webkit.org/show_bug.cgi?id=171966
Reviewed by Ryosuke Niwa.
Stop using PassRefPtr in platform/audio.
- platform/audio/AudioBus.h:
(WebCore::AudioBus::AudioBus):
- platform/audio/AudioFileReader.h:
- platform/audio/HRTFDatabaseLoader.cpp:
(WebCore::HRTFDatabaseLoader::createAndLoadAsynchronouslyIfNecessary):
- platform/audio/HRTFDatabaseLoader.h:
- platform/audio/HRTFKernel.cpp:
(WebCore::HRTFKernel::createInterpolatedKernel):
- platform/audio/HRTFKernel.h:
(WebCore::HRTFKernel::create):
- platform/audio/glib/AudioBusGLib.cpp:
(WebCore::AudioBus::loadPlatformResource):
- platform/audio/gstreamer/AudioFileReaderGStreamer.cpp:
(WebCore::AudioFileReader::createBus):
(WebCore::createBusFromAudioFile):
(WebCore::createBusFromInMemoryAudioFile):
- platform/audio/ios/AudioFileReaderIOS.cpp:
(WebCore::AudioFileReader::createBus):
(WebCore::createBusFromAudioFile):
(WebCore::createBusFromInMemoryAudioFile):
- platform/audio/ios/AudioFileReaderIOS.h:
- platform/audio/mac/AudioBusMac.mm:
(WebCore::AudioBus::loadPlatformResource):
- platform/audio/mac/AudioFileReaderMac.cpp:
(WebCore::AudioFileReader::createBus):
(WebCore::createBusFromAudioFile):
(WebCore::createBusFromInMemoryAudioFile):
- platform/audio/mac/AudioFileReaderMac.h:
- 9:29 AM Changeset in webkit [216678] by
-
- 5 edits in trunk/Tools
Add WPE release bots
https://bugs.webkit.org/show_bug.cgi?id=171973
Reviewed by Žan Doberšek.
This adds a WPE Release Build bot (64-bit) and a WPE Release Test bot.
It also adds a new WPE buildbot category.
- BuildSlaveSupport/build.webkit.org-config/config.json:
- BuildSlaveSupport/build.webkit.org-config/master.cfg:
(InstallWpeDependencies):
(appendCustomBuildFlags):
(Factory.init):
(loadBuilderConfig):
- BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
- BuildSlaveSupport/build.webkit.org-config/templates/root.html:
- 8:26 AM Changeset in webkit [216677] by
-
- 10 edits in trunk
WorkerThread::stop() should call scheduleExecutionTermination() last.
https://bugs.webkit.org/show_bug.cgi?id=171775
<rdar://problem/30975761>
Reviewed by Geoffrey Garen.
Source/JavaScriptCore:
Increased the number of frames captured in VM::nativeStackTraceOfLastThrow()
from 25 to 100. From experience, I found that 25 is sometimes not sufficient
for our debugging needs.
Also added VM::throwingThread() to track which thread an exception was thrown in.
This may be useful if the client is entering the VM from different threads.
- runtime/ExceptionScope.cpp:
(JSC::ExceptionScope::unexpectedExceptionMessage):
(JSC::ExceptionScope::releaseAssertIsTerminatedExecutionException):
- runtime/ExceptionScope.h:
(JSC::ExceptionScope::exception):
(JSC::ExceptionScope::unexpectedExceptionMessage):
- runtime/VM.cpp:
(JSC::VM::throwException):
- runtime/VM.h:
(JSC::VM::throwingThread):
(JSC::VM::clearException):
Source/WebCore:
Currently, WorkerThread::stop() calls scheduleExecutionTermination() to terminate
JS execution first, followed by posting a cleanup task to the worker, and lastly,
it invokes terminate() on the WorkerRunLoop.
As a result, before run loop is terminate, the worker thread may observe the
TerminatedExecutionException in JS code, bail out, see another JS task to run,
re-enters the VM to run said JS code, and fails with an assertion due to the
TerminatedExecutionException still being pending on VM entry.
WorkerRunLoop::Task::performTask() already has a check to only allow a task to
run if and only if !runLoop.terminated() and the task is not a clean up task.
We'll fix the above race by ensuring that having WorkerThread::stop() terminate
the run loop before it scheduleExecutionTermination() which throws the
TerminatedExecutionException. This way, by the time JS code unwinds out of the
VM due to the TerminatedExecutionException, runLoop.terminated() is guaranteed
to be true and thereby prevents re-entry into the VM.
This issue is covered by an existing test that I just unskipped in TestExpectations.
- bindings/js/JSDOMPromiseDeferred.cpp:
(WebCore::DeferredPromise::callFunction):
- workers/WorkerThread.cpp:
(WebCore::WorkerThread::stop):
LayoutTests:
- 6:33 AM Changeset in webkit [216676] by
-
- 2 edits in trunk/LayoutTests
Unreviewed GTK+ gardening. Update expectations of tests failing after r216450.
- platform/gtk/TestExpectations:
- 5:54 AM Changeset in webkit [216675] by
-
- 2 edits in trunk/Source/WebKit2
[GTK] Remove notifications guards from GTK API layer
https://bugs.webkit.org/show_bug.cgi?id=170014
Reviewed by Michael Catanzaro.
ENABLE_NOTIFICATIONS in the GTK port is a private option and
disabling it is unsupported, hence remove its guards from the GTK API
layer.
- UIProcess/API/gtk/WebKitWebContext.cpp:
(webkitWebContextConstructed):
- 2:09 AM Changeset in webkit [216674] by
-
- 1 copy in releases/WebKitGTK/webkit-2.17.2
WebKitGTK+ 2.17.2
- 1:34 AM Changeset in webkit [216673] by
-
- 4 edits in trunk
Unreviewed. Update OptionsGTK.cmake and NEWS for 2.17.2 release.
.:
- Source/cmake/OptionsGTK.cmake: Bump version numbers.
Source/WebKit2:
- gtk/NEWS: Add release notes for 2.17.2.
- 12:56 AM Changeset in webkit [216672] by
-
- 3 edits1 add in trunk
WebAssembly: stop supporting 0xD
https://bugs.webkit.org/show_bug.cgi?id=168788
<rdar://problem/31880922>
Reviewed by Saam Barati.
JSTests:
Test that only version 1 is supported.
- wasm/js-api/version.js: Added.
Source/JavaScriptCore:
Only version 1 is supported by other browsers, and there shouldn't
be any 0xD binaries in the wild anymore.
- wasm/WasmModuleParser.cpp:
- 12:56 AM Changeset in webkit [216671] by
-
- 1 edit18 adds in trunk/Source/WebInspectorUI
[GTK] Web Inspector: Add new GTK+ icons for resources in large sizes (32px @ 1x/2x)
https://bugs.webkit.org/show_bug.cgi?id=155802
<rdar://problem/25320686>
Patch by Fujii Hironori <Fujii Hironori> on 2017-05-11
Reviewed by Carlos Garcia Campos.
Add more free icons for the Web Inspector in GTK+.
- UserInterface/Images/gtk/ClippingCSSLarge.png: Added.
- UserInterface/Images/gtk/ClippingCSSLarge@2x.png: Added.
- UserInterface/Images/gtk/ClippingGenericLarge.png: Added.
- UserInterface/Images/gtk/ClippingGenericLarge@2x.png: Added.
- UserInterface/Images/gtk/ClippingJSLarge.png: Added.
- UserInterface/Images/gtk/ClippingJSLarge@2x.png: Added.
- UserInterface/Images/gtk/DocumentCSSLarge.png: Added.
- UserInterface/Images/gtk/DocumentCSSLarge@2x.png: Added.
- UserInterface/Images/gtk/DocumentFontLarge.png: Added.
- UserInterface/Images/gtk/DocumentFontLarge@2x.png: Added.
- UserInterface/Images/gtk/DocumentGenericLarge.png: Added.
- UserInterface/Images/gtk/DocumentGenericLarge@2x.png: Added.
- UserInterface/Images/gtk/DocumentImageLarge.png: Added.
- UserInterface/Images/gtk/DocumentImageLarge@2x.png: Added.
- UserInterface/Images/gtk/DocumentJSLarge.png: Added.
- UserInterface/Images/gtk/DocumentJSLarge@2x.png: Added.
- UserInterface/Images/gtk/DocumentMarkupLarge.png: Added.
- UserInterface/Images/gtk/DocumentMarkupLarge@2x.png: Added.
- 12:55 AM Changeset in webkit [216670] by
-
- 2 edits in trunk/Source/WebKit2
[GTK] JavaScript prompt uses title of page to be loaded rather than title of current page
https://bugs.webkit.org/show_bug.cgi?id=152690
Reviewed by Michael Catanzaro.
webkit_web_view_get_uri() returns the page to be loaded, use
internal api for this.
- UIProcess/API/gtk/WebKitWebView.cpp:
(webkitWebViewCreateJavaScriptDialog):
- 12:35 AM Changeset in webkit [216669] by
-
- 8 edits1 delete in trunk/Source/WebCore
Drop custom bindings code for HTMLFormControlsCollection's named property getter
https://bugs.webkit.org/show_bug.cgi?id=171964
Reviewed by Sam Weinig.
Drop custom bindings code for HTMLFormControlsCollection's named property getter as
we are able to generate it.
No new tests, no expected Web-facing behavior change.
- CMakeLists.txt:
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/JSBindingsAllInOne.cpp:
- bindings/js/JSHTMLFormControlsCollectionCustom.cpp: Removed.
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateNamedGetter):
- html/HTMLFormControlsCollection.cpp:
(WebCore::HTMLFormControlsCollection::namedItemOrItems):
- html/HTMLFormControlsCollection.h:
- html/HTMLFormControlsCollection.idl:
- 12:27 AM Changeset in webkit [216668] by
-
- 2 edits in branches/safari-604.1.21-branch/Source/WebCore
Cherry-pick r216530. rdar://problem/32080319
- 12:27 AM Changeset in webkit [216667] by
-
- 11 edits in branches/safari-604.1.21-branch/Source
Cherry-pick r216477. rdar://problem/32058957
- 12:27 AM Changeset in webkit [216666] by
-
- 2 edits in branches/safari-604.1.21-branch/Source/WebKit2
Cherry-pick r216475. rdar://problem/32041569
- 12:27 AM Changeset in webkit [216665] by
-
- 3 edits in branches/safari-604.1.21-branch/Source/WebCore
Cherry-pick r216471. rdar://problem/31132092
- 12:27 AM Changeset in webkit [216664] by
-
- 16 edits in branches/safari-604.1.21-branch/Source
Cherry-pick r216463. rdar://problem/32041545
- 12:27 AM Changeset in webkit [216663] by
-
- 4 edits in branches/safari-604.1.21-branch/Source/WebCore
Cherry-pick r216455. rdar://problem/32053243
- 12:27 AM Changeset in webkit [216662] by
-
- 8 edits in branches/safari-604.1.21-branch/Source
Cherry-pick r216446. rdar://problem/31848689
- 12:27 AM Changeset in webkit [216661] by
-
- 3 edits in branches/safari-604.1.21-branch/Source/WebKit2
Cherry-pick r216442. rdar://problem/32051789
- 12:27 AM Changeset in webkit [216660] by
-
- 4 edits in branches/safari-604.1.21-branch/Source
Cherry-pick r216436. rdar://problem/32041544
- 12:27 AM Changeset in webkit [216659] by
-
- 3 edits2 adds in branches/safari-604.1.21-branch
Cherry-pick r216331. rdar://problem/31122612
- 12:27 AM Changeset in webkit [216658] by
-
- 3 edits2 adds in branches/safari-604.1.21-branch
Cherry-pick r216307. rdar://problem/31955660
- 12:27 AM Changeset in webkit [216657] by
-
- 4 edits in branches/safari-604.1.21-branch
Cherry-pick r216292. rdar://problem/32027327
- 12:27 AM Changeset in webkit [216656] by
-
- 2 edits in branches/safari-604.1.21-branch/Source/WebCore
Cherry-pick r216285. rdar://problem/32041544
- 12:27 AM Changeset in webkit [216655] by
-
- 2 edits in branches/safari-604.1.21-branch/Tools
Cherry-pick r216272. rdar://problem/32027327
- 12:27 AM Changeset in webkit [216654] by
-
- 4 edits in branches/safari-604.1.21-branch
Cherry-pick r216258. rdar://problem/32017975
- 12:27 AM Changeset in webkit [216653] by
-
- 2 edits in branches/safari-604.1.21-branch/LayoutTests
Cherry-pick r216252. rdar://problem/32040952
May 10, 2017:
- 9:53 PM Changeset in webkit [216652] by
-
- 2 edits in trunk/Source/WebKit2
Null deref in WebPage::dictionaryPopupInfoForRange
https://bugs.webkit.org/show_bug.cgi?id=171959
<rdar://problem/20886282>
Reviewed by Beth Dakin.
- WebProcess/WebPage/mac/WebPageMac.mm:
(WebKit::WebPage::dictionaryPopupInfoForRange):
Speculative fix for non-reproducible crash when the startContainer of
the range is in an anonymous node.
- 9:23 PM Changeset in webkit [216651] by
-
- 2 edits in trunk/Websites/perf.webkit.org
Another build fix after r215633 to make the bar graphs render even when the confidence intervals aren't available.
- public/v3/components/bar-graph-group.js:
(BarGraphGroup.prototype._computeRange):
- 9:22 PM Changeset in webkit [216650] by
-
- 2 edits in trunk/Source/WebCore
[MediaStream] CoreAudioCaptureSource claims to never be muted
https://bugs.webkit.org/show_bug.cgi?id=171946
<rdar://problem/32111991>
Reviewed by Jer Noble.
- platform/mediastream/mac/CoreAudioCaptureSource.cpp:
(WebCore::CoreAudioCaptureSource::stopProducingData): Set m_muted to true.
- 9:06 PM Changeset in webkit [216649] by
-
- 2 edits in trunk/Websites/perf.webkit.org
Build fix after r215633.
- public/v3/models/test-group.js:
(TestGroup.prototype._computeRequestedCommitSets):
(TestGroup.prototype.requestsForCommitSet):
- 7:58 PM Changeset in webkit [216648] by
-
- 1 copy in tags/Safari-603.3.1
Tag Safari-603.3.1.
- 7:32 PM Changeset in webkit [216647] by
-
- 12 edits2 adds in trunk/Websites/perf.webkit.org
Add API to upload a patched build for a custom A/B testing
https://bugs.webkit.org/show_bug.cgi?id=171956
Reviewed by Chris Dumez.
Added /api/upload-root to upload a root file, the build product of a patch associated with a commit set.
Extracted more functions out of privileged-api/upload-file.php to uploaded-file-helpers.php to share code
with /api/upload-root.php.
- public/api/upload-root.php: Added.
(main):
(compute_commit_set_items_to_update): Find the list of commit set items to associate this root with.
A root can be associated with multiple repositories and there fore commit set items; e.g. if a software
is built from multiple repositories and there is a patch associated with one of them, the built product
must be associated with all those repositories.
- public/include/build-requests-fetcher.php:
(BuildRequestsFetcher::fetch_commits_for_set_if_needed): Include the root file is there is one.
- public/include/json-header.php:
(validate_arguments): Added the support for validating json string.
(verify_slave): Return the slave ID found.
- public/include/uploaded-file-helpers.php:
(validate_uploaded_file): Extracted from /privileged-api/upload-file to be shared with /api/upload-root.
(query_total_file_size): Ditto.
(create_uploaded_file_from_form_data): Ditto.
(upload_file_in_transaction): Ditto. Takes a lambda to do the extra work inside the transaction.
- public/privileged-api/upload-file.php:
(main):
- public/v3/models/build-request.js:
(BuildRequest.constructBuildRequestsFromData): Resolve the rootFIle of each commit set item.
- public/v3/models/commit-set.js:
(CommitSet): Added _repositoryToRootMap and _allRootFiles as instance variables.
(CommitSet.prototype.updateSingleton): Added. Previously, each commit set's states never changed after
its creation. After this patch, each item can be newly associated with a root so we must update its
_repositoryToRootMap and _allRootFiles. For simplicity, we update all states.
(CommitSet.prototype._updateFromObject): Extracted from the constructor.
(CommitSet.prototype.allRootFiles): Added. Includes custom roots and roots created for patches.
(CommitSet.prototype.rootForRepository): Added.
(CommitSet.prototype.equals): Fixed the bug that we were comparing _repositoryToPatchMap to
_repositoryToCommitMap, and added a check for _repositoryToRootMap.
- public/v3/models/test-group.js:
(TestGroup.prototype.task): Added.
(TestGroup.createWithTask):
(TestGroup.createWithCustomConfiguration):
(TestGroup.createAndRefetchTestGroups):
(TestGroup._fetchTestGroupsForTask): Deleted. Now fetchForTask takes a boolean argument: ignoreCache.
(TestGroup.findAllByTask): Added.
(TestGroup.fetchForTask): Renamed from fetchByTask.
- public/v3/pages/analysis-task-page.js:
(AnalysisTaskPage.prototype._fetchRelatedInfoForTaskId):
- server-tests/api-build-requests-tests.js:
- server-tests/api-upload-root-tests.js: Added. Added tests for /api/upload-root.
(makeReport): Added.
(addSlaveAndCreateRootFile): Added.
(createTestGroupWihPatch): Added.
- server-tests/privileged-api-create-test-group-tests.js:
- server-tests/resources/mock-data.js:
(MockData.sharedRepositoryId): Added.
(MockData.addMockData): Added "Shared" repository along with commits.
- 7:26 PM Changeset in webkit [216646] by
-
- 1 edit1 add1 delete in trunk/Websites/perf.webkit.org
Rename server-tests/api-update-triggerable.js to server-tests/api-update-triggerable-tests.js
https://bugs.webkit.org/show_bug.cgi?id=171905
Reviewed by Chris Dumez.
- server-tests/api-update-triggerable-tests.js: Renamed from server-tests/api-update-triggerable.js.
- 6:51 PM Changeset in webkit [216645] by
-
- 2 edits in trunk/Source/WebCore
RELEASE_ASSERT at WebAudioSourceProviderAVFObjC::provideInput()
https://bugs.webkit.org/show_bug.cgi?id=171711
Reviewed by Youenn Fablet.
Before iterating over the channels in either the WebAudioBufferList or the AudioBus, ensure
we don't walk over the end of either by only iterating over the minimum length of either.
Also, when the internal format of WebAudioSourceProviderAVFObjC changes, notify the
MediaStreamAudioSourceNode that the number of channels and sample rate have changed.
- platform/mediastream/mac/WebAudioSourceProviderAVFObjC.mm:
(WebCore::WebAudioSourceProviderAVFObjC::provideInput):
(WebCore::WebAudioSourceProviderAVFObjC::prepare):
- 5:56 PM Changeset in webkit [216644] by
-
- 2 edits in trunk/LayoutTests
Marked fast/animation/request-animation-frame-time-unit.html as flaky.
https://bugs.webkit.org/show_bug.cgi?id=171957
Unreviewed test gardening.
- platform/ios-wk2/TestExpectations:
- 5:33 PM Changeset in webkit [216643] by
-
- 8 edits in trunk
REGRESSION (r167845): ASSERT(!m_renderView.needsLayout()) in svg/custom/bug79798.html
https://bugs.webkit.org/show_bug.cgi?id=132297
Reviewed by Simon Fraser.
Source/WebCore:
We don't know why m_renderView needs layout in this case, but we know that we don't need to
assert if the client hasn't set the ScrollableInnerFrameTrigger compositing trigger.
- rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::requiresCompositingForScrollableFrame):
LayoutTests:
- http/tests/navigation/keyboard-events-during-provisional-navigation-expected.txt:
- http/tests/navigation/keyboard-events-during-provisional-subframe-navigation-expected.txt:
- http/tests/navigation/resources/keyboard-events-test.js:
(runTest):
- platform/ios-wk2/TestExpectations:
- platform/wk2/TestExpectations:
- 5:32 PM Changeset in webkit [216642] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed, rolling out r216630.
This change caused assertion failures with webrtc LayoutTests.
Reverted changeset:
"RELEASE_ASSERT at
WebAudioSourceProviderAVFObjC::provideInput()"
https://bugs.webkit.org/show_bug.cgi?id=171711
http://trac.webkit.org/changeset/216630
- 5:29 PM Changeset in webkit [216641] by
-
- 63 edits11 deletes in trunk
Remove support for legacy Notifications
https://bugs.webkit.org/show_bug.cgi?id=171487
Reviewed by Jon Lee.
Source/JavaScriptCore:
- Configurations/FeatureDefines.xcconfig:
Remove definition of ENABLE_LEGACY_NOTIFICATIONS.
Source/WebCore:
- CMakeLists.txt:
- WebCore.xcodeproj/project.pbxproj:
Remove files.
- Configurations/FeatureDefines.xcconfig:
Remove definition of ENABLE_LEGACY_NOTIFICATIONS.
- DerivedSources.make:
Remove IDL files.
- Modules/notifications/DOMWindowNotifications.cpp: Removed.
- Modules/notifications/DOMWindowNotifications.h: Removed.
- Modules/notifications/DOMWindowNotifications.idl: Removed.
- Modules/notifications/NotificationCenter.cpp: Removed.
- Modules/notifications/NotificationCenter.h: Removed.
- Modules/notifications/NotificationCenter.idl: Removed.
- Modules/notifications/NotificationClient.h:
- Modules/notifications/NotificationController.cpp:
- Modules/notifications/NotificationController.h:
- Modules/notifications/WorkerGlobalScopeNotifications.cpp: Removed.
- Modules/notifications/WorkerGlobalScopeNotifications.h: Removed.
- Modules/notifications/WorkerGlobalScopeNotifications.idl: Removed.
- Modules/notifications/Notification.idl:
- Modules/notifications/Notification.cpp:
- Modules/notifications/Notification.h:
- dom/EventTargetFactory.in:
- page/DOMWindow.cpp:
- workers/WorkerThread.h:
Remove code legacy Notification code. Replace use of NotificationCenter with direct
calls to the NotificationClient.
Source/WebCore/PAL:
- Configurations/FeatureDefines.xcconfig:
Remove definition of ENABLE_LEGACY_NOTIFICATIONS.
Source/WebKit/mac:
- Configurations/FeatureDefines.xcconfig:
- WebCoreSupport/WebNotificationClient.h:
- WebCoreSupport/WebNotificationClient.mm:
- WebView/WebNotification.mm:
- WebView/WebNotificationInternal.h:
- WebView/WebView.mm:
(-[WebView _commonInitializationWithFrameName:groupName:]):
(-[WebView _notificationIDForTesting:]):
Remove legacy notification specific code.
Source/WebKit/win:
- WebCoreSupport/WebChromeClient.cpp:
(WebChromeClient::WebChromeClient):
- WebCoreSupport/WebChromeClient.h:
- WebCoreSupport/WebDesktopNotificationsDelegate.cpp:
- WebCoreSupport/WebDesktopNotificationsDelegate.h:
Remove legacy notification specific code.
Source/WebKit2:
- Configurations/FeatureDefines.xcconfig:
- Shared/WebProcessCreationParameters.cpp:
- Shared/WebProcessCreationParameters.h:
- UIProcess/WebProcessPool.cpp:
- WebProcess/InjectedBundle/InjectedBundle.cpp:
- WebProcess/Notifications/NotificationPermissionRequestManager.cpp:
- WebProcess/Notifications/NotificationPermissionRequestManager.h:
- WebProcess/Notifications/WebNotificationManager.cpp:
- WebProcess/Notifications/WebNotificationManager.h:
- WebProcess/WebCoreSupport/WebNotificationClient.cpp:
- WebProcess/WebCoreSupport/WebNotificationClient.h:
- WebProcess/WebPage/WebPage.cpp:
- WebProcess/WebProcess.cpp:
Remove legacy notification specific code.
Source/WTF:
- wtf/FeatureDefines.h:
Remove definition of ENABLE_LEGACY_NOTIFICATIONS.
Tools:
- DumpRenderTree/win/DRTDesktopNotificationPresenter.cpp:
(DRTDesktopNotificationPresenter::checkNotificationPermission):
- Scripts/webkitperl/FeatureList.pm:
- TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
Remove use and definition of ENABLE_LEGACY_NOTIFICATIONS.
LayoutTests:
- Remove fast/notifications/. It was skipped on all platforms and use legacy Notifications API.
- Remove http/notifications/legacy. It tested the legacy API.
- Update two tests in fast/history to use the non-legacy API to test page cache + notifications.
- Update TestExpectations for removals.
- TestExpectations:
- platform/gtk/TestExpectations:
- platform/ios/TestExpectations:
- platform/mac/TestExpectations:
- platform/win/TestExpectations:
- fast/history/page-cache-notification-non-suspendable.html:
- fast/history/page-cache-notification-suspendable.html:
- fast/notifications: Removed.
- fast/notifications/notification-after-close-expected.txt: Removed.
- fast/notifications/notification-after-close.html: Removed.
- fast/notifications/notification-permisssion-deletable-expected.txt: Removed.
- fast/notifications/notification-permisssion-deletable.html: Removed.
- fast/notifications/notifications-cancel-request-permission-expected.txt: Removed.
- fast/notifications/notifications-cancel-request-permission.html: Removed.
- fast/notifications/notifications-check-permission-expected.txt: Removed.
- fast/notifications/notifications-check-permission.html: Removed.
- fast/notifications/notifications-click-event-expected.txt: Removed.
- fast/notifications/notifications-click-event-focus-expected.txt: Removed.
- fast/notifications/notifications-click-event-focus.html: Removed.
- fast/notifications/notifications-click-event.html: Removed.
- fast/notifications/notifications-constructor-request-permission-expected.txt: Removed.
- fast/notifications/notifications-constructor-request-permission.html: Removed.
- fast/notifications/notifications-constructor-with-permission-expected.txt: Removed.
- fast/notifications/notifications-constructor-with-permission.html: Removed.
- fast/notifications/notifications-constructor-without-permission-expected.txt: Removed.
- fast/notifications/notifications-constructor-without-permission.html: Removed.
- fast/notifications/notifications-display-close-events-expected.txt: Removed.
- fast/notifications/notifications-display-close-events.html: Removed.
- fast/notifications/notifications-document-close-crash-expected.txt: Removed.
- fast/notifications/notifications-document-close-crash.html: Removed.
- fast/notifications/notifications-event-stop-propagation-expected.txt: Removed.
- fast/notifications/notifications-event-stop-propagation.html: Removed.
- fast/notifications/notifications-multi-events-expected.txt: Removed.
- fast/notifications/notifications-multi-events.html: Removed.
- fast/notifications/notifications-no-icon-expected.txt: Removed.
- fast/notifications/notifications-no-icon.html: Removed.
- fast/notifications/notifications-permission-expected.txt: Removed.
- fast/notifications/notifications-permission.html: Removed.
- fast/notifications/notifications-replace-expected.txt: Removed.
- fast/notifications/notifications-replace.html: Removed.
- fast/notifications/notifications-request-permission-expected.txt: Removed.
- fast/notifications/notifications-request-permission-optional-expected.txt: Removed.
- fast/notifications/notifications-request-permission-optional.html: Removed.
- fast/notifications/notifications-request-permission.html: Removed.
- fast/notifications/notifications-rtl-expected.txt: Removed.
- fast/notifications/notifications-rtl.html: Removed.
- fast/notifications/notifications-sandbox-permission-expected.txt: Removed.
- fast/notifications/notifications-sandbox-permission.html: Removed.
- fast/notifications/notifications-window-close-crash-expected.txt: Removed.
- fast/notifications/notifications-window-close-crash.html: Removed.
- fast/notifications/notifications-with-permission-expected.txt: Removed.
- fast/notifications/notifications-with-permission.html: Removed.
- fast/notifications/notifications-without-permission-expected.txt: Removed.
- fast/notifications/notifications-without-permission.html: Removed.
- fast/notifications/request-notification-permission-while-reloading-expected.txt: Removed.
- fast/notifications/request-notification-permission-while-reloading.html: Removed.
- fast/notifications/resources: Removed.
- fast/notifications/resources/notifications-cancel-request-permission.html: Removed.
- fast/notifications/resources/notifications-iframe.html: Removed.
- http/tests/notifications/legacy: Removed.
- http/tests/notifications/legacy/double-show-expected.txt: Removed.
- http/tests/notifications/legacy/double-show.html: Removed.
- http/tests/notifications/legacy/events-expected.txt: Removed.
- http/tests/notifications/legacy/events.html: Removed.
- http/tests/notifications/legacy/notification-request-permission-then-navigate-expected.txt: Removed.
- http/tests/notifications/legacy/notification-request-permission-then-navigate.html: Removed.
- http/tests/notifications/legacy/request-expected.txt: Removed.
- http/tests/notifications/legacy/request-no-callback-expected.txt: Removed.
- http/tests/notifications/legacy/request-no-callback.html: Removed.
- http/tests/notifications/legacy/request.html: Removed.
- http/tests/notifications/legacy/resources: Removed.
- http/tests/notifications/legacy/resources/notify-opener-done.html: Removed.
- http/tests/notifications/legacy/resources/request-permission-then-navigate.html: Removed.
- http/tests/notifications/legacy/show-expected.txt: Removed.
- http/tests/notifications/legacy/show.html: Removed.
- http/tests/notifications/legacy/window-show-on-click-expected.txt: Removed.
- http/tests/notifications/legacy/window-show-on-click.html: Removed.
- 5:25 PM Changeset in webkit [216640] by
-
- 2 edits in trunk/LayoutTests
Mark media/modern-media-controls/media-controller/media-controller-auto-hide-mouse-enter-and-mouse-leave.html as flaky.
https://bugs.webkit.org/show_bug.cgi?id=169876
Unreviewed test gardening.
- platform/mac/TestExpectations:
- 5:20 PM Changeset in webkit [216639] by
-
- 2 edits in trunk/LayoutTests
Mark inspector/protocol/inspector-backend-invocation-return-value.html as flaky.
https://bugs.webkit.org/show_bug.cgi?id=168146
Unreviewed test gardening.
- platform/mac/TestExpectations:
- 4:48 PM Changeset in webkit [216638] by
-
- 10 edits in trunk
Unreviewed, rolling out r216635.
https://bugs.webkit.org/show_bug.cgi?id=171953
"Some worker tests are failing". (Requested by mlam on #webkit).
Reverted changeset:
"WorkerThread::stop() should call
scheduleExecutionTermination() last."
https://bugs.webkit.org/show_bug.cgi?id=171775
http://trac.webkit.org/changeset/216635
Patch by Commit Queue <commit-queue@webkit.org> on 2017-05-10
- 4:43 PM Changeset in webkit [216637] by
-
- 2 edits in trunk/Source/JavaScriptCore
Crash in JavaScriptCore GC when using JSC on dispatch queues (thread_get_state returns NULL stack pointer).
https://bugs.webkit.org/show_bug.cgi?id=160337
<rdar://problem/27611733>
Not reviewed.
Updated a comment per Geoff's suggestion.
- heap/MachineStackMarker.cpp:
(JSC::MachineThreads::tryCopyOtherThreadStack):
- 4:39 PM Changeset in webkit [216636] by
-
- 8 edits in branches/safari-603-branch/Source
Cherry-pick r214320. rdar://problem/32057095
- 4:22 PM Changeset in webkit [216635] by
-
- 10 edits in trunk
WorkerThread::stop() should call scheduleExecutionTermination() last.
https://bugs.webkit.org/show_bug.cgi?id=171775
<rdar://problem/30975761>
Reviewed by Geoffrey Garen.
Source/JavaScriptCore:
Increased the number of frames captured in VM::nativeStackTraceOfLastThrow()
from 25 to 100. From experience, I found that 25 is sometimes not sufficient
for our debugging needs.
Also added VM::throwingThread() to track which thread an exception was thrown in.
This may be useful if the client is entering the VM from different threads.
- runtime/ExceptionScope.cpp:
(JSC::ExceptionScope::unexpectedExceptionMessage):
(JSC::ExceptionScope::releaseAssertIsTerminatedExecutionException):
- runtime/ExceptionScope.h:
(JSC::ExceptionScope::exception):
(JSC::ExceptionScope::unexpectedExceptionMessage):
- runtime/VM.cpp:
(JSC::VM::throwException):
- runtime/VM.h:
(JSC::VM::throwingThread):
(JSC::VM::clearException):
Source/WebCore:
Currently, WorkerThread::stop() calls scheduleExecutionTermination() to terminate
JS execution first, followed by posting a cleanup task to the worker, and lastly,
it invokes terminate() on the WorkerRunLoop.
As a result, before run loop is terminate, the worker thread may observe the
TerminatedExecutionException in JS code, bail out, see another JS task to run,
re-enters the VM to run said JS code, and fails with an assertion due to the
TerminatedExecutionException still being pending on VM entry.
WorkerRunLoop::Task::performTask() already has a check to only allow a task to
run if and only if !runLoop.terminated() and the task is not a clean up task.
We'll fix the above race by ensuring that having WorkerThread::stop() terminate
the run loop before it scheduleExecutionTermination() which throws the
TerminatedExecutionException. This way, by the time JS code unwinds out of the
VM due to the TerminatedExecutionException, runLoop.terminated() is guaranteed
to be true and thereby prevents re-entry into the VM.
This issue is covered by an existing test that I just unskipped in TestExpectations.
- bindings/js/JSDOMPromiseDeferred.cpp:
(WebCore::DeferredPromise::callFunction):
- workers/WorkerThread.cpp:
(WebCore::WorkerThread::stop):
LayoutTests:
- 4:05 PM Changeset in webkit [216634] by
-
- 12 edits in trunk
Add an experimental feature flag for viewport-fit
https://bugs.webkit.org/show_bug.cgi?id=171948
<rdar://problem/31995518>
Reviewed by Simon Fraser.
- Shared/WebPreferencesDefinitions.h:
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::updatePreferences):
Add an experimental feature flag.
- dom/ViewportArguments.cpp:
(WebCore::setViewportFeature):
- page/Settings.in:
Disable parsing of viewport-fit if the experimental feature is disabled.
- fast/css/variables/constants/ios/safe-area-inset-set-expected.html:
- fast/css/variables/constants/ios/safe-area-inset-set.html:
- fast/viewport/ios/viewport-fit-auto.html:
- fast/viewport/ios/viewport-fit-contain.html:
- fast/viewport/ios/viewport-fit-cover.html:
- 3:57 PM Changeset in webkit [216633] by
-
- 2 edits in trunk/LayoutTests
Marked fast/hidpi/filters-and-image-buffer-resolution.html as flaky.
https://bugs.webkit.org/show_bug.cgi?id=171951
Unreviewed test gardening.
- platform/ios-wk2/TestExpectations:
- 3:25 PM Changeset in webkit [216632] by
-
- 19 edits in trunk/Source
Simplify relationship between Attr and Element now that Attr is childless
https://bugs.webkit.org/show_bug.cgi?id=171909
Reviewed by Ryosuke Niwa.
Source/WebCore:
Simplify relationship between Attr and Element now that Attr is childless
after r216259.
No new tests, no Web facing behavior change.
- dom/Attr.cpp:
(WebCore::Attr::setValue):
Attr::setValue() was only called by Element::setAttributeInternal() to make sure
we updated the Attr node's Text child. However, now that Attr has no Text child,
Element no longer needs to update the Attr node's value.
Attr::setValueForBindings() was thus renamed to setValue(). Its implementation
was also simplified by calling Element::setAttribute() on its ownerElement, if
it has one, instead of duplicating a bunch of code from Element::setAttributeInternal().
(WebCore::Attr::setNodeValue):
Call setValue() instead of setValueForBindings() now that it has been renamed.
- dom/Attr.h:
- dom/Attr.idl:
Rename valueForBindings / setValueForBindings to value / setValue.
- dom/Document.h:
Split shouldInvalidateNodeListAndCollectionCaches() into 2 methods, one taking an Attr name
and another that does not. There are now 2 calls sites instead of one, so we no longer need
to branch in this function.
- dom/Element.cpp:
(WebCore::Element::setAttributeInternal):
Drop code calling Attr::setValue() on the Attr node since Attr::setValue() was only
duplicating logic from Element::setAttributeInternal() after r216259. There is nothing
on Attr that needs updating when an element attribute gets updated.
(WebCore::Element::attributeChanged):
Call the new invalidateNodeListAndCollectionCachesInAncestorsForAttribute(). This
is the only call site that passes an attribute name.
- dom/Node.cpp:
(WebCore::Document::shouldInvalidateNodeListAndCollectionCaches):
(WebCore::Document::shouldInvalidateNodeListAndCollectionCachesForAttribute):
Split into 2 to avoid branching, as explained above.
(WebCore::Node::invalidateNodeListAndCollectionCachesInAncestors):
(WebCore::Node::invalidateNodeListAndCollectionCachesInAncestorsForAttribute):
- invalidateNodeListAndCollectionCachesInAncestors() used to invalidate childNodeLists if the Node was an attribute node. Drop this as this is no longer needed as of r216259.
- After the change to Attr::setValue(), call sites for invalidateNodeListAndCollectionCachesInAncestors() either had no parameters, or both parameters present and non-null. There is therefore no longer any need to handle having an attrName but no attributeOwnerElement. To make this obvious, I split this into 2 methods: invalidateNodeListAndCollectionCachesInAncestors() and invalidateNodeListAndCollectionCachesInAncestorsForAttribute(attrName). We no longer need the attributeOwnerElement parameter as it was only used to exit early.
- dom/Node.h:
Source/WebKit/mac:
Build fix.
- DOM/DOMAttr.mm:
(-[DOMAttr value]):
(-[DOMAttr setValue:]):
- 3:23 PM Changeset in webkit [216631] by
-
- 6 edits2 adds in trunk
REGRESSION (r207372) Visibility property is not inherited when used in an animation
https://bugs.webkit.org/show_bug.cgi?id=171883
<rdar://problem/32086550>
Reviewed by Simon Fraser.
Source/WebCore:
The problem here is that our animation code is tied to renderers. We don't have renderers during
the initial style resolution so animations are not applied yet. When constructing renderers we set
their style to the initial animated style but this step can't implement inheritance.
Normally this is invisible as the first animation frame will immediately inherit the style correctly.
However in this case the animation is discrete and the first frame is the same as the initial state.
With r207372 we optimize the descendant style change away.
This patch fixes the problem by tracking that the renderer has initial animated style and inheriting
it to descendants during next style resolution even if it doesn't change.
Test: animations/animation-initial-inheritance.html
- rendering/RenderElement.cpp:
(WebCore::RenderElement::RenderElement):
- rendering/RenderElement.h:
(WebCore::RenderElement::hasInitialAnimatedStyle):
(WebCore::RenderElement::setHasInitialAnimatedStyle):
- style/RenderTreeUpdater.cpp:
(WebCore::RenderTreeUpdater::createRenderer):
Set a bit on renderer indicating it has initial animated style.
- style/StyleTreeResolver.cpp:
(WebCore::Style::TreeResolver::createAnimatedElementUpdate):
Return at least 'Inherit' for style change when updating renderer with initial animated style.
LayoutTests:
- animations/animation-initial-inheritance-expected.html: Added.
- animations/animation-initial-inheritance.html: Added.
- 3:03 PM Changeset in webkit [216630] by
-
- 2 edits in trunk/Source/WebCore
RELEASE_ASSERT at WebAudioSourceProviderAVFObjC::provideInput()
https://bugs.webkit.org/show_bug.cgi?id=171711
Reviewed by Youenn Fablet.
Before iterating over the channels in either the WebAudioBufferList or the AudioBus, ensure
we don't walk over the end of either by only iterating over the minimum length of either.
Also, when the internal format of WebAudioSourceProviderAVFObjC changes, notify the
MediaStreamAudioSourceNode that the number of channels and sample rate have changed.
- platform/mediastream/mac/WebAudioSourceProviderAVFObjC.mm:
(WebCore::WebAudioSourceProviderAVFObjC::provideInput):
(WebCore::WebAudioSourceProviderAVFObjC::prepare):
- 3:01 PM Changeset in webkit [216629] by
-
- 3 edits in trunk/Source/WebInspectorUI
Web Inspector: RTL: in Timelines > JavaScript & Events, digits for timer and animation frame number are not localized
https://bugs.webkit.org/show_bug.cgi?id=171818
Reviewed by Joseph Pecoraro.
These numbers need to be formatted with %d, not %s.
- Localizations/en.lproj/localizedStrings.js:
- UserInterface/Models/ScriptTimelineRecord.js:
(WebInspector.ScriptTimelineRecord.EventType.displayName):
- 2:59 PM Changeset in webkit [216628] by
-
- 10 edits in trunk/Source/WebInspectorUI
Web Inspector: remove dead code for switching Toolbar display options
https://bugs.webkit.org/show_bug.cgi?id=170738
Reviewed by Joseph Pecoraro.
- Localizations/en.lproj/localizedStrings.js:
- UserInterface/Base/Main.js:
(WebInspector.contentLoaded):
- UserInterface/Views/ButtonToolbarItem.css:
(.toolbar .item.button > .glyph):
(.toolbar .item.button > .label):
(.toolbar.icon-and-label-vertical .item.button): Deleted.
(.toolbar.icon-and-label-horizontal .item.button): Deleted.
(.toolbar.small-size .item.button > .glyph): Deleted.
(.toolbar.label-only .item.button > .glyph): Deleted.
(.toolbar.label-only .item.activate.button.activated > .label): Deleted.
(.toolbar.icon-and-label-horizontal .item.button > .label): Deleted.
(.toolbar.icon-only .item.button > .label): Deleted.
- UserInterface/Views/ControlToolbarItem.css:
(.toolbar .item.control):
(.toolbar:matches(.icon-and-label-horizontal, .icon-only) .item.control): Deleted.
- UserInterface/Views/DashboardContainerView.css:
(.toolbar .dashboard-container):
(.toolbar.icon-and-label-vertical:matches(.small-size, .normal-size) .dashboard-container): Deleted.
(.toolbar.label-only .dashboard-container,): Deleted.
(.toolbar.normal-size:matches(.icon-only, .icon-and-label-vertical, .icon-and-label-horizontal) .dashboard-container): Deleted.
(.toolbar.label-only .dashboard-container .advance-arrow): Deleted.
(body[dir=ltr] .toolbar.label-only .dashboard-container .advance-arrow): Deleted.
(body[dir=rtl] .toolbar.label-only .dashboard-container .advance-arrow): Deleted.
- UserInterface/Views/DefaultDashboardView.css:
(.toolbar .dashboard.default > .item):
(.toolbar.label-only .dashboard.default > .item,): Deleted.
(.toolbar.normal-size:matches(.icon-only, .icon-and-label-vertical, .icon-and-label-horizontal) .dashboard.default > .item): Deleted.
- UserInterface/Views/ReplayDashboardView.css:
(.toolbar .dashboard.replay .item.button > .glyph):
(.toolbar.label-only .dashboard.replay .item.button > .glyph): Deleted.
- UserInterface/Views/Toolbar.css:
(.toolbar .control-section):
(.toolbar:matches(.icon-and-label-horizontal.small-size, .icon-only.small-size, .label-only) .control-section): Deleted.
- UserInterface/Views/Toolbar.js:
(WebInspector.Toolbar):
(WebInspector.Toolbar.prototype.layout):
(WebInspector.Toolbar.prototype.get displayMode): Deleted.
(WebInspector.Toolbar.prototype.set displayMode): Deleted.
(WebInspector.Toolbar.prototype.get sizeMode): Deleted.
(WebInspector.Toolbar.prototype.set sizeMode): Deleted.
(WebInspector.Toolbar.prototype._handleContextMenuEvent): Deleted.
(WebInspector.Toolbar.prototype._changeDisplayMode): Deleted.
(WebInspector.Toolbar.prototype._toggleSmallIcons): Deleted.
- 2:59 PM Changeset in webkit [216627] by
-
- 1 edit in branches/safari-603-branch/Source/WebCore/ChangeLog
Fix order of merge from r212528. rdar://problem/31153819
- 2:59 PM Changeset in webkit [216626] by
-
- 2 edits in branches/safari-603-branch/Source/WebCore
Fix order of merge from r212528
- 2:57 PM Changeset in webkit [216625] by
-
- 2 edits in trunk/Source/WebCore
GCController.cpp's collect() should be Async
https://bugs.webkit.org/show_bug.cgi?id=171708
Reviewed by Saam Barati and Geoffrey Garen.
No new tests because no change in behavior.
This is one step towards not requesting sync GCs in WebCore. I'm landing this incrementally to
make bisecting super easy.
This is a ~7% JetStream iOS "regression", because JetStream has a bug where it allows trunk
to sneakily hide GC work between when JetStream measures time. After this change, we are no
longer trying to be sneaky.
- bindings/js/GCController.cpp:
(WebCore::collect):
- 2:34 PM Changeset in webkit [216624] by
-
- 2 edits in trunk/LayoutTests
Marked transitions/extra-transition.html as flaky.
https://bugs.webkit.org/show_bug.cgi?id=171947
Unreviewed test gardening.
- platform/mac-wk2/TestExpectations:
- 2:31 PM Changeset in webkit [216623] by
-
- 2 edits in trunk/Source/WebCore
CoreAudioCaptureSource reports 3 or 5 channel audio output; actually only mono
https://bugs.webkit.org/show_bug.cgi?id=171940
Reviewed by Eric Carlson.
Asking for the Input VPIO stream format will return the internal mic format, before processing. Instead
ask for the input bus's output format, which is post processing, which will return the correct number
of channels (one).
- platform/mediastream/mac/CoreAudioCaptureSource.cpp:
(WebCore::CoreAudioSharedUnit::configureMicrophoneProc):
- 2:23 PM Changeset in webkit [216622] by
-
- 23 edits in branches/safari-603-branch/Source
Additional ENABLE_STREAMS cleanup
- 2:23 PM Changeset in webkit [216621] by
-
- 46 edits in branches/safari-603-branch
Cherry-pick r215429. rdar://problem/32057106
- 2:23 PM Changeset in webkit [216620] by
-
- 10 edits in branches/safari-603-branch
Cherry-pick r215250. rdar://problem/32057106
- 2:14 PM Changeset in webkit [216619] by
-
- 6 edits2 deletes in trunk
Unreviewed, rolling out r216591.
This change broke an internal build.
Reverted changeset:
"REGRESSION (r207372) Visibility property is not inherited
when used in an animation"
https://bugs.webkit.org/show_bug.cgi?id=171883
http://trac.webkit.org/changeset/216591
- 2:11 PM Changeset in webkit [216618] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, remove TestExpectation for a test that was removed in r216259.
- platform/mac/TestExpectations:
- 2:02 PM Changeset in webkit [216617] by
-
- 2 edits in trunk/LayoutTests
Marked perf/class-list-remove.html as flaky.
https://bugs.webkit.org/show_bug.cgi?id=171945
Unreviewed test gardening.
- platform/ios-wk2/TestExpectations:
- 1:52 PM Changeset in webkit [216616] by
-
- 2 edits in trunk/Source/WebKit2
Include headers in WebKit.h
https://bugs.webkit.org/show_bug.cgi?id=171943
Reviewed by Dan Bernstein.
- Shared/API/Cocoa/WebKit.h:
- 1:50 PM Changeset in webkit [216615] by
-
- 6 edits in trunk/Source/WebCore
Drop custom bindings code now window.open()
https://bugs.webkit.org/show_bug.cgi?id=171933
Reviewed by Geoffrey Garen.
Drop custom bindings code now window.open() as it is not doing anything special.
- bindings/js/JSDOMWindowCustom.cpp:
(WebCore::JSDOMWindow::open): Deleted.
- page/DOMWindow.cpp:
(WebCore::DOMWindow::open):
- page/DOMWindow.h:
- page/DOMWindow.idl:
- testing/Internals.cpp:
(WebCore::Internals::openDummyInspectorFrontend):
- 1:44 PM Changeset in webkit [216614] by
-
- 3 edits in trunk/LayoutTests
r216599 accidentally included two copies of the new layout test and expected result
https://bugs.webkit.org/show_bug.cgi?id=171938
Unreviewed.
- http/tests/navigation/keyboard-events-during-provisional-subframe-navigation-expected.txt:
- http/tests/navigation/keyboard-events-during-provisional-subframe-navigation.html:
- 1:41 PM Changeset in webkit [216613] by
-
- 2 edits in trunk/LayoutTests
Skip http/tests/navigation/keyboard-events-during-provisional-subframe-navigation.html on ios-simulator.
https://bugs.webkit.org/show_bug.cgi?id=171880
Unreviewed test gardening.
This test times out on ios-simulator because it relies on eventSender.keyDown.
- platform/ios/TestExpectations:
- 1:29 PM Changeset in webkit [216612] by
-
- 16 edits in trunk/Source/WebKit2
Disable block selection for dynamic selection granularity
https://bugs.webkit.org/show_bug.cgi?id=171908
<rdar://problem/32098024>
Reviewed by Enrica Casucci.
- UIProcess/API/Cocoa/WKWebViewConfiguration.mm:
(-[WKWebViewConfiguration init]):
(-[WKWebViewConfiguration copyWithZone:]):
(-[WKWebViewConfiguration _allowsBlockSelection]):
(-[WKWebViewConfiguration _setAllowsBlockSelection:]):
- UIProcess/API/Cocoa/WKWebViewConfigurationPrivate.h:
Add a private configuration parameter to re-enable block selection.
- Shared/WebPageCreationParameters.cpp:
(WebKit::WebPageCreationParameters::encode):
(WebKit::WebPageCreationParameters::decode):
- Shared/WebPageCreationParameters.h:
- UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _allowsBlockSelection]):
- UIProcess/API/Cocoa/WKWebViewInternal.h:
- UIProcess/Cocoa/VersionChecks.h:
- UIProcess/PageClient.h:
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::creationParameters):
- UIProcess/ios/PageClientImplIOS.h:
- UIProcess/ios/PageClientImplIOS.mm:
(WebKit::PageClientImpl::allowsBlockSelection):
- WebProcess/WebPage/WebPage.cpp:
- WebProcess/WebPage/WebPage.h:
Plumb allowsBlockSelection through from WKWebViewConfiguration to WebPage.
- UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView setupInteraction]):
(-[WKContentView useSelectionAssistantWithGranularity:]):
(-[WKContentView _startAssistingKeyboard]):
(-[WKContentView _stopAssistingKeyboard]):
(toUIWebSelectionMode): Deleted.
(-[WKContentView useSelectionAssistantWithMode:]): Deleted.
Stop needlessly converting to UIWebSelectionMode.
- WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::shouldSwitchToBlockModeForHandle):
Don't switch to block selection unless allowsBlockSelection is set.
- 1:26 PM Changeset in webkit [216611] by
-
- 16 edits in trunk
Add an experimental feature flag for constant properties
https://bugs.webkit.org/show_bug.cgi?id=171913
<rdar://problem/31995518>
Reviewed by Ryosuke Niwa.
- css/parser/CSSParser.cpp:
(WebCore::CSSParserContext::CSSParserContext):
(WebCore::operator==):
- css/parser/CSSParserImpl.cpp:
(WebCore::CSSParserImpl::consumeCustomPropertyValue):
- css/parser/CSSParserMode.h:
- css/parser/CSSPropertyParser.cpp:
(WebCore::CSSPropertyParser::parseValueStart):
- css/parser/CSSVariableParser.cpp:
(WebCore::classifyBlock):
(WebCore::isValidVariableReference):
(WebCore::isValidConstantReference):
(WebCore::classifyVariableRange):
(WebCore::CSSVariableParser::containsValidVariableReferences):
(WebCore::CSSVariableParser::parseDeclarationValue):
- css/parser/CSSVariableParser.h:
Plumb the experimental feature flag down into CSSVariableParser by way
of CSSParserContext.
- page/Settings.in:
- Shared/WebPreferencesDefinitions.h:
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::updatePreferences):
Add an experimental feature flag.
- fast/css/variables/constants/invalid-constant-name-fallback.html:
- fast/css/variables/constants/ios/safe-area-inset-set.html:
- fast/css/variables/constants/safe-area-inset-cannot-override.html:
- fast/css/variables/constants/safe-area-inset-zero.html:
- 1:16 PM Changeset in webkit [216610] by
-
- 2 edits in trunk/Source/WebKit2
Disable WebGL2 by default
https://bugs.webkit.org/show_bug.cgi?id=171894
<rdar://problem/32089917>
Reviewed by Tim Horton.
Some WASM and WebGL2 content is failing because it
detects our WebGL2RenderingContext, but doesn't realise
that we don't implement enough of it to be useful.
- Shared/WebPreferencesDefinitions.h:
- 1:07 PM Changeset in webkit [216609] by
-
- 2 edits in trunk/LayoutTests
Marked media/track/track-cue-rendering-on-resize.html as flaky.
https://bugs.webkit.org/show_bug.cgi?id=171939
Unreviewed test gardening.
- platform/mac-wk2/TestExpectations:
- 1:07 PM Changeset in webkit [216608] by
-
- 2 edits in trunk/Source/JavaScriptCore
Crash in JavaScriptCore GC when using JSC on dispatch queues (thread_get_state returns NULL stack pointer).
https://bugs.webkit.org/show_bug.cgi?id=160337
<rdar://problem/27611733>
Reviewed by Filip Pizlo and Geoffrey Garen.
This is a workaround for <rdar://problem/27607384>. During thread initialization,
for some target platforms, thread state is momentarily set to 0 before being
filled in with the target thread's real register values. As a result, there's
a race condition that may result in us getting a null stackPointer during a GC scan.
This issue may manifest with workqueue threads where the OS may choose to recycle
a thread for an expired task.
The workaround is simply to indicate that there's nothing to copy and return.
This is correct because we will only ever observe a null pointer during thread
initialization. Hence, by definition, there's nothing there that we need to scan
yet, and therefore, nothing that needs to be copied.
- heap/MachineStackMarker.cpp:
(JSC::MachineThreads::tryCopyOtherThreadStack):
- 12:52 PM Changeset in webkit [216607] by
-
- 2 edits in trunk/Source/WebCore
REGRESSION (r206960): Possible null pointer dereference under DOMSelection::getRangeAt()
https://bugs.webkit.org/show_bug.cgi?id=171925
<rdar://problem/29931223>
Reviewed by Wenson Hsieh.
We have evidence that selection().firstRange() can return null in DOMSelection::getRangeAt().
When this happens, we now throw an INDEX_SIZE_ERR instead of dereferencing it.
I believe this can happen if the VisibleSelection is orphaned but not none, because
rangeCount() only checks for isNone() but VisibleSelection::firstRange() can return null
if isNoneOrOrphaned().
No new tests, I do not know how to reproduce.
- page/DOMSelection.cpp:
(WebCore::DOMSelection::getRangeAt):
- 12:41 PM Changeset in webkit [216606] by
-
- 2 edits in trunk/LayoutTests
Mark imported/w3c/web-platform-tests/dom/nodes/ParentNode-querySelector-All tests as flaky.
https://bugs.webkit.org/show_bug.cgi?id=171937
Unreviewed test gardening.
- platform/mac-wk1/TestExpectations:
- 12:34 PM Changeset in webkit [216605] by
-
- 2 edits in branches/safari-603-branch/LayoutTests
Unreviewed test gardening.
- platform/ios-simulator/TestExpectations:
- 12:29 PM Changeset in webkit [216604] by
-
- 2 edits in trunk/LayoutTests
Marked tiled-drawing/scrolling/fast-scroll-select-latched-mainframe.html as flaky.
https://bugs.webkit.org/show_bug.cgi?id=171935
Unreviewed test gardening.
- platform/mac-wk2/TestExpectations:
- 12:24 PM Changeset in webkit [216603] by
-
- 2 edits in trunk/Source/WebCore
DumpRenderTree crashed in com.apple.WebCore: std::optional<WTF::MediaTime>::operator-> + 71 :: CRASHING TEST: fullscreen/video-controls-timeline.html
https://bugs.webkit.org/show_bug.cgi?id=171932
Reviewed by Eric Carlson.
Explicitly initialize m_playbackWithoutUserGesture to "None".
- html/HTMLMediaElement.h:
- 11:53 AM Changeset in webkit [216602] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: Copy to clipboard fails via InspectorFrontendHostStub
https://bugs.webkit.org/show_bug.cgi?id=171907
Patch by Ross Kirsling <Ross Kirsling> on 2017-05-10
Reviewed by Joseph Pecoraro.
- UserInterface/Base/InspectorFrontendHostStub.js:
(WebInspector.InspectorFrontendHostStub.prototype.copyText):
Actually make a text selection before attempting to copy to clipboard.
- 11:43 AM Changeset in webkit [216601] by
-
- 11 edits7 adds in branches/safari-603-branch
Cherry-pick r216352. rdar://problem/32057098
- 11:43 AM Changeset in webkit [216600] by
-
- 16 edits6 adds in branches/safari-603-branch
Cherry-pick r211379. rdar://problem/32057099
- 11:30 AM Changeset in webkit [216599] by
-
- 8 edits2 adds in trunk
Keyboard input suppression should extend to subframes
https://bugs.webkit.org/show_bug.cgi?id=171880
<rdar://problem/31201793>
Reviewed by Ryosuke Niwa.
Source/WebCore:
Test: http/tests/navigation/keyboard-events-during-provisional-subframe-navigation.html
- dom/EventDispatcher.cpp:
(WebCore::shouldSuppressEventDispatchInDOM): Changed to call shouldSuppressKeyboardInput()
on the main frame's loader.
- editing/Editor.cpp:
(WebCore::Editor::shouldInsertText): Ditto.
LayoutTests:
- http/tests/navigation/keyboard-events-during-provisional-navigation-expected.txt:
- http/tests/navigation/keyboard-events-during-provisional-navigation.html:
- http/tests/navigation/keyboard-events-during-provisional-subframe-navigation-expected.txt: Copied from LayoutTests/http/tests/navigation/keyboard-events-during-provisional-navigation-expected.txt.
- http/tests/navigation/keyboard-events-during-provisional-subframe-navigation.html: Copied from LayoutTests/http/tests/navigation/keyboard-events-during-provisional-navigation.html.
- http/tests/navigation/resources/keyboard-events-after-navigation.html:
- http/tests/navigation/resources/keyboard-events-test.js:
(runTest):
(waitForProvisionalNavigation.xhr.onreadystatechange):
(waitForProvisionalNavigation):
- 11:22 AM Changeset in webkit [216598] by
-
- 3 edits1 add in trunk/JSTests
WebAssemby: builder doesn't do Memory section maximum correctly
https://bugs.webkit.org/show_bug.cgi?id=171931
Reviewed by Keith Miller.
- wasm/Builder.js:
(export.default.Builder.prototype._registerSectionBuilders.const.section.in.WASM.description.section.switch.section.case.string_appeared_here.this.section):
- wasm/Builder_WebAssemblyBinary.js:
(const.emitters.Memory):
- wasm/function-tests/memory-grow-invalid.js: Added.
- 11:15 AM Changeset in webkit [216597] by
-
- 19 edits4 copies3 adds in trunk
WebAssembly: support name section
JSTests:
https://bugs.webkit.org/show_bug.cgi?id=171263
Reviewed by Keith Miller.
- wasm/function-tests/nameSection.js: Added.
(const.compile):
- wasm/function-tests/nameSection.wasm: Added.
- wasm/function-tests/stack-trace.js: Update format
Source/JavaScriptCore:
https://bugs.webkit.org/show_bug.cgi?id=171263
Reviewed by Keith Miller.
The name section is an optional custom section in the WebAssembly
spec. At least when debugging, developers expect to be able to use
this section to obtain intelligible stack traces, otherwise we
just number the wasm functions which is somewhat painful.
This patch parses this section, dropping its content eagerly on
error, and if there is a name section then backtraces use their
value instead of numbers. Otherwise we stick to numbers as before.
Note that the format of name sections changed in mid-February:
And binaryen was only updated in early March:
- CMakeLists.txt:
- JavaScriptCore.xcodeproj/project.pbxproj:
- interpreter/Interpreter.cpp:
(JSC::GetStackTraceFunctor::operator()):
- interpreter/StackVisitor.cpp:
(JSC::StackVisitor::readNonInlinedFrame):
(JSC::StackVisitor::Frame::functionName):
- interpreter/StackVisitor.h:
(JSC::StackVisitor::Frame::wasmFunctionIndexOrName):
- runtime/StackFrame.cpp:
(JSC::StackFrame::functionName):
- runtime/StackFrame.h:
(JSC::StackFrame::StackFrame):
(JSC::StackFrame::wasm):
- wasm/WasmBBQPlanInlines.h:
(JSC::Wasm::BBQPlan::initializeCallees):
- wasm/WasmCallee.cpp:
(JSC::Wasm::Callee::Callee):
- wasm/WasmCallee.h:
(JSC::Wasm::Callee::create):
(JSC::Wasm::Callee::indexOrName):
- wasm/WasmFormat.cpp:
(JSC::Wasm::makeString):
- wasm/WasmFormat.h:
(JSC::Wasm::isValidExternalKind):
(JSC::Wasm::isValidNameType):
(JSC::Wasm::NameSection::get):
- wasm/WasmIndexOrName.cpp: Copied from Source/JavaScriptCore/wasm/WasmCallee.cpp.
(JSC::Wasm::IndexOrName::IndexOrName):
(JSC::Wasm::makeString):
- wasm/WasmIndexOrName.h: Copied from Source/JavaScriptCore/wasm/WasmFormat.cpp.
- wasm/WasmModuleInformation.h:
- wasm/WasmModuleParser.cpp:
- wasm/WasmName.h: Copied from Source/JavaScriptCore/wasm/WasmCallee.cpp.
- wasm/WasmNameSectionParser.cpp: Added.
- wasm/WasmNameSectionParser.h: Copied from Source/JavaScriptCore/wasm/WasmCallee.cpp.
(JSC::Wasm::NameSectionParser::NameSectionParser):
- wasm/WasmOMGPlan.cpp:
(JSC::Wasm::OMGPlan::work):
- wasm/WasmParser.h:
(JSC::Wasm::Parser<SuccessType>::consumeUTF8String):
- 10:30 AM Changeset in webkit [216596] by
-
- 26 edits2 deletes in trunk
Unreviewed, rolling out r216563.
Revision caused 2 api failures
Reverted changeset:
"[MediaStream] deviceId constraint doesn't work with
getUserMedia"
https://bugs.webkit.org/show_bug.cgi?id=171877
http://trac.webkit.org/changeset/216563
- 10:29 AM Changeset in webkit [216595] by
-
- 3 edits in branches/safari-603-branch/Source/WebCore
Cherry-pick r215102. rdar://problem/32057110
- 10:16 AM Changeset in webkit [216594] by
-
- 3 edits in trunk/LayoutTests
Marked imported/w3c/web-platform-tests/webrtc/RTCPeerConnection-idl.html as flaky.
https://bugs.webkit.org/show_bug.cgi?id=171930
Unreviewed test gardening.
- platform/ios-wk2/TestExpectations:
- platform/mac-wk2/TestExpectations:
- 10:00 AM Changeset in webkit [216593] by
-
- 3 edits3 adds in trunk
Null pointer dereference in WTF::RefPtr<WTF::StringImpl>::operator!() under slow_path_get_direct_pname
https://bugs.webkit.org/show_bug.cgi?id=171801
Reviewed by Michael Saboff.
JSTests:
These tests used to crash. The prefix and postfix tests cover different paths, except
postfix-ignored goes down the same path as prefix due to an optimization.
- stress/for-in-postfix-ignored-index.js: Added.
(foo):
- stress/for-in-postfix-index.js: Added.
(foo):
- stress/for-in-prefix-index.js: Added.
(foo):
Source/JavaScriptCore:
This was a goofy oversight. The for-in optimization relies on the bytecode generator
to detect when the loop's index variable gets mutated. We forgot to have the hooks for
detecting this in prefix and postfix operations (++i and i++).
- bytecompiler/NodesCodegen.cpp:
(JSC::PostfixNode::emitResolve):
(JSC::PrefixNode::emitResolve):
- 9:57 AM Changeset in webkit [216592] by
-
- 5 edits in trunk/Source/WebCore
Refactor ScrollingCoordinator::setSynchronousScrollingReasons to accept a FrameView
https://bugs.webkit.org/show_bug.cgi?id=171923
Patch by Frederic Wang <fwang@igalia.com> on 2017-05-10
Reviewed by Simon Fraser.
Currently ScrollingCoordinator::setSynchronousScrollingReasons implementations assumes
SynchronousScrollingReasons apply to the main frame. This commit allows to specify
a FrameView in order to prepare support for fast scrolling of frames.
No new tests, no behavior changes.
- page/scrolling/AsyncScrollingCoordinator.cpp:
(WebCore::AsyncScrollingCoordinator::setSynchronousScrollingReasons): Use the FrameView to
find the state node.
(WebCore::AsyncScrollingCoordinator::updateScrollLayerPosition): Rename this function
updateMainFrameScrollLayerPosition and use the specified FrameView.
- page/scrolling/AsyncScrollingCoordinator.h: Add FrameView parameter.
- page/scrolling/ScrollingCoordinator.cpp:
(WebCore::ScrollingCoordinator::updateSynchronousScrollingReasons): Remove the const since
AsyncScrollingCoordinator uses scrollLayerForFrameView. Pass the frameView to
setSynchronousScrollingReasons.
- page/scrolling/ScrollingCoordinator.h:
(WebCore::ScrollingCoordinator::setSynchronousScrollingReasons): Add FrameView parameter.
- 9:50 AM Changeset in webkit [216591] by
-
- 6 edits2 adds in trunk
REGRESSION (r207372) Visibility property is not inherited when used in an animation
https://bugs.webkit.org/show_bug.cgi?id=171883
<rdar://problem/32086550>
Reviewed by Simon Fraser.
Source/WebCore:
The problem here is that our animation code is tied to renderers. We don't have renderers during
the initial style resolution so animations are not applied yet. When constructing renderers we set
their style to the initial animated style but this step can't implement inheritance.
Normally this is invisible as the first animation frame will immediately inherit the style correctly.
However in this case the animation is discrete and the first frame is the same as the initial state.
With r207372 we optimize the descendant style change away.
This patch fixes the problem by tracking that the renderer has initial animated style and inheriting
it to descendants during next style resolution even if it doesn't change.
Test: animations/animation-initial-inheritance.html
- rendering/RenderElement.cpp:
(WebCore::RenderElement::RenderElement):
- rendering/RenderElement.h:
(WebCore::RenderElement::hasInitialAnimatedStyle):
(WebCore::RenderElement::setHasInitialAnimatedStyle):
- style/RenderTreeUpdater.cpp:
(WebCore::RenderTreeUpdater::createRenderer):
Set a bit on renderer indicating it has initial animated style.
- style/StyleTreeResolver.cpp:
(WebCore::Style::TreeResolver::createAnimatedElementUpdate):
Return at least 'Inherit' for style change when updating renderer with initial animated style.
LayoutTests:
- animations/animation-initial-inheritance-expected.html: Added.
- animations/animation-initial-inheritance.html: Added.
- 9:44 AM Changeset in webkit [216590] by
-
- 2 edits in branches/safari-603-branch/Source/WebCore
Remove inadvertant change to ScrollView.h that was included in r216589.
Unreviewed build fix.
- platform/ScrollView.h:
(WebCore::ScrollView::children):
- 9:34 AM Changeset in webkit [216589] by
-
- 14 edits3 adds in branches/safari-603-branch
Cherry-pick r216279. rdar://problem/31967829
- 9:29 AM Changeset in webkit [216588] by
-
- 3 edits in trunk/LayoutTests
LayoutTest http/tests/media/track-in-band-hls-metadata-crash.html is a flaky timeout
https://bugs.webkit.org/show_bug.cgi?id=167749
Reviewed by Eric Carlson.
This is a speculative fix of the test. I have not been able to reproduce the timeout.
When the test times out, the 'addtrack' event is never received. In case the event
was dispatched before we added the event listener, the event listener is added before
the video source is set. In case the test will continue to time out, a couple of
error event callbacks have been added to get more information. Also, video playback
will begin when the 'canplaythrough' event is received.
- http/tests/media/track-in-band-hls-metadata-crash-expected.txt:
- http/tests/media/track-in-band-hls-metadata-crash.html:
- 9:08 AM Changeset in webkit [216587] by
-
- 3 edits in branches/safari-603-branch/Source/WebCore
Cherry-pick r216131. rdar://problem/31967895
- 9:06 AM Changeset in webkit [216586] by
-
- 4 edits in trunk/Source/WebCore
Tiny cleanup in Font::DerivedFonts
https://bugs.webkit.org/show_bug.cgi?id=171893
Reviewed by Jon Lee.
This variable was written to but never read.
No new tests because there is no behavior change.
- css/CSSFontFaceSource.cpp:
(WebCore::CSSFontFaceSource::font):
- platform/graphics/Font.cpp:
(WebCore::Font::verticalRightOrientationFont):
(WebCore::Font::uprightOrientationFont):
(WebCore::Font::smallCapsFont):
(WebCore::Font::noSynthesizableFeaturesFont):
(WebCore::Font::emphasisMarkFont):
(WebCore::Font::brokenIdeographFont):
(WebCore::Font::DerivedFonts::~DerivedFonts): Deleted.
- platform/graphics/Font.h:
(WebCore::Font::DerivedFonts::DerivedFonts): Deleted.
- 7:50 AM Changeset in webkit [216585] by
-
- 4 edits in trunk
Remove user agent quirk for Slack
https://bugs.webkit.org/show_bug.cgi?id=171869
Reviewed by Carlos Garcia Campos.
Source/WebCore:
The user agent quirk for Slack does not seem to be necessary anymore. I am able to use Slack
without difficulty using our default user agent.
- platform/UserAgentQuirks.cpp:
(WebCore::urlRequiresChromeBrowser):
Tools:
Remove the corresponding test.
- TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
(TestWebKitAPI::TEST):
- 7:46 AM Changeset in webkit [216584] by
-
- 2 edits in trunk/Source/WebKit2
[GTK] HTTP authentication dialog should focus on first input field
https://bugs.webkit.org/show_bug.cgi?id=151349
Reviewed by Michael Catanzaro.
Setting focus on a widget before it's mapped does nothing. Move
the call to the right place.
- UIProcess/API/gtk/WebKitAuthenticationDialog.cpp:
(webkitAuthenticationDialogInitialize):
(webkitAuthenticationDialogMap):
- 7:31 AM Changeset in webkit [216583] by
-
- 2 edits in trunk
[Win] Specify source file type when preprocessing IDL files
https://bugs.webkit.org/show_bug.cgi?id=171864
Patch by Don Olmstead <don.olmstead@am.sony.com> on 2017-05-10
Reviewed by Alex Christensen.
- Source/cmake/OptionsCommon.cmake:
- 7:26 AM Changeset in webkit [216582] by
-
- 5 edits in trunk/Source
[GTK] -Wmissing-field-initializers triggered by RemoteInspectorServer.cpp:128
https://bugs.webkit.org/show_bug.cgi?id=171273
Reviewed by Carlos Garcia Campos.
Source/JavaScriptCore:
- inspector/remote/glib/RemoteInspectorGlib.cpp:
- inspector/remote/glib/RemoteInspectorServer.cpp:
Source/WebKit2:
- UIProcess/glib/RemoteInspectorClient.cpp:
(WebKit::RemoteInspectorClient::RemoteInspectorClient):
- 7:05 AM Changeset in webkit [216581] by
-
- 2 edits in trunk/Source/WebCore
[GTK] Fix compile warnings in CryptoKeyECGCrypt.cpp
https://bugs.webkit.org/show_bug.cgi?id=171851
Reviewed by Alex Christensen.
- crypto/gcrypt/CryptoKeyECGCrypt.cpp:
(WebCore::curveSize):
(WebCore::curveName):
(WebCore::uncompressedPointSizeForCurve):
(WebCore::uncompressedFieldElementSizeForCurve):
- 7:01 AM Changeset in webkit [216580] by
-
- 3 edits4 deletes in trunk
Remove some last remnants of the EFL port
https://bugs.webkit.org/show_bug.cgi?id=171922
Patch by Adrian Perez de Castro <Adrian Perez de Castro> on 2017-05-10
Reviewed by Antonio Gomes.
The EFL port is no more.
.:
- Source/PlatformEfl.cmake: Removed.
Source/JavaScriptCore:
- PlatformEfl.cmake: Removed.
- shell/PlatformEfl.cmake: Removed.
Source/WTF:
- wtf/PlatformEfl.cmake: Removed.
- 5:35 AM Changeset in webkit [216579] by
-
- 399 edits2 adds9 deletes in trunk
Unreviewed, rolling out r216578.
https://bugs.webkit.org/show_bug.cgi?id=171920
Broke the GTK+ build with Wayland enabled (Requested by KaL on
#webkit).
Reverted changeset:
"[GTK] Bump GTK+ and its dependencies in jhbuild"
https://bugs.webkit.org/show_bug.cgi?id=171918
http://trac.webkit.org/changeset/216578
- 4:53 AM Changeset in webkit [216578] by
-
- 399 edits9 adds2 deletes in trunk
[GTK] Bump GTK+ and its dependencies in jhbuild
https://bugs.webkit.org/show_bug.cgi?id=171918
Reviewed by Carlos Alberto Lopez Perez.
Tools:
- WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
(WTR::initializeGtkSettings):
- gtk/jhbuild.modules:
- gtk/patches/gtk+-configure-fix-detecting-CUPS-2.x.patch: Removed.
- gtk/patches/librsvg-2.36.1-bump-up-config.guess-to-support-aarch64.patch: Removed.
LayoutTests:
Rebaseline tests for new GTK+ versin.
- platform/gtk/css1/box_properties/acid_test-expected.txt:
- platform/gtk/css2.1/20110323/replaced-elements-001-expected.png:
- platform/gtk/css2.1/20110323/replaced-elements-001-expected.txt:
- platform/gtk/css2.1/t09-c5526c-display-00-e-expected.png:
- platform/gtk/css2.1/t09-c5526c-display-00-e-expected.txt:
- platform/gtk/css3/flexbox/button-expected.png:
- platform/gtk/css3/flexbox/button-expected.txt:
- platform/gtk/css3/selectors3/html/css3-modsel-161-expected.png:
- platform/gtk/css3/selectors3/html/css3-modsel-161-expected.txt:
- platform/gtk/css3/selectors3/html/css3-modsel-19b-expected.png:
- platform/gtk/css3/selectors3/html/css3-modsel-19b-expected.txt:
- platform/gtk/css3/selectors3/html/css3-modsel-23-expected.png:
- platform/gtk/css3/selectors3/html/css3-modsel-23-expected.txt:
- platform/gtk/css3/selectors3/html/css3-modsel-25-expected.png:
- platform/gtk/css3/selectors3/html/css3-modsel-25-expected.txt:
- platform/gtk/css3/selectors3/html/css3-modsel-69-expected.png:
- platform/gtk/css3/selectors3/html/css3-modsel-69-expected.txt:
- platform/gtk/css3/selectors3/html/css3-modsel-70-expected.png:
- platform/gtk/css3/selectors3/html/css3-modsel-70-expected.txt:
- platform/gtk/css3/selectors3/xhtml/css3-modsel-161-expected.png:
- platform/gtk/css3/selectors3/xhtml/css3-modsel-161-expected.txt:
- platform/gtk/css3/selectors3/xhtml/css3-modsel-19b-expected.png:
- platform/gtk/css3/selectors3/xhtml/css3-modsel-19b-expected.txt:
- platform/gtk/css3/selectors3/xhtml/css3-modsel-23-expected.png:
- platform/gtk/css3/selectors3/xhtml/css3-modsel-23-expected.txt:
- platform/gtk/css3/selectors3/xhtml/css3-modsel-25-expected.png:
- platform/gtk/css3/selectors3/xhtml/css3-modsel-25-expected.txt:
- platform/gtk/css3/selectors3/xhtml/css3-modsel-69-expected.png:
- platform/gtk/css3/selectors3/xhtml/css3-modsel-69-expected.txt:
- platform/gtk/css3/selectors3/xhtml/css3-modsel-70-expected.png:
- platform/gtk/css3/selectors3/xhtml/css3-modsel-70-expected.txt:
- platform/gtk/css3/selectors3/xml/css3-modsel-161-expected.png:
- platform/gtk/css3/selectors3/xml/css3-modsel-161-expected.txt:
- platform/gtk/css3/selectors3/xml/css3-modsel-19b-expected.png:
- platform/gtk/css3/selectors3/xml/css3-modsel-19b-expected.txt:
- platform/gtk/css3/selectors3/xml/css3-modsel-23-expected.png:
- platform/gtk/css3/selectors3/xml/css3-modsel-23-expected.txt:
- platform/gtk/css3/selectors3/xml/css3-modsel-25-expected.png:
- platform/gtk/css3/selectors3/xml/css3-modsel-25-expected.txt:
- platform/gtk/css3/selectors3/xml/css3-modsel-69-expected.png:
- platform/gtk/css3/selectors3/xml/css3-modsel-69-expected.txt:
- platform/gtk/css3/selectors3/xml/css3-modsel-70-expected.png:
- platform/gtk/css3/selectors3/xml/css3-modsel-70-expected.txt:
- platform/gtk/editing/pasteboard/4641033-expected.png:
- platform/gtk/editing/pasteboard/4641033-expected.txt:
- platform/gtk/editing/pasteboard/4944770-1-expected.png:
- platform/gtk/editing/pasteboard/4944770-1-expected.txt:
- platform/gtk/editing/pasteboard/4944770-2-expected.png:
- platform/gtk/editing/pasteboard/4944770-2-expected.txt:
- platform/gtk/editing/selection/3690703-2-expected.png:
- platform/gtk/editing/selection/3690703-2-expected.txt:
- platform/gtk/editing/selection/3690703-expected.png:
- platform/gtk/editing/selection/3690703-expected.txt:
- platform/gtk/editing/selection/3690719-expected.png:
- platform/gtk/editing/selection/3690719-expected.txt:
- platform/gtk/editing/selection/4397952-expected.png:
- platform/gtk/editing/selection/4397952-expected.txt:
- platform/gtk/editing/selection/5240265-expected.png:
- platform/gtk/editing/selection/5240265-expected.txt:
- platform/gtk/editing/selection/caret-before-select-expected.png:
- platform/gtk/editing/selection/caret-before-select-expected.txt:
- platform/gtk/editing/selection/replaced-boundaries-3-expected.png:
- platform/gtk/editing/selection/replaced-boundaries-3-expected.txt:
- platform/gtk/editing/selection/select-box-expected.png:
- platform/gtk/editing/selection/select-box-expected.txt:
- platform/gtk/editing/selection/select-element-paragraph-boundary-expected.png:
- platform/gtk/editing/selection/select-element-paragraph-boundary-expected.txt:
- platform/gtk/editing/selection/selection-button-text-expected.png:
- platform/gtk/editing/selection/selection-button-text-expected.txt:
- platform/gtk/fast/block/basic/011-expected.png:
- platform/gtk/fast/block/basic/011-expected.txt:
- platform/gtk/fast/block/float/float-avoidance-expected.png:
- platform/gtk/fast/block/float/float-avoidance-expected.txt:
- platform/gtk/fast/block/margin-collapse/103-expected.png:
- platform/gtk/fast/block/margin-collapse/103-expected.txt:
- platform/gtk/fast/block/positioning/inline-block-relposition-expected.png:
- platform/gtk/fast/block/positioning/inline-block-relposition-expected.txt:
- platform/gtk/fast/box-sizing/percentage-height-expected.png:
- platform/gtk/fast/box-sizing/percentage-height-expected.txt:
- platform/gtk/fast/css/continuationCrash-expected.png:
- platform/gtk/fast/css/continuationCrash-expected.txt:
- platform/gtk/fast/css/focus-ring-exists-for-search-field-expected.png:
- platform/gtk/fast/css/focus-ring-exists-for-search-field-expected.txt:
- platform/gtk/fast/css/input-search-padding-expected.png:
- platform/gtk/fast/css/input-search-padding-expected.txt:
- platform/gtk/fast/css/margin-top-bottom-dynamic-expected.png:
- platform/gtk/fast/css/margin-top-bottom-dynamic-expected.txt:
- platform/gtk/fast/css/non-standard-checkbox-size-expected.png:
- platform/gtk/fast/css/non-standard-checkbox-size-expected.txt:
- platform/gtk/fast/css/rtl-ordering-expected.png:
- platform/gtk/fast/css/rtl-ordering-expected.txt:
- platform/gtk/fast/css/text-input-with-webkit-border-radius-expected.png:
- platform/gtk/fast/css/text-input-with-webkit-border-radius-expected.txt:
- platform/gtk/fast/css/text-overflow-input-expected.png:
- platform/gtk/fast/css/text-overflow-input-expected.txt:
- platform/gtk/fast/css/text-transform-select-expected.png:
- platform/gtk/fast/css/text-transform-select-expected.txt:
- platform/gtk/fast/dom/HTMLInputElement/input-slider-update-expected.png:
- platform/gtk/fast/dom/HTMLInputElement/input-slider-update-expected.txt:
- platform/gtk/fast/dom/HTMLProgressElement/indeterminate-progress-001-expected.txt:
- platform/gtk/fast/dom/HTMLProgressElement/native-progress-bar-expected.png:
- platform/gtk/fast/dom/HTMLProgressElement/native-progress-bar-expected.txt:
- platform/gtk/fast/dom/HTMLProgressElement/progress-bar-value-pseudo-element-expected.png:
- platform/gtk/fast/dom/HTMLProgressElement/progress-bar-value-pseudo-element-expected.txt:
- platform/gtk/fast/dom/HTMLProgressElement/progress-element-expected.png:
- platform/gtk/fast/dom/HTMLProgressElement/progress-element-expected.txt:
- platform/gtk/fast/dom/HTMLTableColElement/resize-table-using-col-width-expected.png:
- platform/gtk/fast/dom/HTMLTableColElement/resize-table-using-col-width-expected.txt:
- platform/gtk/fast/dom/HTMLTextAreaElement/reset-textarea-expected.png:
- platform/gtk/fast/dom/HTMLTextAreaElement/reset-textarea-expected.txt:
- platform/gtk/fast/dynamic/positioned-movement-with-positioned-children-expected.txt:
- platform/gtk/fast/forms/001-expected.png:
- platform/gtk/fast/forms/001-expected.txt:
- platform/gtk/fast/forms/003-expected.png:
- platform/gtk/fast/forms/003-expected.txt:
- platform/gtk/fast/forms/004-expected.png:
- platform/gtk/fast/forms/004-expected.txt:
- platform/gtk/fast/forms/basic-buttons-expected.png:
- platform/gtk/fast/forms/basic-buttons-expected.txt:
- platform/gtk/fast/forms/basic-inputs-expected.png:
- platform/gtk/fast/forms/basic-inputs-expected.txt:
- platform/gtk/fast/forms/basic-selects-expected.png:
- platform/gtk/fast/forms/basic-selects-expected.txt:
- platform/gtk/fast/forms/blankbuttons-expected.png:
- platform/gtk/fast/forms/blankbuttons-expected.txt:
- platform/gtk/fast/forms/box-shadow-override-expected.png:
- platform/gtk/fast/forms/box-shadow-override-expected.txt:
- platform/gtk/fast/forms/button-align-expected.png:
- platform/gtk/fast/forms/button-align-expected.txt:
- platform/gtk/fast/forms/button-cannot-be-nested-expected.png:
- platform/gtk/fast/forms/button-cannot-be-nested-expected.txt:
- platform/gtk/fast/forms/button-default-title-expected.png:
- platform/gtk/fast/forms/button-default-title-expected.txt:
- platform/gtk/fast/forms/button-generated-content-expected.png:
- platform/gtk/fast/forms/button-generated-content-expected.txt:
- platform/gtk/fast/forms/button-inner-block-reuse-expected.png:
- platform/gtk/fast/forms/button-inner-block-reuse-expected.txt:
- platform/gtk/fast/forms/button-positioned-expected.png:
- platform/gtk/fast/forms/button-positioned-expected.txt:
- platform/gtk/fast/forms/button-sizes-expected.png:
- platform/gtk/fast/forms/button-sizes-expected.txt:
- platform/gtk/fast/forms/button-style-color-expected.png:
- platform/gtk/fast/forms/button-style-color-expected.txt:
- platform/gtk/fast/forms/button-table-styles-expected.png:
- platform/gtk/fast/forms/button-table-styles-expected.txt:
- platform/gtk/fast/forms/button-text-transform-expected.png:
- platform/gtk/fast/forms/button-text-transform-expected.txt:
- platform/gtk/fast/forms/button-white-space-expected.png:
- platform/gtk/fast/forms/button-white-space-expected.txt:
- platform/gtk/fast/forms/control-clip-expected.png:
- platform/gtk/fast/forms/control-clip-expected.txt:
- platform/gtk/fast/forms/control-clip-overflow-expected.png:
- platform/gtk/fast/forms/control-clip-overflow-expected.txt:
- platform/gtk/fast/forms/control-restrict-line-height-expected.png:
- platform/gtk/fast/forms/control-restrict-line-height-expected.txt:
- platform/gtk/fast/forms/disabled-select-change-index-expected.png:
- platform/gtk/fast/forms/disabled-select-change-index-expected.txt:
- platform/gtk/fast/forms/file/file-input-direction-expected.png:
- platform/gtk/fast/forms/file/file-input-direction-expected.txt:
- platform/gtk/fast/forms/file/file-input-disabled-expected.png:
- platform/gtk/fast/forms/file/file-input-disabled-expected.txt:
- platform/gtk/fast/forms/form-element-geometry-expected.png:
- platform/gtk/fast/forms/form-element-geometry-expected.txt:
- platform/gtk/fast/forms/formmove-expected.png:
- platform/gtk/fast/forms/formmove-expected.txt:
- platform/gtk/fast/forms/formmove2-expected.png:
- platform/gtk/fast/forms/formmove2-expected.txt:
- platform/gtk/fast/forms/formmove3-expected.png:
- platform/gtk/fast/forms/formmove3-expected.txt:
- platform/gtk/fast/forms/indeterminate-expected.png:
- platform/gtk/fast/forms/indeterminate-expected.txt:
- platform/gtk/fast/forms/input-appearance-height-expected.png:
- platform/gtk/fast/forms/input-appearance-height-expected.txt:
- platform/gtk/fast/forms/input-button-sizes-expected.png:
- platform/gtk/fast/forms/input-button-sizes-expected.txt:
- platform/gtk/fast/forms/input-first-letter-expected.png:
- platform/gtk/fast/forms/input-first-letter-expected.txt:
- platform/gtk/fast/forms/input-number-click-expected.txt: Added.
- platform/gtk/fast/forms/input-value-expected.png:
- platform/gtk/fast/forms/input-value-expected.txt:
- platform/gtk/fast/forms/menulist-deselect-update-expected.png:
- platform/gtk/fast/forms/menulist-deselect-update-expected.txt:
- platform/gtk/fast/forms/menulist-narrow-width-expected.png:
- platform/gtk/fast/forms/menulist-narrow-width-expected.txt:
- platform/gtk/fast/forms/menulist-no-overflow-expected.png:
- platform/gtk/fast/forms/menulist-no-overflow-expected.txt:
- platform/gtk/fast/forms/menulist-restrict-line-height-expected.png:
- platform/gtk/fast/forms/menulist-restrict-line-height-expected.txt:
- platform/gtk/fast/forms/menulist-separator-painting-expected.png:
- platform/gtk/fast/forms/menulist-separator-painting-expected.txt:
- platform/gtk/fast/forms/menulist-style-color-expected.png:
- platform/gtk/fast/forms/menulist-style-color-expected.txt:
- platform/gtk/fast/forms/menulist-width-change-expected.png:
- platform/gtk/fast/forms/menulist-width-change-expected.txt:
- platform/gtk/fast/forms/number/number-appearance-rtl-expected.png:
- platform/gtk/fast/forms/number/number-appearance-rtl-expected.txt:
- platform/gtk/fast/forms/number/number-appearance-spinbutton-disabled-readonly-expected.png:
- platform/gtk/fast/forms/number/number-appearance-spinbutton-disabled-readonly-expected.txt:
- platform/gtk/fast/forms/number/number-appearance-spinbutton-layer-expected.png:
- platform/gtk/fast/forms/number/number-appearance-spinbutton-layer-expected.txt:
- platform/gtk/fast/forms/number/number-spinbutton-change-and-input-events-expected.txt: Added.
- platform/gtk/fast/forms/number/number-spinbutton-click-in-iframe-expected.txt: Added.
- platform/gtk/fast/forms/number/number-spinbutton-gets-disabled-or-readonly-expected.txt: Added.
- platform/gtk/fast/forms/option-script-expected.png:
- platform/gtk/fast/forms/option-script-expected.txt:
- platform/gtk/fast/forms/option-strip-whitespace-expected.png:
- platform/gtk/fast/forms/option-strip-whitespace-expected.txt:
- platform/gtk/fast/forms/option-text-clip-expected.png:
- platform/gtk/fast/forms/option-text-clip-expected.txt:
- platform/gtk/fast/forms/placeholder-position-expected.png:
- platform/gtk/fast/forms/placeholder-position-expected.txt:
- platform/gtk/fast/forms/placeholder-pseudo-style-expected.png:
- platform/gtk/fast/forms/placeholder-pseudo-style-expected.txt:
- platform/gtk/fast/forms/range/input-appearance-range-expected.png:
- platform/gtk/fast/forms/range/input-appearance-range-expected.txt:
- platform/gtk/fast/forms/range/slider-padding-expected.png:
- platform/gtk/fast/forms/range/slider-padding-expected.txt:
- platform/gtk/fast/forms/range/slider-thumb-shared-style-expected.png:
- platform/gtk/fast/forms/range/slider-thumb-shared-style-expected.txt:
- platform/gtk/fast/forms/range/slider-transformed-expected.txt:
- platform/gtk/fast/forms/range/thumbslider-no-parent-slider-expected.png:
- platform/gtk/fast/forms/range/thumbslider-no-parent-slider-expected.txt:
- platform/gtk/fast/forms/search-cancel-button-style-sharing-expected.png:
- platform/gtk/fast/forms/search-cancel-button-style-sharing-expected.txt:
- platform/gtk/fast/forms/search-display-none-cancel-button-expected.png:
- platform/gtk/fast/forms/search-display-none-cancel-button-expected.txt:
- platform/gtk/fast/forms/search-input-rtl-expected.png:
- platform/gtk/fast/forms/search-input-rtl-expected.txt: Added.
- platform/gtk/fast/forms/search-rtl-expected.png:
- platform/gtk/fast/forms/search-rtl-expected.txt:
- platform/gtk/fast/forms/search-styled-expected.png:
- platform/gtk/fast/forms/search-styled-expected.txt:
- platform/gtk/fast/forms/search/search-size-with-decorations-expected.png:
- platform/gtk/fast/forms/search/search-size-with-decorations-expected.txt:
- platform/gtk/fast/forms/searchfield-heights-expected.png:
- platform/gtk/fast/forms/searchfield-heights-expected.txt:
- platform/gtk/fast/forms/select-align-expected.png:
- platform/gtk/fast/forms/select-align-expected.txt:
- platform/gtk/fast/forms/select-background-none-expected.png:
- platform/gtk/fast/forms/select-background-none-expected.txt:
- platform/gtk/fast/forms/select-baseline-expected.png:
- platform/gtk/fast/forms/select-baseline-expected.txt:
- platform/gtk/fast/forms/select-change-listbox-to-popup-expected.png:
- platform/gtk/fast/forms/select-change-listbox-to-popup-expected.txt:
- platform/gtk/fast/forms/select-dirty-parent-pref-widths-expected.png:
- platform/gtk/fast/forms/select-dirty-parent-pref-widths-expected.txt:
- platform/gtk/fast/forms/select-disabled-appearance-expected.png:
- platform/gtk/fast/forms/select-disabled-appearance-expected.txt:
- platform/gtk/fast/forms/select-element-focus-ring-expected.png: Added.
- platform/gtk/fast/forms/select-element-focus-ring-expected.txt:
- platform/gtk/fast/forms/select-initial-position-expected.png:
- platform/gtk/fast/forms/select-initial-position-expected.txt:
- platform/gtk/fast/forms/select-non-native-rendering-direction-expected.png: Added.
- platform/gtk/fast/forms/select-non-native-rendering-direction-expected.txt: Added.
- platform/gtk/fast/forms/select-selected-expected.png:
- platform/gtk/fast/forms/select-selected-expected.txt:
- platform/gtk/fast/forms/select-style-expected.png:
- platform/gtk/fast/forms/select-style-expected.txt:
- platform/gtk/fast/forms/select-visual-hebrew-expected.png:
- platform/gtk/fast/forms/select-visual-hebrew-expected.txt:
- platform/gtk/fast/forms/select-writing-direction-natural-expected.png:
- platform/gtk/fast/forms/select-writing-direction-natural-expected.txt:
- platform/gtk/fast/forms/select/optgroup-rendering-expected.png:
- platform/gtk/fast/forms/select/optgroup-rendering-expected.txt:
- platform/gtk/fast/forms/selectlist-minsize-expected.png:
- platform/gtk/fast/forms/selectlist-minsize-expected.txt:
- platform/gtk/fast/forms/stuff-on-my-optgroup-expected.png:
- platform/gtk/fast/forms/stuff-on-my-optgroup-expected.txt:
- platform/gtk/fast/forms/targeted-frame-submission-expected.png:
- platform/gtk/fast/forms/targeted-frame-submission-expected.txt:
- platform/gtk/fast/forms/validation-message-appearance-expected.png:
- platform/gtk/fast/forms/validation-message-appearance-expected.txt:
- platform/gtk/fast/html/details-replace-summary-child-expected.png:
- platform/gtk/fast/html/details-replace-summary-child-expected.txt:
- platform/gtk/fast/html/details-replace-text-expected.png:
- platform/gtk/fast/html/details-replace-text-expected.txt:
- platform/gtk/fast/html/keygen-expected.png:
- platform/gtk/fast/html/keygen-expected.txt:
- platform/gtk/fast/inline/positionedLifetime-expected.png:
- platform/gtk/fast/inline/positionedLifetime-expected.txt:
- platform/gtk/fast/invalid/014-expected.png:
- platform/gtk/fast/invalid/014-expected.txt:
- platform/gtk/fast/overflow/scroll-nested-positioned-layer-in-overflow-expected.png:
- platform/gtk/fast/overflow/scroll-nested-positioned-layer-in-overflow-expected.txt:
- platform/gtk/fast/overflow/scrollRevealButton-expected.png:
- platform/gtk/fast/overflow/scrollRevealButton-expected.txt:
- platform/gtk/fast/parser/bad-xml-slash-expected.png:
- platform/gtk/fast/parser/bad-xml-slash-expected.txt:
- platform/gtk/fast/parser/document-write-option-expected.png:
- platform/gtk/fast/parser/document-write-option-expected.txt:
- platform/gtk/fast/repaint/search-field-cancel-expected.png:
- platform/gtk/fast/repaint/search-field-cancel-expected.txt:
- platform/gtk/fast/repaint/slider-thumb-drag-release-expected.png:
- platform/gtk/fast/repaint/slider-thumb-drag-release-expected.txt:
- platform/gtk/fast/replaced/replaced-breaking-expected.png:
- platform/gtk/fast/replaced/replaced-breaking-expected.txt:
- platform/gtk/fast/replaced/replaced-breaking-mixture-expected.png:
- platform/gtk/fast/replaced/replaced-breaking-mixture-expected.txt:
- platform/gtk/fast/replaced/three-selects-break-expected.png:
- platform/gtk/fast/replaced/three-selects-break-expected.txt:
- platform/gtk/fast/replaced/width100percent-button-expected.png:
- platform/gtk/fast/replaced/width100percent-button-expected.txt:
- platform/gtk/fast/replaced/width100percent-menulist-expected.png:
- platform/gtk/fast/replaced/width100percent-menulist-expected.txt:
- platform/gtk/fast/replaced/width100percent-searchfield-expected.png:
- platform/gtk/fast/replaced/width100percent-searchfield-expected.txt:
- platform/gtk/fast/scrolling/overflow-scrollable-after-back-expected.txt: Added.
- platform/gtk/fast/table/append-cells2-expected.png:
- platform/gtk/fast/table/append-cells2-expected.txt:
- platform/gtk/fast/table/remove-td-display-none-expected.png:
- platform/gtk/fast/table/remove-td-display-none-expected.txt:
- platform/gtk/fast/text/international/bidi-menulist-expected.png:
- platform/gtk/fast/text/international/bidi-menulist-expected.txt:
- platform/gtk/fast/text/international/hindi-spacing-expected.png:
- platform/gtk/fast/text/international/hindi-spacing-expected.txt:
- platform/gtk/fast/text/international/pop-up-button-text-alignment-and-direction-expected.png:
- platform/gtk/fast/text/international/pop-up-button-text-alignment-and-direction-expected.txt:
- platform/gtk/fast/text/textIteratorNilRenderer-expected.png:
- platform/gtk/fast/text/textIteratorNilRenderer-expected.txt:
- platform/gtk/fast/text/whitespace/normal-after-nowrap-breaking-expected.png:
- platform/gtk/fast/text/whitespace/normal-after-nowrap-breaking-expected.txt:
- platform/gtk/http/tests/navigation/javascriptlink-frames-expected.png:
- platform/gtk/http/tests/navigation/javascriptlink-frames-expected.txt:
- platform/gtk/svg/custom/foreign-object-skew-expected.png:
- platform/gtk/svg/custom/foreign-object-skew-expected.txt:
- platform/gtk/svg/custom/inline-svg-in-xhtml-expected.png:
- platform/gtk/svg/custom/inline-svg-in-xhtml-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug1188-expected.png:
- platform/gtk/tables/mozilla/bugs/bug1188-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug1318-expected.png:
- platform/gtk/tables/mozilla/bugs/bug1318-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug138725-expected.png:
- platform/gtk/tables/mozilla/bugs/bug138725-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug18359-expected.png:
- platform/gtk/tables/mozilla/bugs/bug18359-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug2479-2-expected.png:
- platform/gtk/tables/mozilla/bugs/bug2479-2-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug2479-3-expected.png:
- platform/gtk/tables/mozilla/bugs/bug2479-3-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug2479-4-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug26178-expected.png:
- platform/gtk/tables/mozilla/bugs/bug26178-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug28928-expected.png:
- platform/gtk/tables/mozilla/bugs/bug28928-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug29326-expected.png:
- platform/gtk/tables/mozilla/bugs/bug29326-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug33855-expected.png:
- platform/gtk/tables/mozilla/bugs/bug33855-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug39209-expected.png:
- platform/gtk/tables/mozilla/bugs/bug39209-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug4382-expected.png:
- platform/gtk/tables/mozilla/bugs/bug4382-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug4429-expected.png:
- platform/gtk/tables/mozilla/bugs/bug4429-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug44505-expected.png:
- platform/gtk/tables/mozilla/bugs/bug44505-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug4527-expected.png:
- platform/gtk/tables/mozilla/bugs/bug4527-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug46368-1-expected.png:
- platform/gtk/tables/mozilla/bugs/bug46368-1-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug46368-2-expected.png:
- platform/gtk/tables/mozilla/bugs/bug46368-2-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug51037-expected.png:
- platform/gtk/tables/mozilla/bugs/bug51037-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug51727-expected.png:
- platform/gtk/tables/mozilla/bugs/bug51727-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug52505-expected.png:
- platform/gtk/tables/mozilla/bugs/bug52505-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug52506-expected.png:
- platform/gtk/tables/mozilla/bugs/bug52506-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug60749-expected.png:
- platform/gtk/tables/mozilla/bugs/bug60749-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug68912-expected.png:
- platform/gtk/tables/mozilla/bugs/bug68912-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug7342-expected.png:
- platform/gtk/tables/mozilla/bugs/bug7342-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug92647-2-expected.png:
- platform/gtk/tables/mozilla/bugs/bug92647-2-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug96334-expected.png:
- platform/gtk/tables/mozilla/bugs/bug96334-expected.txt:
- platform/gtk/tables/mozilla/collapsing_borders/bug41262-4-expected.png:
- platform/gtk/tables/mozilla/collapsing_borders/bug41262-4-expected.txt:
- platform/gtk/tables/mozilla/core/margins-expected.png:
- platform/gtk/tables/mozilla/core/margins-expected.txt:
- platform/gtk/tables/mozilla/dom/tableDom-expected.png:
- platform/gtk/tables/mozilla/dom/tableDom-expected.txt:
- platform/gtk/tables/mozilla/other/move_row-expected.png:
- platform/gtk/tables/mozilla/other/move_row-expected.txt:
- platform/gtk/tables/mozilla_expected_failures/bugs/bug1725-expected.png:
- platform/gtk/tables/mozilla_expected_failures/bugs/bug1725-expected.txt:
- platform/gtk/tables/mozilla_expected_failures/bugs/bug2479-5-expected.png:
- platform/gtk/tables/mozilla_expected_failures/bugs/bug2479-5-expected.txt:
- platform/gtk/tables/mozilla_expected_failures/bugs/bug58402-2-expected.png:
- platform/gtk/tables/mozilla_expected_failures/bugs/bug58402-2-expected.txt:
- platform/gtk/tables/mozilla_expected_failures/collapsing_borders/bug41262-5-expected.png:
- platform/gtk/tables/mozilla_expected_failures/collapsing_borders/bug41262-5-expected.txt:
- platform/gtk/tables/mozilla_expected_failures/collapsing_borders/bug41262-6-expected.png:
- platform/gtk/tables/mozilla_expected_failures/collapsing_borders/bug41262-6-expected.txt:
- platform/gtk/tables/mozilla_expected_failures/core/captions1-expected.png:
- platform/gtk/tables/mozilla_expected_failures/core/captions1-expected.txt:
- platform/gtk/tables/mozilla_expected_failures/core/captions2-expected.png:
- platform/gtk/tables/mozilla_expected_failures/core/captions2-expected.txt:
- platform/gtk/transforms/2d/zoom-menulist-expected.png:
- platform/gtk/transforms/2d/zoom-menulist-expected.txt:
- 3:04 AM Changeset in webkit [216577] by
-
- 2 edits in trunk/Tools
[Win] Set CMake args in build-webkit
https://bugs.webkit.org/show_bug.cgi?id=171436
Patch by Don Olmstead <don.olmstead@am.sony.com> on 2017-05-10
Reviewed by Per Arne Vollan.
- Scripts/build-webkit:
- 1:16 AM Changeset in webkit [216576] by
-
- 11 edits1 add3 deletes in trunk/Tools
ImageDiff: Add CG implementation for new ImageDiff
https://bugs.webkit.org/show_bug.cgi?id=170608
Reviewed Alex Christensen.
Patch by Carlos Garcia Campos <cgarcia@igalia.com> on 2017-05-10
- DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
- DumpRenderTree/win/ImageDiffCairo.cpp: Removed.
- DumpRenderTree/win/ImageDiffWin.cpp: Removed.
- ImageDiff/CMakeLists.txt:
- ImageDiff/Cairo.cmake:
- ImageDiff/ImageDiff.cpp:
(main):
- ImageDiff/ImageDiff.xcodeproj/project.pbxproj:
- ImageDiff/PlatformImage.cpp:
- ImageDiff/PlatformImage.h:
- ImageDiff/cairo/PlatformImageCairo.cpp:
- ImageDiff/cg/ImageDiff.cpp: Removed.
- ImageDiff/cg/PlatformImageCG.cpp: Added.
(ImageDiff::PlatformImage::createFromStdin):
(ImageDiff::PlatformImage::createFromDiffData):
(ImageDiff::PlatformImage::PlatformImage):
(ImageDiff::PlatformImage::~PlatformImage):
(ImageDiff::PlatformImage::width):
(ImageDiff::PlatformImage::height):
(ImageDiff::PlatformImage::rowBytes):
(ImageDiff::PlatformImage::hasAlpha):
(ImageDiff::PlatformImage::pixels):
(ImageDiff::PlatformImage::writeAsPNGToStdout):
- 1:04 AM Changeset in webkit [216575] by
-
- 8 edits in trunk
Enable FTL JIT by default on AArch64
https://bugs.webkit.org/show_bug.cgi?id=144039
Reviewed by Yusuke Suzuki.
.:
- Source/cmake/OptionsWPE.cmake:
- Source/cmake/WebKitFeatures.cmake: Set FTL as enabled by default
when targeting either WTF_CPU_X86_64 or WTF_CPU_ARM64.
Tools:
- Scripts/build-jsc: Enable the FTL JIT option by default on ARM64.
- Scripts/run-jsc-stress-tests: Unmark the ARM64 and Linux combination
as an unsupported FTL platform.
- Scripts/webkitdirs.pm:
(isARM64): Returns 1 if the determined architecture is 'arm64'.
- Scripts/webkitperl/FeatureList.pm: Enable FTL_JIT and WEBASSEMBLY on ARM64.
- 12:42 AM Changeset in webkit [216574] by
-
- 6 edits in trunk
[css-grid] Remove Blink-specific code for handling orthogonal grid items
https://bugs.webkit.org/show_bug.cgi?id=171807
Reviewed by Darin Adler.
Source/WebCore:
This code was added in r203252 as part of a patch improving the handling of
{min|max}-content with orthogonal flows. The original code came from Blink which performs a
pre-layout of orthogonal boxes in FrameView. That is not true in the case of WebKit so we do
not need this code at all. Actually it was causing incorrect renderings in some tests.
I'm also removing an invalid return statement just after another return.
- rendering/GridTrackSizingAlgorithm.cpp:
(WebCore::GridTrackSizingAlgorithmStrategy::minContentForChild):
(WebCore::GridTrackSizingAlgorithmStrategy::maxContentForChild):
LayoutTests:
Updated the expectations. They should now be compatible with Firefox and Chrome.
- fast/css-grid-layout/grid-track-sizing-with-orthogonal-flows.html:
- fast/css-grid-layout/grid-track-sizing-with-percentages-and-orthogonal-flows.html:
- fast/css-grid-layout/repeating-layout-must-produce-the-same-results.html:
- 12:40 AM Changeset in webkit [216573] by
-
- 3 edits2 adds in branches/safari-603-branch
Cherry-pick r216443. rdar://problem/31971375
- 12:40 AM Changeset in webkit [216572] by
-
- 3 edits2 adds in branches/safari-603-branch
Cherry-pick r216159. rdar://problem/31971329
- 12:40 AM Changeset in webkit [216571] by
-
- 3 edits2 adds in branches/safari-603-branch
Cherry-pick r216104. rdar://problem/32057088
- 12:40 AM Changeset in webkit [216570] by
-
- 6 edits1 add in branches/safari-603-branch
Cherry-pick r215748. rdar://problem/31971413
- 12:40 AM Changeset in webkit [216569] by
-
- 4 edits2 adds in branches/safari-603-branch
Cherry-pick r215197. rdar://problem/31971401
- 12:40 AM Changeset in webkit [216568] by
-
- 7 edits5 adds in branches/safari-603-branch
Cherry-pick r214375. rdar://problem/32057082
- 12:40 AM Changeset in webkit [216567] by
-
- 2 edits in branches/safari-603-branch/Source/WebCore
Cherry-pick r213727. rdar://problem/32086123
- 12:22 AM Changeset in webkit [216566] by
-
- 2 edits in trunk/Source/WTF
[Win] StaticStringImpl in HTMLNames.cpp aren't constructed
https://bugs.webkit.org/show_bug.cgi?id=171800
Patch by Fujii Hironori <Fujii Hironori> on 2017-05-10
Reviewed by Yusuke Suzuki.
Global variables of StaticStringImpl in HTMLNames.cpp aren't
constructed on Windows since Bug 171586. It seems that
reinterpret_cast prevents constexpr's compile time initialization
in VC++.
- wtf/text/StringImpl.h:
(WTF::StringImplShape::StringImplShape): Added const char* and
const char16_t* members in the union. Do not use reinterpret_cast
in constexpr constructors.
