⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



May 13, 2017:

11:05 PM Changeset in webkit [216838] by ddkilzer@apple.com
  • 2 edits in trunk/Source/WebCore

Unused lambda in JSWebKitSubtleCrypto::wrapKey()
<https://webkit.org/b/172087>

Reviewed by Chris Dumez.

Fixes the following warning with newer clang:

Source/WebCore/bindings/js/JSWebKitSubtleCryptoCustom.cpp:594:35: error: lambda capture 'keyFormat' is not used [-Werror,-Wunused-lambda-capture]

auto exportSuccessCallback = [keyFormat, algorithm, parameters, wrappingKey, wrapper](const Vector<uint8_t>& exportedKeyData) mutable {


  • bindings/js/JSWebKitSubtleCryptoCustom.cpp:

(WebCore::JSWebKitSubtleCrypto::wrapKey): Remove unused lambda.

10:37 PM Changeset in webkit [216837] by ddkilzer@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Unused lambda capture in JSContextGroupAddMarkingConstraint()
<https://webkit.org/b/172084>

Reviewed by Saam Barati.

Fixes the following warning with newer clang:

Source/JavaScriptCore/API/JSMarkingConstraintPrivate.cpp:78:11: error: lambda capture 'vm' is not used [-Werror,-Wunused-lambda-capture]

[&vm, constraintCallback, userData]


  • API/JSMarkingConstraintPrivate.cpp:

(JSContextGroupAddMarkingConstraint): Remove unused lambda
capture for '&vm'.

10:27 PM Changeset in webkit [216836] by eric.carlson@apple.com
  • 39 edits
    2 adds in trunk

[MediaStream] deviceId constraint doesn't work with getUserMedia
https://bugs.webkit.org/show_bug.cgi?id=171877
<rdar://problem/31899730>

Reviewed by Jer Noble.

Source/WebCore:

Test: fast/mediastream/get-user-media-device-id.html

  • Modules/mediastream/MediaConstraintsImpl.h:

(WebCore::MediaConstraintsData::MediaConstraintsData): Add a constructor that
takes a const MediaConstraints&.

  • Modules/mediastream/MediaDevices.cpp:

(WebCore::MediaDevices::~MediaDevices): m_deviceChangedToken is a std::optional<>.

  • Modules/mediastream/MediaDevices.h:
  • Modules/mediastream/MediaDevicesEnumerationRequest.cpp:

(WebCore::MediaDevicesEnumerationRequest::topLevelDocumentOrigin): Don't return
NULL for the main frame so the origin matches that returned for a UserMediaRequest.

  • Modules/mediastream/UserMediaController.h:

(WebCore::UserMediaController::setDeviceIDHashSalt): Deleted, not used.
(WebCore::UserMediaController::deviceIDHashSalt): Deleted, not used.

  • Modules/mediastream/UserMediaRequest.cpp:

(WebCore::UserMediaRequest::allow): Add device ID hash salt parameter, set it on
constraints.

  • Modules/mediastream/UserMediaRequest.h:
  • platform/mediastream/MediaConstraints.h:
  • platform/mediastream/RealtimeMediaSource.cpp:

(WebCore::RealtimeMediaSource::fitnessDistance): ASSERT if called for DeviceId.
(WebCore::RealtimeMediaSource::selectSettings): Special case DeviceId because it
we have to hash the device ID before comparing, and because the DeviceId can't be
changed so it should never be added to the flattened constraints.
(WebCore::RealtimeMediaSource::supportsConstraints):
(WebCore::RealtimeMediaSource::applyConstraints):

  • platform/mediastream/RealtimeMediaSource.h:
  • platform/mediastream/RealtimeMediaSourceCenter.cpp:

(WebCore::RealtimeMediaSourceCenter::validateRequestConstraints): Implement.

  • platform/mediastream/RealtimeMediaSourceCenter.h:
  • platform/mediastream/RealtimeMediaSourceSupportedConstraints.cpp:

(WebCore::RealtimeMediaSourceSupportedConstraints::nameForConstraint): Deleted, unused.
(WebCore::RealtimeMediaSourceSupportedConstraints::constraintFromName): Deleted, unused.

  • platform/mediastream/RealtimeMediaSourceSupportedConstraints.h:
  • platform/mediastream/mac/AVVideoCaptureSource.mm:
  • platform/mediastream/mac/RealtimeMediaSourceCenterMac.cpp:

(WebCore::RealtimeMediaSourceCenterMac::bestSourcesForTypeAndConstraints): Pass device
id, not empty string.
(WebCore::RealtimeMediaSourceCenterMac::validateRequestConstraints): Deleted.

  • platform/mediastream/mac/RealtimeMediaSourceCenterMac.h:
  • platform/mock/MockRealtimeMediaSourceCenter.cpp:

(WebCore::MockRealtimeMediaSourceCenter::validateRequestConstraints): Deleted.

  • platform/mock/MockRealtimeMediaSourceCenter.h:

Source/WebKit2:

  • Shared/WebCoreArgumentCoders.cpp:

(IPC::ArgumentCoder<MediaConstraintsData>::encode): Encode deviceIDHashSalt.
(IPC::ArgumentCoder<MediaConstraintsData>::decode): Decode deviceIDHashSalt.

  • UIProcess/UserMediaPermissionCheckProxy.cpp:

(WebKit::UserMediaPermissionCheckProxy::UserMediaPermissionCheckProxy): Initialize
completion handler, frame ID, and security origins.
(WebKit::UserMediaPermissionCheckProxy::setUserMediaAccessInfo): Complete by calling
completion handler because we now sometimes request access info before calling gUM.
(WebKit::UserMediaPermissionCheckProxy::invalidate): Clear completion handler.

  • UIProcess/UserMediaPermissionCheckProxy.h:
  • UIProcess/UserMediaPermissionRequestManagerProxy.cpp:

(WebKit::FrameAuthorizationState::FrameAuthorizationState): Take security origins, not
UserMediaPermissionRequestProxy, so it can be constructed with a UserMediaPermissionCheckProxy.
(WebKit::FrameAuthorizationState::ensureSecurityOriginsAreEqual): Ditto. Clear has salt
when origins don't match.
(WebKit::UserMediaPermissionRequestManagerProxy::stateForRequest): Templatize.
(WebKit::UserMediaPermissionRequestManagerProxy::userMediaAccessWasDenied): Fix typo.
(WebKit::UserMediaPermissionRequestManagerProxy::userMediaAccessWasGranted): Ditto.
Don't set state for empty UIDs. Pass hash salt to web process.
(WebKit::UserMediaPermissionRequestManagerProxy::requestUserMediaPermissionForFrame):
The device ID hash salt is now required to validate constraints, so get it first.
(WebKit::UserMediaPermissionRequestManagerProxy::getUserMediaPermissionInfo): Helper
method used to get the device ID hash salt.
(WebKit::UserMediaPermissionRequestManagerProxy::enumerateMediaDevicesForFrame): Restructure
to use getUserMediaPermissionInfo.
(WebKit::UserMediaPermissionRequestManagerProxy::didCompleteUserMediaPermissionCheck): Deleted.

  • UIProcess/UserMediaPermissionRequestManagerProxy.h:
  • WebProcess/MediaStream/UserMediaPermissionRequestManager.cpp:

(WebKit::UserMediaPermissionRequestManager::userMediaAccessWasGranted): Add device ID
hash salt parameter.

  • WebProcess/MediaStream/UserMediaPermissionRequestManager.h:
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::userMediaAccessWasGranted): Ditto.

  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebPage/WebPage.messages.in:
  • WebProcess/cocoa/UserMediaCaptureManager.cpp:

(WebKit::UserMediaCaptureManager::createCaptureSource): Use new MediaConstraintsData
constructor.

Tools:

The device ID hash salt is now required for getUserMedia to check deviceId constraint, so
implement the "checkUserMediaPermission" callback.

  • TestWebKitAPI/Tests/WebKit2/UserMedia.cpp:

(TestWebKitAPI::decidePolicyForUserMediaPermissionRequestCallBack):
(TestWebKitAPI::checkUserMediaPermissionCallback):
(TestWebKitAPI::TEST):

  • TestWebKitAPI/Tests/WebKit2Cocoa/UserMediaDisabled.mm:

(-[UserMediaUIDelegate _webView:checkUserMediaPermissionForURL:mainFrameURL:frameIdentifier:decisionHandler:]):

LayoutTests:

  • fast/mediastream/get-user-media-device-id-expected.txt: Added.
  • fast/mediastream/get-user-media-device-id.html: Added.
  • fast/mediastream/apply-constraints-video-expected.txt: Updated.
  • fast/mediastream/apply-constraints-video.html: Ditto.
10:21 PM Changeset in webkit [216835] by ddkilzer@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

[JSC] config.rb fails when checking some clang versions
<https://webkit.org/b/172082>

Reviewed by Mark Lam.

  • offlineasm/config.rb:
  • Add support for quad-dotted version of Apple clang (800.0.12.1).
  • Add support for checking open source clang version (5.0.0).
9:27 PM Changeset in webkit [216834] by ddkilzer@apple.com
  • 2 edits in trunk/LayoutTests

TestExpectations: Remove last refereneces to Legacy Notifications

Unreviewed test gardening fixes these lint warnings:

LayoutTests/TestExpectations:1222 Path does not exist. fast/notifications/notifications-event-stop-propagation.html
LayoutTests/TestExpectations:1223 Path does not exist. fast/notifications/notifications-multi-events.html

Notification support was removed in r216641.

9:04 PM Changeset in webkit [216833] by Chris Dumez
  • 28 edits in trunk

Stop using RefPtr::release()
https://bugs.webkit.org/show_bug.cgi?id=172074

Reviewed by Geoffrey Garen.

Source/WebCore:

  • css/parser/CSSPropertyParser.cpp:

(WebCore::FontVariantLigaturesParser::finalizeValue):
(WebCore::FontVariantNumericParser::finalizeValue):

  • css/parser/CSSPropertyParserHelpers.cpp:

(WebCore::CSSPropertyParserHelpers::CalcParser::consumeValue):

  • loader/SubresourceLoader.cpp:

(WebCore::SubresourceLoader::create):

  • loader/archive/mhtml/MHTMLArchive.cpp:

(WebCore::MHTMLArchive::generateMHTMLData):

  • loader/archive/mhtml/MHTMLArchive.h:
  • loader/archive/mhtml/MHTMLParser.cpp:

(WebCore::MHTMLParser::parseArchiveWithHeader):

  • platform/audio/ios/AudioFileReaderIOS.cpp:

(WebCore::AudioFileReader::createBus):

  • platform/glib/SharedBufferGlib.cpp:

(WebCore::SharedBuffer::createFromReadingFile):

  • platform/graphics/ca/win/CACFLayerTreeHost.cpp:

(WebCore::CACFLayerTreeHost::create):

  • platform/graphics/cairo/CairoUtilities.cpp:

(WebCore::copyCairoImageSurface):

  • platform/graphics/cairo/ImageBufferCairo.cpp:

(WebCore::getImageData):

  • platform/graphics/gtk/IconGtk.cpp:

(WebCore::Icon::createIconForFiles):

  • platform/graphics/win/FontCacheWin.cpp:

(WebCore::FontCache::systemFallbackForCharacters):

  • platform/win/SharedBufferWin.cpp:

(WebCore::SharedBuffer::createFromReadingFile):

Source/WebKit/win:

  • WebFrame.cpp:

(WebFrame::loadPlainTextString):
(WebFrame::loadHTMLString):

  • WebFramePolicyListener.cpp:

(WebFramePolicyListener::receivedPolicyDecision):

Source/WebKit2:

  • Platform/unix/SharedMemoryUnix.cpp:

(WebKit::SharedMemory::create):

  • Shared/CoordinatedGraphics/CoordinatedGraphicsScene.cpp:

(WebKit::CoordinatedGraphicsScene::createImageBacking):

  • Shared/cairo/ShareableBitmapCairo.cpp:

(WebKit::ShareableBitmap::createCairoSurface):

  • WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMNodeFilter.cpp:

(WebKit::core):

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::getContentsAsMHTMLData):

Source/WTF:

  • wtf/win/WorkQueueWin.cpp:

(WTF::WorkQueue::dispatchAfter):

Tools:

  • TestWebKitAPI/Tests/WTF/RefPtr.cpp:

(TestWebKitAPI::TEST):

7:20 PM Changeset in webkit [216832] by Ryan Haddad
  • 2 edits in branches/safari-603-branch/LayoutTests

Unreviewed test gardening.

  • platform/ios-simulator/TestExpectations:
7:18 PM Changeset in webkit [216831] by Ryan Haddad
  • 3 edits in branches/safari-603-branch/LayoutTests

Merge r216614.

6:07 PM Changeset in webkit [216830] by Ryan Haddad
  • 2 edits in trunk/LayoutTests

Remove flaky expectation for LayoutTest media/media-controls-clone-crash.html.
https://bugs.webkit.org/show_bug.cgi?id=171978

Unreviewed test gardening.

  • platform/mac-wk2/TestExpectations:
2:36 PM Changeset in webkit [216829] by jfernandez@igalia.com
  • 7 edits
    2 adds in trunk

[css-align] Implement the place-self shorthand
https://bugs.webkit.org/show_bug.cgi?id=168846

Reviewed by Zalan Bujtas.

Source/WebCore:

The CSS Box Alignment specification defines a new shorthand to set the
Content Alignment properties (align-self and justify-self) at the
same time.

This patch provides the implementation of the CSS parsing logic and the
required regression tests.

Test: css3/parse-place-self.html

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::ComputedStyleExtractor::propertyValue):

  • css/CSSProperties.json:
  • css/StyleProperties.cpp:

(WebCore::StyleProperties::getPropertyValue):

  • css/parser/CSSPropertyParser.cpp:

(WebCore::CSSPropertyParser::consumePlaceSelfShorthand):
(WebCore::CSSPropertyParser::parseShorthand):

  • css/parser/CSSPropertyParser.h:

LayoutTests:

Regression tests for the new place-self alignment shorthand.

  • css3/parse-place-self-expected.txt: Added.
  • css3/parse-place-self.html: Added.
1:46 PM Changeset in webkit [216828] by jmarcell@apple.com
  • 6 edits
    2 adds in branches/safari-603-branch/Source

Cherry-pick r214313. rdar://problem/32080658

1:32 PM Changeset in webkit [216827] by commit-queue@webkit.org
  • 24 edits
    1 delete in trunk

Unreviewed, rolling out r216808.
https://bugs.webkit.org/show_bug.cgi?id=172075

caused lldb to hang when debugging (Requested by smfr on
#webkit).

Reverted changeset:

"Use Mach exceptions instead of signals where possible"
https://bugs.webkit.org/show_bug.cgi?id=171865
http://trac.webkit.org/changeset/216808

12:10 PM Changeset in webkit [216826] by commit-queue@webkit.org
  • 15 edits in trunk

Unreviewed, rolling out r216801.
https://bugs.webkit.org/show_bug.cgi?id=172072

Many memory corruption crashes on worker threads (Requested by
ap on #webkit).

Reverted changeset:

"WorkerRunLoop::Task::performTask() should check
!scriptController->isTerminatingExecution()."
https://bugs.webkit.org/show_bug.cgi?id=171775
http://trac.webkit.org/changeset/216801

11:43 AM Changeset in webkit [216825] by Alan Bujtas
  • 2 edits in trunk/Source/WebCore

AccessibilityRenderObject::textUnderElement needs to assert on unclean tree.
https://bugs.webkit.org/show_bug.cgi?id=172065

Reviewed by Simon Fraser.

r192103 changed the assert logic incorrectly. If the tree is dirty, regardless of the renderer's type,
TextIterator will end up forcing style update/layout on the render tree.
The original assert would have hit with bug 171546 prior to r216726.

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::textUnderElement):

11:24 AM Changeset in webkit [216824] by Simon Fraser
  • 7 edits
    2 adds in trunk

event.clientX/clientY should be in layout viewport coordinates
https://bugs.webkit.org/show_bug.cgi?id=172018

Reviewed by Zalan Bujtas.
Source/WebCore:

Fix clientX and clientY on mouse events to be relative to the layout viewport, to match
getBoundingClientRect(), getClientRects() and fixed-position objects.

Also minor cleanup of MouseRelatedEvent to use initializers.

Test: fast/visual-viewport/client-coordinates-relative-to-layout-viewport.html

  • dom/MouseRelatedEvent.cpp:

(WebCore::MouseRelatedEvent::MouseRelatedEvent):
(WebCore::MouseRelatedEvent::init):
(WebCore::MouseRelatedEvent::initCoordinates):
(WebCore::contentsScrollOffset): Deleted.

  • dom/MouseRelatedEvent.h:

LayoutTests:

  • fast/events/clientXY-in-zoom-and-scroll.html:
  • fast/visual-viewport/client-coordinates-relative-to-layout-viewport-expected.txt: Added.
  • fast/visual-viewport/client-coordinates-relative-to-layout-viewport.html: Added.
  • platform/ios/TestExpectations:
  • platform/mac/fast/events/clientXY-in-zoom-and-scroll-expected.txt:
10:33 AM Changeset in webkit [216823] by Chris Dumez
  • 37 edits in trunk/Source/WebKit/win

Drop uses of PassRefPtr in WebKit/win
https://bugs.webkit.org/show_bug.cgi?id=172067

Reviewed by Yusuke Suzuki.

  • DOMEventsClasses.cpp:

(DOMEvent::DOMEvent):
(DOMEvent::createInstance):

  • DOMEventsClasses.h:

(DOMUIEvent::DOMUIEvent):
(DOMKeyboardEvent::DOMKeyboardEvent):
(DOMMouseEvent::DOMMouseEvent):
(DOMMutationEvent::DOMMutationEvent):
(DOMOverflowEvent::DOMOverflowEvent):
(DOMWheelEvent::DOMWheelEvent):

  • MemoryStream.cpp:

(MemoryStream::MemoryStream):
(MemoryStream::createInstance):

  • MemoryStream.h:
  • Plugins/PluginDatabase.cpp:

(WebCore::PluginDatabase::refresh):
(WebCore::PluginDatabase::add):
(WebCore::PluginDatabase::loadPersistentMetadataCache):

  • Plugins/PluginDatabase.h:
  • Plugins/PluginPackage.cpp:

(WebCore::PluginPackage::createPackage):
(WebCore::PluginPackage::createPackageFromCache):

  • Plugins/PluginPackage.h:
  • Plugins/PluginStream.h:

(WebCore::PluginStream::create):

  • WebActionPropertyBag.cpp:

(WebActionPropertyBag::WebActionPropertyBag):
(WebActionPropertyBag::createInstance):

  • WebActionPropertyBag.h:
  • WebArchive.cpp:

(WebArchive::createInstance):
(WebArchive::WebArchive):

  • WebArchive.h:
  • WebBackForwardList.cpp:

(WebBackForwardList::WebBackForwardList):
(WebBackForwardList::createInstance):

  • WebBackForwardList.h:
  • WebCoreSupport/EmbeddedWidget.cpp:

(EmbeddedWidget::create):

  • WebCoreSupport/EmbeddedWidget.h:
  • WebCoreSupport/WebChromeClient.h:
  • WebFrame.cpp:

(WebFrame::loadData):
(WebFrame::createSubframeWithOwnerElement):

  • WebFrame.h:
  • WebFramePolicyListener.cpp:

(WebFramePolicyListener::WebFramePolicyListener):
(WebFramePolicyListener::createInstance):

  • WebFramePolicyListener.h:
  • WebGeolocationPolicyListener.cpp:

(WebGeolocationPolicyListener::createInstance):
(WebGeolocationPolicyListener::WebGeolocationPolicyListener):

  • WebGeolocationPolicyListener.h:
  • WebHistoryItem.cpp:

(WebHistoryItem::WebHistoryItem):
(WebHistoryItem::createInstance):

  • WebHistoryItem.h:
  • WebMutableURLRequest.cpp:

(WebMutableURLRequest::setFormData):
(WebMutableURLRequest::formData):

  • WebMutableURLRequest.h:
  • WebResource.cpp:

(WebResource::createInstance):

  • WebResource.h:
  • WebScriptWorld.cpp:

(WebScriptWorld::WebScriptWorld):
(WebScriptWorld::createInstance):

  • WebScriptWorld.h:
  • WebURLAuthenticationChallengeSender.cpp:

(WebURLAuthenticationChallengeSender::WebURLAuthenticationChallengeSender):
(WebURLAuthenticationChallengeSender::createInstance):

  • WebURLAuthenticationChallengeSender.h:
  • WebView.cpp:

(WebView::setFullScreenElement):

  • WebView.h:

May 12, 2017:

11:51 PM Changeset in webkit [216822] by jmarcell@apple.com
  • 36 edits
    15 moves
    1 add
    1 delete in branches/safari-604.1.21-branch

Cherry-pick r216809. rdar://problem/32141005

11:51 PM Changeset in webkit [216821] by jmarcell@apple.com
  • 2 edits in branches/safari-604.1.21-branch/Source/WebCore

Cherry-pick r216792. rdar://problem/32084098

11:51 PM Changeset in webkit [216820] by jmarcell@apple.com
  • 2 edits in branches/safari-604.1.21-branch/Source/WebKit2

Cherry-pick r216774. rdar://problem/31587957

11:39 PM Changeset in webkit [216819] by commit-queue@webkit.org
  • 9 edits
    1 delete in trunk/Source/WebCore

[WebIDL] Remove need for custom binding for Worker constructor
https://bugs.webkit.org/show_bug.cgi?id=172050

Patch by Sam Weinig <sam@webkit.org> on 2017-05-12
Reviewed by Chris Dumez.

  • CMakeLists.txt:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSWorkerCustom.cpp: Removed.

Remove JSWorkerCustom.cpp

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateCallWith):

  • bindings/scripts/IDLAttributes.json:

Add RuntimeFlags as a new option for the ConstructorCallWith extended attribute.

  • workers/Worker.cpp:

(WebCore::Worker::create):

  • workers/Worker.h:

Update order of arguments to appease the generator.

  • workers/Worker.idl:

Add extended attributes for the constructor.

11:23 PM Changeset in webkit [216818] by jmarcell@apple.com
  • 8 edits
    2 adds in branches/safari-603-branch

Cherry-pick r216599. rdar://problem/32081484

10:41 PM Changeset in webkit [216817] by Simon Fraser
  • 21 edits in trunk

The rects returned by Element/Range.getClientRects() should not be rounded
https://bugs.webkit.org/show_bug.cgi?id=172057

Reviewed by Chris Dumez.

Source/WebCore:

Fix createDOMRectVector() to not expand the rects to integer boundaries (which
quad.enclosingBoundingBox() does), but to return rects with floating point
values. This matches Chrome and Firefox, and matches getBoundingClientRect(),
which does not integral snap.

  • dom/DOMRect.cpp:

(WebCore::createDOMRectVector):

LayoutTests:

Fix tests that were sensitive to rounding. I had to mark fast/text/multiglyph-characters.html
as failing (webkit.org/b/172056).

  • TestExpectations:
  • fast/dom/Document/CaretRangeFromPoint/caretRangeFromPoint-in-zoom-and-scroll.html:
  • fast/dom/Range/getClientRects-expected.txt:
  • fast/dom/Range/getClientRects.html:
  • fast/dom/Range/simple-line-layout-getclientrects-expected.html:
  • fast/dom/Range/simple-line-layout-getclientrects.html:
  • fast/visual-viewport/client-rects-relative-to-layout-viewport-expected.txt:
  • platform/ios/TestExpectations:
  • platform/ios/fast/multicol/client-rects-expected.txt:
  • platform/ios/fast/multicol/client-rects-spanners-complex-expected.txt:
  • platform/ios/fast/multicol/client-rects-spanners-expected.txt:
  • platform/ios/fast/multicol/newmulticol/client-rects-expected.txt:
  • platform/ios/fast/transforms/bounding-rect-zoom-expected.txt:
  • platform/mac/fast/multicol/client-rects-expected.txt:
  • platform/mac/fast/multicol/client-rects-spanners-complex-expected.txt:
  • platform/mac/fast/multicol/client-rects-spanners-expected.txt:
  • platform/mac/fast/multicol/newmulticol/client-rects-expected.txt:
  • platform/mac/fast/transforms/bounding-rect-zoom-expected.txt:
10:26 PM Changeset in webkit [216816] by Chris Dumez
  • 43 edits in trunk/Source/WebKit

Drop uses of PassRefPtr in WebKit/mac
https://bugs.webkit.org/show_bug.cgi?id=172066

Reviewed by Sam Weinig.

Source/WebKit/ios:

Build fix.

  • Misc/WebGeolocationProviderIOS.mm:

Source/WebKit/mac:

  • History/WebBackForwardListInternal.h:
  • History/WebHistoryItem.mm:

(kit):
(-[WebHistoryItem initWithWebCoreHistoryItem:]):

  • History/WebHistoryItemInternal.h:
  • Plugins/Hosted/HostedNetscapePluginStream.h:

(WebKit::HostedNetscapePluginStream::create):

  • Plugins/Hosted/NetscapePluginHostManager.h:
  • Plugins/Hosted/NetscapePluginHostManager.mm:

(WebKit::NetscapePluginHostManager::instantiatePlugin):

  • Plugins/Hosted/NetscapePluginInstanceProxy.h:
  • Plugins/Hosted/NetscapePluginInstanceProxy.mm:

(WebKit::NetscapePluginInstanceProxy::PluginRequest::create):
(WebKit::NetscapePluginInstanceProxy::create):
(WebKit::NetscapePluginInstanceProxy::setManualStream):

  • Plugins/Hosted/ProxyInstance.h:

(WebKit::ProxyInstance::create):

  • Plugins/Hosted/ProxyInstance.mm:

(WebKit::ProxyInstance::ProxyInstance):
(WebKit::ProxyInstance::newRuntimeObject):

  • Plugins/Hosted/ProxyRuntimeObject.h:

(WebKit::ProxyRuntimeObject::create):

  • Plugins/Hosted/ProxyRuntimeObject.mm:

(WebKit::ProxyRuntimeObject::ProxyRuntimeObject):

  • Plugins/Hosted/WebHostedNetscapePluginView.h:
  • Plugins/Hosted/WebHostedNetscapePluginView.mm:

(-[WebHostedNetscapePluginView initWithFrame:pluginPackage:URL:baseURL:MIMEType:attributeKeys:attributeValues:loadManually:element:]):

  • Plugins/WebBaseNetscapePluginView.h:
  • Plugins/WebBaseNetscapePluginView.mm:

(-[WebBaseNetscapePluginView initWithFrame:pluginPackage:URL:baseURL:MIMEType:attributeKeys:attributeValues:loadManually:element:]):

  • Plugins/WebNetscapePluginStream.h:

(WebNetscapePluginStream::create):

  • Plugins/WebNetscapePluginView.h:
  • Plugins/WebNetscapePluginView.mm:

(-[WebNetscapePluginView initWithFrame:pluginPackage:URL:baseURL:MIMEType:attributeKeys:attributeValues:loadManually:element:]):

  • WebCoreSupport/WebChromeClient.mm:
  • WebCoreSupport/WebEditorClient.mm:
  • WebCoreSupport/WebNotificationClient.mm:

(WebNotificationClient::requestPermission):
(-[WebNotificationPolicyListener initWithCallback:]):

  • WebCoreSupport/WebOpenPanelResultListener.mm:
  • WebCoreSupport/WebUserMediaClient.mm:

(WebUserMediaClient::requestUserMediaAccess):
(WebUserMediaClient::enumerateMediaDevices):
(-[WebUserMediaPolicyListener initWithUserMediaRequest:]):
(-[WebUserMediaPolicyCheckerListener initWithMediaDevicesEnumerationRequest:]):

  • WebView/WebArchive.mm:

(-[WebArchivePrivate initWithCoreArchive:]):
(-[WebArchivePrivate setCoreArchive:]):
(-[WebArchive initWithData:]):
(-[WebArchive subframeArchives]):
(-[WebArchive _initWithCoreLegacyWebArchive:]):

  • WebView/WebArchiveInternal.h:
  • WebView/WebDataSource.mm:

(WebDataSourcePrivate::WebDataSourcePrivate):
(WebDataSourcePrivate::~WebDataSourcePrivate):
(-[WebDataSource _initWithDocumentLoader:]):

  • WebView/WebDataSourceInternal.h:
  • WebView/WebDeviceOrientation.mm:

(-[WebDeviceOrientation initWithCoreDeviceOrientation:]):

  • WebView/WebDeviceOrientationInternal.h:
  • WebView/WebFrame.mm:

(-[WebFrame _convertToDOMRange:]):
(-[WebFrame _convertToDOMRange:rangeIsRelativeTo:]):

  • WebView/WebFrameInternal.h:
  • WebView/WebFullScreenController.h:
  • WebView/WebFullScreenController.mm:

(-[WebFullScreenController setElement:]):

  • WebView/WebGeolocationPosition.mm:

(-[WebGeolocationPositionInternal initWithCoreGeolocationPosition:]):
(-[WebGeolocationPosition initWithGeolocationPosition:]):

  • WebView/WebHTMLView.mm:

(currentKeyboardEvent):

  • WebView/WebResource.mm:
  • WebView/WebScriptWorld.mm:

(-[WebScriptWorld initWithWorld:]):
(+[WebScriptWorld standardWorld]):
(+[WebScriptWorld findOrCreateWorld:]):

  • WebView/WebViewData.h:

(LayerFlushController::create):

9:59 PM Changeset in webkit [216815] by ggaren@apple.com
  • 14 edits
    3 deletes in trunk/Source/JavaScriptCore

[JSC] DFG::Node should not have its own allocator
https://bugs.webkit.org/show_bug.cgi?id=160098

Reviewed by Saam Barati.

I just rebased the patch from <http://trac.webkit.org/changeset/203808>.

I ran Octane and JetStream locally on a MacBook Air and I wasn't able to
reproduce a regression. Let's land this again and see what the bots say.

(JSC::B3::SparseCollection::packIndices):

  • dfg/DFGAllocator.h: Removed.
  • dfg/DFGDriver.cpp:

(JSC::DFG::compileImpl):

  • dfg/DFGGraph.cpp:

(JSC::DFG::Graph::Graph):
(JSC::DFG::Graph::~Graph):
(JSC::DFG::Graph::deleteNode):
(JSC::DFG::Graph::packNodeIndices):
(JSC::DFG::Graph::addNodeToMapByIndex): Deleted.

  • dfg/DFGGraph.h:

(JSC::DFG::Graph::addNode):
(JSC::DFG::Graph::maxNodeCount):
(JSC::DFG::Graph::nodeAt):

  • dfg/DFGLongLivedState.cpp: Removed.
  • dfg/DFGLongLivedState.h: Removed.
  • dfg/DFGNode.h:
  • dfg/DFGNodeAllocator.h:
  • dfg/DFGPlan.cpp:

(JSC::DFG::Plan::compileInThread):
(JSC::DFG::Plan::compileInThreadImpl):

  • dfg/DFGPlan.h:
  • dfg/DFGWorklist.cpp:
  • runtime/VM.cpp:

(JSC::VM::VM):

  • runtime/VM.h:
8:09 PM Changeset in webkit [216814] by jmarcell@apple.com
  • 3 edits
    2 adds in branches/safari-603-branch

Cherry-pick r216307. rdar://problem/32119568

8:03 PM Changeset in webkit [216813] by jiewen_tan@apple.com
  • 3 edits
    2 adds in trunk

Elements should be inserted into a template element as its content's last child
https://bugs.webkit.org/show_bug.cgi?id=171373
<rdar://problem/31862949>

Reviewed by Ryosuke Niwa.

Source/WebCore:

Before this change, our HTML parser obeys the following premises:
1) A fostering child whose parent is a table should be inserted before its parent and under its grandparent.
2) When inserting into a template element, an element should be inserted into its content.

Let's walk through the example:
a) Before eventhandler takes place
template
table

svg <- parser

b) After eventhandler takes place
template

table

svg <- parser

c) after parsing svg
template

content

svg
(table)

table

Finally, in the example, the svg element will be inserted into the content of the template element while
having its next sibling point to the table element. However, the table element is actually under the
template element not its content.

This messy tree is constructed because the second premise is incompleted. It should be: When inserting into
a template element, an element should be inserted into its content as its last child.
Quoted from Step 3 of https://html.spec.whatwg.org/multipage/syntax.html#appropriate-place-for-inserting-a-node
A correct tree will then looks like:
template

content

svg

table

Tests: fast/dom/HTMLTemplateElement/insert-fostering-child-crash.html

fast/dom/HTMLTemplateElement/insert-fostering-child.html

  • html/parser/HTMLConstructionSite.cpp:

(WebCore::insert):
By nullifying task.nextChild, it will force the parser to append the element as task.parent's last child.

LayoutTests:

  • fast/dom/HTMLTemplateElement/insert-fostering-child-expected.txt: Added.
  • fast/dom/HTMLTemplateElement/insert-fostering-child.html: Added.
7:05 PM Changeset in webkit [216812] by jmarcell@apple.com
  • 7 edits in branches/safari-604.1.21-branch/Source

Versioning.

7:02 PM Changeset in webkit [216811] by rniwa@webkit.org
  • 699 adds in trunk/Websites/browserbench.org

Add Websites/browserbench.org
https://bugs.webkit.org/show_bug.cgi?id=172049

Rubber-stamped by Geoffrey Garen.

Added the current contents of browserbench.org.

  • ARES-6/ARES-6.svg: Added.
  • ARES-6/Air/README.md: Added.
  • ARES-6/Air/airjs-tests.yaml: Added.
  • ARES-6/Air/all.js: Added.
  • ARES-6/Air/allocate_stack.js: Added.
  • ARES-6/Air/arg.js: Added.
  • ARES-6/Air/basic_block.js: Added.
  • ARES-6/Air/benchmark.js: Added.
  • ARES-6/Air/code.js: Added.
  • ARES-6/Air/custom.js: Added.
  • ARES-6/Air/frequented_block.js: Added.
  • ARES-6/Air/insertion_set.js: Added.
  • ARES-6/Air/inst.js: Added.
  • ARES-6/Air/liveness.js: Added.
  • ARES-6/Air/make_dist.sh: Added.
  • ARES-6/Air/opcode.js: Added.
  • ARES-6/Air/payload-airjs-ACLj8C.js: Added.
  • ARES-6/Air/payload-gbemu-executeIteration.js: Added.
  • ARES-6/Air/payload-imaging-gaussian-blur-gaussianBlur.js: Added.
  • ARES-6/Air/payload-typescript-scanIdentifier.js: Added.
  • ARES-6/Air/reg.js: Added.
  • ARES-6/Air/stack_slot.js: Added.
  • ARES-6/Air/stress-test.js: Added.
  • ARES-6/Air/strip-hash.rb: Added.
  • ARES-6/Air/symbols.js: Added.
  • ARES-6/Air/test.html: Added.
  • ARES-6/Air/test.js: Added.
  • ARES-6/Air/tmp.js: Added.
  • ARES-6/Air/tmp_base.js: Added.
  • ARES-6/Air/util.js: Added.
  • ARES-6/Babylon/AUTHORS: Added.
  • ARES-6/Babylon/air-blob.js: Added.
  • ARES-6/Babylon/babylon-blob.js: Added.
  • ARES-6/Babylon/basic-blob.js: Added.
  • ARES-6/Babylon/benchmark.js: Added.
  • ARES-6/Babylon/index.js: Added.
  • ARES-6/Babylon/inspector-blob.js: Added.
  • ARES-6/Basic/ast.js: Added.
  • ARES-6/Basic/basic-tests.yaml: Added.
  • ARES-6/Basic/basic.js: Added.
  • ARES-6/Basic/benchmark.js: Added.
  • ARES-6/Basic/caseless_map.js: Added.
  • ARES-6/Basic/lexer.js: Added.
  • ARES-6/Basic/number.js: Added.
  • ARES-6/Basic/parser.js: Added.
  • ARES-6/Basic/random.js: Added.
  • ARES-6/Basic/state.js: Added.
  • ARES-6/Basic/stress-test.js: Added.
  • ARES-6/Basic/test.html: Added.
  • ARES-6/Basic/test.js: Added.
  • ARES-6/Basic/util.js: Added.
  • ARES-6/about.html: Added.
  • ARES-6/air_benchmark.js: Added.
  • ARES-6/babylon_benchmark.js: Added.
  • ARES-6/basic_benchmark.js: Added.
  • ARES-6/cli.js: Added.
  • ARES-6/driver.js: Added.
  • ARES-6/glue.js: Added.
  • ARES-6/index.html: Added.
  • ARES-6/ml/benchmark.js: Added.
  • ARES-6/ml/index.js: Added.
  • ARES-6/ml_benchmark.js: Added.
  • ARES-6/results.js: Added.
  • ARES-6/stats.js: Added.
  • ARES-6/styles.css: Added.
  • ARES-6/swoop.svg: Added.
  • JetStream/CDjsSetup.js: Added.
  • JetStream/JetStream-Logo.png: Added.
  • JetStream/JetStream-Logo@2x.png: Added.
  • JetStream/JetStream.css: Added.
  • JetStream/JetStreamDriver.js: Added.
  • JetStream/LLVM-test-suite-LICENSE.txt: Added.
  • JetStream/Octane/base.js: Added.
  • JetStream/Octane/code-load.js: Added.
  • JetStream/Octane2/base.js: Added.
  • JetStream/Octane2/box2d.js: Added.
  • JetStream/Octane2/code-load.js: Added.
  • JetStream/Octane2/crypto.js: Added.
  • JetStream/Octane2/deltablue.js: Added.
  • JetStream/Octane2/earley-boyer.js: Added.
  • JetStream/Octane2/gbemu-part1.js: Added.
  • JetStream/Octane2/gbemu-part2.js: Added.
  • JetStream/Octane2/mandreel.js: Added.
  • JetStream/Octane2/navier-stokes.js: Added.
  • JetStream/Octane2/pdfjs.js: Added.
  • JetStream/Octane2/raytrace.js: Added.
  • JetStream/Octane2/regexp.js: Added.
  • JetStream/Octane2/richards.js: Added.
  • JetStream/Octane2/run.js: Added.
  • JetStream/Octane2/splay.js: Added.
  • JetStream/Octane2/typescript-compiler.js: Added.
  • JetStream/Octane2/typescript-input.js: Added.
  • JetStream/Octane2/typescript.js: Added.
  • JetStream/Octane2/zlib-data.js: Added.
  • JetStream/Octane2/zlib.js: Added.
  • JetStream/Octane2Setup.js: Added.
  • JetStream/OctaneSetup.js: Added.
  • JetStream/Reference.js: Added.
  • JetStream/SimplePayload.js: Added.
  • JetStream/SimpleSetup.js: Added.
  • JetStream/SunSpiderPayload.js: Added.
  • JetStream/SunSpiderSetup.js: Added.
  • JetStream/Swoosh.png: Added.
  • JetStream/Swoosh@2x.png: Added.
  • JetStream/TestingSetup.js: Added.
  • JetStream/cdjs/benchmark.js: Added.
  • JetStream/cdjs/call_sign.js: Added.
  • JetStream/cdjs/collision.js: Added.
  • JetStream/cdjs/collision_detector.js: Added.
  • JetStream/cdjs/constants.js: Added.
  • JetStream/cdjs/motion.js: Added.
  • JetStream/cdjs/red_black_tree.js: Added.
  • JetStream/cdjs/reduce_collision_set.js: Added.
  • JetStream/cdjs/simulator.js: Added.
  • JetStream/cdjs/util.js: Added.
  • JetStream/cdjs/vector_2d.js: Added.
  • JetStream/cdjs/vector_3d.js: Added.
  • JetStream/in-depth.html: Added.
  • JetStream/index.html: Added.
  • JetStream/simple/bigfib.cpp: Added.
  • JetStream/simple/bigfib.cpp.js: Added.
  • JetStream/simple/container.cpp: Added.
  • JetStream/simple/container.cpp.js: Added.
  • JetStream/simple/dry.c: Added.
  • JetStream/simple/dry.c.js: Added.
  • JetStream/simple/float-mm.c: Added.
  • JetStream/simple/float-mm.c.js: Added.
  • JetStream/simple/gcc-loops.cpp: Added.
  • JetStream/simple/gcc-loops.cpp.js: Added.
  • JetStream/simple/hash-map.js: Added.
  • JetStream/simple/n-body.c: Added.
  • JetStream/simple/n-body.c.js: Added.
  • JetStream/simple/quicksort.c: Added.
  • JetStream/simple/quicksort.c.js: Added.
  • JetStream/simple/towers.c: Added.
  • JetStream/simple/towers.c.js: Added.
  • JetStream/sources/3d-cube.js: Added.
  • JetStream/sources/3d-raytrace.js: Added.
  • JetStream/sources/base64.js: Added.
  • JetStream/sources/bigfib.cpp: Added.
  • JetStream/sources/bigfib.cpp.js: Added.
  • JetStream/sources/box2d.js: Added.
  • JetStream/sources/cdjs-benchmark.js: Added.
  • JetStream/sources/cdjs-call_sign.js: Added.
  • JetStream/sources/cdjs-collision.js: Added.
  • JetStream/sources/cdjs-collision_detector.js: Added.
  • JetStream/sources/cdjs-constants.js: Added.
  • JetStream/sources/cdjs-motion.js: Added.
  • JetStream/sources/cdjs-red_black_tree.js: Added.
  • JetStream/sources/cdjs-reduce_collision_set.js: Added.
  • JetStream/sources/cdjs-simulator.js: Added.
  • JetStream/sources/cdjs-util.js: Added.
  • JetStream/sources/cdjs-vector_2d.js: Added.
  • JetStream/sources/cdjs-vector_3d.js: Added.
  • JetStream/sources/code-first-load-code-load.js: Added.
  • JetStream/sources/code-multi-load-code-load.js: Added.
  • JetStream/sources/container.cpp: Added.
  • JetStream/sources/container.cpp.js: Added.
  • JetStream/sources/crypto-aes.js: Added.
  • JetStream/sources/crypto-md5.js: Added.
  • JetStream/sources/crypto-sha1.js: Added.
  • JetStream/sources/crypto.js: Added.
  • JetStream/sources/date-format-tofte.js: Added.
  • JetStream/sources/date-format-xparb.js: Added.
  • JetStream/sources/deltablue.js: Added.
  • JetStream/sources/dry.c: Added.
  • JetStream/sources/dry.c.js: Added.
  • JetStream/sources/earley-boyer.js: Added.
  • JetStream/sources/float-mm.c: Added.
  • JetStream/sources/float-mm.c.js: Added.
  • JetStream/sources/gbemu-part1.js: Added.
  • JetStream/sources/gbemu-part2.js: Added.
  • JetStream/sources/gcc-loops.cpp: Added.
  • JetStream/sources/gcc-loops.cpp.js: Added.
  • JetStream/sources/hash-map.js: Added.
  • JetStream/sources/mandreel.js: Added.
  • JetStream/sources/n-body.c: Added.
  • JetStream/sources/n-body.c.js: Added.
  • JetStream/sources/n-body.js: Added.
  • JetStream/sources/navier-stokes.js: Added.
  • JetStream/sources/pdfjs.js: Added.
  • JetStream/sources/quicksort.c: Added.
  • JetStream/sources/quicksort.c.js: Added.
  • JetStream/sources/raytrace.js: Added.
  • JetStream/sources/regex-dna.js: Added.
  • JetStream/sources/regexp.js: Added.
  • JetStream/sources/richards.js: Added.
  • JetStream/sources/splay.js: Added.
  • JetStream/sources/tagcloud.js: Added.
  • JetStream/sources/towers.c: Added.
  • JetStream/sources/towers.c.js: Added.
  • JetStream/sources/typescript-compiler.js: Added.
  • JetStream/sources/typescript-input.js: Added.
  • JetStream/sources/typescript.js: Added.
  • JetStream/sources/zlib-data.js: Added.
  • JetStream/sources/zlib.js: Added.
  • JetStream/sunspider/3d-cube.js: Added.
  • JetStream/sunspider/3d-raytrace.js: Added.
  • JetStream/sunspider/base64.js: Added.
  • JetStream/sunspider/crypto-aes.js: Added.
  • JetStream/sunspider/crypto-md5.js: Added.
  • JetStream/sunspider/crypto-sha1.js: Added.
  • JetStream/sunspider/date-format-tofte.js: Added.
  • JetStream/sunspider/date-format-xparb.js: Added.
  • JetStream/sunspider/n-body.js: Added.
  • JetStream/sunspider/regex-dna.js: Added.
  • JetStream/sunspider/tagcloud.js: Added.
  • MotionMark/about.html: Added.
  • MotionMark/developer.html: Added.
  • MotionMark/index.html: Added.
  • MotionMark/resources/debug-runner/animometer.css: Added.
  • MotionMark/resources/debug-runner/animometer.js: Added.
  • MotionMark/resources/debug-runner/d3.min.js: Added.
  • MotionMark/resources/debug-runner/graph.js: Added.
  • MotionMark/resources/debug-runner/tests.js: Added.
  • MotionMark/resources/extensions.js: Added.
  • MotionMark/resources/runner/animometer.css: Added.
  • MotionMark/resources/runner/animometer.js: Added.
  • MotionMark/resources/runner/benchmark-runner.js: Added.
  • MotionMark/resources/runner/crystal.svg: Added.
  • MotionMark/resources/runner/lines.svg: Added.
  • MotionMark/resources/runner/logo.svg: Added.
  • MotionMark/resources/runner/tests.js: Added.
  • MotionMark/resources/statistics.js: Added.
  • MotionMark/resources/strings.js: Added.
  • MotionMark/tests/3d/resources/webgl.js: Added.
  • MotionMark/tests/3d/webgl.html: Added.
  • MotionMark/tests/bouncing-particles/bouncing-canvas-images.html: Added.
  • MotionMark/tests/bouncing-particles/bouncing-canvas-shapes.html: Added.
  • MotionMark/tests/bouncing-particles/bouncing-css-images.html: Added.
  • MotionMark/tests/bouncing-particles/bouncing-css-shapes.html: Added.
  • MotionMark/tests/bouncing-particles/bouncing-svg-images.html: Added.
  • MotionMark/tests/bouncing-particles/bouncing-svg-shapes.html: Added.
  • MotionMark/tests/bouncing-particles/bouncing-tagged-images.html: Added.
  • MotionMark/tests/bouncing-particles/resources/bouncing-canvas-images.js: Added.
  • MotionMark/tests/bouncing-particles/resources/bouncing-canvas-particles.js: Added.
  • MotionMark/tests/bouncing-particles/resources/bouncing-canvas-shapes.js: Added.
  • MotionMark/tests/bouncing-particles/resources/bouncing-css-images.js: Added.
  • MotionMark/tests/bouncing-particles/resources/bouncing-css-shapes.js: Added.
  • MotionMark/tests/bouncing-particles/resources/bouncing-particles.js: Added.
  • MotionMark/tests/bouncing-particles/resources/bouncing-svg-images.js: Added.
  • MotionMark/tests/bouncing-particles/resources/bouncing-svg-particles.js: Added.
  • MotionMark/tests/bouncing-particles/resources/bouncing-svg-shapes.js: Added.
  • MotionMark/tests/bouncing-particles/resources/bouncing-tagged-images.js: Added.
  • MotionMark/tests/bouncing-particles/resources/image1.jpg: Added.
  • MotionMark/tests/bouncing-particles/resources/image2.jpg: Added.
  • MotionMark/tests/bouncing-particles/resources/image3.jpg: Added.
  • MotionMark/tests/bouncing-particles/resources/image4.jpg: Added.
  • MotionMark/tests/bouncing-particles/resources/image5.jpg: Added.
  • MotionMark/tests/dom/compositing-transforms.html: Added.
  • MotionMark/tests/dom/focus.html: Added.
  • MotionMark/tests/dom/leaves.html: Added.
  • MotionMark/tests/dom/particles.html: Added.
  • MotionMark/tests/dom/resources/compositing-transforms.js: Added.
  • MotionMark/tests/dom/resources/dom-particles.js: Added.
  • MotionMark/tests/dom/resources/focus.js: Added.
  • MotionMark/tests/dom/resources/leaves.js: Added.
  • MotionMark/tests/master/canvas-stage.html: Added.
  • MotionMark/tests/master/focus.html: Added.
  • MotionMark/tests/master/image-data.html: Added.
  • MotionMark/tests/master/leaves.html: Added.
  • MotionMark/tests/master/multiply.html: Added.
  • MotionMark/tests/master/resources/canvas-stage.js: Added.
  • MotionMark/tests/master/resources/canvas-tests.js: Added.
  • MotionMark/tests/master/resources/compass.svg: Added.
  • MotionMark/tests/master/resources/compass100.png: Added.
  • MotionMark/tests/master/resources/console.svg: Added.
  • MotionMark/tests/master/resources/console100.png: Added.
  • MotionMark/tests/master/resources/contribute.svg: Added.
  • MotionMark/tests/master/resources/contribute100.png: Added.
  • MotionMark/tests/master/resources/debugger.svg: Added.
  • MotionMark/tests/master/resources/debugger100.png: Added.
  • MotionMark/tests/master/resources/focus.js: Added.
  • MotionMark/tests/master/resources/image-data.js: Added.
  • MotionMark/tests/master/resources/inspector.svg: Added.
  • MotionMark/tests/master/resources/inspector100.png: Added.
  • MotionMark/tests/master/resources/layout.svg: Added.
  • MotionMark/tests/master/resources/layout100.png: Added.
  • MotionMark/tests/master/resources/leaves.js: Added.
  • MotionMark/tests/master/resources/multiply.js: Added.
  • MotionMark/tests/master/resources/particles.js: Added.
  • MotionMark/tests/master/resources/performance.svg: Added.
  • MotionMark/tests/master/resources/performance100.png: Added.
  • MotionMark/tests/master/resources/script.svg: Added.
  • MotionMark/tests/master/resources/script100.png: Added.
  • MotionMark/tests/master/resources/shortcuts.svg: Added.
  • MotionMark/tests/master/resources/shortcuts100.png: Added.
  • MotionMark/tests/master/resources/standards.svg: Added.
  • MotionMark/tests/master/resources/standards100.png: Added.
  • MotionMark/tests/master/resources/storage.svg: Added.
  • MotionMark/tests/master/resources/storage100.png: Added.
  • MotionMark/tests/master/resources/styles.svg: Added.
  • MotionMark/tests/master/resources/styles100.png: Added.
  • MotionMark/tests/master/resources/svg-particles.js: Added.
  • MotionMark/tests/master/resources/text.js: Added.
  • MotionMark/tests/master/resources/timeline.svg: Added.
  • MotionMark/tests/master/resources/timeline100.png: Added.
  • MotionMark/tests/master/svg-particles.html: Added.
  • MotionMark/tests/master/text.html: Added.
  • MotionMark/tests/resources/main.js: Added.
  • MotionMark/tests/resources/math.js: Added.
  • MotionMark/tests/resources/stage.css: Added.
  • MotionMark/tests/resources/star.svg: Added.
  • MotionMark/tests/resources/yin-yang.png: Added.
  • MotionMark/tests/resources/yin-yang.svg: Added.
  • MotionMark/tests/simple/resources/simple-canvas-paths.js: Added.
  • MotionMark/tests/simple/resources/simple-canvas.js: Added.
  • MotionMark/tests/simple/resources/tiled-canvas-image.js: Added.
  • MotionMark/tests/simple/simple-canvas-paths.html: Added.
  • MotionMark/tests/simple/tiled-canvas-image.html: Added.
  • MotionMark/tests/template/resources/template-canvas.js: Added.
  • MotionMark/tests/template/resources/template-css.js: Added.
  • MotionMark/tests/template/resources/template-svg.js: Added.
  • MotionMark/tests/template/template-canvas.html: Added.
  • MotionMark/tests/template/template-css.html: Added.
  • MotionMark/tests/template/template-svg.html: Added.
  • MotionMark/version: Added.
  • Speedometer/Full.html: Added.
  • Speedometer/InteractiveRunner.html: Added.
  • Speedometer/resources/benchmark-report.js: Added.
  • Speedometer/resources/benchmark-runner.js: Added.
  • Speedometer/resources/flightjs-example-app/LICENSE.md: Added.
  • Speedometer/resources/flightjs-example-app/README.md: Added.
  • Speedometer/resources/flightjs-example-app/app/boot/page.js: Added.
  • Speedometer/resources/flightjs-example-app/app/component_data/compose_box.js: Added.
  • Speedometer/resources/flightjs-example-app/app/component_data/mail_items.js: Added.
  • Speedometer/resources/flightjs-example-app/app/component_data/move_to.js: Added.
  • Speedometer/resources/flightjs-example-app/app/component_ui/compose_box.js: Added.
  • Speedometer/resources/flightjs-example-app/app/component_ui/folders.js: Added.
  • Speedometer/resources/flightjs-example-app/app/component_ui/mail_controls.js: Added.
  • Speedometer/resources/flightjs-example-app/app/component_ui/mail_items.js: Added.
  • Speedometer/resources/flightjs-example-app/app/component_ui/move_to_selector.js: Added.
  • Speedometer/resources/flightjs-example-app/app/component_ui/with_select.js: Added.
  • Speedometer/resources/flightjs-example-app/app/css/custom.css: Added.
  • Speedometer/resources/flightjs-example-app/app/data.js: Added.
  • Speedometer/resources/flightjs-example-app/app/templates.js: Added.
  • Speedometer/resources/flightjs-example-app/components/bootstrap/css/bootstrap-responsive.css: Added.
  • Speedometer/resources/flightjs-example-app/components/bootstrap/css/bootstrap-responsive.min.css: Added.
  • Speedometer/resources/flightjs-example-app/components/bootstrap/css/bootstrap.css: Added.
  • Speedometer/resources/flightjs-example-app/components/bootstrap/css/bootstrap.min.css: Added.
  • Speedometer/resources/flightjs-example-app/components/bootstrap/img/glyphicons-halflings-white.png: Added.
  • Speedometer/resources/flightjs-example-app/components/bootstrap/img/glyphicons-halflings.png: Added.
  • Speedometer/resources/flightjs-example-app/components/bootstrap/js/bootstrap.js: Added.
  • Speedometer/resources/flightjs-example-app/components/bootstrap/js/bootstrap.min.js: Added.
  • Speedometer/resources/flightjs-example-app/components/es5-shim/.gitignore: Added.
  • Speedometer/resources/flightjs-example-app/components/es5-shim/CHANGES: Added.
  • Speedometer/resources/flightjs-example-app/components/es5-shim/CONTRIBUTORS.md: Added.
  • Speedometer/resources/flightjs-example-app/components/es5-shim/LICENSE: Added.
  • Speedometer/resources/flightjs-example-app/components/es5-shim/README.md: Added.
  • Speedometer/resources/flightjs-example-app/components/es5-shim/component.json: Added.
  • Speedometer/resources/flightjs-example-app/components/es5-shim/es5-sham.js: Added.
  • Speedometer/resources/flightjs-example-app/components/es5-shim/es5-sham.min.js: Added.
  • Speedometer/resources/flightjs-example-app/components/es5-shim/es5-shim.js: Added.
  • Speedometer/resources/flightjs-example-app/components/es5-shim/es5-shim.min.js: Added.
  • Speedometer/resources/flightjs-example-app/components/es5-shim/package.json: Added.
  • Speedometer/resources/flightjs-example-app/components/es5-shim/tests/helpers/h-kill.js: Added.
  • Speedometer/resources/flightjs-example-app/components/es5-shim/tests/helpers/h-matchers.js: Added.
  • Speedometer/resources/flightjs-example-app/components/es5-shim/tests/helpers/h.js: Added.
  • Speedometer/resources/flightjs-example-app/components/es5-shim/tests/index.html: Added.
  • Speedometer/resources/flightjs-example-app/components/es5-shim/tests/lib/jasmine-html.js: Added.
  • Speedometer/resources/flightjs-example-app/components/es5-shim/tests/lib/jasmine.css: Added.
  • Speedometer/resources/flightjs-example-app/components/es5-shim/tests/lib/jasmine.js: Added.
  • Speedometer/resources/flightjs-example-app/components/es5-shim/tests/lib/jasmine_favicon.png: Added.
  • Speedometer/resources/flightjs-example-app/components/es5-shim/tests/lib/json2.js: Added.
  • Speedometer/resources/flightjs-example-app/components/es5-shim/tests/spec/s-array.js: Added.
  • Speedometer/resources/flightjs-example-app/components/es5-shim/tests/spec/s-date.js: Added.
  • Speedometer/resources/flightjs-example-app/components/es5-shim/tests/spec/s-function.js: Added.
  • Speedometer/resources/flightjs-example-app/components/es5-shim/tests/spec/s-object.js: Added.
  • Speedometer/resources/flightjs-example-app/components/es5-shim/tests/spec/s-string.js: Added.
  • Speedometer/resources/flightjs-example-app/components/flight/.travis.yml: Added.
  • Speedometer/resources/flightjs-example-app/components/flight/lib/advice.js: Added.
  • Speedometer/resources/flightjs-example-app/components/flight/lib/component.js: Added.
  • Speedometer/resources/flightjs-example-app/components/flight/lib/compose.js: Added.
  • Speedometer/resources/flightjs-example-app/components/flight/lib/index.js: Added.
  • Speedometer/resources/flightjs-example-app/components/flight/lib/logger.js: Added.
  • Speedometer/resources/flightjs-example-app/components/flight/lib/registry.js: Added.
  • Speedometer/resources/flightjs-example-app/components/flight/lib/utils.js: Added.
  • Speedometer/resources/flightjs-example-app/components/flight/tools/debug/debug.js: Added.
  • Speedometer/resources/flightjs-example-app/components/jasmine-flight/LICENSE.md: Added.
  • Speedometer/resources/flightjs-example-app/components/jasmine-flight/README.md: Added.
  • Speedometer/resources/flightjs-example-app/components/jasmine-flight/bower.json: Added.
  • Speedometer/resources/flightjs-example-app/components/jasmine-flight/lib/jasmine-flight.js: Added.
  • Speedometer/resources/flightjs-example-app/components/jasmine-jquery/lib/jasmine-jquery.js: Added.
  • Speedometer/resources/flightjs-example-app/components/jquery/component.json: Added.
  • Speedometer/resources/flightjs-example-app/components/jquery/composer.json: Added.
  • Speedometer/resources/flightjs-example-app/components/jquery/jquery.js: Added.
  • Speedometer/resources/flightjs-example-app/components/jquery/jquery.min.js: Added.
  • Speedometer/resources/flightjs-example-app/components/mustache/mustache.js: Added.
  • Speedometer/resources/flightjs-example-app/components/requirejs/require.js: Added.
  • Speedometer/resources/flightjs-example-app/index.html: Added.
  • Speedometer/resources/flightjs-example-app/karma.conf.js: Added.
  • Speedometer/resources/flightjs-example-app/package.json: Added.
  • Speedometer/resources/flightjs-example-app/requireMain.js: Added.
  • Speedometer/resources/gauge.png: Added.
  • Speedometer/resources/gauge@2x.png: Added.
  • Speedometer/resources/logo.png: Added.
  • Speedometer/resources/logo@2x.png: Added.
  • Speedometer/resources/main.css: Added.
  • Speedometer/resources/main.js: Added.
  • Speedometer/resources/statistics.js: Added.
  • Speedometer/resources/tests.js: Added.
  • Speedometer/resources/todomvc/architecture-examples/angularjs/bower.json: Added.
  • Speedometer/resources/todomvc/architecture-examples/angularjs/bower_components/angular-mocks/angular-mocks.js: Added.
  • Speedometer/resources/todomvc/architecture-examples/angularjs/bower_components/angular/angular.js: Added.
  • Speedometer/resources/todomvc/architecture-examples/angularjs/bower_components/todomvc-common/base.css: Added.
  • Speedometer/resources/todomvc/architecture-examples/angularjs/bower_components/todomvc-common/base.js: Added.
  • Speedometer/resources/todomvc/architecture-examples/angularjs/bower_components/todomvc-common/bg.png: Added.
  • Speedometer/resources/todomvc/architecture-examples/angularjs/index.html: Added.
  • Speedometer/resources/todomvc/architecture-examples/angularjs/js/app.js: Added.
  • Speedometer/resources/todomvc/architecture-examples/angularjs/js/controllers/todoCtrl.js: Added.
  • Speedometer/resources/todomvc/architecture-examples/angularjs/js/directives/todoBlur.js: Added.
  • Speedometer/resources/todomvc/architecture-examples/angularjs/js/directives/todoEscape.js: Added.
  • Speedometer/resources/todomvc/architecture-examples/angularjs/js/directives/todoFocus.js: Added.
  • Speedometer/resources/todomvc/architecture-examples/angularjs/js/services/todoStorage.js: Added.
  • Speedometer/resources/todomvc/architecture-examples/angularjs/readme.md: Added.
  • Speedometer/resources/todomvc/architecture-examples/angularjs/test/config/testacular.conf.js: Added.
  • Speedometer/resources/todomvc/architecture-examples/angularjs/test/package.json: Added.
  • Speedometer/resources/todomvc/architecture-examples/angularjs/test/readme.md: Added.
  • Speedometer/resources/todomvc/architecture-examples/angularjs/test/unit/directivesSpec.js: Added.
  • Speedometer/resources/todomvc/architecture-examples/angularjs/test/unit/todoCtrlSpec.js: Added.
  • Speedometer/resources/todomvc/architecture-examples/backbone/bower.json: Added.
  • Speedometer/resources/todomvc/architecture-examples/backbone/bower_components/backbone.localStorage/backbone.localStorage.js: Added.
  • Speedometer/resources/todomvc/architecture-examples/backbone/bower_components/backbone/backbone.js: Added.
  • Speedometer/resources/todomvc/architecture-examples/backbone/bower_components/jquery/jquery.js: Added.
  • Speedometer/resources/todomvc/architecture-examples/backbone/bower_components/todomvc-common/base.css: Added.
  • Speedometer/resources/todomvc/architecture-examples/backbone/bower_components/todomvc-common/base.js: Added.
  • Speedometer/resources/todomvc/architecture-examples/backbone/bower_components/todomvc-common/bg.png: Added.
  • Speedometer/resources/todomvc/architecture-examples/backbone/bower_components/underscore/underscore.js: Added.
  • Speedometer/resources/todomvc/architecture-examples/backbone/index.html: Added.
  • Speedometer/resources/todomvc/architecture-examples/backbone/js/app.js: Added.
  • Speedometer/resources/todomvc/architecture-examples/backbone/js/collections/todos.js: Added.
  • Speedometer/resources/todomvc/architecture-examples/backbone/js/models/todo.js: Added.
  • Speedometer/resources/todomvc/architecture-examples/backbone/js/routers/router.js: Added.
  • Speedometer/resources/todomvc/architecture-examples/backbone/js/views/app-view.js: Added.
  • Speedometer/resources/todomvc/architecture-examples/backbone/js/views/todo-view.js: Added.
  • Speedometer/resources/todomvc/architecture-examples/backbone/readme.md: Added.
  • Speedometer/resources/todomvc/architecture-examples/emberjs/bower.json: Added.
  • Speedometer/resources/todomvc/architecture-examples/emberjs/bower_components/ember-data/ember-data.js: Added.
  • Speedometer/resources/todomvc/architecture-examples/emberjs/bower_components/ember-localstorage-adapter/localstorage_adapter.js: Added.
  • Speedometer/resources/todomvc/architecture-examples/emberjs/bower_components/ember/ember.js: Added.
  • Speedometer/resources/todomvc/architecture-examples/emberjs/bower_components/handlebars/handlebars.js: Added.
  • Speedometer/resources/todomvc/architecture-examples/emberjs/bower_components/jquery/jquery.js: Added.
  • Speedometer/resources/todomvc/architecture-examples/emberjs/bower_components/todomvc-common/base.css: Added.
  • Speedometer/resources/todomvc/architecture-examples/emberjs/bower_components/todomvc-common/base.js: Added.
  • Speedometer/resources/todomvc/architecture-examples/emberjs/bower_components/todomvc-common/bg.png: Added.
  • Speedometer/resources/todomvc/architecture-examples/emberjs/index.html: Added.
  • Speedometer/resources/todomvc/architecture-examples/emberjs/js/app.js: Added.
  • Speedometer/resources/todomvc/architecture-examples/emberjs/js/controllers/todo_controller.js: Added.
  • Speedometer/resources/todomvc/architecture-examples/emberjs/js/controllers/todos_controller.js: Added.
  • Speedometer/resources/todomvc/architecture-examples/emberjs/js/helpers/pluralize.js: Added.
  • Speedometer/resources/todomvc/architecture-examples/emberjs/js/models/todo.js: Added.
  • Speedometer/resources/todomvc/architecture-examples/emberjs/js/router.js: Added.
  • Speedometer/resources/todomvc/architecture-examples/emberjs/js/views/edit_todo_view.js: Added.
  • Speedometer/resources/todomvc/architecture-examples/emberjs/js/views/todos_view.js: Added.
  • Speedometer/resources/todomvc/architecture-examples/emberjs/readme.md: Added.
  • Speedometer/resources/todomvc/architecture-examples/emberjs/test.html: Added.
  • Speedometer/resources/todomvc/architecture-examples/jquery/bower.json: Added.
  • Speedometer/resources/todomvc/architecture-examples/jquery/bower_components/handlebars/handlebars.js: Added.
  • Speedometer/resources/todomvc/architecture-examples/jquery/bower_components/jquery/jquery.js: Added.
  • Speedometer/resources/todomvc/architecture-examples/jquery/bower_components/todomvc-common/base.css: Added.
  • Speedometer/resources/todomvc/architecture-examples/jquery/bower_components/todomvc-common/base.js: Added.
  • Speedometer/resources/todomvc/architecture-examples/jquery/bower_components/todomvc-common/bg.png: Added.
  • Speedometer/resources/todomvc/architecture-examples/jquery/css/app.css: Added.
  • Speedometer/resources/todomvc/architecture-examples/jquery/index.html: Added.
  • Speedometer/resources/todomvc/architecture-examples/jquery/js/app.js: Added.
  • Speedometer/resources/todomvc/architecture-examples/jquery/readme.md: Added.
  • Speedometer/resources/todomvc/dependency-examples/flight/.gitignore: Added.
  • Speedometer/resources/todomvc/dependency-examples/flight/.jshintrc: Added.
  • Speedometer/resources/todomvc/dependency-examples/flight/app/js/app.js: Added.
  • Speedometer/resources/todomvc/dependency-examples/flight/app/js/data/stats.js: Added.
  • Speedometer/resources/todomvc/dependency-examples/flight/app/js/data/todos.js: Added.
  • Speedometer/resources/todomvc/dependency-examples/flight/app/js/main.js: Added.
  • Speedometer/resources/todomvc/dependency-examples/flight/app/js/store.js: Added.
  • Speedometer/resources/todomvc/dependency-examples/flight/app/js/ui/main_selector.js: Added.
  • Speedometer/resources/todomvc/dependency-examples/flight/app/js/ui/new_item.js: Added.
  • Speedometer/resources/todomvc/dependency-examples/flight/app/js/ui/stats.js: Added.
  • Speedometer/resources/todomvc/dependency-examples/flight/app/js/ui/todo_list.js: Added.
  • Speedometer/resources/todomvc/dependency-examples/flight/app/js/ui/toggle_all.js: Added.
  • Speedometer/resources/todomvc/dependency-examples/flight/app/js/ui/with_filters.js: Added.
  • Speedometer/resources/todomvc/dependency-examples/flight/app/js/utils.js: Added.
  • Speedometer/resources/todomvc/dependency-examples/flight/app/templates/stats.html: Added.
  • Speedometer/resources/todomvc/dependency-examples/flight/app/templates/todo.html: Added.
  • Speedometer/resources/todomvc/dependency-examples/flight/bower.json: Added.
  • Speedometer/resources/todomvc/dependency-examples/flight/bower_components/depot/depot.js: Added.
  • Speedometer/resources/todomvc/dependency-examples/flight/bower_components/es5-shim/es5-sham.js: Added.
  • Speedometer/resources/todomvc/dependency-examples/flight/bower_components/es5-shim/es5-shim.js: Added.
  • Speedometer/resources/todomvc/dependency-examples/flight/bower_components/flight/lib/advice.js: Added.
  • Speedometer/resources/todomvc/dependency-examples/flight/bower_components/flight/lib/base.js: Added.
  • Speedometer/resources/todomvc/dependency-examples/flight/bower_components/flight/lib/component.js: Added.
  • Speedometer/resources/todomvc/dependency-examples/flight/bower_components/flight/lib/compose.js: Added.
  • Speedometer/resources/todomvc/dependency-examples/flight/bower_components/flight/lib/debug.js: Added.
  • Speedometer/resources/todomvc/dependency-examples/flight/bower_components/flight/lib/index.js: Added.
  • Speedometer/resources/todomvc/dependency-examples/flight/bower_components/flight/lib/logger.js: Added.
  • Speedometer/resources/todomvc/dependency-examples/flight/bower_components/flight/lib/registry.js: Added.
  • Speedometer/resources/todomvc/dependency-examples/flight/bower_components/flight/lib/utils.js: Added.
  • Speedometer/resources/todomvc/dependency-examples/flight/bower_components/jquery/jquery.js: Added.
  • Speedometer/resources/todomvc/dependency-examples/flight/bower_components/requirejs-text/text.js: Added.
  • Speedometer/resources/todomvc/dependency-examples/flight/bower_components/requirejs/require.js: Added.
  • Speedometer/resources/todomvc/dependency-examples/flight/bower_components/todomvc-common/base.css: Added.
  • Speedometer/resources/todomvc/dependency-examples/flight/bower_components/todomvc-common/base.js: Added.
  • Speedometer/resources/todomvc/dependency-examples/flight/bower_components/todomvc-common/bg.png: Added.
  • Speedometer/resources/todomvc/dependency-examples/flight/index.html: Added.
  • Speedometer/resources/todomvc/dependency-examples/flight/karma.conf.js: Added.
  • Speedometer/resources/todomvc/dependency-examples/flight/package.json: Added.
  • Speedometer/resources/todomvc/dependency-examples/flight/readme.md: Added.
  • Speedometer/resources/todomvc/dependency-examples/flight/test/.jshintrc: Added.
  • Speedometer/resources/todomvc/dependency-examples/flight/test/fixture/footer.html: Added.
  • Speedometer/resources/todomvc/dependency-examples/flight/test/fixture/new_todo.html: Added.
  • Speedometer/resources/todomvc/dependency-examples/flight/test/fixture/toggle_all.html: Added.
  • Speedometer/resources/todomvc/dependency-examples/flight/test/mock/datastore.js: Added.
  • Speedometer/resources/todomvc/dependency-examples/flight/test/spec/data/stats_spec.js: Added.
  • Speedometer/resources/todomvc/dependency-examples/flight/test/spec/data/todos_spec.js: Added.
  • Speedometer/resources/todomvc/dependency-examples/flight/test/spec/ui/new_item_spec.js: Added.
  • Speedometer/resources/todomvc/dependency-examples/flight/test/spec/ui/stats_spec.js: Added.
  • Speedometer/resources/todomvc/dependency-examples/flight/test/spec/ui/toggle_all_spec.js: Added.
  • Speedometer/resources/todomvc/dependency-examples/flight/test/test-main.js: Added.
  • Speedometer/resources/todomvc/labs/architecture-examples/react/bower.json: Added.
  • Speedometer/resources/todomvc/labs/architecture-examples/react/bower_components/director/LICENSE: Added.
  • Speedometer/resources/todomvc/labs/architecture-examples/react/bower_components/director/README.md: Added.
  • Speedometer/resources/todomvc/labs/architecture-examples/react/bower_components/react/JSXTransformer.js: Added.
  • Speedometer/resources/todomvc/labs/architecture-examples/react/bower_components/react/bower.json: Added.
  • Speedometer/resources/todomvc/labs/architecture-examples/react/bower_components/react/react.js: Added.
  • Speedometer/resources/todomvc/labs/architecture-examples/react/bower_components/react/react.min.js: Added.
  • Speedometer/resources/todomvc/labs/architecture-examples/react/bower_components/todomvc-common/base.css: Added.
  • Speedometer/resources/todomvc/labs/architecture-examples/react/bower_components/todomvc-common/base.js: Added.
  • Speedometer/resources/todomvc/labs/architecture-examples/react/bower_components/todomvc-common/bg.png: Added.
  • Speedometer/resources/todomvc/labs/architecture-examples/react/index.html: Added.
  • Speedometer/resources/todomvc/labs/architecture-examples/react/js/app.jsx: Added.
  • Speedometer/resources/todomvc/labs/architecture-examples/react/js/footer.jsx: Added.
  • Speedometer/resources/todomvc/labs/architecture-examples/react/js/todoItem.jsx: Added.
  • Speedometer/resources/todomvc/labs/architecture-examples/react/js/utils.jsx: Added.
  • Speedometer/resources/todomvc/labs/architecture-examples/react/readme.md: Added.
  • Speedometer/resources/todomvc/learn.json: Added.
  • Speedometer/resources/todomvc/license.md: Added.
  • Speedometer/resources/todomvc/readme.md: Added.
  • Speedometer/resources/todomvc/vanilla-examples/vanillajs/bower.json: Added.
  • Speedometer/resources/todomvc/vanilla-examples/vanillajs/bower_components/todomvc-common/base.css: Added.
  • Speedometer/resources/todomvc/vanilla-examples/vanillajs/bower_components/todomvc-common/base.js: Added.
  • Speedometer/resources/todomvc/vanilla-examples/vanillajs/bower_components/todomvc-common/bg.png: Added.
  • Speedometer/resources/todomvc/vanilla-examples/vanillajs/index.html: Added.
  • Speedometer/resources/todomvc/vanilla-examples/vanillajs/js/app.js: Added.
  • Speedometer/resources/todomvc/vanilla-examples/vanillajs/js/controller.js: Added.
  • Speedometer/resources/todomvc/vanilla-examples/vanillajs/js/helpers.js: Added.
  • Speedometer/resources/todomvc/vanilla-examples/vanillajs/js/model.js: Added.
  • Speedometer/resources/todomvc/vanilla-examples/vanillajs/js/store.js: Added.
  • Speedometer/resources/todomvc/vanilla-examples/vanillajs/js/view.js: Added.
  • Speedometer/resources/todomvc/vanilla-examples/vanillajs/readme.md: Added.
  • index.html: Added.
  • resources/ARES-6-Logo.png: Added.
  • resources/ARES-6-Logo@2x.png: Added.
  • resources/JetStream-Logo.png: Added.
  • resources/JetStream-Logo@2x.png: Added.
  • resources/MotionMark-Logo.png: Added.
  • resources/MotionMark-Logo@2x.png: Added.
  • resources/Speedometer-Logo.png: Added.
  • resources/Speedometer-Logo@2x.png: Added.
  • resources/main.css: Added.
6:55 PM Changeset in webkit [216810] by Chris Dumez
  • 44 edits in trunk/Source/WebKit2

Drop remaining uses of PassRefPtr in WebKit2/WebProcess
https://bugs.webkit.org/show_bug.cgi?id=172055

Reviewed by Alex Christensen.

  • WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInScriptWorld.mm:

(+[WKWebProcessPlugInScriptWorld normalWorld]):

  • WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:

(contextMenuItems):

  • WebProcess/InjectedBundle/API/c/WKBundleScriptWorld.cpp:

(WKBundleScriptWorldNormalWorld):

  • WebProcess/InjectedBundle/API/gtk/WebKitScriptWorld.cpp:

(webkitScriptWorldCreate):

  • WebProcess/InjectedBundle/DOM/InjectedBundleCSSStyleDeclarationHandle.cpp:

(WebKit::InjectedBundleCSSStyleDeclarationHandle::getOrCreate):

  • WebProcess/InjectedBundle/DOM/InjectedBundleCSSStyleDeclarationHandle.h:
  • WebProcess/InjectedBundle/DOM/InjectedBundleRangeHandle.cpp:

(WebKit::InjectedBundleRangeHandle::getOrCreate):
(WebKit::InjectedBundleRangeHandle::create):
(WebKit::InjectedBundleRangeHandle::coreRange):
(WebKit::InjectedBundleRangeHandle::renderedImage):

  • WebProcess/InjectedBundle/DOM/InjectedBundleRangeHandle.h:
  • WebProcess/InjectedBundle/InjectedBundle.cpp:

(WebKit::InjectedBundle::create):
(WebKit::InjectedBundle::createWebDataFromUint8Array):

  • WebProcess/InjectedBundle/InjectedBundle.h:
  • WebProcess/InjectedBundle/InjectedBundleBackForwardList.cpp:

(WebKit::InjectedBundleBackForwardList::itemAtIndex):

  • WebProcess/InjectedBundle/InjectedBundleBackForwardList.h:

(WebKit::InjectedBundleBackForwardList::detach):

  • WebProcess/InjectedBundle/InjectedBundleBackForwardListItem.h:

(WebKit::InjectedBundleBackForwardListItem::create):
(WebKit::InjectedBundleBackForwardListItem::InjectedBundleBackForwardListItem):

  • WebProcess/InjectedBundle/InjectedBundleHitTestResult.cpp:

(WebKit::InjectedBundleHitTestResult::nodeHandle):
(WebKit::InjectedBundleHitTestResult::urlElementHandle):

  • WebProcess/InjectedBundle/InjectedBundleHitTestResult.h:
  • WebProcess/InjectedBundle/InjectedBundleNavigationAction.cpp:

(WebKit::InjectedBundleNavigationAction::create):
(WebKit::InjectedBundleNavigationAction::InjectedBundleNavigationAction):

  • WebProcess/InjectedBundle/InjectedBundleNavigationAction.h:
  • WebProcess/InjectedBundle/InjectedBundleScriptWorld.cpp:

(WebKit::InjectedBundleScriptWorld::getOrCreate):
(WebKit::InjectedBundleScriptWorld::normalWorld):

  • WebProcess/InjectedBundle/InjectedBundleScriptWorld.h:
  • WebProcess/Plugins/Netscape/NetscapePlugin.cpp:

(WebKit::NetscapePlugin::create):
(WebKit::NetscapePlugin::NetscapePlugin):
(WebKit::NetscapePlugin::supportsSnapshotting):

  • WebProcess/Plugins/Netscape/NetscapePlugin.h:
  • WebProcess/Plugins/PDF/PDFPluginAnnotation.h:
  • WebProcess/Plugins/PDF/PDFPluginAnnotation.mm:

(WebKit::PDFPluginAnnotation::create):

  • WebProcess/Plugins/PDF/PDFPluginChoiceAnnotation.h:
  • WebProcess/Plugins/PDF/PDFPluginChoiceAnnotation.mm:

(WebKit::PDFPluginChoiceAnnotation::createAnnotationElement):

  • WebProcess/Plugins/PDF/PDFPluginPasswordField.h:
  • WebProcess/Plugins/PDF/PDFPluginPasswordField.mm:

(WebKit::PDFPluginPasswordField::createAnnotationElement):

  • WebProcess/Plugins/PDF/PDFPluginTextAnnotation.h:
  • WebProcess/Plugins/PDF/PDFPluginTextAnnotation.mm:

(WebKit::PDFPluginTextAnnotation::createAnnotationElement):

  • WebProcess/UserContent/WebUserContentController.cpp:

(WebKit::worldMap):
(WebKit::WebUserMessageHandlerDescriptorProxy::create):

  • WebProcess/WebCoreSupport/mac/WebDragClientMac.mm:

(WebKit::convertImageToBitmap):

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::addUserScript):
(WebKit::WebPage::addUserStyleSheet):

  • WebProcess/WebPage/gtk/WebPrintOperationGtk.cpp:

(WebKit::WebPrintOperationGtk::create):

  • WebProcess/WebPage/gtk/WebPrintOperationGtk.h:
  • WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::rangeForPosition):
(WebKit::rangeAtWordBoundaryForPosition):

  • WebProcess/WebPage/mac/PlatformCAAnimationRemote.h:
6:33 PM Changeset in webkit [216809] by achristensen@apple.com
  • 36 edits
    16 moves in trunk

Rename WKContentExtension to WKContentRuleList
https://bugs.webkit.org/show_bug.cgi?id=172053
<rdar://problem/32141005>

Reviewed by Geoffrey Garen.

Source/WebCore:

Covered by existing API tests.

  • English.lproj/Localizable.strings:

Source/WebKit2:

  • Shared/API/APIObject.h:
  • Shared/API/Cocoa/WebKit.h:
  • Shared/API/c/WKDeprecatedFunctions.cpp:

(WKPageGroupAddUserContentFilter):
(WKPageGroupRemoveUserContentFilter):

  • Shared/Cocoa/APIObject.mm:

(API::Object::newObject):

  • Shared/WebCompiledContentExtension.cpp: Removed.
  • Shared/WebCompiledContentExtension.h: Removed.
  • Shared/WebCompiledContentExtensionData.cpp: Removed.
  • Shared/WebCompiledContentExtensionData.h: Removed.
  • Shared/WebCompiledContentRuleList.cpp: Copied from Source/WebKit2/Shared/WebCompiledContentExtension.cpp.

(WebKit::WebCompiledContentRuleList::create):
(WebKit::WebCompiledContentRuleList::WebCompiledContentRuleList):
(WebKit::WebCompiledContentRuleList::~WebCompiledContentRuleList):
(WebKit::WebCompiledContentRuleList::conditionsApplyOnlyToDomain):
(WebKit::WebCompiledContentRuleList::filtersWithoutConditionsBytecode):
(WebKit::WebCompiledContentRuleList::filtersWithoutConditionsBytecodeLength):
(WebKit::WebCompiledContentRuleList::filtersWithConditionsBytecode):
(WebKit::WebCompiledContentRuleList::filtersWithConditionsBytecodeLength):
(WebKit::WebCompiledContentRuleList::topURLFiltersBytecode):
(WebKit::WebCompiledContentRuleList::topURLFiltersBytecodeLength):
(WebKit::WebCompiledContentRuleList::actions):
(WebKit::WebCompiledContentRuleList::actionsLength):
(WebKit::WebCompiledContentExtension::create): Deleted.
(WebKit::WebCompiledContentExtension::WebCompiledContentExtension): Deleted.
(WebKit::WebCompiledContentExtension::~WebCompiledContentExtension): Deleted.
(WebKit::WebCompiledContentExtension::conditionsApplyOnlyToDomain): Deleted.
(WebKit::WebCompiledContentExtension::filtersWithoutConditionsBytecode): Deleted.
(WebKit::WebCompiledContentExtension::filtersWithoutConditionsBytecodeLength): Deleted.
(WebKit::WebCompiledContentExtension::filtersWithConditionsBytecode): Deleted.
(WebKit::WebCompiledContentExtension::filtersWithConditionsBytecodeLength): Deleted.
(WebKit::WebCompiledContentExtension::topURLFiltersBytecode): Deleted.
(WebKit::WebCompiledContentExtension::topURLFiltersBytecodeLength): Deleted.
(WebKit::WebCompiledContentExtension::actions): Deleted.
(WebKit::WebCompiledContentExtension::actionsLength): Deleted.

  • Shared/WebCompiledContentRuleList.h: Copied from Source/WebKit2/Shared/WebCompiledContentExtension.h.
  • Shared/WebCompiledContentRuleListData.cpp: Copied from Source/WebKit2/Shared/WebCompiledContentExtensionData.cpp.

(WebKit::WebCompiledContentRuleListData::encode):
(WebKit::WebCompiledContentRuleListData::decode):
(WebKit::WebCompiledContentExtensionData::encode): Deleted.
(WebKit::WebCompiledContentExtensionData::decode): Deleted.

  • Shared/WebCompiledContentRuleListData.h: Copied from Source/WebKit2/Shared/WebCompiledContentExtensionData.h.

(WebKit::WebCompiledContentRuleListData::WebCompiledContentRuleListData):
(WebKit::WebCompiledContentExtensionData::WebCompiledContentExtensionData): Deleted.

  • Shared/WebPageCreationParameters.cpp:

(WebKit::WebPageCreationParameters::encode):
(WebKit::WebPageCreationParameters::decode):

  • Shared/WebPageCreationParameters.h:
  • UIProcess/API/APIContentExtension.cpp: Removed.
  • UIProcess/API/APIContentExtension.h: Removed.
  • UIProcess/API/APIContentExtensionStore.cpp: Removed.
  • UIProcess/API/APIContentExtensionStore.h: Removed.
  • UIProcess/API/APIContentRuleList.cpp: Copied from Source/WebKit2/UIProcess/API/APIContentExtension.cpp.

(API::ContentRuleList::ContentRuleList):
(API::ContentRuleList::~ContentRuleList):
(API::ContentExtension::ContentExtension): Deleted.
(API::ContentExtension::~ContentExtension): Deleted.

  • UIProcess/API/APIContentRuleList.h: Copied from Source/WebKit2/UIProcess/API/APIContentExtension.h.
  • UIProcess/API/APIContentRuleListStore.cpp: Copied from Source/WebKit2/UIProcess/API/APIContentExtensionStore.cpp.

(API::ContentRuleListStore::legacyDefaultStore):
(API::ContentRuleListStore::nonLegacyDdefaultStore):
(API::ContentRuleListStore::defaultStore):
(API::ContentRuleListStore::storeWithPath):
(API::ContentRuleListStore::ContentRuleListStore):
(API::ContentRuleListStore::~ContentRuleListStore):
(API::constructedPathPrefix):
(API::ContentRuleListMetaData::fileSize):
(API::encodeContentRuleListMetaData):
(API::decodeContentRuleListMetaData):
(API::openAndMapContentRuleList):
(API::compiledToFile):
(API::createExtension):
(API::ContentRuleListStore::lookupContentRuleList):
(API::ContentRuleListStore::getAvailableContentRuleListIdentifiers):
(API::ContentRuleListStore::compileContentRuleList):
(API::ContentRuleListStore::removeContentRuleList):
(API::ContentRuleListStore::synchronousRemoveAllContentRuleLists):
(API::ContentRuleListStore::invalidateContentRuleListVersion):
(API::ContentRuleListStore::getContentRuleListSource):
(API::contentRuleListStoreErrorCategory):
(API::ContentExtensionStore::defaultStore): Deleted.
(API::ContentExtensionStore::storeWithPath): Deleted.
(API::ContentExtensionStore::ContentExtensionStore): Deleted.
(API::ContentExtensionStore::~ContentExtensionStore): Deleted.
(API::ContentExtensionMetaData::fileSize): Deleted.
(API::encodeContentExtensionMetaData): Deleted.
(API::decodeContentExtensionMetaData): Deleted.
(API::openAndMapContentExtension): Deleted.
(API::ContentExtensionStore::lookupContentExtension): Deleted.
(API::ContentExtensionStore::getAvailableContentExtensionIdentifiers): Deleted.
(API::ContentExtensionStore::compileContentExtension): Deleted.
(API::ContentExtensionStore::removeContentExtension): Deleted.
(API::ContentExtensionStore::synchronousRemoveAllContentExtensions): Deleted.
(API::ContentExtensionStore::invalidateContentExtensionVersion): Deleted.
(API::ContentExtensionStore::getContentExtensionSource): Deleted.
(API::contentExtensionStoreErrorCategory): Deleted.

  • UIProcess/API/APIContentRuleListStore.h: Copied from Source/WebKit2/UIProcess/API/APIContentExtensionStore.h.

(API::make_error_code):

  • UIProcess/API/C/WKAPICast.h:
  • UIProcess/API/C/WKPageGroup.cpp:
  • UIProcess/API/C/WKUserContentControllerRef.cpp:

(WKUserContentControllerAddUserContentFilter):
(WKUserContentControllerRemoveAllUserContentFilters):

  • UIProcess/API/C/WKUserContentExtensionStoreRef.cpp:

(WKUserContentExtensionStoreGetTypeID):

  • UIProcess/API/Cocoa/APIUserContentExtensionStoreCocoa.mm:

(API::ContentRuleListStore::defaultStorePath):
(API::ContentExtensionStore::defaultStorePath): Deleted.

  • UIProcess/API/Cocoa/WKContentExtension.h: Removed.
  • UIProcess/API/Cocoa/WKContentExtension.mm: Removed.
  • UIProcess/API/Cocoa/WKContentExtensionInternal.h: Removed.
  • UIProcess/API/Cocoa/WKContentExtensionStore.h: Removed.
  • UIProcess/API/Cocoa/WKContentExtensionStore.mm: Removed.
  • UIProcess/API/Cocoa/WKContentExtensionStoreInternal.h: Removed.
  • UIProcess/API/Cocoa/WKContentExtensionStorePrivate.h: Removed.
  • UIProcess/API/Cocoa/WKContentRuleList.h: Copied from Source/WebKit2/UIProcess/API/Cocoa/WKContentExtension.h.
  • UIProcess/API/Cocoa/WKContentRuleList.mm: Copied from Source/WebKit2/UIProcess/API/Cocoa/WKContentExtension.mm.

(-[WKContentRuleList dealloc]):
(-[WKContentRuleList _apiObject]):
(-[WKContentRuleList identifier]):
(-[WKContentExtension dealloc]): Deleted.
(-[WKContentExtension _apiObject]): Deleted.
(-[WKContentExtension identifier]): Deleted.

  • UIProcess/API/Cocoa/WKContentRuleListInternal.h: Copied from Source/WebKit2/UIProcess/API/Cocoa/WKContentExtensionInternal.h.

(WebKit::wrapper):

  • UIProcess/API/Cocoa/WKContentRuleListStore.h: Copied from Source/WebKit2/UIProcess/API/Cocoa/WKContentExtensionStore.h.
  • UIProcess/API/Cocoa/WKContentRuleListStore.mm: Copied from Source/WebKit2/UIProcess/API/Cocoa/WKContentExtensionStore.mm.

(toWKErrorCode):
(-[WKContentRuleListStore dealloc]):
(+[WKContentRuleListStore defaultStore]):
(+[WKContentRuleListStore storeWithURL:]):
(-[WKContentRuleListStore compileContentRuleListForIdentifier:encodedContentRuleList:completionHandler:]):
(-[WKContentRuleListStore _compileContentRuleListForIdentifier:encodedContentRuleList:completionHandler:releasesArgument:]):
(-[WKContentRuleListStore lookUpContentRuleListForIdentifier:completionHandler:]):
(-[WKContentRuleListStore getAvailableContentRuleListIdentifiers:]):
(-[WKContentRuleListStore removeContentRuleListForIdentifier:completionHandler:]):
(-[WKContentRuleListStore _apiObject]):
(-[WKContentRuleListStore _removeAllContentRuleLists]):
(-[WKContentRuleListStore _invalidateContentRuleListVersionForIdentifier:]):
(-[WKContentRuleListStore _getContentRuleListSourceForIdentifier:completionHandler:]):
(-[WKContentRuleListStore _compileContentRuleListForIdentifier:encodedContentRuleList:completionHandler:]):
(-[WKContentExtensionStore dealloc]): Deleted.
(+[WKContentExtensionStore defaultStore]): Deleted.
(+[WKContentExtensionStore storeWithURL:]): Deleted.
(-[WKContentExtensionStore compileContentExtensionForIdentifier:encodedContentExtension:completionHandler:]): Deleted.
(-[WKContentExtensionStore _compileContentExtensionForIdentifier:encodedContentExtension:completionHandler:releasesArgument:]): Deleted.
(-[WKContentExtensionStore lookUpContentExtensionForIdentifier:completionHandler:]): Deleted.
(-[WKContentExtensionStore getAvailableContentExtensionIdentifiers:]): Deleted.
(-[WKContentExtensionStore removeContentExtensionForIdentifier:completionHandler:]): Deleted.
(-[WKContentExtensionStore _apiObject]): Deleted.
(-[WKContentExtensionStore _removeAllContentExtensions]): Deleted.
(-[WKContentExtensionStore _invalidateContentExtensionVersionForIdentifier:]): Deleted.
(-[WKContentExtensionStore _getContentExtensionSourceForIdentifier:completionHandler:]): Deleted.
(-[WKContentExtensionStore _compileContentExtensionForIdentifier:encodedContentExtension:completionHandler:]): Deleted.

  • UIProcess/API/Cocoa/WKContentRuleListStoreInternal.h: Copied from Source/WebKit2/UIProcess/API/Cocoa/WKContentExtensionStoreInternal.h.

(WebKit::wrapper):

  • UIProcess/API/Cocoa/WKContentRuleListStorePrivate.h: Copied from Source/WebKit2/UIProcess/API/Cocoa/WKContentExtensionStorePrivate.h.
  • UIProcess/API/Cocoa/WKError.h:
  • UIProcess/API/Cocoa/WKError.mm:

(localizedDescriptionForErrorCode):

  • UIProcess/API/Cocoa/WKUserContentController.h:
  • UIProcess/API/Cocoa/WKUserContentController.mm:

(-[WKUserContentController addContentRuleList:]):
(-[WKUserContentController removeContentRuleList:]):
(-[WKUserContentController removeAllContentRuleLists]):
(-[WKUserContentController _addUserContentFilter:]):
(-[WKUserContentController _removeUserContentFilter:]):
(-[WKUserContentController _removeAllUserContentFilters]):
(-[WKUserContentController addContentExtension:]): Deleted.
(-[WKUserContentController removeContentExtension:]): Deleted.
(-[WKUserContentController removeAllContentExtensions]): Deleted.

  • UIProcess/API/Cocoa/_WKUserContentExtensionStore.mm:

(toUserContentRuleListStoreError):
(+[_WKUserContentExtensionStore defaultStore]):
(+[_WKUserContentExtensionStore storeWithURL:]):
(-[_WKUserContentExtensionStore compileContentExtensionForIdentifier:encodedContentExtension:completionHandler:]):
(-[_WKUserContentExtensionStore lookupContentExtensionForIdentifier:completionHandler:]):
(-[_WKUserContentExtensionStore removeContentExtensionForIdentifier:completionHandler:]):
(-[_WKUserContentExtensionStore _apiObject]):
(-[_WKUserContentExtensionStore _removeAllContentExtensions]):
(-[_WKUserContentExtensionStore _invalidateContentExtensionVersionForIdentifier:]):
(-[_WKUserContentExtensionStore _initWithWKContentRuleListStore:]):
(toUserContentExtensionStoreError): Deleted.
(-[_WKUserContentExtensionStore _initWithWKContentExtensionStore:]): Deleted.

  • UIProcess/API/Cocoa/_WKUserContentExtensionStoreInternal.h:
  • UIProcess/API/Cocoa/_WKUserContentExtensionStorePrivate.h:
  • UIProcess/API/Cocoa/_WKUserContentFilter.mm:

(-[_WKUserContentFilter _apiObject]):
(-[_WKUserContentFilter _initWithWKContentRuleList:]):
(-[_WKUserContentFilter _initWithWKContentExtension:]): Deleted.

  • UIProcess/API/Cocoa/_WKUserContentFilterInternal.h:
  • UIProcess/API/Cocoa/_WKUserContentFilterPrivate.h:
  • UIProcess/UserContent/WebUserContentControllerProxy.cpp:

(WebKit::WebUserContentControllerProxy::addProcess):
(WebKit::WebUserContentControllerProxy::addContentRuleList):
(WebKit::WebUserContentControllerProxy::removeContentRuleList):
(WebKit::WebUserContentControllerProxy::removeAllContentRuleLists):
(WebKit::WebUserContentControllerProxy::addContentExtension): Deleted.
(WebKit::WebUserContentControllerProxy::removeContentExtension): Deleted.
(WebKit::WebUserContentControllerProxy::removeAllContentExtensions): Deleted.

  • UIProcess/UserContent/WebUserContentControllerProxy.h:
  • UIProcess/WebPageGroup.cpp:
  • WebKit2.xcodeproj/project.pbxproj:
  • WebProcess/UserContent/WebUserContentController.cpp:

(WebKit::WebUserContentController::addContentRuleLists):
(WebKit::WebUserContentController::removeContentRuleList):
(WebKit::WebUserContentController::removeAllContentRuleLists):
(WebKit::WebUserContentController::addContentExtensions): Deleted.
(WebKit::WebUserContentController::removeContentExtension): Deleted.
(WebKit::WebUserContentController::removeAllContentExtensions): Deleted.

  • WebProcess/UserContent/WebUserContentController.h:
  • WebProcess/UserContent/WebUserContentController.messages.in:
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::m_backgroundCPULimit):

Tools:

  • TestWebKitAPI/Tests/WebKit2Cocoa/WKContentExtensionStore.mm:

(WKContentRuleListStoreTest::SetUp):
(TEST_F):
(-[ContentRuleListDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
(WKContentExtensionStoreTest::SetUp): Deleted.
(-[ContentExtensionDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]): Deleted.

6:30 PM Changeset in webkit [216808] by keith_miller@apple.com
  • 24 edits
    1 copy in trunk

Use Mach exceptions instead of signals where possible
https://bugs.webkit.org/show_bug.cgi?id=171865

Reviewed by Mark Lam.

Source/JavaScriptCore:

This patch adds some new JSC options. The first is an option that
enables or disables web assembly tier up. The second controls
whether or not we use mach exceptions (where available).

  • API/tests/ExecutionTimeLimitTest.cpp:

(dispatchTermitateCallback):
(testExecutionTimeLimit):

  • runtime/JSLock.cpp:

(JSC::JSLock::didAcquireLock):

  • runtime/Options.cpp:

(JSC::overrideDefaults):
(JSC::Options::initialize):

  • runtime/Options.h:
  • runtime/VMTraps.cpp:

(JSC::SignalContext::SignalContext):
(JSC::SignalContext::adjustPCToPointToTrappingInstruction):
(JSC::installSignalHandler):
(JSC::VMTraps::SignalSender::send):

  • tools/SigillCrashAnalyzer.cpp:

(JSC::SignalContext::SignalContext):
(JSC::SignalContext::dump):
(JSC::installCrashHandler):

  • wasm/WasmBBQPlan.cpp:

(JSC::Wasm::BBQPlan::compileFunctions):

  • wasm/WasmFaultSignalHandler.cpp:

(JSC::Wasm::trapHandler):
(JSC::Wasm::enableFastMemory):

  • wasm/WasmMachineThreads.cpp:

(JSC::Wasm::resetInstructionCacheOnAllThreads):

Source/WTF:

This patch enables using mach exceptions on darwin. The way the
mach exception api works is that we create a mach port, which is
like a file descriptor. We then wait for a message to arrive on
that port in a thread. When another thread raises an exception (say
due to a bad memory access) the OS sends our thread a message. The
payload of that message is the register file of the crashing
thread. We then call our custom handlers that change the state as
needed. In order to restart the thread we send a payload back to
the OS with an updated register file along with a success message
header.

This patch also makes thread messages work without signals by
simply suspending the thread, and then running the message at that
time.

You can read more about mach exceptions here:
http://www.cs.cmu.edu/afs/cs/project/mach/public/doc/unpublished/exception.ps
and the Mach interface Generator (MiG) here:
http://www.cs.cmu.edu/afs/cs/project/mach/public/doc/unpublished/mig.ps

  • Configurations/WTF.xcconfig:
  • WTF.xcodeproj/project.pbxproj:
  • wtf/Platform.h:
  • wtf/PlatformRegisters.h:

(WTF::registersFromUContext):

  • wtf/StackBounds.h:

(WTF::StackBounds::StackBounds):

  • wtf/ThreadHolder.cpp:

(WTF::ThreadHolder::~ThreadHolder):

  • wtf/ThreadMessage.cpp:

(WTF::sendMessageUsingSignal):
(WTF::sendMessageUsingMach):
(WTF::deliverMessagesUsingMach):
(WTF::sendMessageScoped):

  • wtf/ThreadMessage.h:

(WTF::sendMessage):

  • wtf/Threading.h:

(WTF::Thread::machThread):

  • wtf/mac/MachExceptions.defs: Copied from Source/WTF/wtf/ThreadMessage.h.
  • wtf/threads/Signals.cpp:

(WTF::startMachExceptionHandlerThread):
(WTF::fromMachException):
(WTF::toMachMask):
(WTF::handleSignalsWithMach):
(WTF::setExceptionPorts):
(WTF::activeThreads):
(WTF::registerThreadForMachExceptionHandling):
(WTF::unregisterThreadForMachExceptionHandling):
(WTF::installSignalHandler):
(WTF::jscSignalHandler):

  • wtf/threads/Signals.h:

Tools:

  • TestWebKitAPI/Tests/WTF/ThreadMessages.cpp:

(runThreadMessageTest):
(TEST):

6:00 PM Changeset in webkit [216807] by timothy_horton@apple.com
  • 3 edits in trunk/Source/WebCore

Don't use LinkPresentation URL shortening if it's not available
https://bugs.webkit.org/show_bug.cgi?id=172064
<rdar://problem/32169232>

Rubber-stamped by Wenson Hsieh.

  • platform/mac/DragImageMac.mm:

(WebCore::LinkImageLayout::LinkImageLayout):

  • platform/spi/cocoa/LinkPresentationSPI.h:
5:32 PM Changeset in webkit [216806] by commit-queue@webkit.org
  • 13 edits in trunk

Add objc version of WK2 UIPageClient setHasVideoInPictureInPicture and rename it to hasVideoInPictureInPictureDidChange.
https://bugs.webkit.org/show_bug.cgi?id=172048
rdar://problem/32163054

Patch by Jeremy Jones <jeremyj@apple.com> on 2017-05-12
Reviewed by Simon Fraser.

Source/WebKit2:

Rename UIPageClient setHasVideoInPictureInPicture to hasVideoInPictureInPictureDidChange.
Add missing _allowsPictureInPictureMediaPlayback property to WKPreferences.
Add -hasVideoInPictureInPictureDidChange to UIDelegate.

  • UIProcess/API/APIUIClient.h:

(API::UIClient::hasVideoInPictureInPictureDidChange):

  • UIProcess/API/C/WKPage.cpp:

(WKPageSetPageUIClient):

  • UIProcess/API/C/WKPageUIClient.h:
  • UIProcess/API/Cocoa/WKPreferences.mm:

(-[WKPreferences _allowsPictureInPictureMediaPlayback]):
(-[WKPreferences _setAllowsPictureInPictureMediaPlayback:]):

  • UIProcess/API/Cocoa/WKPreferencesPrivate.h:
  • UIProcess/API/Cocoa/WKUIDelegatePrivate.h:
  • UIProcess/Cocoa/UIDelegate.h:
  • UIProcess/Cocoa/UIDelegate.mm:

(WebKit::UIDelegate::setDelegate):
(WebKit::UIDelegate::UIClient::hasVideoInPictureInPictureDidChange):

  • UIProcess/Cocoa/WebVideoFullscreenManagerProxy.mm:

(WebKit::WebVideoFullscreenManagerProxy::setupFullscreenWithID):
(WebKit::WebVideoFullscreenManagerProxy::fullscreenModeChanged):

Tools:

Add a WKWebView test for hasVideoInPictureInPictureDidChange UIDelegate callback.

  • TestWebKitAPI/Tests/WebKit2Cocoa/PictureInPictureDelegate.html:
  • TestWebKitAPI/Tests/WebKit2Cocoa/PictureInPictureDelegate.mm:

(hasVideoInPictureInPictureDidChange):
(-[PictureInPictureUIDelegate _webView:hasVideoInPictureInPictureDidChange:]):
(-[PictureInPictureUIDelegate userContentController:didReceiveScriptMessage:]):
(TestWebKitAPI::TEST):

5:31 PM Changeset in webkit [216805] by beidson@apple.com
  • 2 edits in trunk/Tools

REGRESSION (r216711): API test WKWebView.ClearAppCache is failing.
https://bugs.webkit.org/show_bug.cgi?id=172030

Unreviewed - Test gardening

Try to resolve this once and for all by using the WebsiteDataStore API to nuke everything
before the test starts.

  • TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageClear.mm:

(defaultWebsiteCacheDirectory):
(defaultApplicationCacheDirectory):
(TEST):
(defaultWebsiteDataDirectory): Deleted.

5:00 PM Changeset in webkit [216804] by bshafiei@apple.com
  • 7 edits in trunk/Source

Versioning.

4:48 PM Changeset in webkit [216803] by Simon Fraser
  • 19 edits
    5 adds in trunk

Incorrect position when dragging jQuery Draggable elements with position fixed after pinch zoom
https://bugs.webkit.org/show_bug.cgi?id=171113
Source/WebCore:

rdar://problem/31746516

Reviewed by Tim Horton.

Make getBoundingClientRect() and getClientRects() return rects which are relative to the layout
viewport, rather than the visual viewport. This goes part of the way to fixing webkit.org/b/170981,
which aims to make pinch-zoom invisible to web pages ("inert visual viewport"). It fixes issues on various
sites like Facebook when zoomed.

Factor coordinate conversion code into functions on FrameView, which now documents
the various coordinate systems in a big comment. Document::adjustFloatQuadsForScrollAndAbsoluteZoomAndFrameScale()
and Document::adjustFloatRectForScrollAndAbsoluteZoomAndFrameScale() are renamed and factored
to use these helpers.

There are two behavior changes here:

  1. FrameView::documentToClientOffset() now uses the origin of the layout viewport in the "document to client" coordinate mapping.
  1. The two document functions would apply the scale and offset in the wrong order. We need to first undo the effects of CSS zoom, page zoom and page scale, and then map from document to client coordinates.

Tests: fast/visual-viewport/client-rects-relative-to-layout-viewport.html

fast/zooming/client-rects-with-css-and-page-zoom.html

  • dom/Document.cpp:

(WebCore::Document::convertAbsoluteToClientQuads):
(WebCore::Document::convertAbsoluteToClientRect):
(WebCore::Document::adjustFloatQuadsForScrollAndAbsoluteZoomAndFrameScale): Deleted.
(WebCore::Document::adjustFloatRectForScrollAndAbsoluteZoomAndFrameScale): Deleted.

  • dom/Document.h:
  • dom/Element.cpp:

(WebCore::Element::getClientRects):
(WebCore::Element::getBoundingClientRect):

  • dom/Range.cpp:

(WebCore::Range::borderAndTextQuads):

  • page/FrameView.cpp:

(WebCore::FrameView::absoluteToDocumentScaleFactor):
(WebCore::FrameView::absoluteToDocumentRect):
(WebCore::FrameView::absoluteToDocumentPoint):
(WebCore::FrameView::documentToClientOffset):
(WebCore::FrameView::documentToClientRect):
(WebCore::FrameView::documentToClientPoint):

  • page/FrameView.h:
  • platform/ScrollableArea.h: #pragma once
  • platform/Scrollbar.h: #pragma once
  • platform/Widget.h: #pragma once

LayoutTests:

Reviewed by Tim Horton.

Rebaseline tests which dumped the getBoundingClientRect for fixed elements; now that these
are layout viewport-relative, getBoundingClientRect() for a fixed element is unchanging.

New test that exercises getBoundingClientRect() and getClientRects() for fixed and absolute
elements after zooming.

  • fast/events/autoscroll-when-zoomed.html: Adjust to account for behavior change.
  • fast/visual-viewport/client-rects-relative-to-layout-viewport-expected.txt: Added.
  • fast/visual-viewport/client-rects-relative-to-layout-viewport.html: Added.
  • fast/visual-viewport/zoomed-fixed-expected.txt:
  • fast/visual-viewport/zoomed-fixed-header-and-footer-expected.txt:
  • fast/zooming/client-rect-in-fixed-zoomed-expected.txt:
  • fast/zooming/client-rect-in-fixed-zoomed.html:
  • fast/zooming/client-rects-with-css-and-page-zoom-expected.txt: Added.
  • fast/zooming/client-rects-with-css-and-page-zoom.html: Added.
  • platform/ios-wk2/fast/visual-viewport/client-rects-relative-to-layout-viewport-expected.txt: Added.
  • platform/ios/TestExpectations: Mark imported/w3c/web-platform-tests/cssom-view/elementFromPoint.html as failing;

it will be fixed via webkit.org/b/172019

  • platform/ios/fast/visual-viewport/zoomed-fixed-expected.txt:
  • platform/ios/fast/visual-viewport/zoomed-fixed-header-and-footer-expected.txt:
4:29 PM Changeset in webkit [216802] by commit-queue@webkit.org
  • 5 edits
    1 add in trunk

Add SPI for overriding WKWebView's clipping behavior for _visibleContentRect
https://bugs.webkit.org/show_bug.cgi?id=172000
rdar://problem/32144756

Patch by David Quesada <david_quesada@apple.com> on 2017-05-12
Reviewed by Simon Fraser.

Source/WebKit2:

Extract -[WKWebView _visibleContentRect]'s use of -_scroller to a new property
_enclosingViewForExposedRectComputation, which is declared in the private
header for subclasses to implement custom logic for determining the view to
clip rendering to.

  • UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _enclosingViewForExposedRectComputation]):
(-[WKWebView _visibleRectInEnclosingView:]):
(-[WKWebView _visibleContentRect]):
(-[WKWebView _visibleRectInEnclosingScrollView:]): Deleted.

  • UIProcess/API/Cocoa/WKWebViewPrivate.h:

Tools:

Added API tests to verify that WKWebView provides the expected value for
_visibleContentRect in various configurations. (i.e. not inside a scrollview,
inside a scrollview but not clipped, clipped by an ancestor scrollview,
clipped by the webview's _enclosingViewForExposedRectComputation)

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/Tests/WebKit2Cocoa/VisibleContentRect.mm: Added.

(-[TestWKWebViewWithEnclosingView _enclosingViewForExposedRectComputation]):
(TestWebKitAPI::TEST):

4:12 PM Changeset in webkit [216801] by mark.lam@apple.com
  • 15 edits in trunk

WorkerRunLoop::Task::performTask() should check !scriptController->isTerminatingExecution().
https://bugs.webkit.org/show_bug.cgi?id=171775
<rdar://problem/30975761>

Reviewed by Saam Barati.

Source/JavaScriptCore:

Increased the number of frames captured in VM::nativeStackTraceOfLastThrow()
from 25 to 100. From experience, I found that 25 is sometimes not sufficient
for our debugging needs.

Also added VM::throwingThread() to track which thread an exception was thrown in.
This may be useful if the client is entering the VM from different threads.

  • runtime/ExceptionScope.cpp:

(JSC::ExceptionScope::unexpectedExceptionMessage):

  • runtime/ExceptionScope.h:

(JSC::ExceptionScope::exception):
(JSC::ExceptionScope::unexpectedExceptionMessage):

  • runtime/Options.h:
  • Added the unexpectedExceptionStackTraceLimit option.
  • runtime/VM.cpp:

(JSC::VM::throwException):

  • runtime/VM.h:

(JSC::VM::throwingThread):
(JSC::VM::clearException):

Source/WebCore:

Currently, WorkerThread::stop() calls scheduleExecutionTermination() to terminate
JS execution first, followed by posting a cleanup task to the worker, and lastly,
it invokes terminate() on the WorkerRunLoop.

As a result, before the run loop is terminated, the worker thread may observe the
TerminatedExecutionException in JS code, bail out, see another JS task to run,
re-enters the VM to run said JS code, and fails with an assertion due to the
TerminatedExecutionException still being pending on VM entry.

WorkerRunLoop::Task::performTask() already has a check to only allow a task to
run if and only if !runLoop.terminated() and the task is not a clean up task.
We'll fix the above race by changing WorkerRunLoop::Task::performTask() to check
!context->script()->isTerminatingExecution() instead of !runLoop.terminated().
Since WorkerThread::stop() always scheduleExecutionTermination() before it
terminates the run loop, !context->script()->isTerminatingExecution() implies
!runLoop.terminated().

The only time that runLoop is terminated without scheduleExecutionTermination()
being called is when WorkerThread::stop() is called before the WorkerThread has
finished creating its WorkerGlobalScope. In this scenario, WorkerThread::stop()
will still terminate the run loop. Hence, after the WorkerGlobalScope is created
(in WorkerThread::workerThread()), we will check if the run loop has been
terminated (i.e. stop() was called). If so, we'll scheduleExecutionTermination()
there, and guarantee that if runloop.terminated() is true, then
context->script()->isTerminatingExecution() is also true.

Solutions that were considered but did not work (recorded for future reference):

  1. In WorkerThread::stop(), call scheduleExecutionTermination() only after it posts the cleanup task and terminate the run loop.

This did not work because this creates a race where the worker thread may run
the cleanup task before WorkerThread::stop() finishes. As a result, the
scriptController may be deleted before we get to invoke scheduleExecutionTermination()
on it, thereby resulting in a use after free.

To make this work, we would have to change the life cycle management strategy
of the WorkerScriptController. This is a more risky change that we would
want to take on at this time, and may also not be worth the gain.

  1. Break scheduleExecutionTermination() up into 2 parts i.e. WorkerThread::stop() will:
    1. set the scriptControllers m_isTerminatingExecution flag before posting the cleanup task and terminating the run loop, and
    2. invoke VM::notifyNeedsTermination() after posting the cleanup task and terminating the run loop.

This requires that we protect the liveness of the VM until we can invoke
notifyNeedsTermination() on it.

This did not work because:

  1. We may end up destructing the VM in WorkerThread::stop() i.e. in the main web frame, but only the worker thread holds the JS lock for the VM.

We can make the WorkerThread::stop() acquire the JS lock just before it
releases the protected VM's RefPtr, but that would mean the main thread
may be stuck waiting a bit for the worker thread to release its JSLock.
This is not desirable.

  1. In practice, changing the liveness period of the Worker VM relative to its WorkerScriptController and WorkerGlobalScope also has unexpected ramifications. We observed many worker tests failing with assertion failures and crashes due to this change.

Hence, this approach is also a more risky change than it appears on the
surface, and is not worth exploring at this time.

In the end, changing WorkerRunLoop::Task::performTask() to check for
!scriptController->isTerminatingExecution() is the most straight forward solution
that is easy to prove correct.

Also fixed a race in WorkerThread::workerThread() where it can delete the
WorkerGlobalScope while WorkerThread::stop() is in the midst of accessing it.
We now guard the the nullifying of m_workerGlobalScope with the
m_threadCreationAndWorkerGlobalScopeMutex as well.

This issue is covered by an existing test that I just unskipped in TestExpectations.

  • bindings/js/JSDOMPromiseDeferred.cpp:

(WebCore::DeferredPromise::callFunction):

  • bindings/js/WorkerScriptController.cpp:

(WebCore::WorkerScriptController::scheduleExecutionTermination):

  • Added a check to do nothing and return early if the scriptController is already terminating execution.
  • workers/WorkerRunLoop.cpp:

(WebCore::WorkerRunLoop::runInMode):
(WebCore::WorkerRunLoop::runCleanupTasks):
(WebCore::WorkerRunLoop::Task::performTask):

  • workers/WorkerRunLoop.h:
  • Made Task::performTask() private and make Task befriend the WorkerRunLoop class. This ensures that only the WorkerRunLoop may call performTask(). Note: this change only formalizes and hardens a relationship that was already in place before this.
  • workers/WorkerThread.cpp:

(WebCore::WorkerThread::start):
(WebCore::WorkerThread::workerThread):
(WebCore::WorkerThread::stop):

  • workers/WorkerThread.h:
  • Renamed m_threadCreationMutex to m_threadCreationAndWorkerGlobalScopeMutex so that it more accurately describes what it guards.

LayoutTests:

3:51 PM Changeset in webkit [216800] by beidson@apple.com
  • 2 edits in trunk/Tools

REGRESSION (r216711): API test WKWebView.ClearAppCache is failing.
https://bugs.webkit.org/show_bug.cgi?id=172030

Unreviewed - Test gardening, in effect...

More exploration as to why this continues to fail on the bots.

This change should give us a smoking gun.

  • TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageClear.mm:

(TEST):

3:47 PM Changeset in webkit [216799] by dbates@webkit.org
  • 2 edits in trunk/LayoutTests

Attempt to fix timeout failure of test plugins/navigator-plugin-crash.html in WebKit1
following <http://trac.webkit.org/changeset/216789>
(https://bugs.webkit.org/show_bug.cgi?id=171712)

In r216798 I inadvertently added testRunner.setPopupBlockingEnabled(true) instead
instead of testRunner.setPopupBlockingEnabled(false) to disable the popup blocker.

  • plugins/navigator-plugin-crash.html:
3:43 PM Changeset in webkit [216798] by dbates@webkit.org
  • 2 edits in trunk/LayoutTests

Attempt to fix timeout failure of test plugins/navigator-plugin-crash.html in WebKit1
following <http://trac.webkit.org/changeset/216789>
(https://bugs.webkit.org/show_bug.cgi?id=171712)

On WebKit1 we need to explicitly allow the test tool to open windows by calling
testRunner.setCanOpenWindows(). We should also call testRunner.setCloseRemainingWindowsWhenComplete(true)
to have the test tool close any open windows after running the test.

It is also good practice to explicitly disable the popup blocker by calling
testRunner.setPopupBlockingEnabled(true);.

  • plugins/navigator-plugin-crash.html:
3:15 PM Changeset in webkit [216797] by bshafiei@apple.com
  • 1 copy in tags/Safari-604.1.22

Tag Safari-604.1.22.

3:05 PM Changeset in webkit [216796] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WTF

Include algorithm before using std::min
https://bugs.webkit.org/show_bug.cgi?id=171733

Patch by Ting-Wei Lan <Ting-Wei Lan> on 2017-05-12
Reviewed by Chris Dumez.

  • wtf/text/StringCommon.h:
3:02 PM Changeset in webkit [216795] by hyungwook.lee@navercorp.com
  • 2 edits in trunk/Tools

[GTK] Fix compile warnings in PlatformImageCairo.cpp
https://bugs.webkit.org/show_bug.cgi?id=171850

Reviewed by Michael Catanzaro.

  • ImageDiff/cairo/PlatformImageCairo.cpp:

(ImageDiff::PlatformImage::createFromStdin):
(ImageDiff::PlatformImage::writeAsPNGToStdout):

3:00 PM Changeset in webkit [216794] by Chris Dumez
  • 52 edits in trunk/Source/WebKit2

Stop using PassRefPtr under WebKit2/UIProcess
https://bugs.webkit.org/show_bug.cgi?id=172029

Reviewed by Alex Christensen.

  • UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _takeViewSnapshot]):

  • UIProcess/API/Cocoa/WKWebViewInternal.h:
  • UIProcess/API/gtk/PageClientImpl.cpp:

(WebKit::PageClientImpl::registerEditCommand):

  • UIProcess/API/gtk/PageClientImpl.h:
  • UIProcess/API/gtk/WebKitFaviconDatabase.cpp:

(getIconSurfaceSynchronously):

  • UIProcess/API/gtk/WebKitWebContext.cpp:
  • UIProcess/API/wpe/PageClientImpl.cpp:

(WebKit::PageClientImpl::registerEditCommand):

  • UIProcess/API/wpe/PageClientImpl.h:
  • UIProcess/Cocoa/WebViewImpl.h:
  • UIProcess/Cocoa/WebViewImpl.mm:

(WebKit::WebViewImpl::registerEditCommand):

  • UIProcess/DefaultUndoController.cpp:

(WebKit::DefaultUndoController::registerEditCommand):

  • UIProcess/DefaultUndoController.h:
  • UIProcess/Downloads/DownloadProxy.cpp:

(WebKit::DownloadProxy::create):

  • UIProcess/Downloads/DownloadProxy.h:
  • UIProcess/GeolocationPermissionRequestManagerProxy.cpp:

(WebKit::GeolocationPermissionRequestManagerProxy::createRequest):

  • UIProcess/GeolocationPermissionRequestManagerProxy.h:
  • UIProcess/InspectorServer/HTTPRequest.cpp:

(WebKit::HTTPRequest::parseHTTPRequestFromBuffer):

  • UIProcess/InspectorServer/HTTPRequest.h:
  • UIProcess/InspectorServer/WebInspectorServer.cpp:

(WebKit::WebInspectorServer::didReceiveUnrecognizedHTTPRequest):
(WebKit::WebInspectorServer::didReceiveWebSocketUpgradeHTTPRequest):
(WebKit::WebInspectorServer::didEstablishWebSocketConnection):

  • UIProcess/InspectorServer/WebInspectorServer.h:
  • UIProcess/InspectorServer/WebSocketServerClient.h:

(WebKit::WebSocketServerClient::didReceiveUnrecognizedHTTPRequest):
(WebKit::WebSocketServerClient::didReceiveWebSocketUpgradeHTTPRequest):
(WebKit::WebSocketServerClient::didEstablishWebSocketConnection):

  • UIProcess/InspectorServer/WebSocketServerConnection.cpp:

(WebKit::WebSocketServerConnection::readHTTPMessage):
(WebKit::WebSocketServerConnection::upgradeToWebSocketServerConnection):

  • UIProcess/InspectorServer/WebSocketServerConnection.h:
  • UIProcess/Notifications/NotificationPermissionRequestManagerProxy.cpp:

(WebKit::NotificationPermissionRequestManagerProxy::createRequest):

  • UIProcess/Notifications/NotificationPermissionRequestManagerProxy.h:
  • UIProcess/Notifications/WebNotificationProvider.cpp:

(WebKit::WebNotificationProvider::notificationPermissions):

  • UIProcess/Notifications/WebNotificationProvider.h:
  • UIProcess/PageClient.h:
  • UIProcess/Storage/LocalStorageDatabase.cpp:
  • UIProcess/WebContextMenuListenerProxy.h:
  • UIProcess/WebCookieManagerProxy.h:
  • UIProcess/WebEditCommandProxy.cpp:

(WebKit::WebEditCommandProxy::unapply):
(WebKit::WebEditCommandProxy::reapply):

  • UIProcess/WebEditCommandProxy.h:
  • UIProcess/WebGrammarDetail.cpp:

(WebKit::WebGrammarDetail::create):

  • UIProcess/WebGrammarDetail.h:
  • UIProcess/WebPageProxy.cpp:

(WebKit::ExceededDatabaseQuotaRecords::createRecord):
(WebKit::WebPageProxy::registerEditCommand):
(WebKit::WebPageProxy::didReceiveAuthenticationChallengeProxy):
(WebKit::WebPageProxy::exceededDatabaseQuota):
(WebKit::WebPageProxy::reachedApplicationCacheOriginQuota):
(WebKit::WebPageProxy::takeViewSnapshot):

  • UIProcess/WebPageProxy.h:
  • UIProcess/WebProcessPool.cpp:

(WebKit::WebProcessPool::plugInAutoStartOriginHashes):

  • UIProcess/WebProcessPool.h:
  • UIProcess/WebProcessProxy.h:
  • UIProcess/ios/PageClientImplIOS.h:
  • UIProcess/ios/PageClientImplIOS.mm:

(-[WKEditCommandObjC initWithWebEditCommandProxy:]):
(WebKit::PageClientImpl::registerEditCommand):
(WebKit::PageClientImpl::saveImageToLibrary):
(WebKit::PageClientImpl::setDragImage):
(WebKit::PageClientImpl::takeViewSnapshot):

  • UIProcess/ios/WKGeolocationProviderIOS.mm:

(-[WKWebAllowDenyPolicyListener initWithPermissionRequestProxy:]):

  • UIProcess/ios/WebPageProxyIOS.mm:

(WebKit::WebPageProxy::saveImageToLibrary):

  • UIProcess/mac/PageClientImpl.h:
  • UIProcess/mac/PageClientImpl.mm:

(WebKit::PageClientImpl::registerEditCommand):
(WebKit::PageClientImpl::setDragImage):
(WebKit::PageClientImpl::setPromisedDataForImage):
(WebKit::PageClientImpl::takeViewSnapshot):

  • UIProcess/mac/WKImmediateActionController.mm:

(-[WKImmediateActionController _webHitTestResult]):

  • UIProcess/mac/WebPageProxyMac.mm:

(WebKit::WebPageProxy::setDragImage):
(WebKit::WebPageProxy::setPromisedDataForImage):

  • WebProcess/IconDatabase/WebIconDatabaseProxy.h:
2:56 PM Changeset in webkit [216793] by jmarcell@apple.com
  • 1 copy in tags/Safari-604.1.21.2

Tag Safari-604.1.21.2.

1:54 PM Changeset in webkit [216792] by Alan Bujtas
  • 2 edits in trunk/Source/WebCore

[iOS WK1] Do not try to layout a subframe if its document has not been constructed yet.
https://bugs.webkit.org/show_bug.cgi?id=172042
<rdar://problem/32084098>

Reviewed by Antti Koivisto.

On iOS WK1 we can end up in an inconsistent state, where

  1. the web thread is inside a newly injected iframe's document's c'tor and
  2. waiting on a delegate callback on the main thread

while the main thread

  1. executes a pending didLayout() task
  2. triggers layout on the newly injected iframe.
  • rendering/RenderWidget.cpp:

(WebCore::RenderWidget::updateWidgetPosition):

1:49 PM Changeset in webkit [216791] by commit-queue@webkit.org
  • 7 edits
    2 adds in trunk

Add UIClient callback for when picture-in-picture is activated.
https://bugs.webkit.org/show_bug.cgi?id=172023

Patch by Jeremy Jones <jeremyj@apple.com> on 2017-05-12
Reviewed by Simon Fraser.

Source/WebKit2:

Add WKUIPageClientV10 with setHasVideoInPictureInPicture.

  • UIProcess/API/APIUIClient.h:

(API::UIClient::setHasVideoInPictureInPicture):

  • UIProcess/API/C/WKPage.cpp:

(WKPageSetPageUIClient):

  • UIProcess/API/C/WKPageUIClient.h:
  • UIProcess/Cocoa/WebVideoFullscreenManagerProxy.mm:

(WebKit::WebVideoFullscreenManagerProxy::setupFullscreenWithID):
(WebKit::WebVideoFullscreenManagerProxy::fullscreenModeChanged):

Tools:

Added a test for WKPageUIClientV10 setHasVideoInPictureInPicture.

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/Tests/WebKit2Cocoa/PictureInPictureDelegate.html: Added.
  • TestWebKitAPI/Tests/WebKit2Cocoa/PictureInPictureDelegate.mm: Added.

(onLoadedCompletedCallback):
(waitUntilOnLoadIsCompleted):
(didFinishLoadForFrame):
(setHasVideoInPictureInPicture):
(TestWebKitAPI::TEST):

1:43 PM Changeset in webkit [216790] by Brent Fulgham
  • 2 edits in trunk/Source/WebKit2

REGRESSION(r213564): Flash audio playback failures
https://bugs.webkit.org/show_bug.cgi?id=171876
<rdar://problem/32082745>

Reviewed by Alexey Proskuryakov.

The IOKit property filters added in r213564 need to be expanded to support
some Flash features.

  • PluginProcess/mac/com.apple.WebKit.plugin-common.sb.in:
1:37 PM Changeset in webkit [216789] by jiewen_tan@apple.com
  • 3 edits
    2 adds in trunk

Check existence of a page before accessing its plugins
https://bugs.webkit.org/show_bug.cgi?id=171712
<rdar://problem/32007806>

Reviewed by Brent Fulgham.

Source/WebCore:

Test: plugins/navigator-plugin-crash.html

  • plugins/DOMPlugin.cpp:

(WebCore::DOMPlugin::item):
(WebCore::DOMPlugin::namedItem):

LayoutTests:

  • plugins/navigator-plugin-crash-expected.txt: Added.
  • plugins/navigator-plugin-crash.html: Added.
1:37 PM Changeset in webkit [216788] by Jonathan Bedard
  • 4 edits in trunk/Tools

Unreviewed follow-up to r216776.

  • Scripts/webkitpy/port/base.py:

(Port.path_to_crash_logs): Raise not implemented.

  • Scripts/webkitpy/port/test.py:

(TestPort.path_to_crash_logs): Return results directory as the location of crash logs.

  • Scripts/webkitpy/port/win.py:

(WinPort.path_to_crash_logs): Ditto.

1:32 PM Changeset in webkit [216787] by jmarcell@apple.com
  • 7 edits
    2 adds in branches/safari-604.1.21-branch/Source/JavaScriptCore

Cherry-pick r216460. rdar://problem/32027549

1:32 PM Changeset in webkit [216786] by ap@apple.com
  • 2 edits in trunk/Tools

Bot watcher's dashboard shows results links twice sometimes
https://bugs.webkit.org/show_bug.cgi?id=172043

Reviewed by Tim Horton.

  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:

(BuildbotTesterQueueView.prototype._presentPopoverForGenericTestFailures):

1:32 PM Changeset in webkit [216785] by jmarcell@apple.com
  • 2 edits in branches/safari-604.1.21-branch/Source/WTF

Cherry-pick r216772. rdar://problem/31969082

1:32 PM Changeset in webkit [216784] by jmarcell@apple.com
  • 5 edits in branches/safari-604.1.21-branch/Source/WebCore

Cherry-pick r216766. rdar://problem/32151246

1:32 PM Changeset in webkit [216783] by jmarcell@apple.com
  • 13 edits in branches/safari-604.1.21-branch

Cherry-pick r216349. rdar://problem/32117885

1:32 PM Changeset in webkit [216782] by jmarcell@apple.com
  • 23 edits
    3 adds in branches/safari-604.1.21-branch

Cherry-pick r216712. rdar://problem/32117885

1:32 PM Changeset in webkit [216781] by jmarcell@apple.com
  • 2 edits in branches/safari-604.1.21-branch/Source/WebKit2

Cherry-pick r216710. rdar://problem/32146527

1:31 PM Changeset in webkit [216780] by jmarcell@apple.com
  • 2 edits in branches/safari-604.1.21-branch/Source/WebCore

Cherry-pick r216215. rdar://problem/31999512

1:27 PM Changeset in webkit [216779] by Brent Fulgham
  • 5 edits in trunk/Source/WebKit2

[WK2][macOS] Add a mach-lookup exception for 'com.apple.analyticsd'
https://bugs.webkit.org/show_bug.cgi?id=172040
<rdar://problem/31765514>

Reviewed by Alexey Proskuryakov.

  • DatabaseProcess/mac/com.apple.WebKit.Databases.sb.in:
  • NetworkProcess/mac/com.apple.WebKit.NetworkProcess.sb.in:
  • PluginProcess/mac/com.apple.WebKit.plugin-common.sb.in:
  • WebProcess/com.apple.WebProcess.sb.in:
1:09 PM Changeset in webkit [216778] by Simon Fraser
  • 6 edits in trunk/Source

Add some logging for layer tree commits, and resize and orientation change events
https://bugs.webkit.org/show_bug.cgi?id=172041

Reviewed by Tim Horton.

Add some logging that's useful during rotation investigations.

Source/WebCore:

  • dom/Document.cpp:

(WebCore::Document::orientationChanged):

  • page/FrameView.cpp:

(WebCore::FrameView::sendResizeEventIfNeeded):

Source/WebKit2:

  • UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _didCommitLayerTree:]):

  • UIProcess/ios/WKContentView.mm:

(-[WKContentView _didCommitLayerTree:]):

1:09 PM Changeset in webkit [216777] by beidson@apple.com
  • 2 edits in trunk/Tools

REGRESSION (r216711): API test WKWebView.ClearAppCache is failing.
https://bugs.webkit.org/show_bug.cgi?id=172030

Unreviewed - Test gardening, in effect...

This failure is only being seen by the bots.

I believe this test is utterly broken in the first place; when it checks the .wal file's
size that is not actually an indicator that the records were deleted.

But that isn't what's coming up as failure on the bots.

This patch is an attempt to:
1 - More forcefully clear the Website data directory of leftovers before the test starts.
2 - Give an earlier indication of the failure that the bots are seeing, to possibly reveal more.

  • TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageClear.mm:

(defaultWebsiteDataDirectory):
(defaultApplicationCacheDirectory):
(TEST):

12:52 PM Changeset in webkit [216776] by Jonathan Bedard
  • 15 edits in trunk/Tools

webkitpy: Pass directory with crash logs into CrashLogs
https://bugs.webkit.org/show_bug.cgi?id=172033
<rdar://problem/32157616>

Reviewed by Daniel Bates.

Refactor CrashLogs and the callers of CrashLogs so that the port object owns
the location of crash logs.

  • Scripts/webkitpy/common/system/crashlogs.py:

(CrashLogs.init): Pass mandatory crash_log_directory when constructing.
(CrashLogs._find_newest_log_darwin): Use self._crash_log_directory instead of
generating one.
(CrashLogs._find_newest_log_win): Use self._crash_log_directory instead of
self._results_directory.
(CrashLogs._find_all_logs_darwin): Use self._crash_log_directory instead of
generating one.
(CrashLogs._log_directory_darwin): Moved to port.

  • Scripts/webkitpy/common/system/crashlogs_unittest.py: Update tests since the path

to the crash log is no longer owned by CrashLogs.

  • Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py: Use the general

directory for uploading crash logs. Note that crash logs are only supported on Mac
and Windows.

  • Scripts/webkitpy/port/apple.py: Remove unneeded CrashLogs import.
  • Scripts/webkitpy/port/base.py:

(Port.path_to_crash_logs): Unless ports declare otherwise, crash logs are assumed
to be in the results directory.

  • Scripts/webkitpy/port/darwin.py:

(DarwinPort.path_to_crash_logs): Moved from CrashLogs._log_directory_darwin.
(DarwinPort._look_for_all_crash_logs_in_log_dir): Use port specific crash log path.
(DarwinPort._get_crash_log): Ditto.

  • Scripts/webkitpy/port/darwin_testcase.py:

(DarwinTest.test_crashlog_path): Test that the Darwin ports are correctly calculating
the path to crash logs.

  • Scripts/webkitpy/port/ios_device.py:

(IOSDevicePort.path_to_crash_logs): Currently, crash log retrieval is undefined for iOS.

  • Scripts/webkitpy/port/ios_device_unittest.py:

(IOSDeviceTest.test_crashlog_path): Currently, crash log retrieval is undefined for iOS.

  • Scripts/webkitpy/port/ios_simulator.py: Remove unneeded CrashLogs import.
  • Scripts/webkitpy/port/mac.py: Ditto.
  • Scripts/webkitpy/port/test.py:

(TestDriver.run_test): Use port specific crash log path when retrieving crash logs.

  • Scripts/webkitpy/port/win.py:

(WinPort._get_crash_log): Ditto.

  • Scripts/webkitpy/tool/commands/queries.py:

(execute): Construct a port object since this is the object which owns the path to crash logs.

12:18 PM Changeset in webkit [216775] by commit-queue@webkit.org
  • 8 edits in trunk

[Readable Streams API] Add ReadableStreamBYOBReader closed getter
https://bugs.webkit.org/show_bug.cgi?id=172024

Patch by Romain Bellessort <romain.bellessort@crf.canon.fr> on 2017-05-12
Reviewed by Youenn Fablet.

LayoutTests/imported/w3c:

Updated expectations.

  • web-platform-tests/streams/readable-byte-streams/general-expected.txt: Updated.
  • web-platform-tests/streams/readable-byte-streams/general.dedicatedworker-expected.txt: Updated.

Source/WebCore:

Added tests to check closed getter behaviour.

  • Modules/streams/ReadableStreamBYOBReader.js:

(closed): Implemented.

LayoutTests:

Added tests to check closed getter behaviour.

  • streams/readable-stream-byob-reader-expected.txt: Updated.
  • streams/readable-stream-byob-reader.js: Updated.
12:14 PM Changeset in webkit [216774] by aestes@apple.com
  • 2 edits in trunk/Source/WebKit2

[Cocoa] Stop setting a status on PKPaymentRequestShippingContactUpdate when there are errors
https://bugs.webkit.org/show_bug.cgi?id=172036
<rdar://problem/31587957>

Reviewed by Anders Carlsson.

  • UIProcess/ApplePay/cocoa/WebPaymentCoordinatorProxyCocoa.mm:

(WebKit::WebPaymentCoordinatorProxy::platformCompleteShippingContactSelection):

12:10 PM Changeset in webkit [216773] by matthew_hanson@apple.com
  • 2 edits in branches/safari-604.1.21-branch/Source/WebCore

Cherry-pick r216432. rdar://problem/32051782

11:48 AM Changeset in webkit [216772] by akling@apple.com
  • 2 edits in trunk/Source/WTF

More aggressive memory kill limits.
https://bugs.webkit.org/show_bug.cgi?id=172037
<rdar://problem/31969082>

Reviewed by Michael Saboff.

Bring down the memory kill limits to 4GB for active processes, and 2GB for inactive.
Also make MemoryUsagePolicy::Strict kick in above 1.5GB.

  • wtf/MemoryPressureHandler.cpp:

(WTF::MemoryPressureHandler::thresholdForMemoryKill):
(WTF::thresholdForPolicy):

11:34 AM Changeset in webkit [216771] by akling@apple.com
  • 5 edits in trunk/Source/WebCore

MediaResourceLoader shouldn't keep its HTMLMediaElement alive.
https://bugs.webkit.org/show_bug.cgi?id=172032
<rdar://problem/30816144>

Reviewed by Joseph Pecoraro.

Use a WeakPtr<HTMLMediaElement> in MediaResourceLoader instead, since the loader
is retained by a NSURLSession object we hand over to AVFoundation.

This prevents AVFoundation from keeping entire documents alive outside our control.

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::HTMLMediaElement):

  • html/HTMLMediaElement.h:

(WebCore::HTMLMediaElement::createWeakPtr):

  • loader/MediaResourceLoader.cpp:

(WebCore::MediaResourceLoader::MediaResourceLoader):
(WebCore::MediaResourceLoader::requestResource):

  • loader/MediaResourceLoader.h:
11:21 AM Changeset in webkit [216770] by akling@apple.com
  • 2 edits in trunk/Source/WebCore

Memory pressure response should only do sync bmalloc scavenge in sync mode.
https://bugs.webkit.org/show_bug.cgi?id=172035

Reviewed by Michael Saboff.

Only call WTF::releaseFastMallocFreeMemory() and his threading-related friends
when releaseMemory() is invoked with Synchronous::Yes, or if it's a critical
pressure response (maintaining the behavior added in r215775.)

  • page/MemoryRelease.cpp:

(WebCore::releaseMemory):

10:54 AM Changeset in webkit [216769] by dbates@webkit.org
  • 9 edits in trunk/Source/WebCore

Cleanup: Use Ref instead of RefPtr to hold DOMWrapperWorld
https://bugs.webkit.org/show_bug.cgi?id=171988

Reviewed by Chris Dumez.

  • bindings/js/JSCustomElementInterface.cpp:

(WebCore::JSCustomElementInterface::JSCustomElementInterface):
(WebCore::JSCustomElementInterface::upgradeElement):
(WebCore::JSCustomElementInterface::invokeCallback):

  • bindings/js/JSCustomElementInterface.h:
  • bindings/js/JSMutationCallback.cpp:

(WebCore::JSMutationCallback::JSMutationCallback):
(WebCore::JSMutationCallback::call):

  • bindings/js/JSMutationCallback.h:
  • bindings/js/ScheduledAction.cpp:

(WebCore::ScheduledAction::ScheduledAction):
(WebCore::ScheduledAction::execute):

  • bindings/js/ScheduledAction.h:

(WebCore::ScheduledAction::ScheduledAction):

  • page/DOMWindowExtension.cpp:

(WebCore::DOMWindowExtension::DOMWindowExtension):

  • page/DOMWindowExtension.h:

(WebCore::DOMWindowExtension::world):

10:53 AM Changeset in webkit [216768] by dbates@webkit.org
  • 12 edits in trunk/Source

Cleanup: Make QueueTaskToEventLoopFunctionPtr take JSGlobalObject&
https://bugs.webkit.org/show_bug.cgi?id=172021

Reviewed by Mark Lam.

Source/JavaScriptCore:

Change the function alias for QueueTaskToEventLoopFunctionPtr to take JSGlobalObject&
instead of a const JSGlobalObject* as all implementations expect to be passed a non-
const, non-null JSGlobalObject object.

  • runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::queueMicrotask):

  • runtime/JSGlobalObject.h:
  • runtime/VM.cpp:

(JSC::VM::queueMicrotask):

  • runtime/VM.h: Remove JS_EXPORT_PRIVATE annotation from queueMicrotask() as

it is only called from JavaScriptCore code.

Source/WebCore:

  • bindings/js/JSDOMGlobalObjectTask.cpp: Include header JSDOMGlobalObject.h.

(WebCore::JSGlobalObjectTask::JSGlobalObjectTask): Change type of first argument from JSDOMGlobalObject*
to JSDOMGlobalObject& and update code as necessary. Also, use C++11 brace initialization syntax
for member initializer list.

  • bindings/js/JSDOMGlobalObjectTask.h: Remove header JSDOMGlobalObject.h and forward declare

JSDOMGlobalObject and JSC::Microtask.

  • bindings/js/JSDOMWindowBase.cpp:

(WebCore::JSDOMWindowMicrotaskCallback::create):
(WebCore::JSDOMWindowMicrotaskCallback::JSDOMWindowMicrotaskCallback): Change type of first argument
from JSDOMWindowBase* to JSDOMWindowBase& and update code as necessary. Also, use C++11 brace
initialization syntax for member initializer list.
(WebCore::JSDOMWindowBase::queueTaskToEventLoop):

  • bindings/js/JSDOMWindowBase.h:
  • bindings/js/JSWorkerGlobalScopeBase.cpp:

(WebCore::JSWorkerGlobalScopeBase::queueTaskToEventLoop):

  • bindings/js/JSWorkerGlobalScopeBase.h:
10:14 AM Changeset in webkit [216767] by Matt Lewis
  • 2 edits in trunk/LayoutTests

Marked webrtc/closing-peerconnection.html as flaky.
https://bugs.webkit.org/show_bug.cgi?id=172034

Unreviewed test gardening.

  • platform/mac-wk2/TestExpectations:
9:05 AM Changeset in webkit [216766] by jer.noble@apple.com
  • 5 edits in trunk/Source/WebCore

[MediaStream] Streams while play while page is in background can get "stuck" when page is forgrounded.
https://bugs.webkit.org/show_bug.cgi?id=172022

Reviewed by Youenn Fablet.

When an AVSampleBufferDisplayLayer is disconnected from the CA renderer, none of its samples will be decoded
and enqueued for rendering. Once the layer is attached to a renderer again, it's stuffed full of samples which
will never be decoded as their decode time has long passed.

Pass the visibility state of the element through to the MediaPlayer so that MediaPlayerPrivateMediaStreamAVFObjC
can flush its renderers when going from not visible -> visible.

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::visibilityStateChanged):

  • platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.h:
  • platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.mm:

(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::setVisible):

  • rendering/RenderVideo.cpp:

(WebCore::RenderVideo::updatePlayer):

8:37 AM Changeset in webkit [216765] by pvollan@apple.com
  • 2 edits in trunk/Source/WebCore

Unreviewed Windows build fix.

  • bindings/js/JSWebGLRenderingContextCustom.cpp:
7:33 AM Changeset in webkit [216764] by Chris Dumez
  • 34 edits in trunk/Source/WebKit2

Stop using PassRefPtr under WebKit2/Shared
https://bugs.webkit.org/show_bug.cgi?id=172017

Reviewed by Antti Koivisto.

  • Shared/API/APIDictionary.cpp:

(API::Dictionary::add):
(API::Dictionary::set):

  • Shared/API/APIDictionary.h:
  • Shared/API/APISecurityOrigin.h:

(API::SecurityOrigin::createFromString):
(API::SecurityOrigin::create):
(API::SecurityOrigin::securityOrigin):
(API::SecurityOrigin::SecurityOrigin):

  • Shared/API/APISerializedScriptValue.h:

(API::SerializedScriptValue::create):
(API::SerializedScriptValue::SerializedScriptValue):

  • Shared/API/c/WKSharedAPICast.h:

(WebKit::ProxyingRefPtr::ProxyingRefPtr):

  • Shared/APIWebArchiveResource.h:
  • Shared/APIWebArchiveResource.mm:

(API::WebArchiveResource::create):
(API::WebArchiveResource::WebArchiveResource):

  • Shared/AsyncRequest.h:

(WebKit::AsyncRequestMap::add):

  • Shared/BlobDataFileReferenceWithSandboxExtension.cpp:

(WebKit::BlobDataFileReferenceWithSandboxExtension::BlobDataFileReferenceWithSandboxExtension):

  • Shared/BlobDataFileReferenceWithSandboxExtension.h:
  • Shared/CoordinatedGraphics/CoordinatedBackingStore.cpp:

(WebKit::CoordinatedBackingStoreTile::setBackBuffer):
(WebKit::CoordinatedBackingStore::updateTile):

  • Shared/CoordinatedGraphics/CoordinatedBackingStore.h:
  • Shared/CoordinatedGraphics/CoordinatedGraphicsScene.cpp:

(WebKit::CoordinatedGraphicsScene::createUpdateAtlas):
(WebKit::CoordinatedGraphicsScene::updateImageBacking):

  • Shared/CoordinatedGraphics/CoordinatedGraphicsScene.h:
  • Shared/Plugins/Netscape/NetscapePluginModule.cpp:

(WebKit::NetscapePluginModule::getOrCreate):

  • Shared/Plugins/Netscape/NetscapePluginModule.h:
  • Shared/VisitedLinkTable.cpp:

(WebKit::VisitedLinkTable::setSharedMemory):

  • Shared/VisitedLinkTable.h:
  • Shared/WebBackForwardListItem.h:

(WebKit::WebBackForwardListItem::setSnapshot):

  • Shared/WebContextMenuItem.cpp:

(WebKit::WebContextMenuItem::create):

  • Shared/WebContextMenuItem.h:
  • Shared/WebGeolocationPosition.h:
  • Shared/WebRenderLayer.cpp:

(WebKit::WebRenderLayer::create):
(WebKit::WebRenderLayer::createArrayFromLayerList):
(WebKit::WebRenderLayer::WebRenderLayer):

  • Shared/WebRenderLayer.h:
  • Shared/WebRenderObject.cpp:

(WebKit::WebRenderObject::create):
(WebKit::WebRenderObject::WebRenderObject):

  • Shared/WebRenderObject.h:
  • UIProcess/VisitedLinkStore.cpp:

(WebKit::VisitedLinkStore::resizeTable):

  • WebProcess/WebPage/VisitedLinkTableController.cpp:

(WebKit::VisitedLinkTableController::setVisitedLinkTable):

7:15 AM Changeset in webkit [216763] by msaboff@apple.com
  • 15 edits
    2 adds in trunk/Source

[iOS] Use memory footprint to dynamically adjust behavior of allocators
https://bugs.webkit.org/show_bug.cgi?id=171944

Reviewed by Filip Pizlo.

Source/bmalloc:

This change is iOS only.

After the scavenger thread completes scavenging, it asks the OS for how much total memory the
process is using. This information is used to update the sleep delay for the scanvenger thread,
as well as to provide memory in use data for other parts of the system.

The scavenger sleep time is calculated using the following quadradic equation.

scavengerSleep = 1.2*percentFreeMemory2 - percentFreeMemory + 2

Where percentFreeMemory is between 0 and 100. The result is constrained to the values 2 and 250.

This equation empirically works out to providing a 2ms sleep time when we have less than 10%
memory available, 30ms when 20% is available and 250ms when 50% or more is available. In testing,
this exponentially agressive scavenging delay by itself reduced memory usage and made it much
more deterministic when used without the corresponding change in the JSC Heap.

Changed the scavenger thread to use the User Initiated QOS priority to ensure it doesn't
get starved.

Moved the non-Windows functionality of WTF::RAMSize() to new files AvailableMemory.{cpp,h}
and implemented in the function availableMemory(). That functions limits the value returned
on iOS to a maximum of 840MB as that is the jetsam soft memory limit.
Added a new API availableMemory() so that WTF::RAMSize() will use this value.

  • CMakeLists.txt:
  • bmalloc.xcodeproj/project.pbxproj:
  • bmalloc/BPlatform.h:
  • bmalloc/Heap.cpp:

(bmalloc::Heap::Heap):
(bmalloc::Heap::updateMemoryInUseParameters):
(bmalloc::Heap::concurrentScavenge):
(bmalloc::Heap::scavenge):

  • bmalloc/Heap.h:

(bmalloc::Heap::memoryFootprint):
(bmalloc::Heap::percentAvailableMemoryInUse):

  • bmalloc/Sizes.h:
  • bmalloc/bmalloc.h:

(bmalloc::api::availableMemory):
(bmalloc::api::memoryFootprint):
(bmalloc::api::percentAvailableMemoryInUse):

  • bmalloc/AvailableMemory.cpp: Added.

(bmalloc::computeAvailableMemory):
(bmalloc::availableMemory):

  • bmalloc/AvailableMemory.h: Added.

Source/JavaScriptCore:

This change is iOS only.

Added the ability to react to when memory usage is critical. This is defined as memory
usage being above the newly added option criticalGCMemoryThreshold. When we are in this
critical state, all collections are Full and we limit the amount of memory we allocate
between collections to 1/4th the memory above the critical threshold.

Changed the calculation of proportionalHeapSize to be based on process memory footprint
and not how big the heap is. Also, the values of Options::smallHeapRAMFraction and
Options::mediumHeapRAMFraction are overriden so that most of the heap growth is happens
using the more agressive Options::smallHeapGrowthFactor.

  • heap/Heap.cpp:

(JSC::Heap::Heap):
(JSC::Heap::overCriticalMemoryThreshold):
(JSC::Heap::shouldDoFullCollection):
(JSC::Heap::collectIfNecessaryOrDefer):

  • heap/Heap.h:
  • runtime/Options.cpp:

(JSC::overrideDefaults):
(JSC::Options::initialize):

  • runtime/Options.h:

Source/WTF:

Moved the non-Windows implementation of RAMSize() to bmalloc/AvailableMemory.cpp and
called the function availableMemory().

  • wtf/RAMSize.cpp:

(WTF::computeRAMSize):

5:58 AM Changeset in webkit [216762] by Claudio Saavedra
  • 12 edits in trunk/LayoutTests

[GTK] After upgrading glib and glib-networking, resources with zero bytes are always identified as text/plain
https://bugs.webkit.org/show_bug.cgi?id=171058

Reviewed by Carlos Garcia Campos.

GLib-based ports have issues detecting the mimetypes of empty
files, as they are all considered to be text/plain by
glib. Replace these resources with a minimal valid file for its
type (that is, 1x1 PNG files and 1 whitespace for text files).

  • fast/preloader/resources/base-image1.png:
  • fast/preloader/resources/base-image2.png:
  • fast/preloader/resources/base-image3.png:
  • fast/preloader/resources/image1.png:
  • fast/preloader/resources/link1.css:
  • fast/preloader/resources/noscript-image1.png:
  • fast/preloader/resources/noscript-image2.png:
  • fast/preloader/resources/script1.js:
  • fast/preloader/resources/style1.css:
  • tables/mozilla/core/col_widths_fix_autoFixPer.html:
  • platform/gtk/TestExpectations: Unskip the now passing tests.
5:31 AM Changeset in webkit [216761] by Antti Koivisto
  • 7 edits
    2 adds in trunk

Updating class name of a shadow host does not update the style applied by descendants of :host()
https://bugs.webkit.org/show_bug.cgi?id=170762
<rdar://problem/31572668>

Reviewed by Ryosuke Niwa.

Source/WebCore:

We need to invalidate shadow tree style when host classes or attributes change if it may be
affected by host rules.

Test: fast/shadow-dom/css-scoping-host-class-and-attribute-mutation.html

  • css/RuleSet.cpp:

(WebCore::isHostSelectorMatchingInShadowTree):
(WebCore::RuleSet::addRule):

Check if we have :host selectors that affect shadow tree.

  • css/RuleSet.h:

(WebCore::RuleSet::hasHostPseudoClassRulesMatchingInShadowTree):

  • style/AttributeChangeInvalidation.cpp:

(WebCore::Style::mayBeAffectedByHostRules):
(WebCore::Style::AttributeChangeInvalidation::invalidateStyle):

Invalidate the whole subtree if there is a class change that may affect shadow tree style.

  • style/ClassChangeInvalidation.cpp:

(WebCore::Style::mayBeAffectedByHostRules):
(WebCore::Style::ClassChangeInvalidation::invalidateStyle):

  • style/IdChangeInvalidation.cpp:

(WebCore::Style::mayBeAffectedByHostRules):
(WebCore::Style::IdChangeInvalidation::invalidateStyle):

Same for classes and ids.
This should be refactored at some point to reduce copy-code.

LayoutTests:

  • fast/shadow-dom/css-scoping-host-class-and-attribute-mutation-expected.html: Added.
  • fast/shadow-dom/css-scoping-host-class-and-attribute-mutation.html: Added.
4:53 AM Changeset in webkit [216760] by Claudio Saavedra
  • 2 edits in trunk/LayoutTests

[WPE] Unreviewed gardening.

ClientRect, ClientRectList were removed, PromiseRejectionEvent was
added, update global constructors attributes test expectations.

  • platform/wpe/js/dom/global-constructors-attributes-expected.txt:
4:42 AM Changeset in webkit [216759] by Carlos Garcia Campos
  • 4 edits in trunk

[GTK] ASSERTION FAILED: !m_flushingLayers
https://bugs.webkit.org/show_bug.cgi?id=172025

Reviewed by Žan Doberšek.

Source/WebCore:

The problem is that syncImageBacking() is calling didChangeLayerState(). All sync methods are called by
flushCompositingStateForThisLayerOnly() while flushing layers, so none of them should call didChange method that
will schedule a new flush while flushing.

  • platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp:

(WebCore::CoordinatedGraphicsLayer::syncImageBacking):

LayoutTests:

  • platform/gtk/TestExpectations:
3:29 AM Changeset in webkit [216758] by Carlos Garcia Campos
  • 3 edits
    2 adds in trunk

[GTK] GIF images are not properly loaded the first time
https://bugs.webkit.org/show_bug.cgi?id=170432

Reviewed by Carlos Alberto Lopez Perez.

Source/WebCore:

When the GIF image is loaded for the first time, it's always read from the network, and the decoder is usually
fetched with chunks of data. Then the data is cached in disk by the network process, so that when loaded from
the cache, the whole encoded data is available to fetch the encoder. The problem is that we are failing to
decode the image when giving chunks of data, that's why it only happens the first time loaded. If the first
chunk of data provided is enough to get some metadata, including the size, but not frame contents, the load fails
in CachedImage::addIncrementalDataBuffer() because the EncodedDataStatus reported is SizeAvailable but
Image::isNull() returns true. An Image is considered to be Null when its size is empty, and the size is
calculated always using the first frame in ImageFrameCache. Since we still don't have frames, the image is
always Null in this case. It is not expected that EncodedDataStatus returns SizeAvailable and the image is Null,
that's why it's considered an error and the load finishes with a decode error. However, the non CG ImageDecoder
has a m_size member to handle this particular case, and it's when m_size is set when EncodedDataStatus changes
to SizeAvailable. We should return the ImageEncoder size as the ImageSize when we have a decoder but
not frames yet.

Test: http/tests/images/gif-progressive-load.html

  • platform/graphics/ImageFrameCache.cpp:

(WebCore::ImageFrameCache::size): Return ImageDecoder::size() without caching it, if frame list is empty.

LayoutTests:

  • http/tests/images/gif-progressive-load-expected.html: Added.
  • http/tests/images/gif-progressive-load.html: Added.
3:08 AM Changeset in webkit [216757] by pvollan@apple.com
  • 2 edits in trunk/Source/WebCore

The iBooks application is not able to get current position.
https://bugs.webkit.org/show_bug.cgi?id=171982
rdar://problem/29318409

Reviewed by Brent Fulgham.

Geolocation requests from iBooks are currently blocked. Make an exemption from the policy for iBooks.

No new tests since we currently can't mock the iBooks application bundle ID.

  • Modules/geolocation/Geolocation.cpp:

(WebCore::isRequestFromIBooks):
(WebCore::Geolocation::shouldBlockGeolocationRequests):

2:43 AM Changeset in webkit [216756] by Manuel Rego Casasnovas
  • 6 edits in trunk/LayoutTests

[selectors4] css/selectors4/focus-within-006.html test from WPT is failing
https://bugs.webkit.org/show_bug.cgi?id=170900

Reviewed by Sergio Villar Senin.

LayoutTests/imported/w3c:

The issue has been fixed in WPT repo:
https://github.com/w3c/web-platform-tests/pull/5786

This patch is importing the changes so we can close this bug on WebKit.

  • web-platform-tests/css/selectors4/focus-within-006-expected.html:
  • web-platform-tests/css/selectors4/focus-within-006.html:
  • web-platform-tests/css/selectors4/w3c-import.log:

LayoutTests:

2:01 AM Changeset in webkit [216755] by Claudio Saavedra
  • 2 edits in trunk/Source/WTF

[WPE] Add MemoryFootprintLinux to build

Unreviewed build fix after r216731.

  • wtf/PlatformWPE.cmake:
2:00 AM Changeset in webkit [216754] by commit-queue@webkit.org
  • 1 edit
    39 adds in trunk/PerformanceTests

Speedometer: Add a React.js TodoMVC implementation
https://bugs.webkit.org/show_bug.cgi?id=171444

Patch by Addy Osmani <addyosmani@gmail.com> on 2017-05-12
Reviewed by Ryosuke Niwa.

Adds a more recent React.js TodoMVC implemenation to Speedometer

  • Speedometer/resources/todomvc/architecture-examples/react/build.min.js: Added.
  • Speedometer/resources/todomvc/architecture-examples/react/index.html: Added.
  • Speedometer/resources/todomvc/architecture-examples/react/js/app.jsx: Added.
  • Speedometer/resources/todomvc/architecture-examples/react/license.md: Added.
  • Speedometer/resources/todomvc/architecture-examples/react/node_modules/classnames/LICENSE: Added.
  • Speedometer/resources/todomvc/architecture-examples/react/node_modules/classnames/bind.js: Added.
  • Speedometer/resources/todomvc/architecture-examples/react/node_modules/classnames/bower.json: Added.
  • Speedometer/resources/todomvc/architecture-examples/react/node_modules/classnames/dedupe.js: Added.
  • Speedometer/resources/todomvc/architecture-examples/react/node_modules/classnames/index.js: Added.
  • Speedometer/resources/todomvc/architecture-examples/react/node_modules/classnames/package.json: Added.
  • Speedometer/resources/todomvc/architecture-examples/react/node_modules/director/LICENSE: Added.
  • Speedometer/resources/todomvc/architecture-examples/react/node_modules/director/bower.json: Added.
  • Speedometer/resources/todomvc/architecture-examples/react/node_modules/director/package.json: Added.
  • Speedometer/resources/todomvc/architecture-examples/react/node_modules/react-dom/LICENSE: Added.
  • Speedometer/resources/todomvc/architecture-examples/react/node_modules/react-dom/dist/react-dom-server.min.js: Added.
  • Speedometer/resources/todomvc/architecture-examples/react/node_modules/react-dom/dist/react-dom.min.js: Added.
  • Speedometer/resources/todomvc/architecture-examples/react/node_modules/react-dom/index.js: Added.
  • Speedometer/resources/todomvc/architecture-examples/react/node_modules/react/LICENSE: Added.
  • Speedometer/resources/todomvc/architecture-examples/react/node_modules/react/README.md: Added.
  • Speedometer/resources/todomvc/architecture-examples/react/node_modules/react/dist/react-with-addons.min.js: Added.
  • Speedometer/resources/todomvc/architecture-examples/react/node_modules/react/dist/react.min.js: Added.
  • Speedometer/resources/todomvc/architecture-examples/react/node_modules/react/package.json: Added.
  • Speedometer/resources/todomvc/architecture-examples/react/node_modules/todomvc-app-css/index.css: Added.
  • Speedometer/resources/todomvc/architecture-examples/react/node_modules/todomvc-common/base.css: Added.
  • Speedometer/resources/todomvc/architecture-examples/react/node_modules/todomvc-common/base.js: Added.
  • Speedometer/resources/todomvc/architecture-examples/react/npm-shrinkwrap.json: Added.
  • Speedometer/resources/todomvc/architecture-examples/react/package.json: Added.
  • Speedometer/resources/todomvc/architecture-examples/react/yarn.lock: Added.
1:08 AM Changeset in webkit [216753] by pvollan@apple.com
  • 3 edits
    2 adds in trunk

Geolocation requests should not be blocked when the security origin is local.
https://bugs.webkit.org/show_bug.cgi?id=171857
Source/WebCore:

rdar://problem/29318409

Reviewed by Brent Fulgham.

Geolocation requests from security origins where the url scheme is registered as local,
should not be blocked. This applies to the file url scheme, but also to other local url
schemes.

Test: fast/misc/geolocation-local-security-origin.html

  • Modules/geolocation/Geolocation.cpp:

(WebCore::Geolocation::shouldBlockGeolocationRequests):

LayoutTests:

Reviewed by Brent Fulgham.

  • fast/misc/geolocation-local-security-origin-expected.txt: Added.
  • fast/misc/geolocation-local-security-origin.html: Added.
12:52 AM Changeset in webkit [216752] by jmarcell@apple.com
  • 5 edits in branches/safari-604.1.21-branch/Source

Cherry-pick r216691. rdar://problem/32136567

12:52 AM Changeset in webkit [216751] by jmarcell@apple.com
  • 2 edits in branches/safari-604.1.21-branch/Source/WebCore

Cherry-pick r216650. rdar://problem/32111991

12:52 AM Changeset in webkit [216750] by jmarcell@apple.com
  • 2 edits in branches/safari-604.1.21-branch/Source/WebCore

Cherry-pick r216645. rdar://problem/31995807

12:52 AM Changeset in webkit [216749] by jmarcell@apple.com
  • 2 edits in branches/safari-604.1.21-branch/Source/WebCore

Cherry-pick r216623. rdar://problem/32116336

12:52 AM Changeset in webkit [216748] by jmarcell@apple.com
  • 2 edits in branches/safari-604.1.21-branch/Source/WebKit2

Cherry-pick r216616. rdar://problem/32116375

12:52 AM Changeset in webkit [216747] by jmarcell@apple.com
  • 16 edits in branches/safari-604.1.21-branch/Source/WebKit2

Cherry-pick r216612. rdar://problem/32080713

12:52 AM Changeset in webkit [216746] by jmarcell@apple.com
  • 8 edits
    2 adds in branches/safari-604.1.21-branch

Cherry-pick r216599. rdar://problem/31201793

12:52 AM Changeset in webkit [216745] by jmarcell@apple.com
  • 2 edits in branches/safari-604.1.21-branch/Source/WebCore

Cherry-pick r216559. rdar://problem/31771707

12:52 AM Changeset in webkit [216744] by jmarcell@apple.com
  • 3 edits in branches/safari-604.1.21-branch/Source/WebKit/win

Cherry-pick r216554. rdar://problem/27362159

12:52 AM Changeset in webkit [216743] by jmarcell@apple.com
  • 29 edits
    5 adds in branches/safari-604.1.21-branch

Cherry-pick r216541. rdar://problem/27362159

12:52 AM Changeset in webkit [216742] by jmarcell@apple.com
  • 13 edits
    3 adds in branches/safari-604.1.21-branch

Cherry-pick r216279. rdar://problem/31735695

12:52 AM Changeset in webkit [216741] by jmarcell@apple.com
  • 16 edits in branches/safari-604.1.21-branch/Source

Cherry-pick r216216. rdar://problem/31814074

12:52 AM Changeset in webkit [216740] by jmarcell@apple.com
  • 26 edits
    1 add in branches/safari-604.1.21-branch

Cherry-pick r216212. rdar://problem/31544320

12:51 AM Changeset in webkit [216739] by jmarcell@apple.com
  • 33 edits
    2 adds in branches/safari-604.1.21-branch

Cherry-pick r216197. rdar://problem/31821492

12:50 AM Changeset in webkit [216738] by Carlos Garcia Campos
  • 2 edits in trunk/Tools

Unreviewed. Fix GTK+ test /webkit2/WebKitWebView/create-navigation-data after r216615.

In r216615 the custom code for window.open() was removed. The generated code now correctly handles the optional
URL parameter using the default value "about:blank" when not provided.

  • TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp:

(testWebViewCreateNavigationData):

12:48 AM Changeset in webkit [216737] by Csaba Osztrogonác
  • 2 edits in trunk/Source/WTF

Unreviewed trivial JSCOnly buildfix after r216731.
https://bugs.webkit.org/show_bug.cgi?id=171693

  • wtf/PlatformJSCOnly.cmake:
Note: See TracTimeline for information about the timeline view.