⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



May 14, 2017:

11:20 PM Changeset in webkit [216857] by pvollan@apple.com
  • 6 edits in trunk

[Win] fast/cookies/local-file-can-set-cookies.html is flaky.
​https://bugs.webkit.org/show_bug.cgi?id=172071

Reviewed by Alexey Proskuryakov.

Source/WebKit/win:

We need to delete all cookies after each test.

  • Interfaces/IWebPreferencesPrivate.idl:
  • WebPreferences.cpp:

(WebPreferences::linkPreloadEnabled):
(WebPreferences::clearNetworkLoaderSession):

  • WebPreferences.h:

Tools:

  • DumpRenderTree/win/DumpRenderTree.cpp:

(resetWebPreferencesToConsistentValues):

10:51 PM Changeset in webkit [216856] by zandobersek@gmail.com
  • 2 edits in trunk/Source/WebCore

Unreviewed build fix with newer Perl versions.

  • bindings/scripts/CodeGeneratorJS.pm:

(AddLegacyCallerOperationIfNeeded): Support for experimental push on scalar (and
other auto-dereferencing) was removed in Perl 5.24. Instead, the LegacyCallers array
has to be dereferenced when pushing new values to it.

10:00 PM Changeset in webkit [216855] by jcraig@apple.com
  • 2 edits in trunk/Websites/webkit.org

2017-05-14 James Craig <​jcraig@apple.com>

AX: All the articles on the WebKit blog are called 'Clickable Link' by VoiceOver
​https://bugs.webkit.org/show_bug.cgi?id=172096
<rdar://problem/31624323>

Unreviewed. Fixing broken link titles for screen readers.

  • wp-content/themes/webkit/loop.php: Adding relevant link label for accessibility.
8:45 PM Changeset in webkit [216854] by bshafiei@apple.com
  • 3 edits in tags/Safari-604.1.22.0.1/Source/WebCore

Merged r216807. rdar://problem/32169232

8:44 PM Changeset in webkit [216853] by bshafiei@apple.com
  • 7 edits in tags/Safari-604.1.22.0.1/Source

Versioning.

8:42 PM Changeset in webkit [216852] by bshafiei@apple.com
  • 1 copy in tags/Safari-604.1.22.0.1

New tag.

6:09 PM Changeset in webkit [216851] by weinig@apple.com
  • 22 edits
    2 adds
    1 delete in trunk

[WebIDL/DOM] Remove need for custom bindings for HTMLAllCollection and bring up to spec
​https://bugs.webkit.org/show_bug.cgi?id=172095

Reviewed by Darin Adler.

LayoutTests/imported/w3c:

  • web-platform-tests/html/infrastructure/common-dom-interfaces/collections/htmlallcollection-expected.txt:

Update results.

Source/WebCore:

  • Adds support for the legacycaller WebIDL special annotation.
  • Updates implementation of HTMLAllCollection to match the current HTML spec.

Test: fast/dom/document-all.html

  • CMakeLists.txt:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSBindingsAllInOne.cpp:
  • bindings/js/JSHTMLAllCollectionCustom.cpp: Removed.

Removed JSHTMLAllCollectionCustom.cpp

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateInterface):
(AddLegacyCallerOperationIfNeeded):
Before code generation, clone all the legacycaller operations and put them
in their own set, so they can form an overload set.

(AddStringifierOperationIfNeeded):
Use IDLParser::cloneType as the FIXME suggested.

(GenerateHeader):
Group call related functionality together and use new IsCallable predicate.

(GenerateOverloadedFunctionOrConstructor):
Generalize a little bit to allow the function being overloaded to be an overloaded legacycaller.

(GenerateImplementation):
Add call to generate the legacycaller code.

(GenerateLegacyCallerDefinitions):
(GenerateLegacyCallerDefinition):
Generate the legacycaller definition, using GenerateArgumentsCountCheck, GenerateParametersCheck
and GenerateImplementationFunctionCall to do all the heavy lifting.

(IsCallable):
Add helper predicate for both custom calls and legacycaller.

  • bindings/scripts/IDLParser.pm:

(cloneType):.
(cloneArgument):.
(cloneOperation):
Add cloning functions for IDLArgument and IDLOperation, and make IDLType's
clone feasible for calling outside the package by removing the unneeded
self parameter.

  • bindings/scripts/test/JS/JSTestObj.cpp
  • bindings/scripts/test/JS/JSTestObj.h
  • bindings/scripts/test/TestObj.idl:

Add testing of legacycaller overloading.

  • dom/Document.cpp:

(WebCore::Document::allFilteredByName):

  • dom/Document.h:

Add new collection access for the HTMLAllNamedSubCollection.

  • html/CachedHTMLCollection.h:

(WebCore::nameShouldBeVisibleInDocumentAll):
Update list of tags to match the current spec.

  • html/CollectionType.h:

Add new type for HTMLAllNamedSubCollection.

  • html/GenericCachedHTMLCollection.cpp:

(WebCore::GenericCachedHTMLCollection<traversalType>::elementMatches):
Specify that DocumentAllNamedItems does not want
the default elementMatches.

  • html/HTMLAllCollection.cpp:

(WebCore::HTMLAllCollection::namedOrIndexedItemOrItems):
(WebCore::HTMLAllCollection::namedItemOrItems):
(WebCore::HTMLAllNamedSubCollection::~HTMLAllNamedSubCollection):
(WebCore::HTMLAllNamedSubCollection::elementMatches):

  • html/HTMLAllCollection.h:

Move implementations from the custom binding, and re-implement to
match the spec. Alternate names to item/namedItem were needed to not
shadow the existing ones in HTMLCollection. HTMLAllNamedSubCollection
is a simple HTMLCollection that matches on a name, following the rules
of document.all about which tags can have name attributes.

  • html/HTMLAllCollection.idl:

Remove custom annotations and add legacycaller which is now supported.

  • html/HTMLCollection.cpp:

(WebCore::invalidationTypeExcludingIdAndNameAttributes):
(WebCore::HTMLCollection::~HTMLCollection):
Add DocumentAllNamedItems.

LayoutTests:

  • fast/dom/collection-null-like-arguments-expected.txt:

Update results.

  • fast/dom/document-all-expected.txt: Added.
  • fast/dom/document-all.html: Added.

New test that covers a bunch of missing coverage.

5:46 PM Changeset in webkit [216850] by commit-queue@webkit.org
  • 3 edits
    6 deletes in trunk/Source/WebKit2

[CoordinatedGraphics] Remove unused files and lines
​https://bugs.webkit.org/show_bug.cgi?id=172080

Patch by Daewoong Jang <​daewoong.jang@navercorp.com> on 2017-05-14
Reviewed by Darin Adler.

  • Shared/CoordinatedGraphics/CoordinatedGraphicsArgumentCoders.cpp: Removed.
  • Shared/CoordinatedGraphics/CoordinatedGraphicsArgumentCoders.h: Removed.
  • Shared/CoordinatedGraphics/WebCoordinatedSurface.cpp: Removed.
  • Shared/CoordinatedGraphics/WebCoordinatedSurface.h: Removed.
  • UIProcess/CoordinatedGraphics/WKCoordinatedSceneAPICast.h: Removed.
  • UIProcess/WebPageProxy.h:
  • WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.cpp:
  • WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.messages.in: Removed.
2:16 PM Changeset in webkit [216849] by Alan Bujtas
  • 3 edits in trunk/Source/WebCore

Remove unused lambda in TextFragmentIterator::TextFragment::split() and cleanup dependencies.
​https://bugs.webkit.org/show_bug.cgi?id=172089

Reviewed by David Kilzer.

  • rendering/SimpleLineLayout.cpp:

(WebCore::SimpleLineLayout::splitFragmentToFitLine):

  • rendering/SimpleLineLayoutTextFragmentIterator.h:

(WebCore::SimpleLineLayout::TextFragmentIterator::TextFragment::split):
(WebCore::SimpleLineLayout::TextFragmentIterator::TextFragment::splitWithHyphen):

1:10 PM Changeset in webkit [216848] by jmarcell@apple.com
  • 7 edits in branches/safari-604.1.21-branch/Source

Versioning.

12:27 PM Changeset in webkit [216847] by akling@apple.com
  • 2 edits in trunk/Source/WebKit2

Always reset the assisted node when the main frame commits a new load.
​https://bugs.webkit.org/show_bug.cgi?id=172088

Reviewed by Antti Koivisto.

WebPage::m_assistedNode could extend the lifetime of the document it pointed into
if the main frame was navigated while the assisted node was in one of its subframes.
The life-supported document wouldn't be reachable from JavaScript but nevertheless
would consume memory and other resources.

This patch fixes the issue by always clearing WebPage::m_assistedNode when the main
frame commits a new load.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::resetAssistedNodeForFrame):

10:43 AM Changeset in webkit [216846] by ddkilzer@apple.com
  • 3 edits in trunk/LayoutTests

[iOS/macOS Debug WK2] LayoutTests/imported/w3c/web-platform-tests/webrtc/interfaces.html is a flaky crash due to assertion failure
<​https://bugs.webkit.org/show_bug.cgi?id=172094>
<rdar://problem/32184256>

Unreviewed test gardening.

  • platform/ios-wk2/TestExpectations:
  • platform/mac-wk2/TestExpectations:
  • Mark test as flaky crash on Debug WK2 builds.
9:36 AM Changeset in webkit [216845] by matthew_hanson@apple.com
  • 1 copy in tags/Safari-604.1.21.3

Tag Safari-604.1.21.3.

6:27 AM Changeset in webkit [216844] by Csaba Osztrogonác
  • 2 edits in trunk/Source/WebKit2

Unreviewed Mac cmake buildfix after r216690, just for fun.

  • PlatformMac.cmake:
4:28 AM Changeset in webkit [216843] by ddkilzer@apple.com
  • 2 edits in trunk/LayoutTests

[macOS Debug WK1] fast/parser/adoption-agency-unload-iframe-4.html is a flaky timeout (always on iOS 10 Release WK1)
<​https://webkit.org/b/172092>

Unreviewed test gardening.

  • platform/ios-wk1/TestExpectations:
  • This only times out on Release builds.
4:16 AM Changeset in webkit [216842] by ddkilzer@apple.com
  • 3 edits in trunk/LayoutTests

[macOS Debug WK1] fast/parser/adoption-agency-unload-iframe-4.html is a flaky timeout (always on iOS 10 Release WK1)
<​https://webkit.org/b/172092>

Unreviewed test gardening.

See also Bug 169211 for a similar GTK WK1 timeout.

  • platform/ios-wk1/TestExpectations:
  • Mark as always timing out on all builds.
  • platform/mac-wk1/TestExpectations:
  • Mark flaky on Debug builds.
3:41 AM Changeset in webkit [216841] by ddkilzer@apple.com
  • 9 edits in trunk/Source/WebKit2

Fix unused lambdas in WebKit2
<​https://webkit.org/b/172090>

Reviewed by Chris Dumez.

Fixes unused lambda warnings found with newer clang.

  • NetworkProcess/cache/NetworkCache.cpp:

(WebKit::NetworkCache::Cache::retrieve):

  • NetworkProcess/cache/NetworkCacheStatistics.cpp:

(WebKit::NetworkCache::Statistics::initialize):

  • Use UNUSED_PARAM() to silence unused lambda warning since 'startTime' is used in Debug builds.
  • NetworkProcess/capture/NetworkCaptureManager.cpp:

(WebKit::NetworkCapture::Manager::fuzzyMatchURLs):

  • Remove unused 'this' from lambda capture.
  • NetworkProcess/cocoa/NetworkSessionCocoa.mm:

(-[WKNetworkSessionDelegate URLSession:task:willPerformHTTPRedirection:newRequest:completionHandler:]):
(-[WKNetworkSessionDelegate URLSession:task:_schemeUpgraded:completionHandler:]):
(-[WKNetworkSessionDelegate URLSession:task:didReceiveChallenge:completionHandler:]):
(-[WKNetworkSessionDelegate URLSession:dataTask:didReceiveResponse:completionHandler:]):

  • Use UNUSED_PARAM() to silence unused lambda warning since 'taskIdentifier' is used in Debug builds.
  • UIProcess/WebResourceLoadStatisticsStore.cpp:

(WebKit::WebResourceLoadStatisticsStore::registerSharedResourceLoadObserver):
(WebKit::WebResourceLoadStatisticsStore::applicationWillTerminate):

  • Remove unused 'this' from lambda captures.
  • UIProcess/WebsiteData/WebsiteDataStore.cpp:

(WebKit::WebsiteDataStore::fetchData):

  • Remove unused 'fetchOptions' from lambda capture.

(WebKit::WebsiteDataStore::fetchDataForTopPrivatelyControlledDomains):

  • Remove unused 'this' from lambda capture.
  • UIProcess/mac/ViewGestureControllerMac.mm:

(WebKit::ViewGestureController::forceRepaintIfNeeded):

  • Remove unused 'this' from lambda capture.
  • WebProcess/cocoa/WebVideoFullscreenManager.mm:

(WebKit::WebVideoFullscreenManager::didExitFullscreen):

  • Remove unused 'this' from nested lambda captures.
1:18 AM Changeset in webkit [216840] by rniwa@webkit.org
  • 2 edits in trunk/Websites/perf.webkit.org

Build fix. Added a missing null check.

  • public/v3/pages/analysis-task-page.js:

(AnalysisTaskConfiguratorPane.prototype.setTestGroups):

12:31 AM Changeset in webkit [216839] by Chris Dumez
  • 11 edits
    1 delete in trunk

Drop PassRefPtr class from WTF
​https://bugs.webkit.org/show_bug.cgi?id=172091

Reviewed by Alex Christensen.

Source/WTF:

Drop PassRefPtr class from WTF as it is no longer used or needed.
Also drop RefPtr::release() for the same reasons.

  • WTF.xcodeproj/project.pbxproj:
  • wtf/CMakeLists.txt:
  • wtf/CrossThreadCopier.cpp:
  • wtf/CrossThreadCopier.h:
  • wtf/Forward.h:
  • wtf/PassRefPtr.h: Removed.
  • wtf/RefPtr.h:

(WTF::refIfNotNull):
(WTF::derefIfNotNull):
(WTF::RefPtr::RefPtr):
(WTF::RefPtr::release): Deleted.

  • wtf/SizeLimits.cpp:
  • wtf/Vector.h:

Tools:

Drop API test coverage.

  • TestWebKitAPI/Tests/WTF/Ref.cpp:

(TestWebKitAPI::TEST):
(TestWebKitAPI::passWithPassRefPtr): Deleted.

May 13, 2017:

11:05 PM Changeset in webkit [216838] by ddkilzer@apple.com
  • 2 edits in trunk/Source/WebCore

Unused lambda in JSWebKitSubtleCrypto::wrapKey()
<​https://webkit.org/b/172087>

Reviewed by Chris Dumez.

Fixes the following warning with newer clang:

Source/WebCore/bindings/js/JSWebKitSubtleCryptoCustom.cpp:594:35: error: lambda capture 'keyFormat' is not used [-Werror,-Wunused-lambda-capture]

auto exportSuccessCallback = [keyFormat, algorithm, parameters, wrappingKey, wrapper](const Vector<uint8_t>& exportedKeyData) mutable {


  • bindings/js/JSWebKitSubtleCryptoCustom.cpp:

(WebCore::JSWebKitSubtleCrypto::wrapKey): Remove unused lambda.

10:37 PM Changeset in webkit [216837] by ddkilzer@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Unused lambda capture in JSContextGroupAddMarkingConstraint()
<​https://webkit.org/b/172084>

Reviewed by Saam Barati.

Fixes the following warning with newer clang:

Source/JavaScriptCore/API/JSMarkingConstraintPrivate.cpp:78:11: error: lambda capture 'vm' is not used [-Werror,-Wunused-lambda-capture]

[&vm, constraintCallback, userData]


  • API/JSMarkingConstraintPrivate.cpp:

(JSContextGroupAddMarkingConstraint): Remove unused lambda
capture for '&vm'.

10:27 PM Changeset in webkit [216836] by eric.carlson@apple.com
  • 39 edits
    2 adds in trunk

[MediaStream] deviceId constraint doesn't work with getUserMedia
​https://bugs.webkit.org/show_bug.cgi?id=171877
<rdar://problem/31899730>

Reviewed by Jer Noble.

Source/WebCore:

Test: fast/mediastream/get-user-media-device-id.html

  • Modules/mediastream/MediaConstraintsImpl.h:

(WebCore::MediaConstraintsData::MediaConstraintsData): Add a constructor that
takes a const MediaConstraints&.

  • Modules/mediastream/MediaDevices.cpp:

(WebCore::MediaDevices::~MediaDevices): m_deviceChangedToken is a std::optional<>.

  • Modules/mediastream/MediaDevices.h:
  • Modules/mediastream/MediaDevicesEnumerationRequest.cpp:

(WebCore::MediaDevicesEnumerationRequest::topLevelDocumentOrigin): Don't return
NULL for the main frame so the origin matches that returned for a UserMediaRequest.

  • Modules/mediastream/UserMediaController.h:

(WebCore::UserMediaController::setDeviceIDHashSalt): Deleted, not used.
(WebCore::UserMediaController::deviceIDHashSalt): Deleted, not used.

  • Modules/mediastream/UserMediaRequest.cpp:

(WebCore::UserMediaRequest::allow): Add device ID hash salt parameter, set it on
constraints.

  • Modules/mediastream/UserMediaRequest.h:
  • platform/mediastream/MediaConstraints.h:
  • platform/mediastream/RealtimeMediaSource.cpp:

(WebCore::RealtimeMediaSource::fitnessDistance): ASSERT if called for DeviceId.
(WebCore::RealtimeMediaSource::selectSettings): Special case DeviceId because it
we have to hash the device ID before comparing, and because the DeviceId can't be
changed so it should never be added to the flattened constraints.
(WebCore::RealtimeMediaSource::supportsConstraints):
(WebCore::RealtimeMediaSource::applyConstraints):

  • platform/mediastream/RealtimeMediaSource.h:
  • platform/mediastream/RealtimeMediaSourceCenter.cpp:

(WebCore::RealtimeMediaSourceCenter::validateRequestConstraints): Implement.

  • platform/mediastream/RealtimeMediaSourceCenter.h:
  • platform/mediastream/RealtimeMediaSourceSupportedConstraints.cpp:

(WebCore::RealtimeMediaSourceSupportedConstraints::nameForConstraint): Deleted, unused.
(WebCore::RealtimeMediaSourceSupportedConstraints::constraintFromName): Deleted, unused.

  • platform/mediastream/RealtimeMediaSourceSupportedConstraints.h:
  • platform/mediastream/mac/AVVideoCaptureSource.mm:
  • platform/mediastream/mac/RealtimeMediaSourceCenterMac.cpp:

(WebCore::RealtimeMediaSourceCenterMac::bestSourcesForTypeAndConstraints): Pass device
id, not empty string.
(WebCore::RealtimeMediaSourceCenterMac::validateRequestConstraints): Deleted.

  • platform/mediastream/mac/RealtimeMediaSourceCenterMac.h:
  • platform/mock/MockRealtimeMediaSourceCenter.cpp:

(WebCore::MockRealtimeMediaSourceCenter::validateRequestConstraints): Deleted.

  • platform/mock/MockRealtimeMediaSourceCenter.h:

Source/WebKit2:

  • Shared/WebCoreArgumentCoders.cpp:

(IPC::ArgumentCoder<MediaConstraintsData>::encode): Encode deviceIDHashSalt.
(IPC::ArgumentCoder<MediaConstraintsData>::decode): Decode deviceIDHashSalt.

  • UIProcess/UserMediaPermissionCheckProxy.cpp:

(WebKit::UserMediaPermissionCheckProxy::UserMediaPermissionCheckProxy): Initialize
completion handler, frame ID, and security origins.
(WebKit::UserMediaPermissionCheckProxy::setUserMediaAccessInfo): Complete by calling
completion handler because we now sometimes request access info before calling gUM.
(WebKit::UserMediaPermissionCheckProxy::invalidate): Clear completion handler.

  • UIProcess/UserMediaPermissionCheckProxy.h:
  • UIProcess/UserMediaPermissionRequestManagerProxy.cpp:

(WebKit::FrameAuthorizationState::FrameAuthorizationState): Take security origins, not
UserMediaPermissionRequestProxy, so it can be constructed with a UserMediaPermissionCheckProxy.
(WebKit::FrameAuthorizationState::ensureSecurityOriginsAreEqual): Ditto. Clear has salt
when origins don't match.
(WebKit::UserMediaPermissionRequestManagerProxy::stateForRequest): Templatize.
(WebKit::UserMediaPermissionRequestManagerProxy::userMediaAccessWasDenied): Fix typo.
(WebKit::UserMediaPermissionRequestManagerProxy::userMediaAccessWasGranted): Ditto.
Don't set state for empty UIDs. Pass hash salt to web process.
(WebKit::UserMediaPermissionRequestManagerProxy::requestUserMediaPermissionForFrame):
The device ID hash salt is now required to validate constraints, so get it first.
(WebKit::UserMediaPermissionRequestManagerProxy::getUserMediaPermissionInfo): Helper
method used to get the device ID hash salt.
(WebKit::UserMediaPermissionRequestManagerProxy::enumerateMediaDevicesForFrame): Restructure
to use getUserMediaPermissionInfo.
(WebKit::UserMediaPermissionRequestManagerProxy::didCompleteUserMediaPermissionCheck): Deleted.

  • UIProcess/UserMediaPermissionRequestManagerProxy.h:
  • WebProcess/MediaStream/UserMediaPermissionRequestManager.cpp:

(WebKit::UserMediaPermissionRequestManager::userMediaAccessWasGranted): Add device ID
hash salt parameter.

  • WebProcess/MediaStream/UserMediaPermissionRequestManager.h:
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::userMediaAccessWasGranted): Ditto.

  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebPage/WebPage.messages.in:
  • WebProcess/cocoa/UserMediaCaptureManager.cpp:

(WebKit::UserMediaCaptureManager::createCaptureSource): Use new MediaConstraintsData
constructor.

Tools:

The device ID hash salt is now required for getUserMedia to check deviceId constraint, so
implement the "checkUserMediaPermission" callback.

  • TestWebKitAPI/Tests/WebKit2/UserMedia.cpp:

(TestWebKitAPI::decidePolicyForUserMediaPermissionRequestCallBack):
(TestWebKitAPI::checkUserMediaPermissionCallback):
(TestWebKitAPI::TEST):

  • TestWebKitAPI/Tests/WebKit2Cocoa/UserMediaDisabled.mm:

(-[UserMediaUIDelegate _webView:checkUserMediaPermissionForURL:mainFrameURL:frameIdentifier:decisionHandler:]):

LayoutTests:

  • fast/mediastream/get-user-media-device-id-expected.txt: Added.
  • fast/mediastream/get-user-media-device-id.html: Added.
  • fast/mediastream/apply-constraints-video-expected.txt: Updated.
  • fast/mediastream/apply-constraints-video.html: Ditto.
10:21 PM Changeset in webkit [216835] by ddkilzer@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

[JSC] config.rb fails when checking some clang versions
<​https://webkit.org/b/172082>

Reviewed by Mark Lam.

  • offlineasm/config.rb:
  • Add support for quad-dotted version of Apple clang (800.0.12.1).
  • Add support for checking open source clang version (5.0.0).
9:27 PM Changeset in webkit [216834] by ddkilzer@apple.com
  • 2 edits in trunk/LayoutTests

TestExpectations: Remove last refereneces to Legacy Notifications

Unreviewed test gardening fixes these lint warnings:

LayoutTests/TestExpectations:1222 Path does not exist. fast/notifications/notifications-event-stop-propagation.html
LayoutTests/TestExpectations:1223 Path does not exist. fast/notifications/notifications-multi-events.html

Notification support was removed in r216641.

9:04 PM Changeset in webkit [216833] by Chris Dumez
  • 28 edits in trunk

Stop using RefPtr::release()
​https://bugs.webkit.org/show_bug.cgi?id=172074

Reviewed by Geoffrey Garen.

Source/WebCore:

  • css/parser/CSSPropertyParser.cpp:

(WebCore::FontVariantLigaturesParser::finalizeValue):
(WebCore::FontVariantNumericParser::finalizeValue):

  • css/parser/CSSPropertyParserHelpers.cpp:

(WebCore::CSSPropertyParserHelpers::CalcParser::consumeValue):

  • loader/SubresourceLoader.cpp:

(WebCore::SubresourceLoader::create):

  • loader/archive/mhtml/MHTMLArchive.cpp:

(WebCore::MHTMLArchive::generateMHTMLData):

  • loader/archive/mhtml/MHTMLArchive.h:
  • loader/archive/mhtml/MHTMLParser.cpp:

(WebCore::MHTMLParser::parseArchiveWithHeader):

  • platform/audio/ios/AudioFileReaderIOS.cpp:

(WebCore::AudioFileReader::createBus):

  • platform/glib/SharedBufferGlib.cpp:

(WebCore::SharedBuffer::createFromReadingFile):

  • platform/graphics/ca/win/CACFLayerTreeHost.cpp:

(WebCore::CACFLayerTreeHost::create):

  • platform/graphics/cairo/CairoUtilities.cpp:

(WebCore::copyCairoImageSurface):

  • platform/graphics/cairo/ImageBufferCairo.cpp:

(WebCore::getImageData):

  • platform/graphics/gtk/IconGtk.cpp:

(WebCore::Icon::createIconForFiles):

  • platform/graphics/win/FontCacheWin.cpp:

(WebCore::FontCache::systemFallbackForCharacters):

  • platform/win/SharedBufferWin.cpp:

(WebCore::SharedBuffer::createFromReadingFile):

Source/WebKit/win:

  • WebFrame.cpp:

(WebFrame::loadPlainTextString):
(WebFrame::loadHTMLString):

  • WebFramePolicyListener.cpp:

(WebFramePolicyListener::receivedPolicyDecision):

Source/WebKit2:

  • Platform/unix/SharedMemoryUnix.cpp:

(WebKit::SharedMemory::create):

  • Shared/CoordinatedGraphics/CoordinatedGraphicsScene.cpp:

(WebKit::CoordinatedGraphicsScene::createImageBacking):

  • Shared/cairo/ShareableBitmapCairo.cpp:

(WebKit::ShareableBitmap::createCairoSurface):

  • WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMNodeFilter.cpp:

(WebKit::core):

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::getContentsAsMHTMLData):

Source/WTF:

  • wtf/win/WorkQueueWin.cpp:

(WTF::WorkQueue::dispatchAfter):

Tools:

  • TestWebKitAPI/Tests/WTF/RefPtr.cpp:

(TestWebKitAPI::TEST):

7:20 PM Changeset in webkit [216832] by Ryan Haddad
  • 2 edits in branches/safari-603-branch/LayoutTests

Unreviewed test gardening.

  • platform/ios-simulator/TestExpectations:
7:18 PM Changeset in webkit [216831] by Ryan Haddad
  • 3 edits in branches/safari-603-branch/LayoutTests

Merge r216614.

6:07 PM Changeset in webkit [216830] by Ryan Haddad
  • 2 edits in trunk/LayoutTests

Remove flaky expectation for LayoutTest media/media-controls-clone-crash.html.
​https://bugs.webkit.org/show_bug.cgi?id=171978

Unreviewed test gardening.

  • platform/mac-wk2/TestExpectations:
2:36 PM Changeset in webkit [216829] by jfernandez@igalia.com
  • 7 edits
    2 adds in trunk

[css-align] Implement the place-self shorthand
​https://bugs.webkit.org/show_bug.cgi?id=168846

Reviewed by Zalan Bujtas.

Source/WebCore:

The CSS Box Alignment specification defines a new shorthand to set the
Content Alignment properties (align-self and justify-self) at the
same time.

This patch provides the implementation of the CSS parsing logic and the
required regression tests.

Test: css3/parse-place-self.html

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::ComputedStyleExtractor::propertyValue):

  • css/CSSProperties.json:
  • css/StyleProperties.cpp:

(WebCore::StyleProperties::getPropertyValue):

  • css/parser/CSSPropertyParser.cpp:

(WebCore::CSSPropertyParser::consumePlaceSelfShorthand):
(WebCore::CSSPropertyParser::parseShorthand):

  • css/parser/CSSPropertyParser.h:

LayoutTests:

Regression tests for the new place-self alignment shorthand.

  • css3/parse-place-self-expected.txt: Added.
  • css3/parse-place-self.html: Added.
1:46 PM Changeset in webkit [216828] by jmarcell@apple.com
  • 6 edits
    2 adds in branches/safari-603-branch/Source

Cherry-pick r214313. rdar://problem/32080658

1:32 PM Changeset in webkit [216827] by commit-queue@webkit.org
  • 24 edits
    1 delete in trunk

Unreviewed, rolling out r216808.
​https://bugs.webkit.org/show_bug.cgi?id=172075

caused lldb to hang when debugging (Requested by smfr on
#webkit).

Reverted changeset:

"Use Mach exceptions instead of signals where possible"
​https://bugs.webkit.org/show_bug.cgi?id=171865
​http://trac.webkit.org/changeset/216808

12:10 PM Changeset in webkit [216826] by commit-queue@webkit.org
  • 15 edits in trunk

Unreviewed, rolling out r216801.
​https://bugs.webkit.org/show_bug.cgi?id=172072

Many memory corruption crashes on worker threads (Requested by
ap on #webkit).

Reverted changeset:

"WorkerRunLoop::Task::performTask() should check
!scriptController->isTerminatingExecution()."
​https://bugs.webkit.org/show_bug.cgi?id=171775
​http://trac.webkit.org/changeset/216801

11:43 AM Changeset in webkit [216825] by Alan Bujtas
  • 2 edits in trunk/Source/WebCore

AccessibilityRenderObject::textUnderElement needs to assert on unclean tree.
​https://bugs.webkit.org/show_bug.cgi?id=172065

Reviewed by Simon Fraser.

r192103 changed the assert logic incorrectly. If the tree is dirty, regardless of the renderer's type,
TextIterator will end up forcing style update/layout on the render tree.
The original assert would have hit with bug 171546 prior to r216726.

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::textUnderElement):

11:24 AM Changeset in webkit [216824] by Simon Fraser
  • 7 edits
    2 adds in trunk

event.clientX/clientY should be in layout viewport coordinates
​https://bugs.webkit.org/show_bug.cgi?id=172018

Reviewed by Zalan Bujtas.
Source/WebCore:

Fix clientX and clientY on mouse events to be relative to the layout viewport, to match
getBoundingClientRect(), getClientRects() and fixed-position objects.

Also minor cleanup of MouseRelatedEvent to use initializers.

Test: fast/visual-viewport/client-coordinates-relative-to-layout-viewport.html

  • dom/MouseRelatedEvent.cpp:

(WebCore::MouseRelatedEvent::MouseRelatedEvent):
(WebCore::MouseRelatedEvent::init):
(WebCore::MouseRelatedEvent::initCoordinates):
(WebCore::contentsScrollOffset): Deleted.

  • dom/MouseRelatedEvent.h:

LayoutTests:

  • fast/events/clientXY-in-zoom-and-scroll.html:
  • fast/visual-viewport/client-coordinates-relative-to-layout-viewport-expected.txt: Added.
  • fast/visual-viewport/client-coordinates-relative-to-layout-viewport.html: Added.
  • platform/ios/TestExpectations:
  • platform/mac/fast/events/clientXY-in-zoom-and-scroll-expected.txt:
10:33 AM Changeset in webkit [216823] by Chris Dumez
  • 37 edits in trunk/Source/WebKit/win

Drop uses of PassRefPtr in WebKit/win
​https://bugs.webkit.org/show_bug.cgi?id=172067

Reviewed by Yusuke Suzuki.

  • DOMEventsClasses.cpp:

(DOMEvent::DOMEvent):
(DOMEvent::createInstance):

  • DOMEventsClasses.h:

(DOMUIEvent::DOMUIEvent):
(DOMKeyboardEvent::DOMKeyboardEvent):
(DOMMouseEvent::DOMMouseEvent):
(DOMMutationEvent::DOMMutationEvent):
(DOMOverflowEvent::DOMOverflowEvent):
(DOMWheelEvent::DOMWheelEvent):

  • MemoryStream.cpp:

(MemoryStream::MemoryStream):
(MemoryStream::createInstance):

  • MemoryStream.h:
  • Plugins/PluginDatabase.cpp:

(WebCore::PluginDatabase::refresh):
(WebCore::PluginDatabase::add):
(WebCore::PluginDatabase::loadPersistentMetadataCache):

  • Plugins/PluginDatabase.h:
  • Plugins/PluginPackage.cpp:

(WebCore::PluginPackage::createPackage):
(WebCore::PluginPackage::createPackageFromCache):

  • Plugins/PluginPackage.h:
  • Plugins/PluginStream.h:

(WebCore::PluginStream::create):

  • WebActionPropertyBag.cpp:

(WebActionPropertyBag::WebActionPropertyBag):
(WebActionPropertyBag::createInstance):

  • WebActionPropertyBag.h:
  • WebArchive.cpp:

(WebArchive::createInstance):
(WebArchive::WebArchive):

  • WebArchive.h:
  • WebBackForwardList.cpp:

(WebBackForwardList::WebBackForwardList):
(WebBackForwardList::createInstance):

  • WebBackForwardList.h:
  • WebCoreSupport/EmbeddedWidget.cpp:

(EmbeddedWidget::create):

  • WebCoreSupport/EmbeddedWidget.h:
  • WebCoreSupport/WebChromeClient.h:
  • WebFrame.cpp:

(WebFrame::loadData):
(WebFrame::createSubframeWithOwnerElement):

  • WebFrame.h:
  • WebFramePolicyListener.cpp:

(WebFramePolicyListener::WebFramePolicyListener):
(WebFramePolicyListener::createInstance):

  • WebFramePolicyListener.h:
  • WebGeolocationPolicyListener.cpp:

(WebGeolocationPolicyListener::createInstance):
(WebGeolocationPolicyListener::WebGeolocationPolicyListener):

  • WebGeolocationPolicyListener.h:
  • WebHistoryItem.cpp:

(WebHistoryItem::WebHistoryItem):
(WebHistoryItem::createInstance):

  • WebHistoryItem.h:
  • WebMutableURLRequest.cpp:

(WebMutableURLRequest::setFormData):
(WebMutableURLRequest::formData):

  • WebMutableURLRequest.h:
  • WebResource.cpp:

(WebResource::createInstance):

  • WebResource.h:
  • WebScriptWorld.cpp:

(WebScriptWorld::WebScriptWorld):
(WebScriptWorld::createInstance):

  • WebScriptWorld.h:
  • WebURLAuthenticationChallengeSender.cpp:

(WebURLAuthenticationChallengeSender::WebURLAuthenticationChallengeSender):
(WebURLAuthenticationChallengeSender::createInstance):

  • WebURLAuthenticationChallengeSender.h:
  • WebView.cpp:

(WebView::setFullScreenElement):

  • WebView.h:
Note: See TracTimeline for information about the timeline view.