Context Navigation

(WebCore::presentingApplicationPIDOverride):
(WebCore::presentingApplicationPID): Returns the override PID if set, or getCurrentProcessID()
otherwise.
(WebCore::setPresentingApplicationPID):

platform/RuntimeApplicationChecks.h:
platform/cocoa/RuntimeApplicationChecksCocoa.mm: Renamed from Source/WebCore/platform/RuntimeApplicationChecks.mm.

Source/WebKit2:

Added uiProcessPID to Web and Networking process creation parameters. The UI process
initializes these to getpid(), and the child processes call WebCore::setPresentingApplicationPID()
at initialization time.

This replaces presenterApplicationPid.

NetworkProcess/NetworkProcess.cpp:

(WebKit::NetworkProcess::initializeNetworkProcess):

NetworkProcess/NetworkProcessCreationParameters.cpp:

(WebKit::NetworkProcessCreationParameters::encode):
(WebKit::NetworkProcessCreationParameters::decode):

NetworkProcess/NetworkProcessCreationParameters.h:
Shared/WebProcessCreationParameters.cpp:

(WebKit::WebProcessCreationParameters::encode):
(WebKit::WebProcessCreationParameters::decode):

Shared/WebProcessCreationParameters.h:
UIProcess/Cocoa/WebProcessPoolCocoa.mm:

(WebKit::WebProcessPool::platformInitializeWebProcess):

UIProcess/WebProcessPool.cpp:

(WebKit::WebProcessPool::ensureNetworkProcess):
(WebKit::WebProcessPool::createNewWebProcess):

WebProcess/WebPage/mac/WebPageMac.mm:

(WebKit::WebPage::platformInitialize):

WebProcess/WebProcess.cpp:

(WebKit::WebProcess::initializeWebProcess):

WebProcess/WebProcess.h:

(WebKit::WebProcess::presenterApplicationPid): Deleted.

WebProcess/cocoa/WebProcessCocoa.mm:

(WebKit::WebProcess::platformInitializeWebProcess):

10:35 PM Changeset in webkit [216902] by Antti Koivisto

37 edits in trunk/Source

RenderTheme does not need to be per-page
https://bugs.webkit.org/show_bug.cgi?id=172116
<rdar://problem/30426457>

Reviewed by Zalan Bujtas.

There are no implementations of RenderTheme::themeForPage that actually care about the page.
It can be replaced with a singleton, simplifying a bunch of code.

Modules/mediacontrols/MediaControlsHost.cpp:

(WebCore::MediaControlsHost::shadowRootCSSText):
(WebCore::MediaControlsHost::base64StringForIconNameAndType):

css/CSSDefaultStyleSheets.cpp:

(WebCore::CSSDefaultStyleSheets::loadFullDefaultStyle):
(WebCore::CSSDefaultStyleSheets::ensureDefaultStyleSheetsForElement):

Fix a potential crash if we get here when page is null (though it doesn't appear to repro on trunk).

css/StyleColor.cpp:

(WebCore::StyleColor::colorFromKeyword):

css/StyleResolver.cpp:

(WebCore::StyleResolver::adjustRenderStyle):

css/parser/CSSParser.cpp:

(WebCore::CSSParser::parseSystemColor):

css/parser/CSSParser.h:
css/parser/CSSPropertyParser.cpp:

(WebCore::CSSPropertyParser::consumeSystemFont):

editing/FrameSelection.cpp:

(WebCore::FrameSelection::updateAppearance):

html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::ensureMediaControlsInjectedScript):

html/HTMLMeterElement.cpp:

(WebCore::HTMLMeterElement::createElementRenderer):

html/HTMLSelectElement.cpp:

(WebCore::HTMLSelectElement::usesMenuList):
(WebCore::HTMLSelectElement::platformHandleKeydownEvent):
(WebCore::HTMLSelectElement::menuListDefaultEventHandler):

html/HTMLTextFormControlElement.cpp:

(WebCore::HTMLTextFormControlElement::adjustInnerTextStyle):

html/InputType.cpp:

(WebCore::InputType::themeSupportsDataListUI):

html/TextFieldInputType.cpp:

(WebCore::TextFieldInputType::shouldHaveSpinButton):
(WebCore::TextFieldInputType::shouldHaveCapsLockIndicator):

html/canvas/CanvasRenderingContext2D.cpp:

(WebCore::CanvasRenderingContext2D::setStrokeColor):
(WebCore::CanvasRenderingContext2D::setFillColor):

html/canvas/CanvasStyle.cpp:

(WebCore::parseColor):
(WebCore::parseColorOrCurrentColor):
(WebCore::CanvasStyle::createFromString):

html/canvas/CanvasStyle.h:
html/shadow/MediaControlElements.cpp:

(WebCore::MediaControlPanelElement::startTimer):
(WebCore::MediaControlPanelElement::makeOpaque):
(WebCore::MediaControlPanelElement::makeTransparent):

html/shadow/MediaControls.cpp:

(WebCore::MediaControls::reset):
(WebCore::MediaControls::reportedError):
(WebCore::MediaControls::updateCurrentTimeDisplay):

html/shadow/mac/ImageControlsButtonElementMac.cpp:

(WebCore::ImageControlsButtonElementMac::tryCreate):

page/MemoryRelease.cpp:

(WebCore::releaseNoncriticalMemory):

page/Page.cpp:

(WebCore::Page::Page):

page/Page.h:

(WebCore::Page::theme): Deleted.

platform/wpe/RenderThemeWPE.cpp:

(WebCore::RenderTheme::singleton):
(WebCore::RenderTheme::themeForPage): Deleted.

rendering/RenderEmbeddedObject.cpp:

(WebCore::RenderEmbeddedObject::getReplacementTextGeometry):

rendering/RenderObject.cpp:

(WebCore::RenderObject::theme):

rendering/RenderTheme.cpp:

(WebCore::RenderTheme::focusRingColor):

rendering/RenderTheme.h:

(WebCore::RenderTheme::defaultTheme): Deleted.

rendering/RenderThemeGtk.cpp:

(WebCore::RenderTheme::singleton):
(WebCore::RenderTheme::themeForPage): Deleted.

rendering/RenderThemeIOS.mm:

(WebCore::RenderTheme::singleton):
(WebCore::RenderTheme::themeForPage): Deleted.

rendering/RenderThemeMac.mm:

(WebCore::RenderTheme::singleton):
(WebCore::RenderTheme::themeForPage): Deleted.

rendering/RenderThemeWin.cpp:

(WebCore::RenderTheme::singleton):
(WebCore::RenderTheme::themeForPage): Deleted.

rendering/TextPaintStyle.cpp:

(WebCore::computeTextPaintStyle):

10:14 PM Changeset in webkit [216901] by commit-queue@webkit.org

32 edits in trunk

Do not delete asynchronously decoded frames for large images if their clients are in the viewport
https://bugs.webkit.org/show_bug.cgi?id=170640

Patch by Said Abou-Hallawa <sabouhallawa@apple.com> on 2017-05-15
Reviewed by Simon Fraser.

Source/WebCore:

The image flickering problem happens when a large image is visible in the
view port and for some reason, the decoded frame gets destroyed. When this
image is repainted, BitmapImage::draw() does not find a valid decoded frame
for that image. It then requests an async decoding for the image and just
draws nothing in the image rectangle. Drawing no content between two drawing
phases in which the image is drawn causes the unwanted flickering.

To fix this issue we need to protect the decoded frames of all the images
in the view port from being destroyed. When BitmapImage::destroyDecodedData()
is called, it is going to check, through the ImageObserver, whether any
of its clients is visible. And if so, the current decoded frame won't be
destroyed.

Tests: Modifying existing tests.

loader/cache/CachedImage.cpp:

(WebCore::CachedImage::CachedImageObserver::decodedSizeChanged):
(WebCore::CachedImage::CachedImageObserver::didDraw):
(WebCore::CachedImage::CachedImageObserver::canDestroyDecodedData):
(WebCore::CachedImage::CachedImageObserver::imageFrameAvailable):
(WebCore::CachedImage::CachedImageObserver::changedInRect):
(WebCore::CachedImage::decodedSizeChanged):
(WebCore::CachedImage::didDraw):
(WebCore::CachedImage::canDestroyDecodedData): Finds out whether it's okay
to discard the image decoded data or not.
(WebCore::CachedImage::imageFrameAvailable):
(WebCore::CachedImage::changedInRect):

loader/cache/CachedImage.h:
loader/cache/CachedImageClient.h:

(WebCore::CachedImageClient::canDestroyDecodedData):

loader/cache/MemoryCache.cpp:

(WebCore::MemoryCache::destroyDecodedDataForAllImages): This function is
currently not used. Use in the internal destroyDecodedDataForAllImages()
but unlike what CachedImage::destroyDecodedData() does, make it destroy
the decoded frames without deleting the image itself.

loader/cache/MemoryCache.h:
platform/graphics/BitmapImage.cpp:

(WebCore::BitmapImage::destroyDecodedData):
(WebCore::BitmapImage::draw):
(WebCore::BitmapImage::canDestroyCurrentFrameDecodedData):
(WebCore::BitmapImage::advanceAnimation):
(WebCore::BitmapImage::internalAdvanceAnimation):
(WebCore::BitmapImage::imageFrameAvailableAtIndex):

platform/graphics/BitmapImage.h:
platform/graphics/GraphicsContext3D.cpp:

(WebCore::GraphicsContext3D::packImageData):

platform/graphics/ImageFrameCache.cpp:

(WebCore::ImageFrameCache::decodedSizeChanged):
(ImageFrameCache::cacheAsyncFrameNativeImageAtIndex): The assertion in this
function is wrong. frameIsCompleteAtIndex() can be false when the an image
decoding is requested but can be true when the decoding finishes.

platform/graphics/ImageObserver.h:
platform/graphics/cairo/ImageCairo.cpp:

(WebCore::Image::drawPattern):

platform/graphics/cg/ImageCG.cpp:

(WebCore::Image::drawPattern):

platform/graphics/cg/ImageDecoderCG.cpp:

(WebCore::ImageDecoder::frameIsCompleteAtIndex):

platform/graphics/cg/PDFDocumentImage.cpp:

(WebCore::PDFDocumentImage::decodedSizeChanged):
(WebCore::PDFDocumentImage::draw):

platform/graphics/texmap/TextureMapperTiledBackingStore.cpp:

(WebCore::TextureMapperTiledBackingStore::updateContentsFromImageIfNeeded):

platform/graphics/win/ImageDirect2D.cpp:

(WebCore::Image::drawPattern):

rendering/RenderElement.cpp:

(WebCore::RenderElement::isVisibleInDocumentRect):
(WebCore::RenderElement::isVisibleInViewport):
(WebCore::RenderElement::imageFrameAvailable):
(WebCore::RenderElement::repaintForPausedImageAnimationsIfNeeded):
(WebCore::RenderElement::shouldRepaintInVisibleRect): Deleted. Function
is renamed to isVisibleInViewport() for better readability.

rendering/RenderElement.h:
svg/graphics/SVGImage.cpp:

(WebCore::SVGImage::draw):

svg/graphics/SVGImageClients.h:
testing/Internals.cpp:

(WebCore::Internals::destroyDecodedDataForAllImages):

testing/Internals.h:
testing/Internals.idl:

Source/WebKit/mac:

Enable the async decoding for large images.

WebView/WebView.mm:

(-[WebView _preferencesChanged:]):

Source/WebKit2:

Enable the async decoding for large images.

WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::updatePreferences):

LayoutTests:

fast/images/async-image-background-image-repeated.html:
fast/images/async-image-background-image.html:
fast/images/sprite-sheet-image-draw.html:

8:41 PM Changeset in webkit [216900] by commit-queue@webkit.org

3 edits in trunk/Tools

WPT test importer should not account for slow manual tests
https://bugs.webkit.org/show_bug.cgi?id=172127

Patch by Youenn Fablet <youenn@apple.com> on 2017-05-15
Reviewed by Ryosuke Niwa.

Making sure manual tests are not triggering updating tests-options.json file.

Scripts/webkitpy/w3c/test_importer.py:

(TestImporter.find_importable_tests):
(TestImporter._already_identified_as_resource_file):
(TestImporter.update_tests_options):

Scripts/webkitpy/w3c/test_importer_unittest.py:

(test_manual_slow_test):

8:19 PM Changeset in webkit [216899] by Jonathan Bedard

3 edits in trunk/Tools

webkitpy: Some versions of simctl do not place parenthesis around runtime identifiers
https://bugs.webkit.org/show_bug.cgi?id=172142

Reviewed by Tim Horton.

Scripts/webkitpy/xcode/simulator.py:

(Simulator._parse_runtimes): Newer versions of simctl output do not put parenthesis
around runtime identifiers.

Scripts/webkitpy/xcode/simulator_unittest.py: Add tests for new simctl output.

7:45 PM Changeset in webkit [216898] by commit-queue@webkit.org

30 edits in trunk/Source

Simplify RealtimeMediaSource data production and state
https://bugs.webkit.org/show_bug.cgi?id=171999

Patch by Youenn Fablet <youenn@apple.com> on 2017-05-15
Reviewed by Eric Carlson.

Source/WebCore:

RealtimeMediaSource takes 3 booleans:

m_isProducingData tells whether data is produced or not. In the case of capturing, it tells whether capture happens.
m_muted/m_enabled allows JS or WebKit level to start/stop the source.

Changed MediaStream capture state computation so that capture is reported as follows:

m_isProducing is true, capture is happenning and is active
m_muted is true, capture is happening but is inactive.

Except in the case of WebRTC incoming sources, for which sources may be created as muted as per the spec,
all sources are unmuted, enabled and not producing data when created.

RealtimeMediaSource is now activable either by calling start/stop or by calling setMuted/setEnabled.
This in turns will set the boolean values accordingly and will call the underlying
startProducingData/stopProducingData methods doing the actual stuff.

Removing from all RealtimeMediaSource subclasses the handling of producing data.
Making more methods non-virtual/member fields private to simplify the model.

Modules/mediastream/CanvasCaptureMediaStreamTrack.cpp:

(WebCore::CanvasCaptureMediaStreamTrack::Source::create):
(WebCore::CanvasCaptureMediaStreamTrack::Source::startProducingData):
(WebCore::CanvasCaptureMediaStreamTrack::Source::stopProducingData):
(WebCore::CanvasCaptureMediaStreamTrack::Source::canvasDestroyed):
(WebCore::CanvasCaptureMediaStreamTrack::Source::captureCanvas):

Modules/mediastream/CanvasCaptureMediaStreamTrack.h:
Modules/mediastream/MediaStream.cpp:

(WebCore::MediaStream::mediaState):

platform/mediastream/MediaStreamTrackPrivate.h:

(WebCore::MediaStreamTrackPrivate::startProducingData):
(WebCore::MediaStreamTrackPrivate::stopProducingData):

platform/mediastream/RealtimeMediaSource.cpp:

(WebCore::RealtimeMediaSource::setMuted):
(WebCore::RealtimeMediaSource::notifyMutedChange):
(WebCore::RealtimeMediaSource::setEnabled):
(WebCore::RealtimeMediaSource::start):
(WebCore::RealtimeMediaSource::stop):
(WebCore::RealtimeMediaSource::requestStop):
(WebCore::RealtimeMediaSource::reset): Deleted.

platform/mediastream/RealtimeMediaSource.h:
platform/mediastream/mac/AVMediaCaptureSource.h:
platform/mediastream/mac/AVMediaCaptureSource.mm:

(WebCore::AVMediaCaptureSource::AVMediaCaptureSource):
(WebCore::AVMediaCaptureSource::captureSessionIsRunningDidChange):
(WebCore::AVMediaCaptureSource::reset): Deleted.
(WebCore::AVMediaCaptureSource::isProducingData): Deleted.

platform/mediastream/mac/CoreAudioCaptureSource.cpp:

(WebCore::CoreAudioCaptureSource::CoreAudioCaptureSource):
(WebCore::CoreAudioCaptureSource::startProducingData):
(WebCore::CoreAudioCaptureSource::stopProducingData):
(WebCore::CoreAudioCaptureSource::audioSourceProvider):

platform/mediastream/mac/CoreAudioCaptureSource.h:
platform/mediastream/mac/MockRealtimeAudioSourceMac.mm:

(WebCore::MockRealtimeAudioSourceMac::render):
(WebCore::MockRealtimeAudioSource::createMuted): Deleted.

platform/mediastream/mac/MockRealtimeVideoSourceMac.mm:

(WebCore::MockRealtimeVideoSource::createMuted): Deleted.

platform/mediastream/mac/RealtimeIncomingAudioSource.cpp:

(WebCore::RealtimeIncomingAudioSource::create):
(WebCore::RealtimeIncomingAudioSource::RealtimeIncomingAudioSource):
(WebCore::RealtimeIncomingAudioSource::~RealtimeIncomingAudioSource):
(WebCore::RealtimeIncomingAudioSource::startProducingData):
(WebCore::RealtimeIncomingAudioSource::stopProducingData):
(WebCore::RealtimeIncomingAudioSource::setSourceTrack):

platform/mediastream/mac/RealtimeIncomingAudioSource.h:
platform/mediastream/mac/RealtimeIncomingVideoSource.cpp:

(WebCore::RealtimeIncomingVideoSource::create):
(WebCore::RealtimeIncomingVideoSource::RealtimeIncomingVideoSource):
(WebCore::RealtimeIncomingVideoSource::startProducingData):
(WebCore::RealtimeIncomingVideoSource::setSourceTrack):
(WebCore::RealtimeIncomingVideoSource::stopProducingData):
(WebCore::RealtimeIncomingVideoSource::OnFrame):

platform/mediastream/mac/RealtimeIncomingVideoSource.h:
platform/mediastream/mac/WebAudioSourceProviderAVFObjC.mm:

(WebCore::WebAudioSourceProviderAVFObjC::setClient):

platform/mock/MockMediaEndpoint.cpp:

(WebCore::MockMediaEndpoint::createMutedRemoteSource):
(WebCore::MockMediaEndpoint::unmuteTimerFired):

platform/mock/MockRealtimeAudioSource.cpp:

(WebCore::MockRealtimeAudioSource::createMuted):
(WebCore::MockRealtimeAudioSource::startProducingData):
(WebCore::MockRealtimeAudioSource::stopProducingData):

platform/mock/MockRealtimeAudioSource.h:
platform/mock/MockRealtimeMediaSource.cpp:

(WebCore::MockRealtimeMediaSource::startProducingData): Deleted.
(WebCore::MockRealtimeMediaSource::stopProducingData): Deleted.

platform/mock/MockRealtimeMediaSource.h:
platform/mock/MockRealtimeVideoSource.cpp:

(WebCore::MockRealtimeVideoSource::createMuted):
(WebCore::MockRealtimeVideoSource::startProducingData):
(WebCore::MockRealtimeVideoSource::stopProducingData):
(WebCore::MockRealtimeVideoSource::generateFrame):

platform/mock/MockRealtimeVideoSource.h:

Source/WebKit2:

UIProcess/Cocoa/UserMediaCaptureManagerProxy.cpp:

(WebKit::UserMediaCaptureManagerProxy::startProducingData):
(WebKit::UserMediaCaptureManagerProxy::stopProducingData):

WebProcess/cocoa/UserMediaCaptureManager.cpp:

6:59 PM Changeset in webkit [216897] by rniwa@webkit.org

1 edit
1 move in trunk/Websites/browserbench.org

browserbench.org/Speedometer/ should show the benchmark not an index of files
https://bugs.webkit.org/show_bug.cgi?id=172141

Reviewed by Alexey Proskuryakov.

Renamed Speedometer/Full.html to Speedometer/index.html.
We used to have a .htaccess but it's better to use the same file name convention as other benchmarks.

Speedometer/index.html: Renamed from Websites/browserbench.org/Speedometer/Full.html.

6:37 PM Changeset in webkit [216896] by mmaxfield@apple.com

14 edits in trunk/Source/WebCore

Migrate Font constructor from bools to enums
https://bugs.webkit.org/show_bug.cgi?id=172140

Reviewed by Tim Horton.

In https://bugs.webkit.org/show_bug.cgi?id=168487, I'm adding a new flag to Font. We can't
keep having just a pile of bools in this class. Instead, we should be using enums.

No new tests because there is no behavior change.

css/CSSFontFace.cpp:

(WebCore::CSSFontFace::font):

css/CSSFontFaceSource.cpp:

(WebCore::CSSFontFaceSource::font):

css/CSSSegmentedFontFace.cpp:
loader/cache/CachedFont.cpp:

(WebCore::CachedFont::createFont):

platform/graphics/Font.cpp:

(WebCore::Font::Font):
(WebCore::Font::verticalRightOrientationFont):
(WebCore::Font::uprightOrientationFont):
(WebCore::Font::brokenIdeographFont):
(WebCore::Font::description):
(WebCore::Font::mathData):

platform/graphics/Font.h:

(WebCore::Font::create):
(WebCore::Font::origin):
(WebCore::Font::isInterstitial):
(WebCore::Font::widthForGlyph):
(WebCore::Font::isCustomFont): Deleted.
(WebCore::Font::isLoading): Deleted.

platform/graphics/FontRanges.cpp:
platform/graphics/cocoa/FontCocoa.mm:

(WebCore::Font::platformInit):

platform/graphics/freetype/SimpleFontDataFreeType.cpp:

(WebCore::Font::platformCreateScaledFont):

platform/graphics/win/SimpleFontDataCGWin.cpp:

(WebCore::Font::platformInit):

platform/graphics/win/SimpleFontDataDirect2D.cpp:

(WebCore::Font::platformInit):

platform/graphics/win/SimpleFontDataWin.cpp:

(WebCore::Font::platformCreateScaledFont):
(WebCore::Font::determinePitch):

rendering/SimpleLineLayout.cpp:

(WebCore::SimpleLineLayout::canUseForFontAndText):

6:29 PM Changeset in webkit [216895] by ggaren@apple.com

2 edits in trunk/Source/bmalloc

bmalloc: Bump the size of the deallocator log to 512
https://bugs.webkit.org/show_bug.cgi?id=172143

Reviewed by Michael Saboff.

This is a speedup on parallel workloads for machines with lots of CPUs.

bmalloc/Sizes.h:

5:58 PM Changeset in webkit [216894] by Michael Catanzaro

2 edits in trunk/Source/WebCore/platform/gtk/po

[GTK] [l10n] Updated French translation for Webkit/GTK
https://bugs.webkit.org/show_bug.cgi?id=172093

Patch by Alexandre Franke <afranke@gnome.org> on 2017-05-15
Rubber-stamped by Michael Catanzaro.

fr.po:

5:50 PM Changeset in webkit [216893] by Brent Fulgham

2 edits in trunk/Source/WebKit2

Correct typo (part of r216790).

PluginProcess/mac/com.apple.WebKit.plugin-common.sb.in: The check-in missed part of a

regular expression needed to fix the audio playback.

5:41 PM Changeset in webkit [216892] by commit-queue@webkit.org

7 edits in trunk

WebRTC outgoing muted video sources should send black frames
https://bugs.webkit.org/show_bug.cgi?id=170627
<rdar://problem/31513869>

Patch by Youenn Fablet <youenn@apple.com> on 2017-05-15
Reviewed by Eric Carlson.

Source/WebCore:

Covered by updated test.

Instead of sending one black frame and then another one asynchronously,
we use the timer to send a black frame every second when outgoing source is muted.

platform/mediastream/mac/RealtimeOutgoingVideoSource.cpp:

(WebCore::RealtimeOutgoingVideoSource::sourceMutedChanged):
(WebCore::RealtimeOutgoingVideoSource::sourceEnabledChanged):
(WebCore::RealtimeOutgoingVideoSource::sendBlackFrames):
(WebCore::RealtimeOutgoingVideoSource::sendBlackFrame): Deleted.

platform/mediastream/mac/RealtimeOutgoingVideoSource.h:
testing/Internals.cpp:

(WebCore::Internals::videoSampleAvailable):

LayoutTests:

webrtc/video-mute-expected.txt:
webrtc/video-mute.html:

5:21 PM Changeset in webkit [216891] by mark.lam@apple.com

22 edits
2 deletes in trunk

Rolling out r214038 and r213697: Crashes when using computed properties with rest destructuring and object spread.
https://bugs.webkit.org/show_bug.cgi?id=172147

Rubber-stamped by Saam Barati.

JSTests:

stress/object-rest-deconstruct.js: Removed.
stress/object-spread.js: Removed.

Source/JavaScriptCore:

I rolled out every thing in those 2 patches except for the change to make
CodeBlock::finishCreation() return a bool plus its clients that depend on this.
I made this exception because r214931 relies on this change, and this part of
the change looks correct.

builtins/BuiltinNames.h:
builtins/GlobalOperations.js:

(globalPrivate.speciesConstructor):
(globalPrivate.copyDataProperties): Deleted.

bytecode/CodeBlock.cpp:

(JSC::CodeBlock::finishCreation):
(JSC::CodeBlock::setConstantIdentifierSetRegisters): Deleted.

bytecode/CodeBlock.h:
bytecode/UnlinkedCodeBlock.h:

(JSC::UnlinkedCodeBlock::addBitVector):
(JSC::UnlinkedCodeBlock::constantRegisters):
(JSC::UnlinkedCodeBlock::addSetConstant): Deleted.
(JSC::UnlinkedCodeBlock::constantIdentifierSets): Deleted.

bytecompiler/BytecodeGenerator.cpp:
bytecompiler/BytecodeGenerator.h:
bytecompiler/NodesCodegen.cpp:

(JSC::PropertyListNode::emitBytecode):
(JSC::ObjectPatternNode::bindValue):
(JSC::ObjectSpreadExpressionNode::emitBytecode): Deleted.

parser/ASTBuilder.h:

(JSC::ASTBuilder::createProperty):
(JSC::ASTBuilder::appendObjectPatternEntry):
(JSC::ASTBuilder::createObjectSpreadExpression): Deleted.
(JSC::ASTBuilder::appendObjectPatternRestEntry): Deleted.
(JSC::ASTBuilder::setContainsObjectRestElement): Deleted.

parser/NodeConstructors.h:

(JSC::PropertyNode::PropertyNode):
(JSC::SpreadExpressionNode::SpreadExpressionNode):
(JSC::ObjectSpreadExpressionNode::ObjectSpreadExpressionNode): Deleted.

parser/Nodes.h:

(JSC::ObjectPatternNode::appendEntry):
(JSC::ObjectSpreadExpressionNode::expression): Deleted.
(JSC::ObjectPatternNode::setContainsRestElement): Deleted.

parser/Parser.cpp:

(JSC::Parser<LexerType>::parseDestructuringPattern):
(JSC::Parser<LexerType>::parseProperty):

parser/SyntaxChecker.h:

(JSC::SyntaxChecker::createSpreadExpression):
(JSC::SyntaxChecker::createProperty):
(JSC::SyntaxChecker::operatorStackPop):
(JSC::SyntaxChecker::createObjectSpreadExpression): Deleted.

runtime/ObjectConstructor.cpp:

(JSC::ObjectConstructor::finishCreation):

runtime/SetPrototype.cpp:

(JSC::SetPrototype::finishCreation):

Source/WTF:

wtf/HashSet.h:

(WTF::=):

LayoutTests:

js/parser-syntax-check-expected.txt:
js/script-tests/parser-syntax-check.js:

5:07 PM Changeset in webkit [216890] by matthew_hanson@apple.com

15 edits
3 moves in branches/safari-604.1.21-branch

Cherry-pick r216249. rdar://problem/31764764

4:54 PM Changeset in webkit [216889] by ddkilzer@apple.com

3 edits in trunk/Source/WebCore

Crash in libxml2.2.dylib: xmlDictReference
<https://webkit.org/b/172086>
<rdar://problem/23643436>

Reviewed by Daniel Bates.

Speculative fix and code clean-up based on source code
inspection. The fix for the crash is in two parts that change
XSLStyleSheet::parseString():

Always set m_stylesheetDoc to nullptr after freeing it via XSLStyleSheet::clearXSLStylesheetDocument().
Add nullptr check before using m_stylesheetDoc from parent.

Broadly speaking, the changes are:

Extract code to reset m_stylesheetDoc into new private XSLStyleSheet::clearXSLStylesheetDocument() method. There is a special contract between m_stylesheetDoc and m_stylesheetDocTaken that wasn't being followed every time. See comment in XSLStyleSheet::compileStyleSheet().
XSLStyleSheet::clearDocuments() now calls new clearXSLStylesheetDocument() method. Previously, it was not checking or resetting m_stylesheetDocTaken, and it might have leaked an xmlDocPtr if m_stylesheetDoc was set and m_stylesheetDocTaken was false.
XSLStyleSheet::parseString() now calls new clearXSLStylesheetDocument() method. Previously, it did not clear m_stylesheetDoc after freeing it, and it could return early due to a failure in xmlCreateMemoryParserCtxt().
In XSLStyleSheet::parseString() use checked arithmetic when calculating 'size' for xmlCreateMemoryParserCtxt() and xmlCtxtReadMemory(). This code used to do an implicit unsigned -> signed integer conversion that could overflow.
Always iterate m_children using an 'auto& import' variable.

xml/XSLStyleSheet.h:

(WebCore::XSLStyleSheet::clearXSLStylesheetDocument): Add declaration.
(WebCore::XSLStyleSheet::m_disabled): Add default initializer.
(WebCore::XSLStyleSheet::m_stylesheetDoc): Ditto.
(WebCore::XSLStyleSheet::m_stylesheetDocTaken): Ditto.
(WebCore::XSLStyleSheet::m_parentStyleSheet): Ditto.

xml/XSLStyleSheetLibxslt.cpp:

(WebCore::XSLStyleSheet::XSLStyleSheet): Get rid of redundant
initializers. Set m_parentStyleSheet if needed.
(WebCore::XSLStyleSheet::~XSLStyleSheet): Call
clearXSLStylesheetDocument() instead of custom code. Switch
m_children fast iteration to use 'auto& import' variable.
(WebCore::XSLStyleSheet::isLoading): Switch m_children fast
iteration to use 'auto& import' variable.
(WebCore::XSLStyleSheet::clearDocuments): Call
clearXSLStylesheetDocument() instead of setting m_stylesheetDoc
to nullptr. This might fix an occasional xmlDocPtr leak.
(WebCore::XSLStyleSheet::clearXSLStylesheetDocument): Add. This
method always sets m_stylesheetDoc to nullptr (after freeing it
if necessary) and sets m_stylesheetDocTaken to false.
(WebCore::XSLStyleSheet::parseString): Call
clearXSLStylesheetDocument(). Prior to this, m_stylesheetDoc
might be left pointing to a freed value, and this method could
return early if xmlCreateMemoryParserCtxt() failed. Switch to
using Checked<> to compute required buffer size to parse XSL
stylesheet, and return early on overflow. Clean up existing
return statements to use boolean expressions. Add nullptr check
for m_parentStyleSheet->m_stylesheetDoc before using it.
(WebCore::XSLStyleSheet::loadChildSheet): Get rid of local
variable by calling loadSheet() from last array element.
(WebCore::XSLStyleSheet::compileStyleSheet): Add debug assert
that m_stylesheetDoc is not nullptr.

4:36 PM Changeset in webkit [216888] by Chris Dumez

3 edits in trunk/LayoutTests

Unreviewed, rebaseline platform/ios/ios/css/construct-WebKitCSSMatrix.html after r216881.

platform/ios/ios/css/construct-WebKitCSSMatrix-expected.txt:
platform/ios/ios/css/resources/construct-WebKitCSSMatrix.js:

4:24 PM Changeset in webkit [216887] by rniwa@webkit.org

2 edits in trunk/Tools

Update ARES-6 plan file to use the latest version
https://bugs.webkit.org/show_bug.cgi?id=172139

Reviewed by Keith Miller.

Include r216538.

Scripts/webkitpy/benchmark_runner/data/plans/ares6.plan:

3:46 PM Changeset in webkit [216886] by jer.noble@apple.com

22 edits
2 adds in trunk

Add experimental setting to allow document gesture interaction to fulfill media playback gesture requirement
https://bugs.webkit.org/show_bug.cgi?id=172131

Reviewed by Eric Carlson.

Source/WebCore:

Test: media/restricted-audio-playback-with-document-gesture.html

Move all calls to ScriptController::processingUserGestureForMedia() to the new Document equivalent. In Document,
if the new setting is enabled, return true from processingUserGestureForMedia() if the top-level document has had
a user gesture interaction.

Modules/mediastream/MediaStream.cpp:

(WebCore::MediaStream::processingUserGestureForMedia):

Modules/mediastream/MediaStream.h:
Modules/webaudio/AudioContext.cpp:

(WebCore::AudioContext::processingUserGestureForMedia):
(WebCore::AudioContext::willBeginPlayback):
(WebCore::AudioContext::willPausePlayback):

Modules/webaudio/AudioContext.h:
dom/Document.cpp:

(WebCore::Document::processingUserGestureForMedia):

dom/Document.h:
html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::load):
(WebCore::HTMLMediaElement::audioTrackEnabledChanged):
(WebCore::HTMLMediaElement::seekWithTolerance):
(WebCore::HTMLMediaElement::play):
(WebCore::HTMLMediaElement::playInternal):
(WebCore::HTMLMediaElement::pause):
(WebCore::HTMLMediaElement::pauseInternal):
(WebCore::HTMLMediaElement::setMuted):
(WebCore::HTMLMediaElement::webkitShowPlaybackTargetPicker):
(WebCore::HTMLMediaElement::processingUserGestureForMedia):

html/HTMLMediaElement.h:
html/MediaElementSession.cpp:

(WebCore::MediaElementSession::playbackPermitted):
(WebCore::MediaElementSession::dataLoadingPermitted):
(WebCore::MediaElementSession::fullscreenPermitted):
(WebCore::MediaElementSession::canShowControlsManager):
(WebCore::MediaElementSession::showPlaybackTargetPicker):

page/Settings.in:
platform/audio/PlatformMediaSession.h:

Source/WebKit/mac:

WebView/WebPreferenceKeysPrivate.h:
WebView/WebPreferences.mm:

(+[WebPreferences initialize]):
(-[WebPreferences mediaUserGestureInheritsFromDocument]):
(-[WebPreferences setMediaUserGestureInheritsFromDocument:]):

WebView/WebPreferencesPrivate.h:

Source/WebKit2:

Shared/WebPreferencesDefinitions.h:
UIProcess/API/C/WKPreferences.cpp:

(WKPreferencesSetMediaUserGestureInheritsFromDocument):
(WKPreferencesGetMediaUserGestureInheritsFromDocument):

UIProcess/API/C/WKPreferencesRefPrivate.h:
WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::updatePreferences):

LayoutTests:

media/restricted-audio-playback-with-document-gesture-expected.txt: Added.
media/restricted-audio-playback-with-document-gesture.html: Added.

3:40 PM Changeset in webkit [216885] by pvollan@apple.com

3 edits in trunk/LayoutTests

LayoutTest http/tests/media/track-in-band-hls-metadata-crash.html is a flaky timeout
https://bugs.webkit.org/show_bug.cgi?id=167749

Reviewed by Eric Carlson.

Start video playback when the 'canplaythrough' event is handled, and stop logging the event,
since the event sequence is not identical on all bots.

http/tests/media/track-in-band-hls-metadata-crash-expected.txt:
http/tests/media/track-in-band-hls-metadata-crash.html:

3:34 PM Changeset in webkit [216884] by jer.noble@apple.com

2 edits in trunk/Source/WebCore

Only ever initialize LibWebRTCProvider's staticFactoryAndThreads() factories once.
https://bugs.webkit.org/show_bug.cgi?id=172047

Reviewed by Youenn Fablet.

Wrap the initilization of the factories contained in staticFactoryAndThreads() in a call_once to ensure
new factories aren't created every time it's called.

platform/mediastream/libwebrtc/LibWebRTCProvider.cpp:

(WebCore::staticFactoryAndThreads):

3:32 PM Changeset in webkit [216883] by commit-queue@webkit.org

3 edits
2 adds in trunk

Web Inspector: CRASH seen with DOM.setOuterHTML when there is no documentElement
https://bugs.webkit.org/show_bug.cgi?id=172135
<rdar://problem/32175860>

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2017-05-15
Reviewed by Brian Burg.

Source/WebCore:

Test: inspector/dom/setOuterHTML-no-document-element.html

inspector/DOMPatchSupport.cpp:

(WebCore::DOMPatchSupport::patchDocument):
Null check the document element which might not exist.

LayoutTests:

inspector/dom/setOuterHTML-no-document-element-expected.txt: Added.
inspector/dom/setOuterHTML-no-document-element.html: Added.

3:10 PM Changeset in webkit [216882] by commit-queue@webkit.org

15 edits in trunk/Source/WebCore

REGRESSION (216471): Infinite repaint-drawing loop when asynchronously decoding incomplete image frames
https://bugs.webkit.org/show_bug.cgi?id=171900

Patch by Said Abou-Hallawa <sabouhallawa@apple.com> on 2017-05-15
Reviewed by Tim Horton.

-- Don't destroy incomplete decoded image frames for large images. This
is to avoid flickering while decoding another image frame with the new
data. The old incomplete image frame will be destroyed once the newer one
finishes decoding.

-- Extend the enum ImageFrame::DecodingStatus by adding a new value called
'Decoding'. This new value will never be cached in the ImageFrame::
m_decodingStatus. Add a member m_currentFrameDecodingStatus to BitmapImage.
The purpose of this member is to invalidate the current frame, without
deleting it, when new encoded data is received.

-- Don't wait until the native image is decoded to cache the ImageFrame
decodingStatus. There is a big chance that more data arrives between
starting the decoding and finishing it such that the decoding changes
from Partial to Complete. We need to prevent keeping incomplete ImageFrames
cached because we mistakenly assume they are complete. To fix this issue
we need to know the ImageFrame decodingStatus when the decoding is requested.

platform/graphics/BitmapImage.cpp:

(WebCore::BitmapImage::destroyDecodedData):
(WebCore::BitmapImage::dataChanged):
(WebCore::BitmapImage::draw):
(WebCore::BitmapImage::internalStartAnimation): At the beginning of this
function we check whether the next frame is being decoded or not and we
return DecodingActive if it is. Let's handle the second check here also
before requesting the decoding of nextFrame. We need to check whether the
nextFrame has a native image with decoded with the native size or not.
(WebCore::BitmapImage::internalAdvanceAnimation):
(WebCore::BitmapImage::imageFrameAvailableAtIndex):

platform/graphics/BitmapImage.h:
platform/graphics/ImageFrame.cpp:

(WebCore::ImageFrame::operator=):
(WebCore::ImageFrame::setDecodingStatus):
(WebCore::ImageFrame::decodingStatus):

platform/graphics/ImageFrame.h:

(WebCore::ImageFrame::isInvalid):
(WebCore::ImageFrame::isPartial):
(WebCore::ImageFrame::isComplete):
(WebCore::ImageFrame::setDecoding): Deleted.
(WebCore::ImageFrame::decoding): Deleted.
(WebCore::ImageFrame::isEmpty): Deleted.

platform/graphics/ImageFrameCache.cpp:

(WebCore::ImageFrameCache::setNativeImage):
(WebCore::ImageFrameCache::cacheMetadataAtIndex):
(WebCore::ImageFrameCache::cacheNativeImageAtIndex):
(WebCore::ImageFrameCache::cacheNativeImageAtIndexAsync):
(WebCore::ImageFrameCache::startAsyncDecodingQueue):
(WebCore::ImageFrameCache::requestFrameAsyncDecodingAtIndex):
(WebCore::ImageFrameCache::stopAsyncDecodingQueue):
(WebCore::ImageFrameCache::frameAtIndexCacheIfNeeded):
(WebCore::ImageFrameCache::frameDecodingStatusAtIndex):
(WebCore::ImageFrameCache::cacheFrameMetadataAtIndex): Deleted.
(WebCore::ImageFrameCache::cacheFrameNativeImageAtIndex): Deleted.
(WebCore::ImageFrameCache::cacheAsyncFrameNativeImageAtIndex): Deleted.
(WebCore::ImageFrameCache::frameIsCompleteAtIndex): Deleted.

platform/graphics/ImageFrameCache.h:

(WebCore::ImageFrameCache::ImageFrameRequest::operator==):

platform/graphics/ImageSource.cpp:

(WebCore::ImageSource::dataChanged):

platform/graphics/ImageSource.h:

(WebCore::ImageSource::destroyIncompleteDecodedData):
(WebCore::ImageSource::requestFrameAsyncDecodingAtIndex): Let the caller
decide whether another request for the same image frame is allowed or not.
(WebCore::ImageSource::frameDecodingStatusAtIndex):
(WebCore::ImageSource::frameIsCompleteAtIndex): Deleted.

platform/image-decoders/ImageDecoder.cpp:

(WebCore::ImageDecoder::frameDurationAtIndex):
(WebCore::ImageDecoder::createFrameImageAtIndex):

platform/image-decoders/bmp/BMPImageReader.cpp:

(WebCore::BMPImageReader::decodeBMP):

platform/image-decoders/gif/GIFImageDecoder.cpp:

(WebCore::GIFImageDecoder::clearFrameBufferCache):
(WebCore::GIFImageDecoder::haveDecodedRow):
(WebCore::GIFImageDecoder::frameComplete):
(WebCore::GIFImageDecoder::initFrameBuffer):

platform/image-decoders/jpeg/JPEGImageDecoder.cpp:

(WebCore::JPEGImageDecoder::outputScanlines):
(WebCore::JPEGImageDecoder::jpegComplete):

platform/image-decoders/png/PNGImageDecoder.cpp:

(WebCore::PNGImageDecoder::rowAvailable):
(WebCore::PNGImageDecoder::pngComplete):
(WebCore::PNGImageDecoder::clearFrameBufferCache):
(WebCore::PNGImageDecoder::frameComplete):

platform/image-decoders/webp/WEBPImageDecoder.cpp:

(WebCore::WEBPImageDecoder::decode):

3:07 PM Changeset in webkit [216881] by Chris Dumez

9 edits
2 adds in trunk

Align WebKitCSSMatrix stringifier with spec for DOMMatrix
https://bugs.webkit.org/show_bug.cgi?id=172114

Reviewed by Simon Fraser.

Source/WebCore:

Align WebKitCSSMatrix stringifier with spec for DOMMatrix after:

https://github.com/w3c/fxtf-drafts/pull/148

The following changes were made:

Use EcmaScript's ToString() to convert floating point values to string
Throw an invalid state error if the matrix contains non-finite values
Made WebKitCSSMatrix.toString enumerable as per [1].

[1] https://heycam.github.io/webidl/#es-stringifier

Test: fast/css/matrix-stringifier.html

css/WebKitCSSMatrix.cpp:

(WebCore::WebKitCSSMatrix::toString):

css/WebKitCSSMatrix.h:
css/WebKitCSSMatrix.idl:
platform/graphics/transforms/TransformationMatrix.cpp:

(WebCore::TransformationMatrix::containsOnlyFiniteValues):

platform/graphics/transforms/TransformationMatrix.h:

LayoutTests:

fast/css/matrix-stringifier-expected.txt: Added.
fast/css/matrix-stringifier.html: Added.

Add layout test coverage.

fast/dom/Window/custom-constructors-expected.txt:
fast/dom/Window/custom-constructors.html:

Rebaseline existing test to reflect behavior change.

2:51 PM Changeset in webkit [216880] by ddkilzer@apple.com

2 edits in trunk/Source/JavaScriptCore

JSEnvironmentRecord::allocationSizeForScopeSize() and offsetOfVariable(ScopeOffset) should used checked arithmetic
<https://webkit.org/b/172134>

Reviewed by Saam Barati.

runtime/JSEnvironmentRecord.h:

(JSC::JSEnvironmentRecord::offsetOfVariable): Change to return
size_t and use checked arithmetic.
(JSC::JSEnvironmentRecord::allocationSizeForScopeSize): Change
to use checked arithmetic.

2:36 PM Changeset in webkit [216879] by jcraig@apple.com

4 edits in trunk/Websites/webkit.org

AX: Inaccessible content on webkit.org main page
https://bugs.webkit.org/show_bug.cgi?id=172106

Reviewed by Joseph Pecoraro.

wp-content/themes/webkit/widgets/icon.php: Resolved link title.
wp-content/themes/webkit/widgets/post.php: Resolved link title.
wp-content/themes/webkit/widgets/twitter.php: Resolved link titles. Suppressed unlabeled images with alt="".

2:23 PM Changeset in webkit [216878] by Chris Dumez

2 edits
35 adds in trunk/LayoutTests/imported/w3c

Import css/geometry-1 web-platform-tests
https://bugs.webkit.org/show_bug.cgi?id=172130

Reviewed by Youenn Fablet.

Import css/geometry-1 web-platform-tests to gain better test coverage.

resources/import-expectations.json:
web-platform-tests/css/geometry-1/DOMMatrix-001-expected.txt: Added.
web-platform-tests/css/geometry-1/DOMMatrix-001.html: Added.
web-platform-tests/css/geometry-1/DOMMatrix-002-expected.txt: Added.
web-platform-tests/css/geometry-1/DOMMatrix-002.html: Added.
web-platform-tests/css/geometry-1/DOMMatrix-003-expected.txt: Added.
web-platform-tests/css/geometry-1/DOMMatrix-003.html: Added.
web-platform-tests/css/geometry-1/DOMMatrix-a-f-alias-expected.txt: Added.
web-platform-tests/css/geometry-1/DOMMatrix-a-f-alias.html: Added.
web-platform-tests/css/geometry-1/DOMMatrix-css-string.worker-expected.txt: Added.
web-platform-tests/css/geometry-1/DOMMatrix-css-string.worker.html: Added.
web-platform-tests/css/geometry-1/DOMMatrix-css-string.worker.js: Added.

(string_appeared_here.forEach.constr.test):
(string_appeared_here.forEach.constr.assert_equals):
(test):

web-platform-tests/css/geometry-1/DOMMatrix-newobject-expected.txt: Added.
web-platform-tests/css/geometry-1/DOMMatrix-newobject.html: Added.
web-platform-tests/css/geometry-1/DOMPoint-001-expected.txt: Added.
web-platform-tests/css/geometry-1/DOMPoint-001.html: Added.
web-platform-tests/css/geometry-1/DOMPoint-002-expected.txt: Added.
web-platform-tests/css/geometry-1/DOMPoint-002.html: Added.
web-platform-tests/css/geometry-1/DOMQuad-001-expected.txt: Added.
web-platform-tests/css/geometry-1/DOMQuad-001.html: Added.
web-platform-tests/css/geometry-1/DOMQuad-002-expected.txt: Added.
web-platform-tests/css/geometry-1/DOMQuad-002.html: Added.
web-platform-tests/css/geometry-1/DOMRect-001-expected.txt: Added.
web-platform-tests/css/geometry-1/DOMRect-001.html: Added.
web-platform-tests/css/geometry-1/OWNERS: Added.
web-platform-tests/css/geometry-1/WebKitCSSMatrix-expected.txt: Added.
web-platform-tests/css/geometry-1/WebKitCSSMatrix.html: Added.
web-platform-tests/css/geometry-1/WebKitCSSMatrix.worker-expected.txt: Added.
web-platform-tests/css/geometry-1/WebKitCSSMatrix.worker.html: Added.
web-platform-tests/css/geometry-1/WebKitCSSMatrix.worker.js: Added.

(test):

web-platform-tests/css/geometry-1/historical-expected.txt: Added.
web-platform-tests/css/geometry-1/historical.html: Added.
web-platform-tests/css/geometry-1/structured-serialization-expected.txt: Added.
web-platform-tests/css/geometry-1/structured-serialization.html: Added.
web-platform-tests/css/geometry-1/w3c-import.log: Added.

2:21 PM Changeset in webkit [216877] by Brent Fulgham

3 edits in trunk/Source/WebKit2

[WK2][macOS][iOS] Allow Network process to access nsurlstoraged's top level domain data cache
https://bugs.webkit.org/show_bug.cgi?id=172128
<rdar://problem/30871490>

Reviewed by Alex Christensen.

NetworkProcess/mac/com.apple.WebKit.NetworkProcess.sb.in:
Resources/SandboxProfiles/ios/com.apple.WebKit.Networking.sb:

1:34 PM Changeset in webkit [216876] by mark.lam@apple.com

15 edits in trunk

WorkerRunLoop::Task::performTask() should check !scriptController->isTerminatingExecution().
https://bugs.webkit.org/show_bug.cgi?id=171775
<rdar://problem/30975761>

Reviewed by Filip Pizlo.

Source/JavaScriptCore:

Increased the number of frames captured in VM::nativeStackTraceOfLastThrow()
from 25 to 100. From experience, I found that 25 is sometimes not sufficient
for our debugging needs.

Also added VM::throwingThread() to track which thread an exception was thrown in.
This may be useful if the client is entering the VM from different threads.

runtime/ExceptionScope.cpp:

(JSC::ExceptionScope::unexpectedExceptionMessage):

runtime/ExceptionScope.h:

(JSC::ExceptionScope::exception):
(JSC::ExceptionScope::unexpectedExceptionMessage):

runtime/Options.h:
Added the unexpectedExceptionStackTraceLimit option.
runtime/VM.cpp:

(JSC::VM::throwException):

runtime/VM.h:

(JSC::VM::throwingThread):
(JSC::VM::clearException):

Source/WebCore:

Currently, WorkerThread::stop() calls scheduleExecutionTermination() to terminate
JS execution first, followed by posting a cleanup task to the worker, and lastly,
it invokes terminate() on the WorkerRunLoop.

As a result, before the run loop is terminated, the worker thread may observe the
TerminatedExecutionException in JS code, bail out, see another JS task to run,
re-enters the VM to run said JS code, and fails with an assertion due to the
TerminatedExecutionException still being pending on VM entry.

WorkerRunLoop::Task::performTask() already has a check to only allow a task to
run if and only if !runLoop.terminated() and the task is not a clean up task.
We'll fix the above race by changing WorkerRunLoop::Task::performTask() to check
!context->script()->isTerminatingExecution() instead of !runLoop.terminated().
Since WorkerThread::stop() always scheduleExecutionTermination() before it
terminates the run loop, !context->script()->isTerminatingExecution() implies
!runLoop.terminated().

The only time that runLoop is terminated without scheduleExecutionTermination()
being called is when WorkerThread::stop() is called before the WorkerThread has
finished creating its WorkerGlobalScope. In this scenario, WorkerThread::stop()
will still terminate the run loop. Hence, after the WorkerGlobalScope is created
(in WorkerThread::workerThread()), we will check if the run loop has been
terminated (i.e. stop() was called). If so, we'll scheduleExecutionTermination()
there, and guarantee that if runloop.terminated() is true, then
context->script()->isTerminatingExecution() is also true.

Solutions that were considered but did not work (recorded for future reference):

In WorkerThread::stop(), call scheduleExecutionTermination() only after it posts the cleanup task and terminate the run loop.

This did not work because this creates a race where the worker thread may run
the cleanup task before WorkerThread::stop() finishes. As a result, the
scriptController may be deleted before we get to invoke scheduleExecutionTermination()
on it, thereby resulting in a use after free.

To make this work, we would have to change the life cycle management strategy
of the WorkerScriptController. This is a more risky change that we would
want to take on at this time, and may also not be worth the gain.

Break scheduleExecutionTermination() up into 2 parts i.e. WorkerThread::stop() will:
1. set the scriptControllers m_isTerminatingExecution flag before posting the cleanup task and terminating the run loop, and
2. invoke VM::notifyNeedsTermination() after posting the cleanup task and terminating the run loop.

This requires that we protect the liveness of the VM until we can invoke
notifyNeedsTermination() on it.

This did not work because:

We may end up destructing the VM in WorkerThread::stop() i.e. in the main web frame, but only the worker thread holds the JS lock for the VM.

We can make the WorkerThread::stop() acquire the JS lock just before it
releases the protected VM's RefPtr, but that would mean the main thread
may be stuck waiting a bit for the worker thread to release its JSLock.
This is not desirable.

In practice, changing the liveness period of the Worker VM relative to its WorkerScriptController and WorkerGlobalScope also has unexpected ramifications. We observed many worker tests failing with assertion failures and crashes due to this change.

Hence, this approach is also a more risky change than it appears on the
surface, and is not worth exploring at this time.

In the end, changing WorkerRunLoop::Task::performTask() to check for
!scriptController->isTerminatingExecution() is the most straight forward solution
that is easy to prove correct.

Also fixed a race in WorkerThread::workerThread() where it can delete the
WorkerGlobalScope while WorkerThread::stop() is in the midst of accessing it.
We now guard the the nullifying of m_workerGlobalScope with the
m_threadCreationAndWorkerGlobalScopeMutex as well.

UPDATE: the only new thing in this patch for re-landing (vs one previously landed)
is that instead of nullifying m_workerGlobalScope directly (thereby deleting the
WorkerGlobalScope context), we'll swap it out and delete it only after we've
unlocked the m_threadCreationAndWorkerGlobalScopeMutex. This is needed because
the destruction of the WorkerGlobalScope will cause the main thread to race against
the worker thread to delete the WorkerThread object, and the WorkerThread object
owns the mutex that we need to unlock after nullifying the m_workerGlobalScope
field.

This issue is covered by an existing test that I just unskipped in TestExpectations.

bindings/js/JSDOMPromiseDeferred.cpp:

(WebCore::DeferredPromise::callFunction):

bindings/js/WorkerScriptController.cpp:

(WebCore::WorkerScriptController::scheduleExecutionTermination):

Added a check to do nothing and return early if the scriptController is already terminating execution.

workers/WorkerRunLoop.cpp:

(WebCore::WorkerRunLoop::runInMode):
(WebCore::WorkerRunLoop::runCleanupTasks):
(WebCore::WorkerRunLoop::Task::performTask):

workers/WorkerRunLoop.h:
Made Task::performTask() private and make Task befriend the WorkerRunLoop class. This ensures that only the WorkerRunLoop may call performTask(). Note: this change only formalizes and hardens a relationship that was already in place before this.

workers/WorkerThread.cpp:

(WebCore::WorkerThread::start):
(WebCore::WorkerThread::workerThread):
(WebCore::WorkerThread::stop):

workers/WorkerThread.h:
Renamed m_threadCreationMutex to m_threadCreationAndWorkerGlobalScopeMutex so that it more accurately describes what it guards.

LayoutTests:

TestExpectations:

1:20 PM Changeset in webkit [216875] by ddkilzer@apple.com

3 edits in trunk/Source/WebKit2

Update json.hpp to v2.1.1
<https://webkit.org/b/172085>
<rdar://problem/32180980>

Reviewed by Alex Christensen.

NetworkProcess/capture/NetworkCaptureEvent.cpp:
Define JSON_NOEXCEPTION as 1 to disable exceptions in json.hpp.

(WebKit::NetworkCapture::JSONCoder<String>::encode):
(WebKit::NetworkCapture::JSONCoder<WebCore::SharedBuffer>::encode):

Build std::string passing in length to avoid the need for a custom basic_json() constructor, and for efficiency.

NetworkProcess/capture/json.hpp:
Update to v2.1.1 and remove customizations.

1:16 PM Changeset in webkit [216874] by mmaxfield@apple.com

4 edits
4 adds in trunk

Unicode characters which can't be rendered in any font are invisible
https://bugs.webkit.org/show_bug.cgi?id=171942
<rdar://problem/32054234>

Reviewed by Tim Horton.

Source/WebCore:

There are some Unicode characters which don't have any font on the system which can render them.
These characters should be drawn as the .notdef "tofu." This is for security and usability, as
well as what Firefox and Chrome do. However, we still shouldn't draw characters with the
Default_Ignorable_Code_Point property, because this is what CoreText does.

This behavior is also what the Unicode spec recommends: In UTR #36 Unicode Security Considerations:
http://www.unicode.org/reports/tr36/#Recommendations_General
"If there is no available glyph for a character, never show a simple "?" or omit the character."

Also relevant is the Unicode Standard section 5.3 Unknown and MIssing Characters, starting at page
marked 203 in the following: http://www.unicode.org/versions/Unicode9.0.0/ch05.pdf

Tests: fast/text/default-ignorable.html

fast/text/unknown-char-notdef.html

platform/graphics/WidthIterator.cpp:

(WebCore::characterMustDrawSomething):

LayoutTests:

fast/text/default-ignorable-expected.html: Added.
fast/text/default-ignorable.html: Added.
fast/text/unknown-char-notdef-expected-mismatch.html: Added.
fast/text/unknown-char-notdef.html: Added.

12:54 PM Changeset in webkit [216873] by jmarcell@apple.com

5 edits in tags/Safari-603.3.1.0.1/Source

Versioning.

12:50 PM Changeset in webkit [216872] by matthew_hanson@apple.com

5 edits in branches/safari-603-branch/Source

Versioning.

12:44 PM Changeset in webkit [216871] by commit-queue@webkit.org

2 edits in trunk/Tools

Disable Picture In Picture API tests on unsupported platforms.
https://bugs.webkit.org/show_bug.cgi?id=172125
rdar://problem/32199477

Patch by Jeremy Jones <jeremyj@apple.com> on 2017-05-15
Reviewed by Simon Fraser.

The callbacks and allowing picture-in-picture require new SPI.

TestWebKitAPI/Tests/WebKit2Cocoa/PictureInPictureDelegate.mm:

12:38 PM Changeset in webkit [216870] by jmarcell@apple.com

1 copy in tags/Safari-603.3.1.0.1

New tag.

12:34 PM Changeset in webkit [216869] by beidson@apple.com

2 edits in trunk/Tools

[ios-simulator] API test WKWebView.ClearAppCache is failing.
https://bugs.webkit.org/show_bug.cgi?id=172120

Unreviewed test gardening.

TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageClear.mm:

(TEST): ios-sim needs explicit deleting of the app cache paths that I'd removed in 216805.

Restoring that code fixes this.

12:21 PM Changeset in webkit [216868] by timothy_horton@apple.com

4 edits in trunk

Null deref under WebContentReader::readURL when interacting with a file URL
https://bugs.webkit.org/show_bug.cgi?id=172045
<rdar://problem/25880647>

Reviewed by Wenson Hsieh.

editing/ios/EditorIOS.mm:

(WebCore::Editor::WebContentReader::readURL):
The AppSupport soft link was wrong, as there is no such framework in /System/Library/Frameworks.
Thus, any time we hit this codepath, the soft linked function would be null, and calling it would crash.
Instead of just fixing the soft link, remove the code, because it does not seem necessary to
special-case fileURLs to images in the media directory.

TestWebKitAPI/Tests/ios/DataInteractionTests.mm:

(TestWebKitAPI::TEST):
The text of the file URL is pasted because a textual version of it gets
onto the pasteboard. However, this test would have crashed before. Also
tests that we don't make an <a>.

11:31 AM Changeset in webkit [216867] by Brent Fulgham

2 edits in trunk/Source/WebKit2

Unreviewed build fix.

Debugging code was accidentally left in the Plugin sandbox profile.

PluginProcess/mac/com.apple.WebKit.plugin-common.sb.in:

11:26 AM Changeset in webkit [216866] by eric.carlson@apple.com

5 edits in trunk/Source/WebCore

ASSERTION FAILED: wasRemoved in WebCore::RealtimeMediaSourceCenter::removeDevicesChangedObserver(DevicesChangedObserverToken)
https://bugs.webkit.org/show_bug.cgi?id=171529
<rdar://problem/31945791>

Reviewed by Jer Noble.

No new tests, fixes a crash in existing tests.

Modules/mediastream/MediaDevices.cpp:

(WebCore::MediaDevices::MediaDevices): Use a weak ptr.

platform/mediastream/RealtimeMediaSourceCenter.cpp:
platform/mediastream/RealtimeMediaSourceCenter.cpp:

(WebCore::observerMap): Use a static hash map for observers because the
source center can change at runtime.
(WebCore::RealtimeMediaSourceCenter::addDevicesChangedObserver):
(WebCore::RealtimeMediaSourceCenter::removeDevicesChangedObserver):
(WebCore::RealtimeMediaSourceCenter::captureDevicesChanged):

11:14 AM Changeset in webkit [216865] by commit-queue@webkit.org

1 edit
1 add in trunk/Source/WebInspectorUI

[GTK] Web Inspector: Add new GTK+ icons for Search icon of Quick Open dialog
https://bugs.webkit.org/show_bug.cgi?id=172110

Patch by Fujii Hironori <Fujii Hironori> on 2017-05-15
Reviewed by Michael Catanzaro.

Add a free icon for the Web Inspector in GTK+.

UserInterface/Images/gtk/Search.svg: Added.

11:11 AM Changeset in webkit [216864] by commit-queue@webkit.org

2 edits
4 adds in trunk/Source/WebInspectorUI

[GTK] Web Inspector: Add new GTK+ icons for Worker Scripts / Web Sockets
https://bugs.webkit.org/show_bug.cgi?id=164138

Patch by Fujii Hironori <Fujii Hironori> on 2017-05-15
Reviewed by Michael Catanzaro.

Add more free icons for the Web Inspector in GTK+.

UserInterface/Images/gtk/WorkerScript.png: Added.
UserInterface/Images/gtk/WorkerScript@2x.png: Added.
UserInterface/Images/gtk/WorkerScriptLarge.png: Added.
UserInterface/Images/gtk/WorkerScriptLarge@2x.png: Added.
UserInterface/Views/ResourceIcons.css:

(.script.worker-icon .icon):
(.large .script.worker-icon .icon):
(body:matches(.mac-platform, .windows-platform) .script.worker-icon .icon): Deleted.
(body:matches(.mac-platform, .windows-platform) .large .script.worker-icon .icon): Deleted.

10:24 AM Changeset in webkit [216863] by Brent Fulgham

2 edits in trunk/Source/WebCore

[iOS WK1] Do not try to dispatch messages to subframes if their documents have not been constructed yet.
https://bugs.webkit.org/show_bug.cgi?id=172059
<rdar://problem/31963192>

Reviewed by Zalan Bujtas.

On iOS WK1 we can end up in an inconsistent state, where

The web thread is inside a newly-injected iframe's document's constructor and
waiting on a delegate callback on the main thread

while the main thread
(a) Evaluates arbitrary JavaScript that modifies storage which
(b) Triggers an event dispatch.

storage/StorageEventDispatcher.cpp:

(WebCore::StorageEventDispatcher::dispatchSessionStorageEvents): If the sub-frame's document
is in an inconsistent state, skip it.
(WebCore::StorageEventDispatcher::dispatchLocalStorageEvents): Ditto.
(WebCore::StorageEventDispatcher::dispatchSessionStorageEventsToFrames): Ditto.
(WebCore::StorageEventDispatcher::dispatchLocalStorageEventsToFrames): Ditto.

8:26 AM Changeset in webkit [216862] by yoon@igalia.com

3 edits in trunk/Source/WebKit2

[WPE] Unreviewed debug build fix
https://bugs.webkit.org/show_bug.cgi?id=172118

Unreviewed, remove a dead code accidentally committed in r215259.

Shared/CoordinatedGraphics/threadedcompositor/CompositingRunLoop.h:

Remove deprecated CompositingRunLoop::isCurrent.

Shared/CoordinatedGraphics/threadedcompositor/ThreadedCompositor.cpp:

(WebKit::ThreadedCompositor::frameComplete):

7:21 AM Changeset in webkit [216861] by Alan Bujtas

3 edits
2 adds in trunk

Simple line layout: Leading whitespace followed by a <br> produces an extra linebreak.
https://bugs.webkit.org/show_bug.cgi?id=172076

Reviewed by Antti Koivisto.

Source/WebCore:

When the collapsed whitespace does not fit the line, we need to push it to the next line
so that we can decide whether any soft/hard linebreak should be skipped (to avoid double line breaks) or not.

Test: fast/text/simple-line-layout-leading-whitespace-with-soft-hard-linebreak.html

rendering/SimpleLineLayout.cpp:

(WebCore::SimpleLineLayout::consumeLineBreakIfNeeded): special handling <br>
(WebCore::SimpleLineLayout::firstFragment): Now we need to deal with leading collapsed whitespace.
(WebCore::SimpleLineLayout::createLineRuns): We need to push even the collapsed whitespace to the next line.

LayoutTests:

fast/text/simple-line-layout-leading-whitespace-with-soft-hard-linebreak-expected.html: Added.
fast/text/simple-line-layout-leading-whitespace-with-soft-hard-linebreak.html: Added.

2:14 AM Changeset in webkit [216860] by nael.ouedraogo@crf.canon.fr

7 edits
1 copy
2 adds in trunk

Invalid MediaSource duration value should throw TyperError instead of InvalidStateError
https://bugs.webkit.org/show_bug.cgi?id=171653

Reviewed by Chris Dumez.

LayoutTests/imported/w3c:

Rebaseline test results.

web-platform-tests/media-source/mediasource-duration-boundaryconditions-expected.txt:

Source/WebCore:

Modify MediaSource::setDuration to throw a TypeError when duration value is invalid as per MSE specification
(https://www.w3.org/TR/2016/REC-media-source-20161117/#dom-mediasource-duration).

Update expectations of corresponding WPT test.

Modules/mediasource/MediaSource.cpp:

(WebCore::MediaSource::setDuration):
(WebCore::MediaSource::setDurationInternal):

LayoutTests:

Modify MediaSource::setDuration to throw a TypeError when duration value is invalid as per MSE specification
(https://www.w3.org/TR/2016/REC-media-source-20161117/#dom-mediasource-duration).

Update expectations of corresponding WPT test.

platform/gtk/TestExpectations:
platform/gtk/imported/w3c/web-platform-tests/media-source/mediasource-duration-boundaryconditions-expected.txt: Added.
platform/mac-elcapitan/imported/w3c/web-platform-tests/media-source/mediasource-duration-boundaryconditions-expected.txt: Added.
platform/mac/TestExpectations:

2:06 AM Changeset in webkit [216859] by yoon@igalia.com

3 edits
2 adds in trunk

[CAIRO] Painting an image mask with a matrix above Pixman's limit breaks internal states of Cairo
https://bugs.webkit.org/show_bug.cgi?id=169094

Reviewed by Žan Doberšek.

Source/WebCore:

It is the same problem which addressed in r212431.
In HiDPI situation, it happens easily due to the size of coordinates.
Also, if this bug happens, it will break the rendering continuously
since we are reusing graphics contexts to render webpages in same
webview.

Test: fast/hidpi/hidpi-long-page-with-inset-element.html

platform/graphics/cairo/PlatformContextCairo.cpp:

(WebCore::PlatformContextCairo::pushImageMask):
We can avoid the limit of the Pixman by reducing the source surface's
size, and it will create a minimal pattern matrix.

LayoutTests:

fast/hidpi/hidpi-long-page-with-inset-element-expected.html: Added.
fast/hidpi/hidpi-long-page-with-inset-element.html: Added.

12:01 AM Changeset in webkit [216858] by jcraig@apple.com

2 edits
11 adds
1 delete in trunk/Websites/webkit.org

2017-05-14 James Craig <jcraig@apple.com>

Upload poster images and working captioned video
https://bugs.webkit.org/show_bug.cgi?id=172102

Unreviewed. More resources for prefers-reduced-motion post.

blog-files/prefers-reduced-motion/axi.htm: Added.
blog-files/prefers-reduced-motion/axi.png: Removed.
blog-files/prefers-reduced-motion/posters: Added.
blog-files/prefers-reduced-motion/posters/apple_env_load.jpg: Added.
blog-files/prefers-reduced-motion/posters/apple_env_planeshift.jpg: Added.
blog-files/prefers-reduced-motion/posters/apple_ios10.jpg: Added.
blog-files/prefers-reduced-motion/posters/apple_shoot.jpg: Added.
blog-files/prefers-reduced-motion/posters/apple_shoot_reduced.jpg: Added.
blog-files/prefers-reduced-motion/posters/apple_sierra.jpg: Added.
blog-files/prefers-reduced-motion/posters/apple_sierra_reduced.jpg: Added.
blog-files/prefers-reduced-motion/posters/axi.jpg: Added.
blog-files/prefers-reduced-motion/posters/viljami.jpg: Added.
blog-files/prefers-reduced-motion/prm.htm: Link to axi.htm video demo.

May 14, 2017:

11:20 PM Changeset in webkit [216857] by pvollan@apple.com

6 edits in trunk

[Win] fast/cookies/local-file-can-set-cookies.html is flaky.
https://bugs.webkit.org/show_bug.cgi?id=172071

Reviewed by Alexey Proskuryakov.

Source/WebKit/win:

We need to delete all cookies after each test.

Interfaces/IWebPreferencesPrivate.idl:
WebPreferences.cpp:

(WebPreferences::linkPreloadEnabled):
(WebPreferences::clearNetworkLoaderSession):

WebPreferences.h:

Tools:

DumpRenderTree/win/DumpRenderTree.cpp:

(resetWebPreferencesToConsistentValues):

10:51 PM Changeset in webkit [216856] by zandobersek@gmail.com

2 edits in trunk/Source/WebCore

Unreviewed build fix with newer Perl versions.

bindings/scripts/CodeGeneratorJS.pm:

(AddLegacyCallerOperationIfNeeded): Support for experimental push on scalar (and
other auto-dereferencing) was removed in Perl 5.24. Instead, the LegacyCallers array
has to be dereferenced when pushing new values to it.

10:00 PM Changeset in webkit [216855] by jcraig@apple.com

2 edits in trunk/Websites/webkit.org

2017-05-14 James Craig <jcraig@apple.com>

AX: All the articles on the WebKit blog are called 'Clickable Link' by VoiceOver
https://bugs.webkit.org/show_bug.cgi?id=172096
<rdar://problem/31624323>

Unreviewed. Fixing broken link titles for screen readers.

wp-content/themes/webkit/loop.php: Adding relevant link label for accessibility.

8:45 PM Changeset in webkit [216854] by bshafiei@apple.com

3 edits in tags/Safari-604.1.22.0.1/Source/WebCore

Merged r216807. rdar://problem/32169232

8:44 PM Changeset in webkit [216853] by bshafiei@apple.com

7 edits in tags/Safari-604.1.22.0.1/Source

Versioning.

8:42 PM Changeset in webkit [216852] by bshafiei@apple.com

1 copy in tags/Safari-604.1.22.0.1

New tag.

6:09 PM Changeset in webkit [216851] by weinig@apple.com

22 edits
2 adds
1 delete in trunk

[WebIDL/DOM] Remove need for custom bindings for HTMLAllCollection and bring up to spec
https://bugs.webkit.org/show_bug.cgi?id=172095

Reviewed by Darin Adler.

LayoutTests/imported/w3c:

web-platform-tests/html/infrastructure/common-dom-interfaces/collections/htmlallcollection-expected.txt:

Update results.

Source/WebCore:

Adds support for the legacycaller WebIDL special annotation.
Updates implementation of HTMLAllCollection to match the current HTML spec.

Test: fast/dom/document-all.html

CMakeLists.txt:
WebCore.xcodeproj/project.pbxproj:
bindings/js/JSBindingsAllInOne.cpp:
bindings/js/JSHTMLAllCollectionCustom.cpp: Removed.

Removed JSHTMLAllCollectionCustom.cpp

bindings/scripts/CodeGeneratorJS.pm:

(GenerateInterface):
(AddLegacyCallerOperationIfNeeded):
Before code generation, clone all the legacycaller operations and put them
in their own set, so they can form an overload set.

(AddStringifierOperationIfNeeded):
Use IDLParser::cloneType as the FIXME suggested.

(GenerateHeader):
Group call related functionality together and use new IsCallable predicate.

(GenerateOverloadedFunctionOrConstructor):
Generalize a little bit to allow the function being overloaded to be an overloaded legacycaller.

(GenerateImplementation):
Add call to generate the legacycaller code.

(GenerateLegacyCallerDefinitions):
(GenerateLegacyCallerDefinition):
Generate the legacycaller definition, using GenerateArgumentsCountCheck, GenerateParametersCheck
and GenerateImplementationFunctionCall to do all the heavy lifting.

(IsCallable):
Add helper predicate for both custom calls and legacycaller.

bindings/scripts/IDLParser.pm:

(cloneType):.
(cloneArgument):.
(cloneOperation):
Add cloning functions for IDLArgument and IDLOperation, and make IDLType's
clone feasible for calling outside the package by removing the unneeded
self parameter.

bindings/scripts/test/JS/JSTestObj.cpp
bindings/scripts/test/JS/JSTestObj.h
bindings/scripts/test/TestObj.idl:

Add testing of legacycaller overloading.

dom/Document.cpp:

(WebCore::Document::allFilteredByName):

dom/Document.h:

Add new collection access for the HTMLAllNamedSubCollection.

html/CachedHTMLCollection.h:

(WebCore::nameShouldBeVisibleInDocumentAll):
Update list of tags to match the current spec.

html/CollectionType.h:

Add new type for HTMLAllNamedSubCollection.

html/GenericCachedHTMLCollection.cpp:

(WebCore::GenericCachedHTMLCollection<traversalType>::elementMatches):
Specify that DocumentAllNamedItems does not want
the default elementMatches.

html/HTMLAllCollection.cpp:

(WebCore::HTMLAllCollection::namedOrIndexedItemOrItems):
(WebCore::HTMLAllCollection::namedItemOrItems):
(WebCore::HTMLAllNamedSubCollection::~HTMLAllNamedSubCollection):
(WebCore::HTMLAllNamedSubCollection::elementMatches):

html/HTMLAllCollection.h:

Move implementations from the custom binding, and re-implement to
match the spec. Alternate names to item/namedItem were needed to not
shadow the existing ones in HTMLCollection. HTMLAllNamedSubCollection
is a simple HTMLCollection that matches on a name, following the rules
of document.all about which tags can have name attributes.

html/HTMLAllCollection.idl:

Remove custom annotations and add legacycaller which is now supported.

html/HTMLCollection.cpp:

(WebCore::invalidationTypeExcludingIdAndNameAttributes):
(WebCore::HTMLCollection::~HTMLCollection):
Add DocumentAllNamedItems.

LayoutTests:

fast/dom/collection-null-like-arguments-expected.txt:

Update results.

fast/dom/document-all-expected.txt: Added.
fast/dom/document-all.html: Added.

New test that covers a bunch of missing coverage.

5:46 PM Changeset in webkit [216850] by commit-queue@webkit.org

3 edits
6 deletes in trunk/Source/WebKit2

[CoordinatedGraphics] Remove unused files and lines
https://bugs.webkit.org/show_bug.cgi?id=172080

Patch by Daewoong Jang <daewoong.jang@navercorp.com> on 2017-05-14
Reviewed by Darin Adler.

Shared/CoordinatedGraphics/CoordinatedGraphicsArgumentCoders.cpp: Removed.
Shared/CoordinatedGraphics/CoordinatedGraphicsArgumentCoders.h: Removed.
Shared/CoordinatedGraphics/WebCoordinatedSurface.cpp: Removed.
Shared/CoordinatedGraphics/WebCoordinatedSurface.h: Removed.
UIProcess/CoordinatedGraphics/WKCoordinatedSceneAPICast.h: Removed.
UIProcess/WebPageProxy.h:
WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.cpp:
WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.messages.in: Removed.

2:16 PM Changeset in webkit [216849] by Alan Bujtas

3 edits in trunk/Source/WebCore

Remove unused lambda in TextFragmentIterator::TextFragment::split() and cleanup dependencies.
https://bugs.webkit.org/show_bug.cgi?id=172089

Reviewed by David Kilzer.

rendering/SimpleLineLayout.cpp:

(WebCore::SimpleLineLayout::splitFragmentToFitLine):

rendering/SimpleLineLayoutTextFragmentIterator.h:

(WebCore::SimpleLineLayout::TextFragmentIterator::TextFragment::split):
(WebCore::SimpleLineLayout::TextFragmentIterator::TextFragment::splitWithHyphen):

1:10 PM Changeset in webkit [216848] by jmarcell@apple.com

7 edits in branches/safari-604.1.21-branch/Source

Versioning.

12:27 PM Changeset in webkit [216847] by akling@apple.com

2 edits in trunk/Source/WebKit2

Always reset the assisted node when the main frame commits a new load.
https://bugs.webkit.org/show_bug.cgi?id=172088

Reviewed by Antti Koivisto.

WebPage::m_assistedNode could extend the lifetime of the document it pointed into
if the main frame was navigated while the assisted node was in one of its subframes.
The life-supported document wouldn't be reachable from JavaScript but nevertheless
would consume memory and other resources.

This patch fixes the issue by always clearing WebPage::m_assistedNode when the main
frame commits a new load.

WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::resetAssistedNodeForFrame):

10:43 AM Changeset in webkit [216846] by ddkilzer@apple.com

3 edits in trunk/LayoutTests

[iOS/macOS Debug WK2] LayoutTests/imported/w3c/web-platform-tests/webrtc/interfaces.html is a flaky crash due to assertion failure
<https://bugs.webkit.org/show_bug.cgi?id=172094>
<rdar://problem/32184256>

Unreviewed test gardening.

platform/ios-wk2/TestExpectations:
platform/mac-wk2/TestExpectations:
Mark test as flaky crash on Debug WK2 builds.

9:36 AM Changeset in webkit [216845] by matthew_hanson@apple.com

1 copy in tags/Safari-604.1.21.3

Tag Safari-604.1.21.3.

6:27 AM Changeset in webkit [216844] by Csaba Osztrogonác

2 edits in trunk/Source/WebKit2

Unreviewed Mac cmake buildfix after r216690, just for fun.

PlatformMac.cmake:

4:28 AM Changeset in webkit [216843] by ddkilzer@apple.com

2 edits in trunk/LayoutTests

[macOS Debug WK1] fast/parser/adoption-agency-unload-iframe-4.html is a flaky timeout (always on iOS 10 Release WK1)
<https://webkit.org/b/172092>

Unreviewed test gardening.

platform/ios-wk1/TestExpectations:
This only times out on Release builds.

4:16 AM Changeset in webkit [216842] by ddkilzer@apple.com

3 edits in trunk/LayoutTests

[macOS Debug WK1] fast/parser/adoption-agency-unload-iframe-4.html is a flaky timeout (always on iOS 10 Release WK1)
<https://webkit.org/b/172092>

Unreviewed test gardening.

See also Bug 169211 for a similar GTK WK1 timeout.

platform/ios-wk1/TestExpectations:
Mark as always timing out on all builds.
platform/mac-wk1/TestExpectations:
Mark flaky on Debug builds.

3:41 AM Changeset in webkit [216841] by ddkilzer@apple.com

9 edits in trunk/Source/WebKit2

Fix unused lambdas in WebKit2
<https://webkit.org/b/172090>

Reviewed by Chris Dumez.

Fixes unused lambda warnings found with newer clang.

NetworkProcess/cache/NetworkCache.cpp:

(WebKit::NetworkCache::Cache::retrieve):

NetworkProcess/cache/NetworkCacheStatistics.cpp:

(WebKit::NetworkCache::Statistics::initialize):

Use UNUSED_PARAM() to silence unused lambda warning since 'startTime' is used in Debug builds.

NetworkProcess/capture/NetworkCaptureManager.cpp:

(WebKit::NetworkCapture::Manager::fuzzyMatchURLs):

Remove unused 'this' from lambda capture.

NetworkProcess/cocoa/NetworkSessionCocoa.mm:

(-[WKNetworkSessionDelegate URLSession:task:willPerformHTTPRedirection:newRequest:completionHandler:]):
(-[WKNetworkSessionDelegate URLSession:task:_schemeUpgraded:completionHandler:]):
(-[WKNetworkSessionDelegate URLSession:task:didReceiveChallenge:completionHandler:]):
(-[WKNetworkSessionDelegate URLSession:dataTask:didReceiveResponse:completionHandler:]):

Use UNUSED_PARAM() to silence unused lambda warning since 'taskIdentifier' is used in Debug builds.

UIProcess/WebResourceLoadStatisticsStore.cpp:

(WebKit::WebResourceLoadStatisticsStore::registerSharedResourceLoadObserver):
(WebKit::WebResourceLoadStatisticsStore::applicationWillTerminate):

Remove unused 'this' from lambda captures.

UIProcess/WebsiteData/WebsiteDataStore.cpp:

(WebKit::WebsiteDataStore::fetchData):

Remove unused 'fetchOptions' from lambda capture.

(WebKit::WebsiteDataStore::fetchDataForTopPrivatelyControlledDomains):

Remove unused 'this' from lambda capture.

UIProcess/mac/ViewGestureControllerMac.mm:

(WebKit::ViewGestureController::forceRepaintIfNeeded):

Remove unused 'this' from lambda capture.

WebProcess/cocoa/WebVideoFullscreenManager.mm:

(WebKit::WebVideoFullscreenManager::didExitFullscreen):

Remove unused 'this' from nested lambda captures.

1:18 AM Changeset in webkit [216840] by rniwa@webkit.org

2 edits in trunk/Websites/perf.webkit.org

Build fix. Added a missing null check.

public/v3/pages/analysis-task-page.js:

(AnalysisTaskConfiguratorPane.prototype.setTestGroups):

12:31 AM Changeset in webkit [216839] by Chris Dumez

11 edits
1 delete in trunk

Drop PassRefPtr class from WTF
https://bugs.webkit.org/show_bug.cgi?id=172091

Reviewed by Alex Christensen.

Source/WTF:

Drop PassRefPtr class from WTF as it is no longer used or needed.
Also drop RefPtr::release() for the same reasons.

WTF.xcodeproj/project.pbxproj:
wtf/CMakeLists.txt:
wtf/CrossThreadCopier.cpp:
wtf/CrossThreadCopier.h:
wtf/Forward.h:
wtf/PassRefPtr.h: Removed.
wtf/RefPtr.h:

(WTF::refIfNotNull):
(WTF::derefIfNotNull):
(WTF::RefPtr::RefPtr):
(WTF::RefPtr::release): Deleted.

wtf/SizeLimits.cpp:
wtf/Vector.h:

Tools:

Drop API test coverage.

TestWebKitAPI/Tests/WTF/Ref.cpp:

(TestWebKitAPI::TEST):
(TestWebKitAPI::passWithPassRefPtr): Deleted.

Note: See TracTimeline for information about the timeline view.

Download in other formats:

RSS Feed