Context Navigation

← Previous Period
Next Period →

Timeline

May 20, 2017:

11:01 PM Changeset in webkit [217195] by ap@apple.com

3 edits in trunk/LayoutTests

Correct line endings in a couple files.

fast/canvas/script-tests/canvas-gradient-without-path.js:
fast/dom/Geolocation/page-reload-cancel-permission-requests.html:

7:10 PM Changeset in webkit [217194] by Chris Dumez

10 edits
3 deletes in trunk

Drop [NoInterfaceObject] from RTCDTMFSender and RTCStatsReport
https://bugs.webkit.org/show_bug.cgi?id=172418

Reviewed by Youenn Fablet.

Source/JavaScriptCore:

Add CommonIdentifiers that are now needed.

runtime/CommonIdentifiers.h:

Source/WebCore:

Drop [NoInterfaceObject] from RTCDTMFSender and RTCStatsReport to match the specification:

Firefox exposes both RTCDTMFSender and RTCStatsReport. Chrome exposes RTCStatsReport only.
RTCDTMFSender seems to be currently disabled at build time currently so the change to
its interface does not currently impact Web-exposed behavior, only the change to the
RTCStatsReport interface currently does.

No new tests, rebaselined existing test.

Modules/mediastream/RTCDTMFSender.idl:
Modules/mediastream/RTCStatsReport.idl:

Drop [NoInterfaceObject].

Modules/mediastream/RTCIceCandidateEvent.cpp: Removed.
Modules/mediastream/RTCIceCandidateEvent.h: Removed.
Modules/mediastream/RTCIceCandidateEvent.idl: Removed.

Drop class and IDL that are no longer used. They were not even part of any project files.
RTCIceCandidateEvent has been renamed to RTCPeerConnectionIceEvent, which we support.

LayoutTests:

Rebaseline existing test to reflect change.

platform/mac-elcapitan/js/dom/global-constructors-attributes-expected.txt:
platform/mac-wk1/js/dom/global-constructors-attributes-expected.txt:
platform/mac-yosemite/js/dom/global-constructors-attributes-expected.txt:
platform/mac/js/dom/global-constructors-attributes-expected.txt:

3:40 PM Changeset in webkit [217193] by Yusuke Suzuki

3 edits in trunk/Source/JavaScriptCore

Unreviewed, add scope.release() to propertyIsEnumerable functions.
https://bugs.webkit.org/show_bug.cgi?id=172411

runtime/JSGlobalObjectFunctions.cpp:

(JSC::globalFuncPropertyIsEnumerable):

runtime/ObjectPrototype.cpp:

(JSC::objectProtoFuncPropertyIsEnumerable):

1:07 PM Changeset in webkit [217192] by Yusuke Suzuki

16 edits
2 deletes in trunk/Source/JavaScriptCore

[JSC] Drop MapBase
https://bugs.webkit.org/show_bug.cgi?id=172417

Reviewed by Sam Weinig.

MapBase is a purely additional indirection. JSMap and JSSet can directly inherit HashMapImpl.
Thus MapBase is unnecessary. This patch drops it.
It is good because we can eliminate one indirection when accessing to map implementation.
Moreover, we can drop one unnecessary allocation per Map and Set.

CMakeLists.txt:
JavaScriptCore.xcodeproj/project.pbxproj:
dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

ftl/FTLAbstractHeapRepository.h:
ftl/FTLLowerDFGToB3.cpp:

(JSC::FTL::DFG::LowerDFGToB3::compileGetMapBucket):

runtime/HashMapImpl.cpp:

(JSC::HashMapImpl<HashMapBucket>::estimatedSize):
(JSC::getHashMapImplKeyClassInfo): Deleted.
(JSC::getHashMapImplKeyValueClassInfo): Deleted.

runtime/HashMapImpl.h:

(JSC::HashMapImpl::finishCreation):
(JSC::HashMapImpl::get):
(JSC::HashMapImpl::info): Deleted.
(JSC::HashMapImpl::createStructure): Deleted.
(JSC::HashMapImpl::create): Deleted.

runtime/JSMap.h:

(JSC::JSMap::set):
(JSC::JSMap::get): Deleted.

runtime/JSMapIterator.cpp:

(JSC::JSMapIterator::finishCreation):

runtime/JSSet.h:

(JSC::JSSet::add): Deleted.

runtime/JSSetIterator.cpp:

(JSC::JSSetIterator::finishCreation):

runtime/MapBase.cpp: Removed.
runtime/MapBase.h: Removed.
runtime/MapPrototype.cpp:

(JSC::mapProtoFuncSize):

runtime/SetConstructor.cpp:

(JSC::constructSet):

runtime/SetPrototype.cpp:

(JSC::setProtoFuncSize):

runtime/VM.cpp:

(JSC::VM::VM):

1:02 PM Changeset in webkit [217191] by Yusuke Suzuki

6 edits in trunk/Source/JavaScriptCore

[JSC] Speedup Object.assign for slow case by using propertyIsEnumerable
https://bugs.webkit.org/show_bug.cgi?id=172411

Reviewed by Sam Weinig.

We use @Reflect.@getOwnPropertyDescriptor() to check

the descriptor exists,
and the descriptor.enumrable is true

But Object::propertyIsEnumerable does the completely same thing without
allocating a new object for property descriptor.

In this patch, we add a new private function @propertyIsEnumerable, and
use it in Object.assign implementation. It does not allocate unnecessary
objects. It is good for GC-pressure and performance.

This patch improves SixSpeed object-assign.es6 by 1.7x. While this patch
does not introduce a fast path for objects that do not have accessors,
and it could speed up things further, this patch can speed up the common
slow path cases that is the current implementation of Object.assign.

object-assign.es6 1103.2487+-21.5602 ^{621.8478+-34.9875} definitely 1.7741x faster

builtins/BuiltinNames.h:
builtins/ObjectConstructor.js:

(globalPrivate.enumerableOwnProperties):
(assign):

runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::init):

runtime/JSGlobalObjectFunctions.cpp:

(JSC::globalFuncPropertyIsEnumerable):

runtime/JSGlobalObjectFunctions.h:

12:56 PM Changeset in webkit [217190] by commit-queue@webkit.org

2 edits in trunk/Tools

[GTK] gtkdoc-fixxref needs --module argument to work
https://bugs.webkit.org/show_bug.cgi?id=172415

Patch by Ting-Wei Lan <Ting-Wei Lan> on 2017-05-20
Reviewed by Michael Catanzaro.

gtk/gtkdoc.py:

(GTKDoc._run_gtkdoc_fixxref):

12:25 PM Changeset in webkit [217189] by Michael Catanzaro

2 edits in trunk/Source/WebKit2

-Wreturn-type warning triggered by WKNotification.cpp:77
https://bugs.webkit.org/show_bug.cgi?id=172414

Reviewed by Sam Weinig.

UIProcess/API/C/WKNotification.cpp:

(WKNotificationCopyDir):

12:14 PM Changeset in webkit [217188] by Chris Dumez

7 edits in trunk

Value for iterator property is wrong for maplike interfaces
https://bugs.webkit.org/show_bug.cgi?id=172410

Reviewed by Sam Weinig.

Source/WebCore:

Value for iterator property was wrong for maplike interfaces. The iterator property is
supposed to have the same value as the 'entries' property but we were using the value
of the 'values' property.

Specification:

This impacts the iterator of the RTCStatsReport interface.

No new tests, updated existing test.

bindings/scripts/CodeGeneratorJS.pm:

(GenerateImplementation):

bindings/scripts/test/JS/JSMapLike.cpp:

(WebCore::JSMapLikePrototype::finishCreation):

bindings/scripts/test/JS/JSReadOnlyMapLike.cpp:

(WebCore::JSReadOnlyMapLikePrototype::finishCreation):

LayoutTests:

Extend test coverage to test the RTCStatsReport iterator.

webrtc/video-stats.html:

11:58 AM Changeset in webkit [217187] by Chris Dumez

2 edits in trunk/Source/WebCore

Drop superfluous iterator property setting in addValueIterableMethods()
https://bugs.webkit.org/show_bug.cgi?id=172409

Reviewed by Youenn Fablet.

Drop superfluous iterator setting in addValueIterableMethods(). The bindings already take care of
adding the iterator property before calling addValueIterableMethods().

No new tests, no Web-facing behavior change.

bindings/js/JSDOMIterator.cpp:

(WebCore::addValueIterableMethods):

11:15 AM Changeset in webkit [217186] by ap@apple.com

2 edits in trunk/Tools

make-new-script-test should create tests that use js-test.js, not js-test-pre.js
https://bugs.webkit.org/show_bug.cgi?id=172416

Reviewed by Daniel Bates.

Scripts/make-new-script-test:

9:55 AM Changeset in webkit [217185] by jer.noble@apple.com

19 edits
6 adds in trunk

[MSE][Mac] Support painting MSE video-element to canvas
https://bugs.webkit.org/show_bug.cgi?id=125157
<rdar://problem/23062016>

Reviewed by Eric Carlson.

Source/WebCore:

Test: media/media-source/media-source-paint-to-canvas.html

In order to have access to decoded video data for painting, decode the encoded samples manually
instead of adding them to the AVSampleBufferDisplayLayer. To facilitate doing so, add a new
utility class WebCoreDecompressionSession, which can decode samples and store them.

For the purposes of this patch, to avoid double-decoding of video data and to avoid severe complication
of our sample delivery pipeline, we will only support painting of decoded video samples when the video is
not displayed in the DOM.

Modules/mediasource/MediaSource.cpp:

(WebCore::MediaSource::seekToTime): Always send waitForSeekCompleted() to give private a chance to delay seek completion.

Modules/mediasource/SourceBuffer.cpp:

(WebCore::SourceBuffer::sourceBufferPrivateReenqueSamples): Added.

Modules/mediasource/SourceBuffer.h:
WebCore.xcodeproj/project.pbxproj:
platform/cf/CoreMediaSoftLink.cpp: Added new soft link macros.
platform/cf/CoreMediaSoftLink.h: Ditto.
platform/cocoa/CoreVideoSoftLink.cpp: Ditto.
platform/cocoa/CoreVideoSoftLink.h: Ditto.
platform/graphics/SourceBufferPrivateClient.h:
platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.h:

(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::sampleBufferDisplayLayer): Simple accessor.
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::decompressionSession): Ditto.

platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:

(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::MediaPlayerPrivateMediaSourceAVFObjC):
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::load): Update whether we should be displaying in a layer or decompression session..
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::setVisible): Ditto.
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::waitForSeekCompleted): m_seeking is now an enum.
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::seeking): Ditto.
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::seekCompleted): Ditto. If waiting for a video frame, delay completing seek.
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::nativeImageForCurrentTime): Call updateLastImage() and return result.
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::updateLastImage): Fetch the image for the current time.
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::paint): Pass to paintCurrentFrameInCanvas.
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::paintCurrentFrameInContext): Get a native image, and render it.
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::acceleratedRenderingStateChanged): Create or destroy a layer or decompression session as appropriate.
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::ensureLayer): Creates a layer.
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::destroyLayer): Destroys a layer.
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::ensureDecompressionSession): Creates a decompression session.
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::destroyDecompressionSession): Destroys a decompression session.
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::setHasAvailableVideoFrame): If seek completion delayed, complete now. Ditto for ready state change.
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::setReadyState): If waiting for a video frame, delay ready state change.
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::addDisplayLayer): Deleted.
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::removeDisplayLayer): Deleted.

platform/graphics/avfoundation/objc/MediaSourcePrivateAVFObjC.h:
platform/graphics/avfoundation/objc/MediaSourcePrivateAVFObjC.mm:

(WebCore::MediaSourcePrivateAVFObjC::hasVideo): Promote to a class function.
(WebCore::MediaSourcePrivateAVFObjC::hasSelectedVideo): Return whether any of the active source buffers have video and are selected.
(WebCore::MediaSourcePrivateAVFObjC::hasSelectedVideoChanged): Call setSourceBufferWithSelectedVideo().
(WebCore::MediaSourcePrivateAVFObjC::setVideoLayer): Set (or clear) the layer on the selected buffer.
(WebCore::MediaSourcePrivateAVFObjC::setDecompressionSession): Ditto for decompression session.
(WebCore::MediaSourcePrivateAVFObjC::setSourceBufferWithSelectedVideo): Remove the layer and decompression session from the unselected

buffer and add the decompression session or layer to the newly selected buffer.

(WebCore::MediaSourcePrivateAVFObjCHasVideo): Deleted.

platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.h:
platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm:

(WebCore::SourceBufferPrivateAVFObjC::destroyRenderers): Clear the videoLayer and decompressionSession.
(WebCore::SourceBufferPrivateAVFObjC::hasSelectedVideo): Return whether the buffer has a selected video track.
(WebCore::SourceBufferPrivateAVFObjC::trackDidChangeEnabled): The media player now manages the video layer and decompression session lifetimes.
(WebCore::SourceBufferPrivateAVFObjC::flush): Flush the decompression session, if it exists.
(WebCore::SourceBufferPrivateAVFObjC::enqueueSample): Enqueue to the decompression session, if it exists.
(WebCore::SourceBufferPrivateAVFObjC::isReadyForMoreSamples): As the decompression session, if it exists.
(WebCore::SourceBufferPrivateAVFObjC::didBecomeReadyForMoreSamples): Tell the decompression session to stop requesting data, if it exists.
(WebCore::SourceBufferPrivateAVFObjC::notifyClientWhenReadyForMoreSamples): Request media data from the decompression session, if it exists.
(WebCore::SourceBufferPrivateAVFObjC::setVideoLayer): Added.
(WebCore::SourceBufferPrivateAVFObjC::setDecompressionSession): Added.

platform/graphics/cocoa/WebCoreDecompressionSession.h: Added.

(WebCore::WebCoreDecompressionSession::create):
(WebCore::WebCoreDecompressionSession::isInvalidated):
(WebCore::WebCoreDecompressionSession::createWeakPtr):

platform/graphics/cocoa/WebCoreDecompressionSession.mm: Added.

(WebCore::WebCoreDecompressionSession::WebCoreDecompressionSession): Register for media data requests.
(WebCore::WebCoreDecompressionSession::invalidate): Unregister for same.
(WebCore::WebCoreDecompressionSession::maybeBecomeReadyForMoreMediaDataCallback): Pass to maybeBecomeReadyForMoreMediaData.
(WebCore::WebCoreDecompressionSession::maybeBecomeReadyForMoreMediaData): Check in-flight decodes, and decoded frame counts.
(WebCore::WebCoreDecompressionSession::enqueueSample): Pass the sample to be decoded on a background queue.
(WebCore::WebCoreDecompressionSession::decodeSample): Decode the sample.
(WebCore::WebCoreDecompressionSession::decompressionOutputCallback): Call handleDecompressionOutput.
(WebCore::WebCoreDecompressionSession::handleDecompressionOutput): Pass decoded sample to be enqueued on the main thread.
(WebCore::WebCoreDecompressionSession::getFirstVideoFrame):
(WebCore::WebCoreDecompressionSession::enqueueDecodedSample): Enqueue the frame (if it's a displayed frame).
(WebCore::WebCoreDecompressionSession::isReadyForMoreMediaData): Return whether we've hit our high water sample count.
(WebCore::WebCoreDecompressionSession::requestMediaDataWhenReady):
(WebCore::WebCoreDecompressionSession::stopRequestingMediaData): Unset the same.
(WebCore::WebCoreDecompressionSession::notifyWhenHasAvailableVideoFrame): Set a callback to notify when a decoded frame has been enqueued.
(WebCore::WebCoreDecompressionSession::imageForTime): Successively dequeue images until reaching one at or beyond the requested time.
(WebCore::WebCoreDecompressionSession::flush): Synchronously empty the producer and consumer queues.
(WebCore::WebCoreDecompressionSession::getDecodeTime): Utility method.
(WebCore::WebCoreDecompressionSession::getPresentationTime): Ditto.
(WebCore::WebCoreDecompressionSession::getDuration): Ditto.
(WebCore::WebCoreDecompressionSession::compareBuffers): Ditto.

platform/cocoa/VideoToolboxSoftLink.cpp: Added.
platform/cocoa/VideoToolboxSoftLink.h: Added.

LayoutTests:

media/media-source/content/test-fragmented.mp4: Add a 'edts' atom to move the presentation time for the

first sample to 0:00.

media/media-source/content/test-fragmented-manifest.json:
media/media-source/media-source-paint-to-canvas-expected.txt: Added.
media/media-source/media-source-paint-to-canvas.html: Added.

May 19, 2017:

11:55 PM Changeset in webkit [217184] by commit-queue@webkit.org

2 edits
1 add in trunk/Tools

[Win] error LNK2005: WebCore::JSNode::checkSubClassPatchpoint() already defined in WebKit.lib
https://bugs.webkit.org/show_bug.cgi?id=172267

Patch by Fujii Hironori <Fujii Hironori> on 2017-05-19
Reviewed by Per Arne Vollan.

TestWebCoreLib and TestWebKitLib have linked both WebCore and WebKit.
TestWebCoreLib should link only with WebCore. And, TestWebKitLib
should link only with WebKit.

Unfortunately, there is a layer violation at the moment.
WebCore::Image::loadPlatformResource needs loadResourceIntoBuffer
in WebKit. This change contains a stub of loadResourceIntoBuffer
in TestWebCoreLib for the workaround.

TestWebKitAPI/PlatformWin.cmake: Do not link WebKit to

TestWebCoreLib. Do not link WebCore to TestWebKitLib.

TestWebKitAPI/win/TestWebCoreStubs.cpp: Added.

(loadResourceIntoBuffer): Added a stub.

9:24 PM Changeset in webkit [217183] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

WebAVStreamDataParserListener String leak
https://bugs.webkit.org/show_bug.cgi?id=172395

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2017-05-19
Reviewed by Chris Dumez.

platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm:

(-[WebAVStreamDataParserListener streamDataParser:didProvideMediaData:forTrackID:mediaType:flags:]):
(-[WebAVStreamDataParserListener streamDataParser:didReachEndOfTrackWithTrackID:mediaType:]):
Use an isolated String in a lambda used across threads.

8:31 PM Changeset in webkit [217182] by Yusuke Suzuki

5 edits in trunk/Source/JavaScriptCore

[JSC] Enable testapi on Mac CMake build
https://bugs.webkit.org/show_bug.cgi?id=172354

Reviewed by Alex Christensen.

This patch makes testapi buildable and runnable for Mac CMake port.

API/tests/DateTests.mm:

(+[DateTests JSDateToNSDateTest]):
(+[DateTests roundTripThroughJSDateTest]):
This test only works with the en_US locale.

shell/CMakeLists.txt:
shell/PlatformMac.cmake:

Some of tests rely on ARC. We enable ARC for those files.

shell/PlatformWin.cmake:

Clean up.

7:30 PM Changeset in webkit [217181] by Chris Dumez

4 edits in trunk

Consider not exposing webkitURL in workers
https://bugs.webkit.org/show_bug.cgi?id=172166

Reviewed by Geoffrey Garen.

Source/WebCore:

Drop webkitURL alias for URL in workers, to match other browsers. The risk should
be low given that this only impacts workers, we expose URL to workers and Blink
does not have this alias. We still support the webkitURL alias for URL on Window.

No new tests, rebaselined existing test.

workers/WorkerGlobalScope.idl:

LayoutTests:

Rebaseline existing test to reflect behavior change.

js/dom/global-constructors-attributes-dedicated-worker-expected.txt:

6:59 PM Changeset in webkit [217180] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

Add RTCPeerConnection connection state change logging
https://bugs.webkit.org/show_bug.cgi?id=172314

Patch by Youenn Fablet <youenn@apple.com> on 2017-05-19
Reviewed by Eric Carlson.

No change of behavior.
Adding some release logging of connection state changes.

Modules/mediastream/RTCPeerConnection.cpp:

(WebCore::rtcIceGatheringStateToString):
(WebCore::RTCPeerConnection::updateIceGatheringState):
(WebCore::rtcIceConnectionStateToString):
(WebCore::RTCPeerConnection::updateIceConnectionState):

5:59 PM Changeset in webkit [217179] by mark.lam@apple.com

12 edits
1 add in trunk

[Re-landing] DFG::SpeculativeJIT::pickCanTrample() is wrongly ignoring result registers.
https://bugs.webkit.org/show_bug.cgi?id=172383
<rdar://problem/31418651>

Reviewed by Filip Pizlo.

JSTests:

stress/regress-172383.js: Added.

Source/JavaScriptCore:

pickCanTrample() is wrongly assuming that one of regT0 and regT1 is always
available as a scratch register. This assumption is wrong if this canTrample
register is used for a silentFill() after an operation that returns a result in
regT0 or regT1.

Turns out the only reason we need the canTrample register is for
SetDoubleConstant. We can remove the need for this canTrample register by
introducing a moveDouble() pseudo instruction in the MacroAssembler to do the
job using the scratchRegister() on X86_64 or the dataMemoryTempRegister() on
ARM64. In so doing, we can simplify the silentFill() code and eliminate the bug.

Update for re-landing: Changed ARM64 to use scratchRegister() as well.
scratchRegister() is the proper way to get the underlying dataMemoryTempRegister()
as a scratch register.

assembler/MacroAssembler.h:

(JSC::MacroAssembler::moveDouble):

dfg/DFGArrayifySlowPathGenerator.h:
dfg/DFGCallArrayAllocatorSlowPathGenerator.h:

(JSC::DFG::CallArrayAllocatorWithVariableStructureVariableSizeSlowPathGenerator::CallArrayAllocatorWithVariableStructureVariableSizeSlowPathGenerator):

dfg/DFGCallCreateDirectArgumentsSlowPathGenerator.h:
dfg/DFGSaneStringGetByValSlowPathGenerator.h:
dfg/DFGSlowPathGenerator.h:

(JSC::DFG::CallSlowPathGenerator::tearDown):

dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::silentFill):
(JSC::DFG::SpeculativeJIT::compileToLowerCase):
(JSC::DFG::SpeculativeJIT::compileValueToInt32):
(JSC::DFG::SpeculativeJIT::compileInstanceOfForObject):
(JSC::DFG::SpeculativeJIT::emitUntypedBitOp):
(JSC::DFG::SpeculativeJIT::emitUntypedRightShiftBitOp):
(JSC::DFG::SpeculativeJIT::compileArithDiv):
(JSC::DFG::SpeculativeJIT::compileArraySlice):
(JSC::DFG::SpeculativeJIT::emitSwitchImm):
(JSC::DFG::SpeculativeJIT::emitSwitchStringOnString):
(JSC::DFG::SpeculativeJIT::compileStoreBarrier):

dfg/DFGSpeculativeJIT.h:

(JSC::DFG::SpeculativeJIT::silentFill):
(JSC::DFG::SpeculativeJIT::silentSpillAllRegisters):
(JSC::DFG::SpeculativeJIT::silentFillAllRegisters):
(JSC::DFG::SpeculativeJIT::pickCanTrample): Deleted.

dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::nonSpeculativePeepholeBranch):
(JSC::DFG::SpeculativeJIT::nonSpeculativePeepholeStrictEq):
(JSC::DFG::SpeculativeJIT::nonSpeculativeNonPeepholeStrictEq):
(JSC::DFG::SpeculativeJIT::emitCall):
(JSC::DFG::SpeculativeJIT::compile):

dfg/DFGSpeculativeJIT64.cpp:

5:58 PM Changeset in webkit [217178] by jmarcell@apple.com

28 edits
5 adds in branches/safari-603-branch

Cherry-pick r216541. rdar://problem/31971362

5:43 PM Changeset in webkit [217177] by Ryan Haddad

4 edits in branches/safari-603-branch/LayoutTests

Unreviewed test gardening.

platform/mac-wk1/TestExpectations:
platform/mac-wk1/js/dom/global-constructors-attributes-expected.txt:
platform/mac/TestExpectations:

5:27 PM Changeset in webkit [217176] by commit-queue@webkit.org

6 edits
2 copies in trunk

webkitSupportsFullscreen and webkitSupportsPresentationMode('fullscreen') disagree.
https://bugs.webkit.org/show_bug.cgi?id=172329
rdar://problem/32260891

Patch by Jeremy Jones <jeremyj@apple.com> on 2017-05-19
Reviewed by Darin Adler.

Source/WebCore:

Updated tests:

media/media-fullscreen-inline-expected.txt:
media/media-fullscreen-not-in-document-expected.txt:
media/media-fullscreen.js:

webkitSupportsPresentationMode('fullscreen') should delegate to webkitSupportsFullscreen.
The additional mediaSession().fullscreenPermitted() check causes it to return false when
not handling a user gesture, which isn't helpful to deciding to show a button in controls
or not.

html/HTMLVideoElement.cpp:

(WebCore::HTMLVideoElement::webkitSupportsPresentationMode):

LayoutTests:

media/media-fullscreen-inline-expected.txt:
media/media-fullscreen-not-in-document-expected.txt:
media/media-fullscreen.js:

(canplaythrough):

platform/mac-elcapitan/media/media-fullscreen-inline-expected.txt:
platform/mac-elcapitan/media/media-fullscreen-not-in-document-expected.txt:

5:25 PM Changeset in webkit [217175] by commit-queue@webkit.org

9 edits in trunk/Source/WebCore

Prevent javascript interface from activating picture-in-picture for video elements that are showing capture camera on ios.
https://bugs.webkit.org/show_bug.cgi?id=172328

Patch by Jeremy Jones <jeremyj@apple.com> on 2017-05-19
Reviewed by Eric Carlson.

This change allows MediaPlayers to decide if they support pictureInPicture.
And check this from supportsFullscreen().

In MediaPlayerPrivateMediaStreamAVFObjC disable pip if there is a capture video track.
Elsewhere, leave it enabled.

html/HTMLVideoElement.cpp:

(WebCore::HTMLVideoElement::supportsFullscreen): Added Check.

platform/graphics/MediaPlayer.cpp:

(WebCore::MediaPlayer::supportsPictureInPicture): Added.

platform/graphics/MediaPlayer.h:
platform/graphics/MediaPlayerPrivate.h:

(WebCore::MediaPlayerPrivateInterface::supportsPictureInPicture): Added.

platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h:
platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.h:
platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.h:
platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.mm:

(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::supportsPictureInPicture): Added

platform/graphics/mac/MediaPlayerPrivateQTKit.h:
platform/graphics/mac/MediaPlayerPrivateQTKit.mm:

(WebCore::MediaPlayerPrivateQTKit::supportsFullscreen): Deleted. Moved inline.

5:18 PM Changeset in webkit [217174] by Matt Lewis

4 edits in trunk/LayoutTests

Marked webrtc/datachannel/filter-ice-candidate.html as flaky.
https://bugs.webkit.org/show_bug.cgi?id=171061

Unreviewed test gardening.

platform/ios-wk2/TestExpectations:
platform/mac-wk1/TestExpectations:
platform/mac-wk2/TestExpectations:

5:03 PM Changeset in webkit [217173] by rniwa@webkit.org

6 edits in trunk/Websites/perf.webkit.org

Add a commit log viewer next to the analysis results viewer
https://bugs.webkit.org/show_bug.cgi?id=172399

Reviewed by Chris Dumez.

Add a commit log viewer next to the analysis results viewer, which visualizes the A/B testing results.

Also linkify the revisions in the table that shows the status of each A/B testing job,
and allow the prefix of "r" when associating a Subversion revision.

Finally, Fixed a bug that the list of commits associated with the analysis task were not re-rendered
when the list was updated by the user.

public/v3/components/analysis-results-viewer.js:

(AnalysisResultsViewer): Added _selectorRadioButtonList as an instance variable. It's a list of radio
buttons to select a configuration (A/B) with a commit set. It's added to update the checked status of
radio buttons upon changing the currently selected test group.
(AnalysisResultsViewer.prototype.setTestGroups): Update the selected range to that of the currently
selected group.
(AnalysisResultsViewer.prototype.render): Fill _selectorRadioButtonList with radio buttons.

public/v3/components/commit-log-viewer.js:

(CommitLogViewer): Added _showRepositoryName as an instance variable.
(CommitLogViewer.prototype.setShowRepositoryName): Added.
(CommitLogViewer.prototype.render): Hide the repository name when _showRepositoryName is false. This
is used in the newly added commit log viewer for the analysis results since we're showing a select
element with all the names of repositories above this component.

public/v3/components/test-group-revision-table.js:

(TestGroupRevisionTable.prototype._buildCommitCell): Linkify the revisions if possible.

public/v3/models/analysis-task.js:

(AnalysisTask.prototype.associateCommit): Strip "r" at the beginning for a Subversion like r12345
since that's the format we use to show to the user. This makes copy & paste easier.

public/v3/pages/analysis-task-page.js:

(AnalysisTaskResultsPane): Added a bunch of new instance variables to show and update the commit log
viewer next to the analysis results viewer.
(AnalysisTaskResultsPane.prototype.setPoints): Create the list of repositories to show details.
(AnalysisTaskResultsPane.prototype.didConstructShadowTree): Re-render when the current selected test
group changes since that may have updated the selected range for A/B testing. Also re-render when
a new repository is selected to show details.
(AnalysisTaskResultsPane.prototype.render): Update the list of repositories and the commit log viewer.
(AnalysisTaskResultsPane.prototype._renderRepositoryList): Renders the list of repositories.
(AnalysisTaskResultsPane.prototype._updateCommitViewer): Updates the commit log viewer given the range
selected in the analysis results viewer.
(AnalysisTaskResultsPane.htmlTemplate): Updated the template.
(AnalysisTaskResultsPane.cssTemplate): Ditto.
(AnalysisTaskTestGroupPane.cssTemplate): Add a little space between the list of results and the table
of A/B testing jobs with revisions.
(AnalysisTaskPage.prototype.render): Fixed the bug that the list of commits associated with the task
is not updated when the list changes the task or the start point never changed when the list of commits
associated with the task changed. Make the lazily evaluated function compare the actual list of commits
so that it will invoke _renderCauseAndFixes when the list changes.
(AnalysisTaskPage.prototype._renderCauseAndFixes): Now renders a specific list.

5:00 PM Changeset in webkit [217172] by Chris Dumez

3 edits
2 adds in trunk

Do not fire load event for SVGElements that are detached or in frameless documents
https://bugs.webkit.org/show_bug.cgi?id=172289
<rdar://problem/32275689>

Reviewed by Ryosuke Niwa.

Source/WebCore:

We should not fire load event for SVGElements that are detached or in frameless
documents.

Test: svg/load-event-detached.html

svg/SVGElement.cpp:

(WebCore::SVGElement::sendSVGLoadEventIfPossible):

LayoutTests:

Add layout test coverage.

svg/load-event-detached-expected.txt: Added.
svg/load-event-detached.html: Added.

4:37 PM Changeset in webkit [217171] by ap@apple.com

91 edits in trunk/LayoutTests

Many accessibility js-tests use waitUntilDone
https://bugs.webkit.org/show_bug.cgi?id=172372

Reviewed by Tim Horton.

Corrected the use of js-test harness, updated the tests to use js-test.js instead
of js-test-pre.js where possible.

accessibility/anonymous-render-block-in-continuation-causes-crash-expected.txt:
accessibility/anonymous-render-block-in-continuation-causes-crash.html:
accessibility/aria-checkbox-sends-notification.html:
accessibility/aria-invalid.html:
accessibility/aria-switch-sends-notification.html:
accessibility/deleting-iframe-destroys-axcache.html:
accessibility/file-upload-button-with-axpress.html:
accessibility/frame-disconnect-textmarker-cache-crash-expected.txt:
accessibility/frame-disconnect-textmarker-cache-crash.html:
accessibility/gtk/aria-listbox-crash.html:
accessibility/heading-title-includes-links-expected.txt:
accessibility/heading-title-includes-links.html:
accessibility/image-map-update-parent-crash-expected.txt:
accessibility/image-map-update-parent-crash.html:
accessibility/insert-children-assert-expected.txt:
accessibility/insert-children-assert.html:
accessibility/ios-simulator/focus-change-notifications.html:
accessibility/label-element-press.html:
accessibility/loading-iframe-updates-axtree.html:
accessibility/mac/aria-expanded-notifications.html:
accessibility/mac/aria-listbox-selectedchildren-change.html:
accessibility/mac/aria-liveregion-on-image.html:
accessibility/mac/aria-liveregions-addedelement.html:
accessibility/mac/aria-liveregions-changedalt.html:
accessibility/mac/aria-liveregions-changedtext.html:
accessibility/mac/aria-liveregions-removedelement.html:
accessibility/mac/combobox-activedescendant-notifications-expected.txt:
accessibility/mac/combobox-activedescendant-notifications.html:
accessibility/mac/focus-setting-selection-syncronizing-not-clearing-expected.txt:
accessibility/mac/focus-setting-selection-syncronizing-not-clearing.html:
accessibility/mac/html-slider-indicator.html:
accessibility/mac/input-replacevalue-userinfo-expected.txt:
accessibility/mac/input-replacevalue-userinfo.html:
accessibility/mac/ordered-textmarker-crash-expected.txt:
accessibility/mac/ordered-textmarker-crash.html:
accessibility/mac/search-with-frames-expected.txt:
accessibility/mac/search-with-frames.html:
accessibility/mac/selection-boundary-userinfo.html:
accessibility/mac/selection-change-userinfo.html:
accessibility/mac/selection-element-tabbing-to-link.html:
accessibility/mac/selection-value-changes-for-aria-textbox.html:
accessibility/mac/stale-textmarker-crash-expected.txt:
accessibility/mac/stale-textmarker-crash.html:
accessibility/mac/textbox-role-reports-notifications-expected.txt:
accessibility/mac/textbox-role-reports-notifications.html:
accessibility/mac/value-change/value-change-user-info-contenteditable.html:
accessibility/mac/value-change/value-change-user-info-textarea.html:
accessibility/mac/value-change/value-change-user-info-textfield.html:
accessibility/media-element.html:
accessibility/menu-list-sends-change-notification.html:
accessibility/multiselect-list-reports-active-option.html:
accessibility/paragraph-with-linebreaks.html:
accessibility/platform-name.html:
accessibility/radio-button-group-members.html:
accessibility/radio-button-title-label.html:
accessibility/selection-states-expected.txt:
accessibility/selection-states.html:
accessibility/spinbutton-value.html:
accessibility/svg-bounds.html:
accessibility/table-cell-for-column-and-row-crash.html:
accessibility/table-cells-roles.html:
accessibility/table-roles-hierarchy.html:
accessibility/table-with-aria-role.html:
accessibility/textarea-insertion-point-line-number.html:
accessibility/textbox-role-reports-selection.html:
accessibility/title-ui-element-correctness.html:
accessibility/unknown-roles-not-exposed-expected.txt:
accessibility/unknown-roles-not-exposed.html:
accessibility/win/bstr-elements-role.html:
accessibility/win/detached-object-notification-crash.html:
accessibility/win/heading-elements.html:
accessibility/win/img-alt-attribute.html:
accessibility/win/linked-elements.html:
accessibility/win/list-item-role.html:
accessibility/win/list-marker-role.html:
accessibility/win/list-role.html:
accessibility/win/multiple-select-element-role.html:
accessibility/win/option-element-position-and-size.html:
accessibility/win/parent-element.html:
accessibility/win/select-element-role.html:
accessibility/win/selection-and-focus.html:
accessibility/win/single-select-children-changed.html:
accessibility/win/single-select-children.html:
accessibility/win/text-role.html:
platform/mac-wk1/accessibility/loading-iframe-updates-axtree-expected.txt:
platform/mac-wk2/accessibility/deleting-iframe-destroys-axcache-expected.txt:
platform/mac/accessibility/deleting-iframe-destroys-axcache-expected.txt:
platform/mac/accessibility/media-element-expected.txt:
platform/mac/accessibility/table-cells-roles-expected.txt:
platform/mac/accessibility/table-roles-hierarchy-expected.txt:

4:30 PM Changeset in webkit [217170] by Matt Lewis

2 edits in trunk/LayoutTests

Rebaselined js/dom/global-constructors-attributes.html after revision 217129

Unreviewed test gardening.

platform/mac/js/dom/global-constructors-attributes-expected.txt:

4:25 PM Changeset in webkit [217169] by Ryan Haddad

12 edits
1 delete in trunk

Unreviewed, rolling out r217156.

This change broke the iOS build.

Reverted changeset:

"DFG::SpeculativeJIT::pickCanTrample() is wrongly ignoring
result registers."
https://bugs.webkit.org/show_bug.cgi?id=172383
http://trac.webkit.org/changeset/217156

4:20 PM Changeset in webkit [217168] by Chris Dumez

6 edits
4 adds in trunk

Option() named constructor is not per spec
https://bugs.webkit.org/show_bug.cgi?id=172185

Reviewed by Sam Weinig.

LayoutTests/imported/w3c:

Import test coverage from upstream web-platform-tests at 8b69df3a68.

web-platform-tests/html/semantics/forms/the-option-element/option-element-constructor-expected.txt: Added.
web-platform-tests/html/semantics/forms/the-option-element/option-element-constructor.html: Added.
web-platform-tests/html/semantics/forms/the-option-element/option-index-expected.txt: Added.
web-platform-tests/html/semantics/forms/the-option-element/option-index.html: Added.
web-platform-tests/html/semantics/forms/the-option-element/w3c-import.log:

Source/WebCore:

Align the behavior of the Option() named constructor with the HTML specification:

https://html.spec.whatwg.org/#dom-option

In particular, we no longer create an empty Text child node if the input text is the empty string.
This also aligns our behavior with Firefox.

Test: imported/w3c/web-platform-tests/html/semantics/forms/the-option-element/option-element-constructor.html

html/HTMLOptionElement.cpp:

(WebCore::HTMLOptionElement::createForJSConstructor):

html/HTMLOptionElement.h:
html/HTMLOptionElement.idl:

4:14 PM Changeset in webkit [217167] by Simon Fraser

2 edits in trunk/Tools

Fix dump-class-layout to handle different file architectures
https://bugs.webkit.org/show_bug.cgi?id=172392

Reviewed by Zalan Bujtas.

Instead of using lldb.LLDB_ARCH_DEFAULT by default, run 'file' on the binary
and use the first architecture reported. Also add a "--architecture" argument
to allow the user to specify an architecture.

Scripts/dump-class-layout:

(import_lldb):
(verify_type_recursive):
(get_first_file_architecture):
(dump_class):
(main):
(find_build_directory): Deleted.

4:07 PM Changeset in webkit [217166] by Chris Dumez

13 edits in trunk

URLSearchParams / Headers objects @@iterator is not as per Web IDL spec
https://bugs.webkit.org/show_bug.cgi?id=172218

Reviewed by Youenn Fablet.

LayoutTests/imported/w3c:

Rebaseline web-platform-tests that are now passing.

web-platform-tests/fetch/api/headers/headers-idl-expected.txt:
web-platform-tests/url/interfaces.any-expected.txt:
web-platform-tests/url/interfaces.any.worker-expected.txt:

Source/WebCore:

Both URLSearchParams and Headers interfaces are iterable as per their
respective specification, and they both have a pair iterator:

As per the WebIDL specification for 'entries'[1], "If the interface has a pair
iterator, then the Function object is the value of the @@iterator property",
the value of @@iterator being defined at [2]. In WebKit, we were using
different values/functions for 'entries' and @@iterator, although those
functions were doing the same thing (and the right thing).

Also, as per [2], the name of the @@iterator function should be "entries",
which I also implemented in this patch. Previously, we were using
"[Symbol.Iterator]" as function name.

[1] https://heycam.github.io/webidl/#es-iterable-entries
[2] https://heycam.github.io/webidl/#es-iterator

No new tests, rebaselined existing tests.

bindings/scripts/CodeGeneratorJS.pm:

(GenerateImplementation):
(GenerateImplementationIterableFunctions):

bindings/scripts/test/JS/JSMapLike.cpp:
bindings/scripts/test/JS/JSReadOnlyMapLike.cpp:
bindings/scripts/test/JS/JSTestIterable.cpp:

(WebCore::JSTestIterablePrototype::finishCreation):
(WebCore::jsTestIterablePrototypeFunctionEntriesCaller):

bindings/scripts/test/JS/JSTestNode.cpp:

(WebCore::JSTestNodePrototype::finishCreation):
(WebCore::jsTestNodePrototypeFunctionEntriesCaller):

LayoutTests:

fast/text/font-face-set-javascript-expected.txt:
fast/text/font-face-set-javascript.html:

Fix FontFaceSet test which wrong expected FontFaceSet's entries() to return
a pair iterator. It does not make sense to return a pair iterator here given
that this is not a key-value structure. FontFaceSet should not even have an
entries() method but this is an artifact of us using iterable<FontFace> instead of
setlike<FontFace> until we support setlike<> (Bug 159140).

4:02 PM Changeset in webkit [217165] by Jonathan Bedard

2 edits in trunk/Tools

Unreviewed infrastructure fix.

Scripts/webkitpy/port/ios_simulator.py:

(IOSSimulatorPort._create_devices): Ignore failure to open Simulator.app.

3:54 PM Changeset in webkit [217164] by Alan Bujtas

6 edits
2 adds in trunk

Redundant ellipsis box triggers ASSERT_WITH_SECURITY_IMPLICATION in InlineBox::parent().
https://bugs.webkit.org/show_bug.cgi?id=172309
<rdar://problem/32262357>

Reviewed by Simon Fraser.

Source/WebCore:

This patch stops the redundant ellipsis box trigger ASSERT_WITH_SECURITY_IMPLICATION.

In RootInlineBox::placeEllipsis we construct an ellipsis box and append it to a static HashMap which
keeps track of the ellipsis boxes on each line. However when the line already has an ellipsis, we
re-use the existing one and this newly constructed (but redundant) box gets destroyed as we return from this function.
In InlineBox's d'tor, we let the parent know that now it has a dangling child and we assert on it
later, while accessing the children list. However this redundant ellipsis box was never added to the line,
so the assertion hits incorrectly.

Test: fast/inline/redundant-ellipsis-triggers-assert-incorrectly.html

rendering/EllipsisBox.cpp:

(WebCore::EllipsisBox::EllipsisBox):

rendering/InlineBox.cpp: This needs 32bits padding.

(WebCore::InlineBox::invalidateParentChildList):

rendering/InlineBox.h:
rendering/RootInlineBox.cpp:

(WebCore::RootInlineBox::placeEllipsis):

LayoutTests:

fast/inline/redundant-ellipsis-triggers-assert-incorrectly-expected.txt: Added.
fast/inline/redundant-ellipsis-triggers-assert-incorrectly.html: Added.

3:51 PM Changeset in webkit [217163] by jmarcell@apple.com

2 edits in branches/safari-603-branch/Source/WebCore

Cherry-pick r215091. rdar://problem/32279160

3:51 PM Changeset in webkit [217162] by jmarcell@apple.com

3 edits in branches/safari-603-branch/Source/WebCore

Build Fix: Disabling WritableStream and ReadableByteStream.
<rdar://problem/32057089> Grizzly: Outdated WritableStream API shipped in Safari 10.1

Patch by Youenn Fablet <youenn@apple.com> on 2017-05-19

Modules/streams/ReadableStream.js:

(initializeReadableStream): Throwing in case the source type is bytes.

Modules/streams/WritableStream.idl: Making it dependent on writable stream API flag.

3:42 PM Changeset in webkit [217161] by rniwa@webkit.org

4 edits in trunk

REGRESSION(r217118): Speedometer 2.0: Flight.js test is broken
https://bugs.webkit.org/show_bug.cgi?id=172394

Reviewed by Chris Dumez.

PerformanceTests:

Fixed the bug that we were never clearing window.checkLoadedTimeoutId.

Speedometer/resources/todomvc/dependency-examples/flight/flight/node_modules/requirejs/require.js:

(newContext.checkLoaded):

Websites/browserbench.org:

Merge the fix.

Speedometer2.0/resources/todomvc/dependency-examples/flight/flight/node_modules/requirejs/require.js:

(newContext.checkLoaded):

3:38 PM Changeset in webkit [217160] by jmarcell@apple.com

7 edits in branches/safari-604.1.21-branch/Source

Versioning.

3:36 PM Changeset in webkit [217159] by jmarcell@apple.com

1 copy in tags/Safari-604.1.21.7

Tag Safari-604.1.21.7.

3:31 PM Changeset in webkit [217158] by wilander@apple.com

2 edits in trunk/Source/WebKit2

Resource Load Statistics: Use WebProcessPool::allProcessPools() when sending message to network process about partitioning
https://bugs.webkit.org/show_bug.cgi?id=172370
<rdar://problem/32288012>

Reviewed by Alex Christensen.

The existing test case
http/tests/loading/resourceLoadStatistics/partitioned-cookies-with-and-without-user-interaction.html
is currently failing and should start passing again with this patch.

UIProcess/WebsiteData/WebsiteDataStore.cpp:

(WebKit::WebsiteDataStore::shouldPartitionCookiesForTopPrivatelyOwnedDomains):

3:28 PM Changeset in webkit [217157] by mark.lam@apple.com

3 edits
1 add in trunk

Add missing exception check.
https://bugs.webkit.org/show_bug.cgi?id=172346
<rdar://problem/32289640>

Reviewed by Geoffrey Garen.

JSTests:

stress/regress-172346.js: Added.

Source/JavaScriptCore:

runtime/JSObject.cpp:

(JSC::JSObject::hasInstance):

3:25 PM Changeset in webkit [217156] by mark.lam@apple.com

12 edits
1 add in trunk

DFG::SpeculativeJIT::pickCanTrample() is wrongly ignoring result registers.
https://bugs.webkit.org/show_bug.cgi?id=172383
<rdar://problem/31418651>

Reviewed by Filip Pizlo.

JSTests:

stress/regress-172383.js: Added.

Source/JavaScriptCore:

assembler/MacroAssembler.h:

(JSC::MacroAssembler::moveDouble):

dfg/DFGArrayifySlowPathGenerator.h:
dfg/DFGCallArrayAllocatorSlowPathGenerator.h:

(JSC::DFG::CallArrayAllocatorWithVariableStructureVariableSizeSlowPathGenerator::CallArrayAllocatorWithVariableStructureVariableSizeSlowPathGenerator):

dfg/DFGCallCreateDirectArgumentsSlowPathGenerator.h:
dfg/DFGSaneStringGetByValSlowPathGenerator.h:
dfg/DFGSlowPathGenerator.h:

(JSC::DFG::CallSlowPathGenerator::tearDown):

dfg/DFGSpeculativeJIT.cpp:

dfg/DFGSpeculativeJIT.h:

(JSC::DFG::SpeculativeJIT::silentFill):
(JSC::DFG::SpeculativeJIT::silentSpillAllRegisters):
(JSC::DFG::SpeculativeJIT::silentFillAllRegisters):
(JSC::DFG::SpeculativeJIT::pickCanTrample): Deleted.

dfg/DFGSpeculativeJIT32_64.cpp:

dfg/DFGSpeculativeJIT64.cpp:

3:24 PM Changeset in webkit [217155] by Ryan Haddad

2 edits in trunk/LayoutTests

LayoutTest js/Promise-types.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=171739

Unreviewed follow-up fix for JSC tests.

js/script-tests/Promise-types.js:

3:17 PM Changeset in webkit [217154] by rniwa@webkit.org

8 edits in trunk/Websites/browserbench.org

Merge Speedometer 2.0 fixes up to r217121 to browserbench.org
https://bugs.webkit.org/show_bug.cgi?id=172389

Rubber-stamped by Chris Dumez.

Merged the various fixes for Speedometer 2.0 starting from r217107 through r217121.

Speedometer2.0/InteractiveRunner.html:
Speedometer2.0/resources/benchmark-runner.js:
Speedometer2.0/resources/tests.js:
Speedometer2.0/resources/todomvc/dependency-examples/flight/flight/app/js/main.js:
Speedometer2.0/resources/todomvc/dependency-examples/flight/flight/node_modules/requirejs/require.js:
Speedometer2.0/resources/todomvc/functional-prog-examples/elm/dist/elm.js:
Speedometer2.0/resources/todomvc/vanilla-examples/vanillajs/js/store.js:

3:11 PM Changeset in webkit [217153] by Chris Dumez

16 edits in trunk/Source/WebKit2

[WK2] Notify client when a process exceeds background CPU limit while in the foreground
https://bugs.webkit.org/show_bug.cgi?id=172246
<rdar://problem/32235411>

Reviewed by Geoffrey Garen.

When there is a background CPU limit set by the client, we now monitor the CPU
usages of all WebContent processes, not just the non-visible ones. This way, we
are now able to notify the client a process has exceeded the background CPU
limit while in the foreground, via the UIClient's didExceedBackgroundResourceLimitWhileInForeground
function, passing kWKResourceLimitCPU.

Shared/WebPageCreationParameters.cpp:

(WebKit::WebPageCreationParameters::encode):
(WebKit::WebPageCreationParameters::decode):

Shared/WebPageCreationParameters.h:
UIProcess/API/APIPageConfiguration.cpp:

(API::PageConfiguration::copy):

UIProcess/API/APIPageConfiguration.h:

(API::PageConfiguration::cpuLimit):
(API::PageConfiguration::setCPULimit):

UIProcess/API/C/WKPageConfigurationRef.cpp:

(WKPageConfigurationSetBackgroundCPULimit):

UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::updateThrottleState):
(WebKit::WebPageProxy::creationParameters):
(WebKit::WebPageProxy::didExceedInactiveMemoryLimitWhileActive):
(WebKit::WebPageProxy::didExceedBackgroundCPULimitWhileInForeground):

UIProcess/WebPageProxy.h:
UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::didExceedCPULimit):

UIProcess/WebProcessProxy.h:
UIProcess/WebProcessProxy.messages.in:
WebProcess/WebPage/WebPage.cpp:

(WebKit::m_cpuLimit):

WebProcess/WebPage/WebPage.h:

(WebKit::WebPage::cpuLimit):

WebProcess/WebProcess.cpp:

(WebKit::WebProcess::createWebPage):
(WebKit::WebProcess::removeWebPage):
(WebKit::WebProcess::updateCPULimit):
(WebKit::WebProcess::updateCPUMonitorState):
(WebKit::WebProcess::pageActivityStateDidChange):

WebProcess/WebProcess.h:
WebProcess/cocoa/WebProcessCocoa.mm:

(WebKit::WebProcess::updateCPULimit):
(WebKit::WebProcess::updateCPUMonitorState):

2:56 PM Changeset in webkit [217152] by mrajca@apple.com

4 edits
1 add in trunk

Inherit media user gestures from the top document when autoplay quirks are allowed.
https://bugs.webkit.org/show_bug.cgi?id=172375

Reviewed by Eric Carlson.

Added API test.

dom/Document.cpp:

(WebCore::Document::processingUserGestureForMedia):

2:41 PM Changeset in webkit [217151] by commit-queue@webkit.org

10 edits in trunk

Align MockRealtimeMediaSourceCenter with RealtimeMediaSourceCenter
https://bugs.webkit.org/show_bug.cgi?id=172324

Patch by Youenn Fablet <youenn@apple.com> on 2017-05-19
Reviewed by Eric Carlson.

Source/WebCore:

No change of behavior.
Remove most of MockRealtimeMediaSourceCenter implementation.
Next step should be to remove it entirely and use the factory setters instead.

platform/mediastream/RealtimeMediaSourceCenter.cpp:

(WebCore::RealtimeMediaSourceCenter::RealtimeMediaSourceCenter):
(WebCore::RealtimeMediaSourceCenter::createMediaStream):
(WebCore::RealtimeMediaSourceCenter::getMediaStreamDevices):
(WebCore::RealtimeMediaSourceCenter::setDeviceEnabled):

platform/mediastream/RealtimeMediaSourceCenter.h:

(WebCore::RealtimeMediaSourceCenter::supportedConstraints):

platform/mediastream/mac/RealtimeMediaSourceCenterMac.cpp:

(WebCore::RealtimeMediaSourceCenterMac::RealtimeMediaSourceCenterMac):

platform/mediastream/mac/RealtimeMediaSourceCenterMac.h:
platform/mock/MockRealtimeMediaSourceCenter.cpp:

(WebCore::MockRealtimeMediaSourceCenter::MockCaptureDeviceManager::captureDevices):

platform/mock/MockRealtimeMediaSourceCenter.h:

LayoutTests:

fast/mediastream/mock-media-source-webaudio.html:

2:19 PM Changeset in webkit [217150] by ap@apple.com

42 edits in trunk/LayoutTests

Many CSS js-tests use waitUntilDone
https://bugs.webkit.org/show_bug.cgi?id=172379

Reviewed by Tim Horton.

Corrected the use of js-test harness, updated the tests to use js-test.js instead
of js-test-pre.js where possible.

css3/filters/should-not-have-compositing-layer-expected.txt:
css3/filters/should-not-have-compositing-layer.html:
css3/scroll-snap/nested-elements-expected.txt:
css3/scroll-snap/nested-elements.html:
css3/scroll-snap/scroll-snap-2d-change-axis-type-expected.txt:
css3/scroll-snap/scroll-snap-2d-change-axis-type.html:
css3/scroll-snap/scroll-snap-2d-offsets-computed-independently-expected.txt:
css3/scroll-snap/scroll-snap-2d-offsets-computed-independently.html:
css3/scroll-snap/scroll-snap-elements-container-larger-than-children-expected.txt:
css3/scroll-snap/scroll-snap-elements-container-larger-than-children.html:
css3/scroll-snap/scroll-snap-mismatch-expected.txt:
css3/scroll-snap/scroll-snap-mismatch.html:
css3/scroll-snap/scroll-snap-offsets-expected.txt:
css3/scroll-snap/scroll-snap-offsets.html:
css3/scroll-snap/scroll-snap-positions-expected.txt:
css3/scroll-snap/scroll-snap-positions-mainframe-expected.txt:
css3/scroll-snap/scroll-snap-positions-mainframe.html:
css3/scroll-snap/scroll-snap-positions-overflow-resize-expected.txt:
css3/scroll-snap/scroll-snap-positions-overflow-resize.html:
css3/scroll-snap/scroll-snap-positions.html:
css3/scroll-snap/scroll-snap-style-changed-align-expected.txt:
css3/scroll-snap/scroll-snap-style-changed-align.html:
css3/touch-action/touch-action-manipulation-fast-clicks.html:
fast/css/counters/2displays-expected.txt:
fast/css/counters/2displays.html:
fast/css/counters/after-continuation-expected.txt:
fast/css/counters/after-continuation.html:
fast/css/counters/counter-increment-inherit-expected.txt:
fast/css/counters/counter-increment-inherit.htm:
fast/css/counters/counter-increment-tests-expected.txt:
fast/css/counters/counter-increment-tests.htm:
fast/css/device-aspect-ratio.html:
fast/css/hover-display-block-inline-expected.txt:
fast/css/hover-display-block-inline.html:
fast/css/hover-display-block-none-expected.txt:
fast/css/hover-display-block-none.html:
fast/css/image-resolution/image-resolution.html:
fast/css/max-device-aspect-ratio.html:
fast/css/min-device-aspect-ratio.html:
fast/css/pseudo-target-indirect-sibling-001.html:
fast/css/pseudo-target-indirect-sibling-002.html:

2:08 PM Changeset in webkit [217149] by fpizlo@apple.com

2 edits in trunk/Source/JavaScriptCore

Deduplicate some code in arrayProtoPrivateFuncConcatMemcpy
https://bugs.webkit.org/show_bug.cgi?id=172382

Reviewed by Saam Barati.

This is just a small clean-up - my last patch here created some unnecessary code duplication.

runtime/ArrayPrototype.cpp:

(JSC::arrayProtoPrivateFuncConcatMemcpy):

1:47 PM Changeset in webkit [217148] by Alan Bujtas

2 edits in trunk/Source/WebCore

Update SameSizeAsInlineBox with the correct InlineBoxBitfields bits.
https://bugs.webkit.org/show_bug.cgi?id=172377

Reviewed by Tim Horton.

rendering/InlineBox.cpp:

1:47 PM Changeset in webkit [217147] by Jonathan Bedard

4 edits in trunk/Tools

webkitpy: Use simctl boot to run multiple simulators at once
https://bugs.webkit.org/show_bug.cgi?id=172374

Reviewed by Alexey Proskuryakov.

Scripts/webkitpy/common/system/platforminfo.py:

(PlatformInfo.xcode_version): Return the current version of Xcode.

Scripts/webkitpy/common/system/platforminfo_mock.py:

(MockPlatformInfo.xcode_version): Return version 8.0 for testing.

Scripts/webkitpy/port/ios_simulator.py:

(IOSSimulatorPort.use_multiple_simulator_apps): Return true if we need to
run multiple Simulator.app instances.
(IOSSimulatorPort._create_simulators): Only copy the simulator app for older
versions of Xcode.
(IOSSimulatorPort._create_devices): Use 'simctl boot' directly unless using
an older version of Xcode.

1:13 PM Changeset in webkit [217146] by dbates@webkit.org

6 edits in trunk/Source/WebCore

Bindings: Support runtime-enabled features in specific worlds
https://bugs.webkit.org/show_bug.cgi?id=172235

Reviewed by Chris Dumez.

Currently a function, attribute, or interface can be annotated with either EnabledAtRuntime
or EnabledForWorld (not both) to expose/conceal it depending on the state of a runtime
feature flag or the DOM world associated with the running JavaScript code, respectively.
Even though we do not have any functions, attributes, or interfaces that are annotated
with both EnabledAtRuntime and EnabledForWorld at the time of writing, it seems reasonable
to support such a combination of annotations. This also has the benefit of making it
straightforward to support the extended attribute SecureContext by generalizing the logic
that generates the code to expose/conceal a function, attribute, or interface.

bindings/scripts/CodeGeneratorJS.pm:

(GenerateRuntimeEnableConditionalString): Use an array to build up all the conjuncts in
the conditional expression.
(GenerateImplementation): Substitute GenerateRuntimeEnableConditionalString() and $runtimeEnableConditionalString
for GetRuntimeEnableFunctionName() and $enable_function_result, respectively.
(GetRuntimeEnableFunctionName): Deleted.

bindings/scripts/test/JS/JSTestGlobalObject.cpp: (WebCore::JSTestGlobalObject::finishCreation): (WebCore::jsTestGlobalObjectInstanceFunctionEnabledInSpecificWorldWhenRuntimeFeatureEnabled): (WebCore::jsTestGlobalObjectInstanceFunctionEnabledInSpecificWorldWhenRuntimeFeatureEnabledCaller): (WebCore::jsTestGlobalObjectInstanceFunctionEnabledInSpecificWorldWhenRuntimeFeaturesEnabled): (WebCore::jsTestGlobalObjectInstanceFunctionEnabledInSpecificWorldWhenRuntimeFeaturesEnabledCaller): Update expected results.

bindings/scripts/test/JS/JSTestObj.cpp: (WebCore::JSTestObjPrototype::finishCreation): (WebCore::jsTestObjPrototypeFunctionEnabledInSpecificWorldWhenRuntimeFeatureEnabled): (WebCore::jsTestObjPrototypeFunctionEnabledInSpecificWorldWhenRuntimeFeatureEnabledCaller): Ditto.

bindings/scripts/test/TestGlobalObject.idl: Added test cases.
bindings/scripts/test/TestObj.idl: Added test case.

1:12 PM Changeset in webkit [217145] by jer.noble@apple.com

3 edits in trunk/Source/WebCore

Fix macos build after r217143
https://bugs.webkit.org/show_bug.cgi?id=172380

unreviewed.

Remove reference to WebVideoFullscreenInterface for mac build.

Patch by Jeremy Jones <jeremyj@apple.com> on 2017-05-19

html/HTMLMediaElement.cpp:
platform/mac/WebVideoFullscreenInterfaceMac.h:

1:12 PM Changeset in webkit [217144] by Ryan Haddad

5 edits in trunk/LayoutTests

Skip tests that are reporting FailureNotTested.
https://bugs.webkit.org/show_bug.cgi?id=172378

Unreviewed test gardening.

TestExpectations:
platform/ios-wk2/TestExpectations:
platform/ios/TestExpectations:
platform/mac/TestExpectations:

12:39 PM Changeset in webkit [217143] by commit-queue@webkit.org

12 edits
1 delete in trunk/Source

Remove defunct WebVideoFullscreenInterface
https://bugs.webkit.org/show_bug.cgi?id=172254

Patch by Jeremy Jones <jeremyj@apple.com> on 2017-05-19
Reviewed by Jon Lee.

Source/WebCore:

No new tests because no behavior change.

WebVideoFullscreenInterface has long since been replaced by WebVideoFullscreenModelClient.

WebCore.xcodeproj/project.pbxproj:
html/HTMLMediaElement.cpp:
html/HTMLVideoElement.cpp:
platform/cocoa/WebPlaybackSessionModelMediaElement.mm:
platform/cocoa/WebVideoFullscreenInterface.h: Removed.
platform/cocoa/WebVideoFullscreenModel.h:
platform/cocoa/WebVideoFullscreenModelVideoElement.mm:
platform/ios/WebVideoFullscreenControllerAVKit.mm:
platform/ios/WebVideoFullscreenInterfaceAVKit.h:
platform/mac/WebVideoFullscreenInterfaceMac.h:

Source/WebKit2:

Remove reference to WebVideoFullscreenInterface. It has long since been replaced by
WebVideoFullscreenModelClient.

WebProcess/cocoa/WebVideoFullscreenManager.h:

12:31 PM Changeset in webkit [217142] by Ryan Haddad

2 edits in branches/safari-603-branch/LayoutTests

Merge r217138. rdar://problem/32182167

12:25 PM Changeset in webkit [217141] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

HTMLVideoElement::webkitSupportsPresentationMode allowsPictureInPicture() check is redundant.
https://bugs.webkit.org/show_bug.cgi?id=172330
rdar://problem/32285443

Patch by Jeremy Jones <jeremyj@apple.com> on 2017-05-19
Reviewed by Eric Carlson.

No new tests because no behavior change.

This removes a redundant call to allowsPictureInPicture() to make it
more clear that webkitSupportsPresentationMode gives the same result as
webkitSupportsFullscreen(pipMode)

html/HTMLVideoElement.cpp:

(WebCore::HTMLVideoElement::webkitSupportsPresentationMode):

12:09 PM Changeset in webkit [217140] by Ryan Haddad

2 edits in trunk/LayoutTests

LayoutTest js/Promise-types.html is a flaky failure (Unhandled Promise Rejection messages)
https://bugs.webkit.org/show_bug.cgi?id=171739

Reviewed by Joseph Pecoraro.

Silence the console messages for unhandled rejections in this LayoutTest.

js/script-tests/Promise-types.js:

12:06 PM Changeset in webkit [217139] by commit-queue@webkit.org

5 edits in trunk/Source

[WebRTC] Remove PiP support for video elements that are showing camera capture
https://bugs.webkit.org/show_bug.cgi?id=172336

Patch by Jeremy Jones <jeremyj@apple.com> on 2017-05-19
Reviewed by Eric Carlson.

Source/WebCore:

No new tests because no effect on the DOM. This just changes a value sent to the platform interface layer.

Ask video element if it supports picture-in-picture instead of asking the mediaSession directly.
This allows the video element to give a more robust answer.

html/HTMLVideoElement.h:
platform/ios/WebVideoFullscreenControllerAVKit.mm:

(WebVideoFullscreenControllerContext::setUpFullscreen):

Source/WebKit2:

Ask video element if it supports picture-in-picture instead of asking the mediaSession directly.
This allows the video element to give a more robust answer.

WebProcess/cocoa/WebVideoFullscreenManager.mm:

(WebKit::WebVideoFullscreenManager::enterVideoFullscreenForVideoElement):

11:47 AM Changeset in webkit [217138] by Alan Bujtas

2 edits in trunk/LayoutTests

LayoutTests/accessibility/mac/aria-multiple-liveregions-notification.html should force layout after r216726.
https://bugs.webkit.org/show_bug.cgi?id=172363
<rdar://problem/32182167>

Reviewed by Simon Fraser.

10ms timer is too short to securely ensure a layout. Let's force it instead.

accessibility/mac/aria-multiple-liveregions-notification.html:

11:44 AM Changeset in webkit [217137] by Chris Dumez

3 edits
1 copy in trunk/Source/WebKit2

Make sure implementation of InitializeWebKit2() always run on the main thread
https://bugs.webkit.org/show_bug.cgi?id=172362
<rdar://problem/32295678>

Reviewed by Geoffrey Garen.

Add logic in InitializeWebKit2() for Cocoa ports to always run the initialization code
is only called once, and on the main thread. If we are called from a non-main thread,
we will dispatch synchronously to the main thread to run the initialization code.

This is needed because WebKit2Initialize() is called from the API::Object constructor.
API::Object is thread-safe RefCounted and those objects are sometimes initialized on
non-main thread. If the first of such objects happened to be initialized on a non-main
thread, then we would run the initialization code for the first time on a non-main
thread. This would lead to hard to debug issues because code such as
RunLoop::initializeMainRunLoop() is only safe to call on the main thread because it
stores a pointer to the current thread's RunLoop in a static variable for later use
(i.e. for RunLoop::main()).

Shared/Cocoa/WebKit2InitializeCocoa.mm: Copied from Source/WebKit2/Shared/WebKit2Initialize.cpp.

(WebKit::runInitializationCode):
(WebKit::InitializeWebKit2):

Shared/WebKit2Initialize.cpp:

(WebKit::InitializeWebKit2):

WebKit2.xcodeproj/project.pbxproj:

11:41 AM Changeset in webkit [217136] by Wenson Hsieh

2 edits in trunk/Tools

Unreviewed, fix the build on the latest internal SDK.

TestWebKitAPI/Tests/ios/DataInteractionTests.mm:

(TestWebKitAPI::TEST):

11:36 AM Changeset in webkit [217135] by fpizlo@apple.com

7 edits
1 add in trunk

arrayProtoPrivateFuncConcatMemcpy needs to be down with firstArray being undecided
https://bugs.webkit.org/show_bug.cgi?id=172369

Reviewed by Mark Lam.
JSTests:

stress/undecided-concat.js: Added.

Source/JavaScriptCore:

heap/Subspace.cpp: Reshaped the code a bit to aid debugging.

(JSC::Subspace::allocate):
(JSC::Subspace::tryAllocate):

runtime/ArrayPrototype.cpp:

(JSC::arrayProtoPrivateFuncConcatMemcpy): Fix the bug!

runtime/ObjectInitializationScope.cpp: Provide even better feedback.

(JSC::ObjectInitializationScope::verifyPropertiesAreInitialized):

Tools:

Because I wrote a test that relies on the NoCJIT config scribbling free cells, I thought it
would be a good idea to write this down.

Scripts/run-jsc-stress-tests:

11:07 AM Changeset in webkit [217134] by weinig@apple.com

49 edits in trunk/Source

[WebIDL] Remove the need for the generator to know about native type mapping
https://bugs.webkit.org/show_bug.cgi?id=172310

Reviewed by Darin Adler.

Source/WebCore:

Replace the use of explicit typename to native type mappings in CodeGeneratorJS.pm
with use of IDLTypes and Converter, which already need the mapping. This allows us
to have the information in only one spot.

Also, callback generation to account for nullability and update the IDLs to correctly
annotate only the types that need to be nullable.

Modules/geolocation/GeoNotifier.cpp:
Modules/geolocation/GeoNotifier.h:
Modules/geolocation/Geolocation.cpp:
Modules/geolocation/Geolocation.h:
Modules/geolocation/PositionCallback.idl:
Modules/geolocation/PositionErrorCallback.h:

Use references where possible in the Geolocation code. It was almost possible
to make PositionCallback take a non-nullable position, but some odd logic in
Geolocation::makeCachedPositionCallbacks() implies that there is a path where
passing null is possible, though it would assert. Added FIXME's to return to
this in a follow up.

Modules/webaudio/AudioBufferCallback.idl:

Add nullable annotation and FIXME explaining that the latest spec splits the callback
into two separate ones.

Modules/webdatabase/Database.cpp:

(WebCore::Database::runTransaction):

Modules/webdatabase/DatabaseCallback.h:
Modules/webdatabase/DatabaseManager.cpp:

(WebCore::DatabaseManager::openDatabase):

Modules/webdatabase/SQLStatement.cpp:

(WebCore::SQLStatement::performCallback):

Modules/webdatabase/SQLStatementCallback.h:
Modules/webdatabase/SQLStatementErrorCallback.h:
Modules/webdatabase/SQLTransaction.cpp:

(WebCore::SQLTransaction::deliverTransactionCallback):
(WebCore::SQLTransaction::deliverTransactionErrorCallback):

Modules/webdatabase/SQLTransactionCallback.h:
Modules/webdatabase/SQLTransactionErrorCallback.h:
inspector/InspectorDatabaseAgent.cpp:
bindings/js/JSSQLStatementErrorCallbackCustom.cpp:

(WebCore::JSSQLStatementErrorCallback::handleEvent):
Update to pass callback parameters as references, since they are never null.

bindings/IDLTypes.h:

Add NullableParameterType to allow customization of nullable parameters (in much
the same way we allow customization of the nullable implementation type).

bindings/scripts/CodeGeneratorJS.pm:

(GenerateDefaultValue):
Use Converter<>::ReturnType{ } for default values rather than ${GetNativeType..}().

(GenerateHeader):
Remove use of GetNativeType for toWrapped by using the impl type, since this will never
be a complex type.

(GenerateImplementation):
Simplify DOMJIT UnsafeToNative by merging two identical paths and using auto.

(GenerateParametersCheck):
Rework parameter checks to use more specific variable names, make branches more clear,
and use Converter<>::ReturnType rather than GetNativeType.

(GenerateCallbackHeaderContent):
(GenerateCallbackImplementationContent):
Switch to using typename ${IDLType}::ParameterType as the parameters for callback functions. Also
add final and override to make sure the generated function matches the user provided base class.
(GetNativeType): Deleted.
(GetNativeInnerType): Deleted.
(GetNativeTypeForCallbacks): Deleted.
Remove native type mappings.

css/MediaQueryListListener.h:
css/MediaQueryListListener.idl:
css/MediaQueryMatcher.cpp:

Update MediaQueryListListener to take a non-nullable MediaQueryList.

dom/NativeNodeFilter.cpp:
dom/NativeNodeFilter.h:
dom/NodeFilter.h:
dom/NodeFilter.idl:
dom/NodeIterator.cpp:
dom/Traversal.cpp:
dom/Traversal.h:
dom/TreeWalker.cpp:
bindings/js/JSNodeFilterCustom.cpp:

Update acceptNode to be non-nullable and pass the Node by reference.

dom/StringCallback.cpp:
dom/StringCallback.h:

Pass the ScriptExecutionContext by reference.

page/IntersectionObserverCallback.h:

Update to match new parameter types and pass IntersectionObserver by reference.

page/PerformanceObserver.cpp:
page/PerformanceObserverCallback.h:

Update to pass PerformanceObserverEntryList and PerformanceObserver by reference.

bindings/scripts/test/JS/JSTestCallbackFunction.cpp:
bindings/scripts/test/JS/JSTestCallbackFunction.h:
bindings/scripts/test/JS/JSTestCallbackFunctionWithTypedefs.cpp:
bindings/scripts/test/JS/JSTestCallbackFunctionWithTypedefs.h:
bindings/scripts/test/JS/JSTestCallbackInterface.cpp:
bindings/scripts/test/JS/JSTestCallbackInterface.h:
bindings/scripts/test/JS/JSTestObj.cpp:
bindings/scripts/test/JS/JSTestTypedefs.cpp:

Update test results.

bindings/scripts/test/TestCallbackInterface.idl:

Update test to refer to actual interfaces as we now do lookup on these parameter
types rather than blindly assuming they are interfaces.

Source/WebKit/mac:

DOM/DOM.mm:

(-[DOMNodeFilter acceptNode:]):
Update to pass Node by reference.

11:06 AM Changeset in webkit [217133] by Ryan Haddad

18 edits
6 deletes in trunk

Unreviewed, rolling out r217098, r217111, r217113, and
r217114.
https://bugs.webkit.org/show_bug.cgi?id=172367

These changes broke the Windows build and introduced
LayoutTest failures (Requested by ryanhaddad on #webkit).

Reverted changesets:

"[MSE][Mac] Support painting MSE video-element to canvas"
https://bugs.webkit.org/show_bug.cgi?id=125157
http://trac.webkit.org/changeset/217098

"[MSE][Mac] Support painting MSE video-element to canvas"
https://bugs.webkit.org/show_bug.cgi?id=125157
http://trac.webkit.org/changeset/217111

"Unreviewed build fix; add undefined functions and constants
to the CoreMediaSoftLink.h, and use the"
http://trac.webkit.org/changeset/217113

"[MSE][Mac] Support painting MSE video-element to canvas"
https://bugs.webkit.org/show_bug.cgi?id=125157
http://trac.webkit.org/changeset/217114

Patch by Commit Queue <commit-queue@webkit.org> on 2017-05-19

11:02 AM Changeset in webkit [217132] by Devin Rousso

3 edits in trunk/Source/WebInspectorUI

Web Inspector: Use initialLayout for Settings tab
https://bugs.webkit.org/show_bug.cgi?id=172304

Reviewed by Matt Baker.

UserInterface/Views/GeneralSettingsView.js:

(WebInspector.GeneralSettingsView.prototype.initialLayout):
Move listener for zoom factor to only update that editor.

UserInterface/Views/SettingsTabContentView.js:

(WebInspector.SettingsTabContentView):
(WebInspector.SettingsTabContentView.prototype.initialLayout): Added.
It is not necessary to create the UI for editing settings until the Settings tab is shown.
Use initialLayout to ensure UI gets created exactly once, after the tab is selected.

9:37 AM Changeset in webkit [217131] by jmarcell@apple.com

2 edits in branches/safari-604.1.21-branch/Source/WebCore

Cherry-pick r217096. rdar://problem/32243153

9:23 AM Changeset in webkit [217130] by Jonathan Bedard

3 edits in trunk/Tools

webkitpy: Layout tests which have no output will succeed
https://bugs.webkit.org/show_bug.cgi?id=172322
<rdar://problem/32258350>

Reviewed by David Kilzer.

Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:

(SingleTestRunner._compare_text): Add FailreNotTested to failures if test has no output.

Scripts/webkitpy/layout_tests/models/test_failures.py:

(determine_result_type): FailureNotTested means that the test could not be loaded. This
is classified as a MISSING failure.
(FailureNotTested): Added.
(FailureNotTested.message):

9:16 AM Changeset in webkit [217129] by aestes@apple.com

4 edits in trunk

REGRESSION (r217078): window.ApplePaySession is undefined on macOS Sierra
https://bugs.webkit.org/show_bug.cgi?id=172344

Reviewed by Tim Horton.

Source/WebCore:

r213673 mistakenly changed the ApplePaySession interface from being conditional on
APPLE_PAY to being conditional on APPLE_PAY_DELEGATE, so when r217078 disabled
APPLE_PAY_DELEGATE on Sierra and earlier it disabled ApplePaySession.

Fix this by reverting ApplePaySession to being conditional on APPLE_PAY.

Fixes http/tests/ssl/applepay/ApplePaySession.html

Modules/applepay/ApplePaySession.idl:

LayoutTests:

TestExpectations: Removed http/tests/ssl/applepay/ApplePaySession.html

9:11 AM Changeset in webkit [217128] by Carlos Garcia Campos

3 edits in trunk/Source/WebKit2

REGRESSION(r216977): [GTK] Ephemeral sessions broken after r216977
https://bugs.webkit.org/show_bug.cgi?id=172345

Reviewed by Michael Catanzaro.

Since r216977, WebProcessPool sends the page session ID to the web process, but the WebsiteDataStoreParameters
session ID to the network process. WebsiteDataStoreParameters is only implemented for Cocoa, so we are sending 0
session ID to the network process, while using the right session ID everywhere else.

UIProcess/WebProcessPool.cpp:

(WebKit::WebProcessPool::pageAddedToProcess): Add an ASSERT to ensure we are sending the same session ID to Web
and Network processes.

UIProcess/WebsiteData/WebsiteDataStore.cpp:

(WebKit::WebsiteDataStore::parameters): Add minimal implementation for non-Cocoa ports to at least set the
session ID.

8:48 AM Changeset in webkit [217127] by fpizlo@apple.com

12 edits in trunk/Source/JavaScriptCore

B3::Value::effects() says that having a fence range implies the fence bit, but on x86_64 we lower loadAcq/storeRel to load/store so the store-before-load fence bit orderings won't be honored
https://bugs.webkit.org/show_bug.cgi?id=172306

Reviewed by Michael Saboff.

This changes B3 to emit xchg and its variants for fenced stores on x86. This ensures that
fenced stores cannot be reordered around other fenced instructions. Previously, B3 emitted
normal store instructions for fenced stores. That's wrong because then you get reorderings
that are possible in TSO but impossible in SC. Fenced instructions are supposed to be SC
with respect for each other.

This is imprecise. If you really just wanted a store-release, then every X86 store does this.
But, in B3, fenced stores are ARM-style store-release, meaning that they are fenced with
respect to all other fences. If we ever did want to say that something is a store release in
the traditional sense, then we'd want MemoryValue to have a fence flag. Then, having a fence
range without the fence flag would mean the traditional store-release, which lowers to a
normal store on x86. But to my knowledge, that traditional store-release is only useful for
unlocking spinlocks. We don't use spinlocks in JSC. Adaptive locks require CAS for unlock,
and B3 CAS is plenty fast. I think it's OK to have this small imprecision of giving clients
an ARM-style store-release on x86 using xchg.

The implication of this change is that the FTL no longer violates the SAB memory model.

assembler/MacroAssemblerX86Common.h:

(JSC::MacroAssemblerX86Common::xchg8):
(JSC::MacroAssemblerX86Common::xchg16):
(JSC::MacroAssemblerX86Common::xchg32):
(JSC::MacroAssemblerX86Common::loadAcq8): Deleted.
(JSC::MacroAssemblerX86Common::loadAcq8SignedExtendTo32): Deleted.
(JSC::MacroAssemblerX86Common::loadAcq16): Deleted.
(JSC::MacroAssemblerX86Common::loadAcq16SignedExtendTo32): Deleted.
(JSC::MacroAssemblerX86Common::loadAcq32): Deleted.
(JSC::MacroAssemblerX86Common::storeRel8): Deleted.
(JSC::MacroAssemblerX86Common::storeRel16): Deleted.
(JSC::MacroAssemblerX86Common::storeRel32): Deleted.

assembler/MacroAssemblerX86_64.h:

(JSC::MacroAssemblerX86_64::xchg64):
(JSC::MacroAssemblerX86_64::loadAcq64): Deleted.
(JSC::MacroAssemblerX86_64::storeRel64): Deleted.

b3/B3LowerToAir.cpp:

(JSC::B3::Air::LowerToAir::ArgPromise::inst):
(JSC::B3::Air::LowerToAir::trappingInst):
(JSC::B3::Air::LowerToAir::tryAppendStoreBinOp):
(JSC::B3::Air::LowerToAir::createStore):
(JSC::B3::Air::LowerToAir::storeOpcode):
(JSC::B3::Air::LowerToAir::appendStore):
(JSC::B3::Air::LowerToAir::append):
(JSC::B3::Air::LowerToAir::appendTrapping):
(JSC::B3::Air::LowerToAir::fillStackmap):
(JSC::B3::Air::LowerToAir::lower):

b3/air/AirKind.cpp:

(JSC::B3::Air::Kind::dump):

b3/air/AirKind.h:

(JSC::B3::Air::Kind::Kind):
(JSC::B3::Air::Kind::operator==):
(JSC::B3::Air::Kind::hash):

b3/air/AirLowerAfterRegAlloc.cpp:

(JSC::B3::Air::lowerAfterRegAlloc):

b3/air/AirLowerMacros.cpp:

(JSC::B3::Air::lowerMacros):

b3/air/AirOpcode.opcodes:
b3/air/AirValidate.cpp:
b3/air/opcode_generator.rb:
b3/testb3.cpp:

(JSC::B3::correctSqrt):
(JSC::B3::testSqrtArg):
(JSC::B3::testSqrtImm):
(JSC::B3::testSqrtMem):
(JSC::B3::testSqrtArgWithUselessDoubleConversion):
(JSC::B3::testSqrtArgWithEffectfulDoubleConversion):
(JSC::B3::testStoreRelAddLoadAcq32):
(JSC::B3::testTrappingLoad):
(JSC::B3::testTrappingStore):
(JSC::B3::testTrappingLoadAddStore):
(JSC::B3::testTrappingLoadDCE):

7:45 AM Changeset in webkit [217126] by Carlos Garcia Campos

2 edits in trunk/Source/WebKit2

Add more input validation in Connection::processMessage()
https://bugs.webkit.org/show_bug.cgi?id=171682

Reviewed by Michael Catanzaro.

Check limits of attachments and message size. Credit to Nathan Crandall for reporting this issue and submitting
an equivalent fix.

Platform/IPC/unix/ConnectionUnix.cpp:

(IPC::Connection::processMessage):

7:11 AM Changeset in webkit [217125] by Chris Dumez

13 edits
153 adds in trunk

CSSOM insertRule() index argument is optional with default 0
https://bugs.webkit.org/show_bug.cgi?id=172219

Reviewed by Sam Weinig.

LayoutTests/imported/w3c:

Import cssom web-platform-tests. The insertRule* tests include coverage
for this change.

resources/import-expectations.json:
web-platform-tests/cssom/CSS-expected.txt: Added.
web-platform-tests/cssom/CSS.html: Added.
web-platform-tests/cssom/CSSKeyframeRule-expected.txt: Added.
web-platform-tests/cssom/CSSKeyframeRule.html: Added.
web-platform-tests/cssom/CSSKeyframesRule-expected.txt: Added.
web-platform-tests/cssom/CSSKeyframesRule.html: Added.
web-platform-tests/cssom/CSSNamespaceRule-expected.txt: Added.
web-platform-tests/cssom/CSSNamespaceRule.html: Added.
web-platform-tests/cssom/CSSRuleList-expected.txt: Added.
web-platform-tests/cssom/CSSRuleList.html: Added.
web-platform-tests/cssom/CSSStyleRule-expected.txt: Added.
web-platform-tests/cssom/CSSStyleRule.html: Added.
web-platform-tests/cssom/CSSStyleSheet-expected.txt: Added.
web-platform-tests/cssom/CSSStyleSheet.html: Added.
web-platform-tests/cssom/MediaList-expected.txt: Added.
web-platform-tests/cssom/MediaList.html: Added.
web-platform-tests/cssom/MediaList.xhtml: Added.
web-platform-tests/cssom/OWNERS: Added.
web-platform-tests/cssom/StyleSheetList-expected.txt: Added.
web-platform-tests/cssom/StyleSheetList.html: Added.
web-platform-tests/cssom/computed-style-001-expected.txt: Added.
web-platform-tests/cssom/computed-style-001.html: Added.
web-platform-tests/cssom/css-style-attribute-modifications-expected.txt: Added.
web-platform-tests/cssom/css-style-attribute-modifications.html: Added.
web-platform-tests/cssom/css-style-declaration-modifications-expected.txt: Added.
web-platform-tests/cssom/css-style-declaration-modifications.html: Added.
web-platform-tests/cssom/cssimportrule-expected.txt: Added.
web-platform-tests/cssom/cssimportrule.html: Added.
web-platform-tests/cssom/cssom-cssText-serialize-expected.txt: Added.
web-platform-tests/cssom/cssom-cssText-serialize.html: Added.
web-platform-tests/cssom/cssom-cssstyledeclaration-set-expected.txt: Added.
web-platform-tests/cssom/cssom-cssstyledeclaration-set.html: Added.
web-platform-tests/cssom/cssom-fontfacerule-constructors-expected.txt: Added.
web-platform-tests/cssom/cssom-fontfacerule-constructors.html: Added.
web-platform-tests/cssom/cssom-fontfacerule-expected.txt: Added.
web-platform-tests/cssom/cssom-fontfacerule.html: Added.
web-platform-tests/cssom/cssom-setProperty-shorthand-expected.txt: Added.
web-platform-tests/cssom/cssom-setProperty-shorthand.html: Added.
web-platform-tests/cssom/cssstyledeclaration-csstext-expected.txt: Added.
web-platform-tests/cssom/cssstyledeclaration-csstext.html: Added.
web-platform-tests/cssom/cssstyledeclaration-mutability-expected.txt: Added.
web-platform-tests/cssom/cssstyledeclaration-mutability.html: Added.
web-platform-tests/cssom/escape-expected.txt: Added.
web-platform-tests/cssom/escape.html: Added.
web-platform-tests/cssom/getComputedStyle-pseudo-expected.txt: Added.
web-platform-tests/cssom/getComputedStyle-pseudo.html: Added.
web-platform-tests/cssom/historical-expected.txt: Added.
web-platform-tests/cssom/historical.html: Added.
web-platform-tests/cssom/index-001-expected.txt: Added.
web-platform-tests/cssom/index-001.html: Added.
web-platform-tests/cssom/index-002-expected.txt: Added.
web-platform-tests/cssom/index-002.html: Added.
web-platform-tests/cssom/index-003-expected.txt: Added.
web-platform-tests/cssom/index-003.html: Added.
web-platform-tests/cssom/inline-style-001-expected.txt: Added.
web-platform-tests/cssom/inline-style-001.html: Added.
web-platform-tests/cssom/insertRule-charset-no-index-expected.txt: Added.
web-platform-tests/cssom/insertRule-charset-no-index.html: Added.
web-platform-tests/cssom/insertRule-import-no-index-expected.txt: Added.
web-platform-tests/cssom/insertRule-import-no-index.html: Added.
web-platform-tests/cssom/insertRule-namespace-no-index-expected.txt: Added.
web-platform-tests/cssom/insertRule-namespace-no-index.html: Added.
web-platform-tests/cssom/insertRule-no-index-expected.txt: Added.
web-platform-tests/cssom/insertRule-no-index.html: Added.
web-platform-tests/cssom/interfaces-expected.txt: Added.
web-platform-tests/cssom/interfaces.html: Added.
web-platform-tests/cssom/medialist-interfaces-001-expected.txt: Added.
web-platform-tests/cssom/medialist-interfaces-001.html: Added.
web-platform-tests/cssom/medialist-interfaces-002-expected.txt: Added.
web-platform-tests/cssom/medialist-interfaces-002.html: Added.
web-platform-tests/cssom/medialist-interfaces-003-expected.txt: Added.
web-platform-tests/cssom/medialist-interfaces-003.html: Added.
web-platform-tests/cssom/medialist-interfaces-004-expected.txt: Added.
web-platform-tests/cssom/medialist-interfaces-004.html: Added.
web-platform-tests/cssom/overflow-serialization-expected.txt: Added.
web-platform-tests/cssom/overflow-serialization.html: Added.
web-platform-tests/cssom/selectorSerialize-expected.txt: Added.
web-platform-tests/cssom/selectorSerialize.html: Added.
web-platform-tests/cssom/serialization-CSSDeclaration-with-important-expected.txt: Added.
web-platform-tests/cssom/serialization-CSSDeclaration-with-important.html: Added.
web-platform-tests/cssom/serialize-namespaced-type-selectors-expected.txt: Added.
web-platform-tests/cssom/serialize-namespaced-type-selectors.html: Added.
web-platform-tests/cssom/serialize-values-expected.txt: Added.
web-platform-tests/cssom/serialize-values.html: Added.
web-platform-tests/cssom/serialize-variable-reference-expected.txt: Added.
web-platform-tests/cssom/serialize-variable-reference.html: Added.
web-platform-tests/cssom/shorthand-serialization-expected.txt: Added.
web-platform-tests/cssom/shorthand-serialization.html: Added.
web-platform-tests/cssom/style-sheet-interfaces-001-expected.txt: Added.
web-platform-tests/cssom/style-sheet-interfaces-001.html: Added.
web-platform-tests/cssom/style-sheet-interfaces-002-expected.txt: Added.
web-platform-tests/cssom/style-sheet-interfaces-002.html: Added.
web-platform-tests/cssom/stylesheet-same-origin.css: Added.

(body):

web-platform-tests/cssom/stylesheet-same-origin.sub-expected.txt: Added.
web-platform-tests/cssom/stylesheet-same-origin.sub.html: Added.
web-platform-tests/cssom/support/1x1-green.png: Added.
web-platform-tests/cssom/support/1x1-lime.png: Added.
web-platform-tests/cssom/support/1x1-maroon.png: Added.
web-platform-tests/cssom/support/1x1-navy.png: Added.
web-platform-tests/cssom/support/1x1-red.png: Added.
web-platform-tests/cssom/support/1x1-white.png: Added.
web-platform-tests/cssom/support/60x60-gg-rr.png: Added.
web-platform-tests/cssom/support/60x60-green.png: Added.
web-platform-tests/cssom/support/60x60-red.png: Added.
web-platform-tests/cssom/support/README: Added.
web-platform-tests/cssom/support/a-green.css: Added.

(.a):

web-platform-tests/cssom/support/b-green.css: Added.

(.b):

web-platform-tests/cssom/support/c-red.css: Added.

(.c):

web-platform-tests/cssom/support/cat.png: Added.
web-platform-tests/cssom/support/import-charset.css: Added.
web-platform-tests/cssom/support/import-green.css: Added.

(.import):

web-platform-tests/cssom/support/import-red.css: Added.

(.import):

web-platform-tests/cssom/support/pattern-grg-rgr-grg.png: Added.
web-platform-tests/cssom/support/pattern-grg-rrg-rgg.png: Added.
web-platform-tests/cssom/support/pattern-rgr-grg-rgr.png: Added.
web-platform-tests/cssom/support/pattern-tr.png: Added.
web-platform-tests/cssom/support/ruler-h-50%.png: Added.
web-platform-tests/cssom/support/ruler-h-50px.png: Added.
web-platform-tests/cssom/support/ruler-v-100px.png: Added.
web-platform-tests/cssom/support/ruler-v-50px.png: Added.
web-platform-tests/cssom/support/square-purple.png: Added.
web-platform-tests/cssom/support/square-teal.png: Added.
web-platform-tests/cssom/support/square-white.png: Added.
web-platform-tests/cssom/support/support/README: Added.
web-platform-tests/cssom/support/support/swatch-green.png: Added.
web-platform-tests/cssom/support/support/swatch-red.png: Added.
web-platform-tests/cssom/support/support/w3c-import.log: Added.
web-platform-tests/cssom/support/swatch-blue.png: Added.
web-platform-tests/cssom/support/swatch-green.png: Added.
web-platform-tests/cssom/support/swatch-lime.png: Added.
web-platform-tests/cssom/support/swatch-orange.png: Added.
web-platform-tests/cssom/support/swatch-red.png: Added.
web-platform-tests/cssom/support/swatch-teal.png: Added.
web-platform-tests/cssom/support/swatch-white.png: Added.
web-platform-tests/cssom/support/swatch-yellow.png: Added.
web-platform-tests/cssom/support/test-bl.png: Added.
web-platform-tests/cssom/support/test-br.png: Added.
web-platform-tests/cssom/support/test-inner-half-size.png: Added.
web-platform-tests/cssom/support/test-outer.png: Added.
web-platform-tests/cssom/support/test-tl.png: Added.
web-platform-tests/cssom/support/test-tr.png: Added.
web-platform-tests/cssom/support/w3c-import.log: Added.
web-platform-tests/cssom/ttwf-cssom-doc-ext-load-count-expected.txt: Added.
web-platform-tests/cssom/ttwf-cssom-doc-ext-load-count.html: Added.
web-platform-tests/cssom/ttwf-cssom-doc-ext-load-tree-order-expected.txt: Added.
web-platform-tests/cssom/ttwf-cssom-doc-ext-load-tree-order.html: Added.
web-platform-tests/cssom/ttwf-cssom-document-extension-expected.txt: Added.
web-platform-tests/cssom/ttwf-cssom-document-extension.html: Added.
web-platform-tests/cssom/variable-names-expected.txt: Added.
web-platform-tests/cssom/variable-names.html: Added.
web-platform-tests/cssom/w3c-import.log: Added.

Source/WebCore:

Index parameter to CSSSupportsRule.insertRule() and CSSStyleSheet.insertRule() should
be optional with a default value of 0, as per the latest specification:

Tests: imported/w3c/web-platform-tests/cssom/insertRule-charset-no-index.html

imported/w3c/web-platform-tests/cssom/insertRule-import-no-index.html
imported/w3c/web-platform-tests/cssom/insertRule-namespace-no-index.html
imported/w3c/web-platform-tests/cssom/insertRule-no-index.html

css/CSSStyleSheet.cpp:
css/CSSStyleSheet.h:
css/CSSStyleSheet.idl:
css/CSSSupportsRule.idl:

LayoutTests:

Update / Rebaseline existing tests to reflect behavior change.

fast/css/CSSSupportsRule-parameters-expected.txt:
fast/css/CSSSupportsRule-parameters.html:
fast/css/stylesheet-parameters-expected.txt:
fast/css/stylesheet-parameters.html:
fast/dom/non-numeric-values-numeric-parameters-expected.txt:

6:59 AM Changeset in webkit [217124] by Yusuke Suzuki

4 edits
86 adds in trunk

Add SixSpeed benchmark to PerformanceTests
https://bugs.webkit.org/show_bug.cgi?id=172326

Reviewed by Sam Weinig.

PerformanceTests:

This patch imports SixSpeed benchmark into WebKit tree.
It is a collection of ES6 microbenchmarks. While the scripts are very tiny,
it sometimes hits our missing care for optimization. So including it is useful.

The benchmark is released under MIT license.

SixSpeed/LICENSE: Added.
SixSpeed/REVISION: Added.
SixSpeed/ReadMe.md: Added.
SixSpeed/tests/.eslintrc: Added.
SixSpeed/tests/arrow-args/arrow-args.es5: Added.
SixSpeed/tests/arrow-args/arrow-args.es6: Added.
SixSpeed/tests/arrow-declare/arrow-declare.es5: Added.
SixSpeed/tests/arrow-declare/arrow-declare.es6: Added.
SixSpeed/tests/arrow/arrow.es5: Added.
SixSpeed/tests/arrow/arrow.es6: Added.
SixSpeed/tests/bindings-compound/bindings-compound.es5: Added.
SixSpeed/tests/bindings-compound/bindings-compound.es6: Added.
SixSpeed/tests/bindings/bindings.es5: Added.
SixSpeed/tests/bindings/bindings.es6: Added.
SixSpeed/tests/classes/classes.es5: Added.
SixSpeed/tests/classes/classes.es6: Added.
SixSpeed/tests/defaults/defaults.es5: Added.
SixSpeed/tests/defaults/defaults.es6: Added.
SixSpeed/tests/destructuring-simple/destructuring-simple.es5: Added.
SixSpeed/tests/destructuring-simple/destructuring-simple.es6: Added.
SixSpeed/tests/destructuring/destructuring.es5: Added.
SixSpeed/tests/destructuring/destructuring.es6: Added.
SixSpeed/tests/for-of-array/for-of-array.es5: Added.
SixSpeed/tests/for-of-array/for-of-array.es6: Added.
SixSpeed/tests/for-of-object/for-of-object.es5: Added.
SixSpeed/tests/for-of-object/for-of-object.es6: Added.
SixSpeed/tests/generator/generator.es5: Added.
SixSpeed/tests/generator/generator.es6: Added.
SixSpeed/tests/map-set-lookup/map-set-lookup.es5: Added.
SixSpeed/tests/map-set-lookup/map-set-lookup.es6: Added.
SixSpeed/tests/map-set-object/map-set-object.es5: Added.
SixSpeed/tests/map-set-object/map-set-object.es6: Added.
SixSpeed/tests/map-set/map-set.es5: Added.
SixSpeed/tests/map-set/map-set.es6: Added.
SixSpeed/tests/map-string/map-string.es5: Added.
SixSpeed/tests/map-string/map-string.es6: Added.
SixSpeed/tests/new-target/defaults.es5: Added.
SixSpeed/tests/new-target/defaults.es6: Added.
SixSpeed/tests/object-assign/object-assign.es5: Added.
SixSpeed/tests/object-assign/object-assign.es6: Added.
SixSpeed/tests/object-literal-ext/object-literal-ext.es5: Added.
SixSpeed/tests/object-literal-ext/object-literal-ext.es6: Added.
SixSpeed/tests/regex-u/regex-u.es5: Added.
SixSpeed/tests/regex-u/regex-u.es6: Added.
SixSpeed/tests/rest/rest.es5: Added.
SixSpeed/tests/rest/rest.es6: Added.
SixSpeed/tests/spread-generator/spread-generator.es5: Added.
SixSpeed/tests/spread-generator/spread-generator.es6: Added.
SixSpeed/tests/spread-literal/spread-literal.es5: Added.
SixSpeed/tests/spread-literal/spread-literal.es6: Added.
SixSpeed/tests/spread/spread.es5: Added.
SixSpeed/tests/spread/spread.es6: Added.
SixSpeed/tests/super/super.es5: Added.
SixSpeed/tests/super/super.es6: Added.
SixSpeed/tests/template_string/template_string.es5: Added.
SixSpeed/tests/template_string/template_string.es6: Added.
SixSpeed/tests/template_string_tag/template_string_tag.es5: Added.
SixSpeed/tests/template_string_tag/template_string_tag.es6: Added.
SixSpeed/wrappers/wrapper.js:

(test):

Tools:

Scripts/run-jsc-benchmarks:

5:32 AM Changeset in webkit [217123] by Carlos Garcia Campos

15 edits
1 copy
1 add in trunk/Source

[Threaded Compositor] Remove platform ifdefs from threaded compositor implementation
https://bugs.webkit.org/show_bug.cgi?id=172265

Reviewed by Žan Doberšek.

Source/WebCore:

Remove PlatformDisplayWPE::EGLTarget.

platform/graphics/wpe/PlatformDisplayWPE.cpp:
platform/graphics/wpe/PlatformDisplayWPE.h:

Source/WebKit2:

Add AcceleratedSurfaceWPE implementation that is equivalent to the PlatformDisplayWPE::EGLTarget. Since WPE needs the
surface to be initialized/finalized in the compositing thread, two new virtual methods has been added to
AcceleratedSurface initialize/finalize that are only implemented by WPE. The threaded compositor no longer
receives a native surface handle as contructor parameter, it now asks the client for it from the compositing
thread, right after it's created.

PlatformWPE.cmake:
Shared/CoordinatedGraphics/threadedcompositor/ThreadedCompositor.cpp:

(WebKit::ThreadedCompositor::create): Remove ativeSurfaceHandle parameter.
(WebKit::ThreadedCompositor::ThreadedCompositor): Initialize m_nativeSurfaceHandle from the compositing thread
asking the client for it.
(WebKit::ThreadedCompositor::createGLContext): Remove the WPE implementation.
(WebKit::ThreadedCompositor::invalidate): Notify the client that the GL context has been destroyed.
(WebKit::ThreadedCompositor::setNativeSurfaceHandleForCompositing): Remove GTK ifdefs.
(WebKit::ThreadedCompositor::setViewportSize): Remove WPE implementation.
(WebKit::ThreadedCompositor::renderLayerTree): Notify the client the frame will be rendered, and when it has
been rendered.
(WebKit::ThreadedCompositor::frameComplete): Remove WPE ifdefs.

Shared/CoordinatedGraphics/threadedcompositor/ThreadedCompositor.h:
WebProcess/WebPage/AcceleratedSurface.cpp:

(WebKit::AcceleratedSurface::create): Add client parameter.
(WebKit::AcceleratedSurface::AcceleratedSurface): Create a AcceleratedSurfaceWPE if display is WPE.

WebProcess/WebPage/AcceleratedSurface.h:

(WebKit::AcceleratedSurface::surfaceID):
(WebKit::AcceleratedSurface::initialize):
(WebKit::AcceleratedSurface::finalize):
(WebKit::AcceleratedSurface::willRenderFrame):
(WebKit::AcceleratedSurface::didRenderFrame):

WebProcess/WebPage/CoordinatedGraphics/ThreadedCoordinatedLayerTreeHost.cpp:

(WebKit::ThreadedCoordinatedLayerTreeHost::ThreadedCoordinatedLayerTreeHost): Pass this as client of AcceleratedSurface.
(WebKit::ThreadedCoordinatedLayerTreeHost::frameComplete): Notify the compositor.
(WebKit::ThreadedCoordinatedLayerTreeHost::nativeSurfaceHandleForCompositing): Initialize the surface and return
the window handler.
(WebKit::ThreadedCoordinatedLayerTreeHost::didDestroyGLContext): Finalize the surface.
(WebKit::ThreadedCoordinatedLayerTreeHost::willRenderFrame): Notify the surface.
(WebKit::ThreadedCoordinatedLayerTreeHost::didRenderFrame): Ditto.

WebProcess/WebPage/CoordinatedGraphics/ThreadedCoordinatedLayerTreeHost.h:
WebProcess/WebPage/gtk/AcceleratedSurfaceWayland.cpp:

(WebKit::AcceleratedSurfaceWayland::create): Add client parameter.
(WebKit::AcceleratedSurfaceWayland::AcceleratedSurfaceWayland): Ditto.
(WebKit::AcceleratedSurfaceWayland::didRenderFrame): Call Client::frameComplete().

WebProcess/WebPage/gtk/AcceleratedSurfaceWayland.h:
WebProcess/WebPage/gtk/AcceleratedSurfaceX11.cpp:

(WebKit::AcceleratedSurfaceX11::create): Add client parameter.
(WebKit::AcceleratedSurfaceX11::AcceleratedSurfaceX11): Ditto.
(WebKit::AcceleratedSurfaceX11::didRenderFrame): Call Client::frameComplete().

WebProcess/WebPage/gtk/AcceleratedSurfaceX11.h:
WebProcess/WebPage/wpe/AcceleratedSurfaceWPE.cpp: Added.

(WebKit::AcceleratedSurfaceWPE::create):
(WebKit::AcceleratedSurfaceWPE::AcceleratedSurfaceWPE):
(WebKit::AcceleratedSurfaceWPE::~AcceleratedSurfaceWPE):
(WebKit::AcceleratedSurfaceWPE::initialize):
(WebKit::AcceleratedSurfaceWPE::finalize):
(WebKit::AcceleratedSurfaceWPE::window):
(WebKit::AcceleratedSurfaceWPE::surfaceID):
(WebKit::AcceleratedSurfaceWPE::resize):
(WebKit::AcceleratedSurfaceWPE::willRenderFrame):
(WebKit::AcceleratedSurfaceWPE::didRenderFrame):

WebProcess/WebPage/wpe/AcceleratedSurfaceWPE.h: Copied from Source/WebKit2/WebProcess/WebPage/gtk/AcceleratedSurfaceX11.h.

4:46 AM Changeset in webkit [217122] by zandobersek@gmail.com

2 edits in trunk/LayoutTests

Unreviewed GTK+ gardening. Adding or updating test expectations for
four W3C layout tests covering MSE and IndexedDB implementations.

platform/gtk/TestExpectations:

3:50 AM Changeset in webkit [217121] by rniwa@webkit.org

3 edits in trunk/PerformanceTests

Speedometer 2.0: Angular v1 test only deletes the second item
https://bugs.webkit.org/show_bug.cgi?id=172353

Reviewed by Antti Koivisto.

Like jQuery and Inferno, run querySelector after removing each todo item.

Speedometer/InteractiveRunner.html: Tweaked CSS again.
Speedometer/resources/tests.js:

3:13 AM Changeset in webkit [217120] by commit-queue@webkit.org

4 edits in trunk/Source/WTF

[WTF] Remove PLATFORM(WIN) references
https://bugs.webkit.org/show_bug.cgi?id=172301

Patch by Don Olmstead <don.olmstead@am.sony.com> on 2017-05-19
Reviewed by Yusuke Suzuki.

wtf/MemoryPressureHandler.cpp:
wtf/MemoryPressureHandler.h:
wtf/Platform.h:

3:09 AM Changeset in webkit [217119] by rniwa@webkit.org

3 edits in trunk/PerformanceTests

Speedometer 2.0: Elem test isn't updating DOM during the measurement
https://bugs.webkit.org/show_bug.cgi?id=172343

Reviewed by Antti Koivisto.

Elem test wasn't doing much work because it simply enqueues items into the work queue, which doesn't get
executed until the next requestAnimationFrame or setTimeout callback happens.

Expose elm's work function as contentWindow.elemWork and make the first use of rAF a synchronous callback
just as it would when requestAnimationFrame isn't defined, and make the second use of rAF queue up to
an array of callbacks, and have the test runner manually invoke each callback.

This increases the runtime of the Elm suite from 100ms to 300ms on Safari.

Speedometer/resources/tests.js:

(processElmWorkQueue): Added. A helper which processes Elm's work queue and manually invokes render callbacks.

Speedometer/resources/todomvc/functional-prog-examples/elm/dist/elm.js:

3:05 AM Changeset in webkit [217118] by rniwa@webkit.org

4 edits in trunk/PerformanceTests

Speedometer 2.0: Flight.js test is sometime broken
https://bugs.webkit.org/show_bug.cgi?id=172347

Reviewed by Antti Koivisto.

The bug was caused by the test runner only waiting for #new-todo, which happens before all other states are
updated in the Flight.js dependency example. As done in Speedometer v1, insert a dummy element with id set
to appIsReady and wait for this element to appear in the benchmark harness.

Speedometer/resources/tests.js: Wait for #appIsReady.
Speedometer/resources/todomvc/dependency-examples/flight/flight/app/js/main.js: Removed the superflous call

to console.log.
(checkReady): Added. Insert #appIsReady if checkLoaded is no longer running at 50ms interval. Because this
could happen asynchronously, we check the absense of checkLoadedTimeoutId Ωevery 10ms for 5 times for
the total duration of 50ms. If checkLoadedTimeoutId was never present, we call it ready. If we ever observed
the presence of checkLoadedTimeoutId, wait another 50ms and start over.

Speedometer/resources/todomvc/dependency-examples/flight/flight/node_modules/requirejs/require.js:

(.newContext.checkLoaded): Expose checkLoadedTimeoutId which is a timer ID used to check the dependency.

3:02 AM Changeset in webkit [217117] by Wenson Hsieh

2 edits in trunk/Tools

[WK1] MiniBrowser should navigate when handling a dropped URL
https://bugs.webkit.org/show_bug.cgi?id=172350

Reviewed by Tim Horton.

Allow all drop actions, including URL navigation, for WebKit1 MiniBrowser.

MiniBrowser/mac/WK1BrowserWindowController.m:

(-[WK1BrowserWindowController webView:dragDestinationActionMaskForDraggingInfo:]):

3:01 AM Changeset in webkit [217116] by jmarcell@apple.com

2 edits in branches/safari-604.1.21-branch/Source/WebCore

Cherry-pick r217058. rdar://problem/32277335

3:00 AM Changeset in webkit [217115] by jmarcell@apple.com

2 edits in branches/safari-604.1.21-branch/Source/WebCore

Cherry-pick r216936. rdar://problem/32278538

2:54 AM Changeset in webkit [217114] by jer.noble@apple.com

2 edits in trunk/LayoutTests

[MSE][Mac] Support painting MSE video-element to canvas
https://bugs.webkit.org/show_bug.cgi?id=125157
<rdar://problem/23062016>

Reviewed by Eric Carlson.

media/media-source/content/test-fragmented.mp4:

2:50 AM Changeset in webkit [217113] by jer.noble@apple.com

4 edits in trunk/Source/WebCore

Unreviewed build fix; add undefined functions and constants to the CoreMediaSoftLink.h, and use the
correct (and previously soft-linked) method in WebCoreDecompressionSession.

platform/cf/CoreMediaSoftLink.cpp:
platform/cf/CoreMediaSoftLink.h:
platform/graphics/cocoa/WebCoreDecompressionSession.mm:

(WebCore::WebCoreDecompressionSession::imageForTime):

2:43 AM Changeset in webkit [217112] by rniwa@webkit.org

4 edits in trunk/PerformanceTests

Speedometer 2.0: jQuery and Inferno tests don't delete all ToDo items
https://bugs.webkit.org/show_bug.cgi?id=172341

Reviewed by Antti Koivisto.

The bug was caused by the fact TodoMVC examples for jQuery and Inferno JS create a new button
to delete the todo item each time todo items are rendered.

Fixed the bug by dynamically look for .destroy using querySelector for each item.

Also moved the deletion of the iframe from the end of each test suite to the beginning of each suite.
This will make debugging the issue like this easier on InteractiveRunner.html since the iframe
will stick around after stepping the last item in the suite.

Speedometer/InteractiveRunner.html: Tweaked the CSS to make buttons to "Step" and "Run" always visible

even if the list of suites and subtests are too long to fit in the viewport.

Speedometer/resources/benchmark-runner.js:

(BenchmarkRunner.prototype.step):
(BenchmarkRunner.prototype._runTestAndRecordResults):

Speedometer/resources/tests.js: Fixed the bug for jQuery and Inferno. In the case of jQuery

we also have to fix the code for checking every ToDo item as completed as well.

2:41 AM Changeset in webkit [217111] by jer.noble@apple.com

1 edit
2 adds in trunk/LayoutTests

[MSE][Mac] Support painting MSE video-element to canvas
https://bugs.webkit.org/show_bug.cgi?id=125157
<rdar://problem/23062016>

Reviewed by Eric Carlson.

media/media-source/content/test-fragmented.mp4: Add a 'edts' atom to move the presentation time for the

first sample to 0:00.

media/media-source/media-source-paint-to-canvas-expected.txt: Added.
media/media-source/media-source-paint-to-canvas.html: Added.

2:39 AM Changeset in webkit [217110] by jmarcell@apple.com

4 edits in branches/safari-604.1.21-branch/Source/WebCore

Cherry-pick r217083. rdar://problem/32282831

2:39 AM Changeset in webkit [217109] by commit-queue@webkit.org

5 edits in trunk/Source/JavaScriptCore

[JSC] Remove PLATFORM(WIN) references
https://bugs.webkit.org/show_bug.cgi?id=172294

Patch by Don Olmstead <don.olmstead@am.sony.com> on 2017-05-19
Reviewed by Yusuke Suzuki.

heap/MachineStackMarker.cpp:

(JSC::MachineThreads::removeThread):

llint/LLIntOfflineAsmConfig.h:
runtime/ConfigFile.h:
runtime/VM.cpp:

(JSC::VM::updateStackLimits):

2:23 AM Changeset in webkit [217108] by Yusuke Suzuki

307 edits
4 copies
1 add in trunk

[JSC][DFG][DOMJIT] Extend CheckDOM to CheckSubClass
https://bugs.webkit.org/show_bug.cgi?id=172098

Reviewed by Saam Barati.

JSTests:

stress/check-sub-class.js: Added.

(shouldBe):
(shouldThrow):
(calling):
(array.forEach):
(i.array.forEach):

Source/JavaScriptCore:

In this patch, we generalize CheckDOM to CheckSubClass.
It can accept any ClassInfo and perform ClassInfo check
in DFG / FTL. Now, we add a new function pointer to ClassInfo,
checkSubClassPatchpoint. It can create DOMJIT patchpoint
for that ClassInfo. It it natural that ClassInfo holds the
way to emit DOMJIT::Patchpoint to perform CheckSubClass
rather than having it in each DOMJIT getter / function
signature annotation.

One problem is that it enlarges the size of ClassInfo.
But this is the best place to put this function pointer.
By doing so, we can add a patchpoint for CheckSubClass
in an non-intrusive manner: WebCore can inject patchpoints
without interactive JSC.

We still have a way to reduce the size of ClassInfo if
we move ArrayBuffer related methods out to the other places.

This patch touches many files because we add a new function
pointer to ClassInfo. But they are basically mechanical change.

API/JSAPIWrapperObject.mm:
API/JSCallbackConstructor.cpp:
API/JSCallbackFunction.cpp:
API/JSCallbackObject.cpp:
API/ObjCCallbackFunction.mm:
CMakeLists.txt:
JavaScriptCore.xcodeproj/project.pbxproj:
bytecode/CodeBlock.cpp:
bytecode/DOMJITAccessCasePatchpointParams.h:

(JSC::DOMJITAccessCasePatchpointParams::DOMJITAccessCasePatchpointParams):

bytecode/EvalCodeBlock.cpp:
bytecode/FunctionCodeBlock.cpp:
bytecode/GetterSetterAccessCase.cpp:

(JSC::GetterSetterAccessCase::emitDOMJITGetter):

bytecode/ModuleProgramCodeBlock.cpp:
bytecode/ProgramCodeBlock.cpp:
bytecode/UnlinkedCodeBlock.cpp:
bytecode/UnlinkedEvalCodeBlock.cpp:
bytecode/UnlinkedFunctionCodeBlock.cpp:
bytecode/UnlinkedFunctionExecutable.cpp:
bytecode/UnlinkedModuleProgramCodeBlock.cpp:
bytecode/UnlinkedProgramCodeBlock.cpp:
debugger/DebuggerScope.cpp:
dfg/DFGAbstractInterpreterInlines.h:

(JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):

dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::handleDOMJITGetter):

dfg/DFGClobberize.h:

(JSC::DFG::clobberize):

dfg/DFGConstantFoldingPhase.cpp:

(JSC::DFG::ConstantFoldingPhase::foldConstants):

dfg/DFGDOMJITPatchpointParams.h:

(JSC::DFG::DOMJITPatchpointParams::DOMJITPatchpointParams):

dfg/DFGDoesGC.cpp:

(JSC::DFG::doesGC):

dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode):
(JSC::DFG::FixupPhase::attemptToMakeCallDOM):
(JSC::DFG::FixupPhase::fixupCheckSubClass):
(JSC::DFG::FixupPhase::fixupCheckDOM): Deleted.

dfg/DFGGraph.cpp:

(JSC::DFG::Graph::dump):

dfg/DFGNode.h:

(JSC::DFG::Node::hasClassInfo):
(JSC::DFG::Node::classInfo):
(JSC::DFG::Node::hasCheckDOMPatchpoint): Deleted.
(JSC::DFG::Node::checkDOMPatchpoint): Deleted.

dfg/DFGNodeType.h:
dfg/DFGPredictionPropagationPhase.cpp:
dfg/DFGSafeToExecute.h:

(JSC::DFG::safeToExecute):

dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileCheckSubClass):
(JSC::DFG::SpeculativeJIT::compileCheckDOM): Deleted.

dfg/DFGSpeculativeJIT.h:

(JSC::DFG::SpeculativeJIT::vm):

dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

domjit/DOMJITGetterSetter.h:
domjit/DOMJITPatchpointParams.h:

(JSC::DOMJIT::PatchpointParams::PatchpointParams):
(JSC::DOMJIT::PatchpointParams::vm):

domjit/DOMJITSignature.h:

(JSC::DOMJIT::Signature::Signature):
(JSC::DOMJIT::Signature::checkDOM): Deleted.

ftl/FTLAbstractHeapRepository.h:
ftl/FTLCapabilities.cpp:

(JSC::FTL::canCompile):

ftl/FTLDOMJITPatchpointParams.h:

(JSC::FTL::DOMJITPatchpointParams::DOMJITPatchpointParams):

ftl/FTLLowerDFGToB3.cpp:

(JSC::FTL::DFG::LowerDFGToB3::compileNode):
(JSC::FTL::DFG::LowerDFGToB3::compileCheckSubClass):
(JSC::FTL::DFG::LowerDFGToB3::compileCheckDOM): Deleted.

inspector/JSInjectedScriptHost.cpp:
inspector/JSInjectedScriptHostPrototype.cpp:
inspector/JSJavaScriptCallFrame.cpp:
inspector/JSJavaScriptCallFramePrototype.cpp:
jsc.cpp:

(WTF::DOMJITNode::checkSubClassPatchpoint):
(WTF::DOMJITFunctionObject::checkSubClassPatchpoint):
(WTF::DOMJITFunctionObject::finishCreation):
(WTF::DOMJITCheckSubClassObject::DOMJITCheckSubClassObject):
(WTF::DOMJITCheckSubClassObject::createStructure):
(WTF::DOMJITCheckSubClassObject::create):
(WTF::DOMJITCheckSubClassObject::safeFunction):
(WTF::DOMJITCheckSubClassObject::unsafeFunction):
(WTF::DOMJITCheckSubClassObject::finishCreation):
(GlobalObject::finishCreation):
(functionCreateDOMJITCheckSubClassObject):
(WTF::DOMJITNode::checkDOMJITNode): Deleted.
(WTF::DOMJITFunctionObject::checkDOMJITNode): Deleted.

runtime/AbstractModuleRecord.cpp:
runtime/ArrayBufferNeuteringWatchpoint.cpp:
runtime/ArrayConstructor.cpp:
runtime/ArrayIteratorPrototype.cpp:
runtime/ArrayPrototype.cpp:
runtime/AsyncFunctionConstructor.cpp:
runtime/AsyncFunctionPrototype.cpp:
runtime/AtomicsObject.cpp:
runtime/BooleanConstructor.cpp:
runtime/BooleanObject.cpp:
runtime/BooleanPrototype.cpp:
runtime/ClassInfo.cpp: Copied from Source/JavaScriptCore/tools/JSDollarVM.cpp.

(JSC::ClassInfo::dump):

runtime/ClassInfo.h:

(JSC::ClassInfo::offsetOfParentClass):

runtime/ClonedArguments.cpp:
runtime/ConsoleObject.cpp:
runtime/CustomGetterSetter.cpp:
runtime/DateConstructor.cpp:
runtime/DateInstance.cpp:
runtime/DatePrototype.cpp:
runtime/DirectArguments.cpp:
runtime/Error.cpp:
runtime/ErrorConstructor.cpp:
runtime/ErrorInstance.cpp:
runtime/ErrorPrototype.cpp:
runtime/EvalExecutable.cpp:
runtime/Exception.cpp:
runtime/ExceptionHelpers.cpp:
runtime/ExecutableBase.cpp:
runtime/FunctionConstructor.cpp:
runtime/FunctionExecutable.cpp:
runtime/FunctionPrototype.cpp:
runtime/FunctionRareData.cpp:
runtime/GeneratorFunctionConstructor.cpp:
runtime/GeneratorFunctionPrototype.cpp:
runtime/GeneratorPrototype.cpp:
runtime/GetterSetter.cpp:
runtime/HashMapImpl.cpp:
runtime/HashMapImpl.h:
runtime/InferredType.cpp:

(JSC::InferredType::create):

runtime/InferredTypeTable.cpp:
runtime/InferredValue.cpp:
runtime/InspectorInstrumentationObject.cpp:
runtime/InternalFunction.cpp:
runtime/IntlCollator.cpp:
runtime/IntlCollatorConstructor.cpp:
runtime/IntlCollatorPrototype.cpp:
runtime/IntlDateTimeFormat.cpp:
runtime/IntlDateTimeFormatConstructor.cpp:
runtime/IntlDateTimeFormatPrototype.cpp:
runtime/IntlNumberFormat.cpp:
runtime/IntlNumberFormatConstructor.cpp:
runtime/IntlNumberFormatPrototype.cpp:
runtime/IntlObject.cpp:
runtime/IteratorPrototype.cpp:
runtime/JSAPIValueWrapper.cpp:
runtime/JSArray.cpp:
runtime/JSArrayBuffer.cpp:
runtime/JSArrayBufferConstructor.cpp:
runtime/JSArrayBufferPrototype.cpp:
runtime/JSArrayBufferView.cpp:
runtime/JSAsyncFunction.cpp:
runtime/JSBoundFunction.cpp:
runtime/JSCallee.cpp:
runtime/JSCustomGetterSetterFunction.cpp:
runtime/JSDataView.cpp:
runtime/JSDataViewPrototype.cpp:
runtime/JSEnvironmentRecord.cpp:
runtime/JSFixedArray.cpp:
runtime/JSFunction.cpp:
runtime/JSGeneratorFunction.cpp:
runtime/JSGlobalLexicalEnvironment.cpp:
runtime/JSGlobalObject.cpp:
runtime/JSInternalPromise.cpp:
runtime/JSInternalPromiseConstructor.cpp:
runtime/JSInternalPromiseDeferred.cpp:
runtime/JSInternalPromisePrototype.cpp:
runtime/JSLexicalEnvironment.cpp:
runtime/JSMap.cpp:
runtime/JSMapIterator.cpp:
runtime/JSModuleEnvironment.cpp:
runtime/JSModuleLoader.cpp:
runtime/JSModuleNamespaceObject.cpp:
runtime/JSModuleRecord.cpp:
runtime/JSNativeStdFunction.cpp:
runtime/JSONObject.cpp:
runtime/JSObject.cpp:
runtime/JSPromise.cpp:
runtime/JSPromiseConstructor.cpp:
runtime/JSPromiseDeferred.cpp:
runtime/JSPromisePrototype.cpp:
runtime/JSPropertyNameEnumerator.cpp:
runtime/JSPropertyNameIterator.cpp:
runtime/JSProxy.cpp:
runtime/JSScriptFetcher.cpp:
runtime/JSSet.cpp:
runtime/JSSetIterator.cpp:
runtime/JSSourceCode.cpp:
runtime/JSString.cpp:
runtime/JSStringIterator.cpp:
runtime/JSSymbolTableObject.cpp:
runtime/JSTemplateRegistryKey.cpp:
runtime/JSTypedArrayConstructors.cpp:
runtime/JSTypedArrayPrototypes.cpp:
runtime/JSTypedArrayViewConstructor.cpp:
runtime/JSTypedArrays.cpp:
runtime/JSWeakMap.cpp:
runtime/JSWeakSet.cpp:
runtime/JSWithScope.cpp:
runtime/MapConstructor.cpp:
runtime/MapIteratorPrototype.cpp:
runtime/MapPrototype.cpp:
runtime/MathObject.cpp:
runtime/ModuleLoaderPrototype.cpp:
runtime/ModuleProgramExecutable.cpp:
runtime/NativeErrorConstructor.cpp:
runtime/NativeExecutable.cpp:
runtime/NativeStdFunctionCell.cpp:
runtime/NullGetterFunction.cpp:
runtime/NullSetterFunction.cpp:
runtime/NumberConstructor.cpp:
runtime/NumberObject.cpp:
runtime/NumberPrototype.cpp:
runtime/ObjectConstructor.cpp:
runtime/ObjectPrototype.cpp:
runtime/ProgramExecutable.cpp:
runtime/PropertyTable.cpp:
runtime/ProxyConstructor.cpp:
runtime/ProxyObject.cpp:
runtime/ProxyRevoke.cpp:
runtime/ReflectObject.cpp:
runtime/RegExp.cpp:
runtime/RegExpConstructor.cpp:
runtime/RegExpObject.cpp:
runtime/RegExpPrototype.cpp:
runtime/ScopedArguments.cpp:
runtime/ScopedArgumentsTable.cpp:
runtime/ScriptExecutable.cpp:
runtime/SetConstructor.cpp:
runtime/SetIteratorPrototype.cpp:
runtime/SetPrototype.cpp:
runtime/SparseArrayValueMap.cpp:
runtime/StrictEvalActivation.cpp:
runtime/StringConstructor.cpp:
runtime/StringIteratorPrototype.cpp:
runtime/StringObject.cpp:
runtime/StringPrototype.cpp:
runtime/Structure.cpp:
runtime/StructureChain.cpp:
runtime/StructureRareData.cpp:
runtime/Symbol.cpp:
runtime/SymbolConstructor.cpp:
runtime/SymbolObject.cpp:
runtime/SymbolPrototype.cpp:
runtime/SymbolTable.cpp:
runtime/WeakMapConstructor.cpp:
runtime/WeakMapData.cpp:
runtime/WeakMapPrototype.cpp:
runtime/WeakSetConstructor.cpp:
runtime/WeakSetPrototype.cpp:
testRegExp.cpp:
tools/JSDollarVM.cpp:
tools/JSDollarVMPrototype.cpp:
wasm/JSWebAssembly.cpp:
wasm/js/JSWebAssemblyCodeBlock.cpp:
wasm/js/JSWebAssemblyCompileError.cpp:
wasm/js/JSWebAssemblyInstance.cpp:
wasm/js/JSWebAssemblyLinkError.cpp:
wasm/js/JSWebAssemblyMemory.cpp:
wasm/js/JSWebAssemblyModule.cpp:
wasm/js/JSWebAssemblyRuntimeError.cpp:
wasm/js/JSWebAssemblyTable.cpp:
wasm/js/WebAssemblyCompileErrorConstructor.cpp:
wasm/js/WebAssemblyCompileErrorPrototype.cpp:
wasm/js/WebAssemblyFunction.cpp:
wasm/js/WebAssemblyFunctionBase.cpp:
wasm/js/WebAssemblyInstanceConstructor.cpp:
wasm/js/WebAssemblyInstancePrototype.cpp:
wasm/js/WebAssemblyLinkErrorConstructor.cpp:
wasm/js/WebAssemblyLinkErrorPrototype.cpp:
wasm/js/WebAssemblyMemoryConstructor.cpp:
wasm/js/WebAssemblyMemoryPrototype.cpp:
wasm/js/WebAssemblyModuleConstructor.cpp:
wasm/js/WebAssemblyModulePrototype.cpp:
wasm/js/WebAssemblyModuleRecord.cpp:
wasm/js/WebAssemblyPrototype.cpp:
wasm/js/WebAssemblyRuntimeErrorConstructor.cpp:
wasm/js/WebAssemblyRuntimeErrorPrototype.cpp:
wasm/js/WebAssemblyTableConstructor.cpp:
wasm/js/WebAssemblyTablePrototype.cpp:
wasm/js/WebAssemblyToJSCallee.cpp:
wasm/js/WebAssemblyWrapperFunction.cpp:

Source/WebCore:

Add DOMJIT interface IDL attribute. Which allows us to define checkSubClassPatchpointFor${className}
function for that ClassInfo. And we move CheckSubClass patchpoint implementation to ClassInfo's member

CMakeLists.txt:
WebCore.xcodeproj/project.pbxproj:
bindings/js/JSDOMGlobalObject.cpp:
bindings/js/JSDOMWindowBase.cpp:
bindings/js/JSDOMWindowProperties.cpp:
bindings/js/JSDOMWindowShell.cpp:
bindings/js/JSReadableStreamPrivateConstructors.cpp:
bindings/js/JSWorkerGlobalScopeBase.cpp:
bindings/scripts/CodeGeneratorJS.pm:

(GenerateHeader):
(GenerateImplementation):
(GenerateImplementationIterableFunctions):
(GenerateConstructorHelperMethods):

bindings/scripts/IDLAttributes.json:
bindings/scripts/test/JS/JSInterfaceName.cpp:
bindings/scripts/test/JS/JSMapLike.cpp:
bindings/scripts/test/JS/JSReadOnlyMapLike.cpp:
bindings/scripts/test/JS/JSTestActiveDOMObject.cpp:
bindings/scripts/test/JS/JSTestCEReactions.cpp:
bindings/scripts/test/JS/JSTestCEReactionsStringifier.cpp:
bindings/scripts/test/JS/JSTestCallbackInterface.cpp:
bindings/scripts/test/JS/JSTestClassWithJSBuiltinConstructor.cpp:
bindings/scripts/test/JS/JSTestCustomConstructorWithNoInterfaceObject.cpp:
bindings/scripts/test/JS/JSTestCustomNamedGetter.cpp:
bindings/scripts/test/JS/JSTestDOMJIT.cpp:
bindings/scripts/test/JS/JSTestDOMJIT.h:
bindings/scripts/test/JS/JSTestEventConstructor.cpp:
bindings/scripts/test/JS/JSTestEventTarget.cpp:
bindings/scripts/test/JS/JSTestException.cpp:
bindings/scripts/test/JS/JSTestGenerateIsReachable.cpp:
bindings/scripts/test/JS/JSTestGlobalObject.cpp:
bindings/scripts/test/JS/JSTestInterface.cpp:
bindings/scripts/test/JS/JSTestInterfaceLeadingUnderscore.cpp:
bindings/scripts/test/JS/JSTestIterable.cpp:
bindings/scripts/test/JS/JSTestJSBuiltinConstructor.cpp:
bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp:
bindings/scripts/test/JS/JSTestNamedConstructor.cpp:
bindings/scripts/test/JS/JSTestNode.cpp:
bindings/scripts/test/JS/JSTestObj.cpp:
bindings/scripts/test/JS/JSTestOverloadedConstructors.cpp:
bindings/scripts/test/JS/JSTestOverloadedConstructorsWithSequence.cpp:
bindings/scripts/test/JS/JSTestOverrideBuiltins.cpp:
bindings/scripts/test/JS/JSTestPromiseRejectionEvent.cpp:
bindings/scripts/test/JS/JSTestSerialization.cpp:
bindings/scripts/test/JS/JSTestSerializationInherit.cpp:
bindings/scripts/test/JS/JSTestSerializationInheritFinal.cpp:
bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp:
bindings/scripts/test/JS/JSTestTypedefs.cpp:
bridge/c/CRuntimeObject.cpp:
bridge/c/c_instance.cpp:
bridge/objc/ObjCRuntimeObject.mm:
bridge/objc/objc_instance.mm:
bridge/objc/objc_runtime.mm:
bridge/runtime_array.cpp:
bridge/runtime_method.cpp:
bridge/runtime_object.cpp:
dom/Document.idl:
dom/DocumentFragment.idl:
dom/Element.idl:
dom/Event.idl:
dom/Node.idl:
domjit/JSDocumentDOMJIT.cpp:

(WebCore::checkSubClassPatchpointForJSDocument):
(WebCore::DocumentDocumentElementDOMJIT::checkDOM): Deleted.
(WebCore::DocumentBodyDOMJIT::checkDOM): Deleted.

domjit/JSDocumentFragmentDOMJIT.cpp: Copied from Source/JavaScriptCore/runtime/JSMap.cpp.

(WebCore::checkSubClassPatchpointForJSDocumentFragment):

domjit/JSElementDOMJIT.cpp: Copied from Source/JavaScriptCore/tools/JSDollarVM.cpp.

(WebCore::checkSubClassPatchpointForJSElement):

domjit/JSEventDOMJIT.cpp: Copied from Source/JavaScriptCore/tools/JSDollarVM.cpp.

(WebCore::checkSubClassPatchpointForJSEvent):

domjit/JSNodeDOMJIT.cpp:

(WebCore::checkSubClassPatchpointForJSNode):
(WebCore::NodeFirstChildDOMJIT::checkDOM): Deleted.
(WebCore::NodeLastChildDOMJIT::checkDOM): Deleted.
(WebCore::NodeNextSiblingDOMJIT::checkDOM): Deleted.
(WebCore::NodePreviousSiblingDOMJIT::checkDOM): Deleted.
(WebCore::NodeParentNodeDOMJIT::checkDOM): Deleted.
(WebCore::NodeNodeTypeDOMJIT::checkDOM): Deleted.
(WebCore::NodeOwnerDocumentDOMJIT::checkDOM): Deleted.

Source/WebKit/mac:

Plugins/Hosted/ProxyInstance.mm:
Plugins/Hosted/ProxyRuntimeObject.mm:

Source/WebKit2:

WebProcess/Plugins/Netscape/JSNPMethod.cpp:
WebProcess/Plugins/Netscape/JSNPObject.cpp:

2:19 AM Changeset in webkit [217107] by rniwa@webkit.org

2 edits in trunk/PerformanceTests

Speedometer 2.0: Vanilla JS test doesn't mark all todo items as completed
https://bugs.webkit.org/show_bug.cgi?id=172348

Reviewed by Antti Koivisto.

The bug was caused by the in-memory store class using the milisecond precision timestamp as an ID.
Because we inserts 50 items all at once, this can result in multiple data items sharing a single ID.

Fixed the bug by using a mononotically increasing ID instead.