⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Jun 2, 2017:

9:40 PM Changeset in webkit [217751] by Alan Bujtas
  • 4 edits in trunk

Cleanup FrameView::autoSizeIfEnabled.
​https://bugs.webkit.org/show_bug.cgi?id=172889
<rdar://problem/32550783>

Reviewed by Tim Horton.

Source/WebCore:

This patch ensures that we always have a clean tree (and a valid and current document size) when
setting m_autoSizeContentSize.

  • page/FrameView.cpp:

(WebCore::FrameView::autoSizeIfEnabled):

Tools:

  • TestWebKitAPI/Tests/WebKit2Cocoa/AutoLayoutIntegration.mm:

(-[AutoLayoutWKWebView load:withWidth:expectingContentSize:resettingWidth:]): progression.
(TEST):

8:44 PM Changeset in webkit [217750] by Devin Rousso
  • 6 edits in trunk/Source/WebInspectorUI

Web Inspector: Don't create NavigationSidebarPanel classes until they are needed by a Tab
​https://bugs.webkit.org/show_bug.cgi?id=172621

Reviewed by Timothy Hatcher.

  • UserInterface/Views/ContentBrowserTabContentView.js:

(WebInspector.ContentBrowserTabContentView):
(WebInspector.ContentBrowserTabContentView.prototype.shown):

  • UserInterface/Views/TabContentView.js:

(WebInspector.TabContentView):
(WebInspector.TabContentView.prototype.get navigationSidebarPanel):

  • UserInterface/Views/NetworkTabContentView.js:

(WebInspector.NetworkTabContentView.prototype.canShowRepresentedObject):

  • UserInterface/Views/SearchTabContentView.js:

(WebInspector.SearchTabContentView.prototype.canShowRepresentedObject):
Use public getter for navigationSidebarPanel.

  • UserInterface/Views/ResourceSidebarPanel.js:

(WebInspector.ResourceSidebarPanel):
(WebInspector.ResourceSidebarPanel.prototype.initialLayout): Added.
Load information about the current frame once the sidebar panel is displayed.

8:37 PM Changeset in webkit [217749] by Devin Rousso
  • 7 edits in trunk/Source/WebInspectorUI

Web Inspector: Use initialLayout for DetailsSidebarPanel classes
​https://bugs.webkit.org/show_bug.cgi?id=172381

Reviewed by Timothy Hatcher.

  • UserInterface/Views/ApplicationCacheDetailsSidebarPanel.js:

(WebInspector.ApplicationCacheDetailsSidebarPanel):
(WebInspector.ApplicationCacheDetailsSidebarPanel.prototype.initialLayout): Added.
(WebInspector.ApplicationCacheDetailsSidebarPanel.prototype.layout):

  • UserInterface/Views/DOMNodeDetailsSidebarPanel.js:

(WebInspector.DOMNodeDetailsSidebarPanel):
(WebInspector.DOMNodeDetailsSidebarPanel.prototype.initialLayout): Added.
(WebInspector.DOMNodeDetailsSidebarPanel.prototype.layout):

  • UserInterface/Views/IndexedDatabaseDetailsSidebarPanel.js:

(WebInspector.IndexedDatabaseDetailsSidebarPanel):
(WebInspector.IndexedDatabaseDetailsSidebarPanel.prototype.initialLayout): Added.
(WebInspector.IndexedDatabaseDetailsSidebarPanel.prototype.layout):

  • UserInterface/Views/LayerTreeDetailsSidebarPanel.js:

(WebInspector.LayerTreeDetailsSidebarPanel):
(WebInspector.LayerTreeDetailsSidebarPanel.prototype.initialLayout): Added.
(WebInspector.LayerTreeDetailsSidebarPanel.prototype.layout):

  • UserInterface/Views/ProbeDetailsSidebarPanel.js:

(WebInspector.ProbeDetailsSidebarPanel):
(WebInspector.ProbeDetailsSidebarPanel.prototype.initialLayout): Added.

  • UserInterface/Views/ResourceDetailsSidebarPanel.js:

(WebInspector.ResourceDetailsSidebarPanel):
(WebInspector.ResourceDetailsSidebarPanel.prototype.set resource):
(WebInspector.ResourceDetailsSidebarPanel.prototype.initialLayout): Added.
(WebInspector.ResourceDetailsSidebarPanel.prototype.layout):
(WebInspector.ResourceDetailsSidebarPanel.prototype._applyResourceEventListeners):

7:27 PM Changeset in webkit [217748] by Wenson Hsieh
  • 2 edits in trunk/Source/WebCore

REGRESSION(r216212): RenderReplaced::paint() should not save and restore the context unless it has to
​https://bugs.webkit.org/show_bug.cgi?id=172883
<rdar://problem/32548614>

Reviewed by Tim Horton.

After implementing dragged content fading, RenderReplace::paint is now always guarded by unnecessary calls to
GraphicsContext::save and GraphicsContext::restore, even when there is no dragged content being rendered. To
address this, we initialize our GraphicsContextStateSaver with saveAndRestore = false, indicating that we don't
want to immediately try and save the context.

If we are in a dragged content range, we will then call GraphicsContextStateSaver::save, which saves the
graphics context and also causes the GraphicsContextStateSaver to eventually try and restore() when it is
destroyed. Otherwise, in the common codepath where the renderer is not in a dragged content range, the
constructor and destructor of GraphicsContextStateSaver will be no-ops with respect to saving and restoring the
graphics context.

  • rendering/RenderReplaced.cpp:

(WebCore::RenderReplaced::paint):

6:35 PM Changeset in webkit [217747] by Yusuke Suzuki
  • 1 edit
    4 adds in trunk/JSTests

ES2015 modules - Export default function hoisting
​https://bugs.webkit.org/show_bug.cgi?id=170174

Reviewed by Saam Barati.

This issue itself is solved by fixing function declaration hoisting rules.
This patch just adds the specific test to modules tests to ensure the bug
is fixed.

  • modules/export-default-function-hoisting.js: Added.
  • modules/export-default-function-hoisting/cappuccino.js: Added.

(import.drinkCocoa.from.string_appeared_here.export.default.drinkCappuccino):

  • modules/export-default-function-hoisting/cocoa.js: Added.

(export.default.drinkCocoa):

6:18 PM Changeset in webkit [217746] by Devin Rousso
  • 4 edits in trunk/Source/WebInspectorUI

Web Inspector: The CodeMirror instance in the ConsolePrompt does't need to be refreshed each time it is shown
​https://bugs.webkit.org/show_bug.cgi?id=172608

Reviewed by Timothy Hatcher.

  • UserInterface/Views/ConsolePrompt.js:

(WebInspector.ConsolePrompt.prototype.shown): Deleted.

  • UserInterface/Views/DatabaseContentView.js:

(WebInspector.DatabaseContentView.prototype.shown): Deleted.

  • UserInterface/Views/QuickConsole.js:

(WebInspector.QuickConsole):

6:09 PM Changeset in webkit [217745] by keith_miller@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

Defer installing mach breakpoint handler until watchdog is actually called
​https://bugs.webkit.org/show_bug.cgi?id=172885

Reviewed by Saam Barati.

Eagerly installing the mach breakpoint handler causes issues with Xcode GUI debugging.
This hides the issue, so it won't occur as often.

  • runtime/VMTraps.cpp:

(JSC::VMTraps::SignalSender::send):
(JSC::VMTraps::VMTraps): Deleted.

  • runtime/VMTraps.h:
4:58 PM Changeset in webkit [217744] by Devin Rousso
  • 5 edits
    1 add in trunk/Source/WebInspectorUI

Web Inspector: Attributes table in Node Details Sidebar should have editable keys and values
​https://bugs.webkit.org/show_bug.cgi?id=167076
<rdar://problem/30033629>

Reviewed by Timothy Hatcher.

  • UserInterface/Views/DOMNodeDetailsSidebarPanel.js:

(WebInspector.DOMNodeDetailsSidebarPanel.prototype._refreshAttributes):
(WebInspector.DOMNodeDetailsSidebarPanel.prototype._attributeNodeValueChanged):
(WebInspector.DOMNodeDetailsSidebarPanel.prototype._createAttributesDataGrid): Deleted.
Rework creation of the attributes DataGrid so that it is only created once and cleared for
new content. Nodes in the DataGrid are now EditableDataGridNode instances so that attribute
names and values can be changed from within the sidebar. The DataGrid is also sorted based
on attribute name, to make finding attributes easier.

  • UserInterface/Views/DataGrid.css:

(.data-grid tr.editable .cell-content > input):
(body:not(.window-inactive, .window-docked-inactive) .data-grid:matches(:focus, .force-focus) tr.editable.selected .cell-content > input):

  • UserInterface/Views/DetailsSection.css:

(.details-section > .content .data-grid tr:not(.editable) td.value-column):
(.details-section > .content .data-grid tr:not(.editable) td.value-column > div):
(.details-section > .content .data-grid td.value-column): Deleted.
(.details-section > .content .data-grid td.value-column > div): Deleted.

  • UserInterface/Main.html:
  • UserInterface/Views/EditableDataGridNode.js: Added.

(WebInspector.EditableDataGridNode):
(WebInspector.EditableDataGridNode.prototype.get element):
(WebInspector.EditableDataGridNode.prototype.createCellContent):
(WebInspector.EditableDataGridNode.prototype._handleKeyPress):
(WebInspector.EditableDataGridNode.prototype._handleBlur):
(WebInspector.EditableDataGridNode.prototype._notifyInputElementValueChanged):
Special type of DataGridNode that wraps the content of each cell in an <input>.

4:48 PM Changeset in webkit [217743] by Chris Dumez
  • 8 edits in trunk

ResourceLoadStatistics are not using unique paths during test runs
​https://bugs.webkit.org/show_bug.cgi?id=172861
<rdar://problem/32442251>

Reviewed by Darin Adler.

Source/WebKit2:

Add WKContextConfigurationSetResourceLoadStatisticsDirectory() C API to allow
WKTR to use a custom directory.

  • UIProcess/API/APIProcessPoolConfiguration.cpp:

(API::ProcessPoolConfiguration::createWithWebsiteDataStoreConfiguration):
(API::ProcessPoolConfiguration::ProcessPoolConfiguration):
(API::ProcessPoolConfiguration::copy):

  • UIProcess/API/APIProcessPoolConfiguration.h:
  • UIProcess/API/C/WKContextConfigurationRef.cpp:

(WKContextConfigurationCopyResourceLoadStatisticsDirectory):
(WKContextConfigurationSetResourceLoadStatisticsDirectory):

  • UIProcess/API/C/WKContextConfigurationRef.h:
  • UIProcess/WebProcessPool.cpp:

(WebKit::legacyWebsiteDataStoreConfiguration):

Tools:

Make sure WebKitTestRunner sets a temporary path for saving resource
load statistics.

  • WebKitTestRunner/TestController.cpp:

(WTR::TestController::generateContextConfiguration):

4:40 PM Changeset in webkit [217742] by mmaxfield@apple.com
  • 11 edits
    4 adds in trunk

REGRESSION(r213464): [iOS] Fonts get too bold when the "Bold Text" accessibility setting is enabled
​https://bugs.webkit.org/show_bug.cgi?id=172737
Source/WebCore:

Reviewed by Simon Fraser.

Revert the part of r213464 which changed how we calculate the weights of system fonts.

Add an InternalSetting to trigger our mock of the accessbility "Bold Text" setting. We can't
use the real setting, so instead we just ask for bold fonts instead of regular fonts when this
setting is true.

Tests: fast/text/accessibility-bold-system-font.html

fast/text/accessibility-bold-system-font-2.html

  • platform/graphics/FontCache.h:

(WebCore::FontCache::shouldMockBoldSystemFontForAccessibility):
(WebCore::FontCache::setShouldMockBoldSystemFontForAccessibility):

  • platform/graphics/ios/FontCacheIOS.mm:

(WebCore::platformFontWithFamilySpecialCase):

  • rendering/RenderTheme.h:

(WebCore::RenderTheme::shouldMockBoldSystemFontForAccessibility):
(WebCore::RenderTheme::setShouldMockBoldSystemFontForAccessibility):

  • rendering/RenderThemeIOS.h:
  • rendering/RenderThemeIOS.mm:

(WebCore::cssWeightOfSystemFont):
(WebCore::RenderThemeIOS::updateCachedSystemFontDescription):

  • testing/InternalSettings.cpp:

(WebCore::InternalSettings::Backup::Backup):
(WebCore::InternalSettings::Backup::restoreTo):
(WebCore::InternalSettings::setShouldMockBoldSystemFontForAccessibility):

  • testing/InternalSettings.h:
  • testing/InternalSettings.idl:

LayoutTests:

<rdar://problem/31608236>

Reviewed by Simon Fraser.

  • fast/text/accessibility-bold-system-font-2-expected.html: Added.
  • fast/text/accessibility-bold-system-font-2.html: Added.
  • fast/text/accessibility-bold-system-font-expected.txt: Added.
  • fast/text/accessibility-bold-system-font.html: Added.
  • platform/mac/TestExpectations:
4:11 PM Changeset in webkit [217741] by Ryan Haddad
  • 2 edits in trunk/LayoutTests

Mark webrtc/captureCanvas-webrtc.html as flaky on iOS.
​https://bugs.webkit.org/show_bug.cgi?id=170870

Unreviewed test gardening.

  • platform/ios-wk2/TestExpectations:
4:10 PM Changeset in webkit [217740] by Jonathan Bedard
  • 3 edits in trunk/LayoutTests

Move compositing/overflow/dynamic-composited-scrolling-status.html failure expectation.
​https://bugs.webkit.org/show_bug.cgi?id=152439

Unreviewed test gardening

compositing/overflow/dynamic-composited-scrolling-status.html fails on iOS-simulator WK2,
but passes on device.

  • platform/ios-simulator-wk2/TestExpectations:
  • platform/ios-wk2/TestExpectations:
4:07 PM Changeset in webkit [217739] by Ryan Haddad
  • 3 edits in trunk/LayoutTests

Mark webrtc/audio-replace-track.html as flaky on iOS and remove Timeout expectation for macOS.
​https://bugs.webkit.org/show_bug.cgi?id=171895

Unreviewed test gardening.

  • platform/ios-wk2/TestExpectations:
  • platform/mac-wk2/TestExpectations:
4:07 PM Changeset in webkit [217738] by beidson@apple.com
  • 7 edits in trunk

Prevent scheme handlers from handling all built-in URL schemes.
<rdar://problem/32404790> and ​https://bugs.webkit.org/show_bug.cgi?id=172869

Reviewed by Andy Estes.

Source/WebCore:

Covered by API test.

This patch refactors SchemeRegistry to keep a base, constant set of each of the special
URL schemes that WebKit knows about by default.

It then exposes that list through a new method to support WK2 API.

  • platform/SchemeRegistry.cpp:

(WebCore::allBuiltinSchemes):
(WebCore::builtinLocalURLSchemes):
(WebCore::localURLSchemes):
(WebCore::builtinSecureSchemes):
(WebCore::secureSchemes):
(WebCore::builtinSchemesWithUniqueOrigins):
(WebCore::schemesWithUniqueOrigins):
(WebCore::builtinEmptyDocumentSchemes):
(WebCore::emptyDocumentSchemes):
(WebCore::builtinCanDisplayOnlyIfCanRequestSchemes):
(WebCore::canDisplayOnlyIfCanRequestSchemes):
(WebCore::SchemeRegistry::removeURLSchemeRegisteredAsLocal):
(WebCore::builtinCORSEnabledSchemes):
(WebCore::CORSEnabledSchemes):
(WebCore::SchemeRegistry::isBuiltinScheme):

  • platform/SchemeRegistry.h:

Source/WebKit2:

  • UIProcess/API/Cocoa/WKWebView.mm:

(+[WKWebView handlesURLScheme:]): Check against WebCore's new master list of URL schemes.

Tools:

  • TestWebKitAPI/Tests/WebKit2Cocoa/WKURLSchemeHandler-1.mm:
4:06 PM Changeset in webkit [217737] by Simon Fraser
  • 31 edits
    2 copies
    2 adds in trunk/Source

All scroll peformance logging should happen in the UI process
​https://bugs.webkit.org/show_bug.cgi?id=172874
rdar://problem/24474830

Reviewed by Tim Horton.

Printing to stdout from the WebProcess doesn't show up anywhere in non-development builds,
so we have to log from the UI process.

Achieve this by adding a PerformanceLoggingClient to Page which forwards messages to
WebPageProxy, which prints them with the same format they had before. Some plumbing through
PlatformCALayerClient and GraphicsLayerClient is required to get messages from TileControllers
through to something that can get to Page.

Source/WebCore:

  • WebCore.xcodeproj/project.pbxproj:
  • page/Page.cpp:

(WebCore::Page::Page):
(WebCore::Page::~Page):

  • page/Page.h:

(WebCore::Page::performanceLoggingClient):

  • page/PageConfiguration.cpp:
  • page/PageConfiguration.h:
  • page/PerformanceLoggingClient.cpp: Added.

(WebCore::PerformanceLoggingClient::synchronousScrollingReasonsAsString):

  • page/PerformanceLoggingClient.h: Added.

(WebCore::PerformanceLoggingClient::~PerformanceLoggingClient):

  • page/scrolling/AsyncScrollingCoordinator.cpp:

(WebCore::AsyncScrollingCoordinator::reportExposedUnfilledArea):
(WebCore::AsyncScrollingCoordinator::reportSynchronousScrollingReasonsChanged):

  • page/scrolling/AsyncScrollingCoordinator.h:
  • page/scrolling/ScrollingTree.h:

(WebCore::ScrollingTree::reportSynchronousScrollingReasonsChanged):
(WebCore::ScrollingTree::reportExposedUnfilledArea):

  • page/scrolling/ThreadedScrollingTree.cpp:

(WebCore::ThreadedScrollingTree::reportSynchronousScrollingReasonsChanged):
(WebCore::ThreadedScrollingTree::reportExposedUnfilledArea):

  • page/scrolling/ThreadedScrollingTree.h:
  • page/scrolling/mac/ScrollingTreeFrameScrollingNodeMac.h:
  • page/scrolling/mac/ScrollingTreeFrameScrollingNodeMac.mm:

(WebCore::ScrollingTreeFrameScrollingNodeMac::commitStateBeforeChildren):
(WebCore::ScrollingTreeFrameScrollingNodeMac::setScrollPosition):
(WebCore::ScrollingTreeFrameScrollingNodeMac::exposedUnfilledArea):
(WebCore::ScrollingTreeFrameScrollingNodeMac::logExposedUnfilledArea): Deleted.
(WebCore::logThreadedScrollingMode): Deleted.

  • platform/graphics/GraphicsLayerClient.h:

(WebCore::GraphicsLayerClient::logFilledVisibleFreshTile):

  • platform/graphics/ca/GraphicsLayerCA.cpp:

(WebCore::GraphicsLayerCA::platformCALayerLogFilledVisibleFreshTile):

  • platform/graphics/ca/GraphicsLayerCA.h:
  • platform/graphics/ca/PlatformCALayerClient.h:

(WebCore::PlatformCALayerClient::platformCALayerLogFilledVisibleFreshTile):

  • platform/graphics/ca/TileController.cpp:

(WebCore::TileController::logFilledVisibleFreshTile):

  • platform/graphics/ca/TileController.h:
  • platform/graphics/ca/TileGrid.cpp:

(WebCore::TileGrid::platformCALayerPaintContents):

  • platform/graphics/ca/TileGrid.h:
  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::logFilledVisibleFreshTile):

  • rendering/RenderLayerBacking.h:

Source/WebKit2:

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::logScrollingEvent):

  • UIProcess/WebPageProxy.h:
  • UIProcess/WebPageProxy.messages.in:
  • WebKit2.xcodeproj/project.pbxproj:
  • WebProcess/WebCoreSupport/WebPerformanceLoggingClient.cpp: Added.

(WebKit::WebPerformanceLoggingClient::WebPerformanceLoggingClient):
(WebKit::WebPerformanceLoggingClient::logScrollingEvent):

  • WebProcess/WebCoreSupport/WebPerformanceLoggingClient.h: Added.
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::m_cpuLimit):

3:20 PM Changeset in webkit [217736] by commit-queue@webkit.org
  • 8 edits in trunk

[JSCOnly] Build static jsc.exe on Windows
​https://bugs.webkit.org/show_bug.cgi?id=172833

Patch by Stephan Szabo <​stephan.szabo@am.sony.com> on 2017-06-02
Reviewed by Konstantin Tokarev.

.:

  • Source/cmake/OptionsJSCOnly.cmake:

Source/WTF:

  • wtf/PlatformJSCOnly.cmake:

Tools:

  • CMakeLists.txt:
  • Scripts/build-jsc:
3:12 PM Changeset in webkit [217735] by Alan Bujtas
  • 2 edits in trunk/Tools

Disable ViewportSizeForViewportUnits tests on iOS.
​https://bugs.webkit.org/show_bug.cgi?id=172872

Reviewed by Tim Horton.

  • TestWebKitAPI/Tests/WebKit2/ViewportSizeForViewportUnits.mm:
2:16 PM Changeset in webkit [217734] by eric.carlson@apple.com
  • 9 edits
    2 adds in trunk

[MediaStream iOS] Cleanup video muting/unmuting when tab visibility changes
​https://bugs.webkit.org/show_bug.cgi?id=172858

Reviewed by Youenn Fablet.

Source/WebCore:

Test: platform/ios/mediastream/video-muted-in-background-tab.html

  • dom/Document.cpp:

(WebCore::Document::visibilityStateChanged): Call notifyMediaCaptureOfVisibilityChanged.
(WebCore::Document::notifyMediaCaptureOfVisibilityChanged): Renamed from notifyVisibilityChangedToMediaCapture.
Set m_videoCaptureMutedForVisibilityChange when capture is muted because the document is hidden,
and clear it when visibility changes when capture is disabled. Don't unmute when the document
becomes visible unless this m_videoCaptureMutedForVisibilityChange is still true.
(WebCore::Document::notifyVisibilityChangedToMediaCapture): Deleted.

  • dom/Document.h:
  • platform/mediastream/RealtimeMediaSource.h:
  • platform/mediastream/RealtimeMediaSourceCenter.cpp:

(WebCore::RealtimeMediaSourceCenter::setVideoCaptureMutedForPageVisibility): Renamed from
setVisibility.
(WebCore::RealtimeMediaSourceCenter::setVisibility): Deleted.

  • platform/mediastream/RealtimeMediaSourceCenter.h:
  • platform/mediastream/mac/AVVideoCaptureSource.mm:

(WebCore::AVVideoCaptureSourceFactory::setVideoCaptureMutedForPageVisibility): Ditto.
(WebCore::AVVideoCaptureSourceFactory::setVisibility): Deleted.

  • platform/mock/MockRealtimeVideoSource.cpp:

(WebCore::MockRealtimeVideoSourceFactory::setVideoCaptureMutedForPageVisibility): Ditto.
(WebCore::MockRealtimeVideoSourceFactory::setVisibility): Deleted.

LayoutTests:

  • platform/ios/mediastream/video-muted-in-background-tab-expected.txt: Added.
  • platform/ios/mediastream/video-muted-in-background-tab.html: Added.
1:57 PM Changeset in webkit [217733] by Devin Rousso
  • 4 edits in trunk/Source/WebInspectorUI

Web Inspector: Existing query in Search tab doesn't perform search on reload
​https://bugs.webkit.org/show_bug.cgi?id=172663

Reviewed by Timothy Hatcher.

  • Localizations/en.lproj/localizedStrings.js:
  • UserInterface/Views/SearchSidebarPanel.css:

(.sidebar > .panel.navigation.search.changed > .banner):
(.sidebar > .panel.navigation.search.changed > .banner > a):
(.sidebar > .panel.navigation.search.changed > :matches(.content, .empty-content-placeholder)):

  • UserInterface/Views/SearchSidebarPanel.js:

(WebInspector.SearchSidebarPanel.prototype.performSearch.resourcesCallback):
(WebInspector.SearchSidebarPanel.prototype._mainResourceDidChange):
(WebInspector.SearchSidebarPanel.prototype._contentChanged):
Listen for any "resource added" event, and show the content changed banner when one occurs.

1:48 PM Changeset in webkit [217732] by Matt Lewis
  • 3 edits in trunk/LayoutTests

Moved test expectation for http/tests/preload/viewport/meta-viewport-link-headers.php to correct file.
​https://bugs.webkit.org/show_bug.cgi?id=172518

Unreviewed test gardening

  • platform/ios-simulator/TestExpectations:
  • platform/ios/TestExpectations:
12:57 PM Changeset in webkit [217731] by Chris Dumez
  • 3 edits in trunk/LayoutTests

REGRESSION: LayoutTest fast/scrolling/arrow-key-scroll-in-rtl-document.html is a flaky failure
​https://bugs.webkit.org/show_bug.cgi?id=161549
<rdar://problem/28213429>

Reviewed by Simon Fraser.

  • fast/scrolling/arrow-key-scroll-in-rtl-document.html:

Call eventSender.callAfterScrollingCompletes() in the next event loop iteration to
address the flakiness.

  • platform/mac-wk2/TestExpectations:

Unskip test.

12:40 PM Changeset in webkit [217730] by fred.wang@free.fr
  • 6 edits
    5 adds in trunk

[Mac] Include frames in the scrolling tree when ScrollingTreeIncludesFrames=true
​https://bugs.webkit.org/show_bug.cgi?id=172825

Patch by Frederic Wang <​fwang@igalia.com> on 2017-06-02
Reviewed by Simon Fraser.

Source/WebCore:

This commit generalizes RenderLayerCompositor/ScrollingCoordinator so that it handles the
case of non-main frames. When ScrollingTreeIncludesFrames=true, all the frames will appear
in the scrolling tree on Mac WK2.

Test: fast/scrolling/scrolling-tree-includes-frame.html

  • page/scrolling/ScrollingCoordinator.cpp:

(WebCore::ScrollingCoordinator::coordinatesScrollingForFrameView): Do not to restrict to the
main frame.

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::updateBacking): Do not to restrict to the main frame.
(WebCore::RenderLayerCompositor::useCoordinatedScrollingForLayer): Make this function a class
member so it can call hasCoordinatedScrolling and no longer needs a RenderView parameter.
(WebCore::RenderLayerCompositor::updateScrollCoordinatedStatus): Do not to restrict to the
main frame.

  • rendering/RenderLayerCompositor.h: Introduce useCoordinatedScrollingForLayer.

LayoutTests:

Add a new test to check whether a non-main frame appears in the scrolling tree when
ScrollingTreeIncludesFrames=true. For now this is only happens for Mac WK2. Also update
the iOS WK2 reference for scrolling-iframe-expected.html

  • fast/scrolling/scrolling-tree-includes-frame-expected.txt: Added.
  • fast/scrolling/scrolling-tree-includes-frame.html: Added.
  • platform/ios-simulator/fast/scrolling/scrolling-tree-includes-frame-expected.txt: Added.
  • platform/ios-wk2/compositing/iframes/scrolling-iframe-expected.txt: Update reference.
  • platform/mac-wk1/fast/scrolling/scrolling-tree-includes-frame-expected.txt: Added.
12:15 PM Changeset in webkit [217729] by Chris Dumez
  • 2 edits in trunk/Source/WebKit2

REGRESSION (r206386): Xactimate Website Crashes @ com.apple.WebKit: WebKit::NPRuntimeObjectMap::convertJSValueToNPVariant + 255
​https://bugs.webkit.org/show_bug.cgi?id=172846
<rdar://problem/31093005>

Reviewed by Mark Lam.

Follow-up to r217695 to deal with exceptions potentially thrown by
NPRuntimeObjectMap::convertJSValueToNPVariant() as well.

  • WebProcess/Plugins/Netscape/NPJSObject.cpp:

(WebKit::NPJSObject::invoke):

12:04 PM Changeset in webkit [217728] by commit-queue@webkit.org
  • 6 edits in trunk/Source/WebKit2

Add abilility to specify presentingApplicationPID for a WebProcessPool.
​https://bugs.webkit.org/show_bug.cgi?id=172839
rdar://problem/32247170

Patch by Jeremy Jones <​jeremyj@apple.com> on 2017-06-02
Reviewed by Tim Horton.

Expose presentingApplicationPID through WebProcessPoolConfiguration.
This allows rehosted WebViews to specify the hosting application.

  • UIProcess/API/APIProcessPoolConfiguration.cpp:

(API::ProcessPoolConfiguration::copy):

  • UIProcess/API/APIProcessPoolConfiguration.h:
  • UIProcess/API/Cocoa/_WKProcessPoolConfiguration.h:
  • UIProcess/API/Cocoa/_WKProcessPoolConfiguration.mm:

(-[_WKProcessPoolConfiguration setPresentingApplicationPID:]):
(-[_WKProcessPoolConfiguration presentingApplicationPID]):

  • UIProcess/WebProcessPool.cpp:

(WebKit::WebProcessPool::ensureNetworkProcess):
(WebKit::WebProcessPool::createNewWebProcess):

12:04 PM Changeset in webkit [217727] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[WebCore] DragImageRef should correspond to USE(CAIRO)
​https://bugs.webkit.org/show_bug.cgi?id=172863

Patch by Don Olmstead <​don.olmstead@am.sony.com> on 2017-06-02
Reviewed by Carlos Alberto Lopez Perez.

No new tests. No change in behavior.

  • platform/DragImage.h:
11:42 AM Changeset in webkit [217726] by fred.wang@free.fr
  • 6 edits
    7 adds in trunk

[Mac] Use compositing for frames when ScrollingTreeIncludesFrames=true
​https://bugs.webkit.org/show_bug.cgi?id=172851

Patch by Frederic Wang <​fwang@igalia.com> on 2017-06-02
Reviewed by Simon Fraser.

Source/WebCore:

When fast frame scrolling is supported on mac (bug 171667), scrollable frames will require
special composited layer. This commit enables that on mac but only when
ScrollingTreeIncludesFrames=true, so that the default behavior is unchanged.

Test: compositing/iframes/compositing-for-scrollable-iframe.html

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::requiresCompositingForScrollableFrame): Do not enable frame
compositing when ScrollingTreeIncludesFrames=false.
Rename ScrollableInnerFrameTrigger to ScrollableNonMainFrameTrigger.

  • page/ChromeClient.h: Rename ScrollableInnerFrameTrigger.

Source/WebKit2:

When fast frame scrolling is supported on mac (bug 171667), scrollable frames will require
special composited layer. This commit enables that on mac but only when
ScrollingTreeIncludesFrames=true, so that the default behavior is unchanged.

  • WebProcess/WebCoreSupport/WebChromeClient.h: Make scrollable inner frame trigger

compositing on Mac by default. This is ignored on mac when ScrollingTreeIncludesFrames=false.
Rename ScrollableInnerFrameTrigger to ScrollableNonMainFrameTrigger.

LayoutTests:

This commit adds a test to check whether scrollable iframes require a special composited
layer when ScrollingTreeIncludesFrames=true. This is currently only done on Mac WK2.

  • compositing/iframes/compositing-for-scrollable-iframe.html: Added. This is a basic test

printing the layer tree of a page with an iframe.

  • platform/ios-simulator/compositing/iframes/compositing-for-scrollable-iframe-expected.txt: Added.
  • platform/mac/compositing/iframes/compositing-for-scrollable-iframe-expected.txt: Added.
  • platform/mac-wk1/compositing/iframes/compositing-for-scrollable-iframe-expected.txt: Added.
11:38 AM Changeset in webkit [217725] by Alan Bujtas
  • 13 edits
    1 add in trunk

Allow clients to override viewport size for CSS viewport units.
​https://bugs.webkit.org/show_bug.cgi?id=172838
<rdar://problem/32523441>

Reviewed by Tim Horton.

Source/WebKit2:

This enables auto-sizing clients to ensure that styles relative to the viewport are
resolved to a set value (presumably the size of the container) as opposed to the preferred
document size (which is set as the FrameView size).

  • Shared/WebPageCreationParameters.cpp:

(WebKit::WebPageCreationParameters::encode):
(WebKit::WebPageCreationParameters::decode):

  • Shared/WebPageCreationParameters.h:
  • UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _viewportSizeForCSSViewportUnits]):
(-[WKWebView _setViewportSizeForCSSViewportUnits:]):

  • UIProcess/API/Cocoa/WKWebViewPrivate.h:
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::creationParameters):
(WebKit::WebPageProxy::setViewportSizeForCSSViewportUnits):

  • UIProcess/WebPageProxy.h:

(WebKit::WebPageProxy::viewportSizeForCSSViewportUnits):

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::transitionToCommittedForNewPage):

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::m_cpuLimit):
(WebKit::WebPage::setViewportSizeForCSSViewportUnits):

  • WebProcess/WebPage/WebPage.h:

(WebKit::WebPage::viewportSizeForCSSViewportUnits):

  • WebProcess/WebPage/WebPage.messages.in:

Tools:

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/Tests/WebKit2/ViewportSizeForViewportUnits.mm: Added.

(TEST):

11:20 AM Changeset in webkit [217724] by Simon Fraser
  • 20 edits in trunk

Get <chrono> out of StdLibExtras.h
​https://bugs.webkit.org/show_bug.cgi?id=172744

Reviewed by Zalan Bujtas.

Source/WebCore:

Only bring in <chrono> and namespace std::literals::chrono_literals when necessary.

  • fileapi/FileReader.cpp:
  • inspector/InspectorOverlay.cpp:
  • loader/CrossOriginPreflightResultCache.cpp:
  • loader/cache/CachedResource.cpp:

(WebCore::CachedResource::freshnessLifetime):

  • page/ResourceUsageThread.cpp:

(WebCore::ResourceUsageThread::threadBody):

  • page/cocoa/MemoryReleaseCocoa.mm:

(WebCore::jettisonExpensiveObjectsOnTopLevelNavigation):

  • platform/network/CacheValidation.cpp:

(WebCore::computeFreshnessLifetimeForHTTPFamily):

  • platform/network/CacheValidation.h:

Source/WebKit2:

Only bring in <chrono> and namespace std::literals::chrono_literals when necessary.

  • NetworkProcess/cache/NetworkCache.cpp:
  • NetworkProcess/cache/NetworkCacheFileSystem.h:
  • NetworkProcess/cache/NetworkCacheSpeculativeLoadManager.cpp:
  • NetworkProcess/cache/NetworkCacheStorage.cpp:

(WebKit::NetworkCache::computeRecordWorth):

  • Shared/mac/RemoteLayerBackingStoreCollection.mm:
  • WebProcess/Cookies/WebCookieManager.h:

Source/WTF:

We hates std::chrono. Don't include it everywhere to discourage use.

  • wtf/StdLibExtras.h:

Tools:

  • TestWebKitAPI/Tests/WTF/WorkQueue.cpp:
11:14 AM Changeset in webkit [217723] by aestes@apple.com
  • 12 edits
    2 adds in trunk

[Cocoa] Add a "supportedCountries" property to ApplePayPaymentRequest
​https://bugs.webkit.org/show_bug.cgi?id=172832
<rdar://problem/30735544>

Reviewed by Alex Christensen.

Source/WebCore:

Test: http/tests/ssl/applepay/ApplePaySessionV3.html

  • Modules/applepay/ApplePayPaymentRequest.h:
  • Modules/applepay/ApplePayPaymentRequest.idl:
  • Modules/applepay/ApplePaySession.cpp:

(WebCore::convertAndValidate):

  • Modules/applepay/PaymentRequest.h:

(WebCore::PaymentRequest::supportedCountries):
(WebCore::PaymentRequest::setSupportedCountries):

  • Modules/applepay/PaymentRequestValidator.cpp:

(WebCore::PaymentRequestValidator::validate):

  • platform/spi/cocoa/PassKitSPI.h:

Source/WebKit2:

  • Shared/Cocoa/WebCoreArgumentCodersCocoa.mm:

(IPC::ArgumentCoder<PaymentRequest>::encode):
(IPC::ArgumentCoder<PaymentRequest>::decode):

  • UIProcess/ApplePay/cocoa/WebPaymentCoordinatorProxyCocoa.mm:

(WebKit::toNSSet):
(WebKit::toPKPaymentRequest):

LayoutTests:

  • http/tests/ssl/applepay/ApplePaySessionV3-expected.txt: Added.
  • http/tests/ssl/applepay/ApplePaySessionV3.html: Added.
  • platform/mac-wk2/TestExpectations:
10:58 AM Changeset in webkit [217722] by fpizlo@apple.com
  • 7 edits in trunk

Atomics.load and Atomics.store need to be fully fenced
​https://bugs.webkit.org/show_bug.cgi?id=172844

Reviewed by Keith Miller.

Source/JavaScriptCore:

Implement fully fenced loads and stores in FTL using AtomicXchgAdd(0, ptr) for the load and
AtomicXchg(value, ptr) for the store.

DFG needed no changes because it implements all atomics using a CAS loop.

AtomicsObject.cpp now uses new Atomic<> API for fully fences loads and stores.

Prior to this change, we used half fences (acquire/release) for atomic loads and stores. This
is not correct according to my current understanding of the SAB memory model, which requires
that atomic operations are SC with respect to everything not just other atomics.

  • ftl/FTLLowerDFGToB3.cpp:

(JSC::FTL::DFG::LowerDFGToB3::compileAtomicsReadModifyWrite):

  • ftl/FTLOutput.cpp:

(JSC::FTL::Output::atomicWeakCAS):

  • ftl/FTLOutput.h:
  • runtime/AtomicsObject.cpp:

Source/WTF:

Add loadFullyFenced and storeFullyFenced to Atomic<>.

  • wtf/Atomics.h:

(WTF::Atomic::loadFullyFenced):
(WTF::Atomic::storeRelaxed):
(WTF::Atomic::storeFullyFenced):
(WTF::atomicLoadFullyFenced):
(WTF::atomicStoreFullyFenced):

Websites/webkit.org:

Update documentation to say that the canonical way to do fully fenced loads and stores is
AtomicXchgAdd(0, ptr) and AtomicXchg(value, ptr), respectively.

  • docs/b3/intermediate-representation.html:
10:54 AM Changeset in webkit [217721] by Devin Rousso
  • 11 edits
    3 adds in trunk

Web Inspector: Should see active Web Sockets when opening Web Inspector
​https://bugs.webkit.org/show_bug.cgi?id=172312

Reviewed by Joseph Pecoraro.

Source/WebCore:

Test: http/tests/websocket/tests/hybi/inspector/before-load.html

  • Modules/websockets/WebSocket.h:
  • Modules/websockets/WebSocket.cpp:

(WebCore::WebSocket::WebSocket):
(WebCore::WebSocket::~WebSocket):
(WebCore::WebSocket::allActiveWebSockets):
(WebCore::WebSocket::allActiveWebSocketsMutex):
(WebCore::WebSocket::channel):
(WebCore::WebSocket::eventTargetInterface):
Add a static set of all WebSocket objects and provide getters to access web socket metadata.

  • Modules/websockets/ThreadableWebSocketChannel.h:

(WebCore::ThreadableWebSocketChannel::isWebSocketChannel):

  • Modules/websockets/WebSocketChannel.h:
  • Modules/websockets/WebSocketChannel.cpp:

(WebCore::WebSocketChannel::isWebSocketChannel):
(WebCore::WebSocketChannel::identifier):
(WebCore::WebSocketChannel::clientHandshakeRequest):
(WebCore::WebSocketChannel::serverHandshakeResponse):
(WebCore::WebSocketChannel::handshakeMode):
(WebCore::WebSocketChannel::isType):
Provide getters to access web socket metadata.

  • inspector/InspectorNetworkAgent.cpp:

(WebCore::InspectorNetworkAgent::enable):
Loops over the static set of all WebSocket objects and sends events for each to the frontend.

Source/WebInspectorUI:

  • UserInterface/Controllers/FrameResourceManager.js:

(WebInspector.FrameResourceManager.prototype.webSocketHandshakeResponseReceived):
(WebInspector.FrameResourceManager.prototype.initialize): Removed.
Rework order of agent enable calls to ensure that the main frame is initialized before any
websocket events are dispatched.

  • UserInterface/Models/WebSocketResource.js:

(WebInspector.WebSocketResource.ReadyState):
Change symbol strings in enum for better printing in tests.

LayoutTests:

Test that WebSockets created before the inspector loads are also tracked.

  • http/tests/websocket/tests/hybi/inspector/before-load-expected.txt: Added.
  • http/tests/websocket/tests/hybi/inspector/before-load.html: Added.
  • http/tests/websocket/tests/hybi/inspector/before-load_wsh.py: Added.

(web_socket_do_extra_handshake):
(web_socket_transfer_data):

10:01 AM Changeset in webkit [217720] by mitz@apple.com
  • 2 edits in trunk/Source/WebKit2

[Xcode] Header postprocessing should be based on the target OS version rather than the builder OS version
​https://bugs.webkit.org/show_bug.cgi?id=172860

Reviewed by Anders Carlsson.

  • Configurations/WebKit.xcconfig: Use TARGET_MAC_OS_X_VERSION_MAJOR
9:47 AM Changeset in webkit [217719] by Chris Dumez
  • 2 edits in trunk/Source/WebCore

Unreviewed, fix linking errors on iOS after r217712.

  • platform/OrientationNotifer.h:

(WebCore::OrientationNotifier::Observer::setNotifier):

9:26 AM Changeset in webkit [217718] by bshafiei@apple.com
  • 2 edits in tags/Safari-604.1.23.0.5/Source/WebCore

Build fix. rdar://problem/32530825

9:25 AM Changeset in webkit [217717] by Ryan Haddad
  • 2 edits in trunk/Source/JavaScriptCore

Unreviewed, attempt to fix the iOS build after r217711.

  • assembler/MacroAssemblerARM64.h:

(JSC::MacroAssemblerARM64::xor32):
(JSC::MacroAssemblerARM64::xor64):

9:20 AM Changeset in webkit [217716] by bshafiei@apple.com
  • 7 edits in tags/Safari-604.1.23.0.5/Source

Versioning.

9:19 AM Changeset in webkit [217715] by Ryan Haddad
  • 2 edits in branches/safari-603-branch/LayoutTests

Merge r211465.

9:17 AM Changeset in webkit [217714] by bshafiei@apple.com
  • 1 copy in tags/Safari-604.1.23.0.5

New tag.

9:17 AM Changeset in webkit [217713] by Matt Lewis
  • 2 edits in trunk/LayoutTests

Marked fast/images/slower-decoding-than-animation-image.html as flaky.
​https://bugs.webkit.org/show_bug.cgi?id=172666

Unreviewed test gardening.

  • platform/mac-wk2/TestExpectations:
9:08 AM Changeset in webkit [217712] by Chris Dumez
  • 2 edits in trunk/Source/WebCore

Crash under OrientationNotifier::Observer::setNotifier()
​https://bugs.webkit.org/show_bug.cgi?id=172847
<rdar://problem/32519127>

Reviewed by Youenn Fablet.

Update OrientationNotifier::Observer::setNotifier() to unregister itself from
its current notifier if it already has one. This is needed because
Internals::setCameraMediaStreamTrackOrientation() may be used to override the
notifier of an observer. If we override the notifier without unregistering
the observer from its previous notifier, then the previous notifier will not
get notified when the observer gets destroyed.

No new tests, already covered by webrtc/video-rotation.html that is currently
failing on some bots.

  • platform/OrientationNotifer.h:

(WebCore::OrientationNotifier::Observer::setNotifier):

8:59 AM Changeset in webkit [217711] by fpizlo@apple.com
  • 27 edits
    1 add in trunk/Source/JavaScriptCore

GC should use scrambled free-lists
​https://bugs.webkit.org/show_bug.cgi?id=172793

Reviewed by Mark Lam.

Previously, our bump'n'pop allocator would use a conventional linked-list for the free-list.
The linked-list would be threaded through free memory, as is the usual convention.

This scrambles the next pointers of that free-list. It also scrambles the head pointer, because
this leads to a more natural fast-path structure and saves one register on ARM64.

The secret with which pointers are scrambled is per-allocator. Allocators choose a new secret
every time they do a sweep-to-pop.

This doesn't change the behavior of the bump part of bump'n'pop, but it does refactor the code
quite a bit. Previously, there were four copies of the allocator fast path: two in
MarkedAllocatorInlines.h, one in MarkedAllocator.cpp, and one in AssemblyHelpers.h. The JIT one
was obviously different-looking, but the other three were almost identical. This moves all of
that logic into FreeList. There are now just two copies of the allocator: FreeListInlines.h and
AssemblyHelpers.h.

This appears to be just as fast as our previously allocator.

(JSC::FreeList::FreeList):
(JSC::FreeList::~FreeList):
(JSC::FreeList::clear):
(JSC::FreeList::initializeList):
(JSC::FreeList::initializeBump):
(JSC::FreeList::contains):
(JSC::FreeList::dump):

  • heap/FreeList.h:

(JSC::FreeList::allocationWillFail):
(JSC::FreeList::originalSize):
(JSC::FreeList::addressOfList):
(JSC::FreeList::offsetOfBlock):
(JSC::FreeList::offsetOfList):
(JSC::FreeList::offsetOfIndex):
(JSC::FreeList::offsetOfPayloadEnd):
(JSC::FreeList::offsetOfRemaining):
(JSC::FreeList::offsetOfOriginalSize):
(JSC::FreeList::FreeList): Deleted.
(JSC::FreeList::list): Deleted.
(JSC::FreeList::bump): Deleted.
(JSC::FreeList::operator==): Deleted.
(JSC::FreeList::operator!=): Deleted.
(JSC::FreeList::operator bool): Deleted.

  • heap/FreeListInlines.h: Added.

(JSC::FreeList::addFreeCell):
(JSC::FreeList::allocate):
(JSC::FreeList::forEach):
(JSC::FreeList::toOffset):
(JSC::FreeList::fromOffset):

  • heap/IncrementalSweeper.cpp:

(JSC::IncrementalSweeper::sweepNextBlock):

  • heap/MarkedAllocator.cpp:

(JSC::MarkedAllocator::MarkedAllocator):
(JSC::MarkedAllocator::didConsumeFreeList):
(JSC::MarkedAllocator::tryAllocateWithoutCollecting):
(JSC::MarkedAllocator::tryAllocateIn):
(JSC::MarkedAllocator::allocateSlowCaseImpl):
(JSC::MarkedAllocator::stopAllocating):
(JSC::MarkedAllocator::prepareForAllocation):
(JSC::MarkedAllocator::resumeAllocating):
(JSC::MarkedAllocator::sweep):
(JSC::MarkedAllocator::setFreeList): Deleted.

  • heap/MarkedAllocator.h:

(JSC::MarkedAllocator::freeList):
(JSC::MarkedAllocator::isFreeListedCell): Deleted.

  • heap/MarkedAllocatorInlines.h:

(JSC::MarkedAllocator::isFreeListedCell):
(JSC::MarkedAllocator::tryAllocate):
(JSC::MarkedAllocator::allocate):

  • heap/MarkedBlock.cpp:

(JSC::MarkedBlock::Handle::stopAllocating):
(JSC::MarkedBlock::Handle::lastChanceToFinalize):
(JSC::MarkedBlock::Handle::resumeAllocating):
(JSC::MarkedBlock::Handle::zap):
(JSC::MarkedBlock::Handle::sweep):
(JSC::MarkedBlock::Handle::isFreeListedCell):
(JSC::MarkedBlock::Handle::forEachFreeCell): Deleted.

  • heap/MarkedBlock.h:
  • heap/MarkedBlockInlines.h:

(JSC::MarkedBlock::Handle::specializedSweep):
(JSC::MarkedBlock::Handle::finishSweepKnowingSubspace):
(JSC::MarkedBlock::Handle::isFreeListedCell): Deleted.

  • heap/Subspace.cpp:

(JSC::Subspace::finishSweep):

  • heap/Subspace.h:
  • jit/AssemblyHelpers.h:

(JSC::AssemblyHelpers::emitAllocateWithNonNullAllocator):

  • runtime/JSDestructibleObjectSubspace.cpp:

(JSC::JSDestructibleObjectSubspace::finishSweep):

  • runtime/JSDestructibleObjectSubspace.h:
  • runtime/JSSegmentedVariableObjectSubspace.cpp:

(JSC::JSSegmentedVariableObjectSubspace::finishSweep):

  • runtime/JSSegmentedVariableObjectSubspace.h:
  • runtime/JSStringSubspace.cpp:

(JSC::JSStringSubspace::finishSweep):

  • runtime/JSStringSubspace.h:
  • wasm/js/JSWebAssemblyCodeBlockSubspace.cpp:

(JSC::JSWebAssemblyCodeBlockSubspace::finishSweep):

  • wasm/js/JSWebAssemblyCodeBlockSubspace.h:
8:18 AM Changeset in webkit [217710] by zandobersek@gmail.com
  • 4 edits in trunk/LayoutTests

Unreviewed WPE gardening.

  • platform/wpe/TestExpectations: Add a few test failure expectations.
  • platform/wpe/js/dom/global-constructors-attributes-dedicated-worker-expected.txt: Rebaseline.
  • platform/wpe/js/dom/global-constructors-attributes-expected.txt: Ditto.
4:35 AM Changeset in webkit [217709] by jfernandez@igalia.com
  • 7 edits
    2 adds in trunk

[css-grid] Logical margin incorrectly applied during the tracks sizing algorithm of auto tracks
​https://bugs.webkit.org/show_bug.cgi?id=172836

Reviewed by Manuel Rego Casasnovas.

Source/WebCore:

When computing min-content and max-content of the content-sized tracks
we are using the marginIntrinsicLogicalWidthForChild function, which
uses the grid's writing-mode to determine wether to use the child's
margin width or height. This is not correct when the grid item is
orthogonal.

This patch changes how we compute the tracks width so we use always
the item's marginLogicalWidth, which depends only on its own writing
mode.

Test: fast/css-grid-layout/grid-track-sizing-with-margins-and-orthogonal-flows.html

  • rendering/GridTrackSizingAlgorithm.cpp:

(WebCore::GridTrackSizingAlgorithmStrategy::minContentForChild):
(WebCore::GridTrackSizingAlgorithmStrategy::maxContentForChild):

LayoutTests:

Test to verify different cases of auto-sized tracks and orthogonal items with margins.

  • fast/css-grid-layout/grid-track-sizing-with-margins-and-orthogonal-flows-expected.txt: Added.
  • fast/css-grid-layout/grid-track-sizing-with-margins-and-orthogonal-flows.html: Added.
3:18 AM Changeset in webkit [217708] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebCore

Invalidate the shadow subtree style when slotted pseudo rules are present.
​https://bugs.webkit.org/show_bug.cgi?id=172822

Patch by Emilio Cobos Álvarez <​ecobos@igalia.com> on 2017-06-02
Reviewed by Antti Koivisto.

No new tests, this is tested by
fast/shadow-dom/css-scoping-slot-with-id.html, once we don't force an
Inherit style change for slots. I could add some more tests for stuff
with descendant combinators and similar I guess, though.

  • style/AttributeChangeInvalidation.cpp:

(WebCore::Style::AttributeChangeInvalidation::invalidateStyle):

  • style/ClassChangeInvalidation.cpp:

(WebCore::Style::ClassChangeInvalidation::invalidateStyle):

  • style/IdChangeInvalidation.cpp:

(WebCore::Style::IdChangeInvalidation::invalidateStyle):

2:57 AM Changeset in webkit [217707] by yoon@igalia.com
  • 5 edits in trunk/Source/WebKit2

REGRESSION(r217214): [Coordinated Graphics] UpdateAtlas didn't released while resetting testrunner
​https://bugs.webkit.org/show_bug.cgi?id=172746

Reviewed by Žan Doberšek.

After clearing update atlases in CompositingCoordinator, we should
release update atlases at the compositing thread, too.

We cannot remove update atlases from the CoordinatedGraphicsScene
without regard to update scheduling, since previously committed scene
states can try to use already released update atlases.
To prevent this timing problem, releasing update atlases should be done
with a update scheduler.

  • Shared/CoordinatedGraphics/CoordinatedGraphicsScene.cpp:

(WebKit::CoordinatedGraphicsScene::syncRemoteContent):
(WebKit::CoordinatedGraphicsScene::appendUpdate):

  • Shared/CoordinatedGraphics/CoordinatedGraphicsScene.h:

Use WTF::Function instead of std::function

  • Shared/CoordinatedGraphics/threadedcompositor/ThreadedCompositor.cpp:

(WebKit::ThreadedCompositor::updateSceneState):
(WebKit::ThreadedCompositor::releaseUpdateAtlases):

  • WebProcess/WebPage/CoordinatedGraphics/CompositingCoordinator.cpp:

(WebKit::ThreadedCompositor::flushPendingLayerChanges):
Release UpdateAtlases at the end of compositing states update, too.
(WebKit::CompositingCoordinator::clearUpdateAtlases):

2:18 AM Changeset in webkit [217706] by magomez@igalia.com
  • 6 edits in trunk/Source/WebCore

[GTK+][WPE] Allow TextureMapperShaderProgram to perform colorspace conversions with the source texture pixels
​https://bugs.webkit.org/show_bug.cgi?id=172749

Reviewed by Žan Doberšek.

Currently TextureMapperGL is only able to paint properly textures that are in RGBA format. There are
situations where we will want it to be able to handle other formats (for example BGRA for gstreamer-gl).
To make this possible without having to perform the color conversion in the CPU, we add a new color
conversion matrix to TextureMapperShaderProgram. This matrix will perform the color space conversion
in the GPU, just after sampling the source texture.

Also, add a new flag to TextureMapperGL to indicate that a color conversion is required to handle a
texture. This flag will be set to the TextureMapperPlatformLayerBuffers as required, and TextureMapperGL
will set the appropriate color space matrix to the shader. Initially only the flag for BGRA->RGBA conversion
is defined, but support for new transformations can be added as needed.

VideoTextureCopierGStreamer also uses the TextureMapperShaderProgram to perform texture sampling, but for
the moment it just sets an identity matrix because when using gstreamer-gl, the format of the video frames
is RGBA. This will be changed soon to use BGRA.

No new tests.

  • platform/graphics/gstreamer/VideoTextureCopierGStreamer.cpp:

(WebCore::VideoTextureCopierGStreamer::copyVideoTextureToPlatformTexture):

  • platform/graphics/texmap/TextureMapperGL.cpp:

(WebCore::colorSpaceMatrixForFlags):
(WebCore::TextureMapperGL::drawTexturedQuadWithProgram):

  • platform/graphics/texmap/TextureMapperGL.h:
  • platform/graphics/texmap/TextureMapperShaderProgram.cpp:
  • platform/graphics/texmap/TextureMapperShaderProgram.h:
2:08 AM Changeset in webkit [217705] by jfernandez@igalia.com
  • 9 edits
    2 adds in trunk

[css-grid] Margin wrong applied when stretching an orthogonal item in fixed size track
​https://bugs.webkit.org/show_bug.cgi?id=172590

Reviewed by Sergio Villar Senin.

LayoutTests/imported/w3c:

All the test cases of these tests pass with this change, so updating their expectations accordingly.

  • web-platform-tests/css/css-grid-1/alignment/grid-self-alignment-stretch-006-expected.txt:
  • web-platform-tests/css/css-grid-1/alignment/grid-self-alignment-stretch-vertical-lr-006-expected.txt:
  • web-platform-tests/css/css-grid-1/alignment/grid-self-alignment-stretch-vertical-rl-006-expected.txt:

Source/WebCore:

We need to consider orthogonality when using the item's logical margin to
compute the available space for stretching.

The issue this patch fixes is only reproducible when the grid layout logic
is executed several times, since probably the item doesn't need to be
laid out again. In such cases, we just get the cached logical margins
but we were not taking orthogonality into account.

Test: fast/css-grid-layout/grid-item-stretching-must-not-depend-on-previous-layouts.html

  • rendering/RenderGrid.cpp:

(WebCore::RenderGrid::layoutBlock):
(WebCore::RenderGrid::marginLogicalSizeForChild):
(WebCore::RenderGrid::availableAlignmentSpaceForChildBeforeStretching):

  • rendering/RenderGrid.h:

LayoutTests:

  • TestExpectations: 2 tests pass now but 3 more fail because of bug #172836
  • fast/css-grid-layout/grid-item-stretching-must-not-depend-on-previous-layouts-expected.html: Added.
  • fast/css-grid-layout/grid-item-stretching-must-not-depend-on-previous-layouts.html: Added.
12:52 AM Changeset in webkit [217704] by zandobersek@gmail.com
  • 5 edits
    1 add in trunk

[WPE] Enable SUBTLE_CRYPTO
​https://bugs.webkit.org/show_bug.cgi?id=172756

Reviewed by Michael Catanzaro.

Tools:

  • Scripts/webkitperl/FeatureList.pm: Set ENABLE_SUBTLE_CRYPTO to 1 for WPE.
  • wpe/jhbuild.modules: Add libgpg-error and libgcrypt dependencies.
  • wpe/patches/libgcrypt-use-only-dev-urandom-for-testing.patch: Added. Prevents

exhausting entropy when running the crypto layout tests.

LayoutTests:

  • platform/wpe/TestExpectations: Enable tests under crypto/ and

imported/w3c/web-platform-tests/WebCryptoAPI/ in general, but add
the test expectations for failing tests under those directories.

12:47 AM Changeset in webkit [217703] by Yusuke Suzuki
  • 3 edits in trunk/Source/JavaScriptCore

[JSC] Use @globalPrivate for concatSlowPath
​https://bugs.webkit.org/show_bug.cgi?id=172802

Reviewed by Darin Adler.

Use @globalPrivate instead of manually putting it to JSGlobalObject.

  • builtins/ArrayPrototype.js:

(concatSlowPath): Deleted.

  • runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::init):

Jun 1, 2017:

11:40 PM Changeset in webkit [217702] by Carlos Garcia Campos
  • 6 edits
    2 adds in trunk/Source/WebCore

[GTK] Cache RenderThemeGadget hierarchies for rendering themed elements with GTK+ 3.20+
​https://bugs.webkit.org/show_bug.cgi?id=162673

Reviewed by Michael Catanzaro.

Because of the way the new theming system works in GTK+ >= 3.20 we are currently creating a gadget hierarchy
every time we need to render a styled element or get layout information about it. That's happening on every
repaint, and it's specially problematic for overlay scrollbar indicators that fade in/out when shown/hidden. We
need to cache the gadgets and simply apply the state before every paint or layout query. When using GtkWidgetPath,
calling gtk_style_context_save() breaks the gadget hierarchy, and style classes need to be set when building the
GtkWidgetPath. That means we can't cache RenderThemeGadgets, call save, apply style classes and state, and then
call restore. We need to cache gadget hierarchies with fixed style classes. Fortunately, setting the state does
work, so we don't need to also cache a different hierarchy for every possible state. For example, for the
particular case of scrollbars we would cache VerticalScrollbarRight, VerticalScrollbarLeft, HorizontalScrollbar,
VerticalScrollIndicatorRight, VerticalScrollIndicatorLeft and HorizontalScrollIndicator. In practice, we will
only have 4 of those at the same time in the cache.
This patch adds RenderThemeWidget to represent a hierarchy of gadgets with fixed style classes that can be
cached and reused to render or query style of those "widgets". It also simplifies the RenderThemeGtk and
ScrollbarThemeGtk code by removing a lot of duplicated code to build the gadget hierarchies.

  • PlatformGTK.cmake:
  • platform/gtk/RenderThemeGadget.cpp:

(WebCore::createStyleContext):
(WebCore::appendElementToPath):
(WebCore::RenderThemeGadget::state):
(WebCore::RenderThemeGadget::setState):

  • platform/gtk/RenderThemeGadget.h:
  • platform/gtk/RenderThemeWidget.cpp: Added.

(WebCore::widgetMap):
(WebCore::RenderThemeWidget::getOrCreate):
(WebCore::RenderThemeWidget::clearCache):
(WebCore::RenderThemeWidget::~RenderThemeWidget):
(WebCore::RenderThemeScrollbar::RenderThemeScrollbar):
(WebCore::RenderThemeScrollbar::stepper):
(WebCore::RenderThemeToggleButton::RenderThemeToggleButton):
(WebCore::RenderThemeButton::RenderThemeButton):
(WebCore::RenderThemeComboBox::RenderThemeComboBox):
(WebCore::RenderThemeEntry::RenderThemeEntry):
(WebCore::RenderThemeSearchEntry::RenderThemeSearchEntry):
(WebCore::RenderThemeSpinButton::RenderThemeSpinButton):
(WebCore::RenderThemeSlider::RenderThemeSlider):
(WebCore::RenderThemeProgressBar::RenderThemeProgressBar):
(WebCore::RenderThemeListView::RenderThemeListView):
(WebCore::RenderThemeIcon::RenderThemeIcon):

  • platform/gtk/RenderThemeWidget.h: Added.

(WebCore::RenderThemeEntry::entry):
(WebCore::RenderThemeEntry::selection):

  • platform/gtk/ScrollbarThemeGtk.cpp:

(WebCore::ScrollbarThemeGtk::themeChanged):
(WebCore::ScrollbarThemeGtk::updateThemeProperties):
(WebCore::widgetTypeForScrollbar):
(WebCore::contentsRectangle):
(WebCore::ScrollbarThemeGtk::trackRect):
(WebCore::ScrollbarThemeGtk::backButtonRect):
(WebCore::ScrollbarThemeGtk::forwardButtonRect):
(WebCore::ScrollbarThemeGtk::paint):
(WebCore::ScrollbarThemeGtk::scrollbarThickness):
(WebCore::ScrollbarThemeGtk::minimumThumbLength):

  • rendering/RenderThemeGtk.cpp:

(WebCore::createStyleContext):
(WebCore::setToggleSize):
(WebCore::paintToggle):
(WebCore::RenderThemeGtk::paintButton):
(WebCore::menuListColor):
(WebCore::RenderThemeGtk::popupInternalPaddingBox):
(WebCore::RenderThemeGtk::paintMenuList):
(WebCore::RenderThemeGtk::adjustTextFieldStyle):
(WebCore::RenderThemeGtk::paintTextField):
(WebCore::adjustSearchFieldIconStyle):
(WebCore::paintSearchFieldIcon):
(WebCore::RenderThemeGtk::paintSliderTrack):
(WebCore::RenderThemeGtk::adjustSliderThumbSize):
(WebCore::RenderThemeGtk::paintSliderThumb):
(WebCore::RenderThemeGtk::progressBarRectForBounds):
(WebCore::RenderThemeGtk::paintProgressBar):
(WebCore::RenderThemeGtk::adjustInnerSpinButtonStyle):
(WebCore::RenderThemeGtk::paintInnerSpinButton):
(WebCore::styleColor):
(WebCore::RenderThemeGtk::platformActiveSelectionBackgroundColor):
(WebCore::RenderThemeGtk::platformInactiveSelectionBackgroundColor):
(WebCore::RenderThemeGtk::platformActiveSelectionForegroundColor):
(WebCore::RenderThemeGtk::platformInactiveSelectionForegroundColor):
(WebCore::RenderThemeGtk::paintMediaButton):

10:55 PM Changeset in webkit [217701] by sbarati@apple.com
  • 8 edits in trunk

Ensure a good experience for ARES-6 error reporting
​https://bugs.webkit.org/show_bug.cgi?id=171699

Reviewed by Filip Pizlo and Jon Davis.

This patch fixes a bug where we would silently fail running ARES-6. The bug
was that we were calling reportError with the wrong |this| value.
I also cleaned up a bit of the code around error reporting. We
now indicate which test failed, and update the status to reflect
that a failure happened.

This patch also modifies the CSS a bit to work better on smaller
screened devices. The CSS prevents the status from having a line
break both when an error is reported and when we're running the
benchmark.

  • ARES-6/driver.js:

(Driver):
(Driver.prototype.reportError):

  • ARES-6/results.js:

(Results.prototype.reportError):
(Results):

  • ARES-6/styles.css:

(.start):
(#status):
(.failed):
(#status.failed):
(.test .failed:before):
(#magic):
(@media only screen and (max-width: 784px)):
(.test):
(p):
(@media only screen and (max-width: 320px)):

10:32 PM Changeset in webkit [217700] by bshafiei@apple.com
  • 2 edits in tags/Safari-604.1.23.0.4/Source/WebCore

Merged r217692. rdar://problem/32514813

10:30 PM Changeset in webkit [217699] by bshafiei@apple.com
  • 2 edits in tags/Safari-604.1.23.0.4/Source/WebKit2

Merged r217681. rdar://problem/32518102

10:28 PM Changeset in webkit [217698] by bshafiei@apple.com
  • 7 edits in tags/Safari-604.1.23.0.4/Source

Versioning.

10:24 PM Changeset in webkit [217697] by bshafiei@apple.com
  • 1 copy in tags/Safari-604.1.23.0.4

New tag.

10:04 PM Changeset in webkit [217696] by akling@apple.com
  • 18 edits
    3 adds in trunk

[Mac] Remove backing store for layers that are outside the viewport
​https://bugs.webkit.org/show_bug.cgi?id=170082
<rdar://problem/31245009>

Reviewed by Simon Fraser.

Source/WebCore:

Implement the backingStoreAttached flag in PlatformCALayerCocoa. This means that
compositing layers outside the tiling coverage rect will no longer have backing
stores, saving large amounts of memory.

Also added a canDetachBackingStore flag that is set to false for scroll control
layers, to avoid complicating coverage rect computations.

Test: compositing/backing-store-attachment-1.html

  • page/Frame.h:
  • platform/graphics/GraphicsLayer.cpp:

(WebCore::GraphicsLayer::GraphicsLayer):
(WebCore::GraphicsLayer::dumpProperties):

  • platform/graphics/GraphicsLayer.h:

(WebCore::GraphicsLayer::backingStoreAttached):
(WebCore::GraphicsLayer::setCanDetachBackingStore):
(WebCore::GraphicsLayer::canDetachBackingStore):

  • platform/graphics/GraphicsLayerClient.h:
  • platform/graphics/ca/GraphicsLayerCA.cpp:

(WebCore::GraphicsLayerCA::backingStoreAttached):
(WebCore::GraphicsLayerCA::setNeedsDisplay):
(WebCore::GraphicsLayerCA::updateCoverage):

  • platform/graphics/ca/GraphicsLayerCA.h:
  • platform/graphics/ca/PlatformCALayer.h:
  • platform/graphics/ca/cocoa/PlatformCALayerCocoa.h:
  • platform/graphics/ca/cocoa/PlatformCALayerCocoa.mm:

(PlatformCALayerCocoa::setBackingStoreAttached):
(PlatformCALayerCocoa::backingStoreAttached):

  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::updateOverflowControlsLayers):

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::layerTreeAsText):
(WebCore::RenderLayerCompositor::updateOverflowControlsLayers):

  • testing/Internals.cpp:

(WebCore::toLayerTreeFlags):

  • testing/Internals.h:
  • testing/Internals.idl:

Source/WebKit2:

  • WebProcess/WebPage/mac/PlatformCALayerRemote.h:

LayoutTests:

Add a simple test with two compositing layers far apart vertically. Only one of them
should have its backing store attached.

  • compositing/backing-store-attachment-1-expected.txt: Added.
  • compositing/backing-store-attachment-1.html: Added.
9:35 PM Changeset in webkit [217695] by Chris Dumez
  • 2 edits in trunk/Source/WebKit2

REGRESSION (r206386): Xactimate Website Crashes @ com.apple.WebKit: WebKit::NPRuntimeObjectMap::convertJSValueToNPVariant + 255
​https://bugs.webkit.org/show_bug.cgi?id=172846
<rdar://problem/31093005>

Reviewed by Andreas Kling.

In NPJSObject::invoke(), return early if there was an exception when calling JSC::call().
Using the value returned by JSC::call() when an exception occurred is unsafe.

  • WebProcess/Plugins/Netscape/NPJSObject.cpp:

(WebKit::NPJSObject::invoke):

9:17 PM Changeset in webkit [217694] by Ryan Haddad
  • 11 edits
    3 deletes in trunk

Unreviewed, rolling out r217691.

This change broke the Windows build.

Reverted changeset:

"Web Inspector: Should see active Web Sockets when opening Web
Inspector"
​https://bugs.webkit.org/show_bug.cgi?id=172312
​http://trac.webkit.org/changeset/217691

9:14 PM Changeset in webkit [217693] by Joseph Pecoraro
  • 3 edits in trunk/Source/WebCore

Unreviewed Windows build fix after r217691.

  • Modules/websockets/WebSocketChannel.cpp:

(WebCore::WebSocketChannel::sendFrame):

  • Modules/websockets/WebSocketChannel.h:

Disambiguate the Function being used.

7:50 PM Changeset in webkit [217692] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

LibWebRTC might crash with frames having a null width or height
​https://bugs.webkit.org/show_bug.cgi?id=172842
<rdar://problem/32514813>

Patch by Youenn Fablet <​youenn@apple.com> on 2017-06-01
Reviewed by Jon Lee.

Do not send black frames in case the video width or height is zero.
Also ensure that even if a null buffer is returned by the pool, no crash might actually happen.

  • platform/mediastream/mac/RealtimeOutgoingVideoSource.cpp:

(WebCore::RealtimeOutgoingVideoSource::sendBlackFramesIfNeeded):
(WebCore::RealtimeOutgoingVideoSource::videoSampleAvailable):

7:44 PM Changeset in webkit [217691] by Devin Rousso
  • 11 edits
    3 adds in trunk

Web Inspector: Should see active Web Sockets when opening Web Inspector
​https://bugs.webkit.org/show_bug.cgi?id=172312

Reviewed by Joseph Pecoraro.

Source/WebCore:

Test: http/tests/websocket/tests/hybi/inspector/before-load.html

  • Modules/websockets/WebSocket.h:
  • Modules/websockets/WebSocket.cpp:

(WebCore::WebSocket::WebSocket):
(WebCore::WebSocket::~WebSocket):
(WebCore::WebSocket::allActiveWebSockets):
(WebCore::WebSocket::allActiveWebSocketsMutex):
(WebCore::WebSocket::channel):
(WebCore::WebSocket::eventTargetInterface):
Add a static set of all WebSocket objects and provide getters to access web socket metadata.

  • Modules/websockets/ThreadableWebSocketChannel.h:

(WebCore::ThreadableWebSocketChannel::isWebSocketChannel):

  • Modules/websockets/WebSocketChannel.h:
  • Modules/websockets/WebSocketChannel.cpp:

(WebCore::WebSocketChannel::isWebSocketChannel):
(WebCore::WebSocketChannel::identifier):
(WebCore::WebSocketChannel::clientHandshakeRequest):
(WebCore::WebSocketChannel::serverHandshakeResponse):
(WebCore::WebSocketChannel::handshakeMode):
(WebCore::WebSocketChannel::isType):
Provide getters to access web socket metadata.

  • inspector/InspectorNetworkAgent.cpp:

(WebCore::InspectorNetworkAgent::enable):
Loops over the static set of all WebSocket objects and sends events for each to the frontend.

Source/WebInspectorUI:

  • UserInterface/Controllers/FrameResourceManager.js:

(WebInspector.FrameResourceManager.prototype.webSocketHandshakeResponseReceived):
(WebInspector.FrameResourceManager.prototype.initialize): Removed.
Rework order of agent enable calls to ensure that the main frame is initialized before any
websocket events are dispatched.

  • UserInterface/Models/WebSocketResource.js:

(WebInspector.WebSocketResource.ReadyState):
Change symbol strings in enum for better printing in tests.

LayoutTests:

Test that WebSockets created before the inspector loads are also tracked.

  • http/tests/websocket/tests/hybi/inspector/before-load-expected.txt: Added.
  • http/tests/websocket/tests/hybi/inspector/before-load.html: Added.
  • http/tests/websocket/tests/hybi/inspector/before-load_wsh.py: Added.

(web_socket_do_extra_handshake):
(web_socket_transfer_data):

5:50 PM Changeset in webkit [217690] by Nikita Vasilyev
  • 5 edits in trunk/Source/WebInspectorUI

Web Inspector: Web Sockets: Unable to inspect a WebSocket that receives >50 messages per second
​https://bugs.webkit.org/show_bug.cgi?id=171904
<rdar://problem/32095863>

Reviewed by Matt Baker.

Every size increase of a resource causes a sidebar item to be re-attached to the DOM. Sending or
receiving a WebSocket message causes a size increase. When size increase happens too frequently,
the go-to arrow starts to flicker and becomes unclickable. This patch makes sure a sidebar item gets
re-attached only when its position (index) changes.

  • UserInterface/Views/NetworkSidebarPanel.js:

Add the go-to arrow and close buttons when treeElement.status is a spinner element.

(WebInspector.NetworkSidebarPanel.prototype.treeElementAddedOrChanged):

  • UserInterface/Views/ResourceTreeElement.js:

(WebInspector.ResourceTreeElement.prototype._updateStatus):
Setting status to "" removes the go-to arrow and close buttons in the Network tab.
Only set status to "" to remove the spinner.

  • UserInterface/Views/TimelineDataGrid.js:

(WebInspector.TimelineDataGrid.prototype._refreshDirtyDataGridNodes):

  • UserInterface/Views/TreeOutline.js:

(WebInspector.TreeOutline.prototype.reattachIfIndexChanged): Added.

4:50 PM Changeset in webkit [217689] by Ryan Haddad
  • 3 edits in trunk/LayoutTests

Mark http/tests/navigation/statistics.html as flaky.
​https://bugs.webkit.org/show_bug.cgi?id=172454

Unreviewed test gardening.

  • platform/ios-wk2/TestExpectations:
  • platform/mac-wk2/TestExpectations:
4:16 PM Changeset in webkit [217688] by Simon Fraser
  • 2 edits in trunk/Source/WebCore

REGRESSION (r217296): Dragging a video only shows controls during drag event
​https://bugs.webkit.org/show_bug.cgi?id=172837
rdar://problem/32434661

Reviewed by Zalan Bujtas.

r217296 changed RenderVideo::paintReplaced() from checking paintBehavior() flags on the FrameView
to paintInfo.paintBehavior flags. However, RenderLayer was stripping the PaintBehaviorFlattenCompositingLayers
flag from the paintInfo.paintBehavior flags, so fix that.

Not easily testable.

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::paintLayerContents):

3:40 PM Changeset in webkit [217687] by Simon Fraser
  • 3 edits in trunk/Source/WebCore

Remove the redundant selectionOnly argument from RenderLayer::paintForegroundForFragments()
​https://bugs.webkit.org/show_bug.cgi?id=172835

Reviewed by Zalan Bujtas.

The 'selectionOnly' state is already encoded in localPaintingInfo.paintBehavior so there's
no need to pass it separately.

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::paintLayerContents):
(WebCore::RenderLayer::paintForegroundForFragments):

  • rendering/RenderLayer.h:
3:32 PM Changeset in webkit [217686] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Fix compilation errors in LocalizedStrings.cpp on platform not USE(CF) nor USE(GLIB)
​https://bugs.webkit.org/show_bug.cgi?id=172796

Patch by Yoshiaki Jitsukawa <​Yoshiaki.Jitsukawa@sony.com> on 2017-06-01
Reviewed by Alex Christensen.

No new tests needed. Fixing compilation errors.

  • platform/LocalizedStrings.cpp:

(WebCore::contextMenuItemTagLookUpInDictionary):
(WebCore::imageTitle):
(WebCore::validationMessageRangeUnderflowText):
(WebCore::validationMessageRangeOverflowText):

2:53 PM Changeset in webkit [217685] by Matt Lewis
  • 2 edits in trunk/LayoutTests

Fixed typo in test expectations.
​https://bugs.webkit.org/show_bug.cgi?id=172054

Unreviewed test gardening.

  • platform/mac-wk2/TestExpectations:
2:39 PM Changeset in webkit [217684] by Ryan Haddad
  • 2 edits in trunk/LayoutTests

Rebaseline webarchive/loading/mainresource-null-mimetype-crash.html after r217680.

Unreviewed test gardening.

  • webarchive/loading/mainresource-null-mimetype-crash-expected.txt:
2:17 PM Changeset in webkit [217683] by Chris Dumez
  • 2 edits in trunk/Source/WebCore

Unreviewed, rolling out r217647.

No longer needed after r217682

Reverted changeset:

"Avoid iterator invalidation bug in
WebCore::defaultPortForProtocol"
​https://bugs.webkit.org/show_bug.cgi?id=172786
​http://trac.webkit.org/changeset/217647

2:02 PM Changeset in webkit [217682] by Chris Dumez
  • 2 edits in trunk/Source/WebCore

Make WebCore::defaultPortForProtocol() thread-safe
​https://bugs.webkit.org/show_bug.cgi?id=172797

Reviewed by Brent Fulgham.

Make WebCore::defaultPortForProtocol() thread-safe since it is called from the SecurityOrigin
constructor and SecurityOrigin objects are constructed from various threads.

This should not regress the non-testing code paths since we only pay locking costs if
a default port override has been set by the tests.

  • platform/URL.cpp:

(WebCore::defaultPortForProtocolMapLock):
(WebCore::defaultPortForProtocolMapForTesting):
(WebCore::ensureDefaultPortForProtocolMapForTesting):
(WebCore::registerDefaultPortForProtocolForTesting):
(WebCore::clearDefaultPortForProtocolMapForTesting):
(WebCore::defaultPortForProtocol):

1:33 PM Changeset in webkit [217681] by jonlee@apple.com
  • 2 edits in trunk/Source/WebKit2

Rename an experimental feature item
​https://bugs.webkit.org/show_bug.cgi?id=172830

Reviewed by Joseph Pecoraro.

  • Shared/WebPreferencesDefinitions.h:
1:09 PM Changeset in webkit [217680] by Chris Dumez
  • 5 edits in trunk/LayoutTests

webarchive/loading/mainresource-null-mimetype-crash.html / webarchive/loading/missing-data.html are flaky
​https://bugs.webkit.org/show_bug.cgi?id=172823

Reviewed by Alexey Proskuryakov.

Rewrite webarchive/loading/mainresource-null-mimetype-crash.html / webarchive/loading/missing-data.html
to address flakiness. We now navigate a subframe instead of the main frame. We also mark the test as
asynchronous and wait for the subframe to finish loading before calling testRunner.notifyDone().

  • platform/mac/webarchive/loading/mainresource-null-mimetype-crash-expected.txt:
  • webarchive/loading/mainresource-null-mimetype-crash.html:
  • webarchive/loading/missing-data-expected.txt:
  • webarchive/loading/missing-data.html:
12:52 PM Changeset in webkit [217679] by matthew_hanson@apple.com
  • 2 edits in branches/safari-603-branch/Source/WebCore

Cherry-pick r212174. rdar://problem/32080671

12:52 PM Changeset in webkit [217678] by matthew_hanson@apple.com
  • 39 edits
    1 add in branches/safari-603-branch

Cherry-pick r212173. rdar://problem/32080671

12:52 PM Changeset in webkit [217677] by matthew_hanson@apple.com
  • 7 edits in branches/safari-603-branch

Cherry-pick r211501. rdar://problem/32080671

12:51 PM Changeset in webkit [217676] by matthew_hanson@apple.com
  • 8 edits in branches/safari-603-branch/Source/WebCore

Cherry-pick r210226. rdar://problem/32080671

12:51 PM Changeset in webkit [217675] by matthew_hanson@apple.com
  • 5 edits
    1 add in branches/safari-603-branch

Cherry-pick r216459. rdar://problem/32119857

12:46 PM Changeset in webkit [217674] by commit-queue@webkit.org
  • 399 edits
    9 adds
    2 deletes in trunk

[GTK] Bump GTK+ and its dependencies in jhbuild
​https://bugs.webkit.org/show_bug.cgi?id=171918

Patch by Carlos Garcia Campos <​cgarcia@igalia.com> on 2017-06-01
Reviewed by Carlos Alberto Lopez Perez.

Tools:

  • WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:

(WTR::initializeGtkSettings):

  • gtk/jhbuild.modules:
  • gtk/patches/gtk+-configure-fix-detecting-CUPS-2.x.patch: Removed.
  • gtk/patches/librsvg-2.36.1-bump-up-config.guess-to-support-aarch64.patch: Removed.

LayoutTests:

Rebaseline tests for new GTK+ version.

  • platform/gtk/css1/box_properties/acid_test-expected.txt:
  • platform/gtk/css2.1/20110323/replaced-elements-001-expected.png:
  • platform/gtk/css2.1/20110323/replaced-elements-001-expected.txt:
  • platform/gtk/css2.1/t09-c5526c-display-00-e-expected.png:
  • platform/gtk/css2.1/t09-c5526c-display-00-e-expected.txt:
  • platform/gtk/css3/flexbox/button-expected.png:
  • platform/gtk/css3/flexbox/button-expected.txt:
  • platform/gtk/css3/selectors3/html/css3-modsel-161-expected.png:
  • platform/gtk/css3/selectors3/html/css3-modsel-161-expected.txt:
  • platform/gtk/css3/selectors3/html/css3-modsel-19b-expected.png:
  • platform/gtk/css3/selectors3/html/css3-modsel-19b-expected.txt:
  • platform/gtk/css3/selectors3/html/css3-modsel-23-expected.png:
  • platform/gtk/css3/selectors3/html/css3-modsel-23-expected.txt:
  • platform/gtk/css3/selectors3/html/css3-modsel-25-expected.png:
  • platform/gtk/css3/selectors3/html/css3-modsel-25-expected.txt:
  • platform/gtk/css3/selectors3/html/css3-modsel-69-expected.png:
  • platform/gtk/css3/selectors3/html/css3-modsel-69-expected.txt:
  • platform/gtk/css3/selectors3/html/css3-modsel-70-expected.png:
  • platform/gtk/css3/selectors3/html/css3-modsel-70-expected.txt:
  • platform/gtk/css3/selectors3/xhtml/css3-modsel-161-expected.png:
  • platform/gtk/css3/selectors3/xhtml/css3-modsel-161-expected.txt:
  • platform/gtk/css3/selectors3/xhtml/css3-modsel-19b-expected.png:
  • platform/gtk/css3/selectors3/xhtml/css3-modsel-19b-expected.txt:
  • platform/gtk/css3/selectors3/xhtml/css3-modsel-23-expected.png:
  • platform/gtk/css3/selectors3/xhtml/css3-modsel-23-expected.txt:
  • platform/gtk/css3/selectors3/xhtml/css3-modsel-25-expected.png:
  • platform/gtk/css3/selectors3/xhtml/css3-modsel-25-expected.txt:
  • platform/gtk/css3/selectors3/xhtml/css3-modsel-69-expected.png:
  • platform/gtk/css3/selectors3/xhtml/css3-modsel-69-expected.txt:
  • platform/gtk/css3/selectors3/xhtml/css3-modsel-70-expected.png:
  • platform/gtk/css3/selectors3/xhtml/css3-modsel-70-expected.txt:
  • platform/gtk/css3/selectors3/xml/css3-modsel-161-expected.png:
  • platform/gtk/css3/selectors3/xml/css3-modsel-161-expected.txt:
  • platform/gtk/css3/selectors3/xml/css3-modsel-19b-expected.png:
  • platform/gtk/css3/selectors3/xml/css3-modsel-19b-expected.txt:
  • platform/gtk/css3/selectors3/xml/css3-modsel-23-expected.png:
  • platform/gtk/css3/selectors3/xml/css3-modsel-23-expected.txt:
  • platform/gtk/css3/selectors3/xml/css3-modsel-25-expected.png:
  • platform/gtk/css3/selectors3/xml/css3-modsel-25-expected.txt:
  • platform/gtk/css3/selectors3/xml/css3-modsel-69-expected.png:
  • platform/gtk/css3/selectors3/xml/css3-modsel-69-expected.txt:
  • platform/gtk/css3/selectors3/xml/css3-modsel-70-expected.png:
  • platform/gtk/css3/selectors3/xml/css3-modsel-70-expected.txt:
  • platform/gtk/editing/pasteboard/4641033-expected.png:
  • platform/gtk/editing/pasteboard/4641033-expected.txt:
  • platform/gtk/editing/pasteboard/4944770-1-expected.png:
  • platform/gtk/editing/pasteboard/4944770-1-expected.txt:
  • platform/gtk/editing/pasteboard/4944770-2-expected.png:
  • platform/gtk/editing/pasteboard/4944770-2-expected.txt:
  • platform/gtk/editing/selection/3690703-2-expected.png:
  • platform/gtk/editing/selection/3690703-2-expected.txt:
  • platform/gtk/editing/selection/3690703-expected.png:
  • platform/gtk/editing/selection/3690703-expected.txt:
  • platform/gtk/editing/selection/3690719-expected.png:
  • platform/gtk/editing/selection/3690719-expected.txt:
  • platform/gtk/editing/selection/4397952-expected.png:
  • platform/gtk/editing/selection/4397952-expected.txt:
  • platform/gtk/editing/selection/5240265-expected.png:
  • platform/gtk/editing/selection/5240265-expected.txt:
  • platform/gtk/editing/selection/caret-before-select-expected.png:
  • platform/gtk/editing/selection/caret-before-select-expected.txt:
  • platform/gtk/editing/selection/replaced-boundaries-3-expected.png:
  • platform/gtk/editing/selection/replaced-boundaries-3-expected.txt:
  • platform/gtk/editing/selection/select-box-expected.png:
  • platform/gtk/editing/selection/select-box-expected.txt:
  • platform/gtk/editing/selection/select-element-paragraph-boundary-expected.png:
  • platform/gtk/editing/selection/select-element-paragraph-boundary-expected.txt:
  • platform/gtk/editing/selection/selection-button-text-expected.png:
  • platform/gtk/editing/selection/selection-button-text-expected.txt:
  • platform/gtk/fast/block/basic/011-expected.png:
  • platform/gtk/fast/block/basic/011-expected.txt:
  • platform/gtk/fast/block/float/float-avoidance-expected.png:
  • platform/gtk/fast/block/float/float-avoidance-expected.txt:
  • platform/gtk/fast/block/margin-collapse/103-expected.png:
  • platform/gtk/fast/block/margin-collapse/103-expected.txt:
  • platform/gtk/fast/block/positioning/inline-block-relposition-expected.png:
  • platform/gtk/fast/block/positioning/inline-block-relposition-expected.txt:
  • platform/gtk/fast/box-sizing/percentage-height-expected.png:
  • platform/gtk/fast/box-sizing/percentage-height-expected.txt:
  • platform/gtk/fast/css/continuationCrash-expected.png:
  • platform/gtk/fast/css/continuationCrash-expected.txt:
  • platform/gtk/fast/css/focus-ring-exists-for-search-field-expected.png:
  • platform/gtk/fast/css/focus-ring-exists-for-search-field-expected.txt:
  • platform/gtk/fast/css/input-search-padding-expected.png:
  • platform/gtk/fast/css/input-search-padding-expected.txt:
  • platform/gtk/fast/css/margin-top-bottom-dynamic-expected.png:
  • platform/gtk/fast/css/margin-top-bottom-dynamic-expected.txt:
  • platform/gtk/fast/css/non-standard-checkbox-size-expected.png:
  • platform/gtk/fast/css/non-standard-checkbox-size-expected.txt:
  • platform/gtk/fast/css/rtl-ordering-expected.png:
  • platform/gtk/fast/css/rtl-ordering-expected.txt:
  • platform/gtk/fast/css/text-input-with-webkit-border-radius-expected.png:
  • platform/gtk/fast/css/text-input-with-webkit-border-radius-expected.txt:
  • platform/gtk/fast/css/text-overflow-input-expected.png:
  • platform/gtk/fast/css/text-overflow-input-expected.txt:
  • platform/gtk/fast/css/text-transform-select-expected.png:
  • platform/gtk/fast/css/text-transform-select-expected.txt:
  • platform/gtk/fast/dom/HTMLInputElement/input-slider-update-expected.png:
  • platform/gtk/fast/dom/HTMLInputElement/input-slider-update-expected.txt:
  • platform/gtk/fast/dom/HTMLProgressElement/indeterminate-progress-001-expected.txt:
  • platform/gtk/fast/dom/HTMLProgressElement/native-progress-bar-expected.png:
  • platform/gtk/fast/dom/HTMLProgressElement/native-progress-bar-expected.txt:
  • platform/gtk/fast/dom/HTMLProgressElement/progress-bar-value-pseudo-element-expected.png:
  • platform/gtk/fast/dom/HTMLProgressElement/progress-bar-value-pseudo-element-expected.txt:
  • platform/gtk/fast/dom/HTMLProgressElement/progress-element-expected.png:
  • platform/gtk/fast/dom/HTMLProgressElement/progress-element-expected.txt:
  • platform/gtk/fast/dom/HTMLTableColElement/resize-table-using-col-width-expected.png:
  • platform/gtk/fast/dom/HTMLTableColElement/resize-table-using-col-width-expected.txt:
  • platform/gtk/fast/dom/HTMLTextAreaElement/reset-textarea-expected.png:
  • platform/gtk/fast/dom/HTMLTextAreaElement/reset-textarea-expected.txt:
  • platform/gtk/fast/dynamic/positioned-movement-with-positioned-children-expected.txt:
  • platform/gtk/fast/forms/001-expected.png:
  • platform/gtk/fast/forms/001-expected.txt:
  • platform/gtk/fast/forms/003-expected.png:
  • platform/gtk/fast/forms/003-expected.txt:
  • platform/gtk/fast/forms/004-expected.png:
  • platform/gtk/fast/forms/004-expected.txt:
  • platform/gtk/fast/forms/basic-buttons-expected.png:
  • platform/gtk/fast/forms/basic-buttons-expected.txt:
  • platform/gtk/fast/forms/basic-inputs-expected.png:
  • platform/gtk/fast/forms/basic-inputs-expected.txt:
  • platform/gtk/fast/forms/basic-selects-expected.png:
  • platform/gtk/fast/forms/basic-selects-expected.txt:
  • platform/gtk/fast/forms/blankbuttons-expected.png:
  • platform/gtk/fast/forms/blankbuttons-expected.txt:
  • platform/gtk/fast/forms/box-shadow-override-expected.png:
  • platform/gtk/fast/forms/box-shadow-override-expected.txt:
  • platform/gtk/fast/forms/button-align-expected.png:
  • platform/gtk/fast/forms/button-align-expected.txt:
  • platform/gtk/fast/forms/button-cannot-be-nested-expected.png:
  • platform/gtk/fast/forms/button-cannot-be-nested-expected.txt:
  • platform/gtk/fast/forms/button-default-title-expected.png:
  • platform/gtk/fast/forms/button-default-title-expected.txt:
  • platform/gtk/fast/forms/button-generated-content-expected.png:
  • platform/gtk/fast/forms/button-generated-content-expected.txt:
  • platform/gtk/fast/forms/button-inner-block-reuse-expected.png:
  • platform/gtk/fast/forms/button-inner-block-reuse-expected.txt:
  • platform/gtk/fast/forms/button-positioned-expected.png:
  • platform/gtk/fast/forms/button-positioned-expected.txt:
  • platform/gtk/fast/forms/button-sizes-expected.png:
  • platform/gtk/fast/forms/button-sizes-expected.txt:
  • platform/gtk/fast/forms/button-style-color-expected.png:
  • platform/gtk/fast/forms/button-style-color-expected.txt:
  • platform/gtk/fast/forms/button-table-styles-expected.png:
  • platform/gtk/fast/forms/button-table-styles-expected.txt:
  • platform/gtk/fast/forms/button-text-transform-expected.png:
  • platform/gtk/fast/forms/button-text-transform-expected.txt:
  • platform/gtk/fast/forms/button-white-space-expected.png:
  • platform/gtk/fast/forms/button-white-space-expected.txt:
  • platform/gtk/fast/forms/control-clip-expected.png:
  • platform/gtk/fast/forms/control-clip-expected.txt:
  • platform/gtk/fast/forms/control-clip-overflow-expected.png:
  • platform/gtk/fast/forms/control-clip-overflow-expected.txt:
  • platform/gtk/fast/forms/control-restrict-line-height-expected.png:
  • platform/gtk/fast/forms/control-restrict-line-height-expected.txt:
  • platform/gtk/fast/forms/disabled-select-change-index-expected.png:
  • platform/gtk/fast/forms/disabled-select-change-index-expected.txt:
  • platform/gtk/fast/forms/file/file-input-direction-expected.png:
  • platform/gtk/fast/forms/file/file-input-direction-expected.txt:
  • platform/gtk/fast/forms/file/file-input-disabled-expected.png:
  • platform/gtk/fast/forms/file/file-input-disabled-expected.txt:
  • platform/gtk/fast/forms/form-element-geometry-expected.png:
  • platform/gtk/fast/forms/form-element-geometry-expected.txt:
  • platform/gtk/fast/forms/formmove-expected.png:
  • platform/gtk/fast/forms/formmove-expected.txt:
  • platform/gtk/fast/forms/formmove2-expected.png:
  • platform/gtk/fast/forms/formmove2-expected.txt:
  • platform/gtk/fast/forms/formmove3-expected.png:
  • platform/gtk/fast/forms/formmove3-expected.txt:
  • platform/gtk/fast/forms/indeterminate-expected.png:
  • platform/gtk/fast/forms/indeterminate-expected.txt:
  • platform/gtk/fast/forms/input-appearance-height-expected.png:
  • platform/gtk/fast/forms/input-appearance-height-expected.txt:
  • platform/gtk/fast/forms/input-button-sizes-expected.png:
  • platform/gtk/fast/forms/input-button-sizes-expected.txt:
  • platform/gtk/fast/forms/input-first-letter-expected.png:
  • platform/gtk/fast/forms/input-first-letter-expected.txt:
  • platform/gtk/fast/forms/input-number-click-expected.txt: Added.
  • platform/gtk/fast/forms/input-value-expected.png:
  • platform/gtk/fast/forms/input-value-expected.txt:
  • platform/gtk/fast/forms/menulist-deselect-update-expected.png:
  • platform/gtk/fast/forms/menulist-deselect-update-expected.txt:
  • platform/gtk/fast/forms/menulist-narrow-width-expected.png:
  • platform/gtk/fast/forms/menulist-narrow-width-expected.txt:
  • platform/gtk/fast/forms/menulist-no-overflow-expected.png:
  • platform/gtk/fast/forms/menulist-no-overflow-expected.txt:
  • platform/gtk/fast/forms/menulist-restrict-line-height-expected.png:
  • platform/gtk/fast/forms/menulist-restrict-line-height-expected.txt:
  • platform/gtk/fast/forms/menulist-separator-painting-expected.png:
  • platform/gtk/fast/forms/menulist-separator-painting-expected.txt:
  • platform/gtk/fast/forms/menulist-style-color-expected.png:
  • platform/gtk/fast/forms/menulist-style-color-expected.txt:
  • platform/gtk/fast/forms/menulist-width-change-expected.png:
  • platform/gtk/fast/forms/menulist-width-change-expected.txt:
  • platform/gtk/fast/forms/number/number-appearance-rtl-expected.png:
  • platform/gtk/fast/forms/number/number-appearance-rtl-expected.txt:
  • platform/gtk/fast/forms/number/number-appearance-spinbutton-disabled-readonly-expected.png:
  • platform/gtk/fast/forms/number/number-appearance-spinbutton-disabled-readonly-expected.txt:
  • platform/gtk/fast/forms/number/number-appearance-spinbutton-layer-expected.png:
  • platform/gtk/fast/forms/number/number-appearance-spinbutton-layer-expected.txt:
  • platform/gtk/fast/forms/number/number-spinbutton-change-and-input-events-expected.txt: Added.
  • platform/gtk/fast/forms/number/number-spinbutton-click-in-iframe-expected.txt: Added.
  • platform/gtk/fast/forms/number/number-spinbutton-gets-disabled-or-readonly-expected.txt: Added.
  • platform/gtk/fast/forms/option-script-expected.png:
  • platform/gtk/fast/forms/option-script-expected.txt:
  • platform/gtk/fast/forms/option-strip-whitespace-expected.png:
  • platform/gtk/fast/forms/option-strip-whitespace-expected.txt:
  • platform/gtk/fast/forms/option-text-clip-expected.png:
  • platform/gtk/fast/forms/option-text-clip-expected.txt:
  • platform/gtk/fast/forms/placeholder-position-expected.png:
  • platform/gtk/fast/forms/placeholder-position-expected.txt:
  • platform/gtk/fast/forms/placeholder-pseudo-style-expected.png:
  • platform/gtk/fast/forms/placeholder-pseudo-style-expected.txt:
  • platform/gtk/fast/forms/range/input-appearance-range-expected.png:
  • platform/gtk/fast/forms/range/input-appearance-range-expected.txt:
  • platform/gtk/fast/forms/range/slider-padding-expected.png:
  • platform/gtk/fast/forms/range/slider-padding-expected.txt:
  • platform/gtk/fast/forms/range/slider-thumb-shared-style-expected.png:
  • platform/gtk/fast/forms/range/slider-thumb-shared-style-expected.txt:
  • platform/gtk/fast/forms/range/slider-transformed-expected.txt:
  • platform/gtk/fast/forms/range/thumbslider-no-parent-slider-expected.png:
  • platform/gtk/fast/forms/range/thumbslider-no-parent-slider-expected.txt:
  • platform/gtk/fast/forms/search-cancel-button-style-sharing-expected.png:
  • platform/gtk/fast/forms/search-cancel-button-style-sharing-expected.txt:
  • platform/gtk/fast/forms/search-display-none-cancel-button-expected.png:
  • platform/gtk/fast/forms/search-display-none-cancel-button-expected.txt:
  • platform/gtk/fast/forms/search-input-rtl-expected.png:
  • platform/gtk/fast/forms/search-input-rtl-expected.txt: Added.
  • platform/gtk/fast/forms/search-rtl-expected.png:
  • platform/gtk/fast/forms/search-rtl-expected.txt:
  • platform/gtk/fast/forms/search-styled-expected.png:
  • platform/gtk/fast/forms/search-styled-expected.txt:
  • platform/gtk/fast/forms/search/search-size-with-decorations-expected.png:
  • platform/gtk/fast/forms/search/search-size-with-decorations-expected.txt:
  • platform/gtk/fast/forms/searchfield-heights-expected.png:
  • platform/gtk/fast/forms/searchfield-heights-expected.txt:
  • platform/gtk/fast/forms/select-align-expected.png:
  • platform/gtk/fast/forms/select-align-expected.txt:
  • platform/gtk/fast/forms/select-background-none-expected.png:
  • platform/gtk/fast/forms/select-background-none-expected.txt:
  • platform/gtk/fast/forms/select-baseline-expected.png:
  • platform/gtk/fast/forms/select-baseline-expected.txt:
  • platform/gtk/fast/forms/select-change-listbox-to-popup-expected.png:
  • platform/gtk/fast/forms/select-change-listbox-to-popup-expected.txt:
  • platform/gtk/fast/forms/select-dirty-parent-pref-widths-expected.png:
  • platform/gtk/fast/forms/select-dirty-parent-pref-widths-expected.txt:
  • platform/gtk/fast/forms/select-disabled-appearance-expected.png:
  • platform/gtk/fast/forms/select-disabled-appearance-expected.txt:
  • platform/gtk/fast/forms/select-element-focus-ring-expected.png: Added.
  • platform/gtk/fast/forms/select-element-focus-ring-expected.txt:
  • platform/gtk/fast/forms/select-initial-position-expected.png:
  • platform/gtk/fast/forms/select-initial-position-expected.txt:
  • platform/gtk/fast/forms/select-non-native-rendering-direction-expected.png: Added.
  • platform/gtk/fast/forms/select-non-native-rendering-direction-expected.txt: Added.
  • platform/gtk/fast/forms/select-selected-expected.png:
  • platform/gtk/fast/forms/select-selected-expected.txt:
  • platform/gtk/fast/forms/select-style-expected.png:
  • platform/gtk/fast/forms/select-style-expected.txt:
  • platform/gtk/fast/forms/select-visual-hebrew-expected.png:
  • platform/gtk/fast/forms/select-visual-hebrew-expected.txt:
  • platform/gtk/fast/forms/select-writing-direction-natural-expected.png:
  • platform/gtk/fast/forms/select-writing-direction-natural-expected.txt:
  • platform/gtk/fast/forms/select/optgroup-rendering-expected.png:
  • platform/gtk/fast/forms/select/optgroup-rendering-expected.txt:
  • platform/gtk/fast/forms/selectlist-minsize-expected.png:
  • platform/gtk/fast/forms/selectlist-minsize-expected.txt:
  • platform/gtk/fast/forms/stuff-on-my-optgroup-expected.png:
  • platform/gtk/fast/forms/stuff-on-my-optgroup-expected.txt:
  • platform/gtk/fast/forms/targeted-frame-submission-expected.png:
  • platform/gtk/fast/forms/targeted-frame-submission-expected.txt:
  • platform/gtk/fast/forms/validation-message-appearance-expected.png:
  • platform/gtk/fast/forms/validation-message-appearance-expected.txt:
  • platform/gtk/fast/html/details-replace-summary-child-expected.png:
  • platform/gtk/fast/html/details-replace-summary-child-expected.txt:
  • platform/gtk/fast/html/details-replace-text-expected.png:
  • platform/gtk/fast/html/details-replace-text-expected.txt:
  • platform/gtk/fast/html/keygen-expected.png:
  • platform/gtk/fast/html/keygen-expected.txt:
  • platform/gtk/fast/inline/positionedLifetime-expected.png:
  • platform/gtk/fast/inline/positionedLifetime-expected.txt:
  • platform/gtk/fast/invalid/014-expected.png:
  • platform/gtk/fast/invalid/014-expected.txt:
  • platform/gtk/fast/overflow/scroll-nested-positioned-layer-in-overflow-expected.png:
  • platform/gtk/fast/overflow/scroll-nested-positioned-layer-in-overflow-expected.txt:
  • platform/gtk/fast/overflow/scrollRevealButton-expected.png:
  • platform/gtk/fast/overflow/scrollRevealButton-expected.txt:
  • platform/gtk/fast/parser/bad-xml-slash-expected.png:
  • platform/gtk/fast/parser/bad-xml-slash-expected.txt:
  • platform/gtk/fast/parser/document-write-option-expected.png:
  • platform/gtk/fast/parser/document-write-option-expected.txt:
  • platform/gtk/fast/repaint/search-field-cancel-expected.png:
  • platform/gtk/fast/repaint/search-field-cancel-expected.txt:
  • platform/gtk/fast/repaint/slider-thumb-drag-release-expected.png:
  • platform/gtk/fast/repaint/slider-thumb-drag-release-expected.txt:
  • platform/gtk/fast/replaced/replaced-breaking-expected.png:
  • platform/gtk/fast/replaced/replaced-breaking-expected.txt:
  • platform/gtk/fast/replaced/replaced-breaking-mixture-expected.png:
  • platform/gtk/fast/replaced/replaced-breaking-mixture-expected.txt:
  • platform/gtk/fast/replaced/three-selects-break-expected.png:
  • platform/gtk/fast/replaced/three-selects-break-expected.txt:
  • platform/gtk/fast/replaced/width100percent-button-expected.png:
  • platform/gtk/fast/replaced/width100percent-button-expected.txt:
  • platform/gtk/fast/replaced/width100percent-menulist-expected.png:
  • platform/gtk/fast/replaced/width100percent-menulist-expected.txt:
  • platform/gtk/fast/replaced/width100percent-searchfield-expected.png:
  • platform/gtk/fast/replaced/width100percent-searchfield-expected.txt:
  • platform/gtk/fast/scrolling/overflow-scrollable-after-back-expected.txt: Added.
  • platform/gtk/fast/table/append-cells2-expected.png:
  • platform/gtk/fast/table/append-cells2-expected.txt:
  • platform/gtk/fast/table/remove-td-display-none-expected.png:
  • platform/gtk/fast/table/remove-td-display-none-expected.txt:
  • platform/gtk/fast/text/international/bidi-menulist-expected.png:
  • platform/gtk/fast/text/international/bidi-menulist-expected.txt:
  • platform/gtk/fast/text/international/hindi-spacing-expected.png:
  • platform/gtk/fast/text/international/hindi-spacing-expected.txt:
  • platform/gtk/fast/text/international/pop-up-button-text-alignment-and-direction-expected.png:
  • platform/gtk/fast/text/international/pop-up-button-text-alignment-and-direction-expected.txt:
  • platform/gtk/fast/text/textIteratorNilRenderer-expected.png:
  • platform/gtk/fast/text/textIteratorNilRenderer-expected.txt:
  • platform/gtk/fast/text/whitespace/normal-after-nowrap-breaking-expected.png:
  • platform/gtk/fast/text/whitespace/normal-after-nowrap-breaking-expected.txt:
  • platform/gtk/http/tests/navigation/javascriptlink-frames-expected.png:
  • platform/gtk/http/tests/navigation/javascriptlink-frames-expected.txt:
  • platform/gtk/svg/custom/foreign-object-skew-expected.png:
  • platform/gtk/svg/custom/foreign-object-skew-expected.txt:
  • platform/gtk/svg/custom/inline-svg-in-xhtml-expected.png:
  • platform/gtk/svg/custom/inline-svg-in-xhtml-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug1188-expected.png:
  • platform/gtk/tables/mozilla/bugs/bug1188-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug1318-expected.png:
  • platform/gtk/tables/mozilla/bugs/bug1318-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug138725-expected.png:
  • platform/gtk/tables/mozilla/bugs/bug138725-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug18359-expected.png:
  • platform/gtk/tables/mozilla/bugs/bug18359-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug2479-2-expected.png:
  • platform/gtk/tables/mozilla/bugs/bug2479-2-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug2479-3-expected.png:
  • platform/gtk/tables/mozilla/bugs/bug2479-3-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug2479-4-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug26178-expected.png:
  • platform/gtk/tables/mozilla/bugs/bug26178-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug28928-expected.png:
  • platform/gtk/tables/mozilla/bugs/bug28928-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug29326-expected.png:
  • platform/gtk/tables/mozilla/bugs/bug29326-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug33855-expected.png:
  • platform/gtk/tables/mozilla/bugs/bug33855-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug39209-expected.png:
  • platform/gtk/tables/mozilla/bugs/bug39209-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug4382-expected.png:
  • platform/gtk/tables/mozilla/bugs/bug4382-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug4429-expected.png:
  • platform/gtk/tables/mozilla/bugs/bug4429-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug44505-expected.png:
  • platform/gtk/tables/mozilla/bugs/bug44505-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug4527-expected.png:
  • platform/gtk/tables/mozilla/bugs/bug4527-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug46368-1-expected.png:
  • platform/gtk/tables/mozilla/bugs/bug46368-1-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug46368-2-expected.png:
  • platform/gtk/tables/mozilla/bugs/bug46368-2-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug51037-expected.png:
  • platform/gtk/tables/mozilla/bugs/bug51037-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug51727-expected.png:
  • platform/gtk/tables/mozilla/bugs/bug51727-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug52505-expected.png:
  • platform/gtk/tables/mozilla/bugs/bug52505-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug52506-expected.png:
  • platform/gtk/tables/mozilla/bugs/bug52506-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug60749-expected.png:
  • platform/gtk/tables/mozilla/bugs/bug60749-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug68912-expected.png:
  • platform/gtk/tables/mozilla/bugs/bug68912-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug7342-expected.png:
  • platform/gtk/tables/mozilla/bugs/bug7342-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug92647-2-expected.png:
  • platform/gtk/tables/mozilla/bugs/bug92647-2-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug96334-expected.png:
  • platform/gtk/tables/mozilla/bugs/bug96334-expected.txt:
  • platform/gtk/tables/mozilla/collapsing_borders/bug41262-4-expected.png:
  • platform/gtk/tables/mozilla/collapsing_borders/bug41262-4-expected.txt:
  • platform/gtk/tables/mozilla/core/margins-expected.png:
  • platform/gtk/tables/mozilla/core/margins-expected.txt:
  • platform/gtk/tables/mozilla/dom/tableDom-expected.png:
  • platform/gtk/tables/mozilla/dom/tableDom-expected.txt:
  • platform/gtk/tables/mozilla/other/move_row-expected.png:
  • platform/gtk/tables/mozilla/other/move_row-expected.txt:
  • platform/gtk/tables/mozilla_expected_failures/bugs/bug1725-expected.png:
  • platform/gtk/tables/mozilla_expected_failures/bugs/bug1725-expected.txt:
  • platform/gtk/tables/mozilla_expected_failures/bugs/bug2479-5-expected.png:
  • platform/gtk/tables/mozilla_expected_failures/bugs/bug2479-5-expected.txt:
  • platform/gtk/tables/mozilla_expected_failures/bugs/bug58402-2-expected.png:
  • platform/gtk/tables/mozilla_expected_failures/bugs/bug58402-2-expected.txt:
  • platform/gtk/tables/mozilla_expected_failures/collapsing_borders/bug41262-5-expected.png:
  • platform/gtk/tables/mozilla_expected_failures/collapsing_borders/bug41262-5-expected.txt:
  • platform/gtk/tables/mozilla_expected_failures/collapsing_borders/bug41262-6-expected.png:
  • platform/gtk/tables/mozilla_expected_failures/collapsing_borders/bug41262-6-expected.txt:
  • platform/gtk/tables/mozilla_expected_failures/core/captions1-expected.png:
  • platform/gtk/tables/mozilla_expected_failures/core/captions1-expected.txt:
  • platform/gtk/tables/mozilla_expected_failures/core/captions2-expected.png:
  • platform/gtk/tables/mozilla_expected_failures/core/captions2-expected.txt:
  • platform/gtk/transforms/2d/zoom-menulist-expected.png:
  • platform/gtk/transforms/2d/zoom-menulist-expected.txt:
12:34 PM Changeset in webkit [217673] by commit-queue@webkit.org
  • 2 edits
    1 add in trunk/Tools

[GTK] Bump wayland and weston in jhbuild
​https://bugs.webkit.org/show_bug.cgi?id=171921

Patch by Carlos Garcia Campos <​cgarcia@igalia.com> on 2017-06-01
Reviewed by Carlos Alberto Lopez Perez.

  • gtk/jhbuild.modules:
  • gtk/patches/weston-libweston-include-weston-egl-ext.h-in-drm-x11-and-wa.patch: Added.
12:14 PM Changeset in webkit [217672] by aestes@apple.com
  • 12 edits in trunk

REGRESSION (r217626): ENABLE_APPLE_PAY_SESSION_V3 was disabled by mistake
​https://bugs.webkit.org/show_bug.cgi?id=172828

Reviewed by Beth Dakin.

Source/JavaScriptCore:

  • Configurations/FeatureDefines.xcconfig:

Source/WebCore:

  • Configurations/FeatureDefines.xcconfig:

Source/WebCore/PAL:

  • Configurations/FeatureDefines.xcconfig:

Source/WebKit/mac:

  • Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

  • Configurations/FeatureDefines.xcconfig:

Tools:

  • TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
12:06 PM Changeset in webkit [217671] by Jonathan Bedard
  • 2 edits in trunk/Tools

webkitpy: Remove unneeded simulator teardown
​https://bugs.webkit.org/show_bug.cgi?id=171891

Reviewed by Aakash Jain.

  • Scripts/webkitpy/port/ios_simulator.py:

(IOSSimulatorPort.clean_up_test_run): Remove FIFO deletion since TCP is used
for communication between Python and WebKitTestRunner/DumpRenderTree.

11:43 AM Changeset in webkit [217670] by Ryan Haddad
  • 2 edits in trunk/LayoutTests

Mark two webrtc tests as flaky.

Unreviewed test gardening.

11:28 AM Changeset in webkit [217669] by keith_miller@apple.com
  • 24 edits
    1 copy in trunk

Undo rollout in r217638 with bug fix
​https://bugs.webkit.org/show_bug.cgi?id=172824

Unreviewed, reland patch with unused set_state code removed.

Source/JavaScriptCore:

  • API/tests/ExecutionTimeLimitTest.cpp:

(dispatchTermitateCallback):
(testExecutionTimeLimit):

  • runtime/JSLock.cpp:

(JSC::JSLock::didAcquireLock):

  • runtime/Options.cpp:

(JSC::overrideDefaults):
(JSC::Options::initialize):

  • runtime/Options.h:
  • runtime/VMTraps.cpp:

(JSC::SignalContext::SignalContext):
(JSC::SignalContext::adjustPCToPointToTrappingInstruction):
(JSC::installSignalHandler):
(JSC::VMTraps::SignalSender::send):

  • tools/SigillCrashAnalyzer.cpp:

(JSC::SignalContext::SignalContext):
(JSC::SignalContext::dump):
(JSC::installCrashHandler):

  • wasm/WasmBBQPlan.cpp:

(JSC::Wasm::BBQPlan::compileFunctions):

  • wasm/WasmFaultSignalHandler.cpp:

(JSC::Wasm::trapHandler):
(JSC::Wasm::enableFastMemory):

  • wasm/WasmMachineThreads.cpp:

(JSC::Wasm::resetInstructionCacheOnAllThreads):

Source/WTF:

  • Configurations/WTF.xcconfig:
  • WTF.xcodeproj/project.pbxproj:
  • wtf/Platform.h:
  • wtf/PlatformRegisters.h:

(WTF::registersFromUContext):

  • wtf/StackBounds.h:

(WTF::StackBounds::StackBounds):

  • wtf/ThreadHolder.cpp:

(WTF::ThreadHolder::~ThreadHolder):

  • wtf/ThreadMessage.cpp:

(WTF::sendMessageUsingSignal):
(WTF::sendMessageUsingMach):
(WTF::deliverMessagesUsingMach):
(WTF::sendMessageScoped):

  • wtf/ThreadMessage.h:

(WTF::sendMessage):

  • wtf/Threading.h:

(WTF::Thread::machThread):

  • wtf/mac/MachExceptions.defs: Copied from Source/WTF/wtf/ThreadMessage.h.
  • wtf/threads/Signals.cpp:

(WTF::startMachExceptionHandlerThread):
(WTF::fromMachException):
(WTF::toMachMask):
(WTF::handleSignalsWithMach):
(WTF::setExceptionPorts):
(WTF::activeThreads):
(WTF::registerThreadForMachExceptionHandling):
(WTF::unregisterThreadForMachExceptionHandling):
(WTF::installSignalHandler):
(WTF::jscSignalHandler):

  • wtf/threads/Signals.h:

Tools:

  • TestWebKitAPI/Tests/WTF/ThreadMessages.cpp:

(runThreadMessageTest):
(TEST):

11:21 AM Changeset in webkit [217668] by Matt Lewis
  • 2 edits in trunk/LayoutTests

Adjusted loader/stateobjects/replacestate-size-iframe.html Test Expectations.
​https://bugs.webkit.org/show_bug.cgi?id=172054

Unreviewed test gardening.

  • platform/mac-wk2/TestExpectations:
11:17 AM Changeset in webkit [217667] by Matt Lewis
  • 2 edits in trunk/LayoutTests

Marked loader/stateobjects/replacestate-size-iframe.html as flaky.
​https://bugs.webkit.org/show_bug.cgi?id=172054

Unreviewed test gardening.

  • platform/mac-wk2/TestExpectations:
11:04 AM Changeset in webkit [217666] by fred.wang@free.fr
  • 3 edits in trunk/Source/WebCore

ScrollingCoordinator::updateSynchronousScrollingReasons should consider non-main frames
​https://bugs.webkit.org/show_bug.cgi?id=172806

Patch by Frederic Wang <​fwang@igalia.com> on 2017-06-01
Reviewed by Simon Fraser.

Currently, the scrolling coordinator does not manage scrolling of frames other than the main
one (bugs 171667 and 149264) and so ScrollingCoordinator::updateSynchronousScrollingReasons
is only relevant for the main frame. This commit refactors a bit ScrollingCoordinator so that
updateSynchronousScrollingReasons is considered for all the frames whose scrolling is
coordinated by the ScrollingCoordinator so non-main frames will be considered in the future.

No new tests, behavior is unchanged for now.

  • page/scrolling/ScrollingCoordinator.cpp:

(WebCore::ScrollingCoordinator::updateSynchronousScrollingReasons): Add an ASSERT to ensure
that this function is only called for frame whose scrolling is coordinated by this class.
(WebCore::ScrollingCoordinator::updateSynchronousScrollingReasonsForAllFrames): Introduce a
new function to update synchronous scrolling for subframes whose scrolling is coordinated by
this class.
(WebCore::ScrollingCoordinator::setForceSynchronousScrollLayerPositionUpdates): Update
synchronous scrolling reason for non-main frames too.
(WebCore::ScrollingCoordinator::replaySessionStateDidChange): Update synchronous scrolling
reason for non-main frames too.

  • page/scrolling/ScrollingCoordinator.h: Define updateSynchronousScrollingReasonsForAllFrames
11:01 AM Changeset in webkit [217665] by Chris Dumez
  • 2 edits in trunk/Source/WebKit2

[WK2] Update plugin process sandbox profile for flash plugin on HBONow
​https://bugs.webkit.org/show_bug.cgi?id=172820
<rdar://problem/32513297>

Reviewed by Brent Fulgham.

Relax the IOKit whitelist to silence sandbox violations by Flash plugin on
HBONow.

  • PluginProcess/mac/com.apple.WebKit.plugin-common.sb.in:
10:59 AM Changeset in webkit [217664] by aestes@apple.com
  • 4 edits in trunk/Source

[Cocoa] Upstream support for JCB as a supported payment network
​https://bugs.webkit.org/show_bug.cgi?id=172819

Reviewed by Tim Horton.

Source/WebCore:

  • Modules/applepay/PaymentRequest.cpp:

(WebCore::PaymentRequest::isValidSupportedNetwork):
(WebCore::isAdditionalValidSupportedNetwork): Deleted.

Source/WebKit2:

  • UIProcess/ApplePay/cocoa/WebPaymentCoordinatorProxyCocoa.mm:

(WebKit::toSupportedNetwork):
(WebKit::toAdditionalSupportedNetwork): Deleted.

10:42 AM Changeset in webkit [217663] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

[JSC][MIPS] SamplingProfiler::timerLoop() sleeps for 4000+ seconds
​https://bugs.webkit.org/show_bug.cgi?id=172800

Patch by Guillaume Emont <​guijemont@igalia.com> on 2017-06-01
Reviewed by Saam Barati.

This fixes a static_cast<uint64_t> by making it a cast to int64_t
instead, which looks like the original intent. This fixes the
sampling-profiler tests in JSTests/stress.

  • runtime/SamplingProfiler.cpp:

(JSC::SamplingProfiler::timerLoop):

10:04 AM Changeset in webkit [217662] by Ryan Haddad
  • 3 edits in branches/safari-604.1.21-branch/Tools

Merge r217658.

10:04 AM Changeset in webkit [217661] by Chris Dumez
  • 2 edits in trunk/Source/WebCore

Unreviewed, rolling out r217660.

This should not have landed given that the new assertion is
hit on debug EWS bots

Reverted changeset:

"Make sure we don't access WebCore::defaultPortForProtocol
from non-main thread"
​https://bugs.webkit.org/show_bug.cgi?id=172797
​http://trac.webkit.org/changeset/217660

9:54 AM Changeset in webkit [217660] by Brent Fulgham
  • 2 edits in trunk/Source/WebCore

Make sure we don't access WebCore::defaultPortForProtocol from non-main thread
​https://bugs.webkit.org/show_bug.cgi?id=172797

Reviewed by Alex Christensen.

  • platform/URL.cpp:

(WebCore::defaultPortForProtocol): Add an assertion to make sure we don't access the
DefaultPortForProtocolMapForTesting from multiple threads.

9:38 AM Changeset in webkit [217659] by commit-queue@webkit.org
  • 5 edits in trunk/LayoutTests

Rebaseline two media/modern-media-controls/macos-fullscreen-media-controls tests
​https://bugs.webkit.org/show_bug.cgi?id=172810

Patch by Antoine Quint <Antoine Quint> on 2017-06-01
Reviewed by Antoine Quint.

We need to rebaseline a couple of tests to account for the width change for the left button container in fullscreen.

  • media/modern-media-controls/macos-fullscreen-media-controls/macos-fullscreen-media-controls-drag-is-prevented-over-button-expected.txt:
  • media/modern-media-controls/macos-fullscreen-media-controls/macos-fullscreen-media-controls-drag-is-prevented-over-button.html:
  • media/modern-media-controls/macos-fullscreen-media-controls/macos-fullscreen-media-controls-drag-expected.txt:
  • media/modern-media-controls/macos-fullscreen-media-controls/macos-fullscreen-media-controls-drag.html:
9:35 AM Changeset in webkit [217658] by Jonathan Bedard
  • 3 edits in trunk/Tools

webkitpy: Do not send 0 or -1 as a pid to kill_process
​https://bugs.webkit.org/show_bug.cgi?id=172818

Reviewed by Darin Adler.

Sending a signal to process 0 will result in all processes in the group receiving
the signal. Sending a signal to process -1 will result in all non-system processes
receiving the signal. Both Executive.kill_process and Executive.check_running_pid
should consider these cases

  • Scripts/webkitpy/common/system/executive.py:

(Executive.kill_process): Throw exception if pid is undefined, 0 or negative.
(Executive.check_running_pid): An undefined pid, pid 0 or a negative pid will
never be running, although os.kill may succeed.

  • Scripts/webkitpy/port/simulator_process.py:

(SimulatorProcess.stop): Do not kill process if it is undefined.

9:22 AM Changeset in webkit [217657] by magomez@igalia.com
  • 2 edits in trunk/LayoutTests

Unreviewed GTK+ gardening. Update expectations of several tests failing after r217651.

  • platform/gtk/TestExpectations:
8:39 AM Changeset in webkit [217656] by commit-queue@webkit.org
  • 1 edit
    2 deletes in trunk/LayoutTests

Remove media/modern-media-controls/ios-inline-media-controls/ios-inline-media-controls-audio-background.html
​https://bugs.webkit.org/show_bug.cgi?id=172808

Patch by Antoine Quint <Antoine Quint> on 2017-06-01
Reviewed by Antoine Quint.

This test no longer applies, there is no iOS-specific styling for <audio> elements anymore.

  • media/modern-media-controls/ios-inline-media-controls/ios-inline-media-controls-audio-background.html: Removed.
  • media/modern-media-controls/ios-inline-media-controls/ios-inline-media-controls-audio-background-expected.txt: Removed.
8:04 AM Changeset in webkit [217655] by gskachkov@gmail.com
  • 1 edit
    1 add in trunk/JSTests

Class Proxy can't be extended
​https://bugs.webkit.org/show_bug.cgi?id=169040

Reviewed by Saam Barati.

Adding tests that check correctness of Proxy to ES6 class
Bug is already fixed in ​https://bugs.webkit.org/show_bug.cgi?id=164849

  • stress/proxy-class.js: Added.

(assert):
(throw.new.Error.SuperClass):
(throw.new.Error.A):
(throw.new.Error):

8:00 AM Changeset in webkit [217654] by Ryan Haddad
  • 2 edits in trunk/LayoutTests

Mark imported/w3c/web-platform-tests/css/selectors4/focus-display-none-001.html and focus-within-display-none-001.html as flaky failures
​https://bugs.webkit.org/show_bug.cgi?id=172807

Unreviewed test gardening.

  • platform/mac-wk1/TestExpectations:
7:43 AM Changeset in webkit [217653] by commit-queue@webkit.org
  • 3 edits in trunk/LayoutTests

Rebaseline media/modern-media-controls/audio/audio-controls-metrics.html
​https://bugs.webkit.org/show_bug.cgi?id=172715

Patch by Antoine Quint <Antoine Quint> on 2017-06-01
Reviewed by Antoine Quint.

We update the expectations for <audio> metrics to match the latest implementation.

  • media/modern-media-controls/audio/audio-controls-metrics-expected.txt:
  • media/modern-media-controls/audio/audio-controls-metrics.html:
7:14 AM Changeset in webkit [217652] by jfernandez@igalia.com
  • 10 edits
    1 copy
    234 adds
    133 deletes in trunk/LayoutTests/imported/w3c

[css-grid] Update W3C web platform tests for the CSS Grid Layout feature
​https://bugs.webkit.org/show_bug.cgi?id=172783

Reviewed by Manuel Rego Casasnovas.

Imported the last CSS Grid Layout web platform tests (ed50cf49ed).

  • resources/import-expectations.json:
  • web-platform-tests/css/css-grid-1/OWNERS:
  • web-platform-tests/css/css-grid-1/alignment/grid-self-alignment-stretch-001-expected.txt: Added.
  • web-platform-tests/css/css-grid-1/alignment/grid-self-alignment-stretch-001.html: Added.
  • web-platform-tests/css/css-grid-1/alignment/grid-self-alignment-stretch-002-expected.txt: Added.
  • web-platform-tests/css/css-grid-1/alignment/grid-self-alignment-stretch-002.html: Added.
  • web-platform-tests/css/css-grid-1/alignment/grid-self-alignment-stretch-003-expected.txt: Added.
  • web-platform-tests/css/css-grid-1/alignment/grid-self-alignment-stretch-003.html: Added.
  • web-platform-tests/css/css-grid-1/alignment/grid-self-alignment-stretch-004-expected.txt: Added.
  • web-platform-tests/css/css-grid-1/alignment/grid-self-alignment-stretch-004.html: Added.
  • web-platform-tests/css/css-grid-1/alignment/grid-self-alignment-stretch-005-expected.txt: Added.
  • web-platform-tests/css/css-grid-1/alignment/grid-self-alignment-stretch-005.html: Added.
  • web-platform-tests/css/css-grid-1/alignment/grid-self-alignment-stretch-006-expected.txt: Added.
  • web-platform-tests/css/css-grid-1/alignment/grid-self-alignment-stretch-006.html: Added.
  • web-platform-tests/css/css-grid-1/alignment/grid-self-alignment-stretch-007-expected.txt: Added.
  • web-platform-tests/css/css-grid-1/alignment/grid-self-alignment-stretch-007.html: Added.
  • web-platform-tests/css/css-grid-1/alignment/grid-self-alignment-stretch-008-expected.txt: Added.
  • web-platform-tests/css/css-grid-1/alignment/grid-self-alignment-stretch-008.html: Added.
  • web-platform-tests/css/css-grid-1/alignment/grid-self-alignment-stretch-009-expected.txt: Added.
  • web-platform-tests/css/css-grid-1/alignment/grid-self-alignment-stretch-009.html: Added.
  • web-platform-tests/css/css-grid-1/alignment/grid-self-alignment-stretch-010-expected.txt: Added.
  • web-platform-tests/css/css-grid-1/alignment/grid-self-alignment-stretch-010.html: Added.
  • web-platform-tests/css/css-grid-1/alignment/grid-self-alignment-stretch-011-expected.txt: Added.
  • web-platform-tests/css/css-grid-1/alignment/grid-self-alignment-stretch-011.html: Added.
  • web-platform-tests/css/css-grid-1/alignment/grid-self-alignment-stretch-012-expected.txt: Added.
  • web-platform-tests/css/css-grid-1/alignment/grid-self-alignment-stretch-012.html: Added.
  • web-platform-tests/css/css-grid-1/alignment/grid-self-alignment-stretch-013-expected.txt: Added.
  • web-platform-tests/css/css-grid-1/alignment/grid-self-alignment-stretch-013.html: Added.
  • web-platform-tests/css/css-grid-1/alignment/grid-self-alignment-stretch-014-expected.txt: Added.
  • web-platform-tests/css/css-grid-1/alignment/grid-self-alignment-stretch-014.html: Added.
  • web-platform-tests/css/css-grid-1/alignment/grid-self-alignment-stretch-015-expected.txt: Added.
  • web-platform-tests/css/css-grid-1/alignment/grid-self-alignment-stretch-015.html: Added.
  • web-platform-tests/css/css-grid-1/alignment/grid-self-alignment-stretch-016-expected.txt: Added.
  • web-platform-tests/css/css-grid-1/alignment/grid-self-alignment-stretch-016.html: Added.
  • web-platform-tests/css/css-grid-1/alignment/grid-self-alignment-stretch-vertical-lr-001-expected.txt: Added.
  • web-platform-tests/css/css-grid-1/alignment/grid-self-alignment-stretch-vertical-lr-001.html: Added.
  • web-platform-tests/css/css-grid-1/alignment/grid-self-alignment-stretch-vertical-lr-002-expected.txt: Added.
  • web-platform-tests/css/css-grid-1/alignment/grid-self-alignment-stretch-vertical-lr-002.html: Added.
  • web-platform-tests/css/css-grid-1/alignment/grid-self-alignment-stretch-vertical-lr-003-expected.txt: Added.
  • web-platform-tests/css/css-grid-1/alignment/grid-self-alignment-stretch-vertical-lr-003.html: Added.
  • web-platform-tests/css/css-grid-1/alignment/grid-self-alignment-stretch-vertical-lr-004-expected.txt: Added.
  • web-platform-tests/css/css-grid-1/alignment/grid-self-alignment-stretch-vertical-lr-004.html: Added.
  • web-platform-tests/css/css-grid-1/alignment/grid-self-alignment-stretch-vertical-lr-005-expected.txt: Added.
  • web-platform-tests/css/css-grid-1/alignment/grid-self-alignment-stretch-vertical-lr-005.html: Added.
  • web-platform-tests/css/css-grid-1/alignment/grid-self-alignment-stretch-vertical-lr-006-expected.txt: Added.
  • web-platform-tests/css/css-grid-1/alignment/grid-self-alignment-stretch-vertical-lr-006.html: Added.
  • web-platform-tests/css/css-grid-1/alignment/grid-self-alignment-stretch-vertical-lr-007-expected.txt: Added.
  • web-platform-tests/css/css-grid-1/alignment/grid-self-alignment-stretch-vertical-lr-007.html: Added.
  • web-platform-tests/css/css-grid-1/alignment/grid-self-alignment-stretch-vertical-lr-008-expected.txt: Added.
  • web-platform-tests/css/css-grid-1/alignment/grid-self-alignment-stretch-vertical-lr-008.html: Added.
  • web-platform-tests/css/css-grid-1/alignment/grid-self-alignment-stretch-vertical-lr-009-expected.txt: Added.
  • web-platform-tests/css/css-grid-1/alignment/grid-self-alignment-stretch-vertical-lr-009.html: Added.
  • web-platform-tests/css/css-grid-1/alignment/grid-self-alignment-stretch-vertical-lr-010-expected.txt: Added.
  • web-platform-tests/css/css-grid-1/alignment/grid-self-alignment-stretch-vertical-lr-010.html: Added.
  • web-platform-tests/css/css-grid-1/alignment/grid-self-alignment-stretch-vertical-lr-011-expected.txt: Added.
  • web-platform-tests/css/css-grid-1/alignment/grid-self-alignment-stretch-vertical-lr-011.html: Added.
  • web-platform-tests/css/css-grid-1/alignment/grid-self-alignment-stretch-vertical-lr-012-expected.txt: Added.
  • web-platform-tests/css/css-grid-1/alignment/grid-self-alignment-stretch-vertical-lr-012.html: Added.
  • web-platform-tests/css/css-grid-1/alignment/grid-self-alignment-stretch-vertical-lr-013-expected.txt: Added.
  • web-platform-tests/css/css-grid-1/alignment/grid-self-alignment-stretch-vertical-lr-013.html: Added.
  • web-platform-tests/css/css-grid-1/alignment/grid-self-alignment-stretch-vertical-lr-014-expected.txt: Added.
  • web-platform-tests/css/css-grid-1/alignment/grid-self-alignment-stretch-vertical-lr-014.html: Added.
  • web-platform-tests/css/css-grid-1/alignment/grid-self-alignment-stretch-vertical-lr-015-expected.txt: Added.
  • web-platform-tests/css/css-grid-1/alignment/grid-self-alignment-stretch-vertical-lr-015.html: Added.
  • web-platform-tests/css/css-grid-1/alignment/grid-self-alignment-stretch-vertical-lr-016-expected.txt: Added.
  • web-platform-tests/css/css-grid-1/alignment/grid-self-alignment-stretch-vertical-lr-016.html: Added.
  • web-platform-tests/css/css-grid-1/alignment/grid-self-alignment-stretch-vertical-rl-001-expected.txt: Added.
  • web-platform-tests/css/css-grid-1/alignment/grid-self-alignment-stretch-vertical-rl-001.html: Added.
  • web-platform-tests/css/css-grid-1/alignment/grid-self-alignment-stretch-vertical-rl-002-expected.txt: Added.
  • web-platform-tests/css/css-grid-1/alignment/grid-self-alignment-stretch-vertical-rl-002.html: Added.
  • web-platform-tests/css/css-grid-1/alignment/grid-self-alignment-stretch-vertical-rl-003-expected.txt: Added.
  • web-platform-tests/css/css-grid-1/alignment/grid-self-alignment-stretch-vertical-rl-003.html: Added.
  • web-platform-tests/css/css-grid-1/alignment/grid-self-alignment-stretch-vertical-rl-004-expected.txt: Added.
  • web-platform-tests/css/css-grid-1/alignment/grid-self-alignment-stretch-vertical-rl-004.html: Added.
  • web-platform-tests/css/css-grid-1/alignment/grid-self-alignment-stretch-vertical-rl-005-expected.txt: Added.
  • web-platform-tests/css/css-grid-1/alignment/grid-self-alignment-stretch-vertical-rl-005.html: Added.
  • web-platform-tests/css/css-grid-1/alignment/grid-self-alignment-stretch-vertical-rl-006-expected.txt: Added.
  • web-platform-tests/css/css-grid-1/alignment/grid-self-alignment-stretch-vertical-rl-006.html: Added.
  • web-platform-tests/css/css-grid-1/alignment/grid-self-alignment-stretch-vertical-rl-007-expected.txt: Added.
  • web-platform-tests/css/css-grid-1/alignment/grid-self-alignment-stretch-vertical-rl-007.html: Added.
  • web-platform-tests/css/css-grid-1/alignment/grid-self-alignment-stretch-vertical-rl-008-expected.txt: Added.
  • web-platform-tests/css/css-grid-1/alignment/grid-self-alignment-stretch-vertical-rl-008.html: Added.
  • web-platform-tests/css/css-grid-1/alignment/grid-self-alignment-stretch-vertical-rl-009-expected.txt: Added.
  • web-platform-tests/css/css-grid-1/alignment/grid-self-alignment-stretch-vertical-rl-009.html: Added.
  • web-platform-tests/css/css-grid-1/alignment/grid-self-alignment-stretch-vertical-rl-010-expected.txt: Added.
  • web-platform-tests/css/css-grid-1/alignment/grid-self-alignment-stretch-vertical-rl-010.html: Added.
  • web-platform-tests/css/css-grid-1/alignment/grid-self-alignment-stretch-vertical-rl-011-expected.txt: Added.
  • web-platform-tests/css/css-grid-1/alignment/grid-self-alignment-stretch-vertical-rl-011.html: Added.
  • web-platform-tests/css/css-grid-1/alignment/grid-self-alignment-stretch-vertical-rl-012-expected.txt: Added.
  • web-platform-tests/css/css-grid-1/alignment/grid-self-alignment-stretch-vertical-rl-012.html: Added.
  • web-platform-tests/css/css-grid-1/alignment/grid-self-alignment-stretch-vertical-rl-013-expected.txt: Added.
  • web-platform-tests/css/css-grid-1/alignment/grid-self-alignment-stretch-vertical-rl-013.html: Added.
  • web-platform-tests/css/css-grid-1/alignment/grid-self-alignment-stretch-vertical-rl-014-expected.txt: Added.
  • web-platform-tests/css/css-grid-1/alignment/grid-self-alignment-stretch-vertical-rl-014.html: Added.
  • web-platform-tests/css/css-grid-1/alignment/grid-self-alignment-stretch-vertical-rl-015-expected.txt: Added.
  • web-platform-tests/css/css-grid-1/alignment/grid-self-alignment-stretch-vertical-rl-015.html: Added.
  • web-platform-tests/css/css-grid-1/alignment/grid-self-alignment-stretch-vertical-rl-016-expected.txt: Added.
  • web-platform-tests/css/css-grid-1/alignment/grid-self-alignment-stretch-vertical-rl-016.html: Added.
  • web-platform-tests/css/css-grid-1/alignment/w3c-import.log:
  • web-platform-tests/css/css-grid-1/grid-definition/grid-inline-support-flexible-lengths-001.html: Added.
  • web-platform-tests/css/css-grid-1/grid-definition/grid-inline-support-flexible-lengths-001.xht: Removed.
  • web-platform-tests/css/css-grid-1/grid-definition/grid-inline-support-grid-template-areas-001.html: Added.
  • web-platform-tests/css/css-grid-1/grid-definition/grid-inline-support-grid-template-areas-001.xht: Removed.
  • web-platform-tests/css/css-grid-1/grid-definition/grid-inline-support-grid-template-columns-rows-001.html: Added.
  • web-platform-tests/css/css-grid-1/grid-definition/grid-inline-support-grid-template-columns-rows-001.xht: Removed.
  • web-platform-tests/css/css-grid-1/grid-definition/grid-inline-support-named-grid-lines-001.html: Added.
  • web-platform-tests/css/css-grid-1/grid-definition/grid-inline-support-named-grid-lines-001.xht: Removed.
  • web-platform-tests/css/css-grid-1/grid-definition/grid-inline-support-repeat-001.html: Added.
  • web-platform-tests/css/css-grid-1/grid-definition/grid-inline-support-repeat-001.xht: Removed.
  • web-platform-tests/css/css-grid-1/grid-definition/grid-inline-template-columns-rows-resolved-values-001.html: Added.
  • web-platform-tests/css/css-grid-1/grid-definition/grid-inline-template-columns-rows-resolved-values-001.xht: Removed.
  • web-platform-tests/css/css-grid-1/grid-definition/grid-support-flexible-lengths-001.html: Added.
  • web-platform-tests/css/css-grid-1/grid-definition/grid-support-flexible-lengths-001.xht: Removed.
  • web-platform-tests/css/css-grid-1/grid-definition/grid-support-grid-template-areas-001.html: Added.
  • web-platform-tests/css/css-grid-1/grid-definition/grid-support-grid-template-areas-001.xht: Removed.
  • web-platform-tests/css/css-grid-1/grid-definition/grid-support-grid-template-columns-rows-001.html: Added.
  • web-platform-tests/css/css-grid-1/grid-definition/grid-support-grid-template-columns-rows-001.xht: Removed.
  • web-platform-tests/css/css-grid-1/grid-definition/grid-support-named-grid-lines-001.html: Added.
  • web-platform-tests/css/css-grid-1/grid-definition/grid-support-named-grid-lines-001.xht: Removed.
  • web-platform-tests/css/css-grid-1/grid-definition/grid-support-repeat-001.html: Added.
  • web-platform-tests/css/css-grid-1/grid-definition/grid-support-repeat-001.xht: Removed.
  • web-platform-tests/css/css-grid-1/grid-definition/grid-template-columns-rows-resolved-values-001.html: Added.
  • web-platform-tests/css/css-grid-1/grid-definition/grid-template-columns-rows-resolved-values-001.xht: Removed.
  • web-platform-tests/css/css-grid-1/grid-definition/w3c-import.log:
  • web-platform-tests/css/css-grid-1/grid-items/grid-inline-items-001.html: Added.
  • web-platform-tests/css/css-grid-1/grid-items/grid-inline-items-001.xht: Removed.
  • web-platform-tests/css/css-grid-1/grid-items/grid-inline-items-002.html: Added.
  • web-platform-tests/css/css-grid-1/grid-items/grid-inline-items-002.xht: Removed.
  • web-platform-tests/css/css-grid-1/grid-items/grid-inline-items-003.html: Added.
  • web-platform-tests/css/css-grid-1/grid-items/grid-inline-items-003.xht: Removed.
  • web-platform-tests/css/css-grid-1/grid-items/grid-inline-items-inline-blocks-001.html: Added.
  • web-platform-tests/css/css-grid-1/grid-items/grid-inline-items-inline-blocks-001.xht: Removed.
  • web-platform-tests/css/css-grid-1/grid-items/grid-inline-order-property-auto-placement-001-expected.html: Added.
  • web-platform-tests/css/css-grid-1/grid-items/grid-inline-order-property-auto-placement-001-expected.xht: Removed.
  • web-platform-tests/css/css-grid-1/grid-items/grid-inline-order-property-auto-placement-001.html: Added.
  • web-platform-tests/css/css-grid-1/grid-items/grid-inline-order-property-auto-placement-001.xht: Removed.
  • web-platform-tests/css/css-grid-1/grid-items/grid-inline-order-property-auto-placement-002-expected.html: Added.
  • web-platform-tests/css/css-grid-1/grid-items/grid-inline-order-property-auto-placement-002-expected.xht: Removed.
  • web-platform-tests/css/css-grid-1/grid-items/grid-inline-order-property-auto-placement-002.html: Added.
  • web-platform-tests/css/css-grid-1/grid-items/grid-inline-order-property-auto-placement-002.xht: Removed.
  • web-platform-tests/css/css-grid-1/grid-items/grid-inline-order-property-auto-placement-003-expected.html: Added.
  • web-platform-tests/css/css-grid-1/grid-items/grid-inline-order-property-auto-placement-003-expected.xht: Removed.
  • web-platform-tests/css/css-grid-1/grid-items/grid-inline-order-property-auto-placement-003.html: Added.
  • web-platform-tests/css/css-grid-1/grid-items/grid-inline-order-property-auto-placement-003.xht: Removed.
  • web-platform-tests/css/css-grid-1/grid-items/grid-inline-order-property-auto-placement-004-expected.html: Added.
  • web-platform-tests/css/css-grid-1/grid-items/grid-inline-order-property-auto-placement-004-expected.xht: Removed.
  • web-platform-tests/css/css-grid-1/grid-items/grid-inline-order-property-auto-placement-004.html: Added.
  • web-platform-tests/css/css-grid-1/grid-items/grid-inline-order-property-auto-placement-004.xht: Removed.
  • web-platform-tests/css/css-grid-1/grid-items/grid-inline-order-property-auto-placement-005-expected.html: Added.
  • web-platform-tests/css/css-grid-1/grid-items/grid-inline-order-property-auto-placement-005-expected.xht: Removed.
  • web-platform-tests/css/css-grid-1/grid-items/grid-inline-order-property-auto-placement-005.html: Added.
  • web-platform-tests/css/css-grid-1/grid-items/grid-inline-order-property-auto-placement-005.xht: Removed.
  • web-platform-tests/css/css-grid-1/grid-items/grid-inline-order-property-painting-001.html: Added.
  • web-platform-tests/css/css-grid-1/grid-items/grid-inline-order-property-painting-001.xht: Removed.
  • web-platform-tests/css/css-grid-1/grid-items/grid-inline-order-property-painting-002.html: Added.
  • web-platform-tests/css/css-grid-1/grid-items/grid-inline-order-property-painting-002.xht: Removed.
  • web-platform-tests/css/css-grid-1/grid-items/grid-inline-order-property-painting-003.html: Added.
  • web-platform-tests/css/css-grid-1/grid-items/grid-inline-order-property-painting-003.xht: Removed.
  • web-platform-tests/css/css-grid-1/grid-items/grid-inline-order-property-painting-004.html: Added.
  • web-platform-tests/css/css-grid-1/grid-items/grid-inline-order-property-painting-004.xht: Removed.
  • web-platform-tests/css/css-grid-1/grid-items/grid-inline-order-property-painting-005.html: Added.
  • web-platform-tests/css/css-grid-1/grid-items/grid-inline-order-property-painting-005.xht: Removed.
  • web-platform-tests/css/css-grid-1/grid-items/grid-inline-z-axis-ordering-001.html: Added.
  • web-platform-tests/css/css-grid-1/grid-items/grid-inline-z-axis-ordering-001.xht: Removed.
  • web-platform-tests/css/css-grid-1/grid-items/grid-inline-z-axis-ordering-002.html: Added.
  • web-platform-tests/css/css-grid-1/grid-items/grid-inline-z-axis-ordering-002.xht: Removed.
  • web-platform-tests/css/css-grid-1/grid-items/grid-inline-z-axis-ordering-003.html: Added.
  • web-platform-tests/css/css-grid-1/grid-items/grid-inline-z-axis-ordering-003.xht: Removed.
  • web-platform-tests/css/css-grid-1/grid-items/grid-inline-z-axis-ordering-004.html: Added.
  • web-platform-tests/css/css-grid-1/grid-items/grid-inline-z-axis-ordering-004.xht: Removed.
  • web-platform-tests/css/css-grid-1/grid-items/grid-inline-z-axis-ordering-005.html: Added.
  • web-platform-tests/css/css-grid-1/grid-items/grid-inline-z-axis-ordering-005.xht: Removed.
  • web-platform-tests/css/css-grid-1/grid-items/grid-inline-z-axis-ordering-overlapped-items-001-expected.html: Added.
  • web-platform-tests/css/css-grid-1/grid-items/grid-inline-z-axis-ordering-overlapped-items-001-expected.xht: Removed.
  • web-platform-tests/css/css-grid-1/grid-items/grid-inline-z-axis-ordering-overlapped-items-001.html: Added.
  • web-platform-tests/css/css-grid-1/grid-items/grid-inline-z-axis-ordering-overlapped-items-001.xht: Removed.
  • web-platform-tests/css/css-grid-1/grid-items/grid-inline-z-axis-ordering-overlapped-items-002-expected.html: Added.
  • web-platform-tests/css/css-grid-1/grid-items/grid-inline-z-axis-ordering-overlapped-items-002-expected.xht: Removed.
  • web-platform-tests/css/css-grid-1/grid-items/grid-inline-z-axis-ordering-overlapped-items-002.html: Added.
  • web-platform-tests/css/css-grid-1/grid-items/grid-inline-z-axis-ordering-overlapped-items-002.xht: Removed.
  • web-platform-tests/css/css-grid-1/grid-items/grid-inline-z-axis-ordering-overlapped-items-003-expected.html: Added.
  • web-platform-tests/css/css-grid-1/grid-items/grid-inline-z-axis-ordering-overlapped-items-003-expected.xht: Removed.
  • web-platform-tests/css/css-grid-1/grid-items/grid-inline-z-axis-ordering-overlapped-items-003.html: Added.
  • web-platform-tests/css/css-grid-1/grid-items/grid-inline-z-axis-ordering-overlapped-items-003.xht: Removed.
  • web-platform-tests/css/css-grid-1/grid-items/grid-inline-z-axis-ordering-overlapped-items-004-expected.html: Added.
  • web-platform-tests/css/css-grid-1/grid-items/grid-inline-z-axis-ordering-overlapped-items-004-expected.xht: Removed.
  • web-platform-tests/css/css-grid-1/grid-items/grid-inline-z-axis-ordering-overlapped-items-004.html: Added.
  • web-platform-tests/css/css-grid-1/grid-items/grid-inline-z-axis-ordering-overlapped-items-004.xht: Removed.
  • web-platform-tests/css/css-grid-1/grid-items/grid-inline-z-axis-ordering-overlapped-items-005-expected.html: Added.
  • web-platform-tests/css/css-grid-1/grid-items/grid-inline-z-axis-ordering-overlapped-items-005-expected.xht: Removed.
  • web-platform-tests/css/css-grid-1/grid-items/grid-inline-z-axis-ordering-overlapped-items-005.html: Added.
  • web-platform-tests/css/css-grid-1/grid-items/grid-inline-z-axis-ordering-overlapped-items-005.xht: Removed.
  • web-platform-tests/css/css-grid-1/grid-items/grid-inline-z-axis-ordering-overlapped-items-006-expected.html: Added.
  • web-platform-tests/css/css-grid-1/grid-items/grid-inline-z-axis-ordering-overlapped-items-006-expected.xht: Removed.
  • web-platform-tests/css/css-grid-1/grid-items/grid-inline-z-axis-ordering-overlapped-items-006.html: Added.
  • web-platform-tests/css/css-grid-1/grid-items/grid-inline-z-axis-ordering-overlapped-items-006.xht: Removed.
  • web-platform-tests/css/css-grid-1/grid-items/grid-items-001.html: Added.
  • web-platform-tests/css/css-grid-1/grid-items/grid-items-001.xht: Removed.
  • web-platform-tests/css/css-grid-1/grid-items/grid-items-002.html: Added.
  • web-platform-tests/css/css-grid-1/grid-items/grid-items-002.xht: Removed.
  • web-platform-tests/css/css-grid-1/grid-items/grid-items-003.html: Added.
  • web-platform-tests/css/css-grid-1/grid-items/grid-items-003.xht: Removed.
  • web-platform-tests/css/css-grid-1/grid-items/grid-items-inline-blocks-001.html: Added.
  • web-platform-tests/css/css-grid-1/grid-items/grid-items-inline-blocks-001.xht: Removed.
  • web-platform-tests/css/css-grid-1/grid-items/grid-minimum-size-grid-items-001.html: Added.
  • web-platform-tests/css/css-grid-1/grid-items/grid-minimum-size-grid-items-001.xht: Removed.
  • web-platform-tests/css/css-grid-1/grid-items/grid-minimum-size-grid-items-002.html: Added.
  • web-platform-tests/css/css-grid-1/grid-items/grid-minimum-size-grid-items-002.xht: Removed.
  • web-platform-tests/css/css-grid-1/grid-items/grid-minimum-size-grid-items-003.html: Added.
  • web-platform-tests/css/css-grid-1/grid-items/grid-minimum-size-grid-items-003.xht: Removed.
  • web-platform-tests/css/css-grid-1/grid-items/grid-minimum-size-grid-items-004.html: Added.
  • web-platform-tests/css/css-grid-1/grid-items/grid-minimum-size-grid-items-004.xht: Removed.
  • web-platform-tests/css/css-grid-1/grid-items/grid-minimum-size-grid-items-005.html: Added.
  • web-platform-tests/css/css-grid-1/grid-items/grid-minimum-size-grid-items-005.xht: Removed.
  • web-platform-tests/css/css-grid-1/grid-items/grid-minimum-size-grid-items-006.html: Added.
  • web-platform-tests/css/css-grid-1/grid-items/grid-minimum-size-grid-items-006.xht: Removed.
  • web-platform-tests/css/css-grid-1/grid-items/grid-minimum-size-grid-items-007.html: Added.
  • web-platform-tests/css/css-grid-1/grid-items/grid-minimum-size-grid-items-007.xht: Removed.
  • web-platform-tests/css/css-grid-1/grid-items/grid-minimum-size-grid-items-008.html: Added.
  • web-platform-tests/css/css-grid-1/grid-items/grid-minimum-size-grid-items-008.xht: Removed.
  • web-platform-tests/css/css-grid-1/grid-items/grid-minimum-size-grid-items-009.html: Added.
  • web-platform-tests/css/css-grid-1/grid-items/grid-minimum-size-grid-items-009.xht: Removed.
  • web-platform-tests/css/css-grid-1/grid-items/grid-minimum-size-grid-items-021-expected.txt: Added.
  • web-platform-tests/css/css-grid-1/grid-items/grid-minimum-size-grid-items-021.html: Added.
  • web-platform-tests/css/css-grid-1/grid-items/grid-order-property-auto-placement-001-expected.html: Added.
  • web-platform-tests/css/css-grid-1/grid-items/grid-order-property-auto-placement-001-expected.xht: Removed.
  • web-platform-tests/css/css-grid-1/grid-items/grid-order-property-auto-placement-001.html: Added.
  • web-platform-tests/css/css-grid-1/grid-items/grid-order-property-auto-placement-001.xht: Removed.
  • web-platform-tests/css/css-grid-1/grid-items/grid-order-property-auto-placement-002-expected.html: Added.
  • web-platform-tests/css/css-grid-1/grid-items/grid-order-property-auto-placement-002-expected.xht: Removed.
  • web-platform-tests/css/css-grid-1/grid-items/grid-order-property-auto-placement-002.html: Added.
  • web-platform-tests/css/css-grid-1/grid-items/grid-order-property-auto-placement-002.xht: Removed.
  • web-platform-tests/css/css-grid-1/grid-items/grid-order-property-auto-placement-003-expected.html: Added.
  • web-platform-tests/css/css-grid-1/grid-items/grid-order-property-auto-placement-003-expected.xht: Removed.
  • web-platform-tests/css/css-grid-1/grid-items/grid-order-property-auto-placement-003.html: Added.
  • web-platform-tests/css/css-grid-1/grid-items/grid-order-property-auto-placement-003.xht: Removed.
  • web-platform-tests/css/css-grid-1/grid-items/grid-order-property-auto-placement-004-expected.html: Added.
  • web-platform-tests/css/css-grid-1/grid-items/grid-order-property-auto-placement-004-expected.xht: Removed.
  • web-platform-tests/css/css-grid-1/grid-items/grid-order-property-auto-placement-004.html: Added.
  • web-platform-tests/css/css-grid-1/grid-items/grid-order-property-auto-placement-004.xht: Removed.
  • web-platform-tests/css/css-grid-1/grid-items/grid-order-property-auto-placement-005-expected.html: Added.
  • web-platform-tests/css/css-grid-1/grid-items/grid-order-property-auto-placement-005-expected.xht: Removed.
  • web-platform-tests/css/css-grid-1/grid-items/grid-order-property-auto-placement-005.html: Added.
  • web-platform-tests/css/css-grid-1/grid-items/grid-order-property-auto-placement-005.xht: Removed.
  • web-platform-tests/css/css-grid-1/grid-items/grid-order-property-painting-001.html: Added.
  • web-platform-tests/css/css-grid-1/grid-items/grid-order-property-painting-001.xht: Removed.
  • web-platform-tests/css/css-grid-1/grid-items/grid-order-property-painting-002.html: Added.
  • web-platform-tests/css/css-grid-1/grid-items/grid-order-property-painting-002.xht: Removed.
  • web-platform-tests/css/css-grid-1/grid-items/grid-order-property-painting-003.html: Added.
  • web-platform-tests/css/css-grid-1/grid-items/grid-order-property-painting-003.xht: Removed.
  • web-platform-tests/css/css-grid-1/grid-items/grid-order-property-painting-004.html: Added.
  • web-platform-tests/css/css-grid-1/grid-items/grid-order-property-painting-004.xht: Removed.
  • web-platform-tests/css/css-grid-1/grid-items/grid-order-property-painting-005.html: Added.
  • web-platform-tests/css/css-grid-1/grid-items/grid-order-property-painting-005.xht: Removed.
  • web-platform-tests/css/css-grid-1/grid-items/grid-z-axis-ordering-001.html: Added.
  • web-platform-tests/css/css-grid-1/grid-items/grid-z-axis-ordering-001.xht: Removed.
  • web-platform-tests/css/css-grid-1/grid-items/grid-z-axis-ordering-002.html: Added.
  • web-platform-tests/css/css-grid-1/grid-items/grid-z-axis-ordering-002.xht: Removed.
  • web-platform-tests/css/css-grid-1/grid-items/grid-z-axis-ordering-003.html: Added.
  • web-platform-tests/css/css-grid-1/grid-items/grid-z-axis-ordering-003.xht: Removed.
  • web-platform-tests/css/css-grid-1/grid-items/grid-z-axis-ordering-004.html: Added.
  • web-platform-tests/css/css-grid-1/grid-items/grid-z-axis-ordering-004.xht: Removed.
  • web-platform-tests/css/css-grid-1/grid-items/grid-z-axis-ordering-005.html: Added.
  • web-platform-tests/css/css-grid-1/grid-items/grid-z-axis-ordering-005.xht: Removed.
  • web-platform-tests/css/css-grid-1/grid-items/grid-z-axis-ordering-overlapped-items-001-expected.html: Added.
  • web-platform-tests/css/css-grid-1/grid-items/grid-z-axis-ordering-overlapped-items-001-expected.xht: Removed.
  • web-platform-tests/css/css-grid-1/grid-items/grid-z-axis-ordering-overlapped-items-001.html: Added.
  • web-platform-tests/css/css-grid-1/grid-items/grid-z-axis-ordering-overlapped-items-001.xht: Removed.
  • web-platform-tests/css/css-grid-1/grid-items/grid-z-axis-ordering-overlapped-items-002-expected.html: Added.
  • web-platform-tests/css/css-grid-1/grid-items/grid-z-axis-ordering-overlapped-items-002-expected.xht: Removed.
  • web-platform-tests/css/css-grid-1/grid-items/grid-z-axis-ordering-overlapped-items-002.html: Added.
  • web-platform-tests/css/css-grid-1/grid-items/grid-z-axis-ordering-overlapped-items-002.xht: Removed.
  • web-platform-tests/css/css-grid-1/grid-items/grid-z-axis-ordering-overlapped-items-003-expected.html: Added.
  • web-platform-tests/css/css-grid-1/grid-items/grid-z-axis-ordering-overlapped-items-003-expected.xht: Removed.
  • web-platform-tests/css/css-grid-1/grid-items/grid-z-axis-ordering-overlapped-items-003.html: Added.
  • web-platform-tests/css/css-grid-1/grid-items/grid-z-axis-ordering-overlapped-items-003.xht: Removed.
  • web-platform-tests/css/css-grid-1/grid-items/grid-z-axis-ordering-overlapped-items-004-expected.html: Added.
  • web-platform-tests/css/css-grid-1/grid-items/grid-z-axis-ordering-overlapped-items-004-expected.xht: Removed.
  • web-platform-tests/css/css-grid-1/grid-items/grid-z-axis-ordering-overlapped-items-004.html: Added.
  • web-platform-tests/css/css-grid-1/grid-items/grid-z-axis-ordering-overlapped-items-004.xht: Removed.
  • web-platform-tests/css/css-grid-1/grid-items/grid-z-axis-ordering-overlapped-items-005-expected.html: Added.
  • web-platform-tests/css/css-grid-1/grid-items/grid-z-axis-ordering-overlapped-items-005-expected.xht: Removed.
  • web-platform-tests/css/css-grid-1/grid-items/grid-z-axis-ordering-overlapped-items-005.html: Added.
  • web-platform-tests/css/css-grid-1/grid-items/grid-z-axis-ordering-overlapped-items-005.xht: Removed.
  • web-platform-tests/css/css-grid-1/grid-items/grid-z-axis-ordering-overlapped-items-006-expected.html: Added.
  • web-platform-tests/css/css-grid-1/grid-items/grid-z-axis-ordering-overlapped-items-006-expected.xht: Removed.
  • web-platform-tests/css/css-grid-1/grid-items/grid-z-axis-ordering-overlapped-items-006.html: Added.
  • web-platform-tests/css/css-grid-1/grid-items/grid-z-axis-ordering-overlapped-items-006.xht: Removed.
  • web-platform-tests/css/css-grid-1/grid-items/support/500x500-green.png: Added.
  • web-platform-tests/css/css-grid-1/grid-items/support/w3c-import.log:
  • web-platform-tests/css/css-grid-1/grid-items/w3c-import.log:
  • web-platform-tests/css/css-grid-1/grid-model/grid-computed-value-display-floated-items-001.html: Added.
  • web-platform-tests/css/css-grid-1/grid-model/grid-computed-value-display-floated-items-001.xht: Removed.
  • web-platform-tests/css/css-grid-1/grid-model/grid-display-grid-001.html: Added.
  • web-platform-tests/css/css-grid-1/grid-model/grid-display-grid-001.xht: Removed.
  • web-platform-tests/css/css-grid-1/grid-model/grid-display-inline-grid-001.html: Added.
  • web-platform-tests/css/css-grid-1/grid-model/grid-display-inline-grid-001.xht: Removed.
  • web-platform-tests/css/css-grid-1/grid-model/grid-first-letter-001-expected.html: Added.
  • web-platform-tests/css/css-grid-1/grid-model/grid-first-letter-001-expected.xht: Removed.
  • web-platform-tests/css/css-grid-1/grid-model/grid-first-letter-001.html: Added.
  • web-platform-tests/css/css-grid-1/grid-model/grid-first-letter-001.xht: Removed.
  • web-platform-tests/css/css-grid-1/grid-model/grid-first-letter-002-expected.html: Added.
  • web-platform-tests/css/css-grid-1/grid-model/grid-first-letter-002-expected.xht: Removed.
  • web-platform-tests/css/css-grid-1/grid-model/grid-first-letter-002.html: Added.
  • web-platform-tests/css/css-grid-1/grid-model/grid-first-letter-002.xht: Removed.
  • web-platform-tests/css/css-grid-1/grid-model/grid-first-letter-003-expected.html: Added.
  • web-platform-tests/css/css-grid-1/grid-model/grid-first-letter-003-expected.xht: Removed.
  • web-platform-tests/css/css-grid-1/grid-model/grid-first-letter-003.html: Added.
  • web-platform-tests/css/css-grid-1/grid-model/grid-first-letter-003.xht: Removed.
  • web-platform-tests/css/css-grid-1/grid-model/grid-first-line-001-expected.html: Added.
  • web-platform-tests/css/css-grid-1/grid-model/grid-first-line-001-expected.xht: Removed.
  • web-platform-tests/css/css-grid-1/grid-model/grid-first-line-001.html: Added.
  • web-platform-tests/css/css-grid-1/grid-model/grid-first-line-001.xht: Removed.
  • web-platform-tests/css/css-grid-1/grid-model/grid-first-line-002-expected.html: Added.
  • web-platform-tests/css/css-grid-1/grid-model/grid-first-line-002-expected.xht: Removed.
  • web-platform-tests/css/css-grid-1/grid-model/grid-first-line-002.html: Added.
  • web-platform-tests/css/css-grid-1/grid-model/grid-first-line-002.xht: Removed.
  • web-platform-tests/css/css-grid-1/grid-model/grid-first-line-003-expected.html: Added.
  • web-platform-tests/css/css-grid-1/grid-model/grid-first-line-003-expected.xht: Removed.
  • web-platform-tests/css/css-grid-1/grid-model/grid-first-line-003.html: Added.
  • web-platform-tests/css/css-grid-1/grid-model/grid-first-line-003.xht: Removed.
  • web-platform-tests/css/css-grid-1/grid-model/grid-float-001.html: Added.
  • web-platform-tests/css/css-grid-1/grid-model/grid-float-001.xht: Removed.
  • web-platform-tests/css/css-grid-1/grid-model/grid-floats-no-intrude-001.html: Added.
  • web-platform-tests/css/css-grid-1/grid-model/grid-floats-no-intrude-001.xht: Removed.
  • web-platform-tests/css/css-grid-1/grid-model/grid-inline-first-letter-001-expected.html: Added.
  • web-platform-tests/css/css-grid-1/grid-model/grid-inline-first-letter-001-expected.xht: Removed.
  • web-platform-tests/css/css-grid-1/grid-model/grid-inline-first-letter-001.html: Added.
  • web-platform-tests/css/css-grid-1/grid-model/grid-inline-first-letter-001.xht: Removed.
  • web-platform-tests/css/css-grid-1/grid-model/grid-inline-first-letter-002-expected.html: Added.
  • web-platform-tests/css/css-grid-1/grid-model/grid-inline-first-letter-002-expected.xht: Removed.
  • web-platform-tests/css/css-grid-1/grid-model/grid-inline-first-letter-002.html: Added.
  • web-platform-tests/css/css-grid-1/grid-model/grid-inline-first-letter-002.xht: Removed.
  • web-platform-tests/css/css-grid-1/grid-model/grid-inline-first-letter-003-expected.html: Added.
  • web-platform-tests/css/css-grid-1/grid-model/grid-inline-first-letter-003-expected.xht: Removed.
  • web-platform-tests/css/css-grid-1/grid-model/grid-inline-first-letter-003.html: Added.
  • web-platform-tests/css/css-grid-1/grid-model/grid-inline-first-letter-003.xht: Removed.
  • web-platform-tests/css/css-grid-1/grid-model/grid-inline-first-line-001-expected.html: Added.
  • web-platform-tests/css/css-grid-1/grid-model/grid-inline-first-line-001-expected.xht: Removed.
  • web-platform-tests/css/css-grid-1/grid-model/grid-inline-first-line-001.html: Added.
  • web-platform-tests/css/css-grid-1/grid-model/grid-inline-first-line-001.xht: Removed.
  • web-platform-tests/css/css-grid-1/grid-model/grid-inline-first-line-002-expected.html: Added.
  • web-platform-tests/css/css-grid-1/grid-model/grid-inline-first-line-002-expected.xht: Removed.
  • web-platform-tests/css/css-grid-1/grid-model/grid-inline-first-line-002.html: Added.
  • web-platform-tests/css/css-grid-1/grid-model/grid-inline-first-line-002.xht: Removed.
  • web-platform-tests/css/css-grid-1/grid-model/grid-inline-first-line-003-expected.html: Added.
  • web-platform-tests/css/css-grid-1/grid-model/grid-inline-first-line-003-expected.xht: Removed.
  • web-platform-tests/css/css-grid-1/grid-model/grid-inline-first-line-003.html: Added.
  • web-platform-tests/css/css-grid-1/grid-model/grid-inline-first-line-003.xht: Removed.
  • web-platform-tests/css/css-grid-1/grid-model/grid-inline-float-001.html: Added.
  • web-platform-tests/css/css-grid-1/grid-model/grid-inline-float-001.xht: Removed.
  • web-platform-tests/css/css-grid-1/grid-model/grid-inline-floats-no-intrude-001.html: Added.
  • web-platform-tests/css/css-grid-1/grid-model/grid-inline-floats-no-intrude-001.xht: Removed.
  • web-platform-tests/css/css-grid-1/grid-model/grid-inline-margins-no-collapse-001-expected.html: Added.
  • web-platform-tests/css/css-grid-1/grid-model/grid-inline-margins-no-collapse-001-expected.xht: Removed.
  • web-platform-tests/css/css-grid-1/grid-model/grid-inline-margins-no-collapse-001.html: Added.
  • web-platform-tests/css/css-grid-1/grid-model/grid-inline-margins-no-collapse-001.xht: Removed.
  • web-platform-tests/css/css-grid-1/grid-model/grid-inline-multicol-001.html: Added.
  • web-platform-tests/css/css-grid-1/grid-model/grid-inline-multicol-001.xht: Removed.
  • web-platform-tests/css/css-grid-1/grid-model/grid-inline-vertical-align-001.html: Added.
  • web-platform-tests/css/css-grid-1/grid-model/grid-inline-vertical-align-001.xht: Removed.
  • web-platform-tests/css/css-grid-1/grid-model/grid-margins-no-collapse-001-expected.html: Added.
  • web-platform-tests/css/css-grid-1/grid-model/grid-margins-no-collapse-001-expected.xht: Removed.
  • web-platform-tests/css/css-grid-1/grid-model/grid-margins-no-collapse-001.html: Added.
  • web-platform-tests/css/css-grid-1/grid-model/grid-margins-no-collapse-001.xht: Removed.
  • web-platform-tests/css/css-grid-1/grid-model/grid-multicol-001.html: Added.
  • web-platform-tests/css/css-grid-1/grid-model/grid-multicol-001.xht: Removed.
  • web-platform-tests/css/css-grid-1/grid-model/grid-support-display-001.html: Added.
  • web-platform-tests/css/css-grid-1/grid-model/grid-support-display-001.xht: Removed.
  • web-platform-tests/css/css-grid-1/grid-model/grid-vertical-align-001.html: Added.
  • web-platform-tests/css/css-grid-1/grid-model/grid-vertical-align-001.xht: Removed.
  • web-platform-tests/css/css-grid-1/grid-model/w3c-import.log:
  • web-platform-tests/css/css-grid-1/support/check-layout-th.js: Added.

(checkSubtreeExpectedValues):
(checkAttribute):
(assert_tolerance):
(checkExpectedValues):
(window.checkLayout):

  • web-platform-tests/css/css-grid-1/support/w3c-import.log: Copied from LayoutTests/imported/w3c/web-platform-tests/css/css-grid-1/grid-items/support/w3c-import.log.
2:02 AM Changeset in webkit [217651] by Konstantin Tokarev
  • 3 edits in trunk/Source/WebCore

Get rid of more HIGH_DPI_CANVAS leftovers
​https://bugs.webkit.org/show_bug.cgi?id=172751

Reviewed by Simon Fraser.

Get rid of HTMLCanvasElement::convertLogicalToDevice() and
HTMLCanvasElement::convertDeviceToLogical() that are no longer needed,
as canvas doesn't use device scale factor anymore.

No new tests needed.

  • html/HTMLCanvasElement.cpp:

(WebCore::HTMLCanvasElement::createImageBuffer): Use integer width()
and height() instead of floating-point temporary deviceSize variable.
(WebCore::HTMLCanvasElement::baseTransform): Return unmodified
baseTransform of underlying ImageBuffer.

  • html/HTMLCanvasElement.h: Removed declarations of unused methods.
1:22 AM Changeset in webkit [217650] by tpopela@redhat.com
  • 2 edits in trunk/Source/JavaScriptCore

RELEASE_ASSERT_NOT_REACHED() in InferredType::kindForFlags() on Big-Endians
​https://bugs.webkit.org/show_bug.cgi?id=170945

Patch by Tomas Popela <​tpopela@redhat.com>, Mark Lam <​mark.lam@apple.com> on 2017-06-01
Reviewed by Mark Lam.

Re-define PutByIdFlags as a int32_t enum explicitly because it is
stored as an int32_t value in UnlinkedInstruction. This prevents
a bug on 64-bit big endian architectures where the word order is
inverted (when we convert the UnlinkedInstruction into a CodeBlock
Instruction), resulting in the PutByIdFlags value not being stored in
the 32-bit word that the rest of the code expects it to be in.

  • bytecode/PutByIdFlags.h:
12:27 AM Changeset in webkit [217649] by Yusuke Suzuki
  • 3 edits in trunk/LayoutTests

Unreviewed, rebaseline test results according to the error message change
​https://bugs.webkit.org/show_bug.cgi?id=172798

  • js/dom/string-prototype-properties-expected.txt:
  • sputnik/Conformance/15_Native_Objects/15.5_String/15.5.4/15.5.4.6_String.prototype.concat/S15.5.4.6_A1_T3-expected.txt:
Note: See TracTimeline for information about the timeline view.