⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Jun 4, 2017:

11:09 PM Changeset in webkit [217776] by Simon Fraser
  • 5 edits
    2 adds in trunk

Percentages are calculated wrong in SVG transform CSS property
​https://bugs.webkit.org/show_bug.cgi?id=172901

Reviewed by Zalan Bujtas.
Source/WebCore:

The code added in r217236 was just fetching viewBox(), but that can be empty.
SVGLengthContext::determineViewport() does the correct thing to get
the appropriate viewport.

Test: svg/transforms/percent-transform-values-viewbox.html

  • svg/SVGGraphicsElement.cpp:

(WebCore::SVGGraphicsElement::animatedLocalTransform):

LayoutTests:

  • svg/transforms/percent-transform-values-viewbox-expected.html: Added.
  • svg/transforms/percent-transform-values-viewbox.html: Added.
  • svg/transforms/transform-origin-css-property-expected.xhtml:
  • svg/transforms/transform-origin-css-property.xhtml: Make this test a bit less

annoying to maintain by applying the transforms relative to the fill-box, which means all
the transform origins are no longer offset by the box position. Other tests exercise
view-box relative transform origins.

1:56 PM Changeset in webkit [217775] by eric.carlson@apple.com
  • 8 edits
    2 adds in trunk

[MediaStream] Page capture state not reported correctly
​https://bugs.webkit.org/show_bug.cgi?id=172897
<rdar://problem/32493318>

Reviewed by Youenn Fablet.

Source/WebCore:

Test: fast/mediastream/media-stream-track-muted.html

  • Modules/mediastream/MediaStream.cpp:

(WebCore::MediaStream::mediaState): Test for audio and video mute on the tracks.
(WebCore::MediaStream::characteristicsChanged): Call statusDidChange when m_mediaState
changes instead of m_muted, so the page is informed when just audio or video mute state
changes.

  • Modules/mediastream/MediaStream.h:
  • testing/Internals.cpp:

(WebCore::Internals::setMediaStreamTrackMuted): New.

  • testing/Internals.h:
  • testing/Internals.idl:

LayoutTests:

  • fast/mediastream/media-stream-track-muted-expected.txt: Added.
  • fast/mediastream/media-stream-track-muted.html: Added.
11:19 AM Changeset in webkit [217774] by Darin Adler
  • 26 edits in trunk/Source

Streamline handling of attributes, using references as much as possible
​https://bugs.webkit.org/show_bug.cgi?id=172899

Reviewed by Chris Dumez.

Source/WebCore:

  • accessibility/AccessibilityNodeObject.cpp:

(WebCore::AccessibilityNodeObject::valueForRange): Use reference to value of
attribute instead of copy to avoid reference count churn.
(WebCore::AccessibilityNodeObject::maxValueForRange): Ditto.
(WebCore::AccessibilityNodeObject::minValueForRange): Ditto.

  • accessibility/AccessibilitySVGElement.cpp:

(WebCore::AccessibilitySVGElement::childElementWithMatchingLanguage): Ditto.
(WebCore::AccessibilitySVGElement::accessibilityDescription): Ditto.

  • css/PropertySetCSSStyleDeclaration.cpp:

(WebCore::StyleAttributeMutationScope::StyleAttributeMutationScope): Ditto.

  • editing/cocoa/DataDetection.mm:

(WebCore::DataDetection::shouldCancelDefaultAction): Use the
equalLettersIgnoringASCIICase function instead of using
both equalIgnoringASCIICase and convertToASCIILowercase.

  • html/HTMLAudioElement.cpp:

(WebCore::HTMLAudioElement::HTMLAudioElement): Marked this inline since we
want it inlined the one place it's used.
(WebCore::HTMLAudioElement::create): Use auto and named the local variable
just element.
(WebCore::HTMLAudioElement::createForJSConstructor): Call create rather than
repeating the code from create. Use setAttributeWithoutSynchronization directly
rather than calling helper functions. Removed unneeded null check;
setAttributeWithoutSynchronization handles null by removing the attribute.

  • html/HTMLAudioElement.h: Changed src argument of createForJSConstructor to

take AtomicString since that is what we need for an attribute value.

  • html/HTMLAudioElement.idl: Use [AtomicString] for src argument.
  • html/HTMLElement.cpp:

(WebCore::HTMLElement::directionality): Use reference to value of
attribute instead of copy to avoid reference count churn.
(WebCore::HTMLElement::shouldAutocorrect): Ditto.

  • html/HTMLImageElement.cpp:

(WebCore::HTMLImageElement::bestFitSourceFromPictureElement): Call the new
parsedMediaAttribute instead of the old mediaQuerySet function. Other than the
name, the only change is that the result is now a const pointer.

  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::updateType): Removed unnecessary local variable,
resulting in code that is slightly cleaner and possibly eliminating reference
count chrun.

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::setSrc): Deleted.
(WebCore::HTMLMediaElement::selectNextSourceChild): Use parsedMediaAttribute and
removed rendudant direct check of whether mediaAttr is present. Changed logging to
get the media attribute directly rather than with a helper function. Changed type
to get the type attribute directly rather than with a helper function.
(WebCore::HTMLMediaElement::sourceWasAdded): Take a reference rather than a pointer.
(WebCore::HTMLMediaElement::sourceWasRemoved): Ditto.
(WebCore::HTMLMediaElement::doesHaveAttribute): Use reference to value of
attribute instead of copy to avoid reference count churn.

  • html/HTMLMediaElement.h: Updated for the above.
  • html/HTMLSourceElement.cpp:

(WebCore::HTMLSourceElement::insertedInto): Pass reference instead of pointer.
(WebCore::HTMLSourceElement::removedFrom): Ditto.
(WebCore::HTMLSourceElement::setSrc): Deleted.
(WebCore::HTMLSourceElement::media): Deleted.
(WebCore::HTMLSourceElement::setMedia): Deleted.
(WebCore::HTMLSourceElement::type): Deleted.
(WebCore::HTMLSourceElement::setType): Deleted.
(WebCore::HTMLSourceElement::parseAttribute): Clear out m_cachedParsedMediaAttribute.
This makes the parsing be lazy. The old code would parse the attribute value to make
a MediaQuerySet here, but we do it in parsedMediaAttribute now.
(WebCore::HTMLSourceElement::parsedMediaAttribute): Added. Creates a MediaQuerySet
if needed, and returns it or null.

  • html/HTMLSourceElement.h: Removed include of MediaList.h. Removed unneeded media,

type, setSrc, setMedia, and setType functions. Replaced the mediaQuerySet function
with the parsedMediaAttribute, which returns a const pointer rather than non-const,
and is also non-inline because it lazily creates the MediaQuerySet as needed. Replaced
m_mediaQuerySet with m_cachedParsedMediaAttribute.

  • html/HTMLSourceElement.idl: Use [Reflect] for both type and media.
  • html/MediaDocument.cpp: Modernize the MediaDocumentParser constructor.

(WebCore::MediaDocumentParser::createDocumentStructure): Instead of setSrc, use
setAttributeWithoutSynchronization for the src attribute just as we do for all the
other attributes of the newly created video element.

  • html/MediaElementSession.cpp:

(WebCore::MediaElementSession::wirelessVideoPlaybackDisabled): Use reference to
value of attribute instead of copy to avoid reference count churn.

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::defaultSubstituteDataForURL): Ditto.

  • rendering/RenderThemeIOS.mm:

(WebCore::getAttachmentProgress): Ditto.

  • rendering/RenderThemeMac.mm:

(WebCore::AttachmentLayout::layOutSubtitle): Ditto.
(WebCore::RenderThemeMac::paintAttachment): Ditto.

  • svg/SVGHKernElement.cpp:

(WebCore::SVGHKernElement::buildHorizontalKerningPair): Ditto.

  • svg/SVGVKernElement.cpp:

(WebCore::SVGVKernElement::buildVerticalKerningPair): Ditto.

  • svg/animation/SVGSMILElement.cpp:

(WebCore::SVGSMILElement::buildPendingResource): Ditto. Also use parentElement
instead of writing out code that does exactly what it does.

Source/WebKit/mac:

  • WebView/WebHTMLRepresentation.mm:

(matchLabelsAgainstElement): Added handling of nullptr since nothing guarantees the
passed in element can't be null. Removed unnecessary conversion from NSString to String
and then back to NSString.

11:00 AM Changeset in webkit [217773] by weinig@apple.com
  • 41 edits
    38 adds
    4 deletes in trunk

Can't use Object.defineProperty() to add an item to a DOMStringMap or Storage
​https://bugs.webkit.org/show_bug.cgi?id=172687

Reviewed by Darin Adler.

Source/WebCore:

  • Adds support for generating the defineOwnProperty ClassInfo method table hook to add support for Object.defineProperty(). The implementation follows WebIDL section 3.9.3 DefineOwnProperty. (​https://heycam.github.io/webidl/#legacy-platform-object-defineownproperty)
  • Adds support for generating named setters in addition to the already supported indexed setters as much of the required work was needed to make defineOwnProperty work for those properties. This patch does not aim to follow WebIDL faithfully, but rather to generate as close to the custom code as possible. A follow up change will attempt to match WebIDL more closely (which will also require changes to GetOwnPropertySlot).
  • Removes the need for custom bindings in DOMStringMap, HTMLOptionsCollection and HTMLSelectElement. Gets us one function away from supporting Storage.
  • Tidies up generated headers a bit by grouping all the ClassInfo method table hooks together.
  • Removes support for CustomIndexedSetter, which is no longer used.

Test: js/dom/legacy-platform-object-defineOwnProperty.html

  • CMakeLists.txt:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSBindingsAllInOne.cpp:

Removed now unneeded custom bindings.

  • bindings/js/JSDOMStringMapCustom.cpp: Removed.
  • bindings/js/JSHTMLOptionsCollectionCustom.cpp: Removed.
  • bindings/js/JSHTMLSelectElementCustom.cpp: Removed.
  • bindings/js/JSHTMLSelectElementCustom.h: Removed.
  • bindings/js/JSStorageCustom.cpp:

(WebCore::JSStorage::putDelegate): Deleted.
Remove more code that is now generated.

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateIndexedGetter):

  • Add missing check for indexed setter operation when determining if the property should be ReadOnly.
  • Add support for custom implementation name, matching GenerateNamedGetter.
  • Convert to taking an outputArray and indent to allow more flexibility going forward.

(GenerateNamedGetter):

  • Add missing check for named setter operation when determining if the property should be ReadOnly.
  • Convert to taking an outputArray and indent to allow more flexibility going forward.

(GenerateGetOwnPropertySlotBody):

  • Convert to taking an outputArray and indent to allow more flexibility going forward.
  • Take over responsibility for checking and bailing if CustomGetOwnPropertySlot is set.

(GenerateGetOwnPropertySlotBodyByIndex):

  • Convert to taking an outputArray and indent to allow more flexibility going forward.
  • Take over responsibility for checking and bailing if CustomGetOwnPropertySlotByIndex is set.

(GenerateGetOwnPropertyNames):

  • Convert to taking an outputArray and indent to allow more flexibility going forward.
  • Take over responsibility for checking and bailing if CustomEnumerateProperty is set.

(GenerateInvokeIndexedPropertySetter):
Added. Implements the 'invoke an indexed property setter' algorithm (​https://heycam.github.io/webidl/#invoke-indexed-setter)

(GenerateInvokeNamedPropertySetter):
Added. Implements the 'invoke a named property setter' algorithm (​https://heycam.github.io/webidl/#invoke-named-setter)

(GeneratePut):
(GeneratePutByIndex):

  • Convert to taking an outputArray and indent to allow more flexibility going forward.
  • Take over responsibility for checking and bailing if CustomPut is set.
  • Adds support for CEReactions.
  • Adopts GenerateInvokeIndexedPropertySetter and GenerateInvokeNamedPropertySetter to simplify code.
  • Removes support for CustomIndexedSetter, which is no longer used.
  • Replaces use direct checking of OverrideBuiltins with check if any interface it inherits has it, which is how it is specified to work.

(GenerateIsUnforgeablePropertyName):
Added. Helper subroutine to generate a function that compares a property name
agains all the property names defined as Unforgeable on the interface. Used by
GenerateDefineOwnProperty.

(GenerateDefineOwnProperty):
Added. Implements section 3.9.3 DefineOwnProperty (​https://heycam.github.io/webidl/#legacy-platform-object-defineownproperty)
Adds support for CEReactions.

(GenerateDeletePropertyCommon):
Switch from getting OverrideBuiltins directly off the interface to using InheritsExtendedAttribute.

(GenerateNamedDeleterDefinition):
Switch signature to match peer generators.

(InstanceOverridesGetOwnPropertySlot):
Update for rename of JSCustomGetOwnPropertySlotAndDescriptor to CustomGetOwnPropertySlotAndDescriptor.

(InstanceOverridesGetOwnPropertySlotByIndex):
Added. Like InstanceOverridesGetOwnPropertySlot, but checks for the new CustomGetOwnPropertySlotByIndex
rather than CustomGetOwnPropertySlot.

(InstanceOverridesGetOwnPropertyNames):
Added. Moves complex predicate out of line.

(InstanceOverridesPut):
Removes now unused CustomIndexedSetter, and adds CustomPutFunction, which used to be checked separately.

(InstanceOverridesDefineOwnProperty):
Added.

(GenerateHeader):

  • Moves more structure flags together.
  • Simplifies predicates and moves the ClassInfo method table hooks together.

(GenerateImplementation):

  • Moves the ClassInfo method table hooks together
  • Adds call to GenerateDefineOwnProperty.

(GenerateLegacyCallerDefinitions):
Simplify bail condition to match other generators.

(GeneratePrototypeDeclaration):
Update for new extended attribute names.

(InstanceOverridesCall):
Renamed from IsCallable for consistency.

(HasComplexGetOwnProperty):
Deleted. Unused.

(InstanceOverridesPutImplementation):
Deleted. Unused.

(InstanceOverridesPutDeclaration):
Deleted. Unused.

(IsCallable):
Renamed, for consistency, to InstanceOverridesCall .

  • bindings/scripts/IDLAttributes.json:

Renames a few of the extended attributes to remove the JS prefix. This time
around I only did the ones in the area I was working, but we should probably
remove most of the rest.

  • css/CSSStyleDeclaration.idl:

Update for JSCustomGetOwnPropertySlotAndDescriptor -> CustomGetOwnPropertySlotAndDescriptor rename.

  • dom/DOMStringMap.idl:

Remove CustomNamedSetter and add uncomment out the setter.

  • dom/DatasetDOMStringMap.cpp:

(WebCore::DatasetDOMStringMap::setNamedItem):
(WebCore::DatasetDOMStringMap::setItem): Deleted.

  • dom/DatasetDOMStringMap.h:

Rename setItem to setNamedItem, which is what the generator expects.

  • dom/Node.idl:

Update for JSCustomPushEventHandlerScope -> CustomPushEventHandlerScope rename.

  • html/HTMLAppletElement.idl:
  • html/HTMLEmbedElement.idl:
  • html/HTMLObjectElement.idl:

Update for JSCustomGetOwnPropertySlotAndDescriptor -> CustomGetOwnPropertySlotAndDescriptor rename.

  • html/HTMLCollection.cpp:

(WebCore::HTMLCollection::isSupportedPropertyName):

  • html/HTMLCollection.h:

Add isSupportedPropertyName function which is used by the bindings and is now needed.

  • html/HTMLElement.idl:

Update for JSCustomPushEventHandlerScope -> CustomPushEventHandlerScope rename.

  • html/HTMLOptionsCollection.h:

(WebCore::HTMLOptionsCollection::setItem):
Add setItem() implementation which just forwards to the select element. Also, add
a type alias to make the implementations of item and namedItem less verbose.

  • html/HTMLOptionsCollection.idl:

Remove CustomIndexedSetter and uncomment the setter.

  • html/HTMLSelectElement.idl:

Remove CustomIndexedSetter and uncomment the setter. Also, reformat
to match the WHATWG spec.

  • page/DOMWindow.idl:

Update for JSCustomDefineOwnProperty -> CustomDefineOwnProperty rename. Add
CustomGetOwnPropertySlotByIndex which is now needed to remove some unsound
assumptions the generator was making.

  • page/Location.idl:

Update for removal of JS prefix from a bunch of extended attributes.

  • page/UserMessageHandlersNamespace.idl:

Update for JSCustomGetOwnPropertySlotAndDescriptor -> CustomGetOwnPropertySlotAndDescriptor rename.

  • storage/Storage.idl:

Remove CustomNamedSetter and uncomment the setter.

  • bindings/scripts/test/JS/JSInterfaceName.h:
  • bindings/scripts/test/JS/JSTestEventTarget.h:
  • bindings/scripts/test/JS/JSTestIndexedSetterNoIdentifier.cpp: Added.
  • bindings/scripts/test/JS/JSTestIndexedSetterNoIdentifier.h: Added.
  • bindings/scripts/test/JS/JSTestIndexedSetterThrowingException.cpp: Added.
  • bindings/scripts/test/JS/JSTestIndexedSetterThrowingException.h: Added.
  • bindings/scripts/test/JS/JSTestIndexedSetterWithIdentifier.cpp: Added.
  • bindings/scripts/test/JS/JSTestIndexedSetterWithIdentifier.h: Added.
  • bindings/scripts/test/JS/JSTestInterface.cpp:
  • bindings/scripts/test/JS/JSTestNamedAndIndexedSetterNoIdentifier.cpp: Added.
  • bindings/scripts/test/JS/JSTestNamedAndIndexedSetterNoIdentifier.h: Added.
  • bindings/scripts/test/JS/JSTestNamedAndIndexedSetterThrowingException.cpp: Added.
  • bindings/scripts/test/JS/JSTestNamedAndIndexedSetterThrowingException.h: Added.
  • bindings/scripts/test/JS/JSTestNamedAndIndexedSetterWithIdentifier.cpp: Added.
  • bindings/scripts/test/JS/JSTestNamedAndIndexedSetterWithIdentifier.h: Added.
  • bindings/scripts/test/JS/JSTestNamedDeleterNoIdentifier.h:
  • bindings/scripts/test/JS/JSTestNamedDeleterThrowingException.h:
  • bindings/scripts/test/JS/JSTestNamedDeleterWithIdentifier.cpp:
  • bindings/scripts/test/JS/JSTestNamedDeleterWithIdentifier.h:
  • bindings/scripts/test/JS/JSTestNamedDeleterWithIndexedGetter.h:
  • bindings/scripts/test/JS/JSTestNamedSetterNoIdentifier.cpp: Added.
  • bindings/scripts/test/JS/JSTestNamedSetterNoIdentifier.h: Added.
  • bindings/scripts/test/JS/JSTestNamedSetterThrowingException.cpp: Added.
  • bindings/scripts/test/JS/JSTestNamedSetterThrowingException.h: Added.
  • bindings/scripts/test/JS/JSTestNamedSetterWithIdentifier.cpp: Added.
  • bindings/scripts/test/JS/JSTestNamedSetterWithIdentifier.h: Added.
  • bindings/scripts/test/JS/JSTestNamedSetterWithOverrideBuiltins.cpp: Added.
  • bindings/scripts/test/JS/JSTestNamedSetterWithOverrideBuiltins.h: Added.
  • bindings/scripts/test/JS/JSTestNamedSetterWithUnforgableProperties.cpp: Added.
  • bindings/scripts/test/JS/JSTestNamedSetterWithUnforgableProperties.h: Added.
  • bindings/scripts/test/JS/JSTestNamedSetterWithUnforgablePropertiesAndOverrideBuiltins.cpp: Added.
  • bindings/scripts/test/JS/JSTestNamedSetterWithUnforgablePropertiesAndOverrideBuiltins.h: Added.
  • bindings/scripts/test/JS/JSTestObj.cpp:
  • bindings/scripts/test/JS/JSTestObj.h:
  • bindings/scripts/test/JS/JSTestOverrideBuiltins.h:
  • bindings/scripts/test/TestIndexedSetterNoIdentifier.idl: Added.
  • bindings/scripts/test/TestIndexedSetterThrowingException.idl: Added.
  • bindings/scripts/test/TestIndexedSetterWithIdentifier.idl: Added.
  • bindings/scripts/test/TestNamedAndIndexedSetterNoIdentifier.idl: Added.
  • bindings/scripts/test/TestNamedAndIndexedSetterThrowingException.idl: Added.
  • bindings/scripts/test/TestNamedAndIndexedSetterWithIdentifier.idl: Added.
  • bindings/scripts/test/TestNamedDeleterWithIdentifier.idl:
  • bindings/scripts/test/TestNamedSetterNoIdentifier.idl: Added.
  • bindings/scripts/test/TestNamedSetterThrowingException.idl: Added.
  • bindings/scripts/test/TestNamedSetterWithIdentifier.idl: Added.
  • bindings/scripts/test/TestNamedSetterWithOverrideBuiltins.idl: Added.
  • bindings/scripts/test/TestNamedSetterWithUnforgableProperties.idl: Added.
  • bindings/scripts/test/TestNamedSetterWithUnforgablePropertiesAndOverrideBuiltins.idl: Added.

Added new tests and updated some results.

LayoutTests:

  • js/dom/legacy-platform-object-defineOwnProperty-expected.txt: Added.
  • js/dom/legacy-platform-object-defineOwnProperty.html: Added.

New tests for Object.defineProperty on Storage and DOMStringMap.

  • js/dom/named-property-deleter.html:

Fix test which was deleting the wrong property. This doesn't change the result,
but is now actually testing the thing it meant to.

  • storage/domstorage/localstorage/delete-defineproperty-removal-expected.txt:
  • storage/domstorage/localstorage/delete-defineproperty-removal.html:

Convert to testharness.js and show that the results are now correct.

10:57 AM Changeset in webkit [217772] by Simon Fraser
  • 83 edits in trunk

Object bounding box wrong for some paths
​https://bugs.webkit.org/show_bug.cgi?id=172866

Reviewed by Tim Horton.
Source/WebCore:

RenderSVGShape::calculateObjectBoundingBox() should use boundingRect()
rather than fastBoundingRect(), because the latter includes control points.

Covered by existing tests.

  • rendering/svg/RenderSVGShape.cpp:

(WebCore::RenderSVGShape::calculateObjectBoundingBox):

LayoutTests:

So many new baselines.

  • platform/ios/svg/W3C-SVG-1.1-SE/paths-dom-02-f-expected.txt:
  • platform/ios/svg/W3C-SVG-1.1/animate-elem-06-t-expected.txt:
  • platform/ios/svg/W3C-SVG-1.1/animate-elem-08-t-expected.txt:
  • platform/ios/svg/W3C-SVG-1.1/animate-elem-83-t-expected.txt:
  • platform/ios/svg/W3C-SVG-1.1/filters-example-01-b-expected.txt:
  • platform/ios/svg/W3C-SVG-1.1/metadata-example-01-b-expected.txt:
  • platform/ios/svg/W3C-SVG-1.1/paths-data-01-t-expected.txt:
  • platform/ios/svg/W3C-SVG-1.1/paths-data-02-t-expected.txt:
  • platform/ios/svg/W3C-SVG-1.1/paths-data-03-f-expected.txt:
  • platform/ios/svg/W3C-SVG-1.1/paths-data-12-t-expected.txt:
  • platform/ios/svg/W3C-SVG-1.1/text-path-01-b-expected.txt:
  • platform/ios/svg/batik/text/longTextOnPath-expected.txt:
  • platform/ios/svg/batik/text/smallFonts-expected.txt:
  • platform/ios/svg/batik/text/textAnchor-expected.txt:
  • platform/ios/svg/batik/text/textDecoration-expected.txt:
  • platform/ios/svg/batik/text/textEffect-expected.txt:
  • platform/ios/svg/batik/text/textEffect2-expected.txt:
  • platform/ios/svg/batik/text/textEffect3-expected.txt:
  • platform/ios/svg/batik/text/textFeatures-expected.txt:
  • platform/ios/svg/batik/text/textGlyphOrientationHorizontal-expected.txt:
  • platform/ios/svg/batik/text/textLayout-expected.txt:
  • platform/ios/svg/batik/text/textLayout2-expected.txt:
  • platform/ios/svg/batik/text/textLength-expected.txt:
  • platform/ios/svg/batik/text/textOnPath-expected.txt:
  • platform/ios/svg/batik/text/textOnPathSpaces-expected.txt:
  • platform/ios/svg/batik/text/textPosition-expected.txt:
  • platform/ios/svg/batik/text/textPosition2-expected.txt:
  • platform/ios/svg/batik/text/textProperties-expected.txt:
  • platform/ios/svg/batik/text/textProperties2-expected.txt:
  • platform/ios/svg/batik/text/textStyles-expected.txt:
  • platform/ios/svg/batik/text/verticalText-expected.txt:
  • platform/ios/svg/batik/text/verticalTextOnPath-expected.txt:
  • platform/ios/svg/custom/broken-internal-references-expected.txt:
  • platform/ios/svg/custom/path-textPath-simulation-expected.txt:
  • platform/ios/svg/custom/relative-sized-use-on-symbol-expected.txt:
  • platform/ios/svg/custom/relative-sized-use-without-attributes-on-symbol-expected.txt:
  • platform/ios/svg/custom/second-inline-text-expected.txt:
  • platform/ios/svg/text/text-path-01-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1-SE/paths-dom-02-f-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-06-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-07-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-08-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-83-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/filters-example-01-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/metadata-example-01-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/paths-data-01-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/paths-data-02-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/paths-data-03-f-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/paths-data-12-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/text-path-01-b-expected.txt:
  • platform/mac/svg/batik/filters/filterRegions-expected.txt:
  • platform/mac/svg/batik/paints/patternPreserveAspectRatioA-expected.txt:
  • platform/mac/svg/batik/paints/patternRegionA-expected.txt:
  • platform/mac/svg/batik/paints/patternRegions-expected.txt:
  • platform/mac/svg/batik/text/smallFonts-expected.txt:
  • platform/mac/svg/batik/text/textAnchor-expected.txt:
  • platform/mac/svg/batik/text/textEffect2-expected.txt:
  • platform/mac/svg/batik/text/textEffect3-expected.txt:
  • platform/mac/svg/batik/text/textFeatures-expected.txt:
  • platform/mac/svg/batik/text/textGlyphOrientationHorizontal-expected.txt:
  • platform/mac/svg/batik/text/textLayout-expected.txt:
  • platform/mac/svg/batik/text/textLayout2-expected.txt:
  • platform/mac/svg/batik/text/textOnPathSpaces-expected.txt:
  • platform/mac/svg/batik/text/textPosition2-expected.txt:
  • platform/mac/svg/batik/text/textProperties-expected.txt:
  • platform/mac/svg/batik/text/textProperties2-expected.txt:
  • platform/mac/svg/batik/text/textStyles-expected.txt:
  • platform/mac/svg/custom/animate-path-morphing-expected.txt:
  • platform/mac/svg/custom/broken-internal-references-expected.txt:
  • platform/mac/svg/custom/path-textPath-simulation-expected.txt:
  • platform/mac/svg/custom/relative-sized-use-on-symbol-expected.txt:
  • platform/mac/svg/custom/relative-sized-use-without-attributes-on-symbol-expected.txt:
  • platform/mac/svg/custom/second-inline-text-expected.txt:
  • platform/mac/svg/dom/SVGPathSegList-segment-modification-expected.txt:
  • platform/mac/svg/hixie/perf/001-expected.txt:
  • platform/mac/svg/hixie/perf/002-expected.txt:
  • platform/mac/svg/text/text-path-01-b-expected.txt:
  • platform/mac/svg/zoom/page/zoom-svg-through-object-with-override-size-expected.txt:
  • svg/custom/control-points-for-S-and-T-expected.txt:
  • svg/custom/use-nested-transform-expected.txt:
9:38 AM Changeset in webkit [217771] by Konstantin Tokarev
  • 10 edits
    1 add in trunk/Source

Fix build of Windows-specific code with ICU 59.1
​https://bugs.webkit.org/show_bug.cgi?id=172729

Reviewed by Darin Adler.

Source/JavaScriptCore:

Fix conversions from WTF::String to wchar_t* and vice versa.

  • jsc.cpp:

(currentWorkingDirectory):
(fetchModuleFromLocalFileSystem):

  • runtime/DateConversion.cpp:

(JSC::formatDateTime):

Source/WebCore:

Fix conversions from WTF::String to wchar_t* and vice versa.
No new tests needed.

  • platform/graphics/win/MediaPlayerPrivateMediaFoundation.cpp:

(WebCore::mimeTypeCache):
(WebCore::MediaPlayerPrivateMediaFoundation::startCreateMediaSource):

Source/WebKit/win:

Fix conversions from WTF::String to wchar_t* and vice versa.

  • Plugins/PluginDatabaseWin.cpp:

(WebCore::addPluginPathsFromRegistry):
(WebCore::PluginDatabase::getPluginPathsInDirectories):
(WebCore::addMozillaPluginDirectories):
(WebCore::addWindowsMediaPlayerPluginDirectory):
(WebCore::addAdobeAcrobatPluginDirectory):
(WebCore::addJavaPluginDirectory):
(WebCore::safariPluginsDirectory):
(WebCore::addMacromediaPluginDirectories):

  • Plugins/PluginPackageWin.cpp:

(WebCore::getVersionInfo):
(WebCore::PluginPackage::fetchInfo):
(WebCore::PluginPackage::load):

  • Plugins/PluginViewWin.cpp:

(WebCore::PluginView::handlePostReadFile):

Source/WTF:

  • wtf/text/win/WCharStringExtras.h: Added new header file wuth helper

functions for conversion between WTF::String and wchart_t*.
(WTF::stringToNullTerminatedWChar):
(WTF::wcharToString):
(WTF::nullTerminatedWCharToString):

9:26 AM Changeset in webkit [217770] by Yusuke Suzuki
  • 2 edits in trunk/Source/JavaScriptCore

[JSC] Drop unnecessary USE(CF) guard for getenv
​https://bugs.webkit.org/show_bug.cgi?id=172903

Reviewed by Sam Weinig.

getenv is not related to USE(CF) and OS(UNIX). It seems that this
ifdef only hits in WinCairo, but WinCairo can use getenv.
Moreover, in VM::VM, we already use getenv without any ifdef guard.

This patch just drops it.

  • runtime/VM.cpp:

(JSC::enableAssembler):

9:21 AM Changeset in webkit [217769] by Yusuke Suzuki
  • 2 edits in trunk/Source/JavaScriptCore

[JSC] Drop OS(DARWIN) for uintptr_t type conflict
​https://bugs.webkit.org/show_bug.cgi?id=172904

Reviewed by Sam Weinig.

In non-Darwin environment, uintptr_t may have the same type
to uint64_t. We avoided the compile error by using OS(DARWIN).
But, since it depends on cstdint implementaion rather than OS, it is flaky.
Instead, we just use template parameter IntegralType.
And we describe the type constraint in a SFINAE manner.

  • dfg/DFGOpInfo.h:

(JSC::DFG::OpInfo::OpInfo):

8:51 AM Changeset in webkit [217768] by Jonathan Bedard
  • 7 edits in trunk/LayoutTests

Unreviewed test gardening

Gardening test expectations for layout tests on iOS device. Moving
expectations for tests which fail on Simulator but pass on device.

  • platform/ios-simulator-wk1/TestExpectations:
  • platform/ios-simulator-wk2/TestExpectations:
  • platform/ios-simulator/TestExpectations:
  • platform/ios-wk1/TestExpectations:
  • platform/ios-wk2/TestExpectations:
  • platform/ios/TestExpectations:
8:21 AM Changeset in webkit [217767] by Chris Dumez
  • 7 edits
    3 adds in trunk

Implement DOMMatrixReadOnly.transformPoint()
​https://bugs.webkit.org/show_bug.cgi?id=172900

Reviewed by Simon Fraser.

LayoutTests/imported/w3c:

Rebaseline W3C test now that more checks are passing.

  • web-platform-tests/css/geometry-1/DOMMatrix-newobject-expected.txt:

Source/WebCore:

Implement DOMMatrixReadOnly.transformPoint():

Test: imported/blink/fast/dom/geometry-interfaces-dom-matrix-transformPoint.html

  • css/DOMMatrixReadOnly.cpp:

(WebCore::DOMMatrixReadOnly::transformPoint):

  • css/DOMMatrixReadOnly.h:
  • css/DOMMatrixReadOnly.idl:

LayoutTests:

  • imported/blink/fast/dom/geometry-interfaces-dom-matrix-transformPoint-expected.txt: Added.
  • imported/blink/fast/dom/geometry-interfaces-dom-matrix-transformPoint.html: Added.
  • imported/blink/fast/dom/resources/geometry-interfaces-test-helpers.js: Added.

Import test coverage from Blink.

4:26 AM Changeset in webkit [217766] by zandobersek@gmail.com
  • 3 edits
    2 adds in trunk/LayoutTests

Unreviewed GTK+ gardening. Add a few test failure expectations, linking them to
existing bugs. Update or add GTK+-specific baselines for three tests.

  • platform/gtk/TestExpectations:
  • platform/gtk/accessibility/disabled-controls-not-focusable-expected.txt: Added.
  • platform/gtk/compositing/backing-store-attachment-1-expected.txt: Added.
  • platform/gtk/css1/box_properties/acid_test-expected.txt:
3:24 AM Changeset in webkit [217765] by zandobersek@gmail.com
  • 6 edits in trunk/Source/WebCore

[GCrypt] Improve comments in AES, PBKDF2, RSA-SSA algorithm implementations
​https://bugs.webkit.org/show_bug.cgi?id=172894

Reviewed by Michael Catanzaro.

Add or improve code comments in libgcrypt implementations for the AES_CBC,
AES_GCM, AES_KW, PBKDF2 and RSA-SSA algorithms.

  • crypto/gcrypt/CryptoAlgorithmAES_CBCGCrypt.cpp: Add generic comments that

describe each operation that's performed.
(WebCore::gcryptEncrypt):
(WebCore::gcryptDecrypt):

  • crypto/gcrypt/CryptoAlgorithmAES_GCMGCrypt.cpp: Ditto.

(WebCore::gcryptEncrypt):
(WebCore::gcryptDecrypt):

  • crypto/gcrypt/CryptoAlgorithmAES_KWGCrypt.cpp: Ditto.

(WebCore::gcryptWrapKey):
(WebCore::gcryptUnwrapKey):

  • crypto/gcrypt/CryptoAlgorithmPBKDF2GCrypt.cpp: Ditto.

(WebCore::gcryptDeriveBits):

  • crypto/gcrypt/CryptoAlgorithmRSASSA_PKCS1_v1_5GCrypt.cpp:

(WebCore::gcryptVerify): Align the verification results comment with the
one that's used in the ECDSA implementation.

Jun 3, 2017:

6:54 PM Changeset in webkit [217764] by Chris Dumez
  • 10 edits
    2 adds in trunk

Implement DOMMatrix's fromFloat32Array / fromFloat64Array & toFloat32Array / toFloat64Array
​https://bugs.webkit.org/show_bug.cgi?id=172898

Reviewed by Sam Weinig.

LayoutTests/imported/w3c:

Rebaseline web-platform-test now that more checks are passing.

  • web-platform-tests/css/geometry-1/DOMMatrix-newobject-expected.txt:

Source/WebCore:

Implement DOMMatrix's fromFloat32Array / fromFloat64Array & toFloat32Array / toFloat64Array
as per:

Test: http/wpt/geometry/DOMMatrix-from-to-typed-arrays.html

  • css/DOMMatrix.cpp:

(WebCore::DOMMatrix::fromFloat32Array):
(WebCore::DOMMatrix::fromFloat64Array):

  • css/DOMMatrix.h:
  • css/DOMMatrix.idl:
  • css/DOMMatrixReadOnly.cpp:

(WebCore::DOMMatrixReadOnly::fromFloat32Array):
(WebCore::DOMMatrixReadOnly::fromFloat64Array):
(WebCore::DOMMatrixReadOnly::toFloat32Array):
(WebCore::DOMMatrixReadOnly::toFloat64Array):

  • css/DOMMatrixReadOnly.h:
  • css/DOMMatrixReadOnly.idl:

LayoutTests:

Add layout test coverage.

  • http/wpt/geometry/DOMMatrix-from-to-typed-arrays-expected.txt: Added.
  • http/wpt/geometry/DOMMatrix-from-to-typed-arrays.html: Added.
2:09 PM Changeset in webkit [217763] by Simon Fraser
  • 12 edits
    1 copy
    3 adds in trunk

Implement DOMPointReadOnly.matrixTransform()
​https://bugs.webkit.org/show_bug.cgi?id=172896

Reviewed by Chris Dumez.

LayoutTests/imported/w3c:

New baselines.

  • web-platform-tests/css/geometry-1/DOMPoint-002-expected.txt:
  • web-platform-tests/css/geometry-1/historical-expected.txt:

Source/WebCore:

DOMPointReadOnly.matrixTransform() creates the matrix or throws, then uses
a new function in TransformationMatrix to map x,y,z,w through the matrix.

Test: http/wpt/geometry/DOMPoint-003.html

  • CMakeLists.txt:
  • WebCore.xcodeproj/project.pbxproj:
  • css/DOMMatrixReadOnly.h:

(WebCore::DOMMatrixReadOnly::transformationMatrix):

  • dom/DOMPointReadOnly.cpp: Copied from Source/WebCore/dom/DOMPointReadOnly.idl.

(WebCore::DOMPointReadOnly::matrixTransform):

  • dom/DOMPointReadOnly.h:
  • dom/DOMPointReadOnly.idl:
  • platform/graphics/transforms/TransformationMatrix.cpp:

(WebCore::TransformationMatrix::map4ComponentPoint):

  • platform/graphics/transforms/TransformationMatrix.h:

LayoutTests:

DOMPoint-003.html should be upstreamed at some point.

  • http/wpt/geometry/DOMPoint-003-expected.txt: Added.
  • http/wpt/geometry/DOMPoint-003.html: Added.
11:07 AM Changeset in webkit [217762] by mmaxfield@apple.com
  • 4 edits in trunk/Source/WebCore

Cleanup arguments to preparePlatformFont() and fontWithFamily() in FontCacheCoreText.cpp
​https://bugs.webkit.org/show_bug.cgi?id=172886

Reviewed by Simon Fraser.

The number of arguments is getting out of control.

No new tests because there is no behavior change.

  • platform/graphics/FontCache.h:
  • platform/graphics/cocoa/FontCacheCoreText.cpp:

(WebCore::preparePlatformFont):
(WebCore::fontWithFamily):
(WebCore::FontCache::createFontPlatformData):
(WebCore::FontCache::systemFallbackForCharacters):

  • platform/graphics/mac/FontCacheMac.mm:

(WebCore::platformFontWithFamilySpecialCase):

  • platform/graphics/mac/FontCustomPlatformData.cpp:

(WebCore::FontCustomPlatformData::fontPlatformData):

  • platform/spi/cocoa/CoreTextSPI.h:
10:58 AM Changeset in webkit [217761] by Jonathan Bedard
  • 2 edits in trunk/LayoutTests

Unreviewed test gardening

  • platform/ios/TestExpectations: Update expectation for tests passing

after ​https://bugs.webkit.org/show_bug.cgi?id=139968.

9:31 AM Changeset in webkit [217760] by Yusuke Suzuki
  • 9 edits
    4 adds in trunk

Script modules should be able to import data urls
​https://bugs.webkit.org/show_bug.cgi?id=171594

Reviewed by Youenn Fablet.

LayoutTests/imported/w3c:

  • web-platform-tests/html/semantics/scripting-1/the-script-element/data-url-expected.txt:
  • web-platform-tests/html/webappapis/scripting/processing-model-2/compile-error-data-url-expected.txt:
  • web-platform-tests/html/webappapis/scripting/processing-model-2/runtime-error-data-url-expected.txt:

Source/WebCore:

Tests: js/dom/classic-script-with-data-url.html

js/dom/modules/module-script-with-data-url.html

Script tag resources should have SameOriginDataURLFlag::Set to load data URLs
since script tags should treat data URLs as same origin.

  • bindings/js/CachedScriptFetcher.cpp:

(WebCore::CachedScriptFetcher::requestScriptWithCache):

LayoutTests:

  • http/tests/security/script-with-dataurl-expected.txt:
  • http/tests/security/script-with-dataurl.html:

Now, the spec is changed and errors from data: scripts should not be muted.
​https://github.com/whatwg/html/issues/1778

  • js/dom/classic-script-with-data-url-expected.txt: Added.
  • js/dom/classic-script-with-data-url.html: Added.
  • js/dom/modules/module-script-with-data-url-expected.txt: Added.
  • js/dom/modules/module-script-with-data-url.html: Added.
9:21 AM Changeset in webkit [217759] by Simon Fraser
  • 4 edits in trunk/Source

Sort the project file.

Source/WebCore:

  • WebCore.xcodeproj/project.pbxproj:

Source/WebKit2:

  • WebKit2.xcodeproj/project.pbxproj:
9:11 AM Changeset in webkit [217758] by Jonathan Bedard
  • 3 edits in trunk/Tools

webkitpy: Add contextmanager to disable logging for a block
​https://bugs.webkit.org/show_bug.cgi?id=172876

Reviewed by Daniel Bates.

Add a context manager which will use an OutputCapture object to capture logging
in a block and hold it in a variable.

  • Scripts/webkitpy/common/system/outputcapture.py:

(OutputCaptureScope):
(OutputCaptureScope.init): Construct with OutputCapture object.
(OutputCaptureScope.enter): Begin capturing output.
(OutputCaptureScope.exit): Restore output and save captured output to a variable.
output and retain the resulting log.

  • Scripts/webkitpy/common/system/outputcapture_unittest.py:

(OutputCaptureTest.test_output_capture_scope): Added.

8:26 AM Changeset in webkit [217757] by Jonathan Bedard
  • 3 edits in trunk/LayoutTests

Move css3/flexbox/image-percent-max-height.html failure expectation.
​https://bugs.webkit.org/show_bug.cgi?id=126898

Unreviewed test gardening

css3/flexbox/image-percent-max-height.html fails on iOS-simulator,
but passes on device.

  • platform/ios-simulator/TestExpectations:
  • platform/ios/TestExpectations:
6:36 AM Changeset in webkit [217756] by Csaba Osztrogonác
  • 2 edits in trunk/Source/JavaScriptCore

[ARM] Unreviewed buildfix after r217711.

  • assembler/MacroAssemblerARM.h:

(JSC::MacroAssemblerARM::xor32):

4:24 AM Changeset in webkit [217755] by Yusuke Suzuki
  • 4 edits
    1 add in trunk

ASSERTION FAILED: "We should only declare a function as a lexically scoped variable in scopes where var declarations aren't allowed. ..." for function redeclaration with async function module export
​https://bugs.webkit.org/show_bug.cgi?id=168844

Reviewed by Saam Barati.

JSTests:

  • modules/async-function-export.js: Added.

(f):
(export.async.f):

Source/JavaScriptCore:

As the same to the exported function declaration, we should set statementDepth = 1 for exported async function declaration.

  • parser/Parser.cpp:

(JSC::DepthManager::DepthManager):
(JSC::Parser<LexerType>::parseExportDeclaration):

  • parser/Parser.h:

(JSC::Parser::DepthManager::DepthManager): Deleted.
(JSC::Parser::DepthManager::~DepthManager): Deleted.

3:29 AM Changeset in webkit [217754] by zandobersek@gmail.com
  • 7 edits
    1 add in trunk/Source/WebCore

[GCrypt] Gather SUBTLE_CRYPTO utility functions in a single header
​https://bugs.webkit.org/show_bug.cgi?id=172870

Reviewed by Jiewen Tan.

Gather the helper functions used across different source files
for libgcrypt-backed SUBTLE_CRYPTO implementations in a single
header file.

  • crypto/gcrypt/CryptoAlgorithmECDSAGCrypt.cpp:

(WebCore::hashCryptoDigestAlgorithm): Deleted.
(WebCore::hashAlgorithmName): Deleted.
(WebCore::mpiData): Deleted.

  • crypto/gcrypt/CryptoAlgorithmHKDFGCrypt.cpp:

(WebCore::gcryptDeriveBits):
(WebCore::macAlgorithmForHashFunction): Deleted.

  • crypto/gcrypt/CryptoAlgorithmPBKDF2GCrypt.cpp:

(WebCore::gcryptDeriveBits):

  • crypto/gcrypt/CryptoAlgorithmRSAES_PKCS1_v1_5GCrypt.cpp:

(WebCore::mpiData): Deleted.

  • crypto/gcrypt/CryptoAlgorithmRSASSA_PKCS1_v1_5GCrypt.cpp:

(WebCore::hashCryptoDigestAlgorithm): Deleted.
(WebCore::hashAlgorithmName): Deleted.
(WebCore::mpiData): Deleted.

  • crypto/gcrypt/CryptoAlgorithmRSA_OAEPGCrypt.cpp:

(WebCore::hashAlgorithmName): Deleted.
(WebCore::mpiData): Deleted.

  • crypto/gcrypt/GCryptUtilities.h: Added.

(WebCore::hashAlgorithmName):
(WebCore::hmacAlgorithm):
(WebCore::digestAlgorithm):
(WebCore::hashCryptoDigestAlgorithm):
(WebCore::mpiData):

3:27 AM Changeset in webkit [217753] by zandobersek@gmail.com
  • 2 edits in trunk/Source/WebCore

[GCrypt] Fix PK verification for ECDSA
​https://bugs.webkit.org/show_bug.cgi?id=172857

Reviewed by Michael Catanzaro.

No new tests -- covered by existing tests.

  • crypto/gcrypt/CryptoAlgorithmECDSAGCrypt.cpp:

(WebCore::gcryptVerify): Return true if the verification succeeded or false
in any other case, avoiding spilling information about the exact cause of
verification failure.

1:07 AM Changeset in webkit [217752] by Chris Dumez
  • 3 edits in trunk/LayoutTests

http/tests/cache/disk-cache/shattered-deduplication.html is flaky
​https://bugs.webkit.org/show_bug.cgi?id=172868
<rdar://problem/31249379>

Reviewed by Antti Koivisto.

http/tests/cache/disk-cache/shattered-deduplication.html was flaky due to PDF banner
fade-in / fade-out animation.

<rdar://problem/31249379> is fixed for me with the proposed changes.

  • http/tests/cache/disk-cache/shattered-deduplication-expected.html:
  • Wait 1 second before calling notifyDone() to give the PDF as much time to render as

the test page.

  • Reduce frame height to 30 to not have to worry about the PDF tool banner being visible or not (as it fades in and out). 30 is still enough to see the color and confirm the test is passing.
  • http/tests/cache/disk-cache/shattered-deduplication.html:
  • Reduce frame height to 30 to not have to worry about the PDF tool banner being visible or not (as it fades in and out). 30 is still enough to see the color and confirm the test is passing.
Note: See TracTimeline for information about the timeline view.