Timeline

Jul 5, 2017:

10:51 PM Changeset in webkit [219191] by don.olmstead@sony.com

• 154 edits
  1 copy
  2 moves in trunk

[WTF] Move SoftLinking.h into WTF
​https://bugs.webkit.org/show_bug.cgi?id=174000

Reviewed by Alex Christensen.

Source/WebCore:

No new tests. No change in functionality

• Modules/applepay/PaymentRequest.cpp:
• Modules/applepay/cocoa/PaymentContactCocoa.mm:
• Modules/applepay/cocoa/PaymentMerchantSessionCocoa.mm:
• Modules/encryptedmedia/legacy/LegacyCDMPrivateMediaPlayer.cpp:
• WebCore.xcodeproj/project.pbxproj:
• editing/cocoa/EditorCocoa.mm:
• editing/cocoa/HTMLConverter.mm:
• editing/ios/EditorIOS.mm:
• page/CaptionUserPreferencesMediaAF.cpp:
• page/cocoa/SettingsCocoa.mm:
• page/ios/UserAgentIOS.mm:
• page/mac/ServicesOverlayController.mm:
• platform/audio/ios/AudioDestinationIOS.cpp:
• platform/audio/ios/AudioFileReaderIOS.cpp:
• platform/audio/ios/AudioSessionIOS.mm:
• platform/audio/ios/MediaSessionManagerIOS.mm:
• platform/cf/CoreMediaSoftLink.cpp:
• platform/cf/CoreMediaSoftLink.h:
• platform/cf/MediaAccessibilitySoftLink.cpp:
• platform/cf/MediaAccessibilitySoftLink.h:
• platform/cocoa/ContentFilterUnblockHandlerCocoa.mm:
• platform/cocoa/CoreVideoSoftLink.cpp:
• platform/cocoa/CoreVideoSoftLink.h:
• platform/cocoa/DataDetectorsCoreSoftLink.h:
• platform/cocoa/NetworkExtensionContentFilter.mm:
• platform/cocoa/ParentalControlsContentFilter.mm:
• platform/cocoa/TelephoneNumberDetectorCocoa.cpp:
• platform/cocoa/VideoToolboxSoftLink.cpp:
• platform/cocoa/VideoToolboxSoftLink.h:
• platform/cocoa/WebPlaybackSessionModelMediaElement.mm:
• platform/cocoa/WebVideoFullscreenModelVideoElement.mm:
• platform/gamepad/cocoa/GameControllerGamepadProvider.mm:
• platform/graphics/avfoundation/AVTrackPrivateAVFObjCImpl.mm:
• platform/graphics/avfoundation/MediaPlaybackTargetMac.mm:
• platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:
• platform/graphics/avfoundation/MediaSelectionGroupAVFObjC.mm:
• platform/graphics/avfoundation/cf/AVFoundationCFSoftLinking.h:
• platform/graphics/avfoundation/cf/CDMSessionAVFoundationCF.cpp:
• platform/graphics/avfoundation/cf/InbandTextTrackPrivateAVCF.cpp:
• platform/graphics/avfoundation/cf/InbandTextTrackPrivateLegacyAVCF.cpp:
• platform/graphics/avfoundation/cf/WebCoreAVCFResourceLoader.cpp:
• platform/graphics/avfoundation/objc/CDMSessionAVContentKeySession.mm:
• platform/graphics/avfoundation/objc/CDMSessionAVFoundationObjC.mm:
• platform/graphics/avfoundation/objc/CDMSessionAVStreamSession.mm:
• platform/graphics/avfoundation/objc/InbandTextTrackPrivateAVFObjC.mm:
• platform/graphics/avfoundation/objc/InbandTextTrackPrivateLegacyAVFObjC.mm:
• platform/graphics/avfoundation/objc/MediaPlaybackTargetPickerMac.mm:
• platform/graphics/avfoundation/objc/MediaSourcePrivateAVFObjC.mm:
• platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm:
• platform/graphics/avfoundation/objc/WebCoreAVFResourceLoader.mm:
• platform/graphics/ca/cocoa/PlatformCALayerCocoa.mm:
• platform/graphics/ca/win/WKCACFViewLayerTreeHost.cpp:
• platform/graphics/cocoa/FontCascadeCocoa.mm:
• platform/graphics/cocoa/FontFamilySpecificationCoreText.cpp:
• platform/graphics/cv/PixelBufferConformerCV.cpp:
• platform/graphics/ios/FontCacheIOS.mm:
• platform/graphics/mac/ComplexTextControllerCoreText.mm:
• platform/graphics/mac/FontCacheMac.mm:
• platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
• platform/graphics/mac/MediaTimeQTKit.mm:
• platform/graphics/mac/PDFDocumentImageMac.mm:
• platform/graphics/win/MediaPlayerPrivateMediaFoundation.cpp:
• platform/ios/DragImageIOS.mm:
• platform/ios/PlatformPasteboardIOS.mm:
• platform/ios/PlatformScreenIOS.mm:
• platform/ios/PlatformSpeechSynthesizerIOS.mm:
• platform/ios/QuickLookSoftLink.h:
• platform/ios/QuickLookSoftLink.mm:
• platform/ios/RemoteCommandListenerIOS.mm:
• platform/ios/ThemeIOS.mm:
• platform/ios/ValidationBubbleIOS.mm:
• platform/ios/WebCoreMotionManager.mm:
• platform/ios/WebItemProviderPasteboard.mm:
• platform/ios/WebVideoFullscreenControllerAVKit.mm:
• platform/mac/DragImageMac.mm:
• platform/mac/MediaRemoteSoftLink.cpp:
• platform/mac/MediaRemoteSoftLink.h:
• platform/mac/SerializedPlatformRepresentationMac.mm:
• platform/mac/WebPlaybackControlsManager.mm:
• platform/mac/WebVideoFullscreenController.mm:
• platform/mediastream/ios/AVAudioSessionCaptureDeviceManager.mm:
• platform/mediastream/ios/CoreAudioCaptureSourceIOS.mm:
• platform/mediastream/libwebrtc/H264VideoToolBoxEncoder.mm:
• platform/mediastream/mac/AVCaptureDeviceManager.mm:
• platform/network/cf/CookieJarCFNet.cpp:
• platform/network/ios/NetworkStateNotifierIOS.mm:
• platform/network/ios/PreviewConverter.mm:
• platform/network/mac/BlobDataFileReferenceMac.mm:
• platform/spi/cocoa/AVKitSPI.h:

(-[AVTouchBarPlaybackControlsControlling NS_ENUM]): Deleted.

• platform/spi/cocoa/NSAttributedStringSPI.h:
• platform/spi/ios/DataDetectorsUISPI.h:
• platform/spi/mac/AVFoundationSPI.h:
• platform/spi/mac/DataDetectorsSPI.h:
• platform/spi/mac/LookupSPI.h:
• platform/spi/mac/TUCallSPI.h:
• platform/win/ScrollbarThemeWin.cpp:
• rendering/RenderThemeCocoa.mm:
• rendering/RenderThemeIOS.mm:
• rendering/RenderThemeWin.cpp:
• testing/Internals.mm:
• xml/XSLStyleSheetLibxslt.cpp:
• xml/XSLTExtensions.cpp:
• xml/XSLTProcessorLibxslt.cpp:
• xml/XSLTUnicodeSort.cpp:

Source/WebKit/ios:

• Misc/WebGeolocationCoreLocationProvider.mm:
• WebView/WebPDFViewPlaceholder.mm:

Source/WebKit/mac:

• Plugins/WebNetscapePluginView.mm:
• Plugins/WebPluginController.mm:
• WebCoreSupport/WebInspectorClient.mm:
• WebView/WebFullScreenController.mm:
• WebView/WebImmediateActionController.mm:
• WebView/WebView.mm:

Source/WebKit/win:

• WebKitClassFactory.cpp:
• WebView.cpp:

Source/WebKit2:

• Platform/mac/StringUtilities.mm:
• Platform/spi/ios/ManagedConfigurationSPI.h:
• Shared/Cocoa/DataDetectionResult.mm:
• Shared/Cocoa/WebCoreArgumentCodersCocoa.mm:
• Shared/ios/InteractionInformationAtPosition.mm:
• Shared/ios/WebIconUtilities.mm:
• Shared/mac/CookieStorageShim.mm:
• Shared/mac/WebCoreArgumentCodersMac.mm:
• UIProcess/API/Cocoa/_WKElementAction.mm:
• UIProcess/ApplePay/cocoa/WebPaymentCoordinatorProxyCocoa.mm:
• UIProcess/ApplePay/ios/WebPaymentCoordinatorProxyIOS.mm:
• UIProcess/ApplePay/mac/WebPaymentCoordinatorProxyMac.mm:
• UIProcess/Cocoa/UIDelegate.mm:
• UIProcess/Cocoa/WebViewImpl.mm:
• UIProcess/Launcher/mac/ProcessLauncherMac.mm:
• UIProcess/ios/WKActionSheetAssistant.mm:
• UIProcess/ios/WKContentViewInteraction.mm:
• UIProcess/ios/forms/WKAirPlayRoutePicker.mm:
• UIProcess/ios/forms/WKFileUploadPanel.mm:
• UIProcess/mac/WKImmediateActionController.mm:
• UIProcess/mac/WebInspectorProxyMac.mm:
• WebProcess/WebPage/mac/PlatformCALayerRemoteCustom.mm:
• WebProcess/WebPage/mac/WebInspectorUIMac.mm:
• WebProcess/cocoa/WebProcessCocoa.mm:

Source/WTF:

• WTF.xcodeproj/project.pbxproj:
• wtf/SoftLinking.h: Copied from Source/WebCore/platform/ios/QuickLookSoftLink.mm.
• wtf/cocoa/SoftLinking.h: Renamed from Source/WebCore/platform/cocoa/SoftLinking.h.
• wtf/win/SoftLinking.h: Renamed from Source/WebCore/platform/win/SoftLinking.h.

Tools:

• DumpRenderTree/mac/TestRunnerMac.mm:
• Scripts/webkitpy/style/checkers/cpp_unittest.py:

(test_primary_header):
(ErrorCollector.init): Deleted.
(ErrorCollector.call): Deleted.
(ErrorCollector.results): Deleted.
(ErrorCollector.result_list): Deleted.
(ErrorCollector.verify_all_categories_are_seen): Deleted.
(MockIo.open): Deleted.
(CppFunctionsTest.test_convert_to_lower_with_underscores): Deleted.
(CppFunctionsTest.test_create_acronym): Deleted.
(CppFunctionsTest.test_is_c_or_objective_c): Deleted.
(CppFunctionsTest.test_parameter): Deleted.
(CppFunctionsTest.test_single_line_view): Deleted.
(CppFunctionsTest.test_create_skeleton_parameters): Deleted.
(CppFunctionsTest.test_find_parameter_name_index): Deleted.
(CppFunctionsTest.test_parameter_list): Deleted.
(CppFunctionsTest.test_check_parameter_against_text): Deleted.
(CppStyleTestBase.process_file_data): Deleted.
(CppStyleTestBase.perform_lint): Deleted.
(CppStyleTestBase.perform_single_line_lint): Deleted.
(CppStyleTestBase.perform_multi_line_lint): Deleted.
(CppStyleTestBase.perform_language_rules_check): Deleted.
(CppStyleTestBase.perform_function_lengths_check): Deleted.
(CppStyleTestBase.perform_pass_ptr_check): Deleted.
(CppStyleTestBase.perform_leaky_pattern_check): Deleted.
(CppStyleTestBase.perform_include_what_you_use): Deleted.
(CppStyleTestBase.perform_header_guard_check): Deleted.
(CppStyleTestBase.assert_lint): Deleted.
(CppStyleTestBase.assert_lint_one_of_many_errors_re): Deleted.
(CppStyleTestBase.assert_multi_line_lint): Deleted.
(CppStyleTestBase.assert_multi_line_lint_re): Deleted.
(CppStyleTestBase.assert_language_rules_check): Deleted.
(CppStyleTestBase.assert_include_what_you_use): Deleted.
(CppStyleTestBase.assert_header_guard): Deleted.
(CppStyleTestBase.assert_blank_lines_check): Deleted.
(CppStyleTestBase.assert_positions_equal): Deleted.
(FunctionDetectionTest.test_basic_function_detection): Deleted.
(FunctionDetectionTest.test_function_declaration_detection): Deleted.
(FunctionDetectionTest.test_pure_function_detection): Deleted.
(FunctionDetectionTest.test_override_and_final_function_detection): Deleted.
(FunctionDetectionTest.test_ignore_macros): Deleted.
(FunctionDetectionTest.test_non_functions): Deleted.
(FunctionDetectionTest.test_non_functions.Stuff): Deleted.
(FunctionDetectionTest.test_parameter_list): Deleted.
(Cpp11StyleTest.test_rvaule_reference_in_parameter_pack): Deleted.
(CppStyleTest.test_asm_lines_ignored): Deleted.
(CppStyleTest.test_get_line_width): Deleted.
(CppStyleTest.test_find_next_multi_line_comment_start): Deleted.
(CppStyleTest.test_find_next_multi_line_comment_end): Deleted.
(CppStyleTest.test_remove_multi_line_comments_from_range): Deleted.
(CppStyleTest.test_position): Deleted.
(CppStyleTest.test_rfind_in_lines): Deleted.
(CppStyleTest.test_close_expression): Deleted.
(CppStyleTest.test_spaces_at_end_of_line): Deleted.
(CppStyleTest.test_cstyle_cast): Deleted.
(CppStyleTest.test_runtime_casting): Deleted.
(CppStyleTest.test_runtime_selfinit): Deleted.
(CppStyleTest.test_runtime_rtti): Deleted.
(CppStyleTest.test_static_cast_readability): Deleted.
(CppStyleTest.test_check_for_unnamed_params): Deleted.
(CppStyleTest.void): Deleted.
(CppStyleTest.test_deprecated_cast): Deleted.
(CppStyleTest.test_mock_method): Deleted.
(CppStyleTest.test_sizeof_type): Deleted.
(CppStyleTest.cases): Deleted.
(CppStyleTest.for): Deleted.
(CppStyleTest.test_typedef_for_pointer_to_function): Deleted.
(CppStyleTest.test_typedef_for_pointer_to_function.void): Deleted.
(CppStyleTest.test_include_what_you_use_no_implementation_files): Deleted.
(CppStyleTest.test_include_what_you_use): Deleted.
(CppStyleTest.test_files_belong_to_same_module): Deleted.
(CppStyleTest.test_cleanse_line): Deleted.
(CppStyleTest.test_multi_line_comments): Deleted.
(CppStyleTest.test_multi_line_comments.Foo): Deleted.
(CppStyleTest.test_multiline_strings): Deleted.
(CppStyleTest.test_platformh_comments): Deleted.
(CppStyleTest.test_explicit_single_argument_constructors): Deleted.
(CppStyleTest.test_explicit_single_argument_constructors.Foo): Deleted.
(CppStyleTest.test_explicit_single_argument_constructors.Qualifier): Deleted.
(CppStyleTest.test_explicit_single_argument_constructors.definition): Deleted.
(CppStyleTest.test_slash_star_comment_on_single_line): Deleted.
(CppStyleTest.test_suspicious_usage_of_if): Deleted.
(CppStyleTest.test_suspicious_usage_of_memset): Deleted.
(CppStyleTest.test_check_posix_threading): Deleted.
(CppStyleTest.test_insecure_string_operations): Deleted.
(CppStyleTest.test_format_strings): Deleted.
(CppStyleTest.test_insecure_temp_file): Deleted.
(CppStyleTest.test_variable_length_array_detection): Deleted.
(CppStyleTest.test_braces): Deleted.
(CppStyleTest.test_check_check): Deleted.
(CppStyleTest.test_brace_at_begin_of_line): Deleted.
(CppStyleTest.test_mismatching_spaces_in_parens): Deleted.
(CppStyleTest.test_spacing_for_fncall): Deleted.
(CppStyleTest.test_spacing_for_fncall.foo): Deleted.
(CppStyleTest.test_spacing_before_braces): Deleted.
(CppStyleTest.test_spacing_between_braces): Deleted.
(CppStyleTest.test_spacing_before_brackets): Deleted.
(CppStyleTest.test_cpp_lambda_functions): Deleted.
(CppStyleTest.test_objective_c_block): Deleted.
(CppStyleTest.test_objective_c_block_as_argument): Deleted.
(CppStyleTest.test_spacing_around_else): Deleted.
(CppStyleTest.test_spacing_for_binary_ops): Deleted.
(CppStyleTest.test_spacing_for_binary_ops.hash_map): Deleted.
(CppStyleTest.test_operator_methods): Deleted.
(CppStyleTest.test_spacing_in_objective_c_properties): Deleted.
(CppStyleTest.test_spacing_before_last_semicolon): Deleted.
(CppStyleTest.test_static_or_global_stlstrings): Deleted.
(CppStyleTest.test_no_spaces_in_function_calls): Deleted.
(CppStyleTest.test_one_spaces_between_code_and_comments): Deleted.
(CppStyleTest.test_one_spaces_after_punctuation_in_comments): Deleted.
(CppStyleTest.test_space_after_comment_marker): Deleted.
(CppStyleTest.test_newline_at_eof): Deleted.
(CppStyleTest.test_newline_at_eof.do_test): Deleted.
(CppStyleTest.test_extra_newlines_at_eof): Deleted.
(CppStyleTest.test_extra_newlines_at_eof.do_test): Deleted.
(CppStyleTest.test_invalid_utf8): Deleted.
(CppStyleTest.test_invalid_utf8.do_test): Deleted.
(CppStyleTest.test_is_blank_line): Deleted.
(CppStyleTest.test_blank_lines_check): Deleted.
(CppStyleTest.test_allow_blank_line_before_closing_namespace): Deleted.
(CppStyleTest.test_allow_blank_line_before_if_else_chain): Deleted.
(CppStyleTest.test_else_on_same_line_as_closing_braces): Deleted.
(CppStyleTest.test_else_clause_not_on_same_line_as_else): Deleted.
(CppStyleTest.test_comma): Deleted.
(CppStyleTest.test_declaration): Deleted.
(CppStyleTest.test_pointer_reference_marker_location): Deleted.
(CppStyleTest.test_indent): Deleted.
(CppStyleTest.test_indent.Foo): Deleted.
(CppStyleTest.test_not_alabel): Deleted.
(CppStyleTest.test_tab): Deleted.
(CppStyleTest.test_unnamed_namespaces_in_headers): Deleted.
(CppStyleTest.test_build_class): Deleted.
(CppStyleTest.test_build_class.definitions): Deleted.
(CppStyleTest.test_build_class.Foo): Deleted.
(CppStyleTest.test_build_class.DERIVE_FROM_GOO): Deleted.
(CppStyleTest.test_build_end_comment): Deleted.
(CppStyleTest.test_build_forward_decl): Deleted.
(CppStyleTest.test_build_forward_decl.Foo): Deleted.
(CppStyleTest.test_build_header_guard): Deleted.
(CppStyleTest.test_build_header_guard.Foo_h): Deleted.
(CppStyleTest.test_build_header_guard.Foo_h.for): Deleted.
(CppStyleTest.test_build_printf_format): Deleted.
(CppStyleTest.test_runtime_printf_format): Deleted.
(CppStyleTest.assert_lintLogCodeOnError): Deleted.
(CppStyleTest.test_build_storage_class): Deleted.
(CppStyleTest.test_build_storage_class.unsignedLongLong): Deleted.
(CppStyleTest.test_build_storage_class.declaration): Deleted.
(CppStyleTest.test_build_storage_class.after): Deleted.
(CppStyleTest.test_build_storage_class.is): Deleted.
(CppStyleTest.test_legal_copyright): Deleted.
(CppStyleTest.test_invalid_increment): Deleted.
(CppStyleTest.test_enum_bitfields): Deleted.
(CppStyleTest.test_plain_integral_bitfields): Deleted.
(CleansedLinesTest.test_init_empty): Deleted.
(CleansedLinesTest.test_collapse_strings): Deleted.
(OrderOfIncludesTest.tearDown): Deleted.
(OrderOfIncludesTest.test_check_next_include_orderno_config): Deleted.
(OrderOfIncludesTest.test_check_next_include_orderno_self): Deleted.
(OrderOfIncludesTest.test_check_next_include_orderlikely_then_config): Deleted.
(OrderOfIncludesTest.test_check_next_include_orderother_then_config): Deleted.
(OrderOfIncludesTest.test_check_next_include_orderconfig_then_other_then_likely): Deleted.
(OrderOfIncludesTest.test_check_alphabetical_include_order): Deleted.
(OrderOfIncludesTest.test_check_alphabetical_include_order_errors_reported_for_both_lines): Deleted.
(OrderOfIncludesTest.test_check_line_break_after_own_header): Deleted.
(OrderOfIncludesTest.test_check_line_break_before_own_header): Deleted.
(OrderOfIncludesTest.test_check_preprocessor_in_include_section): Deleted.
(OrderOfIncludesTest.test_check_preprocessor_in_include_section.BAZ): Deleted.
(OrderOfIncludesTest.test_check_preprocessor_in_include_section.FOOBAR): Deleted.
(OrderOfIncludesTest.test_primary_header): Deleted.
(OrderOfIncludesTest.test_public_primary_header): Deleted.
(OrderOfIncludesTest.test_check_wtf_includes): Deleted.
(OrderOfIncludesTest.test_classify_include): Deleted.
(OrderOfIncludesTest.test_try_drop_common_suffixes): Deleted.
(CheckForFunctionLengthsTest.tearDown): Deleted.
(CheckForFunctionLengthsTest.set_min_confidence): Deleted.
(CheckForFunctionLengthsTest.assert_function_lengths_check): Deleted.
(CheckForFunctionLengthsTest.trigger_lines): Deleted.
(CheckForFunctionLengthsTest.trigger_test_lines): Deleted.
(CheckForFunctionLengthsTest.assert_function_length_check_definition): Deleted.
(CheckForFunctionLengthsTest.assert_function_length_check_definition_ok): Deleted.
(CheckForFunctionLengthsTest.assert_function_length_check_at_error_level): Deleted.
(CheckForFunctionLengthsTest.assert_function_length_check_below_error_level): Deleted.
(CheckForFunctionLengthsTest.assert_function_length_check_above_error_level): Deleted.
(CheckForFunctionLengthsTest.function_body): Deleted.
(CheckForFunctionLengthsTest.function_body_with_blank_lines): Deleted.
(CheckForFunctionLengthsTest.function_body_with_no_lints): Deleted.
(CheckForFunctionLengthsTest.test_function_length_check_declaration): Deleted.
(CheckForFunctionLengthsTest.test_function_length_check_declaration_with_block_following): Deleted.
(CheckForFunctionLengthsTest.test_function_length_check_class_definition): Deleted.
(CheckForFunctionLengthsTest.test_function_length_check_class_definition.Test): Deleted.
(CheckForFunctionLengthsTest.test_function_length_check_trivial): Deleted.
(CheckForFunctionLengthsTest.test_function_length_check_empty): Deleted.
(CheckForFunctionLengthsTest.test_function_length_check_definition_below_severity0): Deleted.
(CheckForFunctionLengthsTest.test_function_length_check_definition_at_severity0): Deleted.
(CheckForFunctionLengthsTest.test_function_length_check_definition_above_severity0): Deleted.
(CheckForFunctionLengthsTest.test_function_length_check_definition_below_severity1v0): Deleted.
(CheckForFunctionLengthsTest.test_function_length_check_definition_at_severity1v0): Deleted.
(CheckForFunctionLengthsTest.test_function_length_check_definition_below_severity1): Deleted.
(CheckForFunctionLengthsTest.test_function_length_check_definition_at_severity1): Deleted.
(CheckForFunctionLengthsTest.test_function_length_check_definition_above_severity1): Deleted.
(CheckForFunctionLengthsTest.test_function_length_check_definition_severity1_plus_indented): Deleted.
(CheckForFunctionLengthsTest.test_function_length_check_definition_severity1_plus_blanks): Deleted.
(CheckForFunctionLengthsTest.test_function_length_check_complex_definition_severity1): Deleted.
(CheckForFunctionLengthsTest.test_function_length_check_definition_severity1_for_test): Deleted.
(CheckForFunctionLengthsTest.test_function_length_check_definition_severity1_for_split_line_test): Deleted.
(CheckForFunctionLengthsTest.test_function_length_check_definition_severity1_for_bad_test_doesnt_break): Deleted.
(CheckForFunctionLengthsTest.test_function_length_check_definition_severity1_with_embedded_no_lints): Deleted.
(CheckForFunctionLengthsTest.test_function_length_check_definition_severity1_with_no_lint): Deleted.
(CheckForFunctionLengthsTest.test_function_length_check_definition_below_severity2): Deleted.
(CheckForFunctionLengthsTest.test_function_length_check_definition_severity2): Deleted.
(CheckForFunctionLengthsTest.test_function_length_check_definition_above_severity2): Deleted.
(CheckForFunctionLengthsTest.test_function_length_check_definition_below_severity3): Deleted.
(CheckForFunctionLengthsTest.test_function_length_check_definition_severity3): Deleted.
(CheckForFunctionLengthsTest.test_function_length_check_definition_above_severity3): Deleted.
(CheckForFunctionLengthsTest.test_function_length_check_definition_below_severity4): Deleted.
(CheckForFunctionLengthsTest.test_function_length_check_definition_severity4): Deleted.
(CheckForFunctionLengthsTest.test_function_length_check_definition_above_severity4): Deleted.
(CheckForFunctionLengthsTest.test_function_length_check_definition_below_severity5): Deleted.
(CheckForFunctionLengthsTest.test_function_length_check_definition_at_severity5): Deleted.
(CheckForFunctionLengthsTest.test_function_length_check_definition_above_severity5): Deleted.
(CheckForFunctionLengthsTest.test_function_length_check_definition_huge_lines): Deleted.
(CheckForFunctionLengthsTest.test_function_length_not_determinable): Deleted.
(NoNonVirtualDestructorsTest.test_no_error): Deleted.
(NoNonVirtualDestructorsTest.test_no_error.Foo): Deleted.
(NoNonVirtualDestructorsTest.test_no_error.MyClass): Deleted.
(NoNonVirtualDestructorsTest.test_no_error.Qualified): Deleted.
(NoNonVirtualDestructorsTest.test_no_destructor_when_virtual_needed): Deleted.
(NoNonVirtualDestructorsTest.test_no_destructor_when_virtual_needed.Foo): Deleted.
(NoNonVirtualDestructorsTest.test_enum_casing): Deleted.
(NoNonVirtualDestructorsTest.test_enum_casing.Foo): Deleted.
(NoNonVirtualDestructorsTest.test_enum_casing.Enum123): Deleted.
(NoNonVirtualDestructorsTest.test_enum_trailing_semicolon): Deleted.
(NoNonVirtualDestructorsTest.test_enum_trailing_semicolon.CPP11EnumClass): Deleted.
(NoNonVirtualDestructorsTest.test_enum_trailing_semicolon.MyEnum): Deleted.
(NoNonVirtualDestructorsTest.test_destructor_non_virtual_when_virtual_needed): Deleted.
(NoNonVirtualDestructorsTest.test_destructor_non_virtual_when_virtual_needed.Foo): Deleted.
(NoNonVirtualDestructorsTest.test_no_warn_when_derived): Deleted.
(NoNonVirtualDestructorsTest.test_no_warn_when_derived.Foo): Deleted.
(NoNonVirtualDestructorsTest.test_internal_braces): Deleted.
(NoNonVirtualDestructorsTest.test_internal_braces.Foo): Deleted.
(NoNonVirtualDestructorsTest.test_inner_class_needs_virtual_destructor): Deleted.
(NoNonVirtualDestructorsTest.test_inner_class_needs_virtual_destructor.Foo): Deleted.
(NoNonVirtualDestructorsTest.test_inner_class_needs_virtual_destructor.Foo.Goo): Deleted.
(NoNonVirtualDestructorsTest.test_inner_class_needs_virtual_destructor.Goo): Deleted.
(NoNonVirtualDestructorsTest.test_outer_class_needs_virtual_destructor): Deleted.
(NoNonVirtualDestructorsTest.test_outer_class_needs_virtual_destructor.Foo): Deleted.
(NoNonVirtualDestructorsTest.test_outer_class_needs_virtual_destructor.Foo.Goo): Deleted.
(NoNonVirtualDestructorsTest.test_qualified_class_needs_virtual_destructor): Deleted.
(NoNonVirtualDestructorsTest.test_qualified_class_needs_virtual_destructor.Qualified): Deleted.
(NoNonVirtualDestructorsTest.test_multi_line_declaration_no_error): Deleted.
(NoNonVirtualDestructorsTest.test_multi_line_declaration_no_error.Foo): Deleted.
(NoNonVirtualDestructorsTest.test_multi_line_declaration_with_error): Deleted.
(NoNonVirtualDestructorsTest.test_multi_line_declaration_with_error.Foo): Deleted.
(LeakyPatternTest.assert_leaky_pattern_check): Deleted.
(LeakyPatternTest.test_get_dc): Deleted.
(LeakyPatternTest.test_get_dc.HWndDC): Deleted.
(LeakyPatternTest.test_own_get_dc): Deleted.
(LeakyPatternTest.test_create_dc): Deleted.
(LeakyPatternTest.test_create_compatible_dc): Deleted.
(WebKitStyleTest.test_indentation): Deleted.
(WebKitStyleTest.test_indentation.Foo): Deleted.
(WebKitStyleTest.test_indentation.Document): Deleted.
(WebKitStyleTest.test_spacing): Deleted.
(WebKitStyleTest.test_line_breaking): Deleted.
(WebKitStyleTest.test_braces): Deleted.
(WebKitStyleTest.test_braces.MyClass): Deleted.
(WebKitStyleTest.test_braces.NS_ENUM): Deleted.
(WebKitStyleTest.test_braces.CPP11EnumClass): Deleted.
(WebKitStyleTest.test_braces.SOMETHING): Deleted.
(WebKitStyleTest.test_null_false_zero): Deleted.
(WebKitStyleTest.test_directive_indentation): Deleted.
(WebKitStyleTest.test_using_std): Deleted.
(WebKitStyleTest.test_using_namespace): Deleted.
(WebKitStyleTest.test_max_macro): Deleted.
(WebKitStyleTest.test_min_macro): Deleted.
(WebKitStyleTest.test_wtf_move): Deleted.
(WebKitStyleTest.test_ctype_fucntion): Deleted.
(WebKitStyleTest.test_names): Deleted.
(WebKitStyleTest.test_names.HTMLDocument): Deleted.
(WebKitStyleTest.test_names.WebWindowFadeAnimation): Deleted.
(WebKitStyleTest.test_names.declarations): Deleted.
(WebKitStyleTest.test_names.struct): Deleted.
(WebKitStyleTest.test_names.VectorType): Deleted.
(WebKitStyleTest.test_parameter_names): Deleted.
(WebKitStyleTest.test_comments): Deleted.
(WebKitStyleTest.test_webkit_export_check): Deleted.
(WebKitStyleTest.test_member_initialization_list): Deleted.
(WebKitStyleTest.test_member_initialization_list.MyClass): Deleted.
(WebKitStyleTest.test_other): Deleted.
(CppCheckerTest.mock_handle_style_error): Deleted.
(CppCheckerTest._checker): Deleted.
(CppCheckerTest.test_init): Deleted.
(CppCheckerTest.test_eq): Deleted.
(CppCheckerTest.test_eq.mock_handle_style_error2): Deleted.
(CppCheckerTest.test_ne): Deleted.

• TestWebKitAPI/Tests/WebKit/ios/AudioSessionCategoryIOS.mm:
• TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
• TestWebKitAPI/cocoa/TestWKWebView.mm:
• TestWebKitAPI/ios/DataInteractionSimulator.mm:
• WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
• WebKitTestRunner/ios/HIDEventGenerator.mm:

10:49 PM Changeset in webkit [219190] by Alan Bujtas

• 3 edits
  2 adds in trunk

REGRESSION: Stack overflow in RenderBlockFlow::layoutBlock after increasing the font size to max in some RTL vertical books.
​https://bugs.webkit.org/show_bug.cgi?id=174144
<rdar://problem/32781038>

Reviewed by Simon Fraser.

Source/WebCore:

We set the start/end margin on the ruby renderer to support overhanging content. The margins ensure that
adjacent boxes on the line are placed properly respecting the overhanging content.
The line breaking algorithm also takes this value into account as it affects the line's available width.
We need to reset this value before laying out the lines, otherwise we might end up using this value on the line twice;
first as the renderer's margins (as the result of the previous layout) and second as the renderer's overhanging value.
Since this is not strictly part of the renderer's layout context (i.e. we set them during the line layout and not at
RenderRubyRun::layout) we can't rely on the ruby's layout logic to reset them.

Test: fast/ruby/ruby-overhang-margin-crash.html

• rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlockFlow::layoutLineBoxes):

LayoutTests:

• fast/ruby/ruby-overhang-margin-crash-expected.txt: Added.
• fast/ruby/ruby-overhang-margin-crash.html: Added.

10:33 PM Changeset in webkit [219189] by jmarcell@apple.com

• 2 edits in tags/Safari-604.1.29/Source/WebKit2

Cherry-pick r219157. rdar://problem/32956929

10:33 PM Changeset in webkit [219188] by jmarcell@apple.com

• 5 edits in tags/Safari-604.1.29/Source

Cherry-pick r219144. rdar://problem/33086744

10:01 PM Changeset in webkit [219187] by sbarati@apple.com

• 7 edits
  1 add in trunk

NewArray in FTLLowerDFGToB3 does not handle speculating on doubles when having a bad time
​https://bugs.webkit.org/show_bug.cgi?id=174188
<rdar://problem/30581423>

Reviewed by Mark Lam.

JSTests:

• stress/new-array-having-a-bad-time-double.js: Added.

(assert):
(foo):

Source/JavaScriptCore:

We were calling lowJSValue(edge) when we were speculating the
edge as double. This isn't allowed. We should have been using
lowDouble.

This patch also adds a new option, called useArrayAllocationProfiling,
which defaults to true. When false, it will make the array allocation
profile not actually sample seen arrays. It'll force the allocation
profile's predicted indexing type to be ArrayWithUndecided. Adding
this option made it trivial to write a test for this bug.

• bytecode/ArrayAllocationProfile.cpp:

(JSC::ArrayAllocationProfile::updateIndexingType):

• ftl/FTLLowerDFGToB3.cpp:

(JSC::FTL::DFG::LowerDFGToB3::compileNewArray):

• runtime/Options.h:

Tools:

• Scripts/run-jsc-stress-tests:

9:51 PM Changeset in webkit [219186] by Yusuke Suzuki

• 8 edits in trunk

Upgrade GCC baseline
​https://bugs.webkit.org/show_bug.cgi?id=174155

Reviewed by Michael Catanzaro.

.:

This patch bumps the version of GCC from 4.9.0 to 5.0.0,
which is shipped with Ubuntu 16.04 LTS. And the latest
Debian stable (stretch) already ships newer GCC (6.3.0).
Remove workaround for old GCC. And move GCC version check
to the top-level CMakeLists.txt.

• CMakeLists.txt:
• Source/cmake/OptionsGTK.cmake:
• Source/cmake/WebKitHelpers.cmake:

Source/WebCore:

Remove workaround for old GCC.

• CMakeLists.txt:

Source/WTF:

• wtf/Compiler.h:

8:42 PM Changeset in webkit [219185] by Devin Rousso

• 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Group Inspector Style Sheets as part of the Stylesheets folder
​https://bugs.webkit.org/show_bug.cgi?id=173435

Reviewed by Joseph Pecoraro.

• UserInterface/Views/ResourceSidebarPanel.js:

(WebInspector.ResourceSidebarPanel.prototype.matchTreeElementAgainstCustomFilters.match):
Add special case for CSSStyleSheetTreeElement.

7:59 PM Changeset in webkit [219184] by Chris Dumez

• 3 edits in trunk/Source/WebCore

Unreviewed attempt to fix iOS build after r219177.

• page/ios/UserAgentIOS.mm:
• platform/spi/ios/UIKitSPI.h:

7:49 PM Changeset in webkit [219183] by Chris Dumez

• 3 edits in trunk/Source/WebCore

Unreviewed attempt to fix iOS build after r219177.

• page/ios/UserAgentIOS.mm:
• platform/spi/ios/UIKitSPI.h:

7:31 PM Changeset in webkit [219182] by Yusuke Suzuki

• 3 edits
  1 add in trunk

WTF::StringImpl::copyChars segfaults when built with GCC 7
​https://bugs.webkit.org/show_bug.cgi?id=173407

Reviewed by Andreas Kling.

JSTests:

• stress/string-repeat-copy-chars-crash.js: Added.

(shouldBe):

Source/WTF:

With GCC 7, StringImpl::copyChars() behaves as unexpected.
This function violates strict aliasing rule.

This optimization is originally introduced to improve performance
in SunSpider's string tests in 2008. When running it in my Linux
box, it no longer causes any observable difference. So, we just
remove this optimization.

baseline patched

string-base64 7.7544+-0.1761 7.6138+-0.2071 might be 1.0185x faster
string-fasta 10.5429+-0.2746 ? 10.7500+-0.2669 ? might be 1.0196x slower
string-tagcloud 14.8588+-0.2828 14.8039+-0.3039
string-unpack-code 36.1769+-0.4251 35.3397+-0.5398 might be 1.0237x faster
string-validate-input 8.5182+-0.2206 8.3514+-0.2179 might be 1.0200x faster

• wtf/text/StringImpl.h:

(WTF::StringImpl::copyChars):

7:30 PM Changeset in webkit [219181] by commit-queue@webkit.org

• 2 edits in trunk/Source/bmalloc

reinterpret_cast does not evaluate to constexpr
​https://bugs.webkit.org/show_bug.cgi?id=173622

Patch by Daewoong Jang <​daewoong.jang@navercorp.com> on 2017-07-05
Reviewed by Yusuke Suzuki.

• bmalloc/Algorithm.h:

(bmalloc::mask):
(bmalloc::roundUpToMultipleOf):

7:29 PM Changeset in webkit [219180] by Devin Rousso

• 2 edits
  1 move
  1 add in trunk/Source/WebInspectorUI

Web Inspector: Split Canvas.svg into icons for 2D and 3D
​https://bugs.webkit.org/show_bug.cgi?id=174057

Reviewed by Matt Baker.

• UserInterface/Images/Canvas2D.svg: Added.
• UserInterface/Images/Canvas3D.svg: Renamed from Source/WebInspectorUI/UserInterface/Images/Canvas.svg.
• UserInterface/Views/ResourceIcons.css:

(.canvas.canvas-2d .icon):
(.canvas:matches(.webgl, .webgl2, .webgpu) .icon):
(.canvas .icon): Deleted.

7:27 PM Changeset in webkit [219179] by Yusuke Suzuki

• 8 edits in trunk/Source

Use std::lock_guard instead of std::unique_lock if move semantics and try_lock is not necessary
​https://bugs.webkit.org/show_bug.cgi?id=174148

Reviewed by Mark Lam.

Source/WebCore:

• platform/graphics/avfoundation/AudioSourceProviderAVFObjC.mm:

(WebCore::AudioSourceProviderAVFObjC::~AudioSourceProviderAVFObjC):

Source/WTF:

It is not necessary to use std::unique_lock if we do not use additional features compared to std::lock_guard.

(WTF::ThreadHolder::get):
(WTF::ThreadHolder::initialize):
(WTF::ThreadHolder::destruct):

• wtf/Threading.cpp:

(WTF::Thread::didExit):

• wtf/ThreadingPthreads.cpp:

(WTF::Thread::changePriority):
(WTF::Thread::waitForCompletion):
(WTF::Thread::detach):
(WTF::Thread::signal):
(WTF::Thread::resume):
(WTF::Thread::getRegisters):
(WTF::Thread::establish):

• wtf/ThreadingWin.cpp:

(WTF::Thread::changePriority):
(WTF::Thread::waitForCompletion):
(WTF::Thread::detach):
(WTF::Thread::resume):
(WTF::Thread::getRegisters):
(WTF::Thread::establish):

• wtf/WordLock.cpp:

(WTF::WordLockBase::unlockSlow):

7:02 PM Changeset in webkit [219178] by Yusuke Suzuki

• 147 edits
  1 delete in trunk

[WTF] Clean up StringStatics.cpp by using LazyNeverDestroyed<> for Atoms
​https://bugs.webkit.org/show_bug.cgi?id=174150

Reviewed by Mark Lam.

Source/WebCore:

• Modules/mediacontrols/MediaControlsHost.cpp:

(WebCore::MediaControlsHost::captionDisplayMode):

• Modules/mediastream/RTCDataChannel.cpp:

(WebCore::RTCDataChannel::binaryType):

• accessibility/AXObjectCache.cpp:

(WebCore::createFromRenderer):

• accessibility/AccessibilityMediaControls.cpp:

(WebCore::AccessibilityMediaControl::controlTypeName):

• accessibility/AccessibilityObject.cpp:

(WebCore::AccessibilityObject::language):
(WebCore::AccessibilityObject::defaultLiveRegionStatusForRole):
(WebCore::AccessibilityObject::actionVerb):
(WebCore::AccessibilityObject::getAttribute):
(WebCore::AccessibilityObject::placeholderValue):

• accessibility/AccessibilityObject.h:

(WebCore::AccessibilityObject::accessKey):
(WebCore::AccessibilityObject::ariaLiveRegionRelevant):

• accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::accessKey):
(WebCore::AccessibilityRenderObject::actionVerb):

• bindings/js/JSCustomElementInterface.cpp:

(WebCore::JSCustomElementInterface::constructElementWithFallback):

• bindings/js/JSCustomElementRegistryCustom.cpp:

(WebCore::JSCustomElementRegistry::define):

• bindings/scripts/CodeGeneratorJS.pm:

(GenerateDefaultValue):

• bindings/scripts/test/JS/JSTestObj.cpp:

(WebCore::jsTestObjPrototypeFunctionMethodWithOptionalAtomicStringBody):
(WebCore::jsTestObjPrototypeFunctionMethodWithOptionalAtomicStringIsNullBody):
(WebCore::jsTestObjPrototypeFunctionMethodWithOptionalAtomicStringIsEmptyStringBody):

• css/CSSPageRule.cpp:

(WebCore::CSSPageRule::selectorText):

• css/CSSPrimitiveValue.cpp:

(WebCore::valueName):

• css/CSSSelector.cpp:

(WebCore::simpleSelectorSpecificityInternal):
(WebCore::CSSSelector::specificityForPage):
(WebCore::CSSSelector::RareData::RareData):

• css/CSSSelector.h:

(WebCore::CSSSelector::argument):

• css/CSSSelectorList.cpp:

(WebCore::SelectorNeedsNamespaceResolutionFunctor::operator()):

• css/PageRuleCollector.cpp:

(WebCore::checkPageSelectorComponents):

• css/RuleSet.cpp:

(WebCore::computeMatchBasedOnRuleHash):
(WebCore::RuleSet::addRule):

• css/SelectorChecker.cpp:

(WebCore::tagMatches):

• css/SelectorFilter.cpp:

(WebCore::collectDescendantSelectorIdentifierHashes):

• css/StyleBuilderConverter.h:

(WebCore::StyleBuilderConverter::convertStringOrAuto):
(WebCore::StyleBuilderConverter::convertStringOrNone):

• css/StyleBuilderCustom.h:

(WebCore::StyleBuilderCustom::applyValueWebkitLocale):
(WebCore::StyleBuilderCustom::applyValueWebkitTextEmphasisStyle):
(WebCore::StyleBuilderCustom::applyValueContent):
(WebCore::StyleBuilderCustom::applyValueAlt):

• css/StyleSheetContents.cpp:

(WebCore::StyleSheetContents::StyleSheetContents):
(WebCore::StyleSheetContents::namespaceURIFromPrefix):

• css/makeprop.pl:
• css/parser/CSSParserImpl.cpp:

(WebCore::CSSParserImpl::parsePageSelector):

• css/parser/CSSSelectorParser.cpp:

(WebCore::CSSSelectorParser::consumeCompoundSelector):
(WebCore::CSSSelectorParser::consumeName):
(WebCore::CSSSelectorParser::consumeAttribute):
(WebCore::CSSSelectorParser::defaultNamespace):
(WebCore::CSSSelectorParser::determineNamespace):
(WebCore::CSSSelectorParser::prependTypeSelectorIfNeeded):

• cssjit/SelectorCompiler.cpp:

(WebCore::SelectorCompiler::attributeNameTestingRequiresNamespaceRegister):
(WebCore::SelectorCompiler::equalTagNames):
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateElementAttributeMatching):
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateElementHasTagName):

• dom/Attr.cpp:

(WebCore::Attr::setPrefix):
(WebCore::Attr::attachToElement):

• dom/Attribute.h:

(WebCore::Attribute::nameMatchesFilter):

• dom/ConstantPropertyMap.cpp:

(WebCore::ConstantPropertyMap::nameForProperty):

• dom/ContainerNode.cpp:

(WebCore::ContainerNode::getElementsByTagName):
(WebCore::ContainerNode::getElementsByTagNameNS):

• dom/CustomElementReactionQueue.cpp:

(WebCore::CustomElementReactionQueue::enqueuePostUpgradeReactions):

• dom/DatasetDOMStringMap.cpp:

(WebCore::convertPropertyNameToAttributeName):

• dom/Document.cpp:

(WebCore::createUpgradeCandidateElement):
(WebCore::Document::createElementForBindings):
(WebCore::Document::importNode):
(WebCore::Document::hasValidNamespaceForElements):
(WebCore::Document::processBaseElement):
(WebCore::Document::dir):
(WebCore::Document::bgColor):
(WebCore::Document::fgColor):
(WebCore::Document::alinkColor):
(WebCore::Document::linkColorForBindings):
(WebCore::Document::vlinkColor):

• dom/Document.h:
• dom/Element.cpp:

(WebCore::Element::setBooleanAttribute):
(WebCore::Element::synchronizeAttribute):
(WebCore::Element::getAttribute):
(WebCore::Element::getAttributeNS):
(WebCore::Element::setAttribute):
(WebCore::Element::parserSetAttributes):
(WebCore::Element::didMoveToNewDocument):
(WebCore::Element::setPrefix):
(WebCore::Element::insertedInto):
(WebCore::Element::removedFrom):
(WebCore::Element::removeAttributeInternal):
(WebCore::Element::addAttributeInternal):
(WebCore::Element::removeAttributeNS):
(WebCore::Element::getAttributeNodeNS):
(WebCore::Element::hasAttributeNS):
(WebCore::Element::computeInheritedLanguage):
(WebCore::Element::updateNameForDocument):
(WebCore::Element::updateIdForDocument):
(WebCore::Element::didAddAttribute):
(WebCore::Element::didRemoveAttribute):
(WebCore::Element::cloneAttributesFromElement):

• dom/Element.h:

(WebCore::Element::attributeWithoutSynchronization):
(WebCore::Element::idForStyleResolution):
(WebCore::Element::getIdAttribute):
(WebCore::Element::getNameAttribute):

• dom/EventTarget.cpp:

(WebCore::legacyType):

• dom/MutationRecord.h:

(WebCore::MutationRecord::attributeName):
(WebCore::MutationRecord::attributeNamespace):

• dom/NamedNodeMap.cpp:

(WebCore::NamedNodeMap::removeNamedItemNS):

• dom/Node.cpp:

(WebCore::Node::prefix):
(WebCore::Node::localName):
(WebCore::Node::namespaceURI):
(WebCore::Node::checkSetPrefix):
(WebCore::locateDefaultNamespace):
(WebCore::Node::isDefaultNamespace):
(WebCore::Node::lookupNamespaceURI):
(WebCore::locateNamespacePrefix):
(WebCore::Node::lookupPrefix):

• dom/NodeRareData.h:

(WebCore::NodeListsNodeData::addCachedTagCollectionNS):
(WebCore::NodeListsNodeData::addCachedCollection):
(WebCore::NodeListsNodeData::cachedCollection):
(WebCore::NodeListsNodeData::removeCacheWithAtomicName):
(WebCore::NodeListsNodeData::removeCachedTagCollectionNS):
(WebCore::NodeListsNodeData::removeCachedCollection):

• dom/PseudoElement.cpp:

(WebCore::pseudoElementTagName):

• dom/QualifiedName.cpp:

(WebCore::QualifiedName::init):
(WebCore::nullQName):
(WebCore::createQualifiedName):

• dom/QualifiedName.h:

(WebCore::QualifiedName::hasPrefix):

• dom/SelectorQuery.cpp:

(WebCore::SelectorDataList::executeSingleTagNameSelectorData):

• dom/SlotAssignment.cpp:

(WebCore::slotNameFromAttributeValue):

• dom/SlotAssignment.h:

(WebCore::SlotAssignment::defaultSlotName):
(WebCore::ShadowRoot::didRemoveAllChildrenOfShadowHost):
(WebCore::ShadowRoot::didChangeDefaultSlot):

• dom/TagCollection.cpp:

(WebCore::TagCollection::TagCollection):
(WebCore::HTMLTagCollection::HTMLTagCollection):

• dom/TagCollection.h:

(WebCore::TagCollectionNS::elementMatches):

• dom/make_names.pl:

(printNamesCppFile):
(printDefinitions):
(printFactoryCppFile):

• editing/CompositeEditCommand.cpp:

(WebCore::CompositeEditCommand::removeNodeAttribute):

• editing/Editing.cpp:

(WebCore::createHTMLElement):

• editing/MarkupAccumulator.cpp:

(WebCore::MarkupAccumulator::serializeNodesWithNamespaces):
(WebCore::MarkupAccumulator::shouldAddNamespaceElement):
(WebCore::MarkupAccumulator::shouldAddNamespaceAttribute):
(WebCore::MarkupAccumulator::appendNamespace):
(WebCore::MarkupAccumulator::appendOpenTag):
(WebCore::MarkupAccumulator::appendAttribute):

• editing/gtk/EditorGtk.cpp:

(WebCore::elementURL):

• editing/markup.cpp:

(WebCore::AttributeChange::AttributeChange):

• html/Autocapitalize.cpp:

(WebCore::stringForAutocapitalizeType):

• html/Autofill.cpp:

(WebCore::AutofillData::createFromHTMLFormControlElement):

• html/DOMTokenList.h:

(WebCore::DOMTokenList::item):

• html/FormAssociatedElement.cpp:

(WebCore::FormAssociatedElement::name):

• html/HTMLButtonElement.cpp:

(WebCore::HTMLButtonElement::formControlType):

• html/HTMLDetailsElement.cpp:

(WebCore::HTMLDetailsElement::toggleOpen):

• html/HTMLDocument.cpp:

(WebCore::HTMLDocument::isCaseSensitiveAttribute):

• html/HTMLElement.cpp:

(WebCore::HTMLElement::eventNameForEventHandlerAttribute):
(WebCore::toValidDirValue):

• html/HTMLImageElement.cpp:

(WebCore::HTMLImageElement::bestFitSourceFromPictureElement):

• html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::name):
(WebCore::HTMLInputElement::updateType):

• html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::doesHaveAttribute):

• html/HTMLOptionElement.cpp:

(WebCore::HTMLOptionElement::createForJSConstructor):

• html/HTMLParamElement.cpp:

(WebCore::HTMLParamElement::name):

• html/HTMLSelectElement.cpp:

(WebCore::HTMLSelectElement::setMultiple):

• html/HTMLTableCellElement.cpp:

(WebCore::HTMLTableCellElement::scope):

• html/HTMLTrackElement.cpp:

(WebCore::HTMLTrackElement::mediaElementCrossOriginAttribute):

• html/LabelableElement.cpp:

(WebCore::LabelableElement::labels):

• html/LabelsNodeList.cpp:

(WebCore::LabelsNodeList::~LabelsNodeList):

• html/MediaController.cpp:

(MediaController::playbackState):
(eventNameForReadyState):

• html/MediaDocument.cpp:

(WebCore::MediaDocumentParser::createDocumentStructure):

• html/parser/AtomicHTMLToken.h:

(WebCore::AtomicHTMLToken::initializeAttributes):

• html/parser/HTMLConstructionSite.cpp:

(WebCore::HTMLConstructionSite::createElement):
(WebCore::HTMLConstructionSite::createHTMLElementOrFindCustomElementInterface):

• html/parser/HTMLParserIdioms.cpp:

(WebCore::stripLeadingAndTrailingHTMLSpaces):
(WebCore::parseHTMLHashNameReference):

• html/parser/HTMLTreeBuilder.cpp:

(WebCore::createForeignAttributesMap):

• html/track/InbandTextTrack.cpp:

(WebCore::InbandTextTrack::InbandTextTrack):

• html/track/LoadableTextTrack.cpp:

(WebCore::LoadableTextTrack::id):

• html/track/TextTrack.cpp:

(WebCore::TextTrack::captionMenuOffItem):
(WebCore::TextTrack::captionMenuAutomaticItem):

• html/track/TrackBase.cpp:

(WebCore::MediaTrackBase::setKindInternal):

• html/track/VTTRegion.cpp:

(WebCore::VTTRegion::scroll):

• html/track/WebVTTElement.cpp:

(WebCore::nodeTypeToTagName):

• html/track/WebVTTElement.h:
• html/track/WebVTTToken.h:

(WebCore::WebVTTToken::StartTag):

• loader/FrameLoader.cpp:

(WebCore::FrameLoader::clear):

• loader/FrameLoader.h:
• loader/ImageLoader.cpp:

(WebCore::ImageLoader::clearFailedLoadURL):

• loader/NavigationAction.h:
• loader/PolicyChecker.cpp:

(WebCore::PolicyChecker::checkNavigationPolicy):

• page/DOMWindow.cpp:

(WebCore::DOMWindow::showModalDialog):

• page/EventHandler.cpp:

(WebCore::eventNameForTouchPointState):

• page/FrameTree.cpp:

(WebCore::FrameTree::setName):
(WebCore::FrameTree::clearName):

• page/Page.cpp:

(WebCore::Page::groupName):

• platform/graphics/ComplexTextController.cpp:

(WebCore::ComplexTextController::offsetForPosition):

• platform/graphics/FontCache.cpp:

(WebCore::FontCache::alternateFamilyName):

• platform/graphics/FontDescription.h:

(WebCore::FontCascadeDescription::initialLocale):

• platform/graphics/FontGenericFamilies.cpp:

(WebCore::genericFontFamilyForScript):

• platform/graphics/InbandTextTrackPrivate.h:

(WebCore::InbandTextTrackPrivate::inBandMetadataTrackDispatchType):

• platform/graphics/TrackPrivateBase.h:

(WebCore::TrackPrivateBase::id):
(WebCore::TrackPrivateBase::label):
(WebCore::TrackPrivateBase::language):

• platform/graphics/avfoundation/AVTrackPrivateAVFObjCImpl.mm:

(WebCore::AVTrackPrivateAVFObjCImpl::id):
(WebCore::AVTrackPrivateAVFObjCImpl::label):
(WebCore::AVTrackPrivateAVFObjCImpl::language):

• platform/graphics/avfoundation/InbandMetadataTextTrackPrivateAVF.h:
• platform/graphics/avfoundation/cf/InbandTextTrackPrivateAVCF.cpp:

(WebCore::InbandTextTrackPrivateAVCF::label):
(WebCore::InbandTextTrackPrivateAVCF::language):

• platform/graphics/avfoundation/cf/InbandTextTrackPrivateLegacyAVCF.cpp:

(WebCore::InbandTextTrackPrivateLegacyAVCF::label):
(WebCore::InbandTextTrackPrivateLegacyAVCF::language):

• platform/graphics/avfoundation/objc/InbandTextTrackPrivateAVFObjC.mm:

(WebCore::InbandTextTrackPrivateAVFObjC::label):
(WebCore::InbandTextTrackPrivateAVFObjC::language):

• platform/graphics/avfoundation/objc/InbandTextTrackPrivateLegacyAVFObjC.mm:

(WebCore::InbandTextTrackPrivateLegacyAVFObjC::label):
(WebCore::InbandTextTrackPrivateLegacyAVFObjC::language):

• platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:

(WebCore::metadataType):
(WebCore::MediaPlayerPrivateAVFoundationObjC::metadataDidArrive):

• platform/graphics/cocoa/FontCacheCoreText.cpp:

(WebCore::FontCache::platformAlternateFamilyName):

• platform/graphics/cocoa/FontDescriptionCocoa.cpp:

(WebCore::FontCascadeDescription::effectiveFamilyAt):

• platform/graphics/freetype/FontCacheFreeType.cpp:

(WebCore::FontCache::platformAlternateFamilyName):

• platform/graphics/gstreamer/InbandMetadataTextTrackPrivateGStreamer.h:

(WebCore::InbandMetadataTextTrackPrivateGStreamer::create):

• platform/graphics/win/FontCacheWin.cpp:

(WebCore::FontCache::platformAlternateFamilyName):

• platform/mediastream/AudioTrackPrivateMediaStream.h:
• platform/mediastream/RealtimeMediaSourceSettings.cpp:

(WebCore::RealtimeMediaSourceSettings::facingMode):

• platform/mediastream/VideoTrackPrivateMediaStream.h:
• rendering/HitTestResult.cpp:

(WebCore::HitTestResult::linkSuggestedFilename):

• rendering/InlineTextBox.cpp:

(WebCore::InlineTextBox::paint):

• rendering/RenderListItem.cpp:

(WebCore::RenderListItem::markerText):

• rendering/RenderText.cpp:

(WebCore::RenderText::previousOffset):
(WebCore::RenderText::nextOffset):

• rendering/RenderTreeAsText.cpp:

(WebCore::RenderTreeAsText::writeRenderObject):

• rendering/TextPainter.cpp:

(WebCore::TextPainter::paintTextAndEmphasisMarksIfNeeded):

• rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::textEmphasisMarkString):

• rendering/style/RenderStyle.h:

(WebCore::RenderStyle::initialHyphenationString):
(WebCore::RenderStyle::initialTextEmphasisCustomMark):
(WebCore::RenderStyle::initialContentAltText):
(WebCore::RenderStyle::initialLineGrid):
(WebCore::RenderStyle::initialFlowThread):
(WebCore::RenderStyle::initialRegionThread):

• style/StyleScope.cpp:

(WebCore::Style::Scope::collectActiveStyleSheets):

• svg/SVGElement.cpp:

(WebCore::SVGElement::getPresentationAttribute):

• svg/SVGElement.h:

(WebCore::SVGAttributeHashTranslator::hash):

• svg/SVGUseElement.cpp:

(WebCore::SVGUseElement::transferSizeAttributesToTargetClone):

• svg/animation/SVGSMILElement.cpp:

(WebCore::SVGSMILElement::constructAttributeName):

• testing/MockCDMFactory.cpp:

(WebCore::MockCDMInstance::requestLicense):

• xml/XMLErrors.cpp:

(WebCore::createXHTMLParserErrorHeader):

• xml/XPathStep.cpp:

(WebCore::XPath::nodeMatchesBasicTest):
(WebCore::XPath::Step::nodesInAxis):

• xml/parser/XMLDocumentParserLibxml2.cpp:

(WebCore::XMLDocumentParser::XMLDocumentParser):
(WebCore::handleNamespaceAttributes):
(WebCore::handleElementAttributes):

Source/WebKit/mac:

• DOM/DOM.mm:

(lookupElementClass):

Source/WTF:

This patch cleans up StringStatics.cpp and remove it from the tree.

1. Move StringImpl methods to appropriate place, "StringImpl.cpp".

StringImpl::hashSlowCase() and StringImpl::concurrentHash() are defined in
StringStatics.cpp. But they should be defined in StringImpl.cpp.
This patch just moves them to StringImpl.cpp.

2. Use LazyNeverDestroyed to initialize AtomicString atoms like emptyAtom.

Previously, we initialized AtomicString atoms like emptyAtom in a hacky way.
We first define them as extern global variables. However, AtomicString has
a non-trivial constructor. Thus, we cannot do this because it requires global
constructor calls. This is why we have StringStatics.cpp. In this file, we
include "StaticConstructors.h". After including this file, all the global
constructor call disabled in Windows. And in GCC environment, we allocate
void* storage for that variable. And we use placement new in AtomicString::init()
to initialize these storage.
However, we already have better way for that: LazyNeverDestroyed. It just allocates
storage like the above. And it does not have any global constructors. Thus
we can just declare it as a global variable. And we initialize them lazily in
AtomicString::init(). This way effectively avoids "StaticConstructors.h" hacky way.
And it makes "StringStatics.cpp" unnecessary.
Then, we just move these variables and AtomicString::init() to AtomicString.cpp.

And we also change emptyAtom to emptyAtom() to get the value from LazyNeverDestroyed<>.

• WTF.xcodeproj/project.pbxproj:
• wtf/CMakeLists.txt:
• wtf/text/AtomicString.cpp:

(WTF::AtomicString::convertASCIICase):
(WTF::AtomicString::fromUTF8Internal):
(WTF::AtomicString::init):

• wtf/text/AtomicString.h:

(WTF::nullAtom):
(WTF::emptyAtom):
(WTF::starAtom):
(WTF::xmlAtom):
(WTF::xmlnsAtom):
(WTF::AtomicString::fromUTF8):

• wtf/text/StringBuilder.h:

(WTF::StringBuilder::toAtomicString):

• wtf/text/StringImpl.cpp:

(WTF::StringImpl::hashSlowCase):
(WTF::StringImpl::concurrentHash):

• wtf/text/StringStatics.cpp: Removed.

Tools:

• TestWebKitAPI/Tests/WTF/StringBuilder.cpp:

(TestWebKitAPI::TEST):

7:01 PM Changeset in webkit [219177] by Chris Dumez

• 3 edits in trunk/Source/WebCore

[iOS] User agent string incorrectly says "iPhone" instead of "iPad" on newer iPads
​https://bugs.webkit.org/show_bug.cgi?id=174182
<rdar://problem/32868369>

Reviewed by Tim Horton.

In deviceNameForUserAgent() on iOS, we were forcefully returning "iPhone" if
[UIApplication _isClassic] returns true. Update check to return "iPad" if
[UIApplication _isClassic] returns true but [UIApplication _classMode] returns
UIApplicationSceneClassicModeOriginalPad.

• page/ios/UserAgentIOS.mm:

(WebCore::isClassicPad):
(WebCore::isClassicPhone):
(WebCore::osNameForUserAgent):
(WebCore::deviceNameForUserAgent):

• platform/spi/ios/UIKitSPI.h:

6:57 PM Changeset in webkit [219176] by Yusuke Suzuki

• 21 edits in trunk/Source

WTF::Thread should have the threads stack bounds.
​https://bugs.webkit.org/show_bug.cgi?id=173975

Reviewed by Keith Miller.

Source/JavaScriptCore:

There is a site in JSC that try to walk another thread's stack.
Currently, stack bounds are stored in WTFThreadData which is located
in TLS. Thus, only the thread itself can access its own WTFThreadData.
We workaround this situation by holding StackBounds in MachineThread in JSC,
but StackBounds should be put in WTF::Thread instead.

This patch moves StackBounds from WTFThreadData to WTF::Thread. StackBounds
information is tightly coupled with Thread. Thus putting it in WTF::Thread
is natural choice.

• heap/MachineStackMarker.cpp:

(JSC::MachineThreads::MachineThread::MachineThread):
(JSC::MachineThreads::MachineThread::captureStack):

• heap/MachineStackMarker.h:

(JSC::MachineThreads::MachineThread::stackBase):
(JSC::MachineThreads::MachineThread::stackEnd):

• runtime/InitializeThreading.cpp:

(JSC::initializeThreading):

• runtime/VM.cpp:

(JSC::VM::VM):
(JSC::VM::updateStackLimits):
(JSC::VM::committedStackByteCount):

• runtime/VM.h:

(JSC::VM::isSafeToRecurse):

• runtime/VMEntryScope.cpp:

(JSC::VMEntryScope::VMEntryScope):

• runtime/VMInlines.h:

(JSC::VM::ensureStackCapacityFor):

• runtime/VMTraps.cpp:
• yarr/YarrPattern.cpp:

(JSC::Yarr::YarrPatternConstructor::isSafeToRecurse):

Source/WebCore:

When creating WebThread, we first allocate WebCore::ThreadGlobalData in UI thread
and share it with WebThread.
The problem is that WebCore::ThreadGlobalData has CachedResourceRequestInitiators.
It allocates AtomicString, which requires WTFThreadData.

Before this patch, it was OK because WTFThreadData does not touch threading related
things except for ThreadSpecific<>. However, after this patch, it touches
WTF::Thread::current() which requires WTF::initializeThreading().

In this patch, we call WTF::initializeThreading() before allocating WebCore::ThreadGlobalData.
And we also call AtomicString::init() before calling WebCore::ThreadGlobalData since
WebCore::ThreadGlobalData allocates AtomicString.

This fixes crashes in the iOS web threading environment (UIWebView).

• platform/ios/wak/WebCoreThread.mm:

(StartWebThread):

Source/WTF:

We move StackBounds from WTFThreadData to WTF::Thread.
One important thing is that we should make valid StackBounds
visible to Thread::create() caller. When the caller get
WTF::Thread from Thread::create(), this WTF::Thread should
have a valid StackBounds. But StackBounds information can be
retrived only in the WTF::Thread's thread itself.

We also clean up WTF::initializeThreading. StringImpl::empty()
is now statically initialized by using constexpr constructor.
Thus we do not need to call StringImpl::empty() explicitly here.
And WTF::initializeThreading() does not have any main thread
affinity right now in all the platforms. So we fix the comment
in Threading.h. Then, now, WTF::initializeThreading() is called
in UI thread when using Web thread in iOS.

• wtf/StackBounds.h:

(WTF::StackBounds::emptyBounds):
(WTF::StackBounds::StackBounds):

• wtf/StackStats.cpp:

(WTF::StackStats::PerThreadStats::PerThreadStats):

• wtf/Threading.cpp:

(WTF::threadEntryPoint):
(WTF::Thread::create):
(WTF::Thread::currentMayBeNull):
(WTF::Thread::initialize):
(WTF::initializeThreading):

• wtf/Threading.h:

(WTF::Thread::stack):

• wtf/ThreadingPthreads.cpp:

(WTF::Thread::initializeCurrentThreadEvenIfNonWTFCreated):
(WTF::Thread::current):
(WTF::initializeCurrentThreadEvenIfNonWTFCreated): Deleted.
(WTF::Thread::currentMayBeNull): Deleted.

• wtf/ThreadingWin.cpp:

(WTF::Thread::initializeCurrentThreadEvenIfNonWTFCreated):
(WTF::Thread::initializeCurrentThreadInternal):
(WTF::Thread::current):

• wtf/WTFThreadData.cpp:

(WTF::WTFThreadData::WTFThreadData):

• wtf/WTFThreadData.h:

(WTF::WTFThreadData::stack): Deleted.

6:55 PM Changeset in webkit [219175] by jmarcell@apple.com

• 7 edits
  1 add in tags/Safari-604.1.29

Cherry-pick r219154. rdar://problem/33067518

5:29 PM Changeset in webkit [219174] by Jonathan Bedard

• 1 edit
  8 adds in trunk/LayoutTests

Move internal iOS 11 TestExpectations to OpenSource
<rdar://problem/32717028>

Unreviewed test gardening.

• platform/ios-11/platform/ios/ios/fast/text/opticalFont-expected.txt: Added.
• platform/ios-11/platform/ios/ios/fast/text/opticalFontWithTextStyle-expected.txt: Added.
• platform/ios-11/platform/ios/ios/fast/text/opticalFontWithWeight-expected.txt: Added.

5:26 PM Changeset in webkit [219173] by mmaxfield@apple.com

• 3 edits
  2 adds in trunk

CSSFontStyleValue::isItalic seems a bit bogus.
​https://bugs.webkit.org/show_bug.cgi?id=174149

Reviewed by Tim Horton.

Source/WebCore:

Simple typo.

Test: editing/execCommand/italicizeByCharacter-normal.html

• css/CSSFontStyleValue.h:

LayoutTests:

• editing/execCommand/italicizeByCharacter-normal-expected.txt: Added.
• editing/execCommand/italicizeByCharacter-normal.html: Added.

5:05 PM Changeset in webkit [219172] by keith_miller@apple.com

• 7 edits in trunk/Source

Crashing with information should have an abort reason
​https://bugs.webkit.org/show_bug.cgi?id=174185

Reviewed by Saam Barati.

Source/JavaScriptCore:

Add crash information for the abstract interpreter and add an enum
value for object allocation sinking.

• assembler/AbortReason.h:
• dfg/DFGAbstractInterpreterInlines.h:

(JSC::DFG::AbstractInterpreter<AbstractStateType>::verifyEdge):

• dfg/DFGGraph.cpp:

(JSC::DFG::logDFGAssertionFailure):

• dfg/DFGObjectAllocationSinkingPhase.cpp:

Source/WTF:

Fix an ifdef to actually work with X86_64. It turns out X64_64 is
not an architecture... Whoops.

• wtf/Assertions.cpp:

5:05 PM Changeset in webkit [219171] by Matt Lewis

• 2 edits in trunk/LayoutTests

Skipped webgl/1.0.2/conformance/glsl/misc/shader-with-non-reserved-words.html.
​https://bugs.webkit.org/show_bug.cgi?id=174100

Unreviewed test gardening.

• platform/ios-simulator-wk2/TestExpectations:

5:01 PM Changeset in webkit [219170] by beidson@apple.com

• 26 edits
  3 adds in trunk

Allow navigations in subframes to get a ShouldOpenExternalURLsPolicy of "ShouldAllow".
<rdar://problem/22485589> and ​https://bugs.webkit.org/show_bug.cgi?id=174178

Reviewed by Alex Christensen.

Source/WebCore:

Test: loader/navigation-policy/should-open-external-urls/subframe-navigated-programatically-by-main-frame.html

This patch introduces a new flag to FrameLoadRequest to track when it is known with certainty that a
FrameLoadRequest originates from the main frame.

Later, when calculating the final ShouldOpenExternalURLsPolicy, main frames navigating iframes get to propagate
their permissions to the iframe.

• bindings/js/CommonVM.cpp:

(WebCore::lexicalFrameFromCommonVM): Helper to grab the current frame associated with the current JS callstack.

• bindings/js/CommonVM.h:

• inspector/InspectorFrontendClientLocal.cpp:

(WebCore::InspectorFrontendClientLocal::openInNewTab):

• inspector/InspectorPageAgent.cpp:

(WebCore::InspectorPageAgent::navigate):

Add the new flag to FrameLoadRequest (and force almost everybody to explicitly include the flag):

• loader/FrameLoadRequest.cpp:

(WebCore::FrameLoadRequest::FrameLoadRequest):

• loader/FrameLoadRequest.h:

(WebCore::FrameLoadRequest::FrameLoadRequest):
(WebCore::FrameLoadRequest::navigationInitiatedByMainFrame):

• loader/FrameLoader.cpp:

(WebCore::FrameLoader::urlSelected):
(WebCore::FrameLoader::loadURLIntoChildFrame):
(WebCore::shouldOpenExternalURLsPolicyToApply): Helper that takes the new flag into account when deciding

what the final ShouldOpenExternalURLsPolicy will be.

(WebCore::applyShouldOpenExternalURLsPolicyToNewDocumentLoader):
(WebCore::FrameLoader::loadURL):
(WebCore::FrameLoader::load):
(WebCore::FrameLoader::loadWithNavigationAction):
(WebCore::FrameLoader::reloadWithOverrideEncoding):
(WebCore::FrameLoader::reload):
(WebCore::FrameLoader::loadPostRequest):
(WebCore::FrameLoader::continueLoadAfterNewWindowPolicy):
(WebCore::FrameLoader::loadDifferentDocumentItem):
(WebCore::createWindow):
(WebCore::FrameLoader::applyShouldOpenExternalURLsPolicyToNewDocumentLoader): Deleted.

• loader/FrameLoader.h:

• loader/FrameLoaderTypes.h:

• loader/NavigationAction.h:

(WebCore::NavigationAction::navigationInitiatedByMainFrame):

• loader/NavigationScheduler.cpp:

(WebCore::ScheduledNavigation::ScheduledNavigation): Grab the "initiating frame" at the time the

ScheduledNavigation is created, as it dictates the policy we decide later.

(WebCore::ScheduledNavigation::navigationInitiatedByMainFrame):
(WebCore::NavigationScheduler::scheduleLocationChange):

• page/ContextMenuController.cpp:

(WebCore::openNewWindow):
(WebCore::ContextMenuController::contextMenuItemSelected):

• page/DOMWindow.cpp:

(WebCore::DOMWindow::createWindow):

Source/WebKit/ios:

Adopt to the new constructor for FrameLoadRequest.

• WebView/WebPDFViewPlaceholder.mm:

(-[WebPDFViewPlaceholder simulateClickOnLinkToURL:]):

Source/WebKit/mac:

Adopt to the new constructor for FrameLoadRequest.

• WebView/WebPDFView.mm:

(-[WebPDFView PDFViewWillClickOnLink:withURL:]):

Source/WebKit/win:

Adopt to the new constructor for FrameLoadRequest.

• Plugins/PluginView.cpp:

(WebCore::PluginView::start):
(WebCore::PluginView::getURLNotify):
(WebCore::PluginView::getURL):
(WebCore::PluginView::handlePost):

Source/WebKit2:

Adopt to the new constructor for FrameLoadRequest.

• WebProcess/Plugins/PluginView.cpp:

(WebKit::PluginView::loadURL):

• WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::dispatchCreatePage):

• WebProcess/WebPage/WebInspector.cpp:

(WebKit::WebInspector::openInNewTab):

LayoutTests:

Added a new explicit test and updated expectations for an old one.

• loader/navigation-policy/should-open-external-urls/resources/main-frame-with-subframe-main-programatically-navigates-subframe.html: Added.
• loader/navigation-policy/should-open-external-urls/subframe-click-target-self-expected.txt:
• loader/navigation-policy/should-open-external-urls/subframe-navigated-programatically-by-main-frame-expected.txt: Added.
• loader/navigation-policy/should-open-external-urls/subframe-navigated-programatically-by-main-frame.html: Added.

4:56 PM Changeset in webkit [219169] by jmarcell@apple.com

• 2 edits in tags/Safari-604.1.28.1.2/Source/WebKit2

Revert r218821. rdar://problem/33144483

4:54 PM Changeset in webkit [219168] by jmarcell@apple.com

• 7 edits in tags/Safari-604.1.28.1.2/Source

Versioning.

4:44 PM Changeset in webkit [219167] by rniwa@webkit.org

• 2 edits in trunk/Source/WebKit2

Remove unnecessary forward declartions now that we include Foundation.h

• UIProcess/API/Cocoa/WKContentRuleListStore.h:

4:44 PM Changeset in webkit [219166] by Matt Lewis

• 2 edits in trunk/LayoutTests

Marked animations/needs-layout.html as flaky.
​https://bugs.webkit.org/show_bug.cgi?id=172397

Unreviewed test gardening.

• platform/mac-wk2/TestExpectations:

4:40 PM Changeset in webkit [219165] by rniwa@webkit.org

• 9 edits in trunk/Source

Make WebKit's public headers on Mac and iOS C++ module safe
​https://bugs.webkit.org/show_bug.cgi?id=174175

Reviewed by Alex Christensen.

Fixed the header files.

Source/WebKit/mac:

• Misc/WebDownload.h:
• Misc/WebKitErrors.h:
• Plugins/WebPluginContainer.h:
• WebView/WebResourceLoadDelegate.h:

Source/WebKit2:

• UIProcess/API/Cocoa/WKContentRuleList.h:
• UIProcess/API/Cocoa/WKContentRuleListStore.h:
• UIProcess/API/Cocoa/WKUIDelegate.h:

4:36 PM Changeset in webkit [219164] by jmarcell@apple.com

• 1 copy in tags/Safari-604.1.28.2

Tag Safari-604.1.28.2.

4:30 PM Changeset in webkit [219163] by jmarcell@apple.com

• 1 copy in tags/Safari-604.1.28.1.2

Tag Safari-604.1.28.1.2.

3:29 PM Changeset in webkit [219162] by Simon Fraser

• 2 edits in trunk/Source/WebCore

Another build fix, for Mac.

• platform/graphics/cocoa/IOSurface.mm:

(WebCore::IOSurface::surfaceID):

3:27 PM Changeset in webkit [219161] by Chris Dumez

• 11 edits in trunk/Source/WebKit2

[WK2] WebsiteDataStore::setResourceLoadStatisticsEnabled() updates processPools the store is not associated with
​https://bugs.webkit.org/show_bug.cgi?id=174174

Reviewed by Brent Fulgham.

WebsiteDataStore::setResourceLoadStatisticsEnabled() updates processPools the store is not associated with.
Fix this by iterating over WebsiteDataStore::processPools() instead of WebProcessPool::allProcessPools().

Also rename shouldPartitionCookiesForTopPrivatelyOwnedDomains methods / IPC messages to
updateCookiePartitioningForTopPrivatelyOwnedDomains since this is a setter, not a getter.

Finally, drop ShouldPartitionCookiesForTopPrivatelyOwnedDomains IPC message to the NetworkProcessProxy
as well as corresponding methods as those appear to be unused.

• NetworkProcess/NetworkProcess.cpp:

(WebKit::NetworkProcess::updateCookiePartitioningForTopPrivatelyOwnedDomains):
(WebKit::NetworkProcess::shouldPartitionCookiesForTopPrivatelyOwnedDomains): Deleted.

• NetworkProcess/NetworkProcess.h:
• NetworkProcess/NetworkProcess.messages.in:
• UIProcess/Network/NetworkProcessProxy.cpp:

(WebKit::NetworkProcessProxy::shouldPartitionCookiesForTopPrivatelyOwnedDomains): Deleted.

• UIProcess/Network/NetworkProcessProxy.h:
• UIProcess/Network/NetworkProcessProxy.messages.in:
• UIProcess/WebProcessPool.cpp:

(WebKit::WebProcessPool::setResourceLoadStatisticsEnabled):

• UIProcess/WebProcessPool.h:
• UIProcess/WebsiteData/WebsiteDataStore.cpp:

(WebKit::WebsiteDataStore::updateCookiePartitioningForTopPrivatelyOwnedDomains):
(WebKit::WebsiteDataStore::setResourceLoadStatisticsEnabled):
(WebKit::WebsiteDataStore::registerSharedResourceLoadObserver):
(WebKit::WebsiteDataStore::shouldPartitionCookiesForTopPrivatelyOwnedDomains): Deleted.

• UIProcess/WebsiteData/WebsiteDataStore.h:

3:25 PM Changeset in webkit [219160] by Simon Fraser

• 3 edits in trunk/Source/WebCore

Further attempts to fix the iOS public SDK build.

• platform/graphics/cocoa/IOSurface.mm:

(WebCore::IOSurface::surfaceID):

• platform/spi/cocoa/IOSurfaceSPI.h:

3:08 PM Changeset in webkit [219159] by jmarcell@apple.com

• 3 edits
  2 adds in branches/safari-604.1.28-branch

Cherry-pick r219081. rdar://problem/33083972

2:52 PM Changeset in webkit [219158] by timothy_horton@apple.com

• 2 edits in trunk/Source/WebKit2

Async Image Decoding: Image flashes away briefly when tapping on tab in iPad tab picker
​https://bugs.webkit.org/show_bug.cgi?id=174173
<rdar://problem/32431952>

Reviewed by Geoffrey Garen.

• WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.mm:

(WebKit::RemoteLayerTreeDrawingArea::addTransactionCallbackID):
When a client uses e.g. doAfterNextPresentationUpdate (or internally,
dispatchAfterEnsuringDrawing), they're doing so in the hopes that the
callback is called after the page is well-painted -- for example, to
remove a snapshot (in the tab picker case, as well as for navigation
gestures), or to *take* a snapshot. In all of these cases, it is
preferable to do a synchronous decode, to ensure that the image does
not flash away temporarily.

Use the existing mechanism that was implemented for the synchronous
activity state change flush to also force synchronous image decoding
any time there is a post-commit transaction callback.

2:40 PM Changeset in webkit [219157] by Wenson Hsieh

• 2 edits in trunk/Source/WebKit2

[iOS DnD] [WK2] 3D touch fails to recognize when UIDragInteraction is enabled on phone
​https://bugs.webkit.org/show_bug.cgi?id=174171
<rdar://problem/32956929>

Reviewed by Tim Horton.

By default, UIKit defers all competing long press gesture recognizers if dragging is enabled. However, this
would cause 3D touch to be prevented, due to UIKit asking us whether or not we can proceed with the 3D touch
gesture in -_interactionShouldBeginFromPreviewItemController:forPosition:, while the highlight long press
gesture recognizer is being deferred. To address this, we use SPI on UIDragInteraction to allow the highlight
long press gesture recognizer to recognize alongside the drag lift gesture. We then (already) manually cancel
the highlight long press gesture in _dragInteraction:prepareForSession:completion:.

• UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView _dragInteraction:shouldDelayCompetingGestureRecognizer:]):

2:26 PM Changeset in webkit [219156] by don.olmstead@sony.com

• 6 edits
  1 add in trunk

[WinCairo] Consolidate CMake code related to CURL
​https://bugs.webkit.org/show_bug.cgi?id=170860

Reviewed by Alex Christensen.

.:

• Source/cmake/OptionsWinCairo.cmake:

Source/WebCore:

No new tests. No change in functionality.

• PlatformWinCairo.cmake:
• platform/Curl.cmake: Added.

Source/WebKit:

• PlatformWin.cmake:

2:13 PM Changeset in webkit [219155] by mmaxfield@apple.com

• 23 edits
  16 copies
  117 adds
  3 deletes in trunk

Remove copy of ICU headers from WebKit
​https://bugs.webkit.org/show_bug.cgi?id=116407

Reviewed by Alex Christensen.

Source/JavaScriptCore:

Use WTF's copy of ICU headers.

• Configurations/Base.xcconfig:
• icu/unicode/localpointer.h: Removed.
• icu/unicode/parseerr.h: Removed.
• icu/unicode/platform.h: Removed.
• icu/unicode/ptypes.h: Removed.
• icu/unicode/putil.h: Removed.
• icu/unicode/uchar.h: Removed.
• icu/unicode/ucnv.h: Removed.
• icu/unicode/ucnv_err.h: Removed.
• icu/unicode/ucol.h: Removed.
• icu/unicode/uconfig.h: Removed.
• icu/unicode/ucurr.h: Removed.
• icu/unicode/uenum.h: Removed.
• icu/unicode/uiter.h: Removed.
• icu/unicode/uloc.h: Removed.
• icu/unicode/umachine.h: Removed.
• icu/unicode/unorm.h: Removed.
• icu/unicode/unorm2.h: Removed.
• icu/unicode/urename.h: Removed.
• icu/unicode/uscript.h: Removed.
• icu/unicode/uset.h: Removed.
• icu/unicode/ustring.h: Removed.
• icu/unicode/utf.h: Removed.
• icu/unicode/utf16.h: Removed.
• icu/unicode/utf8.h: Removed.
• icu/unicode/utf_old.h: Removed.
• icu/unicode/utypes.h: Removed.
• icu/unicode/uvernum.h: Removed.
• icu/unicode/uversion.h: Removed.
• runtime/IntlCollator.cpp:
• runtime/IntlDateTimeFormat.cpp:

(JSC::IntlDateTimeFormat::partTypeString):

• runtime/JSGlobalObject.cpp:
• runtime/StringPrototype.cpp:

(JSC::normalize):
(JSC::stringProtoFuncNormalize):

Source/WebCore:

Use WTF's copy of ICU headers.

No new tests because there is no behavior change.

• Configurations/WebCore.xcconfig:
• icu/unicode/bytestream.h: Removed.
• icu/unicode/localpointer.h: Removed.
• icu/unicode/parseerr.h: Removed.
• icu/unicode/platform.h: Removed.
• icu/unicode/ptypes.h: Removed.
• icu/unicode/putil.h: Removed.
• icu/unicode/rep.h: Removed.
• icu/unicode/std_string.h: Removed.
• icu/unicode/strenum.h: Removed.
• icu/unicode/stringpiece.h: Removed.
• icu/unicode/ubrk.h: Removed.
• icu/unicode/uchar.h: Removed.
• icu/unicode/ucnv.h: Removed.
• icu/unicode/ucnv_err.h: Removed.
• icu/unicode/ucol.h: Removed.
• icu/unicode/uconfig.h: Removed.
• icu/unicode/ucurr.h: Removed.
• icu/unicode/uenum.h: Removed.
• icu/unicode/uiter.h: Removed.
• icu/unicode/uloc.h: Removed.
• icu/unicode/umachine.h: Removed.
• icu/unicode/unistr.h: Removed.
• icu/unicode/unorm.h: Removed.
• icu/unicode/unorm2.h: Removed.
• icu/unicode/uobject.h: Removed.
• icu/unicode/urename.h: Removed.
• icu/unicode/uscript.h: Removed.
• icu/unicode/uset.h: Removed.
• icu/unicode/ustring.h: Removed.
• icu/unicode/utext.h: Removed.
• icu/unicode/utf.h: Removed.
• icu/unicode/utf16.h: Removed.
• icu/unicode/utf8.h: Removed.
• icu/unicode/utf_old.h: Removed.
• icu/unicode/utypes.h: Removed.
• icu/unicode/uvernum.h: Removed.
• icu/unicode/uversion.h: Removed.
• platform/graphics/FontCache.h:

(WebCore::FontDescriptionKey::makeFlagsKey):

Source/WebKit/mac:

Use WTF's copy of ICU headers.

• Configurations/WebKitLegacy.xcconfig:
• icu/unicode/localpointer.h: Removed.
• icu/unicode/parseerr.h: Removed.
• icu/unicode/platform.h: Removed.
• icu/unicode/ptypes.h: Removed.
• icu/unicode/putil.h: Removed.
• icu/unicode/uchar.h: Removed.
• icu/unicode/uconfig.h: Removed.
• icu/unicode/ucurr.h: Removed.
• icu/unicode/uidna.h: Removed.
• icu/unicode/uiter.h: Removed.
• icu/unicode/umachine.h: Removed.
• icu/unicode/unorm.h: Removed.
• icu/unicode/unorm2.h: Removed.
• icu/unicode/urename.h: Removed.
• icu/unicode/uscript.h: Removed.
• icu/unicode/ustring.h: Removed.
• icu/unicode/utf.h: Removed.
• icu/unicode/utf16.h: Removed.
• icu/unicode/utf8.h: Removed.
• icu/unicode/utf_old.h: Removed.
• icu/unicode/utypes.h: Removed.
• icu/unicode/uvernum.h: Removed.
• icu/unicode/uversion.h: Removed.

Source/WebKit2:

• Configurations/BaseTarget.xcconfig:

Source/WTF:

Add an extra rsync command to CopyWTFHeaders which copies the ICU headers
to DSTROOT/usr/local/include/. These headers already live inside a
"unicode" folder, so an example path of a header is
DSTROOT/usr/local/include/unicode/uchar.h. This is already in the search
path of the other WebKit projects, so those other projects can remove
their explicit listing of the old place these headers lived.

Also add the remaining ICU 55.1 headers which the other projects (like
WebCore) need. Revert any local changes to these headers in favor of
using the GCC_PREPROCESSOR_DEFINITIONS build setting. This is so we can
compile the same way against unmodified headers.

• Configurations/Base.xcconfig:
• Configurations/CopyWTFHeaders.xcconfig:
• WTF.xcodeproj/project.pbxproj:
• icu/unicode/alphaindex.h: Added.
• icu/unicode/appendable.h: Added.
• icu/unicode/basictz.h: Added.
• icu/unicode/brkiter.h: Added.

(BreakIterator::isBufferClone):

• icu/unicode/bytestrie.h: Added.
• icu/unicode/bytestriebuilder.h: Added.
• icu/unicode/calendar.h: Added.

(Calendar::createInstance):
(Calendar::roll):
(Calendar::internalSet):
(Calendar::weekNumber):

• icu/unicode/caniter.h: Added.
• icu/unicode/chariter.h: Renamed from Source/WebCore/icu/unicode/chariter.h.
• icu/unicode/choicfmt.h: Added.
• icu/unicode/coleitr.h: Added.

(CollationElementIterator::primaryOrder):
(CollationElementIterator::secondaryOrder):
(CollationElementIterator::tertiaryOrder):
(CollationElementIterator::isIgnorable):

• icu/unicode/coll.h: Added.
• icu/unicode/compactdecimalformat.h: Added.
• icu/unicode/curramt.h: Added.

(CurrencyAmount::getCurrency):
(CurrencyAmount::getISOCurrency):

• icu/unicode/currpinf.h: Added.

(CurrencyPluralInfo::operator!=):

• icu/unicode/currunit.h: Added.

(CurrencyUnit::getISOCurrency):

• icu/unicode/datefmt.h: Added.
• icu/unicode/dbbi.h: Added.
• icu/unicode/dcfmtsym.h: Added.

(DecimalFormatSymbols::getSymbol):
(DecimalFormatSymbols::getConstSymbol):
(DecimalFormatSymbols::setSymbol):
(DecimalFormatSymbols::getLocale):
(DecimalFormatSymbols::getCurrencyPattern):

• icu/unicode/decimfmt.h: Added.

(DecimalFormat::getConstSymbol):

• icu/unicode/docmain.h: Added.
• icu/unicode/dtfmtsym.h: Added.
• icu/unicode/dtintrv.h: Added.

(DateInterval::getFromDate):
(DateInterval::getToDate):
(DateInterval::operator!=):

• icu/unicode/dtitvfmt.h: Added.

(DateIntervalFormat::operator!=):

• icu/unicode/dtitvinf.h: Added.

(DateIntervalInfo::operator!=):

• icu/unicode/dtptngen.h: Added.
• icu/unicode/dtrule.h: Added.
• icu/unicode/enumset.h: Added.

(EnumSet::EnumSet):
(EnumSet::~EnumSet):
(EnumSet::clear):
(EnumSet::add):
(EnumSet::remove):
(EnumSet::contains):
(EnumSet::set):
(EnumSet::get):
(EnumSet::isValidEnum):
(EnumSet::isValidValue):
(EnumSet::operator=):
(EnumSet::getAll):
(EnumSet::flag):

• icu/unicode/errorcode.h: Added.
• icu/unicode/fieldpos.h: Added.

(FieldPosition::operator=):
(FieldPosition::operator==):
(FieldPosition::operator!=):

• icu/unicode/filteredbrk.h: Added.
• icu/unicode/fmtable.h: Added.

(Formattable::getDate):
(Formattable::getString):
(Formattable::getLong):
(Formattable::toUFormattable):
(Formattable::fromUFormattable):

• icu/unicode/format.h: Added.
• icu/unicode/fpositer.h: Added.
• icu/unicode/gender.h: Added.
• icu/unicode/gregocal.h: Added.
• icu/unicode/icudataver.h: Added.
• icu/unicode/icuplug.h: Added.
• icu/unicode/idna.h: Added.
• icu/unicode/listformatter.h: Added.

(ListFormatData::ListFormatData):

• icu/unicode/locdspnm.h: Added.

(LocaleDisplayNames::createInstance):

• icu/unicode/locid.h: Added.

(Locale::operator!=):
(Locale::getCountry):
(Locale::getLanguage):
(Locale::getScript):
(Locale::getVariant):
(Locale::getName):
(Locale::isBogus):

• icu/unicode/measfmt.h: Added.
• icu/unicode/measunit.h: Added.
• icu/unicode/measure.h: Added.

(Measure::getNumber):
(Measure::getUnit):

• icu/unicode/messagepattern.h: Added.
• icu/unicode/msgfmt.h: Added.
• icu/unicode/normalizer2.h: Added.
• icu/unicode/normlzr.h: Added.

(Normalizer::operator!= ):
(Normalizer::quickCheck):
(Normalizer::isNormalized):
(Normalizer::compare):

• icu/unicode/numfmt.h: Added.

(NumberFormat::isParseIntegerOnly):
(NumberFormat::isLenient):

• icu/unicode/numsys.h: Added.
• icu/unicode/parsepos.h: Added.

(ParsePosition::operator=):
(ParsePosition::operator==):
(ParsePosition::operator!=):
(ParsePosition::getIndex):
(ParsePosition::setIndex):
(ParsePosition::getErrorIndex):
(ParsePosition::setErrorIndex):

• icu/unicode/plurfmt.h: Added.
• icu/unicode/plurrule.h: Added.
• icu/unicode/rbbi.h: Added.

(RuleBasedBreakIterator::operator!=):

• icu/unicode/rbnf.h: Added.

(RuleBasedNumberFormat::isLenient):
(RuleBasedNumberFormat::getDefaultRuleSet):

• icu/unicode/rbtz.h: Added.
• icu/unicode/regex.h: Added.
• icu/unicode/region.h: Added.
• icu/unicode/reldatefmt.h: Added.
• icu/unicode/resbund.h: Added.
• icu/unicode/schriter.h: Added.
• icu/unicode/scientificnumberformatter.h: Added.
• icu/unicode/search.h: Added.

(SearchIterator::operator!=):

• icu/unicode/selfmt.h: Added.
• icu/unicode/simpletz.h: Added.

(SimpleTimeZone::setStartRule):
(SimpleTimeZone::setEndRule):
(SimpleTimeZone::getOffset):

• icu/unicode/smpdtfmt.h: Added.

(SimpleDateFormat::get2DigitYearStart):

• icu/unicode/sortkey.h: Added.

(CollationKey::operator!=):
(CollationKey::isBogus):
(CollationKey::getByteArray):

• icu/unicode/stringtriebuilder.h: Added.
• icu/unicode/stsearch.h: Added.
• icu/unicode/symtable.h: Added.
• icu/unicode/tblcoll.h: Added.
• icu/unicode/timezone.h: Added.

(TimeZone::getID):
(TimeZone::setID):

• icu/unicode/tmunit.h: Added.
• icu/unicode/tmutamt.h: Added.

(TimeUnitAmount::operator!=):

• icu/unicode/tmutfmt.h: Added.

(TimeUnitFormat::operator!=):

• icu/unicode/translit.h: Added.

(Transliterator::getMaximumContextLength):
(Transliterator::setID):
(Transliterator::integerToken):
(Transliterator::pointerToken):

• icu/unicode/tzfmt.h: Added.
• icu/unicode/tznames.h: Added.
• icu/unicode/tzrule.h: Added.
• icu/unicode/tztrans.h: Added.
• icu/unicode/ubidi.h: Added.
• icu/unicode/ucal.h: Renamed from Source/JavaScriptCore/icu/unicode/ucal.h.
• icu/unicode/ucasemap.h: Added.
• icu/unicode/ucat.h: Added.
• icu/unicode/ucharstrie.h: Added.
• icu/unicode/ucharstriebuilder.h: Added.
• icu/unicode/uchriter.h: Added.
• icu/unicode/uclean.h: Added.
• icu/unicode/ucnv_cb.h: Renamed from Source/WebCore/icu/unicode/ucnv_cb.h.
• icu/unicode/ucnvsel.h: Added.
• icu/unicode/ucoleitr.h: Renamed from Source/WebCore/icu/unicode/ucoleitr.h.
• icu/unicode/uconfig.h:
• icu/unicode/ucsdet.h: Renamed from Source/WebCore/icu/unicode/ucsdet.h.
• icu/unicode/udat.h: Renamed from Source/JavaScriptCore/icu/unicode/udat.h.
• icu/unicode/udata.h: Added.
• icu/unicode/udateintervalformat.h: Added.
• icu/unicode/udatpg.h: Renamed from Source/JavaScriptCore/icu/unicode/udatpg.h.
• icu/unicode/udisplaycontext.h: Renamed from Source/JavaScriptCore/icu/unicode/udisplaycontext.h.
• icu/unicode/ufieldpositer.h: Renamed from Source/JavaScriptCore/icu/unicode/ufieldpositer.h.
• icu/unicode/uformattable.h: Renamed from Source/JavaScriptCore/icu/unicode/uformattable.h.
• icu/unicode/ugender.h: Added.
• icu/unicode/uidna.h: Renamed from Source/WebCore/icu/unicode/uidna.h.
• icu/unicode/uldnames.h: Added.
• icu/unicode/ulistformatter.h: Added.
• icu/unicode/ulocdata.h: Added.
• icu/unicode/umisc.h: Renamed from Source/JavaScriptCore/icu/unicode/umisc.h.
• icu/unicode/umsg.h: Added.
• icu/unicode/unifilt.h: Added.
• icu/unicode/unifunct.h: Added.
• icu/unicode/unimatch.h: Added.
• icu/unicode/unirepl.h: Added.
• icu/unicode/uniset.h: Added.

(UnicodeSet::operator!=):
(UnicodeSet::isFrozen):
(UnicodeSet::containsSome):
(UnicodeSet::isBogus):
(UnicodeSet::fromUSet):
(UnicodeSet::toUSet):
(UnicodeSet::span):
(UnicodeSet::spanBack):

• icu/unicode/unum.h: Renamed from Source/JavaScriptCore/icu/unicode/unum.h.
• icu/unicode/unumsys.h: Renamed from Source/JavaScriptCore/icu/unicode/unumsys.h.
• icu/unicode/upluralrules.h: Added.
• icu/unicode/uregex.h: Added.
• icu/unicode/uregion.h: Added.
• icu/unicode/urep.h: Added.
• icu/unicode/ures.h: Added.

(ures_getUnicodeString):
(ures_getNextUnicodeString):
(ures_getUnicodeStringByIndex):
(ures_getUnicodeStringByKey):

• icu/unicode/usearch.h: Renamed from Source/WebCore/icu/unicode/usearch.h.
• icu/unicode/usetiter.h: Added.

(UnicodeSetIterator::isString):
(UnicodeSetIterator::getCodepoint):
(UnicodeSetIterator::getCodepointEnd):

• icu/unicode/ushape.h: Renamed from Source/WebCore/icu/unicode/ushape.h.
• icu/unicode/uspoof.h: Added.
• icu/unicode/usprep.h: Added.
• icu/unicode/ustdio.h: Added.
• icu/unicode/ustream.h: Added.
• icu/unicode/ustringtrie.h: Added.
• icu/unicode/utf32.h: Added.
• icu/unicode/utmscale.h: Added.
• icu/unicode/utrace.h: Added.
• icu/unicode/utrans.h: Added.
• icu/unicode/utypes.h:
• icu/unicode/vtzone.h: Added.

Tools:

• DumpRenderTree/mac/Configurations/Base.xcconfig:
• TestWebKitAPI/Configurations/Base.xcconfig:
• WebKitTestRunner/Configurations/Base.xcconfig:

1:41 PM Changeset in webkit [219154] by Chris Dumez

• 7 edits
  1 add in trunk

Regression(r218821): Bad cast to WebKit::DiagnosticLoggingClient in WKWebView's _setDiagnosticLoggingDelegate
​https://bugs.webkit.org/show_bug.cgi?id=174163
<rdar://problem/33067518>

Reviewed by Alex Christensen.

Source/WebKit2:

After r218821, WebPageProxy::setDiagnosticLoggingClient() would no longer set the client in
private session. This is an issue because there is code in WKWebView which expects the
DiagnosticLoggingClient to be set and of a specific type. This would lead to bad casts in
WKWebView's _diagnosticLoggingDelegate / _setDiagnosticLoggingDelegate.

To avoid the issue, we now unconditionally update the client in
WebPageProxy::setDiagnosticLoggingClient(). Instead, we implement the logic for disabling
logging in private session in the logging methods themselves, via the
WebPageProxy::effectiveDiagnosticLoggingClient() helper instead.

I also added null checks in WKWebView's _diagnosticLoggingDelegate /
_setDiagnosticLoggingDelegate. Even though the WKWebView sets itself as the diagnostic
logging client, WebPageProxy::diagnosticLoggingClient() can still return null after
calling WebPageProxy::close(). Previously, we would have done a bad cast if the WKWebView's
client would have used this API after calling 'close' as well.

• UIProcess/API/APIDiagnosticLoggingClient.h:
• UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _diagnosticLoggingDelegate]):
(-[WKWebView _setDiagnosticLoggingDelegate:]):

• UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::WebPageProxy):
(WebKit::WebPageProxy::setDiagnosticLoggingClient):
(WebKit::WebPageProxy::close):
(WebKit::WebPageProxy::effectiveDiagnosticLoggingClient):
(WebKit::WebPageProxy::logDiagnosticMessage):
(WebKit::WebPageProxy::logDiagnosticMessageWithResult):
(WebKit::WebPageProxy::logDiagnosticMessageWithValue):
(WebKit::WebPageProxy::logDiagnosticMessageWithEnhancedPrivacy):

• UIProcess/WebPageProxy.h:

(WebKit::WebPageProxy::diagnosticLoggingClient):

Tools:

Add API test coverage.

• TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
• TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewDiagnosticLogging.mm: Added.

(TEST):

1:32 PM Changeset in webkit [219153] by Wenson Hsieh

• 5 edits
  1 add in trunk

When dragging a selection, clearing the selection in dragstart should not crash the web process
​https://bugs.webkit.org/show_bug.cgi?id=174142
<rdar://problem/33067501>

Reviewed by Tim Horton.

Source/WebCore:

Currenly, if the page clears the current selection after dragging starts on selected content, the web process
will crash while attempting to write pasteboard data for a nonexistent selection. This patch adds a trivial
check for this case, bailing if no DHTML dragging data was specified by the page during a selection drag and the
selection has been cleared.

Also removes some unused code for estimating the bounds of the current selection. On iOS, dragging was actually
crashing earlier, in this codepath. However, this information isn't even used anymore, since the drag anchor
point is no longer necessary on iOS.

Test: DataInteractionTests.DoNotCrashWhenSelectionIsClearedInDragStart

• page/DragController.cpp:

(WebCore::DragController::startDrag):

Tools:

Adds a unit test checking that the web process does not crash when the selection is cleared while a selection
drag is starting up.

• TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
• TestWebKitAPI/Tests/WebKit2Cocoa/dragstart-clear-selection.html: Added.
• TestWebKitAPI/Tests/ios/DataInteractionTests.mm:

(TestWebKitAPI::TEST):

1:27 PM Changeset in webkit [219152] by Simon Fraser

• 2 edits in trunk/Source/WebCore

Try to fix iOS 10.3 public SDK builds.

• platform/spi/cocoa/IOSurfaceSPI.h:

1:21 PM Changeset in webkit [219151] by Alan Bujtas

• 8 edits in trunk

REGRESSION (r217522): "Show My Relationship" link in familysearch.org does not work.
​https://bugs.webkit.org/show_bug.cgi?id=174070
LayoutTests/imported/w3c:

Reviewed by Simon Fraser.

• web-platform-tests/css-timing-1/frames-timing-functions-output-expected.txt:
• web-platform-tests/html/semantics/interactive-elements/the-dialog-element/centering-expected.txt:

Source/WebCore:

<rdar://problem/32940653>

Reviewed by Simon Fraser.

Decouple in- and out-of-flow computed position values. Now we match blink's implementation on
in-flow values.
This also fixes the flickering content while scrolling on hbr.org.

Covered by existing test cases.

• css/CSSComputedStyleDeclaration.cpp:

(WebCore::positionOffsetValue):

LayoutTests:

Reviewed by Simon Fraser.

• fast/css/getComputedStyle/computed-style-expected.txt:

1:13 PM Changeset in webkit [219150] by Devin Rousso

• 13 edits
  8 adds in trunk

Web Inspector: Allow users to log any tracked canvas context
​https://bugs.webkit.org/show_bug.cgi?id=173397
<rdar://problem/33111581>

Reviewed by Joseph Pecoraro.

Source/JavaScriptCore:

• inspector/protocol/Canvas.json:

Add resolveCanvasContext command that returns a RemoteObject for the given canvas context.

Source/WebCore:

Tests: inspector/canvas/resolveCanvasContext-2d.html

inspector/canvas/resolveCanvasContext-webgl.html
inspector/canvas/resolveCanvasContext-webgl2.html
inspector/canvas/resolveCanvasContext-webgpu.html

• inspector/InspectorCanvasAgent.h:
• inspector/InspectorCanvasAgent.cpp:

(WebCore::InspectorCanvasAgent::InspectorCanvasAgent):
(WebCore::contextAsScriptValue):
(WebCore::InspectorCanvasAgent::resolveCanvasContext):

Source/WebInspectorUI:

• Localizations/en.lproj/localizedStrings.js:
• UserInterface/Protocol/RemoteObject.js:

(WebInspector.RemoteObject.resolveCanvasContext):

• UserInterface/Views/CanvasTreeElement.js:

(WebInspector.CanvasTreeElement.prototype.populateContextMenu):

LayoutTests:

• inspector/canvas/resolveCanvasContext-2d-expected.txt: Added.
• inspector/canvas/resolveCanvasContext-2d.html: Added.
• inspector/canvas/resolveCanvasContext-webgl-expected.txt: Added.
• inspector/canvas/resolveCanvasContext-webgl.html: Added.
• inspector/canvas/resolveCanvasContext-webgl2-expected.txt: Added.
• inspector/canvas/resolveCanvasContext-webgl2.html: Added.
• inspector/canvas/resolveCanvasContext-webgpu-expected.txt: Added.
• inspector/canvas/resolveCanvasContext-webgpu.html: Added.
• platform/gtk/TestExpectations:
• platform/ios/TestExpectations:
• platform/win/TestExpectations:

1:10 PM Changeset in webkit [219149] by dbates@webkit.org

• 4 edits in trunk

Do not pass API::FrameInfo for source frame or clear out page of target frame on
API navigation
​https://bugs.webkit.org/show_bug.cgi?id=174170
<rdar://problem/33140328>

Reviewed by Brady Eidson.

Source/WebKit2:

As a step towards making it straightforward for an embedding client to determine whether
a WebPageProxy::decidePolicyForNavigationAction() callback was initiated from API we
should not pass frame info for the source frame and should not nullify the page pointer
in the target frame info.

Currently we always pass frame info for the source frame and nullify the page pointer
in both the source frame info and target frame info if the navigation was initiated from
API. This seems subtle and error prone. Instead we should not pass frame info for
the source frame and not nullify the page pointer in the target frame info as a step
towards making using this API less error-prone.

• UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::decidePolicyForNavigationAction):

Tools:

Update tests as needed for the behavior change.

• TestWebKitAPI/Tests/WebKit2Cocoa/DecidePolicyForNavigationAction.mm:

(TEST):

1:07 PM Changeset in webkit [219148] by Chris Dumez

• 2 edits in trunk/Source/WebKit2

Add a few more WebKit2 owners
​https://bugs.webkit.org/show_bug.cgi?id=174169

Reviewed by Brady Eidson.

• Owners:

12:58 PM Changeset in webkit [219147] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebCore

Style sharing check for fullscreen element seems bogus.
​https://bugs.webkit.org/show_bug.cgi?id=160196

Patch by Emilio Cobos Álvarez <​ecobos@igalia.com> on 2017-07-05
Reviewed by Antti Koivisto.

No new tests (no easy way to test this reliably).

• style/StyleSharingResolver.cpp:

(WebCore::Style::SharingResolver::canShareStyleWithElement):

12:56 PM Changeset in webkit [219146] by Simon Fraser

• 4 edits in trunk/Source/WebCore

Add a logging channel for IOSurface allocations
​https://bugs.webkit.org/show_bug.cgi?id=174167

Reviewed by Tim Horton.

Add an "IOSurface" log channel, make IOSurface TextStream-loggable, and log cached
and new IOSurface allocations. Do some namespace-related cleanup.

• platform/Logging.h:
• platform/graphics/cocoa/IOSurface.h:
• platform/graphics/cocoa/IOSurface.mm:

(WebCore::WebCore::IOSurface::create):
(WebCore::WebCore::IOSurface::surfaceID):
(WebCore::operator<<):

12:53 PM Changeset in webkit [219145] by Antti Koivisto

• 12 edits in trunk

Low memory notification shouldn't cause style recalc
​https://bugs.webkit.org/show_bug.cgi?id=173574
<rdar://problem/32616997>

Reviewed by Andreas Kling.

Source/WebCore:

Patch mostly by Myles.

When we receive a low memory warning, we clear the style resolver. Previously, we were using
this as an opportunity to also purge the CSSFontSelector. However, purging the font selector
is wasteful, since the exact same set of CSSFontFace objects will be recreated as soon as the
CSSFontSelector is recreated. It's also harmful because this purge operation causes fonts to
be removed from the document's working set, and therefore triggers a relayout. Instead, this
call should be softened to only delete any transitory caches the CSSFontSelector owns.

We can simply delay the rebuild of the CSSFontSelector to
StyleResolver::appendAuthorStyleSheets(), when it's really needed. This way, we can sidestep
this whole problem.

There's also an added benefit: Now, buildStarted() doesn't have to be idempotent, so we can
enforce a stricter calling sequence with ASSERT()s.

• css/CSSFontFaceSet.cpp:

(WebCore::CSSFontFaceSet::emptyCaches):

• css/CSSFontFaceSet.h:
• css/CSSFontSelector.cpp:

(WebCore::CSSFontSelector::emptyCaches):

Add a separate function to clear font selector caches.

(WebCore::CSSFontSelector::buildStarted):
(WebCore::CSSFontSelector::buildCompleted):
(WebCore::CSSFontSelector::addFontFaceRule):
(WebCore::CSSFontSelector::fontModified):

No need to invalidate while building.

(WebCore::CSSFontSelector::fontRangesForFamily):

• css/CSSFontSelector.h:
• css/StyleResolver.cpp:

(WebCore::StyleResolver::StyleResolver):
(WebCore::StyleResolver::addCurrentSVGFontFaceRules):

Factor into a function from the constructor.

(WebCore::StyleResolver::appendAuthorStyleSheets):

Font selector build is now started and finished by StyleScope.

• css/StyleResolver.h:
• dom/Document.cpp:

(WebCore::Document::resolveStyle):

Call FrameView::styleDidChange() to update any custom scrollbars.
This bug was hidden by spurious style recalcs, tested by fast/css/scrollbar-dynamic-style-change.html

(WebCore::Document::userAgentShadowTreeStyleResolver):
(WebCore::Document::didClearStyleResolver):

Don't start the font selector rebuild after clearing the resolver. It would cause style recalc trashing.
Instead the build starts when the new resolver is constructed.

• page/MemoryRelease.cpp:

(WebCore::releaseCriticalMemory):

Release font selector caches.

• style/StyleScope.cpp:

(WebCore::Style::Scope::resolver):

LayoutTests:

• platform/mac/printing/width-overflow-expected.txt:

1px width change that doesn't affect what is being tested.

12:05 PM Changeset in webkit [219144] by Brent Fulgham

• 5 edits in trunk/Source

[WK2] Prevent ResourceLoadStatistics from triggering a cascade of read/write events
​https://bugs.webkit.org/show_bug.cgi?id=174062\
<rdar://problem/33086744>

Reviewed by Chris Dumez.

Source/WebCore:

Treat DISPATCH_VNODE_DELETE, DISPATCH_VNODE_RENAME, and DISPATCH_VNODE_REVOKE as equivalent
"file is unavailable" events, and act as though the file was deleted. Don't listen for
DISPATCH_VNODE_EXTEND, since we always get a DISPATCH_VNODE_WRITE as well, and we only
want to read once.

Finally, add some logging to support future investigations.

• platform/FileMonitor.h:

(WebCore::FileMonitor::platformMonitor): Expose dispatch_source_t for logging purposes.

• platform/cocoa/FileMonitorCocoa.mm:

(WebCore::FileMonitor::startMonitoring): Add logging.
(WebCore::FileMonitor::stopMonitoring): Ditto.

Source/WebKit2:

ResourceLoadStatistics was triggering periods of high CPU use due to a cascade of read/write
operations:
(1) The 'makeRefPtr' call in FileMonitor::startMonitoring was capturing a reference to itself, preventing

the FileMonitor from being destroyed. This caused the file modification handler to fire in response
to our own write events, creating a ridiculous read/write cycle. This problem was addressed in
the short term by stopping the file monitor in WebResourceLoadStatisticsStore::stopMonitoringStatisticsStorage,
rather than relying on the destructor to shut things down. This will be improved in a
subsequent patch.

(2) 'syncWithExistingStatisticsStorageIfNeeded' was creating a FileMonitor during the write operation,

which exacerbated the chain of read/writes already present due to the self-reference described above.

(3) Because VNODE dispatch sources are low level, they do not offer a means of filtering out operations

triggered by the current process. To avoid this, I added code to track the file modification time, so
that we don't bother reading a file that holds data that is older than the in-memory data, even though
we receive a file modification dispatch. Writes seem to trigger a chain of notification events in rapid
succession. Once we've responded to the first of these events, we don't need to to further reads until
the data on disk changes again.

We also shouldn't allow the ResourceLoadStatistics worker thread to consume high CPU resources. Run it
as utility QoS, avoiding using the CPU when other work is going on.

Drive-by fix: The closure in setWritePersistentStoreCallback() should stop monitoring before writing
data, and should start monitoring after the write completes.

• UIProcess/WebResourceLoadStatisticsStore.cpp:

(WebKit::WebResourceLoadStatisticsStore::WebResourceLoadStatisticsStore): Run our worker queue
as a utility-level process.
(WebKit::WebResourceLoadStatisticsStore::registerSharedResourceLoadObserver): Stop checking for
updates before writing, and begin checking again once the write is complete.
(WebKit::WebResourceLoadStatisticsStore::statisticsFileModificationTime): Added.
(WebKit::WebResourceLoadStatisticsStore::readDataFromDiskIfNeeded): Avoid reading the file if it
was last modified on (or before) the time we last read the file.
(WebKit::WebResourceLoadStatisticsStore::refreshFromDisk): Ditto.
(WebKit::WebResourceLoadStatisticsStore::stopMonitoringStatisticsStorage): Explicitly stop file
monitoring so that the active file modification handler will terminate.
(WebKit::WebResourceLoadStatisticsStore::syncWithExistingStatisticsStorageIfNeeded): Do not begin
monitoring the file after syncing, since this is only used as part of an ongoing write operation.

11:40 AM Changeset in webkit [219143] by jmarcell@apple.com

• 7 edits in trunk/Source

Versioning.

11:36 AM Changeset in webkit [219142] by Jonathan Bedard

• 1 edit
  80 adds in trunk/LayoutTests

Move internal iOS 11 TestExpectations to OpenSource
<rdar://problem/32717028>

Unreviewed test gardening.

• platform/ios-11: Added.

11:31 AM Changeset in webkit [219141] by jmarcell@apple.com

• 1 copy in tags/Safari-604.1.29

Tag Safari-604.1.29.

11:14 AM Changeset in webkit [219140] by Jonathan Bedard

• 20 edits
  5 copies
  6 adds in trunk

Add WebKitPrivateFrameworkStubs for iOS 11
​https://bugs.webkit.org/show_bug.cgi?id=173988

Reviewed by David Kilzer.

Source/JavaScriptCore:

• Configurations/Base.xcconfig: iphoneos and iphonesimulator should use the

same directory for private framework stubs.

Source/WebCore:

• Configurations/WebCore.xcconfig: iphoneos and iphonesimulator should use the

same directory for private framework stubs.

Source/WebCore/PAL:

• Configurations/PAL.xcconfig: iphoneos and iphonesimulator should use the

same directory for private framework stubs.

Source/WebKit/mac:

• Configurations/WebKitLegacy.xcconfig: iphoneos and iphonesimulator should

use the same directory for private framework stubs.

Source/WebKit2:

• Configurations/BaseTarget.xcconfig: iphoneos and iphonesimulator should use the

same directory for private framework stubs.

Tools:

• DumpRenderTree/mac/Configurations/Base.xcconfig: iphoneos and iphonesimulator

should use the same directory for private framework stubs.

• WebKitTestRunner/Configurations/Base.xcconfig: Ditto.

WebKitLibraries:

• WebKitPrivateFrameworkStubs/iOS/9: Add Mac architecture for Simulator.
• WebKitPrivateFrameworkStubs/iOS/10: Ditto..
• WebKitPrivateFrameworkStubs/iOS/11: Added.

11:08 AM Changeset in webkit [219139] by aestes@apple.com

• 4 edits in trunk/Source/WebKit2

[iOS] WKActionSheetAssistants can outlive their host views
​https://bugs.webkit.org/show_bug.cgi?id=174160
<rdar://problem/20638607>

Reviewed by Tim Horton.

WKActionSheetAssistant keeps a raw pointer to its host UIView, and nothing clears it when
the host view is deallocated. If the assistant outlives the view, we can end up accessing a
pointer to a deallocated UIView and crashing.

I don't know how to reproduce such a crash, but this patch guards against it by doing the
following:

1. Make _view a WeakObjCPtr in WKActionSheetAssistant to ensure it gets set to nil when the UIView is deallocated.
2. Call -[WKActionSheetAssistant cleanupSheet] when a WKContentView or WKPDFView is deallocated, or when the Web process crashes. This will ensure the action sheet is dismissed and prevent the user from tapping on an action that's no longer valid.

• UIProcess/ios/WKActionSheetAssistant.mm:

(-[WKActionSheetAssistant superviewForSheet]):
(-[WKActionSheetAssistant _presentationRectForSheetGivenPoint:inHostView:]):
(-[WKActionSheetAssistant presentationRectForElementUsingClosestIndicatedRect]):
(-[WKActionSheetAssistant presentationRectForIndicatedElement]):
(-[WKActionSheetAssistant _shouldPresentAtTouchLocationForElementRect:]):

• UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView cleanupInteraction]):

• UIProcess/ios/WKPDFView.mm:

(-[WKPDFView dealloc]):

11:01 AM Changeset in webkit [219138] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebCore

Don't resolve an extra computed style for getComputedStyle in a display: none subtree.
​https://bugs.webkit.org/show_bug.cgi?id=174145

Before this, we were also resolving the first ancestor's style as
inheriting from itself, which felt pretty wrong (though I think it's
not observable).

Patch by Emilio Cobos Álvarez <​ecobos@igalia.com> on 2017-07-05
Reviewed by Antti Koivisto.

No new tests (non-observable behavior).

• dom/Element.cpp:

(WebCore::Element::resolveComputedStyle):

10:56 AM Changeset in webkit [219137] by fred.wang@free.fr

• 13 edits in trunk/Source

Move ScrolledContentsLayer property to ScrollingStateScrollingNode
​https://bugs.webkit.org/show_bug.cgi?id=174134

Patch by Frederic Wang <​fwang@igalia.com> on 2017-07-05
Reviewed by Simon Fraser.

Source/WebCore:

ScrollingStateFrameScrollingNode and ScrollingStateOverflowScrollingNode both use a
ScrolledContentsLayer property for the same purpose. This commit moves that property into
their parent class ScrollingStateScrollingNode, so that more code is shared between the two
classes. This will also help the refactoring in bug 174130.

No new tests, only dumped tree may change a bit.

• page/scrolling/ScrollingStateFrameScrollingNode.cpp: Remove scrolled contents layer.

(WebCore::ScrollingStateFrameScrollingNode::ScrollingStateFrameScrollingNode):
(WebCore::ScrollingStateFrameScrollingNode::dumpProperties):
(WebCore::ScrollingStateFrameScrollingNode::setScrolledContentsLayer): Deleted.

• page/scrolling/ScrollingStateFrameScrollingNode.h: Ditto.
• page/scrolling/ScrollingStateOverflowScrollingNode.cpp: Ditto.

(WebCore::ScrollingStateOverflowScrollingNode::ScrollingStateOverflowScrollingNode):
(WebCore::ScrollingStateOverflowScrollingNode::dumpProperties):
(WebCore::ScrollingStateOverflowScrollingNode::setScrolledContentsLayer): Deleted.

• page/scrolling/ScrollingStateOverflowScrollingNode.h: Ditto.

(): Deleted.
(WebCore::ScrollingStateOverflowScrollingNode::scrolledContentsLayer): Deleted.

• page/scrolling/ScrollingStateScrollingNode.cpp: Add scrolled contents layer.

(WebCore::ScrollingStateScrollingNode::ScrollingStateScrollingNode):
(WebCore::ScrollingStateScrollingNode::setScrolledContentsLayer):
(WebCore::ScrollingStateScrollingNode::dumpProperties): Use the label from the overflow class
which is different from the frame class. The dumping order may change a bit too.

• page/scrolling/ScrollingStateScrollingNode.h: Add ScrolledContentsLayer to the enum and

scrolled contents layer.
(WebCore::ScrollingStateScrollingNode::scrolledContentsLayer):

• page/scrolling/mac/ScrollingTreeFrameScrollingNodeMac.mm:

(WebCore::ScrollingTreeFrameScrollingNodeMac::commitStateBeforeChildren): Adjust enum value
to use ScrollingStateScrollingNode::ScrolledContentsLayer.

Source/WebKit2:

• Shared/Scrolling/RemoteScrollingCoordinatorTransaction.cpp:

(ArgumentCoder<ScrollingStateScrollingNode>::encode): Add encoding for scrolled contents
layer.
(ArgumentCoder<ScrollingStateFrameScrollingNode>::encode): Remove encoding for scrolled
contents layer.
(ArgumentCoder<ScrollingStateOverflowScrollingNode>::encode): Ditto.
(ArgumentCoder<ScrollingStateScrollingNode>::decode): Add decoding for scrolled contents
layer.
(ArgumentCoder<ScrollingStateFrameScrollingNode>::decode): Remove decoding for scrolled
contents layer.
(ArgumentCoder<ScrollingStateOverflowScrollingNode>::decode): Ditto.
(WebKit::dump): Move dumping of scrolled contents layer from overflow/frame nodes to
scrolling node.

• UIProcess/Scrolling/RemoteScrollingCoordinatorProxy.cpp:

(WebKit::RemoteScrollingCoordinatorProxy::connectStateNodeLayers): Adjust enum value to use
ScrollingStateScrollingNode::ScrolledContentsLayer.

• UIProcess/Scrolling/ios/ScrollingTreeOverflowScrollingNodeIOS.mm:

(WebKit::ScrollingTreeOverflowScrollingNodeIOS::commitStateBeforeChildren): Ditto.

• UIProcess/ios/RemoteScrollingCoordinatorProxyIOS.mm:

(WebKit::RemoteScrollingCoordinatorProxy::connectStateNodeLayers): Ditto.

10:43 AM Changeset in webkit [219136] by adachan@apple.com

• 2 edits in trunk/Source/WebKit2

Fix crash in UIKit: +[UIViewController _viewControllerForFullScreenPresentationFromView:]
​https://bugs.webkit.org/show_bug.cgi?id=174143
<rdar://problem/28384582>

Reviewed by Wenson Hsieh.

In -[WKActionSheet willRotate], we can't guarantee that the action sheet belongs
in a window, and passing nil to +[UIViewController _viewControllerForFullScreenPresentationFromView:]
throws an exception. To fix this, bail early if the result from -hostViewForSheet is nil.

• UIProcess/ios/WKActionSheet.mm:

(-[WKActionSheet willRotate]):

10:41 AM Changeset in webkit [219135] by eric.carlson@apple.com

• 4 edits
  1 add in trunk

[MediaStream] Protect request and web view during gUM client callback
​https://bugs.webkit.org/show_bug.cgi?id=174096
<rdar://problem/32833102>

Reviewed by Youenn Fablet.

Source/WebKit2:

Retain the message and WebView during asynchronous calls so they won't be
released if a navigation happens during a call to the UA for getUserMedia
or enumerateMediaDevices.

• UIProcess/Cocoa/UIDelegate.mm:

(WebKit::requestUserMediaAuthorizationForDevices):
(WebKit::UIDelegate::UIClient::decidePolicyForUserMediaPermissionRequest):
(WebKit::UIDelegate::UIClient::checkUserMediaPermissionForOrigin):

Tools:

• TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
• TestWebKitAPI/Tests/WebKit2/GetUserMediaNavigation.mm: New test.

9:51 AM Changeset in webkit [219134] by jfbastien@apple.com

• 3 edits in trunk/Source/JavaScriptCore

WebAssembly: implement name section's module name, skip unknown sections
​https://bugs.webkit.org/show_bug.cgi?id=172008

Reviewed by Keith Miller.

Parse the WebAssembly module name properly, and skip unknown
sections. This is useful because as toolchains support new types
of names we want to keep displaying the information we know about
and simply ignore new information. That capability was designed
into WebAssembly's name section.

Failure to commit this patch would mean that WebKit won't display
stack trace information, which would make developers sad.

Module names were added here: ​https://github.com/WebAssembly/design/pull/1055

Note that this patch doesn't do anything with the parsed name! Two
reasons for this: module names aren't supported in binaryen yet,
so I can't write a simple binary test; and using the name is a
slightly riskier change because it requires changing StackVisitor
+ StackFrame (where they print "[wasm code]") which requires
figuring out the frame's Module. The latter bit isn't trivial
because we only know wasm frames from their tag bits, and
CodeBlocks are always nullptr.

Binaryen bug: ​https://github.com/WebAssembly/binaryen/issues/1010

I filed #174098 to use the module name.

• wasm/WasmFormat.h:

(JSC::Wasm::isValidNameType):

• wasm/WasmNameSectionParser.cpp:

9:40 AM Changeset in webkit [219133] by Matt Lewis

• 2 edits in trunk/LayoutTests

Adjusted test expectations for tiled-drawing/scrolling/fast-scroll-iframe-latched-mainframe.html.
​https://bugs.webkit.org/show_bug.cgi?id=168937

Unreviewed test gardening.

• platform/mac-wk2/TestExpectations:

9:35 AM Changeset in webkit [219132] by commit-queue@webkit.org

• 2 edits in trunk/LayoutTests

Incorrect IfModule on Fedora with with PHP 7
​https://bugs.webkit.org/show_bug.cgi?id=174159

Patch by Charlie Turner <​cturner@igalia.com> on 2017-07-05
Reviewed by Michael Catanzaro.

• http/conf/fedora-httpd-2.4-php7.conf:

9:17 AM Changeset in webkit [219131] by Wenson Hsieh

• 2 edits in trunk/Tools

Unreviewed, guard iOS 11-dependent UIPasteboardTests to be iOS 11+ only

• TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:

9:11 AM Changeset in webkit [219130] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebCore

ProcessingInstruction::clearExistingCachedSheet doesn't really exist.
​https://bugs.webkit.org/show_bug.cgi?id=174146

Patch by Emilio Cobos Álvarez <​ecobos@igalia.com> on 2017-07-05
Reviewed by Chris Dumez.

No new tests (no functionality change).

• dom/ProcessingInstruction.h: Remove dead declaration.

9:07 AM Changeset in webkit [219129] by Matt Lewis

• 11 edits in trunk

Unreviewed, rolling out r219128.

Spoke with engineer who originally submitted, Patch for APi
test to follow.

Reverted changeset:

"Unreviewed, rolling out r219070."
​https://bugs.webkit.org/show_bug.cgi?id=174082
​http://trac.webkit.org/changeset/219128

8:59 AM Changeset in webkit [219128] by Matt Lewis

• 11 edits in trunk

Unreviewed, rolling out r219070.

This revision caused consistent failures of the API test
UIPasteboardTests.DoNotPastePlainTextAsURL on iOS.

Reverted changeset:

"Pasting single words copied to UIPasteboard inserts URLs in
editable areas"
​https://bugs.webkit.org/show_bug.cgi?id=174082
​http://trac.webkit.org/changeset/219070

8:53 AM Changeset in webkit [219127] by commit-queue@webkit.org

• 5 edits
  2 adds in trunk

Receiving tracks should be ended when peer connection is being closed
​https://bugs.webkit.org/show_bug.cgi?id=174109

Patch by Youenn Fablet <​youenn@apple.com> on 2017-07-05
Reviewed by Eric Carlson.

Source/WebCore:

Test: webrtc/peer-connection-track-end.html

As per ​https://www.w3.org/TR/webrtc/#dom-rtcpeerconnection-close, tracks should be ended when peer connection is closed.
Also updating transceiver stopped state.

• Modules/mediastream/RTCPeerConnection.cpp:

(WebCore::RTCPeerConnection::doClose):

• Modules/mediastream/RTCRtpReceiver.cpp:

(WebCore::RTCRtpReceiver::stop):

• Modules/mediastream/RTCRtpReceiver.h:

LayoutTests:

• webrtc/peer-connection-track-end-expected.txt: Added.
• webrtc/peer-connection-track-end.html: Added.

7:05 AM Changeset in webkit [219126] by zandobersek@gmail.com

• 2 edits in trunk/Source/WebKit2

[GLib] Incorrect <glib/gi18n.h> include in WebKitWebsiteData
​https://bugs.webkit.org/show_bug.cgi?id=174093

Reviewed by Michael Catanzaro.

• UIProcess/API/glib/WebKitWebsiteData.cpp: Include <glib/gi18n-lib.h>

rather than <glib/gi18n.h>, since the former has to be included in a
library while the latter should only be included in a standalone application.

Jul 4, 2017:

9:44 PM Changeset in webkit [219125] by Said Abou-Hallawa

• 2 edits in trunk/Source/WebCore

Unreviewed, review follow-up after r218961

• platform/graphics/BitmapImage.cpp:

(WebCore::BitmapImage::updateFromSettings):

5:59 PM Changeset in webkit [219124] by Yusuke Suzuki

• 4 edits in trunk/Source/WTF

[WTF] Make double-conversion's cache data constant and drop double_conversion::initialize()
​https://bugs.webkit.org/show_bug.cgi?id=174124

Reviewed by Saam Barati.

We annotate double-conversion's cache data as const and constexpr. And move it out of function.
Since they are not involving global constructors, they are compiled as rodata and initialized
without calling double_conversion::initialize().

And we drop double_conversion::initialize() function since it is no longer necessary.

• wtf/Threading.cpp:

(WTF::initializeThreading):

• wtf/dtoa/cached-powers.cc:
• wtf/dtoa/cached-powers.h:

3:07 PM Changeset in webkit [219123] by Antti Koivisto

• 3 edits in trunk/Source/WebCore

RenderThemeCocoa::mediaControlsFormattedStringForDuration is leaking NSDateComponentsFormatters
​https://bugs.webkit.org/show_bug.cgi?id=174138

Reviewed by Ryosuke Niwa.

Saw a random spin here during media playback. Looks like we are leaking.

• rendering/RenderThemeCocoa.h:
• rendering/RenderThemeCocoa.mm:

(WebCore::RenderThemeCocoa::mediaControlsFormattedStringForDuration):

Reuse NSDateComponentsFormatter.

2:53 PM BugsWebKitOrgImprovements edited by Michael Catanzaro

CC reviews on bugs when leaving a review (diff)

2:34 PM BugsWebKitOrgImprovements edited by sam@webkit.org

(diff)

1:14 PM Changeset in webkit [219122] by Michael Catanzaro

• 1 edit
  2 deletes in trunk/Tools

Remove unused EFL logo from bot watcher dashboard
​https://bugs.webkit.org/show_bug.cgi?id=174136

Reviewed by Alexey Proskuryakov.

• BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/EFL.png: Removed.
• BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/​EFL@2x.png: Removed.

10:58 AM Changeset in webkit [219121] by Antti Koivisto

• 6 edits in trunk

FrameView should not set RenderView::logicalWidth directly for printing
​https://bugs.webkit.org/show_bug.cgi?id=174135

Reviewed by Zalan Bujtas.

Source/WebCore:

Renderer logicalWidth should be set by layout. Direct override by RenderView when printing means
that we don't layout children in all cases when the width changes. This is currently mostly hidden
by spurious layouts but causes problems when trying to fix other things that reduces those.

• page/FrameView.cpp:

(WebCore::FrameView::forceLayoutForPagination):

Instead of calling setLogicalWidth directly call the new setPageLogicalSize that sets both the width
and the height uniformly.

• rendering/RenderView.cpp:

(WebCore::RenderView::updateLogicalWidth):

Use pageLogicalSize->width() in printing state instead of skipping the logical width update entirely.
This ensures that the layout will progress to children when the page logical width changes.

(WebCore::RenderView::initializeLayoutState):
(WebCore::RenderView::layout):
(WebCore::RenderView::pageOrViewLogicalHeight):
(WebCore::RenderView::setPageLogicalSize):

• rendering/RenderView.h:

Replace the existing m_pageLogicalHeight with std::optional m_pageLogicalSize.

LayoutTests:

• platform/mac/printing/width-overflow-expected.txt:

This is a progression, view and root element sizes now match.
Printing output is not affected.

10:51 AM Changeset in webkit [219120] by Michael Catanzaro

• 3 edits in trunk/Tools

[GTK] Add more GTK bots to dashboard
​https://bugs.webkit.org/show_bug.cgi?id=174129

Reviewed by Carlos Alberto Lopez Perez.

We have a bunch of GTK bots that I never look at because they're not on the dashboard. Add
them.

This also changes the sort order to put WPE above GTK so that it's not buried under all the
less-essential GTK bots.

• BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
• BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:

(WebKitBuildbot):

10:43 AM Changeset in webkit [219119] by Yusuke Suzuki

• 2 edits in trunk/Source/WTF

[WTF] Initialize srandom and srand with cryptographically random number
​https://bugs.webkit.org/show_bug.cgi?id=174123

Reviewed by Mark Lam.

Use cryptographically random number instead of current time as a seed.

• wtf/RandomNumberSeed.h:

(WTF::initializeRandomNumberGenerator):

7:02 AM Changeset in webkit [219118] by Michael Catanzaro

• 4 edits
  3 adds in trunk/Tools

[WPE] Add WPE to bot watcher dashboard
​https://bugs.webkit.org/show_bug.cgi?id=174119

Reviewed by Alexey Proskuryakov.

• BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/CREDIT: Added.
• BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/WPE.png: Added.
• BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/​WPE@2x.png: Added.
• BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
• BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:

(WebKitBuildbot):

• BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:

(table.queue-grid tr.platform.linux-wpe img.logo):

4:43 AM Changeset in webkit [219117] by commit-queue@webkit.org

• 2 edits in trunk/Source/WTF

Xcode duplicate UUID for DisallowCType.h and DispatchPtr.h
​https://bugs.webkit.org/show_bug.cgi?id=174117

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2017-07-04
Reviewed by Alexey Proskuryakov.

• WTF.xcodeproj/project.pbxproj:

Give DisallowCType.h and DispatchPtr.h different UUIDs.

4:12 AM Changeset in webkit [219116] by calvaris@igalia.com

• 3 edits in trunk/Source/WebCore

[EME] Solve a couple of compiler warnings
​https://bugs.webkit.org/show_bug.cgi?id=174020

Reviewed by Michael Catanzaro.

• Modules/encryptedmedia/CDM.cpp:

(WebCore::CDM::isPersistentType): Added default return and
assertion.

• Modules/encryptedmedia/MediaKeySession.cpp:

(WebCore::MediaKeySession::updateKeyStatuses): This warning was
already solved but I think adding an assertion for the default
case can help catch errors in the future.

1:03 AM Changeset in webkit [219115] by commit-queue@webkit.org

• 24 edits in trunk/Source

Cleanup some StringBuilder use
​https://bugs.webkit.org/show_bug.cgi?id=174118

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2017-07-04
Reviewed by Andreas Kling.

Source/JavaScriptCore:

• runtime/FunctionConstructor.cpp:

(JSC::constructFunctionSkippingEvalEnabledCheck):

• tools/FunctionOverrides.cpp:

(JSC::parseClause):

• wasm/WasmOMGPlan.cpp:
• wasm/WasmPlan.cpp:
• wasm/WasmValidate.cpp:

Source/WebCore:

• Modules/mediastream/PeerConnectionBackend.cpp:

(WebCore::filterICECandidate):

• Modules/mediastream/libwebrtc/LibWebRTCPeerConnectionBackend.cpp:
• contentextensions/ContentExtension.cpp:

(WebCore::ContentExtensions::ContentExtension::compileGlobalDisplayNoneStyleSheet):

• css/CSSFontStyleRangeValue.cpp:

(WebCore::CSSFontStyleRangeValue::customCSSText):

• css/CSSFontStyleValue.cpp:

(WebCore::CSSFontStyleValue::customCSSText):

• css/CSSGridAutoRepeatValue.cpp:

(WebCore::CSSGridAutoRepeatValue::customCSSText):

• css/parser/CSSParser.cpp:

(WebCore::CSSParser::parseFontFaceDescriptor):

• dom/Attr.cpp:
• html/canvas/WebGPURenderingContext.cpp:
• html/parser/HTMLParserIdioms.cpp:
• platform/network/ParsedContentType.cpp:
• platform/network/cocoa/CookieCocoa.mm:
• platform/text/mac/LocaleMac.mm:
• xml/XMLHttpRequest.cpp:

(WebCore::XMLHttpRequest::getAllResponseHeaders):

Source/WebKit2:

• NetworkProcess/capture/NetworkCaptureManager.cpp:

(WebKit::NetworkCapture::Manager::hashToPath):

• UIProcess/WebPageProxy.cpp: