Context Navigation

← Previous Period
Next Period →

Timeline

Jul 19, 2017:

11:09 PM Changeset in webkit [219678] by zandobersek@gmail.com

13 edits
10 adds
2 deletes in trunk/Source/WebCore

[EME] Push CDMInstance, CDMPrivate and associated types into the Platform layer
https://bugs.webkit.org/show_bug.cgi?id=174496

Reviewed by Xabier Rodriguez-Calvar.

Move the CDMInstance and CDMPrivate interfaces into the platform layer, enabling
implementations of specific key systems at that level, as well as integration with
the MediaPlayerPrivate stack without any layering violations.

While the platform layer still uses the WebCore namespace, the two interface files
have now been moved under the platform/encryptedmedia/ directory and out of the
Modules/encryptedmedia/ directory where the Web-facing API implementation resides.

The two interfaces integrated closely with the Web-facing enumerations and
dictionaries: MediaKeyMessageType, MediaKeySessionType, MediaKeyStatus,
MediaKeySystemConfiguration, MediaKeySystemCapability, MediaKeysRequirement
and MediaKeysRestrictions. Definitions of these types are also moved to the
platform layer without any changes (apart from renaming), and the previous
types now alias against the types now located in the platform layer.

No new tests -- no change in behavior.

CMakeLists.txt:
Modules/encryptedmedia/CDM.cpp:
Modules/encryptedmedia/CDM.h:
Modules/encryptedmedia/MediaKeyMessageType.h:
Modules/encryptedmedia/MediaKeySessionType.h:
Modules/encryptedmedia/MediaKeyStatus.h:
Modules/encryptedmedia/MediaKeySystemAccess.cpp:
Modules/encryptedmedia/MediaKeySystemAccess.h:
Modules/encryptedmedia/MediaKeySystemConfiguration.h:
Modules/encryptedmedia/MediaKeySystemMediaCapability.h:
Modules/encryptedmedia/MediaKeysRequirement.h:
Modules/encryptedmedia/MediaKeysRestrictions.h:
platform/encryptedmedia/CDMInstance.h: Renamed from Source/WebCore/Modules/encryptedmedia/CDMInstance.h.
platform/encryptedmedia/CDMKeyStatus.h: Copied from Source/WebCore/Modules/encryptedmedia/MediaKeyStatus.h.
platform/encryptedmedia/CDMKeySystemConfiguration.h: Copied from Source/WebCore/Modules/encryptedmedia/MediaKeySystemConfiguration.h.
platform/encryptedmedia/CDMMediaCapability.h: Copied from Source/WebCore/Modules/encryptedmedia/MediaKeySystemMediaCapability.h.
platform/encryptedmedia/CDMMessageType.h: Copied from Source/WebCore/Modules/encryptedmedia/MediaKeyMessageType.h.
platform/encryptedmedia/CDMPrivate.h: Renamed from Source/WebCore/Modules/encryptedmedia/CDMPrivate.h.
platform/encryptedmedia/CDMRequirement.h: Copied from Source/WebCore/Modules/encryptedmedia/MediaKeysRequirement.h.
platform/encryptedmedia/CDMRestrictions.h: Copied from Source/WebCore/Modules/encryptedmedia/MediaKeysRestrictions.h.
platform/encryptedmedia/CDMSessionType.h: Copied from Source/WebCore/Modules/encryptedmedia/MediaKeySessionType.h.

11:08 PM Changeset in webkit [219677] by zandobersek@gmail.com

2 edits in trunk/Source/WebCore

Unreviewed follow-up to r219674.

page/scrolling/coordinatedgraphics/ScrollingCoordinatorCoordinatedGraphics.cpp:

Remove the AsyncScrollingCoordinator.h header include that was added by accident.

10:57 PM Changeset in webkit [219676] by zandobersek@gmail.com

7 edits
1 add in trunk/Source

[CMake] Clean up Web Crypto build targets
https://bugs.webkit.org/show_bug.cgi?id=174253

Reviewed by Alex Christensen.

Gather the common WebCrypto source files in CMakeLists.txt, including them
in the build unconditionally and instead relying on ENABLE_SUBTLE_CRYPTO
build guards to exclude the code from compilation if the feature is disabled.

PlatformGTK.cmake, PlatformMac.cmake and PlatformWPE.cmake can then remove
duplicated build targets. PlatformMac.cmake still lists all the Mac-specific
Web Crypto build targets.

PlatformGTK.cmake and PlatformWPE.cmake now include GCrypt.cmake if the
USE_GCRYPT variable is enabled. Both ports at the moment enable that variable
though as they by default leverage a libgcrypt-based CrpytoDigest implementation
in the PAL library.

The new GCrypt.cmake file adds the libgcrypt-specific Web Crypto build targets to
the build and also sets up libgcrypt include directiories and libraries.

No new tests -- no change in behavior.

CMakeLists.txt:
PlatformGTK.cmake:
PlatformMac.cmake:
PlatformWPE.cmake:
platform/GCrypt.cmake: Added.

10:46 PM Changeset in webkit [219675] by commit-queue@webkit.org

8 edits
1 delete in trunk/Source/WebCore

[WebIDL] Remove custom bindings for CommandLineAPIHost
https://bugs.webkit.org/show_bug.cgi?id=174642

Patch by Sam Weinig <sam@webkit.org> on 2017-07-19
Reviewed by Joseph Pecoraro.

CMakeLists.txt:
WebCore.xcodeproj/project.pbxproj:
bindings/js/JSBindingsAllInOne.cpp:
bindings/js/JSCommandLineAPIHostCustom.cpp: Removed.

Remove JSCommandLineAPIHostCustom.cpp.

bindings/js/JSDOMConvertObject.h:

(WebCore::JSConverter<IDLObject>::convert):
Add missing JSConverter specialization for IDLObject.

inspector/CommandLineAPIHost.cpp:

(WebCore::CommandLineAPIHost::inspect):
(WebCore::listenerEntriesFromListenerInfo):
(WebCore::CommandLineAPIHost::inspectedObject):
(WebCore::CommandLineAPIHost::databaseId):
(WebCore::CommandLineAPIHost::storageId):
(WebCore::CommandLineAPIHost::inspectImpl): Deleted.
(WebCore::CommandLineAPIHost::getEventListenersImpl): Deleted.
(WebCore::CommandLineAPIHost::databaseIdImpl): Deleted.
(WebCore::CommandLineAPIHost::storageIdImpl): Deleted.

inspector/CommandLineAPIHost.h:
inspector/CommandLineAPIHost.idl:

Replace custom bindings with modern bindings affordances: dictionaries, records and sequences.

10:43 PM Changeset in webkit [219674] by zandobersek@gmail.com

2 edits in trunk/Source/WebCore

Unreviewed CoordGraphics build fix.

page/scrolling/coordinatedgraphics/ScrollingCoordinatorCoordinatedGraphics.cpp:

(WebCore::ScrollingCoordinatorCoordinatedGraphics::updateNodeViewportConstraints):
This should be defined for the ScrollingCoordinatorCoordinatedGraphics class.
Also fix the setFixedToViewport() call, fishing out the GraphicsLayer object from
the ScrollingStateNode's LayerRepresentation.
(WebCore::AsyncScrollingCoordinator::updateNodeViewportConstraints): Deleted.

10:23 PM Changeset in webkit [219673] by Chris Dumez

11 edits
3 deletes in trunk/Source

Drop SQLException type
https://bugs.webkit.org/show_bug.cgi?id=174665

Reviewed by Sam Weinig.

Source/WebCore:

Drop SQLException type. We never throw such exception. Also, Firefox
and Chrome no longer expose this type.

CMakeLists.txt:
DerivedSources.cpp:
DerivedSources.make:
Modules/webdatabase/SQLException.cpp: Removed.
Modules/webdatabase/SQLException.h: Removed.
Modules/webdatabase/SQLException.idl: Removed.
WebCore.xcodeproj/project.pbxproj:
bindings/js/JSDOMExceptionHandling.cpp:

(WebCore::createDOMException):

bindings/js/JSExceptionBase.cpp:

(WebCore::toExceptionBase):

dom/DOMExceptions.in:

Source/WebInspectorUI:

Use SQLError instead of SQLException, this is what the script should really
use here since it is checking the code of an SQLError.

.eslintrc:
UserInterface/Models/DatabaseObject.js:

(WebInspector.DatabaseObject.prototype.executeSQL.queryCallback):
(WebInspector.DatabaseObject.prototype.executeSQL):
(WebInspector.DatabaseObject):

8:49 PM Changeset in webkit [219672] by mitz@apple.com

7 copies
1 add in releases/Apple/iOS 10.3.3

Added a tag for iOS 10.3.3.

8:49 PM Changeset in webkit [219671] by mitz@apple.com

8 copies
1 add in releases/Apple/Safari 10.1.2

Added a tag for Safari 10.1.2.

7:14 PM Changeset in webkit [219670] by Wenson Hsieh

2 edits in trunk/Source/WebCore

Unreviewed, tweak a comment above TemporarySelectionOptionIgnoreSelectionChanges in Editor.cpp.

The comment references the UI process, but it describes an entity in WebCore. This should have been generalized
to instead refer to the client layer in general (i.e. WebKit1 or WebKit2).

editing/Editor.h:

5:17 PM Changeset in webkit [219669] by Jonathan Bedard

4 edits in trunk/Tools

lint-test-expectations should be run during style checking
https://bugs.webkit.org/show_bug.cgi?id=173559
<rdar://problem/32854941>

Reviewed by Daniel Bates.

Follow up fix addressing style and a few minor bugs.

Scripts/webkitpy/layout_tests/models/test_expectations.py:

(TestExpectationParser.init): Use lambda x: x instead of str
(TestExpectationsModel.init): Make lambda x: x the default argument.
(TestExpectationsModel._already_seen_better_match): Use a temporary variable to
reduce the calls of _shorten_filename, fix minor bug in appending the current
expectation's line number instead of the previous ones, clarify treatment of None
in file-to-line-number mapping.
(TestExpectations._report_warnings): Collapse call.

Scripts/webkitpy/style/checkers/test_expectations.py:

(TestExpectationsChecker.lint_test_expectations):

Scripts/webkitpy/style/filereader.py: Re-write comment.

(TextFileReader.process_file): Add comment explaining treatment of None in
file-to-line-number mapping.
(TextFileReader.delete_file): Collapse call.

5:15 PM Changeset in webkit [219668] by Simon Fraser

28 edits
1 copy in trunk

getBoundingClientRects not updated for programmatic scrolls
https://bugs.webkit.org/show_bug.cgi?id=174538
rdar://problem/33049012

Reviewed by Tim Horton.
Source/WebCore:

Baidu.com has two event handlers on its <input>, and both query the input location with getBoundingClientRect()
and the current pageYOffset (via jQuery), then try to scroll the input to the top of the screen. The bug is that
programmatic scrolls did not immediately update the layout viewport rect, so the second call to
getBoundingClientRect() would return stale coordinates, triggering an extra scroll.

To fix this, undo the fix for r219320 which tried to keep getBoundingClientRect() current during unstable scroll
updates by adding a shadow layout viewport rect. Instead, almost always update the layout viewport rect on
FrameView, even during unstable visible rect updates, but not if content insets are being changed interactively,
since changing viewport heights cause problems with bottom-fixed elements. Also, we need to compute a new layout
viewport rect in FrameView::updateLayoutViewport() for programmatic scrolls.

However, always updating the layout viewport triggered issues with the scrolling tree. The scrolling state tree
fossilizes layer positions relative to a specific viewport rect, and that relationship has to be maintained.
There are code paths that recompute fixed/sticky viewport constraints when the layout viewport has changed but
we haven't done layout or recomputed layer positions (e.g. updating viewport-constrained layers via
updateScrollCoordinatedLayersAfterFlush()) and in these cases using a new layout viewport for those computations
results in an inconsistent scrolling tree.

Fix this by not updating scrolling constraints every time we have to re-register scrolling nodes.
updateScrollCoordinatedLayersAfterFlush() only needs to update the layer on the scrolling node (to handle
tiled/non-tiled switches), so make updateScrollCoordinatedLayer() a little more fine-grained, and only update
constraints when we've just computed layer geometry. This allows for different scrolling nodes to have
constraints computed at different times, with different layout viewports, which happens.

Two additional fixes were required to make bottom-fixed bars behave correctly.

First, FrameView::computeLayoutViewportOrigin() had a bug where rounding of half-pixel values would cause it to
fall into the if (visualViewport.height() > layoutViewport.height()) clause, but then fail to clamp for
rubber-banding.

Second, the FrameView::unscaledMaximumScrollPosition() was wrong after zooming on iOS, since it uses visibleSize()
which is affected by page scale on iOS only (and the function wants scale-independent values). Fix with a hack that
should be cleaned up via webkit.org/b/174648.

Tested by existing tests.

page/FrameView.cpp:

(WebCore::FrameView::computeUpdatedLayoutViewportRect):
(WebCore::FrameView::computeLayoutViewportOrigin):
(WebCore::FrameView::setLayoutViewportOverrideRect):
(WebCore::FrameView::updateLayoutViewport):
(WebCore::FrameView::unscaledMaximumScrollPosition):
(WebCore::FrameView::documentToClientOffset):
(WebCore::FrameView::setUnstableLayoutViewportRect): Deleted.

page/FrameView.h:
page/scrolling/AsyncScrollingCoordinator.cpp:

(WebCore::AsyncScrollingCoordinator::updateScrollPositionAfterAsyncScroll):
(WebCore::AsyncScrollingCoordinator::reconcileScrollingState):
(WebCore::AsyncScrollingCoordinator::reconcileViewportConstrainedLayerPositions):
(WebCore::AsyncScrollingCoordinator::updateNodeLayer):
(WebCore::AsyncScrollingCoordinator::updateNodeViewportConstraints):
(WebCore::AsyncScrollingCoordinator::updateViewportConstrainedNode): Deleted.

page/scrolling/AsyncScrollingCoordinator.h:
page/scrolling/ScrollingCoordinator.cpp:

(WebCore::operator<<):

page/scrolling/ScrollingCoordinator.h:

(WebCore::ScrollingCoordinator::reconcileScrollingState):
(WebCore::ScrollingCoordinator::updateNodeLayer):
(WebCore::ScrollingCoordinator::updateNodeViewportConstraints):
(WebCore::ScrollingCoordinator::updateViewportConstrainedNode): Deleted.

page/scrolling/ScrollingStateFixedNode.cpp:

(WebCore::ScrollingStateFixedNode::updateConstraints):

page/scrolling/ScrollingStateStickyNode.cpp:

(WebCore::ScrollingStateStickyNode::updateConstraints):
(WebCore::ScrollingStateStickyNode::reconcileLayerPositionForViewportRect):

page/scrolling/ScrollingTree.cpp:

(WebCore::ScrollingTree::commitTreeState):

page/scrolling/mac/ScrollingTreeFixedNode.mm:

(WebCore::ScrollingTreeFixedNode::updateLayersAfterAncestorChange):

page/scrolling/mac/ScrollingTreeStickyNode.mm:

(WebCore::ScrollingTreeStickyNode::updateLayersAfterAncestorChange):

rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::updateGeometry):

rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::updateScrollCoordinatedLayersAfterFlush):
(WebCore::RenderLayerCompositor::updateBacking):
(WebCore::RenderLayerCompositor::fixedRootBackgroundLayerChanged):
(WebCore::RenderLayerCompositor::requiresCompositingForPosition):
(WebCore::RenderLayerCompositor::updateScrollCoordinatedStatus):
(WebCore::RenderLayerCompositor::computeFixedViewportConstraints):
(WebCore::RenderLayerCompositor::computeStickyViewportConstraints):
(WebCore::RenderLayerCompositor::updateScrollCoordinatedLayer):
(WebCore::RenderLayerCompositor::didAddScrollingLayer):

rendering/RenderLayerCompositor.h:

Source/WebKit:

Feed ViewportRectStability and ScrollingLayerPositionAction into reconcileScrollingState().

WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::updateVisibleContentRects):

LayoutTests:

New results for these tests, reflecting the fact that programmatic scrolls now update
the layout viewport.

Clean up fast/dom/elementFromPoint-relative-to-viewport.html, and land an iOS expectation. The test
uses eventSender.zoomPageOut() which is not expected to work correctly on iOS. It works when tested
manually.

fast/dom/elementFromPoint-relative-to-viewport-expected.txt:
fast/dom/elementFromPoint-relative-to-viewport.html:
platform/ios-wk2/fast/dom/elementFromPoint-relative-to-viewport-expected.txt: Copied from LayoutTests/fast/dom/elementFromPoint-relative-to-viewport-expected.txt.
platform/ios-wk2/fast/visual-viewport/client-rects-relative-to-layout-viewport-expected.txt:
platform/ios-wk2/fast/visual-viewport/rtl-zoomed-rects-expected.txt:
platform/ios-wk2/fast/visual-viewport/zoomed-fixed-scroll-down-then-up-expected.txt:
platform/ios-wk2/fast/visual-viewport/zoomed-rects-expected.txt:
platform/ios/fast/visual-viewport/zoomed-fixed-expected.txt:
platform/ios/fast/visual-viewport/zoomed-fixed-header-and-footer-expected.txt:

4:59 PM Changeset in webkit [219667] by Chris Dumez

2 edits in trunk/Tools

Unreviewed attempt to fix API test failure after r219663.

The test was hard-coding an exception string and the string has changed slightly
in r219663.

TestWebKitAPI/Tests/WebKit2Cocoa/WebsiteDataStoreCustomPaths.mm:

(TEST):

4:57 PM Changeset in webkit [219666] by Megan Gardner

5 edits in trunk

Don't write file URLs to iOS Pasteboard
https://bugs.webkit.org/show_bug.cgi?id=174647
<rdar://problem/33199730>

Reviewed by Wenson Hsieh.

Source/WebCore:

Tests updated to reflect the changes. We are no longer vending file URLs in Drag & Drop and Copy/Paste.

editing/ios/EditorIOS.mm:

(WebCore::Editor::writeImageToPasteboard):

platform/ios/PlatformPasteboardIOS.mm:

(WebCore::PlatformPasteboard::write):

Tools:

Updating tests to reflect the lack of file URLs for images.

TestWebKitAPI/Tests/ios/DataInteractionTests.mm:

(checkTypeIdentifierAndIsNotOtherTypeIdentifier):
(checkEstimatedSize):
(TestWebKitAPI::TEST):

4:38 PM Changeset in webkit [219665] by mmaxfield@apple.com

4 edits
10 adds in trunk

Setting the minimum font size preference doesn’t affect absolute line-height values, so lines overlap
https://bugs.webkit.org/show_bug.cgi?id=174406
Source/WebCore:

Reviewed by Simon Fraser.
<rdar://problem/10139227>

Reviewed by NOBODY.

When the minimumFontSize API preference is set, we will increase the font size without increasing
the line height. If the content specifies line-height as an absolute value, there can be two
unfortunate results:

Adjacent lines in a paragraph can overlap
If the paragraph (or containin block or whatever) uses overflow: hidden, the first and last lines

can be cut off and potentially indecipherable.

Instead, we should use the minimum font size preference as a signal that we should increase the
line-height as well as the font-size. Eventually, we will want to increase it by an amount
proportional to the increase in font-size (which can be due to minimumFontSize, minimumLogicalFontSize,
text autosizing, etc.). However, because minimumLogicalFontSize is on by default, this would cause
a behavior change on many webpages which use small text, so such a change would be too risky right now.
Instead, we can pretend that minimumFontSize is the only cause that text increases, and use this as the
only signal to boost the corresponding line-height.

Tests: fast/text/line-height-minimumFontSize-text-zoom.html

fast/text/line-height-minimumFontSize-visual.html
fast/text/line-height-minimumFontSize-zoom.html
fast/text/line-height-minimumFontSize.html
fast/text/line-height-minimumFontSize-autosize.html

css/StyleBuilderCustom.h:

(WebCore::computeBaseSpecifiedFontSize):
(WebCore::computeLineHeightMultiplierDueToFontSize):
(WebCore::StyleBuilderCustom::applyValueLineHeight):
(WebCore::StyleBuilderCustom::applyValueFill):
(WebCore::StyleBuilderCustom::applyValueStroke):
(WebCore::StyleBuilderCustom::applyValueContent):

rendering/TextAutoSizing.cpp:

LayoutTests:

<rdar://problem/10139227>

Reviewed by Simon Fraser.

fast/text/line-height-minimumFontSize-autosize-expected.text: Added.
fast/text/line-height-minimumFontSize-autosize.html: Added.
fast/text/line-height-minimumFontSize-expected.txt: Added.
fast/text/line-height-minimumFontSize-text-zoom-expected.html: Added.
fast/text/line-height-minimumFontSize-text-zoom.html: Added.
fast/text/line-height-minimumFontSize-visual-expected.html: Added.
fast/text/line-height-minimumFontSize-visual.html: Added.
fast/text/line-height-minimumFontSize-zoom-expected.html: Added.
fast/text/line-height-minimumFontSize-zoom.html: Added.
fast/text/line-height-minimumFontSize.html: Added.

1:42 PM Changeset in webkit [219664] by beidson@apple.com

10 edits in trunk

iBooks sometimes crashes when closing a book.
<rdar://problem/31180331> and https://bugs.webkit.org/show_bug.cgi?id=174658

Reviewed by Oliver Hunt.

Source/WebKit:

LegacyCustomProtocolManagerProxy should not reference a WebProcessPool directly.
LegacyCustomProtocolManagerProxy should invalidate in its destructor.

UIProcess/Network/CustomProtocols/LegacyCustomProtocolManagerProxy.cpp:

(WebKit::LegacyCustomProtocolManagerProxy::LegacyCustomProtocolManagerProxy):
(WebKit::LegacyCustomProtocolManagerProxy::~LegacyCustomProtocolManagerProxy):
(WebKit::LegacyCustomProtocolManagerProxy::startLoading):
(WebKit::LegacyCustomProtocolManagerProxy::stopLoading):
(WebKit::LegacyCustomProtocolManagerProxy::invalidate):
(WebKit::LegacyCustomProtocolManagerProxy::wasRedirectedToRequest):
(WebKit::LegacyCustomProtocolManagerProxy::didReceiveResponse):
(WebKit::LegacyCustomProtocolManagerProxy::didLoadData):
(WebKit::LegacyCustomProtocolManagerProxy::didFailWithError):
(WebKit::LegacyCustomProtocolManagerProxy::didFinishLoading):
(WebKit::LegacyCustomProtocolManagerProxy::processDidClose): Deleted.

UIProcess/Network/CustomProtocols/LegacyCustomProtocolManagerProxy.h:

UIProcess/Network/NetworkProcessProxy.cpp:

(WebKit::NetworkProcessProxy::NetworkProcessProxy):
(WebKit::NetworkProcessProxy::didClose):

UIProcess/Network/NetworkProcessProxy.h:

(WebKit::NetworkProcessProxy::processPool):

Tools:

TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm:

(-[ProcessPoolDestroyedDuringLoadingProtocol startLoading]):
(-[ProcessPoolDestroyedDuringLoadingProtocol finishTheLoad]):
(-[ProcessPoolDestroyedDuringLoadingProtocol stopLoading]):
(TestWebKitAPI::TEST):

Add a "spin the runloop X number of times" utility:

TestWebKitAPI/Utilities.h:
TestWebKitAPI/cocoa/UtilitiesCocoa.mm:

(TestWebKitAPI::Util::spinRunLoop):

1:24 PM Changeset in webkit [219663] by Chris Dumez

537 edits in trunk

DOMException should not have its own toString()
https://bugs.webkit.org/show_bug.cgi?id=174630

Reviewed by Sam Weinig.

LayoutTests/imported/w3c:

Rebaseline existing tests now that more checks are passing.

web-platform-tests/WebIDL/ecmascript-binding/es-exceptions/DOMException-custom-bindings.any-expected.txt:
web-platform-tests/WebIDL/ecmascript-binding/es-exceptions/DOMException-custom-bindings.any.worker-expected.txt:

Source/WebCore:

DOMException should not have its own toString() and should use the one from Error.prototype.toString()
instead:

https://heycam.github.io/webidl/#idl-DOMException

No new tests, rebaselined existing tests.

dom/DOMCoreException.idl:

LayoutTests:

Rebaseline existing tests as the exception string is now slightly different.

1:13 PM Changeset in webkit [219662] by commit-queue@webkit.org

10 edits in trunk

[iOS] REGRESSION: Scrubbing media using built-in controls does not pause media
https://bugs.webkit.org/show_bug.cgi?id=174650
<rdar://problem/33401877>

Patch by Antoine Quint <Antoine Quint> on 2017-07-19
Reviewed by Dean Jackson.

Source/WebCore:

We would only pause when scrubbing on macOS because we only listened to "mousedown" events on the
scrubber's backing <input> element to identify that the user had started interacting with the
scrubber.

Implementing the same technique on iOS required a little more work than just listening to "touchstart"
events on the same element. On top of that, we needed to make sure that we would only respond to
"touchstart" events on the slider's thumb, and not on the track, since only on macOS should the user
be able to click anywhere on the track to scrub. So we turn off pointer-events for the <input> on iOS
only, and turn them back on specifically for the thumb.

There is also some finessing when dealing with touch events where we need to track the identifier of
the touch that started the user interaction. So we keep track of it in an ivar and wait until we get
a "touchend" event where the changedTouches list contains a touch with that same identifier to ensure
the same touch that initiates and ends the scrubbing interaction.

Finally, we fix another issue that was uncovered while turning back on the ScrubbingSupport tests
where we would not trash the cached _value ivar when we initiated scrubbing, which was important since
we would mistakenly use the pre-srubbing value during a scrub.

Modules/modern-media-controls/controls/slider.css:

(.ios .slider > input):
(.slider > input::-webkit-slider-thumb):

Modules/modern-media-controls/controls/slider.js:

(Slider.prototype.handleEvent):
(Slider.prototype._handleMousedownEvent):
(Slider.prototype._interactionEndTarget):
(Slider.prototype._handleTouchstartEvent):
(Slider.prototype._valueWillStartChanging):
(Slider.prototype._valueDidStopChanging):
(Slider.prototype._handleMouseupEvent):
(Slider.prototype._handleTouchendEvent):

LayoutTests:

Rebaseline and turn back on all the ScrubberSupport tests on macOS and iOS.

media/modern-media-controls/scrubber-support/ipad/scrubber-support-drag-expected.txt:
media/modern-media-controls/scrubber-support/ipad/scrubber-support-drag.html:
media/modern-media-controls/scrubber-support/scrubber-support-media-api-expected.txt:
media/modern-media-controls/scrubber-support/scrubber-support-media-api.html:
platform/ios-simulator/TestExpectations:
platform/mac/TestExpectations:

12:18 PM Changeset in webkit [219661] by n_wang@apple.com

3 edits
2 adds in trunk

AX: Web page reloaded when a node is labelling multiple childnodes
https://bugs.webkit.org/show_bug.cgi?id=174655

Reviewed by Chris Fleizach.

Source/WebCore:

When we are asking for the aria-labelledby attribute of a node and its
sibling is also labelled by the same node, we get into an infinite loop
in textUnderElement since we only ignore one child. Added checks for
siblings to avoid such loop.

Test: accessibility/mac/aria-labelledby-multiple-child-crash.html

accessibility/AccessibilityNodeObject.cpp:

(WebCore::AccessibilityNodeObject::textUnderElement):

LayoutTests:

accessibility/mac/aria-labelledby-multiple-child-crash-expected.txt: Added.
accessibility/mac/aria-labelledby-multiple-child-crash.html: Added.

11:16 AM Changeset in webkit [219660] by aestes@apple.com

2 edits in trunk/Source/WebCore

Use a cast to work around clang's false -Wobjc-literal-conversion warnings
https://bugs.webkit.org/show_bug.cgi?id=174631

Reviewed by Dan Bernstein.

Instead of ignoring -Wobjc-literal-conversion, use a cast to work around rdar://problem/33383354.

platform/ios/PlatformPasteboardIOS.mm:

(WebCore::PlatformPasteboard::write):

11:16 AM Changeset in webkit [219659] by Chris Dumez

15 edits in trunk

Make cross-origin properties enumerable
https://bugs.webkit.org/show_bug.cgi?id=174576

Reviewed by Darin Adler.

LayoutTests/imported/w3c:

Re-sync tests from upstream and rebaseline to improve test coverage.

web-platform-tests/html/browsers/origin/cross-origin-objects/cross-origin-objects-expected.txt:
web-platform-tests/html/browsers/origin/cross-origin-objects/cross-origin-objects.html:
web-platform-tests/html/browsers/the-window-object/window-indexed-properties-expected.txt:
web-platform-tests/html/browsers/the-window-object/window-indexed-properties.html:

Source/WebCore:

Makes cross-origin properties enumerable on Window and Location objects
as per:

https://github.com/whatwg/html/pull/2777

This simplifies our code quite a bit.

No new tests, updated existing tests.

bindings/js/JSDOMWindowCustom.cpp:

(WebCore::jsDOMWindowGetOwnPropertySlotRestrictedAccess):
(WebCore::JSDOMWindow::getOwnPropertySlotByIndex):
(WebCore::JSDOMWindow::getOwnPropertyNames):

bindings/js/JSLocationCustom.cpp:

(WebCore::getOwnPropertySlotCommon):
(WebCore::JSLocation::getOwnPropertyNames):

bindings/scripts/CodeGeneratorJS.pm:

(GenerateHeader):

LayoutTests:

Update / rebaseline some tests to reflect behavior change.

http/tests/security/cross-origin-descriptors-expected.txt:
http/tests/security/cross-origin-descriptors.html:
js/dom/getOwnPropertyDescriptor-expected.txt:
js/resources/getOwnPropertyDescriptor.js:

10:27 AM Changeset in webkit [219658] by clopez@igalia.com

2 edits in trunk/Source/WebCore

[EME] Build failure with Clang-3.8 on InitDataRegistry.cpp
https://bugs.webkit.org/show_bug.cgi?id=174628

Reviewed by Žan Doberšek.

Modules/encryptedmedia/InitDataRegistry.cpp:

(WebCore::extractKeyIDsKeyids): Add an explicit cast to unsigned.

10:09 AM Changeset in webkit [219657] by Jonathan Bedard

12 edits in trunk/Tools

lint-test-expectations should be run during style checking
https://bugs.webkit.org/show_bug.cgi?id=173559
<rdar://problem/32854941>

Reviewed by David Kilzer.

Running the test expectation linter requires reading both files and lines not in the
patch because, for example, deletion of a test can cause a lint failure even though
no test expectations where modified. This means that the linter will occasionally warn
about lines which were not changed in a given patch but whose error is related to a
change made in that patch.

Scripts/webkitpy/common/system/filesystem_mock.py:

(MockFileSystem.open_text_file_for_reading): Add 'errors' argument to mimic filesystem.

Scripts/webkitpy/layout_tests/models/test_expectations.py:

(TestExpectationWarning): Added class to pass warnings as an object instead of a string.
(TestExpectationWarning.init): Construct warning with file name, line number, line
content, description of the error and the name of the associated test.
(TestExpectationWarning.str): Convert to string so that existing printing code works.
(TestExpectationParser.init): Pass shorten_filename function to
TestExpectationsParser to add a deleted file to the related_files dictionary.
(TestExpectationParser._check_test_exists): If the test does not exist, add the
missing path to the related_files dictionary.
(TestExpectationLine.init): Add related_files dictionary, which tracks
files and line numbers related to this test expectation line. This will allow
tracking linter errors in the style checker occurring across multiple files.
(TestExpectationsModel._already_seen_better_match): Add redundant expectation
lines to related_files dictionary.
(TestExpectations.init): Pass self._shorten_filename to TestExpectationParser.
(TestExpectations._report_warnings): Construct warning object instead of string
when adding to warnings list.

Scripts/webkitpy/port/win.py: Changed logging level form warning to debug to

clean-up log.

Scripts/webkitpy/style/checker.py:

(ProcessorBase.do_association_check): Add required function for processor classes.
(StyleProcessor):
(StyleProcessor.do_association_check): Run the TestExpectations linter when
checking for errors between associated files.

Scripts/webkitpy/style/checkers/test_expectations.py:

(TestExpectationsChecker.check_test_expectations): Reflect changed import statements.
(TestExpectationsChecker):
(TestExpectationsChecker._should_log_linter_warning): Given a warning, a dictionary
of modified files, the current working directory and the host, determine if the linter
warning is associated with the changes.
(TestExpectationsChecker.lint_test_expectations): Lint test expectations for the
style checker.

Scripts/webkitpy/style/filereader.py:

(TextFileReader):
(TextFileReader.init): Track modified files in dictionary instead of a counter.
(TextFileReader.file_count): Use dictionary to determine the number of modified files.
(TextFileReader.process_file): Track both the number of files changed and which lines
in those files were changed.
(TextFileReader.do_association_check): Run the processor's association check on all
modified or deleted files processed by TextFileReader.
(TextFileReader.delete_file): Track deleted files in _files dictionary.
(TextFileReader.count_delete_only_file): Deleted.

Scripts/webkitpy/style/filereader_unittest.py:

(TextFileReaderTest.test_delete_file): Renamed function to reflect new function name.
(TextFileReaderTest.test_count_delete_only_file): Moved to test_delete_file.

Scripts/webkitpy/style/main.py:

(CheckWebKitStyle.main): When running the style checker on a specific list of files,
explicitly run the association check on the file reader.

Scripts/webkitpy/style/main_unittest.py:

(ExpectationLinterInStyleCheckerTest): Added to test the TestExpectationLinter now
embedded in the style checker.
(ExpectationLinterInStyleCheckerTest.setUp): Set up the style checker configuration.
(ExpectationLinterInStyleCheckerTest._generate_file_reader): Given a filesystem object,
construct the TextFileReader object with a StyleProcessor used to run style checks on
specific files.
(ExpectationLinterInStyleCheckerTest._generate_testing_host): Generate a host used for
testing the test expectation linter inside the style checker. This host must contain a
mock file system with the basic structure of test expectations.
(ExpectationLinterInStyleCheckerTest.test_no_linter_errors):
(ExpectationLinterInStyleCheckerTest.test_linter_duplicate_line):
(ExpectationLinterInStyleCheckerTest.test_linter_duplicate_line_no_edit):
(ExpectationLinterInStyleCheckerTest.test_linter_deleted_file):
(ExpectationLinterInStyleCheckerTest.test_linter_deleted_file_no_edit):

Scripts/webkitpy/style/patchreader.py:

(PatchReader.check): Specify which file was deleted, run the association check.

Scripts/webkitpy/style/patchreader_unittest.py:

(PatchReaderTest.MockTextFileReader.delete_file): Renamed count_delete_only_file.
(PatchReaderTest.MockTextFileReader.do_association_check): Added.
(PatchReaderTest.MockTextFileReader.count_delete_only_file): Renamed delete_file.

9:42 AM Changeset in webkit [219656] by Matt Lewis

4 edits
10 deletes in trunk

Unreviewed, rolling out r219646.

The test added are failing on all platforms

Reverted changeset:

"Setting the minimum font size preference doesn’t affect
absolute line-height values, so lines overlap"
https://bugs.webkit.org/show_bug.cgi?id=174406
http://trac.webkit.org/changeset/219646

7:10 AM Changeset in webkit [219655] by zandobersek@gmail.com

2 edits in trunk/LayoutTests

Unreviewed WPE gardening.

platform/wpe/TestExpectations:

Unskip a bunch of Web Crypto tests that are passing now that
the underlying implementation has progressed.

3:44 AM Changeset in webkit [219654] by Yusuke Suzuki

9 edits
1 delete in trunk/Source/WTF

[WTF] Remove unnecessary indirection of WTF::Thread entry point
https://bugs.webkit.org/show_bug.cgi?id=174291

Reviewed by Mark Lam.

Now wtfThreadEntryPoint is almost the same. Only the difference is function signature due to platform APIs.
We remove ThreadFunctionInvocation indirection in ThreadingPthread.cpp and ThreadingWin.cpp.

Also, ThreadFunctionInvocation keeps a RefPtr to the Thread object. This was previously needed to keep the
Thread object alive until the thread itself could install the ThreadHolder into its thread local storage.
The ThreadHolder has a Ref that keeps the Thread object alive for the lifetime of the thread. Since
Thread::create() now waits for the thread to be initialized before returning and Thread::create() hold a Ref
to the Thread object, we are guaranteed that the Thread object will be alive long enough for it to be installed
in the thread's ThreadHolder, and we no longer need ThreadFunctionInvocation.

And we also simplify ThreadHolder::initialize a bit. Now Thread::create waits for the completion of Thread
initialization. So, after establishing thread handle, we can call ThreadHolder::initialize before completing
Thread initialization.

Also we drop errno.h ifdefs in ThreadingWin.cpp. This is introduced to support WinCE. But now WinCE port is removed.

WTF.xcodeproj/project.pbxproj:
wtf/ThreadFunctionInvocation.h: Removed.
wtf/ThreadHolder.h:
wtf/ThreadHolderWin.cpp:

(WTF::ThreadHolder::initialize):

wtf/Threading.cpp:

(WTF::Thread::entryPoint):
(WTF::Thread::create):
(WTF::threadEntryPoint): Deleted.

wtf/Threading.h:
wtf/ThreadingPthreads.cpp:

(WTF::Thread::initializeCurrentThreadEvenIfNonWTFCreated):
(WTF::wtfThreadEntryPoint):
(WTF::Thread::establishHandle):
(WTF::Thread::initializeCurrentThreadInternal):
(WTF::Thread::current):
(WTF::Thread::establishPlatformSpecificHandle):
(WTF::Thread::createInternal): Deleted.
(WTF::Thread::establish): Deleted.

wtf/ThreadingWin.cpp:

(WTF::Thread::initializeCurrentThreadEvenIfNonWTFCreated):
(WTF::Thread::initializeCurrentThreadInternal):
(WTF::wtfThreadEntryPoint):
(WTF::Thread::establishHandle):
(WTF::Thread::current):
(WTF::Thread::establishPlatformSpecificHandle):
(WTF::Thread::createInternal): Deleted.
(WTF::Thread::establish): Deleted.

wtf/win/MainThreadWin.cpp:

(WTF::initializeMainThreadPlatform):

1:43 AM Changeset in webkit [219653] by Yusuke Suzuki

24 edits
2 copies
1 add in trunk

[WTF] Implement WTF::ThreadGroup
https://bugs.webkit.org/show_bug.cgi?id=174081

Reviewed by Mark Lam.

Source/JavaScriptCore:

Large part of MachineThreads are now removed and replaced with WTF::ThreadGroup.
And SamplingProfiler and others interact with WTF::Thread directly.

API/tests/ExecutionTimeLimitTest.cpp:
heap/MachineStackMarker.cpp:

(JSC::MachineThreads::MachineThreads):
(JSC::captureStack):
(JSC::MachineThreads::tryCopyOtherThreadStack):
(JSC::MachineThreads::tryCopyOtherThreadStacks):
(JSC::MachineThreads::gatherConservativeRoots):
(JSC::ActiveMachineThreadsManager::Locker::Locker): Deleted.
(JSC::ActiveMachineThreadsManager::add): Deleted.
(JSC::ActiveMachineThreadsManager::remove): Deleted.
(JSC::ActiveMachineThreadsManager::contains): Deleted.
(JSC::ActiveMachineThreadsManager::ActiveMachineThreadsManager): Deleted.
(JSC::activeMachineThreadsManager): Deleted.
(JSC::MachineThreads::~MachineThreads): Deleted.
(JSC::MachineThreads::addCurrentThread): Deleted.
(): Deleted.
(JSC::MachineThreads::removeThread): Deleted.
(JSC::MachineThreads::removeThreadIfFound): Deleted.
(JSC::MachineThreads::MachineThread::MachineThread): Deleted.
(JSC::MachineThreads::MachineThread::getRegisters): Deleted.
(JSC::MachineThreads::MachineThread::Registers::stackPointer): Deleted.
(JSC::MachineThreads::MachineThread::Registers::framePointer): Deleted.
(JSC::MachineThreads::MachineThread::Registers::instructionPointer): Deleted.
(JSC::MachineThreads::MachineThread::Registers::llintPC): Deleted.
(JSC::MachineThreads::MachineThread::captureStack): Deleted.

heap/MachineStackMarker.h:

(JSC::MachineThreads::addCurrentThread):
(JSC::MachineThreads::getLock):
(JSC::MachineThreads::threads):
(JSC::MachineThreads::MachineThread::suspend): Deleted.
(JSC::MachineThreads::MachineThread::resume): Deleted.
(JSC::MachineThreads::MachineThread::threadID): Deleted.
(JSC::MachineThreads::MachineThread::stackBase): Deleted.
(JSC::MachineThreads::MachineThread::stackEnd): Deleted.
(JSC::MachineThreads::threadsListHead): Deleted.

runtime/SamplingProfiler.cpp:

(JSC::FrameWalker::isValidFramePointer):
(JSC::SamplingProfiler::SamplingProfiler):
(JSC::SamplingProfiler::takeSample):
(JSC::SamplingProfiler::noticeCurrentThreadAsJSCExecutionThread):

runtime/SamplingProfiler.h:
wasm/WasmMachineThreads.cpp:

(JSC::Wasm::resetInstructionCacheOnAllThreads):

Source/WebCore:

page/ResourceUsageThread.h:

Source/WebKit:

Shared/AsyncRequest.h:

Source/WTF:

This patch implements WTF::ThreadGroup. It implements core of JSC::MachineThreads with more reliable way.
JSC::MachineThreads was complicated because of managing dead threads. Each JSC::MachineThreads has its
own TLS with a registered destructor. And everytime a thread dies, the registered TLS destructor is called.
And this destructor will remove the current dying thread from JSC::MachineThreads.

However the above implementation is tricky. And each JSC::MachineThreads requires own TLS space, which is
not considered in WTF's Windows ThreadSpecific implementation. Current design works well since we only
have small number of MachineThreads right now.

Instead, we use more reliable way. After introducing WTF::Thread, WTF::Thread has WTF::Thread::didExit,
which is called when associated TLS (with WTF::Thread) is destroyed. We leverage this mechanism to remove
WTF::Thread from MachineThreads.

This patch introduces WTF::ThreadGroup. It is tightly integrated with WTF::Thread: WTF::Thread knows
ThreadGroups which includes this thread. And WTF::ThreadGroup of course knows WTF::Threads added to it.
WTF::Thread::didExit carefully remove itself from WTF::ThreadGroups.

The most important part of this patch is locking. WTF::Thread can die. And WTF::ThreadGroup can die.
If we take a design using two fine grain locks in WTF::Thread and WTF::ThreadGroup, we easily encounter
dead lock. Consider the following case.

When adding WTF::Thread (TH) to WTF::ThreadGroup (THG), we first hold a lock of THG, and hold a lock of TH (locking order is THG -> TH).
When TH dies, TH need to hold a lock of TH to iterate THGs. And we hold a lock of THG to unregister TH from it (locking order is TH -> THG).
When suspending and resuming THs in THG, we first hold a lock of THG. And then, we hold a lock of TH to suspend and resume it (locking order is THG -> TH).
When destroying THG, we need to hold a lock of TH to unregister THG from TH. We can hold a lock of THG before that (locking order is THG -> TH).

Then, it easily causes dead lock. We cannot swap the locking order of (2) since iterating THG requires a lock of TH.
To solve this problem, we use std::shared_ptr and std::weak_ptr.

When adding WTF::Thread (TH) to WTF::ThreadGroup (THG), we first hold THG, and hold a lock of TH. (THG -> TH)
When TH dies, TH first hold lock of TH. And we use std::weak_ptr<>::lock() to retain non-destructed ThreadGroups.

If some of ThreadGroups are dying, we just ignore them. It is ok because such a ThreadGroup will be destructed. So we do not need to unregister this thread from
such a ThreadGroup. Then, we have Vector<std::shared_ptr<ThreadGroup>>. So we unlock a lock of TH. To unregister a thread from thread group, we first hold a
lock of THG and then hold a lock of TH. Both lifetime is ensured: THG is retained by std::shared_ptr. And TH is itself. (TH), (THG -> TH).

When suspending and resuming THs in THG, we first hold a lock of THG. And then, we hold a lock of TH to suspend and resume it (THG -> TH).
When destroying THG, we hold a lock of THG. And hold a lock of TH. During holding THG's lock, registered thread never dies because (2) holds THG lock. (THG -> TH).

We also fix suspend and resume locking mechanism to avoid dead lock. We should hold the global lock when suspending and resuming.
If we use per-thread lock, the suspended thread can hold the lock of the other threads. It causes dead lock.

WTF.xcodeproj/project.pbxproj:
wtf/AutomaticThread.cpp:
wtf/CMakeLists.txt:
wtf/CrossThreadCopier.h:
wtf/ParkingLot.h:
wtf/ThreadGroup.cpp: Copied from Source/JavaScriptCore/wasm/WasmMachineThreads.cpp.

(WTF::ThreadGroup::~ThreadGroup):
(WTF::ThreadGroup::add):
(WTF::ThreadGroup::addCurrentThread):

wtf/ThreadGroup.h: Copied from Source/JavaScriptCore/wasm/WasmMachineThreads.cpp.

(WTF::ThreadGroup::create):
(WTF::ThreadGroup::threads):
(WTF::ThreadGroup::getLock):
(WTF::ThreadGroup::weakFromThis):

wtf/Threading.cpp:

(WTF::shouldRemoveThreadFromThreadGroup):
(WTF::Thread::didExit):
(WTF::Thread::addToThreadGroup):
(WTF::Thread::removeFromThreadGroup):

wtf/Threading.h:
wtf/ThreadingPthreads.cpp:

(WTF::Thread::resume):
(WTF::Thread::getRegisters):

wtf/ThreadingWin.cpp:

(WTF::Thread::resume):
(WTF::Thread::getRegisters):

Tools:

Add WTF::ThreadGroup tests.

TestWebKitAPI/CMakeLists.txt:
TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
TestWebKitAPI/Tests/WTF/ThreadGroup.cpp: Added.

(TestWebKitAPI::testThreadGroup):
(TestWebKitAPI::TEST):

Jul 18, 2017:

11:11 PM Changeset in webkit [219652] by Carlos Garcia Campos

7 edits in trunk/Source

WebDriver: handle invalid selector errors
https://bugs.webkit.org/show_bug.cgi?id=174619

Reviewed by Brian Burg.

Source/WebDriver:

Add InvalidSelector error and handle it in case of protocol server error.

CommandResult.cpp:

(WebDriver::CommandResult::CommandResult):
(WebDriver::CommandResult::httpStatusCode):
(WebDriver::CommandResult::errorString):

CommandResult.h:

Source/WebKit:

We are currently handling only XPathException and only when it's an invalid expression. In the xpath case, the
spec also says "If any item in result is not an element return an error with error code invalid selector.", so
we should also handle TYPE_ERR (The expression could not be converted to return the specified type.). However,
since the spec says "or other error", I think we can simplify this and simply throw InvalidSelector inside the
catch, without checking any specific error. This is causing 14 failures in selenium tests.

§12. Element Retrieval. Step 6: If a DOMException, SyntaxError, XPathException, or other error occurs during the
execution of the element location strategy, return error invalid selector.
https://www.w3.org/TR/webdriver/#dfn-find

UIProcess/Automation/Automation.json: Add InvalidSelector error.
UIProcess/Automation/atoms/FindNodes.js:

(tryToFindNode): Raise InvalidSelector in case of error.

WebProcess/Automation/WebAutomationSessionProxy.cpp:

(WebKit::WebAutomationSessionProxy::evaluateJavaScriptFunction): Handle InvalidSelector exceptions.

11:10 PM Changeset in webkit [219651] by Carlos Garcia Campos

2 edits in trunk/Source/WebKit

Web Automation: error details not passed to DidEvaluateJavaScriptFunction message when callback was not called before page unload
https://bugs.webkit.org/show_bug.cgi?id=174624

Reviewed by Brian Burg.

There's a variable errorMessage, but it's unused.

WebProcess/Automation/WebAutomationSessionProxy.cpp:

(WebKit::WebAutomationSessionProxy::didClearWindowObjectForFrame): Pass errorMessage instead of String() to DidEvaluateJavaScriptFunction.

11:08 PM Changeset in webkit [219650] by Carlos Garcia Campos

2 edits in trunk/Source/WebKit

Web Automation: evaluateJavaScriptFunction should always notify the web process before returning early
https://bugs.webkit.org/show_bug.cgi?id=174623

Reviewed by Brian Burg.

It currently returns early if page, frame or scriptObject are nullptr, in which cases the UI process is not
notified. This causes test testShouldNotBeAbleToDoAnythingTheFrameIsDeletedFromUnderUs to hang, because message
DidEvaluateJavaScriptFunction is never sent when the given frame no longer exists. We should send
DidEvaluateJavaScriptFunction with WindowNotFound in case of page is nullptr and FrameNotFound if the frame is
nullptr. The scriptObject early return is actually wrong, because scriptObjectForFrame creates a new script if
there's isn't one for the given frame.

WebProcess/Automation/WebAutomationSessionProxy.cpp:

(WebKit::WebAutomationSessionProxy::evaluateJavaScriptFunction):

11:07 PM Changeset in webkit [219649] by Carlos Garcia Campos

3 edits in trunk/Source/WebKit

Web Automation: pending evaluate script callbacks are stored with the wrong frame ID when using the default main frame
https://bugs.webkit.org/show_bug.cgi?id=174622

Reviewed by Brian Burg.

The frameHandle argument is optional in evaluateJavaScriptFunction(), when not provided we pass 0 to the web
process. The proxy gets the web page main frame when received frame ID is 0, but the given frameID is
still used as key of m_webFramePendingEvaluateJavaScriptCallbacksMap and also passed to the javascript function
as argument. I think r203442 was actually a workaround to this bug, making it even more hidden. Both
m_webFrameScriptObjectMap and m_webFramePendingEvaluateJavaScriptCallbacksMap should never have 0 as a
key, since they always use a frame ID, and the frame identifier counter starts at 1. This is causing test
testShouldDetectPageLoadsWhileWaitingOnAnAsyncScriptAndReturnAnError to hang, because when the page is unloaded
and didClearWindowObjectForFrame is called, we try to get the pending callbacks of frame 1, but they were stored
as frame 0 so DidEvaluateJavaScriptFunction message is never sent to the UI process.

WebProcess/Automation/WebAutomationSessionProxy.cpp:

(WebKit::WebAutomationSessionProxy::evaluateJavaScriptFunction): Use always the actual frameID from the WebFrame
we are using.

WebProcess/Automation/WebAutomationSessionProxy.h: Do not allow 0 as a key of

m_webFramePendingEvaluateJavaScriptCallbacksMap and m_webFrameScriptObjectMap.

10:47 PM Changeset in webkit [219648] by aestes@apple.com

36 edits in trunk

[Xcode] Enable CLANG_WARN_RANGE_LOOP_ANALYSIS
https://bugs.webkit.org/show_bug.cgi?id=174631

Reviewed by Tim Horton.

Source/bmalloc:

Configurations/Base.xcconfig:

Source/JavaScriptCore:

Configurations/Base.xcconfig:
b3/B3FoldPathConstants.cpp:
b3/B3LowerMacros.cpp:
b3/air/AirAllocateRegistersByGraphColoring.cpp:
dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::check):
(JSC::DFG::ByteCodeParser::planLoad):

Source/ThirdParty/ANGLE:

Configurations/Base.xcconfig:

Source/WebCore:

Configurations/Base.xcconfig:
rendering/Grid.cpp:

(WebCore::Grid::insert):

rendering/RenderTreeAsText.cpp:

(WebCore::write):

rendering/SimpleLineLayoutCoverage.cpp:

(WebCore::SimpleLineLayout::printSimpleLineLayoutCoverage):

Source/WebCore/PAL:

Configurations/Base.xcconfig:

Source/WebInspectorUI:

Configurations/Base.xcconfig:

Source/WebKit:

Configurations/Base.xcconfig:
Shared/API/APIArray.cpp:

(API::Array::toStringVector):

UIProcess/Plugins/PlugInAutoStartProvider.cpp:

(WebKit::PlugInAutoStartProvider::setAutoStartOriginsArray):

UIProcess/UserContent/WebUserContentControllerProxy.cpp:

(WebKit::WebUserContentControllerProxy::addProcess):
(WebKit::WebUserContentControllerProxy::removeAllUserScripts):
(WebKit::WebUserContentControllerProxy::removeAllUserStyleSheets):

UIProcess/ios/forms/WKFileUploadPanel.mm:

(-[WKFileUploadPanel presentWithParameters:resultListener:]):

WebProcess/InjectedBundle/InjectedBundlePageEditorClient.cpp:

(WebKit::InjectedBundlePageEditorClient::getPasteboardDataForRange):

Source/WebKitLegacy/mac:

Configurations/Base.xcconfig:

Source/WTF:

Configurations/Base.xcconfig:

Tools:

DumpRenderTree/mac/Configurations/Base.xcconfig:
MiniBrowser/Configurations/Base.xcconfig:
MobileMiniBrowser/Configurations/Base.xcconfig:
TestWebKitAPI/Configurations/Base.xcconfig:
WebKitTestRunner/Configurations/Base.xcconfig:

9:53 PM Changeset in webkit [219647] by Yusuke Suzuki

14 edits in trunk/Source

WTF::Thread should have the threads stack bounds.
https://bugs.webkit.org/show_bug.cgi?id=173975

Reviewed by Mark Lam.

Source/JavaScriptCore:

There is a site in JSC that try to walk another thread's stack.
Currently, stack bounds are stored in WTFThreadData which is located
in TLS. Thus, only the thread itself can access its own WTFThreadData.
We workaround this situation by holding StackBounds in MachineThread in JSC,
but StackBounds should be put in WTF::Thread instead.

This patch adds StackBounds to WTF::Thread. StackBounds information is tightly
coupled with Thread. Thus putting it in WTF::Thread is natural choice.

heap/MachineStackMarker.cpp:

(JSC::MachineThreads::MachineThread::MachineThread):
(JSC::MachineThreads::MachineThread::captureStack):

heap/MachineStackMarker.h:

(JSC::MachineThreads::MachineThread::stackBase):
(JSC::MachineThreads::MachineThread::stackEnd):

runtime/VMTraps.cpp:

Source/WebCore:

When creating WebThread, we first allocate WebCore::ThreadGlobalData in UI thread
and share it with WebThread.
The problem is that WebCore::ThreadGlobalData has CachedResourceRequestInitiators.
It allocates AtomicString, which requires WTFThreadData.

In this patch, we call WTF::initializeThreading() before allocating WebCore::ThreadGlobalData.
And we also call AtomicString::init() before calling WebCore::ThreadGlobalData since
WebCore::ThreadGlobalData allocates AtomicString.

platform/ios/wak/WebCoreThread.mm:

(StartWebThread):

Source/WTF:

We move StackBounds from WTFThreadData to WTF::Thread.
One important thing is that we should make valid StackBounds
visible to Thread::create() caller. When the caller get
WTF::Thread from Thread::create(), this WTF::Thread should
have a valid StackBounds. But StackBounds information can be
retrived only in the WTF::Thread's thread itself.

We also clean up WTF::initializeThreading. StringImpl::empty()
is now statically initialized by using constexpr constructor.
Thus we do not need to call StringImpl::empty() explicitly here.
And WTF::initializeThreading() does not have any main thread
affinity right now in all the platforms. So we fix the comment
in Threading.h. Then, now, WTF::initializeThreading() is called
in UI thread when using Web thread in iOS.

wtf/StackBounds.h:

(WTF::StackBounds::emptyBounds):
(WTF::StackBounds::StackBounds):

wtf/Threading.cpp:

(WTF::threadEntryPoint):
(WTF::Thread::create):
(WTF::Thread::currentMayBeNull):
(WTF::Thread::initialize):
(WTF::initializeThreading):

wtf/Threading.h:

(WTF::Thread::stack):

wtf/ThreadingPthreads.cpp:

(WTF::Thread::initializeCurrentThreadEvenIfNonWTFCreated):
(WTF::Thread::current):
(WTF::initializeCurrentThreadEvenIfNonWTFCreated): Deleted.
(WTF::Thread::currentMayBeNull): Deleted.

wtf/ThreadingWin.cpp:

(WTF::Thread::initializeCurrentThreadEvenIfNonWTFCreated):
(WTF::Thread::initializeCurrentThreadInternal):
(WTF::Thread::current):

wtf/WTFThreadData.cpp:

(WTF::WTFThreadData::WTFThreadData):

wtf/WTFThreadData.h:

(WTF::WTFThreadData::stack):

8:54 PM Changeset in webkit [219646] by mmaxfield@apple.com

4 edits
10 adds in trunk

Setting the minimum font size preference doesn’t affect absolute line-height values, so lines overlap
https://bugs.webkit.org/show_bug.cgi?id=174406
<rdar://problem/10139227>

Reviewed by Simon Fraser.

Source/WebCore:

Adjacent lines in a paragraph can overlap
If the paragraph (or containin block or whatever) uses overflow: hidden, the first and last lines

can be cut off and potentially indecipherable.

Tests: fast/text/line-height-minimumFontSize-text-zoom.html

fast/text/line-height-minimumFontSize-visual.html
fast/text/line-height-minimumFontSize-zoom.html
fast/text/line-height-minimumFontSize.html
fast/text/line-height-minimumFontSize-autosize.html

css/StyleBuilderCustom.h:

rendering/TextAutoSizing.cpp:

LayoutTests:

fast/text/line-height-minimumFontSize-autosize-expected.text: Added.
fast/text/line-height-minimumFontSize-autosize.html: Added.
fast/text/line-height-minimumFontSize-expected.txt: Added.
fast/text/line-height-minimumFontSize-text-zoom-expected.html: Added.
fast/text/line-height-minimumFontSize-text-zoom.html: Added.
fast/text/line-height-minimumFontSize-visual-expected.html: Added.
fast/text/line-height-minimumFontSize-visual.html: Added.
fast/text/line-height-minimumFontSize-zoom-expected.html: Added.
fast/text/line-height-minimumFontSize-zoom.html: Added.
fast/text/line-height-minimumFontSize.html: Added.

6:13 PM Changeset in webkit [219645] by Alan Bujtas

2 edits in trunk/Source/WebCore

Media controls are missing content in fullscreen when document has scroll offset.
https://bugs.webkit.org/show_bug.cgi?id=174644
<rdar://problem/32415323>

Reviewed by Simon Fraser.

If a non-user initiated scrolling (result of resize for example) is processed asynchronously, it might
leapfrog other, programatic scrollings and trigger unintentional scroll offsets (and turn into unwanted clippings).
This patch ensures that both resize and top content inset change are translated into programatic scrolling.

Unable to test full screen video.

page/FrameView.cpp:

(WebCore::FrameView::setFrameRect):
(WebCore::FrameView::topContentInsetDidChange):

6:05 PM Changeset in webkit [219644] by aestes@apple.com

27 edits in trunk

[Xcode] Enable CLANG_WARN_OBJC_LITERAL_CONVERSION
https://bugs.webkit.org/show_bug.cgi?id=174631

Reviewed by Sam Weinig.

Source/bmalloc:

Configurations/Base.xcconfig:

Source/JavaScriptCore:

Configurations/Base.xcconfig:

Source/ThirdParty/ANGLE:

Configurations/Base.xcconfig:

Source/ThirdParty/libwebrtc:

Configurations/Base.xcconfig:

Source/WebCore:

Configurations/Base.xcconfig:
platform/ios/PlatformPasteboardIOS.mm:

(WebCore::PlatformPasteboard::write):

Source/WebCore/PAL:

Configurations/Base.xcconfig:

Source/WebInspectorUI:

Configurations/Base.xcconfig:

Source/WebKit:

Configurations/Base.xcconfig:

Source/WebKitLegacy/mac:

Configurations/Base.xcconfig:

Source/WTF:

Configurations/Base.xcconfig:

Tools:

DumpRenderTree/mac/Configurations/Base.xcconfig:
MiniBrowser/Configurations/Base.xcconfig:
MobileMiniBrowser/Configurations/Base.xcconfig:
TestWebKitAPI/Configurations/Base.xcconfig:
WebKitTestRunner/Configurations/Base.xcconfig:

5:33 PM Changeset in webkit [219643] by rniwa@webkit.org

2 edits in trunk/Websites/browserbench.org

Merge r219640 into Speedometer 1.0.

Speedometer/resources/benchmark-runner.js:

(BenchmarkRunner.prototype._writeMark):
(BenchmarkRunner.prototype._runTest):
(BenchmarkRunner.prototype._runTestAndRecordResults):

4:54 PM Changeset in webkit [219642] by commit-queue@webkit.org

4 edits
2 adds in trunk

Align quirky number parsing with other browsers
https://bugs.webkit.org/show_bug.cgi?id=155874

Patch by Ali Juma <ajuma@chromium.org> on 2017-07-18
Reviewed by Simon Fraser.

Source/WebCore:

Parse unit-less non-zero values for animation-duration and transition-duration
as invalid time values in quirks mode.

Test: fast/css/animation-transition-duration-quirksmode.html

css/parser/CSSPropertyParser.cpp:

(WebCore::consumeAnimationValue):

LayoutTests:

animations/animation-add-events-in-handler.html:
fast/css/animation-transition-duration-quirksmode-expected.txt: Added.
fast/css/animation-transition-duration-quirksmode.html: Added.

4:32 PM Changeset in webkit [219641] by Chris Dumez

2 edits in trunk/Source/WebCore

HysteresisActivity cannot be used in the UIProcess
https://bugs.webkit.org/show_bug.cgi?id=174643
<rdar://problem/33086442>

Reviewed by Tim Horton.

Port HysteresisActivity to RunLoop::Timer so that it can safely be used in
the UIProcess as well.

platform/HysteresisActivity.h:

4:22 PM Changeset in webkit [219640] by commit-queue@webkit.org

2 edits in trunk/PerformanceTests

Add performance.mark()s around each test step
https://bugs.webkit.org/show_bug.cgi?id=174530

Patch by Matt Kotsenas <mattkot@microsoft.com> on 2017-07-18
Reviewed by Ryosuke Niwa.

Add performance.mark() around each test step to make analysis
simpler. Now each test step can be investigated via dev tools, ETW, etc.

Speedometer/resources/benchmark-runner.js:

(BenchmarkRunner.prototype._writeMark):
(BenchmarkRunner.prototype._runTest):
(BenchmarkRunner.prototype._runTestAndRecordResults):

4:19 PM Changeset in webkit [219639] by Joseph Pecoraro

8 edits in trunk

Web Inspector: Modernize InjectedScriptSource
https://bugs.webkit.org/show_bug.cgi?id=173890

Reviewed by Brian Burg.

Source/JavaScriptCore:

inspector/InjectedScript.h:

Reorder functions to be slightly better.

inspector/InjectedScriptSource.js:
Convert to classes named InjectedScript and RemoteObject
Align InjectedScript's API with the wrapper C++ interfaces
Move some code to RemoteObject where appropriate (subtype, describe)
Move some code to helper functions (isPrimitiveValue, isDefined)
Refactor for readability and modern features
Remove some unused / unnecessary code

Source/WebCore:

Covered by existing tests.

inspector/CommandLineAPIModuleSource.js:

(CommandLineAPIImpl.prototype.copy):
(CommandLineAPIImpl.prototype._inspect):
Use RemoteObject, a new parameter.

LayoutTests:

inspector/model/remote-object-expected.txt:
inspector/model/stack-trace-expected.txt:

Now that we use classes, implicitly strict mode, the call frame
for evaluate gets tail call eliminated.

4:08 PM Changeset in webkit [219638] by rniwa@webkit.org

3 edits
2 adds in trunk

REGRESSION(r218910): Crash when password field changes to text field
https://bugs.webkit.org/show_bug.cgi?id=174560

Reviewed by Zalan Bujtas.

Source/WebCore:

The crash was caused by textMarkerDataForFirstPositionInTextControl accessing a nullptr returned by getOrCreate.
Unfortunately, in order to this fix bug while preserving the exact behavior would require synchronously creating
a renderer for the editing host when the input type changed since we can't create an accessbility object out of
a renderer-less node.

Instead, revert back to pre-r218910 behavior of always using the text control element's axID when notifying
the value change. While this is inconsistent with the way editing commands report content changes, I've since
learned that VoiceOver has code to deal with this exact situation.

Test: accessibility/mac/input-type-change-crash-2.html

accessibility/AXObjectCache.cpp:

(WebCore::AXObjectCache::textMarkerDataForFirstPositionInTextControl):

LayoutTests:

Added a regression test based on the test case provided by Daniel Bates.

accessibility/mac/input-type-change-crash-2-expected.txt: Added.
accessibility/mac/input-type-change-crash-2.html: Added.

3:54 PM Changeset in webkit [219637] by dbates@webkit.org

2 edits in trunk/Tools

lldb: Add type summary for StringView
https://bugs.webkit.org/show_bug.cgi?id=174637

Reviewed by Sam Weinig.

For debugging convenience, adds a pretty-print type summary for StringView. Evaluating a
StringView object will print output that has the form:

(WTF::StringView) $4 = { length = 2, contents = 'li' } {

m_characters = 0x000000011b57abb5 "eeeeeefjh0n"
m_length = 2
m_is8Bit = true
m_underlyingString = 0x0000614000000a90

}

lldb/lldb_webkit.py:

(lldb_init_module): Use WTFStringView_SummaryProvider to format StringView types.
(WTFStringView_SummaryProvider):
(WTFStringViewProvider):
(WTFStringViewProvider.init):
(WTFStringViewProvider.is_8bit): Access field StringView.m_is8Bit.
(WTFStringViewProvider.get_length): Access field StringView.m_length.
(WTFStringViewProvider.get_characters): Access field StringView.m_characters.
(WTFStringViewProvider.to_string): Returns the string represented by the StringView.

3:40 PM Changeset in webkit [219636] by mark.lam@apple.com

5 edits in trunk/Source/JavaScriptCore

Butterfly storage need not be initialized for indexing type Undecided.
https://bugs.webkit.org/show_bug.cgi?id=174516

Reviewed by Saam Barati.

While it's not incorrect to initialize the butterfly storage when the
indexingType is Undecided, it is inefficient as we'll end up initializing
it again later when we convert the storage to a different indexingType.
Some of our code already skips initializing Undecided butterflies.
This patch makes it the consistent behavior everywhere.

dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::emitAllocateRawObject):

runtime/JSArray.cpp:

(JSC::JSArray::tryCreateUninitializedRestricted):

runtime/JSArray.h:

(JSC::JSArray::tryCreate):

runtime/JSObject.cpp:

(JSC::JSObject::ensureLengthSlow):

3:28 PM Changeset in webkit [219635] by BJ Burg

3 edits in trunk/Source/WebInspectorUI

Web Inspector: adjust wording of "clear when page {navigates -> loads}"
https://bugs.webkit.org/show_bug.cgi?id=174589
<rdar://problem/32797981>

Reviewed by Joseph Pecoraro.

Localizations/en.lproj/localizedStrings.js:
UserInterface/Views/SettingsTabContentView.js:

(WebInspector.SettingsTabContentView.prototype._createGeneralSettingsView):

3:24 PM Changeset in webkit [219634] by Matt Baker

11 edits
2 adds in trunk

Web Inspector: Refactoring: replace InspectorCanvasAgent::CanvasEntry with a helper class
https://bugs.webkit.org/show_bug.cgi?id=174311

Reviewed by Devin Rousso.

Source/WebCore:

This patch adds a helper class for tracking canvases and their data. The
current approach of defining a helper structure in the agent's header is
awkward to use and maintain, and won't scale well as more canvas instrumentation
points and data are added.

CMakeLists.txt:
WebCore.xcodeproj/project.pbxproj:

New file.

inspector/InspectorCanvas.cpp: Added.

(WebCore::InspectorCanvas::create):
(WebCore::InspectorCanvas::InspectorCanvas):
(WebCore::InspectorCanvas::buildObjectForCanvas):

inspector/InspectorCanvas.h: Added.

inspector/InspectorCanvasAgent.cpp:

(WebCore::InspectorCanvasAgent::InspectorCanvasAgent):
(WebCore::InspectorCanvasAgent::enable):
(WebCore::InspectorCanvasAgent::requestNode):
(WebCore::InspectorCanvasAgent::requestContent):
(WebCore::InspectorCanvasAgent::requestCSSCanvasClientNodes):
(WebCore::InspectorCanvasAgent::resolveCanvasContext):
(WebCore::InspectorCanvasAgent::frameNavigated):
(WebCore::InspectorCanvasAgent::didCreateCSSCanvas):
(WebCore::InspectorCanvasAgent::didChangeCSSCanvasClientNodes):
(WebCore::InspectorCanvasAgent::didCreateCanvasRenderingContext):
(WebCore::InspectorCanvasAgent::didChangeCanvasMemory):
(WebCore::InspectorCanvasAgent::canvasDestroyed):
(WebCore::InspectorCanvasAgent::canvasDestroyedTimerFired):
(WebCore::InspectorCanvasAgent::clearCanvasData):
(WebCore::InspectorCanvasAgent::unbindCanvas):
(WebCore::InspectorCanvasAgent::assertInspectorCanvas):
(WebCore::InspectorCanvasAgent::findInspectorCanvas):
(WebCore::InspectorCanvasAgent::getCanvasEntry): Deleted.
(WebCore::InspectorCanvasAgent::buildObjectForCanvas): Deleted.

inspector/InspectorCanvasAgent.h:

inspector/InspectorController.cpp:

(WebCore::InspectorController::InspectorController):
Remove unused constructor argument.

LayoutTests:

Updated test expectations for new error strings.

inspector/canvas/css-canvas-clients-expected.txt:
inspector/canvas/requestContent-2d-expected.txt:
inspector/canvas/requestNode-expected.txt:
inspector/canvas/resolveCanvasContext-2d-expected.txt:

3:07 PM Changeset in webkit [219633] by sbarati@apple.com

4 edits in trunk/Source/JavaScriptCore

AirLowerAfterRegAlloc may incorrectly use a callee save that's live as a scratch register
https://bugs.webkit.org/show_bug.cgi?id=174515
<rdar://problem/33358092>

Reviewed by Filip Pizlo.

AirLowerAfterRegAlloc was computing the set of available scratch
registers incorrectly. It was always excluding callee save registers
from the set of live registers. It did not guarantee that live callee save
registers were not in the set of scratch registers that could
get clobbered. That's incorrect as the shuffling code is free
to overwrite whatever is in the scratch register it gets passed.

b3/air/AirLowerAfterRegAlloc.cpp:

(JSC::B3::Air::lowerAfterRegAlloc):

b3/testb3.cpp:

(JSC::B3::functionNineArgs):
(JSC::B3::testShuffleDoesntTrashCalleeSaves):
(JSC::B3::run):

jit/RegisterSet.h:

2:45 PM Changeset in webkit [219632] by graouts@webkit.org

4 edits in trunk/LayoutTests

Turn tests at media/modern-media-controls/playback-support back on
https://bugs.webkit.org/show_bug.cgi?id=174639

Reviewed by Dean Jackson.

media/modern-media-controls/playback-support/playback-support-button-click.html:
platform/ios-simulator/TestExpectations:
platform/mac/TestExpectations:

2:44 PM Changeset in webkit [219631] by graouts@webkit.org

5 edits in trunk/LayoutTests

Turn tests at media/modern-media-controls/pip-support back on
https://bugs.webkit.org/show_bug.cgi?id=174636

Reviewed by Dean Jackson.

media/modern-media-controls/pip-support/ipad/pip-support-tap.html:
platform/ios-simulator/TestExpectations:
platform/mac-elcapitan/TestExpectations:
platform/mac/TestExpectations:

2:34 PM Changeset in webkit [219630] by commit-queue@webkit.org

4 edits in trunk/Source/WebCore

[Curl] Move detail implementation from ResourceHandle to ResourceHandleInternal
https://bugs.webkit.org/show_bug.cgi?id=174641

After moving stuff from ResourceHandleManager to ResourceHandle on
https://bugs.webkit.org/show_bug.cgi?id=173630, still there're many violation
remains between ResourceHandle and ResourceHandleInternal classes.
Many of implementation detail should be move to ResourceHandleInternal
to improve build speed.

Patch by Basuke Suzuki <Basuke Suzuki> on 2017-07-18
Reviewed by Alex Christensen.

platform/network/ResourceHandle.h:
platform/network/ResourceHandleInternal.h:

(WebCore::ResourceHandleInternal::ResourceHandleInternal):

platform/network/curl/ResourceHandleCurl.cpp:

(WebCore::ResourceHandleInternal::~ResourceHandleInternal):
(WebCore::ResourceHandle::start):
(WebCore::ResourceHandle::cancel):
(WebCore::ResourceHandleInternal::initialize):
(WebCore::ResourceHandleInternal::applyAuthentication):
(WebCore::ResourceHandleInternal::setupPUT):
(WebCore::ResourceHandleInternal::setupPOST):
(WebCore::ResourceHandleInternal::setupFormData):
(WebCore::ResourceHandle::platformSetDefersLoading):
(WebCore::ResourceHandleInternal::didFinish):
(WebCore::ResourceHandleInternal::didFail):
(WebCore::ResourceHandleInternal::calculateWebTimingInformations):
(WebCore::ResourceHandleInternal::handleLocalReceiveResponse):
(WebCore::ResourceHandleInternal::willPrepareSendData):
(WebCore::ResourceHandleInternal::didReceiveHeaderLine):
(WebCore::ResourceHandleInternal::didReceiveAllHeaders):
(WebCore::ResourceHandleInternal::didReceiveContentData):
(WebCore::ResourceHandleInternal::readCallback):
(WebCore::ResourceHandleInternal::headerCallback):
(WebCore::ResourceHandleInternal::writeCallback):
(WebCore::ResourceHandle::platformLoadResourceSynchronously):
(WebCore::ResourceHandleInternal::dispatchSynchronousJob):
(WebCore::ResourceHandleInternal::handleDataURL):
(WebCore::ResourceHandle::initialize): Deleted.
(WebCore::ResourceHandle::applyAuthentication): Deleted.
(WebCore::ResourceHandle::setupPUT): Deleted.
(WebCore::ResourceHandle::setupPOST): Deleted.
(WebCore::ResourceHandle::setupFormData): Deleted.
(WebCore::ResourceHandle::didFinish): Deleted.
(WebCore::ResourceHandle::didFail): Deleted.
(WebCore::ResourceHandle::calculateWebTimingInformations): Deleted.
(WebCore::ResourceHandle::handleLocalReceiveResponse): Deleted.
(WebCore::ResourceHandle::willPrepareSendData): Deleted.
(WebCore::ResourceHandle::didReceiveHeaderLine): Deleted.
(WebCore::ResourceHandle::didReceiveAllHeaders): Deleted.
(WebCore::ResourceHandle::didReceiveContentData): Deleted.
(WebCore::ResourceHandle::readCallback): Deleted.
(WebCore::ResourceHandle::headerCallback): Deleted.
(WebCore::ResourceHandle::writeCallback): Deleted.
(WebCore::ResourceHandle::dispatchSynchronousJob): Deleted.
(WebCore::ResourceHandle::handleDataURL): Deleted.

2:30 PM Changeset in webkit [219629] by Matt Lewis

2 edits in trunk/LayoutTests

Marked http/tests/cache/disk-cache/redirect-chain-limits.html as flaky.
https://bugs.webkit.org/show_bug.cgi?id=172662

Unreviewed test gardening.

platform/wk2/TestExpectations:

2:23 PM Changeset in webkit [219628] by aestes@apple.com

26 edits in trunk

[Xcode] Enable CLANG_WARN_NON_LITERAL_NULL_CONVERSION
https://bugs.webkit.org/show_bug.cgi?id=174631

Reviewed by Dan Bernstein.

Source/bmalloc:

Configurations/Base.xcconfig:

Source/JavaScriptCore:

Configurations/Base.xcconfig:

Source/ThirdParty/ANGLE:

Configurations/Base.xcconfig:

Source/ThirdParty/libwebrtc:

Configurations/Base.xcconfig:

Source/WebCore:

Configurations/Base.xcconfig:

Source/WebCore/PAL:

Configurations/Base.xcconfig:

Source/WebInspectorUI:

Configurations/Base.xcconfig:

Source/WebKit:

Configurations/Base.xcconfig:

Source/WebKitLegacy/mac:

Configurations/Base.xcconfig:

Source/WTF:

Configurations/Base.xcconfig:

Tools:

DumpRenderTree/mac/Configurations/Base.xcconfig:
MiniBrowser/Configurations/Base.xcconfig:
MobileMiniBrowser/Configurations/Base.xcconfig:
TestWebKitAPI/Configurations/Base.xcconfig:
WebKitTestRunner/Configurations/Base.xcconfig:

2:21 PM Changeset in webkit [219627] by Matt Lewis

2 edits in trunk/LayoutTests

Marked http/tests/cache/disk-cache/disk-cache-vary-cookie.html as flaky.
https://bugs.webkit.org/show_bug.cgi?id=172662

Unreviewed test gardening.

platform/wk2/TestExpectations:

2:11 PM Changeset in webkit [219626] by Wenson Hsieh

2 edits in trunk/Source/WebKitLegacy/mac

[iOS DnD] [WK1] Add missing calls to WebThreadLock() in some WebView drag-and-drop SPIs
https://bugs.webkit.org/show_bug.cgi?id=174640
<rdar://problem/33297400>

Reviewed by Tim Horton.

Adds a missing call to WebThreadLock() in -_requestStartDataInteraction:globalPosition:. Previously, this was
invoked at the call site in UIKit, but was removed after some refactoring in UIKit. Instead, we should lock the
web thread here, to match the other WebView drag and drop SPI methods.

This patch also adds a WebThreadLock() call in -_dataInteractionCaretRect. While this is fine today, since all
existing callers of _dataInteractionCaretRect already invoke other methods that WebThreadLock() beforehand, we
should make this robust against future UIKit changes that could make this no longer the case.

WebView/WebView.mm:

(-[WebView _requestStartDataInteraction:globalPosition:]):
(-[WebView _dataInteractionCaretRect]):

1:30 PM Changeset in webkit [219625] by commit-queue@webkit.org

4 edits
2 adds in trunk

[macOS] Mouse pointer does not hide during fullscreen playback
https://bugs.webkit.org/show_bug.cgi?id=174638
<rdar://problem/33244399>

Patch by Antoine Quint <Antoine Quint> on 2017-07-18
Reviewed by Dean Jackson.

Source/WebCore:

Test: media/modern-media-controls/css/webkit-cursor-visibility-auto-hide.html

The user-agent stylesheet sets the "-webkit-cursor-visibility" to "auto-hide" for fullscreen <video>
elements. Since we reset the page styles, including UA styles, on .media-controls-container, we need
to explicitly inherit this style property from the page to ensure the mouse pointer automatically
hides in fullscreen.

Modules/modern-media-controls/controls/media-controls.css:

(.media-controls-container):

LayoutTests:

Add a test that checks that the "-webkit-cursor-visibility" is set to "auto-hide" when
in fullscreen for the media controls container.

media/modern-media-controls/css/webkit-cursor-visibility-auto-hide-expected.txt: Added.
media/modern-media-controls/css/webkit-cursor-visibility-auto-hide.html: Added.
platform/ios-simulator/TestExpectations:

1:21 PM Changeset in webkit [219624] by Devin Rousso

5 edits
1 add in trunk

Web Inspector: Add memoryCost to Inspector Protocol objects
https://bugs.webkit.org/show_bug.cgi?id=174478

Reviewed by Joseph Pecoraro.

Source/JavaScriptCore:

For non-array and non-object InspectorValue, calculate memoryCost as the sizeof the object,
plus the memoryCost of the data if it is a string.

For array InspectorValue, calculate memoryCost as the sum of the memoryCost of all items.

For object InspectorValue, calculate memoryCost as the sum of the memoryCost of the string
key plus the memoryCost of the InspectorValue for each entry.

Test: TestWebKitAPI/Tests/JavaScriptCore/InspectorValue.cpp

inspector/InspectorValues.h:
inspector/InspectorValues.cpp:

(Inspector::InspectorValue::memoryCost):
(Inspector::InspectorObjectBase::memoryCost):
(Inspector::InspectorArrayBase::memoryCost):

Tools:

TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
TestWebKitAPI/Tests/JavaScriptCore/InspectorValue.cpp: Added.

(TestWebKitAPI::TEST(InspectorValue, MemoryCostNull)):
(TestWebKitAPI::TEST(InspectorValue, MemoryCostBoolean)):
(TestWebKitAPI::TEST(InspectorValue, MemoryCostDouble)):
(TestWebKitAPI::TEST(InspectorValue, MemoryCostInteger)):
(TestWebKitAPI::TEST(InspectorValue, MemoryCostString)):
(TestWebKitAPI::TEST(InspectorValue, MemoryCostStringEmpty)):
(TestWebKitAPI::TEST(InspectorValue, MemoryCostStringNull)):
(TestWebKitAPI::TEST(InspectorValue, MemoryCostStringGrowing)):
(TestWebKitAPI::TEST(InspectorValue, MemoryCostStringUnicode)):
(TestWebKitAPI::TEST(InspectorValue, MemoryCostObject)):
(TestWebKitAPI::TEST(InspectorValue, MemoryCostObjectEmpty)):
(TestWebKitAPI::TEST(InspectorValue, MemoryCostObjectGrowing)):
(TestWebKitAPI::TEST(InspectorValue, MemoryCostArray)):
(TestWebKitAPI::TEST(InspectorValue, MemoryCostArrayEmpty)):
(TestWebKitAPI::TEST(InspectorValue, MemoryCostArrayGrowing)):

1:14 PM Changeset in webkit [219623] by commit-queue@webkit.org

32 edits
1 delete in trunk

[WebIDL] Remove custom bindings for MockContentFilterSettings
https://bugs.webkit.org/show_bug.cgi?id=174606

Patch by Sam Weinig <sam@webkit.org> on 2017-07-18
Reviewed by Andy Estes.

Source/WebCore:

PlatformMac.cmake:
WebCore.xcodeproj/project.pbxproj:
bindings/js/JSMockContentFilterSettingsCustom.cpp: Removed.

Remove JSMockContentFilterSettingsCustom.

testing/MockContentFilterSettings.h:
testing/MockContentFilterSettings.idl:

Switch from constants to IDL enums to make the bindings and tests simpler.

LayoutTests:

contentfiltering/allow-after-add-data.html:
contentfiltering/allow-after-finished-adding-data.html:
contentfiltering/allow-after-response.html:
contentfiltering/allow-after-will-send-request.html:
contentfiltering/allow-empty-document.html:
contentfiltering/allow-media-document.html:
contentfiltering/allow-never.html:
contentfiltering/block-after-add-data-then-allow-unblock.html:
contentfiltering/block-after-add-data-then-deny-unblock.html:
contentfiltering/block-after-add-data.html:
contentfiltering/block-after-finished-adding-data-then-allow-unblock.html:
contentfiltering/block-after-finished-adding-data-then-deny-unblock.html:
contentfiltering/block-after-finished-adding-data.html:
contentfiltering/block-after-response-then-allow-unblock.html:
contentfiltering/block-after-response-then-deny-unblock.html:
contentfiltering/block-after-response.html:
contentfiltering/block-after-will-send-request-then-allow-unblock.html:
contentfiltering/block-after-will-send-request-then-deny-unblock.html:
contentfiltering/block-after-will-send-request.html:
contentfiltering/block-never.html:
contentfiltering/modify-request-url.html:
contentfiltering/resources/contentfiltering.js:
http/tests/contentfiltering/allow-after-redirect.html:
http/tests/contentfiltering/block-after-redirect.html:
http/tests/contentfiltering/load-substitute-data-from-appcache.html:
http/tests/contentfiltering/modify-redirect-request-url.html:

Update tests to use new MockContentFilterSettings enums rather than constants.

1:12 PM Changeset in webkit [219622] by weinig@apple.com

12 edits
7 adds in trunk

[WebIDL] Replace some custom bindings code in JSCSSStyleDeclarationCustom.cpp with named getters/setters
https://bugs.webkit.org/show_bug.cgi?id=174529

Reviewed by Chris Dumez.

Source/WebCore:

CMakeLists.txt:
WebCore.xcodeproj/project.pbxproj:
css/CSSAllInOne.cpp:

Add CSSStyleDeclaration.cpp

bindings/js/JSCSSStyleDeclarationCustom.cpp:

Move getter / setter / getOwnProperties logic from here to CSSStyleDeclaration.cpp.

bindings/scripts/CodeGeneratorJS.pm:

(GenerateGetOwnPropertySlot):
(GenerateGetOwnPropertySlotByIndex):
(InstanceOverridesGetOwnPropertySlot):
(GenerateHeader):
Remove support for no longer needed [CustomGetOwnPropertySlotAndDescriptor].
Add support for [PutOnlyForSupportedProperties], which allows named setters to behave
a bit more like normal setters by allowing the implementation to note which properties
are supported which in turn, allows the bindings to continue down the normal put path
for unsupported properties. This is necessary to mimic the behavior of CSSStyleDeclaration
which is using named setters in place hundreds of additional properties.

(InstanceOverridesDefineOwnProperty):
Add [DefaultDefineOwnProperty] to allow disabling defineOwnProperty overriding that comes
automatically with named setters. We need this for CSSStyleDeclaration since the named
setter usage modeling real properties, not a dictionary style setter. We may want to
revisit this, and add support for DefineOwnProperty here, but this allows us to maintain
the status quo.

(GenerateDefineOwnProperty):
Fix the case when you have a named setter, an indexed getter, but no indexed setter. In that
case, we would get a compile error, due to the index variable being unused.

bindings/scripts/IDLAttributes.json:

Remove support for no longer needed [CustomGetOwnPropertySlotAndDescriptor], add
[PutOnlyForSupportedProperties] and [DefaultDefineOwnProperty].

css/CSSStyleDeclaration.h:
css/CSSStyleDeclaration.cpp: Added.

(WebCore::CSSStyleDeclaration::namedItem):
(WebCore::CSSStyleDeclaration::setNamedItem):
(WebCore::CSSStyleDeclaration::isSupportedPropertyName):
(WebCore::CSSStyleDeclaration::supportedPropertyNames):
Use standard getter / setter functions to implement CSS property name getting and setting.
Convert from Identifier to AtomicString, which are now bridgeable.

css/CSSStyleDeclaration.idl:

Add named getter and setter. Remove [CustomGetOwnPropertyNames], [CustomGetOwnPropertySlotAndDescriptor]
and [CustomPut], add [DefaultDefineOwnProperty].

bindings/scripts/test/JS/JSTestNamedSetterWithIndexedGetter.cpp: Added.
bindings/scripts/test/JS/JSTestNamedSetterWithIndexedGetter.h: Added.
bindings/scripts/test/JS/JSTestNamedSetterWithIndexedGetterAndSetter.cpp: Added.
bindings/scripts/test/JS/JSTestNamedSetterWithIndexedGetterAndSetter.h: Added.
bindings/scripts/test/TestNamedSetterWithIndexedGetter.idl: Added.
bindings/scripts/test/TestNamedSetterWithIndexedGetterAndSetter.idl: Added.

Add tests for improved behavior when using named setters with variations of indexed getters and setters as well.

LayoutTests:

fast/dom/CSSStyleDeclaration/cssstyledeclaration-properties-descriptor-expected.txt:
fast/dom/CSSStyleDeclaration/cssstyledeclaration-properties-descriptor.html:

Update test and result to match standard and other browsers.

12:59 PM Changeset in webkit [219621] by commit-queue@webkit.org

4 edits in trunk/Source/WebCore

[iOS] WebKit media controls are sometimes shown after exiting full screen on vimeo.com
https://bugs.webkit.org/show_bug.cgi?id=174627
<rdar://problem/33301005>

Patch by Antoine Quint <Antoine Quint> on 2017-07-18
Reviewed by Dean Jackson, provisionally reviewed by Jeremy Jones.

On iOS 11, both the WebKit media controls and the Vimeo custom controls would appear sometimes when exiting
from fullscreen when the video was playing and the user would tap the X button, which would pause the video
as well as exit fullscreen.

The reason this happens is that the ControlsVisibilitySupport object, which governs whether the WebKit media
controls should be displayed for a given video, woud listen to "pause" and "webkitfullscreenchange" events
and determine whether to show the WebKit media controls. We listen to the "pause" event because when media
pauses, and the video has the "controls" attribute set, we should show the controls and suspend the controls
auto-hide timer. And we're interested in knowing when we enter and exit fullscreen because we want to override
the "controls" attribute not being set when we enter fullscreen.

However, on iOS 11, it appears that the "webkitfullscreenchange" event is not reliably fired as the user enters
and exits fullscreen, which is tracked by webkit.org/b/174626. So, when the user exits fullscreen, we would be
informed of the video being paused via a "pause" event, but not of the video exiting fullscreen. And because
media events are asynchronous, the "pause" event would sometimes be fired before we exited fullscreen, and when
the _updateControls() would run, we would sometimes determine that we are in fullscreen still and determine
that the WebKit media controls should be shown.

Of course, on iOS, the WebKit media controls are not shown and instead we delegate to AVKit to display media controls.
So we could simply disregard this whole logic in iOS. But we choose to instead use the "webkitpresentationmodechanged"
when the presentation mode API is supported, as is the case on iOS 11, to determine changes of media fullscreen state.
This way, should we ever choose to support fullscreen media controls provided by WebKit on iOS, this logic is already
correct and we write less platform-specific code.

This, alas, cannot be tested since we can't force the X button to be tapped within the AVKit fullscreen controls.

Modules/modern-media-controls/media/controls-visibility-support.js:

(ControlsVisibilitySupport.prototype.get mediaEvents):

Modules/modern-media-controls/media/media-controller.js:

(MediaController):

Modules/modern-media-controls/media/start-support.js:

(StartSupport.prototype.get mediaEvents):

12:31 PM Changeset in webkit [219620] by Matt Lewis

47 edits
9 deletes in trunk

Unreviewed, rolling out r219610.

This caused an api failure on all platforms for the test
SnapshotImageLargeAsyncDecoding

Reverted changeset:

"Async image decoding for large images should be disabled
after the first time a tile is painted"
https://bugs.webkit.org/show_bug.cgi?id=174451
http://trac.webkit.org/changeset/219610

11:54 AM Changeset in webkit [219619] by Devin Rousso

7 edits
6 adds in trunk

Add CanvasRenderingContext2D::getTransform
https://bugs.webkit.org/show_bug.cgi?id=174278

Reviewed by Dean Jackson.

Source/WebCore:

Tests: fast/canvas/2d.getTransform.modification.html

fast/canvas/2d.getTransform.newobject.html
fast/canvas/2d.setTransform.matrix.html

css/DOMMatrixReadOnly.h:

Make DOMMatrixReadOnly::validateAndFixup public so that values of DOMMatrixInit are still
usable without having to construct a DOMMatrixReadOnly. This is beneficial in the case that
an exception is thrown, as the validateAndFixup check can happen without any allocations.

html/canvas/CanvasRenderingContext2D.idl:
html/canvas/CanvasRenderingContext2D.h:
html/canvas/CanvasRenderingContext2D.cpp:

(WebCore::CanvasRenderingContext2D::getTransform):
(WebCore::CanvasRenderingContext2D::setTransform):

LayoutTests:

canvas/philip/tests/2d.missingargs.html:

CanvasRenderingContext2D.prototype.setTransform no longer throws an error with no arguments.

fast/canvas/2d.getTransform.modification-expected.txt: Added.
fast/canvas/2d.getTransform.modification.html: Added.
fast/canvas/2d.getTransform.newobject-expected.txt: Added.
fast/canvas/2d.getTransform.newobject.html: Added.
fast/canvas/2d.setTransform.matrix-expected.txt: Added.
fast/canvas/2d.setTransform.matrix.html: Added.

11:39 AM Changeset in webkit [219618] by aestes@apple.com

26 edits in trunk

[Xcode] Enable CLANG_WARN_BLOCK_CAPTURE_AUTORELEASING
https://bugs.webkit.org/show_bug.cgi?id=174631

Reviewed by Darin Adler.

Source/bmalloc:

Configurations/Base.xcconfig:

Source/JavaScriptCore:

Configurations/Base.xcconfig:

Source/ThirdParty/ANGLE:

Configurations/Base.xcconfig:

Source/ThirdParty/libwebrtc:

Configurations/Base.xcconfig:

Source/WebCore:

Configurations/Base.xcconfig:

Source/WebCore/PAL:

Configurations/Base.xcconfig:

Source/WebInspectorUI:

Configurations/Base.xcconfig:

Source/WebKit:

Configurations/Base.xcconfig:

Source/WebKitLegacy/mac:

Configurations/Base.xcconfig:

Source/WTF:

Configurations/Base.xcconfig:

Tools:

DumpRenderTree/mac/Configurations/Base.xcconfig:
MiniBrowser/Configurations/Base.xcconfig:
MobileMiniBrowser/Configurations/Base.xcconfig:
TestWebKitAPI/Configurations/Base.xcconfig:
WebKitTestRunner/Configurations/Base.xcconfig:

10:05 AM Changeset in webkit [219617] by matthew_hanson@apple.com

15 edits in tags/Safari-604.1.32.0.1

Revert r219413. rdar://problem/33337335

10:05 AM Changeset in webkit [219616] by matthew_hanson@apple.com

5 edits in tags/Safari-604.1.32.0.1/Source

Revert r219423. rdar://problem/33337335

10:03 AM Changeset in webkit [219615] by Jonathan Bedard

3 edits in trunk/Source/WebCore

Unreviewed build fix after r219595

platform/graphics/cocoa/FontDescriptionCocoa.cpp:

(WebCore::makeNeverDestroyed): Remove duplicate makeNeverDestroyed definition.

platform/ios/DragImageIOS.mm:

(WebCore::cascadeForSystemFont): Return correct FontCascade object.
(WebCore::createDragImageForLink): Fix compiler error.

9:51 AM Changeset in webkit [219614] by dbates@webkit.org

2 edits in trunk/Source/WebCore

Cleanup: Remove AlternativeTextInfo and use Variant to represent alternative text info details
https://bugs.webkit.org/show_bug.cgi?id=174604

I inadvertently did not commit some of my local changes.

editing/AlternativeTextController.cpp:

(WebCore::AlternativeTextController::startAlternativeTextUITimer):
(WebCore::AlternativeTextController::stopAlternativeTextUITimer):
(WebCore::AlternativeTextController::applyPendingCorrection):
(WebCore::AlternativeTextController::hasPendingCorrection):
(WebCore::AlternativeTextController::show):
(WebCore::AlternativeTextController::handleCancelOperation):
(WebCore::AlternativeTextController::dismiss):
(WebCore::AlternativeTextController::dismissSoon):
(WebCore::AlternativeTextController::applyAutocorrectionBeforeTypingIfAppropriate):
(WebCore::AlternativeTextController::timerFired):
(WebCore::AlternativeTextController::handleAlternativeTextUIResult):
(WebCore::AlternativeTextController::respondToMarkerAtEndOfWord):
(WebCore::AlternativeTextController::markerDescriptionForAppliedAlternativeText):

9:31 AM Changeset in webkit [219613] by dbates@webkit.org

3 edits in trunk/Source/WebCore

Cleanup: Remove AlternativeTextInfo and use Variant to represent alternative text info details
https://bugs.webkit.org/show_bug.cgi?id=174604

Reviewed by Darin Adler.

Remove struct AlternativeTextInfo and represent the alternative text info as instance variables
using Variant to hold either an autocorrection replacement string or the alternative dictation
context.

Not functionality changed. So, no new tests.

editing/AlternativeTextController.cpp: Remove header Event.h as it is ultimately included by TextEvent.h.

(WebCore::AlternativeTextController::show): Update code as needed.
(WebCore::AlternativeTextController::timerFired): Ditto.
(WebCore::AlternativeTextController::alternativeTextClient): Substitute nullptr for 0.
(WebCore::AlternativeTextController::respondToMarkerAtEndOfWord): Update code as needed.
(WebCore::AutocorrectionAlternativeDetails::create): Deleted.
(WebCore::AutocorrectionAlternativeDetails::replacementString): Deleted.
(WebCore::AutocorrectionAlternativeDetails::AutocorrectionAlternativeDetails): Deleted.
(WebCore::DictationAlternativeDetails::create): Deleted.
(WebCore::DictationAlternativeDetails::dictationContext): Deleted.
(WebCore::DictationAlternativeDetails::DictationAlternativeDetails): Deleted.

editing/AlternativeTextController.h: Remove header Range.h and forward declare Range. Include header

Position.h and wtf/Variant.h. Sort forward declarations.
(WebCore::AlternativeTextDetails::~AlternativeTextDetails): Deleted.

9:31 AM Changeset in webkit [219612] by Matt Lewis

2 edits in trunk/LayoutTests

Rebaseline inspector/model/remote-object.html.
https://bugs.webkit.org/show_bug.cgi?id=173991

Unreviewed test gardening.

inspector/model/remote-object-expected.txt:

9:25 AM Changeset in webkit [219611] by msaboff@apple.com

4 edits in trunk/Source/JavaScriptCore

[JSC] There should be a debug option to dump a compiled RegExp Pattern
https://bugs.webkit.org/show_bug.cgi?id=174601

Reviewed by Alex Christensen.

Added the debug option dumpCompiledRegExpPatterns which will dump the YarrPattern and related
objects after a regular expression has been compiled.

runtime/Options.h:
yarr/YarrPattern.cpp:

(JSC::Yarr::YarrPattern::compile):
(JSC::Yarr::indentForNestingLevel):
(JSC::Yarr::dumpUChar32):
(JSC::Yarr::PatternAlternative::dump):
(JSC::Yarr::PatternTerm::dumpQuantifier):
(JSC::Yarr::PatternTerm::dump):
(JSC::Yarr::PatternDisjunction::dump):
(JSC::Yarr::YarrPattern::dumpPattern):

yarr/YarrPattern.h:

(JSC::Yarr::YarrPattern::global):

9:03 AM Changeset in webkit [219610] by commit-queue@webkit.org

47 edits
9 adds in trunk

Async image decoding for large images should be disabled after the first time a tile is painted
https://bugs.webkit.org/show_bug.cgi?id=174451

Patch by Said Abou-Hallawa <sabouhallawa@apple.com> on 2017-07-18
Reviewed by Simon Fraser.

Source/WebCore:

Flashing because of DOM mutation can be fixed by disabling the asynchronous
image decoding after the first time a tile was painted.

We can detect this by consulting the tile repaintCount. If it is zero, then
it is safe to use asynchronous image decoded. If the tile repaintCount is
greater than zero, we are not sure if the renderer rectangle has an image
drawn in it already or not. In this case we have to use the synchronous
image decoding to avoid causing a flash.

Tests: fast/images/async-image-background-change.html

fast/images/async-image-src-change.html
http/tests/multipart/multipart-async-image.html

page/PageOverlayController.cpp:

(WebCore::PageOverlayController::paintContents):

page/PageOverlayController.h:
page/linux/ResourceUsageOverlayLinux.cpp:
page/mac/ServicesOverlayController.h:
page/mac/ServicesOverlayController.mm:

(WebCore::ServicesOverlayController::Highlight::paintContents):

platform/graphics/BitmapImage.h:
platform/graphics/GraphicsLayer.cpp:

(WebCore::GraphicsLayer::paintGraphicsLayerContents):

platform/graphics/GraphicsLayer.h:
platform/graphics/GraphicsLayerClient.h:

(WebCore::GraphicsLayerClient::paintContents):

platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.cpp:

(WebCore::LayerClient::platformCALayerPaintContents):

platform/graphics/ca/GraphicsLayerCA.cpp:

(WebCore::GraphicsLayerCA::platformCALayerPaintContents):

platform/graphics/ca/GraphicsLayerCA.h:
platform/graphics/ca/PlatformCALayer.h:
platform/graphics/ca/PlatformCALayerClient.h:

(WebCore::PlatformCALayerClient::platformCALayerRepaintCount):

platform/graphics/ca/TileCoverageMap.cpp:

(WebCore::TileCoverageMap::platformCALayerPaintContents):

platform/graphics/ca/TileCoverageMap.h:
platform/graphics/ca/TileGrid.cpp:

(WebCore::TileGrid::platformCALayerPaintContents):
(WebCore::TileGrid::platformCALayerRepaintCount):

platform/graphics/ca/TileGrid.h:
platform/graphics/ca/cocoa/PlatformCALayerCocoa.mm:

(PlatformCALayer::drawLayerContents):

platform/graphics/ca/win/PlatformCALayerWin.cpp:

(PlatformCALayer::drawLayerContents):

platform/graphics/ca/win/PlatformCALayerWinInternal.cpp:

(PlatformCALayerWinInternal::displayCallback):

platform/graphics/ca/win/WebTiledBackingLayerWin.cpp:

(WebTiledBackingLayerWin::displayCallback):

platform/graphics/mac/WebLayer.mm:

(-[WebLayer drawInContext:]):
(-[WebSimpleLayer drawInContext:]):

rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::decodingModeForImageDraw):

rendering/RenderElement.h:
rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::paintContents):

rendering/RenderLayerBacking.h:
rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::paintContents):

rendering/RenderLayerCompositor.h:
testing/Internals.cpp:

(WebCore::imageFromImageElement):
(WebCore::bitmapImageFromImageElement):
(WebCore::Internals::imageFrameIndex):
(WebCore::Internals::setImageFrameDecodingDuration):
(WebCore::Internals::resetImageAnimation):
(WebCore::Internals::isImageAnimating):
(WebCore::Internals::setClearDecoderAfterAsyncFrameRequestForTesting):
(WebCore::Internals::imageDecodeCount):
(WebCore::Internals::setLargeImageAsyncDecodingEnabledForTesting):

testing/Internals.h:
testing/Internals.idl:

Source/WebKit:

Shared/mac/RemoteLayerBackingStore.mm:

(WebKit::RemoteLayerBackingStore::drawInContext):

WebProcess/WebPage/CoordinatedGraphics/CompositingCoordinator.cpp:

(WebKit::CompositingCoordinator::paintContents):

WebProcess/WebPage/CoordinatedGraphics/CompositingCoordinator.h:

Source/WebKitLegacy/win:

FullscreenVideoController.cpp:

(FullscreenVideoController::LayerClient::platformCALayerPaintContents):

WebCoreSupport/AcceleratedCompositingContext.cpp:

(AcceleratedCompositingContext::paintContents):

WebCoreSupport/AcceleratedCompositingContext.h:

LayoutTests:

To test async image decoding for large images, we have to create the <img>
element dynamically so we can listen to the load and webkitImageFrameReady
events and know reliably when to end the test. But with this patch the async
image decoding for large images will be disabled after the first paint.
That means async image decoding for large images will be disabled always
unless we force the async image decoding till the image is painted for the
first time. We use Internals::setLargeImageAsyncDecodingEnabledForTesting()
to force the async image decoding. So painting an image in this case will
require multiple paints; in all of them the async image decoding will be
enabled. But this is okay because it resembles the case where the <img> is
created from a static <img> tag in the HTML file.

For new tests, where we want to make sure that mutating the DOM will not
cause a flash, async image decoding will be forced till the image is drawn
for the first time. After that the async image decoding is enabled but not
forced.

Disable new tests for WK1 because the async image decoding is always enabled
because tiling does not necessarily exist in WK1 . But eventually the async
image decoding for large images will be always disabled for WK1.

fast/images/async-image-background-change-expected.html: Added.
fast/images/async-image-background-change.html: Added.
fast/images/async-image-background-image-repeated.html:
fast/images/async-image-background-image.html:
fast/images/async-image-multiple-clients-repaint.html:
fast/images/async-image-src-change-expected.html: Added.
fast/images/async-image-src-change.html: Added.
fast/images/resources/green-400x400.png: Added.
fast/images/resources/red-100x100.png: Added.
fast/images/resources/red-400x400.png: Added.
http/tests/multipart/multipart-async-image-expected.txt: Added.
http/tests/multipart/multipart-async-image.html: Added.
platform/ios-wk1/TestExpectations:
platform/mac-wk1/TestExpectations:

6:03 AM Changeset in webkit [219609] by Michael Catanzaro

2 edits in trunk/LayoutTests

Unreviewed GTK test gardening

fast/forms/range/input-appearance-range-rtl.html is desired to fail.

platform/gtk/TestExpectations:

4:21 AM Changeset in webkit [219608] by clopez@igalia.com

2 edits in trunk/Source/WebDriver

[GTK] Fix build with Clang after r219605.
https://bugs.webkit.org/show_bug.cgi?id=166682

Unreviewed build fix.

Clang-3.8 complains with the following error:
non-constant-expression cannot be narrowed from type 'gboolean' (aka 'int') to 'bool' in initializer list [-Wc++11-narrowing]

glib/SessionHostGlib.cpp: insert an explicit cast to silence this issue.

12:33 AM Changeset in webkit [219607] by Chris Dumez

16 edits in trunk

DOMException should have its properties on the prototype
https://bugs.webkit.org/show_bug.cgi?id=174597

Reviewed by Alex Christensen.

LayoutTests/imported/w3c:

web-platform-tests/WebIDL/ecmascript-binding/es-exceptions/DOMException-constructor-behavior.any-expected.txt:
web-platform-tests/WebIDL/ecmascript-binding/es-exceptions/DOMException-constructor-behavior.any.worker-expected.txt:
web-platform-tests/WebIDL/ecmascript-binding/es-exceptions/DOMException-custom-bindings.any-expected.txt:
web-platform-tests/WebIDL/ecmascript-binding/es-exceptions/DOMException-custom-bindings.any.worker-expected.txt:
web-platform-tests/WebIDL/ecmascript-binding/es-exceptions/exceptions-expected.txt:

Rebaseline now that more checks are passing.

web-platform-tests/url/urlsearchparams-constructor-expected.txt:
web-platform-tests/url/urlsearchparams-constructor.html:

Re-sync test from upstream as it would start failing otherwise.

Source/WebCore:

DOMException should have its properties on the prototype, as other interfaces:

https://heycam.github.io/webidl/#idl-DOMException

No new tests, rebaselined existing tests.

bindings/scripts/CodeGeneratorJS.pm:

(InterfaceRequiresAttributesOnInstance):

LayoutTests:

Rebaseline inspector tests whose output changed slightly now that the
DOMException have moved to the prototype.

inspector/debugger/setPauseOnExceptions-all-expected.txt:
inspector/debugger/setPauseOnExceptions-none-expected.txt:
inspector/debugger/setPauseOnExceptions-uncaught-expected.txt:

12:20 AM Changeset in webkit [219606] by commit-queue@webkit.org

12 edits
2 deletes in trunk/Source/WebCore

[Curl] Unify ResourceHandleManager into CurlJobManager.
https://bugs.webkit.org/show_bug.cgi?id=173991

Use CurlJobManager to make ResourceHandle run in background.
CurlJobManager::start() now accept callback to manage life cycle
of the resource easily in a same context.
Actual management tasks of CurlJobManager is now private class
in CurlJobManager which is better thread safeness.
ResourceHandleManager is deleted at all.

Patch by Basuke Suzuki <Basuke Suzuki> on 2017-07-18
Reviewed by Alex Christensen.

platform/Curl.cmake:
platform/network/ResourceHandle.h:
platform/network/curl/CookieJarCurl.cpp:

(WebCore::cookiesForSession):

platform/network/curl/CurlContext.cpp:

(WebCore::CurlHandle::CurlHandle):
(WebCore::CurlHandle::~CurlHandle):
(WebCore::CurlHandle::errorDescription):
(WebCore::CurlHandle::perform):
(WebCore::CurlHandle::pause):
(WebCore::CurlHandle::appendRequestHeaders):
(WebCore::CurlHandle::appendRequestHeader):
(WebCore::CurlHandle::enableRequestHeaders):
(WebCore::CurlHandle::fetchCookieList):
(WebCore::CurlHandle::getEffectiveURL):
(WebCore::CurlHandle::setPrivateData): Deleted.
(WebCore::CurlHandle::clearRequestHeaders): Deleted.
(WebCore::CurlHandle::getCookieList): Deleted.
(WebCore::CurlHandle::clearCookieList): Deleted.

platform/network/curl/CurlContext.h:

(WebCore::CurlSList::CurlSList):
(WebCore::CurlSList::~CurlSList):
(WebCore::CurlSList::operator struct curl_slist ):
(WebCore::CurlSList::head):
(WebCore::CurlSList::isEmpty):
(WebCore::CurlSList::clear):
(WebCore::CurlSList::append):
(WebCore::CurlHandle::errorCode):
(WebCore::CurlHandle::setErrorCode):
(WebCore::CurlHandle::privateData):
(WebCore::CurlHandle::setPrivateData):

platform/network/curl/CurlDownload.cpp:

(WebCore::CurlDownload::start):
(WebCore::CurlDownload::cancel):
(WebCore::CurlDownload::addHeaders):
(WebCore::CurlDownload::didReceiveData):
(WebCore::CurlDownload::didFail):
(WebCore::CurlDownload::handleCurlMsg): Deleted.

platform/network/curl/CurlDownload.h:
platform/network/curl/CurlJobManager.cpp:

(WebCore::CurlJobList::append):
(WebCore::CurlJobList::cancel):
(WebCore::CurlJobList::complete):
(WebCore::CurlJobList::isEmpty):
(WebCore::CurlJobList::withJob):
(WebCore::CurlJobList::withCurlHandle):
(WebCore::CurlJob::invoke):
(WebCore::CurlJobManager::add):
(WebCore::CurlJobManager::cancel):
(WebCore::CurlJobManager::callOnJobThread):
(WebCore::CurlJobManager::startThreadIfNeeded):
(WebCore::CurlJobManager::stopThreadIfNoMoreJobRunning):
(WebCore::CurlJobManager::stopThread):
(WebCore::CurlJobManager::updateJobs):
(WebCore::CurlJobManager::workerThread):
(WebCore::CurlJobManager::CurlJobManager): Deleted.
(WebCore::CurlJobManager::~CurlJobManager): Deleted.
(WebCore::CurlJobManager::remove): Deleted.
(WebCore::CurlJobManager::getActiveCount): Deleted.
(WebCore::CurlJobManager::getPendingCount): Deleted.
(WebCore::CurlJobManager::stopThreadIfIdle): Deleted.
(WebCore::CurlJobManager::updateHandleList): Deleted.
(WebCore::CurlJobManager::addToCurl): Deleted.
(WebCore::CurlJobManager::removeFromCurl): Deleted.

platform/network/curl/CurlJobManager.h:

(WebCore::CurlJob::CurlJob):
(WebCore::CurlJob::~CurlJob):
(WebCore::CurlJob::operator=):
(WebCore::CurlJob::curlHandle):
(WebCore::CurlJob::ticket):
(WebCore::CurlJob::finished):
(WebCore::CurlJob::error):
(WebCore::CurlJob::cancel):
(WebCore::CurlJobManager::singleton):
(WebCore::CurlJobManager::~CurlJobManager):
(WebCore::CurlJobManager::isActiveJob):
(WebCore::CurlJobManager::runThread): Deleted.
(WebCore::CurlJobManager::setRunThread): Deleted.

platform/network/curl/ResourceError.h:

(WebCore::ResourceError::ResourceError):

platform/network/curl/ResourceHandleCurl.cpp:

(WebCore::ResourceHandle::~ResourceHandle):
(WebCore::ResourceHandle::start):
(WebCore::ResourceHandle::cancel):
(WebCore::ResourceHandle::initialize):
(WebCore::ResourceHandle::applyAuthentication):
(WebCore::getFormElementsCount):
(WebCore::ResourceHandle::setupPUT):
(WebCore::ResourceHandle::setupPOST):
(WebCore::ResourceHandle::setupFormData):
(WebCore::ResourceHandle::setHostAllowsAnyHTTPSCertificate):
(WebCore::ResourceHandle::setClientCertificateInfo):
(WebCore::ResourceHandle::platformSetDefersLoading):
(WebCore::ResourceHandle::didFinish):
(WebCore::ResourceHandle::didFail):
(WebCore::ResourceHandle::shouldUseCredentialStorage):
(WebCore::ResourceHandle::didReceiveAuthenticationChallenge):
(WebCore::ResourceHandle::receivedCredential):
(WebCore::ResourceHandle::receivedRequestToContinueWithoutCredential):
(WebCore::ResourceHandle::receivedCancellation):
(WebCore::ResourceHandle::calculateWebTimingInformations):
(WebCore::ResourceHandle::handleLocalReceiveResponse):
(WebCore::ResourceHandle::willPrepareSendData):
(WebCore::ResourceHandle::didReceiveHeaderLine):
(WebCore::ResourceHandle::didReceiveAllHeaders):
(WebCore::ResourceHandle::didReceiveContentData):
(WebCore::ResourceHandle::readCallback):
(WebCore::ResourceHandle::headerCallback):
(WebCore::ResourceHandle::writeCallback):
(WebCore::ResourceHandle::platformLoadResourceSynchronously):
(WebCore::ResourceHandle::dispatchSynchronousJob):
(WebCore::calculateWebTimingInformations): Deleted.
(WebCore::handleLocalReceiveResponse): Deleted.
(WebCore::writeCallback): Deleted.
(WebCore::headerCallback): Deleted.
(WebCore::readCallback): Deleted.
(WebCore::setupFormData): Deleted.
(WebCore::ResourceHandle::handleCurlMsg): Deleted.

platform/network/curl/ResourceHandleManager.cpp: Removed.
platform/network/curl/ResourceHandleManager.h: Removed.

12:20 AM Changeset in webkit [219605] by Carlos Garcia Campos

5 edits
23 adds in trunk

Add initial implementation of WebDriver process to run the HTTP server
https://bugs.webkit.org/show_bug.cgi?id=166682

Reviewed by Brian Burg.

Enable WebDriver in the GTK port by default.

Source/CMakeLists.txt:
Source/cmake/OptionsGTK.cmake:
Source/cmake/WebKitFS.cmake:
Source/cmake/WebKitFeatures.cmake:

Source/WebDriver:

Add WebDriver process that runs the HTTP server and implements an initial set of commands. Most of the code is
cross-platform, only the HTTP server implementation, the code to launch the browser and the communication with
the remote inspector requires platform specific code. This patch includes the GTK port implementation, using
libsoup for the HTTP server, and GLib for launching the browser and communicating with the remote
inspector. This implementation follows the w3c spec (https://www.w3.org/TR/webdriver) as close as possible, but
using the official selenium python tests as reference.

CMakeLists.txt: Added.
Capabilities.h: Added.
CommandResult.cpp: Added.
CommandResult.h: Added.
HTTPServer.cpp: Added.
HTTPServer.h: Added.
PlatformGTK.cmake: Added.
Session.cpp: Added.
Session.h: Added.
SessionHost.cpp: Added.
SessionHost.h: Added.
WebDriverMain.cpp: Added.
WebDriverService.cpp: Added.
WebDriverService.h: Added.
config.h: Added.
glib/SessionHostGlib.cpp: Added.
gtk/WebDriverServiceGtk.cpp: Added.
soup/HTTPServerSoup.cpp: Added.

Note: See TracTimeline for information about the timeline view.

Download in other formats:

RSS Feed