Timeline

Jul 20, 2017:

11:38 PM Changeset in webkit [219718] by Carlos Garcia Campos

• 3 edits
  1 delete in trunk/Source/WebKit

Unreviewed. Remove WKIconDatabaseCairo.

• PlatformGTK.cmake:
• PlatformWPE.cmake:
• UIProcess/API/C/cairo/WKIconDatabaseCairo.cpp: Removed.
• UIProcess/API/C/cairo/WKIconDatabaseCairo.h: Removed.

11:34 PM Changeset in webkit [219717] by graouts@webkit.org

• 2 edits in trunk/LayoutTests

Turn tests at media/modern-media-controls/seek-forward-support back on
​https://bugs.webkit.org/show_bug.cgi?id=174690

Reviewed by Dean Jackson.

• platform/mac/TestExpectations:

11:32 PM Changeset in webkit [219716] by graouts@webkit.org

• 2 edits in trunk/LayoutTests

Turn tests at media/modern-media-controls/seek-backward-support back on
​https://bugs.webkit.org/show_bug.cgi?id=174689

Reviewed by Dean Jackson.

• platform/mac/TestExpectations:

11:29 PM Changeset in webkit [219715] by graouts@webkit.org

• 7 edits in trunk/LayoutTests

Turn tests at media/modern-media-controls/time-labels-support back on
​https://bugs.webkit.org/show_bug.cgi?id=174688

Reviewed by Dean Jackson.

• media/modern-media-controls/time-labels-support/elapsed-time-expected.txt:
• media/modern-media-controls/time-labels-support/elapsed-time.html:
• media/modern-media-controls/time-labels-support/remaining-time-expected.txt:
• media/modern-media-controls/time-labels-support/remaining-time.html:
• platform/ios-simulator/TestExpectations:
• platform/mac/TestExpectations:

11:28 PM Changeset in webkit [219714] by graouts@webkit.org

• 3 edits in trunk/LayoutTests

Turn tests at media/modern-media-controls/status-support back on
​https://bugs.webkit.org/show_bug.cgi?id=174687

Reviewed by Dean Jackson.

• platform/ios-simulator/TestExpectations:
• platform/mac/TestExpectations:

9:10 PM Changeset in webkit [219713] by beidson@apple.com

• 23 edits
  5 deletes in trunk/Source/WebKit

Get rid of IconDatabase related code in WebKit.
​https://bugs.webkit.org/show_bug.cgi?id=174693

Reviewed by Tim Horton.

This leaves the C-API class but guts it.

No explanations of the other changes are needed.

• CMakeLists.txt:
• DerivedSources.make:
• Shared/WebProcessCreationParameters.cpp:

(WebKit::WebProcessCreationParameters::encode):
(WebKit::WebProcessCreationParameters::decode):

• Shared/WebProcessCreationParameters.h:
• UIProcess/API/C/WKContext.cpp:

(WKContextGetIconDatabase):
(WKContextSetIconDatabasePath):

• UIProcess/API/C/WKIconDatabase.cpp:

(WKIconDatabaseSetIconDatabaseClient):
(WKIconDatabaseRetainIconForURL):
(WKIconDatabaseReleaseIconForURL):
(WKIconDatabaseSetIconDataForIconURL):
(WKIconDatabaseSetIconURLForPageURL):
(WKIconDatabaseCopyIconURLForPageURL):
(WKIconDatabaseCopyIconDataForPageURL):
(WKIconDatabaseEnableDatabaseCleanup):
(WKIconDatabaseRemoveAllIcons):
(WKIconDatabaseCheckIntegrityBeforeOpening):
(WKIconDatabaseClose):

• UIProcess/API/C/cg/WKIconDatabaseCG.cpp:

(WKIconDatabaseTryGetCGImageForURL):
(WKIconDatabaseTryCopyCGImageArrayForURL):

• UIProcess/Cocoa/WebProcessPoolCocoa.mm:

(WebKit::WebProcessPool::platformDefaultIconDatabasePath): Deleted.

• UIProcess/WebIconDatabase.cpp: Removed.
• UIProcess/WebIconDatabase.h:

(WebKit::WebIconDatabase::clearProcessPool): Deleted.

• UIProcess/WebIconDatabase.messages.in: Removed.
• UIProcess/WebIconDatabaseClient.cpp: Removed.
• UIProcess/WebIconDatabaseClient.h: Removed.
• UIProcess/WebProcessPool.cpp:

(WebKit::m_hiddenPageThrottlingTimer):
(WebKit::WebProcessPool::~WebProcessPool):
(WebKit::WebProcessPool::setAnyPageGroupMightHavePrivateBrowsingEnabled):
(WebKit::WebProcessPool::createNewWebProcess):
(WebKit::WebProcessPool::setIconDatabasePath): Deleted.
(WebKit::WebProcessPool::iconDatabasePath): Deleted.

• UIProcess/WebProcessPool.h:
• UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::processWillShutDown):
(WebKit::WebProcessProxy::retainIconForPageURL): Deleted.
(WebKit::WebProcessProxy::releaseIconForPageURL): Deleted.
(WebKit::WebProcessProxy::releaseRemainingIconsForPageURLs): Deleted.

• UIProcess/WebProcessProxy.h:
• UIProcess/WebProcessProxy.messages.in:
• UIProcess/gtk/WebProcessPoolGtk.cpp:

(WebKit::WebProcessPool::platformDefaultIconDatabasePath): Deleted.

• UIProcess/wpe/WebProcessPoolWPE.cpp:

(WebKit::WebProcessPool::platformDefaultIconDatabasePath): Deleted.

• WebKit.xcodeproj/project.pbxproj:
• WebProcess/IconDatabase/WebIconDatabaseProxy.cpp: Removed.
• WebProcess/IconDatabase/WebIconDatabaseProxy.h: Removed.
• WebProcess/IconDatabase/WebIconDatabaseProxy.messages.in: Removed.
• WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
• WebProcess/WebProcess.cpp:

(WebKit::WebProcess::WebProcess):
(WebKit::WebProcess::initializeWebProcess):
(WebKit::WebProcess::getWebCoreStatistics):

• WebProcess/WebProcess.h:

7:36 PM Changeset in webkit [219712] by Chris Dumez

• 61 edits
  2 adds
  7 deletes in trunk

Drop legacy SVGException type
​https://bugs.webkit.org/show_bug.cgi?id=174695

Reviewed by Darin Adler.

Source/WebCore:

Drop legacy SVGException type and use DOMException instead, as per the latest
SVG specification. Both Chrome and Firefox no longer expose the SVGException
type.

• CMakeLists.txt:
• DerivedSources.cpp:
• DerivedSources.make:
• WebCore.xcodeproj/project.pbxproj:
• bindings/js/JSDOMExceptionHandling.cpp:

(WebCore::createDOMException):

• bindings/js/JSExceptionBase.cpp:

(WebCore::toExceptionBase):

• dom/DOMExceptions.in:
• svg/SVGAllInOne.cpp:
• svg/SVGCircleElement.cpp:
• svg/SVGException.cpp: Removed.
• svg/SVGException.h: Removed.
• svg/SVGException.idl: Removed.
• svg/SVGGraphicsElement.idl:
• svg/SVGLocatable.cpp:

(WebCore::SVGLocatable::getTransformToElement):

• svg/SVGMatrixValue.h:
• svg/SVGPathSegList.cpp:

(WebCore::SVGPathSegList::getItem):
(WebCore::SVGPathSegList::replaceItem):
(WebCore::SVGPathSegList::removeItem):

• svg/SVGPathSegList.h:
• svg/SVGPathSegList.idl:
• svg/properties/SVGAnimatedEnumerationPropertyTearOff.h:
• svg/properties/SVGListProperty.h:

LayoutTests:

Update existing tests to reflect behavior change.

• fast/dom/Window/resources/window-properties.js:
• js/dom/global-constructors-attributes-expected.txt:
• platform/gtk/js/dom/global-constructors-attributes-expected.txt:
• platform/mac-elcapitan/js/dom/global-constructors-attributes-expected.txt:
• platform/mac-highsierra-wk1/js/dom/global-constructors-attributes-expected.txt:
• platform/mac-highsierra/js/dom/global-constructors-attributes-expected.txt:
• platform/mac-wk1/js/dom/global-constructors-attributes-expected.txt:
• platform/mac-yosemite/js/dom/global-constructors-attributes-expected.txt:
• platform/mac/js/dom/global-constructors-attributes-expected.txt:
• platform/win/js/dom/global-constructors-attributes-expected.txt:
• platform/wpe/js/dom/global-constructors-attributes-expected.txt:
• svg/animations/animate-marker-orient-from-angle-to-autostartreverse-expected.txt:
• svg/custom/SVGException-expected.txt: Removed.
• svg/custom/SVGException.html: Removed.
• svg/custom/global-constructors-expected.txt:
• svg/custom/global-constructors.html:
• svg/custom/js-svg-constructors-expected.txt:
• svg/custom/js-svg-constructors.svg:
• svg/dom/SVGAnimatedEnumeration-SVGClipPathElement-expected.txt:
• svg/dom/SVGAnimatedEnumeration-SVGComponentTransferFunctionElement-expected.txt:
• svg/dom/SVGAnimatedEnumeration-SVGFEBlendElement-expected.txt:
• svg/dom/SVGAnimatedEnumeration-SVGFEColorMatrixElement-expected.txt:
• svg/dom/SVGAnimatedEnumeration-SVGFEConvolveMatrixElement-expected.txt:
• svg/dom/SVGAnimatedEnumeration-SVGFEDisplacementMapElement-expected.txt:
• svg/dom/SVGAnimatedEnumeration-SVGFEMorphologyElement-expected.txt:
• svg/dom/SVGAnimatedEnumeration-SVGFETurbulenceElement-expected.txt:
• svg/dom/SVGAnimatedEnumeration-SVGFilterElement-expected.txt:
• svg/dom/SVGAnimatedEnumeration-SVGGradientElement-expected.txt:
• svg/dom/SVGAnimatedEnumeration-SVGMarkerElement-expected.txt:
• svg/dom/SVGAnimatedEnumeration-SVGMaskElement-expected.txt:
• svg/dom/SVGAnimatedEnumeration-SVGPatternElement-expected.txt:
• svg/dom/SVGAnimatedEnumeration-SVGTextContentElement-expected.txt:
• svg/dom/SVGAnimatedEnumeration-SVGTextPathElement-expected.txt:
• svg/dom/SVGAnimatedEnumeration-expected.txt:
• svg/dom/SVGException-obsolete-expected.txt: Added.
• svg/dom/SVGException-obsolete.html: Added.
• svg/dom/SVGMatrix-interface-expected.txt:
• svg/dom/svglist-exception-on-out-bounds-error-expected.txt:
• svg/filters/feBlend-invalid-mode-expected.txt:
• svg/filters/feComponentTransfer-style-crash-expected.txt:
• svg/filters/feDisplacementMap-crash-test-expected.txt:

6:38 PM Changeset in webkit [219711] by Chris Dumez

• 2 edits in trunk/Source/WebCore

Hook up ITP quirks to the needsSiteSpecificQuirks setting
​https://bugs.webkit.org/show_bug.cgi?id=174691

Reviewed by Darin Adler.

Hook up ITP quirks to the needsSiteSpecificQuirks setting to make it easier for
Web-developers to test their fixes.

• loader/ResourceLoadObserver.cpp:

(WebCore::shouldEnableSiteSpecificQuirks):
(WebCore::areDomainsAssociated):
(WebCore::ResourceLoadObserver::logFrameNavigation):
(WebCore::resourceNeedsSSOQuirk):
(WebCore::ResourceLoadObserver::logSubresourceLoading):
(WebCore::ResourceLoadObserver::logWebSocketLoading):

6:23 PM Changeset in webkit [219710] by Matt Lewis

• 10 edits in trunk

Unreviewed, rolling out r219700.

This revision caused consistent timouts on iOS.

Reverted changeset:

"Turn tests at media/modern-media-controls/start-support back
on"
​https://bugs.webkit.org/show_bug.cgi?id=174683
​http://trac.webkit.org/changeset/219700

5:39 PM Changeset in webkit [219709] by commit-queue@webkit.org

• 17 edits in trunk

Add SPI to notify WKNavigationDelegate about client redirects
​https://bugs.webkit.org/show_bug.cgi?id=174680
rdar://problem/33184886

Patch by David Quesada <​david_quesada@apple.com> on 2017-07-20
Reviewed by Brady Eidson.

Source/WebCore:

• loader/FrameLoader.cpp:

(WebCore::FrameLoader::performClientRedirect):

• loader/FrameLoader.h:

Add a convenience method for NavigationScheduler that handles a FrameLoadRequest
as a client redirect. Currently this means loading the request and informing the
client about it.

• loader/FrameLoaderClient.h:

Add FrameLoaderClient::dispatchDidPerformClientRedirect() to inform the client when
a client redirect occurs.

• loader/NavigationScheduler.cpp:

Removed ScheduledURLNavigation::fire(). This class was never instantiated directly,
and all subclasses override fire(), so this was unused code.
For ScheduledRedirects and ScheduledLocationChange, use FrameLoader's new method to
load the request as a client redirect.

Source/WebKit:

• UIProcess/API/APINavigationClient.h:

(API::NavigationClient::didPerformClientRedirectForNavigation):
Add a new virtual method for navigation clients to implement if they want to be informed
when the page is initiating a navigation that is a client redirect.

• UIProcess/API/Cocoa/WKNavigationDelegatePrivate.h:

Declare the new WKNavigationDelegate method -_webView:didPerformClientRedirectForNavigation:

• UIProcess/Cocoa/NavigationState.h:
• UIProcess/Cocoa/NavigationState.mm:

(WebKit::NavigationState::setNavigationDelegate):
(WebKit::NavigationState::NavigationClient::didPerformClientRedirectForNavigation):
Add a new method to NavigationState method to tell the WKNavigationDelegate when a
client redirect happens.

• UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::didPerformClientRedirectForLoadForFrame):

• UIProcess/WebPageProxy.h:
• UIProcess/WebPageProxy.messages.in:

Allow the WebPageProxy to receive a message from the web process when a client redirect happens.

• WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::dispatchDidPerformClientRedirect):

• WebProcess/WebCoreSupport/WebFrameLoaderClient.h:

Send this new message to the UI process on client redirects.

Tools:

• TestWebKitAPI/Tests/WebKit2Cocoa/Navigation.mm:

(-[DidPerformClientRedirectNavigationDelegate _webView:didPerformClientRedirectForNavigation:]):
(TEST):
Add API test for -[id<WKNavigationDelegatePrivate> _webView:didPerformClientRedirectForNavigation:].

4:02 PM Changeset in webkit [219708] by Chris Dumez

• 27 edits
  2 adds
  6 deletes in trunk

Drop legacy XPathException type
​https://bugs.webkit.org/show_bug.cgi?id=174679

Reviewed by Sam Weinig.

Source/WebCore:

Drop legacy XPathException type and use DOMException instead. Both Firefox and Chrome
no longer expose XPathException.

Test: fast/dom/DOMException/XPathException-obsolete.html

• CMakeLists.txt:
• DerivedSources.cpp:
• DerivedSources.make:
• WebCore.xcodeproj/project.pbxproj:
• bindings/js/JSDOMExceptionHandling.cpp:

(WebCore::createDOMException):

• bindings/js/JSExceptionBase.cpp:

(WebCore::toExceptionBase):

• dom/DOMExceptions.in:
• xml/XPathException.cpp: Removed.
• xml/XPathException.h: Removed.
• xml/XPathException.idl: Removed.
• xml/XPathExpression.cpp:

(WebCore::XPathExpression::evaluate):

• xml/XPathParser.cpp:

(WebCore::XPath::Parser::parseStatement):

• xml/XPathResult.cpp:

(WebCore::XPathResult::convertTo):
(WebCore::XPathResult::numberValue):
(WebCore::XPathResult::stringValue):
(WebCore::XPathResult::booleanValue):
(WebCore::XPathResult::singleNodeValue):
(WebCore::XPathResult::snapshotLength):
(WebCore::XPathResult::iterateNext):
(WebCore::XPathResult::snapshotItem):

Source/WebKit:

Drop legacy XPathException type and use DOMException instead. Both Firefox and Chrome
no longer expose XPathException.

• UIProcess/Automation/atoms/FindNodes.js:

(tryToFindNode):

Source/WebKitLegacy/mac:

Drop legacy XPathException type and use DOMException instead. Both Firefox and Chrome
no longer expose XPathException.

• DOM/ExceptionHandlers.mm:

(raiseDOMErrorException):

LayoutTests:

Update existing tests to reflect behavior change.

• dom/svg/level3/xpath/XPathEvaluator_createExpression_INVALID_EXPRESSION_ERR.js:

(XPathEvaluator_createExpression_INVALID_EXPRESSION_ERR):

• dom/svg/level3/xpath/XPathEvaluator_evaluate_INVALID_EXPRESSION_ERR.js:

(XPathEvaluator_evaluate_INVALID_EXPRESSION_ERR):

• dom/svg/level3/xpath/XPathEvaluator_evaluate_TYPE_ERR.js:

(XPathEvaluator_evaluate_TYPE_ERR):

• dom/svg/level3/xpath/XPathResult_TYPE_ERR.js:

(XPathResult_TYPE_ERR):

• fast/dom/DOMException/XPathException-expected.txt: Removed.
• fast/dom/DOMException/XPathException.html: Removed.
• fast/dom/DOMException/resources/XPathException.js: Removed.
• fast/dom/Window/resources/window-properties.js:
• fast/dom/Window/window-lookup-precedence-expected.txt:
• fast/xpath/4XPath/Core/test_parser-expected.txt:
• fast/xpath/invalid-functions-expected.txt:
• fast/xpath/py-dom-xpath/expressions-expected.txt:
• platform/gtk/fast/dom/Window/window-lookup-precedence-expected.txt:
• platform/mac/fast/dom/Window/window-lookup-precedence-expected.txt:

3:45 PM Changeset in webkit [219707] by Chris Dumez

• 28 edits
  7 adds
  2 deletes in trunk

Unreviewed, rolling out r219706.

Broke iOS build

Reverted changeset:

"Drop legacy XPathException type"
​https://bugs.webkit.org/show_bug.cgi?id=174679
​http://trac.webkit.org/changeset/219706

3:03 PM Changeset in webkit [219706] by Chris Dumez

• 28 edits
  2 adds
  6 deletes in trunk

Drop legacy XPathException type
​https://bugs.webkit.org/show_bug.cgi?id=174679

Reviewed by Sam Weinig.

Source/WebCore:

Drop legacy XPathException type and use DOMException instead. Both Firefox and Chrome
no longer expose XPathException.

Test: fast/dom/DOMException/XPathException-obsolete.html

• CMakeLists.txt:
• DerivedSources.cpp:
• DerivedSources.make:
• WebCore.xcodeproj/project.pbxproj:
• bindings/js/JSDOMExceptionHandling.cpp:

(WebCore::createDOMException):

• bindings/js/JSExceptionBase.cpp:

(WebCore::toExceptionBase):

• dom/DOMExceptions.in:
• xml/XPathException.cpp: Removed.
• xml/XPathException.h: Removed.
• xml/XPathException.idl: Removed.
• xml/XPathExpression.cpp:

(WebCore::XPathExpression::evaluate):

• xml/XPathParser.cpp:

(WebCore::XPath::Parser::parseStatement):

• xml/XPathResult.cpp:

(WebCore::XPathResult::convertTo):
(WebCore::XPathResult::numberValue):
(WebCore::XPathResult::stringValue):
(WebCore::XPathResult::booleanValue):
(WebCore::XPathResult::singleNodeValue):
(WebCore::XPathResult::snapshotLength):
(WebCore::XPathResult::iterateNext):
(WebCore::XPathResult::snapshotItem):

Source/WebKit:

Drop legacy XPathException type and use DOMException instead. Both Firefox and Chrome
no longer expose XPathException.

• UIProcess/Automation/atoms/FindNodes.js:

(tryToFindNode):

Source/WebKitLegacy/mac:

Drop legacy XPathException type and use DOMException instead. Both Firefox and Chrome
no longer expose XPathException.

• DOM/ExceptionHandlers.mm:

(raiseDOMErrorException):

• WebKit.exp:

LayoutTests:

Update existing tests to reflect behavior change.

• dom/svg/level3/xpath/XPathEvaluator_createExpression_INVALID_EXPRESSION_ERR.js:

(XPathEvaluator_createExpression_INVALID_EXPRESSION_ERR):

• dom/svg/level3/xpath/XPathEvaluator_evaluate_INVALID_EXPRESSION_ERR.js:

(XPathEvaluator_evaluate_INVALID_EXPRESSION_ERR):

• dom/svg/level3/xpath/XPathEvaluator_evaluate_TYPE_ERR.js:

(XPathEvaluator_evaluate_TYPE_ERR):

• dom/svg/level3/xpath/XPathResult_TYPE_ERR.js:

(XPathResult_TYPE_ERR):

• fast/dom/DOMException/XPathException-expected.txt: Removed.
• fast/dom/DOMException/XPathException.html: Removed.
• fast/dom/DOMException/resources/XPathException.js: Removed.
• fast/dom/Window/resources/window-properties.js:
• fast/dom/Window/window-lookup-precedence-expected.txt:
• fast/xpath/4XPath/Core/test_parser-expected.txt:
• fast/xpath/invalid-functions-expected.txt:
• fast/xpath/py-dom-xpath/expressions-expected.txt:
• platform/gtk/fast/dom/Window/window-lookup-precedence-expected.txt:
• platform/mac/fast/dom/Window/window-lookup-precedence-expected.txt:

2:09 PM Changeset in webkit [219705] by Chris Dumez

• 4 edits in trunk/Source/WebKit

Avoid unnecessary WorkQueue dispatch in WebResourceLoadStatisticsStore::processStatisticsAndDataRecords()
​https://bugs.webkit.org/show_bug.cgi?id=174686

Reviewed by Geoffrey Garen.

Avoid unnecessary WorkQueue dispatch in WebResourceLoadStatisticsStore::processStatisticsAndDataRecords(). The most common
call site is already on the right thread.

• UIProcess/API/Cocoa/WKWebsiteDataStore.mm:

(-[WKWebsiteDataStore _resourceLoadStatisticsProcessStatisticsAndDataRecords]):

• UIProcess/WebResourceLoadStatisticsStore.cpp:

(WebKit::WebResourceLoadStatisticsStore::scheduleStatisticsAndDataRecordsProcessing):
(WebKit::WebResourceLoadStatisticsStore::processStatisticsAndDataRecords):

• UIProcess/WebResourceLoadStatisticsStore.h:

2:09 PM Changeset in webkit [219704] by Matt Lewis

• 2 edits in trunk/LayoutTests

Rebaselined svg/css/getComputedStyle-basic.xhtml.

Unreviewed test gardening.

• platform/mac-highsierra/svg/css/getComputedStyle-basic-expected.txt:

2:08 PM Changeset in webkit [219703] by Chris Dumez

• 4 edits in trunk/Source

Regression(ITP): May get frequently logged out of wsj.com
​https://bugs.webkit.org/show_bug.cgi?id=174661
<rdar://problem/32343256>

Reviewed by Geoffrey Garen.

Source/WebCore:

Add the concept of associated domains in the ResourceLoadObserver. We
previously ignore loads to and from the same domains. We now do the same
if the to and from domains are associated (i.e. owned by the same entity).

For now, only add domains owned by Dow Jones & Company, Inc. to the list,
to address login issues on wsj.com.

No new tests, verified manually on wsj.com.

• loader/ResourceLoadObserver.cpp:

(WebCore::areDomainsAssociated):
(WebCore::ResourceLoadObserver::logFrameNavigation):
(WebCore::ResourceLoadObserver::logSubresourceLoading):
(WebCore::ResourceLoadObserver::logWebSocketLoading):

Source/WebKit:

Bump statistics file version to blow away old statistics on disk since those do not
take into account associated domains.

• UIProcess/WebResourceLoadStatisticsStore.cpp:

2:06 PM Changeset in webkit [219702] by Chris Dumez

• 78 edits in trunk/Source

Replace calls to Vector::resize() with calls to more efficient shrink() / grow() when applicable
​https://bugs.webkit.org/show_bug.cgi?id=174660

Reviewed by Geoffrey Garen.

Replace calls to Vector::resize() with calls to more efficient shrink() / grow() when applicable.
This essentially replaces a branch to figure out if the new size is less or greater than the
current size by an assertion.

Source/bmalloc:

• bmalloc/Map.h:

(bmalloc::Hash>::rehash):

Source/JavaScriptCore:

• b3/B3BasicBlockUtils.h:

(JSC::B3::clearPredecessors):

• b3/B3InferSwitches.cpp:
• b3/B3LowerToAir.cpp:

(JSC::B3::Air::LowerToAir::finishAppendingInstructions):

• b3/B3ReduceStrength.cpp:
• b3/B3SparseCollection.h:

(JSC::B3::SparseCollection::packIndices):

• b3/B3UseCounts.cpp:

(JSC::B3::UseCounts::UseCounts):

• b3/air/AirAllocateRegistersAndStackByLinearScan.cpp:
• b3/air/AirEmitShuffle.cpp:

(JSC::B3::Air::emitShuffle):

• b3/air/AirLowerAfterRegAlloc.cpp:

(JSC::B3::Air::lowerAfterRegAlloc):

• b3/air/AirOptimizeBlockOrder.cpp:

(JSC::B3::Air::optimizeBlockOrder):

• bytecode/Operands.h:

(JSC::Operands::ensureLocals):

• bytecode/PreciseJumpTargets.cpp:

(JSC::computePreciseJumpTargetsInternal):

• dfg/DFGBlockInsertionSet.cpp:

(JSC::DFG::BlockInsertionSet::execute):

• dfg/DFGBlockMapInlines.h:

(JSC::DFG::BlockMap<T>::BlockMap):

• dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::processSetLocalQueue):
(JSC::DFG::ByteCodeParser::clearCaches):

• dfg/DFGDisassembler.cpp:

(JSC::DFG::Disassembler::Disassembler):

• dfg/DFGFlowIndexing.cpp:

(JSC::DFG::FlowIndexing::recompute):

• dfg/DFGGraph.cpp:

(JSC::DFG::Graph::registerFrozenValues):

• dfg/DFGInPlaceAbstractState.cpp:

(JSC::DFG::setLiveValues):

• dfg/DFGLICMPhase.cpp:

(JSC::DFG::LICMPhase::run):

• dfg/DFGLivenessAnalysisPhase.cpp:
• dfg/DFGNaturalLoops.cpp:

(JSC::DFG::NaturalLoops::NaturalLoops):

• dfg/DFGStoreBarrierClusteringPhase.cpp:
• ftl/FTLLowerDFGToB3.cpp:

(JSC::FTL::DFG::LowerDFGToB3::compileNode):

• heap/CodeBlockSet.cpp:

(JSC::CodeBlockSet::deleteUnmarkedAndUnreferenced):

• heap/MarkedSpace.cpp:

(JSC::MarkedSpace::sweepLargeAllocations):

• inspector/ContentSearchUtilities.cpp:

(Inspector::ContentSearchUtilities::findMagicComment):

• interpreter/ShadowChicken.cpp:

(JSC::ShadowChicken::update):

• parser/ASTBuilder.h:

(JSC::ASTBuilder::shrinkOperandStackBy):

• parser/Lexer.h:

(JSC::Lexer::setOffset):

• runtime/RegExpInlines.h:

(JSC::RegExp::matchInline):

• runtime/RegExpPrototype.cpp:

(JSC::genericSplit):

• yarr/RegularExpression.cpp:

(JSC::Yarr::RegularExpression::match):

Source/WebCore:

• Modules/gamepad/Gamepad.cpp:

(WebCore::Gamepad::Gamepad):

• Modules/webaudio/AudioContext.cpp:

(WebCore::AudioContext::addReaction):

• Modules/websockets/WebSocketChannel.cpp:

(WebCore::WebSocketChannel::skipBuffer):

• Modules/websockets/WebSocketDeflater.cpp:

(WebCore::WebSocketDeflater::finish):

• contentextensions/ContentExtensionCompiler.cpp:

(WebCore::ContentExtensions::serializeSelector):

• contentextensions/DFABytecodeCompiler.cpp:

(WebCore::ContentExtensions::append):

• crypto/gcrypt/CryptoAlgorithmAES_CBCGCrypt.cpp:

(WebCore::gcryptEncrypt):
(WebCore::gcryptDecrypt):

• crypto/gcrypt/CryptoAlgorithmECDHGCrypt.cpp:

(WebCore::gcryptDerive):

• platform/gamepad/cocoa/GameControllerGamepadProvider.mm:

(WebCore::GameControllerGamepadProvider::controllerDidConnect):

• platform/gamepad/mac/HIDGamepadProvider.cpp:

(WebCore::HIDGamepadProvider::deviceAdded):

• platform/graphics/ImageBackingStore.h:

(WebCore::ImageBackingStore::setSize):

• platform/graphics/WOFFFileFormat.cpp:
• platform/graphics/avfoundation/InbandMetadataTextTrackPrivateAVF.cpp:

(WebCore::InbandMetadataTextTrackPrivateAVF::updatePendingCueEndTimes):
(WebCore::InbandMetadataTextTrackPrivateAVF::flushPartialCues):

• platform/graphics/avfoundation/InbandTextTrackPrivateAVF.cpp:

(WebCore::InbandTextTrackPrivateAVF::resetCueValues):
(WebCore::InbandTextTrackPrivateAVF::readNativeSampleBuffer):

• platform/graphics/avfoundation/cf/InbandTextTrackPrivateAVCF.cpp:

(WebCore::InbandTextTrackPrivateAVCF::readNativeSampleBuffer):

• platform/graphics/cg/ImageBufferCG.cpp:

(WebCore::cfData):

• platform/image-decoders/bmp/BMPImageDecoder.cpp:

(WebCore::BMPImageDecoder::frameBufferAtIndex):

• platform/image-decoders/ico/ICOImageDecoder.cpp:

(WebCore::ICOImageDecoder::decode):

• platform/image-decoders/jpeg/JPEGImageDecoder.cpp:

(WebCore::JPEGImageDecoder::frameBufferAtIndex):

• platform/image-decoders/png/PNGImageDecoder.cpp:

(WebCore::PNGImageDecoder::frameBufferAtIndex):
(WebCore::PNGImageDecoder::readChunks):

• platform/image-decoders/webp/WEBPImageDecoder.cpp:

(WebCore::WEBPImageDecoder::frameBufferAtIndex):

• platform/image-encoders/JPEGImageEncoder.cpp:

(WebCore::compressRGBABigEndianToJPEG):

• platform/text/DecodeEscapeSequences.h:

(WebCore::URLEscapeSequence::decodeRun):

• platform/text/SuffixTree.h:

(WebCore::SuffixTree::Node::Node):

• rendering/Grid.cpp:

(WebCore::Grid::setNeedsItemsPlacement):

• rendering/RenderTable.cpp:

(WebCore::RenderTable::invalidateCachedColumns):

Source/WebKit:

• Platform/IPC/ArgumentCoders.h:
• UIProcess/Gamepad/UIGamepadProvider.cpp:

(WebKit::UIGamepadProvider::platformGamepadConnected):

• UIProcess/WebProcessPool.cpp:

(WebKit::WebProcessPool::setInitialConnectedGamepads):

• WebProcess/Network/WebLoaderStrategy.cpp:

(WebKit::WebLoaderStrategy::loadResourceSynchronously):

• WebProcess/WebCoreSupport/WebPasteboardOverrides.cpp:

(WebKit::WebPasteboardOverrides::getDataForOverride):

• WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::requestAutocorrectionData):

Source/WebKitLegacy/mac:

• Plugins/WebNetscapePluginView.mm:

(-[WebNetscapePluginView saveAndSetNewPortStateForUpdate:]):

Source/WTF:

• wtf/IndexSparseSet.h:

(WTF::OverflowHandler>::IndexSparseSet):
(WTF::OverflowHandler>::clear):

• wtf/Insertion.h:

(WTF::executeInsertions):

• wtf/RangeSet.h:

(WTF::RangeSet::compact):

• wtf/Vector.h:

(WTF::removeRepeatedElements):

• wtf/persistence/Coders.h:

1:52 PM Changeset in webkit [219701] by Chris Dumez

• 4 edits in trunk/Source

Regression(ITP): Can no longer log in on abc.go.com
​https://bugs.webkit.org/show_bug.cgi?id=174533
<rdar://problem/33325881>

Reviewed by Geoffrey Garen.

Source/WebCore:

Add quirk for sp.auth.adobe.com which is used for SSO by web sites such as
abc.go.com. This would otherwise cause adobe.com to be identified as a
tracker and log in on abc.go.com would break.

No new tests, tested manually on abc.go.com.

• loader/ResourceLoadObserver.cpp:

(WebCore::resourceNeedsSSOQuirk):
(WebCore::ResourceLoadObserver::logSubresourceLoading):

Source/WebKit:

Bump statistics database version to blow away any existing statistics. Without this, SSO providers
for which we added a quirk may already be in the database and identified as trackers. The quirk
merely prevents the specified SSO providers from being identified as trackers.

• UIProcess/WebResourceLoadStatisticsStore.cpp:

1:47 PM Changeset in webkit [219700] by commit-queue@webkit.org

• 10 edits in trunk

Turn tests at media/modern-media-controls/start-support back on
​https://bugs.webkit.org/show_bug.cgi?id=174683

Patch by Antoine Quint <Antoine Quint> on 2017-07-20
Reviewed by Dean Jackson.

Source/WebCore:

Turning those tests back on revealed a small bug that is unlikely to really affect content
on the Web. In the case where the size of the video is known right away, without the need
for loading its metadata, as is the case in the start-support-click-to-start.html test with
a local media resource, all queued layouts are flushed at once and we may call the layout()
method of the left ButtonsContainer which originally is set to contain the play/pause button,
which would remove the play/pause button from the center of the media. So before we potentially
set the play/pause button as the central button, we first assign the default button set for
the two ButtonsContainer instances and only add the play/pause button when we're not showing
the prominent play/pause button.

• Modules/modern-media-controls/controls/inline-media-controls.js:

(InlineMediaControls.prototype.layout):
(InlineMediaControls.prototype._leftContainerButtons):

LayoutTests:

• media/modern-media-controls/start-support/start-support-click-to-start-expected.txt:
• media/modern-media-controls/start-support/start-support-click-to-start.html:
• media/modern-media-controls/start-support/start-support-fullscreen.html:
• media/modern-media-controls/start-support/start-support-lowPowerMode-expected.txt:
• media/modern-media-controls/start-support/start-support-lowPowerMode.html:
• platform/ios-simulator/TestExpectations:
• platform/mac/TestExpectations:

1:35 PM Changeset in webkit [219699] by Chris Dumez

• 12 edits
  3 deletes in trunk

Drop legacy FileException type
​https://bugs.webkit.org/show_bug.cgi?id=174676

Reviewed by Alex Christensen.

Drop legacy FileException type and use DOMException instead, as per the latest
File API specification:

• ​https://w3c.github.io/FileAPI/#ErrorAndException

Both Firefox and Chrome no longer expose FileException.

• CMakeLists.txt:
• DerivedSources.cpp:
• DerivedSources.make:
• WebCore.xcodeproj/project.pbxproj:
• bindings/js/JSDOMExceptionHandling.cpp:

(WebCore::createDOMException):

• dom/DOMExceptions.in:
• fileapi/FileException.cpp: Removed.
• fileapi/FileException.h: Removed.
• fileapi/FileException.idl: Removed.
• fileapi/FileReaderLoader.cpp:

(WebCore::FileReaderLoader::FileReaderLoader):
(WebCore::FileReaderLoader::failed):

• fileapi/FileReaderLoader.h:

(WebCore::FileReaderLoader::errorCode):

• fileapi/FileReaderSync.cpp:

(WebCore::errorCodeToExceptionCode):
(WebCore::FileReaderSync::startLoading):

1:34 PM Changeset in webkit [219698] by beidson@apple.com

• 2 edits in trunk/Tools

Test WebKit2CustomProtocolsTest.ProcessPoolDestroyedDuringLoading added in r219664 fails on El Capitan.
​https://bugs.webkit.org/show_bug.cgi?id=174685

Reviewed by Andy Estes.

• TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm:

(TestWebKitAPI::TEST): Use a scoped AutodrainedPool instead of a RetainPtr<NSAutoreleasePool>.

12:06 PM Changeset in webkit [219697] by Matt Lewis

• 2 edits in trunk/LayoutTests

Marked media/modern-media-controls/scrubber-support/scrubber-support-drag.html as flaky
​https://bugs.webkit.org/show_bug.cgi?id=174682

Unreviewed test gardening.

• platform/mac/TestExpectations:

11:32 AM Changeset in webkit [219696] by Yusuke Suzuki

• 10 edits in trunk/Source

[WTF] Use ThreadGroup to bookkeep active threads for Mach exception
​https://bugs.webkit.org/show_bug.cgi?id=174678

Reviewed by Mark Lam.

Source/JavaScriptCore:

Use Thread& instead.

• runtime/JSLock.cpp:

(JSC::JSLock::didAcquireLock):

Source/WTF:

We can use ThreadGroup to bookkeep active threads for Mach exceptions.
When the thread dies, it is automatically removed from the thread groups.
So we do not need to call unregisterThreadForMachExceptionHandling.

• wtf/ThreadGroup.cpp:

(WTF::ThreadGroup::~ThreadGroup):
(WTF::ThreadGroup::add):

• wtf/ThreadGroup.h:
• wtf/ThreadHolder.cpp:

(WTF::ThreadHolder::~ThreadHolder):

• wtf/Threading.cpp:

(WTF::Thread::addToThreadGroup):
(WTF::Thread::removeFromThreadGroup):

• wtf/Threading.h:
• wtf/threads/Signals.cpp:

(WTF::setExceptionPorts):
(WTF::activeThreads):
(WTF::registerThreadForMachExceptionHandling):
(WTF::installSignalHandler):
(WTF::unregisterThreadForMachExceptionHandling): Deleted.

• wtf/threads/Signals.h:

11:07 AM Changeset in webkit [219695] by beidson@apple.com

• 11 edits
  3 deletes in trunk

Deprecate WebIconDatabase in WebKitLegacy/mac.
​https://bugs.webkit.org/show_bug.cgi?id=174607

Reviewed by Alex Christensen.

Source/WebKitLegacy/mac:

This patch:
1 - Formally deprecates WebIconDatabase (which was never API anyways)
2 - Guts the class to where it can only return the default icon at the small size
3 - Reworks other parts of WebKitLegacy that used it for anything to either

use something else or to not do anything.

This patch *could* go much farther. A future patch is what will remove WebCore/IconDatabase
and that patch will remove all of the last remnants of WebIconDatabase.

• History/WebHistoryItem.mm:

(-[WebHistoryItem icon]):

• Misc/WebIconDatabase.h:
• Misc/WebIconDatabase.mm:

(-[WebIconDatabase init]):
(-[WebIconDatabase iconForURL:withSize:cache:]):
(-[WebIconDatabase iconForURL:withSize:]):
(-[WebIconDatabase defaultIconWithSize:]):
(-[WebIconDatabase defaultIconForURL:withSize:]):
(-[WebIconDatabase iconURLForURL:]):
(-[WebIconDatabase retainIconForURL:]):
(-[WebIconDatabase releaseIconForURL:]):
(+[WebIconDatabase delayDatabaseCleanup]):
(+[WebIconDatabase allowDatabaseCleanup]):
(-[WebIconDatabase setDelegate:]):
(-[WebIconDatabase delegate]):
(+[WebIconDatabase initialize]): Deleted.
(-[WebIconDatabase isEnabled]): Deleted.
(-[WebIconDatabase setEnabled:]): Deleted.
(-[WebIconDatabase removeAllIcons]): Deleted.
(+[WebIconDatabase _checkIntegrityBeforeOpening]): Deleted.
(-[WebIconDatabase _sendNotificationForURL:]): Deleted.
(-[WebIconDatabase _sendDidRemoveAllIconsNotification]): Deleted.
(-[WebIconDatabase _startUpIconDatabase]): Deleted.
(-[WebIconDatabase _shutDownIconDatabase]): Deleted.
(-[WebIconDatabase _applicationWillTerminate:]): Deleted.
(-[WebIconDatabase _iconForFileURL:withSize:]): Deleted.
(-[WebIconDatabase _resetCachedWebPreferences:]): Deleted.
(-[WebIconDatabase _largestIconFromDictionary:]): Deleted.
(-[WebIconDatabase _iconsBySplittingRepresentationsOfIcon:]): Deleted.
(-[WebIconDatabase _iconFromDictionary:forSize:cache:]): Deleted.
(-[WebIconDatabase _scaleIcon:toSize:]): Deleted.
(-[WebIconDatabase _databaseDirectory]): Deleted.
(webGetNSImage): Deleted.

• Misc/WebIconDatabaseDelegate.h: Removed.
• Misc/WebIconDatabaseInternal.h: Removed.
• Misc/WebIconDatabasePrivate.h: Removed.

• WebCoreSupport/WebFrameLoaderClient.mm:

(webGetNSImage):

• WebCoreSupport/WebIconDatabaseClient.mm:

(WebIconDatabaseClient::didRemoveAllIcons):
(WebIconDatabaseClient::didImportIconURLForPageURL):

• WebView/WebView.mm:

(-[WebView setFrameLoadDelegate:]):
(-[WebView mainFrameIcon]):

Tools:

• DumpRenderTree/mac/TestRunnerMac.mm:

10:45 AM Changeset in webkit [219694] by Chris Dumez

• 11 edits in trunk/LayoutTests

Unreviewed, rebaseline test on all platforms after r219673.

• js/dom/global-constructors-attributes-expected.txt:
• platform/gtk/js/dom/global-constructors-attributes-expected.txt:
• platform/mac-elcapitan/js/dom/global-constructors-attributes-expected.txt:
• platform/mac-highsierra-wk1/js/dom/global-constructors-attributes-expected.txt:
• platform/mac-highsierra/js/dom/global-constructors-attributes-expected.txt:
• platform/mac-wk1/js/dom/global-constructors-attributes-expected.txt:
• platform/mac-yosemite/js/dom/global-constructors-attributes-expected.txt:
• platform/mac/js/dom/global-constructors-attributes-expected.txt:
• platform/win/js/dom/global-constructors-attributes-expected.txt:
• platform/wpe/js/dom/global-constructors-attributes-expected.txt:

10:18 AM Changeset in webkit [219693] by jiewen_tan@apple.com

• 1 edit
  1 add in trunk/Websites/webkit.org

Unreviewed, add the final demo page for a WebCrypto API blog post

• demos/webcrypto/pbkdf2.html: Added.

10:00 AM Changeset in webkit [219692] by Chris Dumez

• 2 edits in trunk/LayoutTests/imported/w3c

Unreviewed, rebaseline test after r219663.

• web-platform-tests/WebCryptoAPI/import_export/test_rsa_importKey.https-expected.txt:

9:58 AM Changeset in webkit [219691] by commit-queue@webkit.org

• 7 edits
  1 delete in trunk/Source/WebCore

[WebIDL] Remove custom bindings for InspectorFrontendHost
​https://bugs.webkit.org/show_bug.cgi?id=174659

Patch by Sam Weinig <​sam@webkit.org> on 2017-07-20
Reviewed by Chris Dumez.

• CMakeLists.txt:
• WebCore.xcodeproj/project.pbxproj:
• bindings/js/JSBindingsAllInOne.cpp:
• bindings/js/JSInspectorFrontendHostCustom.cpp: Removed.

Remove JSInspectorFrontendHostCustom.cpp.

• inspector/InspectorFrontendHost.cpp:

(WebCore::populateContextMenu):
(WebCore::InspectorFrontendHost::showContextMenu):

• inspector/InspectorFrontendHost.h:
• inspector/InspectorFrontendHost.idl:

Re-implement showContextMenu by using an IDL defined ContextMenuItem dictionary
and converting from that to a WebCore::ContextMenu in the implementation.

9:42 AM Changeset in webkit [219690] by jiewen_tan@apple.com

• 2 edits
  3 adds in trunk/Websites/webkit.org

Unreviewed, add yet another demo page for a WebCrypto API blog post

• demos/webcrypto/aes-gcm.html:
• demos/webcrypto/alice.png: Added.
• demos/webcrypto/bob.png: Added.
• demos/webcrypto/ecdh.html: Added.

9:33 AM Changeset in webkit [219689] by Jonathan Bedard

• 3 edits in trunk/Tools

lint-test-expectations should be run during style checking
​https://bugs.webkit.org/show_bug.cgi?id=173559
<rdar://problem/32854941>

Reviewed by Aakash Jain.

• Scripts/webkitpy/layout_tests/models/test_expectations.py:

(TestExpectationsModel._already_seen_better_match): Append returns 'None' when successful,
prevents identifying errors on specific lines in a file.

• Scripts/webkitpy/style/main_unittest.py:

(ExpectationLinterInStyleCheckerTest.test_linter_duplicate_line_edit_in_file): Test for the
case where a linter error is in the file modified, but the line modified is not related to
the linter error.

8:59 AM Changeset in webkit [219688] by commit-queue@webkit.org

• 4 edits in trunk

[GTK] Layout Test http/tests/media/hls/hls-progress.html is failing
​https://bugs.webkit.org/show_bug.cgi?id=141469

Patch by Charlie Turner <​cturner@igalia.com> on 2017-07-20
Reviewed by Xabier Rodriguez-Calvar.

Source/WebCore:

A work-around for getting progress information in a timely manner from
live pipelines. We cannot rely on getting BUFFERING messages within
the stalled time window (3s), so we have to poll for progress
information somehow.

Makes the following pass reliably

http/tests/media/hls/hls-audio-tracks-has-audio.html passed unexpectedly
http/tests/media/hls/hls-audio-tracks.html passed unexpectedly
http/tests/media/hls/hls-progress.html passed unexpectedly

• platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:

(WebCore::findHLSQueue):
(WebCore::isHLSProgressing):
(WebCore::MediaPlayerPrivateGStreamer::fillTimerFired):

LayoutTests:

Fixes the removed tests.

• platform/gtk/TestExpectations:

8:48 AM Changeset in webkit [219687] by Michael Catanzaro

• 2 edits in trunk/LayoutTests

Unreviewed GTK test gardening

• platform/gtk/TestExpectations:

8:46 AM Changeset in webkit [219686] by jiewen_tan@apple.com

• 2 edits
  2 adds in trunk/Websites/webkit.org

Unreviewed, add another demo page for a WebCrypto API blog post

• demos/webcrypto/aes-gcm.html: Added.
• demos/webcrypto/asynchronous-execution.html:
• demos/webcrypto/common.js: Added.

7:37 AM Changeset in webkit [219685] by akling@apple.com

• 5 edits in trunk/Source/WebCore

Minor Node->Element type tightening fixes
​https://bugs.webkit.org/show_bug.cgi?id=174651

Reviewed by Sam Weinig.

Tighten up some Node* into Element* or even better, Element&.

• dom/Document.cpp:

(WebCore::acceptsEditingFocus): Take a const Element&.
(WebCore::Document::setFocusedElement):

• editing/Editor.cpp:

(WebCore::Editor::findEventTargetFrom): Return an Element*.
(WebCore::Editor::findEventTargetFromSelection): Ditto.
(WebCore::Editor::pasteAsPlainText):
(WebCore::Editor::pasteAsFragment):
(WebCore::Editor::dispatchCPPEvent):

• editing/Editor.h:
• page/DragController.cpp:

(WebCore::DragController::dispatchTextInputEventFor):

7:30 AM Changeset in webkit [219684] by beidson@apple.com

• 12 edits
  3 deletes in trunk

Remove WebIconDatabase from WebKitLegacy/win.
​https://bugs.webkit.org/show_bug.cgi?id=174608

Reviewed by Alex Christensen.

Source/WebKitLegacy/win:

It is unused.

• ForEachCoClass.h:

• Interfaces/IWebIconDatabase.idl: Removed.

• Interfaces/WebKit.idl:

• WebCoreStatistics.cpp:

(WebCoreStatistics::iconPageURLMappingCount):
(WebCoreStatistics::iconRetainedPageURLCount):
(WebCoreStatistics::iconRecordCount):
(WebCoreStatistics::iconsWithDataCount):

• WebIconDatabase.cpp: Removed.
• WebIconDatabase.h: Removed.
• WebKitClassFactory.cpp:

• WebKitDLL.cpp:

(shutDownWebKit):

• WebKitLogging.h:

• WebView.cpp:

(WebView::close):
(WebView::notifyDidAddIcon):
(WebView::registerForIconNotification):
(WebView::dispatchDidReceiveIconFromWebFrame):
(WebView::onNotify):

Tools:

• DumpRenderTree/win/DumpRenderTree.cpp:

(main):

• DumpRenderTree/win/TestRunnerWin.cpp:

(TestRunner::setIconDatabaseEnabled):

7:28 AM Changeset in webkit [219683] by beidson@apple.com

• 4 edits in trunk/Source/WebCore

WKHTTPCookieStore API tests fail on High Sierra.
<rdar://problem/33410271> and ​https://bugs.webkit.org/show_bug.cgi?id=174666

Reviewed by Andy Estes.

Covered by existing API tests.

In r219567 I'd moved cookie storage observation off of NSHTTPCookieStorage and NSNotificationCenter
to CFHTTPCookieStorage observation callbacks.

This is because notifications were only sent for the default [NSHTTPCookieStorage sharedHTTPCookieStorage]
and not any of the other ones we keep in flight.

Unfortunately that SPI has been disabled in High Sierra.
Fortunately we found a way we can get non-shared NSHTTPCookieStorages to send notifications that works everywhere.

• platform/network/cocoa/CookieStorageObserver.h:
• platform/network/cocoa/CookieStorageObserver.mm:

(-[WebCookieObserverAdapter initWithObserver:]):
(-[WebCookieObserverAdapter cookiesChangedNotificationHandler:]):
(WebCore::CookieStorageObserver::create):
(WebCore::CookieStorageObserver::CookieStorageObserver):
(WebCore::CookieStorageObserver::~CookieStorageObserver):
(WebCore::CookieStorageObserver::startObserving): Use a trick to call some SPI on non-shared NSHTTPCookieStorages

to get them to send notifications.

(WebCore::CookieStorageObserver::stopObserving):
(WebCore::cookiesChanged): Deleted.

• platform/network/cocoa/NetworkStorageSessionCocoa.mm:

(WebCore::NetworkStorageSession::cookieStorageObserver):

7:25 AM Changeset in webkit [219682] by jiewen_tan@apple.com

• 1 edit
  3 adds in trunk/Websites/webkit.org

Unreviewed, add a demo page for a WebCrypto API blog post

• demos/webcrypto/asynchronous-execution-worker.js: Added.
• demos/webcrypto/asynchronous-execution.html: Added.

6:07 AM Changeset in webkit [219681] by magomez@igalia.com

• 2 edits in trunk/Source/WebCore

[GStreamer] Some layout tests issue "g_mutex_clear() called on uninitialised or locked mutex" and flaky crash in ~MediaPlayerPrivateGStreamerBase
​https://bugs.webkit.org/show_bug.cgi?id=173952

Reviewed by Carlos Garcia Campos.

Adjust MediaPlayerPrivateGStreamerBase to avoid concurrence problems with the GStreamer thread when
destroying the object.

Covered by existent tests.

• platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:

(WebCore::MediaPlayerPrivateGStreamerBase::~MediaPlayerPrivateGStreamerBase):
(WebCore::MediaPlayerPrivateGStreamerBase::repaint):
(WebCore::MediaPlayerPrivateGStreamerBase::cancelRepaint):

5:11 AM Changeset in webkit [219680] by zandobersek@gmail.com

• 2 edits in trunk/Tools

[WPE] Adjust priority of GSource used in WKTR's HeadlessViewBackend
​https://bugs.webkit.org/show_bug.cgi?id=174671

Reviewed by Carlos Garcia Campos.

• WebKitTestRunner/wpe/HeadlessViewBackend.cpp:

(HeadlessViewBackend::HeadlessViewBackend): Use the RunLoopDispatcher
priority for this source in order to have it dispatched on the same
priority as the other WebKit-controlled GSource objects.

2:12 AM WikiStart edited by clopez@igalia.com

(diff)

2:07 AM WPE edited by clopez@igalia.com

(diff)

2:05 AM WPE created by clopez@igalia.com

12:46 AM Changeset in webkit [219679] by zandobersek@gmail.com

• 37 edits in trunk/LayoutTests

Unreviewed WPE gardening. Updating test baselines after r219663.

• platform/wpe/crypto/subtle/aes-cbc-cfb-decrypt-malformed-parameters-expected.txt:
• platform/wpe/crypto/subtle/aes-cbc-cfb-encrypt-malformed-parameters-expected.txt:
• platform/wpe/crypto/subtle/aes-export-key-malformed-parameters-expected.txt:
• platform/wpe/crypto/subtle/aes-generate-key-malformed-parameters-expected.txt:
• platform/wpe/crypto/subtle/aes-import-key-malformed-parameters-expected.txt:
• platform/wpe/crypto/subtle/rsa-generate-key-malformed-parameters-expected.txt:
• platform/wpe/crypto/subtle/rsa-import-key-malformed-parameters-expected.txt:
• platform/wpe/imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-playback-destroy-persistent-license-expected.txt:
• platform/wpe/imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-playback-persistent-license-events-expected.txt:
• platform/wpe/imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-playback-persistent-license-expected.txt:
• platform/wpe/imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-playback-persistent-usage-record-events-expected.txt:
• platform/wpe/imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-playback-persistent-usage-record-expected.txt:
• platform/wpe/imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-playback-retrieve-destroy-persistent-license-expected.txt:
• platform/wpe/imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-playback-retrieve-persistent-license-expected.txt:
• platform/wpe/imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-playback-retrieve-persistent-usage-record-expected.txt:
• platform/wpe/imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-playback-temporary-clear-encrypted-expected.txt:
• platform/wpe/imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-playback-temporary-encrypted-clear-expected.txt:
• platform/wpe/imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-playback-temporary-encrypted-clear-sources-expected.txt:
• platform/wpe/imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-playback-temporary-events-expected.txt:
• platform/wpe/imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-playback-temporary-expected.txt:
• platform/wpe/imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-playback-temporary-multikey-expected.txt:
• platform/wpe/imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-playback-temporary-multikey-sequential-expected.txt:
• platform/wpe/imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-playback-temporary-multikey-sequential-readyState-expected.txt:
• platform/wpe/imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-playback-temporary-multisession-expected.txt:
• platform/wpe/imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-playback-temporary-setMediaKeys-after-src-expected.txt:
• platform/wpe/imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-playback-temporary-setMediaKeys-after-update-expected.txt:
• platform/wpe/imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-playback-temporary-setMediaKeys-immediately-expected.txt:
• platform/wpe/imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-playback-temporary-setMediaKeys-onencrypted-expected.txt:
• platform/wpe/imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-playback-temporary-two-videos-expected.txt:
• platform/wpe/imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-playback-temporary-waitingforkey-expected.txt:
• platform/wpe/imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-requestmediakeysystemaccess-expected.txt:
• platform/wpe/imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-reset-src-after-setmediakeys-expected.txt:
• platform/wpe/imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-setmediakeys-again-after-resetting-src-expected.txt:
• platform/wpe/imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-setmediakeys-multiple-times-with-the-same-mediakeys-expected.txt:
• platform/wpe/imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-unique-origin-expected.txt:
• platform/wpe/imported/w3c/web-platform-tests/encrypted-media/clearkey-not-callable-after-createsession-expected.txt:

Jul 19, 2017:

11:09 PM Changeset in webkit [219678] by zandobersek@gmail.com

• 13 edits
  10 adds
  2 deletes in trunk/Source/WebCore

[EME] Push CDMInstance, CDMPrivate and associated types into the Platform layer
​https://bugs.webkit.org/show_bug.cgi?id=174496

Reviewed by Xabier Rodriguez-Calvar.

Move the CDMInstance and CDMPrivate interfaces into the platform layer, enabling
implementations of specific key systems at that level, as well as integration with
the MediaPlayerPrivate stack without any layering violations.

While the platform layer still uses the WebCore namespace, the two interface files
have now been moved under the platform/encryptedmedia/ directory and out of the
Modules/encryptedmedia/ directory where the Web-facing API implementation resides.

The two interfaces integrated closely with the Web-facing enumerations and
dictionaries: MediaKeyMessageType, MediaKeySessionType, MediaKeyStatus,
MediaKeySystemConfiguration, MediaKeySystemCapability, MediaKeysRequirement
and MediaKeysRestrictions. Definitions of these types are also moved to the
platform layer without any changes (apart from renaming), and the previous
types now alias against the types now located in the platform layer.

No new tests -- no change in behavior.

• CMakeLists.txt:
• Modules/encryptedmedia/CDM.cpp:
• Modules/encryptedmedia/CDM.h:
• Modules/encryptedmedia/MediaKeyMessageType.h:
• Modules/encryptedmedia/MediaKeySessionType.h:
• Modules/encryptedmedia/MediaKeyStatus.h:
• Modules/encryptedmedia/MediaKeySystemAccess.cpp:
• Modules/encryptedmedia/MediaKeySystemAccess.h:
• Modules/encryptedmedia/MediaKeySystemConfiguration.h:
• Modules/encryptedmedia/MediaKeySystemMediaCapability.h:
• Modules/encryptedmedia/MediaKeysRequirement.h:
• Modules/encryptedmedia/MediaKeysRestrictions.h:
• platform/encryptedmedia/CDMInstance.h: Renamed from Source/WebCore/Modules/encryptedmedia/CDMInstance.h.
• platform/encryptedmedia/CDMKeyStatus.h: Copied from Source/WebCore/Modules/encryptedmedia/MediaKeyStatus.h.
• platform/encryptedmedia/CDMKeySystemConfiguration.h: Copied from Source/WebCore/Modules/encryptedmedia/MediaKeySystemConfiguration.h.
• platform/encryptedmedia/CDMMediaCapability.h: Copied from Source/WebCore/Modules/encryptedmedia/MediaKeySystemMediaCapability.h.
• platform/encryptedmedia/CDMMessageType.h: Copied from Source/WebCore/Modules/encryptedmedia/MediaKeyMessageType.h.
• platform/encryptedmedia/CDMPrivate.h: Renamed from Source/WebCore/Modules/encryptedmedia/CDMPrivate.h.
• platform/encryptedmedia/CDMRequirement.h: Copied from Source/WebCore/Modules/encryptedmedia/MediaKeysRequirement.h.
• platform/encryptedmedia/CDMRestrictions.h: Copied from Source/WebCore/Modules/encryptedmedia/MediaKeysRestrictions.h.
• platform/encryptedmedia/CDMSessionType.h: Copied from Source/WebCore/Modules/encryptedmedia/MediaKeySessionType.h.

11:08 PM Changeset in webkit [219677] by zandobersek@gmail.com

• 2 edits in trunk/Source/WebCore

Unreviewed follow-up to r219674.

• page/scrolling/coordinatedgraphics/ScrollingCoordinatorCoordinatedGraphics.cpp:

Remove the AsyncScrollingCoordinator.h header include that was added by accident.

10:57 PM Changeset in webkit [219676] by zandobersek@gmail.com

• 7 edits
  1 add in trunk/Source

[CMake] Clean up Web Crypto build targets
​https://bugs.webkit.org/show_bug.cgi?id=174253

Reviewed by Alex Christensen.

Gather the common WebCrypto source files in CMakeLists.txt, including them
in the build unconditionally and instead relying on ENABLE_SUBTLE_CRYPTO
build guards to exclude the code from compilation if the feature is disabled.

PlatformGTK.cmake, PlatformMac.cmake and PlatformWPE.cmake can then remove
duplicated build targets. PlatformMac.cmake still lists all the Mac-specific
Web Crypto build targets.

PlatformGTK.cmake and PlatformWPE.cmake now include GCrypt.cmake if the
USE_GCRYPT variable is enabled. Both ports at the moment enable that variable
though as they by default leverage a libgcrypt-based CrpytoDigest implementation
in the PAL library.

The new GCrypt.cmake file adds the libgcrypt-specific Web Crypto build targets to
the build and also sets up libgcrypt include directiories and libraries.

No new tests -- no change in behavior.

• CMakeLists.txt:
• PlatformGTK.cmake:
• PlatformMac.cmake:
• PlatformWPE.cmake:
• platform/GCrypt.cmake: Added.

10:46 PM Changeset in webkit [219675] by commit-queue@webkit.org

• 8 edits
  1 delete in trunk/Source/WebCore

[WebIDL] Remove custom bindings for CommandLineAPIHost
​https://bugs.webkit.org/show_bug.cgi?id=174642

Patch by Sam Weinig <​sam@webkit.org> on 2017-07-19
Reviewed by Joseph Pecoraro.

• CMakeLists.txt:
• WebCore.xcodeproj/project.pbxproj:
• bindings/js/JSBindingsAllInOne.cpp:
• bindings/js/JSCommandLineAPIHostCustom.cpp: Removed.

Remove JSCommandLineAPIHostCustom.cpp.

• bindings/js/JSDOMConvertObject.h:

(WebCore::JSConverter<IDLObject>::convert):
Add missing JSConverter specialization for IDLObject.

• inspector/CommandLineAPIHost.cpp:

(WebCore::CommandLineAPIHost::inspect):
(WebCore::listenerEntriesFromListenerInfo):
(WebCore::CommandLineAPIHost::inspectedObject):
(WebCore::CommandLineAPIHost::databaseId):
(WebCore::CommandLineAPIHost::storageId):
(WebCore::CommandLineAPIHost::inspectImpl): Deleted.
(WebCore::CommandLineAPIHost::getEventListenersImpl): Deleted.
(WebCore::CommandLineAPIHost::databaseIdImpl): Deleted.
(WebCore::CommandLineAPIHost::storageIdImpl): Deleted.

• inspector/CommandLineAPIHost.h:
• inspector/CommandLineAPIHost.idl:

Replace custom bindings with modern bindings affordances: dictionaries, records and sequences.

10:43 PM Changeset in webkit [219674] by zandobersek@gmail.com

• 2 edits in trunk/Source/WebCore

Unreviewed CoordGraphics build fix.

• page/scrolling/coordinatedgraphics/ScrollingCoordinatorCoordinatedGraphics.cpp:

(WebCore::ScrollingCoordinatorCoordinatedGraphics::updateNodeViewportConstraints):
This should be defined for the ScrollingCoordinatorCoordinatedGraphics class.
Also fix the setFixedToViewport() call, fishing out the GraphicsLayer object from
the ScrollingStateNode's LayerRepresentation.
(WebCore::AsyncScrollingCoordinator::updateNodeViewportConstraints): Deleted.

10:23 PM Changeset in webkit [219673] by Chris Dumez

• 11 edits
  3 deletes in trunk/Source

Drop SQLException type
​https://bugs.webkit.org/show_bug.cgi?id=174665

Reviewed by Sam Weinig.

Source/WebCore:

Drop SQLException type. We never throw such exception. Also, Firefox
and Chrome no longer expose this type.

• CMakeLists.txt:
• DerivedSources.cpp:
• DerivedSources.make:
• Modules/webdatabase/SQLException.cpp: Removed.
• Modules/webdatabase/SQLException.h: Removed.
• Modules/webdatabase/SQLException.idl: Removed.
• WebCore.xcodeproj/project.pbxproj:
• bindings/js/JSDOMExceptionHandling.cpp:

(WebCore::createDOMException):

• bindings/js/JSExceptionBase.cpp:

(WebCore::toExceptionBase):

• dom/DOMExceptions.in:

Source/WebInspectorUI:

Use SQLError instead of SQLException, this is what the script should really
use here since it is checking the code of an SQLError.

• .eslintrc:
• UserInterface/Models/DatabaseObject.js:

(WebInspector.DatabaseObject.prototype.executeSQL.queryCallback):
(WebInspector.DatabaseObject.prototype.executeSQL):
(WebInspector.DatabaseObject):

8:49 PM Changeset in webkit [219672] by mitz@apple.com

• 7 copies
  1 add in releases/Apple/iOS 10.3.3

Added a tag for iOS 10.3.3.

8:49 PM Changeset in webkit [219671] by mitz@apple.com

• 8 copies
  1 add in releases/Apple/Safari 10.1.2

Added a tag for Safari 10.1.2.

7:14 PM Changeset in webkit [219670] by Wenson Hsieh

• 2 edits in trunk/Source/WebCore

Unreviewed, tweak a comment above TemporarySelectionOptionIgnoreSelectionChanges in Editor.cpp.

The comment references the UI process, but it describes an entity in WebCore. This should have been generalized
to instead refer to the client layer in general (i.e. WebKit1 or WebKit2).

• editing/Editor.h:

5:17 PM Changeset in webkit [219669] by Jonathan Bedard

• 4 edits in trunk/Tools

lint-test-expectations should be run during style checking
​https://bugs.webkit.org/show_bug.cgi?id=173559
<rdar://problem/32854941>

Reviewed by Daniel Bates.

Follow up fix addressing style and a few minor bugs.

• Scripts/webkitpy/layout_tests/models/test_expectations.py:

(TestExpectationParser.init): Use lambda x: x instead of str
(TestExpectationsModel.init): Make lambda x: x the default argument.
(TestExpectationsModel._already_seen_better_match): Use a temporary variable to
reduce the calls of _shorten_filename, fix minor bug in appending the current
expectation's line number instead of the previous ones, clarify treatment of None
in file-to-line-number mapping.
(TestExpectations._report_warnings): Collapse call.

• Scripts/webkitpy/style/checkers/test_expectations.py:

(TestExpectationsChecker.lint_test_expectations):

• Scripts/webkitpy/style/filereader.py: Re-write comment.

(TextFileReader.process_file): Add comment explaining treatment of None in
file-to-line-number mapping.
(TextFileReader.delete_file): Collapse call.

5:15 PM Changeset in webkit [219668] by Simon Fraser

• 28 edits
  1 copy in trunk

getBoundingClientRects not updated for programmatic scrolls
​https://bugs.webkit.org/show_bug.cgi?id=174538
rdar://problem/33049012

Reviewed by Tim Horton.
Source/WebCore:

Baidu.com has two event handlers on its <input>, and both query the input location with getBoundingClientRect()
and the current pageYOffset (via jQuery), then try to scroll the input to the top of the screen. The bug is that
programmatic scrolls did not immediately update the layout viewport rect, so the second call to
getBoundingClientRect() would return stale coordinates, triggering an extra scroll.

To fix this, undo the fix for r219320 which tried to keep getBoundingClientRect() current during unstable scroll
updates by adding a shadow layout viewport rect. Instead, almost always update the layout viewport rect on
FrameView, even during unstable visible rect updates, but not if content insets are being changed interactively,
since changing viewport heights cause problems with bottom-fixed elements. Also, we need to compute a new layout
viewport rect in FrameView::updateLayoutViewport() for programmatic scrolls.

However, always updating the layout viewport triggered issues with the scrolling tree. The scrolling state tree
fossilizes layer positions relative to a specific viewport rect, and that relationship has to be maintained.
There are code paths that recompute fixed/sticky viewport constraints when the layout viewport has changed but
we haven't done layout or recomputed layer positions (e.g. updating viewport-constrained layers via
updateScrollCoordinatedLayersAfterFlush()) and in these cases using a new layout viewport for those computations
results in an inconsistent scrolling tree.

Fix this by not updating scrolling constraints every time we have to re-register scrolling nodes.
updateScrollCoordinatedLayersAfterFlush() only needs to update the layer on the scrolling node (to handle
tiled/non-tiled switches), so make updateScrollCoordinatedLayer() a little more fine-grained, and only update
constraints when we've just computed layer geometry. This allows for different scrolling nodes to have
constraints computed at different times, with different layout viewports, which happens.

Two additional fixes were required to make bottom-fixed bars behave correctly.

First, FrameView::computeLayoutViewportOrigin() had a bug where rounding of half-pixel values would cause it to
fall into the if (visualViewport.height() > layoutViewport.height()) clause, but then fail to clamp for
rubber-banding.

Second, the FrameView::unscaledMaximumScrollPosition() was wrong after zooming on iOS, since it uses visibleSize()
which is affected by page scale on iOS only (and the function wants scale-independent values). Fix with a hack that
should be cleaned up via webkit.org/b/174648.

Tested by existing tests.

• page/FrameView.cpp:

(WebCore::FrameView::computeUpdatedLayoutViewportRect):
(WebCore::FrameView::computeLayoutViewportOrigin):
(WebCore::FrameView::setLayoutViewportOverrideRect):
(WebCore::FrameView::updateLayoutViewport):
(WebCore::FrameView::unscaledMaximumScrollPosition):
(WebCore::FrameView::documentToClientOffset):
(WebCore::FrameView::setUnstableLayoutViewportRect): Deleted.

• page/FrameView.h:
• page/scrolling/AsyncScrollingCoordinator.cpp:

(WebCore::AsyncScrollingCoordinator::updateScrollPositionAfterAsyncScroll):
(WebCore::AsyncScrollingCoordinator::reconcileScrollingState):
(WebCore::AsyncScrollingCoordinator::reconcileViewportConstrainedLayerPositions):
(WebCore::AsyncScrollingCoordinator::updateNodeLayer):
(WebCore::AsyncScrollingCoordinator::updateNodeViewportConstraints):
(WebCore::AsyncScrollingCoordinator::updateViewportConstrainedNode): Deleted.

• page/scrolling/AsyncScrollingCoordinator.h:
• page/scrolling/ScrollingCoordinator.cpp:

(WebCore::operator<<):

• page/scrolling/ScrollingCoordinator.h:

(WebCore::ScrollingCoordinator::reconcileScrollingState):
(WebCore::ScrollingCoordinator::updateNodeLayer):
(WebCore::ScrollingCoordinator::updateNodeViewportConstraints):
(WebCore::ScrollingCoordinator::updateViewportConstrainedNode): Deleted.

• page/scrolling/ScrollingStateFixedNode.cpp:

(WebCore::ScrollingStateFixedNode::updateConstraints):

• page/scrolling/ScrollingStateStickyNode.cpp:

(WebCore::ScrollingStateStickyNode::updateConstraints):
(WebCore::ScrollingStateStickyNode::reconcileLayerPositionForViewportRect):

• page/scrolling/ScrollingTree.cpp:

(WebCore::ScrollingTree::commitTreeState):

• page/scrolling/mac/ScrollingTreeFixedNode.mm:

(WebCore::ScrollingTreeFixedNode::updateLayersAfterAncestorChange):

• page/scrolling/mac/ScrollingTreeStickyNode.mm:

(WebCore::ScrollingTreeStickyNode::updateLayersAfterAncestorChange):

• rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::updateGeometry):

• rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::updateScrollCoordinatedLayersAfterFlush):
(WebCore::RenderLayerCompositor::updateBacking):
(WebCore::RenderLayerCompositor::fixedRootBackgroundLayerChanged):
(WebCore::RenderLayerCompositor::requiresCompositingForPosition):
(WebCore::RenderLayerCompositor::updateScrollCoordinatedStatus):
(WebCore::RenderLayerCompositor::computeFixedViewportConstraints):
(WebCore::RenderLayerCompositor::computeStickyViewportConstraints):
(WebCore::RenderLayerCompositor::updateScrollCoordinatedLayer):
(WebCore::RenderLayerCompositor::didAddScrollingLayer):

• rendering/RenderLayerCompositor.h:

Source/WebKit:

Feed ViewportRectStability and ScrollingLayerPositionAction into reconcileScrollingState().

• WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::updateVisibleContentRects):

LayoutTests:

New results for these tests, reflecting the fact that programmatic scrolls now update
the layout viewport.

Clean up fast/dom/elementFromPoint-relative-to-viewport.html, and land an iOS expectation. The test
uses eventSender.zoomPageOut() which is not expected to work correctly on iOS. It works when tested
manually.

• fast/dom/elementFromPoint-relative-to-viewport-expected.txt:
• fast/dom/elementFromPoint-relative-to-viewport.html:
• platform/ios-wk2/fast/dom/elementFromPoint-relative-to-viewport-expected.txt: Copied from LayoutTests/fast/dom/elementFromPoint-relative-to-viewport-expected.txt.
• platform/ios-wk2/fast/visual-viewport/client-rects-relative-to-layout-viewport-expected.txt:
• platform/ios-wk2/fast/visual-viewport/rtl-zoomed-rects-expected.txt:
• platform/ios-wk2/fast/visual-viewport/zoomed-fixed-scroll-down-then-up-expected.txt:
• platform/ios-wk2/fast/visual-viewport/zoomed-rects-expected.txt:
• platform/ios/fast/visual-viewport/zoomed-fixed-expected.txt:
• platform/ios/fast/visual-viewport/zoomed-fixed-header-and-footer-expected.txt:

4:59 PM Changeset in webkit [219667] by Chris Dumez

• 2 edits in trunk/Tools

Unreviewed attempt to fix API test failure after r219663.

The test was hard-coding an exception string and the string has changed slightly
in r219663.

• TestWebKitAPI/Tests/WebKit2Cocoa/WebsiteDataStoreCustomPaths.mm:

(TEST):

4:57 PM Changeset in webkit [219666] by Megan Gardner

• 5 edits in trunk

Don't write file URLs to iOS Pasteboard
​https://bugs.webkit.org/show_bug.cgi?id=174647
<rdar://problem/33199730>

Reviewed by Wenson Hsieh.

Source/WebCore:

Tests updated to reflect the changes. We are no longer vending file URLs in Drag & Drop and Copy/Paste.

• editing/ios/EditorIOS.mm:

(WebCore::Editor::writeImageToPasteboard):

• platform/ios/PlatformPasteboardIOS.mm:

(WebCore::PlatformPasteboard::write):

Tools:

Updating tests to reflect the lack of file URLs for images.

• TestWebKitAPI/Tests/ios/DataInteractionTests.mm:

(checkTypeIdentifierAndIsNotOtherTypeIdentifier):
(checkEstimatedSize):
(TestWebKitAPI::TEST):

4:38 PM Changeset in webkit [219665] by mmaxfield@apple.com

• 4 edits
  10 adds in trunk

Setting the minimum font size preference doesn’t affect absolute line-height values, so lines overlap
​https://bugs.webkit.org/show_bug.cgi?id=174406
Source/WebCore:

Reviewed by Simon Fraser.
<rdar://problem/10139227>

Reviewed by NOBODY.

When the minimumFontSize API preference is set, we will increase the font size without increasing
the line height. If the content specifies line-height as an absolute value, there can be two
unfortunate results:

• Adjacent lines in a paragraph can overlap
• If the paragraph (or containin block or whatever) uses overflow: hidden, the first and last lines

can be cut off and potentially indecipherable.

Instead, we should use the minimum font size preference as a signal that we should increase the
line-height as well as the font-size. Eventually, we will want to increase it by an amount
proportional to the increase in font-size (which can be due to minimumFontSize, minimumLogicalFontSize,
text autosizing, etc.). However, because minimumLogicalFontSize is on by default, this would cause
a behavior change on many webpages which use small text, so such a change would be too risky right now.
Instead, we can pretend that minimumFontSize is the only cause that text increases, and use this as the
only signal to boost the corresponding line-height.

Tests: fast/text/line-height-minimumFontSize-text-zoom.html

fast/text/line-height-minimumFontSize-visual.html
fast/text/line-height-minimumFontSize-zoom.html
fast/text/line-height-minimumFontSize.html
fast/text/line-height-minimumFontSize-autosize.html

• css/StyleBuilderCustom.h:

(WebCore::computeBaseSpecifiedFontSize):
(WebCore::computeLineHeightMultiplierDueToFontSize):
(WebCore::StyleBuilderCustom::applyValueLineHeight):
(WebCore::StyleBuilderCustom::applyValueFill):
(WebCore::StyleBuilderCustom::applyValueStroke):
(WebCore::StyleBuilderCustom::applyValueContent):

• rendering/TextAutoSizing.cpp:

LayoutTests:

<rdar://problem/10139227>

Reviewed by Simon Fraser.

• fast/text/line-height-minimumFontSize-autosize-expected.text: Added.
• fast/text/line-height-minimumFontSize-autosize.html: Added.
• fast/text/line-height-minimumFontSize-expected.txt: Added.
• fast/text/line-height-minimumFontSize-text-zoom-expected.html: Added.
• fast/text/line-height-minimumFontSize-text-zoom.html: Added.
• fast/text/line-height-minimumFontSize-visual-expected.html: Added.
• fast/text/line-height-minimumFontSize-visual.html: Added.
• fast/text/line-height-minimumFontSize-zoom-expected.html: Added.
• fast/text/line-height-minimumFontSize-zoom.html: Added.
• fast/text/line-height-minimumFontSize.html: Added.

1:42 PM Changeset in webkit [219664] by beidson@apple.com

• 10 edits in trunk

iBooks sometimes crashes when closing a book.
<rdar://problem/31180331> and ​https://bugs.webkit.org/show_bug.cgi?id=174658

Reviewed by Oliver Hunt.

Source/WebKit:

• LegacyCustomProtocolManagerProxy should not reference a WebProcessPool directly.
• LegacyCustomProtocolManagerProxy should invalidate in its destructor.

• UIProcess/Network/CustomProtocols/LegacyCustomProtocolManagerProxy.cpp:

(WebKit::LegacyCustomProtocolManagerProxy::LegacyCustomProtocolManagerProxy):
(WebKit::LegacyCustomProtocolManagerProxy::~LegacyCustomProtocolManagerProxy):
(WebKit::LegacyCustomProtocolManagerProxy::startLoading):
(WebKit::LegacyCustomProtocolManagerProxy::stopLoading):
(WebKit::LegacyCustomProtocolManagerProxy::invalidate):
(WebKit::LegacyCustomProtocolManagerProxy::wasRedirectedToRequest):
(WebKit::LegacyCustomProtocolManagerProxy::didReceiveResponse):
(WebKit::LegacyCustomProtocolManagerProxy::didLoadData):
(WebKit::LegacyCustomProtocolManagerProxy::didFailWithError):
(WebKit::LegacyCustomProtocolManagerProxy::didFinishLoading):
(WebKit::LegacyCustomProtocolManagerProxy::processDidClose): Deleted.

• UIProcess/Network/CustomProtocols/LegacyCustomProtocolManagerProxy.h:

• UIProcess/Network/NetworkProcessProxy.cpp:

(WebKit::NetworkProcessProxy::NetworkProcessProxy):
(WebKit::NetworkProcessProxy::didClose):

• UIProcess/Network/NetworkProcessProxy.h:

(WebKit::NetworkProcessProxy::processPool):

Tools:

• TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm:

(-[ProcessPoolDestroyedDuringLoadingProtocol startLoading]):
(-[ProcessPoolDestroyedDuringLoadingProtocol finishTheLoad]):
(-[ProcessPoolDestroyedDuringLoadingProtocol stopLoading]):
(TestWebKitAPI::TEST):

Add a "spin the runloop X number of times" utility:

• TestWebKitAPI/Utilities.h:
• TestWebKitAPI/cocoa/UtilitiesCocoa.mm:

(TestWebKitAPI::Util::spinRunLoop):

1:24 PM Changeset in webkit [219663] by Chris Dumez

• 537 edits in trunk

DOMException should not have its own toString()
​https://bugs.webkit.org/show_bug.cgi?id=174630

Reviewed by Sam Weinig.

LayoutTests/imported/w3c:

Rebaseline existing tests now that more checks are passing.

• web-platform-tests/WebIDL/ecmascript-binding/es-exceptions/DOMException-custom-bindings.any-expected.txt:
• web-platform-tests/WebIDL/ecmascript-binding/es-exceptions/DOMException-custom-bindings.any.worker-expected.txt:

Source/WebCore:

DOMException should not have its own toString() and should use the one from Error.prototype.toString()
instead:

• ​https://heycam.github.io/webidl/#idl-DOMException

No new tests, rebaselined existing tests.

• dom/DOMCoreException.idl:

LayoutTests:

Rebaseline existing tests as the exception string is now slightly different.

1:13 PM Changeset in webkit [219662] by commit-queue@webkit.org

• 10 edits in trunk

[iOS] REGRESSION: Scrubbing media using built-in controls does not pause media
​https://bugs.webkit.org/show_bug.cgi?id=174650
<rdar://problem/33401877>

Patch by Antoine Quint <Antoine Quint> on 2017-07-19
Reviewed by Dean Jackson.

Source/WebCore:

We would only pause when scrubbing on macOS because we only listened to "mousedown" events on the
scrubber's backing <input> element to identify that the user had started interacting with the
scrubber.

Implementing the same technique on iOS required a little more work than just listening to "touchstart"
events on the same element. On top of that, we needed to make sure that we would only respond to
"touchstart" events on the slider's thumb, and not on the track, since only on macOS should the user
be able to click anywhere on the track to scrub. So we turn off pointer-events for the <input> on iOS
only, and turn them back on specifically for the thumb.

There is also some finessing when dealing with touch events where we need to track the identifier of
the touch that started the user interaction. So we keep track of it in an ivar and wait until we get
a "touchend" event where the changedTouches list contains a touch with that same identifier to ensure
the same touch that initiates and ends the scrubbing interaction.

Finally, we fix another issue that was uncovered while turning back on the ScrubbingSupport tests
where we would not trash the cached _value ivar when we initiated scrubbing, which was important since
we would mistakenly use the pre-srubbing value during a scrub.

• Modules/modern-media-controls/controls/slider.css:

(.ios .slider > input):
(.slider > input::-webkit-slider-thumb):

• Modules/modern-media-controls/controls/slider.js:

(Slider.prototype.handleEvent):
(Slider.prototype._handleMousedownEvent):
(Slider.prototype._interactionEndTarget):
(Slider.prototype._handleTouchstartEvent):
(Slider.prototype._valueWillStartChanging):
(Slider.prototype._valueDidStopChanging):
(Slider.prototype._handleMouseupEvent):
(Slider.prototype._handleTouchendEvent):

LayoutTests:

Rebaseline and turn back on all the ScrubberSupport tests on macOS and iOS.

• media/modern-media-controls/scrubber-support/ipad/scrubber-support-drag-expected.txt:
• media/modern-media-controls/scrubber-support/ipad/scrubber-support-drag.html:
• media/modern-media-controls/scrubber-support/scrubber-support-media-api-expected.txt:
• media/modern-media-controls/scrubber-support/scrubber-support-media-api.html:
• platform/ios-simulator/TestExpectations:
• platform/mac/TestExpectations:

12:18 PM Changeset in webkit [219661] by n_wang@apple.com

• 3 edits
  2 adds in trunk

AX: Web page reloaded when a node is labelling multiple childnodes
​https://bugs.webkit.org/show_bug.cgi?id=174655

Reviewed by Chris Fleizach.

Source/WebCore:

When we are asking for the aria-labelledby attribute of a node and its
sibling is also labelled by the same node, we get into an infinite loop
in textUnderElement since we only ignore one child. Added checks for
siblings to avoid such loop.

Test: accessibility/mac/aria-labelledby-multiple-child-crash.html

• accessibility/AccessibilityNodeObject.cpp:

(WebCore::AccessibilityNodeObject::textUnderElement):

LayoutTests:

• accessibility/mac/aria-labelledby-multiple-child-crash-expected.txt: Added.
• accessibility/mac/aria-labelledby-multiple-child-crash.html: Added.

11:16 AM Changeset in webkit [219660] by aestes@apple.com

• 2 edits in trunk/Source/WebCore

Use a cast to work around clang's false -Wobjc-literal-conversion warnings
​https://bugs.webkit.org/show_bug.cgi?id=174631

Reviewed by Dan Bernstein.

Instead of ignoring -Wobjc-literal-conversion, use a cast to work around rdar://problem/33383354.

• platform/ios/PlatformPasteboardIOS.mm:

(WebCore::PlatformPasteboard::write):

11:16 AM Changeset in webkit [219659] by Chris Dumez

• 15 edits in trunk

Make cross-origin properties enumerable
​https://bugs.webkit.org/show_bug.cgi?id=174576

Reviewed by Darin Adler.

LayoutTests/imported/w3c:

Re-sync tests from upstream and rebaseline to improve test coverage.

• web-platform-tests/html/browsers/origin/cross-origin-objects/cross-origin-objects-expected.txt:
• web-platform-tests/html/browsers/origin/cross-origin-objects/cross-origin-objects.html:
• web-platform-tests/html/browsers/the-window-object/window-indexed-properties-expected.txt:
• web-platform-tests/html/browsers/the-window-object/window-indexed-properties.html:

Source/WebCore:

Makes cross-origin properties enumerable on Window and Location objects
as per:

• ​https://github.com/whatwg/html/pull/2777

This simplifies our code quite a bit.

No new tests, updated existing tests.

• bindings/js/JSDOMWindowCustom.cpp:

(WebCore::jsDOMWindowGetOwnPropertySlotRestrictedAccess):
(WebCore::JSDOMWindow::getOwnPropertySlotByIndex):
(WebCore::JSDOMWindow::getOwnPropertyNames):

• bindings/js/JSLocationCustom.cpp:

(WebCore::getOwnPropertySlotCommon):
(WebCore::JSLocation::getOwnPropertyNames):

• bindings/scripts/CodeGeneratorJS.pm:

(GenerateHeader):

LayoutTests:

Update / rebaseline some tests to reflect behavior change.

• http/tests/security/cross-origin-descriptors-expected.txt:
• http/tests/security/cross-origin-descriptors.html:
• js/dom/getOwnPropertyDescriptor-expected.txt:
• js/resources/getOwnPropertyDescriptor.js:

10:27 AM Changeset in webkit [219658] by clopez@igalia.com

• 2 edits in trunk/Source/WebCore

[EME] Build failure with Clang-3.8 on InitDataRegistry.cpp
​https://bugs.webkit.org/show_bug.cgi?id=174628

Reviewed by Žan Doberšek.

• Modules/encryptedmedia/InitDataRegistry.cpp:

(WebCore::extractKeyIDsKeyids): Add an explicit cast to unsigned.

10:09 AM Changeset in webkit [219657] by Jonathan Bedard

• 12 edits in trunk/Tools

lint-test-expectations should be run during style checking
​https://bugs.webkit.org/show_bug.cgi?id=173559
<rdar://problem/32854941>

Reviewed by David Kilzer.

Running the test expectation linter requires reading both files and lines not in the
patch because, for example, deletion of a test can cause a lint failure even though
no test expectations where modified. This means that the linter will occasionally warn
about lines which were not changed in a given patch but whose error is related to a
change made in that patch.

• Scripts/webkitpy/common/system/filesystem_mock.py:

(MockFileSystem.open_text_file_for_reading): Add 'errors' argument to mimic filesystem.

• Scripts/webkitpy/layout_tests/models/test_expectations.py:

(TestExpectationWarning): Added class to pass warnings as an object instead of a string.
(TestExpectationWarning.init): Construct warning with file name, line number, line
content, description of the error and the name of the associated test.
(TestExpectationWarning.str): Convert to string so that existing printing code works.
(TestExpectationParser.init): Pass shorten_filename function to
TestExpectationsParser to add a deleted file to the related_files dictionary.
(TestExpectationParser._check_test_exists): If the test does not exist, add the
missing path to the related_files dictionary.
(TestExpectationLine.init): Add related_files dictionary, which tracks
files and line numbers related to this test expectation line. This will allow
tracking linter errors in the style checker occurring across multiple files.
(TestExpectationsModel._already_seen_better_match): Add redundant expectation
lines to related_files dictionary.
(TestExpectations.init): Pass self._shorten_filename to TestExpectationParser.
(TestExpectations._report_warnings): Construct warning object instead of string
when adding to warnings list.

• Scripts/webkitpy/port/win.py: Changed logging level form warning to debug to

clean-up log.

• Scripts/webkitpy/style/checker.py:

(ProcessorBase.do_association_check): Add required function for processor classes.
(StyleProcessor):
(StyleProcessor.do_association_check): Run the TestExpectations linter when
checking for errors between associated files.

• Scripts/webkitpy/style/checkers/test_expectations.py:

(TestExpectationsChecker.check_test_expectations): Reflect changed import statements.
(TestExpectationsChecker):
(TestExpectationsChecker._should_log_linter_warning): Given a warning, a dictionary
of modified files, the current working directory and the host, determine if the linter
warning is associated with the changes.
(TestExpectationsChecker.lint_test_expectations): Lint test expectations for the
style checker.

• Scripts/webkitpy/style/filereader.py:

(TextFileReader):
(TextFileReader.init): Track modified files in dictionary instead of a counter.
(TextFileReader.file_count): Use dictionary to determine the number of modified files.
(TextFileReader.process_file): Track both the number of files changed and which lines
in those files were changed.
(TextFileReader.do_association_check): Run the processor's association check on all
modified or deleted files processed by TextFileReader.
(TextFileReader.delete_file): Track deleted files in _files dictionary.
(TextFileReader.count_delete_only_file): Deleted.

• Scripts/webkitpy/style/filereader_unittest.py:

(TextFileReaderTest.test_delete_file): Renamed function to reflect new function name.
(TextFileReaderTest.test_count_delete_only_file): Moved to test_delete_file.

• Scripts/webkitpy/style/main.py:

(CheckWebKitStyle.main): When running the style checker on a specific list of files,
explicitly run the association check on the file reader.

• Scripts/webkitpy/style/main_unittest.py:

(ExpectationLinterInStyleCheckerTest): Added to test the TestExpectationLinter now
embedded in the style checker.
(ExpectationLinterInStyleCheckerTest.setUp): Set up the style checker configuration.
(ExpectationLinterInStyleCheckerTest._generate_file_reader): Given a filesystem object,
construct the TextFileReader object with a StyleProcessor used to run style checks on
specific files.
(ExpectationLinterInStyleCheckerTest._generate_testing_host): Generate a host used for
testing the test expectation linter inside the style checker. This host must contain a
mock file system with the basic structure of test expectations.
(ExpectationLinterInStyleCheckerTest.test_no_linter_errors):
(ExpectationLinterInStyleCheckerTest.test_linter_duplicate_line):
(ExpectationLinterInStyleCheckerTest.test_linter_duplicate_line_no_edit):
(ExpectationLinterInStyleCheckerTest.test_linter_deleted_file):
(ExpectationLinterInStyleCheckerTest.test_linter_deleted_file_no_edit):

• Scripts/webkitpy/style/patchreader.py:

(PatchReader.check): Specify which file was deleted, run the association check.

• Scripts/webkitpy/style/patchreader_unittest.py:

(PatchReaderTest.MockTextFileReader.delete_file): Renamed count_delete_only_file.
(PatchReaderTest.MockTextFileReader.do_association_check): Added.
(PatchReaderTest.MockTextFileReader.count_delete_only_file): Renamed delete_file.

9:42 AM Changeset in webkit [219656] by Matt Lewis

• 4 edits
  10 deletes in trunk

Unreviewed, rolling out r219646.

The test added are failing on all platforms

Reverted changeset:

"Setting the minimum font size preference doesn’t affect
absolute line-height values, so lines overlap"
​https://bugs.webkit.org/show_bug.cgi?id=174406
​http://trac.webkit.org/changeset/219646

7:10 AM Changeset in webkit [219655] by zandobersek@gmail.com

• 2 edits in trunk/LayoutTests

Unreviewed WPE gardening.

• platform/wpe/TestExpectations:

Unskip a bunch of Web Crypto tests that are passing now that
the underlying implementation has progressed.

3:44 AM Changeset in webkit [219654] by Yusuke Suzuki

• 9 edits
  1 delete in trunk/Source/WTF

[WTF] Remove unnecessary indirection of WTF::Thread entry point
​https://bugs.webkit.org/show_bug.cgi?id=174291

Reviewed by Mark Lam.

Now wtfThreadEntryPoint is almost the same. Only the difference is function signature due to platform APIs.
We remove ThreadFunctionInvocation indirection in ThreadingPthread.cpp and ThreadingWin.cpp.

Also, ThreadFunctionInvocation keeps a RefPtr to the Thread object. This was previously needed to keep the
Thread object alive until the thread itself could install the ThreadHolder into its thread local storage.
The ThreadHolder has a Ref that keeps the Thread object alive for the lifetime of the thread. Since
Thread::create() now waits for the thread to be initialized before returning and Thread::create() hold a Ref
to the Thread object, we are guaranteed that the Thread object will be alive long enough for it to be installed
in the thread's ThreadHolder, and we no longer need ThreadFunctionInvocation.

And we also simplify ThreadHolder::initialize a bit. Now Thread::create waits for the completion of Thread
initialization. So, after establishing thread handle, we can call ThreadHolder::initialize before completing
Thread initialization.

Also we drop errno.h ifdefs in ThreadingWin.cpp. This is introduced to support WinCE. But now WinCE port is removed.

• WTF.xcodeproj/project.pbxproj:
• wtf/ThreadFunctionInvocation.h: Removed.
• wtf/ThreadHolder.h:
• wtf/ThreadHolderWin.cpp:

(WTF::ThreadHolder::initialize):

• wtf/Threading.cpp:

(WTF::Thread::entryPoint):
(WTF::Thread::create):
(WTF::threadEntryPoint): Deleted.

• wtf/Threading.h:
• wtf/ThreadingPthreads.cpp:

(WTF::Thread::initializeCurrentThreadEvenIfNonWTFCreated):
(WTF::wtfThreadEntryPoint):
(WTF::Thread::establishHandle):
(WTF::Thread::initializeCurrentThreadInternal):
(WTF::Thread::current):
(WTF::Thread::establishPlatformSpecificHandle):
(WTF::Thread::createInternal): Deleted.
(WTF::Thread::establish): Deleted.

• wtf/ThreadingWin.cpp:

(WTF::Thread::initializeCurrentThreadEvenIfNonWTFCreated):
(WTF::Thread::initializeCurrentThreadInternal):
(WTF::wtfThreadEntryPoint):
(WTF::Thread::establishHandle):
(WTF::Thread::current):
(WTF::Thread::establishPlatformSpecificHandle):
(WTF::Thread::createInternal): Deleted.
(WTF::Thread::establish): Deleted.

• wtf/win/MainThreadWin.cpp:

(WTF::initializeMainThreadPlatform):

1:43 AM Changeset in webkit [219653] by Yusuke Suzuki

• 24 edits
  2 copies
  1 add in trunk

[WTF] Implement WTF::ThreadGroup
​https://bugs.webkit.org/show_bug.cgi?id=174081

Reviewed by Mark Lam.

Source/JavaScriptCore:

Large part of MachineThreads are now removed and replaced with WTF::ThreadGroup.
And SamplingProfiler and others interact with WTF::Thread directly.

• API/tests/ExecutionTimeLimitTest.cpp:
• heap/MachineStackMarker.cpp:

(JSC::MachineThreads::MachineThreads):
(JSC::captureStack):
(JSC::MachineThreads::tryCopyOtherThreadStack):
(JSC::MachineThreads::tryCopyOtherThreadStacks):
(JSC::MachineThreads::gatherConservativeRoots):
(JSC::ActiveMachineThreadsManager::Locker::Locker): Deleted.
(JSC::ActiveMachineThreadsManager::add): Deleted.
(JSC::ActiveMachineThreadsManager::remove): Deleted.
(JSC::ActiveMachineThreadsManager::contains): Deleted.
(JSC::ActiveMachineThreadsManager::ActiveMachineThreadsManager): Deleted.
(JSC::activeMachineThreadsManager): Deleted.
(JSC::MachineThreads::~MachineThreads): Deleted.
(JSC::MachineThreads::addCurrentThread): Deleted.
(): Deleted.
(JSC::MachineThreads::removeThread): Deleted.
(JSC::MachineThreads::removeThreadIfFound): Deleted.
(JSC::MachineThreads::MachineThread::MachineThread): Deleted.
(JSC::MachineThreads::MachineThread::getRegisters): Deleted.
(JSC::MachineThreads::MachineThread::Registers::stackPointer): Deleted.
(JSC::MachineThreads::MachineThread::Registers::framePointer): Deleted.
(JSC::MachineThreads::MachineThread::Registers::instructionPointer): Deleted.
(JSC::MachineThreads::MachineThread::Registers::llintPC): Deleted.
(JSC::MachineThreads::MachineThread::captureStack): Deleted.

• heap/MachineStackMarker.h:

(JSC::MachineThreads::addCurrentThread):
(JSC::MachineThreads::getLock):
(JSC::MachineThreads::threads):
(JSC::MachineThreads::MachineThread::suspend): Deleted.
(JSC::MachineThreads::MachineThread::resume): Deleted.
(JSC::MachineThreads::MachineThread::threadID): Deleted.
(JSC::MachineThreads::MachineThread::stackBase): Deleted.
(JSC::MachineThreads::MachineThread::stackEnd): Deleted.
(JSC::MachineThreads::threadsListHead): Deleted.

• runtime/SamplingProfiler.cpp:

(JSC::FrameWalker::isValidFramePointer):
(JSC::SamplingProfiler::SamplingProfiler):
(JSC::SamplingProfiler::takeSample):
(JSC::SamplingProfiler::noticeCurrentThreadAsJSCExecutionThread):

• runtime/SamplingProfiler.h:
• wasm/WasmMachineThreads.cpp:

(JSC::Wasm::resetInstructionCacheOnAllThreads):

Source/WebCore:

• page/ResourceUsageThread.h:

Source/WebKit:

• Shared/AsyncRequest.h:

Source/WTF:

This patch implements WTF::ThreadGroup. It implements core of JSC::MachineThreads with more reliable way.
JSC::MachineThreads was complicated because of managing dead threads. Each JSC::MachineThreads has its
own TLS with a registered destructor. And everytime a thread dies, the registered TLS destructor is called.
And this destructor will remove the current dying thread from JSC::MachineThreads.

However the above implementation is tricky. And each JSC::MachineThreads requires own TLS space, which is
not considered in WTF's Windows ThreadSpecific implementation. Current design works well since we only
have small number of MachineThreads right now.

Instead, we use more reliable way. After introducing WTF::Thread, WTF::Thread has WTF::Thread::didExit,
which is called when associated TLS (with WTF::Thread) is destroyed. We leverage this mechanism to remove
WTF::Thread from MachineThreads.

This patch introduces WTF::ThreadGroup. It is tightly integrated with WTF::Thread: WTF::Thread knows
ThreadGroups which includes this thread. And WTF::ThreadGroup of course knows WTF::Threads added to it.
WTF::Thread::didExit carefully remove itself from WTF::ThreadGroups.

The most important part of this patch is locking. WTF::Thread can die. And WTF::ThreadGroup can die.
If we take a design using two fine grain locks in WTF::Thread and WTF::ThreadGroup, we easily encounter
dead lock. Consider the following case.

1. When adding WTF::Thread (TH) to WTF::ThreadGroup (THG), we first hold a lock of THG, and hold a lock of TH (locking order is THG -> TH).
2. When TH dies, TH need to hold a lock of TH to iterate THGs. And we hold a lock of THG to unregister TH from it (locking order is TH -> THG).
3. When suspending and resuming THs in THG, we first hold a lock of THG. And then, we hold a lock of TH to suspend and resume it (locking order is THG -> TH).
4. When destroying THG, we need to hold a lock of TH to unregister THG from TH. We can hold a lock of THG before that (locking order is THG -> TH).

Then, it easily causes dead lock. We cannot swap the locking order of (2) since iterating THG requires a lock of TH.
To solve this problem, we use std::shared_ptr and std::weak_ptr.

1. When adding WTF::Thread (TH) to WTF::ThreadGroup (THG), we first hold THG, and hold a lock of TH. (THG -> TH)
2. When TH dies, TH first hold lock of TH. And we use std::weak_ptr<>::lock() to retain non-destructed ThreadGroups.

If some of ThreadGroups are dying, we just ignore them. It is ok because such a ThreadGroup will be destructed. So we do not need to unregister this thread from
such a ThreadGroup. Then, we have Vector<std::shared_ptr<ThreadGroup>>. So we unlock a lock of TH. To unregister a thread from thread group, we first hold a
lock of THG and then hold a lock of TH. Both lifetime is ensured: THG is retained by std::shared_ptr. And TH is itself. (TH), (THG -> TH).

3. When suspending and resuming THs in THG, we first hold a lock of THG. And then, we hold a lock of TH to suspend and resume it (THG -> TH).
4. When destroying THG, we hold a lock of THG. And hold a lock of TH. During holding THG's lock, registered thread never dies because (2) holds THG lock. (THG -> TH).

We also fix suspend and resume locking mechanism to avoid dead lock. We should hold the global lock when suspending and resuming.
If we use per-thread lock, the suspended thread can hold the lock of the other threads. It causes dead lock.

• WTF.xcodeproj/project.pbxproj:
• wtf/AutomaticThread.cpp:
• wtf/CMakeLists.txt:
• wtf/CrossThreadCopier.h:
• wtf/ParkingLot.h:
• wtf/ThreadGroup.cpp: Copied from Source/JavaScriptCore/wasm/WasmMachineThreads.cpp.

(WTF::ThreadGroup::~ThreadGroup):
(WTF::ThreadGroup::add):
(WTF::ThreadGroup::addCurrentThread):

• wtf/ThreadGroup.h: Copied from Source/JavaScriptCore/wasm/WasmMachineThreads.cpp.

(WTF::ThreadGroup::create):
(WTF::ThreadGroup::threads):
(WTF::ThreadGroup::getLock):
(WTF::ThreadGroup::weakFromThis):

• wtf/Threading.cpp:

(WTF::shouldRemoveThreadFromThreadGroup):
(WTF::Thread::didExit):
(WTF::Thread::addToThreadGroup):
(WTF::Thread::removeFromThreadGroup):

• wtf/Threading.h:
• wtf/ThreadingPthreads.cpp:

(WTF::Thread::resume):
(WTF::Thread::getRegisters):

• wtf/ThreadingWin.cpp:

(WTF::Thread::resume):
(WTF::Thread::getRegisters):

Tools:

Add WTF::ThreadGroup tests.

• TestWebKitAPI/CMakeLists.txt:
• TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
• TestWebKitAPI/Tests/WTF/ThreadGroup.cpp: Added.

(TestWebKitAPI::testThreadGroup):
(TestWebKitAPI::TEST):