⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Jul 24, 2017:

11:49 PM Changeset in webkit [219863] by Carlos Garcia Campos
  • 3 edits in trunk/Source/WebKit

[GTK] ASSERTION FAILED: client in WebKit::IconDatabase::setClient
​https://bugs.webkit.org/show_bug.cgi?id=174788

Patch by Michael Catanzaro <Michael Catanzaro> on 2017-07-24
Reviewed by Carlos Garcia Campos.

IconDatabase ensures that setClient is never called with nullptr, but WebKitFaviconDatabase
does exactly that. First, ensure it's safe to unset the client. Next, we can either remove
the assertions from setClient or else automatically unset the client in IconDatabase::close.
I opted to do both.

  • UIProcess/API/glib/IconDatabase.cpp:

(WebKit::IconDatabase::close):
(WebKit::IconDatabase::setIconDataForIconURL):
(WebKit::IconDatabase::setIconURLForPageURL):

  • UIProcess/API/glib/WebKitFaviconDatabase.cpp:

(_WebKitFaviconDatabasePrivate::~_WebKitFaviconDatabasePrivate): Deleted.
(webkitFaviconDatabaseDispose): Deleted.

11:45 PM Changeset in webkit [219862] by Carlos Garcia Campos
  • 2 edits in trunk/Source/WebKit

[GTK][WPE] Remove useless conditional in IconDatabase::setIconDataForIconURL
​https://bugs.webkit.org/show_bug.cgi?id=174792

Patch by Michael Catanzaro <Michael Catanzaro> on 2017-07-24
Reviewed by Carlos Garcia Campos.

We have in IconDatabase::setIconDataForIconURL some code in a conditional to check if it's
not being executed on the icon sync thread. But at the top of the function is an assertion
to ensure the code is never executed on the icon sync thread. The condition is therefore
useless and the code should be executed unconditionally.

  • UIProcess/API/glib/IconDatabase.cpp:

(WebKit::IconDatabase::setIconDataForIconURL):

11:39 PM Changeset in webkit [219861] by Carlos Garcia Campos
  • 2 edits in trunk/Source/WebKit

[GTK] Icon database error and crash
​https://bugs.webkit.org/show_bug.cgi?id=174760

Reviewed by Michael Catanzaro.

The crash is a debug ASSERT that happens when the IconRecord image is created in one thread and destroyed in
another one. IconDatabase creates and destroys IconRecord objects in both database and main thread. The
IconRecord is destroyed when the icon is no longer retained, and we only release icons when we fail to get the
image data (including pages that don't have a favicon). We can prevent this crash from happening if we ensure we
never create an Image for an IconRecord when the given image data is nullptr.

  • UIProcess/API/glib/IconDatabase.cpp:

(WebKit::IconDatabase::IconRecord::setImageData):

9:36 PM Changeset in webkit [219860] by commit-queue@webkit.org
  • 7 edits in trunk/Tools

Fix BenchmarkRunner to only import selenium when needed
​https://bugs.webkit.org/show_bug.cgi?id=174808

Patch by Matthew Stewart <​matthew_r_stewart@apple.com> on 2017-07-24
Reviewed by Stephanie Lewis.

  • Scripts/webkitpy/benchmark_runner/browser_driver/linux_chrome_driver.py:

(LinuxChromeDriver.launch_driver):

  • Scripts/webkitpy/benchmark_runner/browser_driver/linux_firefox_driver.py:

(LinuxFirefoxDriver.launch_driver):

  • Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py:

(OSXChromeDriver.launch_driver):
(OSXChromeCanaryDriver.launch_driver):
(create_chrome_options):

  • Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py:

(OSXFirefoxDriver.launch_driver):
(OSXFirefoxNightlyDriver.launch_driver):

  • Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:

(OSXSafariDriver.launch_driver):

  • Scripts/webkitpy/benchmark_runner/webdriver_benchmark_runner.py:

(WebDriverBenchmarkRunner._run_one_test):

9:35 PM Changeset in webkit [219859] by jmarcell@apple.com
  • 2 edits in branches/safari-604-branch/Source/WebKit

Cherry-pick r219852. rdar://problem/33503476

9:29 PM Changeset in webkit [219858] by Darin Adler
  • 51 edits in trunk

More NeverDestroyed and related cleanup
​https://bugs.webkit.org/show_bug.cgi?id=174745

Reviewed by Alex Christensen.

Source/WebCore:

  • bindings/js/JSCustomElementInterface.cpp:

(WebCore::JSCustomElementInterface::constructElementWithFallback):
Use isNull() rather than comparing against nullAtom() since it's
slightly more efficient.

  • css/MediaQueryEvaluator.cpp:

(WebCore::prefersReducedMotionEvaluate): Use a switch statement for the
three states of forcedPrefersReducedMotionAccessibilityValue. Also update
to use Theme::singleton() instead of platformTheme().

  • dom/QualifiedName.h: Removed some unneeded includes, minor style tweaks,

and use isNull() rather than comparing against nullAtom() since it's
slightly more efficient.

  • html/Autofill.cpp:

(WebCore::AutofillData::createFromHTMLFormControlElement): Use isNull()
rather than comparing against nullAtom() since it's slightly more efficient.

  • html/HTMLDocument.cpp:

(WebCore::addLocalNameToSet): Deleted.
(WebCore::createHtmlCaseInsensitiveAttributesSet): Deleted.
(WebCore::HTMLDocument::isCaseSensitiveAttribute): Moved the case-sensitive
attribute set in here and made it use makeNeverDestroyed.

  • html/HTMLNameCollection.cpp:

(WebCore::WindowNameCollection::elementMatchesIfNameAttributeMatch):
Formatted vertically and sorted so it's easier to see what it does.
(WebCore::WindowNameCollection::elementMatches): Use boolean logic instead
of multiple return statements to make this a little more straightforward.
(WebCore::isObjectElementForDocumentNameCollection): Added. Calls the new
isExposed function. The old code called this isDocNamedItem.
(WebCore::DocumentNameCollection::elementMatchesIfIdAttributeMatch):
Use isObjectElementForDocumentNameCollection to clean up logic. Also
sorted classes.
(WebCore::DocumentNameCollection::elementMatchesIfNameAttributeMatch):
Use isObjectElementForDocumentNameCollection to clean up logic. Also
sorted classes and formatted vertically.
(WebCore::DocumentNameCollection::elementMatches): Write in terms of
above functions for clarity. Efficiency is roughly the same.

  • html/HTMLObjectElement.cpp:

(WebCore::HTMLObjectElement::HTMLObjectElement): Initialize data members
in class definition instead of here.
(WebCore::HTMLObjectElement::childrenChanged): Update for name change;
function is now called updateExposedState rather than updateDocNamedItem.
Also use m_useFallbackContent directly instead of through a function.
(WebCore::HTMLObjectElement::renderFallbackContent): Ditto.
(WebCore::preventsParentObjectFromExposure): Added. Replaces the old
isRecognizedTagName function, and does almost the same thing, but the
argument type is different and the param tag is now one of the tags
exempted here. Also broke up into two overloads so we can handle the
Element, Text, and other Node cases.
(WebCore::shouldBeExposed): Added. Helper for the updateExposedState
function that handles the logic of when the element should be exposed,
separating it from what to do when the state changes.
(WebCore::HTMLObjectElement::updateExposedState): Renamed from
updateDocNamedItem.

  • html/HTMLObjectElement.h: Renamed isDocNamedItem -> isExposed,

m_docNamedItem -> m_isExposed, updateDocNamedItem -> updateExposedState,
stopped using bit fields for the two boolean data members, and
initialized those data members here in the class definition.

  • platform/Theme.cpp:

(WebCore::Theme::baselinePositionAdjustment): Moved here from header.
(WebCore::Theme::controlFont): Ditto.
(WebCore::Theme::controlSize): Ditto.
(WebCore::Theme::minimumControlSize): Ditto.
(WebCore::Theme::controlRequiresPreWhiteSpace): Ditto.
(WebCore::Theme::paint): Ditto.
(WebCore::Theme::inflateControlPaintRect): Ditto.
(WebCore::Theme::userPrefersReducedMotion): Ditto.
(WebCore::Theme::controlBorder): Fixed switch statement indentation.
(WebCore::Theme::controlPadding): Ditto.

  • platform/Theme.h: Removed the many unnecessary includes. The one

I was really after here was FontCascade.h. Replaced the platformTheme
function with a singleton function, following our normal style. Also
changed the return type to a reference rather than a pointer.
Removed many unused function and data members.

  • platform/cocoa/ThemeCocoa.h: Tightened up implementation, removing

unnecessary members and making overrides private.

  • platform/cocoa/ThemeCocoa.mm: Moved include in here.
  • platform/gamepad/glib/GamepadsGlib.cpp:

(WebCore::sampleGamepads): Use NeverDestroyed instead of
DEPRECATED_DEFINE_STATIC_LOCAL.

  • platform/graphics/FontCascade.cpp:

(WebCore::useBackslashAsYenSignForFamily): Build the set in a cleaner
way and use a NeverDestroyed set instead of a heap-allocated one.
(WebCore::FontCascade::FontCascade): Moved initialization of data members
to the class definition.

  • platform/graphics/FontCascade.h: Initialize GlyphOverflow and

FonstCascade data members in the class definition. Remove the constructor
for GlyphOverflow entirely. Added FIXME about the peculiar != operator we
defined for GlyphOverflow.

  • platform/graphics/NamedImageGeneratedImage.cpp:

(WebCore::NamedImageGeneratedImage::draw): Use Theme::singleton() instead
of platformTheme().
(WebCore::NamedImageGeneratedImage::drawPattern): Ditto.

  • platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.cpp:

(WebCore::CMTimeRangeStartKey): Use CFSTR directly instead of using
DEPRECATED_DEFINE_STATIC_LOCAL.
(WebCore::CMTimeRangeDurationKey): Ditto.
(WebCore::CACFContextNeedsFlushNotification): Ditto.

  • platform/graphics/ca/win/LayerChangesFlusher.cpp:

(WebCore::LayerChangesFlusher::singleton): Use NeverDestroyed instead of
DEPRECATED_DEFINE_STATIC_LOCAL.

  • platform/graphics/ca/win/LayerChangesFlusher.h: Ditto.
  • platform/graphics/cg/ImageSourceCGWin.cpp:

(WebCore::preferredExtensionForImageSourceType): Use HashMap constructor
instead of writing out a lot of add calls.

  • platform/graphics/harfbuzz/HarfBuzzFace.cpp:

(WebCore::harfBuzzFaceCache): Use NeverDestroyed instead of
DEPRECATED_DEFINE_STATIC_LOCAL.

  • platform/graphics/win/FontCacheWin.cpp:

(WebCore::FontCache::lastResortFallbackFont): Ditto.

  • platform/ios/ThemeIOS.h: Tightened up implementation, removing

unnecessary members and making overrides private.

  • platform/ios/ThemeIOS.mm:

(WebCore::Theme::singleton): Renamed from platformTheme.

  • platform/mac/ThemeMac.h: Tightened up implementation, removing

unnecessary members and making overrides private. Removed unneeded
WTF_MAKE_FAST_ALLOCATED since this is never allocated on the heap.
Removed unused -[NSFont webCoreFamilyName] method.

  • platform/mac/ThemeMac.mm:

(-[NSFont webCoreFamilyName]): Deleted.
(WebCore::Theme::singleton): Renamed from platformTheme.

  • platform/mediastream/mac/MockRealtimeAudioSourceMac.h:

Removed unneeded include of FontCascade.h.

  • platform/mediastream/mac/MockRealtimeVideoSourceMac.h:

Ditto.

  • platform/mock/MockRealtimeAudioSource.h: Ditto.
  • platform/network/win/DownloadBundleWin.cpp:

(WebCore::DownloadBundle::fileExtension): Use NeverDestroyed
instead of DEPRECATED_DEFINE_STATIC_LOCAL.

  • platform/win/ClipboardUtilitiesWin.cpp:

(WebCore::replaceNewlinesWithWindowsStyleNewlines): Use
appendLiteral instead of DEPRECATED_DEFINE_STATIC_LOCAL.

  • platform/win/FileSystemWin.cpp:

(WebCore::bundleName): Use NeverDestroyed instead of
DEPRECATED_DEFINE_STATIC_LOCAL, and used a lambda to initialize
rather than a boolean to control one-time code.
(WebCore::storageDirectory): Removed unneeded use of
DEPRECATED_DEFINE_STATIC_LOCAL for a prefix we are appending to
a String. The + operator can handle a literal just as efficiently
without first storing it in a String.

  • platform/wpe/ThemeWPE.cpp:

(WebCore::Theme::singleton): Renamed from platformTheme.

  • platform/wpe/ThemeWPE.h: Tightened up implementation, removing

unnecessary members and making overrides private.

  • rendering/RenderTheme.cpp:

(WebCore::RenderTheme::RenderTheme): No need to initialize m_theme.
(WebCore::RenderTheme::adjustStyle): Use Theme::singleton() instead
of accessing it through m_theme.
(WebCore::RenderTheme::paint): Ditto.
(WebCore::RenderTheme::baselinePosition): Ditto.
(WebCore::RenderTheme::adjustRepaintRect): Ditto.
(WebCore::RenderTheme::setCustomFocusRingColor): Ditto.
(WebCore::RenderTheme::platformTapHighlightColor): Ditto.

  • rendering/RenderTheme.h: Removed unneded m_theme and unneeded

inclusion of Theme.h.

  • rendering/line/LineBreaker.h: Removed unneeded include of

FontCascade.h.

Source/WebKitLegacy/mac:

  • DOM/DOMUIKitExtensions.mm: Removed a lot of unneeded "using"

for names that aren't even used in this file.
(-[DOMNode boundingBoxes]): Use @[] syntax instead of
-[NSArray arrayWithObject:].
(-[DOMNode absoluteQuads]): Ditto.
(-[DOMNode findExplodedTextNodeAtPoint:]): Use auto* instead
of writing out various types.
(-[DOMHTMLAreaElement boundingBoxesWithOwner:]): Use @[]
syntax instea of -[NSArray arrayWithObject:].
(-[DOMHTMLAreaElement absoluteQuadsWithOwner:]): Ditto.
(-[DOMHTMLImageElement dataRepresentation:]): Use auto* instead
of writing out various types.
(-[DOMHTMLImageElement mimeType]): Ditto.

Source/WebKitLegacy/win:

  • Plugins/PluginDatabase.cpp:

(WebCore::persistentPluginMetadataCachePath): Use NeverDestroyed
instead of DEPRECATED_DEFINE_STATIC_LOCAL.

  • Plugins/PluginMainThreadScheduler.cpp:

(WebCore::PluginMainThreadScheduler::scheduler): Ditto.

  • Plugins/PluginMainThreadScheduler.h: Ditto.
  • WebCoreSupport/WebPlatformStrategies.cpp:

(WebPlatformStrategies::initialize): Ditto.

  • WebCoreSupport/WebPlatformStrategies.h: Ditto.
  • WebHistory.cpp:

(sharedHistoryStorage): Ditto.

  • WebLocalizableStrings.cpp:

(mainBundleLocStrings): Ditto.
(frameworkLocStringsMutex): Ditto.
(frameworkLocStrings): Ditto.

  • WebView.cpp:

(WebView::standardUserAgentWithApplicationName): Ditto.
Also changed to keep one global string with the prefix of the user agent string
instead of keeping two globals with pieces of that prefix.

Tools:

  • DumpRenderTree/JavaScriptThreading.cpp:

(javaScriptThreadsMutex): Use NeverDestroyed instead of
DEPRECATED_DEFINE_STATIC_LOCAL.
(javaScriptThreads): Ditto.

9:10 PM Changeset in webkit [219857] by commit-queue@webkit.org
  • 4 edits
    2 adds in trunk/Tools

Subclass Benchmark Runner script for WebDriver support
​https://bugs.webkit.org/show_bug.cgi?id=174390

Patch by Matthew Stewart <​matthew_r_stewart@apple.com> on 2017-07-24
Reviewed by Dewei Zhu, Stephanie Lewis.

Add WebServerBenchmarkRunner and WebDriverBenchmarkRunner subclasses.

  • Scripts/webkitpy/benchmark_runner/benchmark_builder.py:

(BenchmarkBuilder.init):

  • Scripts/webkitpy/benchmark_runner/benchmark_runner.py:

(BenchmarkRunner.init):
(BenchmarkRunner._find_plan_file):
(BenchmarkRunner._run_one_test.and):
(BenchmarkRunner.execute):
(BenchmarkRunner._get_result): Deleted.

  • Scripts/webkitpy/benchmark_runner/run_benchmark.py:

(parse_args):
(start):

  • Scripts/webkitpy/benchmark_runner/webdriver_benchmark_runner.py: Added.

(WebDriverBenchmarkRunner):
(WebDriverBenchmarkRunner._get_result):
(WebDriverBenchmarkRunner._run_one_test):

  • Scripts/webkitpy/benchmark_runner/webserver_benchmark_runner.py: Added.

(WebServerBenchmarkRunner):
(WebServerBenchmarkRunner.init):
(WebServerBenchmarkRunner._get_result):
(WebServerBenchmarkRunner._run_one_test):

8:59 PM Changeset in webkit [219856] by Chris Dumez
  • 184 edits in trunk/Source

ExceptionCode enumeration should use modern exception names
​https://bugs.webkit.org/show_bug.cgi?id=174794

Reviewed by Geoffrey Garen.

Source/WebCore:

ExceptionCode enumeration should use modern exception names consistently.
This makes the code nicer and closer to the text of the specification.

Source/WebKitLegacy/mac:

  • DOM/ExceptionHandlers.mm:

(raiseNotSupportedErrorException):

8:07 PM Changeset in webkit [219855] by Chris Dumez
  • 3 edits in trunk/Source/WebKit

[WK2][Cocoa] Allow overriding the ITP data removal internal using a default
​https://bugs.webkit.org/show_bug.cgi?id=174802
<rdar://problem/33497898>

Reviewed by Sam Weinig.

Allow overriding the ITP data removal internal using a default to facilitate testing.
Can be used like so:
defaults write -g ResourceLoadStatisticsMinimumTimeBetweenDataRecordsRemoval 60

Will cause us to write every 60 seconds instead of 3600.

  • Shared/WebPreferencesDefinitions.h:
  • UIProcess/Cocoa/WebResourceLoadStatisticsStoreCocoa.mm:

(WebKit::WebResourceLoadStatisticsStore::registerUserDefaultsIfNeeded):

6:58 PM Changeset in webkit [219854] by commit-queue@webkit.org
  • 14 edits
    10 copies
    11 moves
    2 adds in trunk/Tools

Add BenchmarkRunner patches with WebDriver support for each testing plan
​https://bugs.webkit.org/show_bug.cgi?id=174443

Patch by Matthew Stewart <​matthew_r_stewart@apple.com> on 2017-07-24
Reviewed by Dewei Zhu, Stephanie Lewis.

  • Scripts/webkitpy/benchmark_runner/benchmark_builder.py:

(BenchmarkBuilder.enter):

  • Scripts/webkitpy/benchmark_runner/data/patches/webdriver/ARES-6.patch:
  • Scripts/webkitpy/benchmark_runner/data/patches/webdriver/ContentAnimation.patch:
  • Scripts/webkitpy/benchmark_runner/data/patches/webdriver/Dromaeo.patch:
  • Scripts/webkitpy/benchmark_runner/data/patches/webdriver/JSBench.patch:
  • Scripts/webkitpy/benchmark_runner/data/patches/webdriver/JetStream.patch:
  • Scripts/webkitpy/benchmark_runner/data/patches/webdriver/Kraken.patch:
  • Scripts/webkitpy/benchmark_runner/data/patches/webdriver/MotionMark.patch:
  • Scripts/webkitpy/benchmark_runner/data/patches/webdriver/Octane.patch:
  • Scripts/webkitpy/benchmark_runner/data/patches/webdriver/Speedometer.patch:
  • Scripts/webkitpy/benchmark_runner/data/patches/webdriver/SunSpider.patch:
  • Scripts/webkitpy/benchmark_runner/data/patches/webserver/ARES-6.patch:
  • Scripts/webkitpy/benchmark_runner/data/patches/webserver/Animometer.patch:
  • Scripts/webkitpy/benchmark_runner/data/patches/webserver/ContentAnimation.patch:
  • Scripts/webkitpy/benchmark_runner/data/patches/webserver/Dromaeo.patch:
  • Scripts/webkitpy/benchmark_runner/data/patches/webserver/JSBench.patch:
  • Scripts/webkitpy/benchmark_runner/data/patches/webserver/JetStream.patch:
  • Scripts/webkitpy/benchmark_runner/data/patches/webserver/Kraken.patch:
  • Scripts/webkitpy/benchmark_runner/data/patches/webserver/MotionMark.patch:
  • Scripts/webkitpy/benchmark_runner/data/patches/webserver/Octane.patch:
  • Scripts/webkitpy/benchmark_runner/data/patches/webserver/Speedometer.patch:
  • Scripts/webkitpy/benchmark_runner/data/patches/webserver/SunSpider.patch:
  • Scripts/webkitpy/benchmark_runner/data/plans/ares6.plan:
  • Scripts/webkitpy/benchmark_runner/data/plans/content-animation.plan:
  • Scripts/webkitpy/benchmark_runner/data/plans/dromaeo-cssquery.plan:
  • Scripts/webkitpy/benchmark_runner/data/plans/dromaeo-dom.plan:
  • Scripts/webkitpy/benchmark_runner/data/plans/dromaeo-jslib.plan:
  • Scripts/webkitpy/benchmark_runner/data/plans/jetstream.plan:
  • Scripts/webkitpy/benchmark_runner/data/plans/jsbench.plan:
  • Scripts/webkitpy/benchmark_runner/data/plans/kraken.plan:
  • Scripts/webkitpy/benchmark_runner/data/plans/motionmark.plan:
  • Scripts/webkitpy/benchmark_runner/data/plans/octane.plan:
  • Scripts/webkitpy/benchmark_runner/data/plans/speedometer.plan:
  • Scripts/webkitpy/benchmark_runner/data/plans/sunspider.plan:
6:42 PM Changeset in webkit [219853] by commit-queue@webkit.org
  • 10 edits in trunk/Tools

Add functions to autoinstaller needed for Benchmark Runner script
​https://bugs.webkit.org/show_bug.cgi?id=174331

Patch by Matthew Stewart <​matthew_r_stewart@apple.com> on 2017-07-24
Reviewed by Dean Johnson, Dewei Zhu, Stephanie Lewis.

Adds autoinstaller functions to install selenium and webdriver binaries
which will be used by the browser driver part of Benchmark Runner.

  • Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py:

(BrowserDriver.restore_env):
(BrowserDriver):
(BrowserDriver.get_webdriver_binary_path):

  • Scripts/webkitpy/benchmark_runner/browser_driver/linux_chrome_driver.py:

(LinuxChromeDriver.launch_driver):

  • Scripts/webkitpy/benchmark_runner/browser_driver/linux_firefox_driver.py:

(LinuxFirefoxDriver.launch_driver):

  • Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py:

(OSXChromeDriver.launch_driver):
(OSXChromeCanaryDriver.launch_driver):

  • Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py:

(OSXFirefoxDriver.launch_driver):
(OSXFirefoxNightlyDriver.launch_driver):

  • Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
  • Scripts/webkitpy/benchmark_runner/utils.py:

(get_driver_binary_path):

  • Scripts/webkitpy/common/system/autoinstall.py:

(AutoInstaller._unzip):

  • Scripts/webkitpy/thirdparty/init.py:

(AutoinstallImportHook.find_module):
(AutoinstallImportHook._install_selenium):
(AutoinstallImportHook):
(AutoinstallImportHook._install_chromedriver):
(AutoinstallImportHook._install_geckodriver):
(AutoinstallImportHook.get_latest_pypi_url):
(AutoinstallImportHook.install_binary):
(autoinstall_everything):
(get_driver_filename):
(get_os_info):

6:17 PM Changeset in webkit [219852] by Simon Fraser
  • 2 edits in trunk/Source/WebKit

[iOS WK2] Crash under PageOverlayController::uninstallPageOverlay when doing multiple finds
​https://bugs.webkit.org/show_bug.cgi?id=174806
rdar://problem/33501664

Reviewed by Tim Horton.

Calling TextIndicator::createWithSelectionInFrame can trigger layout via VisibleSelection code,
which can re-enter FindController::updateFindIndicator which has by now removed m_findIndicatorOverlay
from pageOverlayController's map, but not deleted it. The second call to uninstallPageOverlay()
thus crashes at m_overlayGraphicsLayers.take(&overlay)->removeFromParent().

Fix by nulling out m_findIndicatorOverlay as soon as we uninstall it.

  • WebProcess/WebPage/ios/FindControllerIOS.mm:

(WebKit::FindController::updateFindIndicator):

5:51 PM Changeset in webkit [219851] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Settings: Some controls overlay settings header
​https://bugs.webkit.org/show_bug.cgi?id=174804

Patch by Nikita Vasilyev <​me@elv1s.ru> on 2017-07-24
Reviewed by Matt Baker.

  • UserInterface/Views/SettingsTabContentView.css:

(.content-view.settings .navigation-bar):

5:40 PM Changeset in webkit [219850] by commit-queue@webkit.org
  • 11 edits in trunk/Tools

Add WebDriver support in browser driver part of BenchmarkRunner
​https://bugs.webkit.org/show_bug.cgi?id=174445

Patch by Matthew Stewart <​matthew_r_stewart@apple.com> on 2017-07-24
Reviewed by Stephanie Lewis.

Adds a launch_driver function to each BrowserDriver subclass. This
function sets up the arguments for the webdriver and launches the
webdriver specific to that browser.

  • Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py:

(BrowserDriver.launch_webdriver):
(BrowserDriver):

  • Scripts/webkitpy/benchmark_runner/browser_driver/linux_browser_driver.py:

(LinuxBrowserDriver.launch_webdriver):

  • Scripts/webkitpy/benchmark_runner/browser_driver/linux_chrome_driver.py:

(LinuxChromeDriver.launch_url):
(LinuxChromeDriver):
(LinuxChromeDriver.launch_driver):

  • Scripts/webkitpy/benchmark_runner/browser_driver/linux_epiphany_driver.py:

(EpiphanyBrowserDriver.launch_url):
(EpiphanyBrowserDriver):
(EpiphanyBrowserDriver.launch_driver):

  • Scripts/webkitpy/benchmark_runner/browser_driver/linux_firefox_driver.py:

(LinuxFirefoxDriver):
(LinuxFirefoxDriver.launch_url):
(LinuxFirefoxDriver.launch_driver):

  • Scripts/webkitpy/benchmark_runner/browser_driver/linux_minibrowsergtk_driver.py:

(GTKMiniBrowserDriver.launch_url):
(GTKMiniBrowserDriver):
(GTKMiniBrowserDriver.launch_driver):

  • Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:

(OSXBrowserDriver._launch_webdriver):
(OSXBrowserDriver):
(OSXBrowserDriver._screen_size):
(OSXBrowserDriver._insert_url):

  • Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py:

(OSXChromeDriver):
(OSXChromeDriver.launch_url):
(OSXChromeDriver.launch_driver):
(OSXChromeCanaryDriver):
(OSXChromeCanaryDriver.launch_url):
(OSXChromeCanaryDriver.launch_driver):

  • Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py:

(OSXFirefoxDriver):
(OSXFirefoxDriver.launch_url):
(OSXFirefoxDriver.launch_driver):
(OSXFirefoxNightlyDriver):
(OSXFirefoxNightlyDriver.launch_url):
(OSXFirefoxNightlyDriver.launch_driver):

  • Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:

(OSXSafariDriver.launch_driver):

4:54 PM Changeset in webkit [219849] by pvollan@apple.com
  • 2 edits in trunk/LayoutTests

[Win] The tests fast/text/line-height-minimumFontSize*.html are failing.
​https://bugs.webkit.org/show_bug.cgi?id=174801

Unreviewed test gardening, update test expectations for failing tests.

  • platform/win/TestExpectations:
4:52 PM Changeset in webkit [219848] by aestes@apple.com
  • 2 edits in trunk/Source/WebCore

Consider implementing W3C Payment Request API
​https://bugs.webkit.org/show_bug.cgi?id=174796

Reviewed by Daniel Bates.

Add Payment Request to features.json as "Under Consideration".

  • features.json:
4:41 PM Changeset in webkit [219847] by Matt Lewis
  • 2 edits in trunk/LayoutTests

Marked tests as failures.
<rdar://problem/33437597>

Unreviewed test gardening.

  • platform/mac-highsierra/TestExpectations:
4:12 PM Changeset in webkit [219846] by Matt Lewis
  • 2 edits in trunk/LayoutTests

Fixed typo in test expectations.
​https://bugs.webkit.org/show_bug.cgi?id=173010

Unreviewed gardening.

  • platform/ios-simulator-wk2/TestExpectations:
3:50 PM Changeset in webkit [219845] by Chris Dumez
  • 3 edits in trunk/Source/WebKit

Fix lifetime management issue in ResourceLoadStatisticsPersistentStorage::scheduleOrWriteMemoryStore()
​https://bugs.webkit.org/show_bug.cgi?id=174790

Reviewed by Brady Eidson.

Fix lifetime management issue in ResourceLoadStatisticsPersistentStorage::scheduleOrWriteMemoryStore().
WorkQueue::dispatchAfter() keeps the WorkQueue alive because its implementation keeps a strong ref to
|this|. As a result, the lambda passed to dispatchAfter(), which calls writeMemoryStoreToDisk(), can
get executed after the store is gone.

To address the issue, we now use a RunLoop::Timer to schedule the write, instead of a
WorkQueue::dispatchAfter() call. This way, we are guaranteed that the callback will not get called
after the store has been destroyed.

  • UIProcess/Storage/ResourceLoadStatisticsPersistentStorage.cpp:

(WebKit::ResourceLoadStatisticsPersistentStorage::ResourceLoadStatisticsPersistentStorage):
(WebKit::ResourceLoadStatisticsPersistentStorage::asyncWriteTimerFired):
(WebKit::ResourceLoadStatisticsPersistentStorage::scheduleOrWriteMemoryStore):
(WebKit::ResourceLoadStatisticsPersistentStorage::finishAllPendingWorkSynchronously):
(WebKit::ResourceLoadStatisticsPersistentStorage::ref):
(WebKit::ResourceLoadStatisticsPersistentStorage::deref):

  • UIProcess/Storage/ResourceLoadStatisticsPersistentStorage.h:
3:42 PM Changeset in webkit [219844] by pvollan@apple.com
  • 2 edits in trunk/LayoutTests

[Win] Async image tests are failing.
​https://bugs.webkit.org/show_bug.cgi?id=174653

Unreviewed test gardening, update test expectations for async image tests.

  • platform/win/TestExpectations:
3:29 PM Changeset in webkit [219843] by Simon Fraser
  • 2 edits in trunk/LayoutTests

Rebaseline this test. The previous result was generated using an older iOS SDK.

  • fast/events/ios/no-touch-events-when-stopping-momentum-scroll-in-mainframe-expected.txt:
3:26 PM Changeset in webkit [219842] by pvollan@apple.com
  • 2 edits in trunk/LayoutTests

Mark Skia font test as image only failure on Windows.

Unreviewed test gardening.

  • platform/win/TestExpectations:
2:57 PM Changeset in webkit [219841] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

LayoutTest userscripts/user-script-audio-document.html failing on High Sierra
​https://bugs.webkit.org/show_bug.cgi?id=174726
rdar://problem/30059973

Patch by Jeremy Jones <​jeremyj@apple.com> on 2017-07-24
Reviewed by Alexey Proskuryakov.

Underlying issue has been resolved.
Re-enable test: userscripts/user-script-audio-document.html

  • platform/mac-highsierra/TestExpectations:
2:57 PM Changeset in webkit [219840] by Konstantin Tokarev
  • 2 edits in trunk/Source/WebCore

Unreviewed attempt to fix Mac cmake build

  • PlatformMac.cmake:
2:53 PM Changeset in webkit [219839] by Simon Fraser
  • 2 edits in trunk/LayoutTests

Fix typo (Timout -> Timeout).

  • platform/mac-wk2/TestExpectations:
2:42 PM Changeset in webkit [219838] by Chris Dumez
  • 3 edits in trunk/Source/WebKit

Unreviewed, rolling out r219828.

Causes debug assertions to be hit on iOS

Reverted changeset:

"Fix lifetime management issue in
ResourceLoadStatisticsPersistentStorage::scheduleOrWriteMemoryStore()"
​https://bugs.webkit.org/show_bug.cgi?id=174790
​http://trac.webkit.org/changeset/219828

2:21 PM Changeset in webkit [219837] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

5 wav media layoutTest timeouts on High Sierra
​https://bugs.webkit.org/show_bug.cgi?id=174725
rdar://problem/30182218

Patch by Jeremy Jones <​jeremyj@apple.com> on 2017-07-24
Reviewed by Andreas Kling.

Underlying issue is fixed. Re-enable tests on High Sierra.

media/audio-controls-timeline-in-media-document.html
media/audio-data-url.html
media/media-document-audio-controls-visible.html
media/media-document-audio-repaint.html
media/media-document-audio-size.html

  • platform/mac-highsierra/TestExpectations:
1:58 PM Changeset in webkit [219836] by Wenson Hsieh
  • 3 edits
    1 copy in trunk/Tools

[Mac WK2] Add an API test to cover r219765 (null dereference in [WKWebView dealloc])
​https://bugs.webkit.org/show_bug.cgi?id=174793

Reviewed by Tim Horton.

Adds a new unit test that invokes some asynchronous NSTextInputClient SPI methods as the web view is tearing
down. Without r219765, this test will dereference null and crash.

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/Tests/TestWebKitAPI/mac/NSTextInputClientSPI.h: Added.
  • TestWebKitAPI/Tests/mac/WKWebViewSelectionTests.mm:

(TEST):

1:20 PM Changeset in webkit [219835] by jmarcell@apple.com
  • 7 edits in branches/safari-604-branch/Source

Versioning.

1:15 PM Changeset in webkit [219834] by jmarcell@apple.com
  • 1 copy in tags/Safari-604.1.33

Tag Safari-604.1.33.

12:16 PM Changeset in webkit [219833] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebDriver

WebDriver: rename m_browsingContext as m_currentBrowsingContext in Session
​https://bugs.webkit.org/show_bug.cgi?id=174783

Patch by Carlos Garcia Campos <​cgarcia@igalia.com> on 2017-07-24
Reviewed by Brian Burg.

We have m_toplevelBrowsingContext and m_browsingContext, which is confusing. m_browsingContext is actually the
current browsing context, and the spec also refers to it as the current browsing context, so better use
m_currentBrowsingContext.

  • Session.cpp:

(WebDriver::Session::switchToTopLevelBrowsingContext):
(WebDriver::Session::switchToBrowsingContext):
(WebDriver::Session::switchToFrame):
(WebDriver::Session::switchToParentFrame):
(WebDriver::Session::computeElementLayout):
(WebDriver::Session::findElements):
(WebDriver::Session::isElementSelected):
(WebDriver::Session::getElementText):
(WebDriver::Session::getElementTagName):
(WebDriver::Session::isElementEnabled):
(WebDriver::Session::isElementDisplayed):
(WebDriver::Session::getElementAttribute):
(WebDriver::Session::waitForNavigationToComplete):
(WebDriver::Session::elementClear):
(WebDriver::Session::elementSendKeys):
(WebDriver::Session::elementSubmit):
(WebDriver::Session::executeScript):

  • Session.h:
11:55 AM Changeset in webkit [219832] by Michael Catanzaro
  • 2 edits in trunk/Source/WebKit

[GTK][WPE] Stop using AutodrainedPool in IconDatabase
​https://bugs.webkit.org/show_bug.cgi?id=174791

Reviewed by Alex Christensen.

AutodrainedPool seems to be some NS garbage collection thing that has no implementation on
other platforms. Now that IconDatabase is used only by GTK and WPE, we can stop using it.

  • UIProcess/API/glib/IconDatabase.cpp:

(WebKit::IconDatabase::setIconDataForIconURL):
(WebKit::IconDatabase::setIconURLForPageURL):
(WebKit::IconDatabase::iconDatabaseSyncThread):
(WebKit::IconDatabase::performURLImport):
(WebKit::IconDatabase::readFromDatabase):

11:42 AM Changeset in webkit [219831] by Chris Dumez
  • 200 edits in trunk/Source

Make ExceptionCode a proper enumeration
​https://bugs.webkit.org/show_bug.cgi?id=174771

Reviewed by Sam Weinig.

Make ExceptionCode a proper enumeration instead of a typedef to uint8_t.

Source/WebCore:

  • Modules/fetch/FetchBody.h:

(WebCore::FetchBody::formData):

  • Modules/indexeddb/shared/IDBError.h:

(WebCore::IDBError::encode):
(WebCore::IDBError::decode):

  • bindings/js/JSSubtleCryptoCustom.cpp:

(WebCore::rejectWithException):

  • dom/Exception.h:
  • dom/ExceptionCode.h:
  • fileapi/FileReaderSync.cpp:

(WebCore::errorCodeToExceptionCode):

  • html/canvas/WebGLRenderingContextBase.cpp:

(WebCore::WebGLRenderingContextBase::texSubImage2D):
(WebCore::WebGLRenderingContextBase::texImage2D):

  • xml/XMLHttpRequest.cpp:

(WebCore::XMLHttpRequest::createRequest):

  • xml/XMLHttpRequest.h:

Source/WebKitLegacy/win:

  • DOMCoreClasses.cpp:

(DOMDocument::createEvent):

  • WebView.cpp:

(WebView::prepareCandidateWindow):

11:34 AM Changeset in webkit [219830] by commit-queue@webkit.org
  • 5 edits in trunk/Tools

[Win] Implement Authentication dialog in MiniBrowser
​https://bugs.webkit.org/show_bug.cgi?id=174662

Patch by Basuke Suzuki <Basuke Suzuki> on 2017-07-24
Reviewed by Alex Christensen.

  • MiniBrowser/win/Common.cpp:

(CustomUserAgent):
(DisplayAuthDialog):
(AuthDialogProc):

  • MiniBrowser/win/MiniBrowserLib.rc:
  • MiniBrowser/win/MiniBrowserLibResource.h:
  • MiniBrowser/win/ResourceLoadDelegate.cpp:

(ResourceLoadDelegate::didReceiveAuthenticationChallenge):

11:07 AM Changeset in webkit [219829] by Simon Fraser
  • 12 edits
    2 adds in trunk

Change "client" coordinates back to match scrolling coordinates
​https://bugs.webkit.org/show_bug.cgi?id=174734
rdar://problem/33336930

Reviewed by Tim Horton.

Baidu.com (which uses jQuery), and various iOS apps make the assumption that getBoundingClientRect() returns a rectangle
that can be used to set or compare with the scroll position. With visual viewports, that assumption is no longer valid
when the page is zoomed, or when the keyboard has caused the visual viewport to detach from the layout viewport.

At this point the compatibility cost of shipping layout viewport-based client rects seems higher than the gain, so revert
to the shipping behavior. This reverts r216803, and will re-introduce bugs that occurred on zoomed pages on macOS,
many of which are noted in webkit.org/b/170981.

  • page/FrameView.cpp:

(WebCore::FrameView::documentToClientOffset):

LayoutTests:
Revert "client" coordinates to be in scrolling coordinates
​https://bugs.webkit.org/show_bug.cgi?id=174734
rdar://problem/33336930

Reviewed by Tim Horton.

Rebaseline.

  • fast/events/ios/no-touch-events-when-stopping-momentum-scroll-in-mainframe-expected.txt:
  • fast/visual-viewport/client-coordinates-relative-to-layout-viewport-expected.txt:
  • fast/visual-viewport/client-rects-relative-to-layout-viewport-expected.txt:
  • fast/visual-viewport/zoomed-fixed-expected.txt:
  • fast/visual-viewport/zoomed-fixed-header-and-footer-expected.txt:
  • fast/zooming/client-rect-in-fixed-zoomed-expected.txt:
  • platform/ios-wk2/fast/visual-viewport/client-rects-relative-to-layout-viewport-expected.txt:
  • platform/ios-wk2/imported/w3c/web-platform-tests/cssom-view/elementFromPoint-expected.txt: Added.
  • platform/ios/fast/visual-viewport/zoomed-fixed-expected.txt:
  • platform/ios/fast/visual-viewport/zoomed-fixed-header-and-footer-expected.txt:
10:43 AM Changeset in webkit [219828] by Chris Dumez
  • 3 edits in trunk/Source/WebKit

Fix lifetime management issue in ResourceLoadStatisticsPersistentStorage::scheduleOrWriteMemoryStore()
​https://bugs.webkit.org/show_bug.cgi?id=174790

Reviewed by Brady Eidson.

Fix lifetime management issue in ResourceLoadStatisticsPersistentStorage::scheduleOrWriteMemoryStore().
WorkQueue::dispatchAfter() keeps the WorkQueue alive because its implementation keeps a strong ref to
|this|. As a result, the lambda passed to dispatchAfter(), which calls writeMemoryStoreToDisk(), can
get executed after the store is gone.

  • UIProcess/Storage/ResourceLoadStatisticsPersistentStorage.cpp:

(WebKit::ResourceLoadStatisticsPersistentStorage::ResourceLoadStatisticsPersistentStorage):
(WebKit::ResourceLoadStatisticsPersistentStorage::scheduleOrWriteMemoryStore):

  • UIProcess/Storage/ResourceLoadStatisticsPersistentStorage.h:

(WebKit::ResourceLoadStatisticsPersistentStorage::createWeakPtr):

10:31 AM Changeset in webkit [219827] by Jonathan Bedard
  • 3 edits in trunk/Tools

Handle case where line_numbers is None instead of an array of line numbers
​https://bugs.webkit.org/show_bug.cgi?id=174775

Reviewed by Aakash Jain.

Added files set line_numbers to None in process_file.

  • Scripts/webkitpy/style/filereader.py:

(TextFileReader.process_file): Handle case where line_number is set to None.

  • Scripts/webkitpy/style/main_unittest.py:

(ExpectationLinterInStyleCheckerTest.test_linter_added_file_with_error): Test case of an added file.

10:13 AM Changeset in webkit [219826] by Matt Baker
  • 2 edits in trunk/Source/WebInspectorUI

Web Inspector: should only show Canvases in resource type filter if debug setting enabled
​https://bugs.webkit.org/show_bug.cgi?id=174765
<rdar://problem/33479009>

Reviewed by Devin Rousso.

  • UserInterface/Views/ResourceSidebarPanel.js:

(WebInspector.ResourceSidebarPanel):

9:41 AM Changeset in webkit [219825] by Matt Lewis
  • 2 edits in trunk/LayoutTests

Marked tiled-drawing/scrolling/scroll-snap/scroll-snap-mandatory-mainframe-vertical.html as failure.
​https://bugs.webkit.org/show_bug.cgi?id=172148

Unreviewed test gardening.

  • platform/mac-wk2/TestExpectations:
9:06 AM Changeset in webkit [219824] by Darin Adler
  • 2 edits in trunk/LayoutTests

Remove race from one plug-in test
​https://bugs.webkit.org/show_bug.cgi?id=130653

Reviewed by Antti Koivisto.

  • plugins/plugin-remove-readystatechange.html: Updated test to use waitUntilDone/notifyDone

rather than racing. Added a computation of offsetLeft to trigger layout and adding a long
comment explaining why this is both needed and potentially insufficient in the long run.

9:01 AM Changeset in webkit [219823] by clopez@igalia.com
  • 3 edits in trunk/Source/WebCore/PAL

[CMake] libtasn1 should not be required when not enabling subtle_crypto
​https://bugs.webkit.org/show_bug.cgi?id=174785

Reviewed by Žan Doberšek.

  • pal/PlatformGTK.cmake:
  • pal/PlatformWPE.cmake:
8:43 AM Changeset in webkit [219822] by jmarcell@apple.com
  • 4 edits
    10 adds in branches/safari-604-branch

Cherry-pick r219665.

7:46 AM Changeset in webkit [219821] by mark.lam@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Gardening: fixed C Loop build after r219790.
​https://bugs.webkit.org/show_bug.cgi?id=174696

Not reviewed.

  • assembler/testmasm.cpp:
7:27 AM Changeset in webkit [219820] by zandobersek@gmail.com
  • 5 edits in trunk

[WPE] Add libepoxy to the Jhbuild moduleset
​https://bugs.webkit.org/show_bug.cgi?id=174711

Reviewed by Carlos Alberto Lopez Perez.

.:

libepoxy 1.3.1 that's widely available in current stable distributions (Debian stable,
Ubuntu LTS) does suffice our needs, but also contains a bug that incorrectly determines
the current EGL context and the API version of OpenGL that's bound to that context.
Focusing on experiences on Debian systems, while the current stable Debian release has
this bug patched, the package for the testing distribution of Debian removed that same
patch for whatever reason, despite using the 1.3.1 version as the package basis.

To avoid this, libepoxy 1.4.3 is now added to WPE's Jhbuild moduleset. The WPE port
also now demands at least the 1.4.0 version to be available when configuring.

We should revisit the minimum version for libepoxy in the future if the 1.3 release
branch gets updated with the proper fix.

  • Source/cmake/FindLibEpoxy.cmake:
  • Source/cmake/OptionsWPE.cmake:

Tools:

  • wpe/jhbuild.modules: Add libepoxy 1.4.3 to WPE's Jhbuild moduleset.
7:24 AM Changeset in webkit [219819] by zandobersek@gmail.com
  • 11 edits
    3 adds
    1 delete in trunk

[WPE] libepoxy headers can use EGL_CAST, which might not be defined by eglplatform.h
​https://bugs.webkit.org/show_bug.cgi?id=174780

Reviewed by Carlos Garcia Campos.

Source/WebCore:

Newer versions of libepoxy provide EGL definitions that already use the EGL_CAST macro.
We'd like to compile on systems where the eglplatform.h header doesn't yet provide
that macro that was added only recently (e.g. it's available in Mesa 17.1, but not
before).

To address that, the EpoxyEGL.h header is added that first includes the libepoxy's EGL
header and then provides the EGL_CAST definition in case the eglplatform.h header doesn't.
This header should be included in place of <epoxy/egl.h> (which is included in this new
header).

The EpoxyEGL.h and EpoxyShims.h headers are also moved under the platform/graphics/epoxy/
directory, with the new directory added to the list of inclusion paths for WPE.

  • PlatformWPE.cmake:
  • platform/graphics/PlatformDisplay.cpp:
  • platform/graphics/cairo/CairoUtilities.cpp:
  • platform/graphics/cairo/ImageBufferCairo.cpp:
  • platform/graphics/egl/GLContextEGL.cpp:
  • platform/graphics/egl/GLContextEGLWPE.cpp:
  • platform/graphics/epoxy/EpoxyEGL.h: Added.
  • platform/graphics/epoxy/EpoxyShims.h: Renamed from Source/WebCore/platform/graphics/EpoxyShims.h.
  • platform/graphics/opengl/Extensions3DOpenGLES.cpp:
  • platform/graphics/wpe/PlatformDisplayWPE.cpp:

Tools:

  • WebKitTestRunner/wpe/HeadlessViewBackend.cpp:

Manually define the EGL_CAST macro to the C++ version that uses static_cast<>
in case the eglplatform.h header doesn't provide that macro. This replicates
the work in WebCore's EpoxyEGL.h header, but we can't include that header here.

6:50 AM Changeset in webkit [219818] by zandobersek@gmail.com
  • 1 edit
    1 delete in trunk/Source/WebCore

[CoordinatedGraphics] Remove unused GLDefs.h header
​https://bugs.webkit.org/show_bug.cgi?id=174712

Reviewed by Michael Catanzaro.

  • platform/graphics/opengl/GLDefs.h: Remove this unused header.

As far as my recollection goes it was used in the IPC-based
CoordinatedGraphics subsystem, which has been removed already.

5:46 AM Changeset in webkit [219817] by Carlos Garcia Campos
  • 1 copy in releases/WebKitGTK/webkit-2.16.6

WebKitGTK+ 2.16.6

5:45 AM Changeset in webkit [219816] by Carlos Garcia Campos
  • 4 edits in releases/WebKitGTK/webkit-2.16

Unreviewed. Update OptionsGTK.cmake and NEWS for 2.16.6 release.

.:

  • Source/cmake/OptionsGTK.cmake:

Source/WebKit2:

  • gtk/NEWS: Add release notes for 2.16.6.
4:57 AM WebKitGTK/2.16.x edited by Carlos Garcia Campos
(diff)
4:15 AM WebKitGTK/2.16.x edited by Carlos Garcia Campos
(diff)
4:13 AM Changeset in webkit [219815] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.16/Source/JavaScriptCore

Unreviewed. Fix the build with GCC 4.9 after merge r217438.

  • bytecompiler/BytecodeGenerator.h:

(JSC::StructureForInContext::addGetInst):

4:09 AM Changeset in webkit [219814] by Carlos Garcia Campos
  • 3 edits in releases/WebKitGTK/webkit-2.16/Source/ThirdParty/ANGLE

Merge r219446 - eglplatform.h does not support Wayland
​https://bugs.webkit.org/show_bug.cgi?id=163482

This makes it possible to build WebKitGTK+ when the target system has only Wayland support,
but no X11 (and therefore the X11 headers are not present).

Reviewed by Alex Christensen.

  • include/EGL/eglplatform.h: Add Wayland typedefs when WL_EGL_PLATFORM is defined (for example

by including wayland-egl.h before including EGL/egl.h). Also, include the X11 headers only
when ANGLE_USE_X11 is defined and, for consistency with Mesa's version of the header, when
MESA_EGL_NO_X11_HEADERS is not defined.

4:07 AM Changeset in webkit [219813] by Carlos Garcia Campos
  • 3 edits in releases/WebKitGTK/webkit-2.16/Source/WebCore

Merge r219332, r219447 - [GTK] Spin buttons on input type number appear over the value itself for small widths
​https://bugs.webkit.org/show_bug.cgi?id=173572

Reviewed by Carlos Garcia Campos.

Source/WebCore:

When drawing the spin buttons, override the width of the input
element to increment it with the width of the spin button.
This ensures that we don't end up covering the input values with
the spin buttons.

Do this also for user controlled styles, because most web authors
won't test how their site renders on WebKitGTK+, and they will
assume spin buttons in the order of 13 pixels wide (that is what
most browsers use), but the GTK+ spin button is much wider (66 pixels).

  • rendering/RenderTheme.cpp:

(WebCore::RenderTheme::adjustStyle):

  • rendering/RenderThemeGtk.cpp:

(WebCore::RenderThemeGtk::adjustTextFieldStyle): Call the theme's adjustTextFieldStyle() also for user controlled styles.
(WebCore::RenderThemeGtk::adjustInnerSpinButtonStyle):

REGRESSION(r219332): [GTK] 9 new failures on fast/forms spinbutton related tests
​https://bugs.webkit.org/show_bug.cgi?id=174395

Reviewed by Carlos Garcia Campos.

Source/WebCore:

Before r219332 the height of the spin button widget was
calculated as the maximum value between the individual button
( the [+] or [-] ) width (33 pixels) and height (16 pixels).
And r219332 caused the height of the widget to be calculated as
the height of the button (16 pixels), which was incorrect as
each button should be first expanded vertically to fit the
preferred size of the widget.

Fix this by making the calculations about the spin button widget
on a new function spinButtonSize() that takes this into account,
and use this values both for adjusting the style of the input
field and the spin button widget itself.

  • rendering/RenderThemeGtk.cpp:

(WebCore::spinButtonSize):
(WebCore::RenderThemeGtk::adjustTextFieldStyle):
(WebCore::RenderThemeGtk::adjustInnerSpinButtonStyle):

3:57 AM Changeset in webkit [219812] by Carlos Garcia Campos
  • 3 edits
    1 add in releases/WebKitGTK/webkit-2.16

Merge r218819 - Crash in JSC::Lexer<unsigned char>::setCode
​https://bugs.webkit.org/show_bug.cgi?id=172754

Reviewed by Mark Lam.

JSTests:

  • stress/dont-reserve-huge-capacity-lexer.js: Added.

(catch):

Source/JavaScriptCore:

The lexer was asking one of its buffers to reserve initial space that
was O(text size in bytes). For large sources, this would end up causing
the vector to overflow and crash. This patch changes this code be like
the Lexer's other buffers and to only reserve a small starting buffer.

  • parser/Lexer.cpp:

(JSC::Lexer<T>::setCode):

3:53 AM Changeset in webkit [219811] by Carlos Garcia Campos
  • 3 edits
    2 adds in releases/WebKitGTK/webkit-2.16

Merge r216813 - Elements should be inserted into a template element as its content's last child
​https://bugs.webkit.org/show_bug.cgi?id=171373
<rdar://problem/31862949>

Reviewed by Ryosuke Niwa.

Source/WebCore:

Before this change, our HTML parser obeys the following premises:
1) A fostering child whose parent is a table should be inserted before its parent and under its grandparent.
2) When inserting into a template element, an element should be inserted into its content.

Let's walk through the example:
a) Before eventhandler takes place
template
table

svg <- parser

b) After eventhandler takes place
template

table

svg <- parser

c) after parsing svg
template

content

svg
(table)

table

Finally, in the example, the svg element will be inserted into the content of the template element while
having its next sibling point to the table element. However, the table element is actually under the
template element not its content.

This messy tree is constructed because the second premise is incompleted. It should be: When inserting into
a template element, an element should be inserted into its content as its last child.
Quoted from Step 3 of ​https://html.spec.whatwg.org/multipage/syntax.html#appropriate-place-for-inserting-a-node
A correct tree will then looks like:
template

content

svg

table

Tests: fast/dom/HTMLTemplateElement/insert-fostering-child-crash.html

fast/dom/HTMLTemplateElement/insert-fostering-child.html

  • html/parser/HTMLConstructionSite.cpp:

(WebCore::insert):
By nullifying task.nextChild, it will force the parser to append the element as task.parent's last child.

LayoutTests:

  • fast/dom/HTMLTemplateElement/insert-fostering-child-expected.txt: Added.
  • fast/dom/HTMLTemplateElement/insert-fostering-child.html: Added.
3:51 AM Changeset in webkit [219810] by Carlos Garcia Campos
  • 3 edits
    1 add in releases/WebKitGTK/webkit-2.16

Merge r215351 - Should use flushDirect() when flushing the scopeRegister due to needsScopeRegister().
​https://bugs.webkit.org/show_bug.cgi?id=170661
<rdar://problem/31579046>

Reviewed by Filip Pizlo.

JSTests:

  • stress/regress-170661.js: Added.

Source/JavaScriptCore:

Previously, we were using flush() to flush the outermost frame's scopeRegister.
This is incorrect because flush() expects the VirtualRegister value passed to
it to be that of the top most inlined frame. In the event that we reach a
terminal condition while inside an inlined frame, flush() will end up flushing
the wrong register. The fix is simply to use flushDirect() instead.

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::flush):

3:49 AM Changeset in webkit [219809] by Carlos Garcia Campos
  • 3 edits
    1 add in releases/WebKitGTK/webkit-2.16

Merge r215596 - virtualThunkFor() needs to materialize its of tagMaskRegister for tail calls.
​https://bugs.webkit.org/show_bug.cgi?id=171079
<rdar://problem/31684756>

Reviewed by Saam Barati.

JSTests:

  • stress/regress-171079.js: Added.

Source/JavaScriptCore:

This is needed because tail calls would restore callee saved registers (and
therefore, potentially clobber the tag registers) before jumping to the thunk.

  • jit/ThunkGenerators.cpp:

(JSC::virtualThunkFor):

3:48 AM Changeset in webkit [219808] by Carlos Garcia Campos
  • 4 edits in releases/WebKitGTK/webkit-2.16/Source/JavaScriptCore

Merge r216309 - Put does not properly consult the prototype chain
​https://bugs.webkit.org/show_bug.cgi?id=171754

Reviewed by Saam Barati.

We should do a follow up that cleans up the rest of put. See:
​https://bugs.webkit.org/show_bug.cgi?id=171759

  • runtime/JSCJSValue.cpp:

(JSC::JSValue::putToPrimitive):

  • runtime/JSObject.cpp:

(JSC::JSObject::putInlineSlow):

  • runtime/JSObjectInlines.h:

(JSC::JSObject::canPerformFastPutInline):

3:31 AM Changeset in webkit [219807] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.16/Source/JavaScriptCore

Unreviewed. Fix merge r217438.

See bug #174781.

  • bytecompiler/BytecodeGenerator.cpp:

(JSC::StructureForInContext::finalize): Use operand instead of unsignedValue.

3:28 AM Changeset in webkit [219806] by Carlos Garcia Campos
  • 13 edits
    3 adds in releases/WebKitGTK/webkit-2.16

Merge r216279 - putDirectIndex does not properly do defineOwnProperty
​https://bugs.webkit.org/show_bug.cgi?id=171591
<rdar://problem/31735695>

Reviewed by Geoffrey Garen.

JSTests:

  • stress/array-prototype-splice-making-typed-array.js:

(test):

  • stress/array-species-config-array-constructor.js:

(shouldThrow):
(test):

  • stress/put-direct-index-broken-2.js: Added.

(assert):
(test):
(makeLengthWritable):
(set get restoreOldDesc):

  • stress/put-direct-index-broken.js: Added.

(whatToTest):
(tryRunning):
(tryItOut):

  • stress/put-indexed-getter-setter.js: Added.

(foo.X.prototype.set 7):
(foo.X.prototype.get 7):
(foo.X):
(foo):

Source/JavaScriptCore:

This patch fixes putDirectIndex and its JIT implementations to be
compatible with the ES6 spec. I think our code became out of date
when we implemented ArraySpeciesCreate since ArraySpeciesCreate may
return arbitrary objects. We perform putDirectIndex on that arbitrary
object. The behavior we want is as if we performed defineProperty({configurable:true, enumerable:true, writable:true}).
However, we weren't doing this. putDirectIndex assumed it could just splat
data into any descendent of JSObject's butterfly. For example, this means
we'd just splat into the butterfly of a typed array, even though a typed
array doesn't use its butterfly to store its indexed properties in the usual
way. Also, typed array properties are non-configurable, so this operation
should throw. This also means if we saw a ProxyObject, we'd just splat
into its butterfly, but this is obviously wrong because ProxyObject should
intercept the defineProperty operation.

This patch fixes this issue by adding a whitelist of cell types that can
go down putDirectIndex's fast path. Anything not in that whitelist will
simply call into defineOwnProperty.

  • bytecode/ByValInfo.h:

(JSC::jitArrayModePermitsPutDirect):

  • dfg/DFGArrayMode.cpp:

(JSC::DFG::ArrayMode::refine):

  • jit/JITOperations.cpp:
  • runtime/ArrayPrototype.cpp:

(JSC::arrayProtoFuncSplice):

  • runtime/ClonedArguments.cpp:

(JSC::ClonedArguments::createStructure):

  • runtime/JSGenericTypedArrayViewInlines.h:

(JSC::JSGenericTypedArrayView<Adaptor>::defineOwnProperty):

  • runtime/JSObject.cpp:

(JSC::canDoFastPutDirectIndex):
(JSC::JSObject::defineOwnIndexedProperty):
(JSC::JSObject::putDirectIndexSlowOrBeyondVectorLength):
(JSC::JSObject::putDirectIndexBeyondVectorLength): Deleted.

  • runtime/JSObject.h:

(JSC::JSObject::putDirectIndex):
(JSC::JSObject::canSetIndexQuicklyForPutDirect): Deleted.

  • runtime/JSType.h:
2:54 AM Changeset in webkit [219805] by Carlos Garcia Campos
  • 5 edits
    2 adds in releases/WebKitGTK/webkit-2.16

Merge r216992 - Replace CryptoOperationData with BufferSource for WebKitSubtleCrypto
​https://bugs.webkit.org/show_bug.cgi?id=172146
<rdar://problem/32122256>

Reviewed by Brent Fulgham.

Source/WebCore:

In this patch, we replaces CryptoOperationData with BufferSource for WebKitSubtleCrypto in
the custom binding codes.

Test: crypto/webkitSubtle/import-export-raw-key-leak.html

  • bindings/js/JSWebKitSubtleCryptoCustom.cpp:

(WebCore::JSWebKitSubtleCrypto::encrypt):
(WebCore::JSWebKitSubtleCrypto::decrypt):
(WebCore::JSWebKitSubtleCrypto::sign):
(WebCore::JSWebKitSubtleCrypto::verify):
(WebCore::JSWebKitSubtleCrypto::digest):
(WebCore::JSWebKitSubtleCrypto::importKey):
(WebCore::JSWebKitSubtleCrypto::unwrapKey):

  • crypto/WebKitSubtleCrypto.idl:

LayoutTests:

  • crypto/webkitSubtle/argument-conversion-expected.txt:
  • crypto/webkitSubtle/import-export-raw-key-leak-expected.txt: Added.
  • crypto/webkitSubtle/import-export-raw-key-leak.html: Added.
2:51 AM Changeset in webkit [219804] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.16/JSTests

Merge r217018 - Unreviewed, address mlam's review feedback.

  • stress/arguments-elimination-varargs-too-many-args-arg-count.js:
2:50 AM Changeset in webkit [219803] by Carlos Garcia Campos
  • 3 edits
    1 add in releases/WebKitGTK/webkit-2.16

Merge r217016 - JSC: Incorrect LoadVarargs handling in ArgumentsEliminationPhase::transform
​https://bugs.webkit.org/show_bug.cgi?id=172208

Reviewed by Saam Barati.

JSTests:

  • stress/arguments-elimination-varargs-too-many-args-arg-count.js: Added.

(foo):
(bar):
(baz):

Source/JavaScriptCore:

  • dfg/DFGArgumentsEliminationPhase.cpp:
2:45 AM Changeset in webkit [219802] by Carlos Garcia Campos
  • 3 edits
    1 add in releases/WebKitGTK/webkit-2.16

Merge r215451 - JSArray::appendMemcpy() needs to handle copying from Undecided indexing type too.
​https://bugs.webkit.org/show_bug.cgi?id=170896
<rdar://problem/31651319>

Reviewed by JF Bastien and Keith Miller.

JSTests:

  • stress/regress-170896.js: Added.

Source/JavaScriptCore:

  • runtime/JSArray.cpp:

(JSC::JSArray::appendMemcpy):

2:41 AM Changeset in webkit [219801] by Carlos Garcia Campos
  • 13 edits
    1 add in releases/WebKitGTK/webkit-2.16

Merge r217438 - Our for-in optimization in the bytecode generator does its static analysis incorrectly
​https://bugs.webkit.org/show_bug.cgi?id=172532
<rdar://problem/32369452>

Reviewed by Mark Lam.

JSTests:

  • stress/for-in-invalidation-for-any-write.js: Added.

(assert):
(test):
(test.i):

Source/JavaScriptCore:

Our static analysis for when a for-in induction variable
is written to tried to its analysis as we generate
bytecode. This has issues, since it does not account for
the dynamic execution path of the program. Let's consider
a program where our old analysis worked:

`
for (let p in o) {

o[p]; We can transform this into a fast get_direct_pname
p = 20;
o[p]; We cannot transform this since p has been changed.

}
`

However, our static analysis did not account for loops, which exist
in JavaScript. e.g, it would incorrectly compile this program as:
`
for (let p in o) {

for (let i = 0; i < 20; ++i) {

o[p]; It transforms this to use get_direct_pname even though p will be over-written if we get here from the inner loop back edge!
p = 20;
o[p]; We correctly do not transform this.

}

}
`

Because of this flaw, I've made the optimization more conservative.
We now optimistically emit code for the optimized access. However,
if a for-in context is *ever* invalidated, before we pop it off
the stack, we rewrite the program's optimized accesses to no longer
be optimized. To do this, each context keeps track of its optimized
accesses.

This patch also adds a new bytecode, op_nop, which is just a no-op.
It was helpful to add this because reverting get_direct_pname to get_by_val
will leave us with an extra instruction word because get_direct_pname is
has a length of 7 where get_by_val has a length of 6. This leaves us with
an extra slot that we fill with an op_nop.

  • bytecode/BytecodeDumper.cpp:

(JSC::BytecodeDumper<Block>::dumpBytecode):

  • bytecode/BytecodeList.json:
  • bytecode/BytecodeUseDef.h:

(JSC::computeUsesForBytecodeOffset):
(JSC::computeDefsForBytecodeOffset):

  • bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::emitGetByVal):
(JSC::BytecodeGenerator::popIndexedForInScope):
(JSC::BytecodeGenerator::popStructureForInScope):
(JSC::BytecodeGenerator::invalidateForInContextForLocal):
(JSC::StructureForInContext::pop):
(JSC::IndexedForInContext::pop):

  • bytecompiler/BytecodeGenerator.h:

(JSC::StructureForInContext::addGetInst):
(JSC::IndexedForInContext::addGetInst):

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::parseBlock):

  • dfg/DFGCapabilities.cpp:

(JSC::DFG::capabilityLevel):

  • jit/JIT.cpp:

(JSC::JIT::privateCompileMainPass):

  • jit/JIT.h:
  • jit/JITOpcodes.cpp:

(JSC::JIT::emit_op_nop):

  • llint/LowLevelInterpreter.asm:
2:40 AM Changeset in webkit [219800] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.16/Source/WebCore

Merge r216825 - AccessibilityRenderObject::textUnderElement needs to assert on unclean tree.
​https://bugs.webkit.org/show_bug.cgi?id=172065

Reviewed by Simon Fraser.

r192103 changed the assert logic incorrectly. If the tree is dirty, regardless of the renderer's type,
TextIterator will end up forcing style update/layout on the render tree.
The original assert would have hit with bug 171546 prior to r216726.

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::textUnderElement):

2:40 AM Changeset in webkit [219799] by Carlos Garcia Campos
  • 7 edits
    2 adds in releases/WebKitGTK/webkit-2.16

Merge r216726 - AX: Defer text changes until after the tree is clean if needed.
​https://bugs.webkit.org/show_bug.cgi?id=171546
<rdar://problem/31934942>

Reviewed by Simon Fraser.

Source/WebCore:

While updating an accessibility object state, we might
trigger unintentional style updates. This style update could
end up destroying renderes that are still referenced by functions
on the callstack.
To avoid that, defer such changes and let AXObjectCache operate on a clean tree.

Test: accessibility/crash-when-render-tree-is-not-clean.html

  • accessibility/AXObjectCache.cpp:

(WebCore::AXObjectCache::remove):
(WebCore::AXObjectCache::handleAttributeChanged):
(WebCore::AXObjectCache::labelChanged):
(WebCore::AXObjectCache::performDeferredCacheUpdate):
(WebCore::AXObjectCache::deferRecomputeIsIgnored):
(WebCore::AXObjectCache::deferTextChangedIfNeeded):
(WebCore::AXObjectCache::recomputeDeferredIsIgnored): Deleted.
(WebCore::AXObjectCache::deferTextChanged): Deleted.

  • accessibility/AXObjectCache.h: Decouple different type of changes.

(WebCore::AXObjectCache::deferRecomputeIsIgnored):
(WebCore::AXObjectCache::deferTextChangedIfNeeded):
(WebCore::AXObjectCache::recomputeDeferredIsIgnored): Deleted.
(WebCore::AXObjectCache::deferTextChanged): Deleted.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::deleteLines):

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlockFlow::createAndAppendRootInlineBox):

  • rendering/RenderText.cpp:

(WebCore::RenderText::setText):

LayoutTests:

  • accessibility/crash-when-render-tree-is-not-clean-expected.txt: Added.
  • accessibility/crash-when-render-tree-is-not-clean.html: Added.
1:58 AM Changeset in webkit [219798] by Carlos Garcia Campos
  • 6 edits
    2 adds in releases/WebKitGTK/webkit-2.16

Merge r216096 - Defer AX cache update when text content changes until after layout is finished.
​https://bugs.webkit.org/show_bug.cgi?id=171429
<rdar://problem/31885984>

Reviewed by Simon Fraser.

Source/WebCore:

When the content of the RenderText changes (even as the result of a text-transform change)
instead of updating the AX cache eagerly (and trigger layout on a half-backed render tree)
we should just defer it until after the subsequent layout is done.

Test: accessibility/crash-while-adding-text-child-with-transform.html

  • accessibility/AXObjectCache.cpp:

(WebCore::AXObjectCache::remove):
(WebCore::AXObjectCache::performDeferredCacheUpdate):
(WebCore::AXObjectCache::recomputeDeferredIsIgnored):
(WebCore::AXObjectCache::deferTextChanged):
(WebCore::AXObjectCache::performDeferredIsIgnoredChange): Deleted.

  • accessibility/AXObjectCache.h:

(WebCore::AXObjectCache::deferTextChanged):
(WebCore::AXObjectCache::performDeferredCacheUpdate):
(WebCore::AXObjectCache::performDeferredIsIgnoredChange): Deleted.

  • page/FrameView.cpp:

(WebCore::FrameView::performPostLayoutTasks):

  • rendering/RenderText.cpp:

(WebCore::RenderText::setText):

LayoutTests:

  • accessibility/crash-while-adding-text-child-with-transform-expected.txt: Added.
  • accessibility/crash-while-adding-text-child-with-transform.html: Added.
1:33 AM Changeset in webkit [219797] by fred.wang@free.fr
  • 8 edits
    7 adds in trunk

Add attribute allow-top-navigation-by-user-activation to iframe sandbox
​https://bugs.webkit.org/show_bug.cgi?id=171327

Patch by Frederic Wang <​fwang@igalia.com> on 2017-07-11
Reviewed by Chris Dumez.

LayoutTests/imported/w3c:

This commit updates the expectation for the test verifying that a sandboxed iframe without
the allow-top-navigation-by-user-activation flag set can not perform top navigation if it is
not triggered by a user gesture. The navigation is still prohibited but the parsing of the
allow-top-navigation-by-user-activation flag should not raised any error message.
A similar update is done for the test verifying that the combination of the flags
allow-top-navigation-by-user-activation and allow-top-navigation.

  • web-platform-tests/html/semantics/embedded-content/the-iframe-element/iframe_sandbox_allow_top_navigation_by_user_activation_without_user_gesture-expected.txt: Remove the error message.
  • web-platform-tests/html/semantics/embedded-content/the-iframe-element/iframe_sandbox_allow_top_navigation-3-expected.txt: Ditto.

Source/WebCore:

Tests: http/tests/security/frameNavigation/sandbox-ALLOWED-top-navigation-with-user-gesture-1.html

http/tests/security/frameNavigation/sandbox-ALLOWED-top-navigation-with-user-gesture-2.html
imported/w3c/web-platform-tests/html/semantics/embedded-content/the-iframe-element/iframe_sandbox_allow_top_navigation_by_user_activation_without_user_gesture-expected.txt
imported/w3c/web-platform-tests/html/semantics/embedded-content/the-iframe-element/iframe_sandbox_allow_top_navigation-3-expected.txt

  • dom/Document.cpp:

(WebCore::Document::canNavigate): Case 2 of conformance verification is refined to match the
current specification: Top navigation is allowed when it is triggered by user activation and
when allow-top-navigation-by-user-activation is set. Because we have additional "security
origin" rules with respect to the specification we also add some early return to ensure that
navigation is really allowed for this new case.

  • dom/SecurityContext.cpp:

(WebCore::SecurityContext::isSupportedSandboxPolicy): Add allow-top-navigation-by-user-activation flag.
(WebCore::SecurityContext::parseSandboxPolicy): Parse the new flag to allow top user
navigation by user activation. Also, make sure that allow-top-navigation allows such
navigation as defined by the specification.

  • dom/SecurityContext.h: Declare new sandboxing flag.

LayoutTests:

This patch adds tests to verify that a sandboxed iframe with the flag
'allow-top-navigation-by-user-activation' or 'allow-top-navigation' can navigate the top
level page, if navigation is triggered by a user gesture. This is based on a test from the
Chromium repository.
It also verifies that navigation fails when 'allow-top-navigation-by-user-activation' is
absent, even when it is triggered by a user gesture.

  • http/tests/security/frameNavigation/resources/iframe-that-performs-parent-navigation-with-user-activation.html: Added. This is similar to iframe-that-performs-parent-navigation.html but it

performs navigation of its parent using user activation.

  • http/tests/security/frameNavigation/sandbox-ALLOWED-top-navigation-with-user-gesture-1.html: Added.

Test top navigation for a sandboxed frame with 'allow-top-navigation-by-user-activation'

  • http/tests/security/frameNavigation/sandbox-ALLOWED-top-navigation-with-user-gesture-1-expected.txt: Added.

Add PASS expectation.

  • http/tests/security/frameNavigation/sandbox-ALLOWED-top-navigation-with-user-gesture-2.html: Added.

Test top navigation for a sandboxed frame with 'allow-top-navigation'.

  • http/tests/security/frameNavigation/sandbox-ALLOWED-top-navigation-with-user-gesture-2-expected.txt: Added.

Add PASS expectation.

  • http/tests/security/frameNavigation/sandbox-DENIED-top-navigation-with-user-gesture.html: Added.

Test user-triggered navigation for a sandboxed frame without 'allow-top-navigation-by-user-activation'.

  • http/tests/security/frameNavigation/sandbox-DENIED-top-navigation-with-user-gesture-expected.txt: Added.

Add reference with navigation failure.

Jul 23, 2017:

11:47 PM Changeset in webkit [219796] by Carlos Garcia Campos
  • 2 edits in trunk/Source/WebKit

Unreviewed. REGRESSION(r219713): [GTK][WPE] Fix default favicon database patch.

When nullptr is passed to webkit_web_context_set_favicon_database_directory() the default database directory was
taken from WebProcessPool::platformDefaultIconDatabasePath(), that has been removed in r219713 without properly
replacing it, now it uses an empty string. This causes that the current directory is used to create the favicon
database.

  • UIProcess/API/glib/WebKitWebContext.cpp:

(webkit_web_context_set_favicon_database_directory): Use the default icon database directory instead of an empty
string when nullptr is passed.

11:05 PM Changeset in webkit [219795] by Wenson Hsieh
  • 4 edits in trunk/Source

[iOS WK2] 5 DataInteractionTests are failing: observed selection rects after dropping don't match expected values
​https://bugs.webkit.org/show_bug.cgi?id=174769
<rdar://problem/33478864>

Reviewed by Tim Horton.

Source/WebCore:

These tests began failing after r219541, due to a change in behavior of whether or not we call
setIgnoreSelectionChanges(false, RevealSelection::No) or setIgnoreSelectionChanges(false, RevealSelection::Yes)
when performing a text editing drop.

Before r219541, we would not reveal the selection when performing an edit drag operation. This is because in
WebPage::performDragControllerAction, we would begin ignoring selection changes by calling
setIgnoreSelectionChanges(true). However, while taking a text indicator snapshot, we would stop ignoring
selection in TextIndicator::createWithRange due to us calling setIgnoreSelectionChanges(false,
RevealSelection::No) at the end of the function. Then, when we return to the scope of
WebPage::performDragControllerAction and try to setIgnoreSelectionChanges(false), this is a no-op because we've
already stopped ignoring selection changes.

After r219541, switching to using TemporarySelectionChange means that TextIndicator::createWithRange now means
we respect whether or not we were already ignoring selection before taking the snapshot, so we won't always
setIgnoreSelectionChanges(false) at the end. This means that selection changes will now be correctly ignored
when performing a drag operation, but this also means that we'll try to reveal the selection, since
WebPage::performDragControllerAction calls setIgnoreSelectionChanges(false), for which RevealSelection::Yes
is used by default.

Revealing the selection in WebPage::performDragControllerAction was unintended in the first place, so we should
revert to calling setIgnoreSelectionChanges(false, RevealSelection::No). To ensure this, we adopt
TemporarySelectionChange here and pass only TemporarySelectionOptionIgnoreSelectionChanges, so that we won't
additionally try to reveal selection after the drop. This is consistent with behavior prior to macOS 10.13 and
iOS 11. Additionally, this patch also moves the call to ignore selection change from WebKit into WebCore, so
that whether we ignore selection is consistent across both WebKit1 and WebKit2.

  • page/DragController.cpp:

(WebCore::DragController::performDragOperation):

Source/WebKit:

Fixes several API tests in the DataInteractionTests suite. See Source/WebCore/ChangeLog for more details.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::performDragControllerAction):

10:58 PM Changeset in webkit [219794] by Carlos Garcia Campos
  • 9 edits in trunk/Source

WebDriver: implement page load timeout
​https://bugs.webkit.org/show_bug.cgi?id=174672

Reviewed by Brian Burg.

Source/WebDriver:

Handle timeout errors and pass the page load timeout to waitForNavigationToComplete and all other navigation
commands. Also fix the setTimeouts command that was still using the legacy name of the page load timeout,
instead of the one in the spec.

  1. Sessions

​https://www.w3.org/TR/webdriver/#dfn-session-page-load-timeout

  • CommandResult.cpp:

(WebDriver::CommandResult::CommandResult):
(WebDriver::CommandResult::httpStatusCode):
(WebDriver::CommandResult::errorString):

  • CommandResult.h:
  • Session.cpp:

(WebDriver::Session::go):
(WebDriver::Session::back):
(WebDriver::Session::forward):
(WebDriver::Session::refresh):
(WebDriver::Session::waitForNavigationToComplete):

  • WebDriverService.cpp:

(WebDriver::WebDriverService::setTimeouts):

Source/WebKit:

Always start a timer when waiting for a navigation to complete. When the timer fires, pending callbacks for
navigations are removed and invoked with a timeout error. If navigation completes before the timer is fired,
then the timer is stopped. All navigation commands now receive the page load strategy and timeout as optional
parameters, when not provided the default timeout (300 seconds) is used.

  • UIProcess/Automation/Automation.json:
  • UIProcess/Automation/WebAutomationSession.cpp:

(WebKit::WebAutomationSession::WebAutomationSession):
(WebKit::WebAutomationSession::waitForNavigationToComplete):
(WebKit::WebAutomationSession::waitForNavigationToCompleteOnPage):
(WebKit::WebAutomationSession::waitForNavigationToCompleteOnFrame):
(WebKit::WebAutomationSession::loadTimerFired):
(WebKit::WebAutomationSession::navigateBrowsingContext):
(WebKit::WebAutomationSession::goBackInBrowsingContext):
(WebKit::WebAutomationSession::goForwardInBrowsingContext):
(WebKit::WebAutomationSession::reloadBrowsingContext):
(WebKit::WebAutomationSession::navigationOccurredForFrame):

  • UIProcess/Automation/WebAutomationSession.h:
8:20 PM Changeset in webkit [219793] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit

[GTK] Correct a typo in the reference manual of WebKitWebInspector
​https://bugs.webkit.org/show_bug.cgi?id=174767

Patch by Takuro Ashie <​ashie@clear-code.com> on 2017-07-23
Reviewed by Michael Catanzaro.

  • UIProcess/API/gtk/WebKitWebInspector.cpp:
7:10 PM Changeset in webkit [219792] by Chris Dumez
  • 117 edits
    2 deletes in trunk/Source

Drop ExceptionCodeDescription class
​https://bugs.webkit.org/show_bug.cgi?id=174757

Reviewed by Darin Adler.

Source/WebCore:

Drop ExceptionCodeDescription class now that there is only one exception
type: DOMException. Instead, we now have static methods on DOMException
to get the name / message for a given exception code.

  • CMakeLists.txt:
  • Modules/indexeddb/shared/IDBError.cpp:

(WebCore::IDBError::name):
(WebCore::IDBError::message):

  • Modules/quota/StorageErrorCallback.cpp:

(WebCore::StorageErrorCallback::CallbackTask::CallbackTask):

  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSDOMExceptionHandling.cpp:

(WebCore::createDOMException):

  • dom/DOMAllInOne.cpp:
  • dom/DOMException.cpp:

(WebCore::errorCodeFromName):
(WebCore::DOMException::create):
(WebCore::DOMException::DOMException):
(WebCore::DOMException::name):
(WebCore::DOMException::message):

  • dom/DOMException.h:
  • dom/ExceptionCodeDescription.cpp: Removed.
  • dom/ExceptionCodeDescription.h: Removed.
  • inspector/DOMEditor.cpp:

(WebCore::populateErrorString):

  • inspector/InspectorDOMAgent.cpp:

(WebCore::InspectorDOMAgent::toErrorString):

  • inspector/InspectorDOMStorageAgent.cpp:

(WebCore::InspectorDOMStorageAgent::setDOMStorageItem):

Source/WebKit:

Update GTK bindings to use new API on DOMException instead of
ExceptionCodeDescription.

  • WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMAttr.cpp:

(webkit_dom_attr_dispatch_event):

  • WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMBlob.cpp:
  • WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMCDATASection.cpp:

(webkit_dom_cdata_section_dispatch_event):

  • WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMCSSRule.cpp:

(webkit_dom_css_rule_set_css_text):

  • WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMCSSRuleList.cpp:
  • WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMCSSStyleDeclaration.cpp:

(webkit_dom_css_style_declaration_set_property):
(webkit_dom_css_style_declaration_set_css_text):

  • WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMCSSStyleSheet.cpp:

(webkit_dom_css_style_sheet_insert_rule):
(webkit_dom_css_style_sheet_delete_rule):
(webkit_dom_css_style_sheet_add_rule):
(webkit_dom_css_style_sheet_remove_rule):

  • WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMCSSValue.cpp:

(webkit_dom_css_value_set_css_text):

  • WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMCharacterData.cpp:

(webkit_dom_character_data_dispatch_event):
(webkit_dom_character_data_insert_data):
(webkit_dom_character_data_delete_data):
(webkit_dom_character_data_replace_data):

  • WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMClientRect.cpp:
  • WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMClientRectList.cpp:
  • WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMComment.cpp:

(webkit_dom_comment_dispatch_event):

  • WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMDOMImplementation.cpp:

(webkit_dom_dom_implementation_create_document_type):
(webkit_dom_dom_implementation_create_document):

  • WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMDOMSelection.cpp:

(webkit_dom_dom_selection_collapse_to_end):
(webkit_dom_dom_selection_collapse_to_start):
(webkit_dom_dom_selection_extend):
(webkit_dom_dom_selection_get_range_at):

  • WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMDOMTokenList.cpp:

(webkit_dom_dom_token_list_add):
(webkit_dom_dom_token_list_remove):
(webkit_dom_dom_token_list_toggle):
(webkit_dom_dom_token_list_replace):

  • WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMDOMWindow.cpp:

(webkit_dom_dom_window_dispatch_event):

  • WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMDeprecated.cpp:

(webkit_dom_node_set_prefix):

  • WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMDocument.cpp:

(webkit_dom_document_dispatch_event):
(webkit_dom_document_create_element):
(webkit_dom_document_create_cdata_section):
(webkit_dom_document_create_processing_instruction):
(webkit_dom_document_create_attribute):
(webkit_dom_document_import_node):
(webkit_dom_document_create_element_ns):
(webkit_dom_document_create_attribute_ns):
(webkit_dom_document_adopt_node):
(webkit_dom_document_create_event):
(webkit_dom_document_create_expression):
(webkit_dom_document_evaluate):
(webkit_dom_document_query_selector):
(webkit_dom_document_query_selector_all):
(webkit_dom_document_set_xml_version):
(webkit_dom_document_set_cookie):
(webkit_dom_document_set_body):

  • WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMDocumentFragment.cpp:

(webkit_dom_document_fragment_dispatch_event):
(webkit_dom_document_fragment_query_selector):
(webkit_dom_document_fragment_query_selector_all):

  • WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMDocumentType.cpp:

(webkit_dom_document_type_dispatch_event):

  • WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMElement.cpp:

(webkit_dom_element_dispatch_event):
(webkit_dom_element_set_attribute):
(webkit_dom_element_set_attribute_node):
(webkit_dom_element_remove_attribute_node):
(webkit_dom_element_set_attribute_ns):
(webkit_dom_element_set_attribute_node_ns):
(webkit_dom_element_matches):
(webkit_dom_element_closest):
(webkit_dom_element_insert_adjacent_element):
(webkit_dom_element_insert_adjacent_html):
(webkit_dom_element_insert_adjacent_text):
(webkit_dom_element_remove):
(webkit_dom_element_query_selector):
(webkit_dom_element_query_selector_all):
(webkit_dom_element_set_inner_html):
(webkit_dom_element_set_outer_html):

  • WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMEvent.cpp:
  • WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMFile.cpp:
  • WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMFileList.cpp:
  • WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMHTMLAnchorElement.cpp:

(webkit_dom_html_anchor_element_dispatch_event):

  • WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMHTMLAppletElement.cpp:

(webkit_dom_html_applet_element_dispatch_event):

  • WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMHTMLAreaElement.cpp:

(webkit_dom_html_area_element_dispatch_event):

  • WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMHTMLBRElement.cpp:

(webkit_dom_html_br_element_dispatch_event):

  • WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMHTMLBaseElement.cpp:

(webkit_dom_html_base_element_dispatch_event):

  • WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMHTMLBodyElement.cpp:

(webkit_dom_html_body_element_dispatch_event):

  • WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMHTMLButtonElement.cpp:

(webkit_dom_html_button_element_dispatch_event):

  • WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMHTMLCanvasElement.cpp:

(webkit_dom_html_canvas_element_dispatch_event):

  • WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMHTMLCollection.cpp:
  • WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMHTMLDListElement.cpp:

(webkit_dom_html_d_list_element_dispatch_event):

  • WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMHTMLDirectoryElement.cpp:

(webkit_dom_html_directory_element_dispatch_event):

  • WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMHTMLDivElement.cpp:

(webkit_dom_html_div_element_dispatch_event):

  • WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMHTMLDocument.cpp:

(webkit_dom_html_document_dispatch_event):

  • WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMHTMLElement.cpp:

(webkit_dom_html_element_dispatch_event):
(webkit_dom_html_element_set_inner_text):
(webkit_dom_html_element_set_outer_text):
(webkit_dom_html_element_set_content_editable):

  • WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMHTMLEmbedElement.cpp:

(webkit_dom_html_embed_element_dispatch_event):

  • WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMHTMLFieldSetElement.cpp:

(webkit_dom_html_field_set_element_dispatch_event):

  • WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMHTMLFontElement.cpp:

(webkit_dom_html_font_element_dispatch_event):

  • WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMHTMLFormElement.cpp:

(webkit_dom_html_form_element_dispatch_event):

  • WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMHTMLFrameElement.cpp:

(webkit_dom_html_frame_element_dispatch_event):

  • WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMHTMLFrameSetElement.cpp:

(webkit_dom_html_frame_set_element_dispatch_event):

  • WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMHTMLHRElement.cpp:

(webkit_dom_html_hr_element_dispatch_event):

  • WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMHTMLHeadElement.cpp:

(webkit_dom_html_head_element_dispatch_event):

  • WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMHTMLHeadingElement.cpp:

(webkit_dom_html_heading_element_dispatch_event):

  • WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMHTMLHtmlElement.cpp:

(webkit_dom_html_html_element_dispatch_event):

  • WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMHTMLIFrameElement.cpp:

(webkit_dom_html_iframe_element_dispatch_event):

  • WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMHTMLImageElement.cpp:

(webkit_dom_html_image_element_dispatch_event):

  • WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMHTMLInputElement.cpp:

(webkit_dom_html_input_element_dispatch_event):
(webkit_dom_html_input_element_set_max_length):
(webkit_dom_html_input_element_set_size):

  • WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMHTMLLIElement.cpp:

(webkit_dom_html_li_element_dispatch_event):

  • WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMHTMLLabelElement.cpp:

(webkit_dom_html_label_element_dispatch_event):

  • WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMHTMLLegendElement.cpp:

(webkit_dom_html_legend_element_dispatch_event):

  • WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMHTMLLinkElement.cpp:

(webkit_dom_html_link_element_dispatch_event):

  • WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMHTMLMapElement.cpp:

(webkit_dom_html_map_element_dispatch_event):

  • WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMHTMLMarqueeElement.cpp:

(webkit_dom_html_marquee_element_dispatch_event):

  • WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMHTMLMenuElement.cpp:

(webkit_dom_html_menu_element_dispatch_event):

  • WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMHTMLMetaElement.cpp:

(webkit_dom_html_meta_element_dispatch_event):

  • WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMHTMLModElement.cpp:

(webkit_dom_html_mod_element_dispatch_event):

  • WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMHTMLOListElement.cpp:

(webkit_dom_html_o_list_element_dispatch_event):

  • WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMHTMLObjectElement.cpp:

(webkit_dom_html_object_element_dispatch_event):

  • WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMHTMLOptGroupElement.cpp:

(webkit_dom_html_opt_group_element_dispatch_event):

  • WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMHTMLOptionElement.cpp:

(webkit_dom_html_option_element_dispatch_event):

  • WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMHTMLOptionsCollection.cpp:
  • WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMHTMLParagraphElement.cpp:

(webkit_dom_html_paragraph_element_dispatch_event):

  • WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMHTMLParamElement.cpp:

(webkit_dom_html_param_element_dispatch_event):

  • WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMHTMLPreElement.cpp:

(webkit_dom_html_pre_element_dispatch_event):

  • WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMHTMLQuoteElement.cpp:

(webkit_dom_html_quote_element_dispatch_event):

  • WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMHTMLScriptElement.cpp:

(webkit_dom_html_script_element_dispatch_event):

  • WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMHTMLSelectElement.cpp:

(webkit_dom_html_select_element_dispatch_event):
(webkit_dom_html_select_element_add):
(webkit_dom_html_select_element_set_length):

  • WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMHTMLStyleElement.cpp:

(webkit_dom_html_style_element_dispatch_event):

  • WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMHTMLTableCaptionElement.cpp:

(webkit_dom_html_table_caption_element_dispatch_event):

  • WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMHTMLTableCellElement.cpp:

(webkit_dom_html_table_cell_element_dispatch_event):

  • WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMHTMLTableColElement.cpp:

(webkit_dom_html_table_col_element_dispatch_event):

  • WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMHTMLTableElement.cpp:

(webkit_dom_html_table_element_dispatch_event):
(webkit_dom_html_table_element_insert_row):
(webkit_dom_html_table_element_delete_row):
(webkit_dom_html_table_element_set_caption):
(webkit_dom_html_table_element_set_t_head):
(webkit_dom_html_table_element_set_t_foot):

  • WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMHTMLTableRowElement.cpp:

(webkit_dom_html_table_row_element_dispatch_event):
(webkit_dom_html_table_row_element_insert_cell):
(webkit_dom_html_table_row_element_delete_cell):

  • WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMHTMLTableSectionElement.cpp:

(webkit_dom_html_table_section_element_dispatch_event):
(webkit_dom_html_table_section_element_insert_row):
(webkit_dom_html_table_section_element_delete_row):

  • WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMHTMLTextAreaElement.cpp:

(webkit_dom_html_text_area_element_dispatch_event):

  • WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMHTMLTitleElement.cpp:

(webkit_dom_html_title_element_dispatch_event):

  • WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMHTMLUListElement.cpp:

(webkit_dom_html_u_list_element_dispatch_event):

  • WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMKeyboardEvent.cpp:
  • WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMMediaList.cpp:

(webkit_dom_media_list_delete_medium):
(webkit_dom_media_list_append_medium):
(webkit_dom_media_list_set_media_text):

  • WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMMouseEvent.cpp:
  • WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMNamedNodeMap.cpp:

(webkit_dom_named_node_map_set_named_item):
(webkit_dom_named_node_map_remove_named_item):
(webkit_dom_named_node_map_remove_named_item_ns):

  • WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMNode.cpp:

(webkit_dom_node_dispatch_event):
(webkit_dom_node_insert_before):
(webkit_dom_node_replace_child):
(webkit_dom_node_remove_child):
(webkit_dom_node_append_child):
(webkit_dom_node_clone_node_with_error):
(webkit_dom_node_set_node_value):
(webkit_dom_node_set_text_content):

  • WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMNodeIterator.cpp:
  • WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMNodeList.cpp:
  • WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMProcessingInstruction.cpp:

(webkit_dom_processing_instruction_dispatch_event):

  • WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMRange.cpp:

(webkit_dom_range_set_start):
(webkit_dom_range_set_end):
(webkit_dom_range_set_start_before):
(webkit_dom_range_set_start_after):
(webkit_dom_range_set_end_before):
(webkit_dom_range_set_end_after):
(webkit_dom_range_select_node):
(webkit_dom_range_select_node_contents):
(webkit_dom_range_compare_boundary_points):
(webkit_dom_range_delete_contents):
(webkit_dom_range_extract_contents):
(webkit_dom_range_clone_contents):
(webkit_dom_range_insert_node):
(webkit_dom_range_surround_contents):
(webkit_dom_range_create_contextual_fragment):
(webkit_dom_range_compare_node):
(webkit_dom_range_intersects_node):
(webkit_dom_range_compare_point):
(webkit_dom_range_is_point_in_range):
(webkit_dom_range_expand):

  • WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMStyleSheet.cpp:
  • WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMStyleSheetList.cpp:
  • WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMText.cpp:

(webkit_dom_text_dispatch_event):
(webkit_dom_text_split_text):

  • WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMTreeWalker.cpp:
  • WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMUIEvent.cpp:
  • WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMWheelEvent.cpp:
  • WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMXPathExpression.cpp:

(webkit_dom_xpath_expression_evaluate):

  • WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMXPathResult.cpp:

(webkit_dom_xpath_result_iterate_next):
(webkit_dom_xpath_result_snapshot_item):
(webkit_dom_xpath_result_get_number_value):
(webkit_dom_xpath_result_get_boolean_value):
(webkit_dom_xpath_result_get_single_node_value):
(webkit_dom_xpath_result_get_snapshot_length):

Source/WebKitLegacy/mac:

Stop using ExceptionCodeDescription.

  • DOM/ExceptionHandlers.mm:

(raiseDOMErrorException):

2:01 PM Changeset in webkit [219791] by Michael Catanzaro
  • 2 edits in trunk/Source/WTF

Implement FALLTHROUGH attribute for C with GCC
​https://bugs.webkit.org/show_bug.cgi?id=174555

Reviewed by Darin Adler.

My previous attempt to silence the JSC -Wimplicit-fallthrough warnings failed because they
are coming from a C file, and our FALLTHROUGH macro is only implemented for C++. So
implement it for C as well, using C attribute syntax.

Note this is only possible to do for GCC, because Clang only supports this attribute using
the C++ attribute syntax.

  • wtf/Compiler.h:
1:35 PM Changeset in webkit [219790] by mark.lam@apple.com
  • 8 edits
    1 add in trunk/Source/JavaScriptCore

Create regression tests for the JIT probe.
​https://bugs.webkit.org/show_bug.cgi?id=174696
<rdar://problem/33436922>

Reviewed by Saam Barati.

The new testmasm will test the following:

  1. the probe is able to read the value of CPU registers.
  2. the probe is able to write the value of CPU registers.
  3. the probe is able to preserve all CPU registers.
  4. special case of (2): the probe is able to change the value of the stack pointer.
  5. special case of (2): the probe is able to change the value of the program counter i.e. the probe can change where the code continues executing upon returning from the probe.

Currently, the x86, x86_64, and ARMv7 ports passes the test. ARM64 does not
because it does not support changing the sp and pc yet. The ARM64 probe
implementation will be fixed in ​https://bugs.webkit.org/show_bug.cgi?id=174697
later.

  • Configurations/ToolExecutable.xcconfig:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • assembler/MacroAssembler.h:

(JSC::MacroAssembler::CPUState::pc):
(JSC::MacroAssembler::CPUState::fp):
(JSC::MacroAssembler::CPUState::sp):
(JSC::ProbeContext::pc):
(JSC::ProbeContext::fp):
(JSC::ProbeContext::sp):

  • assembler/MacroAssemblerARM64.cpp:

(JSC::arm64ProbeTrampoline):

  • assembler/MacroAssemblerPrinter.cpp:

(JSC::Printer::printPCRegister):

  • assembler/testmasm.cpp: Added.

(hiddenTruthBecauseNoReturnIsStupid):
(usage):
(JSC::nextID):
(JSC::isPC):
(JSC::isSP):
(JSC::isFP):
(JSC::compile):
(JSC::invoke):
(JSC::compileAndRun):
(JSC::testSimple):
(JSC::testProbeReadsArgumentRegisters):
(JSC::testProbeWritesArgumentRegisters):
(JSC::testFunctionToTrashRegisters):
(JSC::testProbePreservesGPRS):
(JSC::testProbeModifiesStackPointer):
(JSC::testProbeModifiesProgramCounter):
(JSC::run):
(run):
(main):

  • b3/air/testair.cpp:

(usage):

  • shell/CMakeLists.txt:
12:02 PM Changeset in webkit [219789] by jmarcell@apple.com
  • 4 edits
    2 adds in branches/safari-604-branch

Cherry-pick r219571. rdar://problem/33464710

10:00 AM WebKitGTK/2.16.x edited by clopez@igalia.com
(diff)
Note: See TracTimeline for information about the timeline view.