Timeline

Jul 26, 2017:

8:57 PM Changeset in webkit [219975] by jmarcell@apple.com

• 7 edits in branches/safari-604-branch/Source

Versioning.

7:47 PM Changeset in webkit [219974] by beidson@apple.com

• 2 edits in trunk/Source/WebKit

ResourceLoadStatistics API tests fail on El Capitan.
​https://bugs.webkit.org/show_bug.cgi?id=174877

Reviewed by Chris Dumez.

Always install the testing callback.

• UIProcess/WebsiteData/WebsiteDataStore.cpp:

(WebKit::WebsiteDataStore::enableResourceLoadStatisticsAndSetTestingCallback):

6:49 PM Changeset in webkit [219973] by timothy_horton@apple.com

• 2 edits in trunk/Source/WebKit

REGRESSION (r211160): Can't pinch to zoom unlocked encrypted PDFs in WKWebView
​https://bugs.webkit.org/show_bug.cgi?id=174881
<rdar://problem/33556312>

Reviewed by Andy Estes.

• UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _hidePasswordView]):
WKPasswordView saves and restores a bunch of scroll view properties, including
those relating to zoom limits. The restoration happens in -[WKPasswordView hide],
which is never called. Instead, the code added in r211160 just calls
removeFromSuperview after unlocking, never restoring the old zoom limits,
causing the then fully unlocked PDF to not be zoomable. Fix this by calling
-hide instead of -removeFromSuperview (which -hide also calls).

5:13 PM Changeset in webkit [219972] by Devin Rousso

• 3 edits in trunk/Source/WebInspectorUI

Uncaught Exception: undefined is not an object (evaluating 'this._memoryRow.value = Number.bytesToString(this._canvas.memoryCost)')
​https://bugs.webkit.org/show_bug.cgi?id=174823

Reviewed by Joseph Pecoraro.

• UserInterface/Views/CanvasDetailsSidebarPanel.js:

(WebInspector.CanvasDetailsSidebarPanel.prototype._refreshIdentitySection):
(WebInspector.CanvasDetailsSidebarPanel.prototype._refreshSourceSection):
(WebInspector.CanvasDetailsSidebarPanel.prototype._refreshAttributesSection):
(WebInspector.CanvasDetailsSidebarPanel.prototype._refreshCSSCanvasSection):
(WebInspector.CanvasDetailsSidebarPanel.prototype._formatMemoryRow):
Early return if the view has not called initialLayout, as the rows might not have been
constructed yet.

• UserInterface/Views/View.js:

(WebInspector.View.prototype.get didInitialLayout): Added.

5:05 PM Changeset in webkit [219971] by jmarcell@apple.com

• 1 copy in tags/Safari-604.1.34

Tag Safari-604.1.34.

4:53 PM Changeset in webkit [219970] by commit-queue@webkit.org

• 7 edits
  2 adds in trunk

Implement new TextMetrics, returned by canvas measureText()
​https://bugs.webkit.org/show_bug.cgi?id=82798
Source/WebCore:

<rdar://problem/11159332>

Patch by Arnaud Renevier <​a.renevier@sisa.samsung.com> and Fujii Hironori <Fujii Hironori> on 2017-07-26
Reviewed by Dean Jackson.

The specification: ​https://html.spec.whatwg.org/multipage/canvas.html#dom-context-2d-measuretext

Add new attributes to TextMetrics.

Add a new method textOffset() of CanvasRenderingContext2D by
extracting from drawTextInternal() to use the same horizontal and
vertical offsets of a text in both drawTextInternal() and
measureText().

Test: fast/canvas/canvas-measureText-2.html

• html/TextMetrics.h:

(WebCore::TextMetrics::actualBoundingBoxLeft):
(WebCore::TextMetrics::setActualBoundingBoxLeft):
(WebCore::TextMetrics::actualBoundingBoxRight):
(WebCore::TextMetrics::setActualBoundingBoxRight):
(WebCore::TextMetrics::fontBoundingBoxAscent):
(WebCore::TextMetrics::setFontBoundingBoxAscent):
(WebCore::TextMetrics::fontBoundingBoxDescent):
(WebCore::TextMetrics::setFontBoundingBoxDescent):
(WebCore::TextMetrics::actualBoundingBoxAscent):
(WebCore::TextMetrics::setActualBoundingBoxAscent):
(WebCore::TextMetrics::actualBoundingBoxDescent):
(WebCore::TextMetrics::setActualBoundingBoxDescent):
(WebCore::TextMetrics::emHeightAscent):
(WebCore::TextMetrics::setEmHeightAscent):
(WebCore::TextMetrics::emHeightDescent):
(WebCore::TextMetrics::setEmHeightDescent):
(WebCore::TextMetrics::hangingBaseline):
(WebCore::TextMetrics::setHangingBaseline):
(WebCore::TextMetrics::alphabeticBaseline):
(WebCore::TextMetrics::setAlphabeticBaseline):
(WebCore::TextMetrics::ideographicBaseline):
(WebCore::TextMetrics::setIdeographicBaseline):
Added getters and setters.
(WebCore::TextMetrics::TextMetrics): Deleted.

• html/TextMetrics.idl: Added new attributes.
• html/canvas/CanvasRenderingContext2D.cpp:

(WebCore::CanvasRenderingContext2D::FontProxy::fontMetrics):
Changed the return value type to a const reference of FontMetrics
not to copy it.
(WebCore::CanvasRenderingContext2D::FontProxy::width):
Added the second arguemnt of GlyphOverflow type.
(WebCore::CanvasRenderingContext2D::measureText): Calculate and
set the new attributes of TextMetrics.
(WebCore::CanvasRenderingContext2D::textOffset): Extracted from drawTextInternal.
(WebCore::CanvasRenderingContext2D::drawTextInternal): Removed the
offset calculation code and call textOffset.

• html/canvas/CanvasRenderingContext2D.h: Added the method

declaration of textOffset. Change types of fontMetrics and width
methods.

• platform/graphics/cairo/FontCairoHarfbuzzNG.cpp:

(WebCore::FontCascade::floatWidthForComplexText): Added a dummy
implementation of calculating GlyphOverflow.

LayoutTests:

Patch by Arnaud Renevier <​a.renevier@sisa.samsung.com> and Fujii Hironori <Fujii Hironori> on 2017-07-26
Reviewed by Dean Jackson.

Create a test that checks that:

• ascent + descent is greater than zero
• actualBoundingBoxLeft + actualBoundingBoxRight is somewhere quite close to width
• when baseline is top, emHeightAscent is 0 (respectively bottom/emHeightDescent)
• when baseline is hanging, hangingBaseline in 0 (respectively alphabetic and ideographic)
• order of different vertical measures (for example, emHeightAscent is always higher that alphabeticBaseline)

• fast/canvas/canvas-measureText-2-expected.txt: Added.
• fast/canvas/canvas-measureText-2.html: Added.

4:29 PM Changeset in webkit [219969] by jfbastien@apple.com

• 2 edits
  2 adds in trunk/JSTests

WebAssembly: test throwing out of the start function
​https://bugs.webkit.org/show_bug.cgi?id=165714
<rdar://problem/29760251>

Reviewed by Keith Miller.

• wasm/assert.js:
• wasm/function-tests/trap-from-start.js: Added.

(StartTraps):

• wasm/function-tests/trap-from-start-async.js: Added.

(async.StartTrapsAsync):

3:57 PM Changeset in webkit [219968] by Matt Lewis

• 2 edits in trunk/LayoutTests

Marked Multiple imported/w3c/web-platform-tests/ as failing.
<rdar://problem/33251388>

Unreviewed test gardening.

• platform/ios-11/TestExpectations:

3:57 PM Changeset in webkit [219967] by Matt Lewis

• 2 edits in trunk/LayoutTests

Rebaselined http/tests/quicklook/top-navigation-blocked-expected.txt.
​https://bugs.webkit.org/show_bug.cgi?id=174755

Unreviewed test gardening.

• platform/ios-11/http/tests/quicklook/top-navigation-blocked-expected.txt:

3:52 PM Changeset in webkit [219966] by beidson@apple.com

• 7 edits
  20 copies
  3 adds
  2 deletes in trunk/Source/WebKit

Rename {Web/UI}Process/Storage to {Web/UI}Process/WebStorage.
​https://bugs.webkit.org/show_bug.cgi?id=174871

Reviewed by Chris Dumez.

The standard these directories help implement is the "Web Storage" standard.
"Storage" is too general of a word that we have plans to start using in other contexts soon.

• CMakeLists.txt:
• DerivedSources.make:
• PlatformGTK.cmake:
• PlatformMac.cmake:
• PlatformWPE.cmake:
• WebKit.xcodeproj/project.pbxproj:

• UIProcess/ResourceLoadStatisticsPersistentStorage.cpp: Renamed from Source/WebKit/UIProcess/Storage/ResourceLoadStatisticsPersistentStorage.cpp.
• UIProcess/ResourceLoadStatisticsPersistentStorage.h: Renamed from Source/WebKit/UIProcess/Storage/ResourceLoadStatisticsPersistentStorage.h.
• UIProcess/WebStorage/LocalStorageDatabase.cpp: Renamed from Source/WebKit/UIProcess/Storage/LocalStorageDatabase.cpp.
• UIProcess/WebStorage/LocalStorageDatabase.h: Renamed from Source/WebKit/UIProcess/Storage/LocalStorageDatabase.h.
• UIProcess/WebStorage/LocalStorageDatabaseTracker.cpp: Renamed from Source/WebKit/UIProcess/Storage/LocalStorageDatabaseTracker.cpp.
• UIProcess/WebStorage/LocalStorageDatabaseTracker.h: Renamed from Source/WebKit/UIProcess/Storage/LocalStorageDatabaseTracker.h.
• UIProcess/WebStorage/StorageManager.cpp: Renamed from Source/WebKit/UIProcess/Storage/StorageManager.cpp.
• UIProcess/WebStorage/StorageManager.h: Renamed from Source/WebKit/UIProcess/Storage/StorageManager.h.
• UIProcess/WebStorage/StorageManager.messages.in: Renamed from Source/WebKit/UIProcess/Storage/StorageManager.messages.in.
• UIProcess/WebStorage/ios/LocalStorageDatabaseTrackerIOS.mm: Renamed from Source/WebKit/UIProcess/Storage/ios/LocalStorageDatabaseTrackerIOS.mm.
• UIProcess/ios/ResourceLoadStatisticsPersistentStorageIOS.mm: Renamed from Source/WebKit/UIProcess/Storage/ios/ResourceLoadStatisticsPersistentStorageIOS.mm.

• WebProcess/WebStorage/StorageAreaImpl.cpp: Renamed from Source/WebKit/WebProcess/Storage/StorageAreaImpl.cpp.
• WebProcess/WebStorage/StorageAreaImpl.h: Renamed from Source/WebKit/WebProcess/Storage/StorageAreaImpl.h.
• WebProcess/WebStorage/StorageAreaMap.cpp: Renamed from Source/WebKit/WebProcess/Storage/StorageAreaMap.cpp.
• WebProcess/WebStorage/StorageAreaMap.h: Renamed from Source/WebKit/WebProcess/Storage/StorageAreaMap.h.
• WebProcess/WebStorage/StorageAreaMap.messages.in: Renamed from Source/WebKit/WebProcess/Storage/StorageAreaMap.messages.in.
• WebProcess/WebStorage/StorageNamespaceImpl.cpp: Renamed from Source/WebKit/WebProcess/Storage/StorageNamespaceImpl.cpp.
• WebProcess/WebStorage/StorageNamespaceImpl.h: Renamed from Source/WebKit/WebProcess/Storage/StorageNamespaceImpl.h.
• WebProcess/WebStorage/WebStorageNamespaceProvider.cpp: Renamed from Source/WebKit/WebProcess/Storage/WebStorageNamespaceProvider.cpp.
• WebProcess/WebStorage/WebStorageNamespaceProvider.h: Renamed from Source/WebKit/WebProcess/Storage/WebStorageNamespaceProvider.h.

3:15 PM Changeset in webkit [219965] by mark.lam@apple.com

• 2 edits in trunk/Tools

Make run-javascriptcore-test run testair, testb3, and testmasm.
​https://bugs.webkit.org/show_bug.cgi?id=174837
<rdar://problem/33522927>

Reviewed by Saam Barati and Filip Pizlo.

1. Refactors code for running testapi so that we can use it to run other tests.
2. Added running of testmasm, testair, testb3.

Note: the existing testapi invocation code does not support remote invocation of
the tests (e.g. on a ARM device). Hence, the new additions of testmasm, testair,
and testb3 also do not support remote invocation. If we wish to add remote
invocation support, we should do that in a separate patch.

• Scripts/run-javascriptcore-tests:

(testPath):
(runTest):
(testapiPath): Deleted.

2:45 PM Changeset in webkit [219964] by Devin Rousso

• 29 edits
  6 copies
  6 adds in trunk

Web Inspector: create protocol for recording Canvas contexts
​https://bugs.webkit.org/show_bug.cgi?id=174481

Reviewed by Joseph Pecoraro.

Source/JavaScriptCore:

• inspector/protocol/Canvas.json:
  • Add requestRecording command to mark the provided canvas as having requested a recording.
  • Add cancelRecording command to clear a previously marked canvas and flush any recorded data.
  • Add recordingFinished event that is fired once a recording is finished.

• CMakeLists.txt:
• DerivedSources.make:
• inspector/protocol/Recording.json: Added.
  • Add Type enum that lists the types of recordings
  • Add InitialState type that contains information about the canvas context at the beginning of the recording.
  • Add Frame type that holds a list of actions that were recorded.
  • Add Recording type as the container object of recording data.

• inspector/scripts/codegen/generate_js_backend_commands.py:

(JSBackendCommandsGenerator.generate_domain):
Create an agent for domains with no events or commands.

• inspector/InspectorValues.h:

Make Array get public so that values can be retrieved if needed.

Source/WebCore:

Currently, a recording doesn't actually "start" until an action is performed on the context.
This change adds the recording logic, but it does not use it anywhere. Additonal tests will
be added in the patches that add uses:

• <​https://webkit.org/b/174482> Web Inspector: Record actions performed on CanvasRenderingContext2D
• <​https://webkit.org/b/174483> Web Inspector: Record actions performed on WebGLRenderingContext

Test: inspector/model/recording.html

• bindings/scripts/IDLAttributes.json:
• bindings/scripts/CodeGeneratorJS.pm:

(GenerateAttributeGetterBodyDefinition):
(GenerateAttributeSetterBodyDefinition):
(GenerateImplementationFunctionCall):

• WebCore.xcodeproj/project.pbxproj:
• bindings/js/CallTracer.h: Added.
• bindings/js/CallTracer.cpp: Added.

(WebCore::CallTracer::recordCanvasAction):

• bindings/js/CallTracerTypes.h: Added.
• bindings/scripts/test/TestCallTracer.idl: Added.
• bindings/scripts/test/JS/JSTestCallTracer.h: Added.
• bindings/scripts/test/JS/JSTestCallTracer.cpp: Added.

Create new IDL extended attribute called "CallTracingCallback" that will add code to call a
static function on CallTracer with the given extended attribute value as the function name,
the impl object as the first parameter, the name of the attribute/operation as the second,
and an optional object that accepts an initializer list of all the parameters as the third.

This function will not be called, however, unless a callTracingActive function on the
impl object returns true, and this is marked as UNLIKELY.

"CallTracingCallback" can be added to an Interface, in which case it will apply to all
attributes/operations of the generated class, or an individual Attribute/Operation.

• html/canvas/CanvasRenderingContext.h:

(WebCore::CanvasRenderingContext::callTracingActive):
(WebCore::CanvasRenderingContext::setCallTracingActive):

• inspector/InspectorCanvas.h:
• inspector/InspectorCanvas.cpp:

(WebCore::InspectorCanvas::~InspectorCanvas):
(WebCore::InspectorCanvas::resetRecordingData):
(WebCore::InspectorCanvas::hasRecordingData):
(WebCore::InspectorCanvas::recordAction):
(WebCore::InspectorCanvas::releaseInitialState):
(WebCore::InspectorCanvas::releaseFrames):
(WebCore::InspectorCanvas::releaseData):
(WebCore::InspectorCanvas::markNewFrame):
(WebCore::InspectorCanvas::markCurrentFrameIncomplete):
(WebCore::InspectorCanvas::setBufferLimit):
(WebCore::InspectorCanvas::hasBufferSpace):
(WebCore::InspectorCanvas::singleFrame):
(WebCore::InspectorCanvas::setSingleFrame):
(WebCore::InspectorCanvas::indexForData):
(WebCore::buildArrayForAffineTransform):
(WebCore::buildArrayForVector):
(WebCore::InspectorCanvas::buildInitialState):
(WebCore::InspectorCanvas::buildAction):
(WebCore::InspectorCanvas::buildArrayForCanvasGradient):
(WebCore::InspectorCanvas::buildArrayForCanvasPattern):
(WebCore::InspectorCanvas::buildArrayForImageData):

Hold the recording data on the corresponding InspectorCanvas. Recording Frames are
completed when the HTMLCanvasElement paints or a 0_s timer is fired. A recording is not
considered valid until at least one action is performed on the canvas context. Once that
condition is satisfied, canceling the recording will flush the data.

• inspector/InspectorCanvasAgent.h:
• inspector/InspectorCanvasAgent.cpp:

(WebCore::InspectorCanvasAgent::InspectorCanvasAgent):
(WebCore::InspectorCanvasAgent::disable):
(WebCore::InspectorCanvasAgent::requestRecording):
(WebCore::InspectorCanvasAgent::cancelRecording):
(WebCore::InspectorCanvasAgent::recordCanvasAction):
(WebCore::InspectorCanvasAgent::didFinishRecordingCanvasFrame):
(WebCore::InspectorCanvasAgent::canvasDestroyed):
(WebCore::InspectorCanvasAgent::canvasRecordingTimerFired):
(WebCore::InspectorCanvasAgent::clearCanvasData):

• inspector/InspectorInstrumentation.h:
• inspector/InspectorInstrumentation.cpp:

(WebCore::InspectorInstrumentation::recordCanvasAction):
(WebCore::InspectorInstrumentation::recordCanvasActionImpl):
(WebCore::InspectorInstrumentation::didFinishRecordingCanvasFrameImpl):

• html/canvas/CanvasRenderingContext2D.h:
• html/canvas/CanvasRenderingContext2D.cpp:

(WebCore::CanvasRenderingContext2D::stringForWindingRule):
(WebCore::CanvasRenderingContext2D::stringForImageSmoothingQuality):

• platform/graphics/Gradient.h:

(WebCore::Gradient::stops):

• svg/SVGPathUtilities.h:
• svg/SVGPathUtilities.cpp:

(WebCore::buildStringFromPath):

Source/WebInspectorUI:

Create model objects that effectively mirror the protocol objects sent for Canvas recordings.

• .eslintrc:
• UserInterface/Main.html:
• UserInterface/Test.html:

• UserInterface/Controllers/CanvasManager.js:

(WebInspector.CanvasManager.prototype.recordingFinished):

• UserInterface/Protocol/CanvasObserver.js:

(WebInspector.CanvasObserver.prototype.recordingFinished):

• UserInterface/Models/Recording.js: Added.

(WebInspector.Recording):
(WebInspector.Recording.fromPayload):
(WebInspector.Recording.prototype.get type):
(WebInspector.Recording.prototype.get initialState):
(WebInspector.Recording.prototype.get frames):
(WebInspector.Recording.prototype.get data):
(WebInspector.Recording.prototype.toJSON):

• UserInterface/Models/RecordingAction.js: Added.

(WebInspector.RecordingAction):
(WebInspector.RecordingAction.fromPayload):
(WebInspector.RecordingAction.prototype.get name):
(WebInspector.RecordingAction.prototype.get parameters):
(WebInspector.RecordingAction.prototype.toJSON):

• UserInterface/Models/RecordingFrame.js: Added.

(WebInspector.RecordingFrame):
(WebInspector.RecordingFrame.fromPayload):
(WebInspector.RecordingFrame.prototype.get actions):
(WebInspector.RecordingFrame.prototype.get incomplete):
(WebInspector.RecordingFrame.prototype.toJSON):

LayoutTests:

• inspector/model/recording-expected.txt: Added.
• inspector/model/recording.html: Added.

2:38 PM Changeset in webkit [219963] by aakash_jain@apple.com

• 3 edits in trunk/Tools

Remove duplicate code from Buildbot.js in dashboard
​https://bugs.webkit.org/show_bug.cgi?id=174870

Reviewed by Daniel Bates.

• BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:

(Buildbot.prototype.javaScriptCoreTestFailuresURLForIteration): Remove duplicate code and reuse buildPageURLForIteration() to construct URL.
(Buildbot.prototype.javaScriptCoreTestStdioUrlForIteration): Ditto.

• BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/MockBuildbot.js:

(MockBuildbot.prototype.javaScriptCoreTestStdioUrlForIteration): Ditto for tests.

2:02 PM Changeset in webkit [219962] by mitz@apple.com

• 9 copies
  1 add in releases/Apple/Safari Technology Preview 36

Added a tag for Safari Technology Preview release 36.

1:51 PM Changeset in webkit [219961] by commit-queue@webkit.org

• 30 edits
  17 adds in trunk

Implement document.elementsFromPoint
​https://bugs.webkit.org/show_bug.cgi?id=153137

Patch by Ali Juma <​ajuma@chromium.org> on 2017-07-26
Reviewed by Simon Fraser.

LayoutTests/imported/w3c:

Add tests from upstream pull request ​https://github.com/w3c/web-platform-tests/pull/6568.

• web-platform-tests/cssom-view/elementsFromPoint-expected.txt: Added.
• web-platform-tests/cssom-view/elementsFromPoint-iframes-expected.txt: Added.
• web-platform-tests/cssom-view/elementsFromPoint-iframes.html: Added.
• web-platform-tests/cssom-view/elementsFromPoint-invalid-cases-expected.txt: Added.
• web-platform-tests/cssom-view/elementsFromPoint-invalid-cases.html: Added.
• web-platform-tests/cssom-view/elementsFromPoint-shadowroot-expected.txt: Added.
• web-platform-tests/cssom-view/elementsFromPoint-shadowroot.html: Added.
• web-platform-tests/cssom-view/elementsFromPoint-simple-expected.txt: Added.
• web-platform-tests/cssom-view/elementsFromPoint-simple.html: Added.
• web-platform-tests/cssom-view/elementsFromPoint-svg-expected.txt: Added.
• web-platform-tests/cssom-view/elementsFromPoint-svg.html: Added.
• web-platform-tests/cssom-view/elementsFromPoint-table-expected.txt: Added.
• web-platform-tests/cssom-view/elementsFromPoint-table.html: Added.
• web-platform-tests/cssom-view/negativeMargins-expected.txt:
• web-platform-tests/cssom-view/resources/elementsFromPoint.js: Added.

(nodeToString.prototype.else):
(nodeListToString):
(assertElementsFromPoint):
(checkElementsFromPointFourCorners):

• web-platform-tests/cssom-view/resources/iframe1.html: Added.
• web-platform-tests/cssom-view/resources/iframe2.html: Added.

Source/WebCore:

This ports Blink's implementation of elementsFromPoint, from the
following patches by Philip Rogers (​pdr@chromium.org):
-​https://src.chromium.org/viewvc/blink?revision=190686&view=revision
-​https://src.chromium.org/viewvc/blink?revision=191240&view=revision
-​https://src.chromium.org/viewvc/blink?revision=199214&view=revision

Tests: imported/w3c/web-platform-tests/cssom-view/elementsFromPoint-iframes.html

imported/w3c/web-platform-tests/cssom-view/elementsFromPoint-invalid-cases.html
imported/w3c/web-platform-tests/cssom-view/elementsFromPoint-shadowroot.html
imported/w3c/web-platform-tests/cssom-view/elementsFromPoint-simple.html
imported/w3c/web-platform-tests/cssom-view/elementsFromPoint-svg.html
imported/w3c/web-platform-tests/cssom-view/elementsFromPoint-table.html

• dom/DocumentOrShadowRoot.idl:
• dom/TreeScope.cpp:

(WebCore::absolutePointIfNotClipped):
(WebCore::TreeScope::nodeFromPoint):
(WebCore::TreeScope::elementFromPoint):
(WebCore::TreeScope::elementsFromPoint):

• dom/TreeScope.h:
• page/EventHandler.cpp:

(WebCore::EventHandler::hitTestResultAtPoint):

• rendering/EllipsisBox.cpp:

(WebCore::EllipsisBox::nodeAtPoint):

• rendering/HitTestRequest.h:

(WebCore::HitTestRequest::HitTestRequest):
(WebCore::HitTestRequest::resultIsElementList):
(WebCore::HitTestRequest::includesAllElementsUnderPoint):

• rendering/HitTestResult.cpp:

(WebCore::HitTestResult::HitTestResult):
(WebCore::HitTestResult::operator=):
(WebCore::HitTestResult::addNodeToListBasedTestResult):
(WebCore::HitTestResult::append):
(WebCore::HitTestResult::listBasedTestResult):
(WebCore::HitTestResult::mutableListBasedTestResult):
(WebCore::HitTestResult::addNodeToRectBasedTestResult): Deleted.
(WebCore::HitTestResult::rectBasedTestResult): Deleted.
(WebCore::HitTestResult::mutableRectBasedTestResult): Deleted.

• rendering/HitTestResult.h:
• rendering/InlineFlowBox.cpp:

(WebCore::InlineFlowBox::nodeAtPoint):

• rendering/InlineTextBox.cpp:

(WebCore::InlineTextBox::nodeAtPoint):

• rendering/RenderBlock.cpp:

(WebCore::RenderBlock::nodeAtPoint):

• rendering/RenderBox.cpp:

(WebCore::RenderBox::nodeAtPoint):

• rendering/RenderImage.cpp:

(WebCore::RenderImage::nodeAtPoint):

• rendering/RenderInline.cpp:

(WebCore::RenderInline::hitTestCulledInline):

• rendering/RenderLayer.cpp:

(WebCore::RenderLayer::hitTestFixedLayersInNamedFlows):
(WebCore::RenderLayer::hitTestLayer):
(WebCore::RenderLayer::hitTestContents):
(WebCore::RenderLayer::hitTestList):
(WebCore::RenderLayer::calculateClipRects):

• rendering/RenderTable.cpp:

(WebCore::RenderTable::nodeAtPoint):

• rendering/RenderTableSection.cpp:

(WebCore::RenderTableSection::nodeAtPoint):

• rendering/RenderWidget.cpp:

(WebCore::RenderWidget::nodeAtPoint):

• rendering/SimpleLineLayoutFunctions.cpp:

(WebCore::SimpleLineLayout::hitTestFlow):

• rendering/svg/RenderSVGContainer.cpp:

(WebCore::RenderSVGContainer::nodeAtFloatPoint):

• rendering/svg/RenderSVGImage.cpp:

(WebCore::RenderSVGImage::nodeAtFloatPoint):

• rendering/svg/RenderSVGRoot.cpp:

(WebCore::RenderSVGRoot::nodeAtPoint):

• rendering/svg/RenderSVGShape.cpp:

(WebCore::RenderSVGShape::nodeAtFloatPoint):

• rendering/svg/SVGInlineTextBox.cpp:

(WebCore::SVGInlineTextBox::nodeAtPoint):

• testing/Internals.cpp:

(WebCore::Internals::nodesFromRect):

LayoutTests:

• TestExpectations: Unskip a test.

1:11 PM Changeset in webkit [219960] by beidson@apple.com

• 44 edits in trunk

Remove DATABASE_PROCESS build flag.
​https://bugs.webkit.org/show_bug.cgi?id=174868

Reviewed by Andy Estes.

.:

• Source/cmake/OptionsGTK.cmake:
• Source/cmake/OptionsMac.cmake:
• Source/cmake/OptionsWPE.cmake:
• Source/cmake/WebKitFeatures.cmake:

Source/WebKit:

• CMakeLists.txt:
• DatabaseProcess/DatabaseProcess.cpp:
• DatabaseProcess/DatabaseProcess.h:
• DatabaseProcess/DatabaseProcess.messages.in:
• DatabaseProcess/DatabaseToWebProcessConnection.cpp:
• DatabaseProcess/DatabaseToWebProcessConnection.h:
• DatabaseProcess/DatabaseToWebProcessConnection.messages.in:
• DatabaseProcess/IndexedDB/WebIDBConnectionToClient.messages.in:
• DatabaseProcess/gtk/DatabaseProcessMainGtk.cpp:
• DatabaseProcess/ios/DatabaseProcessIOS.mm:
• DatabaseProcess/mac/DatabaseProcessMac.mm:
• DatabaseProcess/unix/DatabaseProcessMainUnix.h:
• Shared/Databases/DatabaseProcessCreationParameters.cpp:
• Shared/Databases/DatabaseProcessCreationParameters.h:
• Shared/ProcessExecutablePath.h:
• Shared/gtk/ProcessExecutablePathGtk.cpp:

(WebKit::executablePathOfDatabaseProcess):

• Shared/wpe/ProcessExecutablePathWPE.cpp:

(WebKit::executablePathOfDatabaseProcess):

• UIProcess/ChildProcessProxy.cpp:

(WebKit::ChildProcessProxy::getLaunchOptions):

• UIProcess/Databases/DatabaseProcessProxy.cpp:
• UIProcess/Databases/DatabaseProcessProxy.h:
• UIProcess/Databases/DatabaseProcessProxy.messages.in:
• UIProcess/Launcher/ProcessLauncher.h:
• UIProcess/Launcher/gtk/ProcessLauncherGtk.cpp:

(WebKit::ProcessLauncher::launchProcess):

• UIProcess/Launcher/mac/ProcessLauncherMac.mm:

(WebKit::serviceName):

• UIProcess/Launcher/wpe/ProcessLauncherWPE.cpp:

(WebKit::ProcessLauncher::launchProcess):

• UIProcess/Network/NetworkProcessProxy.cpp:

(WebKit::NetworkProcessProxy::grantSandboxExtensionsToDatabaseProcessForBlobs):

• UIProcess/WebProcessPool.cpp:

(WebKit::WebProcessPool::databaseProcessCrashed):
(WebKit::WebProcessPool::databaseProcessIdentifier):
(WebKit::WebProcessPool::terminateDatabaseProcess):

• UIProcess/WebProcessPool.h:

(WebKit::WebProcessPool::sendToDatabaseProcessRelaunchingIfNecessary):

• UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::getDatabaseProcessConnection):

• UIProcess/WebProcessProxy.h:
• UIProcess/WebProcessProxy.messages.in:
• UIProcess/WebsiteData/WebsiteDataStore.cpp:

(WebKit::WebsiteDataStore::fetchDataAndApply):
(WebKit::WebsiteDataStore::removeData):

• WebKit2Prefix.h:
• WebProcess/Databases/IndexedDB/WebIDBConnectionToServer.messages.in:
• WebProcess/Databases/WebToDatabaseProcessConnection.cpp:
• WebProcess/Databases/WebToDatabaseProcessConnection.h:
• WebProcess/WebProcess.cpp:
• WebProcess/WebProcess.h:

1:08 PM Changeset in webkit [219959] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebCore

[GStreamer] Review WebKitWebSource after r219252.
​https://bugs.webkit.org/show_bug.cgi?id=174415

Patch by Charlie Turner <​cturner@igalia.com> on 2017-07-26
Reviewed by Carlos Garcia Campos.

Remove ResourceHandleStreamingClient, and flatten the StreamingClient
into CachedResourceStreamingClient (the only implemetation left). They
are no longer required after r219252.

Also remove the locking code. It's not needed now, and what existed
was heavy-handed and missed several cases it was supposed to protect

Covered by existing tests.

• platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:

(webkit_web_src_init):
(webKitWebSrcDispose):
(webKitWebSrcStop):
(webKitWebSrcStart):
(webKitWebSrcNeedData):
(webKitWebSrcEnoughData):
(webKitWebSrcSeek):
(webKitWebSrcSetMediaPlayer):
(CachedResourceStreamingClient::CachedResourceStreamingClient):
(CachedResourceStreamingClient::~CachedResourceStreamingClient):
(CachedResourceStreamingClient::getOrCreateReadBuffer):
(CachedResourceStreamingClient::responseReceived):
(CachedResourceStreamingClient::dataReceived):
(CachedResourceStreamingClient::loadFinished):
(ResourceHandleStreamingClient::create): Deleted.
(): Deleted.
(StreamingClient::StreamingClient): Deleted.
(StreamingClient::~StreamingClient): Deleted.
(StreamingClient::createReadBuffer): Deleted.
(StreamingClient::handleResponseReceived): Deleted.
(StreamingClient::handleDataReceived): Deleted.
(StreamingClient::handleNotifyFinished): Deleted.
(ResourceHandleStreamingClient::ResourceHandleStreamingClient): Deleted.
(ResourceHandleStreamingClient::~ResourceHandleStreamingClient): Deleted.
(ResourceHandleStreamingClient::cleanupAndStopRunLoop): Deleted.
(ResourceHandleStreamingClient::invalidate): Deleted.
(ResourceHandleStreamingClient::loadFailed): Deleted.
(ResourceHandleStreamingClient::setDefersLoading): Deleted.
(ResourceHandleStreamingClient::getOrCreateReadBuffer): Deleted.
(ResourceHandleStreamingClient::willSendRequest): Deleted.
(ResourceHandleStreamingClient::didReceiveResponse): Deleted.
(ResourceHandleStreamingClient::didReceiveData): Deleted.
(ResourceHandleStreamingClient::didReceiveBuffer): Deleted.
(ResourceHandleStreamingClient::didFinishLoading): Deleted.
(ResourceHandleStreamingClient::didFail): Deleted.
(ResourceHandleStreamingClient::wasBlocked): Deleted.
(ResourceHandleStreamingClient::cannotShowURL): Deleted.

1:00 PM Changeset in webkit [219958] by beidson@apple.com

• 6 edits in trunk

Add test to verify certain child processes are not launched as a side effect of enabling ResourceLoadStatistics.
​https://bugs.webkit.org/show_bug.cgi?id=174851

Reviewed by Chris Dumez.

Source/WebKit:

• UIProcess/API/Cocoa/WKProcessPool.mm:

(-[WKProcessPool _databaseProcessIdentifier]):
(-[WKProcessPool _pluginProcessCount]):

• UIProcess/API/Cocoa/WKProcessPoolPrivate.h:

• UIProcess/Plugins/PluginProcessManager.h:

(WebKit::PluginProcessManager::pluginProcesses):

Tools:

• TestWebKitAPI/Tests/WebKit2Cocoa/ResourceLoadStatistics.mm:

(TEST):

12:24 PM Changeset in webkit [219957] by matthew_hanson@apple.com

• 2 edits in branches/safari-604-branch/LayoutTests

Cherry-pick r219877. rdar://problem/33523803

12:24 PM Changeset in webkit [219956] by matthew_hanson@apple.com

• 60 edits
  9 adds in branches/safari-604-branch

Cherry-pick r219876. rdar://problem/33523847

12:24 PM Changeset in webkit [219955] by matthew_hanson@apple.com

• 47 edits
  9 deletes in branches/safari-604-branch

Cherry-pick r219620. rdar://problem/33523847

11:40 AM Changeset in webkit [219954] by BJ Burg

• 91 edits in trunk

Remove WEB_TIMING feature flag
​https://bugs.webkit.org/show_bug.cgi?id=174795

Reviewed by Alex Christensen.

.:

• Source/cmake/OptionsWPE.cmake:
• Source/cmake/OptionsWin.cmake:
• Source/cmake/WebKitFeatures.cmake:
• Source/cmake/tools/vsprops/FeatureDefines.props:
• Source/cmake/tools/vsprops/FeatureDefinesCairo.props:

Source/JavaScriptCore:

• Configurations/FeatureDefines.xcconfig:

Source/WebCore:

• Configurations/FeatureDefines.xcconfig:
• bindings/js/JSPerformanceEntryCustom.cpp:
• dom/Document.cpp:

(WebCore::Document::setReadyState):
(WebCore::Document::finishedParsing):

• dom/Document.h:

(WebCore::Document::timing):

• dom/DocumentTiming.h:
• dom/EventTargetFactory.in:
• loader/DocumentThreadableLoader.cpp:

(WebCore::DocumentThreadableLoader::finishedTimingForWorkerLoad):
(WebCore::DocumentThreadableLoader::loadRequest):

• loader/DocumentThreadableLoader.h:
• loader/ResourceTimingInformation.cpp:
• loader/ResourceTimingInformation.h:
• loader/SubresourceLoader.cpp:

(WebCore::SubresourceLoader::didFinishLoading):
(WebCore::SubresourceLoader::reportResourceTiming):

• loader/SubresourceLoader.h:
• loader/ThreadableLoaderClient.h:

(WebCore::ThreadableLoaderClient::didFail):
(WebCore::ThreadableLoaderClient::didFinishTiming):

• loader/WorkerThreadableLoader.cpp:

(WebCore::WorkerThreadableLoader::MainThreadBridge::didFinishTiming):

• loader/WorkerThreadableLoader.h:
• loader/cache/CachedResourceLoader.cpp:

(WebCore::CachedResourceLoader::requestResource):
(WebCore::CachedResourceLoader::revalidateResource):
(WebCore::CachedResourceLoader::loadResource):

• loader/cache/CachedResourceLoader.h:

(WebCore::CachedResourceLoader::resourceTimingInformation):

• page/DOMWindow.cpp:

(WebCore::DOMWindow::~DOMWindow):
(WebCore::DOMWindow::resetDOMWindowProperties):
(WebCore::DOMWindow::nowTimestamp):
(WebCore::DOMWindow::removeAllEventListeners):

• page/DOMWindow.h:
• page/GlobalPerformance.idl:
• page/Performance.cpp:
• page/Performance.h:
• page/Performance.idl:
• page/PerformanceEntry.cpp:
• page/PerformanceEntry.h:
• page/PerformanceEntry.idl:
• page/PerformanceMark.h:
• page/PerformanceMark.idl:
• page/PerformanceMeasure.h:
• page/PerformanceMeasure.idl:
• page/PerformanceNavigation.cpp:
• page/PerformanceNavigation.h:
• page/PerformanceNavigation.idl:
• page/PerformanceObserver.cpp:
• page/PerformanceObserver.h:
• page/PerformanceObserver.idl:
• page/PerformanceObserverCallback.h:
• page/PerformanceObserverCallback.idl:
• page/PerformanceObserverEntryList.cpp:
• page/PerformanceObserverEntryList.h:
• page/PerformanceObserverEntryList.idl:
• page/PerformanceResourceTiming.cpp:
• page/PerformanceResourceTiming.h:
• page/PerformanceResourceTiming.idl:
• page/PerformanceTiming.cpp:
• page/PerformanceTiming.h:
• page/PerformanceTiming.idl:
• page/PerformanceUserTiming.cpp:
• page/PerformanceUserTiming.h:
• platform/network/ResourceHandle.h:
• platform/network/ResourceHandleInternal.h:
• platform/network/cf/ResourceHandleCFNet.cpp:

(WebCore::ResourceHandle::start):

• platform/network/cf/ResourceHandleCFURLConnectionDelegateWithOperationQueue.cpp:

(WebCore::ResourceHandleCFURLConnectionDelegateWithOperationQueue::didReceiveResponse):

• platform/network/cf/SynchronousResourceHandleCFURLConnectionDelegate.cpp:

(WebCore::SynchronousResourceHandleCFURLConnectionDelegate::didReceiveResponse):

• platform/network/curl/ResourceHandleCurl.cpp:

(WebCore::ResourceHandleInternal::didFinish):
(WebCore::ResourceHandleInternal::calculateWebTimingInformations):
(WebCore::ResourceHandleInternal::dispatchSynchronousJob):

• platform/network/mac/ResourceHandleMac.mm:

(WebCore::ResourceHandle::createNSURLConnection):

• platform/network/mac/WebCoreResourceHandleAsDelegate.mm:

(-[WebCoreResourceHandleAsDelegate connection:didReceiveResponse:]):

• platform/network/mac/WebCoreResourceHandleAsOperationQueueDelegate.mm:

(-[WebCoreResourceHandleAsOperationQueueDelegate connection:didReceiveResponse:]):

• platform/network/soup/ResourceHandleSoup.cpp:

(WebCore::restartedCallback):
(WebCore::sendRequestCallback):
(WebCore::createSoupMessageForHandleAndRequest):
(WebCore::ResourceHandle::sendPendingRequest):

• platform/network/soup/SoupNetworkSession.cpp:

(WebCore::SoupNetworkSession::SoupNetworkSession):

• workers/WorkerGlobalScope.cpp:

(WebCore::WorkerGlobalScope::WorkerGlobalScope):
(WebCore::WorkerGlobalScope::~WorkerGlobalScope):
(WebCore::WorkerGlobalScope::removeAllEventListeners):

• workers/WorkerGlobalScope.h:

Source/WebCore/PAL:

• Configurations/FeatureDefines.xcconfig:

Source/WebInspectorUI:

Remove fallback for ports that lack WEB_TIMING.

• UserInterface/Base/Utilities.js:

(timestamp): Deleted.

• UserInterface/Protocol/Connection.js:

(InspectorBackend.Connection.prototype._dispatchResponse):
(InspectorBackend.Connection.prototype._dispatchEvent):
(InspectorBackend.Connection.prototype._sendCommandToBackendWithCallback):
(InspectorBackend.Connection.prototype._sendCommandToBackendExpectingPromise):

• UserInterface/Protocol/MessageDispatcher.js:

(WebInspector.dispatchNextQueuedMessageFromBackend):

Source/WebKit:

• Configurations/FeatureDefines.xcconfig:
• NetworkProcess/soup/NetworkDataTaskSoup.cpp:

(WebKit::NetworkDataTaskSoup::NetworkDataTaskSoup):
(WebKit::NetworkDataTaskSoup::createRequest):
(WebKit::NetworkDataTaskSoup::didSendRequest):
(WebKit::NetworkDataTaskSoup::dispatchDidReceiveResponse):
(WebKit::NetworkDataTaskSoup::dispatchDidCompleteWithError):
(WebKit::NetworkDataTaskSoup::continueHTTPRedirection):
(WebKit::NetworkDataTaskSoup::didGetHeaders):
(WebKit::NetworkDataTaskSoup::didRestart):

• NetworkProcess/soup/NetworkDataTaskSoup.h:

Source/WebKitLegacy/mac:

• Configurations/FeatureDefines.xcconfig:

Source/WTF:

• wtf/FeatureDefines.h:

Tools:

• Scripts/webkitperl/FeatureList.pm:
• TestWebKitAPI/Configurations/FeatureDefines.xcconfig:

LayoutTests:

• inspector/formatting/resources/javascript-tests/sample-normal-utilities-expected.js:

(decodeBase64ToBlob):
(timestamp): Deleted.

• inspector/formatting/resources/javascript-tests/sample-normal-utilities.js:

(decodeBase64ToBlob):
(timestamp): Deleted.

11:33 AM Changeset in webkit [219953] by Matt Lewis

• 3 edits in trunk/LayoutTests

Rebaselined multiple fast/css/getComputedStyle.
<rdar://problem/33416054>

Unreviewed test gardening.

• platform/mac-highsierra/fast/css/getComputedStyle/computed-style-expected.txt:
• platform/mac-highsierra/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:

11:32 AM Changeset in webkit [219952] by BJ Burg

• 2 edits in trunk/Source/WebKit

Use SandboxExtension::HandleArray when sending extensions for file uploads to the web process
​https://bugs.webkit.org/show_bug.cgi?id=174828

Reviewed by Tim Horton.

In the previous change I forgot to hoist the HandleArray and message-send out of the
loop, so the code wasn't actually sending fewer messages. That's fixed now.

• UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::didChooseFilesForOpenPanelWithDisplayStringAndIcon):
(WebKit::WebPageProxy::didChooseFilesForOpenPanel):

11:31 AM Changeset in webkit [219951] by mark.lam@apple.com

• 3 edits in trunk/Source/JavaScriptCore

Add the ability to change sp and pc to the ARM64 JIT probe.
​https://bugs.webkit.org/show_bug.cgi?id=174697
<rdar://problem/33436965>

Reviewed by JF Bastien.

This patch implements the following:

1. The ARM64 probe now supports modifying the pc and sp.

However, lr is not preserved when modifying the pc because it is used as the
scratch register for the indirect jump. Hence, the probe handler function
may not modify both lr and pc in the same probe invocation.

2. Fix probe tests to use bitwise comparison when comparing double register values. Otherwise, equivalent nan values will be interpreted as not equivalent.

3. Change the minimum offset increment in testProbeModifiesStackPointer to be 16 bytes for ARM64. This is because the ARM64 probe now uses the ldp and stp instructions which require 16 byte alignment for their memory access.

• assembler/MacroAssemblerARM64.cpp:

(JSC::arm64ProbeError):
(JSC::MacroAssembler::probe):
(JSC::arm64ProbeTrampoline): Deleted.

• assembler/testmasm.cpp:

(JSC::isSpecialGPR):
(JSC::testProbeReadsArgumentRegisters):
(JSC::testProbeWritesArgumentRegisters):
(JSC::testProbePreservesGPRS):
(JSC::testProbeModifiesStackPointer):
(JSC::testProbeModifiesStackPointerToInsideProbeContextOnStack):
(JSC::testProbeModifiesStackPointerToNBytesBelowSP):

10:15 AM Changeset in webkit [219950] by Chris Dumez

• 8 edits
  2 adds in trunk

Pressing the Escape key should not be a valid user gesture to enter fullscreen
​https://bugs.webkit.org/show_bug.cgi?id=174864
<rdar://problem/33009088>

Reviewed by Geoffrey Garen.

Source/WebCore:

Pressing the Escape key should not be a valid user gesture to enter fullscreen since this
is the gesture to exit fullscreen already.

Test: fullscreen/requestFullscreen-escape-key.html

• dom/Document.cpp:

(WebCore::Document::requestFullScreenForElement):

• dom/UserGestureIndicator.cpp:

(WebCore::UserGestureIndicator::UserGestureIndicator):

• dom/UserGestureIndicator.h:

(WebCore::UserGestureToken::create):
(WebCore::UserGestureToken::gestureType):
(WebCore::UserGestureToken::UserGestureToken):

• page/EventHandler.cpp:

(WebCore::EventHandler::internalKeyEvent):

Tools:

Add support for eventSender.keyDown('escape') in DRT to match the behavior of
WKTR.

• DumpRenderTree/mac/EventSendingController.mm:

(-[EventSendingController keyDown:withModifiers:withLocation:]):

LayoutTests:

Add layout test coverage.

• fullscreen/requestFullscreen-escape-key-expected.txt: Added.
• fullscreen/requestFullscreen-escape-key.html: Added.

9:53 AM Changeset in webkit [219949] by n_wang@apple.com

• 5 edits in trunk

AX: Incorrect range from index and length in contenteditable with <p> tags
​https://bugs.webkit.org/show_bug.cgi?id=174856

Reviewed by Chris Fleizach.

Source/WebCore:

When asking for the string inside a text control with a given range, we sometimes get
a wrong string at the line boundary due to a bad plain range to text marker conversion.
To fix this, we should use the exsisting method on text controls to avoid this issue.

Updated the test to test the problematic case.

• accessibility/mac/WebAccessibilityObjectWrapperMac.mm:

(-[WebAccessibilityObjectWrapper accessibilityAttributeValue:forParameter:]):

LayoutTests:

• accessibility/mac/range-for-contenteditable-newline-expected.txt:
• accessibility/mac/range-for-contenteditable-newline.html:

8:29 AM Changeset in webkit [219948] by commit-queue@webkit.org

• 3 edits in trunk/Source/WebCore

[Curl] Bug fix after r219606
​https://bugs.webkit.org/show_bug.cgi?id=174845

Patch by Daewoong Jang <​daewoong.jang@navercorp.com> on 2017-07-26
Reviewed by Alex Christensen.

• platform/network/curl/CurlContext.h:

(WebCore::CurlSList::isEmpty):

• platform/network/curl/ResourceHandleCurl.cpp:

(WebCore::ResourceHandleInternal::didReceiveHeaderLine):
(WebCore::ResourceHandleInternal::headerCallback):

8:27 AM Changeset in webkit [219947] by commit-queue@webkit.org

• 2 edits in trunk/LayoutTests

Remove obsolete failure annotation for bad-charset-alias.html.
​https://bugs.webkit.org/show_bug.cgi?id=145048

Patch by Ms2ger <​Ms2ger@igalia.com> on 2017-07-26
Reviewed by Carlos Garcia Campos.

This appears to have been fixed in r204850.

• platform/gtk/TestExpectations:

7:33 AM Changeset in webkit [219946] by zandobersek@gmail.com

• 4 edits in trunk/Source/WebCore

[EME][GStreamer] Multi-key support in the GStreamer ClearKey decryptor
​https://bugs.webkit.org/show_bug.cgi?id=174779

Reviewed by Xabier Rodriguez-Calvar.

In the CENC decryptor, the key ID value is retrieved from the info structure
on the GstProtectionMeta object. GstBuffer for that value is retrieved and
passed to the setupCipher() function.

In the ClearKey decryptor (which extends the CENC decryptor), the single
GstBuffer object on the private instance that holds the key value is replaced
with a Vector object that holds pairs of key ID and value GstBuffers. In the
handleKeyResponse() implementation that Vector is emptied and then refilled
with key ID and value pairs that are passed in through the drm-cipher-clearkey
structure that's attached to the GstEvent that signalled new key information.

In the ClearKey decryptor's setupCipher() implementation the passed-in key ID
buffer is used to find a matching key ID and value pair stored on the private
instance. If not found, an error is thrown. If found, the matching key value
is used for decryption.

• platform/graphics/gstreamer/eme/WebKitClearKeyDecryptorGStreamer.cpp:

(webKitMediaClearKeyDecryptorHandleKeyResponse):
(webKitMediaClearKeyDecryptorSetupCipher):

• platform/graphics/gstreamer/eme/WebKitCommonEncryptionDecryptorGStreamer.cpp:

(webkitMediaCommonEncryptionDecryptTransformInPlace):
(webKitMediaCommonEncryptionDecryptDefaultSetupCipher):

• platform/graphics/gstreamer/eme/WebKitCommonEncryptionDecryptorGStreamer.h:

7:31 AM Changeset in webkit [219945] by zandobersek@gmail.com

• 2 edits in trunk/Source/WebCore

[EME][GStreamer] Handle ClearKey as a supported key system
​https://bugs.webkit.org/show_bug.cgi?id=174778

Reviewed by Xabier Rodriguez-Calvar.

• platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:

(WebCore::MediaPlayerPrivateGStreamerBase::supportsKeySystem):
Return true for the 'org.w3.clearkey' key system when building with
ENCRYPTED_MEDIA enabled. The underlying implementation will follow.

7:23 AM Changeset in webkit [219944] by fred.wang@free.fr

• 2 edits
  1 add in trunk/Websites/webkit.org

Unreviewed, minor adjustments to the previous demo.

Patch by Frederic Wang <​fwang@igalia.com> on 2017-07-26

• demos/frames/index.html: Added. Index page for the list of demos.
• demos/frames/sandboxing/index.html: Minor fixes.

6:52 AM Changeset in webkit [219943] by Claudio Saavedra

• 2 edits in trunk/Source/WebCore

[WPE] Fix a potential crash in the platform pasteboard when reading a string
​https://bugs.webkit.org/show_bug.cgi?id=174859

Reviewed by Žan Doberšek.

We shouldn't assume that the wpe_pasteboard_string struct will be
filled in, so initialize it.

• platform/wpe/PlatformPasteboardWPE.cpp:

(WebCore::PlatformPasteboard::readString): Initialize the struct
before passing it to wpe and early return if it's still empty.

6:43 AM Changeset in webkit [219942] by fred.wang@free.fr

• 1 edit
  8 adds in trunk/Websites/webkit.org

Unreviewed, add demos (frame sandboxing and scrolling) for a blog post.

Patch by Frederic Wang <​fwang@igalia.com> on 2017-07-26

• demos/frames/sandboxing/am-i-sandboxed.html: Added.
• demos/frames/sandboxing/framebusting-success.html: Added.
• demos/frames/sandboxing/framebusting-without-user-activation.html: Added.
• demos/frames/sandboxing/index.html: Added.
• demos/frames/scrollable-iframes.html: Added.
• demos/frames/scrollingElement.html: Added.

6:41 AM Changeset in webkit [219941] by romain.bellessort@crf.canon.fr

• 2 edits in trunk/Tools

Unreviewed, added Romain Bellessort to contributors.json.

• Scripts/webkitpy/common/config/contributors.json:

6:09 AM Changeset in webkit [219940] by zandobersek@gmail.com

• 2 edits in trunk/Source/WebKit

Unreviewed. Fix a compiler warning that springs up when
building the WPE port with Clang.

• UIProcess/API/wpe/ScrollGestureController.h:

Let ScrollGestureController be a class, and not a struct.
This fits the usual pattern, and also matches the forward
declaration used in WPE's PageClientImpl.h.

3:33 AM Changeset in webkit [219939] by commit-queue@webkit.org

• 2 edits in trunk/LayoutTests

Remove obsolete failure expectations for 2d.fillStyle.parse.{rgb,rgba}-eof.
​https://bugs.webkit.org/show_bug.cgi?id=174857

Patch by Ms2ger <​Ms2ger@igalia.com> on 2017-07-26
Reviewed by Žan Doberšek.

These tests started passing in r209666.

• platform/gtk/TestExpectations:

2:52 AM Changeset in webkit [219938] by jmarcell@apple.com

• 6 edits in branches/safari-604-branch

Cherry-pick r219764. rdar://problem/33523878

2:52 AM Changeset in webkit [219937] by jmarcell@apple.com

• 18 edits in branches/safari-604-branch/Source/WebCore

Cherry-pick r219762. rdar://problem/33523889

2:52 AM Changeset in webkit [219936] by jmarcell@apple.com

• 2 edits in branches/safari-604-branch/Source/WebKit

Cherry-pick r219739. rdar://problem/33523884

2:52 AM Changeset in webkit [219935] by jmarcell@apple.com

• 4 edits in branches/safari-604-branch/Source/WebCore

Cherry-pick r219738. rdar://problem/33523826

2:52 AM Changeset in webkit [219934] by jmarcell@apple.com

• 8 edits
  2 adds in branches/safari-604-branch

Cherry-pick r219594. rdar://problem/33523357

2:52 AM Changeset in webkit [219933] by jmarcell@apple.com

• 3 edits in branches/safari-604-branch/Source/WebKit

Cherry-pick r219845. rdar://problem/33523884

2:52 AM Changeset in webkit [219932] by jmarcell@apple.com

• 2 edits in branches/safari-604-branch/LayoutTests

Cherry-pick r219841. rdar://problem/33524930

2:52 AM Changeset in webkit [219931] by jmarcell@apple.com

• 2 edits in branches/safari-604-branch/LayoutTests

Cherry-pick r219837. rdar://problem/33524936

2:52 AM Changeset in webkit [219930] by jmarcell@apple.com

• 3 edits
  1 copy in branches/safari-604-branch/Tools

Cherry-pick r219836. rdar://problem/33523818

2:52 AM Changeset in webkit [219929] by jmarcell@apple.com

• 12 edits
  2 adds in branches/safari-604-branch

Cherry-pick r219829. rdar://problem/33523803

2:52 AM Changeset in webkit [219928] by jmarcell@apple.com

• 2 edits in branches/safari-604-branch/Source/WebKit

Cherry-pick r219765. rdar://problem/33523818

2:52 AM Changeset in webkit [219927] by jmarcell@apple.com

• 3 edits in branches/safari-604-branch/Source/WebCore

Cherry-pick r219761. rdar://problem/33523829

2:51 AM Changeset in webkit [219926] by jmarcell@apple.com

• 8 edits in branches/safari-604-branch/Source/WebCore

Cherry-pick r219756. rdar://problem/33523829

2:51 AM Changeset in webkit [219925] by jmarcell@apple.com

• 5 edits
  2 adds in branches/safari-604-branch

Cherry-pick r219755. rdar://problem/33523843

2:51 AM Changeset in webkit [219924] by jmarcell@apple.com

• 2 edits in branches/safari-604-branch/Source/WebKit

Cherry-pick r219754. rdar://problem/33523873

2:51 AM Changeset in webkit [219923] by jmarcell@apple.com

• 2 edits in branches/safari-604-branch/Source/WebCore

Cherry-pick r219752. rdar://problem/33524766

2:51 AM Changeset in webkit [219922] by jmarcell@apple.com

• 7 edits
  2 adds in branches/safari-604-branch

Cherry-pick r219751. rdar://problem/33523861

2:51 AM Changeset in webkit [219921] by jmarcell@apple.com

• 3 edits
  1 delete in branches/safari-604-branch/Source/WebKit

Cherry-pick r219750. rdar://problem/33523870

2:51 AM Changeset in webkit [219920] by jmarcell@apple.com

• 2 edits in branches/safari-604-branch/Source/WebCore

Cherry-pick r219742. rdar://problem/33523798

2:51 AM Changeset in webkit [219919] by jmarcell@apple.com

• 2 edits in branches/safari-604-branch/Source/WebCore

Cherry-pick r219737. rdar://problem/33523854

2:51 AM Changeset in webkit [219918] by jmarcell@apple.com

• 2 edits in branches/safari-604-branch/Source/WebCore

Cherry-pick r219736. rdar://problem/33523835

2:51 AM Changeset in webkit [219917] by jmarcell@apple.com

• 3 edits
  2 adds in branches/safari-604-branch

Cherry-pick r219638. rdar://problem/33523787

2:51 AM Changeset in webkit [219916] by jmarcell@apple.com

• 47 edits
  9 adds in branches/safari-604-branch

Cherry-pick r219610. rdar://problem/33523847

2:51 AM Changeset in webkit [219915] by jmarcell@apple.com

• 9 edits in branches/safari-604-branch

Revert r219342. rdar://problem/33523803

2:48 AM Changeset in webkit [219914] by jfernandez@igalia.com

• 3 edits
  16 adds in trunk

InsertOrderedList command applied to table cells inserts an extra BR before the table
​https://bugs.webkit.org/show_bug.cgi?id=174593

Reviewed by Darin Adler.

Source/WebCore:

Don't add BR when pruning empty blocks if it's the start of a paragraph.

The function MoveParagraph is used for several operations and editing
commands, like 'insertOrderedList'. When moving paragraphs we check out
whether we should add a 'br' element to avoid undesired block collapse.

However, we shouldn't do this when destination is the start of a
paragraph.

Tests: editing/inserting/insert-list-in-table-cell-01.html

editing/inserting/insert-list-in-table-cell-02.html
editing/inserting/insert-list-in-table-cell-03.html
editing/inserting/insert-list-in-table-cell-04.html
editing/inserting/insert-list-in-table-cell-05.html
editing/inserting/insert-list-in-table-cell-06.html
editing/inserting/insert-list-in-table-cell-07.html
editing/inserting/insert-list-in-table-cell-08.html

• editing/CompositeEditCommand.cpp:

(WebCore::CompositeEditCommand::moveParagraphs):

LayoutTests:

Tests to verify that the insertOrderedList command works as expected when applied
in table cells.

• editing/inserting/insert-list-in-table-cell-01.html: Added.
• editing/inserting/insert-list-in-table-cell-01-expected.txt: Added.
• editing/inserting/insert-list-in-table-cell-02.html: Added.
• editing/inserting/insert-list-in-table-cell-02-expected.txt: Added.
• editing/inserting/insert-list-in-table-cell-03.html: Added.
• editing/inserting/insert-list-in-table-cell-03-expected.txt: Added.
• editing/inserting/insert-list-in-table-cell-04.html: Added.
• editing/inserting/insert-list-in-table-cell-04-expected.txt: Added.
• editing/inserting/insert-list-in-table-cell-05.html: Added.
• editing/inserting/insert-list-in-table-cell-05-expected.txt: Added.
• editing/inserting/insert-list-in-table-cell-06.html: Added.
• editing/inserting/insert-list-in-table-cell-06-expected.txt: Added.
• editing/inserting/insert-list-in-table-cell-07.html: Added.
• editing/inserting/insert-list-in-table-cell-07-expected.txt: Added.
• editing/inserting/insert-list-in-table-cell-08.html: Added.
• editing/inserting/insert-list-in-table-cell-08-expected.txt: Added.

2:22 AM Changeset in webkit [219913] by commit-queue@webkit.org

• 6 edits
  1 delete in trunk/LayoutTests

Fix an incorrect check in 2d.missingargs.html.
​https://bugs.webkit.org/show_bug.cgi?id=174854

Patch by Ms2ger <​Ms2ger@igalia.com> on 2017-07-26
Reviewed by Carlos Garcia Campos.

The check was introduced without explanation in r168302. This change reverts
it to the previous, correct check.

• canvas/philip/tests/2d.missingargs-expected.txt:
• canvas/philip/tests/2d.missingargs.html:
• platform/gtk/TestExpectations:
• platform/ios/TestExpectations:
• platform/mac/canvas/philip/tests/2d.missingargs-expected.txt: Removed.
• platform/wpe/TestExpectations:

2:01 AM Changeset in webkit [219912] by Claudio Saavedra

• 4 edits in trunk

[WPE] Enable KeyboardEvent key and code attributes
​https://bugs.webkit.org/show_bug.cgi?id=174822

Reviewed by Žan Doberšek.

Source/WTF:

There is no reason for this to be disabled from what I see.

• wtf/FeatureDefines.h: Enable KeyboardEvent key and code attributes.

LayoutTests:

• platform/wpe/TestExpectations: Mark

fast/events/constructors/keyboard-event-constructor.html as passing.

1:31 AM Changeset in webkit [219911] by Carlos Garcia Campos

• 2 edits in trunk

Unreviewed. Fix WebKit2 derived sources directory creation after r219488.

The variable is still DERIVED_SOURCES_WEBKIT2_DIR, not DERIVED_SOURCES_WEBKIT_DIR. Build was not really affected
because WebKit2 makefile creates the directory too.

• Source/cmake/WebKitFS.cmake:

1:26 AM Changeset in webkit [219910] by zandobersek@gmail.com

• 7 edits in trunk

[WPE] WebGL2 support
​https://bugs.webkit.org/show_bug.cgi?id=174249

Reviewed by Alex Christensen.

Source/WebCore:

Implement WebGL2 support in GraphicsContext3DCairo for the WPE port, but keep
the implementation specific to libepoxy (which WPE leverages by default).

In the GraphicsContext3D::create() method, we first construct the
GraphicsContext3D object that also ensures a current GL context on this thread.
Only then can we determine through libepoxy whether the underlying GL library
is able to support WebGL2.

For WebGL2, the GLES3 support is required. The initial libepoxy implementation
ensures this only in case of 'non-desktop GL' library of minimum version 3.0.
This effectively translates to the only supported configuration being the
EGL and OpenGL ES 3.0 (or higher) combination. If this cannot be ensured, we
discard the existing GraphicsContext3D object and return null.

WebGL2 can also be supported via OpenGL (i.e. 'desktop GL'), but this hasn't
been tested yet. Implementation will in the future be extended to support that
as required.

In the GraphicsContext3D constructor itself, the ANGLEWebKitBridge constructor
has to now receive the second argument, the desired shader specification that's
used when parsing the provided shaders. This should be SH_WEBGL_SPEC for WebGL1,
and SH_WEBGL2_SPEC for WebGL2.

No new tests -- a small set of existing WebGL2 tests is unskipped and passing.

• platform/graphics/cairo/GraphicsContext3DCairo.cpp:

(WebCore::GraphicsContext3D::create):
(WebCore::GraphicsContext3D::GraphicsContext3D):

• platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:

Add WebGL2-specific methods to the build.

Tools:

• Scripts/webkitperl/FeatureList.pm:

Enable WebGL2 for WPE when building through build-webkit.

LayoutTests:

• platform/wpe/TestExpectations:

Unskip WebGL2 tests under the webgl/ directory. More tests under fast/canvas/webgl2/
will be unskipped later.

1:16 AM Changeset in webkit [219909] by Carlos Garcia Campos

• 1 copy in releases/WebKitGTK/webkit-2.17.5

WebKitGTK+ 2.17.5

1:15 AM Changeset in webkit [219908] by Carlos Garcia Campos

• 4 edits in trunk

Unreviewed. Update OptionsGTK.cmake and NEWS for 2.17.5 release.

.:

• Source/cmake/OptionsGTK.cmake: Bump version numbers.

Source/WebKit:

• gtk/NEWS: Add release notes for 2.17.5.

1:13 AM Changeset in webkit [219907] by Carlos Garcia Campos

• 4 edits in trunk

Unreviewed. Fix GTK distcheck.

Source/WebDriver:

Ensure WebDriver derived sources directory is created, WebKitFS.cmake is useless for this.

• PlatformGTK.cmake:

Tools:

• gtk/make-dist.py:

(ensure_version_if_possible): Use the right pkg-config filename, it's webkit2gtk not webkitgtk.

12:39 AM Changeset in webkit [219906] by n_wang@apple.com

• 11 edits in trunk

AX: should dispatch accessibilityPerformPressAction async on MacOS
​https://bugs.webkit.org/show_bug.cgi?id=174849

Reviewed by Chris Fleizach.

Source/WebCore:

If performing the accessibility press action results in a modal alert being displayed,
it can cause VoiceOver to hang. To fix it, we should dispatch the action asynchronously.

Updated tests to adapt to this change.

• accessibility/mac/WebAccessibilityObjectWrapperMac.mm:

(-[WebAccessibilityObjectWrapper accessibilityPerformPressAction]):
(-[WebAccessibilityObjectWrapper _accessibilityPerformPressAction]):

LayoutTests:

• accessibility/file-upload-button-with-axpress.html:
• accessibility/mac/html5-input-number.html:
• accessibility/mac/search-field-cancel-button.html:
• accessibility/press-target-uses-text-descendant-node.html:
• accessibility/press-targets-center-point.html:
• accessibility/press-works-on-control-types.html:

Jul 25, 2017:

11:19 PM Changeset in webkit [219905] by Carlos Garcia Campos

• 4 edits in trunk/Source

Icon loader error on startup
​https://bugs.webkit.org/show_bug.cgi?id=174787

Reviewed by Brady Eidson.

Source/WebCore:

This is a regression of the new icon loading, it happens with pages that shouldn't have a favicon, like about
pages. IconController::startLoader() did several checks before starting the load that
DocumentLoader::startIconLoading() is not doing. It checked that the frame is the main one, the document can have
an icon (document url is not empty and not about:blank) and that favicon url is in HTTP family. We should do the
same checks now before starting to load icons.

• loader/DocumentLoader.cpp:

(WebCore::DocumentLoader::startIconLoading):

Source/WebKit:

Ignore non HTTP favicons in glib API.

• UIProcess/API/glib/WebKitIconLoadingClient.cpp:

10:44 PM Changeset in webkit [219904] by beidson@apple.com

• 13 edits
  2 adds in trunk

ResourceLoadStatistics grandfathering happens much too often.
<rdar://problem/32655834> and ​https://bugs.webkit.org/show_bug.cgi?id=174825

Reviewed by Chris Dumez.

Source/WebKit:

The ResourceLoadStatistics grandfathering procedure happens too often.

• With an empty memory store, even though an empty memory store is a perfectly valid state.
• On each launch, even if grandfathering happened on the last launch - because grandfathering data would not automatically be saved to disk.
• After clearing all website data, at which point no grandfathering can possibly be relevant because there is no data to grandfather.

This patch fixes those cases and adds API tests to verify they remain fixed.

• Shared/WebsiteData/WebsiteDataType.h:

• UIProcess/API/Cocoa/WKWebsiteDataStore.mm:

(+[WKWebsiteDataStore _allWebsiteDataTypesIncludingPrivate]): allWebsiteDataTypes, but even with the private ones.
(-[WKWebsiteDataStore _resourceLoadStatisticsClearInMemoryAndPersistentStore]): If the types being cleared cover all of

the types that ResourceLoadStatistics care about, don't grandfather afterwards.

(-[WKWebsiteDataStore _resourceLoadStatisticsClearInMemoryAndPersistentStoreModifiedSinceHours:]): Ditto.
(-[WKWebsiteDataStore _setResourceLoadStatisticsTestingCallback:]):

• UIProcess/API/Cocoa/WKWebsiteDataStorePrivate.h:

• UIProcess/Storage/ResourceLoadStatisticsPersistentStorage.cpp:

(WebKit::ResourceLoadStatisticsPersistentStorage::populateMemoryStoreFromDisk): Don't grandfather if the store read from

disk is empty (as being empty is perfectly fine), and also log the event of "populated without grandfathering".

• UIProcess/Storage/ResourceLoadStatisticsPersistentStorage.h:

• UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::topPrivatelyControlledDomainsWithWebsiteData):

• UIProcess/WebResourceLoadStatisticsStore.cpp:

(WebKit::WebResourceLoadStatisticsStore::monitoredDataTypes):
(WebKit::WebResourceLoadStatisticsStore::WebResourceLoadStatisticsStore):
(WebKit::WebResourceLoadStatisticsStore::~WebResourceLoadStatisticsStore):
(WebKit::WebResourceLoadStatisticsStore::removeDataRecords):
(WebKit::WebResourceLoadStatisticsStore::grandfatherExistingWebsiteData): Schedule a write right away so we don't re-grandfather

on next launch, and also log the grandfathering event.

(WebKit::WebResourceLoadStatisticsStore::scheduleClearInMemoryAndPersistent): Takes a ShouldGrandfather flag

to tell whether or not data should be re-grandfathered after the store is cleared.

(WebKit::WebResourceLoadStatisticsStore::logTestingEvent): Log the event to the testing client.
(WebKit::dataTypesToRemove): Deleted.

• UIProcess/WebResourceLoadStatisticsStore.h:

• UIProcess/WebsiteData/WebsiteDataStore.cpp:

(WebKit::WebsiteDataStore::removeData):
(WebKit::WebsiteDataStore::setResourceLoadStatisticsEnabled):
(WebKit::WebsiteDataStore::enableResourceLoadStatisticsAndSetTestingCallback): Handles enabling ResourceLoadStatistics both

with and without a testing callback.

• UIProcess/WebsiteData/WebsiteDataStore.h:

Tools:

• TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
• TestWebKitAPI/Tests/WebKit2Cocoa/EmptyGrandfatheredResourceLoadStatistics.plist: Added.
• TestWebKitAPI/Tests/WebKit2Cocoa/ResourceLoadStatistics.mm: Added.

(TEST):

9:42 PM Changeset in webkit [219903] by commit-queue@webkit.org

• 4 edits
  9 moves
  3 adds
  1 delete in trunk/PerformanceTests

Speedometer 2.0: Document es2015-babel-webpack build process
​https://bugs.webkit.org/show_bug.cgi?id=174252

Patch by Mathias Bynens <​mathias@qiwi.be> on 2017-07-25
Reviewed by Ryosuke Niwa.

• Speedometer/resources/todomvc/vanilla-examples/es2015-babel-webpack/README.md: Added build docs.
• Speedometer/resources/todomvc/vanilla-examples/es2015-babel-webpack/dist/*: Update generated build files.
• Speedometer/resources/todomvc/vanilla-examples/es2015-babel-webpack/package.json: Remove unused items.
• Speedometer/resources/todomvc/vanilla-examples/es2015-babel-webpack/package-lock.json: Added lockfile.
• Speedometer/resources/todomvc/vanilla-examples/es2015-babel-webpack/src/index.html: Make title consistent.

9:31 PM Changeset in webkit [219902] by weinig@apple.com

• 7 edits
  1 delete in trunk/Source/WebCore

[WebIDL] Remove custom bindings for HTMLCanvasElement
​https://bugs.webkit.org/show_bug.cgi?id=174847

Reviewed by Darin Adler.

• CMakeLists.txt:
• WebCore.xcodeproj/project.pbxproj:
• bindings/js/JSBindingsAllInOne.cpp:
• bindings/js/JSHTMLCanvasElementCustom.cpp: Removed.

Remove JSHTMLCanvasElementCustom.

• html/HTMLCanvasElement.cpp:

(WebCore::HTMLCanvasElement::getContext):
(WebCore::HTMLCanvasElement::getContext2d):
(WebCore::HTMLCanvasElement::getContextWebGL):
(WebCore::HTMLCanvasElement::getContextWebGPU):

• html/HTMLCanvasElement.h:
• html/HTMLCanvasElement.idl:

Move context picking code to HTMLCanvasElement. Give more
exact types to remaining context getters.

7:34 PM Changeset in webkit [219901] by Chris Dumez

• 20 edits in trunk/Source

Clean up ExceptionCode enumeration
​https://bugs.webkit.org/show_bug.cgi?id=174812

Reviewed by Darin Adler.

Clean up ExceptionCode enumeration:

• Updated comments to reflect the latest WebIDL specification
• Drop special values given to some exception codes. Those legacy codes are already in the table inside DOMException.cpp. This also allows us to drop empty rows in the DOMException table
• Drop NoException value in the enumeration and use std::optional<ExceptionCode> when needed instead.

• Modules/indexeddb/shared/IDBError.cpp:

(WebCore::IDBError::IDBError):
(WebCore::IDBError::name):
(WebCore::IDBError::message):

• Modules/indexeddb/shared/IDBError.h:

(WebCore::IDBError::code):
(WebCore::IDBError::encode):
(WebCore::IDBError::decode):

• dom/DOMException.cpp:
• dom/ExceptionCode.h:
• fileapi/FileReaderSync.cpp:

(WebCore::errorCodeToException):
(WebCore::FileReaderSync::startLoading):

• xml/XMLHttpRequest.cpp:

(WebCore::XMLHttpRequest::createRequest):

• xml/XMLHttpRequest.h:

7:27 PM Changeset in webkit [219900] by commit-queue@webkit.org

• 3 edits in trunk/Source/WebInspectorUI

Web Inspector: Don't output "No message" for multi-value logs like console.log(x, y)
​https://bugs.webkit.org/show_bug.cgi?id=174842

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2017-07-25
Reviewed by Matt Baker.

• Localizations/en.lproj/localizedStrings.js:

Removed "No message".

• UserInterface/Views/ConsoleMessageView.js:

(WebInspector.ConsoleMessageView.prototype._appendFormattedArguments):
Track whether or not outputting the next parameter will need a divider
in front of it or not.

7:23 PM Changeset in webkit [219899] by jfbastien@apple.com

• 6 edits in trunk/Source/JavaScriptCore

WebAssembly: generate smaller binaries
​https://bugs.webkit.org/show_bug.cgi?id=174818

Reviewed by Filip Pizlo.

This patch reduces generated code size for WebAssembly in 2 ways:

1. Use the ZR register when storing zero on ARM64.
2. Synthesize wasm context lazily.

This leads to a modest size reduction on both x86-64 and ARM64 for
large WebAssembly games, without any performance loss on WasmBench
and TitzerBench.

The reason this works is that these games, using Emscripten,
generate 100k+ tiny functions, and our JIT allocation granule
rounds all allocations up to 32 bytes. There are plenty of other
simple gains to be had, I've filed a follow-up bug at
webkit.org/b/174819

We should further avoid the per-function cost of tiering, which
represents the bulk of code generated for small functions.

• assembler/MacroAssemblerARM64.h:

(JSC::MacroAssemblerARM64::storeZero64):

• assembler/MacroAssemblerX86_64.h:

(JSC::MacroAssemblerX86_64::storeZero64):

• b3/B3LowerToAir.cpp:

(JSC::B3::Air::LowerToAir::createStore): this doesn't make sense
for x86 because it constrains register reuse and codegen in a way
that doesn't affect ARM64 because it has a dedicated zero
register.

• b3/air/AirOpcode.opcodes: add the storeZero64 opcode.
• wasm/WasmB3IRGenerator.cpp:

(JSC::Wasm::B3IRGenerator::instanceValue):
(JSC::Wasm::B3IRGenerator::restoreWasmContext):
(JSC::Wasm::B3IRGenerator::B3IRGenerator):
(JSC::Wasm::B3IRGenerator::materializeWasmContext): Deleted.

6:58 PM Changeset in webkit [219898] by fpizlo@apple.com

• 17 edits
  8 adds
  1 delete in trunk/Source

B3 should do LICM
​https://bugs.webkit.org/show_bug.cgi?id=174750

Reviewed by Keith Miller and Saam Barati.

Source/JavaScriptCore:

Added a LICM phase to B3. This phase is called hoistLoopInvariantValues, to conform to the B3 naming
convention for phases (it has to be an imperative). The phase uses NaturalLoops and BackwardsDominators,
so this adds those analyses to B3. BackwardsDominators was already available in templatized form. This
change templatizes DFG::NaturalLoops so that we can just use it.

The LICM phase itself is really simple. We are decently precise with our handling of everything except
the relationship between control dependence and side exits.

Also added a bunch of tests.

This isn't super important. It's perf-neutral on JS benchmarks. FTL already does LICM on DFG SSA IR, and
probably all current WebAssembly content has had LICM done to it. That being said, this is a cheap phase
so it doesn't hurt to have it.

I wrote it because I thought I needed it for bug 174727. It turns out that there's a better way to
handle the problem I had, so I ended up not needed it - but by then I had already written it. I think
it's good to have it because LICM is one of those core compiler phases; every compiler has it
eventually.

• CMakeLists.txt:
• JavaScriptCore.xcodeproj/project.pbxproj:
• b3/B3BackwardsCFG.h: Added.

(JSC::B3::BackwardsCFG::BackwardsCFG):

• b3/B3BackwardsDominators.h: Added.

(JSC::B3::BackwardsDominators::BackwardsDominators):

• b3/B3BasicBlock.cpp:

(JSC::B3::BasicBlock::appendNonTerminal):

• b3/B3Effects.h:
• b3/B3EnsureLoopPreHeaders.cpp: Added.

(JSC::B3::ensureLoopPreHeaders):

• b3/B3EnsureLoopPreHeaders.h: Added.
• b3/B3Generate.cpp:

(JSC::B3::generateToAir):

• b3/B3HoistLoopInvariantValues.cpp: Added.

(JSC::B3::hoistLoopInvariantValues):

• b3/B3HoistLoopInvariantValues.h: Added.
• b3/B3NaturalLoops.h: Added.

(JSC::B3::NaturalLoops::NaturalLoops):

• b3/B3Procedure.cpp:

(JSC::B3::Procedure::invalidateCFG):
(JSC::B3::Procedure::naturalLoops):
(JSC::B3::Procedure::backwardsCFG):
(JSC::B3::Procedure::backwardsDominators):

• b3/B3Procedure.h:
• b3/testb3.cpp:

(JSC::B3::generateLoop):
(JSC::B3::makeArrayForLoops):
(JSC::B3::generateLoopNotBackwardsDominant):
(JSC::B3::oneFunction):
(JSC::B3::noOpFunction):
(JSC::B3::testLICMPure):
(JSC::B3::testLICMPureSideExits):
(JSC::B3::testLICMPureWritesPinned):
(JSC::B3::testLICMPureWrites):
(JSC::B3::testLICMReadsLocalState):
(JSC::B3::testLICMReadsPinned):
(JSC::B3::testLICMReads):
(JSC::B3::testLICMPureNotBackwardsDominant):
(JSC::B3::testLICMPureFoiledByChild):
(JSC::B3::testLICMPureNotBackwardsDominantFoiledByChild):
(JSC::B3::testLICMExitsSideways):
(JSC::B3::testLICMWritesLocalState):
(JSC::B3::testLICMWrites):
(JSC::B3::testLICMFence):
(JSC::B3::testLICMWritesPinned):
(JSC::B3::testLICMControlDependent):
(JSC::B3::testLICMControlDependentNotBackwardsDominant):
(JSC::B3::testLICMControlDependentSideExits):
(JSC::B3::testLICMReadsPinnedWritesPinned):
(JSC::B3::testLICMReadsWritesDifferentHeaps):
(JSC::B3::testLICMReadsWritesOverlappingHeaps):
(JSC::B3::testLICMDefaultCall):
(JSC::B3::run):

• dfg/DFGBasicBlock.h:
• dfg/DFGCFG.h:
• dfg/DFGNaturalLoops.cpp: Removed.
• dfg/DFGNaturalLoops.h:

(JSC::DFG::NaturalLoops::NaturalLoops):
(JSC::DFG::NaturalLoop::NaturalLoop): Deleted.
(JSC::DFG::NaturalLoop::header): Deleted.
(JSC::DFG::NaturalLoop::size): Deleted.
(JSC::DFG::NaturalLoop::at): Deleted.
(JSC::DFG::NaturalLoop::operator[]): Deleted.
(JSC::DFG::NaturalLoop::contains): Deleted.
(JSC::DFG::NaturalLoop::index): Deleted.
(JSC::DFG::NaturalLoop::isOuterMostLoop): Deleted.
(JSC::DFG::NaturalLoop::addBlock): Deleted.
(JSC::DFG::NaturalLoops::numLoops): Deleted.
(JSC::DFG::NaturalLoops::loop): Deleted.
(JSC::DFG::NaturalLoops::headerOf): Deleted.
(JSC::DFG::NaturalLoops::innerMostLoopOf): Deleted.
(JSC::DFG::NaturalLoops::innerMostOuterLoop): Deleted.
(JSC::DFG::NaturalLoops::belongsTo): Deleted.
(JSC::DFG::NaturalLoops::loopDepth): Deleted.

Source/WTF:

Moved DFG::NaturalLoops to WTF. The new templatized NaturalLoops<> uses the same Graph abstraction as
Dominators<>. This allows us to add a B3::NaturalLoops for free.

Also made small tweaks to RangeSet, which the LICM uses.

• WTF.xcodeproj/project.pbxproj:
• wtf/CMakeLists.txt:
• wtf/Dominators.h:
• wtf/NaturalLoops.h: Added.

(WTF::NaturalLoop::NaturalLoop):
(WTF::NaturalLoop::graph):
(WTF::NaturalLoop::header):
(WTF::NaturalLoop::size):
(WTF::NaturalLoop::at):
(WTF::NaturalLoop::operator[]):
(WTF::NaturalLoop::contains):
(WTF::NaturalLoop::index):
(WTF::NaturalLoop::isOuterMostLoop):
(WTF::NaturalLoop::dump):
(WTF::NaturalLoop::addBlock):
(WTF::NaturalLoops::NaturalLoops):
(WTF::NaturalLoops::graph):
(WTF::NaturalLoops::numLoops):
(WTF::NaturalLoops::loop):
(WTF::NaturalLoops::headerOf):
(WTF::NaturalLoops::innerMostLoopOf):
(WTF::NaturalLoops::innerMostOuterLoop):
(WTF::NaturalLoops::belongsTo):
(WTF::NaturalLoops::loopDepth):
(WTF::NaturalLoops::loopsOf):
(WTF::NaturalLoops::dump):

• wtf/RangeSet.h:

(WTF::RangeSet::begin):
(WTF::RangeSet::end):
(WTF::RangeSet::addAll):

6:19 PM Changeset in webkit [219897] by fpizlo@apple.com

• 5 edits in trunk/Source/JavaScriptCore

GC should be fine with trading blocks between destructor and non-destructor blocks
​https://bugs.webkit.org/show_bug.cgi?id=174811

Reviewed by Mark Lam.

Our GC has the ability to trade blocks between MarkedAllocators. A MarkedAllocator is a
size-class-within-a-Subspace. The ability to trade helps reduce memory wastage due to
fragmentation. Prior to this change, this only worked between blocks that did not have destructors.
This was partly a policy decision. But mostly, it was fallout from the way we use the empty block
set.

Here's how empty used to work. If a block is empty, we don't run destructors. We say that a block
is empty if:

A) It has no live objects and its a non-destructor block, or
B) We just allocated it (so it has no destructors even if it's a destructor block), or
C) We just stole it from another allocator (so it also has no destructors), or
D) We just swept the block and ran all destructors.

Case (A) is for trading blocks. That's how a different MarkedAllocator would know that this is a
block that could be stolen.

Cases (B) and (C) need to be detected for correctness, since otherwise we might try to run
destructors in blocks that have garbage bits. In that case, the isZapped check won't detect that
cells don't need destruction, so without having the empty bit we would try to destruct garbage
and crash. Currently, we know that we have cases (B) and (C) when the block is empty.

Case (D) is necessary for detecting which blocks can be removed when we shrink the heap.

If we tried to enable trading of blocks between allocators without making any changes to how
empty works, then it just would not work. We have to set the empty bits of blocks that have no
live objects in order for those bits to be candidates for trading. But if we do that, then our
logic for cases (B-D) will think that the block has no destructible objects. That's bad, since then
our destructors won't run and we'll leak memory.

This change fixes this issue by decoupling the "do I have destructors" question from the "do I have
live objects" question by introducing a new destructible bitvector. The GC flags all live blocks
as being destructible at the end. We clear the destructible bit in cases (B-D). Cases (B-C) are
handled entirely by the new destrictible bit, while case (D) is detected by looking for blocks that
are (empty & ~destructible).

Then we can simply remove all destructor-oriented special-casing of the empty bit. And we can
remove destructor-oriented special-casing of block trading.

This is a perf-neutral change. We expect most free memory to be in non-destructor blocks anyway,
so this change is more about clean-up than perf. But, this could reduce memory usage in some
pathological cases.

• heap/MarkedAllocator.cpp:

(JSC::MarkedAllocator::findEmptyBlockToSteal):
(JSC::MarkedAllocator::tryAllocateWithoutCollecting):
(JSC::MarkedAllocator::endMarking):
(JSC::MarkedAllocator::shrink):
(JSC::MarkedAllocator::shouldStealEmptyBlocksFromOtherAllocators): Deleted.

• heap/MarkedAllocator.h:
• heap/MarkedBlock.cpp:

(JSC::MarkedBlock::Handle::lastChanceToFinalize):
(JSC::MarkedBlock::Handle::sweep):

• heap/MarkedBlockInlines.h:

(JSC::MarkedBlock::Handle::specializedSweep):
(JSC::MarkedBlock::Handle::finishSweepKnowingSubspace):
(JSC::MarkedBlock::Handle::emptyMode):

6:03 PM Changeset in webkit [219896] by aestes@apple.com

• 8 edits in trunk

[Apple Pay] Add "carteBancaire" as a supported payment network
​https://bugs.webkit.org/show_bug.cgi?id=174841
<rdar://problem/31935596>

Reviewed by Alex Christensen.

Source/WebCore:

Tests: http/tests/ssl/applepay/ApplePaySession.html

http/tests/ssl/applepay/ApplePaySessionV3.html

• Modules/applepay/PaymentRequest.cpp:

(WebCore::PaymentRequest::isValidSupportedNetwork):

Source/WebKit:

• UIProcess/ApplePay/cocoa/WebPaymentCoordinatorProxyCocoa.mm:

(WebKit::toSupportedNetwork):

LayoutTests:

• http/tests/ssl/applepay/ApplePaySession-expected.txt:
• http/tests/ssl/applepay/ApplePaySession.html:
• http/tests/ssl/applepay/ApplePaySessionV3.html:

5:45 PM Changeset in webkit [219895] by keith_miller@apple.com

• 2 edits in trunk/Source/JavaScriptCore

Remove Broken CompareEq constant folding phase.
​https://bugs.webkit.org/show_bug.cgi?id=174846
<rdar://problem/32978808>

Reviewed by Saam Barati.

This bug happened when we would get code like the following:

a: JSConst(Undefined)
b: GetLocal(SomeObjectOrUndefined)
...
c: CompareEq(Check:ObjectOrOther:b, Check:ObjectOrOther:a)

constant folding will turn this into:

a: JSConst(Undefined)
b: GetLocal(SomeObjectOrUndefined)
...
c: CompareEq(Check:ObjectOrOther:b, Other:a)

But the SpeculativeJIT/FTL lowering will fail to check b
properly which leads to an assertion failure in the AI.

I'll follow up with a more robust fix later. For now, I'll remove the
case that generates the code. Removing the code appears to be perf
neutral.

• dfg/DFGConstantFoldingPhase.cpp:

(JSC::DFG::ConstantFoldingPhase::foldConstants):

5:45 PM Changeset in webkit [219894] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Fix warnings about console.assert lines without semicolons
​https://bugs.webkit.org/show_bug.cgi?id=174840

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2017-07-25
Reviewed by Brian Burg.

• UserInterface/Views/SettingsTabContentView.js:

(WebInspector.SettingsTabContentView.prototype.set selectedSettingsView):
(WebInspector.SettingsTabContentView.prototype.setSettingsViewVisible):
Add semicolon to assert lines so they can be stripped in optimized builds.

4:31 PM Changeset in webkit [219893] by commit-queue@webkit.org

• 5 edits in trunk/Source/WebInspectorUI

Web Inspector: Inline multiple console log values if they are simple
​https://bugs.webkit.org/show_bug.cgi?id=174746
<rdar://problem/33469376>

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2017-07-25
Reviewed by Matt Baker.

• UserInterface/Models/IssueMessage.js:
• UserInterface/Protocol/RemoteObject.js:

(WebInspector.RemoteObject.type): Deleted.
Remove this as it isn't as useful as directly checking the type.

• UserInterface/Views/ConsoleMessageView.js:

(WebInspector.ConsoleMessageView.prototype._appendExtraParameters):
(WebInspector.ConsoleMessageView.prototype._appendFormattedArguments):
(WebInspector.ConsoleMessageView.prototype._hasSimpleDisplay):
(WebInspector.ConsoleMessageView.prototype._isStackTrace):
For leading primitive/simple values, display them inline on the console message.

• UserInterface/Views/FormattedValue.js:

(WebInspector.FormattedValue.hasSimpleDisplay):
Provide a helper to determine if a formatted value will be simple.

4:06 PM Changeset in webkit [219892] by dbates@webkit.org

• 3 edits in trunk/Source/WebCore

Make StyleResolver::isValid{Cue, Region}StyleProperty() static, inline, non-member functions
​https://bugs.webkit.org/show_bug.cgi?id=174827

Reviewed by Simon Fraser.

StyleResolver::isValid{Cue, Region}StyleProperty() access neither instance nor
class data. Moreover, they are private member functions and hence cannot be
used outside of StyleResolver's implementation. So, make these static, inline,
non-member functions.

• css/StyleResolver.cpp:

(WebCore::isValidRegionStyleProperty):
(WebCore::isValidCueStyleProperty):
(WebCore::StyleResolver::CascadedProperties::addMatch):
(WebCore::StyleResolver::isValidRegionStyleProperty): Deleted.
(WebCore::StyleResolver::isValidCueStyleProperty): Deleted.

• css/StyleResolver.h:

3:48 PM Changeset in webkit [219891] by pvollan@apple.com

• 2 edits in trunk/Source/WebCore

Dragged links are blurry on 1x displays.
​https://bugs.webkit.org/show_bug.cgi?id=174831
<rdar://problem/33519698>

Reviewed by Simon Fraser.

When the width and height of the drag image is a multiple of 2, the drag image is not blurry
on a 1x display. This is a workaround which should be removed when <rdar://problem/33059739>
is fixed.

No new tests, since this is not straightforward to test with a layout test.

• platform/mac/DragImageMac.mm:

(WebCore::LinkImageLayout::LinkImageLayout):

2:49 PM Changeset in webkit [219890] by Matt Lewis

• 2 edits in trunk/LayoutTests

Marked multiple fast/ tests as crashing on High Sierra WK1.
<rdar://problem/33522420>

Unreviewed test gardening.

• platform/mac-highsierra-wk1/TestExpectations:

2:46 PM Changeset in webkit [219889] by Matt Baker

• 9 edits in trunk/Source

Web Inspector: Refactoring: extract async stack trace logic from InspectorInstrumentation
​https://bugs.webkit.org/show_bug.cgi?id=174738

Reviewed by Brian Burg.

Source/JavaScriptCore:

Move AsyncCallType enum to InspectorDebuggerAgent, which manages async
stack traces. This preserves the call type in JSC, makes the range of
possible call types explicit, and is safer than passing ints.

• inspector/agents/InspectorDebuggerAgent.cpp:

(Inspector::InspectorDebuggerAgent::asyncCallIdentifier):
(Inspector::InspectorDebuggerAgent::didScheduleAsyncCall):
(Inspector::InspectorDebuggerAgent::didCancelAsyncCall):
(Inspector::InspectorDebuggerAgent::willDispatchAsyncCall):

• inspector/agents/InspectorDebuggerAgent.h:

Source/WebCore:

Relocate AsyncCallType from InspectorInstrumentation to the debugger
agent. Plumbing for requestAnimationFrame notifications has been added
to PageDebuggerAgent, which is responsible for managing async stack traces.

• dom/ScriptedAnimationController.cpp:

(WebCore::ScriptedAnimationController::registerCallback):
(WebCore::ScriptedAnimationController::cancelCallback):
(WebCore::ScriptedAnimationController::serviceScriptedAnimations):

• inspector/InspectorInstrumentation.cpp:

(WebCore::InspectorInstrumentation::didInstallTimerImpl):
(WebCore::InspectorInstrumentation::didRemoveTimerImpl):
(WebCore::InspectorInstrumentation::willFireTimerImpl):
(WebCore::InspectorInstrumentation::didRequestAnimationFrameImpl):
(WebCore::InspectorInstrumentation::didCancelAnimationFrameImpl):
(WebCore::InspectorInstrumentation::willFireAnimationFrameImpl):
(): Deleted.
(WebCore::didScheduleAsyncCall): Deleted.

• inspector/InspectorInstrumentation.h:

(WebCore::InspectorInstrumentation::didRequestAnimationFrame):
(WebCore::InspectorInstrumentation::didCancelAnimationFrame):
(WebCore::InspectorInstrumentation::willFireAnimationFrame):
Replaced Frame and Document pointers with references and moved
pointer validation upstream.

• inspector/PageDebuggerAgent.cpp:

(WebCore::PageDebuggerAgent::didRequestAnimationFrame):
(WebCore::PageDebuggerAgent::willFireAnimationFrame):
(WebCore::PageDebuggerAgent::didCancelAnimationFrame):

• inspector/PageDebuggerAgent.h:

2:43 PM Changeset in webkit [219888] by Nikita Vasilyev

• 7 edits
  1 copy in trunk/Source/WebInspectorUI

Web Inspector: Styles: Add a switch for Spreadsheet model style editor to experimental settings
​https://bugs.webkit.org/show_bug.cgi?id=174741
<rdar://problem/33467954>

Reviewed by Brian Burg.

Show a blank panel when Spreadsheet Style Editor is enabled.

• UserInterface/Base/Setting.js:
• UserInterface/Main.html:
• UserInterface/Views/CSSStyleDetailsSidebarPanel.js:

(WebInspector.CSSStyleDetailsSidebarPanel):
(WebInspector.CSSStyleDetailsSidebarPanel.prototype.computedStyleDetailsPanelShowProperty):

• UserInterface/Views/RulesStyleSpreadsheetDetailsPanel.js: Added.

(WebInspector.RulesStyleSpreadsheetDetailsPanel):
(WebInspector.RulesStyleSpreadsheetDetailsPanel.prototype.filterDidChange):
(WebInspector.RulesStyleSpreadsheetDetailsPanel.prototype.scrollToSectionAndHighlightProperty):

• UserInterface/Views/SettingsTabContentView.css:

(.content-view.settings > .settings-view > .container.hidden):
(.content-view.settings > .settings-view > .container-centered):
(.content-view.settings > .settings-view > .container button):

• UserInterface/Views/SettingsTabContentView.js:

(WebInspector.SettingsTabContentView.prototype._createDebugSettingsView):

• UserInterface/Views/SettingsView.js:

(WebInspector.SettingsView.prototype.addCenteredContainer):
(WebInspector.SettingsView):
Show "Reload Web Inspector" button when Spreadsheet Style Editor setting is modified.

2:22 PM Changeset in webkit [219887] by BJ Burg

• 5 edits in trunk/Source/WebKit

Use SandboxExtension::HandleArray when sending extensions for file uploads to the web process
​https://bugs.webkit.org/show_bug.cgi?id=174828

Reviewed by Tim Horton.

Send all of the sandbox extension handles in a single message, rather than
one message per extension. Update message name and parameter types to match.

• UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::didChooseFilesForOpenPanelWithDisplayStringAndIcon):
(WebKit::WebPageProxy::didChooseFilesForOpenPanel):

• WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::extendSandboxForFilesFromOpenPanel):
(WebKit::WebPage::extendSandboxForFileFromOpenPanel): Deleted.

• WebProcess/WebPage/WebPage.h:
• WebProcess/WebPage/WebPage.messages.in:

2:12 PM Changeset in webkit [219886] by Matt Lewis

• 2 edits in trunk/LayoutTests

Marked imported/w3c/web-platform-tests/XMLHttpRequest/send-blob-with-no-mime-type.html as failing.
<rdar://problem/33251388>

Unreviewed test gardening.

• platform/mac-highsierra/TestExpectations:

1:56 PM Changeset in webkit [219885] by mark.lam@apple.com

• 5 edits in trunk/Source/JavaScriptCore

Fix bugs in probe code to change sp on x86, x86_64 and 32-bit ARM.
​https://bugs.webkit.org/show_bug.cgi?id=174809
<rdar://problem/33504759>

Reviewed by Filip Pizlo.

1. When the probe handler function changes the sp register to point to the region of stack in the middle of the ProbeContext on the stack, there is a bug where the ProbeContext's register values to be restored can be over-written before they can be restored. This is now fixed.

2. Added more robust probe tests for changing the sp register.

3. Made existing probe tests to ensure that probe handlers were actually called.

4. Added some verification to testProbePreservesGPRS().

5. Change all the probe tests to fail early on discovering an error instead of batching till the end of the test. This helps point a finger to the failing issue earlier.

This patch was tested on x86, x86_64, and ARMv7. ARM64 probe code will be fixed
next in ​https://bugs.webkit.org/show_bug.cgi?id=174697.

• assembler/MacroAssemblerARM.cpp:
• assembler/MacroAssemblerARMv7.cpp:
• assembler/MacroAssemblerX86Common.cpp:
• assembler/testmasm.cpp:

(JSC::testProbeReadsArgumentRegisters):
(JSC::testProbeWritesArgumentRegisters):
(JSC::testProbePreservesGPRS):
(JSC::testProbeModifiesStackPointer):
(JSC::testProbeModifiesStackPointerToInsideProbeContextOnStack):
(JSC::testProbeModifiesStackPointerToNBytesBelowSP):
(JSC::testProbeModifiesProgramCounter):
(JSC::run):

1:55 PM Changeset in webkit [219884] by Matt Lewis

• 2 edits in trunk/LayoutTests

Rebaselinged the test http/tests/quicklook/top-navigation-blocked.html
​https://bugs.webkit.org/show_bug.cgi?id=174755

Unreviewed test gardening.

• http/tests/quicklook/top-navigation-blocked-expected.txt:

1:54 PM Changeset in webkit [219883] by jmarcell@apple.com

• 7 edits in branches/safari-604-branch/Source

Versioning.

1:50 PM Changeset in webkit [219882] by commit-queue@webkit.org

• 2 edits in trunk/Tools

Fix autoinstaller failing on autoinstall_everything
​https://bugs.webkit.org/show_bug.cgi?id=174830

Patch by Matthew Stewart <​matthew_r_stewart@apple.com> on 2017-07-25
Reviewed by Joseph Pecoraro.

• Scripts/webkitpy/thirdparty/init.py:

(AutoinstallImportHook.find_module):
(AutoinstallImportHook.install_chromedriver):
(AutoinstallImportHook.install_geckodriver):
(AutoinstallImportHook._install_chromedriver): Deleted.
(AutoinstallImportHook._install_geckodriver): Deleted.

1:47 PM Changeset in webkit [219881] by achristensen@apple.com

• 2 edits in trunk/Source/WebKit

Fix API tests after r219871.
​https://bugs.webkit.org/show_bug.cgi?id=174807

WebKit2.OpenAndCloseWindowAsync and WebKit2.OpenAsyncWithNil API tests are fixed.

• UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::createNewPage):
createNewPageAsync or createNewPage should be called, not both.

1:45 PM Changeset in webkit [219880] by jmarcell@apple.com

• 1 copy in tags/Safari-604.1.33

Tag Safari-604.1.33.

1:20 PM Changeset in webkit [219879] by jmarcell@apple.com

• 7 edits in branches/safari-604-branch/Source

Versioning.

1:16 PM Changeset in webkit [219878] by jmarcell@apple.com

• 1 delete in tags/Safari-604.1.33

Delete Tag.

11:56 AM Changeset in webkit [219877] by Matt Lewis

• 2 edits in trunk/LayoutTests

Rebaselined missed test.
​https://bugs.webkit.org/show_bug.cgi?id=174734

Unreviewed test gardening.

• fast/events/touch/ios/touches-client-coords-after-zoom-expected.txt:

11:53 AM Changeset in webkit [219876] by commit-queue@webkit.org

• 60 edits
  9 adds in trunk

Async image decoding for large images should be disabled after the first time a tile is painted
​https://bugs.webkit.org/show_bug.cgi?id=174451
<rdar://problem/31246421>

Patch by Said Abou-Hallawa <​sabouhallawa@apple.com> on 2017-07-25
Reviewed by Simon Fraser.

Source/WebCore:

Flashing because of DOM mutation can be fixed by disabling the asynchronous
image decoding after the first time a tile was painted.

We can detect this by consulting the tile repaintCount. If it is zero, then
it is safe to use asynchronous image decoded. If the tile repaintCount is
greater than zero, we are not sure if the renderer rectangle has an image
drawn in it already or not. In this case we have to use the synchronous
image decoding to avoid causing a flash.

Tests: fast/images/async-image-background-change.html

fast/images/async-image-src-change.html
http/tests/multipart/multipart-async-image.html

• html/shadow/MediaControlElements.cpp:

(WebCore::MediaControlTextTrackContainerElement::createTextTrackRepresentationImage):

• page/FrameView.cpp:

(WebCore::FrameView::willPaintContents):
(WebCore::FrameView::paintContentsForSnapshot):

• page/PageOverlayController.cpp:

(WebCore::PageOverlayController::paintContents):

• page/PageOverlayController.h:
• page/linux/ResourceUsageOverlayLinux.cpp:
• page/mac/ServicesOverlayController.h:
• page/mac/ServicesOverlayController.mm:

(WebCore::ServicesOverlayController::Highlight::paintContents):

• platform/graphics/BitmapImage.cpp:

(WebCore::BitmapImage::draw):

• platform/graphics/BitmapImage.h:
• platform/graphics/GraphicsLayer.cpp:

(WebCore::GraphicsLayer::paintGraphicsLayerContents):

• platform/graphics/GraphicsLayer.h:
• platform/graphics/GraphicsLayerClient.h:

(WebCore::GraphicsLayerClient::paintContents):

• platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.cpp:

(WebCore::LayerClient::platformCALayerPaintContents):

• platform/graphics/ca/GraphicsLayerCA.cpp:

(WebCore::GraphicsLayerCA::platformCALayerPaintContents):

• platform/graphics/ca/GraphicsLayerCA.h:
• platform/graphics/ca/PlatformCALayer.h:
• platform/graphics/ca/PlatformCALayerClient.h:

(WebCore::PlatformCALayerClient::platformCALayerRepaintCount):

• platform/graphics/ca/TileCoverageMap.cpp:

(WebCore::TileCoverageMap::platformCALayerPaintContents):

• platform/graphics/ca/TileCoverageMap.h:
• platform/graphics/ca/TileGrid.cpp:

(WebCore::TileGrid::platformCALayerPaintContents):
(WebCore::TileGrid::platformCALayerRepaintCount):

• platform/graphics/ca/TileGrid.h:
• platform/graphics/ca/cocoa/PlatformCALayerCocoa.mm:

(PlatformCALayer::drawLayerContents):

• platform/graphics/ca/win/PlatformCALayerWin.cpp:

(PlatformCALayer::drawLayerContents):

• platform/graphics/ca/win/PlatformCALayerWinInternal.cpp:

(PlatformCALayerWinInternal::displayCallback):

• platform/graphics/ca/win/WebTiledBackingLayerWin.cpp:

(WebTiledBackingLayerWin::displayCallback):

• platform/graphics/mac/WebLayer.mm:

(-[WebLayer drawInContext:]):
(-[WebSimpleLayer drawInContext:]):

• rendering/PaintPhase.h:
• rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::decodingModeForImageDraw):

• rendering/RenderElement.h:
• rendering/RenderLayer.cpp:

(WebCore::RenderLayer::paintLayerContents):
(WebCore::RenderLayer::paintForegroundForFragments):

• rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::paintContents):

• rendering/RenderLayerBacking.h:
• rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::paintContents):

• rendering/RenderLayerCompositor.h:
• rendering/RenderWidget.cpp:

(WebCore::RenderWidget::paintContents):

• testing/Internals.cpp:

(WebCore::imageFromImageElement):
(WebCore::bitmapImageFromImageElement):
(WebCore::Internals::imageFrameIndex):
(WebCore::Internals::setImageFrameDecodingDuration):
(WebCore::Internals::resetImageAnimation):
(WebCore::Internals::isImageAnimating):
(WebCore::Internals::setClearDecoderAfterAsyncFrameRequestForTesting):
(WebCore::Internals::imageDecodeCount):
(WebCore::Internals::setLargeImageAsyncDecodingEnabledForTesting):

• testing/Internals.h:
• testing/Internals.idl:

Source/WebKit:

• Shared/mac/RemoteLayerBackingStore.mm:

(WebKit::RemoteLayerBackingStore::drawInContext):

• WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.cpp:

(WebKit::imageForRect):

• WebProcess/InjectedBundle/DOM/InjectedBundleRangeHandle.cpp:

(WebKit::InjectedBundleRangeHandle::renderedImage):

• WebProcess/WebPage/CoordinatedGraphics/CompositingCoordinator.cpp:

(WebKit::CompositingCoordinator::paintContents):

• WebProcess/WebPage/CoordinatedGraphics/CompositingCoordinator.h:

Source/WebKitLegacy/mac:

• WebView/WebFrame.mm:

(-[WebFrame _paintBehaviorForDestinationContext:]):
(-[WebFrame _drawRect:contentsOnly:]):

• WebView/WebHTMLView.mm:

(imageFromRect):

Source/WebKitLegacy/win:

• FullscreenVideoController.cpp:

(FullscreenVideoController::LayerClient::platformCALayerPaintContents):

• WebCoreSupport/AcceleratedCompositingContext.cpp:

(AcceleratedCompositingContext::paintContents):

• WebCoreSupport/AcceleratedCompositingContext.h:

LayoutTests:

To test async image decoding for large images, we have to create the <img>
element dynamically so we can listen to the load and webkitImageFrameReady
events and know reliably when to end the test. But with this patch the async
image decoding for large images will be disabled after the first paint.
That means async image decoding for large images will be disabled always
unless we force the async image decoding till the image is painted for the
first time. We use Internals::setLargeImageAsyncDecodingEnabledForTesting()
to force the async image decoding. So painting an image in this case will
require multiple paints; in all of them the async image decoding will be
enabled. But this is okay because it resembles the case where the <img> is
created from a static <img> tag in the HTML file.

For new tests, where we want to make sure that mutating the DOM will not
cause a flash, async image decoding will be forced till the image is drawn
for the first time. After that the async image decoding is enabled but not
forced.

Disable new tests for WK1 because the async image decoding is always enabled
because tiling does not necessarily exist in WK1 . But eventually the async
image decoding for large images will be always disabled for WK1.

• fast/images/async-image-background-change-expected.html: Added.
• fast/images/async-image-background-change.html: Added.
• fast/images/async-image-background-image-repeated.html:
• fast/images/async-image-background-image.html:
• fast/images/async-image-body-background-image.html:
• fast/images/async-image-multiple-clients-repaint.html:
• fast/images/async-image-src-change-expected.html: Added.
• fast/images/async-image-src-change.html: Added.
• fast/images/resources/green-400x400.png: Added.
• fast/images/resources/red-100x100.png: Added.
• fast/images/resources/red-400x400.png: Added.
• fast/images/sprite-sheet-image-draw.html:
• http/tests/multipart/multipart-async-image-expected.txt: Added.
• http/tests/multipart/multipart-async-image.html: Added.
• platform/ios-wk1/TestExpectations:
• platform/mac-wk1/TestExpectations:

11:28 AM Changeset in webkit [219875] by Jonathan Bedard

• 7 edits in trunk/Tools

Replace --runtime with something for both ios-simulator and ios-device
​https://bugs.webkit.org/show_bug.cgi?id=173775
<rdar://problem/32952164>

Reviewed by Aakash Jain.

Add --version flag for both iOS simulator and iOS device.

• Scripts/webkitpy/layout_tests/run_webkit_tests.py:

(parse_args): Add --version flag and move --no-install.

• Scripts/webkitpy/port/factory.py:

(platform_options): Move --no-intall to run_webkit_tests.py.

• Scripts/webkitpy/port/ios.py:

(IOSPort):
(IOSPort._is_valid_ios_version): Check that the provided version string is legal.
(IOSPort.get_option): If accessing the iOS version, check that it is a valid version string.

• Scripts/webkitpy/port/ios_device.py:

(IOSDevicePort.ios_version): Consult --version flag before checking connected
devices for iOS version.

• Scripts/webkitpy/port/ios_device_unittest.py:

(IOSDeviceTest.make_port): Set --version option so that we can generate test
expectation paths without devices connected.
(IOSDeviceTest.test_additional_platform_directory): Deleted.
(IOSDeviceTest.test_baseline_searchpath): Deleted.
(IOSDeviceTest.test_expectations_ordering): Deleted.

• Scripts/webkitpy/port/ios_simulator.py:

(IOSSimulatorPort.simulator_runtime): If no runtime is specified, use the --version
flag to specify a runtime.
(IOSSimulatorPort.ios_version): First check the --version flag, then the --runtime
flag and then use the default runtime.

11:03 AM Changeset in webkit [219874] by BJ Burg

• 31 edits in trunk/Source

Web Automation: add support for uploading files
​https://bugs.webkit.org/show_bug.cgi?id=174797
<rdar://problem/28485063>

Reviewed by Joseph Pecoraro.

Source/JavaScriptCore:

• inspector/scripts/generate-inspector-protocol-bindings.py:

(generate_from_specification):
Start generating frontend dispatcher code if the target framework is 'WebKit'.

• inspector/scripts/codegen/generate_cpp_frontend_dispatcher_implementation.py:

(CppFrontendDispatcherImplementationGenerator.generate_output):
Use a framework include for InspectorFrontendRouter.h since this generated code
will be compiled outside of WebCore.framework.

• inspector/scripts/tests/all/expected/definitions-with-mac-platform.json-result:
• inspector/scripts/tests/generic/expected/commands-with-async-attribute.json-result:
• inspector/scripts/tests/generic/expected/commands-with-optional-call-return-parameters.json-result:
• inspector/scripts/tests/generic/expected/definitions-with-mac-platform.json-result:
• inspector/scripts/tests/generic/expected/domain-availability.json-result:
• inspector/scripts/tests/generic/expected/domains-with-varying-command-sizes.json-result:
• inspector/scripts/tests/generic/expected/enum-values.json-result:
• inspector/scripts/tests/generic/expected/events-with-optional-parameters.json-result:
• inspector/scripts/tests/generic/expected/generate-domains-with-feature-guards.json-result:
• inspector/scripts/tests/generic/expected/same-type-id-different-domain.json-result:
• inspector/scripts/tests/generic/expected/shadowed-optional-type-setters.json-result:
• inspector/scripts/tests/generic/expected/type-declaration-aliased-primitive-type.json-result:
• inspector/scripts/tests/generic/expected/type-declaration-array-type.json-result:
• inspector/scripts/tests/generic/expected/type-declaration-enum-type.json-result:
• inspector/scripts/tests/generic/expected/type-declaration-object-type.json-result:
• inspector/scripts/tests/generic/expected/type-requiring-runtime-casts.json-result:
• inspector/scripts/tests/generic/expected/type-with-open-parameters.json-result:
• inspector/scripts/tests/generic/expected/worker-supported-domains.json-result:
• inspector/scripts/tests/ios/expected/definitions-with-mac-platform.json-result:
• inspector/scripts/tests/mac/expected/definitions-with-mac-platform.json-result:

Rebaseline code generator tests.

Source/WebKit:

The general strategy is to have automation clients set the list of files they want
to select ahead of time. Then, the client simulates a click on the <input type="file"> element.
When that causes WebPageProxy to ask the UI delegate to runOpenPanel, it instead
gives WebAutomationSession a chance to select files if the page is under control of
automation. WebAutomationSession validates its file list and selects the files if valid.

• CMakeLists.txt: Add frontend dispatcher files.
• DerivedSources.make:

Add frontend dispatcher code generator scripts as dependencies of the generated code.
Add generated frontend dispatcher files to the list of output files.

• UIProcess/Automation/Automation.json:

Add a command to set the canned list of files that should be selected when prompted.
If no files are selected, then the effect is as if the user had clicked "cancel" in
the file chooser dialog.

Add an event to signal to the WebDriver service that the file selection request has
been either fulfilled or cancelled. This event is necessary because otherwise remotes
cannot distinguish whether selecting the files failed for some reason, or if the
UIProcess has not yet selected the files and sent them to the web content process.
In either case, the input element's "files" attribute would return an empty FileList.

• UIProcess/Automation/WebAutomationSession.h:
• UIProcess/Automation/WebAutomationSession.cpp:

(WebKit::WebAutomationSession::WebAutomationSession):
Add the frontend dispatcher for Automation domain. This is named m_domainNotifier since
m_domainDispatcher is already being used for the backend command dispatcher.

(WebKit::WebAutomationSession::handleRunOpenPanel):
Validate that the files-to-select list has valid entries and select the files if so.
If anything goes wrong, pretend to cancel out of the file chooser. Either way, notify the
frontend with an event that the file chooser was dismissed due to selecting files or cancelling.
Automation protocol clients may implement additional strategies to further restrict
the conditions upon which local files can be uploaded.

(WebKit::WebAutomationSession::setFilesToSelectForFileUpload): Added.
Store the list of files as a vector of strings. The file list is always replaced.

• UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::runOpenPanel):
If the page is under automation, delegating the runOpenPanel is likely to hang
because WebDriver cannot interact directly with the file chooser dialog. Instead,
give WebAutomationSession a chance to select files and don't tell the delegate.

• WebKit.xcodeproj/project.pbxproj:

Add frontend dispatcher files to "Derived Sources" group.

11:02 AM Changeset in webkit [219873] by weinig@apple.com

• 20 edits
  1 add in trunk/Source/WebCore

[WebIDL] Add support for generating timer bindings
​https://bugs.webkit.org/show_bug.cgi?id=174766

Reviewed by Darin Adler.

Adds a new non-standard type, ScheduledAction, which stands in for the
standard (DOMString or Function). It would be good to move to that in
future, but for now, this allows for forward momentum on removing custom
bindings.

• WebCore.xcodeproj/project.pbxproj:

Add JSDOMConvertScheduledAction.h.

• bindings/IDLTypes.h:

Add IDLScheduledAction.

• bindings/js/JSDOMConvertScheduledAction.h: Added.

(WebCore::Converter<IDLScheduledAction>::convert):
Add conversion from JSValue -> ScheduledAction. This is moved from the old ScheduledAction
create function.

• bindings/js/JSDOMConvertVariadic.h:

(WebCore::convertVariadicArguments):
(WebCore::Detail::VariadicConverterBase::convert): Deleted.
(WebCore::Detail::VariadicConverterBase<IDLInterface<T>>::convert): Deleted.

• bindings/js/JSDOMConvertBase.h:
• bindings/js/JSDOMConvertAny.h:

(WebCore::VariadicConverter<IDLAny>::convert):

• bindings/js/JSDOMConvertInterface.h:

(WebCore::VariadicConverter<IDLInterface<T>>::convert):
Rename VariadicConverter to VariadicConverterDetails, and remove base class. Rename
VariadicConverterBase to VariadicConverter, and move specializations to the file
containing the base converter for that IDL type

• bindings/js/JSDOMWindowCustom.cpp:

(WebCore::JSDOMWindow::setTimeout): Deleted.
(WebCore::JSDOMWindow::setInterval): Deleted.

• bindings/js/JSWorkerGlobalScopeCustom.cpp:

(WebCore::JSWorkerGlobalScope::setTimeout): Deleted.
(WebCore::JSWorkerGlobalScope::setInterval): Deleted.
Remove custom implementations of setTimeout and setInterval.

• bindings/js/ScheduledAction.cpp:

(WebCore::ScheduledAction::create):
(WebCore::ScheduledAction::ScheduledAction):
(WebCore::ScheduledAction::~ScheduledAction):
(WebCore::ScheduledAction::addArguments):
(WebCore::ScheduledAction::executeFunctionInContext):

• bindings/js/ScheduledAction.h:

(WebCore::ScheduledAction::ScheduledAction): Deleted.
Rework ScheduledAction. Now has two create functions, one for the function
form, one for the string form. These are now called by the Converter. Also,
rather than extracting the arguments directly from the ExecState, allow the
bindings to work as designed, and have the arguments come in as variadic
arguments to setTimeout/setInterval and get added to the ScheduledAction if
needed. Also, move ContentSecurityPolicy check out of construction, and into
setTimeout/setInterval.

• bindings/scripts/CodeGenerator.pm:

(IsBuiltinType):
Add ScheduledAction to the builtin list.

• bindings/scripts/CodeGeneratorJS.pm:

(AddToIncludesForIDLType):
Add the correct include when ScheduledAction is used.

(GenerateParametersCheck):
Remove rule disallowing optional arguments before variadic arguments. That works
just fine.

(GetBaseIDLType):
Add mapping of ScheduledAction -> IDLScheduledAction.

(JSValueToNativeDOMConvertNeedsGlobalObject):
Add ScheduledAction to the list of types that need a global object
for conversion.

• page/WindowOrWorkerGlobalScope.idl:

Update interface to match spec and add FIXMEs for moving to TimerHandler.

• page/DOMWindow.cpp:

(WebCore::DOMWindow::setTimeout):
(WebCore::DOMWindow::setInterval):

• page/DOMWindow.h:
• workers/WorkerGlobalScope.cpp:

(WebCore::WorkerGlobalScope::setTimeout):
(WebCore::WorkerGlobalScope::setInterval):

• workers/WorkerGlobalScope.h:

Update for new signatures. WorkerGlobalScope now has to return ExceptionOr<int>
even though it never throws, due to having one IDL file defining these. This is
unfortunate and something we should look at addressing the future.

10:42 AM Changeset in webkit [219872] by commit-queue@webkit.org

• 2 edits in trunk/LayoutTests

[GTK] Unreviewed test gardening
​https://bugs.webkit.org/show_bug.cgi?id=174820

Unreviewed gardening.

Patch by Charlie Turner <​cturner@igalia.com> on 2017-07-25

• platform/gtk/TestExpectations:

10:17 AM Changeset in webkit [219871] by achristensen@apple.com

• 22 edits in trunk/Source/WebKit

Modernize NavigationAction code
​https://bugs.webkit.org/show_bug.cgi?id=174807

Reviewed by Darin Adler.

Mostly just use more move semantics.

• Platform/IPC/HandleMessage.h:

(IPC::callMemberFunctionImpl):

• Shared/API/APIURLRequest.h:
• Shared/NavigationActionData.h:
• UIProcess/API/APINavigation.cpp:

(API::Navigation::Navigation):

• UIProcess/API/APINavigation.h:

(API::Navigation::create):

• UIProcess/API/APINavigationAction.h:
• UIProcess/API/APINavigationClient.h:

(API::NavigationClient::decidePolicyForNavigationAction):

• UIProcess/API/APIPolicyClient.h:
• UIProcess/API/APIUIClient.h:

(API::UIClient::createNewPage):
(API::UIClient::createNewPageAsync):
(API::UIClient::canCreateNewPageAsync):

• UIProcess/API/C/WKPage.cpp:

(WKPageLoadURLRequest):
(WKPageLoadURLRequestWithUserData):
(WKPageSetPageUIClient):
(WKPageSetPageNavigationClient):

• UIProcess/Cocoa/NavigationState.h:
• UIProcess/Cocoa/NavigationState.mm:

(WebKit::NavigationState::NavigationClient::decidePolicyForNavigationAction):

• UIProcess/Cocoa/UIDelegate.h:
• UIProcess/Cocoa/UIDelegate.mm:

(WebKit::UIDelegate::UIClient::createNewPageCommon):
(WebKit::UIDelegate::UIClient::createNewPage):
(WebKit::UIDelegate::UIClient::canCreateNewPageAsync):
(WebKit::UIDelegate::UIClient::createNewPageAsync):

• UIProcess/WebInspectorProxy.cpp:

(WebKit::decidePolicyForNavigationAction):

• UIProcess/WebNavigationState.cpp:

(WebKit::WebNavigationState::createLoadRequestNavigation):

• UIProcess/WebNavigationState.h:
• UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::loadRequest):
(WebKit::WebPageProxy::decidePolicyForNavigationAction):
(WebKit::WebPageProxy::decidePolicyForNewWindowAction):
(WebKit::WebPageProxy::createNewPage):

• UIProcess/WebPageProxy.h:

10:07 AM Changeset in webkit [219870] by Devin Rousso

• 11 edits in trunk

Web Inspector: add context menu item for taking a screenshot of a node
​https://bugs.webkit.org/show_bug.cgi?id=174754

Reviewed by Brian Burg.

Source/WebInspectorUI:

• Localizations/en.lproj/localizedStrings.js:
• UserInterface/Views/ContextMenuUtilities.js:

(WebInspector.appendContextMenuItemsForDOMNode):
Add "Capture Element Screenshot " context menu item that opens a save dialog with a picture of the node.

• UserInterface/Base/Main.js:

(WebInspector.saveDataToFile):
Allow the saveData to specify whether the contained content is base64Encoded, instead of
having to go through a Blob to save base64 data.

• UserInterface/Base/Utilities.js:

Add Number.pad to add leading zeros up to a certain width.

Drive-by: fix failing test for Number.constrain.

• UserInterface/Models/DOMNode.js:

(WebInspector.DOMNode.prototype.scrollIntoView.resolvedNode.scrollIntoView): Added.
(WebInspector.DOMNode.prototype.scrollIntoView.resolvedNode): Added.
(WebInspector.DOMNode.prototype.scrollIntoView): Added.

• UserInterface/Views/DOMTreeElement.js:

(WebInspector.DOMTreeElement.prototype._populateNodeContextMenu):
(WebInspector.DOMTreeElement.prototype._scrollIntoView.resolvedNode.scrollIntoView): Deleted.
(WebInspector.DOMTreeElement.prototype._scrollIntoView.resolvedNode): Deleted.
(WebInspector.DOMTreeElement.prototype._scrollIntoView): Deleted.

• UserInterface/Views/DOMTreeOutline.js:

(WebInspector.DOMTreeOutline.prototype.populateContextMenu):
Drive-by: move "Scroll Into View" context menu command to WebInspector.appendContextMenuItemsForDOMNode
so that it can be triggered from more places than just the DOM tree.

LayoutTests:

• inspector/unit-tests/number-utilities-expected.txt:
• inspector/unit-tests/number-utilities.html:

Add test for Number.zeroPad.

Drive-by: Change tests to use expectEqual for better output on failure.

9:49 AM Changeset in webkit [219869] by commit-queue@webkit.org

• 16 edits in trunk/Source/WebCore

[WinCairo] Fix build with AllInOnes disabled
​https://bugs.webkit.org/show_bug.cgi?id=174784
<rdar://problem/33488914>

Patch by Yoshiaki Jitsukawa <​Yoshiaki.Jitsukawa@sony.com> on 2017-07-25
Reviewed by Alex Christensen.

• PlatformWin.cmake:

Add RenderThemeWin.cpp to WebCore_SOURCES

• rendering/RenderingAllInOne.cpp:

Remove #include "RenderThemeWin.cpp"

• testing/MemoryInfo.h:

Remove #include "JSDomWindow.h"

• bindings/js/JSDOMGlobalObject.cpp:
• bindings/js/JSDOMPromiseDeferred.cpp:
• bindings/js/JSDOMWrapper.cpp:
• bindings/js/JSImageDataCustom.cpp:
• bindings/scripts/CodeGeneratorJS.pm:

(GenerateCallWith):

• dom/ScriptExecutionContext.cpp:
• inspector/InspectorController.cpp:
• inspector/InspectorTimelineAgent.cpp:
• rendering/RenderMediaControls.cpp:
• rendering/RenderMediaControls.h:
• rendering/RenderThemeWin.cpp:

• bindings/scripts/test/JS/JSTestObj.cpp:

Update test results.

6:22 AM Changeset in webkit [219868] by Claudio Saavedra

• 2 edits
  1 add in trunk/LayoutTests

REGRESSION (r143068): fast/events/clientXY-in-zoom-and-scroll.html failing on GTK, Qt
​https://bugs.webkit.org/show_bug.cgi?id=110090

Unreviewed gardening.

This test only needed the expectation to be updated.

• platform/gtk/TestExpectations: Remove test below.
• platform/gtk/fast/events/clientXY-in-zoom-and-scroll-expected.txt: Added.

4:43 AM Changeset in webkit [219867] by Konstantin Tokarev

• 2 edits in trunk/Source/WebCore

Unreviewed, fix Mac CMake build after r219567

• PlatformMac.cmake:

4:38 AM Changeset in webkit [219866] by Carlos Garcia Campos

• 2 edits in trunk/Source/WebKit

REGRESSION(r218629): [GTK] ASSERTION FAILED: m_eglDisplay == EGL_NO_DISPLAY in WebCore::PlatformDisplay::~PlatformDisplay
​https://bugs.webkit.org/show_bug.cgi?id=174789

Reviewed by Žan Doberšek.

Before r218629, the wayland nested compositor display was a singleton created on demand by
AcceleratedSurfaceWayland, but now it's created unconditionally on web process creation when a valid display
name is received from the UI process. The side effect of this is that now the shared display is created after
the nested compositor display that is not a singleton anymore. The atexit used by PlatformDisplay to shutdown
egl display assumes that it will be registered by the shared display. Since we switched to on demand AC mode,
the shared display is only used in the web process when entering AC mode, that's why it only crashes when we
have entered AC at least once. We just need to ensure that the shared display is created before the nested
compositor display.

• WebProcess/gtk/WaylandCompositorDisplay.cpp:

(WebKit::WaylandCompositorDisplay::create): Check we are under wayland before creating the WaylandCompositorDisplay.

4:36 AM Changeset in webkit [219865] by Carlos Garcia Campos

• 4 edits in trunk/Tools

[GTK] TestWebKitAPI tests are no longer built since the WebKit2 rename
​https://bugs.webkit.org/show_bug.cgi?id=174815

Reviewed by Carlos Alberto Lopez Perez.

Only WebKitGTK specific tests are built, but not WebKit2, WTF nor WebCore ones. We are still checking
ENABLE_WEBKIT2 in the makefile, that was renamed to ENABLE_WEBKIT. Also, all WebKit2 test paths were updated to
use WebKit dir, while the tests are still in WebKit2 directory. This patch also removes
TestWebKitAPIInjectedBundle_PATH that is unused and now makes the configure to fail (it used to be a warning, I
think), probably because of a newer CMake version.

• CMakeLists.txt:
• TestWebKitAPI/CMakeLists.txt:
• TestWebKitAPI/PlatformGTK.cmake:

4:29 AM WebKitGTK/KeepingTheTreeGreen edited by clopez@igalia.com

(diff)

4:28 AM WebKitGTK/KeepingTheTreeGreen edited by clopez@igalia.com

(diff)

4:25 AM WebKitGTK/KeepingTheTreeGreen edited by clopez@igalia.com

(diff)

3:22 AM Changeset in webkit [219864] by Carlos Garcia Campos

• 2 edits in trunk

Unreviewed. Fix GTK+ WebKit2 library soname after r219488.

The WebKit2 -> WebKit rename shouldn't affect the GTK+ library that is still called libwebkit2gtk, so keep using
WEBKIT2 as the library name in CALCULATE_LIBRARY_VERSIONS_FROM_LIBTOOL_TRIPLE, since that's also what the WebKit
makefile passes to WEBKIT_POPULATE_LIBRARY_VERSION.

• Source/cmake/OptionsGTK.cmake: