⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Jul 29, 2017:

8:01 PM Changeset in webkit [220047] by keith_miller@apple.com
  • 11 edits in trunk/Source/JavaScriptCore

LLInt offsets extractor should be able to handle C++ constexprs
​https://bugs.webkit.org/show_bug.cgi?id=174964

Reviewed by Saam Barati.

This patch adds new syntax to the offline asm language. The new keyword,
constexpr, takes the subsequent identifier and maps it to a C++ constexpr
expression. Additionally, if the value is not an identifier you can wrap it in
parentheses. e.g. constexpr (myConstexprFunction() + OBJECT_OFFSET(Foo, bar)),
which will get converted into:
static_cast<int64_t>(myConstexprFunction() + OBJECT_OFFSET(Foo, bar));

This patch also changes the data format the LLIntOffsetsExtractor
binary produces. Previously, it would produce unsigned values,
after this patch every value is an int64_t. Using an int64_t is
useful because it means that we can represent any constant needed.
int32_t masks are sign extended then passed then converted to a
negative literal sting in the assembler so it will be the constant
expected.

  • llint/LLIntOffsetsExtractor.cpp:

(JSC::LLIntOffsetsExtractor::dummy):

  • llint/LowLevelInterpreter.asm:
  • llint/LowLevelInterpreter64.asm:
  • offlineasm/asm.rb:
  • offlineasm/ast.rb:
  • offlineasm/generate_offset_extractor.rb:
  • offlineasm/offsets.rb:
  • offlineasm/parser.rb:
  • offlineasm/transform.rb:
12:51 PM Changeset in webkit [220046] by Yusuke Suzuki
  • 7 edits in trunk

Unreviewed, build fix for GTK and WPE about StorageProcess renaming

.:

  • Source/cmake/OptionsWPE.cmake:

Source/WebKit:

  • CMakeLists.txt:
  • PlatformGTK.cmake:
  • PlatformMac.cmake:
  • PlatformWPE.cmake:
12:36 PM Changeset in webkit [220045] by fpizlo@apple.com
  • 6 edits in trunk/Source/WebCore

Unreviewed, rollout r220044 because it set the bots on fire.

It seems that the "-Wunguarded-availability-new" pragma is not widely supported. So, a bunch of the
Mac bots are now unable to build and that includes EWS.

Fixing by rolling it out.

  • platform/graphics/avfoundation/objc/CDMSessionMediaSourceAVFObjC.h:
  • platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.h:
  • platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:

(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::setHasAvailableAudioSample):
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::addAudioRenderer):
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::removeAudioRenderer):

  • platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.h:
  • platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm:

(-[WebAVSampleBufferErrorListener beginObservingRenderer:]):
(-[WebAVSampleBufferErrorListener stopObservingRenderer:]):
(-[WebAVSampleBufferErrorListener observeValueForKeyPath:ofObject:change:context:]):
(WebCore::SourceBufferPrivateAVFObjC::trackDidChangeEnabled):
(WebCore::SourceBufferPrivateAVFObjC::rendererDidReceiveError):
(WebCore::SourceBufferPrivateAVFObjC::flush):

9:25 AM Changeset in webkit [220044] by mitz@apple.com
  • 6 edits in trunk/Source/WebCore

Fixed building for macOS 10.12 with the macOS 10.13 SDK.

Suppressed the unguarded-availability-new warning around uses of AVSampleBufferAudioRenderer
and AVSampleBufferRenderSynchronizer. Even though the 10.13 SDK declares them as available
starting in that release, they have been available as SPI earlier.

  • platform/graphics/avfoundation/objc/CDMSessionMediaSourceAVFObjC.h:
  • platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.h:
  • platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:

(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::setHasAvailableAudioSample):
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::addAudioRenderer):
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::removeAudioRenderer):

  • platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.h:
  • platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm:

(-[WebAVSampleBufferErrorListener beginObservingRenderer:]):
(-[WebAVSampleBufferErrorListener stopObservingRenderer:]):
(-[WebAVSampleBufferErrorListener observeValueForKeyPath:ofObject:change:context:]):
(WebCore::SourceBufferPrivateAVFObjC::trackDidChangeEnabled):
(WebCore::SourceBufferPrivateAVFObjC::rendererDidReceiveError):
(WebCore::SourceBufferPrivateAVFObjC::flush):

4:40 AM UsingGitWithWebKit edited by Adrian Perez de Castro
Add note about how to fetch branches using git-svn (diff)
4:38 AM Changeset in webkit [220043] by commit-queue@webkit.org
  • 2 edits
    1 add in trunk/PerformanceTests

Speedometer 2.0: Document vanilla/es2015 build process
​https://bugs.webkit.org/show_bug.cgi?id=174894

Patch by Mathias Bynens <​mathias@chromium.org> on 2017-07-29
Reviewed by Ryosuke Niwa.

  • Speedometer/resources/todomvc/vanilla-examples/es2015/README.md: Added.
  • Speedometer/resources/todomvc/vanilla-examples/es2015/index.html: Made title consistent.
3:27 AM Changeset in webkit [220042] by n_wang@apple.com
  • 3 edits
    2 adds in trunk

AX: findMatchingObjects doesn't work when the startObject is ignored
​https://bugs.webkit.org/show_bug.cgi?id=174965

Reviewed by Chris Fleizach.

Source/WebCore:

findMatchingObjects would return a wrong element if we pass in an ignored
start object. To fix this, we should use the closest accessible sibling as
the start object.

Test: accessibility/mac/search-predicate-from-ignored-element.html

  • accessibility/AccessibilityObject.cpp:

(WebCore::appendChildrenToArray):

LayoutTests:

  • accessibility/mac/search-predicate-from-ignored-element-expected.txt: Added.
  • accessibility/mac/search-predicate-from-ignored-element.html: Added.
3:00 AM Changeset in webkit [220041] by commit-queue@webkit.org
  • 6 edits
    2 adds in trunk

AX: FKA: Buttons need a visible focus indicator
​https://bugs.webkit.org/show_bug.cgi?id=171040
<rdar://problem/30922548>

Patch by Aaron Chu <​aaron_chu@apple.com> on 2017-07-29
Reviewed by Antoine Quint.

Source/WebCore:

Added a background color for the focus state of the icon buttons in modern media controls.

Test: media/modern-media-controls/button/button-focus-state.html

  • Modules/modern-media-controls/controls/button.css:

(button:focus):
(button:focus > picture):

  • Modules/modern-media-controls/controls/slider.css:

(.slider > input):

LayoutTests:

  • media/modern-media-controls/button/button-focus-state-expected.txt: Added.
  • media/modern-media-controls/button/button-focus-state.html: Added.
  • platform/ios-simulator/TestExpectations:
  • platform/mac-elcapitan/TestExpectations:

Jul 28, 2017:

7:39 PM Changeset in webkit [220040] by Brent Fulgham
  • 2 edits in trunk/Source/WebKit

[Mac][WebKit2] WebKit sandbox errors while streaming Netflix
​https://bugs.webkit.org/show_bug.cgi?id=174955
<rdar://problem/33583994>

Reviewed by Alex Christensen.

Wider testing with the stricter sandboxing rules identified three more IOKit properties we need to expose:

  • CEAModeID
  • CEAPixelRepetition
  • IOFBHDMIDongleROM
  • WebProcess/com.apple.WebProcess.sb.in:
7:35 PM Changeset in webkit [220039] by commit-queue@webkit.org
  • 14 edits
    1 delete in trunk

[WebIDL] Remove JS builtin bindings for FetchHeaders
​https://bugs.webkit.org/show_bug.cgi?id=174905

Patch by Sam Weinig <​sam@webkit.org> on 2017-07-28
Reviewed by Alex Christensen.

LayoutTests/imported/w3c:

  • web-platform-tests/fetch/api/headers/headers-basic-expected.txt:
  • web-platform-tests/fetch/api/headers/headers-record-expected.txt:

Update results for more passing tests.

Source/WebCore:

  • CMakeLists.txt:
  • DerivedSources.make:
  • WebCore.xcodeproj/project.pbxproj:
  • Modules/fetch/FetchHeaders.js: Removed.

Remove FetchHeaders.js

  • Modules/fetch/FetchHeaders.cpp:

(WebCore::appendToHeaderMap):
(WebCore::FetchHeaders::create):
(WebCore::FetchHeaders::append):

  • Modules/fetch/FetchHeaders.h:

(WebCore::FetchHeaders::FetchHeaders):
Add create function for generated constructor.
Add appendToHeaderMap static function which takes the functionality
from the existing append function, and makes it useable in create.

  • Modules/fetch/FetchHeaders.idl:

Replace [JSBuiltinConstructor] with real constructor. Keep other builtin
attributes as they are still used by other Fetch code.

  • bindings/js/JSDOMConvertRecord.h:

Fix record conversion to work with proxies by changing to use the method table
for getOwnPropertyNames, and undefined values by not excluding undefined values.

LayoutTests:

  • fetch/header-constructor-is-array-expected.txt:
  • fetch/header-constructor-is-array.html:

Update test to match spec. An array with out a prototype will not yield
a valid Header as it is not iterable.

5:57 PM Changeset in webkit [220038] by commit-queue@webkit.org
  • 22 edits
    24 copies
    3 moves
    12 adds
    4 deletes in trunk

Unreviewed, rolling out r219986.
​https://bugs.webkit.org/show_bug.cgi?id=174962

"broke PLT on iOS (rdar://problem/33602751)" (Requested by
estes on #webkit).

Reverted changeset:

"Part 1 of: Rename DatabaseProcess to StorageProcess."
​https://bugs.webkit.org/show_bug.cgi?id=174879
​http://trac.webkit.org/changeset/219986

5:52 PM Changeset in webkit [220037] by commit-queue@webkit.org
  • 52 edits in trunk

Unreviewed, rolling out r219990.
​https://bugs.webkit.org/show_bug.cgi?id=174961

"broke PLT on iOS (rdar://problem/33602751)" (Requested by
estes on #webkit).

Reverted changeset:

"Part 2 of: Rename DatabaseProcess to StorageProcess."
​https://bugs.webkit.org/show_bug.cgi?id=174880
​http://trac.webkit.org/changeset/219990

5:33 PM Changeset in webkit [220036] by Matt Baker
  • 12 edits in trunk

Web Inspector: capture an async stack trace when web content calls addEventListener
​https://bugs.webkit.org/show_bug.cgi?id=174739
<rdar://problem/33468197>

Reviewed by Brian Burg.

Source/JavaScriptCore:

Allow debugger agents to perform custom logic when asynchronous stack
trace data is cleared. For example, the PageDebuggerAgent would clear
its list of registered listeners for which call stacks have been recorded.

  • inspector/agents/InspectorDebuggerAgent.cpp:

(Inspector::InspectorDebuggerAgent::clearAsyncStackTraceData):

  • inspector/agents/InspectorDebuggerAgent.h:

Source/WebCore:

Test: inspector/debugger/async-stack-trace.html

Add instrumentation to EventTarget to support showing asynchronous
stack traces when the debugger breaks in a script event listener.

  • dom/EventTarget.cpp:

(WebCore::EventTarget::addEventListener):
(WebCore::EventTarget::removeEventListener):
(WebCore::EventTarget::fireEventListeners):

  • inspector/InspectorInstrumentation.cpp:

(WebCore::InspectorInstrumentation::didAddEventListenerImpl):
(WebCore::InspectorInstrumentation::willRemoveEventListenerImpl):
(WebCore::InspectorInstrumentation::willHandleEventImpl):
(WebCore::InspectorInstrumentation::didHandleEventImpl):

  • inspector/InspectorInstrumentation.h:

(WebCore::InspectorInstrumentation::didAddEventListener):
(WebCore::InspectorInstrumentation::willRemoveEventListener):
(WebCore::InspectorInstrumentation::willHandleEvent):
(WebCore::InspectorInstrumentation::didHandleEvent):

  • inspector/PageDebuggerAgent.cpp:

(WebCore::PageDebuggerAgent::didClearAsyncStackTraceData):
(WebCore::PageDebuggerAgent::didAddEventListener):
(WebCore::PageDebuggerAgent::willRemoveEventListener):
(WebCore::PageDebuggerAgent::willHandleEvent):

  • inspector/PageDebuggerAgent.h:

LayoutTests:

Add test case checking that async stack traces are recorded for addEventListener.

  • inspector/debugger/async-stack-trace-expected.txt:
  • inspector/debugger/async-stack-trace.html:
5:25 PM Changeset in webkit [220035] by mrajca@apple.com
  • 4 edits
    2 adds in trunk

Don't add autoplay restrictions to media elements created in response to user gestures.
​https://bugs.webkit.org/show_bug.cgi?id=174947

Reviewed by Eric Carlson.

Source/WebCore:

Test: media/video-create-with-user-gesture.html

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::HTMLMediaElement):

LayoutTests:

Skip the test on iOS because "runWithKeyDown" does not work there.

Jer: "Turns out the problem with iOS is that the WKTR EventSender is basically unwritten. It
doesn't support sending mouse, key, or touch events, so our "do this during a user gesture"
helper in video-test.js doesn't work."

  • media/video-create-with-user-gesture-expected.txt: Added.
  • media/video-create-with-user-gesture.html: Added.
  • platform/ios/TestExpectations:
4:21 PM Changeset in webkit [220034] by pvollan@apple.com
  • 2 edits in trunk/LayoutTests

The test imported/w3c/web-platform-tests/fetch/api/basic/accept-header.any.html is slow on Windows.

Unreviewed test gardening, mark test as slow.

  • platform/win/TestExpectations:
4:19 PM Changeset in webkit [220033] by beidson@apple.com
  • 5 edits in trunk

API tests that use URLSchemeHandler are failing.
​https://bugs.webkit.org/show_bug.cgi?id=174950

Reviewed by Alex Christensen.

Source/WebKit:

Make sure that in all cases where we remove the last task from the page->task map...
...We also remove the map itself.

  • UIProcess/WebURLSchemeHandler.cpp:

(WebKit::WebURLSchemeHandler::stopTask):
(WebKit::WebURLSchemeHandler::taskCompleted):
(WebKit::WebURLSchemeHandler::removeTaskFromPageMap):

  • UIProcess/WebURLSchemeHandler.h:

Tools:

Fix the NoMIMEType test to be correct.

  • TestWebKitAPI/Tests/WebKit2Cocoa/WKURLSchemeHandler-1.mm:

(-[SchemeHandler initWithData:mimeType:]):
(-[SchemeHandler webView:startURLSchemeTask:]):
(TEST):

3:31 PM Changeset in webkit [220032] by dbates@webkit.org
  • 2 edits in trunk/Tools

prepare-ChangeLog should not list added layout tests in PAL ChangeLog
​https://bugs.webkit.org/show_bug.cgi?id=174876

Reviewed by Alex Christensen.

Do not list added layout tests in the PAL ChangeLog as such tests are unlikely to be related
to a PAL change. Unit tests are more appropriate for PAL changes than layout tests because
they provide a more direct way to test the platform abstraction.

As a side effect of this change we no longer list added layout tests in WebCore/platform/gtk/po/ChangeLog.

  • Scripts/prepare-ChangeLog:

(generateNewChangeLogs): Only list added layout tests in the WebCore ChangeLog regardless
of the current working directory.

3:21 PM Changeset in webkit [220031] by Matt Lewis
  • 2 edits in trunk/LayoutTests

Unreviewed, rolling out r220016.

Test needs to be unskipped due to configuration change in High
Sierra.

Reverted changeset:

"Marked fast/images/pdf-as-image-with-annotations.html as
image failure."
​http://trac.webkit.org/changeset/220016

3:20 PM Changeset in webkit [220030] by jmarcell@apple.com
  • 13 edits
    2 adds in branches/safari-604-branch

Cherry-pick r219904. rdar://problem/33595576

3:20 PM Changeset in webkit [220029] by jmarcell@apple.com
  • 4 edits
    2 adds in branches/safari-604-branch

Cherry-pick r220003. rdar://problem/33595572

3:20 PM Changeset in webkit [220028] by jmarcell@apple.com
  • 3 edits in branches/safari-604-branch/Source/WebCore

Cherry-pick r219998. rdar://problem/33595610

3:20 PM Changeset in webkit [220027] by jmarcell@apple.com
  • 3 edits in branches/safari-604-branch/Source/WebCore

Cherry-pick r219992. rdar://problem/33595621

3:19 PM Changeset in webkit [220026] by jmarcell@apple.com
  • 2 edits in branches/safari-604-branch/Source/WebCore

Cherry-pick r219991. rdar://problem/33595570

3:19 PM Changeset in webkit [220025] by jmarcell@apple.com
  • 2 edits in branches/safari-604-branch/Source/WebKit

Cherry-pick r219987. rdar://problem/33595619

3:19 PM Changeset in webkit [220024] by jmarcell@apple.com
  • 2 edits in branches/safari-604-branch/Source/WebKit

Cherry-pick r219973. rdar://problem/33595608

3:19 PM Changeset in webkit [220023] by jmarcell@apple.com
  • 8 edits
    2 adds in branches/safari-604-branch

Cherry-pick r219950. rdar://problem/33595459

3:19 PM Changeset in webkit [220022] by jmarcell@apple.com
  • 5 edits in branches/safari-604-branch

Cherry-pick r219949. rdar://problem/33595616

3:19 PM Changeset in webkit [220021] by jmarcell@apple.com
  • 11 edits in branches/safari-604-branch

Cherry-pick r219906. rdar://problem/33595387

3:19 PM Changeset in webkit [220020] by jmarcell@apple.com
  • 2 edits in branches/safari-604-branch/Source/JavaScriptCore

Cherry-pick r219895. rdar://problem/33595450

3:19 PM Changeset in webkit [220019] by jmarcell@apple.com
  • 2 edits in branches/safari-604-branch/Source/WebCore

Cherry-pick r219891. rdar://problem/33595436

3:19 PM Changeset in webkit [220018] by jmarcell@apple.com
  • 3 edits in branches/safari-604-branch/Source/WebKit

Cherry-pick r219855. rdar://problem/33595427

3:04 PM Changeset in webkit [220017] by Jonathan Bedard
  • 2 edits in trunk/Tools

Using "auto <function()> -> returnType" breaks prepare-ChangeLog
​https://bugs.webkit.org/show_bug.cgi?id=174930

Unreviewed test fix.

We need to check parentheses before printing 'const' or 'volatile' in the ChangeLog.

  • Scripts/prepare-ChangeLog:

(get_function_line_ranges_for_cpp):

2:58 PM Changeset in webkit [220016] by Matt Lewis
  • 2 edits in trunk/LayoutTests

Marked fast/images/pdf-as-image-with-annotations.html as image failure.
<rdar://problem/33550614>

Unreviewed test gardening.

  • platform/mac-highsierra/TestExpectations:
2:09 PM Changeset in webkit [220015] by Matt Lewis
  • 2 edits in trunk/LayoutTests

Marked multiple iimported/w3c/web-platform-tests/WebCryptoAPI/derive_bits_keys/ as failing.
<rdar://problem/33548297>

Unreviewed test gardening.

  • platform/mac-highsierra/TestExpectations:
2:08 PM Changeset in webkit [220014] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

WebMediaSessionHelper calls -[UIApplication beginReceivingRemoteControlEvents] from WebThread
​https://bugs.webkit.org/show_bug.cgi?id=174934
rdar://problem/33586772

Patch by Jeremy Jones <​jeremyj@apple.com> on 2017-07-28
Reviewed by Eric Carlson.

No new tests because no effect on DOM.

This dispatches a UIKit call to the main thread since it might happen on WebThread in WK1.

  • platform/audio/ios/MediaSessionManagerIOS.mm:

(-[WebMediaSessionHelper initWithCallback:]):

1:49 PM Changeset in webkit [220013] by Matt Lewis
  • 3 edits in trunk/LayoutTests

Marked imported/w3c/IndexedDB-private-browsing/idbfactory_open12.html as flaky.
<rdar://problem/33555052>

Unreviewed test gardening.

  • platform/ios-wk2/TestExpectations:
  • platform/mac-highsierra/TestExpectations:
1:29 PM Changeset in webkit [220012] by mark.lam@apple.com
  • 4 edits
    1 add in trunk

ObjectToStringAdaptiveStructureWatchpoint should not fire if it's dying imminently.
​https://bugs.webkit.org/show_bug.cgi?id=174948
<rdar://problem/33495680>

Reviewed by Filip Pizlo.

JSTests:

  • stress/regress-174948.js: Added.

Source/JavaScriptCore:

ObjectToStringAdaptiveStructureWatchpoint is owned by StructureRareData. If its
owner StructureRareData is already known to be dead (in terms of GC liveness) but
hasn't been destructed yet (i.e. not swept by the GC yet), we should ignore all
requests to fire this watchpoint.

If the GC had the chance to sweep the StructureRareData, thereby destructing the
ObjectToStringAdaptiveStructureWatchpoint, it (the watchpoint) would have removed
itself from the WatchpointSet it was on. Hence, it would not have been fired.

But since the watchpoint hasn't been destructed yet, it still remains on the
WatchpointSet and needs to guard against being fired in this state. The fix is
to simply return early if its owner StructureRareData is not live. This has the
effect of the watchpoint fire being a no-op, which is equivalent to the watchpoint
not firing as we would expect.

This patch also removes some cargo cult copying of watchpoint code which
instantiates a StringFireDetail. In a few cases, that StringFireDetail is never
used. This patch removes these unnecessary instantiations.

  • bytecode/LLIntPrototypeLoadAdaptiveStructureWatchpoint.cpp:

(JSC::LLIntPrototypeLoadAdaptiveStructureWatchpoint::fireInternal):

  • runtime/StructureRareData.cpp:

(JSC::ObjectToStringAdaptiveStructureWatchpoint::fireInternal):
(JSC::ObjectToStringAdaptiveInferredPropertyValueWatchpoint::handleFire):

1:03 PM Changeset in webkit [220011] by beidson@apple.com
  • 15 edits in trunk/Source/WebKit

WKURLSchemeTaskImpl instances are being abandoned (except if the task is stopped).
<rdar://problem/33568276> and ​https://bugs.webkit.org/show_bug.cgi?id=174895

Reviewed by Alex Christensen.

There was a lot going on here:

  • There was an unbroken cycle between URLSchemeHandlers and URLSchemeTasks
  • WKURLSchemeTasks were not destroying their API::URLSchemeTask implementation object
  • When a WKWebView was dealloc'ed, it was not cleaning up the related UIProcess tasks
  • If the NetworkingProcess crashed, WebProcesses were not cleaning up their tasks (and therefore the UIProcess tasks were also not getting cleaned up)
  • If a WebProcess crashed, the UIProcess was not cleaning up the related tasks
  • UIProcess/API/Cocoa/WKURLSchemeTask.mm:

(-[WKURLSchemeTaskImpl dealloc]): Call API::~URLSchemeTask

  • UIProcess/Cocoa/WebURLSchemeHandlerCocoa.h:
  • UIProcess/Cocoa/WebURLSchemeHandlerCocoa.mm:

(WebKit::WebURLSchemeHandlerCocoa::platformTaskCompleted): Clear out the API wrapper map

so the wrapper and implementation object can both be destroyed.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::close): Call stopAllURLSchemeTasks.
(WebKit::WebPageProxy::processDidTerminate): Call stopAllURLSchemeTasks.
(WebKit::WebPageProxy::stopAllURLSchemeTasks):

  • UIProcess/WebPageProxy.h:
  • UIProcess/WebURLSchemeHandler.cpp:

(WebKit::WebURLSchemeHandler::startTask):
(WebKit::WebURLSchemeHandler::stopAllTasksForPage):
(WebKit::WebURLSchemeHandler::stopTask):
(WebKit::WebURLSchemeHandler::taskCompleted):

  • UIProcess/WebURLSchemeHandler.h:
  • UIProcess/WebURLSchemeTask.cpp:

(WebKit::WebURLSchemeTask::WebURLSchemeTask):

  • UIProcess/WebURLSchemeTask.h:

(WebKit::WebURLSchemeTask::pageID): Store separate from the WebPage so messaging

is possible even after the WebPage* has been cleared.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::stopAllURLSchemeTasks):

  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebPage/WebURLSchemeHandlerProxy.cpp:

(WebKit::WebURLSchemeHandlerProxy::stopAllTasks):
(WebKit::WebURLSchemeHandlerProxy::taskDidComplete):
(WebKit::WebURLSchemeHandlerProxy::taskDidStopLoading):
(WebKit::WebURLSchemeHandlerProxy::removeTask):

  • WebProcess/WebPage/WebURLSchemeHandlerProxy.h:
  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::networkProcessConnectionClosed): Call stopAllURLSchemeTasks

for each WebPage.

11:54 AM Changeset in webkit [220010] by jfbastien@apple.com
  • 4 edits in trunk/Tools

Using "auto <function()> -> returnType" breaks prepare-ChangeLog
​https://bugs.webkit.org/show_bug.cgi?id=174930

Reviewed by Daniel Bates.

Teach prepare-ChangeLog about C++ auto arrow return, and while I'm
here also teach it about const and volatile overloads. I didn't do
reference and rvalue reference overloads because we don't really
use them, and the current parser throws away those characters and
it doesn't seem worth making it more complex.

  • Scripts/prepare-ChangeLog:

(get_function_line_ranges_for_cpp):

  • Scripts/webkitperl/prepare-ChangeLog_unittest/resources/cpp_unittests-expected.txt:
  • Scripts/webkitperl/prepare-ChangeLog_unittest/resources/cpp_unittests.cpp:

(Foo::Arrow::arrow):
(Foo::Arrow::otherArrow):
(Foo::Arrow::otherArrow const):
(Foo::Arrow::otherArrow volatile):
(Foo::Arrow::otherArrow const volatile):

11:36 AM Changeset in webkit [220009] by mmaxfield@apple.com
  • 7 edits
    4 adds in trunk

[macOS] Reeder's defaults font is Times instead of San Francisco
​https://bugs.webkit.org/show_bug.cgi?id=174885
<rdar://problem/33462483>

Reviewed by Simon Fraser.

Source/WebCore:

Reeder uses explicit dot-prefixed names in its source code. Within Core Text,
dot-prefixed names cannot be matched case insensitively. The solution is to
not case-fold these family names, and to make our caches case sensitive for
these special names.

Tests: fast/text/font-lookup-dot-prefix-case-sensitive-2.html

fast/text/font-lookup-dot-prefix-case-sensitive.html

  • platform/graphics/FontCache.cpp:

(WebCore::FontPlatformDataCacheKey::operator==):
(WebCore::FontPlatformDataCacheKeyHash::hash):

  • platform/graphics/FontCascade.cpp:

(WebCore::keysMatch):
(WebCore::computeFontCascadeCacheHash):

  • platform/graphics/FontDescription.cpp:

(WebCore::FontCascadeDescription::familyNamesAreEqual):
(WebCore::FontCascadeDescription::familyNameHash):
(WebCore::FontCascadeDescription::foldedFamilyName):

  • platform/graphics/FontDescription.h:
  • platform/graphics/cocoa/FontCacheCoreText.cpp:

(WebCore::FontDatabase::fontForPostScriptName):

LayoutTests:

  • fast/text/font-lookup-dot-prefix-case-sensitive-2-expected.html: Added.
  • fast/text/font-lookup-dot-prefix-case-sensitive-2.html: Added.
  • fast/text/font-lookup-dot-prefix-case-sensitive-expected-mismatch.html: Added.
  • fast/text/font-lookup-dot-prefix-case-sensitive.html: Added.
11:22 AM Changeset in webkit [220008] by Devin Rousso
  • 18 edits
    4 adds in trunk

Web Inspector: Record actions performed on CanvasRenderingContext2D
​https://bugs.webkit.org/show_bug.cgi?id=174482

Reviewed by Joseph Pecoraro.

Source/WebCore:

Tests: inspector/canvas/recording-2d.html

inspector/canvas/recording.html

  • html/canvas/CanvasRenderingContext2D.idl:

Add CallTracingCallback to interface to record all API calls.

  • html/HTMLCanvasElement.cpp:

(WebCore::HTMLCanvasElement::paint):
If a recording is active, mark the current frame as completed.

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateAttributeGetterBodyDefinition):
(GenerateAttributeSetterBodyDefinition):
(GenerateImplementationFunctionCall):
(GenerateCallTracerParameter):
(GenerateCallTracer):

  • bindings/scripts/test/TestCallTracer.idl:
  • bindings/scripts/test/JS/JSTestCallTracer.cpp:

(WebCore::setJSTestCallTracerTestAttributeInterfaceSetter):
(WebCore::setJSTestCallTracerTestAttributeSpecifiedSetter):
(WebCore::jsTestCallTracerTestAttributeWithVariantGetter):
(WebCore::jsTestCallTracerTestAttributeWithVariant):
(WebCore::setJSTestCallTracerTestAttributeWithVariantSetter):
(WebCore::setJSTestCallTracerTestAttributeWithVariant):
(WebCore::jsTestCallTracerPrototypeFunctionTestOperationInterfaceBody):
(WebCore::jsTestCallTracerPrototypeFunctionTestOperationSpecifiedBody):
(WebCore::jsTestCallTracerPrototypeFunctionTestOperationWithArgumentsBody):
(WebCore::jsTestCallTracerPrototypeFunctionTestOperationWithNullableArgumentBody):
(WebCore::jsTestCallTracerPrototypeFunctionTestOperationWithVariantArgumentBody):
(WebCore::jsTestCallTracerPrototypeFunctionTestOperationWithVariantArgument):

  • inspector/InspectorCanvas.h:
  • inspector/InspectorCanvas.cpp:

(WebCore::InspectorCanvas::recordAction):
(WebCore::InspectorCanvas::buildAction):
Change CallTracer IDL generation to flatten any variants so that all types for the
parameters of an action are able to be listed in a single variant. This prevents possible
ambiguity when constructing the variant, as they require that exactly one type be
constructible and a sub-variant might not satisfy that condition. This was only an issue for
older mac SDKs.

  • bindings/js/CallTracer.h:
  • bindings/js/CallTracer.cpp:

(WebCore::CallTracer::recordCanvasAction):

  • bindings/js/CallTracerTypes.h:
  • inspector/InspectorCanvasAgent.h:
  • inspector/InspectorCanvasAgent.cpp:

(WebCore::InspectorCanvasAgent::recordCanvasAction):

  • inspector/InspectorInstrumentation.h:
  • inspector/InspectorInstrumentation.cpp:

(WebCore::InspectorInstrumentation::recordCanvasAction):
(WebCore::InspectorInstrumentation::recordCanvasActionImpl):
Rename CanvasActionParameterVariant to RecordCanvasActionVariant to match what is expected by
the IDL generator. Also remove unnecessary includes now that they are in CallTracerTypes.h.

  • CMakeLists.txt:
  • bindings/js/JSBindingsAllInOne.cpp:

Add CallTracer for CMake builds.

LayoutTests:

  • inspector/canvas/recording-2d-expected.txt: Added.
  • inspector/canvas/recording-2d.html: Added.
  • inspector/canvas/recording-expected.txt: Added.
  • inspector/canvas/recording.html: Added.

Take a recording of all CanvasRenderingContext2D actions and dump the recorded JSON data.

11:06 AM Changeset in webkit [220007] by Adrian Perez de Castro
  • 4 edits in trunk

[GTK] Building with ENABLE_VIDEO=OFF fails
​https://bugs.webkit.org/show_bug.cgi?id=174940

Reviewed by Alex Christensen.

.:

Code guarded by ENABLE(MEDIA_STREAM) requires the definition of HTMLVideoElement to
be available, which in turn is guarded by ENABLE(VIDEO).

  • Source/cmake/WebKitFeatures.cmake: Make ENABLE_MEDIA_STREAM depend on ENABLE_VIDEO.

Tools:

When GStreamer usage is completely disabled at build time, CMake does not query pkg-config for the GStreamer.
This adds missing USE(GSTREAMER) guards in order to make testing code buildable when GStreamer usage is disabled.

  • TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:

(methodCallCallback): Add missing USE(GSTREAMER) guard.

10:29 AM Changeset in webkit [220006] by commit-queue@webkit.org
  • 14 edits
    12 adds in trunk/Source/WebCore

[WebIDL] Split-up and cleanup Fetch IDL files in preparation for removing unnecessary js builtins
​https://bugs.webkit.org/show_bug.cgi?id=174915

Patch by Sam Weinig <​sam@webkit.org> on 2017-07-28
Reviewed by Alex Christensen.

  • Split FetchRequest enums and Init dictionary out of FetchRequest so they can be used from other files like WorkerGlobalScopeFetch and DOMWindowFetch.
  • Add missing FetchResponseInit. Currently unused but will be in a subsequent patch.
  • Add and update comments about missing properties and functions.
  • CMakeLists.txt:
  • DerivedSources.make:
  • WebCore.xcodeproj/project.pbxproj:
  • Modules/fetch/DOMWindowFetch.idl:
  • Modules/fetch/FetchBody.idl:
  • Modules/fetch/FetchBodyOwner.h:
  • Modules/fetch/FetchHeaders.h:
  • Modules/fetch/FetchHeaders.idl:
  • Modules/fetch/FetchReferrerPolicy.h: Added.
  • Modules/fetch/FetchReferrerPolicy.idl: Added.
  • Modules/fetch/FetchRequest.h:
  • Modules/fetch/FetchRequest.idl:
  • Modules/fetch/FetchRequestCache.h: Added.
  • Modules/fetch/FetchRequestCache.idl: Added.
  • Modules/fetch/FetchRequestCredentials.h: Added.
  • Modules/fetch/FetchRequestCredentials.idl: Added.
  • Modules/fetch/FetchRequestInit.h: Added.
  • Modules/fetch/FetchRequestInit.idl: Added.
  • Modules/fetch/FetchRequestMode.h: Added.
  • Modules/fetch/FetchRequestMode.idl: Added.
  • Modules/fetch/FetchRequestRedirect.h: Added.
  • Modules/fetch/FetchRequestRedirect.idl: Added.
  • Modules/fetch/FetchResponse.h:
  • Modules/fetch/FetchResponse.idl:
  • Modules/fetch/WorkerGlobalScopeFetch.idl:
10:28 AM Changeset in webkit [220005] by pvollan@apple.com
  • 2 edits in trunk/LayoutTests

The test imported/w3c/web-platform-tests/cors/allow-headers.htm is slow on Windows.

Unreviewed test gardening, mark test as slow.

  • platform/win/TestExpectations:
10:27 AM Changeset in webkit [220004] by Devin Rousso
  • 28 edits in trunk/Source/WebInspectorUI

Web Inspector: Cleanup unused/invalid parameters for TreeElements
​https://bugs.webkit.org/show_bug.cgi?id=173987

Reviewed by Brian Burg.

  • UserInterface/Views/TreeElement.js:
  • UserInterface/Views/GeneralTreeElement.js:
  • UserInterface/Views/ApplicationCacheFrameTreeElement.js:
  • UserInterface/Views/BreakpointTreeElement.js:
  • UserInterface/Views/CSSStyleSheetTreeElement.js:
  • UserInterface/Views/CallFrameTreeElement.js:
  • UserInterface/Views/ContentFlowTreeElement.js:
  • UserInterface/Views/DOMNodeTreeElement.js:
  • UserInterface/Views/DatabaseTableTreeElement.js:
  • UserInterface/Views/DatabaseTreeElement.js:
  • UserInterface/Views/FolderTreeElement.js:
  • UserInterface/Views/FolderizedTreeElement.js:
  • UserInterface/Views/FrameTreeElement.js:
  • UserInterface/Views/IndexedDatabaseObjectStoreIndexTreeElement.js:
  • UserInterface/Views/IndexedDatabaseObjectStoreTreeElement.js:
  • UserInterface/Views/IndexedDatabaseTreeElement.js:
  • UserInterface/Views/IssueTreeElement.js:
  • UserInterface/Views/ObjectTreeBaseTreeElement.js:
  • UserInterface/Views/ProfileNodeTreeElement.js:
  • UserInterface/Views/ResourceTreeElement.js:
  • UserInterface/Views/ScriptTreeElement.js:
  • UserInterface/Views/SearchResultTreeElement.js:
  • UserInterface/Views/SourceCodeTreeElement.js:
  • UserInterface/Views/SourceMapResourceTreeElement.js:
  • UserInterface/Views/StorageTreeElement.js:
  • UserInterface/Views/TimelineRecordTreeElement.js:
  • UserInterface/Views/TypeTreeElement.js:
10:06 AM Changeset in webkit [220003] by mmaxfield@apple.com
  • 4 edits
    2 adds in trunk

REGRESSION(r216944): Fallback fonts erroneously visible when the primary font is loading
​https://bugs.webkit.org/show_bug.cgi?id=174772
<rdar://problem/33267643>

Reviewed by Simon Fraser.

Source/WebCore:

During a font load, we try pretty hard to find a font to use that isn't the
last resort font (which happens to be Times). We do this by iterating through
all the fonts in the font-family list, as well as through all the relevant
@font-face blocks which share the requested font family name.

Unfortunately, if we find one of these fallback fonts, we were simply using it
directly, which means that it was being drawn as visible (because the
visibility setting lives inside the Font object). Instead, we should carry the
invisibility setting from the interstitial font to this used fallback font.

This patch is an extension of r219221, which fixed the problem only for system
fallback fonts. This patch adopts the same methodology to all fallback fonts.

Test: http/tests/webfont/font-loading-system-fallback-visibility-FontRanges.html

  • platform/graphics/FontCascadeFonts.cpp:

(WebCore::FontCascadeFonts::glyphDataForVariant):
(WebCore::glyphPageFromFontRanges):

  • platform/graphics/FontRanges.cpp:

(WebCore::FontRanges::glyphDataForCharacter):

LayoutTests:

  • http/tests/webfont/font-loading-system-fallback-visibility-FontRanges-expected.html: Added.
  • http/tests/webfont/font-loading-system-fallback-visibility-FontRanges.html: Added.
9:52 AM Changeset in webkit [220002] by pvollan@apple.com
  • 2 edits in trunk/LayoutTests

REGRESSION(r125147): Layout Test svg/dom/SVGScriptElement/script-change-externalResourcesRequired-while-loading.svg is failing
​https://bugs.webkit.org/show_bug.cgi?id=93589

Unreviewed test gardening, this test is also a flaky timeout on Windows.

  • platform/win/TestExpectations:
8:38 AM Changeset in webkit [220001] by fred.wang@free.fr
  • 6 edits in trunk/Source

Fix typo in scrollPositionChangedViaDelegatedScrolling
​https://bugs.webkit.org/show_bug.cgi?id=174937

Patch by Frederic Wang <​fwang@igalia.cpm> on 2017-07-28
Reviewed by Wenson Hsieh.

Source/WebCore:

No new tests, fix typo in the inUserInteraction parameter.

  • page/scrolling/ScrollingTree.cpp:

(WebCore::ScrollingTree::scrollPositionChangedViaDelegatedScrolling):

  • page/scrolling/ScrollingTree.h:

Source/WebKit:

  • UIProcess/Scrolling/ios/ScrollingTreeOverflowScrollingNodeIOS.h:
  • UIProcess/Scrolling/ios/ScrollingTreeOverflowScrollingNodeIOS.mm:

(WebKit::ScrollingTreeOverflowScrollingNodeIOS::scrollViewDidScroll):

3:27 AM Changeset in webkit [220000] by Claudio Saavedra
  • 10 edits
    3 adds in trunk

[WPE] Implement EventSenderProxy in WTR
​https://bugs.webkit.org/show_bug.cgi?id=173419

Reviewed by Žan Doberšek.

Add the implementation of EventSenderProxy to the WTR. This
allows us to extend the coverage of the test suite in WKWPE.

.:

  • Source/cmake/FindLibxkbcommon.cmake: Added.

Tools:

  • WebKitTestRunner/EventSenderProxy.h:
  • WebKitTestRunner/PlatformWPE.cmake: Add dependency on

libxkbcommon needed to deal with key events.

  • WebKitTestRunner/wpe/EventSenderProxyWPE.cpp:

(WTR::EventSenderProxy::EventSenderProxy):
(WTR::senderButtonToWPEButton):
(WTR::EventSenderProxy::mouseDown):
(WTR::EventSenderProxy::mouseUp):
(WTR::EventSenderProxy::mouseMoveTo):
(WTR::EventSenderProxy::mouseScrollBy):
(WTR::EventSenderProxy::mouseScrollByWithWheelAndMomentumPhases):
(WTR::EventSenderProxy::leapForward):
(WTR::wkEventModifiersToWPE):
(WTR::getXKBKeySymForKeyRef):
(WTR::EventSenderProxy::keyDown):
(WTR::EventSenderProxy::addTouchPoint):
(WTR::EventSenderProxy::updateTouchPoint):
(WTR::EventSenderProxy::setTouchModifier):
(WTR::EventSenderProxy::setTouchPointRadius):
(WTR::EventSenderProxy::getUpdatedTouchEvents):
(WTR::EventSenderProxy::removeUpdatedTouchEvents):
(WTR::EventSenderProxy::prepareAndDispatchTouchEvent):
(WTR::EventSenderProxy::touchStart):
(WTR::EventSenderProxy::touchMove):
(WTR::EventSenderProxy::touchEnd):
(WTR::EventSenderProxy::touchCancel):
(WTR::EventSenderProxy::clearTouchPoints):
(WTR::EventSenderProxy::releaseTouchPoint):
(WTR::EventSenderProxy::cancelTouchPoint):

LayoutTests:

  • platform/wpe/TestExpectations: Unskip fast/events tests, marking failures

that are related to features not yet implemented in WPE. Also remove other
tests that are now passing thanks to having event injection.

  • platform/wpe/fast/dom/HTMLTableColElement/resize-table-using-col-width-expected.txt: Update.
  • platform/wpe/fast/dynamic/layer-hit-test-crash-expected.txt: Update.
  • platform/wpe/fast/events/clientXY-in-zoom-and-scroll-expected.txt: Added.
  • platform/wpe/ietestcenter/css3/bordersbackgrounds/background-attachment-local-scrolling-expected.txt: Update.
12:53 AM Changeset in webkit [219999] by zandobersek@gmail.com
  • 2 edits in trunk

Unreviewed. Bumping the patch version for WPEWebKit library to 20170728.

  • Source/cmake/OptionsWPE.cmake:
12:31 AM Changeset in webkit [219998] by Wenson Hsieh
  • 3 edits in trunk/Source/WebCore

[iOS DnD] [WK1] Snapshots generated using -[DOMRange renderImageForcingBlackText:] are upside down
​https://bugs.webkit.org/show_bug.cgi?id=174928
<rdar://problem/33584280>

Reviewed by Tim Horton.

Pulls the implementation of createDragImageForRange out into DragImageIOS, and use TextIndicator to generate a
snapshot instead of FrameSelection's snapshotting utilities. This makes snapshotting a DOMRange behave the same
way as snapshotting a dragged selection.

No way of testing TextIndicator-based snapshotting yet.

  • platform/DragImage.cpp:

Guard createDragImageForRange for !PLATFORM(IOS).

  • platform/ios/DragImageIOS.mm:

(WebCore::createDragImageForSelection):

Add a FIXME to point out that having an additional context flip inside the UIGraphicsImageRenderer block results
in an upside-down drag image being returned from createDragImageFromImage. This image is being flipped elsewhere
in drag initiation code, which eventually results in the correct orientation; we'll need further investigation
to remove this extraneous flip.

(WebCore::createDragImageForRange):

12:25 AM Changeset in webkit [219997] by Yusuke Suzuki
  • 3 edits
    1 add in trunk
ASSERTION FAILED: candidate->op() == PhantomCreateRest
candidate->op() == PhantomDirectArguments candidate->op() == PhantomClonedArguments candidate->op() == PhantomSpread candidate->op() == PhantomNewArrayWithSpread

​https://bugs.webkit.org/show_bug.cgi?id=174900

Reviewed by Saam Barati.

JSTests:

  • stress/arguments-elimination-candidate-listings-should-respect-pseudo-terminals.js: Added.

(sideEffect):
(args):
(test):

Source/JavaScriptCore:

In the arguments elimination phase, due to high cost of AI, we intentionally do not run AI.
Instead, we use ForceOSRExit etc. (pseudo terminals) not to look into unreachable nodes.
The problem is that even transforming phase also checks this pseudo terminals.

BB1
1: ForceOSRExit
2: CreateDirectArguments

BB2
3: GetButterfly(@2)
4: ForceOSRExit

In the above case, @2 is not converted to PhantomDirectArguments. But @3 is processed. And the assertion fires.

In this patch, we do not list candidates up after seeing pseudo terminals in basic blocks.

  • dfg/DFGArgumentsEliminationPhase.cpp:
12:25 AM Changeset in webkit [219996] by commit-queue@webkit.org
  • 24 edits
    26 moves
    2 adds
    2 deletes in trunk/Source

Remove Web prefix from WebVideoFullscreen and WebPlaybackSession classes.
​https://bugs.webkit.org/show_bug.cgi?id=174437

Patch by Jeremy Jones <​jeremyj@apple.com> on 2017-07-28
Reviewed by Darin Adler.

Source/WebCore:

No new tests because no behavior change.

Remove redundant Web- prefix from classes in WebCore namespace.

  • WebCore.xcodeproj/project.pbxproj:
  • html/HTMLMediaElement.cpp:
  • html/HTMLVideoElement.cpp:
  • platform/cocoa/PlaybackSessionInterface.h: Renamed from Source/WebCore/platform/cocoa/WebPlaybackSessionInterface.h.

(WebCore::PlaybackSessionInterface::~PlaybackSessionInterface):

  • platform/cocoa/PlaybackSessionModel.h: Renamed from Source/WebCore/platform/cocoa/WebPlaybackSessionModel.h.

(WebCore::PlaybackSessionModel::~PlaybackSessionModel):
(WebCore::PlaybackSessionModelClient::~PlaybackSessionModelClient):
(WebCore::PlaybackSessionModelClient::externalPlaybackChanged):

  • platform/cocoa/PlaybackSessionModelMediaElement.h: Renamed from Source/WebCore/platform/cocoa/WebPlaybackSessionModelMediaElement.h.
  • platform/cocoa/PlaybackSessionModelMediaElement.mm: Renamed from Source/WebCore/platform/cocoa/WebPlaybackSessionModelMediaElement.mm.
  • platform/cocoa/VideoFullscreenChangeObserver.h: Renamed from Source/WebCore/platform/cocoa/WebVideoFullscreenChangeObserver.h.

(WebCore::VideoFullscreenChangeObserver::~VideoFullscreenChangeObserver):

  • platform/cocoa/VideoFullscreenModel.h: Renamed from Source/WebCore/platform/cocoa/WebVideoFullscreenModel.h.

(WebCore::VideoFullscreenModel::~VideoFullscreenModel):
(WebCore::VideoFullscreenModelClient::~VideoFullscreenModelClient):

  • platform/cocoa/VideoFullscreenModelVideoElement.h: Renamed from Source/WebCore/platform/cocoa/WebVideoFullscreenModelVideoElement.h.

(WebCore::VideoFullscreenModelVideoElement::create):

  • platform/cocoa/VideoFullscreenModelVideoElement.mm: Renamed from Source/WebCore/platform/cocoa/WebVideoFullscreenModelVideoElement.mm.
  • platform/ios/PlaybackSessionInterfaceAVKit.h: Renamed from Source/WebCore/platform/ios/WebPlaybackSessionInterfaceAVKit.h.
  • platform/ios/PlaybackSessionInterfaceAVKit.mm: Renamed from Source/WebCore/platform/ios/WebPlaybackSessionInterfaceAVKit.mm.
  • platform/ios/VideoFullscreenInterfaceAVKit.h: Renamed from Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.h.
  • platform/ios/VideoFullscreenInterfaceAVKit.mm: Renamed from Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm.
  • platform/ios/WebAVPlayerController.h:
  • platform/ios/WebAVPlayerController.mm:
  • platform/ios/WebVideoFullscreenControllerAVKit.mm:
  • platform/mac/PlaybackSessionInterfaceMac.h: Renamed from Source/WebCore/platform/mac/WebPlaybackSessionInterfaceMac.h.
  • platform/mac/PlaybackSessionInterfaceMac.mm: Renamed from Source/WebCore/platform/mac/WebPlaybackSessionInterfaceMac.mm.
  • platform/mac/VideoFullscreenInterfaceMac.h: Renamed from Source/WebCore/platform/mac/WebVideoFullscreenInterfaceMac.h.
  • platform/mac/VideoFullscreenInterfaceMac.mm: Renamed from Source/WebCore/platform/mac/WebVideoFullscreenInterfaceMac.mm.
  • platform/mac/WebPlaybackControlsManager.h:
  • platform/mac/WebPlaybackControlsManager.mm:

Source/WebKit:

Remove redundant Web- prefix from classes in WebKit namespace.

  • DerivedSources.make:
  • UIProcess/API/Cocoa/WKWebView.mm:
  • UIProcess/Cocoa/PlaybackSessionManagerProxy.h: Renamed from Source/WebKit/UIProcess/Cocoa/WebPlaybackSessionManagerProxy.h.
  • UIProcess/Cocoa/PlaybackSessionManagerProxy.messages.in: Renamed from Source/WebKit/UIProcess/Cocoa/WebPlaybackSessionManagerProxy.messages.in.
  • UIProcess/Cocoa/PlaybackSessionManagerProxy.mm: Added.
  • UIProcess/Cocoa/VideoFullscreenManagerProxy.h: Renamed from Source/WebKit/UIProcess/Cocoa/WebVideoFullscreenManagerProxy.h.
  • UIProcess/Cocoa/VideoFullscreenManagerProxy.messages.in: Renamed from Source/WebKit/UIProcess/Cocoa/WebVideoFullscreenManagerProxy.messages.in.
  • UIProcess/Cocoa/VideoFullscreenManagerProxy.mm: Renamed from Source/WebKit/UIProcess/Cocoa/WebVideoFullscreenManagerProxy.mm.
  • UIProcess/Cocoa/WebPlaybackSessionManagerProxy.mm: Removed.
  • UIProcess/Cocoa/WebViewImpl.mm:

(WebKit::WebViewImpl::updateMediaTouchBar):

  • UIProcess/WebPageProxy.cpp:

(WebKit::m_weakPtrFactory):
(WebKit::WebPageProxy::reattachToWebProcess):
(WebKit::WebPageProxy::playbackSessionManager):
(WebKit::WebPageProxy::videoFullscreenManager):

  • UIProcess/WebPageProxy.h:
  • UIProcess/ios/WebPageProxyIOS.mm:
  • WebKit.xcodeproj/project.pbxproj:
  • WebProcess/WebCoreSupport/WebChromeClient.cpp:
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::playbackSessionManager):
(WebKit::WebPage::videoFullscreenManager):

  • WebProcess/WebPage/WebPage.h:
  • WebProcess/cocoa/PlaybackSessionManager.h: Renamed from Source/WebKit/WebProcess/cocoa/WebPlaybackSessionManager.h.
  • WebProcess/cocoa/PlaybackSessionManager.messages.in: Renamed from Source/WebKit/WebProcess/cocoa/WebPlaybackSessionManager.messages.in.
  • WebProcess/cocoa/PlaybackSessionManager.mm: Added.
  • WebProcess/cocoa/VideoFullscreenManager.h: Renamed from Source/WebKit/WebProcess/cocoa/WebVideoFullscreenManager.h.

(WebKit::VideoFullscreenInterfaceContext::create):

  • WebProcess/cocoa/VideoFullscreenManager.messages.in: Renamed from Source/WebKit/WebProcess/cocoa/WebVideoFullscreenManager.messages.in.
  • WebProcess/cocoa/VideoFullscreenManager.mm: Renamed from Source/WebKit/WebProcess/cocoa/WebVideoFullscreenManager.mm.
  • WebProcess/cocoa/WebPlaybackSessionManager.mm: Removed.

Source/WebKitLegacy/mac:

Remove redundant Web- prefix from classes in WebKit namespace.

  • WebView/WebView.mm:

(-[WebView _setUpPlaybackControlsManagerForMediaElement:]):

  • WebView/WebViewData.h:
  • WebView/WebViewData.mm:
Note: See TracTimeline for information about the timeline view.