Context Navigation

Existing libtasn1 utilities are used to achieve this. First, the provided key data
is decoded against the PrivateKeyInfo ASN.1 definition. First, the version member
of that structure is validated, followed by the algorithm member. The latter is
also properly tested depending on this being an import of an ECDSA or ECDH key.

Data of the parameters member is decoded against the ECParameters ASN.1 definition,
and the namedCurve object identifier is validated, making sure it represents a
valid EC curve and that this curve maches the one specified for the import
operation.

Data of the privateKey member is decoded against the ECPrivateKey ASN.1 definition.
The version member of that structure is properly validated. The optional parameters
member of that structure is already decoded against the ECParameters ASN.1
definition. If present, it is checked to contain a valid EC curve identifier that
matches the specified curve.

The optional publicKey member of the ECPrivateKey structure is validated, testing
that its data matches in size an uncompressed EC point, and that the first byte
of this data is 0x04, as expected for an uncompressed EC point.

What's left is the private key data on the initial ECPrivateKey structure. That
data is retrieved and validated, making sure its size matches the size of the
specified curve. The private-key s-expression is then constructed, embedding
the curve name and the validated private key data. This s-expression is then used
to construct an EC context.

If the optional publicKey data was provided, it's used to set the q parameter
for this EC context. Otherwise, the value for q is computed on-the-fly for the
specified EC and the provided private key. The q point is then tested through
the gcry_mpi_ec_curve_point() function, making sure that the derived point is
indeed located on the given EC.

Finally, with the private key properly validated, a new CryptoKeyEC object is
constructed, using the private-key s-expression and the parameters that were
specified for this import operation.

crypto/gcrypt/CryptoKeyECGCrypt.cpp:

(WebCore::CryptoKeyEC::platformImportPkcs8):

crypto/gcrypt/GCryptUtilities.h:

LayoutTests:

platform/wpe/TestExpectations:

Unskip passing Web Crypto tests that cover PKCS#8 imports of EC keys.

9:37 PM Changeset in webkit [220252] by Chris Dumez

12 edits
1 move
2 adds
1 delete in trunk

Fix parsing of <meta http-equiv=refresh> to allow time starting with a '.' without a leading 0
https://bugs.webkit.org/show_bug.cgi?id=175132

Reviewed by Darin Adler.

LayoutTests/imported/w3c:

Re-sync WPT tests from upstream c8bf1bbe9296. This extends test coverage.

web-platform-tests/html/semantics/document-metadata/the-meta-element/pragma-directives/attr-meta-http-equiv-refresh/allow-scripts-flag-changing-1-expected.txt:
web-platform-tests/html/semantics/document-metadata/the-meta-element/pragma-directives/attr-meta-http-equiv-refresh/allow-scripts-flag-changing-2-expected.txt:
web-platform-tests/html/semantics/document-metadata/the-meta-element/pragma-directives/attr-meta-http-equiv-refresh/moving-documents-expected.txt: Removed.
web-platform-tests/html/semantics/document-metadata/the-meta-element/pragma-directives/attr-meta-http-equiv-refresh/parsing-expected.txt:
web-platform-tests/html/semantics/document-metadata/the-meta-element/pragma-directives/attr-meta-http-equiv-refresh/parsing.html:
web-platform-tests/html/semantics/document-metadata/the-meta-element/pragma-directives/attr-meta-http-equiv-refresh/remove-from-document-expected.txt: Added.
web-platform-tests/html/semantics/document-metadata/the-meta-element/pragma-directives/attr-meta-http-equiv-refresh/remove-from-document.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/html/semantics/document-metadata/the-meta-element/pragma-directives/attr-meta-http-equiv-refresh/moving-documents.html.
web-platform-tests/html/semantics/document-metadata/the-meta-element/pragma-directives/attr-meta-http-equiv-refresh/support/refresh.sub.html: Added.
web-platform-tests/html/semantics/document-metadata/the-meta-element/pragma-directives/attr-meta-http-equiv-refresh/support/w3c-import.log:
web-platform-tests/html/semantics/document-metadata/the-meta-element/pragma-directives/attr-meta-http-equiv-refresh/w3c-import.log:

Source/WebCore:

Fix parsing of <meta http-equiv=refresh> to allow time starting with a '.', without
a leading 0. This is as per https://github.com/whatwg/html/pull/2852.

The latest spec is at:

https://html.spec.whatwg.org/multipage/semantics.html#attr-meta-http-equiv-refresh

Test: imported/w3c/web-platform-tests/html/semantics/document-metadata/the-meta-element/pragma-directives/attr-meta-http-equiv-refresh/parsing.html

html/parser/HTMLParserIdioms.cpp:

(WebCore::parseHTTPRefreshInternal):

LayoutTests:

TestExpectations:

Mark as flaky tests that used to not run because they were missing a subresource. Now that I imported
this subresource, the tests run but are failing. When they fail, those tests are flaky due to the lines
they log.

tests-options.json:

8:57 PM Changeset in webkit [220251] by commit-queue@webkit.org

2 edits in trunk/Source/WebInspectorUI

JSContext Inspector: Scripts sometimes do not show in resources tab
https://bugs.webkit.org/show_bug.cgi?id=175153
<rdar://problem/33708683>

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2017-08-03
Reviewed by Matt Baker.

UserInterface/Views/ResourceSidebarPanel.js:

(WI.ResourceSidebarPanel.prototype.initialLayout):
When the ResourceSidebar is lazily created, be sure to add any scripts
to the sidebar that are not backed by Resources.

(WI.ResourceSidebarPanel.prototype._scriptWasAdded):
(WI.ResourceSidebarPanel.prototype._addScript):
Extract so it can be used outside of an event handler.

7:41 PM Changeset in webkit [220250] by BJ Burg

66 edits in trunk

Remove ENABLE(WEB_SOCKET) guards
https://bugs.webkit.org/show_bug.cgi?id=167044

Reviewed by Joseph Pecoraro.

Source/cmake/OptionsMac.cmake:
Source/cmake/OptionsWin.cmake:
Source/cmake/WebKitFeatures.cmake:
Source/cmake/tools/vsprops/FeatureDefines.props:
Source/cmake/tools/vsprops/FeatureDefinesCairo.props:

Source/JavaScriptCore:

Configurations/FeatureDefines.xcconfig:

Source/WebCore:

Configurations/FeatureDefines.xcconfig:
Modules/websockets/ThreadableWebSocketChannel.cpp:
Modules/websockets/ThreadableWebSocketChannel.h:
Modules/websockets/ThreadableWebSocketChannelClientWrapper.cpp:
Modules/websockets/ThreadableWebSocketChannelClientWrapper.h:
Modules/websockets/WebSocket.cpp:
Modules/websockets/WebSocket.h:
Modules/websockets/WebSocket.idl:
Modules/websockets/WebSocketChannel.cpp:
Modules/websockets/WebSocketChannel.h:
Modules/websockets/WebSocketChannelClient.h:
Modules/websockets/WebSocketDeflateFramer.cpp:
Modules/websockets/WebSocketDeflateFramer.h:
Modules/websockets/WebSocketDeflater.cpp:
Modules/websockets/WebSocketDeflater.h:
Modules/websockets/WebSocketExtensionDispatcher.cpp:
Modules/websockets/WebSocketExtensionDispatcher.h:
Modules/websockets/WebSocketExtensionParser.cpp:
Modules/websockets/WebSocketExtensionParser.h:
Modules/websockets/WebSocketExtensionProcessor.h:
Modules/websockets/WebSocketFrame.cpp:
Modules/websockets/WebSocketFrame.h:
Modules/websockets/WebSocketHandshake.cpp:
Modules/websockets/WebSocketHandshake.h:
Modules/websockets/WorkerThreadableWebSocketChannel.cpp:
Modules/websockets/WorkerThreadableWebSocketChannel.h:
dom/Document.cpp:

(WebCore::Document::Document):
(WebCore::Document::idbConnectionProxy):
(WebCore::Document::socketProvider):

dom/Document.h:
dom/ScriptExecutionContext.h:
inspector/InspectorInstrumentation.cpp:

(WebCore::InspectorInstrumentation::didSendWebSocketFrameImpl):

inspector/InspectorInstrumentation.h:

(WebCore::InspectorInstrumentation::didSendWebSocketFrame):

inspector/InspectorNetworkAgent.cpp:
inspector/InspectorNetworkAgent.h:
page/RuntimeEnabledFeatures.cpp:

(WebCore::RuntimeEnabledFeatures::webSocketEnabled const):

page/RuntimeEnabledFeatures.h:
page/SocketProvider.cpp:
page/SocketProvider.h:
workers/WorkerGlobalScope.cpp:

(WebCore::WorkerGlobalScope::WorkerGlobalScope):

workers/WorkerGlobalScope.h:
workers/WorkerMessagingProxy.cpp:

(WebCore::WorkerMessagingProxy::startWorkerGlobalScope):

workers/WorkerThread.cpp:

(WebCore::WorkerThread::WorkerThread):
(WebCore::WorkerThread::socketProvider):

workers/WorkerThread.h:

Source/WebCore/PAL:

Configurations/FeatureDefines.xcconfig:

Source/WebKit:

Configurations/FeatureDefines.xcconfig:
WebProcess/Network/WebSocketProvider.cpp:
WebProcess/Network/WebSocketProvider.h:

Source/WebKitLegacy/mac:

Configurations/FeatureDefines.xcconfig:
WebView/WebPreferencesPrivate.h:

Source/WTF:

wtf/FeatureDefines.h:

Tools:

Scripts/webkitperl/FeatureList.pm:
TestWebKitAPI/Configurations/FeatureDefines.xcconfig:

7:37 PM Changeset in webkit [220249] by don.olmstead@sony.com

6 edits
1 add in trunk/Source/WebCore

Remove LayoutUnit dependency in TextStream
https://bugs.webkit.org/show_bug.cgi?id=175110

Reviewed by Zalan Bujtas.

No new tests. No change in behavior.

CMakeLists.txt:
WebCore.xcodeproj/project.pbxproj:
platform/LayoutUnit.cpp: Added.

(WebCore::operator<<):

platform/LayoutUnit.h:
platform/text/TextStream.cpp:
platform/text/TextStream.h:

6:58 PM Changeset in webkit [220248] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

Improve WebKitLegacy video fullscreen animation begin and end rects.
https://bugs.webkit.org/show_bug.cgi?id=175152
rdar://problem/32840576

Patch by Jeremy Jones <jeremyj@apple.com> on 2017-08-03
Reviewed by Eric Carlson.

No new tests, becuase this change has no effect on the DOM.

This change uses different rects for fullscreen animation to prevent the animation
from failing, and to improve the aesthetics of the animation.

platform/mac/WebVideoFullscreenController.mm:

(frameExpandedToRatioOfFrame):
(-[WebVideoFullscreenController enterFullscreen:]):
(-[WebVideoFullscreenController exitFullscreen]):
(-[WebVideoFullscreenWindow animateFromRect:toRect:withSubAnimation:controllerAction:]):
(constrainFrameToRatioOfFrame): Deleted.

6:44 PM WebKitGTK/2.16.x edited by clopez@igalia.com

(diff)

6:38 PM WebKitGTK/2.16.x edited by clopez@igalia.com

(diff)

6:13 PM Changeset in webkit [220247] by jer.noble@apple.com

4 edits in trunk/Source/WebCore

[EME][Mac] SecureStop left on disk in Private Browsing mode.
https://bugs.webkit.org/show_bug.cgi?id=175162

Reviewed by Eric Carlson.

Return an empty string from mediaKeysStorageDirectory() when the page indicates that storage should
be ephemeral(). Previously, an empty string in this case would be treated as an error. Instead, treat
an empty string as valid, and do not try to store or retrieve session information to disk in that case.

Modules/encryptedmedia/legacy/WebKitMediaKeySession.cpp:

(WebCore::WebKitMediaKeySession::mediaKeysStorageDirectory const):

platform/graphics/avfoundation/objc/CDMSessionAVContentKeySession.mm:

(WebCore::CDMSessionAVContentKeySession::releaseKeys):
(WebCore::CDMSessionAVContentKeySession::update):
(WebCore::CDMSessionAVContentKeySession::generateKeyReleaseMessage):
(WebCore::CDMSessionAVContentKeySession::contentKeySession):

platform/graphics/avfoundation/objc/CDMSessionMediaSourceAVFObjC.mm:

(WebCore::CDMSessionMediaSourceAVFObjC::storagePath const):

6:12 PM Changeset in webkit [220246] by clopez@igalia.com

3 edits in trunk/Tools

REGRESSION(r219850): run-benchmark script broken on Linux
https://bugs.webkit.org/show_bug.cgi?id=175126

Reviewed by Stephanie Lewis.

The run-benchmark script dynamically generates the list of supported
browsers and platforms (currently Linux and OSX) by loading all
python files from Tools/Scripts/webkitpy/benchmark_runner/browser_driver
and getting the browser_name and platform variables from the
classes defined there.

This means that this classes should not raise an exception when
loaded on other platforms or otherwise they will broke the whole
script. Its fine if they raise an exception when executing any of
the methods they implement, but not when just loading/importing
the class.

Move the argument variable definitions that call on the platform
specific OSXBrowserDriver._screen_size() function from beeing
variables that are evaluated when loading the file, to be functions
that are only evaluated when the actual functionality needs to be
executed.

Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py:

(OSXChromeDriver.launch_url):
(OSXChromeCanaryDriver.launch_url):
(create_args):
(create_chrome_options):
(create_window_size_arg):

Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py:

(OSXFirefoxDriver.launch_url):
(OSXFirefoxNightlyDriver.launch_url):
(OSXFirefoxNightlyDriver.launch_driver):
(create_args):

6:07 PM Changeset in webkit [220245] by Chris Dumez

11 edits
7 deletes in trunk

Multiple Layout tests from web-platform-tests/beacon/ are timing out.
https://bugs.webkit.org/show_bug.cgi?id=175076
<rdar://problem/33704752>

Reviewed by Alexey Proskuryakov.

LayoutTests/imported/w3c:

Rebaseline tests that are now passing.

web-platform-tests/fetch/api/cors/cors-basic.any-expected.txt:
web-platform-tests/fetch/api/cors/cors-basic.any.worker-expected.txt:
web-platform-tests/fetch/api/cors/cors-no-preflight.any-expected.txt:
web-platform-tests/fetch/api/cors/cors-origin.any-expected.txt:
web-platform-tests/fetch/api/cors/cors-origin.any.worker-expected.txt:

Source/WebKit:

NetworkProcess/NetworkLoad.cpp:

(WebKit::NetworkLoad::completeAuthenticationChallenge):
In the NETWORK_SESSION code path, we did not ask the client about server trust evaluation
when the clientCredentialPolicy was CannotAskClientForCredentials. This is because the
same delegate is used for HTTP authentication and server trust evaluation in the
NETWORK_SESSION code path. To align both code paths, we now ask the client about server
trust evaluation even if the policy CannotAskClientForCredentials. This allows WKTR
to trust certificates for localhost / 127.0.0.1 unconditionally and consistently.

LayoutTests:

platform/ios-wk2/imported/w3c/web-platform-tests/fetch/api/basic/mode-no-cors-expected.txt: Removed.
platform/ios-wk2/imported/w3c/web-platform-tests/fetch/api/basic/mode-no-cors-worker-expected.txt: Removed.
platform/mac-wk1/imported/w3c/web-platform-tests/fetch/api/cors/cors-basic.any-expected.txt: Removed.
platform/mac-wk1/imported/w3c/web-platform-tests/fetch/api/cors/cors-basic.any.worker-expected.txt: Removed.
platform/mac-wk1/imported/w3c/web-platform-tests/fetch/api/cors/cors-no-preflight.any-expected.txt: Removed.
platform/mac-wk1/imported/w3c/web-platform-tests/fetch/api/cors/cors-origin.any-expected.txt: Removed.
platform/mac-wk1/imported/w3c/web-platform-tests/fetch/api/cors/cors-origin.any.worker-expected.txt: Removed.
platform/mac-wk2/imported/w3c/web-platform-tests/fetch/api/basic/mode-no-cors-expected.txt: Removed.
platform/mac-wk2/imported/w3c/web-platform-tests/fetch/api/basic/mode-no-cors-worker-expected.txt: Removed.

Drop platform-specific expectations as those tests are now passing everywhere.

platform/wk2/TestExpectations:

Unskip tests that are now passing.

6:00 PM Changeset in webkit [220244] by commit-queue@webkit.org

8 edits
2 adds in trunk

[Fetch API] Add support for Request keepalive getter
https://bugs.webkit.org/show_bug.cgi?id=175151

Patch by Youenn Fablet <youenn@apple.com> on 2017-08-03
Reviewed by Chris Dumez.

LayoutTests/imported/w3c:

web-platform-tests/fetch/api/request/request-idl-expected.txt:
web-platform-tests/fetch/api/request/request-idl.html:
web-platform-tests/fetch/api/request/request-keepalive-expected.txt: Added.
web-platform-tests/fetch/api/request/request-keepalive.html: Added.

Source/WebCore:

Test: imported/w3c/web-platform-tests/fetch/api/request/request-keepalive.html

Adding keepalive as a fetch option.
Adding initialization and getter of keepalive into FetchRequest.

Modules/fetch/FetchRequest.cpp:

(WebCore::buildOptions):

Modules/fetch/FetchRequest.h:
Modules/fetch/FetchRequest.idl:
loader/FetchOptions.h:

5:20 PM Changeset in webkit [220243] by commit-queue@webkit.org

69 edits
6 copies
2 adds
1 delete in trunk

[PAL] Move spi/cf directory into PAL
https://bugs.webkit.org/show_bug.cgi?id=175057

Patch by Yoshiaki Jitsukawa <jitsu@rd.scei.sony.co.jp> on 2017-08-03
Reviewed by Antti Koivisto.

Source/WebCore:

WebCore.xcodeproj/project.pbxproj:
loader/cocoa/DiskCacheMonitorCocoa.mm:
loader/cocoa/SubresourceLoaderCocoa.mm:
loader/mac/ResourceLoaderMac.mm:
platform/cf/CoreMediaSoftLink.cpp:
platform/cf/CoreMediaSoftLink.h:
platform/mac/PluginBlacklist.mm:
platform/mac/WebCoreNSStringExtras.mm:
platform/mac/WebGLBlacklist.mm:
platform/mediastream/mac/CoreAudioCaptureSource.cpp:
platform/network/NetworkStorageSession.h:
platform/network/cf/CookieJarCFNet.cpp:
platform/network/cf/CredentialStorageCFNet.cpp:
platform/network/cf/ResourceHandleCFNet.cpp:
platform/network/cf/ResourceHandleCFURLConnectionDelegate.cpp:
platform/network/cf/ResourceHandleCFURLConnectionDelegateWithOperationQueue.cpp:
platform/network/cf/ResourceRequestCFNet.cpp:
platform/network/cf/ResourceRequestCFNet.h:
platform/network/cf/ResourceResponse.h:
platform/network/cf/ResourceResponseCFNet.cpp:
platform/network/cf/SocketStreamHandleImplCFNet.cpp:
platform/network/cf/SynchronousResourceHandleCFURLConnectionDelegate.cpp:
platform/network/cocoa/CookieStorageObserver.h:
platform/network/cocoa/CredentialCocoa.h:
platform/network/cocoa/NetworkStorageSessionCocoa.mm:
platform/network/cocoa/ResourceRequestCocoa.mm:
platform/network/cocoa/ResourceResponseCocoa.mm:
platform/network/ios/ResourceRequestIOS.mm:
platform/network/mac/CookieJarMac.mm:
platform/network/mac/FormDataStreamMac.mm:
platform/network/mac/ResourceHandleMac.mm:
platform/network/mac/ResourceRequestMac.mm:
platform/network/mac/WebCoreResourceHandleAsDelegate.mm:
platform/network/mac/WebCoreResourceHandleAsOperationQueueDelegate.mm:
platform/network/mac/WebCoreURLResponse.h:
testing/cocoa/WebArchiveDumpSupport.mm:

Source/WebCore/PAL:

PAL.xcodeproj/project.pbxproj:
pal/spi/cf/CFLocaleSPI.h: Renamed from Source/WebCore/platform/spi/cf/CFLocaleSPI.h.
pal/spi/cf/CFNetworkConnectionCacheSPI.h: Renamed from Source/WebCore/platform/spi/cf/CFNetworkConnectionCacheSPI.h.
pal/spi/cf/CFNetworkSPI.h: Renamed from Source/WebCore/platform/spi/cf/CFNetworkSPI.h.
pal/spi/cf/CFUtilitiesSPI.h: Renamed from Source/WebCore/platform/spi/cf/CFUtilitiesSPI.h.
pal/spi/cf/CoreAudioSPI.h: Renamed from Source/WebCore/platform/spi/cf/CoreAudioSPI.h.
pal/spi/cf/CoreMediaSPI.h: Renamed from Source/WebCore/platform/spi/cf/CoreMediaSPI.h.

Source/WebKit:

NetworkProcess/cocoa/NetworkDataTaskCocoa.mm:
NetworkProcess/cocoa/NetworkProcessCocoa.mm:
NetworkProcess/cocoa/NetworkSessionCocoa.mm:
NetworkProcess/ios/NetworkProcessIOS.mm:
NetworkProcess/mac/NetworkLoadMac.mm:
NetworkProcess/mac/NetworkProcessMac.mm:
Shared/cf/CookieStorageUtilsCF.h:
Shared/mac/ChildProcessMac.mm:
Shared/mac/CookieStorageShim.mm:
UIProcess/API/Cocoa/WKHTTPCookieStore.mm:
UIProcess/API/Cocoa/WKProcessPool.mm:
UIProcess/Cocoa/WebProcessPoolCocoa.mm:
UIProcess/Plugins/mac/PluginProcessProxyMac.mm:
UIProcess/WebsiteData/Cocoa/WebsiteDataStoreCocoa.mm:
UIProcess/WebsiteData/WebsiteDataRecord.cpp:
UIProcess/WebsiteData/WebsiteDataStore.h:
UIProcess/mac/WebCookieManagerProxyMac.mm:
WebProcess/WebCoreSupport/mac/WebFrameNetworkingContext.mm:
WebProcess/cocoa/WebProcessCocoa.mm:

Source/WebKitLegacy/mac:

Plugins/Hosted/HostedNetscapePluginStream.mm:
Plugins/WebNetscapePluginStream.mm:
WebCoreSupport/WebFrameNetworkingContext.mm:
WebView/WebPreferences.mm:
WebView/WebView.mm:

Tools:

Scripts/webkitpy/style/checker.py:
Scripts/webkitpy/style/checker_unittest.py:

(GlobalVariablesTest.test_path_rules_specifier):

Ignore "readability/naming/underscores" style errors for sources
under the WebCore/PAL/pal/spi directory.

TestWebKitAPI/Tests/WebKit2Cocoa/CookieAcceptPolicy.mm:

5:14 PM Changeset in webkit [220242] by matthew_hanson@apple.com

7 edits in branches/safari-604-branch/Source

Versioning.

4:54 PM Changeset in webkit [220241] by commit-queue@webkit.org

47 edits in trunk

Remove FETCH_API compilation guard
https://bugs.webkit.org/show_bug.cgi?id=175154

Patch by Youenn Fablet <youenn@apple.com> on 2017-08-03
Reviewed by Chris Dumez.

Source/JavaScriptCore:

Configurations/FeatureDefines.xcconfig:

Source/WebCore:

No change of behavior.

Configurations/FeatureDefines.xcconfig:
Modules/fetch/DOMWindowFetch.cpp:
Modules/fetch/DOMWindowFetch.h:
Modules/fetch/DOMWindowFetch.idl:
Modules/fetch/FetchBody.cpp:
Modules/fetch/FetchBody.h:
Modules/fetch/FetchBody.idl:
Modules/fetch/FetchBodyConsumer.cpp:
Modules/fetch/FetchBodyConsumer.h:
Modules/fetch/FetchBodyOwner.cpp:
Modules/fetch/FetchBodyOwner.h:
Modules/fetch/FetchHeaders.cpp:
Modules/fetch/FetchHeaders.h:
Modules/fetch/FetchHeaders.idl:
Modules/fetch/FetchInternals.js:
Modules/fetch/FetchLoader.cpp:
Modules/fetch/FetchLoader.h:
Modules/fetch/FetchLoaderClient.h:
Modules/fetch/FetchRequest.cpp:
Modules/fetch/FetchRequest.h:
Modules/fetch/FetchRequest.idl:
Modules/fetch/FetchResponse.cpp:
Modules/fetch/FetchResponse.h:
Modules/fetch/FetchResponse.idl:
Modules/fetch/FetchResponse.js:
Modules/fetch/FetchResponseSource.cpp:
Modules/fetch/FetchResponseSource.h:
Modules/fetch/WorkerGlobalScopeFetch.cpp:
Modules/fetch/WorkerGlobalScopeFetch.h:
Modules/fetch/WorkerGlobalScopeFetch.idl:
page/RuntimeEnabledFeatures.h:

(WebCore::RuntimeEnabledFeatures::fetchAPIEnabled const):

Source/WebCore/PAL:

Configurations/FeatureDefines.xcconfig:

Source/WebKit:

Configurations/FeatureDefines.xcconfig:
WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::updatePreferences):

Source/WebKitLegacy/mac:

Configurations/FeatureDefines.xcconfig:
WebView/WebPreferences.mm:

(+[WebPreferences initialize]):

WebView/WebView.mm:

(-[WebView _preferencesChanged:]):

Source/WTF:

wtf/FeatureDefines.h:

Tools:

TestWebKitAPI/Configurations/FeatureDefines.xcconfig:

4:38 PM Changeset in webkit [220240] by matthew_hanson@apple.com

1 copy in tags/Safari-604.2.1

Tag Safari-604.2.1.

4:27 PM Changeset in webkit [220239] by matthew_hanson@apple.com

1 copy in tags/Safari-604.1.37

Tag Safari-604.1.37.

4:17 PM Changeset in webkit [220238] by Lucas Forschler

2 edits in trunk/Tools

https://bugs.webkit.org/show_bug.cgi?id=174718

4:11 PM Changeset in webkit [220237] by matthew_hanson@apple.com

7 edits in branches/safari-604.1-branch/Source

Versioning.

4:11 PM Changeset in webkit [220236] by matthew_hanson@apple.com

7 edits in branches/safari-604.1-branch/Source

Versioning.

4:10 PM Changeset in webkit [220235] by Devin Rousso

10 edits in trunk/Source

Web Inspector: add button to open Inspector^{2

https://bugs.webkit.org/show_bug.cgi?id=175108}

Reviewed by Brian Burg.

Source/WebCore:

This patch just exposes a function to the inspector page. No new functionality was added.

inspector/InspectorFrontendHost.idl:
inspector/InspectorFrontendHost.h:
inspector/InspectorFrontendHost.cpp:

(WebCore::InspectorFrontendHost::inspectInspector):

Source/WebInspectorUI:

UserInterface/Debug/Bootstrap.js:

(updateDebugUI):
(WI.runBootstrapOperations):

UserInterface/Views/ButtonToolbarItem.js:

(WI.ButtonToolbarItem):
(WI.ButtonToolbarItem.prototype.get label): Deleted.
(WI.ButtonToolbarItem.prototype.set label): Deleted.

UserInterface/Views/ButtonToolbarItem.css:

(.toolbar .item.button):
(.toolbar .item.button:not(.disabled):active):
(.toolbar .item.button:not(.disabled):matches(:focus, .activate.activated)):
(.toolbar .item.button:not(.disabled):active:matches(:focus, .activate.activated)):
(.toolbar .item.button > .glyph):
(.toolbar .item.button:not(.disabled):active > .glyph): Deleted.
(.toolbar .item.button:not(.disabled):matches(:focus, .activate.activated) > .glyph): Deleted.
(.toolbar .item.button:not(.disabled):active:matches(:focus, .activate.activated) > .glyph): Deleted.
(.toolbar .item.button > .label): Deleted.

UserInterface/Views/ActivateButtonToolbarItem.js:

(WI.ActivateButtonToolbarItem):
(WI.ActivateButtonToolbarItem.prototype.get label): Deleted.
(WI.ActivateButtonToolbarItem.prototype.set label): Deleted.

UserInterface/Base/Main.js:

(WI.contentLoaded):
Remove unused label parameter from Toolbar objects.

4:09 PM Changeset in webkit [220234] by matthew_hanson@apple.com

2 edits in branches/safari-604.1-branch/Source/WebKitLegacy

Cherry-pick r220205. rdar://problem/33711361

3:31 PM Changeset in webkit [220233] by Matt Baker

20 edits
1 copy
7 adds in trunk

Web Inspector: Instrument WebGLProgram created/deleted
https://bugs.webkit.org/show_bug.cgi?id=175059

Reviewed by Devin Rousso.

Source/JavaScriptCore:

Extend the Canvas protocol with types/events for tracking WebGLPrograms.

inspector/protocol/Canvas.json:

Source/WebCore:

Tests: inspector/canvas/shaderProgram-add-remove-webgl.html

inspector/canvas/shaderProgram-add-remove-webgl2.html

This patch adds instrumentation to WebGLRenderingContextBase for tracking
WebGLPrograms. A new helper class, InspectorShaderProgram, is used by
the CanvasAgent to hold related data.

CMakeLists.txt:
WebCore.xcodeproj/project.pbxproj:

html/canvas/WebGLRenderingContextBase.cpp:

(WebCore::WebGLRenderingContextBase::createProgram):
(WebCore::WebGLRenderingContextBase::deleteProgram):

inspector/InspectorCanvasAgent.cpp:

(WebCore::InspectorCanvasAgent::enable):
(WebCore::InspectorCanvasAgent::frameNavigated):
(WebCore::InspectorCanvasAgent::didCreateProgram):
(WebCore::InspectorCanvasAgent::willDeleteProgram):
(WebCore::InspectorCanvasAgent::clearCanvasData):
(WebCore::InspectorCanvasAgent::unbindCanvas):
(WebCore::InspectorCanvasAgent::unbindProgram):
(WebCore::InspectorCanvasAgent::assertInspectorProgram):
(WebCore::InspectorCanvasAgent::findInspectorProgram):

inspector/InspectorCanvasAgent.h:

inspector/InspectorInstrumentation.cpp:

(WebCore::InspectorInstrumentation::didCreateCSSCanvasImpl):
(WebCore::InspectorInstrumentation::didChangeCSSCanvasClientNodesImpl):
(WebCore::InspectorInstrumentation::didCreateCanvasRenderingContextImpl):
(WebCore::InspectorInstrumentation::didChangeCanvasMemoryImpl):
(WebCore::InspectorInstrumentation::recordCanvasActionImpl):
(WebCore::InspectorInstrumentation::didFinishRecordingCanvasFrameImpl):
(WebCore::InspectorInstrumentation::didCreateProgramImpl):
(WebCore::InspectorInstrumentation::willDeleteProgramImpl):

inspector/InspectorInstrumentation.h:

(WebCore::InspectorInstrumentation::recordCanvasActionImpl):
(WebCore::InspectorInstrumentation::didCreateCSSCanvas):
(WebCore::InspectorInstrumentation::didChangeCSSCanvasClientNodes):
(WebCore::InspectorInstrumentation::didCreateCanvasRenderingContext):
(WebCore::InspectorInstrumentation::didChangeCanvasMemory):
(WebCore::InspectorInstrumentation::recordCanvasAction):
(WebCore::InspectorInstrumentation::didFinishRecordingCanvasFrame):
(WebCore::InspectorInstrumentation::didCreateProgram):
(WebCore::InspectorInstrumentation::willDeleteProgram):

inspector/InspectorShaderProgram.cpp: Added.

(WebCore::InspectorShaderProgram::create):
(WebCore::InspectorShaderProgram::InspectorShaderProgram):
(WebCore::InspectorShaderProgram::context const):

inspector/InspectorShaderProgram.h: Added.

Source/WebInspectorUI:

This patch adds frontend support for shader program instrumentation.
The frontend creates a ShaderProgram model object for each WebGLProgram.
Since only canvases with a WebGL context have programs, the Canvas model
object does not contain any logic specific to programs. CanvasManager
dispatches program added/removed events, and the parent Canvas can be
accessed from ShaderProgram but not the other way around.

UserInterface/Controllers/CanvasManager.js:

(WI.CanvasManager):
(WI.CanvasManager.prototype.get shaderPrograms):
(WI.CanvasManager.prototype.canvasRemoved):
(WI.CanvasManager.prototype.programCreated):
(WI.CanvasManager.prototype.programDeleted):
(WI.CanvasManager.prototype._mainResourceDidChange):
(WI.CanvasManager.prototype._dispatchShaderProgramRemoved):

UserInterface/Main.html:

UserInterface/Models/Canvas.js:

(WI.Canvas.prototype.nextShaderProgramDisplayNumber):
(WI.Canvas):

UserInterface/Models/ShaderProgram.js: Added.

(WI.ShaderProgram):
(WI.ShaderProgram.prototype.get identifier):
(WI.ShaderProgram.prototype.get canvas):
(WI.ShaderProgram.prototype.get displayName):

UserInterface/Protocol/CanvasObserver.js:

(WI.CanvasObserver.prototype.programCreated):
(WI.CanvasObserver.prototype.programDeleted):
(WI.CanvasObserver):

UserInterface/Test.html:

LayoutTests:

Add tests for CanvasManager shader program events and ShaderProgram model object.
WebGL and WebGL2 contexts are tested separately based on platform support.

inspector/canvas/resources/shaderProgram-utilities.js: Added.

(createProgram):
(deleteProgram):
(deleteContext):
(TestPage.registerInitializer.awaitProgramAdded):
(TestPage.registerInitializer):
(TestPage.registerInitializer.window.initializeTestSuite):
(TestPage.registerInitializer.window.addSimpleTestCase):
(TestPage.registerInitializer.window.addParentCanvasRemovedTestCase):

inspector/canvas/shaderProgram-add-remove-webgl-expected.txt: Added.
inspector/canvas/shaderProgram-add-remove-webgl.html: Added.
inspector/canvas/shaderProgram-add-remove-webgl2-expected.txt: Added.
inspector/canvas/shaderProgram-add-remove-webgl2.html: Added.

platform/gtk/TestExpectations:
platform/mac/TestExpectations:
platform/win/TestExpectations:

3:18 PM Changeset in webkit [220232] by commit-queue@webkit.org

2 edits in trunk/Source/WebInspectorUI

JSContext Inspector: Recording tab should not be available in New Tab picker
https://bugs.webkit.org/show_bug.cgi?id=175155

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2017-08-03
Reviewed by Brian Burg.

UserInterface/Views/RecordingTabContentView.js:

(WI.RecordingTabContentView.isTabAllowed):
Only allow the Recording Tab if we have a CanvasAgent.

1:28 PM Changeset in webkit [220231] by matthew_hanson@apple.com

1 edit in branches/safari-604-branch/Source/JavaScriptCore/ChangeLog

Cherry-pick r220144. rdar://problem/33692161

1:27 PM Changeset in webkit [220230] by matthew_hanson@apple.com

5 edits in branches/safari-604-branch/Source/WebKit

Cherry-pick r220138. rdar://problem/33692550

1:27 PM Changeset in webkit [220229] by matthew_hanson@apple.com

2 edits in branches/safari-604-branch

Cherry-pick r220112. rdar://problem/33692164

1:27 PM Changeset in webkit [220228] by matthew_hanson@apple.com

1 edit in branches/safari-604-branch/Source/WebCore/ChangeLog

Cherry-pick r220085. rdar://problem/33692157

1:27 PM Changeset in webkit [220227] by matthew_hanson@apple.com

1 edit in branches/safari-604-branch/Source/WebCore/ChangeLog

Cherry-pick r220084. rdar://problem/33692167

1:27 PM Changeset in webkit [220226] by Matt Lewis

6 edits in trunk/Source

Unreviewed, rolling out r220209.

This caused internal build failures.

Reverted changeset:

"Use MPAVRoutingController instead of deprecated versions."
https://bugs.webkit.org/show_bug.cgi?id=175063
http://trac.webkit.org/changeset/220209

1:27 PM Changeset in webkit [220225] by matthew_hanson@apple.com

1 edit in branches/safari-604-branch/Source/WebCore/ChangeLog

Cherry-pick r220077. rdar://problem/33692157

1:27 PM Changeset in webkit [220224] by matthew_hanson@apple.com

2 edits in branches/safari-604-branch

Cherry-pick r220035. rdar://problem/33692157

1:21 PM Changeset in webkit [220223] by commit-queue@webkit.org

164 edits
13 copies
1 move
302 adds
1 delete in trunk/LayoutTests

Import WPT service worker tests
https://bugs.webkit.org/show_bug.cgi?id=175053

Patch by Youenn Fablet <youenn@apple.com> on 2017-08-03
Reviewed by Brady Eidson.

LayoutTests/imported/w3c:

Importing service-worker tests up to cfdfb48329b20e19b6492a317ac5181a99506fd2.

resources/resource-files.json:
resources/import-expectations.json:
web-platform-tests/service-workers/:

LayoutTests:

TestExpectations: skipping service worker tests.

1:19 PM Changeset in webkit [220222] by BJ Burg

2 edits in trunk/Source/WebKit

Web Automation: consider file extensions in the "accept" attribute when deciding if a file can be uploaded
https://bugs.webkit.org/show_bug.cgi?id=175081

Reviewed by Joseph Pecoraro.

UIProcess/Automation/WebAutomationSession.cpp:

(WebKit::fileCanBeAcceptedForUpload):
(WebKit::WebAutomationSession::handleRunOpenPanel):
In cases where a file has an extension, try to match it against the
accepted extensions list. Give up if there's no extension. Otherwise,
proceed as normal to infer a MIME type based on the extension.
In cases where extension-less files are inside hidden folders, the MIME
inference will fail as well.

12:37 PM Changeset in webkit [220221] by clopez@igalia.com

2 edits in trunk/Tools

[GTK][WKE] Pass the --memory-limited option on the GTK and WPE buildbots for the JSC tests.
https://bugs.webkit.org/show_bug.cgi?id=175140

Reviewed by Alexey Proskuryakov.

We are having lately issues with JSC tests causing problems on
the GTK+ and WPE bots due to the high amount of memory some tests
need to run.

The best thing we can do now is to workaround this by disabling
all the tests marked as memoryLimited on the GTK and WPE bots.
We may revise this on the future.

BuildSlaveSupport/build.webkit.org-config/master.cfg:

(RunJavaScriptCoreTests.start):

12:21 PM Changeset in webkit [220220] by beidson@apple.com

36 edits
14 adds in trunk

Add SW IDLs and stub out basic functionality.
https://bugs.webkit.org/show_bug.cgi?id=175115

Reviewed by Chris Dumez.

Source/cmake/WebKitFeatures.cmake:
Source/cmake/tools/vsprops/FeatureDefines.props:
Source/cmake/tools/vsprops/FeatureDefinesCairo.props:

Source/JavaScriptCore:

Configurations/FeatureDefines.xcconfig:

runtime/CommonIdentifiers.h:

Source/WebCore:

No new tests (Currently no behavior change).

Overall note: This feature is EnabledAtRuntime as opposed to EnabledBySetting because
the Settings-based code generation is completely broken for non-Document contexts,
whereas the RuntimeEnabledFeatures-based generation is not.

CMakeLists.txt:
Configurations/FeatureDefines.xcconfig:
DerivedSources.make:
WebCore.xcodeproj/project.pbxproj:

bindings/scripts/preprocess-idls.pl: Handle the new global scope c'tor file.

bindings/js/JSServiceWorkerContainerCustom.cpp: Added.

(WebCore::JSServiceWorkerContainer::ready const):

bindings/js/JSWorkerGlobalScopeBase.cpp:

(WebCore::toJSWorkerGlobalScope): Refactor to handle both types of derived workers.
(WebCore::toJSServiceWorkerGlobalScope):

bindings/js/JSWorkerGlobalScopeBase.h:

dom/EventNames.h:
dom/EventTargetFactory.in:

features.json: Change status of feature.

page/Navigator.idl:
page/NavigatorBase.cpp:

(WebCore::NavigatorBase::serviceWorker):

page/NavigatorBase.h:
page/NavigatorServiceWorker.idl: Added.

page/RuntimeEnabledFeatures.h:

(WebCore::RuntimeEnabledFeatures::serviceWorkerEnabled const):
(WebCore::RuntimeEnabledFeatures::setServiceWorkerEnabled):

workers/ServiceWorker.cpp: Added.

(WebCore::ServiceWorker::postMessage):
(WebCore::ServiceWorker::~ServiceWorker):
(WebCore::ServiceWorker::scriptURL const):
(WebCore::ServiceWorker::state const):
(WebCore::ServiceWorker::eventTargetInterface const):
(WebCore::ServiceWorker::scriptExecutionContext const):

workers/ServiceWorker.h: Added.
workers/ServiceWorker.idl: Added.

workers/ServiceWorkerContainer.cpp: Added.

(WebCore::ServiceWorkerContainer::~ServiceWorkerContainer):
(WebCore::ServiceWorkerContainer::controller const):
(WebCore::ServiceWorkerContainer::ready):
(WebCore::ServiceWorkerContainer::addRegistration):
(WebCore::ServiceWorkerContainer::getRegistration):
(WebCore::ServiceWorkerContainer::getRegistrations):
(WebCore::ServiceWorkerContainer::startMessages):
(WebCore::ServiceWorkerContainer::eventTargetInterface const):
(WebCore::ServiceWorkerContainer::scriptExecutionContext const):

workers/ServiceWorkerContainer.h: Added.
workers/ServiceWorkerContainer.idl: Added.

workers/ServiceWorkerGlobalScope.cpp: Added.

(WebCore::ServiceWorkerGlobalScope::registration):
(WebCore::ServiceWorkerGlobalScope::skipWaiting):

workers/ServiceWorkerGlobalScope.h: Added.
workers/ServiceWorkerGlobalScope.idl: Added.

workers/ServiceWorkerRegistration.cpp: Added.

(WebCore::ServiceWorkerRegistration::~ServiceWorkerRegistration):
(WebCore::ServiceWorkerRegistration::installing):
(WebCore::ServiceWorkerRegistration::waiting):
(WebCore::ServiceWorkerRegistration::active):
(WebCore::ServiceWorkerRegistration::scope const):
(WebCore::ServiceWorkerRegistration::update):
(WebCore::ServiceWorkerRegistration::unregister):
(WebCore::ServiceWorkerRegistration::eventTargetInterface const):
(WebCore::ServiceWorkerRegistration::scriptExecutionContext const):

workers/ServiceWorkerRegistration.h: Added.
workers/ServiceWorkerRegistration.idl: Added.

Source/WebCore/PAL:

Configurations/FeatureDefines.xcconfig:

Source/WebKit:

Configurations/FeatureDefines.xcconfig:

Shared/WebPreferencesDefinitions.h:

UIProcess/WebPreferences.cpp:

(WebKit::WebPreferences::enableAllExperimentalFeatures): Explicitly skip SW for now.

The ramifications to layouttests are complicated, and we'd like to follow up in a
separate patch.

WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::updatePreferences):

Source/WebKitLegacy/mac:

Configurations/FeatureDefines.xcconfig:

Source/WTF:

wtf/FeatureDefines.h:

Tools:

TestWebKitAPI/Configurations/FeatureDefines.xcconfig:

Scripts/webkitpy/bindings/main.py:

12:17 PM Changeset in webkit [220219] by mark.lam@apple.com

11 edits in trunk/Source/JavaScriptCore

Rename ScratchBuffer::activeLengthPtr to addressOfActiveLength.
https://bugs.webkit.org/show_bug.cgi?id=175142
<rdar://problem/33704528>

Reviewed by Filip Pizlo.

The convention in the rest of of JSC for such methods which return the address of
a field is to name them "addressOf<field name>". We'll rename
ScratchBuffer::activeLengthPtr to be consistent with this convention.

dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileNewArrayWithSpread):

dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

dfg/DFGThunks.cpp:

(JSC::DFG::osrExitGenerationThunkGenerator):

ftl/FTLLowerDFGToB3.cpp:

(JSC::FTL::DFG::LowerDFGToB3::compileNewArray):
(JSC::FTL::DFG::LowerDFGToB3::compileNewArrayWithSpread):

ftl/FTLThunks.cpp:

(JSC::FTL::genericGenerationThunkGenerator):

jit/AssemblyHelpers.cpp:

(JSC::AssemblyHelpers::debugCall):

jit/ScratchRegisterAllocator.cpp:

(JSC::ScratchRegisterAllocator::preserveUsedRegistersToScratchBufferForCall):
(JSC::ScratchRegisterAllocator::restoreUsedRegistersFromScratchBufferForCall):

runtime/VM.h:

(JSC::ScratchBuffer::addressOfActiveLength):
(JSC::ScratchBuffer::activeLengthPtr): Deleted.

wasm/WasmBinding.cpp:

(JSC::Wasm::wasmToJs):

12:13 PM Changeset in webkit [220218] by commit-queue@webkit.org

4 edits
1 add in trunk/LayoutTests

Test gardening.
https://bugs.webkit.org/show_bug.cgi?id=175137

Unreviewed test gardening.

Patch by Ms2ger <Ms2ger@igalia.com> on 2017-08-03

platform/gtk/TestExpectations:
platform/gtk/fast/images/async-image-multiple-clients-repaint-expected.txt: Added.
platform/gtk/fast/text/atsui-pointtooffset-calls-cg-expected.txt:
platform/win/TestExpectations:

11:59 AM Changeset in webkit [220217] by Yusuke Suzuki

2 edits in trunk/Source/WTF

Unreviewed, build fix for Windows port
https://bugs.webkit.org/show_bug.cgi?id=175013

wtf/Threading.h:

11:58 AM Changeset in webkit [220216] by matthew_hanson@apple.com

7 edits in branches/safari-604-branch/Source

Versioning.

11:55 AM Changeset in webkit [220215] by matthew_hanson@apple.com

7 edits in branches/safari-604.1-branch/Source

Versioning.

11:29 AM Changeset in webkit [220214] by Yusuke Suzuki

7 edits
4 deletes in trunk/Source/WTF

Merge ThreadHolder to WTF::Thread itself
https://bugs.webkit.org/show_bug.cgi?id=175013

Reviewed by Mark Lam.

Currently, we store ThreadHolder* to the TLS, and ThreadHolder* holds Ref<Thread>.
When we get Thread& from the current thread TLS, we need to dereference the ThreadHolder*.
However, ideally, we can store Thread* directly to the current thread TLS.
While the ThreadHolder design is beautiful, it's worth optimizing by storing Thread* directly
since Thread::current() is so frequently executed.

This patch merges ThreadHolder to Thread. And we now store Thread* directly in the TLS.
When storing it to TLS, we call leakRef() to keep Thread ref count incremented by the TLS.
And when destroying the TLS, we call deref() to ensure that Thread* is dereferenced from
the TLS.

WTF.xcodeproj/project.pbxproj:
wtf/CMakeLists.txt:
wtf/ThreadHolder.cpp: Removed.
wtf/ThreadHolder.h: Removed.
wtf/ThreadHolderPthreads.cpp: Removed.
wtf/ThreadHolderWin.cpp: Removed.
wtf/Threading.cpp:

(WTF::Thread::entryPoint):
(WTF::initializeThreading):

wtf/Threading.h:

(WTF::Thread::currentMayBeNull):
(WTF::Thread::current):

wtf/ThreadingPthreads.cpp:

(WTF::Thread::waitForCompletion):
(WTF::Thread::initializeCurrentTLS):
(WTF::Thread::initializeTLSKey):
(WTF::Thread::initializeTLS):
(WTF::Thread::destructTLS):
(WTF::Thread::createCurrentThread): Deleted.

wtf/ThreadingWin.cpp:

(WTF::Thread::initializeCurrentTLS):
(WTF::threadMapMutex):
(WTF::Thread::initializeTLSKey):
(WTF::Thread::currentDying):
(WTF::Thread::get):
(WTF::Thread::initializeTLS):
(WTF::Thread::destructTLS):
(WTF::waitForThreadCompletion):
(WTF::Thread::createCurrentThread): Deleted.

11:06 AM Changeset in webkit [220213] by matthew_hanson@apple.com

1 copy in branches/safari-604.1-branch

New Tag.

11:03 AM Changeset in webkit [220212] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit

[WebKit] Sort Xcode project file
https://bugs.webkit.org/show_bug.cgi?id=175122

Patch by Yoshiaki Jitsukawa <jitsu@rd.scei.sony.co.jp> on 2017-08-03
Reviewed by Antti Koivisto.

WebKit.xcodeproj/project.pbxproj:

11:03 AM Changeset in webkit [220211] by commit-queue@webkit.org

4 edits in trunk/Source/WebCore

[WebCore] Sort Xcode project files
https://bugs.webkit.org/show_bug.cgi?id=175121

Patch by Yoshiaki Jitsukawa <jitsu@rd.scei.sony.co.jp> on 2017-08-03
Reviewed by Antti Koivisto.

Source/WebCore:

WebCore.xcodeproj/project.pbxproj:

Source/WebCore/PAL:

PAL.xcodeproj/project.pbxproj:

10:51 AM Changeset in webkit [220210] by weinig@apple.com

59 edits
4 adds
2 deletes in trunk

Source/WebCore:
[WebIDL] Convert MutationCallback to be a normal generated callback
https://bugs.webkit.org/show_bug.cgi?id=174140

Reviewed by Darin Adler.

To make this work more nicely, I:

Added the ability to for non-nullable interfaces in sequences to be passed via a Ref<> rather than a RefPtr<> as a parameter to a callback function. (e.g. callback MyCallback = void (sequence<Foo> foos) will now have the signature, CallbackResult<void> handleEvent(const Vector<Ref<Foo>>&) rather than CallbackResult<void> handleEvent(const Vector<RefPtr<Foo>>&).
Added a new extended attribute for callback functions called [CallbackThisObject=Type] which allows you to specify that the callback needs a this object in addition to its arguments. When specified, the first argument of the C++ implementation function will now correspond to the this object, with the remaining arguments shifted over one.
Converted callback objects to all inherit directly from ActiveDOMCallback rather than having the generated JS callback derived class inherit from it. This allows us to have access to a callback's canInvokeCallback() function anywhere (needed for MutationCallback) as well as giving a place to put an optional virtual visitJSFunction to allow marking weak callbacks (while not an ideal layering, this matches what we do in EventListener). This change requires each callback to have a bit more code to import the ActiveDOMCallback's constructor and requires non-JS derived callbacks to pass a ScriptExecutionContext (e.g. the Document).

CMakeLists.txt:
DerivedSources.make:
WebCore.xcodeproj/project.pbxproj:
bindings/js/JSMutationCallback.cpp: Removed.
bindings/js/JSMutationCallback.h: Removed.

Remove custom JSMutationCallback.h/cpp

Modules/geolocation/PositionCallback.h:
Modules/geolocation/PositionErrorCallback.h:
Modules/notifications/NotificationPermissionCallback.h:
Modules/webaudio/AudioBufferCallback.h:
Modules/webdatabase/DatabaseCallback.h:
Modules/webdatabase/SQLStatementCallback.h:
Modules/webdatabase/SQLStatementErrorCallback.h:
Modules/webdatabase/SQLTransactionCallback.h:
Modules/webdatabase/SQLTransactionErrorCallback.h:
css/MediaQueryListListener.h:
dom/NodeFilter.h:
dom/RequestAnimationFrameCallback.h:
dom/StringCallback.h:
fileapi/BlobCallback.h:
html/VoidCallback.h:
page/IntersectionObserverCallback.h:
page/PerformanceObserverCallback.h:

Add ActiveDOMCallback as a base class. Import the ActiveDOMCallback constructor.

Modules/mediastream/MediaDevicesRequest.cpp:

(WebCore::MediaDevicesRequest::filterDeviceList):
(WebCore::MediaDevicesRequest::start):

Modules/mediastream/MediaDevicesRequest.h:

Change filterDeviceList to take a Vector of Refs.

bindings/IDLTypes.h:

Add InnerParameterType and NullableInnerParameterType type hooks
and specialize wrappers to use Ref for InnerParameterType, and RefPtr
for NullableInnerParameterType.

bindings/js/JSCallbackData.cpp:
bindings/js/JSCallbackData.h:

Add support for passing a this object and give JSCallbackDataWeak a visitJSFunction
to allow marking the underlying function.

bindings/js/JSMutationObserverCustom.cpp:

(WebCore::JSMutationObserver::visitAdditionalChildren):
(WebCore::constructJSMutationObserver): Deleted.
Remove the custom constructor and replace it with a custom visitAdditionalChildren
that calls the new ActiveDOMObject's visitJSFunction.

bindings/scripts/CodeGenerator.pm:

(ParseType):
Add helper to parse a type and cache the result.

bindings/scripts/CodeGeneratorJS.pm:

(GenerateCallbackHeaderContent):
(GenerateCallbackImplementationContent):
(GetJSCallbackDataType): Deleted.

Add support for [CallbackThisObject]. When [CallbackThisObject] is not specified, use jsUndefined() as the this object as specified by WebIDL.
Stop inheriting from ActiveDOMCallback now that callbacks need to do this themselves.
Add a visitJSFunction override for weak callback functions which calls into the callback data.

bindings/scripts/IDLAttributes.json:

Add [CallbackThisObject].

bindings/scripts/IDLParser.pm:

(ParseType):
Add entry point to parse a single type.

css/FontFaceSet.h:

Use Ref rather than RefPtr for the faces sequence.

dom/ActiveDOMCallback.h:

(WebCore::ActiveDOMCallback::visitJSFunction):
Add an optional visitJSFunction virtual function so that derived classes
have a way of marking underlying function objects.

dom/MutationCallback.h:

Convert to support generation (return a CallbackResult, inherit from ActiveDOMObject).

dom/MutationCallback.idl: Added.

Added to generate the callback. Uses the new [CallbackThisObject].

dom/MutationObserver.cpp:

(WebCore::MutationObserver::deliver):
Switch to call idiomatic handleEvent, and pass *this as the first parameter
which will be translated into the this object.

dom/MutationObserver.h:

(WebCore::MutationObserver::callback):
Expose the callback so it can marked during GC.

dom/MutationObserver.idl:

Remove CustomConstructor and replace it with a custom mark function.

dom/NativeNodeFilter.cpp:
dom/NativeNodeFilter.h:
inspector/InspectorDatabaseAgent.cpp:

Pass now needed ScriptExecutionContext to non-js based callbacks.

bindings/scripts/test/JS/JSTestCallbackFunction.cpp:
bindings/scripts/test/JS/JSTestCallbackFunctionRethrow.cpp:
bindings/scripts/test/JS/JSTestCallbackFunctionWithThisObject.cpp: Added.
bindings/scripts/test/JS/JSTestCallbackFunctionWithThisObject.h: Added.
bindings/scripts/test/JS/JSTestCallbackFunctionWithTypedefs.cpp:
bindings/scripts/test/JS/JSTestCallbackInterface.cpp:
bindings/scripts/test/JS/JSTestCallbackInterface.h:
bindings/scripts/test/JS/JSTestVoidCallbackFunction.cpp:
bindings/scripts/test/TestCallbackFunctionWithThisObject.idl: Added.
bindings/scripts/test/TestCallbackInterface.idl:

Add/update tests.

Source/WebKit:
[WebIDL] Convert MutationCallback to be a normal generated callback
https://bugs.webkit.org/show_bug.cgi?id=174140

Reviewed by Darin Adler.

WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMDocument.cpp:
WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMNodeFilter.cpp:
WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMNodeFilterPrivate.h:

Pass, now necessary, Document to NativeNodeFilter constructor.

Source/WebKitLegacy/mac:
[WebIDL] Convert MutationCallback to be a normal generated callback
https://bugs.webkit.org/show_bug.cgi?id=174140

Reviewed by Darin Adler.

DOM/DOMDocument.mm:

(-[DOMDocument createNodeIterator:whatToShow:filter:expandEntityReferences:]):
(-[DOMDocument createTreeWalker:whatToShow:filter:expandEntityReferences:]):
Pass, now necessary, Document to NativeNodeFilter constructor.

LayoutTests:
[WebIDL] Convert MutationCallback to be a normal generate callback
https://bugs.webkit.org/show_bug.cgi?id=174140

Reviewed by Darin Adler.

fast/dom/MutationObserver/mutation-observer-constructor-expected.txt:

Update results for standard error messages.

10:37 AM Changeset in webkit [220209] by commit-queue@webkit.org

6 edits in trunk/Source

Use MPAVRoutingController instead of deprecated versions.
https://bugs.webkit.org/show_bug.cgi?id=175063
Source/WebCore:

Patch by Jeremy Jones <jeremyj@apple.com> on 2017-08-03
Reviewed by Tim Horton.

No new tests because no behavior change. This uses a different platform class to present
an interface.

Remove deprecated MPAudioVideoRoutingPopoverController and MPAVRoutingSheet
Add MPMediaControlsViewController.

platform/spi/ios/MediaPlayerSPI.h:

Source/WebKit:

rdar://problem/33301230

Patch by Jeremy Jones <jeremyj@apple.com> on 2017-08-03
Reviewed by Tim Horton.

Remove dependence on deprecated classes MPAVRoutingSheet and MPAudioVideoRoutingPopoverController.

UIProcess/ios/forms/WKAirPlayRoutePicker.h:
UIProcess/ios/forms/WKAirPlayRoutePicker.mm:

(-[WKAirPlayRoutePicker dealloc]):
(-[WKAirPlayRoutePicker show:fromRect:]):
(-[WKAirPlayRoutePicker popoverControllerDidDismissPopover:]): Deleted.
(-[WKAirPlayRoutePicker _presentAirPlayPopoverAnimated:fromRect:]): Deleted.
(-[WKAirPlayRoutePicker _windowWillRotate:]): Deleted.
(-[WKAirPlayRoutePicker _windowDidRotate:]): Deleted.
(-[WKAirPlayRoutePicker _dismissAirPlayRoutePickerIPad]): Deleted.
(-[WKAirPlayRoutePicker showAirPlayPickerIPad:fromRect:]): Deleted.
(-[WKAirPlayRoutePicker showAirPlayPickerIPhone:]): Deleted.

10:19 AM Changeset in webkit [220208] by Chris Dumez

29 edits
31 adds in trunk

Improve our support for referrer policies
https://bugs.webkit.org/show_bug.cgi?id=175069
<rdar://problem/33677313>

Reviewed by Darin Adler.

LayoutTests/imported/w3c:

Rebaseline several WPT tests now that more checks are passing.

web-platform-tests/beacon/headers/header-referrer-origin-when-cross-origin-expected.txt:
web-platform-tests/beacon/headers/header-referrer-same-origin-expected.txt:
web-platform-tests/beacon/headers/header-referrer-strict-origin-when-cross-origin.https-expected.txt:
web-platform-tests/beacon/headers/header-referrer-strict-origin.https-expected.txt:
web-platform-tests/beacon/headers/header-referrer-unsafe-url.https-expected.txt:
web-platform-tests/fetch/api/redirect/redirect-referrer-expected.txt:
web-platform-tests/fetch/api/redirect/redirect-referrer-worker-expected.txt:
web-platform-tests/fetch/api/request/request-init-001.sub-expected.txt:

Source/WebCore:

Improve our support for referrer policies. In particular, we now support the
additional following ones: "same-origin", "origin-when-cross-origin" and
"strict-origin-when-cross-origin".

This is as per the following specification:

https://www.w3.org/TR/referrer-policy/#referrer-policies

Also refactor the code a bit for clarity: I merged the ReferrerPolicy enum and the
FetchOptions::ReferrerPolicy one.

Tests: http/tests/referrer-policy/origin-when-cross-origin/cross-origin-http-http.html

http/tests/referrer-policy/origin-when-cross-origin/cross-origin-http.https.html
http/tests/referrer-policy/origin-when-cross-origin/same-origin.html
http/tests/referrer-policy/same-origin/cross-origin-http-http.html
http/tests/referrer-policy/same-origin/cross-origin-http.https.html
http/tests/referrer-policy/same-origin/same-origin.html
http/tests/referrer-policy/strict-origin-when-cross-origin/cross-origin-http-http.html
http/tests/referrer-policy/strict-origin-when-cross-origin/cross-origin-http.https.html
http/tests/referrer-policy/strict-origin-when-cross-origin/same-origin.html
http/tests/referrer-policy/strict-origin/cross-origin-http-http.html
http/tests/referrer-policy/strict-origin/cross-origin-http.https.html
http/tests/referrer-policy/strict-origin/same-origin.html

Modules/fetch/FetchLoader.cpp:

(WebCore::FetchLoader::start):

Modules/fetch/FetchReferrerPolicy.h:
Modules/fetch/FetchReferrerPolicy.idl:
Modules/fetch/FetchRequest.h:
Modules/fetch/FetchRequestInit.h:
dom/Document.cpp:

(WebCore::Document::processReferrerPolicy):
(WebCore::Document::applyQuickLookSandbox):
(WebCore::Document::applyContentDispositionAttachmentSandbox):

dom/Document.h:
loader/FetchOptions.h:
loader/FrameNetworkingContext.h:
loader/PingLoader.cpp:

(WebCore::PingLoader::sendBeacon):
Drop explicit call to SecurityPolicy::shouldHideReferrer(). This is already called inside
SecurityPolicy::generateReferrerHeader() and used only when needed, depending on the
actual referrer policy.

loader/cache/CachedResourceLoader.cpp:

(WebCore::CachedResourceLoader::updateHTTPRequestHeaders):

loader/cache/CachedResourceRequest.cpp:

(WebCore::CachedResourceRequest::updateReferrerOriginAndUserAgentHeaders):

page/SecurityPolicy.cpp:

(WebCore::referrerToOriginString):
(WebCore::SecurityPolicy::generateReferrerHeader):

page/SecurityPolicy.h:
platform/ReferrerPolicy.h:

Source/WebKit:

WebProcess/Network/WebLoaderStrategy.cpp:

(WebKit::WebLoaderStrategy::loadResource):
(WebKit::WebLoaderStrategy::schedulePluginStreamLoad):

LayoutTests:

http/tests/referrer-policy/origin-when-cross-origin/cross-origin-http-http-expected.txt: Added.
http/tests/referrer-policy/origin-when-cross-origin/cross-origin-http-http.html: Added.
http/tests/referrer-policy/origin-when-cross-origin/cross-origin-http.https-expected.txt: Added.
http/tests/referrer-policy/origin-when-cross-origin/cross-origin-http.https.html: Added.
http/tests/referrer-policy/origin-when-cross-origin/same-origin-expected.txt: Added.
http/tests/referrer-policy/origin-when-cross-origin/same-origin.html: Added.
http/tests/referrer-policy/resources/document.html: Added.
http/tests/referrer-policy/same-origin/cross-origin-http-http-expected.txt: Added.
http/tests/referrer-policy/same-origin/cross-origin-http-http.html: Added.
http/tests/referrer-policy/same-origin/cross-origin-http.https-expected.txt: Added.
http/tests/referrer-policy/same-origin/cross-origin-http.https.html: Added.
http/tests/referrer-policy/same-origin/same-origin-expected.txt: Added.
http/tests/referrer-policy/same-origin/same-origin.html: Added.
http/tests/referrer-policy/strict-origin-when-cross-origin/cross-origin-http-http-expected.txt: Added.
http/tests/referrer-policy/strict-origin-when-cross-origin/cross-origin-http-http.html: Added.
http/tests/referrer-policy/strict-origin-when-cross-origin/cross-origin-http.https-expected.txt: Added.
http/tests/referrer-policy/strict-origin-when-cross-origin/cross-origin-http.https.html: Added.
http/tests/referrer-policy/strict-origin-when-cross-origin/same-origin-expected.txt: Added.
http/tests/referrer-policy/strict-origin-when-cross-origin/same-origin.html: Added.
http/tests/referrer-policy/strict-origin/cross-origin-http-http-expected.txt: Added.
http/tests/referrer-policy/strict-origin/cross-origin-http-http.html: Added.
http/tests/referrer-policy/strict-origin/cross-origin-http.https-expected.txt: Added.
http/tests/referrer-policy/strict-origin/cross-origin-http.https.html: Added.
http/tests/referrer-policy/strict-origin/same-origin-expected.txt: Added.
http/tests/referrer-policy/strict-origin/same-origin.html: Added.

Add layout test coverage.

http/tests/security/referrer-policy-invalid-expected.txt:

Rebaseline test now that console message has changed.

9:16 AM Changeset in webkit [220207] by dbates@webkit.org

11 edits
12 adds in trunk

Support ::marker pseudo-element
https://bugs.webkit.org/show_bug.cgi?id=141477

Reviewed by David Hyatt.

Source/WebCore:

Implements the ::marker pseudo element as per the CSS Pseudo-Element Module Level 4
spec., <https://drafts.csswg.org/css-pseudo-4> (Editor's Draft, 24 July 2017).

The ::marker pseudo element is a convenience pseudo element that allows a person to
style the appearance of a list item marker. For example, to render all list item
markers in bolded, blue text you would define a stylesheet with the following content:

li::marker {

color: blue;
font-weight: bold;

}

and this could be applied to a page that contains markup of the form:

<ol>

<li>Item 1</li>
<li>Item 2</li>
...
<li>Item N-1</li>
<li>Item N</li>

</ol>

Formerly to the achieve the same effect you would need to use a stylesheet of the form:

li {

color: blue;
font-weight: bold;

}

.list-item-content {

all: initial;

}

and then write your markup to have the form:

<ol>

<li>Item 1</li>
<li>Item 2</li>
...
<li>Item N-1</li>
<li>Item N</li>

</ol>

The ::marker pseudo element only supports stylizing all font properties and the color property
of a list item marker.

Tests: fast/lists/list-marker-with-display.html

http/wpt/css/css-pseudo-4/marker-and-other-pseudo-elements.html
http/wpt/css/css-pseudo-4/marker-color.html
http/wpt/css/css-pseudo-4/marker-font-properties.html
http/wpt/css/css-pseudo-4/marker-inherit-values.html

css/CSSSelector.cpp:

(WebCore::CSSSelector::pseudoId): Return the pseudo id for the ::marker pseudo element.

css/CSSSelector.h: Add enumerator PseudoElementMarker to the pseudo element enum.
css/RuleSet.cpp:

(WebCore::determinePropertyWhitelistType): Return whitelist type PropertyWhitelistMarker for ::marker
so that we match rules against the acceptable rules for ::marker.

css/RuleSet.h: Add enumerator PropertyWhitelistMarker to the property whitelist type enum.
css/SelectorPseudoElementTypeMap.in: Add "marker" to the list of pseudo element types.
css/StyleResolver.cpp:

(WebCore::isValidMarkerStyleProperty): Determines if the specified CSS property is valid inside ::marker.
(WebCore::StyleResolver::CascadedProperties::addMatch): Only recognize CSS properties in the content block
of ::marker that match the ::marker whitelist policy.

rendering/RenderListItem.cpp:

(WebCore::RenderListItem::computeMarkerStyle): Computes the style object for the list item marker. We
apply the user-agent style to the marker here as opposed to defining ::marker in the UA sheet as per
the spec. as an optimization to avoid having the style resolver apply the pseudo element to all elements.
For now, we always inherit style from the originating element (list item). Added FIXME to selectively
inherit styles.
(WebCore::RenderListItem::styleDidChange): Always apply the list marker style to the list marker renderer.

rendering/RenderListItem.h:
rendering/style/RenderStyleConstants.h: Add pseudo ID for the ::marker pseudo element.

LayoutTests:

Add tests that check we respect ::marker when rendering the list item marker. I will
submit all the tests in http/wpt/css/css-pseudo-4 to the Web Platform Tests repository
shortly and then import them into the WebKit repository in a subsequent commit.

fast/lists/list-marker-with-display-expected.html: Added.
fast/lists/list-marker-with-display.html: Added.
http/wpt/css/css-pseudo-4/marker-and-other-pseudo-elements-expected.html: Added.
http/wpt/css/css-pseudo-4/marker-and-other-pseudo-elements.html: Added.
http/wpt/css/css-pseudo-4/marker-color-expected.html: Added.
http/wpt/css/css-pseudo-4/marker-color.html: Added.
http/wpt/css/css-pseudo-4/marker-font-properties-expected.html: Added.
http/wpt/css/css-pseudo-4/marker-font-properties.html: Added.
http/wpt/css/css-pseudo-4/marker-inherit-values-expected.html: Added.
http/wpt/css/css-pseudo-4/marker-inherit-values.html: Added.

9:01 AM Changeset in webkit [220206] by pvollan@apple.com

2 edits in trunk/Tools

[Win] The test http/tests/security/contentSecurityPolicy/upgrade-insecure-requests/basic-upgrade.https.html is failing.
https://bugs.webkit.org/show_bug.cgi?id=159510

Reviewed by Daniel Bates.

Allow any https certificate when running tests.

DumpRenderTree/win/DumpRenderTree.cpp:

(runTest):

7:47 AM Changeset in webkit [220205] by pvollan@apple.com

2 edits in trunk/Source/WebKitLegacy

[Win] WebKit COM header file is not placed in the correct location.
https://bugs.webkit.org/show_bug.cgi?id=175101

Reviewed by Brent Fulgham.

After the transition to WebKitLegacy, the generated WebKit header files should still
be placed in the WebKit folder, so WebKit clients will find the header files in the
same place.

WebKitLegacy.vcxproj/WebKitLegacy.proj:

7:45 AM Changeset in webkit [220204] by Antti Koivisto

5 edits
1 add in trunk/Source/WebCore

Factor common code in Style::*ChangeInvalidation into helper functions
https://bugs.webkit.org/show_bug.cgi?id=174312

Reviewed by Andreas Kling.

There is a lot of copy code here.

Style/StyleInvalidationFunctions.h: Added.

(WebCore::Style::traverseRuleFeaturesInShadowTree):
(WebCore::Style::traverseRuleFeaturesForSlotted):
(WebCore::Style::traverseRuleFeatures):

Add functions for traversing rule features that may affect style of an element.
Use lambdas to implement client-specific behavior.

WebCore.xcodeproj/project.pbxproj:
style/AttributeChangeInvalidation.cpp:

(WebCore::Style::mayBeAffectedByAttributeChange):
(WebCore::Style::AttributeChangeInvalidation::invalidateStyle):
(WebCore::Style::mayBeAffectedByHostRules): Deleted.
(WebCore::Style::mayBeAffectedBySlottedRules): Deleted.

style/ClassChangeInvalidation.cpp:

(WebCore::Style::ClassChangeInvalidation::invalidateStyle):
(WebCore::Style::mayBeAffectedByHostRules): Deleted.
(WebCore::Style::mayBeAffectedBySlottedRules): Deleted.

style/IdChangeInvalidation.cpp:

(WebCore::Style::IdChangeInvalidation::invalidateStyle):
(WebCore::Style::mayBeAffectedByHostRules): Deleted.
(WebCore::Style::mayBeAffectedBySlottedRules): Deleted.

7:40 AM Changeset in webkit [220203] by zandobersek@gmail.com

2 edits in trunk/Source/WebCore

[EME] CDM constructor assigns CDMPrivate member multiple times
https://bugs.webkit.org/show_bug.cgi?id=175128

Reviewed by Xabier Rodriguez-Calvar.

In the CDM class constructor, iterate over the registered CDM
factories, finding one that supports the specified key system.
A CDMPrivate object is created through that factory, and the
iteration is now stopped at that point, while previously it
contined to potentially create CDMPrivate objects through
other factories.

Helper createCDMPrivateForKeySystem() function is removed.

Modules/encryptedmedia/CDM.cpp:

(WebCore::CDM::CDM):
(WebCore::createCDMPrivateForKeySystem): Deleted.

6:20 AM Changeset in webkit [220202] by commit-queue@webkit.org

5 edits in trunk/Source/WebCore

Don't always recalc the style of display: contents elements.
https://bugs.webkit.org/show_bug.cgi?id=172753

Patch by Emilio Cobos Álvarez <ecobos@igalia.com> on 2017-08-03
Reviewed by Antti Koivisto.

No new tests (no functionality change). This only removes an
inefficiency.

dom/Element.cpp:

(WebCore::Element::existingComputedStyle):

dom/Element.h:
style/RenderTreeUpdater.cpp:

(WebCore::RenderTreeUpdater::updateRenderTree):
(WebCore::RenderTreeUpdater::updateElementRenderer):

style/StyleTreeResolver.cpp:

(WebCore::Style::renderOrDisplayContentsStyle):
(WebCore::Style::TreeResolver::resolveElement):
(WebCore::Style::TreeResolver::createAnimatedElementUpdate):
(WebCore::Style::shouldResolveElement):
(WebCore::Style::TreeResolver::resolveComposedTree):

4:17 AM Changeset in webkit [220201] by Yusuke Suzuki

4 edits in trunk/Source/WTF

[Linux][WTF] Use one global semaphore to notify thread suspend and resume completion
https://bugs.webkit.org/show_bug.cgi?id=175124

Reviewed by Carlos Garcia Campos.

POSIX sem_t is used to notify thread suspend and resume completion in Linux ports
since sem_post is async-signal-safe function. Since we guard suspend() and resume()
with one global lock, this semaphore is also guarded by this lock. So we do not need
to have semaphore per WTF::Thread.

This patch introduces one global Semaphore. And drop per thread semaphore.

wtf/Threading.h:
wtf/ThreadingPthreads.cpp:

(WTF::Thread::~Thread):
(WTF::Semaphore::Semaphore):
(WTF::Semaphore::~Semaphore):
(WTF::Semaphore::wait):
(WTF::Semaphore::post):
(WTF::Thread::signalHandlerSuspendResume):
(WTF::Thread::initializePlatformThreading):
(WTF::Thread::suspend):
(WTF::Thread::resume):
(WTF::Thread::Thread): Deleted.

wtf/ThreadingWin.cpp:

(WTF::Thread::Thread): Deleted.

3:03 AM Changeset in webkit [220200] by commit-queue@webkit.org

2 edits in trunk/LayoutTests

[GTK] Remove obsolete failure expectation for narrow-non-breaking-space.html.
https://bugs.webkit.org/show_bug.cgi?id=139493

Unreviewed test gardening.

It likely started passing in r205826 due to its change in Font.cpp.

Patch by Ms2ger <Ms2ger@igalia.com> on 2017-08-03

platform/gtk/TestExpectations:

2:33 AM Changeset in webkit [220199] by commit-queue@webkit.org

2 edits in trunk/LayoutTests

[GTK] Skip timezone-dependent Sputnik tests.
https://bugs.webkit.org/show_bug.cgi?id=175120

Unreviewed test gardening.

These tests are skipped in the platform-neutral TestExpectations file because
they only pass in Pacific Time (see bug 42625). There doesn't seem to be a
reason for gtk to run them, and they do pass on the buildbot.

Patch by Ms2ger <Ms2ger@igalia.com> on 2017-08-03

platform/gtk/TestExpectations:

1:53 AM Changeset in webkit [220198] by Yusuke Suzuki

3 edits in trunk/Source/WTF

[Linux][WTF] Reduce sizeof(WTF::Thread) by using a pointer to PlatformRegisters
https://bugs.webkit.org/show_bug.cgi?id=175119

Reviewed by Carlos Garcia Campos.

sizeof(PlatformRegisters) is so large. In my Linux box, it is 256. It enlarges the sizeof(WTF::Thread).
However, it is not necessary to hold it in WTF::Thread member. Thread's ucontext data and its stack is
effective while suspending the thread. So, we can just use the pointer to the PlatformRegister instead
of copying it to the member of the WTF::Thread.

wtf/Threading.h:
wtf/ThreadingPthreads.cpp:

(WTF::Thread::signalHandlerSuspendResume):
(WTF::Thread::getRegisters):

12:03 AM Changeset in webkit [220197] by jmarcell@apple.com

7 edits in branches/safari-604.1.36-branch/Source

Versioning.

12:01 AM Changeset in webkit [220196] by jmarcell@apple.com

7 edits in tags/Safari-604.1.36/Source

Revert "Versioning."

This reverts commit 47a02c7900432c88ffc054f87447bf2ced2bc7bc.

Aug 2, 2017:

11:44 PM Changeset in webkit [220195] by jmarcell@apple.com

3 edits in branches/safari-604.1.36-branch/Source/JavaScriptCore

Cherry-pick r220144. rdar://problem/33692161

11:44 PM Changeset in webkit [220194] by jmarcell@apple.com

5 edits in branches/safari-604.1.36-branch/Source/WebKit

Cherry-pick r220138. rdar://problem/33692550

11:44 PM Changeset in webkit [220193] by jmarcell@apple.com

5 edits
3 adds in branches/safari-604.1.36-branch

Cherry-pick r220112. rdar://problem/33692164

11:44 PM Changeset in webkit [220192] by jmarcell@apple.com

6 edits in branches/safari-604.1.36-branch/Source/WebCore

Cherry-pick r220085. rdar://problem/33692157

11:43 PM Changeset in webkit [220191] by jmarcell@apple.com

2 edits in branches/safari-604.1.36-branch/Source/WebCore

Cherry-pick r220084. rdar://problem/33692167

11:43 PM Changeset in webkit [220190] by jmarcell@apple.com

3 edits in branches/safari-604.1.36-branch/Source/WebCore

Cherry-pick r220077. rdar://problem/33692157

11:43 PM Changeset in webkit [220189] by jmarcell@apple.com

4 edits
2 adds in branches/safari-604.1.36-branch

Cherry-pick r220035. rdar://problem/33692157

11:18 PM Changeset in webkit [220188] by Devin Rousso

20 edits
1 copy
1 add in trunk

Web Inspector: add stack trace information for each RecordingAction
https://bugs.webkit.org/show_bug.cgi?id=174663

Reviewed by Joseph Pecoraro.

Source/JavaScriptCore:

inspector/ScriptCallFrame.h:

Add operator== so that when a ScriptCallFrame object is held in a Vector, calling find
with an existing value doesn't need require a functor and can use existing code.

interpreter/StackVisitor.h:
interpreter/StackVisitor.cpp:

(JSC::StackVisitor::Frame::isWasmFrame const): Inlined in header.

Source/WebCore:

Tests: inspector/canvas/recording-2d.html

inspector/model/recording.html

inspector/InspectorCanvas.h:
inspector/InspectorCanvas.cpp:

(WebCore::InspectorCanvas::indexForData):
(WebCore::InspectorCanvas::buildAction):

Source/WebInspectorUI:

Localizations/en.lproj/localizedStrings.js:
UserInterface/Main.html:

UserInterface/Models/Recording.js:

(WI.Recording.prototype.swizzle):
Add Array type for swizzling array values.

UserInterface/Models/RecordingAction.js:

(WI.RecordingAction):
(WI.RecordingAction.fromPayload):
(WI.RecordingAction.prototype.get trace):
(WI.RecordingAction.prototype.swizzle):
(WI.RecordingAction.prototype.toJSON):

UserInterface/Views/RecordingTraceDetailsSidebarPanel.js: Added.

(WI.RecordingTraceDetailsSidebarPanel):
(WI.RecordingTraceDetailsSidebarPanel.disallowInstanceForClass):
(WI.RecordingTraceDetailsSidebarPanel.prototype.inspect):
(WI.RecordingTraceDetailsSidebarPanel.prototype.set recording):
(WI.RecordingTraceDetailsSidebarPanel.prototype.updateActionIndex):

UserInterface/Views/RecordingTraceDetailsSidebarPanel.css: Added.

(.sidebar > .panel.details.recording-trace > .content > .call-frame):
(.sidebar > .details.recording-trace > .content > .no-trace-data):
(.sidebar > .details.recording-trace > .content > .no-trace-data > .message):

UserInterface/Views/RecordingTabContentView.js:

(WI.RecordingTabContentView):

UserInterface/Views/RecordingActionTreeElement.js:

(WI.RecordingActionTreeElement.prototype.populateContextMenu):

UserInterface/Views/CallFrameView.css:

(.call-frame):
(body[dir=ltr] .call-frame .icon):
(body[dir=rtl] .call-frame .icon):
Apply the same trailing margin for CallFrameView icons as TreeElement.

LayoutTests:

inspector/canvas/recording-2d-expected.txt:
inspector/canvas/recording-2d.html:
inspector/model/recording-expected.txt:
inspector/model/recording.html:

11:16 PM Changeset in webkit [220187] by Yusuke Suzuki

3 edits in trunk/Source/WTF

Unreviewed, build fix for Windows port
https://bugs.webkit.org/show_bug.cgi?id=174716

This ugliness will be fixed in https://bugs.webkit.org/show_bug.cgi?id=175013.

wtf/ThreadHolder.h:
wtf/Threading.h:

11:03 PM Changeset in webkit [220186] by Yusuke Suzuki

40 edits
2 deletes in trunk/Source

Merge WTFThreadData to Thread::current
https://bugs.webkit.org/show_bug.cgi?id=174716

Reviewed by Mark Lam.

Source/JavaScriptCore:

Use Thread::current() instead.

API/JSContext.mm:

(+[JSContext currentContext]):
(+[JSContext currentThis]):
(+[JSContext currentCallee]):
(+[JSContext currentArguments]):
(-[JSContext beginCallbackWithData:calleeValue:thisValue:argumentCount:arguments:]):
(-[JSContext endCallbackWithData:]):

heap/Heap.cpp:

(JSC::Heap::requestCollection):

runtime/Completion.cpp:

(JSC::checkSyntax):
(JSC::checkModuleSyntax):
(JSC::evaluate):
(JSC::loadAndEvaluateModule):
(JSC::loadModule):
(JSC::linkAndEvaluateModule):
(JSC::importModule):

runtime/Identifier.cpp:

(JSC::Identifier::checkCurrentAtomicStringTable):

runtime/InitializeThreading.cpp:

(JSC::initializeThreading):

runtime/JSLock.cpp:

(JSC::JSLock::didAcquireLock):
(JSC::JSLock::willReleaseLock):
(JSC::JSLock::dropAllLocks):
(JSC::JSLock::grabAllLocks):

runtime/JSLock.h:
runtime/VM.cpp:

(JSC::VM::VM):
(JSC::VM::updateStackLimits):
(JSC::VM::committedStackByteCount):

runtime/VM.h:

(JSC::VM::isSafeToRecurse const):

runtime/VMEntryScope.cpp:

(JSC::VMEntryScope::VMEntryScope):

runtime/VMInlines.h:

(JSC::VM::ensureStackCapacityFor):

yarr/YarrPattern.cpp:

(JSC::Yarr::YarrPatternConstructor::isSafeToRecurse const):

Source/WebCore:

Use Thread::current() instead.

fileapi/AsyncFileStream.cpp:
platform/ThreadGlobalData.cpp:

(WebCore::ThreadGlobalData::ThreadGlobalData):

platform/graphics/cocoa/WebCoreDecompressionSession.h:
platform/ios/wak/WebCoreThread.mm:

(StartWebThread):

workers/WorkerThread.cpp:

(WebCore::WorkerThread::workerThread):

Source/WTF:

We placed thread specific data in WTFThreadData previously. But now, we have a new good place
to put thread specific data: WTF::Thread. Before this patch, WTFThreadData and WTF::Thread
sometimes have the completely same fields (m_stack etc.) due to initialization order limitations.
This patch merges WTFThreadData to WTF::Thread. We apply WTFThreadData's initialization style
to WTF::Thread. So, WTF::Thread's holder now uses fast TLS for darwin environment. Thus,
Thread::current() access is now accelerated. And WTF::Thread::current() can be accessed even
before calling WTF::initializeThreading.

WTF.xcodeproj/project.pbxproj:
wtf/CMakeLists.txt:
wtf/LockAlgorithm.h:
wtf/LockAlgorithmInlines.h:
wtf/MainThread.h:
wtf/ParkingLot.cpp:
wtf/StackStats.cpp:

(WTF::StackStats::PerThreadStats::PerThreadStats):
(WTF::StackStats::CheckPoint::CheckPoint):
(WTF::StackStats::CheckPoint::~CheckPoint):
(WTF::StackStats::probe):
(WTF::StackStats::LayoutCheckPoint::LayoutCheckPoint):

wtf/ThreadHolder.cpp:

(WTF::ThreadHolder::initializeCurrent):

wtf/ThreadHolder.h:

(WTF::ThreadHolder::ThreadHolder):
(WTF::ThreadHolder::currentMayBeNull):
(WTF::ThreadHolder::current):

wtf/ThreadHolderPthreads.cpp:

(WTF::ThreadHolder::initializeKey):
(WTF::ThreadHolder::initialize):
(WTF::ThreadHolder::destruct):
(WTF::ThreadHolder::initializeOnce): Deleted.
(WTF::ThreadHolder::current): Deleted.

wtf/ThreadHolderWin.cpp:

(WTF::ThreadHolder::initializeKey):
(WTF::ThreadHolder::currentDying):
(WTF::ThreadHolder::initialize):
(WTF::ThreadHolder::initializeOnce): Deleted.
(WTF::ThreadHolder::current): Deleted.

wtf/Threading.cpp:

(WTF::Thread::initializeInThread):
(WTF::Thread::entryPoint):
(WTF::Thread::create):
(WTF::Thread::didExit):
(WTF::initializeThreading):
(WTF::Thread::currentMayBeNull): Deleted.

wtf/Threading.h:

(WTF::Thread::current):
(WTF::Thread::atomicStringTable):
(WTF::Thread::setCurrentAtomicStringTable):
(WTF::Thread::stackStats):
(WTF::Thread::savedStackPointerAtVMEntry):
(WTF::Thread::setSavedStackPointerAtVMEntry):
(WTF::Thread::savedLastStackTop):
(WTF::Thread::setSavedLastStackTop):

wtf/ThreadingPrimitives.h:
wtf/ThreadingPthreads.cpp:

(WTF::Thread::createCurrentThread):
(WTF::Thread::current): Deleted.

wtf/ThreadingWin.cpp:

(WTF::Thread::createCurrentThread):
(WTF::Thread::current): Deleted.

wtf/WTFThreadData.cpp: Removed.
wtf/WTFThreadData.h: Removed.
wtf/text/AtomicString.cpp:
wtf/text/AtomicStringImpl.cpp:

(WTF::stringTable):

wtf/text/AtomicStringTable.cpp:

(WTF::AtomicStringTable::create):

wtf/text/AtomicStringTable.h:

10:57 PM Changeset in webkit [220185] by Chris Dumez

6 edits in trunk

NetworkResourceLoader::setDefersLoading() may cause start() to be called multiple times
https://bugs.webkit.org/show_bug.cgi?id=175109
<rdar://problem/33363169>

Reviewed by Brady Eidson.

Source/WebKit:

If NetworkResourceLoader::setDefersLoading(false) is called by the client while m_networkLoad is null
then we call NetworkResourceLoader::start() to start the load. This is needed in the case where
a NetworkResourceLoader is constructed in deferred mode so that the load can later be started via
setDefersLoading(). However, it is possible for setDefersLoading(false) to be called when start()
has already been called, which causes start() to be called multiple times and leads to an assertion
hit in debug.

Normally, setDefersLoading(false) returns without calling start() if m_networkLoad is not null. It
relies on m_networkLoad being non-null to determine if start() should be called. This is bad because
start() checks the disk cache asynchronously *before* calling startNetworkLoad() and initializing
m_networkLoad. Therefore, if setDefersLoading(false) is called *while* we are checking the cache,
then we will call incorrectly call start() again.

In the case of the radar, this happens when we:

Call start() and check the disk cache
Retrieve a cached redirect from the cache, which causes a WillSendRequest IPC to be sent to the WebProcess
The WebProcess calls setDefersLoading(true), sends the ContinueWillSendRequest IPC back and then calls setDefersLoading(false)

The call to continueWillSendRequest() causes us to retrieve the redirected entry from the cache,
asynchronously, which will return no entry and start a load.
The later call to setDefersLoading(false) causes us to call start() again and we end up back to step 1.

NetworkProcess/NetworkResourceLoader.cpp:

(WebKit::NetworkResourceLoader::start):
(WebKit::NetworkResourceLoader::setDefersLoading):

NetworkProcess/NetworkResourceLoader.h:

LayoutTests:

Extend test coverage to cover cacheable redirects to a resource that needs
revalidation, similarly to the case in the radar.

http/tests/cache/disk-cache/disk-cache-redirect-expected.txt:
http/tests/cache/disk-cache/disk-cache-redirect.html:

10:48 PM Changeset in webkit [220184] by fpizlo@apple.com

5 edits in trunk/Source/JavaScriptCore

LLInt should do pointer caging
https://bugs.webkit.org/show_bug.cgi?id=175036

Reviewed by Keith Miller.

Implementing this in the LLInt was challenging because offlineasm did not previously know
how to load from globals. This teaches it how to do that on Darwin/x86_64, which happens
to be where the Gigacage is enabled right now.

llint/LLIntOfflineAsmConfig.h:
llint/LowLevelInterpreter64.asm:
offlineasm/ast.rb:
offlineasm/x86.rb:

9:46 PM Changeset in webkit [220183] by commit-queue@webkit.org

2 edits in trunk/Source/WTF

NeverDestroyed related leaks seen on bots
https://bugs.webkit.org/show_bug.cgi?id=175113

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2017-08-02
Reviewed by Yusuke Suzuki.

wtf/NeverDestroyed.h:

(WTF::NeverDestroyed::NeverDestroyed):
Previously the result of makeNeverDestroyed was not always moving into
the static NeverDestroyed static local variable. In some cases it would
re-invoke the constructor, creating a new NeverDestroyed object. In the
case of a Vector it was causing leaks.

Adding a move constructor convinces the compiler to move the result
of makeNeverDestroyed into the NeverDestroyed static. It doesn't actually
invoke the move constructor here, which I believe means it is deciding
to perform optional copy elision optimization.
'http://en.cppreference.com/w/cpp/language/copy_elision

9:40 PM Changeset in webkit [220182] by jmarcell@apple.com

7 edits in tags/Safari-604.1.36/Source

Versioning.

9:25 PM Changeset in webkit [220181] by jmarcell@apple.com

1 copy in branches/safari-604.1.36-branch

New branch.

9:21 PM Changeset in webkit [220180] by Devin Rousso

4 edits in trunk/Source/WebInspectorUI

Web Inspector: add TreeElement virtualization for the Recording tab
https://bugs.webkit.org/show_bug.cgi?id=174968

Reviewed by Joseph Pecoraro.

UserInterface/Views/RecordingNavigationSidebarPanel.js:

(WI.RecordingNavigationSidebarPanel):

UserInterface/Views/TreeOutline.js:

(WI.TreeOutline):
(WI.TreeOutline.prototype.get virtualized):
(WI.TreeOutline.prototype.registerScrollVirtualizer):
(WI.TreeOutline.prototype.updateVirtualizedElements.walk):
(WI.TreeOutline.prototype.updateVirtualizedElements):
Add spacer elements before and after the TreeOutline element that will size to ensure that
the TreeOutline node still takes up the same amount of space after some of the TreeElements
are removed. Whenever the scroll of the container view changes, recalculate the visible area
and add/remove TreeElements based on whether they would be in that. This is only possible if
every TreeElement has the same vertical height, which is given when setting up the scroll
listener on the container view.

UserInterface/Views/TreeElement.js:

(WI.TreeElement.prototype.set hidden):
(WI.TreeElement.prototype._attach):
(WI.TreeElement.prototype.collapse):
(WI.TreeElement.prototype.expand):
(WI.TreeElement.prototype.reveal):
If the TreeOutline is being virtualized, don't add each TreeElement's node to the DOM. They
will be added at the end of the frame (via setTimeout) if they are within the visible + padding
area of the TreeOutline.

9:19 PM Changeset in webkit [220179] by commit-queue@webkit.org

5 edits
2 deletes in trunk

HTTP tests with 'https' suffix are only run over HTTPS for WK2, not WK1
https://bugs.webkit.org/show_bug.cgi?id=175089

Patch by Youenn Fablet <youenn@apple.com> on 2017-08-02
Reviewed by Chris Dumez.

Tools:

DumpRenderTree/TestOptions.mm:

(TestOptions::TestOptions): Using absolutePath if available.

DumpRenderTree/mac/DumpRenderTree.mm:

(computeTestURL): Removing http/tests/ specific URL computation.

Scripts/webkitpy/port/driver.py:

(Driver._command_from_driver_input): Making webkitpy passing HTTP urls for HTTP served tests to all test runners, including WK1.

LayoutTests:

Removing no longer needed expectations.

platform/ios-wk1/http/tests/security/contentSecurityPolicy/upgrade-insecure-requests/iframe-upgrade.https-expected.txt: Removed.
platform/mac-wk1/http/tests/security/contentSecurityPolicy/upgrade-insecure-requests/iframe-upgrade.https-expected.txt: Removed.

8:53 PM Changeset in webkit [220178] by akling@apple.com

2 edits in trunk/Source/WebKit

NetworkRTCProvider::createResolver() leaks CFHost objects
https://bugs.webkit.org/show_bug.cgi?id=175103
<rdar://problem/33690347>

Reviewed by Youenn Fablet.

Add a missing adoptCF() so we don't leak the CFHost.

NetworkProcess/webrtc/NetworkRTCProvider.cpp:

(WebKit::NetworkRTCProvider::createResolver):

8:49 PM Changeset in webkit [220177] by commit-queue@webkit.org

4 edits in trunk/Source/WebCore

Fix crashes in GC creating a document fragment on a background thread
https://bugs.webkit.org/show_bug.cgi?id=175111

Patch by Sam Weinig <sam@webkit.org> on 2017-08-02
Reviewed by Chris Dumez.

r220095 (https://webkit.org/b/175006) change JSHTMLTemplateElement from using a
private name + property to manager the lifetime of the reference DocumentFragment
to using the idiomatic visitAdditionalChildren. Unfortunately, the function to access
the DocumentFragment lazily creates it. If this lazy creation happens on a GC thread,
badness ensues. This introduces an accessor that returns the DocumentFragment if it
has been created or null if it has not.

bindings/js/JSHTMLTemplateElementCustom.cpp:

(WebCore::JSHTMLTemplateElement::visitAdditionalChildren):

html/HTMLTemplateElement.cpp:

(WebCore::HTMLTemplateElement::contentIfAvailable):

html/HTMLTemplateElement.h:

8:25 PM Changeset in webkit [220176] by commit-queue@webkit.org

5 edits in trunk/Source/WebCore

[WebIDL] Simplify [EnabledBySettings] extended attribute code to not require passing a global object to finishCreation
https://bugs.webkit.org/show_bug.cgi?id=175087

Patch by Sam Weinig <sam@webkit.org> on 2017-08-02
Reviewed by Chris Dumez.

bindings/scripts/CodeGeneratorJS.pm:

(GenerateImplementation):
(GeneratePrototypeDeclaration):
Remove unnecessary passing of the global object to finishCreation for [EnabledBySettings].

bindings/scripts/test/JS/JSTestGenerateIsReachable.cpp:
bindings/scripts/test/JS/JSTestNode.cpp:
bindings/scripts/test/JS/JSTestObj.cpp:

Update tests.

6:57 PM Changeset in webkit [220175] by fpizlo@apple.com

2 edits in trunk/Source/JavaScriptCore

Sweeping should only scribble when sweeping to free list
https://bugs.webkit.org/show_bug.cgi?id=175105

Reviewed by Saam Barati.

I just saw a crash on the bots where a destructor call attempt dereferenced scribbled memory. This
can happen because the bump path of specializedSweep will scribble in SweepOnly, which replaces the
zap word (i.e. 0) with the scribble word (i.e. 0xbadbeef0). This is a recent regression, since we
didn't used to do destruction on the bump path. No destruction, no zapping. Looking at the pop
path, we only scribble when we SweepToFreeList. This ensures that we only overwrite the zap word
when it doesn't matter anyway because we're building a free list.

This is a fix for those crashes on the bots because it means that we'll no longer scribble over the
zap.

heap/MarkedBlockInlines.h:

(JSC::MarkedBlock::Handle::specializedSweep):

6:55 PM Changeset in webkit [220174] by Matt Lewis

2 edits in trunk/LayoutTests

Marked http/tests/appcache/deferred-events-delete-while-raising-timer.html as flaky.
https://bugs.webkit.org/show_bug.cgi?id=175107

Unreviewed test gardening.

TestExpectations:

6:42 PM Changeset in webkit [220173] by clopez@igalia.com

2 edits in trunk/JSTests

[Linux] JSTests/wasm/stress/oom.js should not run on Linux
https://bugs.webkit.org/show_bug.cgi?id=175100

Reviewed by Mark Lam.

The JSC test JSTests/wasm/stress/oom.js tries to use all the
available memory until an out of memory exception happens.

The Linux kernel is more tuned for server workloads than for GUI
responsiveness. When a process tries to use a lot of memory, Linux
will do its best to serve the request. This usually translates to
free physical RAM by writing to disk dirty pages and/or moving out
less recently used pages to swap (disk storage).
Meanwhile it does this, the system will become unresponsive and this
leads to freezes that can last even some minutes on the worst cases.

Therefore, let's skip this test on Linux as it will cause more harm
than good on the Linux bots or on the machines of Linux developers.

wasm/stress/oom.js:

6:33 PM Changeset in webkit [220172] by jmarcell@apple.com

3 edits in branches/safari-604-branch/Source/JavaScriptCore

Cherry-pick r220144. rdar://problem/33687404

6:33 PM Changeset in webkit [220171] by jmarcell@apple.com

5 edits
3 adds in branches/safari-604-branch

Cherry-pick r220112. rdar://problem/33687415

6:33 PM Changeset in webkit [220170] by jmarcell@apple.com

6 edits in branches/safari-604-branch/Source/WebCore

Cherry-pick r220085. rdar://problem/33687398

6:33 PM Changeset in webkit [220169] by jmarcell@apple.com

2 edits in branches/safari-604-branch/Source/WebCore

Cherry-pick r220084. rdar://problem/33687425

6:33 PM Changeset in webkit [220168] by jmarcell@apple.com

3 edits in branches/safari-604-branch/Source/WebCore

Cherry-pick r220077. rdar://problem/33687398

6:32 PM Changeset in webkit [220167] by jmarcell@apple.com

4 edits
2 adds in branches/safari-604-branch

Cherry-pick r220035. rdar://problem/33687398

6:32 PM Changeset in webkit [220166] by Lucas Forschler

2 edits in trunk/Tools

6:32 PM Changeset in webkit [220165] by fpizlo@apple.com

8 edits
1 add in trunk/Source

All C++ accesses to JSObject::m_butterfly should do caging
https://bugs.webkit.org/show_bug.cgi?id=175039

Reviewed by Keith Miller.

Source/JavaScriptCore:

Makes JSObject::m_butterfly a AuxiliaryBarrier<CagedPtr<Butterfly>> and adopts the CagedPtr<> API.
This ensures that you can't cause C++ code to access a butterfly that has been rewired to point
outside the gigacage.

runtime/JSArray.cpp:

(JSC::JSArray::setLength):
(JSC::JSArray::pop):
(JSC::JSArray::push):
(JSC::JSArray::shiftCountWithAnyIndexingType):
(JSC::JSArray::unshiftCountWithAnyIndexingType):
(JSC::JSArray::fillArgList):
(JSC::JSArray::copyToArguments):

runtime/JSObject.cpp:

(JSC::JSObject::heapSnapshot):
(JSC::JSObject::createInitialIndexedStorage):
(JSC::JSObject::createArrayStorage):
(JSC::JSObject::convertUndecidedToInt32):
(JSC::JSObject::convertUndecidedToDouble):
(JSC::JSObject::convertUndecidedToContiguous):
(JSC::JSObject::convertInt32ToDouble):
(JSC::JSObject::convertInt32ToArrayStorage):
(JSC::JSObject::convertDoubleToContiguous):
(JSC::JSObject::convertDoubleToArrayStorage):
(JSC::JSObject::convertContiguousToArrayStorage):
(JSC::JSObject::defineOwnIndexedProperty):
(JSC::JSObject::putByIndexBeyondVectorLengthWithoutAttributes):
(JSC::JSObject::ensureLengthSlow):
(JSC::JSObject::allocateMoreOutOfLineStorage):

runtime/JSObject.h:

(JSC::JSObject::canGetIndexQuickly):
(JSC::JSObject::getIndexQuickly):
(JSC::JSObject::tryGetIndexQuickly const):
(JSC::JSObject::canSetIndexQuickly):
(JSC::JSObject::setIndexQuickly):
(JSC::JSObject::initializeIndex):
(JSC::JSObject::initializeIndexWithoutBarrier):
(JSC::JSObject::butterfly const):
(JSC::JSObject::butterfly):

Source/WTF:

Adds a smart pointer class that does various kinds of caging for you.

WTF.xcodeproj/project.pbxproj:
wtf/CMakeLists.txt:
wtf/CagedPtr.h: Added.

(WTF::CagedPtr::CagedPtr):
(WTF::CagedPtr::get const):
(WTF::CagedPtr::getMayBeNull const):
(WTF::CagedPtr::operator== const):
(WTF::CagedPtr::operator!= const):
(WTF::CagedPtr::operator bool const):
(WTF::CagedPtr::operator* const):
(WTF::CagedPtr::operator-> const):

5:54 PM Changeset in webkit [220164] by Matt Lewis

2 edits
8 deletes in trunk/LayoutTests

Removed bad expectations and marked test as flaky.
https://bugs.webkit.org/show_bug.cgi?id=175061

Unreviewed test gardening.

platform/mac-elcapitan-wk2/imported/w3c/web-platform-tests/fetch/api/basic/mode-no-cors-expected.txt: Removed.
platform/mac-elcapitan-wk2/imported/w3c/web-platform-tests/fetch/api/basic/mode-no-cors-worker-expected.txt: Removed.
platform/mac-elcapitan-wk2/imported/w3c/web-platform-tests/fetch/api/cors/cors-basic.any-expected.txt: Removed.
platform/mac-elcapitan-wk2/imported/w3c/web-platform-tests/fetch/api/cors/cors-basic.any.worker-expected.txt: Removed.
platform/mac-elcapitan-wk2/imported/w3c/web-platform-tests/fetch/api/cors/cors-no-preflight.any-expected.txt: Removed.
platform/mac-elcapitan-wk2/imported/w3c/web-platform-tests/fetch/api/cors/cors-no-preflight.any.worker-expected.txt: Removed.
platform/mac-elcapitan-wk2/imported/w3c/web-platform-tests/fetch/api/cors/cors-origin.any-expected.txt: Removed.
platform/mac-elcapitan-wk2/imported/w3c/web-platform-tests/fetch/api/cors/cors-origin.any.worker-expected.txt: Removed.
platform/mac/TestExpectations:

5:46 PM Changeset in webkit [220163] by aestes@apple.com

4 edits
3 adds in trunk

REGRESSION (r207155): Unable to switch sheets when previewing Numbers '09 spreadsheets
https://bugs.webkit.org/show_bug.cgi?id=175098
<rdar://problem/31416763>

Reviewed by Daniel Bates.

Source/WebCore:

r207155 enabled sandboxing on the frame displaying a QuickLook preview. This restricted
frames within the sandbox from navigating their sandboxed siblings or ancestors, which
breaks the functionality of multi-sheet Numbers '09 spreadsheet previews. These previews
contain a frameset with a table of contents frame and a content frame, and the table of
contents frame needs to be able to navigate the content frame when the sheet selection
changes.

Fix this by disabling the SandboxNavigation flag in the QuickLook sandbox. Frames within the
sandbox will be able to navigate each other, but will not be able to navigate the top frame
(due to SandboxTopNavigation still being enabled), nor will they be able to navigate any
other ancestor frame outside the sandbox (due to QuickLook previews being in a different
origin than the hosting frame). These two cases are covered by existing tests.

Test: quicklook/multi-sheet-numbers-09.html

dom/Document.cpp:

(WebCore::Document::applyQuickLookSandbox): Added a call to
disableSandboxFlags(SandboxNavigation) after applying the content security policy.

dom/SecurityContext.h:

(WebCore::SecurityContext::disableSandboxFlags): Defined disableSandboxFlags().

LayoutTests:

quicklook/multi-sheet-numbers-09-expected.txt: Added.
quicklook/multi-sheet-numbers-09.html: Added.
quicklook/resources/multi-sheet-numbers-09.numbers: Added.

5:44 PM Changeset in webkit [220162] by jmarcell@apple.com

1 copy in tags/Safari-604.1.36

Tag Safari-604.1.36.

5:44 PM Changeset in webkit [220161] by jmarcell@apple.com

1 delete in tags/Safari-604.1.36

Delete Tag.

4:56 PM Changeset in webkit [220160] by Chris Dumez

2 edits in trunk/LayoutTests

Unreviewed, skip newly imported WPT that is slow in Debug builds.

TestExpectations:

3:46 PM Changeset in webkit [220159] by commit-queue@webkit.org

3 edits in trunk/LayoutTests

inspector/runtime/CommandLineAPI-inspect.html is flaky.
https://bugs.webkit.org/show_bug.cgi?id=175092

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2017-08-02
Reviewed by Brian Burg.

inspector/runtime/CommandLineAPI-inspect-expected.txt:
inspector/runtime/CommandLineAPI-inspect.html:

3:35 PM Changeset in webkit [220158] by Jonathan Bedard

3 edits in trunk/Tools

check-webkit-style: deleting lines in a file runs the linter on the whole file
https://bugs.webkit.org/show_bug.cgi?id=175078

Reviewed by David Kilzer.

Deleting lines in a file should not cause linter errors to be blamed on the patch.
<https://bugs.webkit.org/show_bug.cgi?id=86142> is an example of this happening.

Scripts/webkitpy/style/checkers/test_expectations.py:

(TestExpectationsChecker._should_log_linter_warning): Do not log a linter error if the file it is associated with only has deleted lines

Scripts/webkitpy/style/main_unittest.py:

(ExpectationLinterInStyleCheckerTest.test_linter_duplicate_line): Added files should have every line number in the file when processing.
(ExpectationLinterInStyleCheckerTest.test_linter_duplicate_line_only_deletes): Test case where the file with the linter errors only contained deletes.
(ExpectationLinterInStyleCheckerTest.test_linter_added_file_with_error): Added files should have every line number in the file when processing.

3:31 PM Changeset in webkit [220157] by jmarcell@apple.com

7 edits in branches/safari-604-branch/Source

Versioning.

3:29 PM Changeset in webkit [220156] by jmarcell@apple.com

1 copy in tags/Safari-604.1.36

Tag Safari-604.1.36.

3:23 PM Changeset in webkit [220155] by jmarcell@apple.com

7 edits in trunk/Source

Versioning.

2:50 PM Changeset in webkit [220154] by fpizlo@apple.com

4 edits in trunk/Source/bmalloc

If Gigacage is disabled, bmalloc should service large aligned memory allocation requests through vmAllocate
https://bugs.webkit.org/show_bug.cgi?id=175085

Reviewed by Saam Barati.

This fixes a problem where if we used gmalloc, WebAssembly memory allocations would still use
bmalloc's large allocator.

We want to use the page allocator for those "large" allocations when the Gigacage is disabled.

bmalloc/DebugHeap.cpp:

(bmalloc::DebugHeap::DebugHeap):
(bmalloc::DebugHeap::memalignLarge):
(bmalloc::DebugHeap::freeLarge):

bmalloc/DebugHeap.h:
bmalloc/Heap.cpp:

(bmalloc::Heap::tryAllocateLarge):
(bmalloc::Heap::deallocateLarge):

2:50 PM Changeset in webkit [220153] by jer.noble@apple.com

2 edits in trunk/Source/WebCore

[MSE] Removing samples when presentation order does not match decode order can cause bad behavior.
https://bugs.webkit.org/show_bug.cgi?id=175091

Reviewed by Eric Carlson.

Address follow-up comments to r219519.

Modules/mediasource/SourceBuffer.cpp:

(WebCore::SourceBuffer::removeCodedFrames):

1:51 PM Changeset in webkit [220152] by jmarcell@apple.com

1 copy in tags/Safari-605.1.2

Tag Safari-605.1.2.

1:45 PM Changeset in webkit [220151] by commit-queue@webkit.org

7 edits in trunk/Source

Remove unused and obsolete setting mediaDocumentEntersFullscreenAutomatically
https://bugs.webkit.org/show_bug.cgi?id=175080

Patch by Jeremy Jones <jeremyj@apple.com> on 2017-08-02
Reviewed by Jon Lee.

Source/WebCore:

No new tests because this only removes unused code.

This is obsolete because of the alternate solution in
https://bugs.webkit.org/show_bug.cgi?id=174850

page/Settings.in:

Source/WebKit:

This is obsolete because of the alternate solution in
https://bugs.webkit.org/show_bug.cgi?id=174850

Shared/WebPreferencesDefinitions.h:
UIProcess/API/Cocoa/WKPreferences.mm:

(-[WKPreferences _setMediaDocumentEntersFullscreenAutomatically:]): Deleted.
(-[WKPreferences _mediaDocumentEntersFullscreenAutomatically]): Deleted.

UIProcess/API/Cocoa/WKPreferencesPrivate.h:
WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::updatePreferences):

1:01 PM Changeset in webkit [220150] by Jonathan Bedard

4 edits in trunk/Tools

webkitpy: Allow caller to specify response to unicode encode/decode error in filesystem
https://bugs.webkit.org/show_bug.cgi?id=175075

Reviewed by David Kilzer.

We have no way of handling text files with illegal unicode characters. Allow the callers of
filesystem.read_text_file to specify one of Python 2.7's supported responses ('strict', 'ignore', or
'replace'). See https://docs.python.org/2/howto/unicode.html for details on these responses.

Scripts/webkitpy/common/system/filesystem.py:

(FileSystem.read_text_file): Allow caller to specify unicode error handling.
(FileSystem.write_text_file): Ditto.

Scripts/webkitpy/common/system/filesystem_mock.py:

(MockFileSystem.read_text_file): Allow caller to specify unicode error handling.
(MockFileSystem.write_text_file): Ditto.

Scripts/webkitpy/common/system/filesystem_unittest.py:

(RealFileSystemTest.test_read_text_file_unicode_decode_error): Test reading a file with illegal unicode content.
(RealFileSystemTest.test_write_text_file_unicode_encode_error): Test writing illegal unicode content to a file.

12:59 PM Changeset in webkit [220149] by Chris Dumez

3 edits in trunk/LayoutTests

Unreviewed, skip newly imported WPT HTTPS tests on WK2 only.

The tests seem to work fine on WK1.

TestExpectations:
platform/wk2/TestExpectations:

12:57 PM Changeset in webkit [220148] by fpizlo@apple.com

13 edits in trunk/Source

We should be OK with the gigacage being disabled on gmalloc
https://bugs.webkit.org/show_bug.cgi?id=175082

Reviewed by Michael Saboff.
Source/bmalloc:

This adds Gigacage::shouldBeEnabled(), which returns false when we're using gmalloc or other things
that enable DebugHeap.

bmalloc/Environment.cpp:

(bmalloc::Environment::Environment):

bmalloc/Environment.h:
bmalloc/Gigacage.cpp:

(Gigacage::ensureGigacage):
(Gigacage::shouldBeEnabled):

bmalloc/Gigacage.h:
bmalloc/Heap.cpp:

(bmalloc::Heap::Heap):

bmalloc/Heap.h:

Source/JavaScriptCore:

jsc.cpp:

(jscmain):

Source/WebKit:

WebProcess/WebProcess.cpp:

(WebKit::m_webSQLiteDatabaseTracker):

Source/WTF:

wtf/Gigacage.h:

(Gigacage::shouldBeEnabled):

11:35 AM Changeset in webkit [220147] by BJ Burg

2 edits in trunk/Source/WebKit

Web Automation: files selected for upload should be checked against values of the 'accept' attribute
https://bugs.webkit.org/show_bug.cgi?id=174803
<rdar://problem/33514190>

Reviewed by Carlos Garcia Campos.

Use the parsed values of the file input element's "accept" attribute to reject
files that don't match the specified values. This is normally done by Safari
using NSOpenPanel, but since a real open panel isn't shown during automation,
it needs to be done here.

Support for limiting accepted files by file extensions will be added when the
same is implemented in the normal code path for the C and Objective-C APIs.

This change is covered by internal WebDriver tests that will be rewritten for the
public Webdriver W3C test suite someday, when safaridriver runs those tests itself.

UIProcess/Automation/WebAutomationSession.cpp:

(WebKit::WebAutomationSession::handleRunOpenPanel):
Since we already have the proposed files, there's no need to compute a list of
supported extensions based on wildcard MIME types. First check the extension,
then the inferred MIME type for the extension, and then the wildcard MIME type
if the inferred type is not an exact match.

11:25 AM Changeset in webkit [220146] by Matt Lewis

2 edits in trunk/LayoutTests

Unmarked imported/w3c/IndexedDB-private-browsing/idbfactory_open.html as flaky.
https://bugs.webkit.org/show_bug.cgi?id=174949

Unreviewed test gardening.

platform/ios-wk2/TestExpectations:

11:24 AM Changeset in webkit [220145] by fpizlo@apple.com

2 edits in trunk/Source/WebCore

GPUBuffer::length() should return the size of the array buffer backing the GPU buffer, not the rounded-up GPU buffer length
https://bugs.webkit.org/show_bug.cgi?id=175079

Reviewed by Simon Fraser.

This fixes a failure in the GPU.BufferCreate unit test.

The problem is that in order to have a Metal buffer wrap memory we allocated, we have to tell Metal
that the memory is page-aligned. This means that the Metal buffer reports back a page-aligned size,
which is different than what the test expected.

It seems that it's most convenient for our GPUBuffer class to return the unaligned length, rather
than the aligned length. This is just a simple matter of returning the length from the ArrayBuffer
rather than the Metal buffer.

This fixes the unit test and is probably more sensible for actual users of this class, since the page
alignment of the length is a goofy implementation detail.

platform/graphics/cocoa/GPUBufferMetal.mm:

(WebCore::GPUBuffer::length const):

11:15 AM Changeset in webkit [220144] by sbarati@apple.com

3 edits in trunk/Source/JavaScriptCore

On memory-constrained iOS devices, reduce the rate at which the JS heap grows before a GC to try to keep more memory available for the system
https://bugs.webkit.org/show_bug.cgi?id=175041
<rdar://problem/33659370>

Reviewed by Filip Pizlo.

The testing I have done shows that this new function is a ~10%
progression running JetStream on 1GB iOS devices. I've also tried
this on a few > 1GB iOS devices, and the testing shows this is either neutral
or a regression. Right now, we'll just enable this for <= 1GB devices
since it's a win. In the future, we might want to either look into
tweaking these parameters or coming up with a new function for > 1GB
devices.

heap/Heap.cpp:
runtime/Options.h:

11:10 AM Changeset in webkit [220143] by matthew_hanson@apple.com

2 edits in tags/Safari-604.1.35.1/Source/WebKitLegacy

Cherry-pick r220128. rdar://problem/33537767

11:10 AM Changeset in webkit [220142] by matthew_hanson@apple.com

13 edits in tags/Safari-604.1.35.1

Cherry-pick r219602. rdar://problem/33537767

11:10 AM Changeset in webkit [220141] by matthew_hanson@apple.com

7 edits in tags/Safari-604.1.35.1/Source

Versioning.

10:57 AM Changeset in webkit [220140] by matthew_hanson@apple.com

1 copy in tags/Safari-604.1.35.1

New Tag.

10:54 AM Changeset in webkit [220139] by aakash_jain@apple.com

2 edits in trunk/Tools

Intermittent exception in buildPageURLForIteration for Buildbot 0.9 dashboard
https://bugs.webkit.org/show_bug.cgi?id=175072

Reviewed by Alexey Proskuryakov.

BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:

(Buildbot): Make sure this._builderNameToIDMap is always defined for Buildbot 0.9.

10:51 AM Changeset in webkit [220138] by timothy_horton@apple.com

5 edits in trunk/Source/WebKit

WKPDFView doesn't respect safe area insets
https://bugs.webkit.org/show_bug.cgi?id=175046
<rdar://problem/33558386>

Reviewed by Wenson Hsieh.

Platform/spi/ios/UIKitSPI.h:

Add some SPI.

UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _setHasCustomContentView:loadedMIMEType:]):
Drive-by fix two small custom content view issues:

Reset _scrollViewBackgroundColor; it is used to early-return from

updating the background color if it hasn't changed, but if you go from a
site with (for example) a white background, to a PDF, to another site
with a white background, we will early-return and not reset the background
color from the grey WKPDFView background.

When installing a custom content view, scroll to the origin. We miss

the usual mechanism for scrolling to the origin when custom content views
are installed, so do it here.

(-[WKWebView _effectiveObscuredInsetEdgesAffectedBySafeArea]):
Ignore _obscuredInsetEdgesAffectedBySafeArea for custom content views.
This is fairly arbitrary, and we should find a different way to
express different edge sets for different kinds of content (perhaps
bake this into default viewports?), but for now this works.

(-[WKWebView _computedContentInset]):
Use _effectiveObscuredInsetEdgesAffectedBySafeArea instead of the ivar directly.

(-[WKWebView _safeAreaShouldAffectObscuredInsets]):
Force safe areas to not affect obscured insets for custom content views,
so that it's up to every custom content view to take safe areas into
account themselves.

UIProcess/API/Cocoa/WKWebViewInternal.h:

Expose _computedUnobscuredSafeAreaInset for WKPDFView's use.

UIProcess/ios/WKPDFView.mm:

(-[WKPDFView web_setMinimumSize:]):
Avoid rebuilding the WKPDFView if the minimum size didn't change.

(-[WKPDFView _offsetForPageNumberIndicator]):
Take unobscured safe area insets into account when insetting
the page number indicator.

(-[WKPDFView web_computedContentInsetDidChange]):
Watch for unobscured safe area inset changes, and apply them to the
layout of the WKPDFView.

(-[WKPDFView _computePageAndDocumentFrames]):
Make it possible to only update the WKPDFView's size and position, without
rebuilding its subviews, if the width did not change. This prevents lots
of flashing of the child UIPDFPageViews when the unobscured safe area
insets change dynamically.

Take the safe area insets into account when determining what width
to lay out to.

(-[WKPDFView _updateDocumentFrame]):
Take the safe area insets into account when positioning the WKPDFView
inside the WKScrollView.

10:46 AM Changeset in webkit [220137] by Chris Dumez

2 edits in trunk/LayoutTests

Unreviewed, temporarily skip some HTTPS tests that time out on the bots.

TestExpectations:

10:45 AM Changeset in webkit [220136] by wilander@apple.com

2 edits in trunk/Source/WebKit

ResourceLoadStatisticsClassifierCocoa::singletonPredictionModel() should check the return value of storagePath()
https://bugs.webkit.org/show_bug.cgi?id=175055
<rdar://problem/32671352>

Reviewed by David Kilzer.

Platform/classifier/cocoa/ResourceLoadStatisticsClassifierCocoa.cpp:

(WebKit::ResourceLoadStatisticsClassifierCocoa::singletonPredictionModel):

Now uses dispatch_once() instead of NeverDestroyed and checks the
return value of storagePath() before using it to load the model.

10:38 AM Changeset in webkit [220135] by BJ Burg

9 edits in trunk/Source

HTML file input elements do not support file extensions in the "accept" attribute
https://bugs.webkit.org/show_bug.cgi?id=95698
<rdar://problem/12231850>

Reviewed by Darin Adler.

Source/WebCore:

Serialize the accepted file extensions so they can be accessed in the UI process.

platform/FileChooser.h:
platform/FileChooser.cpp:

(WebCore::FileChooser::invalidate): Modernize.
(WebCore::FileChooserSettings::acceptTypes const): Deleted.
This is dead code, it was only used by Chromium.

Source/WebKit:

Plumb accepted file extensions out to the C API.
The Cocoa API will be improved in a later patch.

Shared/WebCoreArgumentCoders.cpp:

(IPC::ArgumentCoder<FileChooserSettings>::encode):
(IPC::ArgumentCoder<FileChooserSettings>::decode):

UIProcess/API/APIOpenPanelParameters.cpp:

(API::OpenPanelParameters::acceptFileExtensions const):

UIProcess/API/APIOpenPanelParameters.h:
UIProcess/API/C/WKOpenPanelParametersRef.cpp:

(WKOpenPanelParametersCopyAcceptedFileExtensions):

UIProcess/API/C/WKOpenPanelParametersRef.h:

10:37 AM Changeset in webkit [220134] by Matt Lewis

1 edit
8 moves
8 adds in trunk/LayoutTests

Added new expectations folders and moved expectations to correct folders.
https://bugs.webkit.org/show_bug.cgi?id=175061

Unreviewed gardening.

platform/mac-elcapitan-wk2/imported/w3c/web-platform-tests/fetch/api/basic/mode-no-cors-expected.txt: Renamed from LayoutTests/platform/mac-elcapitan/imported/w3c/web-platform-tests/fetch/api/basic/mode-no-cors-expected.txt.
platform/mac-elcapitan-wk2/imported/w3c/web-platform-tests/fetch/api/basic/mode-no-cors-worker-expected.txt: Renamed from LayoutTests/platform/mac-elcapitan/imported/w3c/web-platform-tests/fetch/api/basic/mode-no-cors-worker-expected.txt.
platform/mac-elcapitan-wk2/imported/w3c/web-platform-tests/fetch/api/cors/cors-basic.any-expected.txt: Renamed from LayoutTests/platform/mac-elcapitan/imported/w3c/web-platform-tests/fetch/api/cors/cors-basic.any-expected.txt.
platform/mac-elcapitan-wk2/imported/w3c/web-platform-tests/fetch/api/cors/cors-basic.any.worker-expected.txt: Renamed from LayoutTests/platform/mac-elcapitan/imported/w3c/web-platform-tests/fetch/api/cors/cors-basic.any.worker-expected.txt.
platform/mac-elcapitan-wk2/imported/w3c/web-platform-tests/fetch/api/cors/cors-no-preflight.any-expected.txt: Renamed from LayoutTests/platform/mac-elcapitan/imported/w3c/web-platform-tests/fetch/api/cors/cors-no-preflight.any-expected.txt.
platform/mac-elcapitan-wk2/imported/w3c/web-platform-tests/fetch/api/cors/cors-no-preflight.any.worker-expected.txt: Renamed from LayoutTests/platform/mac-elcapitan/imported/w3c/web-platform-tests/fetch/api/cors/cors-no-preflight.any.worker-expected.txt.
platform/mac-elcapitan-wk2/imported/w3c/web-platform-tests/fetch/api/cors/cors-origin.any-expected.txt: Renamed from LayoutTests/platform/mac-elcapitan/imported/w3c/web-platform-tests/fetch/api/cors/cors-origin.any-expected.txt.
platform/mac-elcapitan-wk2/imported/w3c/web-platform-tests/fetch/api/cors/cors-origin.any.worker-expected.txt: Renamed from LayoutTests/platform/mac-elcapitan/imported/w3c/web-platform-tests/fetch/api/cors/cors-origin.any.worker-expected.txt.

10:28 AM Changeset in webkit [220133] by matthew_hanson@apple.com

13 edits in branches/safari-604-branch

Cherry-pick r219602. rdar://problem/33537767

10:03 AM Changeset in webkit [220132] by commit-queue@webkit.org

5 edits in trunk/LayoutTests

Remove obsolete expectations for syntax-021.xml.
https://bugs.webkit.org/show_bug.cgi?id=86142

Patch by Ms2ger <Ms2ger@igalia.com> on 2017-08-02
Reviewed by Sam Weinig.

It may have started passing in r209396.

platform/gtk/TestExpectations:
platform/ios-simulator/TestExpectations:
platform/mac/TestExpectations:
platform/win/TestExpectations:

9:46 AM Changeset in webkit [220131] by commit-queue@webkit.org

7 edits in trunk/Source

Use LazyNeverDestroyed instead of DEFINE_GLOBAL for QualifiedName
https://bugs.webkit.org/show_bug.cgi?id=175010
<rdar://problem/33647818>

Patch by Fujii Hironori <Fujii Hironori> on 2017-08-02
Reviewed by Alex Christensen.

Source/WebCore:

No new tests because no behavior change.

Stop using DEFINE_GLOBAL hack in favor of LazyNeverDestroyed.

contentextensions/ContentExtensionParser.cpp:

(WebCore::ContentExtensions::isValidCSSSelector):
Call QualifiedName::init().

dom/DOMAllInOne.cpp: Remove the warning. Include QualifiedName.cpp.
dom/QualifiedName.cpp:

(WebCore::QualifiedName::init): Call LazyNeverDestroyed::construct
instead of placement new.

dom/QualifiedName.h: Use LazyNeverDestroyed.

Source/WebKit:

UIProcess/API/APIContentRuleListStore.cpp:

(API::ContentRuleListStore::compileContentRuleList):
Call QualifiedName::init().

8:36 AM Changeset in webkit [220130] by commit-queue@webkit.org

2 edits in trunk/LayoutTests

Remove overridden lines from win's TestExpectations.
https://bugs.webkit.org/show_bug.cgi?id=175068

Patch by Ms2ger <Ms2ger@igalia.com> on 2017-08-02
Reviewed by Darin Adler.

These lines cause lint errors and block any patch that touches the file from
landing.

platform/win/TestExpectations:

7:07 AM Changeset in webkit [220129] by matthew_hanson@apple.com

2 edits in branches/safari-604-branch/Source/WebKitLegacy

Cherry-pick r220128. rdar://problem/33537767

6:53 AM Changeset in webkit [220128] by matthew_hanson@apple.com

2 edits in trunk/Source/WebKitLegacy

Build-fix for Windows in Visual Studio after directory rename.

Reviewed by Per Arne Vollan.

WebKitLegacy.vcxproj/WebKitLegacy.proj:

We still build WebKit.dll, not WebKitLegacy.dll.

6:25 AM Changeset in webkit [220127] by commit-queue@webkit.org

2 edits in trunk/LayoutTests

[GTK] Layout test editing/pasteboard/copy-standalone-image.html failing
https://bugs.webkit.org/show_bug.cgi?id=163184

Unreviewed test gardening.

Remove obsolete failure expectation for copy-standalone-image.html.

The bug was fixed in r212428. (The test was also broken by both landings for
bug 170956, until r216174 fixed it again.)

Patch by Ms2ger <Ms2ger@igalia.com> on 2017-08-02

platform/gtk/TestExpectations:

1:45 AM Changeset in webkit [220126] by Michael Catanzaro

2 edits in trunk/Tools

[CMake] Remove obsolete code in TestWebKitAPI/CMakeLists.txt
https://bugs.webkit.org/show_bug.cgi?id=175019

Context Navigation

Timeline

Aug 3, 2017:

Aug 2, 2017:

Download in other formats: