⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Aug 11, 2017:

10:18 PM Changeset in webkit [220623] by beidson@apple.com
  • 4 edits
    22 moves
    1 add in trunk/Source/WebCore

Move files inside WebCore/workers to WebCore/workers/service.
​https://bugs.webkit.org/show_bug.cgi?id=175495

Rubberstamped by Tim Horton.

  • CMakeLists.txt:
  • DerivedSources.make:
  • WebCore.xcodeproj/project.pbxproj:
  • workers/service/ServiceWorker.cpp: Renamed from Source/WebCore/workers/ServiceWorker.cpp.
  • workers/service/ServiceWorker.h: Renamed from Source/WebCore/workers/ServiceWorker.h.
  • workers/service/ServiceWorker.idl: Renamed from Source/WebCore/workers/ServiceWorker.idl.
  • workers/service/ServiceWorkerContainer.cpp: Renamed from Source/WebCore/workers/ServiceWorkerContainer.cpp.
  • workers/service/ServiceWorkerContainer.h: Renamed from Source/WebCore/workers/ServiceWorkerContainer.h.
  • workers/service/ServiceWorkerContainer.idl: Renamed from Source/WebCore/workers/ServiceWorkerContainer.idl.
  • workers/service/ServiceWorkerGlobalScope.cpp: Renamed from Source/WebCore/workers/ServiceWorkerGlobalScope.cpp.
  • workers/service/ServiceWorkerGlobalScope.h: Renamed from Source/WebCore/workers/ServiceWorkerGlobalScope.h.
  • workers/service/ServiceWorkerGlobalScope.idl: Renamed from Source/WebCore/workers/ServiceWorkerGlobalScope.idl.
  • workers/service/ServiceWorkerJob.cpp: Renamed from Source/WebCore/workers/ServiceWorkerJob.cpp.
  • workers/service/ServiceWorkerJob.h: Renamed from Source/WebCore/workers/ServiceWorkerJob.h.
  • workers/service/ServiceWorkerJobClient.h: Renamed from Source/WebCore/workers/ServiceWorkerJobClient.h.
  • workers/service/ServiceWorkerProvider.cpp: Renamed from Source/WebCore/workers/ServiceWorkerProvider.cpp.
  • workers/service/ServiceWorkerProvider.h: Renamed from Source/WebCore/workers/ServiceWorkerProvider.h.
  • workers/service/ServiceWorkerRegistration.cpp: Renamed from Source/WebCore/workers/ServiceWorkerRegistration.cpp.
  • workers/service/ServiceWorkerRegistration.h: Renamed from Source/WebCore/workers/ServiceWorkerRegistration.h.
  • workers/service/ServiceWorkerRegistration.idl: Renamed from Source/WebCore/workers/ServiceWorkerRegistration.idl.
  • workers/service/ServiceWorkerRegistrationOptions.h: Renamed from Source/WebCore/workers/ServiceWorkerRegistrationOptions.h.
  • workers/service/ServiceWorkerRegistrationParameters.cpp: Renamed from Source/WebCore/workers/ServiceWorkerRegistrationParameters.cpp.
  • workers/service/ServiceWorkerRegistrationParameters.h: Renamed from Source/WebCore/workers/ServiceWorkerRegistrationParameters.h.
  • workers/service/ServiceWorkerUpdateViaCache.h: Renamed from Source/WebCore/workers/ServiceWorkerUpdateViaCache.h.
  • workers/service/ServiceWorkerUpdateViaCache.idl: Renamed from Source/WebCore/workers/ServiceWorkerUpdateViaCache.idl.
7:51 PM Changeset in webkit [220622] by Chris Dumez
  • 37 edits
    4 adds in trunk

Implement quota limitation for keepalive Fetch requests
​https://bugs.webkit.org/show_bug.cgi?id=175482

Reviewed by Sam Weinig and Youenn Fablet.

LayoutTests/imported/w3c:

  • web-platform-tests/fetch/api/basic/scheme-about.any-expected.txt:
  • web-platform-tests/fetch/api/basic/scheme-about.any.worker-expected.txt:
  • web-platform-tests/fetch/api/cors/cors-multiple-origins-expected.txt:
  • web-platform-tests/fetch/api/cors/cors-multiple-origins-worker-expected.txt:
  • web-platform-tests/fetch/api/cors/cors-preflight-star.any-expected.txt:
  • web-platform-tests/fetch/api/cors/cors-preflight-star.any.worker-expected.txt:
  • web-platform-tests/fetch/http-cache/cc-request-expected.txt:

Rebaseline tests now that we provide a more helpful error message when rejecting
the fetch() promise.

  • web-platform-tests/fetch/api/request/request-keepalive-quota-expected.txt:

Rebaseline test for keepalive Fetch requests quota which is now passing.

Source/WebCore:

Implement quota limitation for keepalive Fetch requests as per:

This partly works for Beacon as well, meaning that no Beacon with a body
over 64Kb can be sent. However, we don't keep track about wether or not
beacon loads are inflight or not.

Also update CachedResourceLoader::requestResource() so that the caller
can get a ResourceError when it returns null. This is useful for both
Fetch and Beacon to return better error messages.

Test: http/wpt/beacon/beacon-quota.html

  • CMakeLists.txt:
  • Modules/beacon/NavigatorBeacon.cpp:

(WebCore::NavigatorBeacon::sendBeacon):

  • Modules/fetch/FetchBodyOwner.cpp:

(WebCore::FetchBodyOwner::BlobLoader::didReceiveResponse):
(WebCore::FetchBodyOwner::BlobLoader::didFail):

  • Modules/fetch/FetchBodyOwner.h:
  • Modules/fetch/FetchLoader.cpp:

(WebCore::FetchLoader::start):
(WebCore::FetchLoader::didFail):

  • Modules/fetch/FetchLoaderClient.h:
  • Modules/fetch/FetchResponse.cpp:

(WebCore::FetchResponse::BodyLoader::didFail):

  • Modules/fetch/FetchResponse.h:
  • WebCore.xcodeproj/project.pbxproj:
  • loader/DocumentThreadableLoader.cpp:

(WebCore::DocumentThreadableLoader::loadRequest):

  • loader/cache/CachedResource.cpp:

(WebCore::CachedResource::load):

  • loader/cache/CachedResource.h:

(WebCore::CachedResource::isMainOrMediaOrIconOrRawResource const):

  • loader/cache/CachedResourceLoader.cpp:

(WebCore::createResource):
(WebCore::CachedResourceLoader::requestImage):
(WebCore::CachedResourceLoader::requestFont):
(WebCore::CachedResourceLoader::requestTextTrack):
(WebCore::CachedResourceLoader::requestCSSStyleSheet):
(WebCore::CachedResourceLoader::requestUserCSSStyleSheet):
(WebCore::CachedResourceLoader::requestScript):
(WebCore::CachedResourceLoader::requestXSLStyleSheet):
(WebCore::CachedResourceLoader::requestSVGDocument):
(WebCore::CachedResourceLoader::requestLinkResource):
(WebCore::CachedResourceLoader::requestMedia):
(WebCore::CachedResourceLoader::requestIcon):
(WebCore::CachedResourceLoader::requestRawResource):
(WebCore::CachedResourceLoader::requestBeaconResource):
(WebCore::CachedResourceLoader::requestMainResource):
(WebCore::CachedResourceLoader::requestResource):
(WebCore::CachedResourceLoader::preload):

  • loader/cache/CachedResourceLoader.h:
  • loader/cache/KeepaliveRequestTracker.cpp: Added.

(WebCore::KeepaliveRequestTracker::~KeepaliveRequestTracker):
(WebCore::KeepaliveRequestTracker::canLoadRequest):
(WebCore::KeepaliveRequestTracker::registerRequest):
(WebCore::KeepaliveRequestTracker::responseReceived):
(WebCore::KeepaliveRequestTracker::notifyFinished):
(WebCore::KeepaliveRequestTracker::unregisterRequest):

  • loader/cache/KeepaliveRequestTracker.h: Added.
  • platform/network/FormData.cpp:

(WebCore::FormDataElement::lengthInBytes const):
(WebCore::FormData::lengthInBytes const):

  • platform/network/FormData.h:

LayoutTests:

  • fast/xmlhttprequest/xmlhttprequest-nonexistent-file-expected.txt:
  • http/tests/contentextensions/async-xhr-onerror-expected.txt:
  • http/tests/security/contentSecurityPolicy/block-all-mixed-content/insecure-xhr-asynchronous-in-iframe-expected.txt:
  • http/tests/security/contentSecurityPolicy/block-all-mixed-content/insecure-xhr-asynchronous-in-main-frame-expected.txt:
  • http/tests/security/mixedContent/insecure-xhr-in-main-frame-expected.txt:

Rebaseline a few tests now that we provide a more helpful error message when an XHR is failing synchronously.

  • http/wpt/beacon/beacon-quota-expected.txt: Added.
  • http/wpt/beacon/beacon-quota.html: Added.

Add layout test coverage for keepalive Fetch requests quota in the context of sendBeacon().
The second part of the test is still failing because WebCore does not currently know when
ping loads (e.g. beacon loads) complete. This will be addressed via Bug 175443.

6:13 PM Changeset in webkit [220621] by don.olmstead@sony.com
  • 13 edits
    1 move in trunk/Source

[WTF] Move ValueToString into WTF
​https://bugs.webkit.org/show_bug.cgi?id=175469

Reviewed by Sam Weinig.

Source/WebCore:

No new tests. No change in behavior.

  • WebCore.xcodeproj/project.pbxproj:
  • html/HTMLMediaElement.h:

(WTF::ValueToString<WebCore::TextTrackCue::string):
(WebCore::ValueToString<TextTrackCue::string): Deleted.
(WebCore::ValueToString<MediaTime>::string): Deleted.

  • platform/LayoutUnit.h:

(WTF::ValueToString<WebCore::LayoutUnit>::string):
(WebCore::ValueToString<LayoutUnit>::string): Deleted.

  • platform/PODInterval.h:
  • platform/PODIntervalTree.h:
  • platform/PODRedBlackTree.h:
  • platform/graphics/FloatPolygon.h:

(WTF::ValueToString<WebCore::FloatPolygonEdge::string):
(WebCore::ValueToString<FloatPolygonEdge::string): Deleted.

  • rendering/FloatingObjects.h:

(WTF::ValueToString<WebCore::FloatingObject::string):
(WebCore::ValueToString<FloatingObject::string): Deleted.

  • rendering/RenderFlowThread.h:

(WTF::ValueToString<WebCore::RenderRegion::string):
(WebCore::ValueToString<RenderRegion::string): Deleted.

Source/WTF:

  • WTF.xcodeproj/project.pbxproj:
  • wtf/CMakeLists.txt:
  • wtf/text/ValueToString.h: Renamed from Source/WebCore/platform/ValueToString.h.
5:32 PM Changeset in webkit [220620] by commit-queue@webkit.org
  • 7 edits in trunk/Source/WebCore

[Bindings] Simplify DOMPromiseProxy now that WTF::Function can return references
​https://bugs.webkit.org/show_bug.cgi?id=175394

Patch by Sam Weinig <​sam@webkit.org> on 2017-08-11
Reviewed by Chris Dumez.

  • bindings/IDLTypes.h:

(WebCore::IDLWrapper::convertToParameterType): Deleted.

Remove no longer used convertToParameterType.

  • bindings/js/DOMPromiseProxy.h:
  • Replace Variant<Value, Exception> with ExceptionOr<Value> / ExceptionOr<void>.
  • Update ResolveCallback to have a return type of IDLType::ParameterType, rather than IDLType::ImplementationType, now that WTF::Function supports references as the return type. This is needed, since the IDLType::ParameterType for an interface T is T&.
  • css/FontFace.cpp:
  • css/FontFace.h:
  • css/FontFaceSet.cpp:
  • css/FontFaceSet.h:

Update resolve callbacks to return a reference rather than a RefPtr, matching
the new signature requirement.

5:07 PM Changeset in webkit [220619] by commit-queue@webkit.org
  • 17 edits
    11 copies
    1 move
    2 deletes in trunk/Source/WebCore

[WebIDL] Replace JSCryptoKeyCustom and JSCryptoAlgorithmBuilder with generated code
​https://bugs.webkit.org/show_bug.cgi?id=175457

Patch by Sam Weinig <​sam@webkit.org> on 2017-08-11
Reviewed by Chris Dumez.

  • CMakeLists.txt:
  • DerivedSources.make:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSCryptoAlgorithmBuilder.cpp: Removed.
  • bindings/js/JSCryptoAlgorithmBuilder.h: Removed.
  • bindings/js/JSCryptoKeyCustom.cpp: Removed.

Remove JSCryptoAlgorithmBuilder and JSCryptoKeyCustom, add KeyAlgorithm
IDLs and headers.

  • crypto/CryptoKey.cpp:
  • crypto/CryptoKey.h:
  • crypto/CryptoKey.idl:

Replace custom algorithm attribute with a union of the supported key algorithms.

  • crypto/keys/CryptoAesKeyAlgorithm.h: Added.
  • crypto/keys/CryptoAesKeyAlgorithm.idl: Added.
  • crypto/keys/CryptoEcKeyAlgorithm.h: Added.
  • crypto/keys/CryptoEcKeyAlgorithm.idl: Added.
  • crypto/keys/CryptoHmacKeyAlgorithm.h: Added.
  • crypto/keys/CryptoHmacKeyAlgorithm.idl: Added.
  • crypto/keys/CryptoKeyAlgorithm.h: Added.
  • crypto/keys/CryptoKeyAlgorithm.idl: Added.
  • crypto/keys/CryptoRsaHashedKeyAlgorithm.h: Added.
  • crypto/keys/CryptoRsaHashedKeyAlgorithm.idl: Added.
  • crypto/keys/CryptoRsaKeyAlgorithm.h: Added.
  • crypto/keys/CryptoRsaKeyAlgorithm.idl: Added.

Add IDLs and headers fo the supported key algorithms.

  • crypto/keys/CryptoKeyAES.h:
  • crypto/keys/CryptoKeyEC.h:
  • crypto/keys/CryptoKeyHMAC.h:
  • crypto/keys/CryptoKeyRSA.h:
  • crypto/keys/CryptoKeyRaw.h:

Give each of the existing KeyAlgorithm subclasses a dictionary() function
that returns the populated corresponding spec'd dictionary.

4:18 PM Changeset in webkit [220618] by fpizlo@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

JSLexicalEnvironment needs to be in the JSValue gigacage
​https://bugs.webkit.org/show_bug.cgi?id=174922

Reviewed by Michael Saboff.

We can sorta random access the JSLexicalEnvironment. So, we put it in the JSValue gigacage and make
the only random accesses use pointer caging.

We don't need to do anything to normal lexical environment accesses.

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileGetByValOnScopedArguments):

  • ftl/FTLLowerDFGToB3.cpp:

(JSC::FTL::DFG::LowerDFGToB3::compileGetByVal):

  • runtime/JSEnvironmentRecord.h:

(JSC::JSEnvironmentRecord::subspaceFor):
(JSC::JSEnvironmentRecord::variables):

4:12 PM Changeset in webkit [220617] by Ryan Haddad
  • 2 edits in trunk/LayoutTests

Update TestExpectations for failing media/video-controls tests.
​https://bugs.webkit.org/show_bug.cgi?id=173978

Unreviewed test gardening.

  • platform/mac/TestExpectations:
3:43 PM Changeset in webkit [220616] by Simon Fraser
  • 10 edits in trunk/Source/WebCore

Some RenderSVGResource cleanup
​https://bugs.webkit.org/show_bug.cgi?id=175494

Reviewed by Zalan Bujtas.

Use more initializers. Remove spurious use of bitfields that didn't save any space at all.
0 -> nullptr.

No behavior change.

  • rendering/svg/RenderSVGResourceContainer.cpp:

(WebCore::RenderSVGResourceContainer::RenderSVGResourceContainer):

  • rendering/svg/RenderSVGResourceContainer.h:
  • rendering/svg/RenderSVGResourceGradient.cpp:

(WebCore::RenderSVGResourceGradient::RenderSVGResourceGradient):
(WebCore::RenderSVGResourceGradient::applyResource):

  • rendering/svg/RenderSVGResourceGradient.h:
  • rendering/svg/RenderSVGResourcePattern.cpp:

(WebCore::RenderSVGResourcePattern::RenderSVGResourcePattern):

  • rendering/svg/RenderSVGResourcePattern.h:
  • rendering/svg/RenderSVGShape.cpp:

(WebCore::RenderSVGShape::fillShape):
(WebCore::RenderSVGShape::strokeShape):

  • rendering/svg/SVGRenderingContext.cpp:

(WebCore::SVGRenderingContext::~SVGRenderingContext):
(WebCore::SVGRenderingContext::prepareToRenderSVGContent):

  • rendering/svg/SVGRenderingContext.h:

(WebCore::SVGRenderingContext::SVGRenderingContext):

3:35 PM Changeset in webkit [220615] by timothy_horton@apple.com
  • 5 edits in trunk/Source

Fix the build with modern Clang's -Wexpansion-to-defined
​https://bugs.webkit.org/show_bug.cgi?id=175467
<rdar://problem/33667497>

Reviewed by Simon Fraser.

Source/WebCore:

  • crypto/mac/SerializedCryptoKeyWrapMac.mm:

Source/WTF:

  • wtf/FeatureDefines.h:
  • wtf/Platform.h:

Avoid object-like macros that expand to include defined(), because this
behaves inconsistently between different compilers (though in ways
that don't matter for these particular defines, which aren't used on MSVC),
and Clang has added a warning for it.

Move ENABLE_WEBASSEMBLY to Platform.h since it depends on things that
are defined there and can't be evaluated at time-of-use because of the
aforementioned new rules. Previously, there was a cycle between
ENABLE_WEBASSEMBLY and ENABLE_B3_JIT -- break that so that it just
goes FTL_JIT->B3_JIT->WASM instead.

3:33 PM Changeset in webkit [220614] by Nikita Vasilyev
  • 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Clicking on suggestion hint should apply it, not dismiss
​https://bugs.webkit.org/show_bug.cgi?id=175409

Reviewed by Matt Baker.

Make clicking on the suggestion hint apply the completion, and place the text caret after it.

  • UserInterface/Controllers/CodeMirrorCompletionController.js:

(WI.CodeMirrorCompletionController.prototype._createCompletionHintMarker):

3:21 PM Changeset in webkit [220613] by jmarcell@apple.com
  • 7 edits in branches/safari-604.1.38.0-branch/Source

Versioning.

3:20 PM Changeset in webkit [220612] by jmarcell@apple.com
  • 7 edits in branches/safari-604.1.38.1-branch/Source

Versioning.

2:27 PM Changeset in webkit [220611] by jmarcell@apple.com
  • 1 copy in tags/Safari-604.1.38.1.5

Tag Safari-604.1.38.1.5.

2:25 PM Changeset in webkit [220610] by jmarcell@apple.com
  • 1 copy in tags/Safari-604.1.38.0.5

Tag Safari-604.1.38.0.5.

2:08 PM Changeset in webkit [220609] by Nikita Vasilyev
  • 15 edits in trunk/Source/WebInspectorUI

Web Inspector: Styles: Update the filter icon to match Xcode
​https://bugs.webkit.org/show_bug.cgi?id=175458
<rdar://problem/33838660>

Reviewed by Matt Baker.

  • UserInterface/Images/FilterFieldGlyph.svg:

Half-pixel transform is necessary for a cleaner rasterisation.

  • UserInterface/Views/FilterBar.css:

(.filter-bar > input[type="search"]::-webkit-search-decoration):
(.sidebar > .panel.dom-node-details .details-section.dom-node-event-listeners > .header > .filter):
::-webkit-search-decoration is a flexbox item. Remove vertical-align: bottom,
since it didn't do anything for it.

  • UserInterface/Views/DOMNodeDetailsSidebarPanel.css:
  • UserInterface/Views/FilterBar.js:

(WI.FilterBar):

  • UserInterface/Views/CSSStyleDetailsSidebarPanel.js:

(WI.CSSStyleDetailsSidebarPanel.prototype.initialLayout):

  • UserInterface/Views/DebuggerSidebarPanel.js:
  • UserInterface/Views/LogContentView.js:

(WI.LogContentView):

  • UserInterface/Views/NetworkSidebarPanel.js:

(WI.NetworkSidebarPanel):

  • UserInterface/Views/RecordingNavigationSidebarPanel.js:

(WI.RecordingNavigationSidebarPanel):

  • UserInterface/Views/ResourceSidebarPanel.js:

(WI.ResourceSidebarPanel):

  • UserInterface/Views/SearchSidebarPanel.js:

(WI.SearchSidebarPanel):

  • UserInterface/Views/StorageSidebarPanel.js:

(WI.StorageSidebarPanel):

  • UserInterface/Views/TimelineRecordingContentView.js:

(WI.TimelineRecordingContentView):

  • Localizations/en.lproj/localizedStrings.js:

Replace placeholder text for all filter fields with "Filter".

1:37 PM Changeset in webkit [220608] by beidson@apple.com
  • 2 edits in trunk/Source/WebCore

Crash under ServiceWorkerJob::failedWithException.
​https://bugs.webkit.org/show_bug.cgi?id=175488

Reviewed by Tim Horton.

Covered by existing tests.

  • workers/ServiceWorkerJob.cpp:

(WebCore::ServiceWorkerJob::failedWithException): jobDidFinish might cause the Job to be deleted, so make it last.

1:36 PM Changeset in webkit [220607] by Ryan Haddad
  • 5 edits in branches/safari-604.1.38.0-branch/LayoutTests

Unreviewed test gardening. rdar://problem/33831603

  • fast/events/ios/no-touch-events-when-stopping-momentum-scroll-in-mainframe-expected.txt:
  • platform/ios-11/TestExpectations:
  • platform/ios-simulator-wk2/TestExpectations:
  • platform/ios-wk2/fast/dom/elementFromPoint-relative-to-viewport-expected.txt:
1:08 PM Changeset in webkit [220606] by fpizlo@apple.com
  • 7 edits in trunk/Source/JavaScriptCore

DirectArguments should be in the JSValue gigacage
​https://bugs.webkit.org/show_bug.cgi?id=174920

Reviewed by Michael Saboff.

This puts DirectArguments in a new subspace for cells that want to be in the JSValue gigacage. All
indexed accesses to DirectArguments now do caging. get_from_arguments/put_to_arguments are exempted
because they always operate on a DirectArguments that is pointed to directly from the stack, they are
required to use fixed offsets, and you can only store JSValues.

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileGetByValOnDirectArguments):

  • ftl/FTLLowerDFGToB3.cpp:

(JSC::FTL::DFG::LowerDFGToB3::compileGetByVal):

  • jit/JITPropertyAccess.cpp:

(JSC::JIT::emitDirectArgumentsGetByVal):

  • runtime/DirectArguments.h:

(JSC::DirectArguments::subspaceFor):
(JSC::DirectArguments::storage):

  • runtime/VM.cpp:

(JSC::VM::VM):

  • runtime/VM.h:
1:04 PM Changeset in webkit [220605] by Jonathan Bedard
  • 2 edits in trunk/Tools

Create mock ITP data in testing to prevent grandfathering
​https://bugs.webkit.org/show_bug.cgi?id=174720

Unreviewed follow-up fix for r220604.

  • WebKitTestRunner/cocoa/TestControllerCocoa.mm:

(WTR::TestController::cocoaPlatformInitialize): Release resourceLogPlist.

10:30 AM Changeset in webkit [220604] by Jonathan Bedard
  • 5 edits in trunk/Tools

Create mock ITP data in testing to prevent grandfathering
​https://bugs.webkit.org/show_bug.cgi?id=174720
<rdar://problem/33457779>

Reviewed by Brent Fulgham.

We don't need to be triggering grandfathering when each test runner starts. On Mac,
this may launch plugins which can cause layout tests to fail later if the test
runner does not shut-down before the plugins unload.

  • WebKitTestRunner/TestController.h: Add declaration of cocoaPlatformInitialize.
  • WebKitTestRunner/cocoa/TestControllerCocoa.mm:

(WTR::TestController::cocoaPlatformInitialize): Write the minimum data required to
prevent grandfathering from being triggered.

  • WebKitTestRunner/ios/TestControllerIOS.mm:

(WTR::TestController::platformInitialize): Call cocoaPlatformInitialize.

  • WebKitTestRunner/mac/TestControllerMac.mm:

(WTR::TestController::platformInitialize): Ditto.

10:26 AM Changeset in webkit [220603] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Unreviewed, add a FIXME.

  • ftl/FTLLowerDFGToB3.cpp:

(JSC::FTL::DFG::LowerDFGToB3::caged):

10:26 AM Changeset in webkit [220602] by Matt Lewis
  • 2 edits in branches/safari-604.1.38.0-branch/LayoutTests

Unreviwed test gardening. <rdar://problem/33831603>

  • platform/ios-11/TestExpectations:
9:56 AM Changeset in webkit [220601] by weinig@apple.com
  • 10 edits in trunk

WTF::Function does not allow for reference / non-default constructible return types
​https://bugs.webkit.org/show_bug.cgi?id=175244
Source/JavaScriptCore:

Reviewed by Chris Dumez.

  • runtime/ArrayBuffer.cpp:

(JSC::ArrayBufferContents::transferTo):
Call reset(), rather than clear() to avoid the call to destroy() in clear(). The
destroy call needed to be a no-op anyway, since the data is being moved.

Source/WebCore:

Reviewed by Chris Dumez.

  • bindings/js/JSCustomElementInterface.h:

(WebCore::JSCustomElementInterface::invokeCallback):
Update the default value for the addArguments parameter to be an empty lambda, rather than
default initialization, which leads to a null WTF::Function. This allows us to remove support
for calling null WTF::Function. No change in behavior.

Source/WebKit:

Reviewed by Chris Dumez.

  • UIProcess/WebResourceLoadStatisticsStore.h:

Update the default value for the updateCookiePartitioningForDomainsHandler parameter to be an
empty lambda, rather than default initialization, which leads to a null WTF::Function. This allows
us to remove support for calling null WTF::Function. No change in behavior.

Source/WTF:

Reviewed by Chris Dumez.

When Function, then NoncopyableFunction, was templatized to allow non-void return values
in r201493, it maintained the behavior of being callable even if the Function was null.
To accomplish this, when null, the default construction of the return parameter was used.
This means Function can't be used with return types that are not default constructible,
such as reference types and Ref.

This behavior of returning something when null is surprising, as this is not how normal
functions behave, and not very useful. Instead, we now assert that the function is not
null when being called.

  • wtf/Function.h:

(WTF::Function operator(...)):
Instead of allowing a null callable wrapper by returning the default construction of
the return type, assert that the wrapper is there when calling a Function.

Tools:

<rdar://problem/33801582>

Reviewed by Chris Dumez.

  • TestWebKitAPI/Tests/WTF/Function.cpp:

(TestWebKitAPI::TEST):

9:54 AM Changeset in webkit [220600] by mark.lam@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Gardening: fix CLoop build.
​https://bugs.webkit.org/show_bug.cgi?id=175446
<rdar://problem/33836545>

Not reviewed.

  • assembler/MacroAssemblerPrinter.cpp:
9:53 AM Changeset in webkit [220599] by jmarcell@apple.com
  • 6 edits
    3 adds in branches/safari-604.1.38.1-branch

Cherry-pick r220551. rdar://problem/33843387

9:53 AM Changeset in webkit [220598] by jmarcell@apple.com
  • 3 edits
    3 deletes in branches/safari-604.1.38.1-branch

Revert r220587. rdar://problem/33843387

9:53 AM Changeset in webkit [220597] by jmarcell@apple.com
  • 7 edits in branches/safari-604.1.38.1-branch

Revert r220588. rdar://problem/33843387

9:47 AM Changeset in webkit [220596] by fpizlo@apple.com
  • 5 edits in trunk/Source/JavaScriptCore

DFG should do caging
​https://bugs.webkit.org/show_bug.cgi?id=174918

Reviewed by Saam Barati.

Adds the appropriate cage() calls to the DFG, including a cageTypedArrayStorage() helper that does
the conditional caging with a watchpoint.

This might be a 1% SunSpider slow-down, but it's not clear.

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::cageTypedArrayStorage):
(JSC::DFG::SpeculativeJIT::compileGetIndexedPropertyStorage):
(JSC::DFG::SpeculativeJIT::compileGetTypedArrayByteOffset):
(JSC::DFG::SpeculativeJIT::compileCreateRest):
(JSC::DFG::SpeculativeJIT::compileSpread):
(JSC::DFG::SpeculativeJIT::compileNewArrayWithSpread):
(JSC::DFG::SpeculativeJIT::compileArraySlice):
(JSC::DFG::SpeculativeJIT::compileGetButterfly):

  • dfg/DFGSpeculativeJIT.h:
  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

9:39 AM Changeset in webkit [220595] by Konstantin Tokarev
  • 17 edits in trunk

[CMake] Fix broken use of REQUIRED with find modules
​https://bugs.webkit.org/show_bug.cgi?id=175427

Reviewed by Michael Catanzaro.

Module name passed to find_package_handle_standard_args() must exactly
match file name of CMake find module including letter case, e.g. "WebP"
must be used in FindWebP.cmake file. Otherwise find_package() arguments
(REQUIRED, QUIET, version) are not processed correctly.

To continue using old XXX_FOUND variables without case changes porting
to new find_package_handle_standard_args syntax which has FOUND_VAR
parameter. Unfortunately, variable name GTK_UNIX_PRINT_FOUND is not
allowed by find_package_handle_standard_args when package name is
GTKUnixPrint, so it's replaced to GTKUnixPrint_FOUND (default).

  • Source/cmake/FindGTKUnixPrint.cmake:
  • Source/cmake/FindGeoClue2.cmake:
  • Source/cmake/FindHyphen.cmake:
  • Source/cmake/FindLibEpoxy.cmake:
  • Source/cmake/FindLibGBM.cmake:
  • Source/cmake/FindLibsecret.cmake:
  • Source/cmake/FindLibtasn1.cmake:
  • Source/cmake/FindLibxkbcommon.cmake:
  • Source/cmake/FindOpenGL.cmake:
  • Source/cmake/FindOpenGLES2.cmake:
  • Source/cmake/FindOpenWebRTC.cmake:
  • Source/cmake/FindWPEBackend-mesa.cmake:
  • Source/cmake/FindWPEBackend.cmake:
  • Source/cmake/FindWayland.cmake:
  • Source/cmake/FindWebP.cmake:
  • Source/cmake/OptionsGTK.cmake:
9:22 AM Changeset in webkit [220594] by Antti Koivisto
  • 7 edits in trunk/Source/WebCore

Remove RenderQuote collection from RenderView
​https://bugs.webkit.org/show_bug.cgi?id=175479

Reviewed by Andreas Kling.

We can do it well enough without maintaining this pointer structure.

Global updating doesn't work well with future direction for first-letter and similar anyway.
We need to update quote immediately when updating its style.

  • rendering/RenderQuote.cpp:

(WebCore::RenderQuote::insertedIntoTree):
(WebCore::RenderQuote::willBeRemovedFromTree):

Just tell the view that there are renderers to update.

(WebCore::RenderQuote::styleDidChange):
(WebCore::RenderQuote::isOpen const):
(WebCore::RenderQuote::updateRenderer):
(WebCore::RenderQuote::updateRenderers): Deleted.

Update single renderer only. RenderTreeUpdater provides the previous renderer to compute the depth.

  • rendering/RenderQuote.h:
  • rendering/RenderView.cpp:

(WebCore::RenderView::registerQuote): Deleted.
(WebCore::RenderView::unregisterQuote): Deleted.
(WebCore::RenderView::updateSpecialRenderers): Deleted.

Remove the quote list.

  • rendering/RenderView.h:
  • style/RenderTreeUpdater.cpp:

(WebCore::RenderTreeUpdater::commit):

Ensure that all quotes are updated.

(WebCore::RenderTreeUpdater::updateBeforeOrAfterPseudoElement):
(WebCore::RenderTreeUpdater::updateQuotesUpTo):

Traverse render tree to find quotes to update starting from the previous updated quote.

  • style/RenderTreeUpdater.h:
8:48 AM Changeset in webkit [220593] by Ryan Haddad
  • 2 edits
    46 adds in branches/safari-604.1.38.1-branch/LayoutTests

Cherry-pick r220555.

8:44 AM Changeset in webkit [220592] by Yusuke Suzuki
  • 2 edits in trunk/Source/JavaScriptCore

Unreviewed, build fix for x86 GTK port
​https://bugs.webkit.org/show_bug.cgi?id=175446

Use pushfl/popfl instead of pushfd/popfd.

  • assembler/MacroAssemblerX86Common.cpp:
8:44 AM Changeset in webkit [220591] by Adrian Perez de Castro
  • 2 edits in trunk/Source/WebCore

[CMake] Many warning about missing “override” keywords in ANGLE with Clang
​https://bugs.webkit.org/show_bug.cgi?id=175475

Reviewed by Michael Catanzaro.

  • CMakeLists.txt: Add "-Wno-inconsistent-missing-override" to the

compiler flags using for building the ANGLE sources.

8:43 AM Changeset in webkit [220590] by jmarcell@apple.com
  • 2 edits in branches/safari-604.1.38.0-branch/Source/WebKit

Cherry-pick r220571. rdar://problem/33829964

8:41 AM Changeset in webkit [220589] by jmarcell@apple.com
  • 2 edits in branches/safari-604.1.38.1-branch/Source/WebKit

Cherry-pick r220571. rdar://problem/33829962

8:17 AM Changeset in webkit [220588] by jmarcell@apple.com
  • 7 edits in branches/safari-604.1.38.1-branch

Cherry-pick r220551. rdar://problem/33594320

8:16 AM Changeset in webkit [220587] by jmarcell@apple.com
  • 3 edits
    3 adds in branches/safari-604.1.38.1-branch

Cherry-pick r220463. rdar://problem/33594320

6:46 AM Changeset in webkit [220586] by Adrian Perez de Castro
  • 2 edits in trunk/Source/WebCore

[GTK][WPE] Overriden virtual function not marked “override” in ImageBufferDataCairo.h
​https://bugs.webkit.org/show_bug.cgi?id=175476

Reviewed by Carlos Garcia Campos.

  • platform/graphics/cairo/ImageBufferDataCairo.h: Add missing "override" qualifier.
6:25 AM Changeset in webkit [220585] by Adrian Perez de Castro
  • 2 edits in trunk/Source/WebKit

[WPE] Build failure with Clang 4.0.1: no matching conversion for functional-style cast from 'pointer' (aka 'unsigned short *') to 'WTF::String'
​https://bugs.webkit.org/show_bug.cgi?id=175477

Reviewed by Žan Doberšek.

  • Shared/wpe/WebEventFactory.cpp:

(WebKit::singleCharacterStringForKeyEvent): Cast to UChar* to make
compiler choose the correct WTF::String constructor.

5:28 AM Changeset in webkit [220584] by clopez@igalia.com
  • 2 edits in trunk/Source/WebDriver

Fix build warning in WebDriverService.h
​https://bugs.webkit.org/show_bug.cgi?id=166682

Unreviewed build fix.

  • WebDriverService.h: Fixes the warning: class 'Capabilities' was previously declared as a struct [-Wmismatched-tags]
3:06 AM Changeset in webkit [220583] by Carlos Garcia Campos
  • 7 edits in trunk

[Soup] Cannot access HTTPS sites using a HTTP proxy that requires authentication
​https://bugs.webkit.org/show_bug.cgi?id=175378

Reviewed by Sergio Villar Senin.

Source/WebCore:

Bring back part of the code removed in r206732, to keep a reference to the SoupMessage in the
AuthenticationChallenge since it can be different to the resource message.

  • platform/network/soup/AuthenticationChallenge.h:

(WebCore::AuthenticationChallenge::AuthenticationChallenge): Deleted.
(WebCore::AuthenticationChallenge::authenticationClient const): Deleted.
(WebCore::AuthenticationChallenge::soupAuth const): Deleted.
(WebCore::AuthenticationChallenge::setProposedCredential): Deleted.

  • platform/network/soup/AuthenticationChallengeSoup.cpp:

(WebCore::AuthenticationChallenge::AuthenticationChallenge):
(WebCore::AuthenticationChallenge::platformCompare):

Source/WebKit:

In case of HTTPS resource with a proxy, libsoup uses a tunnel internally, that uses its own SoupMessage during
the proxy authentication. We were ignoring authentication requests for other messages.

  • NetworkProcess/soup/NetworkDataTaskSoup.cpp:

(WebKit::NetworkDataTaskSoup::authenticateCallback): Only return early if the message does't match and it's not
HTTPS resource over a proxy.
(WebKit::NetworkDataTaskSoup::authenticate): Use the soup message from the authentication challenge.
(WebKit::NetworkDataTaskSoup::continueAuthenticate): Ditto.

Tools:

Add two test cases to check proxy authentication.

  • TestWebKitAPI/Tests/WebKitGLib/TestAuthentication.cpp:

(Tunnel::Tunnel):
(Tunnel::~Tunnel):
(Tunnel::connect):
(Tunnel::connected):
(serverCallback):
(ProxyAuthenticationTest::ProxyAuthenticationTest):
(ProxyAuthenticationTest::~ProxyAuthenticationTest):
(ProxyAuthenticationTest::proxyServerPortAsString):
(testWebViewAuthenticationProxy):
(testWebViewAuthenticationProxyHTTPS):
(beforeAll):

1:15 AM Changeset in webkit [220582] by calvaris@igalia.com
  • 3 edits
    6 moves
    3 adds
    5 deletes in trunk/Tools

[GStreamer][GTK][WPE] Unify GStreamer JHBuild moduleset for both GTK+ and WPE
​https://bugs.webkit.org/show_bug.cgi?id=175428

Both ports share the GStreamer code as multimedia backend and till
not so long they were using different versions. Now they do use
the same versions and it does not make any sense anymore (and
neither had sense before) to have differences in the modulesets.

In this patch I created a GStreamer moduleset and referenced it
from both GTK+'s and WPE's. GStreamer patches were also moved there.

Reviewed by Žan Doberšek.

  • gstreamer/jhbuild.modules: Added.
  • gstreamer/patches/gst-plugins-good-0003-rtpbin-receive-bundle-support.patch: Renamed from Tools/gtk/patches/gst-plugins-good-0003-rtpbin-receive-bundle-support.patch.
  • gstreamer/patches/gst-plugins-good-0005-souphttpsrc-cookie-jar-and-context-query-support.patch: Renamed from Tools/gtk/patches/gst-plugins-good-0005-souphttpsrc-cookie-jar-and-context-query-support.patch.
  • gstreamer/patches/gst-plugins-good-0006-qtdemux-add-context-for-a-preferred-protection.patch: Renamed from Tools/gtk/patches/gst-plugins-good-0006-qtdemux-add-context-for-a-preferred-protection.patch.
  • gstreamer/patches/gst-plugins-good-0008-qtdemux-also-push-buffers-without-encryption-info-in.patch: Renamed from Tools/gtk/patches/gst-plugins-good-0008-qtdemux-also-push-buffers-without-encryption-info-in.patch.
  • gstreamer/patches/gstreamer-0001-protection-added-function-to-filter-system-ids.patch: Renamed from Tools/gtk/patches/gstreamer-0001-protection-added-function-to-filter-system-ids.patch.
  • gstreamer/patches/openh264-configure.patch: Renamed from Tools/gtk/patches/openh264-configure.patch.
  • gtk/jhbuild.modules:
  • wpe/jhbuild.modules:
  • wpe/patches/gst-plugins-good-0003-rtpbin-receive-bundle-support.patch: Removed.
  • wpe/patches/gst-plugins-good-0005-souphttpsrc-cookie-jar-and-context-query-support.patch: Removed.
  • wpe/patches/gst-plugins-good-0006-qtdemux-add-context-for-a-preferred-protection.patch: Removed.
  • wpe/patches/gst-plugins-good-0008-qtdemux-also-push-buffers-without-encryption-info-in.patch: Removed.
  • wpe/patches/gstreamer-0001-protection-added-function-to-filter-system-ids.patch: Removed.

Aug 10, 2017:

11:02 PM Changeset in webkit [220581] by Carlos Garcia Campos
  • 2 edits in trunk/Source/WebKit

[Soup] Do not spawn the network process to setup cookie persistent storage
​https://bugs.webkit.org/show_bug.cgi?id=175424

Reviewed by Sergio Villar Senin.

The persistent storage configuration is saved and passed to network process as creation parameters, so we don't
need to spawn the network process to configure it, when it's created eventually it will use the configuration.

  • UIProcess/soup/WebCookieManagerProxySoup.cpp:

(WebKit::WebCookieManagerProxy::setCookiePersistentStorage): Use sendToNetworkingProcess() instead of
endToNetworkingProcessRelaunchingIfNecessary().

11:01 PM Changeset in webkit [220580] by Carlos Garcia Campos
  • 4 edits in trunk/Source/WebKit

[GTK][WPE] Assertion failure in TimerBase inside WebCore::IconRecord::setImageData
​https://bugs.webkit.org/show_bug.cgi?id=173866
<rdar://problem/33122050>

Reviewed by Michael Catanzaro.

IconDatabase creates and destroys IconRecord objects in both database and main thread. If the IconRecord has a
valid icon, its Image could be created in one thread and destroyed in another, something that is not expected to
happen, because Image has a Timer member. Since we have all the data and we are decoding it right after creating
the Image, we don't really need to keep the Image object around, we could simply take a reference of the encoded
data and the decoded native image to be returned by synchronousIconForPageURL().

  • UIProcess/API/glib/IconDatabase.cpp:

(WebKit::IconDatabase::IconRecord::image): Return NativeImagePtr now.
(WebKit::IconDatabase::IconRecord::setImageData): Create a BitmapImage to decode it and keep a reference to the
encoded data and decoded native image.
(WebKit::IconDatabase::IconRecord::snapshot const): Use m_imageData to get the encoded data.
(WebKit::IconDatabase::synchronousIconForPageURL): Return the native image and whether the icon is known or not.
(WebKit::IconDatabase::IconRecord::loadImageFromResource): Deleted.

  • UIProcess/API/glib/IconDatabase.h:
  • UIProcess/API/glib/WebKitFaviconDatabase.cpp:

(getIconSurfaceSynchronously): Use new API.

10:31 PM Changeset in webkit [220579] by mark.lam@apple.com
  • 18 edits in trunk/Source

Make the MASM_PROBE mechanism mandatory for DFG and FTL builds.
​https://bugs.webkit.org/show_bug.cgi?id=175446
<rdar://problem/33836545>

Reviewed by Saam Barati.

Source/JavaScriptCore:

  • assembler/AbstractMacroAssembler.h:
  • assembler/MacroAssembler.cpp:

(JSC::MacroAssembler::probe):

  • assembler/MacroAssembler.h:
  • assembler/MacroAssemblerARM.cpp:

(JSC::MacroAssembler::probe):

  • assembler/MacroAssemblerARM.h:

(JSC::MacroAssemblerARM::trustedImm32FromPtr):

  • assembler/MacroAssemblerARM64.cpp:

(JSC::MacroAssembler::probe):

  • assembler/MacroAssemblerARMv7.cpp:

(JSC::MacroAssembler::probe):

  • assembler/MacroAssemblerARMv7.h:

(JSC::MacroAssemblerARMv7::trustedImm32FromPtr):

  • assembler/MacroAssemblerPrinter.cpp:
  • assembler/MacroAssemblerPrinter.h:
  • assembler/MacroAssemblerX86Common.cpp:
  • assembler/testmasm.cpp:

(JSC::isSpecialGPR):
(JSC::testProbeModifiesProgramCounter):
(JSC::run):

  • b3/B3LowerToAir.cpp:

(JSC::B3::Air::LowerToAir::print):

  • b3/air/AirPrintSpecial.cpp:
  • b3/air/AirPrintSpecial.h:

Source/WTF:

This is needed in order to support ​https://bugs.webkit.org/show_bug.cgi?id=174645.
One consequence of this is that the DFG will now be disabled for the MIPS and
Windows ports. See:

​https://bugs.webkit.org/show_bug.cgi?id=175447
​https://bugs.webkit.org/show_bug.cgi?id=175449

Also, we should only ENABLE_SIGNAL_BASED_VM_TRAPS if the DFG is enabled. It was
never meaningful to use SIGNAL_BASED_VM_TRAPS with the baseline JIT anyway. This
is a mis-configuration error that is now fixed.

  • wtf/Platform.h:
9:47 PM Changeset in webkit [220578] by mitz@apple.com
  • 4 edits in trunk/Source

Restored svn:ignore values that went missing when the project got renamed.

Source/WebKit:

  • WebKit.xcodeproj: Added property svn:ignore.

Source/WebKitLegacy:

  • WebKitLegacy.xcodeproj: Added property svn:ignore.
9:22 PM Changeset in webkit [220577] by mitz@apple.com
  • 6 edits in trunk/Source/WebCore

Fixed building for macOS 10.12 with the macOS 10.13 SDK.

Suppressed the unguarded-availability-new warning around uses of AVSampleBufferAudioRenderer
and AVSampleBufferRenderSynchronizer. Even though the 10.13 SDK declares them as available
starting in that release, they have been available as SPI earlier.

  • platform/graphics/avfoundation/objc/CDMSessionMediaSourceAVFObjC.h:
  • platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.h:
  • platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:

(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::setHasAvailableAudioSample):
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::addAudioRenderer):
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::removeAudioRenderer):

  • platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.h:
  • platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm:

(-[WebAVSampleBufferErrorListener beginObservingRenderer:]):
(-[WebAVSampleBufferErrorListener stopObservingRenderer:]):
(-[WebAVSampleBufferErrorListener observeValueForKeyPath:ofObject:change:context:]):
(WebCore::SourceBufferPrivateAVFObjC::trackDidChangeEnabled):
(WebCore::SourceBufferPrivateAVFObjC::rendererDidReceiveError):
(WebCore::SourceBufferPrivateAVFObjC::flush):

8:37 PM Changeset in webkit [220576] by jmarcell@apple.com
  • 2 edits in branches/safari-604.1.38.1-branch/Source/WebKit

Cherry-pick r220505. rdar://problem/33829962

8:06 PM Changeset in webkit [220575] by commit-queue@webkit.org
  • 1 edit
    4 adds in trunk/Source/WebInspectorUI

Web Inspector: Add three.js in preparation for layer visualization.
​https://bugs.webkit.org/show_bug.cgi?id=174798

Patch by Ross Kirsling <Ross Kirsling> on 2017-08-10
Reviewed by Brian Burg.

  • UserInterface/External/three.js/LICENSE: Added.
  • UserInterface/External/three.js/OrbitControls.js: Added.
  • UserInterface/External/three.js/three.js: Added.
7:59 PM Changeset in webkit [220574] by beidson@apple.com
  • 10 edits
    7 moves in trunk/Source

Rename the source files for the WTF persistent coders.
​https://bugs.webkit.org/show_bug.cgi?id=175441

Reviewed by Tim Horton.

Source/WebCore:

  • platform/network/NetworkLoadMetrics.h:

Source/WebKit:

  • NetworkProcess/cache/NetworkCacheCoders.h:
  • NetworkProcess/cache/NetworkCacheKey.cpp:
  • NetworkProcess/cache/NetworkCacheKey.h:
  • UIProcess/API/APIContentRuleListStore.cpp:

Source/WTF:

  • WTF.xcodeproj/project.pbxproj:
  • wtf/CMakeLists.txt:
  • wtf/persistence/PersistentCoder.h: Renamed from Source/WTF/wtf/persistence/Coder.h.
  • wtf/persistence/PersistentCoders.cpp: Renamed from Source/WTF/wtf/persistence/Coders.cpp.
  • wtf/persistence/PersistentCoders.h: Renamed from Source/WTF/wtf/persistence/Coders.h.
  • wtf/persistence/PersistentDecoder.cpp: Renamed from Source/WTF/wtf/persistence/Decoder.cpp.
  • wtf/persistence/PersistentDecoder.h: Renamed from Source/WTF/wtf/persistence/Decoder.h.
  • wtf/persistence/PersistentEncoder.cpp: Renamed from Source/WTF/wtf/persistence/Encoder.cpp.
  • wtf/persistence/PersistentEncoder.h: Renamed from Source/WTF/wtf/persistence/Encoder.h.
7:58 PM Changeset in webkit [220573] by jmarcell@apple.com
  • 2 edits in branches/safari-604.1.38.0-branch/Source/WebKit

Cherry-pick r220505. rdar://problem/33829964

7:17 PM Changeset in webkit [220572] by don.olmstead@sony.com
  • 2 edits in trunk/Tools

Unreviewed, adding Ross Kirsling to contributors.json\n\n* Scripts/webkitpy/common/config/contributors.json:\n

6:47 PM Changeset in webkit [220571] by wilander@apple.com
  • 2 edits in trunk/Source/WebKit

Resource Load Statistics: Increase grandfathering time to 7 days
​https://bugs.webkit.org/show_bug.cgi?id=175414
<rdar://problem/33818046>

Reviewed by Brent Fulgham.

  • UIProcess/WebResourceLoadStatisticsStore.h:
6:41 PM Changeset in webkit [220570] by n_wang@apple.com
  • 2 edits in trunk/LayoutTests

Layout test accessibility/press-target-uses-text-descendant-node.html is flaky.
​https://bugs.webkit.org/show_bug.cgi?id=175272
<rdar://problem/33756962>

Since accessibilityPress is async, we shouldn't rely on the timeout.

Reviewed by Chris Fleizach.

  • accessibility/press-target-uses-text-descendant-node.html:
5:41 PM Changeset in webkit [220569] by Yusuke Suzuki
  • 3 edits in trunk/Source/WebCore

Make ThreadGlobalData RefCounted for web thread
​https://bugs.webkit.org/show_bug.cgi?id=175439

Reviewed by Mark Lam.

When the web thread is enabled, we share ThreadGlobalData between the web thread and the main thread.
The problem happens when the main thread is dying. It could start deallocating TLS and the web
thread may see the destructed ThreadGlobalData.

Even though, the current implementation is safe because the main thread do not perform TLS deallocation
in the Darwin environment. But this is not true in Windows. And we should not rely on this condition
that depends on the platforms.

In this patch, we make ThreadGlobalData ThreadSafeRefCounted. This type verbosely describes that
ThreadGlobalData could be shared between threads when the web thread enabled. And make the life time
management simple instead of relying on the platform dependent TLS implementation.

  • platform/ThreadGlobalData.cpp:

(WebCore::ThreadGlobalData::setWebCoreThreadData):
(WebCore::threadGlobalData):

  • platform/ThreadGlobalData.h:

(WebCore::ThreadGlobalData::cachedResourceRequestInitiators): Deleted.
(WebCore::ThreadGlobalData::eventNames): Deleted.
(WebCore::ThreadGlobalData::threadTimers): Deleted.
(WebCore::ThreadGlobalData::qualifiedNameCache): Deleted.
(WebCore::ThreadGlobalData::cachedConverterICU): Deleted.
(WebCore::ThreadGlobalData::cachedConverterTEC): Deleted.

5:41 PM Changeset in webkit [220568] by wilander@apple.com
  • 2 edits in trunk/Source/WebKit

Resource Load Statistics: Add significant figures to telemetry calls
​https://bugs.webkit.org/show_bug.cgi?id=175442
<rdar://problem/33834834>

Reviewed by Brent Fulgham.

With this change, logged values are allowed to have 3 significant figures
as opposed to today's 0 which is wrong.

  • UIProcess/WebResourceLoadStatisticsTelemetry.cpp:

(WebKit::submitTopList):
(WebKit::WebResourceLoadStatisticsTelemetry::calculateAndSubmit):

5:36 PM Changeset in webkit [220567] by Yusuke Suzuki
  • 4 edits in trunk

Unreviewed, attempt to fix build failure with VC2017

Source/WTF:

  • wtf/PriorityQueue.h:

Tools:

  • TestWebKitAPI/Tests/WTF/PriorityQueue.cpp:

(TEST):

5:36 PM Changeset in webkit [220566] by Yusuke Suzuki
  • 3 edits in trunk/Source/WebCore

[JSC] Use @toNumber in builtins
​https://bugs.webkit.org/show_bug.cgi?id=172692

Reviewed by Sam Weinig.

Use @toNumber bytecode intrinsic. It emits op_to_number, which efficiently converts
a given argument to a number.

  • Modules/streams/ReadableByteStreamInternals.js:

(privateInitializeReadableByteStreamController):
(readableByteStreamControllerRespond):

  • Modules/streams/StreamInternals.js:

(validateAndNormalizeQueuingStrategy):
(enqueueValueWithSize):

5:29 PM Changeset in webkit [220565] by Yusuke Suzuki
  • 2 edits in trunk/Tools

Unreviewed, suppress warnings on GCC

  • TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp:

(TestWebKitAPI::CheckedArithmeticTester::run):

5:23 PM Changeset in webkit [220564] by Matt Lewis
  • 2 edits in branches/safari-604.1.38.0-branch/LayoutTests

Unreviwed test gardening. <rdar://problem/33831603>

  • platform/ios-11/TestExpectations:
4:57 PM Changeset in webkit [220563] by mitz@apple.com
  • 2 edits in trunk/Tools

[Xcode] With Xcode 9 developer beta, everything rebuilds when switching between command-line and IDE
​https://bugs.webkit.org/show_bug.cgi?id=173223

Reviewed by Tim Horton.

The rebuilds were happening due to a difference in the compiler options that the IDE and
xcodebuild were specifying. Only the IDE was passing the -index-store-path option. To make
xcodebuild pass that option, too, set INDEX_ENABLE_DATA_STORE to YES and
INDEX_DATA_STORE_DIR to the Index Datastore path specified in Xcode Locations preferences >
Advanced when a Custom Absolute path is selected.

  • Scripts/webkitdirs.pm:

(determineBaseProductDir):

4:42 PM Changeset in webkit [220562] by Yusuke Suzuki
  • 7 edits
    1 copy in trunk

Run more WTF tests
​https://bugs.webkit.org/show_bug.cgi?id=174970

Reviewed by Michael Catanzaro.

Source/WTF:

CHAR_BIT is not defined.

  • wtf/LEBDecoder.h:

Tools:

Some of WTF tests are not executed in non Apple ports while they are generic ones.
This patch adds these tests to non-Apple port TestWebKitAPI.
Currently, we do not add Signals.cpp since it depends on signal functionality.

  • TestWebKitAPI/CMakeLists.txt:
  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/Tests/WTF/PriorityQueue.cpp:

(isHigherPriority):
(TEST):

  • TestWebKitAPI/Tests/WTF/Signals.cpp: Copied from Tools/TestWebKitAPI/Tests/WTF/ThreadMessages.cpp.

(TEST):

  • TestWebKitAPI/Tests/WTF/ThreadMessages.cpp:

(TEST):

4:21 PM Changeset in webkit [220561] by Ryan Haddad
  • 3 edits
    2 copies
    3 adds in branches/safari-604.1.38.1-branch/LayoutTests

Unreviwed test gardening. rdar://problem/33789505

  • imported/w3c/web-platform-tests/WebCryptoAPI/derive_bits_keys/test_pbkdf2_long_empty.https-expected.txt:
  • imported/w3c/web-platform-tests/WebCryptoAPI/derive_bits_keys/test_pbkdf2_short_empty.https-expected.txt:
  • platform/mac-highsierra/http/tests/cookies/js-get-and-set-http-only-cookie-expected.txt: Added.
  • platform/mac-highsierra/imported/w3c/web-platform-tests/WebCryptoAPI/derive_bits_keys/test_pbkdf2_long_empty.https-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/WebCryptoAPI/derive_bits_keys/test_pbkdf2_long_empty.https-expected.txt.
  • platform/mac-highsierra/imported/w3c/web-platform-tests/WebCryptoAPI/derive_bits_keys/test_pbkdf2_short_empty.https-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/WebCryptoAPI/derive_bits_keys/test_pbkdf2_short_empty.https-expected.txt.
4:20 PM Changeset in webkit [220560] by jmarcell@apple.com
  • 7 edits in branches/safari-604.1.38.1-branch/Source

Versioning.

4:18 PM Changeset in webkit [220559] by jmarcell@apple.com
  • 7 edits in branches/safari-604.1.38.0-branch/Source

Versioning.

4:16 PM Changeset in webkit [220558] by jmarcell@apple.com
  • 7 edits in branches/safari-604-branch/Source

Versioning.

4:14 PM Changeset in webkit [220557] by jmarcell@apple.com
  • 1 copy in tags/Safari-604.2.2

Tag Safari-604.2.2.

4:00 PM Changeset in webkit [220556] by mark.lam@apple.com
  • 15 edits in trunk/Source

Apply the UNLIKELY macro to some unlikely things.
​https://bugs.webkit.org/show_bug.cgi?id=175440
<rdar://problem/33834767>

Reviewed by Yusuke Suzuki.

Source/JavaScriptCore:

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::~CodeBlock):
(JSC::CodeBlock::jettison):

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::handleCall):
(JSC::DFG::ByteCodeParser::handleVarargsCall):
(JSC::DFG::ByteCodeParser::handleGetById):
(JSC::DFG::ByteCodeParser::handlePutById):
(JSC::DFG::ByteCodeParser::parseBlock):
(JSC::DFG::ByteCodeParser::parseCodeBlock):

  • dfg/DFGJITCompiler.cpp:

(JSC::DFG::JITCompiler::JITCompiler):
(JSC::DFG::JITCompiler::linkOSRExits):
(JSC::DFG::JITCompiler::link):
(JSC::DFG::JITCompiler::disassemble):

  • dfg/DFGJITFinalizer.cpp:

(JSC::DFG::JITFinalizer::finalizeCommon):

  • dfg/DFGOSRExit.cpp:

(JSC::DFG::OSRExit::compileOSRExit):

  • dfg/DFGPlan.cpp:

(JSC::DFG::Plan::Plan):

  • ftl/FTLJITFinalizer.cpp:

(JSC::FTL::JITFinalizer::finalizeCommon):

  • ftl/FTLLink.cpp:

(JSC::FTL::link):

  • ftl/FTLOSRExitCompiler.cpp:

(JSC::FTL::compileStub):

  • jit/JIT.cpp:

(JSC::JIT::privateCompileMainPass):
(JSC::JIT::compileWithoutLinking):
(JSC::JIT::link):

  • runtime/ScriptExecutable.cpp:

(JSC::ScriptExecutable::installCode):

  • runtime/VM.cpp:

(JSC::VM::VM):

Source/WebKit:

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::getBytecodeProfile):

3:57 PM Changeset in webkit [220555] by Ryan Haddad
  • 2 edits
    46 adds in trunk/LayoutTests

Unreviewed test gardening for High Sierra.

  • platform/mac-highsierra/css1/basic/inheritance-expected.txt: Added.
  • platform/mac-highsierra/css2.1/t0602-c13-inh-underlin-00-e-expected.txt: Added.
  • platform/mac-highsierra/css2.1/t0805-c5522-brdr-02-e-expected.txt: Added.
  • platform/mac-highsierra/css3/selectors3/html/css3-modsel-18-expected.txt: Added.
  • platform/mac-highsierra/css3/selectors3/xhtml/css3-modsel-18-expected.txt: Added.
  • platform/mac-highsierra/css3/selectors3/xml/css3-modsel-18-expected.txt: Added.
  • platform/mac-highsierra/fast/block/basic/001-expected.txt: Added.
  • platform/mac-highsierra/fast/css-generated-content/initial-letter-basic-expected.txt: Added.
  • platform/mac-highsierra/fast/css-generated-content/initial-letter-border-padding-expected.txt: Added.
  • platform/mac-highsierra/fast/css-generated-content/initial-letter-raised-expected.txt: Added.
  • platform/mac-highsierra/fast/css-generated-content/initial-letter-sunken-expected.txt: Added.
  • platform/mac-highsierra/fast/css/css3-nth-child-expected.txt: Added.
  • platform/mac-highsierra/fast/css/text-overflow-input-expected.txt: Added.
  • platform/mac-highsierra/fast/dom/34176-expected.txt: Added.
  • platform/mac-highsierra/fast/dom/clone-node-dynamic-style-expected.txt: Added.
  • platform/mac-highsierra/fast/forms/basic-inputs-expected.txt: Added.
  • platform/mac-highsierra/fast/forms/input-value-expected.txt: Added.
  • platform/mac-highsierra/fast/forms/plaintext-mode-2-expected.txt: Added.
  • platform/mac-highsierra/fast/invalid/003-expected.txt: Added.
  • platform/mac-highsierra/fast/invalid/004-expected.txt: Added.
  • platform/mac-highsierra/fast/invalid/nestedh3s-expected.txt: Added.
  • platform/mac-highsierra/fast/selectors/018-expected.txt: Added.
  • platform/mac-highsierra/fast/table/frame-and-rules-expected.txt: Added.
  • platform/mac-highsierra/fast/text/atsui-multiple-renderers-expected.txt: Added.
  • platform/mac-highsierra/fast/text/bidi-embedding-pop-and-push-same-expected.txt: Added.
  • platform/mac-highsierra/fast/text/font-weights-expected.txt: Added.
  • platform/mac-highsierra/fast/text/font-weights-zh-expected.txt: Added.
  • platform/mac-highsierra/fast/text/indic-expected.txt: Added.
  • platform/mac-highsierra/fast/text/international/complex-character-based-fallback-expected.txt:
  • platform/mac-highsierra/svg/W3C-SVG-1.1/animate-elem-46-t-expected.txt: Added.
  • platform/mac-highsierra/svg/W3C-SVG-1.1/struct-use-01-t-expected.txt: Added.
  • platform/mac-highsierra/svg/batik/text/textStyles-expected.txt: Added.
  • platform/mac-highsierra/tables/mozilla/other/wa_table_thtd_rowspan-expected.txt: Added.
  • platform/mac-highsierra/tables/mozilla/other/wa_table_tr_align-expected.txt: Added.
3:44 PM Changeset in webkit [220554] by jmarcell@apple.com
  • 1 copy in tags/Safari-604.1.38.1.4

Tag Safari-604.1.38.1.4.

3:42 PM Changeset in webkit [220553] by Chris Dumez
  • 2 edits in trunk/Source/WebKit

Turn on support for Beacon API by default in STP
​https://bugs.webkit.org/show_bug.cgi?id=175445
<rdar://problem/33836379>

Reviewed by Youenn Fablet.

  • Shared/WebPreferencesDefinitions.h:
3:39 PM Changeset in webkit [220552] by jmarcell@apple.com
  • 1 copy in tags/Safari-604.1.38.0.4

Tag Safari-604.1.38.0.4.

3:15 PM Changeset in webkit [220551] by n_wang@apple.com
  • 6 edits
    3 adds in trunk

AX: crash at WebCore::AccessibilityObject::supportsARIALiveRegion() const + 24
​https://bugs.webkit.org/show_bug.cgi?id=175340
<rdar://problem/33782159>

Reviewed by Chris Fleizach.

Source/WebCore:

The issue here is that we manualy set the parent object of the AccessibilitySVGRoot object
and there are chances that the parent doesn't detach it properly during the parent's destroying
process. Accessing the stale parent object will lead to a crash.
Fixed this by making the parent object a weak pointer so we don't access an invalid memory.

Test: accessibility/add-children-pseudo-element.html

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::AccessibilityRenderObject):

  • accessibility/AccessibilityRenderObject.h:

(WebCore::AccessibilityRenderObject::createWeakPtr):

  • accessibility/AccessibilitySVGRoot.cpp:

(WebCore::AccessibilitySVGRoot::AccessibilitySVGRoot):
(WebCore::AccessibilitySVGRoot::setParent):
(WebCore::AccessibilitySVGRoot::parentObject const):

  • accessibility/AccessibilitySVGRoot.h:

LayoutTests:

  • accessibility/add-children-pseudo-element-expected.txt: Added.
  • accessibility/add-children-pseudo-element.html: Added.
  • accessibility/resources/svg-circle.svg: Added.
3:08 PM Changeset in webkit [220550] by Ryan Haddad
  • 2 edits in trunk/Source/WebKit

Fix iOS simulator build after change "[WTF] Move TextStream into WTF"
​https://bugs.webkit.org/show_bug.cgi?id=175211

Patch by Ross Kirsling <Ross Kirsling> on 2017-08-10
Reviewed by Myles C. Maxfield.

  • UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _scrollByContentOffset:]):
(-[WKWebView _navigationGestureDidBegin]):

2:51 PM Changeset in webkit [220549] by Chris Dumez
  • 19 edits
    4 adds in trunk

[Beacon] Do connect-src CSP check on redirects as well
​https://bugs.webkit.org/show_bug.cgi?id=175410
<rdar://problem/33815470>

Reviewed by Youenn Fablet.

Source/WebCore:

Pass ContentSecurityPolicy object to createPingHandle so that we can send
enough data to the NetworkProcess so do CSP checks for Ping loads such
as Beacon. For the IPC, we serialize the ContentSecurityPolicy's response
headers. Those headers are now cached in ContentSecurityPolicy for
performance reasons. CSP headers are rarely updated in practice but
sendBeacon() may get called repeatedly for a given document.

Tests: http/wpt/beacon/connect-src-beacon-redirect-allowed.sub.html

http/wpt/beacon/connect-src-beacon-redirect-blocked.sub.html

  • loader/LoaderStrategy.h:
  • loader/PingLoader.cpp:

(WebCore::PingLoader::loadImage):
(WebCore::PingLoader::sendPing):
(WebCore::PingLoader::sendViolationReport):
(WebCore::PingLoader::startPingLoad):

  • loader/PingLoader.h:
  • loader/cache/CachedResource.cpp:

(WebCore::CachedResource::load):

  • page/csp/ContentSecurityPolicy.cpp:

(WebCore::ContentSecurityPolicy::responseHeaders const):
(WebCore::ContentSecurityPolicy::didReceiveHeader):

  • page/csp/ContentSecurityPolicy.h:
  • page/csp/ContentSecurityPolicyResponseHeaders.h:

(WebCore::ContentSecurityPolicyResponseHeaders::encode const):
(WebCore::ContentSecurityPolicyResponseHeaders::decode):

Source/WebKit:

Pass CSP Response headers to the NetworkProcess via NetworkResourceLoadParameters
when doing a PingLoad. This allows PingLoad to do CSP checks (in particular
connect-src ones) in case the ping load gets redirected. Those checks need to be
done on the NetworkProcess side at this point because there is no guarantee the
WebContent process is still around.

To do the CSP checks, PingLoad lazily reconstructs a ContentSecurityPolicy object
from the CSP response headers.

  • NetworkProcess/NetworkResourceLoadParameters.cpp:

(WebKit::NetworkResourceLoadParameters::encode const):
(WebKit::NetworkResourceLoadParameters::decode):

  • NetworkProcess/NetworkResourceLoadParameters.h:
  • NetworkProcess/PingLoad.cpp:

(WebKit::PingLoad::willPerformHTTPRedirection):
(WebKit::PingLoad::contentSecurityPolicy):

  • NetworkProcess/PingLoad.h:
  • WebProcess/Network/WebLoaderStrategy.cpp:

(WebKit::WebLoaderStrategy::createPingHandle):

  • WebProcess/Network/WebLoaderStrategy.h:

Source/WebKitLegacy:

Update createPingHandle() to take in ContentSecurityPolicy
object in but no behavior change for WK1.

  • WebCoreSupport/WebResourceLoadScheduler.cpp:

(WebResourceLoadScheduler::createPingHandle):

  • WebCoreSupport/WebResourceLoadScheduler.h:

LayoutTests:

Add layout test coverage.

  • http/wpt/beacon/connect-src-beacon-redirect-allowed.sub-expected.txt: Added.
  • http/wpt/beacon/connect-src-beacon-redirect-allowed.sub.html: Added.
  • http/wpt/beacon/connect-src-beacon-redirect-blocked.sub-expected.txt: Added.
  • http/wpt/beacon/connect-src-beacon-redirect-blocked.sub.html: Added.
2:19 PM Changeset in webkit [220548] by Yusuke Suzuki
  • 7 edits in trunk/Source

[WTF] ThreadSpecific should not introduce additional indirection
​https://bugs.webkit.org/show_bug.cgi?id=175187

Reviewed by Mark Lam.

Source/JavaScriptCore:

  • runtime/Identifier.cpp:

Source/WebCore:

We drop ThreadSpecific::replace feature which is only used by
Web thread. Instead, we use ThreadSpecific<std::unique_ptr<T>> here.

While this std::unique_ptr<T> shares one instance between main thread
and web thread, this is the same to the current implementation. It is
safe because the web thread never finishes.

And for non-web thread implementation, we just use ThreadSpecific<T>,
since it is the most efficient.

  • platform/ThreadGlobalData.cpp:

(WebCore::ThreadGlobalData::ThreadGlobalData):
(WebCore::ThreadGlobalData::setWebCoreThreadData):
(WebCore::threadGlobalData):
We also drop StringImpl::empty() call since it is not necessary now:
StringImpl::empty data is statically initialized by using constexpr.

  • platform/ThreadGlobalData.h:

We make it FAST_ALLOCATED since it is previously allocated by fast malloc
in ThreadSpecific.

Source/WTF:

ThreadSpecific sets Data* to the TLS. And Data holds T*, which
is fast allocated actual data. But ideally, we should store T
instance directly in Data instead of introducing an additional
indirection.

This patch adds storage in Data in order to embed the instance of T. The constructor
for Data will invoke the constructor for T on the embedded storage. We also drop
ThreadSpecific::replace which is only used by the web thread to set its thread specific
ThreadGlobalData to the one shared from the main thread. The existing implementation
relies on the main thread and the web thread never exiting in order for the shared
ThreadGlobalData to stay alive. We can achieve the same semantics by using a
ThreadSpecific<std::unique_ptr<T>> to hold the ThreadGlobalData instance instead.

  • wtf/ThreadSpecific.h:

(WTF::ThreadSpecific::Data::construct):
(WTF::ThreadSpecific::Data::Data):
We make it fast allocated since we previously allocated ThreadSpecific T data by fastMalloc.

(WTF::ThreadSpecific::Data::~Data):
(WTF::ThreadSpecific::Data::storagePointer const):
(WTF::canBeGCThread>::get):
We also drop RELEASE_ASSERT from ::get(). We already inserted this assert to setAndConstruct(),
so when creating the member to this TLS, we execute this release assert. So it is
not necessary to execute this assertion every time we get data from this TLS.

(WTF::canBeGCThread>::set):
(WTF::canBeGCThread>::destroy):
(WTF::canBeGCThread>::setAndConstruct):
(WTF::T):
(WTF::canBeGCThread>::replace): Deleted.

2:06 PM Changeset in webkit [220547] by jmarcell@apple.com
  • 12 edits in tags/Safari-604.2.1.1

Cherry-pick r220473. rdar://problem/33834103

2:05 PM Changeset in webkit [220546] by jmarcell@apple.com
  • 7 edits in tags/Safari-604.2.1.1/Source

Versioning.

1:50 PM Changeset in webkit [220545] by jmarcell@apple.com
  • 1 copy in tags/Safari-604.2.1.1

Tag Safari-604.2.1.1.

1:49 PM Changeset in webkit [220544] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

Remove obsolete link from webkit-queues status page
​https://bugs.webkit.org/show_bug.cgi?id=175337

Patch by obinna obike <​oobike@apple.com> on 2017-08-10
Reviewed by Aakash Jain.

  • QueueStatusServer/templates/recentstatus.html:

Removed the link to the ews-watcher server.

1:47 PM Changeset in webkit [220543] by Jonathan Bedard
  • 2 edits in trunk/LayoutTests

Mark webgl/webgl-box-shadow.html and webgl/webgl-border.html as failing for ios-device.
​https://bugs.webkit.org/show_bug.cgi?id=175437

Unreviewed test gardening.

  • platform/ios-device/TestExpectations:
1:34 PM Changeset in webkit [220542] by BJ Burg
  • 5 edits
    1 add in trunk

WKPreferences should conform to NSCopying
​https://bugs.webkit.org/show_bug.cgi?id=175303
<rdar://problem/33764939>

Reviewed by Dan Bernstein.

Source/WebKit:

  • UIProcess/API/Cocoa/WKPreferencesPrivate.h:

Add conformance in the private header, as there is not consensus that this
needs to be API.

  • UIProcess/API/Cocoa/WKPreferences.mm:

(-[WKPreferences copyWithZone:]):
Copy the wrapped WebPreferences instance and return its wrapper.

Tools:

Add unit test to make sure a WKPreference and its copy are
not aliased to each other or affect each other's properties.

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/Tests/WebKit2Cocoa/Copying.mm: Added.

(TEST):

12:39 PM Changeset in webkit [220541] by timothy_horton@apple.com
  • 2 edits in trunk/Source/WTF

Fix a silly typo in Compiler.h

  • wtf/Compiler.h:

Heature, indeed.

12:31 PM Changeset in webkit [220540] by Michael Catanzaro
  • 6 edits in trunk

REGRESSION(r220515) [GTK][CMake] Build with ENABLE_GEOLOCATION fails on Debian Jessie
​https://bugs.webkit.org/show_bug.cgi?id=175426

Reviewed by Carlos Alberto Lopez Perez.

.:

  • Source/cmake/FindGeoClue2.cmake:

Source/WebCore:

Also stop using GEOCLUE_LIBRARIES and GEOCLUE_INCLUDE_DIRS, since they are empty. Apparently
we have not actually been using the client library at all this whole time, only the D-Bus
interface.

  • PlatformGTK.cmake:

Source/WebKit:

  • PlatformGTK.cmake:
12:28 PM Changeset in webkit [220539] by beidson@apple.com
  • 14 edits
    2 copies
    14 adds in trunk

Add ServiceWorkerJob.
​https://bugs.webkit.org/show_bug.cgi?id=175241

Reviewed by Tim Horton.

Source/WebCore:

Test: http/tests/workers/service/basic-register.html

This patch does a few things:

  • Adds the spec concept of a ServiceWorkerJob (in the WebProcess, at least)
  • Adds a ServiceWorkerProvider interface for WebKit to implement
  • Actually creates a job for service worker registration and "schedules" it, though it always immediately errors out the promise.

Actually queuing jobs and executing asynchronously is coming up soon.

  • CMakeLists.txt:
  • WebCore.xcodeproj/project.pbxproj:
  • dom/Document.cpp:

(WebCore::Document::sessionID const):

  • dom/Document.h:
  • workers/ServiceWorkerContainer.cpp:

(WebCore::ServiceWorkerContainer::~ServiceWorkerContainer):
(WebCore::ServiceWorkerContainer::addRegistration):
(WebCore::ServiceWorkerContainer::scheduleJob):
(WebCore::ServiceWorkerContainer::jobDidFinish):

  • workers/ServiceWorkerContainer.h:
  • workers/ServiceWorkerJob.cpp: Added.

(WebCore::ServiceWorkerJob::ServiceWorkerJob):
(WebCore::ServiceWorkerJob::~ServiceWorkerJob):
(WebCore::ServiceWorkerJob::failedWithException):

  • workers/ServiceWorkerJob.h: Copied from Source/WebCore/workers/ServiceWorkerContainer.h.

(WebCore::ServiceWorkerJob::createRegisterJob):
(WebCore::ServiceWorkerJob::identifier const):

  • workers/ServiceWorkerJobClient.h: Added.

(WebCore::ServiceWorkerJobClient::~ServiceWorkerJobClient):

  • workers/ServiceWorkerProvider.cpp: Added.

(WebCore::ServiceWorkerProvider::singleton):
(WebCore::ServiceWorkerProvider::setSharedProvider):

  • workers/ServiceWorkerProvider.h: Added.
  • workers/ServiceWorkerRegistrationOptions.h: Copied from Source/WebCore/workers/ServiceWorkerContainer.h.
  • workers/ServiceWorkerRegistrationParameters.cpp: Added.
  • workers/ServiceWorkerRegistrationParameters.h: Added.

Source/WebKit:

  • CMakeLists.txt:
  • WebKit.xcodeproj/project.pbxproj:
  • WebProcess/Storage/WebServiceWorkerProvider.cpp: Added.

(WebKit::WebServiceWorkerProvider::singleton):
(WebKit::WebServiceWorkerProvider::WebServiceWorkerProvider):
(WebKit::WebServiceWorkerProvider::scheduleJob):

  • WebProcess/Storage/WebServiceWorkerProvider.h: Added.
  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::initializeWebProcess):

LayoutTests:

Verifies that the "serviceWorker.register()" job we currently schedule fails as expected.

  • http/tests/workers/service/basic-register-expected.txt: Added.
  • http/tests/workers/service/basic-register.html: Added.
  • http/tests/workers/service/resources/basic-register.js: Added.
  • http/tests/workers/service/resources/empty-worker.js: Added.
  • platform/mac-wk1/TestExpectations:
  • platform/win/TestExpectations:
12:05 PM Changeset in webkit [220538] by timothy_horton@apple.com
  • 10 edits in trunk

Remove some unused lambda captures so that WebKit builds with -Wunused-lambda-capture
​https://bugs.webkit.org/show_bug.cgi?id=175436
<rdar://problem/33667497>

Reviewed by Simon Fraser.

Source/JavaScriptCore:

  • interpreter/Interpreter.cpp:

(JSC::Interpreter::Interpreter):

Source/WebCore:

  • platform/audio/cocoa/MediaSessionManagerCocoa.cpp:

(PlatformMediaSessionManager::updateSessionState):

  • platform/graphics/cocoa/WebCoreDecompressionSession.mm:

(WebCore::WebCoreDecompressionSession::handleDecompressionOutput):

Source/WebKit:

  • UIProcess/UserMediaPermissionRequestManagerProxy.cpp:

(WebKit::UserMediaPermissionRequestManagerProxy::requestUserMediaPermissionForFrame):

  • UIProcess/WebsiteData/WebsiteDataStore.cpp:

(WebKit::WebsiteDataStore::topPrivatelyControlledDomainsWithWebsiteData):

Tools:

  • TestWebKitAPI/Tests/WebCore/FileMonitor.cpp:

(TestWebKitAPI::TEST_F):

11:57 AM Changeset in webkit [220537] by Lucas Forschler
  • 2 edits in trunk/Tools

Fix duplicated code from r220534.

Unreviewed cleanup.

  • Scripts/bisect-builds:
11:47 AM Changeset in webkit [220536] by jiewen_tan@apple.com
  • 4 edits
    1 add in trunk/Tools

[WebCrypto] Enable SerializedCryptoKeyWrapTest in iOS
​https://bugs.webkit.org/show_bug.cgi?id=175344
<rdar://problem/28507240>

Reviewed by Alexey Proskuryakov.

Add entitlements to TestWebKitAPI project for iOS. Then add Keychain Access entitlement to the project.
Finally enable the existing tests for iOS.

  • TestWebKitAPI/Configurations/TestWebKitAPI-iOS.entitlements: Added.
  • TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/Tests/WebCore/cocoa/SerializedCryptoKeyWrap.mm:
11:27 AM Changeset in webkit [220535] by commit-queue@webkit.org
  • 3 edits
    3 deletes in trunk

Unreviewed, rolling out r220463.
​https://bugs.webkit.org/show_bug.cgi?id=175435

unaccepted fix (Requested by n_wang on #webkit).

Reverted changeset:

"AX: crash at
WebCore::AccessibilityObject::supportsARIALiveRegion() const +
24"
​https://bugs.webkit.org/show_bug.cgi?id=175340
​http://trac.webkit.org/changeset/220463

11:22 AM Changeset in webkit [220534] by Lucas Forschler
  • 1 edit
    1 add in trunk/Tools

Write a tool to bisect WebKit builds
​https://bugs.webkit.org/show_bug.cgi?id=174596

Reviewed by Dean Johnson and Kocsen Chung.

  • Scripts/bisect-builds: Added.

(bisect_builds): main bisection algorithm
(download_archive):download an archive from S3 using existing tools
(extract_archive):extract an archive using existing tools
(find_le):Find rightmost value less than or equal to x
(find_ge):Find leftmost item greater than or equal to x
(get_api_url):generate url for the rest api/database
(get_indices_from_revisions):convert revisions to list indexes for bisection
(get_sorted_revisions):retrieve sorted revision list
(get_s3_location_for_revision):calculate the S3 archive storage location
(parse_args):parse command line arguments
(pick_next_build):compute the next build to bisect
(prompt_did_reproduce):prompt user for direction for bisection
(set_webkit_output_dir):set the folder for bisected builds to avoid overwriting engineering build output
(test_archive):Platform specific logic to test downloaded archive
(minified_platforms):return a list of minified platforms in the database
(unminified_platforms):return a list of full platforms in the database
(is_supported_platform):check if platform is supported
(validate_options):validate command line options
(main):

11:17 AM Changeset in webkit [220533] by Lucas Forschler
  • 1 edit
    1 delete in trunk/Tools

Remove bisect-builds script.
​https://bugs.webkit.org/show_bug.cgi?id=175433

Reviewed by Aakash Jain.

  • Scripts/bisect-builds: Removed.
10:04 AM Changeset in webkit [220532] by Michael Catanzaro
  • 21 edits
    5 deletes in trunk

Remove ENABLE_GAMEPAD_DEPRECATED
​https://bugs.webkit.org/show_bug.cgi?id=175361

Reviewed by Carlos Garcia Campos.

.:

  • Source/cmake/FindGUdev.cmake: Removed.
  • Source/cmake/OptionsGTK.cmake:
  • Source/cmake/OptionsMac.cmake:
  • Source/cmake/WebKitFeatures.cmake:

Source/JavaScriptCore:

  • Configurations/FeatureDefines.xcconfig:

Source/WebCore:

  • CMakeLists.txt:
  • Configurations/FeatureDefines.xcconfig:
  • PlatformGTK.cmake:
  • PlatformWPE.cmake:
  • platform/Linux.cmake: Removed.
  • platform/gamepad/deprecated/Gamepads.h: Removed.
  • platform/gamepad/glib/GamepadsGlib.cpp: Removed.
  • platform/gamepad/linux/GamepadDeviceLinux.cpp: Removed.
  • platform/gamepad/linux/GamepadDeviceLinux.h: Removed.

Source/WebCore/PAL:

  • Configurations/FeatureDefines.xcconfig:

Source/WebKit:

  • Configurations/FeatureDefines.xcconfig:

Source/WebKitLegacy/mac:

  • Configurations/FeatureDefines.xcconfig:

Source/WTF:

  • wtf/FeatureDefines.h:

Tools:

  • TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
9:59 AM Changeset in webkit [220531] by mmaxfield@apple.com
  • 3 edits in trunk/Source/WebCore

Addressing post-review comments after r219173.
​https://bugs.webkit.org/show_bug.cgi?id=174149

Unreviewed.

  • css/CSSFontStyleValue.h:
  • editing/EditingStyle.cpp:

(WebCore::identifierForStyleProperty):

9:53 AM Changeset in webkit [220530] by Ryan Haddad
  • 4 edits in trunk/LayoutTests

Update TestExpectations for imported/w3c/web-platform-tests/IndexedDB/interleaved-cursors.html.
​https://bugs.webkit.org/show_bug.cgi?id=170698

Unreviewed test gardening.

  • TestExpectations: Skip test on debug because it times out on every run.
  • platform/ios/TestExpectations: Mark as flaky on Release.
  • platform/mac/TestExpectations: Ditto.
9:33 AM Changeset in webkit [220529] by clopez@igalia.com
  • 4 edits in trunk

REGRESSION(r220515) [GTK][CMake] Build with ENABLE_GEOLOCATION fails on Debian Jessie
​https://bugs.webkit.org/show_bug.cgi?id=175426

Reviewed by Carlos Garcia Campos.

.:

Fix the pkg-config file name.
We really require geoclue-2.0 and not libgeoclue-2.0.

  • Source/cmake/FindGeoClue2.cmake:

Tools:

  • gtk/install-dependencies: libgeoclue-dev packages not really needed on Debian/Ubuntu.
8:44 AM Changeset in webkit [220528] by Antti Koivisto
  • 2 edits in trunk/Source/WebCore

Try to fix windows build.

  • style/StyleUpdate.h:

(WebCore::Style::TextUpdate::TextUpdate):

5:25 AM Changeset in webkit [220527] by zandobersek@gmail.com
  • 2 edits in trunk/Source/WebKit

[GTK] Don't use --whole-archive linking flags for the WebKit2 target libraries
​https://bugs.webkit.org/show_bug.cgi?id=175416

Reviewed by Carlos Garcia Campos.

  • PlatformGTK.cmake: Drop the ADD_WHOLE_ARCHIVE_TO_LIBRARIES instruction

for the WebKit2 target. This unnecessarily bundles complete archive
files both into the main .so library as well as single executables that
are linked against the WebKit2 target.

5:01 AM Changeset in webkit [220526] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

Add Ms2ger as contributor.
​https://bugs.webkit.org/show_bug.cgi?id=175325

Patch by Ms2ger <​Ms2ger@igalia.com> on 2017-08-10
Reviewed by Carlos Alberto Lopez Perez.

  • Scripts/webkitpy/common/config/contributors.json:
4:02 AM Changeset in webkit [220525] by Carlos Garcia Campos
  • 2 edits in trunk/Source/WebCore

[GTK] Crashes in WebCore::PasteboardHelper::fillSelectionData when source file of drag is unavailable
​https://bugs.webkit.org/show_bug.cgi?id=174161

Reviewed by Xabier Rodriguez-Calvar.

In r219385 we changed the early return in fillSelectionData() to check the selection data length instead of the
data pointer. However, the gtk_selection_data_get_length() can return -1, so we need to check also if the value
less than 0. The case of setting an empty string could be valid depending on the target type, so it's better to
return early only when data lenght is less than 0 and handle the 0 length case in each target.

  • platform/gtk/PasteboardHelper.cpp:

(WebCore::PasteboardHelper::fillSelectionData):

3:44 AM Changeset in webkit [220524] by magomez@igalia.com
  • 2 edits in trunk/LayoutTests

Unreviewed GTK+ gardening. Update expectations of several tests failing at r220516.

  • platform/gtk/TestExpectations:
3:20 AM Changeset in webkit [220523] by Antti Koivisto
  • 9 edits in trunk/Source/WebCore

Text renderer updates should be done by RenderTreeUpdater
​https://bugs.webkit.org/show_bug.cgi?id=175417

Reviewed by Andreas Kling.

All render tree mutations should be done by RenderTreeUpdater. Currently
Text::updateRendererAfterContentChange calls RenderText::setTextWithOffset directly.

  • dom/Document.cpp:

(WebCore::Document::updateTextRenderer):

Add range argument.

  • dom/Document.h:
  • dom/Text.cpp:

(WebCore::Text::updateRendererAfterContentChange):

Remove call to setTextWithOffset and pass the range to updateTextRenderer

  • style/RenderTreeUpdater.cpp:

(WebCore::RenderTreeUpdater::updateRenderTree):
(WebCore::RenderTreeUpdater::updateTextRenderer):

Call setTextWithOffset here.

  • style/RenderTreeUpdater.h:
  • style/StyleTreeResolver.cpp:

(WebCore::Style::TreeResolver::resolveComposedTree):

  • style/StyleUpdate.cpp:

(WebCore::Style::Update::textUpdate const):
(WebCore::Style::Update::addText):

Add TextUpdate struct similar to ElementUpdate to pass the range to the RenderTreeUpdater.

  • style/StyleUpdate.h:
1:37 AM Changeset in webkit [220522] by zandobersek@gmail.com
  • 2 edits in trunk/Source/WebCore

Unreviewed GTK+ build fix for ENABLE_GLES2=ON.

  • platform/graphics/texmap/TextureMapperGLHeaders.h:

Define various GL constants that are not provided in GLES2 headers
but are only leveraged in OpenGL calls if at runtime the underlying
OpenGL is GLES2-capable.

12:39 AM Changeset in webkit [220521] by zandobersek@gmail.com
  • 4 edits in trunk/Source/WebCore

[TexMap] Remove GraphicsContext3D usage from BitmapTexturePool
​https://bugs.webkit.org/show_bug.cgi?id=175319

Reviewed by Carlos Garcia Campos.

Drop the GraphicsContext3D reference in BitmapTexturePool now
that the BitmapTextureGL doesn't require it anymore.

No new tests -- no change in behavior.

  • platform/graphics/texmap/BitmapTexturePool.cpp:

(WebCore::BitmapTexturePool::BitmapTexturePool):

  • platform/graphics/texmap/BitmapTexturePool.h:
  • platform/graphics/texmap/TextureMapperGL.cpp:

(WebCore::TextureMapperGL::TextureMapperGL):

12:30 AM Changeset in webkit [220520] by jmarcell@apple.com
  • 21 edits in branches/safari-604-branch

Cherry-pick r220459. rdar://problem/33820790

12:20 AM Changeset in webkit [220519] by zandobersek@gmail.com
  • 6 edits in trunk/Source/WebCore

[TexMap] Drop GraphicsContext3D usage from BitmapTextureGL
​https://bugs.webkit.org/show_bug.cgi?id=175317

Reviewed by Carlos Garcia Campos.

Have BitmapTextureGL use direct OpenGL API entrypoints and constants
instead of leveraging the GraphicsContext3D class. Any GraphicsContext3D
object passed to BitmapTextureGL would assume rendering to the GL context
that's current on that thread, translating method invocations to the
OpenGL API. We can do this by ourselves and benefit by avoiding allocating
GraphicsContext3D resources like the ANGLE compiler that are by most useful
for WebGL.

BitmapTextureGL::create() call sites are adjusted to stop passing a
GraphicsContext3D reference. BitmapTextureGL::bindAsSurface() doesn't need
a replacement for the passed-in GraphicsContext3D object since that object
originated from the TextureMapperGL instance, whose GraphicsContext3D is by
default of the render-to-current-context nature. Other changes are direct
translations of GraphicsContext3D methods to OpenGL API calls, or of
GraphicsContext3D values to OpenGL API constants.

No new tests -- no change in behavior.

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:

(WebCore::MediaPlayerPrivateGStreamerBase::pushTextureToCompositor):

  • platform/graphics/texmap/BitmapTextureGL.cpp:

Also remove an unnecessary GraphicsContext.h header inclusion.
(WebCore::BitmapTextureGL::BitmapTextureGL):
(WebCore::BitmapTextureGL::didReset):
(WebCore::BitmapTextureGL::updateContentsNoSwizzle):
(WebCore::BitmapTextureGL::updateContents):
(WebCore::BitmapTextureGL::initializeStencil):
(WebCore::BitmapTextureGL::initializeDepthBuffer):
(WebCore::BitmapTextureGL::clearIfNeeded):
(WebCore::BitmapTextureGL::createFboIfNeeded):
(WebCore::BitmapTextureGL::bindAsSurface):
(WebCore::BitmapTextureGL::~BitmapTextureGL):
(WebCore::BitmapTextureGL::copyFromExternalTexture):

  • platform/graphics/texmap/BitmapTextureGL.h:

(WebCore::BitmapTextureGL::create):
(WebCore::BitmapTextureGL::textureTarget const):
(WebCore::BitmapTextureGL::internalFormat const):

  • platform/graphics/texmap/BitmapTexturePool.cpp:

(WebCore::BitmapTexturePool::createTexture):

  • platform/graphics/texmap/TextureMapperGL.cpp:

(WebCore::TextureMapperGL::bindSurface):
(WebCore::TextureMapperGL::createTexture):

Note: See TracTimeline for information about the timeline view.