Timeline
Aug 13, 2017:
- 11:55 PM Changeset in webkit [220645] by
-
- 2 edits in releases/WebKitGTK/webkit-2.18/Source/WebKit
Merge r220467 - ServiceWorker experimental feature should not be on by default (definitely not ready).
https://bugs.webkit.org/show_bug.cgi?id=175389
Rubberstamped by Andy Estes.
- Shared/WebPreferencesDefinitions.h: false, not DEFAULT_EXPERIMENTAL_FEATURES_ENABLED
- 11:53 PM Changeset in webkit [220644] by
-
- 2 edits in releases/WebKitGTK/webkit-2.18/Source/WebCore
Merge r220464 - [WinCairo] Fix build after rev 220399
https://bugs.webkit.org/show_bug.cgi?id=175360
Reviewed by Žan Doberšek.
No new tests. No change in behavior.
- platform/graphics/texmap/TextureMapperGLHeaders.h:
- 11:52 PM Changeset in webkit [220643] by
-
- 2 edits in releases/WebKitGTK/webkit-2.18/Source/WebCore
Merge r220461 - [GStreamer][MSE] Add missing lock around getStreamByTrackId
https://bugs.webkit.org/show_bug.cgi?id=175323
Patch by Charlie Turner <cturner@igalia.com> on 2017-08-09
Reviewed by Xabier Rodriguez-Calvar.
Covered by existing tests.
- platform/graphics/gstreamer/mse/PlaybackPipeline.cpp:
(WebCore::PlaybackPipeline::enqueueSample): Ensure the media source
lock is taken before modifiying the track queues indirectly via the
iterator use in getTrackId.
- 11:49 PM Changeset in webkit [220642] by
-
- 3 edits in releases/WebKitGTK/webkit-2.18/JSTests
Merge r220458 - Skip failing JSC tests stress/regress-169783.js and wasm.yaml/wasm/stress/oom.js.
https://bugs.webkit.org/show_bug.cgi?id=175255
Unreviewed test gardening.
- stress/regress-169783.js:
- wasm/stress/oom.js:
- 11:46 PM Changeset in webkit [220641] by
-
- 2 edits in releases/WebKitGTK/webkit-2.18/Source/WebCore
Merge r220454 - Remove unnecessary copies of PlatformMediaSessionManager::m_sessions
https://bugs.webkit.org/show_bug.cgi?id=175375
Patch by Ms2ger <Ms2ger@igalia.com> on 2017-08-09
Reviewed by Sam Weinig.
Remove unnecessary copies of PlatformMediaSessionManager::m_sessions.
These should have been removed in r207688.
No new tests: no behavior change.
- platform/audio/PlatformMediaSessionManager.cpp:
(WebCore::PlatformMediaSessionManager::applicationWillBecomeInactive const):
(WebCore::PlatformMediaSessionManager::applicationDidBecomeActive const):
(WebCore::PlatformMediaSessionManager::applicationDidEnterBackground const):
(WebCore::PlatformMediaSessionManager::applicationWillEnterForeground const):
- 11:44 PM Changeset in webkit [220640] by
-
- 11 edits in releases/WebKitGTK/webkit-2.18
Merge r220453 - Reinstate active flag for iterators
https://bugs.webkit.org/show_bug.cgi?id=175312
Reviewed by Sam Weinig.
LayoutTests/imported/w3c:
Resync WPT tests from upstream to gain test coverage.
- web-platform-tests/dom/traversal/NodeIterator-expected.txt:
- web-platform-tests/dom/traversal/NodeIterator.html:
- web-platform-tests/dom/traversal/TreeWalker-expected.txt:
- web-platform-tests/dom/traversal/TreeWalker.html:
Source/WebCore:
NodeIterator / TreeWalker should no longer allow recursive filters
after the following change to the DOM specification:
This patch aligns our behavior with the latest specification.
No new tests, updated existing tests.
- dom/NodeIterator.cpp:
(WebCore::NodeIterator::nextNode):
(WebCore::NodeIterator::previousNode):
Note that we now also call m_candidateNode.clear() before returning an
exception. This was a pre-existing bug that we failed to do so in the
exception case but it became more obvious after this change now that
we throw. This was causing traversal/moz-bug559526.html to fail
otherwise (the filter was called one too many times). The test case
is passing in Firefox (The filter is called 4 times and they throw
each time).
- dom/Traversal.cpp:
(WebCore::NodeIteratorBase::NodeIteratorBase):
(WebCore::NodeIteratorBase::acceptNode):
- dom/Traversal.h:
- dom/TreeWalker.cpp:
- 11:31 PM Changeset in webkit [220639] by
-
- 12 edits2 adds in trunk
Composition underline color is always black
https://bugs.webkit.org/show_bug.cgi?id=174675
Reviewed by Ryosuke Niwa.
Source/WebCore:
This patch uses the current color of the text instead of black
for the composition underline marker.
This makes it visible in the case we have a black/dark background.
Test: editing/composition-underline-color.html
- editing/CompositionUnderline.h:
(WebCore::CompositionUnderline::CompositionUnderline):
Added new attribute compositionUnderlineColor.
- rendering/InlineTextBox.cpp:
(WebCore::InlineTextBox::paintCompositionUnderline):
Use the text color if compositionUnderlineColor is TextColor.
Source/WebKit:
This patch uses the current color of the text instead of black
for the composition underline marker.
This makes it visible in the case we have a black/dark background.
- UIProcess/Cocoa/WebViewImpl.mm:
(WebKit::extractUnderlines): If NSUnderlineColorAttributeName
is not present use text color for composition underline.
(WebKit::WebViewImpl::setMarkedText): Use text color
for composition underline in the plain text case.
- UIProcess/gtk/InputMethodFilter.cpp:
(WebKit::InputMethodFilter::handleKeyboardEventWithCompositionResults):
Use text color for composition underline.
(WebKit::InputMethodFilter::updatePreedit): Ditto.
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::setCompositionForTesting): Ditto.
Source/WebKitLegacy/mac:
- WebView/WebHTMLView.mm:
(extractUnderlines): If NSUnderlineColorAttributeName
is not present use text color for composition underline.
(-[WebHTMLView setMarkedText:selectedRange:]): Use text color
for composition underline in the plain text case.
Source/WebKitLegacy/win:
- WebView.cpp:
(WebView::setCompositionForTesting): Use text color for
composition underline.
LayoutTests:
Added new test to check that the composition underline
is using the text color.
The test hides the text and the caret, so it only shows
the composition underline and checks against an -expected-mismatch
that the color of the composition marker is different.
- editing/composition-underline-color-expected-mismatch.html: Added.
- editing/composition-underline-color.html: Added.
- 11:23 PM Changeset in webkit [220638] by
-
- 2 edits in trunk/Source/WebCore
[GTK] stop kinetic scrolling when a zero movement is reached
https://bugs.webkit.org/show_bug.cgi?id=175468
Reviewed by Michael Catanzaro.
This is GTK+ change by Christian Hergert.
https://git.gnome.org/browse/gtk+/commit/?h=gtk-3-22&id=4f63d839550f7a9038b391e7d3e1e6fc8bdfafa6
When the kinetic scrolling reduces its speed, there can be multiple frames where the movement is zero pixels,
followed by a 1 pixel movement later on. This causes a "jitter" right at the end of the scroll which makes it
feel less quality than other platforms. Instead, we should just clamp it as soon as we get a zero movement.
- platform/ScrollAnimationKinetic.cpp:
(WebCore::ScrollAnimationKinetic::PerAxisData::animateScroll):
- 11:06 PM Changeset in webkit [220637] by
-
- 3 edits in releases/WebKitGTK/webkit-2.18/LayoutTests
Merge r220450 - [GTK] [WPE] Update expectations for global-constructors-attributes.html.
https://bugs.webkit.org/show_bug.cgi?id=175373
Unreviewed test gardening.
Patch by Ms2ger <Ms2ger@igalia.com> on 2017-08-09
- platform/gtk/js/dom/global-constructors-attributes-expected.txt:
- platform/wpe/js/dom/global-constructors-attributes-expected.txt:
- 11:00 PM Changeset in webkit [220636] by
-
- 5 edits in releases/WebKitGTK/webkit-2.18
Merge r220449 - REGRESSION: 2 test262/test/language/statements/async-function failures
https://bugs.webkit.org/show_bug.cgi?id=175334
Reviewed by Yusuke Suzuki.
JSTests:
Add @skip parameters to tests, and remove test for async iterator from
async await syntax test because it is already covered by async-iterator-syntax.js
- stress/async-await-syntax.js:
- stress/async-iteration-syntax.js:
Source/JavaScriptCore:
Switch off useAsyncIterator by default
- runtime/Options.h:
- 10:56 PM Changeset in webkit [220635] by
-
- 2 edits in branches/safari-604-branch/Source/WebKit
Cherry-pick r220571. rdar://problem/33829966
- 10:56 PM Changeset in webkit [220634] by
-
- 6 edits3 adds in branches/safari-604-branch
Cherry-pick r220551. rdar://problem/33843388
- 10:55 PM Changeset in webkit [220633] by
-
- 2 edits in branches/safari-604-branch/Source/WebKit
Cherry-pick r220505. rdar://problem/33829966
- 2:07 PM Changeset in webkit [220632] by
-
- 10 edits in trunk/Source/WebCore
Drop non-const getter for CachedResource::resourceRequest()
https://bugs.webkit.org/show_bug.cgi?id=175524
Reviewed by Youenn Fablet.
Drop non-const getter for CachedResource::resourceRequest(). It would be unsafe to modify the request of a CachedResource
after it has been cached. Exposing such a getter is therefore a footgun.
- loader/LinkLoader.cpp:
(WebCore::LinkLoader::preloadIfNeeded):
- loader/cache/CachedImage.cpp:
(WebCore::CachedImage::CachedImage):
- loader/cache/CachedImage.h:
- loader/cache/CachedResource.cpp:
(WebCore::CachedResource::CachedResource):
- loader/cache/CachedResource.h:
(WebCore::CachedResource::resourceRequest const):
(WebCore::CachedResource::ignoreForRequestCount const):
(WebCore::CachedResource::setIgnoreForRequestCount):
- loader/cache/CachedResourceLoader.cpp:
(WebCore::CachedResourceLoader::requestResource):
- loader/cache/CachedResourceRequest.h:
(WebCore::CachedResourceRequest::ignoreForRequestCount const):
(WebCore::CachedResourceRequest::setIgnoreForRequestCount):
- loader/cache/MemoryCache.cpp:
(WebCore::MemoryCache::addImageToCache):
- platform/network/ResourceRequestBase.h:
- 5:13 AM Changeset in webkit [220631] by
-
- 9 edits1 move in trunk
[WPE] Implement WebCore::standardUserAgent()
https://bugs.webkit.org/show_bug.cgi?id=175507
Reviewed by Carlos Alberto Lopez Perez.
Implement missing User-Agent handling for the WPE port by sharing the code with the GTK+ port.
.:
- Source/cmake/OptionsGTK.cmake: Rename "GTK" with "GLIB" in UA version macros.
- Source/cmake/OptionsWPE.cmake: Add UA version macros.
Source/WebCore:
- PlatformGTK.cmake: Handlde renaming of UserAgentGtk.cpp to UserAgentGLib.cpp.
- PlatformWPE.cmake: Add UserAgentGLib.cpp and UserAgentQuirks.cpp to the list of built WebCore sources.
- platform/glib/UserAgentGLib.cpp: Renamed from Source/WebCore/platform/gtk/UserAgentGtk.cpp.
(WebCore::versionForUAString): Change "GTK" in UA version macros to "GLIB".
Source/WebKit:
- UIProcess/API/glib/WebKitSettings.cpp: Remove preprocessor conditionals for the WPE port.
(webkit_settings_set_user_agent):
(webkit_settings_set_user_agent_with_application_details):
- UIProcess/wpe/WebPageProxyWPE.cpp:
(WebKit::WebPageProxy::standardUserAgent): Remove hardcoded value and make use of WebCore::standardUserAgent().
Aug 12, 2017:
- 11:47 PM Changeset in webkit [220630] by
-
- 3 edits in trunk/Source/JavaScriptCore
[ARM64] Use x29 and x30 instead of fp and lr to make GCC happy
https://bugs.webkit.org/show_bug.cgi?id=175512
<rdar://problem/33863584>
Reviewed by Mark Lam.
- CMakeLists.txt: Added MacroAssemblerARM64.cpp.
- assembler/MacroAssemblerARM64.cpp: Use x29 and x30 instead of fp and lr to make GCC happy.
- 11:22 PM Changeset in webkit [220629] by
-
- 2 edits in trunk/Source/JavaScriptCore
ARM_TRADITIONAL: static assertion failed: ProbeContext_size_matches_ctiMasmProbeTrampoline
https://bugs.webkit.org/show_bug.cgi?id=175513
Reviewed by Mark Lam.
- assembler/MacroAssemblerARM.cpp: Added d16-d31 FP registers too.
- 6:59 PM Changeset in webkit [220628] by
-
- 6 edits in trunk/Source/JavaScriptCore
FTL's compileGetTypedArrayByteOffset needs to do caging
https://bugs.webkit.org/show_bug.cgi?id=175366
Reviewed by Saam Barati.
While implementing boxing in the DFG, I noticed that there was some missing boxing in the FTL. This
fixes the case in GetTypedArrayByteOffset, and files FIXMEs for more such cases.
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compileGetTypedArrayByteOffset):
- ftl/FTLLowerDFGToB3.cpp:
(JSC::FTL::DFG::LowerDFGToB3::compileGetTypedArrayByteOffset):
(JSC::FTL::DFG::LowerDFGToB3::cagedMayBeNull):
- runtime/ArrayBuffer.h:
- runtime/ArrayBufferView.h:
- runtime/JSArrayBufferView.h:
- 3:14 PM Changeset in webkit [220627] by
-
- 43 edits3 adds in trunk
Replace DATA_TRANSFER_ITEMS by a runtime flag and add a stub implementation
https://bugs.webkit.org/show_bug.cgi?id=175474
.:
<rdar://problem/33844628>
Reviewed by Wenson Hsieh.
- Source/cmake/OptionsMac.cmake:
- Source/cmake/OptionsWin.cmake:
- Source/cmake/WebKitFeatures.cmake:
- Source/cmake/tools/vsprops/FeatureDefines.props:
- Source/cmake/tools/vsprops/FeatureDefinesCairo.props:
Source/JavaScriptCore:
<rdar://problem/33844628>
Reviewed by Wenson Hsieh.
- Configurations/FeatureDefines.xcconfig:
- runtime/CommonIdentifiers.h:
Source/WebCore:
<rdar://problem/33844628>
Reviewed by Wenson Hsieh.
Replaced the build flag by a runtime flag and added a stub implementation for DataTransferItemList
and DataTransferItem to make it compile. DataTransferItemList is created lazily by DataTransfer.items,
and its lifetime is tied to DataTransfer by forwarding ref and deref.
See https://html.spec.whatwg.org/multipage/dnd.html#the-datatransferitemlist-interface
Tests: editing/pasteboard/datatransfer-idl.html
- CMakeLists.txt:
- Configurations/FeatureDefines.xcconfig:
- WebCore.xcodeproj/project.pbxproj:
- dom/DataTransfer.cpp:
(WebCore::DataTransfer::items): Added. Create DataTransferItemList lazily
- dom/DataTransfer.h:
- dom/DataTransfer.idl:
- dom/DataTransferItem.cpp:
(WebCore::DataTransferItem::DataTransferItem): Added a stub implementation.
(WebCore::DataTransferItem::~DataTransferItem): Ditto.
(WebCore::DataTransferItem::getAsString const): Ditto.
(WebCore::DataTransferItem::getAsFile const): Ditto.
- dom/DataTransferItem.h:
(WebCore::DataTransferItemList): Devirtualized functions.
(WebCore::DataTransferItemList::kind const):
(WebCore::DataTransferItemList::type const):
- dom/DataTransferItem.idl:
- dom/DataTransferItemList.cpp: Added.
(WebCore::DataTransferItemList::length const): Added a stub implementation.
(WebCore::DataTransferItemList::item): Ditto.
(WebCore::DataTransferItemList::add): Ditto.
(WebCore::DataTransferItemList::remove): Ditto.
(WebCore::DataTransferItemList::clear): Ditto.
- dom/DataTransferItemList.h:
(WebCore::DataTransferItemList::DataTransferItemList):
(WebCore::DataTransferItemList::~DataTransferItemList): Deleted.
(WebCore::DataTransferItemList::ref): Forwards to DataTransfer's ref.
(WebCore::DataTransferItemList::deref): Ditto.
- dom/DataTransferItemList.idl: Updated to match the latest specification.
- page/RuntimeEnabledFeatures.h:
(WebCore::RuntimeEnabledFeatures::setDataTransferItemsEnabled): Added.
(WebCore::RuntimeEnabledFeatures::dataTransferItemsEnabled const): Added.
Source/WebCore/PAL:
<rdar://problem/33844628>
Reviewed by Wenson Hsieh.
- Configurations/FeatureDefines.xcconfig:
Source/WebKit:
<rdar://problem/33844628>
Reviewed by Wenson Hsieh.
Replaced the build flag by a runtime flag and disabled the feature by default.
- Configurations/FeatureDefines.xcconfig:
- Shared/WebPreferencesDefinitions.h:
- UIProcess/API/C/WKPreferences.cpp:
(WKPreferencesSetDataTransferItemsEnabled): Added to be used by WebKitTestRunner.
(WKPreferencesGetDataTransferItemsEnabled): Ditto.
- UIProcess/API/C/WKPreferencesRefPrivate.h:
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::updatePreferences):
Source/WebKitLegacy/mac:
<rdar://problem/33844628>
Reviewed by Wenson Hsieh.
Replaced the build flag by a runtime flag and disabled the feature by default.
- Configurations/FeatureDefines.xcconfig:
- WebView/WebPreferenceKeysPrivate.h:
- WebView/WebPreferences.mm:
(+[WebPreferences initialize]): Disables dataTransfer.items by default.
(-[WebPreferences dataTransferItemsEnabled]): Added.
(-[WebPreferences setDataTransferItemsEnabled:]): Added.
- WebView/WebPreferencesPrivate.h:
- WebView/WebView.mm:
(-[WebView _preferencesChanged:]):
Source/WTF:
Reviewed by Wenson Hsieh.
- wtf/FeatureDefines.h:
Tools:
<rdar://problem/33844628>
Reviewed by Wenson Hsieh.
Enable dataTransfer.items by default in DumpRenderTree and WebKitTestRunner for testing purposes.
- DumpRenderTree/mac/DumpRenderTree.mm:
(resetWebPreferencesToConsistentValues):
- WebKitTestRunner/TestController.cpp:
(WTR::TestController::resetPreferencesToConsistentValues):
LayoutTests:
<rdar://problem/33844628>
Reviewed by Wenson Hsieh.
Added a W3C-style IDL test.
- editing/pasteboard/datatransfer-idl.html: Added.
- 2:58 PM Changeset in webkit [220626] by
-
- 34 edits in trunk
Address flakiness related to download tests
https://bugs.webkit.org/show_bug.cgi?id=175338
Reviewed by Ryosuke Niwa.
LayoutTests/imported/w3c:
Rebaseline several WPT tests now that download callbacks are no longer logged.
- web-platform-tests/html/semantics/embedded-content/the-area-element/area-download-click-expected.txt:
- web-platform-tests/html/semantics/text-level-semantics/the-a-element/a-download-click-expected.txt:
Tools:
- Update WKTR so that the flag set by testRunner.waitUntilDownloadFinished() is actually queried when a download completes. Previously, this would be identical to a call to testRunner.waitUntilDone() because any download completion would call testRunner.notifyDone().
- Disable logging of download callbacks by default and add a testRunner.setShouldLogDownloadCallbacks(true) API to allow tests to enable such logging.
- WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
- WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
(WTR::InjectedBundle::didReceiveMessageToPage):
- WebKitTestRunner/InjectedBundle/TestRunner.cpp:
(WTR::TestRunner::setShouldLogDownloadCallbacks):
- WebKitTestRunner/InjectedBundle/TestRunner.h:
- WebKitTestRunner/TestController.cpp:
(WTR::TestController::downloadDidStart):
(WTR::TestController::decideDestinationWithSuggestedFilename):
(WTR::TestController::downloadDidFinish):
(WTR::TestController::downloadDidFail):
(WTR::TestController::downloadDidCancel):
- WebKitTestRunner/TestController.h:
(WTR::TestController::setShouldLogDownloadCallbacks):
- WebKitTestRunner/TestInvocation.cpp:
(WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
LayoutTests:
Unmark several download tests as flaky.
- fast/dom/HTMLAnchorElement/anchor-download-synthetic-click.html:
- fast/dom/HTMLAnchorElement/anchor-download-user-triggered-synthetic-click.html:
- fast/dom/HTMLAnchorElement/anchor-download.html:
- fast/dom/HTMLAnchorElement/anchor-file-blob-convert-to-download.html:
- fast/dom/HTMLAnchorElement/anchor-file-blob-download-includes-backslash.html:
- fast/dom/HTMLAnchorElement/anchor-file-blob-download-includes-doublequote.html:
- fast/dom/HTMLAnchorElement/anchor-file-blob-download-includes-slashes.html:
- fast/dom/HTMLAnchorElement/anchor-file-blob-download-includes-unicode.html:
- fast/dom/HTMLAnchorElement/anchor-file-blob-download-no-extension.html:
- fast/dom/HTMLAnchorElement/anchor-file-blob-download.html:
- fast/dom/HTMLAnchorElement/anchor-nodownload-set.html:
- http/tests/download/anchor-download-attribute-content-disposition.html:
- http/tests/download/anchor-download-no-extension.html:
- http/tests/download/anchor-download-no-value.html:
- http/tests/download/area-download-expected.txt:
- http/tests/download/area-download.html:
- http/tests/security/anchor-download-allow-blob-expected.txt:
- http/tests/security/anchor-download-allow-blob.html:
- http/tests/security/anchor-download-allow-data-expected.txt:
- http/tests/security/anchor-download-allow-data.html:
- http/tests/security/anchor-download-allow-sameorigin.html:
Update download tests to explicitly enable download callbacks logging.
- 11:44 AM Changeset in webkit [220625] by
-
- 14 edits in trunk
Caging shouldn't have to use a patchpoint for adding
https://bugs.webkit.org/show_bug.cgi?id=175483
Reviewed by Mark Lam.
Source/JavaScriptCore:
Caging involves doing a Add(ptr, largeConstant). All of B3's heuristics for how to deal with
constants and associative operations dictate that you always want to sink constants. For example,
Add(Add(a, constant), b) always becomes Add(Add(a, b), constant). This is profitable because in
typical code, it reveals downstream optimizations. But it's terrible in the case of caging, because
we want the large constant (which is shared by all caging operations) to be hoisted. Reassociating to
sink constants obscures the constant in this case. Currently, moveConstants is not smart enough to
reassociate, so instead of sinking largeConstant, it tries (and often fails) to sink some other
constants instead. Without some hacks, this is a 5% Kraken regression and a 1.6% Octane regression.
It's not clear that moveConstants could ever be smart enough to rematerialize that constant and then
hoist it - that would require quite a bit of algebraic reasoning. But the only case we know of where
our current constant reassociation heuristics are wrong is caging. So, we can get away with some
hacks for just stopping B3's reassociation only in this specific case.
Previously, we achieved this by concealing the Add(ptr, largeConstant) inside a patchpoint. That's
OK, but patchpoints are expensive. They require a SharedTask instance. They require callbacks from
the backend, including during register allocation. And they cannot be CSE'd. We do want B3 to know
that if we cage the same pointer in two places, both places will compute the same value.
This patch improves the situation by introducing the Opaque opcode. This is handled by LowerToAir as
if it was Identity, but all prior phases treat it as an unknown pure unary idempotent operation. I.e.
they know that Opaque(x) == Opaque(x) and that Opaque(Opaque(x)) == Opaque(x). But they don't know
that Opaque(x) == x until LowerToAir. So, you can use Opaque exactly when you know that B3 will mess
up your code but Air won't. (Currently we know of no cases where Air messes things up on a large
enough scale to warrant new opcodes.)
This change is perf-neutral, but may start to help as I add more uses of caged() in the FTL. It also
makes the code a bit less ugly.
- b3/B3LowerToAir.cpp:
(JSC::B3::Air::LowerToAir::shouldCopyPropagate):
(JSC::B3::Air::LowerToAir::lower):
- b3/B3Opcode.cpp:
(WTF::printInternal):
- b3/B3Opcode.h:
- b3/B3ReduceStrength.cpp:
- b3/B3Validate.cpp:
- b3/B3Value.cpp:
(JSC::B3::Value::effects const):
(JSC::B3::Value::key const):
(JSC::B3::Value::isFree const):
(JSC::B3::Value::typeFor):
- b3/B3Value.h:
- b3/B3ValueKey.cpp:
(JSC::B3::ValueKey::materialize const):
- ftl/FTLLowerDFGToB3.cpp:
(JSC::FTL::DFG::LowerDFGToB3::caged):
- ftl/FTLOutput.cpp:
(JSC::FTL::Output::opaque):
- ftl/FTLOutput.h:
Websites/webkit.org:
Write documentation for the new Opaque opcode.
- docs/b3/intermediate-representation.html:
- 11:40 AM Changeset in webkit [220624] by
-
- 5 edits in trunk/Source/JavaScriptCore
ScopedArguments overflow storage needs to be in the JSValue gigacage
https://bugs.webkit.org/show_bug.cgi?id=174923
Reviewed by Saam Barati.
ScopedArguments overflow storage sits at the end of the ScopedArguments object, so we put that
object into the JSValue gigacage.
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compileGetByValOnScopedArguments):
- ftl/FTLLowerDFGToB3.cpp:
(JSC::FTL::DFG::LowerDFGToB3::compileGetByVal):
- jit/JITPropertyAccess.cpp:
(JSC::JIT::emitScopedArgumentsGetByVal):
- runtime/ScopedArguments.h:
(JSC::ScopedArguments::subspaceFor):
(JSC::ScopedArguments::overflowStorage const):
