Timeline

Aug 16, 2017:

11:58 PM Changeset in webkit [220832] by Carlos Garcia Campos

• 33 edits
  35 deletes in releases/WebKitGTK/webkit-2.18

Merge r220734 - Remove Proximity Events and related code
​https://bugs.webkit.org/show_bug.cgi?id=175545

Reviewed by Daniel Bates.

No platform enables Proximity Events, so remove code inside ENABLE(PROXIMITY_EVENTS)
and other related code.

.:

• Source/cmake/OptionsMac.cmake:
• Source/cmake/OptionsWin.cmake:
• Source/cmake/WebKitFeatures.cmake:
• Source/cmake/tools/vsprops/FeatureDefines.props:
• Source/cmake/tools/vsprops/FeatureDefinesCairo.props:

Source/JavaScriptCore:

• Configurations/FeatureDefines.xcconfig:

Source/WebCore:

• CMakeLists.txt:
• Configurations/FeatureDefines.xcconfig:
• DerivedSources.cpp:
• Modules/proximity/DeviceProximityClient.h: Removed.
• Modules/proximity/DeviceProximityController.cpp: Removed.
• Modules/proximity/DeviceProximityController.h: Removed.
• Modules/proximity/DeviceProximityEvent.cpp: Removed.
• Modules/proximity/DeviceProximityEvent.h: Removed.
• Modules/proximity/DeviceProximityEvent.idl: Removed.
• dom/EventNames.h:
• dom/EventNames.in:
• history/PageCache.cpp:

(WebCore::canCachePage):

• page/DOMWindow.cpp:

(WebCore::DOMWindow::addEventListener):
(WebCore::DOMWindow::removeEventListener):
(WebCore::DOMWindow::removeAllEventListeners):

• page/DOMWindow.idl:
• page/DiagnosticLoggingKeys.cpp:

(WebCore::DiagnosticLoggingKeys::deviceProximityKey): Deleted.

• page/DiagnosticLoggingKeys.h:
• testing/Internals.cpp:

(WebCore::Internals::setDeviceProximity): Deleted.

• testing/Internals.h:
• testing/Internals.idl:

Source/WebCore/PAL:

• Configurations/FeatureDefines.xcconfig:

Source/WebInspectorUI:

• UserInterface/Models/ScriptTimelineRecord.js:

(WI.ScriptTimelineRecord.EventType.displayName):

Source/WebKit:

• CMakeLists.txt:
• Configurations/FeatureDefines.xcconfig:
• WebProcess/WebCoreSupport/WebDeviceProximityClient.cpp: Removed.
• WebProcess/WebCoreSupport/WebDeviceProximityClient.h: Removed.
• WebProcess/WebPage/WebPage.cpp:

(WebKit::m_cpuLimit):

Source/WebKitLegacy/mac:

• Configurations/FeatureDefines.xcconfig:

Source/WTF:

• wtf/FeatureDefines.h:

Tools:

• TestWebKitAPI/Configurations/FeatureDefines.xcconfig:

LayoutTests:

• fast/events/constructors/device-proximity-event-constructor-expected.txt: Removed.
• fast/events/constructors/device-proximity-event-constructor.html: Removed.
• platform/gtk/TestExpectations:
• platform/ios/TestExpectations:
• platform/mac/TestExpectations:
• platform/win/TestExpectations:
• proximity/add-listener-from-callback-expected.txt: Removed.
• proximity/add-listener-from-callback.html: Removed.
• proximity/basic-operation-expected.txt: Removed.
• proximity/basic-operation.html: Removed.
• proximity/check-event-deviceproximity-expected.txt: Removed.
• proximity/check-event-deviceproximity.html: Removed.
• proximity/create-event-deviceproximity-expected.txt: Removed.
• proximity/create-event-deviceproximity.html: Removed.
• proximity/create-event-expected.txt: Removed.
• proximity/create-event.html: Removed.
• proximity/event-after-navigation-expected.txt: Removed.
• proximity/event-after-navigation.html: Removed.
• proximity/multiple-frames-expected.txt: Removed.
• proximity/multiple-frames.html: Removed.
• proximity/no-page-cache-expected.txt: Removed.
• proximity/no-page-cache.html: Removed.
• proximity/optional-event-properties-expected.txt: Removed.
• proximity/optional-event-properties.html: Removed.
• proximity/resources/cached-page-1.html: Removed.
• proximity/resources/cached-page-2.html: Removed.
• proximity/resources/event-after-navigation-new.html: Removed.
• proximity/updates-expected.txt: Removed.
• proximity/updates.html: Removed.
• proximity/window-property-expected.txt: Removed.
• proximity/window-property.html: Removed.

11:58 PM Changeset in webkit [220831] by Carlos Garcia Campos

• 21 edits
  6 deletes in releases/WebKitGTK/webkit-2.18

Merge r220732 - Remove ENABLE(REQUEST_AUTOCOMPLETE) code, which was disabled everywhere
​https://bugs.webkit.org/show_bug.cgi?id=175504

Reviewed by Sam Weinig.
Source/JavaScriptCore:

• Configurations/FeatureDefines.xcconfig:

Source/WebCore:

REQUEST_AUTOCOMPLETE was added in r133396 then removed in r148731, but brought back in r173596,
however no further work was done, and it was left disabled. So remove the code.

• Configurations/FeatureDefines.xcconfig:
• DerivedSources.make:
• WebCore.xcodeproj/project.pbxproj:
• dom/AutocompleteErrorEvent.h: Removed.
• dom/AutocompleteErrorEvent.idl: Removed.
• dom/EventNames.in:
• dom/GlobalEventHandlers.idl:
• html/HTMLFormElement.cpp:

(WebCore::HTMLFormElement::HTMLFormElement):
(WebCore::HTMLFormElement::requestAutocomplete): Deleted.
(WebCore::HTMLFormElement::finishRequestAutocomplete): Deleted.
(WebCore::HTMLFormElement::requestAutocompleteTimerFired): Deleted.

• html/HTMLFormElement.h:
• html/HTMLFormElement.idl:
• loader/EmptyClients.cpp:
• loader/FrameLoaderClient.h:

Source/WebCore/PAL:

• Configurations/FeatureDefines.xcconfig:

Source/WebKit:

• Configurations/FeatureDefines.xcconfig:
• WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::didRequestAutocomplete): Deleted.

• WebProcess/WebCoreSupport/WebFrameLoaderClient.h:

Source/WebKitLegacy/mac:

• Configurations/FeatureDefines.xcconfig:
• DOM/DOMHTMLFormElement.mm:

(-[DOMHTMLFormElement requestAutocomplete]): Deleted.

• WebCoreSupport/WebFrameLoaderClient.h:

Source/WTF:

• wtf/FeatureDefines.h:

Tools:

• TestWebKitAPI/Configurations/FeatureDefines.xcconfig:

11:57 PM Changeset in webkit [220830] by Carlos Garcia Campos

• 29 edits
  12 deletes in releases/WebKitGTK/webkit-2.18

Merge r220730 - Remove ENABLE_VIEW_MODE_CSS_MEDIA and related code
​https://bugs.webkit.org/show_bug.cgi?id=175557

Reviewed by Jon Lee.
.:

No port cares about the ENABLE(VIEW_MODE_CSS_MEDIA) feature, so remove it.

• Source/cmake/OptionsMac.cmake:
• Source/cmake/OptionsWPE.cmake:
• Source/cmake/OptionsWin.cmake:
• Source/cmake/WebKitFeatures.cmake:
• Source/cmake/tools/vsprops/FeatureDefines.props:
• Source/cmake/tools/vsprops/FeatureDefinesCairo.props:

Source/JavaScriptCore:

No port cares about the ENABLE(VIEW_MODE_CSS_MEDIA) feature, so remove it.

• Configurations/FeatureDefines.xcconfig:

Source/WebCore:

No port cares about the ENABLE(VIEW_MODE_CSS_MEDIA) feature, so remove it.

• Configurations/FeatureDefines.xcconfig:
• css/CSSValueKeywords.in:
• css/MediaFeatureNames.h:
• css/MediaQueryEvaluator.cpp:

(WebCore::viewModeEvaluate): Deleted.

• css/MediaQueryExpression.cpp:

(WebCore::featureWithValidIdent):
(WebCore::isFeatureValidWithoutValue):

• page/Page.cpp:

(WebCore::Page::stringToViewMode): Deleted.
(WebCore::Page::setViewMode): Deleted.

• page/Page.h:

(WebCore::Page::viewMode const): Deleted.

Source/WebCore/PAL:

No port cares about the ENABLE(VIEW_MODE_CSS_MEDIA) feature, so remove it.

• Configurations/FeatureDefines.xcconfig:

Source/WebKit:

No port cares about the ENABLE(VIEW_MODE_CSS_MEDIA) feature, so remove it.

• Configurations/FeatureDefines.xcconfig:

Source/WebKitLegacy/mac:

No port cares about the ENABLE(VIEW_MODE_CSS_MEDIA) feature, so remove it.

• Configurations/FeatureDefines.xcconfig:

Source/WTF:

No port cares about the ENABLE(VIEW_MODE_CSS_MEDIA) feature, so remove it.

• wtf/FeatureDefines.h:

Tools:

No port cares about the ENABLE(VIEW_MODE_CSS_MEDIA) feature, so remove it.

• DumpRenderTree/TestRunner.cpp:

(TestRunner::staticFunctions):
(setViewModeMediaFeatureCallback): Deleted.

• DumpRenderTree/TestRunner.h:
• DumpRenderTree/mac/TestRunnerMac.mm:

(TestRunner::setViewModeMediaFeature): Deleted.

• DumpRenderTree/win/TestRunnerWin.cpp:

(TestRunner::setViewModeMediaFeature): Deleted.

• TestWebKitAPI/Configurations/FeatureDefines.xcconfig:

LayoutTests:

No port cares about the ENABLE(VIEW_MODE_CSS_MEDIA) feature, so remove it.

• fast/media/media-query-list-02-expected.txt: Removed.
• fast/media/media-query-list-02.html: Removed.
• fast/media/media-query-list-03-expected.txt: Removed.
• fast/media/media-query-list-03.html: Removed.
• fast/media/media-query-list-04-expected.txt: Removed.
• fast/media/media-query-list-04.html: Removed.
• fast/media/media-query-list-05-expected.txt: Removed.
• fast/media/media-query-list-05.html: Removed.
• fast/media/media-query-list-06-expected.txt: Removed.
• fast/media/media-query-list-06.html: Removed.
• fast/media/view-mode-media-feature-expected.html: Removed.
• fast/media/view-mode-media-feature.html: Removed.
• platform/gtk/TestExpectations:
• platform/ios-wk2/TestExpectations:
• platform/ios/TestExpectations:
• platform/mac/TestExpectations:
• platform/win/TestExpectations:

11:17 PM Changeset in webkit [220829] by rniwa@webkit.org

• 9 edits
  2 adds in trunk

Add the support for mutating clipboard data via DataTransferItemList
​https://bugs.webkit.org/show_bug.cgi?id=175639

Reviewed by Wenson Hsieh.

Source/WebCore:

Added the support for adding plaintext data via dataTransfer.items.add, clearing data via clear,
and removing an entry via remove. When DataTransferItem is removed from DataTransferItemList,
we must put into the disabled mode.

To support the removal of DataTransferItem, this patch replaces a reference to DataTransfer by
a WeakPtr to DataTransferItemList, and stops forwarding ref from DataTransferItem to DataTransfer.
This means that DataTransfer can now be GC'ed before DataTransferItem is GC'ed.

Because the identify and the order of DataTransferItems need to be preserved, we can't simply
re-popluate m_itemList in DataTransferItemList. Instead, whenever the clipboard content is mutated,
we make the parallel modifications to m_itemList. This includes changes made via DataTransfer
methods such as setData and clearData.

Test: editing/pasteboard/datatransfer-items-copy-plaintext.html

• dom/DataTransfer.cpp:

(WebCore::DataTransfer::clearData): Invoke didClearStringData when m_itemList exists.
(WebCore::DataTransfer::setData): Ditto.
(WebCore::DataTransfer::createForInputEvent):
(WebCore::DataTransfer::createForDrag):
(WebCore::DataTransfer::createForDrop):

• dom/DataTransferItem.cpp:

(WebCore::DataTransferItem::create):
(WebCore::DataTransferItem::DataTransferItem):
(WebCore::DataTransferItem::clearListAndPutIntoDisabledMode): Added.
(WebCore::DataTransferItem::type const): Moved from the header.
(WebCore::DataTransferItem::getAsString const):
(WebCore::DataTransferItem::getAsFile const):

• dom/DataTransferItem.h:

(WebCore::DataTransferItem::ref): Deleted.
(WebCore::DataTransferItem::deref): Deleted.
(WebCore::DataTransferItem::isFile const): Added.
(WebCore::DataTransferItem::type const): Move to the cpp file.

• dom/DataTransferItemList.cpp:

(WebCore::isSupportedType): Moved.
(WebCore::DataTransferItemList::DataTransferItemList): Moved from the header.
(WebCore::DataTransferItemList::~DataTransferItemList): Added.
(WebCore::DataTransferItemList::item):
(WebCore::DataTransferItemList::add): Implemented the variant to add string data.
(WebCore::DataTransferItemList::remove): Implemented. For now, we don't have to deal with removing
a file since a writable dataTransfer never contains a File object.
(WebCore::DataTransferItemList::clear): Implemented.
(WebCore::DataTransferItemList::ensureItems const):
(WebCore::removeStringItemOfLowercasedType): Added.
(WebCore::DataTransferItemList::didClearStringData): Called when dataTransfer.clear is called.
(WebCore::DataTransferItemList::didSetStringData): Ditto for

• dom/DataTransferItemList.h:

(WebCore::DataTransferItemList): Added a WeakPtrFactory. Also use a vector of Ref<DataTransferItem>
instead of unique_ptr<DataTransferItem> since DataTransferItem can outlive DataTransferItemList.
(WebCore::DataTransferItemList::dataTransfer): Added.

• dom/DataTransferItemList.idl:

LayoutTests:

Rebaselined the IDL test which now passes all test cases, and added a regression test for mutating clipboard data
via dataTransfer.items and methods on dataTransfer for plaintext.

• editing/pasteboard/datatransfer-idl-expected.txt:
• editing/pasteboard/datatransfer-items-copy-plaintext-expected.txt: Added.
• editing/pasteboard/datatransfer-items-copy-plaintext.html: Added.

11:11 PM Changeset in webkit [220828] by Carlos Garcia Campos

• 4 edits
  2 adds in releases/WebKitGTK/webkit-2.18

Merge r220717 - The none smooth stroke applied to an SVG shape breaks its hit testing
​https://bugs.webkit.org/show_bug.cgi?id=175506

Patch by Said Abou-Hallawa <​sabouhallawa@apple.com> on 2017-08-14
Reviewed by Simon Fraser.

Source/WebCore:

Clear RenderSVGShape::m_path when calling RenderSVGRect::updateShapeFromElement().
The m_path will be recalculated when RenderSVGShape::updateShapeFromElement()
is called from RenderSVGRect::shapeDependentStrokeContains().

Test: svg/stroke/stroke-linejoin-click.html

• rendering/svg/RenderSVGRect.cpp:

(WebCore::RenderSVGRect::updateShapeFromElement):

• rendering/svg/RenderSVGShape.h:

(WebCore::RenderSVGShape::clearPath):

LayoutTests:

• svg/stroke/stroke-linejoin-click-expected.html: Added.
• svg/stroke/stroke-linejoin-click.html: Added.

11:08 PM Changeset in webkit [220827] by Carlos Garcia Campos

• 2 edits in releases/WebKitGTK/webkit-2.18/Source/WebCore

Merge r220522 - Unreviewed GTK+ build fix for ENABLE_GLES2=ON.

• platform/graphics/texmap/TextureMapperGLHeaders.h:

Define various GL constants that are not provided in GLES2 headers
but are only leveraged in OpenGL calls if at runtime the underlying
OpenGL is GLES2-capable.

11:08 PM Changeset in webkit [220826] by Carlos Garcia Campos

• 4 edits in releases/WebKitGTK/webkit-2.18/Source/WebCore

Merge r220521 - [TexMap] Remove GraphicsContext3D usage from BitmapTexturePool
​https://bugs.webkit.org/show_bug.cgi?id=175319

Reviewed by Carlos Garcia Campos.

Drop the GraphicsContext3D reference in BitmapTexturePool now
that the BitmapTextureGL doesn't require it anymore.

No new tests -- no change in behavior.

• platform/graphics/texmap/BitmapTexturePool.cpp:

(WebCore::BitmapTexturePool::BitmapTexturePool):

• platform/graphics/texmap/BitmapTexturePool.h:
• platform/graphics/texmap/TextureMapperGL.cpp:

(WebCore::TextureMapperGL::TextureMapperGL):

11:08 PM Changeset in webkit [220825] by Carlos Garcia Campos

• 3 edits in releases/WebKitGTK/webkit-2.18

Merge r220699 - REGRESSION(r220517-r220521) [GTK] Various compositing tests fail
​https://bugs.webkit.org/show_bug.cgi?id=175478

Reviewed by Sergio Villar Senin.

Source/WebCore:

Fix a regression introduced in r220519. Move a framebuffer binding in TextureMapperGL
away from GraphicsContext3D and onto the OpenGL API to work around the framebuffer
binding state that's kept in the GraphicsContext3D class. This mismatch in how the
framebuffer was bound was causing a couple of test failures in compositing tests.

No new tests -- regressed tests have their failure expectations removed.

• platform/graphics/texmap/TextureMapperGL.cpp:

(WebCore::TextureMapperGL::bindDefaultSurface): Don't use GraphicsContext3D for the
glBindFramebuffer() call. This would be done in subsequent patches that would move
TextureMapperGL off the GraphicsContext3D usage, but this specific use case clashes
with the framebuffer binding that's done in BitmapTextureGL and was causing test
failures.

LayoutTests:

• platform/gtk/TestExpectations: Remove failure and flakiness expectations.

11:08 PM Changeset in webkit [220824] by Carlos Garcia Campos

• 6 edits in releases/WebKitGTK/webkit-2.18/Source/WebCore

Merge r220519 - [TexMap] Drop GraphicsContext3D usage from BitmapTextureGL
​https://bugs.webkit.org/show_bug.cgi?id=175317

Reviewed by Carlos Garcia Campos.

Have BitmapTextureGL use direct OpenGL API entrypoints and constants
instead of leveraging the GraphicsContext3D class. Any GraphicsContext3D
object passed to BitmapTextureGL would assume rendering to the GL context
that's current on that thread, translating method invocations to the
OpenGL API. We can do this by ourselves and benefit by avoiding allocating
GraphicsContext3D resources like the ANGLE compiler that are by most useful
for WebGL.

BitmapTextureGL::create() call sites are adjusted to stop passing a
GraphicsContext3D reference. BitmapTextureGL::bindAsSurface() doesn't need
a replacement for the passed-in GraphicsContext3D object since that object
originated from the TextureMapperGL instance, whose GraphicsContext3D is by
default of the render-to-current-context nature. Other changes are direct
translations of GraphicsContext3D methods to OpenGL API calls, or of
GraphicsContext3D values to OpenGL API constants.

No new tests -- no change in behavior.

• platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:

(WebCore::MediaPlayerPrivateGStreamerBase::pushTextureToCompositor):

• platform/graphics/texmap/BitmapTextureGL.cpp:

Also remove an unnecessary GraphicsContext.h header inclusion.
(WebCore::BitmapTextureGL::BitmapTextureGL):
(WebCore::BitmapTextureGL::didReset):
(WebCore::BitmapTextureGL::updateContentsNoSwizzle):
(WebCore::BitmapTextureGL::updateContents):
(WebCore::BitmapTextureGL::initializeStencil):
(WebCore::BitmapTextureGL::initializeDepthBuffer):
(WebCore::BitmapTextureGL::clearIfNeeded):
(WebCore::BitmapTextureGL::createFboIfNeeded):
(WebCore::BitmapTextureGL::bindAsSurface):
(WebCore::BitmapTextureGL::~BitmapTextureGL):
(WebCore::BitmapTextureGL::copyFromExternalTexture):

• platform/graphics/texmap/BitmapTextureGL.h:

(WebCore::BitmapTextureGL::create):
(WebCore::BitmapTextureGL::textureTarget const):
(WebCore::BitmapTextureGL::internalFormat const):

• platform/graphics/texmap/BitmapTexturePool.cpp:

(WebCore::BitmapTexturePool::createTexture):

• platform/graphics/texmap/TextureMapperGL.cpp:

(WebCore::TextureMapperGL::bindSurface):
(WebCore::TextureMapperGL::createTexture):

10:09 PM Changeset in webkit [220823] by mark.lam@apple.com

• 16 edits in trunk/Source

Add back the ability to disable MASM_PROBE from the build.
​https://bugs.webkit.org/show_bug.cgi?id=175656
<rdar://problem/33933720>

Reviewed by Yusuke Suzuki.

Source/JavaScriptCore:

This is needed for ports that the existing MASM_PROBE implementation doesn't work
well with e.g. GTK with ARM_THUMB2. Note that if the DFG_JIT will be disabled by
default if !ENABLE(MASM_PROBE).

• assembler/AbstractMacroAssembler.h:
• assembler/MacroAssembler.cpp:
• assembler/MacroAssembler.h:
• assembler/MacroAssemblerARM.cpp:
• assembler/MacroAssemblerARM64.cpp:
• assembler/MacroAssemblerARMv7.cpp:
• assembler/MacroAssemblerPrinter.cpp:
• assembler/MacroAssemblerPrinter.h:
• assembler/MacroAssemblerX86Common.cpp:
• assembler/testmasm.cpp:

(JSC::run):

• b3/B3LowerToAir.cpp:
• b3/air/AirPrintSpecial.cpp:
• b3/air/AirPrintSpecial.h:

Source/WTF:

• wtf/Platform.h:

8:32 PM Changeset in webkit [220822] by mitz@apple.com

• 2 edits in trunk/Source/JavaScriptCore

[Cocoa] Older-iOS install name symbols are being exported on other platforms
​https://bugs.webkit.org/show_bug.cgi?id=175654

Reviewed by Tim Horton.

• API/JSBase.cpp: Define the symbols only when targeting iOS.

6:24 PM Changeset in webkit [220821] by aestes@apple.com

• 33 edits
  2 moves in trunk/Source

[Apple Pay] Rename PaymentRequest to ApplePaySessionPaymentRequest
​https://bugs.webkit.org/show_bug.cgi?id=175648

Reviewed by Tim Horton.

Source/WebCore:

The W3C Payment Request API defines an interface called PaymentRequest, which conflicts with
an existing Apple Pay class. This patch renames PaymentRequest to
ApplePaySessionPaymentRequest so that a follow-on patch can introduce PaymentRequest for the
W3C API.

• Modules/applepay/ApplePayError.h:
• Modules/applepay/ApplePayLineItem.h:
• Modules/applepay/ApplePayPaymentRequest.h:
• Modules/applepay/ApplePaySession.cpp:

(WebCore::convertAndValidateTotal):
(WebCore::convertAndValidate):
(WebCore::ApplePaySession::ApplePaySession):
(WebCore::ApplePaySession::didSelectShippingMethod):

• Modules/applepay/ApplePaySession.h:
• Modules/applepay/ApplePaySessionPaymentRequest.cpp: Renamed from Source/WebCore/Modules/applepay/PaymentRequest.cpp.

(WebCore::ApplePaySessionPaymentRequest::ApplePaySessionPaymentRequest):
(WebCore::ApplePaySessionPaymentRequest::~ApplePaySessionPaymentRequest):
(WebCore::ApplePaySessionPaymentRequest::isValidSupportedNetwork):

• Modules/applepay/ApplePaySessionPaymentRequest.h: Renamed from Source/WebCore/Modules/applepay/PaymentRequest.h.
• Modules/applepay/ApplePayShippingMethodSelectedEvent.cpp:

(WebCore::convert):
(WebCore::ApplePayShippingMethodSelectedEvent::ApplePayShippingMethodSelectedEvent):

• Modules/applepay/ApplePayShippingMethodSelectedEvent.h:
• Modules/applepay/PaymentCoordinator.cpp:

(WebCore::PaymentCoordinator::beginPaymentSession):
(WebCore::PaymentCoordinator::didSelectShippingMethod):

• Modules/applepay/PaymentCoordinator.h:
• Modules/applepay/PaymentCoordinatorClient.h:
• Modules/applepay/PaymentHeaders.h:
• Modules/applepay/PaymentRequestValidator.cpp:

(WebCore::PaymentRequestValidator::validate):
(WebCore::PaymentRequestValidator::validateTotal):
(WebCore::validateMerchantCapabilities):
(WebCore::validateShippingMethod):
(WebCore::validateShippingMethods):

• Modules/applepay/PaymentRequestValidator.h:
• WebCore.xcodeproj/project.pbxproj:
• loader/EmptyClients.cpp:

Source/WebKit:

• Scripts/webkit/messages.py:

(headers_for_type):

• Shared/Cocoa/WebCoreArgumentCodersCocoa.mm:

(IPC::ArgumentCoder<ApplePaySessionPaymentRequest>::encode):
(IPC::ArgumentCoder<ApplePaySessionPaymentRequest>::decode):
(IPC::ArgumentCoder<ApplePaySessionPaymentRequest::ContactFields>::encode):
(IPC::ArgumentCoder<ApplePaySessionPaymentRequest::ContactFields>::decode):
(IPC::ArgumentCoder<ApplePaySessionPaymentRequest::LineItem>::encode):
(IPC::ArgumentCoder<ApplePaySessionPaymentRequest::LineItem>::decode):
(IPC::ArgumentCoder<ApplePaySessionPaymentRequest::MerchantCapabilities>::encode):
(IPC::ArgumentCoder<ApplePaySessionPaymentRequest::MerchantCapabilities>::decode):
(IPC::ArgumentCoder<ApplePaySessionPaymentRequest::ShippingMethod>::encode):
(IPC::ArgumentCoder<ApplePaySessionPaymentRequest::ShippingMethod>::decode):
(IPC::ArgumentCoder<ApplePaySessionPaymentRequest::TotalAndLineItems>::encode):
(IPC::ArgumentCoder<ApplePaySessionPaymentRequest::TotalAndLineItems>::decode):
(IPC::ArgumentCoder<PaymentRequest>::encode): Deleted.
(IPC::ArgumentCoder<PaymentRequest>::decode): Deleted.
(IPC::ArgumentCoder<PaymentRequest::ContactFields>::encode): Deleted.
(IPC::ArgumentCoder<PaymentRequest::ContactFields>::decode): Deleted.
(IPC::ArgumentCoder<PaymentRequest::LineItem>::encode): Deleted.
(IPC::ArgumentCoder<PaymentRequest::LineItem>::decode): Deleted.
(IPC::ArgumentCoder<PaymentRequest::MerchantCapabilities>::encode): Deleted.
(IPC::ArgumentCoder<PaymentRequest::MerchantCapabilities>::decode): Deleted.
(IPC::ArgumentCoder<PaymentRequest::ShippingMethod>::encode): Deleted.
(IPC::ArgumentCoder<PaymentRequest::ShippingMethod>::decode): Deleted.
(IPC::ArgumentCoder<PaymentRequest::TotalAndLineItems>::encode): Deleted.
(IPC::ArgumentCoder<PaymentRequest::TotalAndLineItems>::decode): Deleted.

• Shared/WebCoreArgumentCoders.h:
• UIProcess/ApplePay/WebPaymentCoordinatorProxy.cpp:

(WebKit::WebPaymentCoordinatorProxy::showPaymentUI):
(WebKit::WebPaymentCoordinatorProxy::didSelectShippingMethod):

• UIProcess/ApplePay/WebPaymentCoordinatorProxy.h:
• UIProcess/ApplePay/WebPaymentCoordinatorProxy.messages.in:
• UIProcess/ApplePay/cocoa/WebPaymentCoordinatorProxyCocoa.h:
• UIProcess/ApplePay/cocoa/WebPaymentCoordinatorProxyCocoa.mm:

(toShippingMethod):
(WebKit::toPKContactFields):
(WebKit::toPKAddressField):
(WebKit::toPKPaymentSummaryItemType):
(WebKit::toPKPaymentSummaryItem):
(WebKit::toPKPaymentSummaryItems):
(WebKit::toPKMerchantCapabilities):
(WebKit::toPKShippingType):
(WebKit::toPKShippingMethod):
(WebKit::toPKPaymentRequest):

• UIProcess/ApplePay/ios/WebPaymentCoordinatorProxyIOS.mm:

(WebKit::WebPaymentCoordinatorProxy::platformShowPaymentUI):

• UIProcess/ApplePay/mac/WebPaymentCoordinatorProxyMac.mm:

(WebKit::WebPaymentCoordinatorProxy::platformShowPaymentUI):

• WebProcess/ApplePay/WebPaymentCoordinator.cpp:

(WebKit::WebPaymentCoordinator::showPaymentUI):
(WebKit::WebPaymentCoordinator::didSelectShippingMethod):

• WebProcess/ApplePay/WebPaymentCoordinator.h:
• WebProcess/ApplePay/WebPaymentCoordinator.messages.in:

Source/WebKitLegacy/mac:

• WebCoreSupport/WebPaymentCoordinatorClient.h:
• WebCoreSupport/WebPaymentCoordinatorClient.mm:

(WebPaymentCoordinatorClient::showPaymentUI):

5:45 PM Changeset in webkit [220820] by Ryan Haddad

• 2 edits in trunk/LayoutTests

Mark fullscreen/full-screen-iframe-legacy.html as flaky on Sierra WK1.
​https://bugs.webkit.org/show_bug.cgi?id=175554

Unreviewed test gardening.

• platform/mac-wk1/TestExpectations:

5:43 PM WebKitGTK/Gardening/Calendar edited by Michael Catanzaro

(diff)

5:40 PM Changeset in webkit [220819] by Ryan Haddad

• 2 edits in trunk/LayoutTests

Correct a typo in a test name.

Unreviewed test gardening.

• platform/mac/TestExpectations:

5:33 PM Changeset in webkit [220818] by Ryan Haddad

• 2 edits in trunk/LayoutTests

Rebaseline crypto/subtle/rsa-generate-key-malformed-parameters.html after r220811.

Unreviewed test gardening.

• platform/ios-11/crypto/subtle/rsa-generate-key-malformed-parameters-expected.txt:

5:28 PM Changeset in webkit [220817] by Chris Dumez

• 31 edits
  1 move
  1 add
  3 deletes in trunk

Cross origin Beacon requests with a ArrayBuffer / ArrayBufferView payload should not do a CORS preflight
​https://bugs.webkit.org/show_bug.cgi?id=175628
<rdar://problem/33919278>

Reviewed by Geoffrey Garen.

LayoutTests/imported/w3c:

Rebaseline a few web-platform-tests due to revert of r220779.

• web-platform-tests/beacon/headers/header-content-type-expected.txt:
• web-platform-tests/fetch/api/basic/request-headers.any-expected.txt:
• web-platform-tests/fetch/api/basic/request-headers.any.worker-expected.txt:

Source/WebCore:

Cross origin Beacon requests with a ArrayBuffer / ArrayBufferView payload should not do a CORS preflight.
To achieve this, the following changes were made:

1. Revert r220779 which caused us to use a non CORS-safelisted Content-Type header for such payload
2. Teach PingLoad how to deal with "simple" cross origin requests (i.e. Don't assume we need a CORS preflight merely because the fetch mode is set to "cors").

Test: http/wpt/beacon/cors/crossorigin-arraybufferview-no-preflight.html

• Modules/fetch/FetchBody.cpp:

(WebCore::FetchBody::extract):

• loader/CrossOriginAccessControl.h:
• loader/LoaderStrategy.h:
• loader/PingLoader.cpp:

(WebCore::PingLoader::loadImage):
(WebCore::PingLoader::sendPing):
(WebCore::PingLoader::sendViolationReport):
(WebCore::PingLoader::startPingLoad):

• loader/PingLoader.h:
• loader/cache/CachedResource.cpp:

(WebCore::CachedResource::CachedResource):
(WebCore::CachedResource::load):

• loader/cache/CachedResource.h:
• loader/cache/CachedResourceRequest.cpp:

(WebCore::CachedResourceRequest::CachedResourceRequest):

• loader/cache/CachedResourceRequest.h:

(WebCore::CachedResourceRequest::releaseOriginalRequestHeaders):

• platform/network/HTTPHeaderValues.cpp:
• platform/network/HTTPHeaderValues.h:

Source/WebKit:

Cross origin Beacon requests with a ArrayBuffer / ArrayBufferView payload should not do a CORS preflight.
To achieve this, the following changes were made:

1. Revert r220779 which caused us to use a non CORS-safelisted Content-Type header for such payload
2. Teach PingLoad how to deal with "simple" cross origin requests (i.e. Don't assume we need a CORS preflight merely because the fetch mode is set to "cors").

• NetworkProcess/NetworkCORSPreflightChecker.cpp:

(WebKit::NetworkCORSPreflightChecker::startPreflight):

• NetworkProcess/NetworkResourceLoadParameters.cpp:

(WebKit::NetworkResourceLoadParameters::encode const):
(WebKit::NetworkResourceLoadParameters::decode):

• NetworkProcess/NetworkResourceLoadParameters.h:
• NetworkProcess/PingLoad.cpp:

(WebKit::PingLoad::PingLoad):
(WebKit::PingLoad::loadRequest):
(WebKit::PingLoad::originalRequestHeaders const):
(WebKit::PingLoad::willPerformHTTPRedirection):
(WebKit::PingLoad::isAllowedRedirect const):
(WebKit::PingLoad::makeCrossOriginAccessRequest):
(WebKit::PingLoad::makeSimpleCrossOriginAccessRequest):
(WebKit::PingLoad::makeCrossOriginAccessRequestWithPreflight):
(WebKit::PingLoad::preflightSuccess):

• NetworkProcess/PingLoad.h:
• WebProcess/Network/WebLoaderStrategy.cpp:

(WebKit::WebLoaderStrategy::createPingHandle):

• WebProcess/Network/WebLoaderStrategy.h:

Source/WebKitLegacy:

• WebCoreSupport/WebResourceLoadScheduler.cpp:

(WebResourceLoadScheduler::createPingHandle):

• WebCoreSupport/WebResourceLoadScheduler.h:

LayoutTests:

• http/tests/blink/sendbeacon/beacon-same-origin-expected.txt:
• http/wpt/fetch/fetch-request-arraybuffer-content-type-expected.txt:
• http/wpt/fetch/fetch-request-arraybuffer-content-type.html:

Rebaseline test due to revert of r220779.

• http/wpt/beacon/cors/cors-preflight-arraybufferview-failure-expected.txt: Removed.
• http/wpt/beacon/cors/cors-preflight-arraybufferview-failure.html: Removed.

Drop outdated test. CORS preflight failure is still covered by the corresponding Blob payload test.

• http/wpt/beacon/cors/cors-preflight-arraybufferview-success-expected.txt: Removed.
• http/wpt/beacon/cors/cors-preflight-arraybufferview-success.html: Removed.
• http/wpt/beacon/cors/crossorigin-arraybufferview-no-preflight-expected.txt: Added.
• http/wpt/beacon/cors/crossorigin-arraybufferview-no-preflight.html: Added.

Rename and update test so that it checks that we no longer do a CORS preflight for cross origin
beacons that have an ArrayBuffer payload.

4:29 PM Changeset in webkit [220816] by mark.lam@apple.com

• 2 edits in trunk/Source/WTF

Gardening: fix GTK ARM_THUMB2 build.
​https://bugs.webkit.org/show_bug.cgi?id=175446

Not reviewed.

Disable the use of the DFG for GTK ARM_THUMB2 builds until
​https://bugs.webkit.org/show_bug.cgi?id=175514 is fixed.

• wtf/Platform.h:

4:15 PM Changeset in webkit [220815] by Matt Baker

• 12 edits
  1 add in trunk

Web Inspector: capture async stack trace when workers/main context posts a message
​https://bugs.webkit.org/show_bug.cgi?id=167084
<rdar://problem/30033673>

Reviewed by Brian Burg.

Source/JavaScriptCore:

• inspector/agents/InspectorDebuggerAgent.h:

Add PostMessage async call type.

Source/WebCore:

Add instrumentation to DOMWindow to support showing asynchronous
stack traces when the debugger pauses in a MessageEvent handler.

Test: inspector/debugger/async-stack-trace.html

• inspector/InspectorInstrumentation.cpp:

(WebCore::InspectorInstrumentation::didPostMessageImpl):
(WebCore::InspectorInstrumentation::didFailPostMessageImpl):
(WebCore::InspectorInstrumentation::willDispatchPostMessageImpl):
(WebCore::InspectorInstrumentation::didDispatchPostMessageImpl):

• inspector/InspectorInstrumentation.h:

(WebCore::InspectorInstrumentation::didPostMessage):
(WebCore::InspectorInstrumentation::didFailPostMessage):
(WebCore::InspectorInstrumentation::willDispatchPostMessage):
(WebCore::InspectorInstrumentation::didDispatchPostMessage):

• inspector/PageDebuggerAgent.cpp:

(WebCore::PageDebuggerAgent::didClearAsyncStackTraceData):
(WebCore::PageDebuggerAgent::didPostMessage):
(WebCore::PageDebuggerAgent::didFailPostMessage):
(WebCore::PageDebuggerAgent::willDispatchPostMessage):
(WebCore::PageDebuggerAgent::didDispatchPostMessage):

• inspector/PageDebuggerAgent.h:

• page/DOMWindow.cpp:

(WebCore::DOMWindow::postMessage):
(WebCore::DOMWindow::postMessageTimerFired):

LayoutTests:

Add a test to check for asynchronous stack trace data when the debugger
pauses inside a MessageEvent handler.

• inspector/debugger/async-stack-trace-expected.txt:
• inspector/debugger/async-stack-trace.html:
• inspector/debugger/resources/postMessage-echo.html: Added.

4:00 PM Changeset in webkit [220814] by timothy_horton@apple.com

• 2 edits in trunk/Source/WebCore

Try to fix the build

• platform/ios/PlatformPasteboardIOS.mm:

3:58 PM Changeset in webkit [220813] by Simon Fraser

• 2 edits in trunk/Source/WebCore

Build fix after r220812

Fix builds where LOG_DISABLED is defined.

• css/MediaQueryEvaluator.cpp:

3:12 PM Changeset in webkit [220812] by Simon Fraser

• 20 edits in trunk/Source/WebCore

Add a log channel for media queries
​https://bugs.webkit.org/show_bug.cgi?id=175591

Reviewed by Zalan Bujtas.

Add a "MediaQueries" log channel which logs data about media query evaluation.

• css/MediaList.cpp:

(WebCore::MediaQuerySet::MediaQuerySet):
(WebCore::operator<<):

• css/MediaList.h:
• css/MediaQuery.cpp:

(WebCore::operator<<):

• css/MediaQuery.h:
• css/MediaQueryEvaluator.cpp:

(WebCore::operator<<):
(WebCore::MediaQueryEvaluator::evaluate const):
(WebCore::aspectRatioValueAsString):
(WebCore::orientationEvaluate):
(WebCore::aspectRatioEvaluate):
(WebCore::deviceAspectRatioEvaluate):
(WebCore::evaluateResolution):
(WebCore::deviceHeightEvaluate):
(WebCore::deviceWidthEvaluate):
(WebCore::heightEvaluate):
(WebCore::widthEvaluate):

• css/MediaQueryExpression.cpp:

(WebCore::operator<<):

• css/MediaQueryExpression.h:
• css/MediaQueryMatcher.cpp:

(WebCore::MediaQueryMatcher::styleResolverChanged):

• css/StyleResolver.cpp:

(WebCore::StyleResolver::hasMediaQueriesAffectedByViewportChange const):
(WebCore::StyleResolver::hasMediaQueriesAffectedByAccessibilitySettingsChange const):

• dom/InlineStyleSheetOwner.cpp:

(WebCore::InlineStyleSheetOwner::createSheet):

• html/HTMLImageElement.cpp:

(WebCore::HTMLImageElement::bestFitSourceFromPictureElement):

• html/HTMLLinkElement.cpp:

(WebCore::HTMLLinkElement::process):

• html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::selectNextSourceChild):

• html/HTMLPictureElement.cpp:

(WebCore::HTMLPictureElement::viewportChangeAffectedPicture const):

• html/parser/HTMLPreloadScanner.cpp:

(WebCore::TokenPreloadScanner::StartTagScanner::processAttribute):

• page/FrameView.cpp:

(WebCore::FrameView::layout):

• platform/Logging.cpp:

(WebCore::initializeLogChannelsIfNecessary):

• platform/Logging.h:
• platform/URL.cpp:

(WebCore::isSchemeFirstChar):
(WebCore::operator<<):

• platform/URL.h:

3:11 PM Changeset in webkit [220811] by commit-queue@webkit.org

• 62 edits
  1 copy
  1 delete in trunk

[WebIDL] Remove the need for JSSubtleCryptoCustom.cpp
​https://bugs.webkit.org/show_bug.cgi?id=175526

Patch by Sam Weinig <​sam@webkit.org> on 2017-08-16
Reviewed by Chris Dumez.

Source/WebCore:

• Generates bindings for all of SubtleCrypto except AlgorithmIdentifier normalization, which is defined in the WebCrypto spec to happen after normal IDL operations.
• Adds initial support for IDL object types in unions (some, unneeded at the moment, edge cases remain).

• CMakeLists.txt:
• WebCore.xcodeproj/project.pbxproj:
• bindings/js/JSSubtleCryptoCustom.cpp: Removed.

Remove JSSubtleCryptoCustom.cpp, added CryptoKeyFormat.h

• bindings/js/JSDOMConvertObject.h:

Add needed, when included in generated code, #include of StrongInlines.h

• bindings/js/JSDOMConvertUnion.h:

Add initial support for object (needed for AlgorithmIdentifier which is
(object or DOMString)). Remaining support will be handled by ​https://webkit.org/b/175616

Also add remaining spec comments while in the area.

• bindings/js/JSDOMPromiseDeferred.cpp:

(WebCore::DeferredPromise::reject):

Add support for the special ExistingExceptionError error code. Capturing
the current exception and using it as the rejection value.

• crypto/SubtleCrypto.cpp:

(WebCore::SubtleCrypto::~SubtleCrypto):
(WebCore::toHashIdentifier):
(WebCore::normalizeCryptoAlgorithmParameters):
(WebCore::toCryptoKeyUsageBitmap):
(WebCore::rejectWithException):
(WebCore::normalizeJsonWebKey):
(WebCore::toKeyData):
(WebCore::copyToVector):
(WebCore::isSupportedExportKey):
(WebCore::SubtleCrypto::encrypt):
(WebCore::SubtleCrypto::decrypt):
(WebCore::SubtleCrypto::sign):
(WebCore::SubtleCrypto::verify):
(WebCore::SubtleCrypto::digest):
(WebCore::SubtleCrypto::generateKey):
(WebCore::SubtleCrypto::deriveKey):
(WebCore::SubtleCrypto::deriveBits):
(WebCore::SubtleCrypto::importKey):
(WebCore::SubtleCrypto::exportKey):
(WebCore::SubtleCrypto::wrapKey):
(WebCore::SubtleCrypto::unwrapKey):

• crypto/SubtleCrypto.h:
• crypto/SubtleCrypto.idl:

Moves implementation from JSSubtleCryptoCustom.cpp -> here. Important changes that come
with that are:

• All parameters are now converted / type checked for us.
• Rather than throwing exceptions and expecting the bindings layer to convert them to promise rejections, all rejections are now explicitly made.
• Algorithms are no longer checked for being supported twice, once in normalizeCryptoAlgorithmParameters and then again in the operation. We instead rely on normalizeCryptoAlgorithmParameters to return an Exception if its not supported.
• Shaves 251 lines off the file.

• crypto/CryptoKeyFormat.h: Added.

Add new header for unified key format enum. (For bindings purposes, SubtleCrypto
re aliases it to SubtleCrypto::KeyFormat).

• bindings/js/JSWebKitSubtleCryptoCustom.cpp:
• crypto/CryptoAlgorithm.cpp:
• crypto/CryptoAlgorithm.h:
• crypto/algorithms/CryptoAlgorithmAES_CBC.cpp:
• crypto/algorithms/CryptoAlgorithmAES_CBC.h:
• crypto/algorithms/CryptoAlgorithmAES_CFB.cpp:
• crypto/algorithms/CryptoAlgorithmAES_CFB.h:
• crypto/algorithms/CryptoAlgorithmAES_CTR.cpp:
• crypto/algorithms/CryptoAlgorithmAES_CTR.h:
• crypto/algorithms/CryptoAlgorithmAES_GCM.cpp:
• crypto/algorithms/CryptoAlgorithmAES_GCM.h:
• crypto/algorithms/CryptoAlgorithmAES_KW.cpp:
• crypto/algorithms/CryptoAlgorithmAES_KW.h:
• crypto/algorithms/CryptoAlgorithmECDH.cpp:
• crypto/algorithms/CryptoAlgorithmECDH.h:
• crypto/algorithms/CryptoAlgorithmECDSA.cpp:
• crypto/algorithms/CryptoAlgorithmECDSA.h:
• crypto/algorithms/CryptoAlgorithmHKDF.cpp:
• crypto/algorithms/CryptoAlgorithmHKDF.h:
• crypto/algorithms/CryptoAlgorithmHMAC.cpp:
• crypto/algorithms/CryptoAlgorithmHMAC.h:
• crypto/algorithms/CryptoAlgorithmPBKDF2.cpp:
• crypto/algorithms/CryptoAlgorithmPBKDF2.h:
• crypto/algorithms/CryptoAlgorithmRSAES_PKCS1_v1_5.cpp:
• crypto/algorithms/CryptoAlgorithmRSAES_PKCS1_v1_5.h:
• crypto/algorithms/CryptoAlgorithmRSASSA_PKCS1_v1_5.cpp:
• crypto/algorithms/CryptoAlgorithmRSASSA_PKCS1_v1_5.h:
• crypto/algorithms/CryptoAlgorithmRSA_OAEP.cpp:
• crypto/algorithms/CryptoAlgorithmRSA_OAEP.h:
• crypto/algorithms/CryptoAlgorithmRSA_PSS.cpp:
• crypto/algorithms/CryptoAlgorithmRSA_PSS.h:

Use CryptoKeyFormat enum directly, rather than SubtleCrypto::KeyFormat,
to allow not including SubtleCrypto.h.

• crypto/parameters/CryptoAlgorithmEcdsaParams.h:
• crypto/parameters/CryptoAlgorithmHkdfParams.h:
• crypto/parameters/CryptoAlgorithmHmacKeyParams.h:
• crypto/parameters/CryptoAlgorithmPbkdf2Params.h:
• crypto/parameters/CryptoAlgorithmRsaHashedImportParams.h:
• crypto/parameters/CryptoAlgorithmRsaHashedKeyGenParams.h:
• crypto/parameters/EcdsaParams.idl:
• crypto/parameters/HkdfParams.idl:
• crypto/parameters/HmacKeyParams.idl:
• crypto/parameters/Pbkdf2Params.idl:
• crypto/parameters/RsaHashedImportParams.idl:
• crypto/parameters/RsaHashedKeyGenParams.idl:

Update IDLs and implementations to use the correct definition of HashAlgorithmIdentifier,
which is (object or DOMString), now that it is supported.

LayoutTests:

• crypto/subtle/encrypt-malformed-parameters-expected.txt:
• crypto/subtle/export-key-malformed-parameters-expected.txt:
• crypto/subtle/generate-key-malformed-parameters-expected.txt:
• crypto/subtle/hkdf-derive-bits-malformed-parametrs-expected.txt:
• crypto/subtle/hmac-generate-key-malformed-parameters-expected.txt:
• crypto/subtle/import-key-malformed-parameters-expected.txt:
• crypto/subtle/pbkdf2-derive-bits-malformed-parametrs-expected.txt:
• crypto/subtle/rsa-generate-key-malformed-parameters-expected.txt:
• platform/mac-highsierra/crypto/subtle/rsa-generate-key-malformed-parameters-expected.txt:

Update expectations with improved error messages.

3:09 PM Changeset in webkit [220810] by commit-queue@webkit.org

• 10 edits
  1 copy
  1 add in trunk/Source/WebCore

[Cache API] Implement Worker connection to the Cache storage engine
​https://bugs.webkit.org/show_bug.cgi?id=175599

Patch by Youenn Fablet <​youenn@apple.com> on 2017-08-16
Reviewed by Chris Dumez.

Covered by existing tests.

Adding a WorkerCacheStorageConnection to connect workers Cache/CacheStorage
to the cache storage engine.
WorkerCacheStorageConnection does this by hopping to the main thread to call the document cache storage connection to do the actual job.
Doing some CacheStorageConnection refactoring to share code with WK2 implementation of the cache storage connection.

• Modules/cache/CacheQueryOptions.h:

(WebCore::CacheQueryOptions::isolatedCopy const):

• Modules/cache/CacheStorageConnection.cpp:

(WebCore::CacheStorageConnection::open):
(WebCore::CacheStorageConnection::remove):
(WebCore::CacheStorageConnection::retrieveCaches):
(WebCore::CacheStorageConnection::retrieveRecords):
(WebCore::CacheStorageConnection::batchDeleteOperation):
(WebCore::CacheStorageConnection::batchPutOperation):
(WebCore::CacheStorageConnection::openOrRemoveCompleted):
(WebCore::CacheStorageConnection::updateCaches):
(WebCore::CacheStorageConnection::updateRecords):
(WebCore::CacheStorageConnection::removeRecordsCompleted):
(WebCore::CacheStorageConnection::putRecordsCompleted):

• Modules/cache/CacheStorageConnection.h:

(WebCore::CacheStorageConnection::openCompleted):
(WebCore::CacheStorageConnection::removeCompleted):
(WebCore::CacheStorageConnection::doOpen):
(WebCore::CacheStorageConnection::doRemove):
(WebCore::CacheStorageConnection::doRetrieveCaches):
(WebCore::CacheStorageConnection::doRetrieveRecords):
(WebCore::CacheStorageConnection::doBatchDeleteOperation):
(WebCore::CacheStorageConnection::doBatchPutOperation):

• Modules/cache/WorkerCacheStorageConnection.cpp: Added.

(WebCore::toCrossThreadRecordData):
(WebCore::fromCrossThreadRecordData):
(WebCore::WorkerCacheStorageConnection::create):
(WebCore::WorkerCacheStorageConnection::WorkerCacheStorageConnection):
(WebCore::WorkerCacheStorageConnection::doOpen):
(WebCore::WorkerCacheStorageConnection::doRemove):
(WebCore::WorkerCacheStorageConnection::doRetrieveCaches):
(WebCore::WorkerCacheStorageConnection::doRetrieveRecords):
(WebCore::WorkerCacheStorageConnection::doBatchDeleteOperation):
(WebCore::WorkerCacheStorageConnection::doBatchPutOperation):

• Modules/cache/WorkerCacheStorageConnection.h: Added.
• Modules/cache/WorkerGlobalScopeCaches.cpp:

(WebCore::WorkerGlobalScopeCaches::caches const):

• WebCore.xcodeproj/project.pbxproj:
• loader/FetchOptions.h:

(WebCore::FetchOptions::isolatedCopy const):

• workers/WorkerGlobalScope.cpp:

(WebCore::WorkerGlobalScope::cacheStorageConnection):

• workers/WorkerGlobalScope.h:

2:42 PM Changeset in webkit [220809] by commit-queue@webkit.org

• 43 edits
  11 copies
  2 adds
  2 deletes in trunk

[PAL] Move spi/ios and spi/win directories into PAL
​https://bugs.webkit.org/show_bug.cgi?id=175171

Patch by Yoshiaki Jitsukawa <​Yoshiaki.Jitsukawa@sony.com> on 2017-08-16
Reviewed by Antti Koivisto.

Source/WebCore:

• PlatformWin.cmake:
• WebCore.xcodeproj/project.pbxproj:
• editing/cocoa/DataDetection.mm:
• loader/ios/PreviewLoader.mm:
• page/CaptionUserPreferencesMediaAF.cpp:
• page/cocoa/MemoryReleaseCocoa.mm:
• page/cocoa/SettingsCocoa.mm:
• page/ios/UserAgentIOS.mm:
• platform/audio/ios/MediaSessionManagerIOS.mm:
• platform/graphics/ca/PlatformCALayer.cpp:
• platform/graphics/cocoa/FontCascadeCocoa.mm:
• platform/graphics/cocoa/GraphicsContext3DCocoa.mm:
• platform/graphics/opentype/OpenTypeCG.h:
• platform/graphics/win/SimpleFontDataCGWin.cpp:
• platform/graphics/win/SimpleFontDataDirect2D.cpp:
• platform/ios/Device.h:
• platform/ios/PlatformPasteboardIOS.mm:
• platform/ios/PlatformScreenIOS.mm:
• platform/ios/QuickLookSoftLink.h:
• platform/ios/QuickLookSoftLink.mm:
• platform/ios/ValidationBubbleIOS.mm:
• platform/ios/WebItemProviderPasteboard.mm:
• platform/network/ios/PreviewConverter.mm:
• platform/sql/SQLiteFileSystem.cpp:
• rendering/RenderThemeIOS.mm:

Source/WebCore/PAL:

• PAL.xcodeproj/project.pbxproj:
• pal/spi/ios/CoreUISPI.h: Renamed from Source/WebCore/platform/spi/ios/CoreUISPI.h.
• pal/spi/ios/DataDetectorsUISPI.h: Renamed from Source/WebCore/platform/spi/ios/DataDetectorsUISPI.h.
• pal/spi/ios/GraphicsServicesSPI.h: Renamed from Source/WebCore/platform/spi/ios/GraphicsServicesSPI.h.
• pal/spi/ios/LaunchServicesSPI.h: Renamed from Source/WebCore/platform/spi/ios/LaunchServicesSPI.h.
• pal/spi/ios/MediaPlayerSPI.h: Renamed from Source/WebCore/platform/spi/ios/MediaPlayerSPI.h.
• pal/spi/ios/MobileGestaltSPI.h: Renamed from Source/WebCore/platform/spi/ios/MobileGestaltSPI.h.
• pal/spi/ios/OpenGLESSPI.h: Renamed from Source/WebCore/platform/spi/ios/OpenGLESSPI.h.
• pal/spi/ios/QuickLookSPI.h: Renamed from Source/WebCore/platform/spi/ios/QuickLookSPI.h.
• pal/spi/ios/SQLite3SPI.h: Renamed from Source/WebCore/platform/spi/ios/SQLite3SPI.h.
• pal/spi/ios/UIKitSPI.h: Renamed from Source/WebCore/platform/spi/ios/UIKitSPI.h.
• pal/spi/win/CoreTextSPIWin.h: Renamed from Source/WebCore/platform/spi/win/CoreTextSPIWin.h.

Source/WebKit:

• UIProcess/Cocoa/NavigationState.mm:
• UIProcess/ios/WKActionSheetAssistant.h:
• UIProcess/ios/WKActionSheetAssistant.mm:
• UIProcess/ios/WKContentViewInteraction.mm:
• UIProcess/ios/forms/WKAirPlayRoutePicker.mm:
• WebProcess/EntryPoint/mac/XPCService/WebContentServiceEntryPoint.mm:
• WebProcess/cocoa/WebProcessCocoa.mm:

Source/WebKitLegacy:

• Storage/StorageTracker.cpp:

Source/WebKitLegacy/mac:

• WebCoreSupport/WebFrameLoaderClient.mm:
• WebView/WebView.mm:

Tools:

• DumpRenderTree/mac/EventSendingController.mm:

1:49 PM Changeset in webkit [220808] by timothy_horton@apple.com

• 16 edits in trunk/Source/WebCore

2-3% of main thread time under UTTypeCreatePreferredIdentifierForTag on wunderground map
​https://bugs.webkit.org/show_bug.cgi?id=175618

Reviewed by Simon Fraser.

No new tests, just a perf win.

UTTypeCreatePreferredIdentifierForTag is fairly expensive, and is called
under every toDataURL, which the Wunderground wundermap does a /lot/.

Keep a 16-item LRU cache of MIMEType->UTI mappings.

Also, make other callers of UTTypeCreatePreferredIdentifierForTag use
the UTIUtilities version so they can share in the caching.

Also, as a drive-by, add and make other callers use mimeTypeFromUTI too,
and make the UTIUtilities operate on Strings for a slightly more WebCore-y feel.

• editing/ios/EditorIOS.mm:

(WebCore::Editor::WebContentReader::readImage):

• platform/MIMETypeRegistry.cpp:

(WebCore::initializeSupportedImageMIMETypes):
(WebCore::initializeSupportedImageMIMETypesForEncoding):

• platform/graphics/mac/MediaPlayerPrivateQTKit.mm:

(WebCore::createFileTypesSet):

• platform/graphics/cg/ImageSourceCGMac.mm:

(WebCore::MIMETypeForImageSourceType):
Adopt newly-added MIMETypeFromUTI().

• platform/graphics/cg/ImageBufferCG.cpp:

(WebCore::utiFromImageBufferMIMEType):
(WebCore::ImageBuffer::toCFData const):
(WebCore::cfData):
(WebCore::utiFromMIMEType): Deleted.
Adopt UTIFromMIMEType, and rename the local helper that does something
different (a small static map) on iOS and Windows to not have an overlapping name.

• platform/ios/PasteboardIOS.mm:

(WebCore::Pasteboard::resourceMIMEType):
(WebCore::utiTypeFromCocoaType):
Adopt UTIFromMIMEType().

• platform/ios/PlatformPasteboardIOS.mm:

(WebCore::PlatformPasteboard::writeObjectRepresentations):

• platform/mac/PasteboardMac.mm:

(WebCore::cocoaTypeFromHTMLClipboardType):
Adopt isDeclaredUTI and UTIFromMIMEType().

• platform/graphics/avfoundation/objc/WebCoreAVFResourceLoader.mm:

(WebCore::WebCoreAVFResourceLoader::responseReceived):

• platform/network/ios/WebCoreURLResponseIOS.mm:

(WebCore::adjustMIMETypeIfNecessary):

• platform/network/mac/WebCoreURLResponse.mm:

(WebCore::adjustMIMETypeIfNecessary):

• rendering/RenderThemeIOS.mm:

(WebCore::iconForAttachment):

• rendering/RenderThemeMac.mm:

(WebCore::iconForAttachment):
Deal with the fact that UTI utilities deal in Strings now.

• platform/network/mac/UTIUtilities.h:
• platform/network/mac/UTIUtilities.mm:

(WebCore::MIMETypeFromUTI):
Added. This doesn't crawl up the UTI tree if the first conversion fails,
which is what most of the existing code does. It's possible we want to
use MIMETypeFromUTITree's logic everywhere, but I didn't want to change
that in this patch.

(WebCore::MIMETypeFromUTITree):
(WebCore::isDeclaredUTI):
Take and return strings.

(WebCore::UTIFromMIMETypeCachePolicy::createValueForKey):
(WebCore::UTIFromMIMEType):
Add the aforementioned cache.

1:38 PM Changeset in webkit [220807] by mark.lam@apple.com

• 7 edits in trunk/Source/JavaScriptCore

Enhance MacroAssembler::probe() to support an initializeStackFunction callback.
​https://bugs.webkit.org/show_bug.cgi?id=175617
<rdar://problem/33912104>

Reviewed by JF Bastien.

This patch adds a new feature to MacroAssembler::probe() where the probe function
can provide a ProbeFunction callback to fill in stack values after the stack
pointer has been adjusted. The probe function can use this feature as follows:

1. Set the new sp value in the ProbeContext's CPUState.

2. Set the ProbeContext's initializeStackFunction to a ProbeFunction callback which will do the work of filling in the stack values after the probe trampoline has adjusted the machine stack pointer.

3. Set the ProbeContext's initializeStackArgs to any value that the client wants to pass to the initializeStackFunction callback.

4. Return from the probe function.

Upon returning from the probe function, the probe trampoline will adjust the
the stack pointer based on the sp value in CPUState. If initializeStackFunction
is not set, the probe trampoline will restore registers and return to its caller.

If initializeStackFunction is set, the trampoline will move the ProbeContext
beyond the range of the stack pointer i.e. it will place the new ProbeContext at
an address lower than where CPUState.sp() points. This ensures that the
ProbeContext will not be trashed by the initializeStackFunction when it writes to
the stack. Then, the trampoline will call back to the initializeStackFunction
ProbeFunction to let it fill in the stack values as desired. The
initializeStackFunction ProbeFunction will be passed the moved ProbeContext at
the new location.

initializeStackFunction may now write to the stack at addresses greater or
equal to CPUState.sp(), but not below that. initializeStackFunction is also
not allowed to change CPUState.sp(). If the initializeStackFunction does not
abide by these rules, then behavior is undefined, and bad things may happen.

For future reference, some implementation details that this patch needed to
be mindful of:

1. When the probe trampoline allocates stack space for the ProbeContext, it should include OUT_SIZE as well. This ensures that it doesn't have to move the ProbeContext on exit if the probe function didn't change the sp.

2. If the trampoline has to move the ProbeContext, it needs to point the machine sp to new ProbeContext first before copying over the ProbeContext data. This protects the new ProbeContext from possibly being trashed by interrupts.

3. When computing the new address of ProbeContext to move to, we need to make sure that it is properly aligned in accordance with stack ABI requirements (just like we did when we allocated the ProbeContext on entry to the probe trampoline).

4. When copying the ProbeContext to its new location, the trampoline should always copy words from low addresses to high addresses. This is because if we're moving the ProbeContext, we'll always be moving it to a lower address.

• assembler/MacroAssembler.h:
• assembler/MacroAssemblerARM.cpp:
• assembler/MacroAssemblerARM64.cpp:
• assembler/MacroAssemblerARMv7.cpp:
• assembler/MacroAssemblerX86Common.cpp:
• assembler/testmasm.cpp:

(JSC::testProbePreservesGPRS):
(JSC::testProbeModifiesStackPointer):
(JSC::fillStack):
(JSC::testProbeModifiesStackWithCallback):
(JSC::run):

1:30 PM Changeset in webkit [220806] by Simon Fraser

• 9 edits in trunk/Source/WebCore

Make RenderLayer and RenderLayerBacking TextStream-loggable, and clean up compositing logging
​https://bugs.webkit.org/show_bug.cgi?id=175634

Reviewed by Zalan Bujtas.

Add operator<<(TextStream&) for RenderLayer and RenderLayer backing, and use them for compositing logging.

Convert CompositingUpdateType to an enum class.

• page/FrameView.cpp:

(WebCore::FrameView::updateCompositingLayersAfterLayout):
(WebCore::FrameView::updateCompositingLayersAfterScrolling):

• page/ios/FrameIOS.mm:

(WebCore::Frame::viewportOffsetChanged):

• rendering/RenderLayer.cpp:

(WebCore::RenderLayer::updateLayerPositionsAfterLayout):
(WebCore::RenderLayer::updateCompositingLayersAfterScroll):
(WebCore::RenderLayer::calculateClipRects const):

• rendering/RenderLayer.h:
• rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::updateAfterLayout):
(WebCore::RenderLayerBacking::updateGeometry):
(WebCore::operator<<):

• rendering/RenderLayerBacking.h:
• rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::didRecalcStyleWithNoPendingLayout):
(WebCore::RenderLayerCompositor::flushPendingLayerChanges):
(WebCore::RenderLayerCompositor::updateCompositingLayersTimerFired):
(WebCore::RenderLayerCompositor::updateCompositingLayers):
(WebCore::RenderLayerCompositor::layerTreeAsText):
(WebCore::operator<<):

• rendering/RenderLayerCompositor.h:

1:20 PM Changeset in webkit [220805] by eric.carlson@apple.com

• 5 edits
  4 adds in trunk

Consider allow gUM to be called from localhost without https
​https://bugs.webkit.org/show_bug.cgi?id=173457
<rdar://problem/33900527>

Reviewed by Youenn Fablet.

Source/WebCore:

Tests: http/tests/media/media-stream/get-user-media-localhost.html

http/tests/media/media-stream/get-user-media-loopback-ip.html

• Modules/mediastream/UserMediaRequest.cpp:

(WebCore::isSecure): Call SchemeRegistry::shouldTreatURLSchemeAsSecure instead of looking for
the string 'https'.
(WebCore::canCallGetUserMedia): Allow localhost or loopback address.

• page/SecurityOrigin.cpp:

(WebCore::isLoopbackIPAddress): Add a comment.
(WebCore::shouldTreatAsPotentionallyTrustworthy): Move tests for localhost and loopback address
to isLocalHostOrLoopbackIPAddress, call it.
(WebCore::SecurityOrigin::isLocalHostOrLoopbackIPAddress):

• page/SecurityOrigin.h:

LayoutTests:

• http/tests/media/media-stream/get-user-media-localhost-expected.txt: Added.
• http/tests/media/media-stream/get-user-media-localhost.html: Added.
• http/tests/media/media-stream/get-user-media-loopback-ip-expected.txt: Added.
• http/tests/media/media-stream/get-user-media-loopback-ip.html: Added.

1:19 PM Changeset in webkit [220804] by Ryan Haddad

• 2 edits in trunk/LayoutTests

Skip workers/wasm-hashset-many.html and workers/wasm-hashset-many-2.html
​https://bugs.webkit.org/show_bug.cgi?id=175102

Unreviewed test gardening.

• platform/mac/TestExpectations:

12:53 PM WebKitGTK/2.18.x edited by Michael Catanzaro

Propose r220797 (diff)

12:42 PM Changeset in webkit [220803] by jmarcell@apple.com

• 7 edits in trunk/Source

Versioning.

12:36 PM Changeset in webkit [220802] by jmarcell@apple.com

• 1 copy in tags/Safari-605.1.3

Tag Safari-605.1.3.

12:17 PM Changeset in webkit [220801] by commit-queue@webkit.org

• 9 edits
  7 adds in trunk/PerformanceTests

Speedometer: Update Angular 1 TodoMVC example to v1.6.5
​https://bugs.webkit.org/show_bug.cgi?id=175623

Patch by Mathias Bynens <​mathias@qiwi.be> on 2017-08-16
Reviewed by Ryosuke Niwa.

• Speedometer/resources/todomvc/architecture-examples/angularjs/index.html: Made title consistent.
• Speedometer/resources/todomvc/architecture-examples/angularjs/node_modules/angular-resource/angular-resource.min.js: Added.
• Speedometer/resources/todomvc/architecture-examples/angularjs/node_modules/angular-resource/angular-resource.min.js.map: Added.
• Speedometer/resources/todomvc/architecture-examples/angularjs/node_modules/angular-route/angular-route.min.js: Added.
• Speedometer/resources/todomvc/architecture-examples/angularjs/node_modules/angular-route/angular-route.min.js.map: Added.
• Speedometer/resources/todomvc/architecture-examples/angularjs/node_modules/angular/angular.min.js: Added.
• Speedometer/resources/todomvc/architecture-examples/angularjs/node_modules/angular/angular.min.js.map: Added.
• Speedometer/resources/todomvc/architecture-examples/angularjs/node_modules/todomvc-app-css/package.json: Updated per build steps.
• Speedometer/resources/todomvc/architecture-examples/angularjs/node_modules/todomvc-common/package.json: Updated per build steps.
• Speedometer/resources/todomvc/architecture-examples/angularjs/package-lock.json: Added to pin dependencies.
• Speedometer/resources/todomvc/architecture-examples/angularjs/package.json: Updated per build steps.
• Speedometer/resources/todomvc/architecture-examples/angularjs/readme.md: Document the build process.

11:59 AM Changeset in webkit [220800] by commit-queue@webkit.org

• 5 edits
  7 adds in trunk/PerformanceTests

Speedometer: Document Backbone example
​https://bugs.webkit.org/show_bug.cgi?id=175626

Patch by Mathias Bynens <​mathias@qiwi.be> on 2017-08-16
Reviewed by Ryosuke Niwa.

• Speedometer/resources/todomvc/architecture-examples/backbone/index.html: Made title consistent.
• Speedometer/resources/todomvc/architecture-examples/backbone/node_modules/backbone/backbone-min.js: Added.
• Speedometer/resources/todomvc/architecture-examples/backbone/node_modules/backbone/backbone-min.map: Added.
• Speedometer/resources/todomvc/architecture-examples/backbone/node_modules/jquery/dist/jquery.js: Updated per build steps.
• Speedometer/resources/todomvc/architecture-examples/backbone/node_modules/jquery/dist/jquery.min.js: Added.
• Speedometer/resources/todomvc/architecture-examples/backbone/node_modules/jquery/dist/jquery.min.map: Added.
• Speedometer/resources/todomvc/architecture-examples/backbone/node_modules/todomvc-app-css/index.css: Updated per build steps.
• Speedometer/resources/todomvc/architecture-examples/backbone/node_modules/underscore/underscore-min.js: Added.
• Speedometer/resources/todomvc/architecture-examples/backbone/node_modules/underscore/underscore-min.map: Added.
• Speedometer/resources/todomvc/architecture-examples/backbone/package-lock.json: Added.
• Speedometer/resources/todomvc/architecture-examples/backbone/readme.md: Documented build steps.

10:30 AM Changeset in webkit [220799] by Chris Dumez

• 5 edits
  2 adds in trunk

EventSource: ignore IDs with U+0000
​https://bugs.webkit.org/show_bug.cgi?id=175178

Reviewed by Darin Adler.

LayoutTests/imported/w3c:

Import WPT test coverage from:

• ​https://github.com/w3c/web-platform-tests/pull/6584

• web-platform-tests/eventsource/format-field-id-null-expected.txt: Added.
• web-platform-tests/eventsource/format-field-id-null.htm: Added.
• web-platform-tests/eventsource/resources/last-event-id.py:

(main):

• web-platform-tests/eventsource/w3c-import.log:

Source/WebCore:

EventSource: ignore IDs with U+0000 as per:
​https://github.com/whatwg/html/pull/2849

Test: imported/w3c/web-platform-tests/eventsource/format-field-id-null.htm

• page/EventSource.cpp:

(WebCore::EventSource::parseEventStreamLine):

9:46 AM Changeset in webkit [220798] by Ryan Haddad

• 2 edits in trunk/LayoutTests

Rebaseline js/dom/global-constructors-attributes.html.

Unreviewed test gardening.

• platform/mac-wk1/js/dom/global-constructors-attributes-expected.txt:

9:36 AM Changeset in webkit [220797] by commit-queue@webkit.org

• 3 edits
  2 adds in trunk

[HarfBuzz] Decomposed Vietnamese characters are rendered incorrectly
​https://bugs.webkit.org/show_bug.cgi?id=174418

Patch by Fujii Hironori <Fujii Hironori> on 2017-08-16
Reviewed by Michael Catanzaro.

Source/WebCore:

HarfBuzzShaper should normalize the input text before collecting
HarfBuzzRuns. Actually, HarfBuzzShaper::setNormalizedBuffer does
the task. But, this function hasn't been called from anywhere
since Bug 90951.

Test: fast/text/international/vietnamese-nfd.html

imported/blink/fast/text/international/text-shaping-arabic-diffs.html

• platform/graphics/harfbuzz/HarfBuzzShaper.cpp:

(WebCore::HarfBuzzShaper::HarfBuzzShaper):
Call setNormalizedBuffer instead of normalizeCharacters.
(WebCore::normalizeCharacters): Deleted.
(WebCore::normalizeSpacesAndMirrorChars) Use
FontCascade::treatAsZeroWidthSpaceInComplexScript instead of
FontCascade::treatAsZeroWidthSpace to preserve ZWJ and ZWNJ.

LayoutTests:

• fast/text/international/vietnamese-nfd-expected.html: Added.
• fast/text/international/vietnamese-nfd.html: Added.

9:08 AM WebKitGTK/2.18.x edited by Michael Catanzaro

Propose r220746 (diff)

8:43 AM Changeset in webkit [220796] by Chris Dumez

• 4 edits in trunk/LayoutTests

Unreviewed, rebaseline a few tests after r220779.

• http/tests/blink/sendbeacon/beacon-same-origin-expected.txt:
• http/wpt/beacon/cors/cors-preflight-arraybufferview-failure.html:
• http/wpt/beacon/cors/cors-preflight-arraybufferview-success.html:

6:15 AM Changeset in webkit [220795] by Antti Koivisto

• 14 edits
  2 adds in trunk/Source/WebCore

Move first-letter renderer mutation code out of RenderBlock and into RenderTreeUpdater
​https://bugs.webkit.org/show_bug.cgi?id=175627

Reviewed by Andreas Kling.

Render tree should not mutate itself. We already fixed this for first-letter, supporting code
can now move to RenderTreeUpdater too.

• CMakeLists.txt:
• WebCore.xcodeproj/project.pbxproj:
• rendering/RenderBlock.cpp:

(WebCore::styleForFirstLetter): Deleted.
(WebCore::isPunctuationForFirstLetter): Deleted.
(WebCore::shouldSkipForFirstLetter): Deleted.
(WebCore::RenderBlock::updateFirstLetterStyle): Deleted.
(WebCore::RenderBlock::createFirstLetterRenderer): Deleted.
(WebCore::RenderBlock::updateFirstLetter): Deleted.

• rendering/RenderBlock.h:
• rendering/RenderRubyRun.cpp:

(WebCore::RenderRubyRun::updateFirstLetter): Deleted.

• rendering/RenderRubyRun.h:
• rendering/RenderTable.cpp:

(WebCore::RenderTable::updateFirstLetter): Deleted.

• rendering/RenderTable.h:

Virtual overrides just disabled first letter for some RenderBlock subclasses. This is now achieved via
supportsFirstLetter test in the first letter updater.

• rendering/TextAutoSizing.cpp:

(WebCore::TextAutoSizingValue::adjustTextNodeSizes):

• rendering/svg/RenderSVGText.cpp:

(WebCore::RenderSVGText::updateFirstLetter): Deleted.

• rendering/svg/RenderSVGText.h:
• style/RenderTreeUpdater.cpp:

(WebCore::RenderTreeUpdater::popParent):

• style/RenderTreeUpdater.h:
• style/RenderTreeUpdaterFirstLetter.cpp: Added.

(WebCore::styleForFirstLetter):
(WebCore::isPunctuationForFirstLetter):
(WebCore::shouldSkipForFirstLetter):
(WebCore::updateFirstLetterStyle):
(WebCore::createFirstLetterRenderer):
(WebCore::supportsFirstLetter):
(WebCore::RenderTreeUpdater::FirstLetter::update):

• style/RenderTreeUpdaterFirstLetter.h: Added.

4:38 AM Changeset in webkit [220794] by Carlos Garcia Campos

• 8 edits in trunk/Source/WebDriver

WebDriver: fix return value of close window command
​https://bugs.webkit.org/show_bug.cgi?id=174861

Reviewed by Brian Burg.

We are currently returning null, but we should return the list of window handles, and try to close the session
if there aren't more window handles.

10.2 Close Window
​https://w3c.github.io/webdriver/webdriver-spec.html#close-window

3. If there are no more open top-level browsing contexts, then try to close the session.
4. Return the result of running the remote end steps for the Get Window Handles command.

• Session.cpp:

(WebDriver::Session::closeAllToplevelBrowsingContexts): Helper function to close the given toplevel browsing
context and the next one if there are more.
(WebDriver::Session::close): Call closeAllToplevelBrowsingContexts() to delete all toplevel browsing contexts of
the session.
(WebDriver::Session::closeTopLevelBrowsingContext): Close the given toplevel browsing context and call
getWindowHandles() when done.
(WebDriver::Session::closeWindow): Call closeTopLevelBrowsingContext() passing the current toplevel browsing context.
(WebDriver::Session::getWindowHandles): Remove the early return, this command doesn't depend on a current
toplevel browsing context.

• Session.h:
• SessionHost.h:
• WebDriverService.cpp:

(WebDriver::WebDriverService::run): Disconnect the server when main loop quits.
(WebDriver::WebDriverService::deleteSession): Do not fail if the given session is not active.
(WebDriver::WebDriverService::closeWindow): Remove the session if the closed window was the last one.

• WebDriverService.h: Remove unused quit() method.
• glib/SessionHostGlib.cpp:

(WebDriver::SessionHost::isConnected): Return whether host is connected to a browser instance.
(WebDriver::SessionHost::dbusConnectionClosedCallback): Delete m_browser.

4:26 AM Changeset in webkit [220793] by magomez@igalia.com

• 2 edits in trunk/Source/WebKit

[GTK] Crash of WebProcess with on-demand AC
​https://bugs.webkit.org/show_bug.cgi?id=171161

Reviewed by Carlos Garcia Campos.

Set the viewOverlayRootLayer to the previous layerTreeHost if it exists. This avoids a
crash when reusing the previous layerTreeHost, because it would keep a reference to an
already destroyed viewOverlayRootLayer.

• WebProcess/WebPage/AcceleratedDrawingArea.cpp:

(WebKit::AcceleratedDrawingArea::attachViewOverlayGraphicsLayer):

4:21 AM Changeset in webkit [220792] by zandobersek@gmail.com

• 10 edits in trunk/Source/WebKit

[CoordGraphics] Simplify CoordinatedGraphicsScene state updates
​https://bugs.webkit.org/show_bug.cgi?id=175528
<rdar://problem/33876795>

Reviewed by Carlos Garcia Campos.

Hold the information about state updates in ThreadedCompositor, in the
m_attributes struct. This way we don't need to store the updates in
functors and accumulate them in the CoordinatedGraphicsScene class, but
instead just apply any pending state update or atlas removal before the
scene is rendered.

This removes the need to update the CoordinatedGraphicsScene object from
the main thread with data that ultimately has to be handled on the
composition thread. Similarly, when updating CoordinatedGraphicsScene, we
only need to synchronize on the m_attributes lock object once in order to
retrieve the scene update information, instead of having each functor do
that repeatedly.

Outside of CoordinatedGraphicsScene and ThreadedCompositor classes, the
CompositingCoordinator class now passes the atlases-to-remove Vector by
a const lvalue reference down to ThreadedCompositor, and then manually
clears the Vector. Before the Vector was passed as an rvalue reference,
depending on the ThreadedCompositor code to clear out the original Vector
object by moving its resources into the functor object. This doesn't occur
anymore because the Vector object is now appended to another Vector.

• Shared/CoordinatedGraphics/CoordinatedGraphicsScene.cpp:

(WebKit::CoordinatedGraphicsScene::applyStateChanges):
(WebKit::CoordinatedGraphicsScene::paintToCurrentGLContext):
(WebKit::CoordinatedGraphicsScene::detach):
(WebKit::CoordinatedGraphicsScene::setActive):
(WebKit::CoordinatedGraphicsScene::syncRemoteContent): Deleted.
(WebKit::CoordinatedGraphicsScene::appendUpdate): Deleted.

• Shared/CoordinatedGraphics/CoordinatedGraphicsScene.h:
• Shared/CoordinatedGraphics/threadedcompositor/ThreadedCompositor.cpp:

(WebKit::ThreadedCompositor::renderLayerTree):
(WebKit::ThreadedCompositor::updateSceneState):
(WebKit::ThreadedCompositor::releaseUpdateAtlases):

• Shared/CoordinatedGraphics/threadedcompositor/ThreadedCompositor.h:
• WebProcess/WebPage/CoordinatedGraphics/CompositingCoordinator.cpp:

(WebKit::CompositingCoordinator::flushPendingLayerChanges):
(WebKit::CompositingCoordinator::releaseAtlases):
(WebKit::CompositingCoordinator::clearUpdateAtlases):

• WebProcess/WebPage/CoordinatedGraphics/CompositingCoordinator.h:
• WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.h:
• WebProcess/WebPage/CoordinatedGraphics/ThreadedCoordinatedLayerTreeHost.cpp:

(WebKit::ThreadedCoordinatedLayerTreeHost::releaseUpdateAtlases):

• WebProcess/WebPage/CoordinatedGraphics/ThreadedCoordinatedLayerTreeHost.h:

3:06 AM Changeset in webkit [220791] by Csaba Osztrogonác

• 2 edits in trunk/Source/JavaScriptCore

Fix JSCOnly ARM buildbots after r220047 and r220184
​https://bugs.webkit.org/show_bug.cgi?id=174993

Reviewed by Carlos Alberto Lopez Perez.

• CMakeLists.txt: Generate only one backend on Linux to save build time.

1:25 AM Changeset in webkit [220790] by calvaris@igalia.com

• 5 edits
  2 adds in trunk/Source/WebCore

[GStreamer][EME] Rework handling key systems and UUIDs
​https://bugs.webkit.org/show_bug.cgi?id=175567

Reviewed by Žan Doberšek.

The UUIDs and key system strings were moved to the
GStreamerEMEUtilities class because so far they were managed by
the decryptors and that was ugly.

• platform/GStreamer.cmake:
• platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:

(WebCore::MediaPlayerPrivateGStreamerBase::supportsKeySystem):

• platform/graphics/gstreamer/eme/GStreamerEMEUtilities.cpp: Added.
• platform/graphics/gstreamer/eme/GStreamerEMEUtilities.h: Added.

(WebCore::GStreamerEMEUtilities::isClearKeyKeySystem):
(WebCore::GStreamerEMEUtilities::keySystemToUuid):

• platform/graphics/gstreamer/eme/WebKitClearKeyDecryptorGStreamer.cpp:

(webkit_media_clear_key_decrypt_class_init):

• platform/graphics/gstreamer/eme/WebKitClearKeyDecryptorGStreamer.h:

12:49 AM Changeset in webkit [220789] by jmarcell@apple.com

• 3 edits in branches/safari-604-branch/Source/WebCore

Cherry-pick r220723. rdar://problem/33901127

12:49 AM Changeset in webkit [220788] by jmarcell@apple.com

• 12 edits in branches/safari-604-branch/Source/WebKit

Cherry-pick r220286. rdar://problem/33904738

12:34 AM Changeset in webkit [220787] by aestes@apple.com

• 20 edits in trunk

[Payment Request] Add an ENABLE flag and an experimental feature preference
​https://bugs.webkit.org/show_bug.cgi?id=175622

Reviewed by Tim Horton.

Source/JavaScriptCore:

• Configurations/FeatureDefines.xcconfig:

Source/WebCore:

• Configurations/FeatureDefines.xcconfig:
• page/Settings.in:

Source/WebCore/PAL:

• Configurations/FeatureDefines.xcconfig:

Source/WebKit:

• Configurations/FeatureDefines.xcconfig:
• Shared/WebPreferencesDefinitions.h:
• UIProcess/API/C/WKPreferences.cpp:

(WKPreferencesSetPaymentRequestEnabled):
(WKPreferencesGetPaymentRequestEnabled):

• UIProcess/API/C/WKPreferencesRefPrivate.h:
• WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::updatePreferences):

Source/WebKitLegacy/mac:

• Configurations/FeatureDefines.xcconfig:

Source/WTF:

• wtf/FeatureDefines.h:

Tools:

• TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
• WebKitTestRunner/TestController.cpp:

(WTR::TestController::resetPreferencesToConsistentValues):

Aug 15, 2017:

11:09 PM Changeset in webkit [220786] by Carlos Garcia Campos

• 2 edits in trunk/Source/WebKit

[GTK][WPE] WebKitAutomationSession should set session client to nullptr on dispose
​https://bugs.webkit.org/show_bug.cgi?id=175564

Reviewed by Carlos Alberto Lopez Perez.

WebAutomationSession expects its client to be nullptr in the destructor.

• UIProcess/API/glib/WebKitAutomationSession.cpp:

(webkitAutomationSessionDispose):

8:52 PM Changeset in webkit [220785] by aestes@apple.com

• 5 edits
  53 adds in trunk/LayoutTests

[Payment Request] Import test suite from web-platform-tests
​https://bugs.webkit.org/show_bug.cgi?id=175612
<rdar://problem/33906070>

Reviewed by Tim Horton.

LayoutTests/imported/w3c:

Imported the payment-request test suite using import-w3c-tests. Generated failing expected
results for each test and skipped 5 tests that currently time out.

• resources/import-expectations.json:
• resources/resource-files.json:
• web-platform-tests/payment-request/OWNERS: Added.
• web-platform-tests/payment-request/allowpaymentrequest/active-document-cross-origin.https.sub-expected.txt: Added.
• web-platform-tests/payment-request/allowpaymentrequest/active-document-cross-origin.https.sub.html: Added.
• web-platform-tests/payment-request/allowpaymentrequest/active-document-same-origin.https-expected.txt: Added.
• web-platform-tests/payment-request/allowpaymentrequest/active-document-same-origin.https.html: Added.
• web-platform-tests/payment-request/allowpaymentrequest/allowpaymentrequest-attribute-cross-origin-bc-containers.https-expected.txt: Added.
• web-platform-tests/payment-request/allowpaymentrequest/allowpaymentrequest-attribute-cross-origin-bc-containers.https.html: Added.
• web-platform-tests/payment-request/allowpaymentrequest/allowpaymentrequest-attribute-same-origin-bc-containers.https-expected.txt: Added.
• web-platform-tests/payment-request/allowpaymentrequest/allowpaymentrequest-attribute-same-origin-bc-containers.https.html: Added.
• web-platform-tests/payment-request/allowpaymentrequest/basic.https-expected.txt: Added.
• web-platform-tests/payment-request/allowpaymentrequest/basic.https.html: Added.
• web-platform-tests/payment-request/allowpaymentrequest/common.sub.js: Added.

(window.onmessage):
(string_appeared_here.forEach):

• web-platform-tests/payment-request/allowpaymentrequest/echo-PaymentRequest.html: Added.
• web-platform-tests/payment-request/allowpaymentrequest/no-attribute-cross-origin-bc-containers.https-expected.txt: Added.
• web-platform-tests/payment-request/allowpaymentrequest/no-attribute-cross-origin-bc-containers.https.html: Added.
• web-platform-tests/payment-request/allowpaymentrequest/no-attribute-same-origin-bc-containers.https-expected.txt: Added.
• web-platform-tests/payment-request/allowpaymentrequest/no-attribute-same-origin-bc-containers.https.html: Added.
• web-platform-tests/payment-request/allowpaymentrequest/removing-allowpaymentrequest.https.sub-expected.txt: Added.
• web-platform-tests/payment-request/allowpaymentrequest/removing-allowpaymentrequest.https.sub.html: Added.
• web-platform-tests/payment-request/allowpaymentrequest/setting-allowpaymentrequest-timing.https.sub-expected.txt: Added.
• web-platform-tests/payment-request/allowpaymentrequest/setting-allowpaymentrequest-timing.https.sub.html: Added.
• web-platform-tests/payment-request/allowpaymentrequest/setting-allowpaymentrequest.https.sub-expected.txt: Added.
• web-platform-tests/payment-request/allowpaymentrequest/setting-allowpaymentrequest.https.sub.html: Added.
• web-platform-tests/payment-request/allowpaymentrequest/w3c-import.log: Added.
• web-platform-tests/payment-request/historical.https-expected.txt: Added.
• web-platform-tests/payment-request/historical.https.html: Added.
• web-platform-tests/payment-request/interfaces.https-expected.txt: Added.
• web-platform-tests/payment-request/interfaces.https.html: Added.
• web-platform-tests/payment-request/payment-request-abort-method.https-expected.txt: Added.
• web-platform-tests/payment-request/payment-request-abort-method.https.html: Added.
• web-platform-tests/payment-request/payment-request-canmakepayment-method.https.http: Added.
• web-platform-tests/payment-request/payment-request-constructor-crash.https-expected.txt: Added.
• web-platform-tests/payment-request/payment-request-constructor-crash.https.html: Added.
• web-platform-tests/payment-request/payment-request-constructor.https-expected.txt: Added.
• web-platform-tests/payment-request/payment-request-constructor.https.html: Added.
• web-platform-tests/payment-request/payment-request-id.https-expected.txt: Added.
• web-platform-tests/payment-request/payment-request-id.https.html: Added.
• web-platform-tests/payment-request/payment-request-in-iframe-expected.txt: Added.
• web-platform-tests/payment-request/payment-request-in-iframe.html: Added.
• web-platform-tests/payment-request/payment-request-onshippingaddresschange-attribute.https-expected.txt: Added.
• web-platform-tests/payment-request/payment-request-onshippingaddresschange-attribute.https.html: Added.
• web-platform-tests/payment-request/payment-request-onshippingoptionchange-attribute.https-expected.txt: Added.
• web-platform-tests/payment-request/payment-request-onshippingoptionchange-attribute.https.html: Added.
• web-platform-tests/payment-request/payment-request-response-id.html: Added.
• web-platform-tests/payment-request/payment-request-show-method.https-expected.txt: Added.
• web-platform-tests/payment-request/payment-request-show-method.https.html: Added.
• web-platform-tests/payment-request/payment-request-update-event-constructor.http-expected.txt: Added.
• web-platform-tests/payment-request/payment-request-update-event-constructor.http.html: Added.
• web-platform-tests/payment-request/payment-request-update-event-constructor.https-expected.txt: Added.
• web-platform-tests/payment-request/payment-request-update-event-constructor.https.html: Added.
• web-platform-tests/payment-request/w3c-import.log: Added.

LayoutTests:

• TestExpectations: Skipped payment-request tests that currently time out.

8:06 PM Changeset in webkit [220784] by timothy_horton@apple.com

• 2 edits in trunk/Source/WebKit

WKSnapshotConfiguration is missing from the WebKit umbrella header
​https://bugs.webkit.org/show_bug.cgi?id=175614
<rdar://problem/33812691>

Reviewed by Dan Bernstein.

• Shared/API/Cocoa/WebKit.h:

Add WKSnapshotConfiguration, which is a public header.

7:49 PM Changeset in webkit [220783] by commit-queue@webkit.org

• 4 edits in trunk/Source/JavaScriptCore

We are too conservative about the effects of PushWithScope
​https://bugs.webkit.org/show_bug.cgi?id=175584

Patch by Robin Morisset <​rmorisset@apple.com> on 2017-08-15
Reviewed by Saam Barati.

PushWithScope converts its argument to an object (this can throw a type error,
but has no other observable effect), and allocates a new scope, that it then
makes the new current scope. We were a bit too
conservative in saying that it clobbers the world.

• dfg/DFGAbstractInterpreterInlines.h:

(JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):

• dfg/DFGClobberize.h:

(JSC::DFG::clobberize):

• dfg/DFGDoesGC.cpp:

(JSC::DFG::doesGC):

7:23 PM Changeset in webkit [220782] by rniwa@webkit.org

• 22 edits
  5 adds in trunk

Make DataTransferItemList work with plain text entries
​https://bugs.webkit.org/show_bug.cgi?id=175596

Reviewed by Wenson Hsieh.

Source/JavaScriptCore:

Added DataTransferItem as a common identifier since it's a runtime enabled feature.

• runtime/CommonIdentifiers.h:

Source/WebCore:

Added the basic machinery to get the list of plain text items to DataTransferItemList and DataTransferItem.

Each DataTransferItem now depends on DataTransfer so it does ref-forwarding like DataTransferItemList to make
DataTransfer alive as long as any DataTransferItem is alive.

Specifications: ​https://html.spec.whatwg.org/multipage/dnd.html#the-datatransferitem-interface

​https://html.spec.whatwg.org/multipage/dnd.html#the-datatransferitemlist-interface

Tests: editing/pasteboard/datatransfer-items-drop-plaintext-file.html

editing/pasteboard/datatransfer-items-paste-plaintext.html

• dom/DataTransferItem.cpp:

(WebCore::DataTransferItem::DataTransferItem): Added two variants one for plain text and another one for a file.
(WebCore::DataTransferItem::kind const): Rewritten.
(WebCore::DataTransferItem::getAsString const): Implemented.
(WebCore::DataTransferItem::getAsFile const): Implemented.

• dom/DataTransferItem.h:

(WebCore::DataTransferItem::ref): Added.
(WebCore::DataTransferItem::deref): Added.
(WebCore::DataTransferItem::type const): Returns String instead of AtomicString.
(WebCore::DataTransferItem::kind const): Moved to cpp.

• dom/DataTransferItem.idl: Removed NoInterfaceObject since the interface object should exist on DOMWindow.
• dom/DataTransferItemList.cpp:

(WebCore::DataTransferItemList::length): Implemented.
(WebCore::DataTransferItemList::item): Ditto.
(WebCore::isSupportedType): Added. For now, we only support text/plain.
(WebCore::DataTransferItemList::ensureItems): Added. Constructs the list of DataTransferItems.

• dom/DataTransferItemList.h:

(DataTransferItemList): Added m_items. The list is filled lazily by ensureItems.

• dom/DataTransferItemList.idl: Removed NoInterfaceObject since the interface object should exist on DOMWindow.

LayoutTests:

Rebaselined the tests and added two regression tests for pasting plain text and dropping a plain text file.

Unfortunately, dropping a file is only supported by DumpRenderTree on Mac :( so it's disabled elsewhere.

• editing/pasteboard/datatransfer-idl-expected.txt: Rebaselined now that NoInterfaceObject has been dropped from

DataTransferItem.idl and DataTransferItemList.idl as expected.

• editing/pasteboard/datatransfer-idl.html: Fixed the bug that it wasn't testing IDL for DataTransferItem.
• editing/pasteboard/datatransfer-items-drop-plaintext-file-expected.txt: Added.
• editing/pasteboard/datatransfer-items-drop-plaintext-file.html: Added.
• editing/pasteboard/datatransfer-items-paste-plaintext-expected.txt: Added.
• editing/pasteboard/datatransfer-items-paste-plaintext.html: Added.
• editing/resources/text-pasteboard-data.txt: Added.
• platform/gtk/js/dom/global-constructors-attributes-expected.txt:
• platform/ios/TestExpectations:
• platform/mac-elcapitan-wk2/js/dom/global-constructors-attributes-expected.txt:
• platform/mac-elcapitan/js/dom/global-constructors-attributes-expected.txt:
• platform/mac-highsierra-wk1/js/dom/global-constructors-attributes-expected.txt:
• platform/mac-highsierra/js/dom/global-constructors-attributes-expected.txt:
• platform/mac/js/dom/global-constructors-attributes-expected.txt:
• platform/win/TestExpectations:
• platform/wk2/TestExpectations:
• platform/wpe/js/dom/global-constructors-attributes-expected.txt:

7:05 PM Changeset in webkit [220781] by Simon Fraser

• 4 edits in trunk/Source/WebCore

Remove ScrollView::clipsRepaints() which was only used by Chromium
​https://bugs.webkit.org/show_bug.cgi?id=175594

Reviewed by Tim Horton.

clipsRepaints() was added in r74568 but was only used by Chromium. It's always
true for other platforms, so remove conditionals that test for it and assume true.

• page/FrameView.cpp:

(WebCore::FrameView::scrollContentsFastPath):

• platform/ScrollView.cpp:

(WebCore::ScrollView::repaintContentRectangle):
(WebCore::ScrollView::setClipsRepaints): Deleted.

• platform/ScrollView.h:

(WebCore::ScrollView::clipsRepaints const): Deleted.

6:37 PM Changeset in webkit [220780] by Simon Fraser

• 8 edits in trunk/Source

Allow WebCore logging channels to be set from the UI process
​https://bugs.webkit.org/show_bug.cgi?id=175608

Reviewed by Tim Horton.

Source/WebCore:

Change initializeLogChannelsIfNecessary() to take an optional String, which can
be a list of log channels passed from the UI process.

• platform/LogInitialization.h:
• platform/Logging.cpp:

(WebCore::initializeLogChannelsIfNecessary):

Source/WebKit:

The UI process can now read the "WebCoreLogging" default, and pass it to the web process
via WebProcessCreationParameters, where WebProcess::platformInitializeWebProcess() uses
it to set up WebCore logging channels. Note that these will override channels read from
the web process user defaults domain (but those are hard to set anyway).

• Shared/WebProcessCreationParameters.cpp:

(WebKit::WebProcessCreationParameters::encode const):
(WebKit::WebProcessCreationParameters::decode):

• Shared/WebProcessCreationParameters.h:
• UIProcess/Cocoa/WebProcessPoolCocoa.mm:

(WebKit::WebProcessPool::platformInitializeWebProcess):

• WebProcess/cocoa/WebProcessCocoa.mm:

(WebKit::WebProcess::platformInitializeWebProcess):

6:23 PM Changeset in webkit [220779] by Chris Dumez

• 11 edits
  2 adds in trunk

Fetch / Beacon: Use "application/octet-stream" Content-Type for payloads of type ArrayBuffer / ArrayBufferView
​https://bugs.webkit.org/show_bug.cgi?id=175600

Reviewed by Youenn Fablet.

LayoutTests/imported/w3c:

• web-platform-tests/beacon/headers/header-content-type-expected.txt:
• web-platform-tests/fetch/api/basic/request-headers.any-expected.txt:
• web-platform-tests/fetch/api/basic/request-headers.any.worker-expected.txt:

Source/WebCore:

Use "application/octet-stream" Content-Type for payloads of type ArrayBuffer / ArrayBufferView in Fetch & Beacon.
If we don't set a Content-Type header, our underlying network stack is going to add a "application/x-www-form-urlencoded"
Content-Type header, which is worse.

Chrome is already using "application/octet-stream" Content-Type in Beacon, but use no Content-Type in Fetch.
The Fetch/Beacon specification says we should have no Content-Type header in this case but this is unfortunately
not something we can support at the moment. Using "application/octet-stream" Content-Type for now seems like the
lesser evil.

Test: http/wpt/fetch/fetch-request-arraybuffer-content-type.html

• Modules/fetch/FetchBody.cpp:

(WebCore::FetchBody::extract):

• platform/network/HTTPHeaderValues.cpp:

(WebCore::HTTPHeaderValues::octetStreamContentType):

• platform/network/HTTPHeaderValues.h:

LayoutTests:

• http/wpt/fetch/fetch-request-arraybuffer-content-type-expected.txt: Added.
• http/wpt/fetch/fetch-request-arraybuffer-content-type.html: Added.
• platform/mac-highsierra/imported/w3c/web-platform-tests/fetch/api/basic/request-headers.any-expected.txt:
• platform/mac-highsierra/imported/w3c/web-platform-tests/fetch/api/basic/request-headers.any.worker-expected.txt:

6:10 PM Changeset in webkit [220778] by commit-queue@webkit.org

• 18 edits in trunk

JSTests:
Support the 'with' keyword in FTL.
​https://bugs.webkit.org/show_bug.cgi?id=175585

Patch by Robin Morisset <​rmorisset@apple.com> on 2017-08-15
Reviewed by Saam Barati.

Also improve the JSTest/stress/with.js file to test
what happens when non-objects are passed to with.

• stress/with.js:

(foo):
(i.catch):
(i.with): Deleted.

Source/JavaScriptCore:
Support the 'with' keyword in FTL
​https://bugs.webkit.org/show_bug.cgi?id=175585

Patch by Robin Morisset <​rmorisset@apple.com> on 2017-08-15
Reviewed by Saam Barati.

Also makes sure that the order of arguments of PushWithScope, op_push_with_scope, JSWithScope::create()
and so on is consistent (always parentScope first, the new scopeObject second). We used to go from one
to the other at different step which was quite confusing. I picked this order for consistency with CreateActivation
that takes its parentScope argument first.

• bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::emitPushWithScope):

• debugger/DebuggerCallFrame.cpp:

(JSC::DebuggerCallFrame::evaluateWithScopeExtension):

• dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::parseBlock):

• dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode):

• dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compilePushWithScope):

• ftl/FTLCapabilities.cpp:

(JSC::FTL::canCompile):

• ftl/FTLLowerDFGToB3.cpp:

(JSC::FTL::DFG::LowerDFGToB3::compileNode):
(JSC::FTL::DFG::LowerDFGToB3::compilePushWithScope):

• jit/JITOperations.cpp:
• runtime/CommonSlowPaths.cpp:

(JSC::SLOW_PATH_DECL):

• runtime/Completion.cpp:

(JSC::evaluateWithScopeExtension):

• runtime/JSWithScope.cpp:

(JSC::JSWithScope::create):

• runtime/JSWithScope.h:

Source/WebCore:
Change the order of arguments of JSWithScope::create() for consistency
​https://bugs.webkit.org/show_bug.cgi?id=175585

Patch by Robin Morisset <​rmorisset@apple.com> on 2017-08-15
Reviewed by Saam Barati.

No change of behavior.

• bindings/js/JSHTMLElementCustom.cpp:

(WebCore::JSHTMLElement::pushEventHandlerScope const):

5:03 PM Changeset in webkit [220777] by sbarati@apple.com

• 3 edits in trunk/Source/JavaScriptCore

Make VM::scratchBufferForSize thread safe
​https://bugs.webkit.org/show_bug.cgi?id=175604

Reviewed by Geoffrey Garen and Mark Lam.

I want to use the VM::scratchBufferForSize in another patch I'm writing.
The use case for my other patch is to call it from the compiler thread.
When reading the code, I saw that this API was not thread safe. This patch
makes it thread safe. It actually turns out we were calling this API from
the compiler thread already when we created FTL::State for an FTL OSR entry
compilation, and from FTLLowerDFGToB3. That code was racy and wrong, but
is now correct with this patch.

• runtime/VM.cpp:

(JSC::VM::VM):
(JSC::VM::~VM):
(JSC::VM::gatherConservativeRoots):
(JSC::VM::scratchBufferForSize):

• runtime/VM.h:

(JSC::VM::scratchBufferForSize): Deleted.

5:02 PM Changeset in webkit [220776] by Matt Lewis

• 2 edits in trunk/LayoutTests

Skipped media/modern-media-controls/time-labels-support/elapsed-time.html.
<rdar://problem/33731086>

Unreviewed test gardening.

• platform/mac-highsierra/TestExpectations:

4:56 PM Changeset in webkit [220775] by jmarcell@apple.com

• 7 edits in branches/safari-604.1.38.1-branch/Source

Versioning.

4:54 PM Changeset in webkit [220774] by jmarcell@apple.com

• 1 copy in tags/Safari-604.1.38.1.6

Tag Safari-604.1.38.1.6.

4:48 PM Changeset in webkit [220773] by jfbastien@apple.com

• 2 edits
  6 adds in trunk/LayoutTests

LayoutTests: test that an XMLHttpRequest with Content-Encoding: gzip is properly decompressed
​https://bugs.webkit.org/show_bug.cgi?id=175579

Also test that without Content-Encoding proper sniffing takes place, and gzip
decoding occurs. This test is disabled and tracked by #175597.

Reviewed by Daniel Bates.

• TestExpectations:
• http/tests/xmlhttprequest/gzip-content-type-expected.txt: Added.
• http/tests/xmlhttprequest/gzip-content-type-no-content-encoding-expected.txt: Added.
• http/tests/xmlhttprequest/gzip-content-type-no-content-encoding.html: Added.
• http/tests/xmlhttprequest/gzip-content-type.html: Added.
• http/tests/xmlhttprequest/resources/gzip-lorem-no-content-encoding.php: Added.
• http/tests/xmlhttprequest/resources/gzip-lorem.php: Added.

4:23 PM Changeset in webkit [220772] by Chris Dumez

• 32 edits
  1 copy
  30 adds
  4 deletes in trunk/LayoutTests

Re-sync DOM Web-Platform-Tests from upstream
​https://bugs.webkit.org/show_bug.cgi?id=175588

Reviewed by Youenn Fablet.

LayoutTests/imported/w3c:

Re-sync DOM Web-Platform-Tests from upstream b5129e92ce.

• web-platform-tests/dom/abort/event.any-expected.txt: Added.
• web-platform-tests/dom/abort/event.any.html: Added.
• web-platform-tests/dom/abort/event.any.js: Added.
• web-platform-tests/dom/abort/event.any.worker-expected.txt: Added.
• web-platform-tests/dom/abort/event.any.worker.html: Added.
• web-platform-tests/dom/abort/w3c-import.log: Added.
• web-platform-tests/dom/events/Event-dispatch-click-expected.txt:
• web-platform-tests/dom/events/Event-dispatch-click.html:
• web-platform-tests/dom/events/Event-timestamp-high-resolution-expected.txt: Added.
• web-platform-tests/dom/events/Event-timestamp-high-resolution.html: Added.
• web-platform-tests/dom/events/Event-timestamp-safe-resolution-expected.txt: Added.
• web-platform-tests/dom/events/Event-timestamp-safe-resolution.html: Added.
• web-platform-tests/dom/events/EventTarget-constructible.any-expected.txt: Added.
• web-platform-tests/dom/events/EventTarget-constructible.any.html: Added.
• web-platform-tests/dom/events/EventTarget-constructible.any.js: Added.

(test.listener):
(test):
(test.prototype.on):
(test.prototype.off):
(test.prototype.dispatch):

• web-platform-tests/dom/events/EventTarget-constructible.any.worker-expected.txt: Added.
• web-platform-tests/dom/events/EventTarget-constructible.any.worker.html: Added.
• web-platform-tests/dom/events/EventTarget-dispatchEvent-expected.txt:
• web-platform-tests/dom/events/w3c-import.log:
• web-platform-tests/dom/interface-objects-expected.txt:
• web-platform-tests/dom/interface-objects.html:
• web-platform-tests/dom/interfaces-expected.txt:
• web-platform-tests/dom/interfaces.html:
• web-platform-tests/dom/nodes/Document-constructor-svg.svg: Removed.
• web-platform-tests/dom/nodes/Document-contentType/contentType/contenttype_datauri_01-expected.txt: Removed.
• web-platform-tests/dom/nodes/Document-contentType/contentType/contenttype_datauri_01.html: Removed.
• web-platform-tests/dom/nodes/Document-contentType/contentType/contenttype_datauri_02-expected.txt:
• web-platform-tests/dom/nodes/Document-contentType/contentType/contenttype_datauri_02.html:
• web-platform-tests/dom/nodes/Document-contentType/contentType/w3c-import.log:
• web-platform-tests/dom/nodes/Document-createElement-namespace-tests/empty.html: Added.
• web-platform-tests/dom/nodes/Document-createElement-namespace-tests/empty.svg: Added.
• web-platform-tests/dom/nodes/Document-createElement-namespace-tests/empty.xhtml: Added.
• web-platform-tests/dom/nodes/Document-createElement-namespace-tests/empty.xml: Added.
• web-platform-tests/dom/nodes/Document-createElement-namespace-tests/w3c-import.log:
• web-platform-tests/dom/nodes/Document-createEvent-expected.txt:
• web-platform-tests/dom/nodes/Document-createEvent.html:
• web-platform-tests/dom/nodes/Document-createEvent.js:
• web-platform-tests/dom/nodes/Element-classlist-expected.txt:
• web-platform-tests/dom/nodes/Element-classlist.html:
• web-platform-tests/dom/nodes/Element-matches-init.js: Copied from LayoutTests/imported/w3c/web-platform-tests/dom/nodes/Element-matches.html.

(init):

• web-platform-tests/dom/nodes/Element-matches.html:
• web-platform-tests/dom/nodes/Element-webkitMatchesSelector.html:
• web-platform-tests/dom/nodes/Node-cloneNode-expected.txt:
• web-platform-tests/dom/nodes/Node-cloneNode.html:
• web-platform-tests/dom/nodes/w3c-import.log:
• web-platform-tests/interfaces/OWNERS: Added.
• web-platform-tests/interfaces/clipboard.idl: Added.
• web-platform-tests/interfaces/cssom.idl: Added.
• web-platform-tests/interfaces/dedicated-workers.idl: Added.
• web-platform-tests/interfaces/dom.idl: Added.
• web-platform-tests/interfaces/fullscreen.idl: Added.
• web-platform-tests/interfaces/geometry.idl: Added.
• web-platform-tests/interfaces/html.idl: Added.
• web-platform-tests/interfaces/mediacapture-main.idl: Added.
• web-platform-tests/interfaces/remoteplayback.idl: Added.
• web-platform-tests/interfaces/touchevents.idl: Added.
• web-platform-tests/interfaces/uievents.idl: Added.
• web-platform-tests/interfaces/web-share.idl: Added.
• web-platform-tests/interfaces/webrtc-pc.idl: Added.
• web-platform-tests/interfaces/webusb.idl: Added.

LayoutTests:

• platform/mac/TestExpectations:

3:58 PM Changeset in webkit [220771] by aakash_jain@apple.com

• 3 edits in trunk/Tools

undefined URL in PopoverTracker for failed step
​https://bugs.webkit.org/show_bug.cgi?id=175593
<rdar://problem/33898769>

Reviewed by Daniel Bates.

This fix is a workaround for Buildbot 0.9 bug <​https://github.com/buildbot/buildbot/issues/3529> where it
does not provide a URL to stdio for a build step. Buildbot 0.8 always included a URL to the stdio of the step.

• BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:

(BuildbotIteration.prototype._parseData): Pass the URL while instantiating BuildbotTestResults.
(BuildbotIteration.prototype._urlForStep): Method to get the URL for a step.

• BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js:

(BuildbotTestResults): Accept URL in constructor.

3:54 PM Changeset in webkit [220770] by keith_miller@apple.com

• 4 edits in trunk/Source/JavaScriptCore

JSC named bytecode offsets should use references rather than pointers
​https://bugs.webkit.org/show_bug.cgi?id=175601

Reviewed by Saam Barati.

• dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::parseBlock):

• jit/JITOpcodes.cpp:

(JSC::JIT::emit_op_overrides_has_instance):
(JSC::JIT::emit_op_instanceof):
(JSC::JIT::emitSlow_op_instanceof):
(JSC::JIT::emitSlow_op_instanceof_custom):

• jit/JITOpcodes32_64.cpp:

(JSC::JIT::emit_op_overrides_has_instance):
(JSC::JIT::emit_op_instanceof):
(JSC::JIT::emitSlow_op_instanceof):
(JSC::JIT::emitSlow_op_instanceof_custom):

3:50 PM Changeset in webkit [220769] by jmarcell@apple.com

• 7 edits in branches/safari-604-branch/Source

Versioning.

3:48 PM Changeset in webkit [220768] by jmarcell@apple.com

• 1 copy in tags/Safari-604.2.3

Tag Safari-604.2.3.

3:43 PM Changeset in webkit [220767] by Ryan Haddad

• 2 edits in trunk/LayoutTests

Mark http/tests/loading/resourceLoadStatistics/clear-in-memory-and-persistent-store.html as flaky.
​https://bugs.webkit.org/show_bug.cgi?id=175263

Unreviewed test gardening.

• platform/wk2/TestExpectations:

3:43 PM Changeset in webkit [220766] by jmarcell@apple.com

• 7 edits in branches/safari-604.1.38.0-branch/Source

Versioning.

3:41 PM Changeset in webkit [220765] by jmarcell@apple.com

• 1 copy in tags/Safari-604.1.38.0.6

Tag Safari-604.1.38.0.6.

3:38 PM Changeset in webkit [220764] by commit-queue@webkit.org

• 3 edits in trunk/Source/WebCore

[Cache API] Ensure ResourceResponse is not null when redirected/tainting/type fields are set
​https://bugs.webkit.org/show_bug.cgi?id=175538

Patch by Youenn Fablet <​youenn@apple.com> on 2017-08-15
Reviewed by Chris Dumez.

No change of behavior.
This change ensures that response type is preserved when encoding/decoding ResourceResponse, in particular the error type.
This will allow Cache API to preserve responses when reading them from a different process.

• platform/network/ResourceResponseBase.cpp:

(WebCore::ResourceResponseBase::setType):

• platform/network/ResourceResponseBase.h:

(WebCore::ResourceResponseBase::setType):

3:34 PM Changeset in webkit [220763] by Ryan Haddad

• 2 edits in trunk/LayoutTests

Mark fast/images/animated-gif-scrolling-crash.html as flaky.
​https://bugs.webkit.org/show_bug.cgi?id=175345.

Unreviewed test gardening.

• platform/mac-wk1/TestExpectations:

3:06 PM Changeset in webkit [220762] by Ryan Haddad

• 2 edits in trunk/LayoutTests

Mark fast/mediacapturefromelement/CanvasCaptureMediaStream-webgl-events.html as flaky.
​https://bugs.webkit.org/show_bug.cgi?id=175592

Unreviewed test gardening.

• platform/mac/TestExpectations:

2:44 PM Changeset in webkit [220761] by Ryan Haddad

• 2 edits in trunk/LayoutTests

Mark http/tests/appcache/deferred-events-delete-while-raising-timer.html as flaky.
​https://bugs.webkit.org/show_bug.cgi?id=87633

Unreviewed test gardening.

• TestExpectations: Add expectation that was removed with r220750.

2:15 PM Changeset in webkit [220760] by Chris Dumez

• 28 edits in trunk/Source/WebCore

Update CachedResourceLoader::requestResource() to return a WTF::Expected
​https://bugs.webkit.org/show_bug.cgi?id=175505

Reviewed by Youenn Fablet.

Update CachedResourceLoader::requestResource() to return a WTF::Expected
type instead of using an out parameter for the ResourceError in case of
synchronous failure.

• Modules/beacon/NavigatorBeacon.cpp:

(WebCore::NavigatorBeacon::sendBeacon):

• bindings/js/CachedScriptFetcher.cpp:

(WebCore::CachedScriptFetcher::requestScriptWithCache const):

• css/CSSFontFaceSrcValue.cpp:

(WebCore::CSSFontFaceSrcValue::cachedFont):

• css/CSSImageSetValue.cpp:

(WebCore::CSSImageSetValue::loadBestFitImage):

• css/CSSImageValue.cpp:

(WebCore::CSSImageValue::loadImage):

• css/StyleRuleImport.cpp:

(WebCore::StyleRuleImport::requestStyleSheet):

• dom/ProcessingInstruction.cpp:

(WebCore::ProcessingInstruction::checkStyleSheet):

• html/HTMLLinkElement.cpp:

(WebCore::HTMLLinkElement::process):

• loader/CrossOriginPreflightChecker.cpp:

(WebCore::CrossOriginPreflightChecker::startPreflight):

• loader/DocumentLoader.cpp:

(WebCore::DocumentLoader::startLoadingMainResource):

• loader/DocumentThreadableLoader.cpp:

(WebCore::DocumentThreadableLoader::loadRequest):

• loader/FrameLoader.cpp:

(WebCore::FrameLoader::loadedResourceFromMemoryCache):

• loader/FrameLoader.h:
• loader/ImageLoader.cpp:

(WebCore::ImageLoader::updateFromElement):

• loader/LinkLoader.cpp:

(WebCore::LinkLoader::preloadIfNeeded):

• loader/MediaResourceLoader.cpp:

(WebCore::MediaResourceLoader::requestResource):

• loader/TextTrackLoader.cpp:

(WebCore::TextTrackLoader::load):

• loader/cache/CachedResourceLoader.cpp:

(WebCore::castCachedResourceTo):
(WebCore::CachedResourceLoader::requestImage):
(WebCore::CachedResourceLoader::requestFont):
(WebCore::CachedResourceLoader::requestTextTrack):
(WebCore::CachedResourceLoader::requestCSSStyleSheet):
(WebCore::CachedResourceLoader::requestUserCSSStyleSheet):
(WebCore::CachedResourceLoader::requestScript):
(WebCore::CachedResourceLoader::requestXSLStyleSheet):
(WebCore::CachedResourceLoader::requestSVGDocument):
(WebCore::CachedResourceLoader::requestLinkResource):
(WebCore::CachedResourceLoader::requestMedia):
(WebCore::CachedResourceLoader::requestIcon):
(WebCore::CachedResourceLoader::requestRawResource):
(WebCore::CachedResourceLoader::requestBeaconResource):
(WebCore::CachedResourceLoader::requestMainResource):
(WebCore::CachedResourceLoader::shouldContinueAfterNotifyingLoadedFromMemoryCache):
(WebCore::CachedResourceLoader::requestResource):
(WebCore::CachedResourceLoader::preload):

• loader/cache/CachedResourceLoader.h:
• loader/cache/CachedSVGDocumentReference.cpp:

(WebCore::CachedSVGDocumentReference::load):

• loader/icon/IconLoader.cpp:

(WebCore::IconLoader::startLoading):

• platform/graphics/avfoundation/objc/WebCoreAVFResourceLoader.mm:

(WebCore::WebCoreAVFResourceLoader::startLoading):

• svg/SVGFEImageElement.cpp:

(WebCore::SVGFEImageElement::requestImageResource):

• svg/SVGFontFaceUriElement.cpp:

(WebCore::SVGFontFaceUriElement::loadFont):

• svg/SVGUseElement.cpp:

(WebCore::SVGUseElement::updateExternalDocument):

• xml/XSLImportRule.cpp:

(WebCore::XSLImportRule::loadSheet):

2:08 PM Changeset in webkit [220759] by don.olmstead@sony.com

• 19 edits
  8 moves
  1 add in trunk/Source

[PAL] Move Sleep classes into PAL
​https://bugs.webkit.org/show_bug.cgi?id=175456

Reviewed by Ryosuke Niwa.

Source/WebCore:

No new tests. No change in behavior.

• CMakeLists.txt:
• PlatformMac.cmake:
• WebCore.xcodeproj/project.pbxproj:
• html/HTMLMediaElement.cpp:
• html/HTMLMediaElement.h:
• platform/audio/PlatformMediaSessionManager.cpp:
• platform/audio/PlatformMediaSessionManager.h:
• platform/mac/WebVideoFullscreenController.h:
• platform/mac/WebVideoFullscreenController.mm:

Source/WebCore/PAL:

• PAL.xcodeproj/project.pbxproj:
• pal/CMakeLists.txt:
• pal/PlatformMac.cmake:
• pal/system/SleepDisabler.cpp: Renamed from Source/WebCore/platform/SleepDisabler.cpp.
• pal/system/SleepDisabler.h: Renamed from Source/WebCore/platform/SleepDisabler.h.
• pal/system/SystemSleepListener.cpp: Renamed from Source/WebCore/platform/SystemSleepListener.cpp.
• pal/system/SystemSleepListener.h: Renamed from Source/WebCore/platform/SystemSleepListener.h.
• pal/system/cocoa/SleepDisablerCocoa.cpp: Renamed from Source/WebCore/platform/cocoa/SleepDisablerCocoa.cpp.
• pal/system/cocoa/SleepDisablerCocoa.h: Renamed from Source/WebCore/platform/cocoa/SleepDisablerCocoa.h.
• pal/system/mac/SystemSleepListenerMac.h: Renamed from Source/WebCore/platform/mac/SystemSleepListenerMac.h.
• pal/system/mac/SystemSleepListenerMac.mm: Renamed from Source/WebCore/platform/mac/SystemSleepListenerMac.mm.

Source/WebKit:

• UIProcess/mac/WKFullScreenWindowController.h:
• UIProcess/mac/WKFullScreenWindowController.mm:

Source/WebKitLegacy/mac:

• WebView/WebFullScreenController.h:

2:04 PM Changeset in webkit [220758] by commit-queue@webkit.org

• 58 edits
  3 copies
  3 adds in trunk

[Cache API] Adding generic support for CacheStorage and Cache methods
​https://bugs.webkit.org/show_bug.cgi?id=175455

Patch by Youenn Fablet <​youenn@apple.com> on 2017-08-15
Reviewed by Chris Dumez.

LayoutTests/imported/w3c:

• web-platform-tests/service-workers/cache-storage/serviceworker/credentials.https-expected.txt:
• web-platform-tests/service-workers/cache-storage/window/cache-storage-match.https-expected.txt:
• web-platform-tests/service-workers/cache-storage/window/cache-storage.https-expected.txt:
• web-platform-tests/service-workers/cache-storage/worker/cache-storage-match.https-expected.txt:
• web-platform-tests/service-workers/cache-storage/worker/cache-storage.https-expected.txt:

Source/WebCore:

Covered by existing tests.

Adding a CacheStorageProvider abstraction that creates a CacheStorageConnection.
The CacheStorageProvider is accessed from the page for Document calls.
The CacheStorageConnection is responsible to implement the read/write operations on the cache database.
At the moment, it does nothing but return not implemented errors.

Implementing CacheStorage APIs and Cache APIs based on the CacheStorageConnection except for Cache add and addAll which will be implemented later on.
CacheStoragConnection is responsible to read/write CacheStorage list of caches and each individual cache.
The CacheStorageConnection is a generic connection and not tied to any document/context.
CacheStorage objects are manipulated by providing to the connection the origin of the context.
CacheStorage are global to all contexts with the same origin.
Cache objects are manipulated by an ID that is given initially by the CacheStorageEngine when opening the Cache object.

Adding various accessors and constructors for Fetch constructs as needed by the Cache API implementation.

• Modules/cache/Cache.cpp:

(WebCore::Cache::Cache):
(WebCore::Cache::~Cache):
The CacheStorageConnection is a generic connection and not tied to any document/context.
(WebCore::Cache::match): Implementation of ​https://www.w3.org/TR/service-workers-1/#cache-match.
Redirect to matchAll as per spec.
(WebCore::Cache::matchAll): Implementation of ​https://www.w3.org/TR/service-workers-1/#cache-matchAll.
Checks for request as per spec. Then either refresh the request to response map and return all responses.
Or call the query cache algorithm and return copies of the responses (using clone).
(WebCore::Cache::put):
Check the request and response as per spec.
Add temporary rejection cases (being loaded responses, responses with ReadableStream) as there is no support for them right now.
Call the batch put operation.
(WebCore::Cache::remove):
Check the request and response as per spec.
Call the batch delete operation.
(WebCore::Cache::keys):
Refresh the request to response map and return corresponding requests.
Making sure to reuse the same request objects as per spec.
As per spec, the request to response map is ordered. We implement it as a Vector.
(WebCore::Cache::refreshRequestToResponseMap):
Use the cache storage connection to get an up-to-date list of cached records.
(WebCore::Cache::queryCacheMatch):
Implements the match algorithm defined in ​https://www.w3.org/TR/service-workers-1/#query-cache-algorithm.
This is split for queryCache as cache storage engine will need to use it when implementing the delete operation.
(WebCore::Cache::queryCache):
Full implementation of ​https://www.w3.org/TR/service-workers-1/#query-cache-algorithm with no targetStorage argument.
(WebCore::Cache::queryCacheWithTargetStorage):
Full implementation of ​https://www.w3.org/TR/service-workers-1/#query-cache-algorithm with a provided targetStorage argument.
(WebCore::Cache::batchDeleteOperation):
Implementation of ​https://www.w3.org/TR/service-workers-1/#batch-cache-operations-algorithm but dedicated to a delete operation.
Delete operation are always done one at a time.
(WebCore::Cache::batchPutOperation):
Implementation of ​https://www.w3.org/TR/service-workers-1/#batch-cache-operations-algorithm dedicated to a put operation.
Put operation takes one record for put but can take several records in the case of addAll, hence the current design.
(WebCore::Cache::updateRequestToResponseMap):
Update the cache request to response map based on the records retrieved from the cache storage connection.

• Modules/cache/Cache.h:

(WebCore::Cache::create):
(WebCore::Cache::name const):

• Modules/cache/Cache.idl:
• Modules/cache/CacheStorage.cpp:

(WebCore::CacheStorage::origin const):
Computing the cache origin that is passed to the CacheStorageConnection.
(WebCore::CacheStorage::has):
Implementation of ​https://www.w3.org/TR/service-workers-1/#cache-storage-has.
Call the cache storage connection to refresh its cache map.
Then use it to check whether a cache exists.
(WebCore::CacheStorage::refreshCacheMap):
Use the cache storage connection to get the list of existing caches.
(WebCore::CacheStorage::open):
Implementation of ​https://www.w3.org/TR/service-workers-1/#cache-storage-open.
Refreshing the cache map so as to return a pre-existing cache if any.
(WebCore::CacheStorage::remove):
Implementation of ​https://www.w3.org/TR/service-workers-1/#cache-storage-delete-method.
Refreshing the cache map so as to do nothing if there is no cache to remove.
(WebCore::CacheStorage::keys):
Implementation of ​https://www.w3.org/TR/service-workers-1/#cache-storage-keys-method.
Refreshing the cache map and returnin its keys.
As per spec, the cache map is ordered. We implement it as a Vector.
(WebCore::CacheStorage::cacheMap):
Get the list of cache objects, used as a private accessor for JS built-ins.

• Modules/cache/CacheStorage.h:

(WebCore::CacheStorage::create):
(WebCore::CacheStorage::CacheStorage):

• Modules/cache/CacheStorageConnection.cpp: Added.

(WebCore::CacheStorageConnection::exceptionFromError):

• Modules/cache/CacheStorageConnection.h: Added.

Makes the link between Web facing Cache API and the cache storage engine.
Envisioned implementation are:

• One main thread connection used by all documents in the given process.
• One connection per worker that forwards the calls to the main thread and use the main thread connection afterwards.

(WebCore::CacheStorageConnection::create):
(WebCore::CacheStorageConnection::open):
(WebCore::CacheStorageConnection::remove):
(WebCore::CacheStorageConnection::refreshCacheMap):
(WebCore::CacheStorageConnection::refreshRequestToResponseMap):
(WebCore::CacheStorageConnection::batchDeleteOperation):
(WebCore::CacheStorageConnection::batchPutOperation):

• Modules/cache/CacheStorageRecord.h: Added. A fetch record from the Web facing cache API perspective.
• Modules/cache/DOMWindowCaches.cpp:

(WebCore::DOMWindowCaches::caches const):

• Modules/cache/WorkerGlobalScopeCaches.cpp:

(WebCore::WorkerGlobalScopeCaches::from):
(WebCore::WorkerGlobalScopeCaches::caches const):

• Modules/cache/WorkerGlobalScopeCaches.h:

(WebCore::WorkerGlobalScopeCaches::WorkerGlobalScopeCaches):

• Modules/fetch/FetchBodyOwner.h:

(WebCore::FetchBodyOwner::isReadableStreamBody const): Added getter as it is used by cache API.

• Modules/fetch/FetchHeaders.h:

(WebCore::FetchHeaders::create): Add another create as used by the cache API.
(WebCore::FetchHeaders::guard const): Added getter and IPC serializer as this is something that will be stored by the cache engine.

• Modules/fetch/FetchLoader.cpp:

(WebCore::FetchLoader::start):

• Modules/fetch/FetchRequest.cpp:

(WebCore::buildOptions): In case FetchRequest::create is called from C++, there is no need to set init.window to a null value.
Add a check so that no value at all is the same as a null/undefined value.
(WebCore::FetchRequest::resourceRequest const):

• Modules/fetch/FetchRequest.h:
• Modules/fetch/FetchResponse.h:
• WebCore.xcodeproj/project.pbxproj:
• inspector/InspectorOverlay.cpp:

(WebCore::InspectorOverlay::overlayPage):

• page/CacheStorageProvider.h: Added.

Interface to create main thread cache storage connection for the given page.
There will be one provider for each process.
Passing a sessionID so that we will create a connection per session.

• page/Page.cpp:

(WebCore::Page::Page):

• page/Page.h:

(WebCore::Page::cacheStorageProvider):

• page/PageConfiguration.cpp:

(WebCore::PageConfiguration::PageConfiguration):

• page/PageConfiguration.h:
• svg/graphics/SVGImage.cpp:

(WebCore::SVGImage::dataChanged):

Source/WebKit:

• WebKit.xcodeproj/project.pbxproj:
• WebProcess/Cache/WebCacheStorageProvider.h: Added.
• WebProcess/WebPage/WebPage.cpp:

(WebKit::m_cpuLimit):

• WebProcess/WebProcess.cpp:

(WebKit::WebProcess::WebProcess):

• WebProcess/WebProcess.h:

(WebKit::WebProcess::cacheStorageProvider):

Source/WebKitLegacy/mac:

• WebView/WebView.mm:

(-[WebView _commonInitializationWithFrameName:groupName:]):

Source/WebKitLegacy/win:

• WebView.cpp:

(WebView::initWithFrame):

LayoutTests:

• TestExpectations: Skipping a test that would timeout otherwise due to the current implementation limitations.

1:45 PM Changeset in webkit [220757] by jmarcell@apple.com

• 3 edits in branches/safari-604.1.38.1-branch/Source/WebCore

Cherry-pick r220723. rdar://problem/33901117

1:41 PM Changeset in webkit [220756] by jmarcell@apple.com

• 6 edits
  2 adds in branches/safari-604-branch

Cherry-pick r217197. rdar://problem/33890650

1:36 PM Changeset in webkit [220755] by jmarcell@apple.com

• 6 edits
  2 adds in branches/safari-604.1.38.0-branch

Cherry-pick r217197. rdar://problem/33890636

1:21 PM Changeset in webkit [220754] by commit-queue@webkit.org

• 2 edits in trunk/LayoutTests/imported/w3c

WPT harness errors on leaks bot
​https://bugs.webkit.org/show_bug.cgi?id=175269

Patch by Youenn Fablet <​youenn@apple.com> on 2017-08-15
Reviewed by Alexey Proskuryakov.

To try debugging these errors, let's check whether the WPT server is
sending back resources of the expected size.

• web-platform-tests/tools/wptserve/wptserve/response.py:

(Response.write_content):
(ResponseWriter.write_content):
(ResponseWriter.write):
(ResponseWriter.write_content_file):

1:13 PM Changeset in webkit [220753] by keith_miller@apple.com

• 13 edits in trunk/Source/JavaScriptCore

Enable named offsets into JSC bytecodes
​https://bugs.webkit.org/show_bug.cgi?id=175561

Reviewed by Mark Lam.

This patch adds the ability to add named offsets into JSC's
bytecodes. In the bytecode json file, instead of listing a
length, you can now list a set of names and their types. Each
opcode with an offsets property will have a struct named after the
opcode by in our C++ naming style. For example,
op_overrides_has_instance would become OpOverridesHasInstance. The
struct has the same memory layout as the instruction list has but
comes with handy named accessors.

As a first cut I converted the various instanceof bytecodes to use
named offsets.

As an example op_overrides_has_instance produces the following struct:

struct OpOverridesHasInstance {
public:

Opcode& opcode() { return *reinterpret_cast<Opcode*>(&m_opcode); }
const Opcode& opcode() const { return *reinterpret_cast<const Opcode*>(&m_opcode); }
int& dst() { return *reinterpret_cast<int*>(&m_dst); }
const int& dst() const { return *reinterpret_cast<const int*>(&m_dst); }
int& constructor() { return *reinterpret_cast<int*>(&m_constructor); }
const int& constructor() const { return *reinterpret_cast<const int*>(&m_constructor); }
int& hasInstanceValue() { return *reinterpret_cast<int*>(&m_hasInstanceValue); }
const int& hasInstanceValue() const { return *reinterpret_cast<const int*>(&m_hasInstanceValue); }

private:

friend class LLIntOffsetsExtractor;
std::aligned_storage<sizeof(Opcode), sizeof(Instruction)>::type m_opcode;
std::aligned_storage<sizeof(int), sizeof(Instruction)>::type m_dst;
std::aligned_storage<sizeof(int), sizeof(Instruction)>::type m_constructor;
std::aligned_storage<sizeof(int), sizeof(Instruction)>::type m_hasInstanceValue;

};

• CMakeLists.txt:
• DerivedSources.make:
• JavaScriptCore.xcodeproj/project.pbxproj:
• bytecode/BytecodeList.json:
• dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::parseBlock):

• generate-bytecode-files:
• jit/JITOpcodes.cpp:

(JSC::JIT::emit_op_overrides_has_instance):
(JSC::JIT::emit_op_instanceof):
(JSC::JIT::emitSlow_op_instanceof):
(JSC::JIT::emitSlow_op_instanceof_custom):

• jit/JITOpcodes32_64.cpp:

(JSC::JIT::emit_op_overrides_has_instance):
(JSC::JIT::emit_op_instanceof):
(JSC::JIT::emitSlow_op_instanceof):
(JSC::JIT::emitSlow_op_instanceof_custom):

• llint/LLIntOffsetsExtractor.cpp:
• llint/LowLevelInterpreter.asm:
• llint/LowLevelInterpreter32_64.asm:
• llint/LowLevelInterpreter64.asm:

1:11 PM Changeset in webkit [220752] by msaboff@apple.com

• 5 edits
  19 adds in trunk/PerformanceTests

Add Offline Assembler parsing test to RexBench
​https://bugs.webkit.org/show_bug.cgi?id=175581

Reviewed by Saam Barati.

This is a port of the JavaScriptCore offline assmebler's lexer, parser, AST and
supporting code from Ruby to JavaScript turned into a benchmark. The benchmark
timing includes parsing through AST. The validation processing time is not
part of the benchmark measurement.

The input data is the current tip of tree LLInt .asm source files. Those file
were converted to JavaScript using the python script, convert_asm_to_js.py.
There is also a new JavaScript file, generate_expected.js, to create the
expected output JavaScript file.

• RexBench/OfflineAssembler: Added.
• RexBench/OfflineAssembler/ast.js: Added.
• RexBench/OfflineAssembler/instructions.js: Added.
• RexBench/OfflineAssembler/parser.js: Added.
• RexBench/OfflineAssembler/registers.js: Added.

These are JavaScript translation of the Ruby Offline Assembler. Code not
needed for the benchmark was not translated and therefore missing.

• RexBench/OfflineAssembler/InitBytecodes.asm: Added.
• RexBench/OfflineAssembler/InitBytecodes.js: Added.
• RexBench/OfflineAssembler/LowLevelInterpreter.asm: Added.
• RexBench/OfflineAssembler/LowLevelInterpreter.js: Added.
• RexBench/OfflineAssembler/LowLevelInterpreter32_64.asm: Added.
• RexBench/OfflineAssembler/LowLevelInterpreter32_64.js: Added.
• RexBench/OfflineAssembler/LowLevelInterpreter64.asm: Added.
• RexBench/OfflineAssembler/LowLevelInterpreter64.js: Added.

Copies of the current LLInt source and conversion to JavaScript.

• RexBench/OfflineAssembler/file.js: Added.

(File):
(File.open):
(File.prototype.read):
Mock File class used to simulate filesystem access.

• RexBench/OfflineAssembler/expected.js: Added.

Expected output of the AST dumped and split into individual lines.

• RexBench/OfflineAssembler/benchmark.js: Added.

(OfflineAssemblerBenchmark):
(OfflineAssemblerBenchmark.prototype.runOnce):
(OfflineAssemblerBenchmark.prototype.validate):
Benchmark sub class for this test.

• RexBench/OfflineAssembler/convert_asm_to_js.py: Added.

(convertFile):
Converts .asm into .js files compatible to the benchmark.

• RexBench/OfflineAssembler/generate_expected.js: Added.

Converts AST output into the expected file format.

• RexBench/about.html: Added description of this sub-benchmark test.

• RexBench/cli.js:
• RexBench/glue.js:
• RexBench/index.html:
• RexBench/offline_assembler_benchmark.js: Added.

Updates to add this sub-benchmark.

12:35 PM Changeset in webkit [220751] by Chris Dumez

• 38 edits
  4 adds in trunk

Implement quota limitation for keepalive Fetch requests
​https://bugs.webkit.org/show_bug.cgi?id=175482

Reviewed by Sam Weinig and Youenn Fablet.

LayoutTests/imported/w3c:

• web-platform-tests/fetch/api/basic/scheme-about.any-expected.txt:
• web-platform-tests/fetch/api/basic/scheme-about.any.worker-expected.txt:
• web-platform-tests/fetch/api/cors/cors-multiple-origins-expected.txt:
• web-platform-tests/fetch/api/cors/cors-multiple-origins-worker-expected.txt:
• web-platform-tests/fetch/api/cors/cors-preflight-star.any-expected.txt:
• web-platform-tests/fetch/api/cors/cors-preflight-star.any.worker-expected.txt:
• web-platform-tests/fetch/http-cache/cc-request-expected.txt:

Rebaseline tests now that we provide a more helpful error message when rejecting
the fetch() promise.

• web-platform-tests/fetch/api/request/request-keepalive-quota-expected.txt:

Rebaseline test for keepalive Fetch requests quota which is now passing.

Source/WebCore:

Implement quota limitation for keepalive Fetch requests as per:

• ​https://fetch.spec.whatwg.org/#http-network-or-cache-fetch (Step 9)

This partly works for Beacon as well, meaning that no Beacon with a body
over 64Kb can be sent. However, we don't keep track about wether or not
beacon loads are inflight or not.

Also update CachedResourceLoader::requestResource() so that the caller
can get a ResourceError when it returns null. This is useful for both
Fetch and Beacon to return better error messages.

Test: http/wpt/beacon/beacon-quota.html

• CMakeLists.txt:
• Modules/beacon/NavigatorBeacon.cpp:

(WebCore::NavigatorBeacon::sendBeacon):

• Modules/fetch/FetchBodyOwner.cpp:

(WebCore::FetchBodyOwner::BlobLoader::didReceiveResponse):
(WebCore::FetchBodyOwner::BlobLoader::didFail):

• Modules/fetch/FetchBodyOwner.h:
• Modules/fetch/FetchLoader.cpp:

(WebCore::FetchLoader::start):
(WebCore::FetchLoader::didFail):

• Modules/fetch/FetchLoaderClient.h:
• Modules/fetch/FetchResponse.cpp:

(WebCore::FetchResponse::BodyLoader::didFail):

• Modules/fetch/FetchResponse.h:
• WebCore.xcodeproj/project.pbxproj:
• loader/DocumentThreadableLoader.cpp:

(WebCore::DocumentThreadableLoader::loadRequest):

• loader/cache/CachedResource.cpp:

(WebCore::CachedResource::load):

• loader/cache/CachedResource.h:

(WebCore::CachedResource::isMainOrMediaOrIconOrRawResource const):

• loader/cache/CachedResourceLoader.cpp:

(WebCore::createResource):
(WebCore::CachedResourceLoader::requestImage):
(WebCore::CachedResourceLoader::requestFont):
(WebCore::CachedResourceLoader::requestTextTrack):
(WebCore::CachedResourceLoader::requestCSSStyleSheet):
(WebCore::CachedResourceLoader::requestUserCSSStyleSheet):
(WebCore::CachedResourceLoader::requestScript):
(WebCore::CachedResourceLoader::requestXSLStyleSheet):
(WebCore::CachedResourceLoader::requestSVGDocument):
(WebCore::CachedResourceLoader::requestLinkResource):
(WebCore::CachedResourceLoader::requestMedia):
(WebCore::CachedResourceLoader::requestIcon):
(WebCore::CachedResourceLoader::requestRawResource):
(WebCore::CachedResourceLoader::requestBeaconResource):
(WebCore::CachedResourceLoader::requestMainResource):
(WebCore::CachedResourceLoader::requestResource):
(WebCore::CachedResourceLoader::preload):

• loader/cache/CachedResourceLoader.h:
• loader/cache/KeepaliveRequestTracker.cpp: Added.

(WebCore::KeepaliveRequestTracker::~KeepaliveRequestTracker):
(WebCore::KeepaliveRequestTracker::canLoadRequest):
(WebCore::KeepaliveRequestTracker::registerRequest):
(WebCore::KeepaliveRequestTracker::responseReceived):
(WebCore::KeepaliveRequestTracker::notifyFinished):
(WebCore::KeepaliveRequestTracker::unregisterRequest):

• loader/cache/KeepaliveRequestTracker.h: Added.
• platform/network/FormData.cpp:

(WebCore::FormDataElement::lengthInBytes const):
(WebCore::FormData::lengthInBytes const):

• platform/network/FormData.h:

LayoutTests:

• fast/xmlhttprequest/xmlhttprequest-nonexistent-file-expected.txt:
• http/tests/contentextensions/async-xhr-onerror-expected.txt:
• http/tests/security/contentSecurityPolicy/block-all-mixed-content/insecure-xhr-asynchronous-in-iframe-expected.txt:
• http/tests/security/contentSecurityPolicy/block-all-mixed-content/insecure-xhr-asynchronous-in-main-frame-expected.txt:
• http/tests/security/mixedContent/insecure-xhr-in-main-frame-expected.txt:

Rebaseline a few tests now that we provide a more helpful error message when an XHR is failing synchronously.

• http/wpt/beacon/beacon-quota-expected.txt: Added.
• http/wpt/beacon/beacon-quota.html: Added.

Add layout test coverage for keepalive Fetch requests quota in the context of sendBeacon().
The second part of the test is still failing because WebCore does not currently know when
ping loads (e.g. beacon loads) complete. This will be addressed via Bug 175443.

11:13 AM Changeset in webkit [220750] by Darin Adler

• 4 edits in trunk

REGRESSION(r220052): http/tests/appcache/deferred-events-delete-while-raising-timer.html is crashing.
​https://bugs.webkit.org/show_bug.cgi?id=175107

Reviewed by Alexey Proskuryakov.

Source/WebCore:

• loader/FrameLoader.cpp:

(WebCore::FrameLoader::checkLoadComplete): Moved the assertion to after the null page check.

LayoutTests:

• TestExpectations: Removed the flakiness expectation for this test.

10:57 AM Changeset in webkit [220749] by matthew_hanson@apple.com

• 6 edits
  1 copy
  1 add in branches/safari-604-branch

Cherry-pick r220722. rdar://problem/33890577

10:55 AM WebKitGTK/Gardening/Calendar edited by Michael Catanzaro

(diff)

10:50 AM Changeset in webkit [220748] by matthew_hanson@apple.com

• 6 edits
  1 copy
  1 add in branches/safari-604.1.38.0-branch

Cherry-pick r220722. rdar://problem/33890575

10:47 AM Changeset in webkit [220747] by Michael Catanzaro

• 6 edits
  4 adds in trunk/LayoutTests

Unreviewed GTK test gardening

• TestExpectations:
• platform/gtk/TestExpectations:
• platform/gtk/fast/events/input-events-paste-rich-datatransfer-expected.txt:
• platform/gtk/imported/w3c/web-platform-tests/eventsource/format-field-id-2-expected.txt: Added.
• platform/gtk/imported/w3c/web-platform-tests/eventsource/format-field-id-expected.txt: Added.
• platform/gtk/imported/w3c/web-platform-tests/eventsource/format-mime-bogus-expected.txt: Added.
• platform/ios/TestExpectations:
• platform/mac/TestExpectations:

10:15 AM Changeset in webkit [220746] by commit-queue@webkit.org

• 3 edits
  2 deletes in trunk

Unreviewed, rolling out r219504.
​https://bugs.webkit.org/show_bug.cgi?id=175580

Broke Arabic text shaping (Requested by mcatanzaro on
#webkit).

Reverted changeset:

"[HarfBuzz] Decomposed Vietnamese characters are rendered
incorrectly"
​https://bugs.webkit.org/show_bug.cgi?id=174418
​http://trac.webkit.org/changeset/219504

10:05 AM Changeset in webkit [220745] by Ryan Haddad

• 2 edits in branches/safari-604.1.38.0-branch/LayoutTests

Cherry-pick r219572.

9:42 AM Changeset in webkit [220744] by mark.lam@apple.com

• 2 edits in trunk/Source/JavaScriptCore

Update testmasm to use new CPUState APIs.
​https://bugs.webkit.org/show_bug.cgi?id=175573

Reviewed by Keith Miller.

1. Applied convenience CPUState accessors to minimize casting.
2. Converted the CHECK macro to CHECK_EQ to get more friendly failure debugging messages.
3. Removed the CHECK_DOUBLE_BITWISE_EQ macro. We can just use CHECK_EQ now since casting is (mostly) no longer an issue.
4. Replaced the use of testDoubleWord(id) with bitwise_cast<double>(testWord64(id)) to make it clear that we're comparing against the bit values of testWord64(id).
5. Added a "Completed N tests" message at the end of running all tests. This makes it easy to tell at a glance that testmasm completed successfully versus when it crashed midway in a test. The number of tests also serves as a quick checksum to confirm that we ran the number of tests we expected.

• assembler/testmasm.cpp:

(WTF::printInternal):
(JSC::testSimple):
(JSC::testProbeReadsArgumentRegisters):
(JSC::testProbeWritesArgumentRegisters):
(JSC::testProbePreservesGPRS):
(JSC::testProbeModifiesStackPointer):
(JSC::testProbeModifiesProgramCounter):
(JSC::run):

8:31 AM Changeset in webkit [220743] by Ryan Haddad

• 2 edits in branches/safari-604.1.38.1-branch/LayoutTests

Cherry-pick r219697.

7:16 AM Changeset in webkit [220742] by Michael Catanzaro

• 5 edits in trunk/Source/WebKit

Unreviewed, rolling out r220700.

Broke debug bot

Reverted changeset:

"[CoordGraphics] Simplify CoordinatedGraphicsScene state
updates"
​https://bugs.webkit.org/show_bug.cgi?id=175528
​http://trac.webkit.org/changeset/220700

12:17 AM Changeset in webkit [220741] by Carlos Garcia Campos

• 4 edits in trunk/Source/WebKit

WebDriver: timeout when JavaScript alert is shown in onload handler
​https://bugs.webkit.org/show_bug.cgi?id=175315
<rdar://problem/33788294>

Reviewed by Brian Burg.

When a JavaScript alert is shown in an onload handler, the alert prevents the load from finishing in case of
normal page load strategy, so navigation commands or any other command for which we wait for navigation to
complete end up timing out. There are two selenium tests covering this that are currently timing out:
testShouldHandleAlertOnPageLoad and testShouldHandleAlertOnPageLoadUsingGet. The spec says that in case of page
load timeout we should only fail with timeout error when there isn't an active alert dialog. If the next command
expects an alert it will just work, otherwise it will fail with UnexpectedAlertOpen error when trying to handle
user prompts.

9 Navigation.
​https://w3c.github.io/webdriver/webdriver-spec.html#dfn-wait-for-navigation-to-complete

• UIProcess/Automation/WebAutomationSession.cpp:

(WebKit::WebAutomationSession::waitForNavigationToComplete): Do not wait for the timeout when the page is
loading and there's an active alert in case of normal page load strategy.
(WebKit::WebAutomationSession::respondToPendingPageNavigationCallbacksWithTimeout): Respond with timeout unless
the page is showing a JavaScript dialog.
(WebKit::WebAutomationSession::respondToPendingFrameNavigationCallbacksWithTimeout): Ditto.
(WebKit::WebAutomationSession::loadTimerFired): Use respondToPendingPageNavigationCallbacksWithTimeout() and
respondToPendingFrameNavigationCallbacksWithTimeout().
(WebKit::WebAutomationSession::willShowJavaScriptDialog): The page is about to show a JavaScript dialog, so
we wait until the next run loop iteration to give time for the client to show the dialog, then check if page is
loading and the dialog is still present. If that's the case we finish all normal strategy pending navigations.

• UIProcess/Automation/WebAutomationSession.h:
• UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::runJavaScriptAlert): If controlled by automation, notify the session.
(WebKit::WebPageProxy::runJavaScriptConfirm): Ditto.
(WebKit::WebPageProxy::runJavaScriptPrompt): Ditto.
(WebKit::WebPageProxy::runBeforeUnloadConfirmPanel): Ditto.

12:03 AM Changeset in webkit [220740] by Carlos Garcia Campos

• 16 edits in trunk/Source

WebDriver: handle click events on option elements
​https://bugs.webkit.org/show_bug.cgi?id=174710
<rdar://problem/33459305>

Reviewed by Brian Burg.

Source/WebCore:

Export WebCore symbols required by WebKit layer.

• html/HTMLOptGroupElement.h:
• html/HTMLOptionElement.h:

Source/WebDriver:

Option elements are considered as a special case by the specification. When clicking an option element, we
should get its container and use it when scrolling into view and calculating in-view center point instead of the
option element itself. Then, we should not emulate a click, but change the selected status of the option element
like if it were done by a user action, firing the corresponding events. Now we check whether the element is an
option to call selectOptionElement() or performMouseInteraction().

This fixes more than 20 selenium tests.

• CommandResult.cpp:

(WebDriver::CommandResult::CommandResult): Handle ElementNotSelectable protocol error.
(WebDriver::CommandResult::httpStatusCode const): Add ElementNotSelectable.
(WebDriver::CommandResult::errorString const): Ditto.

• CommandResult.h:
• Session.cpp:

(WebDriver::Session::selectOptionElement): Ask automation to select the given option element.
(WebDriver::Session::elementClick): Call selectOptionElement() or performMouseInteraction() depending on whether
the element is an option or not.

• Session.h:

Source/WebKit:

Add selectOptionElement method to automation to select an option element according to the WebDriver
specification.

14.1 Element Click.
​https://w3c.github.io/webdriver/webdriver-spec.html#element-click

• UIProcess/Automation/Automation.json: Add selectOptionElement method and ElementNotSelectable error.
• UIProcess/Automation/WebAutomationSession.cpp:

(WebKit::WebAutomationSession::selectOptionElement):Send SelectOptionElement message to the web process.
(WebKit::WebAutomationSession::didSelectOptionElement): Notify the driver.

• UIProcess/Automation/WebAutomationSession.h:
• UIProcess/Automation/WebAutomationSession.messages.in: Add DidSelectOptionElement message.
• WebProcess/Automation/WebAutomationSessionProxy.cpp:

(WebKit::elementContainer): Helper to get the container of an element according to the spec.
(WebKit::WebAutomationSessionProxy::computeElementLayout): Use the container element to scroll the view and
compute the in-view center point.
(WebKit::WebAutomationSessionProxy::selectOptionElement): Use HTMLSelectElement::optionSelectedByUser().

• WebProcess/Automation/WebAutomationSessionProxy.h:
• WebProcess/Automation/WebAutomationSessionProxy.messages.in: Add SelectOptionElement message.