Timeline

Aug 19, 2017:

7:11 PM Changeset in webkit [220955] by aestes@apple.com

• 30 edits
  36 adds in trunk

[Payment Request] Add interface stubs
​https://bugs.webkit.org/show_bug.cgi?id=175730

Reviewed by Youenn Fablet.

LayoutTests/imported/w3c:

• web-platform-tests/payment-request/allowpaymentrequest/active-document-cross-origin.https.sub-expected.txt:
• web-platform-tests/payment-request/allowpaymentrequest/active-document-same-origin.https-expected.txt:
• web-platform-tests/payment-request/allowpaymentrequest/allowpaymentrequest-attribute-same-origin-bc-containers.https-expected.txt:
• web-platform-tests/payment-request/allowpaymentrequest/basic.https-expected.txt:
• web-platform-tests/payment-request/allowpaymentrequest/no-attribute-same-origin-bc-containers.https-expected.txt:
• web-platform-tests/payment-request/historical.https-expected.txt:
• web-platform-tests/payment-request/interfaces.https-expected.txt:
• web-platform-tests/payment-request/payment-request-abort-method.https-expected.txt:
• web-platform-tests/payment-request/payment-request-constructor-crash.https-expected.txt:
• web-platform-tests/payment-request/payment-request-constructor.https-expected.txt:
• web-platform-tests/payment-request/payment-request-id.https-expected.txt:
• web-platform-tests/payment-request/payment-request-in-iframe-expected.txt:
• web-platform-tests/payment-request/payment-request-onshippingaddresschange-attribute.https-expected.txt:
• web-platform-tests/payment-request/payment-request-onshippingoptionchange-attribute.https-expected.txt:
• web-platform-tests/payment-request/payment-request-show-method.https-expected.txt:
• web-platform-tests/payment-request/payment-request-update-event-constructor.http-expected.txt:
• web-platform-tests/payment-request/payment-request-update-event-constructor.https-expected.txt:

Source/JavaScriptCore:

• runtime/CommonIdentifiers.h:

Source/WebCore:

• DerivedSources.make:
• Modules/paymentrequest/PaymentAddress.h: Added.
• Modules/paymentrequest/PaymentAddress.idl: Added.
• Modules/paymentrequest/PaymentComplete.h: Added.
• Modules/paymentrequest/PaymentComplete.idl: Added.
• Modules/paymentrequest/PaymentCurrencyAmount.h: Added.
• Modules/paymentrequest/PaymentCurrencyAmount.idl: Added.
• Modules/paymentrequest/PaymentDetailsBase.h: Added.
• Modules/paymentrequest/PaymentDetailsBase.idl: Added.
• Modules/paymentrequest/PaymentDetailsInit.h: Added.
• Modules/paymentrequest/PaymentDetailsInit.idl: Added.
• Modules/paymentrequest/PaymentDetailsModifier.h: Added.
• Modules/paymentrequest/PaymentDetailsModifier.idl: Added.
• Modules/paymentrequest/PaymentDetailsUpdate.h: Added.
• Modules/paymentrequest/PaymentDetailsUpdate.idl: Added.
• Modules/paymentrequest/PaymentItem.h: Added.
• Modules/paymentrequest/PaymentItem.idl: Added.
• Modules/paymentrequest/PaymentMethodData.h: Added.
• Modules/paymentrequest/PaymentMethodData.idl: Added.
• Modules/paymentrequest/PaymentOptions.h: Added.
• Modules/paymentrequest/PaymentOptions.idl: Added.
• Modules/paymentrequest/PaymentRequest.cpp: Added.

(WebCore::PaymentRequest::create):
(WebCore::PaymentRequest::PaymentRequest):
(WebCore::PaymentRequest::~PaymentRequest):
(WebCore::PaymentRequest::show):
(WebCore::PaymentRequest::abort):
(WebCore::PaymentRequest::canMakePayment):

• Modules/paymentrequest/PaymentRequest.h: Added.
• Modules/paymentrequest/PaymentRequest.idl: Added.
• Modules/paymentrequest/PaymentRequestUpdateEvent.cpp: Added.

(WebCore::PaymentRequestUpdateEvent::~PaymentRequestUpdateEvent):
(WebCore::PaymentRequestUpdateEvent::updateWith):

• Modules/paymentrequest/PaymentRequestUpdateEvent.h: Added.
• Modules/paymentrequest/PaymentRequestUpdateEvent.idl: Added.
• Modules/paymentrequest/PaymentRequestUpdateEventInit.h: Added.
• Modules/paymentrequest/PaymentRequestUpdateEventInit.idl: Added.
• Modules/paymentrequest/PaymentResponse.cpp: Added.

(WebCore::PaymentResponse::complete):

• Modules/paymentrequest/PaymentResponse.h: Added.
• Modules/paymentrequest/PaymentResponse.idl: Added.
• Modules/paymentrequest/PaymentShippingOption.h: Added.
• Modules/paymentrequest/PaymentShippingOption.idl: Added.
• Modules/paymentrequest/PaymentShippingType.h: Added.
• Modules/paymentrequest/PaymentShippingType.idl: Added.
• WebCore.xcodeproj/project.pbxproj:
• dom/EventNames.h:
• dom/EventNames.in:
• dom/EventTargetFactory.in:

LayoutTests:

• TestExpectations: Skipped payment-request tests.
• platform/ios-wk2/TestExpectations: Enabled payment-request tests on ios-wk2.
• platform/mac-wk2/TestExpectations: Ditto for mac-wk2.

10:28 AM Changeset in webkit [220954] by commit-queue@webkit.org

• 15 edits in trunk/Source/WebCore

[WebCrypto] Remove the KeyAlgorithm type hierarchy
​https://bugs.webkit.org/show_bug.cgi?id=175750

Patch by Sam Weinig <​sam@webkit.org> on 2017-08-19
Reviewed by Chris Dumez.

Removes the unnecessary indirection that existed to generate a
KeyAlgorithm dictionary (or rather, one of its derived dictionaries)
for a CryptoKey. We were calling the virtual buildAlgorithm(), which
return a std::unique_ptr<KeyAlgorithm>, which we then casted to the
correct derived class and called dictionary() on. This can now be
simplified by making each CryptoKey derived class override a function
that returns the KeyAlgorithm variant.

• crypto/CryptoKey.cpp:

(WebCore::CryptoKey::algorithm const): Deleted.

• crypto/CryptoKey.h:

(WebCore::CryptoKey::extractable const):
(WebCore::KeyAlgorithm::~KeyAlgorithm): Deleted.
(WebCore::KeyAlgorithm::name const): Deleted.
(WebCore::KeyAlgorithm::KeyAlgorithm): Deleted.

• crypto/gcrypt/CryptoKeyRSAGCrypt.cpp:

(WebCore::CryptoKeyRSA::algorithm const):
(WebCore::CryptoKeyRSA::buildAlgorithm const): Deleted.

• crypto/keys/CryptoKeyAES.cpp:

(WebCore::CryptoKeyAES::algorithm const):
(WebCore::AesKeyAlgorithm::dictionary const): Deleted.
(WebCore::CryptoKeyAES::buildAlgorithm const): Deleted.

• crypto/keys/CryptoKeyAES.h:
• crypto/keys/CryptoKeyEC.cpp:

(WebCore::CryptoKeyEC::algorithm const):
(WebCore::EcKeyAlgorithm::dictionary const): Deleted.
(WebCore::CryptoKeyEC::buildAlgorithm const): Deleted.

• crypto/keys/CryptoKeyEC.h:

(WebCore::EcKeyAlgorithm::EcKeyAlgorithm): Deleted.
(WebCore::EcKeyAlgorithm::namedCurve const): Deleted.

• crypto/keys/CryptoKeyHMAC.cpp:

(WebCore::CryptoKeyHMAC::algorithm const):
(WebCore::HmacKeyAlgorithm::dictionary const): Deleted.
(WebCore::CryptoKeyHMAC::buildAlgorithm const): Deleted.

• crypto/keys/CryptoKeyHMAC.h:
• crypto/keys/CryptoKeyRSA.cpp:

(WebCore::RsaKeyAlgorithm::dictionary const): Deleted.
(WebCore::RsaHashedKeyAlgorithm::dictionary const): Deleted.

• crypto/keys/CryptoKeyRSA.h:

(WebCore::RsaKeyAlgorithm::RsaKeyAlgorithm): Deleted.
(WebCore::RsaKeyAlgorithm::modulusLength const): Deleted.
(WebCore::RsaKeyAlgorithm::publicExponent const): Deleted.

• crypto/keys/CryptoKeyRaw.cpp:

(WebCore::CryptoKeyRaw::algorithm const):
(WebCore::RawKeyAlgorithm::dictionary const): Deleted.
(WebCore::CryptoKeyRaw::buildAlgorithm const): Deleted.

• crypto/keys/CryptoKeyRaw.h:

(WebCore::RawKeyAlgorithm::RawKeyAlgorithm): Deleted.

• crypto/mac/CryptoKeyRSAMac.cpp:

(WebCore::CryptoKeyRSA::algorithm const):
(WebCore::CryptoKeyRSA::buildAlgorithm const): Deleted.

9:41 AM Changeset in webkit [220953] by commit-queue@webkit.org

• 7 edits in trunk/Source/WebCore

[Mac] Change uint8_t* to Vector<uint8_t> type in all crypto algorithm implementation
​https://bugs.webkit.org/show_bug.cgi?id=164939

Patch by Sam Weinig <​sam@webkit.org> on 2017-08-19
Reviewed by Chris Dumez.

Address FIXMEs, replacing uint8_t*/size_t parameters with Vector<uint8_t>&.

• crypto/mac/CryptoAlgorithmAES_CBCMac.cpp:

(WebCore::transformAES_CBC):
(WebCore::CryptoAlgorithmAES_CBC::platformEncrypt):
(WebCore::CryptoAlgorithmAES_CBC::platformDecrypt):

• crypto/mac/CryptoAlgorithmAES_KWMac.cpp:

(WebCore::wrapKeyAES_KW):
(WebCore::unwrapKeyAES_KW):
(WebCore::CryptoAlgorithmAES_KW::platformWrapKey):
(WebCore::CryptoAlgorithmAES_KW::platformUnwrapKey):

• crypto/mac/CryptoAlgorithmHMACMac.cpp:

(WebCore::calculateSignature):
(WebCore::CryptoAlgorithmHMAC::platformSign):
(WebCore::CryptoAlgorithmHMAC::platformVerify):

• crypto/mac/CryptoAlgorithmRSAES_PKCS1_v1_5Mac.cpp:

(WebCore::encryptRSAES_PKCS1_v1_5):
(WebCore::decryptRSAES_PKCS1_v1_5):
(WebCore::CryptoAlgorithmRSAES_PKCS1_v1_5::platformEncrypt):
(WebCore::CryptoAlgorithmRSAES_PKCS1_v1_5::platformDecrypt):

• crypto/mac/CryptoAlgorithmRSASSA_PKCS1_v1_5Mac.cpp:

(WebCore::signRSASSA_PKCS1_v1_5):
(WebCore::verifyRSASSA_PKCS1_v1_5):
(WebCore::CryptoAlgorithmRSASSA_PKCS1_v1_5::platformSign):
(WebCore::CryptoAlgorithmRSASSA_PKCS1_v1_5::platformVerify):

• crypto/mac/CryptoAlgorithmRSA_OAEPMac.cpp:

(WebCore::encryptRSA_OAEP):
(WebCore::decryptRSA_OAEP):
(WebCore::CryptoAlgorithmRSA_OAEP::platformEncrypt):
(WebCore::CryptoAlgorithmRSA_OAEP::platformDecrypt):

1:46 AM Changeset in webkit [220952] by Wenson Hsieh

• 2 edits in trunk/Tools

[iOS WK2] Add a version of DataInteractionTests.ExternalSourceAttributedStringToContentEditable that doesn't hit a debug assertion
​https://bugs.webkit.org/show_bug.cgi?id=175509
<rdar://problem/33728169>

Reviewed by Ryosuke Niwa.

Removes ExternalSourceAttributedStringToContentEditable and adds
ExternalSourceColoredAttributedStringToContentEditable, which tests dropping an attributed string with colored
text instead of a bold attributed string of system font. Due to a recent change in behavior in UIKit, the
original test (which this patch renames to ExternalSourceBoldSystemAttributedStringToContentEditable) hits a
debug assertion when dropping text of system bold font. Since the original intent of this test was to verify
that the attributed string UTI can be accepted in richly contenteditable areas, it suffices to check that some
other style attribute, such as color, carries over from the NSAttributedString to the DOM.

Also marks ExternalSourceBoldSystemAttributedStringToContentEditable as disabled for the time being.

• TestWebKitAPI/Tests/ios/DataInteractionTests.mm:

(TestWebKitAPI::TEST):

Aug 18, 2017:

11:40 PM Changeset in webkit [220951] by rniwa@webkit.org

• 4 edits in trunk/Source/WebCore

Forbid setDragImage after dragstart
​https://bugs.webkit.org/show_bug.cgi?id=175751

Reviewed by Wenson Hsieh.

Removed the code to allow setting the drag mage after dragstart had happened.

The feature was apparently used in Mac WebKit1 port but using it today causes the drag image
to disapepar while the user is moving the mouse cursor and being drawn once it's stopped
and results in the contionus flickering of the drag image.

The feaure was never supported in WebKit2 and doesn't match the HTML5 specification:
​https://html.spec.whatwg.org/multipage/dnd.html#concept-dnd-rw
​https://html.spec.whatwg.org/multipage/dnd.html#dom-datatransfer-setdragimage
or the behaviors of other browsers such as Chrome and Firefox.

No new tests. This patch simply removes code.

• dom/DataTransfer.cpp:

(WebCore::DataTransfer::setDragImage):
(WebCore::DataTransfer::canSetDragImage const): Deleted.

• dom/DataTransfer.h:

(WebCore::DataTransfer::makeDragImageWritable): Deleted.

• page/EventHandler.cpp:

(WebCore::EventHandler::handleDrag):

8:05 PM Changeset in webkit [220950] by rniwa@webkit.org

• 4 edits in trunk

REGRESSION(r219640): Speedometer no longer runs on Safari 7
​https://bugs.webkit.org/show_bug.cgi?id=175749

Reviewed by Joseph Pecoraro.

PerformanceTests:

Use regular string instead of template literal to make the script compatible with older versions of Safari.

• Speedometer/resources/benchmark-runner.js:

(BenchmarkRunner.prototype._runTest):

Websites/browserbench.org:

Fix the bug on browserbench.org.

• Speedometer/resources/benchmark-runner.js:

(BenchmarkRunner.prototype._runTest):

6:40 PM Changeset in webkit [220949] by weinig@apple.com

• 24 edits
  2 moves
  3 deletes in trunk/Source/WebCore

[WebCrypto] Get rid of CryptoKeyData class and all its subclasses
​https://bugs.webkit.org/show_bug.cgi?id=169806

Reviewed by Chris Dumez.

• Replaces the CryptoKeyData type hierarchy

CryptoKeyData

• CryptoKeyDataOctetSequence
• CryptoKeyDataRSAComponents

with the renamed CryptoKeyRSAComponents.

• Removes pure virtual exportData function on CryptoKey, and all the implementations except the one on CryptoKeyRSA, which now is non-virtual, and returns a CryptoKeyRSAComponents. Update the one external caller, SerializedScriptValue, to handle this.

• CMakeLists.txt:
• WebCore.xcodeproj/project.pbxproj:
• bindings/js/SerializedScriptValue.cpp:
• crypto/CryptoAlgorithm.h:
• crypto/CryptoKey.h:
• crypto/CryptoKeyData.h: Removed.
• crypto/algorithms/CryptoAlgorithmAES_CBC.cpp:
• crypto/algorithms/CryptoAlgorithmAES_KW.cpp:
• crypto/algorithms/CryptoAlgorithmHMAC.cpp:
• crypto/algorithms/CryptoAlgorithmRSAES_PKCS1_v1_5.cpp:
• crypto/algorithms/CryptoAlgorithmRSASSA_PKCS1_v1_5.cpp:
• crypto/algorithms/CryptoAlgorithmRSA_OAEP.cpp:
• crypto/gcrypt/CryptoKeyRSAGCrypt.cpp:

(WebCore::CryptoKeyRSA::create):
(WebCore::CryptoKeyRSA::exportData const):

• crypto/keys/CryptoKeyAES.cpp:

(WebCore::CryptoKeyAES::exportData const): Deleted.

• crypto/keys/CryptoKeyAES.h:
• crypto/keys/CryptoKeyDataOctetSequence.cpp: Removed.
• crypto/keys/CryptoKeyDataOctetSequence.h: Removed.
• crypto/keys/CryptoKeyDataRSAComponents.cpp: Removed.
• crypto/keys/CryptoKeyDataRSAComponents.h: Removed.
• crypto/keys/CryptoKeyEC.cpp:

(WebCore::CryptoKeyEC::exportData const): Deleted.

• crypto/keys/CryptoKeyEC.h:
• crypto/keys/CryptoKeyHMAC.cpp:

(WebCore::CryptoKeyHMAC::exportData const): Deleted.

• crypto/keys/CryptoKeyHMAC.h:
• crypto/keys/CryptoKeyRSA.cpp:

(WebCore::CryptoKeyRSA::importJwk):
(WebCore::CryptoKeyRSA::exportJwk const):

• crypto/keys/CryptoKeyRSA.h:
• crypto/keys/CryptoKeyRSAComponents.cpp: Copied from crypto/keys/CryptoKeyDataRSAComponents.cpp.

(WebCore::CryptoKeyRSAComponents::CryptoKeyRSAComponents):
(WebCore::CryptoKeyRSAComponents::~CryptoKeyRSAComponents):
(WebCore::CryptoKeyDataRSAComponents::CryptoKeyDataRSAComponents): Deleted.
(WebCore::CryptoKeyDataRSAComponents::~CryptoKeyDataRSAComponents): Deleted.

• crypto/keys/CryptoKeyRSAComponents.h: Copied from crypto/keys/CryptoKeyDataRSAComponents.h.

(WebCore::CryptoKeyRSAComponents::createPublic):
(WebCore::CryptoKeyRSAComponents::createPrivate):
(WebCore::CryptoKeyRSAComponents::createPrivateWithAdditionalData):

• crypto/keys/CryptoKeyRaw.cpp:

(WebCore::CryptoKeyRaw::exportData const): Deleted.

• crypto/keys/CryptoKeyRaw.h:
• crypto/mac/CryptoKeyRSAMac.cpp:

(WebCore::getPrivateKeyComponents):
(WebCore::CryptoKeyRSA::create):
(WebCore::CryptoKeyRSA::exportData const):

6:29 PM Changeset in webkit [220948] by commit-queue@webkit.org

• 11 edits in trunk

[Cache API] Add support for being loaded responses
​https://bugs.webkit.org/show_bug.cgi?id=175732

Patch by Youenn Fablet <​youenn@apple.com> on 2017-08-18
Reviewed by Chris Dumez.

LayoutTests/imported/w3c:

• web-platform-tests/service-workers/cache-storage/common.https-expected.txt:

Source/WebCore:

Covered by existing and rebased tests.

Introducing a callback-based method to consume the body when the load is finished.
Using that new method in Cache::put and calling batchPutOperation when the load is finished.

Fixing the case of a fetch response being cloned, in which case its body should be marked as ReadableStream.

• Modules/cache/Cache.cpp:

(WebCore::Cache::put): Changing order of checks to reduce test flakiness risks as there is not yet support for putting responses with ReadableStream.
(WebCore::toConnectionRecord):
(WebCore::Cache::batchPutOperation):

• Modules/cache/Cache.h:
• Modules/fetch/FetchBody.cpp:

(WebCore::FetchBody::readableStreamBody): Deleted.

• Modules/fetch/FetchBody.h:

(WebCore::FetchBody::loadingBody):
(WebCore::FetchBody::setAsReadableStream):

• Modules/fetch/FetchResponse.cpp:

(WebCore::FetchResponse::BodyLoader::didSucceed):
(WebCore::FetchResponse::BodyLoader::didFail):
(WebCore::FetchResponse::consumeBody):
(WebCore::FetchResponse::consumeBodyWhenLoaded):

• Modules/fetch/FetchResponse.h:

LayoutTests:

• TestExpectations: Removing some flaky test expectations.

5:30 PM Changeset in webkit [220947] by Ryan Haddad

• 7 edits
  1 delete in trunk

Unreviewed, rolling out r220938.

The API tests added with this change are failing.

Reverted changeset:

"Add WTFLogChannel level to allow runtime log filtering"
​https://bugs.webkit.org/show_bug.cgi?id=175731
​http://trac.webkit.org/changeset/220938

5:27 PM Changeset in webkit [220946] by Chris Dumez

• 24 edits
  2 adds in trunk

[Beacon] Improve error reporting
​https://bugs.webkit.org/show_bug.cgi?id=175723

Reviewed by Darin Adler.

Source/WebCore:

Have Ping loads such as beacons report errors via their completion handler.
The Beacon API is using this error to log a console message when beacon loads
fail, provided that the page is still alive.

Test: http/wpt/beacon/beacon-async-error-logging.html

• Modules/beacon/NavigatorBeacon.cpp:

(WebCore::NavigatorBeacon::NavigatorBeacon):
(WebCore::NavigatorBeacon::~NavigatorBeacon):
(WebCore::NavigatorBeacon::from):
(WebCore::NavigatorBeacon::supplementName):
(WebCore::NavigatorBeacon::notifyFinished):
(WebCore::NavigatorBeacon::logError):
(WebCore::NavigatorBeacon::sendBeacon):

• Modules/beacon/NavigatorBeacon.h:
• loader/LoaderStrategy.h:
• loader/cache/CachedResource.cpp:

(WebCore::CachedResource::load):

• loader/cache/CachedResourceLoader.cpp:

(WebCore::CachedResourceLoader::requestBeaconResource):

• loader/cache/CachedResourceLoader.h:
• platform/network/PingHandle.h:

Source/WebKit:

Have Ping loads such as beacons report errors via their completion handler.
The Beacon API is using this error to log a console message when beacon loads
fail, provided that the page is still alive.

• NetworkProcess/NetworkConnectionToWebProcess.cpp:

(WebKit::NetworkConnectionToWebProcess::loadPing):
(WebKit::NetworkConnectionToWebProcess::didFinishPingLoad):

• NetworkProcess/NetworkConnectionToWebProcess.h:
• NetworkProcess/PingLoad.cpp:

(WebKit::PingLoad::~PingLoad):
(WebKit::PingLoad::didFinish):
(WebKit::PingLoad::willPerformHTTPRedirection):
(WebKit::PingLoad::didReceiveChallenge):
(WebKit::PingLoad::didReceiveResponseNetworkSession):
(WebKit::PingLoad::didCompleteWithError):
(WebKit::PingLoad::wasBlocked):
(WebKit::PingLoad::cannotShowURL):
(WebKit::PingLoad::timeoutTimerFired):
(WebKit::PingLoad::currentRequest const):
(WebKit::PingLoad::makeCrossOriginAccessRequestWithPreflight):

• NetworkProcess/PingLoad.h:
• WebProcess/Network/NetworkProcessConnection.cpp:

(WebKit::NetworkProcessConnection::didFinishPingLoad):

• WebProcess/Network/NetworkProcessConnection.h:
• WebProcess/Network/NetworkProcessConnection.messages.in:
• WebProcess/Network/WebLoaderStrategy.cpp:

(WebKit::WebLoaderStrategy::networkProcessCrashed):
(WebKit::WebLoaderStrategy::startPingLoad):
(WebKit::WebLoaderStrategy::didFinishPingLoad):

• WebProcess/Network/WebLoaderStrategy.h:

Source/WebKitLegacy:

Have Ping loads such as beacons report errors via their completion handler.
The Beacon API is using this error to log a console message when beacon loads
fail, provided that the page is still alive.

• WebCoreSupport/WebResourceLoadScheduler.cpp:

(WebResourceLoadScheduler::startPingLoad):

• WebCoreSupport/WebResourceLoadScheduler.h:

LayoutTests:

Add layout test coverage.

• http/wpt/beacon/beacon-async-error-logging-expected.txt: Added.
• http/wpt/beacon/beacon-async-error-logging.html: Added.

5:27 PM Changeset in webkit [220945] by webkit@devinrousso.com

• 2 edits in trunk/Tools

Unreviewed, change my email.

• Scripts/webkitpy/common/config/contributors.json:

5:20 PM Changeset in webkit [220944] by Matt Lewis

• 2 edits in trunk/LayoutTests

Marked fast/scrolling/arrow-key-scroll-in-rtl-document.html as flaky.
​https://bugs.webkit.org/show_bug.cgi?id=173779

Unreviewed Test gardening.

• platform/mac-wk2/TestExpectations:

5:03 PM Changeset in webkit [220943] by Ryan Haddad

• 2 edits in trunk/JSTests

Skip flaky JSC test microbenchmarks/generator-with-several-types.js.
​https://bugs.webkit.org/show_bug.cgi?id=172543

Unreviewed test gardening.

• microbenchmarks/generator-with-several-types.js:

4:26 PM Changeset in webkit [220942] by Jonathan Bedard

• 3 edits in trunk/Tools

Fix leak-checking for iOS Simulators
​https://bugs.webkit.org/show_bug.cgi?id=175735

Reviewed by Darin Adler.

If the leak checking currently occurs in ServerProcess, we can’t check leaks on an iOS
Simulator (or device) because the process will have already been killed by the time we
check for leaks. Duplicate leak-checking code and share code waiting on a process to stop.

• Scripts/webkitpy/port/server_process.py:

(ServerProcess.stop): Move code waiting for the process to close to _wait_for_stop(...).
(ServerProcess._wait_for_stop): Share code shutting down a process between ServerProcess
and SimulatorProcess.

• Scripts/webkitpy/port/simulator_process.py:

(SimulatorProcess.stop): Before closing the process, check for leaks.

4:24 PM Changeset in webkit [220941] by weinig@apple.com

• 51 edits
  23 deletes in trunk

Remove the deprecated WebKitSubtleCrypto interface
​https://bugs.webkit.org/show_bug.cgi?id=164938
<rdar://problem/29894563>

Reviewed by Chris Dumez.

Source/WebCore:

Remove WebKitSubtleCrypto and all of its helper classes / functionality.

• CMakeLists.txt:
• DerivedSources.cpp:
• DerivedSources.make:
• WebCore.xcodeproj/project.pbxproj:
• bindings/js/JSCryptoAlgorithmDictionary.cpp: Removed.
• bindings/js/JSCryptoAlgorithmDictionary.h: Removed.
• bindings/js/JSCryptoKeySerializationJWK.cpp: Removed.
• bindings/js/JSCryptoKeySerializationJWK.h: Removed.
• bindings/js/JSCryptoOperationData.cpp: Removed.
• bindings/js/JSCryptoOperationData.h: Removed.
• bindings/js/JSWebKitSubtleCryptoCustom.cpp: Removed.
• crypto/CryptoAlgorithm.cpp:

(WebCore::CryptoAlgorithm::deriveKey): Deleted.
(WebCore::CryptoAlgorithm::encryptForWrapKey): Deleted.
(WebCore::CryptoAlgorithm::decryptForUnwrapKey): Deleted.

• crypto/CryptoAlgorithm.h:
• crypto/CryptoAlgorithmParametersDeprecated.h: Removed.
• crypto/CryptoKeySerialization.h: Removed.
• crypto/WebKitSubtleCrypto.cpp: Removed.
• crypto/WebKitSubtleCrypto.h: Removed.
• crypto/WebKitSubtleCrypto.idl: Removed.
• crypto/algorithms/CryptoAlgorithmAES_CBC.cpp:

(WebCore::CryptoAlgorithmAES_CBC::keyAlgorithmMatches const): Deleted.

• crypto/algorithms/CryptoAlgorithmAES_CBC.h:
• crypto/algorithms/CryptoAlgorithmAES_KW.cpp:

(WebCore::CryptoAlgorithmAES_KW::encryptForWrapKey): Deleted.
(WebCore::CryptoAlgorithmAES_KW::decryptForUnwrapKey): Deleted.

• crypto/algorithms/CryptoAlgorithmAES_KW.h:
• crypto/algorithms/CryptoAlgorithmHMAC.cpp:

(WebCore::CryptoAlgorithmHMAC::keyAlgorithmMatches const): Deleted.

• crypto/algorithms/CryptoAlgorithmHMAC.h:
• crypto/algorithms/CryptoAlgorithmRSAES_PKCS1_v1_5.cpp:
• crypto/algorithms/CryptoAlgorithmRSAES_PKCS1_v1_5.h:
• crypto/algorithms/CryptoAlgorithmRSASSA_PKCS1_v1_5.cpp:

(WebCore::CryptoAlgorithmRSASSA_PKCS1_v1_5::keyAlgorithmMatches const): Deleted.

• crypto/algorithms/CryptoAlgorithmRSASSA_PKCS1_v1_5.h:
• crypto/algorithms/CryptoAlgorithmRSA_OAEP.cpp:

(WebCore::CryptoAlgorithmRSA_OAEP::keyAlgorithmMatches const): Deleted.

• crypto/algorithms/CryptoAlgorithmRSA_OAEP.h:
• crypto/algorithms/CryptoAlgorithmSHA1.cpp:
• crypto/algorithms/CryptoAlgorithmSHA1.h:
• crypto/algorithms/CryptoAlgorithmSHA224.cpp:
• crypto/algorithms/CryptoAlgorithmSHA224.h:
• crypto/algorithms/CryptoAlgorithmSHA256.cpp:
• crypto/algorithms/CryptoAlgorithmSHA256.h:
• crypto/algorithms/CryptoAlgorithmSHA384.cpp:
• crypto/algorithms/CryptoAlgorithmSHA384.h:
• crypto/algorithms/CryptoAlgorithmSHA512.cpp:
• crypto/algorithms/CryptoAlgorithmSHA512.h:
• crypto/gcrypt/CryptoAlgorithmAES_CBCGCrypt.cpp:
• crypto/gcrypt/CryptoAlgorithmAES_KWGCrypt.cpp:

(WebCore::CryptoAlgorithmAES_KW::platformEncrypt): Deleted.
(WebCore::CryptoAlgorithmAES_KW::platformDecrypt): Deleted.

• crypto/gcrypt/CryptoAlgorithmHMACGCrypt.cpp:
• crypto/gcrypt/CryptoAlgorithmRSAES_PKCS1_v1_5GCrypt.cpp:
• crypto/gcrypt/CryptoAlgorithmRSASSA_PKCS1_v1_5GCrypt.cpp:
• crypto/gcrypt/CryptoAlgorithmRSA_OAEPGCrypt.cpp:
• crypto/keys/CryptoKeySerializationRaw.cpp: Removed.
• crypto/keys/CryptoKeySerializationRaw.h: Removed.
• crypto/mac/CryptoAlgorithmAES_CBCMac.cpp:
• crypto/mac/CryptoAlgorithmAES_KWMac.cpp:

(WebCore::CryptoAlgorithmAES_KW::platformEncrypt): Deleted.
(WebCore::CryptoAlgorithmAES_KW::platformDecrypt): Deleted.

• crypto/mac/CryptoAlgorithmHMACMac.cpp:
• crypto/mac/CryptoAlgorithmRSAES_PKCS1_v1_5Mac.cpp:
• crypto/mac/CryptoAlgorithmRSASSA_PKCS1_v1_5Mac.cpp:
• crypto/mac/CryptoAlgorithmRSA_OAEPMac.cpp:
• crypto/parameters/CryptoAlgorithmAesCbcParamsDeprecated.h: Removed.
• crypto/parameters/CryptoAlgorithmAesKeyGenParamsDeprecated.h: Removed.
• crypto/parameters/CryptoAlgorithmHmacKeyParamsDeprecated.h: Removed.
• crypto/parameters/CryptoAlgorithmHmacParamsDeprecated.h: Removed.
• crypto/parameters/CryptoAlgorithmRsaKeyGenParamsDeprecated.h: Removed.
• crypto/parameters/CryptoAlgorithmRsaKeyParamsWithHashDeprecated.h: Removed.
• crypto/parameters/CryptoAlgorithmRsaOaepParamsDeprecated.h: Removed.
• crypto/parameters/CryptoAlgorithmRsaSsaParamsDeprecated.h: Removed.
• features.json:
• page/Crypto.cpp:
• page/Crypto.h:
• page/Crypto.idl:

LayoutTests:

• crypto/webkitSubtle: Removed.
• crypto/webkitSubtle/aes-cbc-192-encrypt-decrypt-expected.txt: Removed.
• crypto/webkitSubtle/aes-cbc-192-encrypt-decrypt.html: Removed.
• crypto/webkitSubtle/aes-cbc-256-encrypt-decrypt-expected.txt: Removed.
• crypto/webkitSubtle/aes-cbc-256-encrypt-decrypt.html: Removed.
• crypto/webkitSubtle/aes-cbc-encrypt-decrypt-expected.txt: Removed.
• crypto/webkitSubtle/aes-cbc-encrypt-decrypt-with-padding-expected.txt: Removed.
• crypto/webkitSubtle/aes-cbc-encrypt-decrypt-with-padding.html: Removed.
• crypto/webkitSubtle/aes-cbc-encrypt-decrypt.html: Removed.
• crypto/webkitSubtle/aes-cbc-generate-key-expected.txt: Removed.
• crypto/webkitSubtle/aes-cbc-generate-key.html: Removed.
• crypto/webkitSubtle/aes-cbc-import-jwk-expected.txt: Removed.
• crypto/webkitSubtle/aes-cbc-import-jwk.html: Removed.
• crypto/webkitSubtle/aes-cbc-invalid-length-expected.txt: Removed.
• crypto/webkitSubtle/aes-cbc-invalid-length.html: Removed.
• crypto/webkitSubtle/aes-cbc-unwrap-failure-expected.txt: Removed.
• crypto/webkitSubtle/aes-cbc-unwrap-failure.html: Removed.
• crypto/webkitSubtle/aes-cbc-unwrap-rsa-expected.txt: Removed.
• crypto/webkitSubtle/aes-cbc-unwrap-rsa.html: Removed.
• crypto/webkitSubtle/aes-cbc-wrap-rsa-expected.txt: Removed.
• crypto/webkitSubtle/aes-cbc-wrap-rsa-non-extractable-expected.txt: Removed.
• crypto/webkitSubtle/aes-cbc-wrap-rsa-non-extractable.html: Removed.
• crypto/webkitSubtle/aes-cbc-wrap-rsa.html: Removed.
• crypto/webkitSubtle/aes-cbc-wrong-key-class-expected.txt: Removed.
• crypto/webkitSubtle/aes-cbc-wrong-key-class.html: Removed.
• crypto/webkitSubtle/aes-export-key-expected.txt: Removed.
• crypto/webkitSubtle/aes-export-key.html: Removed.
• crypto/webkitSubtle/aes-kw-key-manipulation-expected.txt: Removed.
• crypto/webkitSubtle/aes-kw-key-manipulation.html: Removed.
• crypto/webkitSubtle/aes-kw-wrap-unwrap-aes-expected.txt: Removed.
• crypto/webkitSubtle/aes-kw-wrap-unwrap-aes.html: Removed.
• crypto/webkitSubtle/aes-postMessage-expected.txt: Removed.
• crypto/webkitSubtle/aes-postMessage.html: Removed.
• crypto/webkitSubtle/argument-conversion-expected.txt: Removed.
• crypto/webkitSubtle/argument-conversion.html: Removed.
• crypto/webkitSubtle/array-buffer-view-offset-expected.txt: Removed.
• crypto/webkitSubtle/array-buffer-view-offset.html: Removed.
• crypto/webkitSubtle/disallowed-in-worker-expected.txt: Removed.
• crypto/webkitSubtle/disallowed-in-worker.html: Removed.
• crypto/webkitSubtle/gc-2-expected.txt: Removed.
• crypto/webkitSubtle/gc-2.html: Removed.
• crypto/webkitSubtle/gc-3-expected.txt: Removed.
• crypto/webkitSubtle/gc-3.html: Removed.
• crypto/webkitSubtle/gc-expected.txt: Removed.
• crypto/webkitSubtle/gc.html: Removed.
• crypto/webkitSubtle/hmac-check-algorithm-expected.txt: Removed.
• crypto/webkitSubtle/hmac-check-algorithm.html: Removed.
• crypto/webkitSubtle/hmac-export-key-expected.txt: Removed.
• crypto/webkitSubtle/hmac-export-key.html: Removed.
• crypto/webkitSubtle/hmac-generate-key-expected.txt: Removed.
• crypto/webkitSubtle/hmac-generate-key.html: Removed.
• crypto/webkitSubtle/hmac-import-jwk-expected.txt: Removed.
• crypto/webkitSubtle/hmac-import-jwk.html: Removed.
• crypto/webkitSubtle/hmac-postMessage-expected.txt: Removed.
• crypto/webkitSubtle/hmac-postMessage.html: Removed.
• crypto/webkitSubtle/hmac-sign-verify-empty-key-expected.txt: Removed.
• crypto/webkitSubtle/hmac-sign-verify-empty-key.html: Removed.
• crypto/webkitSubtle/hmac-sign-verify-expected.txt: Removed.
• crypto/webkitSubtle/hmac-sign-verify.html: Removed.
• crypto/webkitSubtle/import-export-raw-key-leak-expected.txt: Removed.
• crypto/webkitSubtle/import-export-raw-key-leak.html: Removed.
• crypto/webkitSubtle/import-jwk-expected.txt: Removed.
• crypto/webkitSubtle/import-jwk.html: Removed.
• crypto/webkitSubtle/jwk-export-use-values-expected.txt: Removed.
• crypto/webkitSubtle/jwk-export-use-values.html: Removed.
• crypto/webkitSubtle/jwk-import-use-values-expected.txt: Removed.
• crypto/webkitSubtle/jwk-import-use-values.html: Removed.
• crypto/webkitSubtle/resources: Removed.
• crypto/webkitSubtle/resources/disallowed-in-worker.js: Removed.
• crypto/webkitSubtle/resources/rsa-indexeddb-non-exportable.js: Removed.
• crypto/webkitSubtle/resources/rsa-indexeddb.js: Removed.
• crypto/webkitSubtle/rsa-export-generated-keys-expected.txt: Removed.
• crypto/webkitSubtle/rsa-export-generated-keys.html: Removed.
• crypto/webkitSubtle/rsa-export-key-expected.txt: Removed.
• crypto/webkitSubtle/rsa-export-key.html: Removed.
• crypto/webkitSubtle/rsa-export-private-key-expected.txt: Removed.
• crypto/webkitSubtle/rsa-export-private-key.html: Removed.
• crypto/webkitSubtle/rsa-indexeddb-expected.txt: Removed.
• crypto/webkitSubtle/rsa-indexeddb-non-exportable-expected.txt: Removed.
• crypto/webkitSubtle/rsa-indexeddb-non-exportable-private-expected.txt: Removed.
• crypto/webkitSubtle/rsa-indexeddb-non-exportable-private.html: Removed.
• crypto/webkitSubtle/rsa-indexeddb-non-exportable.html: Removed.
• crypto/webkitSubtle/rsa-indexeddb-private-expected.txt: Removed.
• crypto/webkitSubtle/rsa-indexeddb-private.html: Removed.
• crypto/webkitSubtle/rsa-indexeddb.html: Removed.
• crypto/webkitSubtle/rsa-oaep-generate-non-extractable-key-expected.txt: Removed.
• crypto/webkitSubtle/rsa-oaep-generate-non-extractable-key.html: Removed.
• crypto/webkitSubtle/rsa-oaep-key-manipulation-expected.txt: Removed.
• crypto/webkitSubtle/rsa-oaep-key-manipulation.html: Removed.
• crypto/webkitSubtle/rsa-oaep-plaintext-length-expected.txt: Removed.
• crypto/webkitSubtle/rsa-oaep-plaintext-length.html: Removed.
• crypto/webkitSubtle/rsa-oaep-wrap-unwrap-aes-expected.txt: Removed.
• crypto/webkitSubtle/rsa-oaep-wrap-unwrap-aes.html: Removed.
• crypto/webkitSubtle/rsa-postMessage-expected.txt: Removed.
• crypto/webkitSubtle/rsa-postMessage.html: Removed.
• crypto/webkitSubtle/rsaes-pkcs1-v1_5-decrypt-expected.txt: Removed.
• crypto/webkitSubtle/rsaes-pkcs1-v1_5-decrypt.html: Removed.
• crypto/webkitSubtle/rsaes-pkcs1-v1_5-wrap-unwrap-aes-expected.txt: Removed.
• crypto/webkitSubtle/rsaes-pkcs1-v1_5-wrap-unwrap-aes.html: Removed.
• crypto/webkitSubtle/rsassa-pkcs1-v1_5-generate-key-expected.txt: Removed.
• crypto/webkitSubtle/rsassa-pkcs1-v1_5-generate-key-with-leading-zeroes-in-exponent-expected.txt: Removed.
• crypto/webkitSubtle/rsassa-pkcs1-v1_5-generate-key-with-leading-zeroes-in-exponent.html: Removed.
• crypto/webkitSubtle/rsassa-pkcs1-v1_5-generate-key.html: Removed.
• crypto/webkitSubtle/rsassa-pkcs1-v1_5-import-jwk-expected.txt: Removed.
• crypto/webkitSubtle/rsassa-pkcs1-v1_5-import-jwk-small-key-expected.txt: Removed.
• crypto/webkitSubtle/rsassa-pkcs1-v1_5-import-jwk-small-key.html: Removed.
• crypto/webkitSubtle/rsassa-pkcs1-v1_5-import-jwk.html: Removed.
• crypto/webkitSubtle/rsassa-pkcs1-v1_5-sign-verify-expected.txt: Removed.
• crypto/webkitSubtle/rsassa-pkcs1-v1_5-sign-verify.html: Removed.
• crypto/webkitSubtle/sha-1-expected.txt: Removed.
• crypto/webkitSubtle/sha-1.html: Removed.
• crypto/webkitSubtle/sha-224-expected.txt: Removed.
• crypto/webkitSubtle/sha-224.html: Removed.
• crypto/webkitSubtle/sha-256-expected.txt: Removed.
• crypto/webkitSubtle/sha-256.html: Removed.
• crypto/webkitSubtle/sha-384-expected.txt: Removed.
• crypto/webkitSubtle/sha-384.html: Removed.
• crypto/webkitSubtle/sha-512-expected.txt: Removed.
• crypto/webkitSubtle/sha-512.html: Removed.
• crypto/webkitSubtle/unimplemented-unwrap-crash-expected.txt: Removed.
• crypto/webkitSubtle/unimplemented-unwrap-crash.html: Removed.
• crypto/webkitSubtle/unwrapKey-check-usage-expected.txt: Removed.
• crypto/webkitSubtle/unwrapKey-check-usage.html: Removed.
• crypto/webkitSubtle/wrapKey-check-usage-expected.txt: Removed.
• crypto/webkitSubtle/wrapKey-check-usage.html: Removed.

Remove webkitSubtleCrypto tests.

• fast/dom/Window/property-access-on-cached-window-after-frame-removed-expected.txt:

Remove webkitSubtleCrypto deprecation warning that no longer happens.

• platform/ios-wk1/TestExpectations:
• platform/win/TestExpectations:
• platform/wpe/TestExpectations:

Remove webkitSubtle tests from expectations files.

4:15 PM Changeset in webkit [220940] by timothy_horton@apple.com

• 2 edits in trunk/Source/WebCore

Remove classic mode screen scale clamping
​https://bugs.webkit.org/show_bug.cgi?id=175739
<rdar://problem/33894531>

Reviewed by Andy Estes.

• platform/ios/PlatformScreenIOS.mm:

(WebCore::screenScaleFactor):
This code is no longer needed.

4:02 PM Changeset in webkit [220939] by commit-queue@webkit.org

• 10 edits
  1 copy
  1 add in trunk/Source/WebCore

[Curl] Improve multi-threaded networking
​https://bugs.webkit.org/show_bug.cgi?id=175713

Patch by Daewoong Jang <​daewoong.jang@navercorp.com> on 2017-08-18
Reviewed by Alex Christensen.

• platform/Curl.cmake:
• platform/network/ResourceHandleInternal.h:

(WebCore::ResourceHandleInternal::ResourceHandleInternal):
(WebCore::ResourceHandleInternal::m_failureTimer): Deleted.

• platform/network/curl/CurlCacheManager.cpp:

(WebCore::CurlCacheManager::didReceiveResponse):

• platform/network/curl/CurlDownload.cpp:

(WebCore::CurlDownload::init):
(WebCore::CurlDownload::start):
(WebCore::CurlDownload::cancel):
(WebCore::CurlDownload::retain):
(WebCore::CurlDownload::release):
(WebCore::CurlDownload::setupRequest):
(WebCore::CurlDownload::notifyFinish):
(WebCore::CurlDownload::notifyFail):

• platform/network/curl/CurlDownload.h:
• platform/network/curl/CurlJobManager.cpp:

(WebCore::CurlJobList::isEmpty const):
(WebCore::CurlJobList::startJobs):
(WebCore::CurlJobList::finishJobs):
(WebCore::CurlJobList::notifyResult):
(WebCore::CurlJobManager::add):
(WebCore::CurlJobManager::cancel):
(WebCore::CurlJobManager::callOnJobThread):
(WebCore::CurlJobManager::startThreadIfNeeded):
(WebCore::CurlJobManager::updateJobList):
(WebCore::CurlJobManager::workerThread):
(WebCore::CurlJobList::append): Deleted.
(WebCore::CurlJobList::cancel): Deleted.
(WebCore::CurlJobList::complete): Deleted.
(WebCore::CurlJobList::withJob): Deleted.
(WebCore::CurlJobList::withCurlHandle): Deleted.
(WebCore::CurlJob::invoke): Deleted.
(WebCore::CurlJobManager::updateJobs): Deleted.

• platform/network/curl/CurlJobManager.h:

(WebCore::CurlJob::CurlJob): Deleted.
(WebCore::CurlJob::~CurlJob): Deleted.
(WebCore::CurlJob::operator=): Deleted.
(WebCore::CurlJob::curlHandle const): Deleted.
(WebCore::CurlJob::ticket const): Deleted.
(WebCore::CurlJob::finished): Deleted.
(WebCore::CurlJob::error): Deleted.
(WebCore::CurlJob::cancel): Deleted.
(WebCore::CurlJobManager::isActiveJob const): Deleted.

• platform/network/curl/MultipartHandle.cpp:

(WebCore::MultipartHandle::didReceiveData):

• platform/network/curl/ResourceHandleCurl.cpp:

(WebCore::ResourceHandleInternal::~ResourceHandleInternal):
(WebCore::ResourceHandle::start):
(WebCore::ResourceHandle::cancel):
(WebCore::ResourceHandle::platformSetDefersLoading):
(WebCore::ResourceHandle::didReceiveAuthenticationChallenge):
(WebCore::ResourceHandle::receivedCredential):
(WebCore::ResourceHandle::receivedRequestToContinueWithoutCredential):
(WebCore::ResourceHandle::platformLoadResourceSynchronously):
(WebCore::ResourceHandleInternal::initialize): Deleted.
(WebCore::ResourceHandleInternal::applyAuthentication): Deleted.
(WebCore::getFormElementsCount): Deleted.
(WebCore::ResourceHandleInternal::setupPUT): Deleted.
(WebCore::ResourceHandleInternal::setupPOST): Deleted.
(WebCore::ResourceHandleInternal::setupFormData): Deleted.
(WebCore::ResourceHandleInternal::didFinish): Deleted.
(WebCore::ResourceHandleInternal::didFail): Deleted.
(WebCore::ResourceHandleInternal::calculateWebTimingInformations): Deleted.
(WebCore::ResourceHandleInternal::handleLocalReceiveResponse): Deleted.
(WebCore::isHttpInfo): Deleted.
(WebCore::isHttpRedirect): Deleted.
(WebCore::isHttpAuthentication): Deleted.
(WebCore::isHttpNotModified): Deleted.
(WebCore::isAppendableHeader): Deleted.
(WebCore::removeLeadingAndTrailingQuotes): Deleted.
(WebCore::getProtectionSpace): Deleted.
(WebCore::ResourceHandleInternal::willPrepareSendData): Deleted.
(WebCore::ResourceHandleInternal::didReceiveHeaderLine): Deleted.
(WebCore::ResourceHandleInternal::didReceiveAllHeaders): Deleted.
(WebCore::ResourceHandleInternal::didReceiveContentData): Deleted.
(WebCore::ResourceHandleInternal::readCallback): Deleted.
(WebCore::ResourceHandleInternal::headerCallback): Deleted.
(WebCore::ResourceHandleInternal::writeCallback): Deleted.
(WebCore::ResourceHandleInternal::dispatchSynchronousJob): Deleted.
(WebCore::ResourceHandleInternal::handleDataURL): Deleted.

• platform/network/curl/ResourceHandleCurlDelegate.cpp: Added.

(WebCore::ResourceHandleCurlDelegate::ResourceHandleCurlDelegate):
(WebCore::ResourceHandleCurlDelegate::~ResourceHandleCurlDelegate):
(WebCore::ResourceHandleCurlDelegate::hasHandle const):
(WebCore::ResourceHandleCurlDelegate::releaseHandle):
(WebCore::ResourceHandleCurlDelegate::start):
(WebCore::ResourceHandleCurlDelegate::cancel):
(WebCore::ResourceHandleCurlDelegate::setDefersLoading):
(WebCore::ResourceHandleCurlDelegate::setAuthentication):
(WebCore::ResourceHandleCurlDelegate::dispatchSynchronousJob):
(WebCore::ResourceHandleCurlDelegate::retain):
(WebCore::ResourceHandleCurlDelegate::release):
(WebCore::ResourceHandleCurlDelegate::setupRequest):
(WebCore::ResourceHandleCurlDelegate::notifyFinish):
(WebCore::ResourceHandleCurlDelegate::notifyFail):
(WebCore::ResourceHandleCurlDelegate::response):
(WebCore::ResourceHandleCurlDelegate::setupAuthentication):
(WebCore::removeLeadingAndTrailingQuotes):
(WebCore::ResourceHandleCurlDelegate::getProtectionSpace):
(WebCore::isHttpInfo):
(WebCore::isHttpRedirect):
(WebCore::isHttpAuthentication):
(WebCore::isHttpNotModified):
(WebCore::isAppendableHeader):
(WebCore::ResourceHandleCurlDelegate::didReceiveHeaderLine):
(WebCore::ResourceHandleCurlDelegate::didReceiveAllHeaders):
(WebCore::ResourceHandleCurlDelegate::didReceiveContentData):
(WebCore::ResourceHandleCurlDelegate::handleLocalReceiveResponse):
(WebCore::ResourceHandleCurlDelegate::prepareSendData):
(WebCore::ResourceHandleCurlDelegate::didFinish):
(WebCore::ResourceHandleCurlDelegate::didFail):
(WebCore::ResourceHandleCurlDelegate::handleDataURL):
(WebCore::ResourceHandleCurlDelegate::setupPOST):
(WebCore::ResourceHandleCurlDelegate::setupPUT):
(WebCore::ResourceHandleCurlDelegate::getFormElementsCount):
(WebCore::ResourceHandleCurlDelegate::setupFormData):
(WebCore::ResourceHandleCurlDelegate::applyAuthentication):
(WebCore::ResourceHandleCurlDelegate::setWebTimings):
(WebCore::ResourceHandleCurlDelegate::didReceiveHeader):
(WebCore::ResourceHandleCurlDelegate::didReceiveData):
(WebCore::ResourceHandleCurlDelegate::willSendData):
(WebCore::ResourceHandleCurlDelegate::didReceiveHeaderCallback):
(WebCore::ResourceHandleCurlDelegate::didReceiveDataCallback):
(WebCore::ResourceHandleCurlDelegate::willSendDataCallback):

• platform/network/curl/ResourceHandleCurlDelegate.h: Added.

3:46 PM Changeset in webkit [220938] by eric.carlson@apple.com

• 7 edits
  1 add in trunk

Add WTFLogChannel level to allow runtime log filtering
​https://bugs.webkit.org/show_bug.cgi?id=175731
<rdar://problem/33967234>

Reviewed by Jer Noble.
Source/WTF:

Add WTFLog*, LOG, and RELEASE_LOG variants that take a "log level" parameter so code
can include logging statements that are only conditionally emitted.

• wtf/Assertions.cpp:
• wtf/Assertions.h:
• wtf/MemoryPressureHandler.cpp:
• wtf/RefCountedLeakCounter.cpp:

Tools:

• TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
• TestWebKitAPI/Tests/WebCore/Logging.cpp: Added.

(TestWebKitAPI::LoggingTest::output):
(TestWebKitAPI::TEST_F):

3:34 PM Changeset in webkit [220937] by rniwa@webkit.org

• 2 edits in trunk/Source/WebCore

iOS 10 debug build fix.

• dom/DataTransfer.cpp:

(WebCore::DataTransfer::DataTransfer):

3:15 PM Changeset in webkit [220936] by Jonathan Bedard

• 2 edits in trunk/LayoutTests

Marking canvas/webgl tests as failing
​https://bugs.webkit.org/show_bug.cgi?id=175736

Unreviewed test gardening.

• platform/ios-device/TestExpectations:

2:53 PM Changeset in webkit [220935] by rniwa@webkit.org

• 8 edits
  1 delete in trunk/Source/WebCore

Rename DataTransferAccessPolicy to match spec and refactor related node
​https://bugs.webkit.org/show_bug.cgi?id=175704

Reviewed by Wenson Hsieh.

Renamed DataTransferAccessPolicy to DataTransfer::StoreMode to match the drag data store mode concept
in the HTML5 specification:
​https://html.spec.whatwg.org/multipage/dnd.html#drag-data-store-mode

DataTransfer in addition to those states can be disassociated from the drag data store when it becomes
no longer valid. We also support a special mode which allows only updating the drag image.
These two states, Invalid and DragImageWritable, are added in addition to the three states in the spec.

Also split DragAndDrop type of DataTransfer into DragAndDropData and DragAndDropFiles, and refactored
the related code.

No new tests since there should be no behavioral change.

• WebCore.xcodeproj/project.pbxproj:
• dom/DataTransfer.cpp:

(WebCore::DataTransfer::DataTransfer): No longer takes forFileDrag boolean since it's folded into type.
(WebCore::DataTransfer::createForCopyAndPaste):
(WebCore::DataTransfer::~DataTransfer):
(WebCore::DataTransfer::setAccessPolicy): Deleted.
(WebCore::DataTransfer::canReadTypes const):
(WebCore::DataTransfer::canReadData const):
(WebCore::DataTransfer::canWriteData const):
(WebCore::DataTransfer::createForInputEvent):
(WebCore::DataTransfer::createForDrag):
(WebCore::DataTransfer::createForDrop):
(WebCore::DataTransfer::canSetDragImage const):

• dom/DataTransfer.h:

(WebCore::DataTransfer::makeInvalidForSecurity): Added.
(WebCore::DataTransfer::makeDragImageWritable): Added.

• dom/DataTransferAccessPolicy.h: Removed.
• editing/Editor.cpp:

(WebCore::dispatchClipboardEvent): Moved and renamed from dispatchCPPEvent. Now computes the store mode
inside the function to match the spec: ​https://w3c.github.io/clipboard-apis/#fire-a-clipboard-event
(WebCore::Editor::canDHTMLCut):
(WebCore::Editor::canDHTMLCopy):
(WebCore::Editor::canDHTMLPaste):
(WebCore::Editor::tryDHTMLCopy):
(WebCore::Editor::tryDHTMLCut):
(WebCore::Editor::tryDHTMLPaste):
(WebCore::Editor::dispatchCPPEvent): Deleted.

• editing/Editor.h:
• page/DragController.cpp:

(WebCore::createDataTransferToUpdateDrag): Extracted to share code.
(WebCore::DragController::dragExited):
(WebCore::DragController::performDragOperation):
(WebCore::DragController::tryDHTMLDrag):

• page/EventHandler.cpp:

(WebCore::EventHandler::invalidateDataTransfer):
(WebCore::EventHandler::handleDrag):

2:40 PM Changeset in webkit [220934] by commit-queue@webkit.org

• 8 edits in trunk/Source/WebCore

Followup (r220289): RenderImageResourceStyleImage code clean up
​https://bugs.webkit.org/show_bug.cgi?id=175444

Patch by Said Abou-Hallawa <​sabouhallawa@apple.com> on 2017-08-18
Reviewed by Darin Adler.

RenderImageResourceStyleImage may be created with a StyleImage of type
StyleGeneratedImage. It may also be associated with a CachedImage which
is loaded through a source URL. In this case, adding and removing m_renderer
as a client of the CachedImage will be done through
RenderImageResource::setCachedImage().

RenderImageResource::setCachedImage() is already called from
ImageLoader::updateRenderer() when the CachedImage finishes loading. This
call adds m_renderer to the clients of the CachedImage.
RenderImageResource::setCachedImage() will also be called from
RenderImageResourceStyleImage::shutdown() via RenderImageResource::shutdown()
to remove m_renderer from the clients of CachedImage by passing a null pointer.

• rendering/RenderImage.cpp:

(WebCore::RenderImage::styleWillChange):

• rendering/RenderImageResource.cpp:

(WebCore::RenderImageResource::initialize):
(WebCore::RenderImageResource::shutdown):
(WebCore::RenderImageResource::setCachedImage):
(WebCore::RenderImageResource::resetAnimation):
(WebCore::RenderImageResource::image const):
(WebCore::RenderImageResource::setContainerSizeForRenderer):
(WebCore::RenderImageResource::imageSize const):
(WebCore::RenderImageResource::~RenderImageResource): Deleted.
(WebCore::RenderImageResource::errorOccurred const): Deleted.
(WebCore::RenderImageResource::imageHasRelativeWidth const): Deleted.
(WebCore::RenderImageResource::imageHasRelativeHeight const): Deleted.
(WebCore::RenderImageResource::intrinsicSize const): Deleted.
(WebCore::RenderImageResource::getImageSize const): Deleted.

• rendering/RenderImageResource.h:

(WebCore::RenderImageResource::initialize):
(WebCore::RenderImageResource::renderer const):
(WebCore::RenderImageResource::errorOccurred const):
(WebCore::RenderImageResource::imageHasRelativeWidth const):
(WebCore::RenderImageResource::imageHasRelativeHeight const):
(WebCore::RenderImageResource::imageSize const):
(WebCore::RenderImageResource::intrinsicSize const):
(WebCore::RenderImageResource::imagePtr const):

• rendering/RenderImageResourceStyleImage.cpp:

(WebCore::RenderImageResourceStyleImage::initialize):
(WebCore::RenderImageResourceStyleImage::shutdown):
(WebCore::RenderImageResourceStyleImage::image const):
(WebCore::RenderImageResourceStyleImage::setContainerSizeForRenderer):
(WebCore::RenderImageResourceStyleImage::~RenderImageResourceStyleImage): Deleted.

• rendering/RenderImageResourceStyleImage.h:
• rendering/RenderSnapshottedPlugIn.cpp:

(WebCore::RenderSnapshottedPlugIn::RenderSnapshottedPlugIn):

• rendering/svg/RenderSVGImage.cpp:

(WebCore::RenderSVGImage::RenderSVGImage):

2:30 PM Changeset in webkit [220933] by jiewen_tan@apple.com

• 8 edits
  2 adds in trunk

[WebCrypto][Mac] Replace CCECCryptorGetKeyComponents with CCECCryptorExportKey for exporting ECC JWKs
​https://bugs.webkit.org/show_bug.cgi?id=175657
<rdar://problem/33797150>

Reviewed by Brent Fulgham.

Source/WebCore:

CCECCryptorGetKeyComponents returns components in unpadded formats. In some minor cases, the ECC components
do need padding. Therefore, we occasionally see some corrupted outputs in JWKs. To overcome that, this patch
replaces CCECCryptorGetKeyComponents with CCECCryptorExportKey which does padding all the time.

In the meantime, this patch also makes export* methods return OperationError if any error occur in the
underlying operations though very unlikely.

Test: crypto/subtle/ecdsa-generate-export-import-jwk-sign-verify.html

• crypto/algorithms/CryptoAlgorithmECDH.cpp:

(WebCore::CryptoAlgorithmECDH::exportKey):

• crypto/algorithms/CryptoAlgorithmECDSA.cpp:

(WebCore::CryptoAlgorithmECDSA::exportKey):

• crypto/gcrypt/CryptoKeyECGCrypt.cpp:

(WebCore::CryptoKeyEC::platformAddFieldElements const):

• crypto/keys/CryptoKeyEC.cpp:

(WebCore::CryptoKeyEC::exportRaw const):
(WebCore::CryptoKeyEC::exportJwk const):
(WebCore::CryptoKeyEC::exportSpki const):
(WebCore::CryptoKeyEC::exportPkcs8 const):

• crypto/keys/CryptoKeyEC.h:
• crypto/mac/CryptoKeyECMac.cpp:

(WebCore::CryptoKeyEC::platformExportRaw const):
(WebCore::CryptoKeyEC::platformAddFieldElements const):
(WebCore::CryptoKeyEC::platformExportSpki const):
(WebCore::CryptoKeyEC::platformExportPkcs8 const):

LayoutTests:

• crypto/subtle/ecdsa-generate-export-import-jwk-sign-verify-expected.txt: Added.
• crypto/subtle/ecdsa-generate-export-import-jwk-sign-verify.html: Added.

2:07 PM Changeset in webkit [220932] by Matt Lewis

• 2 edits in trunk/LayoutTests

Marked imported/w3c/web-platform-tests/IndexedDB/open-request-queue.html as flaky timeout.
​https://bugs.webkit.org/show_bug.cgi?id=172044

Unreviewed test gardening.

• platform/mac-wk2/TestExpectations:

1:53 PM Changeset in webkit [220931] by Chris Dumez

• 3 edits in trunk/Source/WebKit

REGRESSION (r220601): Crash when closing google doc after switching the order of tabs in safari
​https://bugs.webkit.org/show_bug.cgi?id=175721
<rdar://problem/33928369>

Reviewed by Geoffrey Garen.

Make sure WebProcess::markAllLayersVolatile() does not call WTFMove() multiple times
on the same completion handler. Use a RefCounter to hold on to the completion handler
and make sure the handler gets called when the RefCounter's value becomes 0.

• WebProcess/WebProcess.cpp:

(WebKit::WebProcess::cancelPrepareToSuspend):
(WebKit::WebProcess::markAllLayersVolatile):
(WebKit::WebProcess::cancelMarkAllLayersVolatile):

• WebProcess/WebProcess.h:

1:50 PM Changeset in webkit [220930] by pvollan@apple.com

• 4 edits in trunk/Source

[Win] accessibility/heading-crash-after-hidden.html is a flaky crash.
​https://bugs.webkit.org/show_bug.cgi?id=173536

Reviewed by Brent Fulgham.

If the tree state is dirty, accessible objects are deleted while iterating over children
under AccessibilityNodeObject::textUnderElement when the style is updated. Make sure the
style is updated before this method is called.

Source/WebCore:

No new tests, covered by existing tests.

• accessibility/win/AccessibilityObjectWrapperWin.cpp:

(WebCore::AccessibilityObjectWrapper::accessibilityAttributeValue):

Source/WebKitLegacy/win:

• AccessibleBase.cpp:

(AccessibleBase::getAccessibilityObjectForChild):

1:16 PM Changeset in webkit [220929] by Matt Lewis

• 2 edits in trunk/LayoutTests

Marked js/slow-stress/Int32Array-alloc-huge.html as flaky on mac.
​https://bugs.webkit.org/show_bug.cgi?id=173010

Unreviewed test gardening.

• platform/mac/TestExpectations:

12:32 PM Changeset in webkit [220928] by commit-queue@webkit.org

• 20 edits in trunk

[Cache API] Add response body storage
​https://bugs.webkit.org/show_bug.cgi?id=175658

Patch by Youenn Fablet <​youenn@apple.com> on 2017-08-18
Reviewed by Alex Christensen.

LayoutTests/imported/w3c:

• web-platform-tests/service-workers/cache-storage/window/cache-match.https-expected.txt:
• web-platform-tests/service-workers/cache-storage/window/cache-put.https-expected.txt:
• web-platform-tests/service-workers/cache-storage/worker/cache-match.https-expected.txt:
• web-platform-tests/service-workers/cache-storage/worker/cache-put.https-expected.txt:

Source/WebCore:

Covered by rebased tests.
Tests are still flaky until waiting for end of fetch load is implemented.

Adding a response body within CacheStorageConnection::Record.
Adding ability to pass this body from/to the main thread.

Adding response body consumption into a CacheStorageConnection::Record.
Adding response body setting from a CacheStorageConnection::Record.

• Modules/beacon/NavigatorBeacon.cpp:

(WebCore::NavigatorBeacon::sendBeacon):

• Modules/cache/Cache.cpp:

(WebCore::Cache::put):
(WebCore::toConnectionRecord):
(WebCore::Cache::updateRecords):

• Modules/cache/CacheStorageConnection.cpp:

(WebCore::CacheStorageConnection::copyResponseBody):
(WebCore::CacheStorageConnection::isolatedResponseBody):
(WebCore::CacheStorageConnection::Record::copy const):

• Modules/cache/CacheStorageConnection.h:
• Modules/cache/WorkerCacheStorageConnection.cpp:

(WebCore::toCrossThreadRecordData):
(WebCore::fromCrossThreadRecordData):

• Modules/fetch/FetchBody.cpp:

(WebCore::FetchBody::bodyAsFormData const):
(WebCore::FetchBody::take):
(WebCore::FetchBody::bodyForInternalRequest const): Deleted.

• Modules/fetch/FetchBody.h:

(WebCore::FetchBody::setAsFormData):

• Modules/fetch/FetchBodyConsumer.h:

(WebCore::FetchBodyConsumer::setData):

• Modules/fetch/FetchRequest.cpp:

(WebCore::FetchRequest::resourceRequest const):

• Modules/fetch/FetchResponse.cpp:

(WebCore::FetchResponse::consumeBody):
(WebCore::FetchResponse::setBodyData):

• Modules/fetch/FetchResponse.h:

Source/WebKit:

Added IPC serialization of Record response body.
Updated CacheStorageEngine implementation as Record has no longer a copy constructor.

• NetworkProcess/cache/CacheStorageEngine.cpp:

(WebKit::CacheStorageEngine::retrieveRecords):
(WebKit::CacheStorageEngine::deleteMatchingRecords):

• Shared/WebCoreArgumentCoders.cpp:

(IPC::encodeSharedBuffer):
(IPC::decodeSharedBuffer):
(IPC::ArgumentCoder<CacheStorageConnection::Record>::encode):
(IPC::ArgumentCoder<CacheStorageConnection::Record>::decode):

12:32 PM Changeset in webkit [220927] by commit-queue@webkit.org

• 5 edits in trunk/Source/WebCore

[Fetch API] Add support for a callback-based fetch
​https://bugs.webkit.org/show_bug.cgi?id=175710

Patch by Youenn Fablet <​youenn@apple.com> on 2017-08-18
Reviewed by Alex Christensen.

No change of behavior.

Moving from a DOMPromise to a Callback taking an ExceptionOr<FetchResponse&>.
Updating window and worker call sites.

• Modules/fetch/DOMWindowFetch.cpp:

(WebCore::DOMWindowFetch::fetch):

• Modules/fetch/FetchResponse.cpp:

(WebCore::FetchResponse::fetch):
(WebCore::FetchResponse::BodyLoader::didFail):
(WebCore::FetchResponse::BodyLoader::BodyLoader):
(WebCore::FetchResponse::BodyLoader::didReceiveResponse):
(WebCore::FetchResponse::BodyLoader::stop):

• Modules/fetch/FetchResponse.h:
• Modules/fetch/WorkerGlobalScopeFetch.cpp:

(WebCore::WorkerGlobalScopeFetch::fetch):

12:20 PM Changeset in webkit [220926] by pvollan@apple.com

• 7 edits in trunk/Source

Implement 32-bit MacroAssembler::probe support for Windows.
​https://bugs.webkit.org/show_bug.cgi?id=175449

Reviewed by Mark Lam.

Source/JavaScriptCore:

This is needed to enable the DFG.

• assembler/MacroAssemblerX86Common.cpp:
• assembler/testmasm.cpp:

(JSC::run):
(dllLauncherEntryPoint):

• shell/CMakeLists.txt:
• shell/PlatformWin.cmake:

Source/WTF:

Enable the DFG on Win32.

• wtf/Platform.h:

11:56 AM Changeset in webkit [220925] by ap@apple.com

• 2 edits in trunk/Tools

Add Dean Johnson to contributors.json for Bugzilla autocomplete.

• Scripts/webkitpy/common/config/contributors.json:

11:52 AM Changeset in webkit [220924] by beidson@apple.com

• 66 edits
  7 copies
  3 adds in trunk

Bounce ServiceWorker jobs to the Storage Process.
​https://bugs.webkit.org/show_bug.cgi?id=175650

Reviewed by Andy Estes.

LayoutTests/imported/w3c:

Now that the serviceWorker.register() call is asynchronous, update a whole bunch of test results.

• web-platform-tests/FileAPI/historical.https-expected.txt:
• web-platform-tests/background-fetch/interfaces-worker.https-expected.txt:
• web-platform-tests/fetch/api/policies/referrer-no-referrer-service-worker.https-expected.txt:
• web-platform-tests/fetch/api/policies/referrer-origin-service-worker.https-expected.txt:
• web-platform-tests/fetch/api/policies/referrer-origin-when-cross-origin-service-worker.https-expected.txt:
• web-platform-tests/fetch/api/policies/referrer-unsafe-url-service-worker.https-expected.txt:
• web-platform-tests/html/webappapis/scripting/processing-model-2/integration-with-the-javascript-agent-formalism/canblock-serviceworker.https-expected.txt:
• web-platform-tests/service-workers/cache-storage/serviceworker/cache-add.https-expected.txt:
• web-platform-tests/service-workers/cache-storage/serviceworker/cache-delete.https-expected.txt:
• web-platform-tests/service-workers/cache-storage/serviceworker/cache-keys.https-expected.txt:
• web-platform-tests/service-workers/cache-storage/serviceworker/cache-match.https-expected.txt:
• web-platform-tests/service-workers/cache-storage/serviceworker/cache-matchAll.https-expected.txt:
• web-platform-tests/service-workers/cache-storage/serviceworker/cache-put.https-expected.txt:
• web-platform-tests/service-workers/cache-storage/serviceworker/cache-storage-keys.https-expected.txt:
• web-platform-tests/service-workers/cache-storage/serviceworker/cache-storage-match.https-expected.txt:
• web-platform-tests/service-workers/cache-storage/serviceworker/cache-storage.https-expected.txt:
• web-platform-tests/streams/byte-length-queuing-strategy.serviceworker.https-expected.txt:
• web-platform-tests/streams/count-queuing-strategy.serviceworker.https-expected.txt:
• web-platform-tests/streams/piping/close-propagation-backward.serviceworker.https-expected.txt:
• web-platform-tests/streams/piping/close-propagation-forward.serviceworker.https-expected.txt:
• web-platform-tests/streams/piping/error-propagation-backward.serviceworker.https-expected.txt:
• web-platform-tests/streams/piping/error-propagation-forward.serviceworker.https-expected.txt:
• web-platform-tests/streams/piping/flow-control.serviceworker.https-expected.txt:
• web-platform-tests/streams/piping/general.serviceworker.https-expected.txt:
• web-platform-tests/streams/piping/multiple-propagation.serviceworker.https-expected.txt:
• web-platform-tests/streams/piping/pipe-through.serviceworker.https-expected.txt:
• web-platform-tests/streams/piping/transform-streams.serviceworker.https-expected.txt:
• web-platform-tests/streams/readable-byte-streams/general.serviceworker.https-expected.txt:
• web-platform-tests/streams/readable-streams/bad-strategies.serviceworker.https-expected.txt:
• web-platform-tests/streams/readable-streams/bad-underlying-sources.serviceworker.https-expected.txt:
• web-platform-tests/streams/readable-streams/brand-checks.serviceworker.https-expected.txt:
• web-platform-tests/streams/readable-streams/cancel.serviceworker.https-expected.txt:
• web-platform-tests/streams/readable-streams/count-queuing-strategy-integration.serviceworker.https-expected.txt:
• web-platform-tests/streams/readable-streams/default-reader.serviceworker.https-expected.txt:
• web-platform-tests/streams/readable-streams/floating-point-total-queue-size.serviceworker.https-expected.txt:
• web-platform-tests/streams/readable-streams/garbage-collection.serviceworker.https-expected.txt:
• web-platform-tests/streams/readable-streams/general.serviceworker.https-expected.txt:
• web-platform-tests/streams/readable-streams/pipe-through.serviceworker.https-expected.txt:
• web-platform-tests/streams/readable-streams/readable-stream-reader.serviceworker.https-expected.txt:
• web-platform-tests/streams/readable-streams/tee.serviceworker.https-expected.txt:
• web-platform-tests/streams/readable-streams/templated.serviceworker.https-expected.txt:

Source/WebCore:

No new tests (Covered by both changes and consistencies in existing tests)

This lays the groundwork for the SW job queue being in the StorageProcess by actually
setting up some objects for IPC communication and actually sending things over the wire.

The main point of IPC is the WebCore abstract base class "SWServer::Connection"

A collection of them will soon be managed by the SWServer itself in the StorageProcess.

That object will be the stand-in for IPC on both the WebProcess and StorageProcess side.

Currently, any job that we try to schedule still immediately rejects (though now it does
so asynchronously instead of synchronously).

• CMakeLists.txt:
• WebCore.xcodeproj/project.pbxproj:

• dom/ExceptionData.h: Copied from Source/WebCore/workers/service/ServiceWorkerProvider.h.

(WebCore::ExceptionData::toException const):
(WebCore::ExceptionData::encode const):
(WebCore::ExceptionData::decode):

• workers/service/ServiceWorkerContainer.cpp:

(WebCore::ServiceWorkerContainer::addRegistration):
(WebCore::ServiceWorkerContainer::scheduleJob):

• workers/service/ServiceWorkerContainer.h:

• workers/service/ServiceWorkerJob.cpp:

(WebCore::ServiceWorkerJob::failedWithException):
(WebCore::ServiceWorkerJob::data const):

• workers/service/ServiceWorkerJob.h:

• workers/service/ServiceWorkerJobData.h: Copied from Source/WebCore/workers/service/ServiceWorkerProvider.h.

(WebCore::ServiceWorkerJobData::encode const):
(WebCore::ServiceWorkerJobData::decode):

• workers/service/ServiceWorkerJobType.h: Copied from Source/WebCore/workers/service/ServiceWorkerProvider.h.

• workers/service/ServiceWorkerProvider.h:

• workers/service/ServiceWorkerRegistrationParameters.h:

• workers/service/server/SWServer.cpp: Copied from Source/WebKit/WebProcess/Storage/WebServiceWorkerProvider.cpp.

(WebCore::SWServer::Connection::scheduleJob):
(WebCore::SWServer::Connection::jobRejected):

• workers/service/server/SWServer.h: Copied from Source/WebCore/workers/service/ServiceWorkerProvider.h.

(WebCore::SWServer::Connection::~Connection):

Source/WebKit:

• CMakeLists.txt:
• DerivedSources.make:
• WebKit.xcodeproj/project.pbxproj:

• Platform/Logging.h:

• StorageProcess/StorageToWebProcessConnection.cpp:

(WebKit::StorageToWebProcessConnection::didReceiveMessage):
(WebKit::StorageToWebProcessConnection::didClose):
(WebKit::StorageToWebProcessConnection::establishSWServerConnection):
(WebKit::StorageToWebProcessConnection::removeSWServerConnection):
(WebKit::StorageToWebProcessConnection::establishIDBConnectionToServer):

• StorageProcess/StorageToWebProcessConnection.h:
• StorageProcess/StorageToWebProcessConnection.messages.in:

• WebProcess/Storage/WebSWServerConnection.cpp: Added.

(WebKit::WebSWServerConnection::WebSWServerConnection):
(WebKit::WebSWServerConnection::~WebSWServerConnection):
(WebKit::WebSWServerConnection::disconnectedFromWebProcess):
(WebKit::WebSWServerConnection::scheduleJob):
(WebKit::WebSWServerConnection::scheduleStorageJob):

• WebProcess/Storage/WebSWServerConnection.h: Copied from Source/WebCore/workers/service/ServiceWorkerJob.h.

(WebKit::WebSWServerConnection::create):
(WebKit::WebSWServerConnection::identifier const):

• WebProcess/Storage/WebSWServerConnection.messages.in: Copied from Source/WebKit/StorageProcess/StorageToWebProcessConnection.messages.in.

• WebProcess/Storage/WebServiceWorkerProvider.cpp:

(WebKit::WebServiceWorkerProvider::serviceWorkerConnectionForSession):
(WebKit::WebServiceWorkerProvider::scheduleJob): Deleted.

• WebProcess/Storage/WebServiceWorkerProvider.h:

• WebProcess/Storage/WebToStorageProcessConnection.cpp:

(WebKit::WebToStorageProcessConnection::didReceiveMessage):
(WebKit::WebToStorageProcessConnection::serviceWorkerConnectionForSession):

• WebProcess/Storage/WebToStorageProcessConnection.h:

LayoutTests:

Service worker tests will always be dumpAsText and always be asynchronous.

• http/tests/workers/service/basic-register.html:
• http/tests/workers/service/resources/basic-register.js:
• http/tests/workers/service/resources/sw-test-pre.js: Added.

10:58 AM Changeset in webkit [220923] by Ryan Haddad

• 2 edits in branches/safari-604.1.38.1-branch/LayoutTests

Unreviewed, update TestExpectations.

• platform/mac-highsierra/TestExpectations:

10:58 AM Changeset in webkit [220922] by Chris Dumez

• 21 edits in trunk

[Beacon] Add support for quota limitation
​https://bugs.webkit.org/show_bug.cgi?id=175443
<rdar://problem/33729002>

Reviewed by Youenn Fablet.

Source/WebCore:

LoaderStrategy::startPingLoad() now takes a completion handler parameter, allowing CachedResource::load()
to know when a Beacon load is complete. This was needed in order for the fetch in-flight keepalive request
quota limit to work properly for beacon loads as well. We need to know when the beacon load completes in
order to know if the beacon is in-flight or not and only free up its allocated quota once it is no longer
in-flight.

No new tests, updated existing test.

• loader/LoaderStrategy.h:
• loader/PingLoader.cpp:

(WebCore::PingLoader::startPingLoad):

• loader/cache/CachedResource.cpp:

(WebCore::CachedResource::load):

• platform/network/PingHandle.h:

Source/WebKit:

WebLoaderStrategy now generates an identifier for ping loads and keep
the completion handler in a local HashMap. Once the ping load is done,
the network process sends an IPC message back to the WebContent process
so that WebLoaderStrategy can look up the completion handler for the
ping load and call it.

• NetworkProcess/NetworkConnectionToWebProcess.cpp:

(WebKit::NetworkConnectionToWebProcess::loadPing):
(WebKit::NetworkConnectionToWebProcess::didFinishPingLoad):

• NetworkProcess/NetworkConnectionToWebProcess.h:
• NetworkProcess/PingLoad.cpp:

(WebKit::PingLoad::PingLoad):
(WebKit::PingLoad::~PingLoad):

• NetworkProcess/PingLoad.h:
• WebProcess/Network/NetworkProcessConnection.cpp:

(WebKit::NetworkProcessConnection::didFinishPingLoad):

• WebProcess/Network/NetworkProcessConnection.h:
• WebProcess/Network/NetworkProcessConnection.messages.in:
• WebProcess/Network/WebLoaderStrategy.cpp:

(WebKit::generatePingLoadIdentifier):
(WebKit::WebLoaderStrategy::startPingLoad):
(WebKit::WebLoaderStrategy::didFinishPingLoad):

• WebProcess/Network/WebLoaderStrategy.h:

Source/WebKitLegacy:

• WebCoreSupport/WebResourceLoadScheduler.cpp:

(WebResourceLoadScheduler::startPingLoad):

• WebCoreSupport/WebResourceLoadScheduler.h:

LayoutTests:

Extend layout test coverage and rebaseline test.

• http/wpt/beacon/beacon-quota-expected.txt:
• http/wpt/beacon/beacon-quota.html:

10:54 AM Changeset in webkit [220921] by mark.lam@apple.com

• 14 edits in trunk/Source/JavaScriptCore

Rename ProbeContext and ProbeFunction to Probe::State and Probe::Function.
​https://bugs.webkit.org/show_bug.cgi?id=175725
<rdar://problem/33965477>

Rubber-stamped by JF Bastien.

This is purely a refactoring patch (in preparation for the introduction of a
Probe::Context data structure in ​https://bugs.webkit.org/show_bug.cgi?id=175688
later). This patch does not change any semantics / behavior.

• assembler/AbstractMacroAssembler.h:
• assembler/MacroAssembler.cpp:

(JSC::stdFunctionCallback):
(JSC::MacroAssembler::probe):

• assembler/MacroAssembler.h:

(JSC::ProbeContext::gpr): Deleted.
(JSC::ProbeContext::spr): Deleted.
(JSC::ProbeContext::fpr): Deleted.
(JSC::ProbeContext::gprName): Deleted.
(JSC::ProbeContext::sprName): Deleted.
(JSC::ProbeContext::fprName): Deleted.
(JSC::ProbeContext::pc): Deleted.
(JSC::ProbeContext::fp): Deleted.
(JSC::ProbeContext::sp): Deleted.

• assembler/MacroAssemblerARM.cpp:

(JSC::MacroAssembler::probe):

• assembler/MacroAssemblerARM.h:

(JSC::MacroAssemblerARM::trustedImm32FromPtr):

• assembler/MacroAssemblerARM64.cpp:

(JSC::arm64ProbeError):
(JSC::MacroAssembler::probe):

• assembler/MacroAssemblerARMv7.cpp:

(JSC::MacroAssembler::probe):

• assembler/MacroAssemblerARMv7.h:

(JSC::MacroAssemblerARMv7::trustedImm32FromPtr):

• assembler/MacroAssemblerPrinter.cpp:

(JSC::Printer::printCallback):

• assembler/MacroAssemblerPrinter.h:
• assembler/MacroAssemblerX86Common.cpp:

(JSC::MacroAssembler::probe):

• assembler/Printer.h:

(JSC::Printer::Context::Context):

• assembler/testmasm.cpp:

(JSC::testProbeReadsArgumentRegisters):
(JSC::testProbeWritesArgumentRegisters):
(JSC::testProbePreservesGPRS):
(JSC::testProbeModifiesStackPointer):
(JSC::testProbeModifiesStackPointerToInsideProbeStateOnStack):
(JSC::testProbeModifiesStackPointerToNBytesBelowSP):
(JSC::testProbeModifiesProgramCounter):
(JSC::fillStack):
(JSC::testProbeModifiesStackWithCallback):
(JSC::run):
(JSC::testProbeModifiesStackPointerToInsideProbeContextOnStack): Deleted.

10:49 AM Changeset in webkit [220920] by Ryan Haddad

• 2 edits in trunk/LayoutTests

Unreviewed, land TestExpectations for rdar://problem/33850189.

• platform/mac-highsierra/TestExpectations:

10:42 AM Changeset in webkit [220919] by Ryan Haddad

• 2 edits in trunk/LayoutTests

Rebaseline js/dom/global-constructors-attributes.html for El Capitan WK2.

Unreviewed test gardening.

• platform/mac-elcapitan-wk2/js/dom/global-constructors-attributes-expected.txt:

9:08 AM Changeset in webkit [220918] by commit-queue@webkit.org

• 1 edit
  1 add in trunk/Tools

[Tools] Add script to download a GitHub release
​https://bugs.webkit.org/show_bug.cgi?id=175279

Patch by Ross Kirsling <Ross Kirsling> on 2017-08-18
Reviewed by Brent Fulgham.

• Scripts/download-latest-github-release.py: Added.

8:51 AM Changeset in webkit [220917] by commit-queue@webkit.org

• 35 edits
  2 copies
  7 adds in trunk

[Cache API] Add a WK2 implementation of CacheStorageConnection
​https://bugs.webkit.org/show_bug.cgi?id=175640

Patch by Youenn Fablet <​youenn@apple.com> on 2017-08-18
Reviewed by Alex Christensen & Chris Dumez.

LayoutTests/imported/w3c:

• web-platform-tests/service-workers/cache-storage/window/cache-add.https-expected.txt:
• web-platform-tests/service-workers/cache-storage/window/cache-delete.https-expected.txt:
• web-platform-tests/service-workers/cache-storage/window/cache-keys.https-expected.txt:
• web-platform-tests/service-workers/cache-storage/window/cache-match.https-expected.txt:
• web-platform-tests/service-workers/cache-storage/window/cache-matchAll.https-expected.txt:
• web-platform-tests/service-workers/cache-storage/window/cache-put.https-expected.txt:
• web-platform-tests/service-workers/cache-storage/window/cache-storage-keys.https-expected.txt:
• web-platform-tests/service-workers/cache-storage/window/cache-storage.https-expected.txt:
• web-platform-tests/service-workers/cache-storage/window/sandboxed-iframes.https-expected.txt:
• web-platform-tests/service-workers/cache-storage/worker/cache-add.https-expected.txt:
• web-platform-tests/service-workers/cache-storage/worker/cache-delete.https-expected.txt:
• web-platform-tests/service-workers/cache-storage/worker/cache-keys.https-expected.txt:
• web-platform-tests/service-workers/cache-storage/worker/cache-match.https-expected.txt:
• web-platform-tests/service-workers/cache-storage/worker/cache-matchAll.https-expected.txt:
• web-platform-tests/service-workers/cache-storage/worker/cache-put.https-expected.txt:
• web-platform-tests/service-workers/cache-storage/worker/cache-storage-keys.https-expected.txt:
• web-platform-tests/service-workers/cache-storage/worker/cache-storage.https-expected.txt:

Source/WebCore:

• Modules/cache/CacheStorageConnection.cpp: Adding Internal error.
• Modules/cache/CacheStorageConnection.h: Ditto.
• WebCore.xcodeproj/project.pbxproj: Exporting CacheQueryOptions.h header.

Source/WebKit:

Adding WebCacheStorageConnection as an implementation of CacheStorageConnection.
Making WebCacheStorageProvider instantiates such class.
One WebCacheStorageConnection is created for each session of a given WebProcess.

WebCacheStorageConnection is sending IPC calls to the network process.
Main implementation of the cache API is done in the network process by CacheStorageEngineConnection and CacheStorageEngine.
There is one WebCacheStorageConnection per session.
WebCacheStorageConnection is passing the session ID for each call to the network process to ensure the right cache storage engine is used.

CacheStorageEngineConnection mirrors WebCacheStorageConnection on the network process.
There is one CacheStorageEngine per session and CacheStorageEngineConnection will select the right CacheStorageEngine using the given session ID.

CacheStorageEngine is responsible of storing and matching cache API records.
Current implementation only keeps in memory the cached objects.

CacheStorageEngine is keeping (for each different origin) caches and records as a Vector as the order of insertion is important as per spec.
It also keeps a list of removed caches. These caches should remain functional until the last web page having access to these is gone.
The mechanism to fully remove these caches is not implemented yet.

Adding IPC encodings for WTF::Expected, CacheQueryOptions, FetchOptions, CacheStorageConnection Record and CacheInfo.

• CMakeLists.txt:
• DerivedSources.make:
• NetworkProcess/NetworkConnectionToWebProcess.cpp:

(WebKit::NetworkConnectionToWebProcess::didReceiveMessage):
(WebKit::generateCacheStorageConnectionIdentifier):
(WebKit::NetworkConnectionToWebProcess::createCacheStorageConnection):
(WebKit::NetworkConnectionToWebProcess::closeCacheStorageConnection):

• NetworkProcess/NetworkConnectionToWebProcess.h:
• NetworkProcess/NetworkConnectionToWebProcess.messages.in:
• NetworkProcess/cache/CacheStorageEngine.cpp: Added.

(WebKit::defaultCacheStorageEngine):
(WebKit::globalEngineMap):
(WebKit::CacheStorageEngine::from):
(WebKit::CacheStorageEngine::destroyEngine):
(WebKit::CacheStorageEngine::defaultEngine):
(WebKit::CacheStorageEngine::open):
(WebKit::CacheStorageEngine::remove):
(WebKit::CacheStorageEngine::retrieveCaches):
(WebKit::CacheStorageEngine::retrieveRecords):
(WebKit::CacheStorageEngine::putRecords):
(WebKit::CacheStorageEngine::deleteMatchingRecords):
(WebKit::CacheStorageEngine::writeCachesToDisk):
(WebKit::CacheStorageEngine::readCachesFromDisk):
(WebKit::CacheStorageEngine::readCache):
(WebKit::CacheStorageEngine::writeCacheRecords):
(WebKit::CacheStorageEngine::removeCacheRecords):
(WebKit::CacheStorageEngine::cache):
(WebKit::CacheStorageEngine::caches const):
(WebKit::CacheStorageEngine::records):
(WebKit::CacheStorageEngine::queryCache):

• NetworkProcess/cache/CacheStorageEngine.h: Added.
• NetworkProcess/cache/CacheStorageEngineConnection.cpp: Added.

(WebKit::CacheStorageEngineConnection::CacheStorageEngineConnection):
(WebKit::CacheStorageEngineConnection::open):
(WebKit::CacheStorageEngineConnection::remove):
(WebKit::CacheStorageEngineConnection::caches):
(WebKit::CacheStorageEngineConnection::records):
(WebKit::CacheStorageEngineConnection::deleteMatchingRecords):
(WebKit::CacheStorageEngineConnection::putRecords):

• NetworkProcess/cache/CacheStorageEngineConnection.h: Added.

(WebKit::CacheStorageEngineConnection::create):

• NetworkProcess/cache/CacheStorageEngineConnection.messages.in: Added.
• Platform/IPC/ArgumentCoders.h:
• Shared/WebCoreArgumentCoders.cpp:

(IPC::ArgumentCoder<CacheQueryOptions>::encode):
(IPC::ArgumentCoder<CacheQueryOptions>::decode):
(IPC::ArgumentCoder<FetchOptions>::encode):
(IPC::ArgumentCoder<FetchOptions>::decode):
(IPC::ArgumentCoder<CacheStorageConnection::CacheInfo>::encode):
(IPC::ArgumentCoder<CacheStorageConnection::CacheInfo>::decode):
(IPC::ArgumentCoder<CacheStorageConnection::Record>::encode):
(IPC::ArgumentCoder<CacheStorageConnection::Record>::decode):

• Shared/WebCoreArgumentCoders.h:
• WebKit.xcodeproj/project.pbxproj:
• WebProcess/Cache/WebCacheStorageConnection.cpp: Added.

(WebKit::WebCacheStorageConnection::WebCacheStorageConnection):
(WebKit::WebCacheStorageConnection::~WebCacheStorageConnection):
(WebKit::WebCacheStorageConnection::messageSenderConnection):
(WebKit::WebCacheStorageConnection::doOpen):
(WebKit::WebCacheStorageConnection::doRemove):
(WebKit::WebCacheStorageConnection::doRetrieveCaches):
(WebKit::WebCacheStorageConnection::doRetrieveRecords):
(WebKit::WebCacheStorageConnection::doBatchDeleteOperation):
(WebKit::WebCacheStorageConnection::doBatchPutOperation):
(WebKit::WebCacheStorageConnection::openCompleted):
(WebKit::WebCacheStorageConnection::removeCompleted):
(WebKit::WebCacheStorageConnection::updateCaches):
(WebKit::WebCacheStorageConnection::updateRecords):
(WebKit::WebCacheStorageConnection::deleteRecordsCompleted):
(WebKit::WebCacheStorageConnection::putRecordsCompleted):

• WebProcess/Cache/WebCacheStorageConnection.h: Added.
• WebProcess/Cache/WebCacheStorageConnection.messages.in: Added.
• WebProcess/Cache/WebCacheStorageProvider.cpp: Copied from Source/WebKit/WebProcess/Cache/WebCacheStorageProvider.h.

(WebKit::WebCacheStorageProvider::createCacheStorageConnection):

• WebProcess/Cache/WebCacheStorageProvider.h:
• WebProcess/Network/NetworkProcessConnection.cpp:

(WebKit::NetworkProcessConnection::didReceiveMessage):

LayoutTests:

• TestExpectations: Marking some tests as flaky until being loaded resources can be cached.

7:52 AM Changeset in webkit [220916] by Antti Koivisto

• 9 edits
  2 adds in trunk/Source/WebCore

Factor render tree mutation code from RenderListItem to RenderTreeUpdater
​https://bugs.webkit.org/show_bug.cgi?id=175718

Reviewed by Andreas Kling.

We already stopped doing layout time mutations. We can now move the code out too.

• WebCore.xcodeproj/project.pbxproj:
• rendering/RenderListItem.cpp:

(WebCore::isHTMLListElement):
(WebCore::getParentOfFirstLineBox): Deleted.
(WebCore::firstNonMarkerChild): Deleted.
(WebCore::RenderListItem::updateMarkerRenderer): Deleted.

Moved to RenderTreeUpdater::ListItem.

• rendering/RenderListItem.h:
• rendering/RenderListMarker.cpp:

(WebCore::RenderListMarker::willBeDestroyed):

• rendering/TextAutoSizing.cpp:

(WebCore::TextAutoSizingValue::adjustTextNodeSizes):

• style/RenderTreeUpdater.cpp:

(WebCore::RenderTreeUpdater::pushParent):
(WebCore::RenderTreeUpdater::popParent):
(WebCore::RenderTreeUpdater::updateBeforeDescendants):
(WebCore::RenderTreeUpdater::updateAfterDescendants):

Factor pre/post update into functions.

(WebCore::RenderTreeUpdater::updateBeforeOrAfterPseudoElement):

• style/RenderTreeUpdater.h:
• style/RenderTreeUpdaterListItem.cpp: Added.

Mutation functions move here.

(WebCore::getParentOfFirstLineBox):
(WebCore::firstNonMarkerChild):
(WebCore::RenderTreeUpdater::ListItem::updateMarker):

• style/RenderTreeUpdaterListItem.h: Added.

6:41 AM Changeset in webkit [220915] by commit-queue@webkit.org

• 3 edits in trunk/LayoutTests

[GTK] Layout Test media/video-controls-no-scripting.html is failing
​https://bugs.webkit.org/show_bug.cgi?id=141835

Unreviewed test gardening.

The output appears to be consistent based on local testing.

Rebaseline video-controls-no-scripting.html.

Patch by Ms2ger <​Ms2ger@igalia.com> on 2017-08-18

• platform/gtk/TestExpectations:
• platform/gtk/media/video-controls-no-scripting-expected.txt:

4:06 AM Changeset in webkit [220914] by Carlos Garcia Campos

• 1 copy in releases/WebKitGTK/webkit-2.17.91

WebKitGTK+ 2.17.91

4:04 AM Changeset in webkit [220913] by Carlos Garcia Campos

• 4 edits in releases/WebKitGTK/webkit-2.18

Unreviewed. Update OptionsGTK.cmake and NEWS for 2.17.91 release.

.:

• Source/cmake/OptionsGTK.cmake: Bump version numbers.

Source/WebKit:

• gtk/NEWS: Add release notes for 2.17.91.

2:24 AM Changeset in webkit [220912] by commit-queue@webkit.org

• 7 edits in trunk/LayoutTests

Update track-datacue.html test to the current code.
​https://bugs.webkit.org/show_bug.cgi?id=175624

Patch by Ms2ger <​Ms2ger@igalia.com> on 2017-08-18
Reviewed by Eric Carlson.

• media/track/track-datacue-expected.txt: rebaselined.
• media/track/track-datacue.html: updated for IDL, exception changes, addition of a new constructor.
• platform/gtk/TestExpectations: removed failure expectation.
• platform/ios/TestExpectations: enable.
• platform/mac/TestExpectations: enable.
• platform/win/TestExpectations: enable.

2:12 AM Changeset in webkit [220911] by commit-queue@webkit.org

• 2 edits in trunk/LayoutTests

[GTK] Remove some obsolete expected failures.
​https://bugs.webkit.org/show_bug.cgi?id=175674

Unreviewed test gardening.

Patch by Ms2ger <​Ms2ger@gmail.com> on 2017-08-18

• platform/gtk/TestExpectations:
  • imported/w3c/web-platform-tests/IndexedDB/keyorder.htm: passing since r204279.
  • imported/w3c/web-platform-tests/resource-timing/rt-cors.html: passing since r212944 and r212993.
  • imported/w3c/web-platform-tests/resource-timing/rt-cors.worker.html: passing since r212944 and r212993.
  • imported/w3c/web-platform-tests/webrtc/getstats.html: passing since test update and rebaseline in r217225.
  • mathml/opentype/large-operators-displaystyle-dynamic.html: used to be flaky, seems to be passing consistently now.
  • media/media-fullscreen-return-to-inline.html: likely passing since r218270.
  • media/video-fast-seek.html: passing since r207879-r207894.
  • platform/gtk/scrollbars/main-frame-scrollbar-horizontal-wheel-scroll.html: passing since r205075.
  • security/contentSecurityPolicy/video-with-data-url-allowed-by-media-src-star.html: flaky.
  • storage/indexeddb/cursor-key-order.html: likely passing since r209135.
  • svg/dom/SVGScriptElement/script-change-externalResourcesRequired-while-loading.svg: flaky.
  • svg/repaint/add-outline-property-on-root.html: passing since r211277
  • svg/repaint/remove-outline-property-on-root.html: passing since r211277

1:58 AM Changeset in webkit [220910] by commit-queue@webkit.org

• 4 edits in trunk

[GTK] Show controls if a video element isn't allowed to play inline.
​https://bugs.webkit.org/show_bug.cgi?id=141705

Patch by Ms2ger <​Ms2ger@gmail.com> on 2017-08-18
Reviewed by Xabier Rodriguez-Calvar.

Source/WebCore:

Test: covered by media/video-fullscreeen-only-controls.html [sic].

• Modules/mediacontrols/mediaControlsGtk.js:

(ControllerGtk.prototype.shouldHaveControls):

LayoutTests:

• platform/gtk/TestExpectations: enable test for this case.

12:53 AM WebKitGTK/2.18.x edited by Carlos Garcia Campos

(diff)

12:53 AM Changeset in webkit [220909] by Carlos Garcia Campos

• 2 edits
  1 add
  1 delete in releases/WebKitGTK/webkit-2.18/Tools

Merge r220902 - [GTK] Make TestContextMenu work on Fedora
​https://bugs.webkit.org/show_bug.cgi?id=175708

Reviewed by Carlos Garcia Campos.

TestContextMenu has been broken for as long as I remember, but not on the bots, only for me
and my student last summer who was trying to work on a context menu API. It's trying to load
an MPEG-2 video file and confirm that right-clicking on it shows media element context menu
entries. Doesn't work on Fedora. Dunno why, since Fedora actually can play MPEG-2, but I
don't care to investigate. Let's switch it to WebM so I can move on.

• TestWebKitAPI/Tests/WebKit2Gtk/TestContextMenu.cpp:

(prepareContextMenuTestView):

• TestWebKitAPI/Tests/WebKitGLib/resources/silence.mpg: Removed.
• TestWebKitAPI/Tests/WebKitGLib/resources/silence.webm: Added.

12:50 AM Changeset in webkit [220908] by Carlos Garcia Campos

• 4 edits
  3 adds in releases/WebKitGTK/webkit-2.18

Merge r220894 - WebAssembly: const in unreachable code decoded incorrectly, erroneously rejects binary as invalid
​https://bugs.webkit.org/show_bug.cgi?id=175693
<rdar://problem/33952443>

Reviewed by Saam Barati.

JSTests:

Add a regression directory for WebAssembly tests.

• wasm.yaml:
• wasm/regress/175693.js: Added.

(else.else):
(instance.new.WebAssembly.Instance.new.WebAssembly.Module):
(catch):

• wasm/regress/175693.wasm: Added.

Source/JavaScriptCore:

64-bit constants in an unreachable context were being decoded as
32-bit constants. This is pretty benign because unreachable code
shouldn't occur often. The effect is that 64-bit constants which
can't be encoded as 32-bit constants would cause the binary to be
rejected.

At the same time, 32-bit integer constants should be decoded as signed.

• wasm/WasmFunctionParser.h:

(JSC::Wasm::FunctionParser<Context>::parseUnreachableExpression):

12:48 AM Changeset in webkit [220907] by Carlos Garcia Campos

• 4 edits in releases/WebKitGTK/webkit-2.18/Source

Merge r220860 - [WPE][GTK] Ensure proper casting of data in gvariants
​https://bugs.webkit.org/show_bug.cgi?id=175667

Patch by Jacobo Aragunde Pérez <​jaragunde@igalia.com> on 2017-08-17
Reviewed by Michael Catanzaro.

Source/JavaScriptCore:

g_variant_new requires data to have the correct width for their types, using
casting if necessary. Some data of type unsigned were being saved to guint64
types without explicit casting, leading to undefined behavior in some platforms.

• inspector/remote/glib/RemoteInspectorGlib.cpp:

(Inspector::RemoteInspector::listingForInspectionTarget const):
(Inspector::RemoteInspector::listingForAutomationTarget const):
(Inspector::RemoteInspector::sendMessageToRemote):

Source/WebKit:

g_variant_builder_add requires data to have the correct width for their types, using
casting if necessary. Corrected a call where a single precision float was being put
into a double precision parameter without a cast.

• UIProcess/API/glib/WebKitWebViewSessionState.cpp:

(encodeFrameState):

12:47 AM Changeset in webkit [220906] by Carlos Garcia Campos

• 11 edits in releases/WebKitGTK/webkit-2.18

Merge r220858 - RenderListItem - Avoid render tree mutation during layout
​https://bugs.webkit.org/show_bug.cgi?id=175666

Reviewed by Andreas Kling.

Source/WebCore:

Mutations should be done by RenderTreeUpdater only.

• rendering/RenderListItem.cpp:

(WebCore::RenderListItem::updateMarkerRenderer):

This is now called by RenderTreeUpdater only.
Remove code dealing with this being called at layout time.
Merged marker construction code from styleDidChange here and renamed for clarity.

(WebCore::RenderListItem::layout):
(WebCore::RenderListItem::computePreferredLogicalWidths):

Remove mutating calls.

(WebCore::RenderListItem::styleDidChange): Deleted.
(WebCore::RenderListItem::insertOrMoveMarkerRendererIfNeeded): Deleted.

• rendering/RenderListItem.h:
• rendering/TextAutoSizing.cpp:

(WebCore::TextAutoSizingValue::adjustTextNodeSizes):

Call updateMarkerRenderer.

• style/RenderTreeUpdater.cpp:

(WebCore::RenderTreeUpdater::popParent):
(WebCore::RenderTreeUpdater::updateBeforeOrAfterPseudoElement):

Call updateMarkerRenderer.

LayoutTests:

Changes in render tree dumps that don't affect rendering.

• platform/ios/fast/doctypes/002-expected.txt:
• platform/ios/fast/lists/marker-before-empty-inline-expected.txt:
• platform/mac/css2.1/t0805-c5520-brdr-b-01-e-expected.txt:
• platform/mac/fast/doctypes/002-expected.txt:
• platform/mac/fast/lists/marker-before-empty-inline-expected.txt:

12:45 AM Changeset in webkit [220905] by zandobersek@gmail.com

• 7 edits
  1 add in trunk/Source/WebCore

[EME] MediaKeySession has to initiate playback resume on HTMLMediaElement
​https://bugs.webkit.org/show_bug.cgi?id=175671

Reviewed by Xabier Rodriguez-Calvar.

In MediaKeySession::updateKeyStatuses(), HTMLMediaElement objects that are
associated with the MediaKeys instance that created this session have to
be notified in order to run the 'Attempt to Resume Playback If Necessary'
algorithm.

MediaKeys object now tracks the sessions that were created through it.
MediaKeySession object is passed a MediaKeys reference, and has that
reference invalidated if/when the MediaKeys object is destroyed.

In MediaKeySession::updateKeyStatuses(), a task is now queued, notifying
the MediaKeys object, if any, that the associated HTMLMediaElement
instances have to run the mentioned algorithm. The associated media
elements are stored through CDMClient pointers, with HTMLMediaElement
class inheriting from the newly-introduced CDMClient interface.

HTMLMediaElement::cdmClientAttemptToResumePlaybackIfNecessary() is left
unimplemented for now. The object will attach itself to and detach from
the associated MediaKeys object in setMediaKeys() and the destructor,
enabling the MediaKeys object to properly dispatch the playback resume
requests for the attached clients.

• Modules/encryptedmedia/CDMClient.h: Copied from Source/WebCore/Modules/encryptedmedia/MediaKeys.h.

(WebCore::CDMClient::~CDMClient):

• Modules/encryptedmedia/MediaKeySession.cpp:

(WebCore::MediaKeySession::create):
(WebCore::MediaKeySession::MediaKeySession):
(WebCore::MediaKeySession::detachKeys):
(WebCore::MediaKeySession::updateKeyStatuses):

• Modules/encryptedmedia/MediaKeySession.h:
• Modules/encryptedmedia/MediaKeys.cpp:

(WebCore::MediaKeys::~MediaKeys):
(WebCore::MediaKeys::createSession):
(WebCore::MediaKeys::attachCDMClient):
(WebCore::MediaKeys::detachCDMClient):
(WebCore::MediaKeys::attemptToResumePlaybackOnClients):

• Modules/encryptedmedia/MediaKeys.h:
• html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::cdmClientAttemptToResumePlaybackIfNecessary):

• html/HTMLMediaElement.h:

12:27 AM Changeset in webkit [220904] by Carlos Garcia Campos

• 17 edits in releases/WebKitGTK/webkit-2.18

Merge r220903 - Unreviewed, rolling out r220854.
​https://bugs.webkit.org/show_bug.cgi?id=175716

I'm not sure we really need this (Requested by KaL on

Reverted changeset:

"[GTK][WPE] Add NTLM authentication enabled API"
​https://bugs.webkit.org/show_bug.cgi?id=122952
​http://trac.webkit.org/changeset/220854

12:22 AM Changeset in webkit [220903] by commit-queue@webkit.org

• 17 edits in trunk

Unreviewed, rolling out r220854.
​https://bugs.webkit.org/show_bug.cgi?id=175716

I'm not sure we really need this (Requested by KaL on
#webkit).

Reverted changeset:

"[GTK][WPE] Add NTLM authentication enabled API"
​https://bugs.webkit.org/show_bug.cgi?id=122952
​http://trac.webkit.org/changeset/220854