Timeline

Aug 28, 2017:

9:33 PM Changeset in webkit [221289] by Brent Fulgham

• 3 edits in trunk/Source/WebKitLegacy/win

Unreviewed build fix #2 after r221275.

• WebCoreSupport/WebPlatformStrategies.cpp:

(WebPlatformStrategies::cookieRequestHeaderFieldValue): Correct return type and arguments
to match new API.

• WebCoreSupport/WebPlatformStrategies.h: Update signatures.

7:59 PM Changeset in webkit [221288] by eric.carlson@apple.com

• 4 edits in trunk

Logger should use makeString instead of String::format
​https://bugs.webkit.org/show_bug.cgi?id=176035

Reviewed by Jer Noble.

Source/WebCore/PAL:

• pal/Logger.h:

(PAL::LogArgument::toString):
(PAL::Logger::logAlways):
(PAL::Logger::error):
(PAL::Logger::warning):
(PAL::Logger::notice):
(PAL::Logger::info):
(PAL::Logger::debug):
(PAL::Logger::MethodAndPointer::MethodAndPointer):
(PAL::Logger::log):
(PAL::LogArgument<Logger::MethodAndPointer>::toString):

Tools:

• TestWebKitAPI/Tests/WebCore/Logging.cpp:

(TestWebKitAPI::TEST_F): Update test.

7:18 PM Changeset in webkit [221287] by pvollan@apple.com

• 2 edits in trunk/LayoutTests

Rebaseline accessibility/menu-list-crash2.html after r220930.

Unreviewed test gardening.

• platform/win/accessibility/menu-list-crash2-expected.txt:

5:55 PM Changeset in webkit [221286] by aestes@apple.com

• 15 edits
  2 adds in trunk/Source

[Cocoa] Upstream WKGetWebDefaultCFStringEncoding()
​https://bugs.webkit.org/show_bug.cgi?id=176039

Reviewed by Alex Christensen.

Source/WebCore:

• PlatformMac.cmake:
• WebCore.xcodeproj/project.pbxproj:
• platform/ios/WebCoreSystemInterfaceIOS.mm:
• platform/mac/WebCoreSystemInterface.h:
• platform/mac/WebCoreSystemInterface.mm:
• platform/text/TextEncodingRegistry.cpp:

(WebCore::defaultTextEncodingNameForSystemLanguage):

• platform/text/TextEncodingRegistry.h:
• platform/text/ios/TextEncodingRegistryIOS.mm: Added.

(WebCore::webDefaultCFStringEncoding):

• platform/text/mac/TextEncodingRegistryMac.mm: Added.

(WebCore::webDefaultCFStringEncoding):

Source/WebKit:

• WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:

(InitWebCoreSystemInterface):

Source/WebKitLegacy/mac:

• WebCoreSupport/WebSystemInterface.mm:

(InitWebCoreSystemInterface):

• WebView/WebPreferences.mm:

(+[WebPreferences _systemCFStringEncoding]):

Source/WTF:

• wtf/spi/cf/CFStringSPI.h:

5:42 PM Changeset in webkit [221285] by Ryan Haddad

• 2 edits
  1 copy
  3 adds in trunk/LayoutTests

Rebaseline http/tests/websocket/tests/hybi/secure-cookie-secure-connection.pl.

Unreviewed test gardening.

• http/tests/websocket/tests/hybi/secure-cookie-secure-connection-expected.txt:
• platform/mac-highsierra/http/tests/websocket/tests/hybi/secure-cookie-secure-connection-expected.txt: Copied from LayoutTests/http/tests/websocket/tests/hybi/secure-cookie-secure-connection-expected.txt.

5:40 PM Changeset in webkit [221284] by Michael Catanzaro

• 5 edits in trunk/Tools

[GStreamer] The glvideoflip GStreamer element isn't available. Video mirroring and rotation functionalities are thus disabled.
​https://bugs.webkit.org/show_bug.cgi?id=175576

Reviewed by Carlos Alberto Lopez Perez.

Build graphene to enable the glvideoflip element.

• gstreamer/jhbuild.modules:
• gtk/jhbuild.modules:
• jhbuild/jhbuild-wrapper:
• wpe/jhbuild.modules:

5:27 PM Changeset in webkit [221283] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebCore

REGRESSION(r220278): Web Inspector: ContextMenu items are not getting triggered
​https://bugs.webkit.org/show_bug.cgi?id=176034

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2017-08-28
Reviewed by Devin Rousso.

• inspector/InspectorFrontendHost.cpp:

(WebCore::InspectorFrontendHost::showContextMenu):
Responses go through InspectorFrontendAPI not InspectorFrontendHost.

5:21 PM Changeset in webkit [221282] by Matt Lewis

• 2 edits in branches/safari-604.1.38.0-branch/LayoutTests

Unreviewed test gardening. <rdar://problem/33381269> <rdar://problem/33903582>

• platform/ios-11/TestExpectations:

4:56 PM Changeset in webkit [221281] by Megan Gardner

• 2 edits in trunk/Source/WebKit

Fix incorrect enum in atBoundaryOfGranularity call
​https://bugs.webkit.org/show_bug.cgi?id=176004

Reviewed by Wenson Hsieh and Enrica Casucci

Enum that was being used was incorrect, as that case in not covered in called function.
Resulted in a no-op. Should now have correct behavior around line boundaries.

Not possible to add tests for selections with velocity. Will attempt to add this behavior later.

• WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::rangeAtWordBoundaryForPosition):

4:29 PM Changeset in webkit [221280] by Matt Lewis

• 2 edits in trunk/LayoutTests

Unreviewed test gardening. <rdar://problem/34051745>

• platform/ios-11/TestExpectations:

4:29 PM Changeset in webkit [221279] by commit-queue@webkit.org

• 1 edit
  1 add in trunk/Source/WebKit

[WinCairo] Add PlatformWin cmake for Webkit
​https://bugs.webkit.org/show_bug.cgi?id=176027

Patch by Stephan Szabo <​stephan.szabo@sony.com> on 2017-08-28
Reviewed by Brent Fulgham.

• PlatformWin.cmake: Added.

3:46 PM Changeset in webkit [221278] by Brent Fulgham

• 2 edits in trunk/Source/WebKitLegacy/win

Unreviewed build fix after r221275.

• WebCoreSupport/WebPlatformStrategies.cpp:

(WebPlatformStrategies::cookieRequestHeaderFieldValue): Correct return type and arguments
to match new API.

3:38 PM Changeset in webkit [221277] by commit-queue@webkit.org

• 9 edits in trunk

WebRTC MediaStream created without tracks does not update active state after tracks are added
​https://bugs.webkit.org/show_bug.cgi?id=175434

Patch by Youenn Fablet <​youenn@apple.com> on 2017-08-28
Reviewed by Eric Carlson.

Source/WebCore:

Covered by updated test.

Removing active/inactive events.
active attribute is still kept and is updated synchronously on every track change.

• Modules/mediastream/MediaStream.cpp:

(WebCore::MediaStream::MediaStream):
(WebCore::MediaStream::activeStatusChanged):
(WebCore::MediaStream::internalAddTrack):
(WebCore::MediaStream::updateActiveState):
(WebCore::MediaStream::hasPendingActivity const):
(WebCore::MediaStream::scheduleActiveStateChange): Deleted.
(WebCore::MediaStream::activityEventTimerFired): Deleted.

• Modules/mediastream/MediaStream.h:
• Modules/mediastream/MediaStream.idl:

LayoutTests:

• fast/mediacapturefromelement/CanvasCaptureMediaStream-clone-track-expected.txt:
• fast/mediacapturefromelement/CanvasCaptureMediaStream-creation-expected.txt:
• fast/mediastream/MediaStream-add-remove-tracks-expected.txt:
• fast/mediastream/MediaStream-add-remove-tracks.html:

3:23 PM Changeset in webkit [221276] by aestes@apple.com

• 20 edits in trunk/Source

[Cocoa] Upstream CFNetwork-related WebKitSystemInterface functions
​https://bugs.webkit.org/show_bug.cgi?id=176032

Reviewed by Alex Christensen.

Source/WebCore:

• platform/ios/WebCoreSystemInterfaceIOS.mm:
• platform/mac/WebCoreSystemInterface.h:
• platform/mac/WebCoreSystemInterface.mm:
• platform/network/NetworkStorageSession.h:
• platform/network/cf/NetworkStorageSessionCFNet.cpp:

(WebCore::NetworkStorageSession::switchToNewTestingSession):
(WebCore::NetworkStorageSession::ensureSession):

• platform/network/cf/ResourceRequest.h:
• platform/network/cocoa/NetworkStorageSessionCocoa.mm:

(WebCore::createPrivateStorageSession):

• platform/network/cocoa/ResourceRequestCocoa.mm:

(WebCore::ResourceRequest::setStorageSession):
(WebCore::copyRequestWithStorageSession):
(WebCore::cachedResponseForRequest):

• platform/network/mac/CookieJarMac.mm:

(WebCore::httpCookies):
(WebCore::setHTTPCookiesForURL):
(WebCore::deleteHTTPCookie):
(WebCore::deleteAllHTTPCookies):
(WebCore::setCookiesFromDOM):
(WebCore::httpCookieAcceptPolicy):
(WebCore::cookiesEnabled):
(WebCore::deleteCookie):
(WebCore::getHostnamesWithCookies):
(WebCore::deleteAllCookies):
(WebCore::deleteCookiesForHostnames):

• platform/network/mac/ResourceHandleMac.mm:

(WebCore::ResourceHandle::createNSURLConnection):

Source/WebCore/PAL:

• pal/spi/cf/CFNetworkSPI.h:

Source/WebKit:

• UIProcess/Cocoa/WebProcessPoolCocoa.mm:

(WebKit::privateBrowsingSession):

• WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:

(InitWebCoreSystemInterface):

• WebProcess/WebPage/mac/WebPageMac.mm:

(WebKit::WebPage::platformHasLocalDataForURL):
(WebKit::cachedResponseForURL):

Source/WebKitLegacy/mac:

• WebCoreSupport/WebSystemInterface.mm:

(InitWebCoreSystemInterface):

• WebView/WebView.mm:

(-[WebView _cachedResponseForURL:]):

3:08 PM Changeset in webkit [221275] by Brent Fulgham

• 26 edits
  4 adds in trunk

Disable access to secure cookies if an HTTPS site loads mixed content (Part 2: Header Requests)
​https://bugs.webkit.org/show_bug.cgi?id=175992
<rdar://problem/34086613>

Reviewed by Daniel Bates.

Source/WebCore:

The original work in Bug 157053 did not properly handle the case of websockets. This patch completes
the changes to secure cookie handling to make sure websockets are also protected.

Tests: http/tests/websocket/tests/hybi/secure-cookie-insecure-connection.pl

http/tests/websocket/tests/hybi/secure-cookie-secure-connection.pl

• Modules/websockets/WebSocketChannel.cpp:

(WebCore::WebSocketChannel::clientHandshakeRequest): Remove 'const' declaration so we can work with
a mutable Document object. This allows us to mark the Document as having accessed secure cookies.
(WebCore::WebSocketChannel::clientHandshakeRequest const): Deleted.

• Modules/websockets/WebSocketChannel.h:
• Modules/websockets/WebSocketHandshake.cpp:

(WebCore::WebSocketHandshake::clientHandshakeMessage): Ditto.
(WebCore::WebSocketHandshake::clientHandshakeRequest): Ditto.
(WebCore::WebSocketHandshake::clientHandshakeMessage const): Deleted.
(WebCore::WebSocketHandshake::clientHandshakeRequest const): Deleted.

• Modules/websockets/WebSocketHandshake.h:
• loader/CookieJar.cpp:

(WebCore::cookies): Small naming cleanup.
(WebCore::cookieRequestHeaderFieldValue): Pass a flag indicating whether secure cookies should be
included in the result or not. Set the document flag indicating secure cookies were accessed (if
they were), and return the resulting cookie string.

• loader/CookieJar.h:
• platform/CookiesStrategy.h:
• platform/network/CacheValidation.cpp:

(WebCore::headerValueForVary): Revise to pass a flag indicating whether secure cookies should be included
or not.

• platform/network/PlatformCookieJar.h:
• platform/network/cf/CookieJarCFNet.cpp:

(WebCore::doesContainSecureCookies): Added helper method.
(WebCore::cookiesForDOM): Revise to use new helper function.
(WebCore::cookieRequestHeaderFieldValue): Revise to accept a flag indicating if secure cookies should
be included in the result. Return a pair consisting of the cookie string, and a flag indicating whether
secure cookies were accessed or not.

• platform/network/curl/CookieJarCurl.cpp:

(WebCore::CookieJarCurlFileSystem::cookieRequestHeaderFieldValue): Ditto.
(WebCore::cookieRequestHeaderFieldValue): Ditto.

• platform/network/curl/CookieJarCurl.h:
• platform/network/mac/CookieJarMac.mm:

(WebCore::cookiesForSession): Ditto.
(WebCore::cookiesForDOM): Update for new 'cookiesForSession' signature.
(WebCore::cookieRequestHeaderFieldValue): Ditto.

• platform/network/soup/CookieJarSoup.cpp:

(WebCore::cookieRequestHeaderFieldValue): Revise to accept a flag indicating if secure cookies should
be included in the result. Return a pair consisting of the cookie string, and a flag indicating whether
secure cookies were accessed or not.

Source/WebKit:

• NetworkProcess/NetworkConnectionToWebProcess.cpp:

(WebKit::NetworkConnectionToWebProcess::cookiesForDOM): Use a better label than 'result'.
(WebKit::NetworkConnectionToWebProcess::cookieRequestHeaderFieldValue): Modify to accept a flag
indicating if secure cookies should be included, and return a pair containing the resulting
cookie string and a boolean indicating if secure cookies were accessed.

• NetworkProcess/NetworkConnectionToWebProcess.h:
• NetworkProcess/NetworkConnectionToWebProcess.messages.in: Ditto.
• Shared/mac/CookieStorageShim.mm:

(WebKit::webKitCookieStorageCopyRequestHeaderFieldsForURL): Ditto.

• WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:

(WebKit::WebPlatformStrategies::cookieRequestHeaderFieldValue): Ditto.

• WebProcess/WebCoreSupport/WebPlatformStrategies.h:

Source/WebKitLegacy/mac:

• WebCoreSupport/WebPlatformStrategies.h:
• WebCoreSupport/WebPlatformStrategies.mm:

(WebPlatformStrategies::cookieRequestHeaderFieldValue): Modify to accept a flag indicating if secure
cookies should be included, and return a pair containing the resulting cookie string and a boolean
indicating if secure cookies were accessed.

LayoutTests:

• http/tests/websocket/tests/hybi/secure-cookie-insecure-connection-expected.txt: Added.
• http/tests/websocket/tests/hybi/secure-cookie-insecure-connection.pl: Added.
• http/tests/websocket/tests/hybi/secure-cookie-secure-connection-expected.txt: Added.
• http/tests/websocket/tests/hybi/secure-cookie-secure-connection.pl: Added.

2:57 PM Changeset in webkit [221274] by Ryan Haddad

• 2 edits in trunk/LayoutTests

Unreviewed, remove duplicated TestExpectation entry.

• platform/mac-highsierra-wk2/TestExpectations:

2:48 PM Changeset in webkit [221273] by jmarcell@apple.com

• 2 edits in branches/safari-604-branch/Source/WebKit

Cherry-pick r221161. rdar://problem/34113784

2:48 PM Changeset in webkit [221272] by jmarcell@apple.com

• 4 edits in branches/safari-604-branch

Cherry-pick r221153. rdar://problem/34113728

2:14 PM Changeset in webkit [221271] by pvollan@apple.com

• 2 edits in trunk/LayoutTests

Before r220970, these ssl tests were failing. Now they are timing out.

Unreviewed test gardening.

• platform/win/TestExpectations:

2:13 PM Changeset in webkit [221270] by Ryan Haddad

• 2 edits in trunk/LayoutTests

Mark tiled-drawing/scrolling/fast-scroll-iframe-latched-mainframe-with-handler.html as flaky.
​https://bugs.webkit.org/show_bug.cgi?id=172544

Unreviewed test gardening.

• platform/mac-wk2/TestExpectations:

1:57 PM Changeset in webkit [221269] by jmarcell@apple.com

• 3 edits in branches/safari-604-branch/Source/WebKit

Cherry-pick r221138. rdar://problem/34113574

1:11 PM Changeset in webkit [221268] by pvollan@apple.com

• 2 edits in trunk/Source/WebKitLegacy/win

[Win] The test http/tests/misc/policy-delegate-called-twice.html is crashing.
​https://bugs.webkit.org/show_bug.cgi?id=176031

Reviewed by Brent Fulgham.

When the function in the FramePolicyFunction parameter is called, it has already been moved
to an internal member by the setUpPolicyListener method, and is no longer valid. Invoke the
function by using the stored member instead.

• WebCoreSupport/WebFrameLoaderClient.cpp:

(WebFrameLoaderClient::dispatchDecidePolicyForResponse):
(WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction):
(WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):

1:10 PM Changeset in webkit [221267] by Matt Lewis

• 2 edits in trunk/LayoutTests

Marked svg/in-html/by-reference.html as flaky.
​https://bugs.webkit.org/show_bug.cgi?id=175781

Unreviewed test gardening.

• platform/mac-wk2/TestExpectations:

12:56 PM Changeset in webkit [221266] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Remove some unused DataGrid code
​https://bugs.webkit.org/show_bug.cgi?id=176029

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2017-08-28
Reviewed by Matt Baker.

• UserInterface/Views/DataGrid.js:

(WI.DataGrid.prototype.get copyTextDelimiter):
(WI.DataGrid.prototype.set copyTextDelimiter):
(WI.DataGrid.prototype.resizerDragging):
(WI.DataGrid.prototype.columnWidthsMap): Deleted.
(WI.DataGrid.prototype.applyColumnWidthsMap): Deleted.
(WI.DataGrid.prototype.get resizeMethod): Deleted.
(WI.DataGrid.prototype.set resizeMethod): Deleted.

12:48 PM Changeset in webkit [221265] by pvollan@apple.com

• 2 edits in trunk/LayoutTests

Skip service workers tests on Windows.

Unreviewed test gardening.

• platform/win/TestExpectations:

12:05 PM Changeset in webkit [221264] by Matt Lewis

• 2 edits in trunk/LayoutTests

Fixed expectations for http/tests/loading/basic-auth-remove-credentials.html by removing double expectations

Unreviewed test gardening.

• platform/mac-wk2/TestExpectations:

11:40 AM Changeset in webkit [221263] by Ryan Haddad

• 3 edits in trunk/LayoutTests

Rebaseline js/dom/global-constructors-attributes.html after r221209.

Unreviewed test gardening..

• platform/mac-highsierra-wk1/js/dom/global-constructors-attributes-expected.txt:
• platform/mac-highsierra/js/dom/global-constructors-attributes-expected.txt:

11:40 AM WebKitIDL edited by Konstantin Tokarev

JSCustomSetter -> CustomSetter (diff)

11:26 AM WebKitIDL edited by Konstantin Tokarev

Remove uses of obsolete module MODULE_NAME { } blocks which were … (diff)

11:21 AM WebKitIDL edited by Konstantin Tokarev

Remove mentions of CPP bindings which are long gone (diff)

11:20 AM Changeset in webkit [221262] by achristensen@apple.com

• 4 edits in trunk/Source/WebKit

Add WKUIDelegatePrivate equivalent of WKPageUIClient's didExceedBackgroundResourceLimitWhileInForeground
​https://bugs.webkit.org/show_bug.cgi?id=176028
<rdar://problem/29270035>

Reviewed by Andy Estes.

An API test for this did not succeed with either the memory or CPU limit calls,
possibly because the app must be in the foreground for this call to be made.

• UIProcess/API/Cocoa/WKUIDelegatePrivate.h:
• UIProcess/Cocoa/UIDelegate.h:
• UIProcess/Cocoa/UIDelegate.mm:

(WebKit::UIDelegate::setDelegate):
(WebKit::toWKResourceLimit):
(WebKit::UIDelegate::UIClient::didExceedBackgroundResourceLimitWhileInForeground):

10:31 AM WebKitGTK/Gardening/Calendar edited by Michael Catanzaro

(diff)

10:30 AM WebKitGTK/Gardening/Calendar edited by Michael Catanzaro

(diff)

9:52 AM Changeset in webkit [221261] by commit-queue@webkit.org

• 5 edits
  1 delete in trunk/LayoutTests

Fix document-create-touch.html.
​https://bugs.webkit.org/show_bug.cgi?id=172813

Patch by Ms2ger <​Ms2ger@igalia.com> on 2017-08-28
Reviewed by Michael Catanzaro.

The document.createTouch() call is supposed to throw an exception (as
defined by WebIDL). It has been doing this since r203941, but this
wasn't noticed because the entire fast/events/touch folder is skipped
on mac, ios and win.

• fast/events/touch/document-create-touch-expected.txt:
• fast/events/touch/document-create-touch.html:
• platform/gtk/TestExpectations:
• platform/gtk/fast/events/touch/document-create-touch-expected.txt: Removed.
• platform/wpe/TestExpectations:

9:37 AM Changeset in webkit [221260] by clopez@igalia.com

• 3 edits
  1 move in trunk/Source/WebCore

[GTK] [WPE] Rename EventHandlerGlib to EventHandlerGLib
​https://bugs.webkit.org/show_bug.cgi?id=175864

Unreviewed cosmetic follow-up patch after r221075.

No new tests. No change in behavior.

• PlatformGTK.cmake:
• PlatformWPE.cmake:
• platform/glib/EventHandlerGLib.cpp: Renamed from Source/WebCore/platform/glib/EventHandlerGlib.cpp.

(WebCore::EventHandler::tabsToAllFormControls const):
(WebCore::EventHandler::focusDocumentView):
(WebCore::EventHandler::passWidgetMouseDownEventToWidget):
(WebCore::EventHandler::passMouseDownEventToWidget):
(WebCore::EventHandler::eventActivatedView const):
(WebCore::EventHandler::widgetDidHandleWheelEvent):
(WebCore::EventHandler::createDraggingDataTransfer const):
(WebCore::EventHandler::passMousePressEventToSubframe):
(WebCore::EventHandler::passMouseMoveEventToSubframe):
(WebCore::EventHandler::passMouseReleaseEventToSubframe):
(WebCore::EventHandler::accessKeyModifiers):
(WebCore::EventHandler::shouldTurnVerticalTicksIntoHorizontal const):

8:54 AM Changeset in webkit [221259] by Ryan Haddad

• 2 edits in branches/safari-604.1.38.0-branch/Tools

Cherry-pick r221117.

8:50 AM Changeset in webkit [221258] by Ryan Haddad

• 4 edits in trunk/LayoutTests

Rebaseline js/dom/global-constructors-attributes.html after r221209.

Unreviewed test gardening.

• platform/mac-elcapitan-wk2/js/dom/global-constructors-attributes-expected.txt:
• platform/mac-wk1/js/dom/global-constructors-attributes-expected.txt:
• platform/mac/js/dom/global-constructors-attributes-expected.txt:

8:29 AM Changeset in webkit [221257] by Michael Catanzaro

• 4 edits
  1 add in trunk/LayoutTests

Unreviewed GTK/WPE test gardening

• platform/gtk/TestExpectations:
• platform/gtk/compositing/iframes/compositing-for-scrollable-iframe-expected.txt: Added.
• platform/gtk/js/dom/global-constructors-attributes-expected.txt:
• platform/wpe/js/dom/global-constructors-attributes-expected.txt:

7:38 AM Changeset in webkit [221256] by Carlos Garcia Campos

• 10 edits in releases/WebKitGTK/webkit-2.18/Source/JavaScriptCore

Merge r221018 - We are using valueProfileForBytecodeOffset when there may not be a value profile
​https://bugs.webkit.org/show_bug.cgi?id=175812

Reviewed by Michael Saboff.

This patch uses the type system to aid the code around CodeBlock's ValueProfile
accessor methods. valueProfileForBytecodeOffset used to return ValueProfile*,
so there were callers of this that thought it could return nullptr when there
was no such ValueProfile. This was not the case, it always returned a non-null
pointer. This patch changes valueProfileForBytecodeOffset to return ValueProfile&
and adds a new tryGetValueProfileForBytecodeOffset method that returns ValueProfile*
and does the right thing if there is no such ValueProfile.

This patch also changes the other ValueProfile accessors on CodeBlock to
return ValueProfile& instead of ValueProfile*. Some callers handled the null
case unnecessarily, and using the type system to specify the result can't be
null removes these useless branches.

• bytecode/CodeBlock.cpp:

(JSC::CodeBlock::updateAllPredictionsAndCountLiveness):
(JSC::CodeBlock::dumpValueProfiles):
(JSC::CodeBlock::tryGetValueProfileForBytecodeOffset):
(JSC::CodeBlock::valueProfileForBytecodeOffset):
(JSC::CodeBlock::validate):

• bytecode/CodeBlock.h:

(JSC::CodeBlock::valueProfileForArgument):
(JSC::CodeBlock::valueProfile):
(JSC::CodeBlock::valueProfilePredictionForBytecodeOffset):
(JSC::CodeBlock::getFromAllValueProfiles):

• dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::handleInlining):

• dfg/DFGGraph.cpp:

(JSC::DFG::Graph::methodOfGettingAValueProfileFor):

• dfg/DFGPredictionInjectionPhase.cpp:

(JSC::DFG::PredictionInjectionPhase::run):

• jit/JIT.h:
• jit/JITInlines.h:

(JSC::JIT::emitValueProfilingSite):

• profiler/ProfilerBytecodeSequence.cpp:

(JSC::Profiler::BytecodeSequence::BytecodeSequence):

• tools/HeapVerifier.cpp:

(JSC::HeapVerifier::validateJSCell):

6:55 AM Changeset in webkit [221255] by Carlos Garcia Campos

• 17 edits
  2 adds in trunk/Source

WebDriver: implement screen capture commands
​https://bugs.webkit.org/show_bug.cgi?id=174615

Reviewed by Brian Burg.

Source/WebDriver:

Implement takeScreenshot and takeElementScreenshot commands.

19. Screen Capture.

​https://w3c.github.io/webdriver/webdriver-spec.html#screen-capture

• CommandResult.cpp:

(WebDriver::CommandResult::CommandResult): Handle ScreenshotError protocol error.
(WebDriver::CommandResult::httpStatusCode const): Add UnableToCaptureScreen.
(WebDriver::CommandResult::errorString const): Ditto.

• CommandResult.h:
• Session.cpp:

(WebDriver::Session::takeScreenshot):

• Session.h:
• WebDriverService.cpp:

(WebDriver::WebDriverService::takeScreenshot):
(WebDriver::WebDriverService::takeElementScreenshot):

• WebDriverService.h:

Source/WebKit:

Extend takeScreenshot command to optionally take a screenshot of an element. When no element is provided, the
screenshot is taken from the page visible area.

• PlatformGTK.cmake: Add WebAutomationSessionCairo.cpp to compilation.
• PlatformWPE.cmake: Ditto.
• UIProcess/Automation/Automation.json: Add ScreenshotError and several optional parameters to takeScreenshot.
• UIProcess/Automation/WebAutomationSession.cpp:

(WebKit::WebAutomationSession::takeScreenshot): Receive optional frame, node and scrollIntoView that are
checked and passed to the web process.

• UIProcess/Automation/WebAutomationSession.h:
• UIProcess/Automation/cairo/WebAutomationSessionCairo.cpp: Added.

(WebKit::WebAutomationSession::platformGetBase64EncodedPNGData): Cairo implementation.

• UIProcess/Automation/gtk/WebAutomationSessionGtk.cpp:
• WebProcess/Automation/WebAutomationSessionProxy.cpp:

(WebKit::snapshotRectForScreenshot): Helper to get the rectangle to be used for a screenshot.
(WebKit::WebAutomationSessionProxy::takeScreenshot): If a node handle is provided take the snapshot using the
element rectangle, otherwise use the page visible content rectangle.

• WebProcess/Automation/WebAutomationSessionProxy.h:
• WebProcess/Automation/WebAutomationSessionProxy.messages.in: Update TakeSnapshot message.

6:39 AM Changeset in webkit [221254] by Carlos Garcia Campos

• 2 edits in releases/WebKitGTK/webkit-2.18/Source/WebCore

Merge r221008 - GLContext: zero-initialize the GLContext pointer in ThreadGlobalGLContext
​https://bugs.webkit.org/show_bug.cgi?id=175819

Reviewed by Xabier Rodriguez-Calvar.

• platform/graphics/GLContext.cpp: The ThreadGlobalGLContext object is

allocated on heap, so the embedded GLContext pointer can contain a
non-null value that can cause problems when e.g. checking for a current
GLContext on some specific thread on which a GLContext hasn't yet been
made current. Zero-initializing this pointer will avoid false positives
that can occur in these circumstances.

6:38 AM Changeset in webkit [221253] by Carlos Garcia Campos

• 3 edits
  1 move
  1 add in releases/WebKitGTK/webkit-2.18/Source/WebKit

Merge r221007 - [GTK][WPE] Rename StorageProcessMainGtk.cpp to StorageProcessMainGLib.cpp
​https://bugs.webkit.org/show_bug.cgi?id=175814

Reviewed by Gyuyoung Kim.

Both GTK+ and WPE ports already compile the StorageProcessMainGtk.cpp
file, but it should be renamed to StorageProcessMainGLib and moved into
the StorageProcess/glib/ directory.

• PlatformGTK.cmake:
• PlatformWPE.cmake:
• StorageProcess/glib/StorageProcessMainGLib.cpp: Renamed from Source/WebKit/StorageProcess/gtk/StorageProcessMainGtk.cpp.

6:30 AM Changeset in webkit [221252] by Carlos Garcia Campos

• 5 edits in releases/WebKitGTK/webkit-2.18/Source/WebCore

Merge r220988 - Cleanup TextPainter
​https://bugs.webkit.org/show_bug.cgi?id=175782

Reviewed by Myles C. Maxfield.

Remove redundant mention of "text" in the name of TextPainter member functions, add separate
setters for selection and non-selection shadows, and do some other minor cleanups.

• rendering/InlineTextBox.cpp:

(WebCore::InlineTextBox::paint): Update code for renamed functions.

• rendering/SimpleLineLayoutFunctions.cpp:

(WebCore::SimpleLineLayout::paintFlow): Ditto.

• rendering/TextPainter.cpp: Include ShadowData.h.

(WebCore::ShadowApplier::ShadowApplier): Use C++11 brace-initialization syntax.
(WebCore::ShadowApplier::isLastShadowIteration): Moved from TextPainter.h.
(WebCore::ShadowApplier::shadowIsCompletelyCoveredByText): Ditto.
(WebCore::TextPainter::paintTextOrEmphasisMarks): Renamed; formerly named drawTextOrEmphasisMarks.
(WebCore::TextPainter::paintTextWithShadows): Update code for renamed functions.
(WebCore::TextPainter::paintRange): Renamed; formerly named paintTextInRange.
(WebCore::TextPainter::paint): Renamed; formerly named paintText.
(WebCore::TextPainter::drawTextOrEmphasisMarks): Renamed to paintTextOrEmphasisMarks() to match
the naming convention of all the other paint functions in this class.
(WebCore::TextPainter::paintTextInRange): Renamed to paintRange.
(WebCore::TextPainter::paintText): Renamed to paint.

• rendering/TextPainter.h: Forward declare ShadowData.

(WebCore::TextPainter::setStyle): Renamed; formerly named setTextPaintStyle.
(WebCore::TextPainter::setSelectionStyle): Renamed; formerly named setSelectionPaintStyle.
(WebCore::TextPainter::setShadow): Added.
(WebCore::TextPainter::setSelectionShadow): Added.
(WebCore::TextPainter::setEmphasisMark): Renamed; formerly named addEmphasis.
(WebCore::TextPainter::setTextPaintStyle): Renamed to setStyle.
(WebCore::TextPainter::setSelectionPaintStyle): Renamed to setSelectionStyle.
(WebCore::TextPainter::addEmphasis): Renamed to setEmphasisMark.
(WebCore::TextPainter::addTextShadow): Split functionality into setShadow and setSelectionShadow.
(WebCore::ShadowApplier::isLastShadowIteration): Moved to TextPainter.cpp.
(WebCore::ShadowApplier::shadowIsCompletelyCoveredByText): Ditto.

6:27 AM Changeset in webkit [221251] by Carlos Garcia Campos

• 4 edits
  1 copy in releases/WebKitGTK/webkit-2.18/LayoutTests

Merge r220985 - Stop media/video-controls-toggling.html from timing out.
​https://bugs.webkit.org/show_bug.cgi?id=116266

Patch by Ms2ger <​Ms2ger@gmail.com> on 2017-08-21
Reviewed by Dean Jackson.

Use getComputedStyle to check the display property. Element::style only
contains properties set in the style attribute, but the display property
is set through CSS using the 'hidden' class.

• media/video-controls-toggling-expected.txt:
• media/video-controls-toggling.html:
• platform/gtk/TestExpectations:
• platform/gtk/media/video-controls-toggling-expected.txt: Copied from LayoutTests/media/video-controls-toggling-expected.txt. I'm not sure where the console message comes from, but it seems to be in the GTK-specific code.

6:22 AM Changeset in webkit [221250] by Carlos Garcia Campos

• 4 edits in releases/WebKitGTK/webkit-2.18

Merge r220982 - StringView could use a function to strip leading/trailing characters without allocation
​https://bugs.webkit.org/show_bug.cgi?id=175757

Reviewed by Darin Adler.

Source/WTF:

There are many places in WebCore/WebKit that we call functions like,
WebCore::stripLeadingAndTrailingHTMLSpaces, or String::stripWhiteSpace() only to use
the allocated String as a temporary for either another transformation or a comparison.
Now that we have StringView, we can avoid that extra allocation, by having returning a
StringView substring in these scenarios.

For instance, the check (from ScriptElement.cpp:287):

if (!stripLeadingAndTrailingHTMLSpaces(sourceURL).isEmpty()) {

...

}

currently allocates a string just to make this check. With a new
stripLeadingAndTrailingHTMLSpaces such as:

StringView stripLeadingAndTrailingHTMLSpaces(StringView stringView)
{

return stringView.stripLeadingAndTrailingMatchedCharacters([] (auto c) {

return isHTMLSpace(c);

});

}

We could instead have exact same code from ScriptElement.cpp now avoid an allocation.

• wtf/text/StringView.h:

(WTF::StringView::stripLeadingAndTrailingMatchedCharacters):

Tools:

• TestWebKitAPI/Tests/WTF/StringView.cpp:

Add tests for StringView::stripLeadingAndTrailingMatchedCharacters().

5:46 AM Changeset in webkit [221249] by Carlos Garcia Campos

• 2 edits in releases/WebKitGTK/webkit-2.18/Source/WebCore

Merge r220978 - [GTK][WPE][GSTREAMER_GL] Overriden virtual function not marked “override” in MediaPlayerPrivateGStreamerBase.h
​https://bugs.webkit.org/show_bug.cgi?id=175780

Reviewed by Konstantin Tokarev.

• platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.h: Add missing "override" qualifier.

5:44 AM Changeset in webkit [221248] by Carlos Garcia Campos

• 5 edits in releases/WebKitGTK/webkit-2.18/LayoutTests

Merge r220967 - [GTK][WPE] Rebaseline tests with list item markers.
​https://bugs.webkit.org/show_bug.cgi?id=175771

Unreviewed test gardening.

The output was changed in r220858 and rebaselined for ios and mac only.
They're changes in render tree dumps that don't affect rendering.

Patch by Ms2ger <​Ms2ger@igalia.com> on 2017-08-21

• platform/gtk/css2.1/t0805-c5520-brdr-b-01-e-expected.txt:
• platform/gtk/fast/doctypes/002-expected.txt:
• platform/gtk/fast/lists/marker-before-empty-inline-expected.txt:
• platform/wpe/css2.1/t0805-c5520-brdr-b-01-e-expected.txt:

5:43 AM Changeset in webkit [221247] by Carlos Garcia Campos

• 2 edits in releases/WebKitGTK/webkit-2.18/Source/WebKit

Merge r220963 - MemoryCache::setCapacities assertion failure maxDeadBytes <= totalBytes
​https://bugs.webkit.org/show_bug.cgi?id=175571

Patch by Charlie Turner <​cturner@igalia.com> on 2017-08-21
Reviewed by Antti Koivisto.

• Shared/CacheModel.cpp:

(WebKit::calculateMemoryCacheSizes): Ensure cacheTotalCapacity is
set to a reasonable value even in low-memory environments.

5:32 AM Changeset in webkit [221246] by Carlos Garcia Campos

• 2 edits in trunk/Source/WebKit

Automation: takeScreenshot should use the visible content rect not the document rect
​https://bugs.webkit.org/show_bug.cgi?id=175665

Reviewed by Brian Burg.

According to the spec, we should get the toplevel browsing context document rectangle and take a screenshot of
it using the current viewport width and height. We are currently using the document size.

19. Screen Capture.

​https://w3c.github.io/webdriver/webdriver-spec.html#dfn-draw-a-bounding-box-from-the-framebuffer

• WebProcess/Automation/WebAutomationSessionProxy.cpp:

(WebKit::WebAutomationSessionProxy::takeScreenshot): Use FrameView::visibleContentRect().

5:07 AM Changeset in webkit [221245] by Carlos Garcia Campos

• 8 edits in releases/WebKitGTK/webkit-2.18/Source/WebCore

Merge r220934 - Followup (r220289): RenderImageResourceStyleImage code clean up
​https://bugs.webkit.org/show_bug.cgi?id=175444

Patch by Said Abou-Hallawa <​sabouhallawa@apple.com> on 2017-08-18
Reviewed by Darin Adler.

RenderImageResourceStyleImage may be created with a StyleImage of type
StyleGeneratedImage. It may also be associated with a CachedImage which
is loaded through a source URL. In this case, adding and removing m_renderer
as a client of the CachedImage will be done through
RenderImageResource::setCachedImage().

RenderImageResource::setCachedImage() is already called from
ImageLoader::updateRenderer() when the CachedImage finishes loading. This
call adds m_renderer to the clients of the CachedImage.
RenderImageResource::setCachedImage() will also be called from
RenderImageResourceStyleImage::shutdown() via RenderImageResource::shutdown()
to remove m_renderer from the clients of CachedImage by passing a null pointer.

• rendering/RenderImage.cpp:

(WebCore::RenderImage::styleWillChange):

• rendering/RenderImageResource.cpp:

(WebCore::RenderImageResource::initialize):
(WebCore::RenderImageResource::shutdown):
(WebCore::RenderImageResource::setCachedImage):
(WebCore::RenderImageResource::resetAnimation):
(WebCore::RenderImageResource::image const):
(WebCore::RenderImageResource::setContainerSizeForRenderer):
(WebCore::RenderImageResource::imageSize const):
(WebCore::RenderImageResource::~RenderImageResource): Deleted.
(WebCore::RenderImageResource::errorOccurred const): Deleted.
(WebCore::RenderImageResource::imageHasRelativeWidth const): Deleted.
(WebCore::RenderImageResource::imageHasRelativeHeight const): Deleted.
(WebCore::RenderImageResource::intrinsicSize const): Deleted.
(WebCore::RenderImageResource::getImageSize const): Deleted.

• rendering/RenderImageResource.h:

(WebCore::RenderImageResource::initialize):
(WebCore::RenderImageResource::renderer const):
(WebCore::RenderImageResource::errorOccurred const):
(WebCore::RenderImageResource::imageHasRelativeWidth const):
(WebCore::RenderImageResource::imageHasRelativeHeight const):
(WebCore::RenderImageResource::imageSize const):
(WebCore::RenderImageResource::intrinsicSize const):
(WebCore::RenderImageResource::imagePtr const):

• rendering/RenderImageResourceStyleImage.cpp:

(WebCore::RenderImageResourceStyleImage::initialize):
(WebCore::RenderImageResourceStyleImage::shutdown):
(WebCore::RenderImageResourceStyleImage::image const):
(WebCore::RenderImageResourceStyleImage::setContainerSizeForRenderer):
(WebCore::RenderImageResourceStyleImage::~RenderImageResourceStyleImage): Deleted.

• rendering/RenderImageResourceStyleImage.h:
• rendering/RenderSnapshottedPlugIn.cpp:

(WebCore::RenderSnapshottedPlugIn::RenderSnapshottedPlugIn):

• rendering/svg/RenderSVGImage.cpp:

(WebCore::RenderSVGImage::RenderSVGImage):

5:02 AM Changeset in webkit [221244] by Carlos Garcia Campos

• 3 edits in releases/WebKitGTK/webkit-2.18/Source/WebKit

Merge r220931 - REGRESSION (r220601): Crash when closing google doc after switching the order of tabs in safari
​https://bugs.webkit.org/show_bug.cgi?id=175721
<rdar://problem/33928369>

Reviewed by Geoffrey Garen.

Make sure WebProcess::markAllLayersVolatile() does not call WTFMove() multiple times
on the same completion handler. Use a RefCounter to hold on to the completion handler
and make sure the handler gets called when the RefCounter's value becomes 0.

• WebProcess/WebProcess.cpp:

(WebKit::WebProcess::cancelPrepareToSuspend):
(WebKit::WebProcess::markAllLayersVolatile):
(WebKit::WebProcess::cancelMarkAllLayersVolatile):

• WebProcess/WebProcess.h:

4:57 AM Changeset in webkit [221243] by Carlos Garcia Campos

• 8 edits
  2 adds in releases/WebKitGTK/webkit-2.18/Source/WebCore

Merge r220916 - Factor render tree mutation code from RenderListItem to RenderTreeUpdater
​https://bugs.webkit.org/show_bug.cgi?id=175718

Reviewed by Andreas Kling.

We already stopped doing layout time mutations. We can now move the code out too.

• WebCore.xcodeproj/project.pbxproj:
• rendering/RenderListItem.cpp:

(WebCore::isHTMLListElement):
(WebCore::getParentOfFirstLineBox): Deleted.
(WebCore::firstNonMarkerChild): Deleted.
(WebCore::RenderListItem::updateMarkerRenderer): Deleted.

Moved to RenderTreeUpdater::ListItem.

• rendering/RenderListItem.h:
• rendering/RenderListMarker.cpp:

(WebCore::RenderListMarker::willBeDestroyed):

• rendering/TextAutoSizing.cpp:

(WebCore::TextAutoSizingValue::adjustTextNodeSizes):

• style/RenderTreeUpdater.cpp:

(WebCore::RenderTreeUpdater::pushParent):
(WebCore::RenderTreeUpdater::popParent):
(WebCore::RenderTreeUpdater::updateBeforeDescendants):
(WebCore::RenderTreeUpdater::updateAfterDescendants):

Factor pre/post update into functions.

(WebCore::RenderTreeUpdater::updateBeforeOrAfterPseudoElement):

• style/RenderTreeUpdater.h:
• style/RenderTreeUpdaterListItem.cpp: Added.

Mutation functions move here.

(WebCore::getParentOfFirstLineBox):
(WebCore::firstNonMarkerChild):
(WebCore::RenderTreeUpdater::ListItem::updateMarker):

• style/RenderTreeUpdaterListItem.h: Added.

4:53 AM Changeset in webkit [221242] by Carlos Garcia Campos

• 4 edits in releases/WebKitGTK/webkit-2.18

Merge r220910 - [GTK] Show controls if a video element isn't allowed to play inline.
​https://bugs.webkit.org/show_bug.cgi?id=141705

Patch by Ms2ger <​Ms2ger@gmail.com> on 2017-08-18
Reviewed by Xabier Rodriguez-Calvar.

Source/WebCore:

Test: covered by media/video-fullscreeen-only-controls.html [sic].

• Modules/mediacontrols/mediaControlsGtk.js:

(ControllerGtk.prototype.shouldHaveControls):

LayoutTests:

• platform/gtk/TestExpectations: enable test for this case.

4:52 AM Changeset in webkit [221241] by Carlos Garcia Campos

• 7 edits in trunk/Source/WebDriver

WebDriver: implement cookies commands
​https://bugs.webkit.org/show_bug.cgi?id=174613

Reviewed by Brian Burg.

Add cookies commands.

16. Cookies.

​https://w3c.github.io/webdriver/webdriver-spec.html#cookies

• CommandResult.cpp:

(WebDriver::CommandResult::httpStatusCode const): Add NoSuchCookie error.
(WebDriver::CommandResult::errorString const): Ditto.

• CommandResult.h:
• Session.cpp:

(WebDriver::parseAutomationCookie): Parse JSON cookie object returned by automation and convert it to a Cookie struct.
(WebDriver::builtAutomationCookie): Build a JSON cookie object as expected by automation from a Cookie struct.
(WebDriver::serializeCookie): Serialize a Cookie struct into a JSON cookie object according to the WebDriver spec.
(WebDriver::Session::getAllCookies):
(WebDriver::Session::getNamedCookie):
(WebDriver::Session::addCookie):
(WebDriver::Session::deleteCookie):
(WebDriver::Session::deleteAllCookies):

• Session.h:
• WebDriverService.cpp:

(WebDriver::WebDriverService::getAllCookies):
(WebDriver::WebDriverService::getNamedCookie):
(WebDriver::deserializeCookie):
(WebDriver::WebDriverService::addCookie):
(WebDriver::WebDriverService::deleteCookie):
(WebDriver::WebDriverService::deleteAllCookies):

• WebDriverService.h:

4:46 AM Changeset in webkit [221240] by commit-queue@webkit.org

• 2 edits in trunk/Tools

Ensure that the alert function is called in TestWebExtensions.
​https://bugs.webkit.org/show_bug.cgi?id=175880

Patch by Ms2ger <​Ms2ger@gmail.com> on 2017-08-28
Reviewed by Carlos Garcia Campos.

The test relied on a bug in the HTMLDocument JavaScript bindings: when calling
document.open() with three arguments, it would call any function set as the
"open" property on the window object, rather than just the real Window::open()
method. This bug was fixed by the removal of custom bindings for HTMLDocument
in r218437. As a result, the test no longer called alert(), which caused it to
fail.

Instead, call the window.open() function directly.

• TestWebKitAPI/Tests/WebKitGLib/TestWebExtensions.cpp:

(testWebExtensionIsolatedWorld):

4:23 AM Changeset in webkit [221239] by Michael Catanzaro

• 2 edits
  1 delete in trunk/LayoutTests

New baseline for insecure-audio-video-in-main-frame.html should apply to all ports

The global baseline was never updated because the test has been failing on macOS.

• http/tests/security/mixedContent/insecure-audio-video-in-main-frame-expected.txt:
• platform/gtk/http/tests/security/mixedContent/insecure-audio-video-in-main-frame-expected.txt: Removed.

4:18 AM Changeset in webkit [221238] by Carlos Garcia Campos

• 3 edits in trunk/Source/WebKit

[GTK][WPE] ASSERTION FAILED: !isOpen() in WebKit::IconDatabase::~IconDatabase()
​https://bugs.webkit.org/show_bug.cgi?id=175719

Reviewed by Michael Catanzaro.

This is happening always when running /webkit2/WebKitFaviconDatabase/favicon-database-test in debug builds. The
last step we do is removing all icons, then the test finishes, which destroys the WebKitFaviconDatabase object
that closes the icon database on dispose. The problem is that removing all icons schedules a main thread
notification and IconDatabase is not considered closed until all main thread callbacks have been dispatched. This
is never going to happen in the test, because the main loop is no longer running at that point. I don't think
it's worth it to consider the database open while main thread callbacks are pending, they are just notifications
and the client is no longer insterested on them afer closing the database. I think it's bettter and simpler to
simply cancel the pending callbacks on database close. That ensures that isOpen() after close() is always
false. This patch adds a helper private class to schedule notifications to the main thread that can be cancelled
on database close. It also removes the didClose() notification because it was unused and because it's pointless
now that we know the database is closed after close().

• UIProcess/API/glib/IconDatabase.cpp:

(WebKit::IconDatabase::open): Mark the main thread notifier as active.
(WebKit::IconDatabase::close): Mark the main thread notifier as not active.
(WebKit::IconDatabase::IconDatabase): Remove m_mainThreadCallbackCount initialization.
(WebKit::IconDatabase::isOpen const): Do what isOpenBesidesMainThreadCallbacks() used to do.
(WebKit::IconDatabase::removeAllIconsOnThread): Remove the notification because it's currently unused.
(WebKit::IconDatabase::dispatchDidImportIconURLForPageURLOnMainThread): Use MainThreadNotifier.
(WebKit::IconDatabase::dispatchDidImportIconDataForPageURLOnMainThread): Ditto.
(WebKit::IconDatabase::dispatchDidFinishURLImportOnMainThread): Ditto.
(WebKit::IconDatabase::isOpenBesidesMainThreadCallbacks const): Deleted.
(WebKit::IconDatabase::checkClosedAfterMainThreadCallback): Deleted.
(WebKit::IconDatabase::dispatchDidRemoveAllIconsOnMainThread): Deleted.

• UIProcess/API/glib/IconDatabase.h:

(WebKit::IconDatabaseClient::didChangeIconForPageURL):
(WebKit::IconDatabaseClient::didFinishURLImport):
(WebKit::IconDatabase::MainThreadNotifier::MainThreadNotifier):
(WebKit::IconDatabase::MainThreadNotifier::setActive):
(WebKit::IconDatabase::MainThreadNotifier::notify):
(WebKit::IconDatabase::MainThreadNotifier::stop):
(WebKit::IconDatabase::MainThreadNotifier::timerFired):
(WebKit::IconDatabaseClient::didRemoveAllIcons): Deleted.
(WebKit::IconDatabaseClient::didClose): Deleted.

4:02 AM Changeset in webkit [221237] by commit-queue@webkit.org

• 2 edits
  2 adds in trunk/LayoutTests

[GTK] Rebaseline insecure-audio-video-in-main-frame.html.
​https://bugs.webkit.org/show_bug.cgi?id=142482

Unreviewed test gardening.

The test is failing due to a different console message. It seems better
to add a platform-specific baseline so we can catch actual failures.

Patch by Ms2ger <​Ms2ger@igalia.com> on 2017-08-28

• platform/gtk/TestExpectations:
• platform/gtk/http/tests/security/mixedContent/insecure-audio-video-in-main-frame-expected.txt: Added.

3:20 AM Changeset in webkit [221236] by commit-queue@webkit.org

• 2 edits in trunk/LayoutTests

[GTK] Enable userAgentShadowDOM tests.
​https://bugs.webkit.org/show_bug.cgi?id=176015

Unreviewed test gardening.

Patch by Ms2ger <​Ms2ger@igalia.com> on 2017-08-28

• platform/gtk/TestExpectations:

1:16 AM Changeset in webkit [221235] by zandobersek@gmail.com

• 21 edits in trunk/Source/WebCore

[WebCrypto] Push WorkQueue dispatches for AES algorithms into shared code
​https://bugs.webkit.org/show_bug.cgi?id=175539

Reviewed by Sam Weinig.

Push the WorkQueue dispatch code and other code duplicated between the
Mac and libgcrypt implementations of Web Crypto into the shared layer.
This patch focuses on the AES-based algorithms.

Functions with platform-specific implementations that are invoked from
these asynchronous dispatches are made static and return an ExceptionOr
value. CryptoAlgorithmParameters objects are passed through non-const
references because data getters could lazily construct the underlying
Vector objects. CryptoKey objects are passed through const references.
Implementations can then manually retrieve and further validate any key
or parameter data, as required for that specific implementation. Input
data is passed through const references to the original Vector objects.

No new tests -- no changes in behavior that's covered by existing tests.

• crypto/algorithms/CryptoAlgorithmAES_CBC.cpp:

(WebCore::CryptoAlgorithmAES_CBC::encrypt):
(WebCore::CryptoAlgorithmAES_CBC::decrypt):

• crypto/algorithms/CryptoAlgorithmAES_CBC.h:
• crypto/algorithms/CryptoAlgorithmAES_CFB.cpp:

(WebCore::CryptoAlgorithmAES_CFB::encrypt):
(WebCore::CryptoAlgorithmAES_CFB::decrypt):

• crypto/algorithms/CryptoAlgorithmAES_CFB.h:
• crypto/algorithms/CryptoAlgorithmAES_CTR.cpp:

(WebCore::CryptoAlgorithmAES_CTR::encrypt):
(WebCore::CryptoAlgorithmAES_CTR::decrypt):

• crypto/algorithms/CryptoAlgorithmAES_CTR.h:
• crypto/algorithms/CryptoAlgorithmAES_GCM.cpp:

(WebCore::CryptoAlgorithmAES_GCM::encrypt):
(WebCore::CryptoAlgorithmAES_GCM::decrypt):

• crypto/algorithms/CryptoAlgorithmAES_GCM.h:
• crypto/algorithms/CryptoAlgorithmAES_KW.cpp:

(WebCore::CryptoAlgorithmAES_KW::wrapKey):
(WebCore::CryptoAlgorithmAES_KW::unwrapKey):

• crypto/algorithms/CryptoAlgorithmAES_KW.h:
• crypto/gcrypt/CryptoAlgorithmAES_CBCGCrypt.cpp:

(WebCore::CryptoAlgorithmAES_CBC::platformEncrypt):
(WebCore::CryptoAlgorithmAES_CBC::platformDecrypt):

• crypto/gcrypt/CryptoAlgorithmAES_CFBGCrypt.cpp:

(WebCore::CryptoAlgorithmAES_CFB::platformEncrypt):
(WebCore::CryptoAlgorithmAES_CFB::platformDecrypt):

• crypto/gcrypt/CryptoAlgorithmAES_CTRGCrypt.cpp:

(WebCore::CryptoAlgorithmAES_CTR::platformEncrypt):
(WebCore::CryptoAlgorithmAES_CTR::platformDecrypt):

• crypto/gcrypt/CryptoAlgorithmAES_GCMGCrypt.cpp:

(WebCore::gcryptEncrypt):
(WebCore::gcryptDecrypt):
(WebCore::CryptoAlgorithmAES_GCM::platformEncrypt):
(WebCore::CryptoAlgorithmAES_GCM::platformDecrypt):

• crypto/gcrypt/CryptoAlgorithmAES_KWGCrypt.cpp:

(WebCore::CryptoAlgorithmAES_KW::platformWrapKey):
(WebCore::CryptoAlgorithmAES_KW::platformUnwrapKey):

• crypto/mac/CryptoAlgorithmAES_CBCMac.cpp:

(WebCore::CryptoAlgorithmAES_CBC::platformEncrypt):
(WebCore::CryptoAlgorithmAES_CBC::platformDecrypt):

• crypto/mac/CryptoAlgorithmAES_CFBMac.cpp:

(WebCore::CryptoAlgorithmAES_CFB::platformEncrypt):
(WebCore::CryptoAlgorithmAES_CFB::platformDecrypt):

• crypto/mac/CryptoAlgorithmAES_CTRMac.cpp:

(WebCore::CryptoAlgorithmAES_CTR::platformEncrypt):
(WebCore::CryptoAlgorithmAES_CTR::platformDecrypt):

• crypto/mac/CryptoAlgorithmAES_GCMMac.cpp:

(WebCore::CryptoAlgorithmAES_GCM::platformEncrypt):
(WebCore::CryptoAlgorithmAES_GCM::platformDecrypt):

• crypto/mac/CryptoAlgorithmAES_KWMac.cpp:

(WebCore::CryptoAlgorithmAES_KW::platformWrapKey):
(WebCore::CryptoAlgorithmAES_KW::platformUnwrapKey):

Aug 27, 2017:

10:12 PM Changeset in webkit [221234] by Wenson Hsieh

• 18 edits
  1 add in trunk

Picking an emoji via the emoji dialog (Ctrl+Cmd+Space) fires inconsistent beforeinput events.
​https://bugs.webkit.org/show_bug.cgi?id=170955
<rdar://problem/31697653>

Reviewed by Ryosuke Niwa.

Source/WebKit:

Currently, we insert text with TextEventInputAutocompletion as the text event input type if any text range to
replace was specified by the platform. Instead, limit this only to when the text replacement range is not empty.
This more closely matches the intention of the spec, which states that the "insertReplacementText" inputType
should be used when "[replacing] existing text by means of a spell checker, auto-correct or similar".

• WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::insertTextAsync):

Source/WebKitLegacy/mac:

Tweak -insertText: to pass TextEventInputAutocompletion to Editor::insertText when inserting text, if existing
text is being replaced.

• WebView/WebHTMLView.mm:

(-[WebHTMLView insertText:]):

Tools:

Replace UIScriptController.insertText with UIScriptController.replaceTextAtRange, and implement
replaceTextAtRange in WebKit1. See corresponding layout tests (input-event-insert-replacement.html and
before-input-prevent-insert-replacement.html) for more detail.

• DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
• DumpRenderTree/mac/AppKitTestSPI.h: Added.

Introduce an SPI header for private AppKit headers needed to support DumpRenderTree.

• DumpRenderTree/mac/UIScriptControllerMac.mm:

(WTR::UIScriptController::replaceTextAtRange):
(WTR::UIScriptController::insertText): Deleted.

• TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
• TestRunnerShared/UIScriptContext/UIScriptController.cpp:

(WTR::UIScriptController::replaceTextAtRange):
(WTR::UIScriptController::insertText): Deleted.

• TestRunnerShared/UIScriptContext/UIScriptController.h:
• WebKitTestRunner/mac/UIScriptControllerMac.mm:

(WTR::UIScriptController::replaceTextAtRange):
(WTR::UIScriptController::insertText): Deleted.

Replace UIScriptController.insertText with UIScriptController.replaceTextAtRange, which better describes the
behavior of this function.

LayoutTests:

Augments two existing layout tests to check for additional cases of inserting text with replacement ranges.
Also enables this test for WebKit1 on Mac. Both these tests are currently enabled only for WebKit2, and also only
check the case where we're replacing an existing non-empty range of text.

• fast/events/before-input-prevent-insert-replacement-expected.txt:
• fast/events/before-input-prevent-insert-replacement.html:
• fast/events/input-event-insert-replacement-expected.txt:
• fast/events/input-event-insert-replacement.html:

Tests for cases of replacing existing text ranges, and inserting text at a position.

• platform/mac-wk1/TestExpectations:
• resources/ui-helper.js:

Add a new UIHelper function to insert text at a given replacement range. This codepath is taken when selecting
an emoji using the emoji picker menu on Mac, and also when selecting a dead key option after holding down on a
vowel key.

(window.UIHelper.replaceTextAtRange):

6:22 PM Changeset in webkit [221233] by Wenson Hsieh

• 12 edits
  1 add in trunk

[iOS WK2] Web process crashes after changing selection to the end of the document when speaking a selection
​https://bugs.webkit.org/show_bug.cgi?id=176011
<rdar://problem/32614095>

Reviewed by Ryosuke Niwa.

Source/WebCore:

Adds a null check to visiblePositionForPositionWithOffset. This is a crash point for accessibility codepaths,
since indexForVisiblePosition is not guaranteed to set the given root outparam to a non-null value, yet
visiblePositionForIndex requires root to be non-null. This causes a crash when selecting some text, hitting
'Speak', and then changing the selection to somewhere near the end of the document, since accessibility code
will attempt to speak words at an offset past the end of the document. While this is a bug in and of itself, the
web process should still handle this case gracefully and not crash. To fix this, we simply bail and return a
null VisiblePosition if a root container node was not found.

Currently, visiblePositionForPositionWithOffset is implemented twice, in WebCore (AXObjectCache.cpp) and also in
WebKit (WebPageIOS.mm), as identical static functions. This patch moves this helper into Editing.cpp and removes
it from AXObjectCache and WebPageIOS.

Tests: AccessibilityTests.RectsForSpeakingSelectionBasic

AccessibilityTests.RectsForSpeakingSelectionWithLineWrapping
AccessibilityTests.RectsForSpeakingSelectionDoNotCrashWhenChangingSelection

• accessibility/AXObjectCache.cpp:

(WebCore::visiblePositionForPositionWithOffset): Deleted.

• editing/Editing.cpp:

(WebCore::visiblePositionForPositionWithOffset):

• editing/Editing.h:

Source/WebKit:

Adds an SPI hook to test accessibility codepaths when speaking selected content. This patch does some minor
refactoring by introducing _accessibilityRetrieveRectsAtSelectionOffset:withText:completionHandler:, which takes
and invokes a completion handler block. The existing _accessibilityRetrieveRectsAtSelectionOffset:withText:
method simply turns around and calls the former variant with nil as a completion handler.

• UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _accessibilityRetrieveRectsAtSelectionOffset:withText:completionHandler:]):

• UIProcess/API/Cocoa/WKWebViewPrivate.h:
• UIProcess/ios/WKContentViewInteraction.h:
• UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView _accessibilityRetrieveRectsAtSelectionOffset:withText:]):
(-[WKContentView _accessibilityRetrieveRectsAtSelectionOffset:withText:completionHandler:]):

• WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::visiblePositionForPositionWithOffset): Deleted.

Tools:

Introduces AccessibilityTests, and adds three new tests that traverse selection-rect-finding codepaths when
speaking selected content. See WebKit and WebCore ChangeLogs for more detail.

• TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
• TestWebKitAPI/Tests/ios/AccessibilityTestsIOS.mm: Added.

(-[WKWebView rectsAtSelectionOffset:withText:]):
(checkCGRectValueAtIndex):
(TestWebKitAPI::TEST):

9:12 AM Changeset in webkit [221232] by webkit@devinrousso.com

• 23 edits
  4 adds in trunk

Web Inspector: Record actions performed on WebGLRenderingContext
​https://bugs.webkit.org/show_bug.cgi?id=174483
<rdar://problem/34040722>

Reviewed by Matt Baker.

Source/JavaScriptCore:

• inspector/protocol/Recording.json:
• inspector/scripts/codegen/generator.py:

Add type and mapping for WebGL: "canvas-webgl" => CanvasWebGL

Source/WebCore:

Tests: inspector/canvas/recording-webgl.html

inspector/canvas/recording-webgl-snapshots.html

• bindings/js/CallTracerTypes.h:

Add types for WebGL parameters.

• bindings/scripts/CodeGeneratorJS.pm:

(GenerateAttributeSetterBodyDefinition):
(GenerateImplementationFunctionCall):
(GenerateCallTracerParameter):
Modify the generated code for CallTracingCallback so that optional/nullable types are only
dereferenced if they have a value.

• html/canvas/WebGLRenderingContext.idl:

Add CallTracingCallback to interface to record all API calls.

• inspector/InspectorCanvas.h:
• inspector/InspectorCanvas.cpp:

(WebCore::InspectorCanvas::resetRecordingData):
(WebCore::shouldSnapshotWebGLAction):
(WebCore::InspectorCanvas::recordAction):
(WebCore::InspectorCanvas::releaseInitialState):
(WebCore::InspectorCanvas::releaseFrames):
(WebCore::InspectorCanvas::appendActionSnapshotIfNeeded):
(WebCore::InspectorCanvas::getCanvasContentAsDataURL):
(WebCore::InspectorCanvas::buildInitialState):
(WebCore::InspectorCanvas::buildAction):
For all non-primitive WebGL objects, send a string corresponding to the object's name. The
value isn't needed since the preview will be generated by the toDataURL snapshots taken
after every visual action.

• inspector/InspectorCanvasAgent.cpp:

(WebCore::InspectorCanvasAgent::didFinishRecordingCanvasFrame):

• bindings/scripts/test/TestCallTracer.idl:
• bindings/scripts/test/JS/JSTestCallTracer.cpp:

(WebCore::jsTestCallTracerPrototypeFunctionTestOperationWithNullableArgumentBody):
(WebCore::jsTestCallTracerPrototypeFunctionTestOperationWithNullableVariantArgumentBody):
(WebCore::jsTestCallTracerPrototypeFunctionTestOperationWithNullableVariantArgument):
(WebCore::jsTestCallTracerPrototypeFunctionTestOperationWithOptionalVariantArgumentBody):
(WebCore::jsTestCallTracerPrototypeFunctionTestOperationWithOptionalVariantArgument):
(WebCore::jsTestCallTracerPrototypeFunctionTestOperationWithDefaultVariantArgumentBody):
(WebCore::jsTestCallTracerPrototypeFunctionTestOperationWithDefaultVariantArgument):

Source/WebInspectorUI:

• UserInterface/Models/Recording.js:

(WI.Recording):
(WI.Recording.fromPayload):
(WI.Recording.prototype.swizzle):
Add swizzle types for WebGL parameters.

• UserInterface/Models/RecordingAction.js:

(WI.RecordingAction):
(WI.RecordingAction.fromPayload):
(WI.RecordingAction.prototype.get snapshot):
(WI.RecordingAction.prototype.swizzle):
(WI.RecordingAction.prototype.toJSON):
Include an optional fourth parameter snapshot that will be sent for visual actions when
recording WebGL canvas contexts.

• UserInterface/Views/RecordingContentView.js:

(WI.RecordingContentView):
(WI.RecordingContentView.prototype.get navigationItems):
(WI.RecordingContentView.prototype.updateActionIndex):
(WI.RecordingContentView.prototype.shown):
(WI.RecordingContentView.prototype._generateContentCanvasWebGL):

• UserInterface/Views/RecordingContentView.css:

(.content-view:not(.tab).recording :matches(img, canvas)):
(.content-view:not(.tab).recording canvas): Deleted.
Instead of regenerating the canvas context in the WebInspector frontend, just display the
snapshot image for the last visual action.

• UserInterface/Views/CanvasContentView.js:

(WI.CanvasContentView):

• UserInterface/Views/RecordingActionTreeElement.js:

(WI.RecordingActionTreeElement._generateDOM):

LayoutTests:

• inspector/canvas/recording-webgl-expected.txt: Added.
• inspector/canvas/recording-webgl.html: Added.

• inspector/canvas/recording-webgl-snapshots-expected.txt: Added.
• inspector/canvas/recording-webgl-snapshots.html: Added.

Created separate test for checking that snapshots differ so that each test doesn't interfere
with the results of the other tests.

• inspector/canvas/recording-2d-expected.html:
• inspector/canvas/recording-2d.html:

Drive by: change naming to match inspector/canvas/recording-webgl.html.