Context Navigation

← Previous Period
Next Period →

Timeline

Sep 1, 2017:

7:33 PM Changeset in webkit [221513] by fpizlo@apple.com

5 edits
4 adds in trunk/Tools

WSL should check unreachable code and no returns
https://bugs.webkit.org/show_bug.cgi?id=176262

Reviewed by Myles Maxfield.

This adds phases to check whether non-void functions return and whether there is any code after
a return in any block. Added tests for simple versions of both of those things. We cannot add
more complex versions until we support control flow statements.

WebGPUShadingLanguageRI/All.js:
WebGPUShadingLanguageRI/CheckReturns.js: Added.

(checkReturns):

WebGPUShadingLanguageRI/CheckUnreachableCode.js: Added.

(checkUnreachableCode):

WebGPUShadingLanguageRI/Parse.js:

(parseReturn):

WebGPUShadingLanguageRI/Prepare.js:

(prepare):

WebGPUShadingLanguageRI/ReturnChecker.js: Added.

(ReturnChecker.prototype.visitFuncDef):
(ReturnChecker.prototype.visitBlock):
(ReturnChecker.prototype.visitReturn):
(ReturnChecker):

WebGPUShadingLanguageRI/Test.js:

(TEST_simpleNoReturn):

WebGPUShadingLanguageRI/UnreachableCodeChecker.js: Added.

(UnreachableCodeChecker.prototype.visitBlock):
(UnreachableCodeChecker):

6:38 PM Changeset in webkit [221512] by weinig@apple.com

21 edits in trunk

DOMMatrix and DOMMatrixReadOnly should be available in workers
https://bugs.webkit.org/show_bug.cgi?id=176255

Reviewed by Simon Fraser.

LayoutTests/imported/w3c:

web-platform-tests/css/geometry-1/DOMMatrix-css-string.worker-expected.txt:
web-platform-tests/css/geometry-1/interfaces.worker-expected.txt:

Update test results.

Source/WebCore:

WebCore.xcodeproj/project.pbxproj:

Add GlobalPerformance.idl to the project. It was missing.

bindings/scripts/CodeGeneratorJS.pm:

(IsAlwaysExposedOnInterface):
(NeedsRuntimeCheck):
(GenerateRuntimeEnableConditionalStringForExposed):
(GenerateRuntimeEnableConditionalString):

Adds support for [Exposed] extended attributes on operations, attributes and
constants. This allows an interface that is exposed to both windows and workers
(with [Exposed=(Window,Worker)]), to indicate that a specific property should
only be be exposed somewhere, e.g only the window. This is need by DOMMatrixReadOnly's
stringifier, which is only exposed in the window environment.

bindings/scripts/IDLParser.pm:

(parseExtendedAttributeRest2):

Fix bug where array extended attributes, like those found in Exposed expressions
where being converter to scalars.

bindings/scripts/test/JS/JSTestGenerateIsReachable.cpp:
bindings/scripts/test/JS/JSTestGlobalObject.cpp:
bindings/scripts/test/JS/JSTestObj.cpp:
bindings/scripts/test/TestObj.idl:

Add tests and update results. Some results are just improved
includes.

css/DOMMatrix.cpp:
css/DOMMatrix.h:
css/DOMMatrix.idl:
css/DOMMatrixReadOnly.cpp:
css/DOMMatrixReadOnly.h:
css/DOMMatrixReadOnly.idl:

Expose DOMMatrix and DOMMatrixReadOnly to workers and update the constructors
to match the current spec, throwing if the argument is a string, and the context
is not the window / document context. Also did some refactoring to avoid allocating
the DOMMatrix or DOMMatrixReadOnly until after all the exceptional cases were handled.

LayoutTests:

js/dom/global-constructors-attributes-dedicated-worker-expected.txt:
platform/mac-wk1/js/dom/global-constructors-attributes-dedicated-worker-expected.txt
platform/wpe/js/dom/global-constructors-attributes-dedicated-worker-expected.txt

5:57 PM Changeset in webkit [221511] by fpizlo@apple.com

7 edits in trunk/Tools

WSL should use & for getting a ^{and @ for getting a []

https://bugs.webkit.org/show_bug.cgi?id=176245}

Reviewed by Myles Maxfield.

Using \ as an operator was a bad decision since that's an escape character in so many contexts.

Henceforth, & is for making pointers, for example:

thread int^{foo() { int x; return &x; }

And @ is for making array references, for example:

thread int[] foo() { int[42] x; return @x; }

Having separate operators makes it easy to have pointers to fixed-size arrays:

thread int[42]} foo() { int[42] x; return &x; }

WebGPUShadingLanguageRI/Intrinsics.js:

(Intrinsics):

WebGPUShadingLanguageRI/Lexer.js:

(Lexer.prototype.next):
(Lexer):

WebGPUShadingLanguageRI/MakePtrExpression.js:

(MakePtrExpression.prototype.toString):
(MakePtrExpression):

WebGPUShadingLanguageRI/Parse.js:

(parsePossibleSuffix):
(parsePossiblePrefix):
(parseFuncName):

WebGPUShadingLanguageRI/StandardLibrary.js:
WebGPUShadingLanguageRI/Test.js:

(TEST_simpleMakePtr):

5:19 PM Changeset in webkit [221510] by Chris Dumez

6 edits
2 adds in trunk

Implement FileSystemDirectoryEntry.getFile()
https://bugs.webkit.org/show_bug.cgi?id=176167
<rdar://problem/34187775>

Reviewed by Andreas Kling.

Source/WebCore:

Implement FileSystemDirectoryEntry.getFile():

https://wicg.github.io/entries-api/#dom-filesystemdirectoryentry-getfile

Test: editing/pasteboard/datatransfer-items-drop-getFile.html

Modules/entriesapi/DOMFileSystem.cpp:

(WebCore::isValidPathNameCharacter):
(WebCore::isValidPathSegment):
(WebCore::isValidRelativeVirtualPath):
(WebCore::isValidAbsoluteVirtualPath):
(WebCore::isValidVirtualPath):
Implement various path validation functions as per:

https://wicg.github.io/entries-api/#names-paths

(WebCore::resolveRelativeVirtualPath):

Use StringView for second parameter for efficiency. Had to keep a String for the first parameter because I need the split to return a Vector.
If the input path is absolute, call recursively with '/' as base path so that the virtual path gets sanitized (i.e. '..' and '.' in the absolute URL get resolved).

(WebCore::DOMFileSystem::listDirectory):
Use String instead of auto. It is not much longer and is clearer.

(WebCore::validatePathIsDirectory):
(WebCore::DOMFileSystem::getParent):
Move logic to validate that the path is a directory from getParent() to a
separate function. This only makes sure the ScriptExecutionContext is only
ref'd / deref'd on the main thread.

(WebCore::validatePathIsFile):
Logic for validating that a path is a file, used by getFile().

(WebCore::DOMFileSystem::getFile):
Implement getFile() as per:

https://wicg.github.io/entries-api/#dom-filesystemdirectoryentry-getfile

Modules/entriesapi/DOMFileSystem.h:
Modules/entriesapi/FileSystemDirectoryEntry.cpp:

(WebCore::FileSystemDirectoryEntry::getFile):
Add implementation of FileSystemDirectoryEntry::getFile() which merely calls
DOMFileSystem::getFile().

LayoutTests:

Add layout test coverage.

editing/pasteboard/datatransfer-items-drop-getFile-expected.txt: Added.
editing/pasteboard/datatransfer-items-drop-getFile.html: Added.

4:59 PM Changeset in webkit [221509] by beidson@apple.com

2 edits in trunk/Source/WebCore

ASSERTION FAILED: taken.get() == &job in WebCore::ServiceWorkerContainer::jobDidFinish(WebCore::ServiceWorkerJob &).
https://bugs.webkit.org/show_bug.cgi?id=176234

Rubberstamped by Tim Horton, reluctantly.

workers/service/ServiceWorkerContainer.cpp:

(WebCore::ServiceWorkerContainer::jobDidFinish): It's valid for the job to be missing after navigations, which is

why this was hitting downstream tests.

4:54 PM Changeset in webkit [221508] by mmaxfield@apple.com

3 edits in trunk/Tools

WSL's lexer will never emit keyword tokens
https://bugs.webkit.org/show_bug.cgi?id=176248

Reviewed by Filip Pizlo.

Because all tokens are also identified as idents, we need to handle them together.

WebGPUShadingLanguageRI/Lexer.js:

(Lexer.prototype.next):
(Lexer):

WebGPUShadingLanguageRI/Test.js:

(doLex):
(checkLexerToken):
(TEST_lexerKeyword):

4:43 PM Changeset in webkit [221507] by Matt Lewis

2 edits in trunk/LayoutTests

Skipped multiple webgl tests.
<rdar://problem/34209038>

Unreviewed test gardening.

platform/ios-11/TestExpectations:

4:28 PM Changeset in webkit [221506] by commit-queue@webkit.org

8 edits in trunk/Source

Do not Reject CacheStorage promises when updating the persistent filesystem data fails
https://bugs.webkit.org/show_bug.cgi?id=176241

Patch by Youenn Fablet <youenn@apple.com> on 2017-09-01
Reviewed by Alex Christensen.

Source/WebCore:

Open/Remove caches may succeed in updating the memory representation but the write-to-disk operation may fail.
In that case, the corresponding promise is now resolved since the web page can still proceeed.

There is no way to test that currently as this would require a write disk failure to be triggered.

Modules/cache/CacheStorage.cpp:

(WebCore::logConsolePersistencyError):
(WebCore::CacheStorage::open):
(WebCore::CacheStorage::remove):

Modules/cache/DOMCacheEngine.h:

(WebCore::DOMCacheEngine::CacheIdentifierOperationResult::encode const):
(WebCore::DOMCacheEngine::CacheIdentifierOperationResult::decode):

Source/WebKit:

Open/Remove caches may succeed in the memory representation but the write-to-disk operation may fail.
In that case, the callback does not return an error but a value containing the cache identifier.
The value will also contain a boolean flag set to true to notify the client that persistent storage failed this time.

NetworkProcess/cache/CacheStorageEngine.cpp:

(WebKit::CacheStorage::Engine::open):
(WebKit::CacheStorage::Engine::remove):

NetworkProcess/cache/CacheStorageEngineCaches.cpp:

(WebKit::CacheStorage::Caches::open):
(WebKit::CacheStorage::Caches::remove):

NetworkProcess/cache/CacheStorageEngineCaches.h:

3:56 PM Changeset in webkit [221505] by achristensen@apple.com

193 edits in trunk/Tools

Rename WebKit2 API tests after directory rename
https://bugs.webkit.org/show_bug.cgi?id=176250

Reviewed by Tim Horton.

TestWebKitAPI/Tests/Lots of files...

Renamed WebKit2 to WebKit and WebKit1 to WebKitLegacy.

3:53 PM Changeset in webkit [221504] by commit-queue@webkit.org

15 edits
7 adds in trunk

[Fetch API] Add support for consuming a Request ReadableStream body
https://bugs.webkit.org/show_bug.cgi?id=176182

Patch by Youenn Fablet <youenn@apple.com> on 2017-09-01
Reviewed by Alex Christensen.

Source/WebCore:

Tests: http/wpt/fetch/request-stream-empty.html

http/wpt/fetch/request-stream-error.html

Adding a ReadableStreamSink which allows to pipe all ReadableStream data back to C++ code.
This sink only takes BufferSource as the only user is Fetch which has this restriction.
This sink is tied to the readableStreamPipeTo builtin internal function that reads all data from the ReadableStream
and send it to the sink.

Adding a ReadableStreamToSharedBufferSink specialization to get the data as a SharedBuffer.

Use that class in FetchBodyConsumer to get the data back from the ReadableStream and transform it according
the desired body type (text, JSON, ArrayBuffer).

CMakeLists.txt:
DerivedSources.make:
Modules/fetch/FetchBody.cpp:

(WebCore::FetchBody::consume):
(WebCore::FetchBody::loadingSucceeded):

Modules/fetch/FetchBodyConsumer.cpp:

(WebCore::resolveWithTypeAndData):
(WebCore::FetchBodyConsumer::clean):
(WebCore::FetchBodyConsumer::resolveWithData):
(WebCore::FetchBodyConsumer::resolve):

Modules/fetch/FetchBodyConsumer.h:
Modules/fetch/FetchResponse.cpp:

(WebCore::FetchResponse::finishConsumingStream):

Modules/streams/ReadableStreamInternals.js:

(readableStreamPipeTo):

Modules/streams/ReadableStreamSink.cpp: Added.

(WebCore::ReadableStreamToSharedBufferSink::ReadableStreamToSharedBufferSink):
(WebCore::ReadableStreamToSharedBufferSink::pipeFrom):
(WebCore::ReadableStreamToSharedBufferSink::enqueue):
(WebCore::ReadableStreamToSharedBufferSink::close):
(WebCore::ReadableStreamToSharedBufferSink::error):

Modules/streams/ReadableStreamSink.h: Added.
Modules/streams/ReadableStreamSink.idl: Added.
WebCore.xcodeproj/project.pbxproj:
bindings/js/ReadableStream.cpp:

(WebCore::ReadableStream::pipeTo):

bindings/js/ReadableStream.h:

LayoutTests:

http/wpt/fetch/request-stream-disturbed-1-expected.txt:
http/wpt/fetch/request-stream-disturbed-2-expected.txt:
http/wpt/fetch/request-stream-disturbed-3-expected.txt:
http/wpt/fetch/request-stream-empty-expected.txt: Added.
http/wpt/fetch/request-stream-empty.html: Added.
http/wpt/fetch/request-stream-error-expected.txt: Added.
http/wpt/fetch/request-stream-error.html: Added.

3:25 PM Changeset in webkit [221503] by achristensen@apple.com

12 edits in trunk

Add WKUIDelegatePrivate equivalent of WKPageUIClient's toolbarsAreVisible
https://bugs.webkit.org/show_bug.cgi?id=176246
<rdar://problem/29270035>

Reviewed by Tim Horton.

Source/WebKit:

UIProcess/API/APIUIClient.h:

(API::UIClient::toolbarsAreVisible):

UIProcess/API/C/WKPage.cpp:

(WKPageSetPageUIClient):

UIProcess/API/Cocoa/WKUIDelegatePrivate.h:
UIProcess/Cocoa/UIDelegate.h:
UIProcess/Cocoa/UIDelegate.mm:

(WebKit::UIDelegate::setDelegate):
(WebKit::UIDelegate::UIClient::toolbarsAreVisible):

UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::getToolbarsAreVisible):

UIProcess/WebPageProxy.h:
UIProcess/WebPageProxy.messages.in:

Tools:

TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:

(-[ToolbarDelegate _webView:getToolbarsAreVisibleWithCompletionHandler:]):
(-[ToolbarDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
(TEST):

3:19 PM Changeset in webkit [221502] by achristensen@apple.com

9 edits
2 moves
1 add in trunk/Source/WebKit

Make PageClientImplCocoa a proper superclass of PageClientImpls for Mac and iOS
https://bugs.webkit.org/show_bug.cgi?id=176239

Reviewed by Tim Horton.

UIProcess/Cocoa/PageClientImplCocoa.h: Added.

(WebKit::PageClientImplCocoa::PageClientImplCocoa):

UIProcess/Cocoa/PageClientImplCocoa.mm:

(WebKit::PageClientImplCocoa::isPlayingAudioWillChange):
(WebKit::PageClientImplCocoa::isPlayingAudioDidChange):
(WebKit::PageClientImpl::isPlayingAudioWillChange): Deleted.
(WebKit::PageClientImpl::isPlayingAudioDidChange): Deleted.

UIProcess/Cocoa/WebViewImpl.mm:
UIProcess/ios/PageClientImplIOS.h:
UIProcess/ios/PageClientImplIOS.mm:

(WebKit::PageClientImpl::PageClientImpl):

UIProcess/mac/PageClientImpl.h: Removed.
UIProcess/mac/PageClientImpl.mm: Removed.
UIProcess/mac/PageClientImplMac.h: Copied from Source/WebKit/UIProcess/mac/PageClientImpl.h.
UIProcess/mac/PageClientImplMac.mm: Copied from Source/WebKit/UIProcess/mac/PageClientImpl.mm.

(WebKit::PageClientImpl::PageClientImpl):

UIProcess/mac/WebContextMenuProxyMac.mm:
UIProcess/mac/WebPageProxyMac.mm:
UIProcess/mac/WebPopupMenuProxyMac.mm:
WebKit.xcodeproj/project.pbxproj:

3:16 PM Changeset in webkit [221501] by commit-queue@webkit.org

6 edits in trunk

Wrong getComputedStyle behavior for pseudo-elements for layout-dependent properties.
https://bugs.webkit.org/show_bug.cgi?id=175936

Patch by Emilio Cobos Álvarez <emilio> on 2017-09-01
Reviewed by Antti Koivisto.

LayoutTests/imported/w3c:

web-platform-tests/cssom/getComputedStyle-pseudo-expected.txt:
web-platform-tests/cssom/getComputedStyle-pseudo.html: Sync test with upstream.

Source/WebCore:

Before this patch we may wrongly end up using the wrong renderer to resolve
this.

Tests: imported/w3c/web-platform-tests/cssom/getComputedStyle-pseudo.html

css/CSSComputedStyleDeclaration.cpp:

(WebCore::ComputedStyleExtractor::styledElement const):
(WebCore::ComputedStyleExtractor::styledRenderer const):
(WebCore::ComputedStyleExtractor::propertyValue):

css/CSSComputedStyleDeclaration.h:

3:14 PM Changeset in webkit [221500] by eric.carlson@apple.com

2 edits in trunk/Tools

Switch HTMLMediaElement to release logging
https://bugs.webkit.org/show_bug.cgi?id=176065

Unreviewed build fix.

TestWebKitAPI/Tests/WebCore/Logging.cpp:

3:09 PM Changeset in webkit [221499] by pvollan@apple.com

2 edits in trunk/LayoutTests

http/tests/misc/slow-loading-animated-image.html is flaky on iOS simulator and Windows.
https://bugs.webkit.org/show_bug.cgi?id=157916

Unreviewed test gardening.

platform/win/TestExpectations:

2:47 PM Changeset in webkit [221498] by pvollan@apple.com

6 edits
3 moves in trunk/Source/WebCore

[Win] Compile error, 'Cache' is not declared.
https://bugs.webkit.org/show_bug.cgi?id=176062

Reviewed by Youenn Fablet.

Rename Cache to DOMCache.

No new tests, covered by existing tests.

DerivedSources.make:
Modules/cache/Cache.cpp: Removed.
Modules/cache/Cache.h: Removed.
Modules/cache/Cache.idl: Removed.
Modules/cache/CacheStorage.cpp:

(WebCore::doSequentialMatch):
(WebCore::startSequentialMatch):
(WebCore::copyCaches):
(WebCore::CacheStorage::match):
(WebCore::CacheStorage::retrieveCaches):
(WebCore::CacheStorage::open):

Modules/cache/CacheStorage.h:
Modules/cache/DOMCache.cpp: Copied from Source/WebCore/Modules/cache/Cache.cpp.

(WebCore::DOMCache::DOMCache):
(WebCore::DOMCache::~DOMCache):
(WebCore::DOMCache::match):
(WebCore::DOMCache::doMatch):
(WebCore::DOMCache::matchAll):
(WebCore::DOMCache::add):
(WebCore::DOMCache::requestFromInfo):
(WebCore::DOMCache::addAll):
(WebCore::DOMCache::put):
(WebCore::DOMCache::remove):
(WebCore::DOMCache::keys):
(WebCore::DOMCache::retrieveRecords):
(WebCore::DOMCache::queryCache):
(WebCore::DOMCache::queryCacheWithTargetStorage):
(WebCore::DOMCache::batchDeleteOperation):
(WebCore::DOMCache::batchPutOperation):
(WebCore::DOMCache::updateRecords):
(WebCore::DOMCache::stop):
(WebCore::DOMCache::activeDOMObjectName const):
(WebCore::DOMCache::canSuspendForDocumentSuspension const):
(WebCore::Cache::Cache): Deleted.
(WebCore::Cache::~Cache): Deleted.
(WebCore::Cache::match): Deleted.
(WebCore::Cache::doMatch): Deleted.
(WebCore::Cache::matchAll): Deleted.
(WebCore::Cache::add): Deleted.
(WebCore::Cache::requestFromInfo): Deleted.
(WebCore::Cache::addAll): Deleted.
(WebCore::Cache::put): Deleted.
(WebCore::Cache::remove): Deleted.
(WebCore::Cache::keys): Deleted.
(WebCore::Cache::retrieveRecords): Deleted.
(WebCore::Cache::queryCache): Deleted.
(WebCore::Cache::queryCacheWithTargetStorage): Deleted.
(WebCore::Cache::batchDeleteOperation): Deleted.
(WebCore::Cache::batchPutOperation): Deleted.
(WebCore::Cache::updateRecords): Deleted.
(WebCore::Cache::stop): Deleted.
(WebCore::Cache::activeDOMObjectName const): Deleted.
(WebCore::Cache::canSuspendForDocumentSuspension const): Deleted.

Modules/cache/DOMCache.h: Copied from Source/WebCore/Modules/cache/Cache.h.
Modules/cache/DOMCache.idl: Copied from Source/WebCore/Modules/cache/Cache.idl.
WebCore.xcodeproj/project.pbxproj:

2:45 PM Changeset in webkit [221497] by fpizlo@apple.com

3 edits in trunk/Tools

WSL should have more tests of type checking failures
https://bugs.webkit.org/show_bug.cgi?id=176244

Reviewed by Myles Maxfield.

WebGPUShadingLanguageRI/Checker.js:

(Checker.prototype.visitProtocolDecl.set throw):

WebGPUShadingLanguageRI/Test.js:

(TEST_typeMismatchReturn):

2:35 PM Changeset in webkit [221496] by fpizlo@apple.com

19 edits
1 add in trunk/Tools

WSL should be be able to call a function declared in a protocol from a generic function
https://bugs.webkit.org/show_bug.cgi?id=176242

Reviewed by Myles Maxfield.

It turns out that we need to know when a function is resolved to a protocol signature, so we
need to have a type for this. This introduces ProtocolFuncDecl.

Also, this introduces parsing of protocol decls.

When instantiating a function, we need to rewrite its CallExpressions if they were previously
resolved to a PrtococolFuncDecl instead of a FuncDef or NativeFunc. In that case, we need to
rerun the resolution on the program. That resolution is guaranteed to succeed if the type
system works correctly.

WebGPUShadingLanguageRI/All.js:
WebGPUShadingLanguageRI/CallExpression.js:

(CallExpression.prototype.resolve):

WebGPUShadingLanguageRI/Checker.js:

(Checker.prototype.visitProtocolDecl.set throw):

WebGPUShadingLanguageRI/EBufferBuilder.js:

(EBufferBuilder.prototype._createEPtr):

WebGPUShadingLanguageRI/Func.js:

(Func):
(Func.prototype.get origin):

WebGPUShadingLanguageRI/FuncDef.js:

(FuncDef):
(FuncDef.prototype.get origin): Deleted.

WebGPUShadingLanguageRI/FuncInstantiator.js:

(FuncInstantiator):
(FuncInstantiator.prototype.getUnique.InstantiationSubstitution.prototype.visitCallExpression):
(FuncInstantiator.prototype.getUnique.InstantiationSubstitution):

WebGPUShadingLanguageRI/NativeFunc.js:

(NativeFunc):
(NativeFunc.prototype.get origin): Deleted.

WebGPUShadingLanguageRI/NativeFuncInstance.js:

(NativeFuncInstance):

WebGPUShadingLanguageRI/Node.js:

(Node.prototype.substitute):

WebGPUShadingLanguageRI/Parse.js:

(parseProtocolFuncDecl):
(parseProtocolDecl):
(parse):

WebGPUShadingLanguageRI/Program.js:

(Program):
(Program.prototype.get protocols):
(Program.prototype.add):

WebGPUShadingLanguageRI/ProtocolDecl.js:

(ProtocolDecl.prototype.add):
(ProtocolDecl.prototype.hasHeir):
(ProtocolDecl.prototype.addSignature): Deleted.

WebGPUShadingLanguageRI/ProtocolFuncDecl.js: Added.

(ProtocolFuncDecl):

WebGPUShadingLanguageRI/Rewriter.js:

(Rewriter.prototype.visitStructType):
(Rewriter.prototype.visitTypeVariable):
(Rewriter.prototype.visitProtocolFuncDecl):
(Rewriter.prototype.visitCallExpression):

WebGPUShadingLanguageRI/StructType.js:

(StructType.prototype.instantiate):

WebGPUShadingLanguageRI/Substitution.js:

(Substitution):
(Substitution.mapping): Deleted.

WebGPUShadingLanguageRI/Test.js:

(TEST_simpleGeneric):
(TEST_simpleAssignment):
(TEST_simpleDefault):
(TEST_simpleDereference):
(TEST_dereferenceStore):
(TEST_simpleMakePtr):
(TEST_threadArrayLoad):
(TEST_deviceArrayLoad):
(TEST_threadArrayStore):
(TEST_deviceArrayStore):
(TEST_simpleProtocol):

WebGPUShadingLanguageRI/Visitor.js:

(Visitor.prototype.visitProtocolFuncDecl):

2:33 PM Changeset in webkit [221495] by beidson@apple.com

7 edits in trunk/Source/WebCore

Move ServiceWorkerJob from FetchLoader to ThreadableLoader.
https://bugs.webkit.org/show_bug.cgi?id=176231

Reviewed by Youenn Fablet.

No new tests (No behavior change).

WebCore.xcodeproj/project.pbxproj:

Re-indent these headers. Yuck!

loader/ThreadableLoader.h:

(WebCore::ThreadableLoader::ref):
(WebCore::ThreadableLoader::deref):
(WebCore::ThreadableLoader::ThreadableLoader):
(WebCore::ThreadableLoader::~ThreadableLoader):

loader/ThreadableLoaderClient.h:

(WebCore::ThreadableLoaderClient::didSendData):
(WebCore::ThreadableLoaderClient::didReceiveResponse):
(WebCore::ThreadableLoaderClient::didReceiveData):
(WebCore::ThreadableLoaderClient::didFinishLoading):
(WebCore::ThreadableLoaderClient::didFail):
(WebCore::ThreadableLoaderClient::didFinishTiming):
(WebCore::ThreadableLoaderClient::ThreadableLoaderClient):
(WebCore::ThreadableLoaderClient::~ThreadableLoaderClient):

Move from FetchLoaderClient to ThreadableLoaderClient:

workers/service/ServiceWorkerJob.cpp:

(WebCore::ServiceWorkerJob::fetchScriptWithContext):
(WebCore::ServiceWorkerJob::didReceiveResponse):
(WebCore::ServiceWorkerJob::didReceiveData):
(WebCore::ServiceWorkerJob::didFinishLoading):
(WebCore::ServiceWorkerJob::didFail):
(WebCore::ServiceWorkerJob::didSucceed): Deleted.

workers/service/ServiceWorkerJob.h:

workers/service/server/SWClientConnection.cpp: Add a now-required include.

1:40 PM Changeset in webkit [221494] by eric.carlson@apple.com

12 edits
1 add in trunk

Switch HTMLMediaElement to release logging
https://bugs.webkit.org/show_bug.cgi?id=176065

Reviewed by Jer Noble.

Source/WebCore:

dom/Document.cpp:

(WebCore::Document::privateBrowsingStateDidChange): Disable the logger when private browsing
mode is enabled.
(WebCore::Document::logger const):

dom/Document.h:

Convert debug-only logging to configurable release logging.

html/HTMLMediaElement.cpp:

(PAL::LogArgument<WebCore::URL>::toString): Logger template for URL that returns the url as a
String when only when the LOG_DISABLED build flag is not defined. Returns "[url]" when it is.

html/HTMLMediaElement.h:

Source/WTF:

wtf/MediaTime.cpp:

(WTF::MediaTime::dump const): Use toString.
(WTF::MediaTime::toString const): New.

wtf/MediaTime.h:

(PAL::LogArgument<WTF::MediaTime>::toString): Logger template.

Tools:

TestWebKitAPI/Tests/WebCore/Logging.cpp:

(TestWebKitAPI::LogObserver::level const):

12:47 PM Changeset in webkit [221493] by aestes@apple.com

2 edits in trunk/Source/WebCore/PAL

Try again to fix the Internal iOS Simulator build after r221485.

pal/spi/cg/CoreGraphicsSPI.h:

12:31 PM Changeset in webkit [221492] by aestes@apple.com

2 edits in trunk/Source/WebCore/PAL

Try to fix the Internal iOS Simulator build after r221485.

pal/spi/cg/CoreGraphicsSPI.h:

12:13 PM Changeset in webkit [221491] by commit-queue@webkit.org

2 edits in trunk/Tools

download-latest-github-release.py should have friendlier output for non-404 errors
https://bugs.webkit.org/show_bug.cgi?id=176201

Patch by Ross Kirsling <Ross Kirsling> on 2017-09-01
Reviewed by Brent Fulgham.

Scripts/download-latest-github-release.py:

11:57 AM Changeset in webkit [221490] by fpizlo@apple.com

3 edits in trunk/Tools

[WSL] Add tests for storing to arrays
https://bugs.webkit.org/show_bug.cgi?id=176237

Reviewed by Myles Maxfield.

Storing to arrays works now.

WebGPUShadingLanguageRI/ArrayType.js:

(ArrayType):

WebGPUShadingLanguageRI/Test.js:

(TEST_threadArrayStore):
(TEST_deviceArrayStore):

11:54 AM Changeset in webkit [221489] by achristensen@apple.com

19 edits
1 add in trunk

Replace WKUIDelegatePrivate's isPlayingMediaDidChange with KVO _isPlayingAudio on WKWebView
https://bugs.webkit.org/show_bug.cgi?id=176212

Reviewed by Tim Horton.

Source/WebKit:

Dan suggested this in bug 176203, I think it's a good idea,
and I'll need to add more KVO properties soon anyways so I'd better learn how.
Determining if audio playing changed is important for Safari, so WKPageUIClient's
isPlayingAudioDidChange was correctly named but incorrectly fired if either audio
or video playing changed and had you check if audio was playing, possibly too often.

UIProcess/API/APIUIClient.h:

(API::UIClient::isPlayingMediaDidChange):

UIProcess/API/C/WKPage.cpp:

(WKPageSetPageUIClient):

UIProcess/API/Cocoa/WKUIDelegatePrivate.h:
UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _isPlayingAudio]):

UIProcess/API/Cocoa/WKWebViewPrivate.h:
UIProcess/API/glib/WebKitUIClient.cpp:
UIProcess/Cocoa/UIDelegate.h:
UIProcess/Cocoa/UIDelegate.mm:

(WebKit::UIDelegate::setDelegate):
(WebKit::UIDelegate::UIClient::isPlayingMediaDidChange): Deleted.

UIProcess/Cocoa/WebViewImpl.h:
UIProcess/Cocoa/WebViewImpl.mm:

(WebKit::WebViewImpl::isPlayingAudioWillChange):
(WebKit::WebViewImpl::isPlayingAudioDidChange):

UIProcess/PageClient.h:
UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::isPlayingMediaDidChange):

UIProcess/mac/PageClientImpl.h:
UIProcess/mac/PageClientImpl.mm:

(WebKit::PageClientImpl::isPlayingAudioDidChange):
(WebKit::PageClientImpl::isPlayingAudioWillChange):

Tools:

TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:

(-[AudioObserver observeValueForKeyPath:ofObject:change:context:]):
(TEST):
(-[MediaDelegate _webView:isPlayingMediaDidChange:]): Deleted.

11:49 AM Changeset in webkit [221488] by Simon Fraser

3 edits
2 adds in trunk

transformCanLikelyUseFastPath() can read off the end of a string
https://bugs.webkit.org/show_bug.cgi?id=176232
rdar://problem/33851237

Reviewed by Tim Horton.
Source/WebCore:

Code added in r220382 could read one byte past the end of the string when looking for the 'z'
of a rotateZ() function. The code was actually incorrect, testing for the 'z at i+6 after
already incrementing i by 6. This patch makes the code correctly detect rotateZ().

Also, rotate functions at the end of a string could be ignored because kShortestValidTransformStringLength
was too long, so set it to the length of "rotate(0)", the shortest transform function that we currently
fast-parse.

There's an implicit assumption in this code that chars is not indexed past i+kShortestValidTransformStringLength.
If the 'translate' path is taken, i is incremented by 9 (==kShortestValidTransformStringLength), but that's
OK because WTF::find() doesn't index into chars if i >= length.

Test: fast/css/transform-fast-paths.html

css/parser/CSSParserFastPaths.cpp:

(WebCore::transformCanLikelyUseFastPath):

LayoutTests:

fast/css/transform-fast-paths-expected.txt: Added.
fast/css/transform-fast-paths.html: Added.

11:48 AM Changeset in webkit [221487] by fpizlo@apple.com

5 edits in trunk/Tools

WSL Rewriter should be an identity on things that aren't inside function bodies
https://bugs.webkit.org/show_bug.cgi?id=176208

Reviewed by Myles Maxfield.

Previously, if the Rewriter encountered a FunctionDef, StructType, NativeType, etc., then it
would either crash or try to rewrite them. That's unfortunate because we use the Rewriter to
rewrite struct and function bodies. If a function calls another function, then rewriting the
caller should not mean also rewriting the callee. Previously we "fixed" this by religiously
wrapping references to types with TypeDef and doing other such hacks. But that's subtly wrong.
It only worked because Rewriter wasn't rewriting TypeRef.type. I think that Rewriter has to
rewrite that in the long run because it may refer to another TypeRef, and it may be an
instantiation that is using types that themselves need to be rewritten.

WebGPUShadingLanguageRI/Checker.js:

(Checker.prototype.visitProtocolDecl.set throw):

WebGPUShadingLanguageRI/NullType.js:

(NullType):

WebGPUShadingLanguageRI/Rewriter.js:

(Rewriter.prototype.visitFuncDef):
(Rewriter.prototype.visitNativeFunc):
(Rewriter.prototype.visitNativeFuncInstance):
(Rewriter.prototype.visitNativeType):
(Rewriter.prototype.visitTypeDef):
(Rewriter.prototype.visitStructType):
(Rewriter.prototype.visitTypeVariable):
(Rewriter.prototype.visitConstexprTypeParameter):
(Rewriter.prototype.visitNativeTypeInstance):
(Rewriter.prototype.visitTypeRef):

WebGPUShadingLanguageRI/Visitor.js:

(Visitor.prototype.visitNativeTypeInstance):

11:47 AM Changeset in webkit [221486] by achristensen@apple.com

6 edits in trunk

Disable ObjC WebGL policy SPI on iOS
https://bugs.webkit.org/show_bug.cgi?id=176233

Reviewed by Tim Horton.
Source/WebKit:

In r221465 I uploaded new SPI that is only needed on Mac with a beautiful test that only works on Mac.
Since it fails on iOS and is not needed on iOS, let's just disable it on iOS.

UIProcess/API/Cocoa/WKNavigationDelegatePrivate.h:
UIProcess/Cocoa/NavigationState.h:
UIProcess/Cocoa/NavigationState.mm:

(WebKit::NavigationState::setNavigationDelegate):

Tools:

TestWebKitAPI/Tests/WebKitCocoa/WebGLPolicy.mm:

11:37 AM Changeset in webkit [221485] by aestes@apple.com

32 edits
1 copy in trunk/Source

[CG] Upstream CoreGraphics-related WebKitSystemInterface functions
https://bugs.webkit.org/show_bug.cgi?id=176200

Reviewed by Tim Horton.

Source/WebCore:

platform/graphics/GraphicsContext.h:
platform/graphics/ImageSource.cpp:

(WebCore::ImageSource::subsamplingLevelForScaleFactor):

platform/graphics/cg/GraphicsContextCG.cpp:

(WebCore::GraphicsContext::clipOut):
(WebCore::applyShadowOffsetWorkaroundIfNeeded):

platform/graphics/cg/PatternCG.cpp:

(WebCore::Pattern::createPlatformPattern const):

platform/graphics/cocoa/GraphicsContextCocoa.mm:

(WebCore::GraphicsContext::focusRingColor):
(WebCore::drawFocusRingAtTime):
(WebCore::drawFocusRing):
(WebCore::drawFocusRingToContext):
(WebCore::drawFocusRingToContextAtTime):

platform/ios/WebCoreSystemInterfaceIOS.mm:
platform/mac/PasteboardMac.mm:

(WebCore::flipImageSpec):
(WebCore::setDragImageImpl):
(WebCore::Pasteboard::setDragImage):

platform/mac/PlatformEventFactoryMac.mm:
platform/mac/ScrollbarThemeMac.mm:

(WebCore::linenBackgroundColor):

platform/mac/ThemeMac.mm:

(WebCore::drawCellFocusRingWithFrameAtTime):
(WebCore::drawCellFocusRing):

platform/mac/WebCoreSystemInterface.h:
platform/mac/WebCoreSystemInterface.mm:
platform/mac/WebWindowAnimation.mm:

(flipRect):
(mainWindowServerConnectionID):
(setScaledFrameForWindow):
(-[WebWindowScaleAnimation setCurrentProgress:]):
(-[WebWindowFadeAnimation setCurrentProgress:]):

Source/WebCore/PAL:

PAL.xcodeproj/project.pbxproj:
pal/spi/cg/CoreGraphicsSPI.h:
pal/spi/mac/HIServicesSPI.h:
pal/spi/mac/NSGraphicsSPI.h: Copied from Source/WebCore/PAL/pal/spi/mac/HIServicesSPI.h.

Source/WebKit:

PluginProcess/mac/PluginProcessMac.mm:

(WebKit::PluginProcess::platformInitializeProcess):

UIProcess/mac/WindowServerConnection.h:
UIProcess/mac/WindowServerConnection.mm:

(WebKit::registerOcclusionNotificationHandler):
(WebKit::WindowServerConnection::WindowServerConnection):
(WebKit::WindowServerConnection::applicationWindowModificationsStarted): Deleted.

WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:

(InitWebCoreSystemInterface):

Source/WebKitLegacy/mac:

Carbon/HIWebView.mm:

(-[NSWindowGraphicsContext _web_setGraphicsPort:]):
(overrideCGContext):
(restoreCGContext):
(Draw):

Plugins/Hosted/WebHostedNetscapePluginView.mm:

(+[WebHostedNetscapePluginView initialize]):

Plugins/WebBaseNetscapePluginView.h:
Plugins/WebBaseNetscapePluginView.mm:

(WebKit::sendUserChangeNotifications):

Plugins/WebNetscapePluginView.mm:

(+[WebNetscapePluginView initialize]):
(-[WebNetscapePluginView saveAndSetNewPortStateForUpdate:]):

WebCoreSupport/WebSystemInterface.mm:

(InitWebCoreSystemInterface):

WebView/WebFrame.mm:

(-[WebFrame _paintBehaviorForDestinationContext:]):

WebView/WebFullScreenController.mm:

(setClipRectForWindow):
(-[WebFullScreenController finishedEnterFullScreenAnimation:]):
(-[WebFullScreenController finishedExitFullScreenAnimation:]):
(-[WebFullScreenController _startEnterFullScreenAnimationWithDuration:]):
(-[WebFullScreenController _startExitFullScreenAnimationWithDuration:]):

11:33 AM Changeset in webkit [221484] by Matt Lewis

2 edits in trunk/LayoutTests

Marked webrtc/datachannel/bufferedAmountLowThreshold.html as flaky on Mac WK1.
https://bugs.webkit.org/show_bug.cgi?id=172334

Unreviewed test gardening.

platform/mac-wk1/TestExpectations:

11:16 AM Changeset in webkit [221483] by commit-queue@webkit.org

5 edits in trunk/Source/WebCore

Reject promises in case of internal CacheStorage engine errors.
https://bugs.webkit.org/show_bug.cgi?id=176194

Patch by Youenn Fablet <youenn@apple.com> on 2017-09-01
Reviewed by Alex Christensen.

No new tests as this covers error cases that should not happen in regular cases.
Replacing lambdas that take no parameters to lambdas taking an optional error.
Reject promise if an error is found.

Modules/cache/Cache.cpp:

(WebCore::Cache::doMatch):
(WebCore::Cache::matchAll):
(WebCore::Cache::keys):
(WebCore::Cache::retrieveRecords):
(WebCore::Cache::queryCache):

Modules/cache/Cache.h:
Modules/cache/CacheStorage.cpp:

(WebCore::CacheStorage::match):
(WebCore::CacheStorage::has):
(WebCore::CacheStorage::retrieveCaches):
(WebCore::CacheStorage::open):
(WebCore::CacheStorage::remove):
(WebCore::CacheStorage::keys):

Modules/cache/CacheStorage.h:

10:53 AM Changeset in webkit [221482] by zandobersek@gmail.com

2 edits in trunk/Source/WebCore

Unreviewed WPE build fix after r221439.

html/canvas/WebGL2RenderingContext.cpp: Add the HeapInlines.h

header include in order to properly inline a Heap::vm() call.

10:37 AM Changeset in webkit [221481] by Chris Dumez

18 edits
6 adds in trunk

Implement FileSystemEntry.getParent()
https://bugs.webkit.org/show_bug.cgi?id=176165
<rdar://problem/34187743>

Reviewed by Andreas Kling.

Source/WebCore:

Implement FileSystemEntry.getParent():

https://wicg.github.io/entries-api/#dom-filesystementry-getparent

Tests: editing/pasteboard/datatransfer-items-drop-getParent-root.html

editing/pasteboard/datatransfer-items-drop-getParent.html
editing/pasteboard/datatransfer-items-drop-getParent2.html

Modules/entriesapi/DOMFileSystem.cpp:

(WebCore::toFileSystemEntries):
Take a ScriptExecutionContext now that FileSystemEntry is an ActiveDOMObject.

(WebCore::isAbsoluteVirtualPath):
Add utility function to determine if a virtual path is absolute:

https://wicg.github.io/entries-api/#absolute-path

(WebCore::DOMFileSystem::root):
Take a ScriptExecutionContext now that FileSystemEntry is an ActiveDOMObject.

(WebCore::DOMFileSystem::fileAsEntry):
Take a ScriptExecutionContext now that FileSystemEntry is an ActiveDOMObject.

(WebCore::resolveRelativePath):
Add implementation for:

https://wicg.github.io/entries-api/#resolve-a-relative-path

(WebCore::DOMFileSystem::listDirectory):
Take a ScriptExecutionContext now that FileSystemEntry is an ActiveDOMObject.

(WebCore::DOMFileSystem::getParent):
Add implementation of getParent() as per:

https://wicg.github.io/entries-api/#dom-filesystementry-getparent

Modules/entriesapi/DOMFileSystem.h:

(WebCore::DOMFileSystem::createEntryForFile):

Modules/entriesapi/DOMFileSystem.idl:
Modules/entriesapi/FileSystemDirectoryEntry.cpp:

(WebCore::FileSystemDirectoryEntry::FileSystemDirectoryEntry):

Modules/entriesapi/FileSystemDirectoryEntry.h:
Modules/entriesapi/FileSystemDirectoryReader.cpp:

(WebCore::FileSystemDirectoryReader::readEntries):
Take a ScriptExecutionContext now that FileSystemEntry is an ActiveDOMObject.

Modules/entriesapi/FileSystemEntry.cpp:

(WebCore::FileSystemEntry::FileSystemEntry):
(WebCore::FileSystemEntry::activeDOMObjectName const):
(WebCore::FileSystemEntry::canSuspendForDocumentSuspension const):
(WebCore::FileSystemEntry::getParent):

Modules/entriesapi/FileSystemEntry.h:
Modules/entriesapi/FileSystemEntry.idl:
Add implementation of FileSystemEntry.getParent() which relies on DOMFileSystem::getParent()
Make FileSystemEntry an ActiveDOMObject as getParent() is an asynchronous operation which causes delayed JS execution.

Modules/entriesapi/FileSystemFileEntry.cpp:

(WebCore::FileSystemFileEntry::FileSystemFileEntry):

Modules/entriesapi/FileSystemFileEntry.h:
dom/DataTransferItem.cpp:

(WebCore::DataTransferItem::getAsEntry const):

dom/DataTransferItem.h:
dom/DataTransferItem.idl:

Take a ScriptExecutionContext now that FileSystemEntry is an ActiveDOMObject.

LayoutTests:

editing/pasteboard/datatransfer-items-drop-getParent-expected.txt: Added.
editing/pasteboard/datatransfer-items-drop-getParent-root-expected.txt: Added.
editing/pasteboard/datatransfer-items-drop-getParent-root.html: Added.
editing/pasteboard/datatransfer-items-drop-getParent.html: Added.
editing/pasteboard/datatransfer-items-drop-getParent2-expected.txt: Added.
editing/pasteboard/datatransfer-items-drop-getParent2.html: Added.

Add layout test coverage for FileSystemEntry.getParent().

http/wpt/entries-api/interfaces-expected.txt:

Rebaseline test now that one more check is passing.

platform/wk2/TestExpectations:

Skip new tests on WK2 since they rely on beginDragWithFiles.

10:17 AM Changeset in webkit [221480] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

Ensure RenderStyle and SameSizeAsRenderStyle have the same size
https://bugs.webkit.org/show_bug.cgi?id=176210

Patch by Yoshiaki Jitsukawa <Yoshiaki.Jitsukawa@sony.com> on 2017-09-01
Reviewed by Daniel Bates.

SameSizeAsRenderStyle::m_nonInheritedFlags requires a 64 bit alignment,
which currently produces an extra 32 bit padding with 32 bit build.

rendering/style/RenderStyle.cpp:

Make m_nonInheritedFlags 32 bit aligned and restore the size check.

9:05 AM Changeset in webkit [221479] by Yusuke Suzuki

2 edits in trunk/Source/JavaScriptCore

[FTL] FTL allocation for async Function is incorrect
https://bugs.webkit.org/show_bug.cgi?id=176214

Reviewed by Saam Barati.

In FTL, allocating async function / async generator function was incorrectly using
JSFunction logic. While it is not observable right now since sizeof(JSFunction) == sizeof(JSAsyncFunction),
but it is a bug.

ftl/FTLLowerDFGToB3.cpp:

(JSC::FTL::DFG::LowerDFGToB3::compileNewFunction):

8:08 AM Changeset in webkit [221478] by pvollan@apple.com

26 edits
2 moves in trunk/Source

[Win] Compile error, 'Cache' is not declared.
https://bugs.webkit.org/show_bug.cgi?id=176062

Reviewed by Youenn Fablet.

Rename DOMCache to DOMCacheEngine.

Source/WebCore:

No new tests, covered by existing tests.

Modules/cache/Cache.cpp:

(WebCore::Cache::addAll):
(WebCore::Cache::put):
(WebCore::queryCacheMatch):
(WebCore::Cache::batchDeleteOperation):
(WebCore::toConnectionRecord):
(WebCore::Cache::batchPutOperation):

Modules/cache/Cache.h:
Modules/cache/CacheStorage.cpp:

(WebCore::CacheStorage::open):
(WebCore::CacheStorage::remove):

Modules/cache/CacheStorageConnection.cpp:
Modules/cache/CacheStorageConnection.h:

(WebCore::CacheStorageConnection::clearMemoryRepresentation):
(WebCore::CacheStorageConnection::openCompleted):
(WebCore::CacheStorageConnection::removeCompleted):
(WebCore::CacheStorageConnection::doOpen):
(WebCore::CacheStorageConnection::doRemove):
(WebCore::CacheStorageConnection::doBatchDeleteOperation):
(WebCore::CacheStorageConnection::doBatchPutOperation):

Modules/cache/DOMCache.cpp: Removed.
Modules/cache/DOMCache.h: Removed.
Modules/cache/DOMCacheEngine.cpp: Copied from Source/WebCore/Modules/cache/DOMCache.cpp.

(WebCore::DOMCacheEngine::isolatedResponseBody):
(WebCore::DOMCacheEngine::copyResponseBody):
(WebCore::DOMCache::errorToException): Deleted.
(WebCore::DOMCache::queryCacheMatch): Deleted.
(WebCore::DOMCache::isolatedResponseBody): Deleted.
(WebCore::DOMCache::copyResponseBody): Deleted.
(WebCore::DOMCache::Record::copy const): Deleted.

Modules/cache/DOMCacheEngine.h: Copied from Source/WebCore/Modules/cache/DOMCache.h.
Modules/cache/WorkerCacheStorageConnection.cpp:
Modules/cache/WorkerCacheStorageConnection.h:
WebCore.xcodeproj/project.pbxproj:
testing/Internals.cpp:

(WebCore::Internals::clearCacheStorageMemoryRepresentation):

Source/WebKit:

NetworkProcess/cache/CacheStorageEngine.cpp:

(WebKit::CacheStorage::Engine::queryCache):
(WebKit::CacheStorage::Engine::writeFile):

NetworkProcess/cache/CacheStorageEngine.h:
NetworkProcess/cache/CacheStorageEngineCache.h:
NetworkProcess/cache/CacheStorageEngineCaches.cpp:

(WebKit::CacheStorage::Caches::initialize):

NetworkProcess/cache/CacheStorageEngineCaches.h:
NetworkProcess/cache/CacheStorageEngineConnection.cpp:
NetworkProcess/cache/CacheStorageEngineConnection.h:
NetworkProcess/cache/CacheStorageEngineConnection.messages.in:
Shared/WebCoreArgumentCoders.cpp:

(IPC::ArgumentCoder<DOMCacheEngine::CacheInfo>::encode):
(IPC::ArgumentCoder<DOMCacheEngine::CacheInfo>::decode):
(IPC::ArgumentCoder<DOMCacheEngine::Record>::encode):
(IPC::ArgumentCoder<DOMCacheEngine::Record>::decode):
(IPC::ArgumentCoder<DOMCache::CacheInfo>::encode): Deleted.
(IPC::ArgumentCoder<DOMCache::CacheInfo>::decode): Deleted.
(IPC::ArgumentCoder<DOMCache::Record>::encode): Deleted.
(IPC::ArgumentCoder<DOMCache::Record>::decode): Deleted.

Shared/WebCoreArgumentCoders.h:
WebProcess/Cache/WebCacheStorageConnection.cpp:
WebProcess/Cache/WebCacheStorageConnection.h:
WebProcess/Cache/WebCacheStorageConnection.messages.in:

5:44 AM Changeset in webkit [221477] by commit-queue@webkit.org

2 edits in trunk/LayoutTests

[GTK] Mark audio-mpeg-supported.html as passing.
https://bugs.webkit.org/show_bug.cgi?id=131535

Unreviewed test gardening.

The last time it intermittently timed out was on r194436.
(It also timed out between r200951 and r201016, but that was consistent
and unrelated.)

Patch by Ms2ger <Ms2ger@igalia.com> on 2017-09-01

platform/gtk/TestExpectations:

5:27 AM WebKitGTK/2.18.x edited by clopez@igalia.com

(diff)

5:19 AM WebKitGTK/2.18.x edited by clopez@igalia.com

(diff)

4:47 AM Changeset in webkit [221476] by commit-queue@webkit.org

2 edits in trunk/LayoutTests

Mark media-ended.html as passing.
https://bugs.webkit.org/show_bug.cgi?id=131534

Unreviewed test gardening.

The test needs to run through the entire audio file twice, so it will
take several seconds by design. GTK used to have a shorter timeout,
which was extended in r218270. The test hasn't timed out since.

Patch by Ms2ger <Ms2ger@igalia.com> on 2017-09-01

platform/gtk/TestExpectations:

Aug 31, 2017:

11:40 PM Changeset in webkit [221475] by Yusuke Suzuki

6 edits in trunk

[JSC] Fix "name" and "length" of Proxy revoke function
https://bugs.webkit.org/show_bug.cgi?id=176155

Reviewed by Mark Lam.

JSTests:

test262.yaml:

Source/JavaScriptCore:

ProxyRevoke's length should be configurable. And it does not have
its own name. We add NameVisibility enum to InternalFunction to
control visibility of the name.

runtime/InternalFunction.cpp:

(JSC::InternalFunction::finishCreation):

runtime/InternalFunction.h:
runtime/ProxyRevoke.cpp:

(JSC::ProxyRevoke::finishCreation):

11:36 PM Changeset in webkit [221474] by Carlos Garcia Campos

3 edits in trunk/Tools

[GTK] Improve the way unit test are run and the results reported
https://bugs.webkit.org/show_bug.cgi?id=176104

Reviewed by Carlos Alberto Lopez Perez.

There are several issues with the way unit tests are run by run-gtk-tests and also with the way results are
reported:

The results summary only mentions the test binaries, not the actual test cases, so you always have to scroll up to find the actual test cases failing.
The number of reported failures is the number of test binaries that failed, so if a new test case fails for the same binary in a new revision, we won't notice it just looking at the number of failures.
We show detailed information about skipped test in the results summary, which is just noise.
In the case of glib tests, when a test case times out, we finish the test suite, instead of continuing with the rest of the test cases like we do for normal failures or crashes. If a new test case fails after a test case that timed out we will not notice it until we fix or skip the test cases timing out.
In the case of glib tests, the timeout is applied to the whole suite, instead of per test case, we have a hack to make it longer only for that. It has worked so far, but it doesn't scale, and it's an ugly hack.
It's not currently possible to detect flaky tests, because again, we know the binaries/suites that failed but not the actual test cases.

This patch fixes all these issues and makes it possible to add support for flaky tests in a follow up patch.

BuildSlaveSupport/build.webkit.org-config/master.cfg:

(RunGtkAPITests.commandComplete): Update the RunGtkAPITests step to parse the new output.

Scripts/run-gtk-tests:

(TestRunner._start_timeout): Helper to start the timeout if needed.
(TestRunner._start_timeout._alarm_handler): Raise timeout exception.
(TestRunner._stop_timeout): Helper to stop the timeout if needed.
(TestRunner._waitpid): Merged waitpid and return_code_from_exit_status.
(TestRunner._run_test_glib): Do not double the timeout anymore, we now start/stop the timeout for every test
case. Return a dictionary where keys are test cases and values the results only in case of failures.
(TestRunner._run_test_glib.parse_line): Update the parser to also detect test cases and the results.
(TestRunner._run_test_glib.parse_line.set_test_result): Helper to set the result of a test case.
(TestRunner._run_google_test): Return a dictionary where key is the test case and value is the result only in
case of failure.
(TestRunner._run_google_test_suite): Updated now that _run_google_test returns a dictionary.
(TestRunner.run_tests): Handle the results dictionary and show the results with information about test cases
failing and grouped by test binaries.

11:00 PM Changeset in webkit [221473] by aestes@apple.com

23 edits
3 copies in trunk/Source

[Mac] Upstream AppKit-related WebKitSystemInterface functions
https://bugs.webkit.org/show_bug.cgi?id=176175

Reviewed by Brady Eidson.

Source/WebCore:

Configurations/WebCore.xcconfig: Added -ObjC to OTHER_LDFLAGS so that Objective-C classes

in PAL are exported by WebCore even if WebCore doesn't use them.

platform/mac/PlatformEventFactoryMac.h:
platform/mac/PlatformEventFactoryMac.mm:

(WebCore::getWheelEventDeltas):
(WebCore::keyCharForEvent):
(WebCore::PlatformWheelEventBuilder::PlatformWheelEventBuilder):

platform/mac/WebCoreSystemInterface.h:
platform/mac/WebCoreSystemInterface.mm:

Source/WebCore/PAL:

PAL.xcodeproj/project.pbxproj:
pal/spi/mac/HIToolboxSPI.h:
pal/spi/mac/NSResponderSPI.h: Copied from Source/WebCore/PAL/pal/spi/mac/NSWindowSPI.h.
pal/spi/mac/NSWindowSPI.h:
pal/system/mac/WebPanel.h: Copied from Source/WebCore/PAL/pal/spi/mac/NSWindowSPI.h.
pal/system/mac/WebPanel.mm: Copied from Source/WebCore/PAL/pal/spi/mac/HIToolboxSPI.h.

(-[WebPanel init]):

Source/WebKit:

PluginProcess/mac/PluginProcessMac.mm:

(WebKit::initializeCocoaOverrides):

Shared/mac/WebEventFactory.mm:

(WebKit::WebEventFactory::createWebWheelEvent):
(WebKit::WebEventFactory::createWebKeyboardEvent):

UIProcess/mac/WKTextInputWindowController.mm:

(-[WKTextInputPanel init]):

WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:

(InitWebCoreSystemInterface):

Source/WebKitLegacy/mac:

Plugins/Hosted/NetscapePluginInstanceProxy.mm:

(WebKit::NetscapePluginInstanceProxy::keyEvent):

Plugins/Hosted/WebTextInputWindowController.m:

(-[WebTextInputPanel init]):

WebCoreSupport/WebSystemInterface.mm:

(InitWebCoreSystemInterface):

WebView/WebDynamicScrollBarsView.mm:

(-[WebDynamicScrollBarsView scrollWheel:]):

WebView/WebHTMLView.mm:

(-[WebHTMLView _removeWindowObservers]):
(-[WebHTMLView addWindowObservers]):

WebView/WebView.mm:

(-[WebView addWindowObserversForWindow:]):
(-[WebView removeWindowObservers]):
(-[WebView viewWillMoveToWindow:]):

10:41 PM Changeset in webkit [221472] by sbarati@apple.com

18 edits in trunk/Source/JavaScriptCore

Throwing an exception in the DFG/FTL should not cause a jettison
https://bugs.webkit.org/show_bug.cgi?id=176060
<rdar://problem/34143348>

Reviewed by Keith Miller.

Throwing an exception is not something that should be a jettison-able
OSR exit. We used to count Throw/ThrowStaticError towards our OSR exit
counts which could cause a CodeBlock to jettison and recompile. This
was dumb. Throwing an exception is not a reason to jettison and
recompile in the way that a speculation failure is. This patch
treats Throw/ThrowStaticError as true terminals in DFG IR.

bytecode/BytecodeUseDef.h:

(JSC::computeUsesForBytecodeOffset):

dfg/DFGAbstractInterpreterInlines.h:

(JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):

dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::parseBlock):

dfg/DFGClobberize.h:

(JSC::DFG::clobberize):

dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode):

dfg/DFGInPlaceAbstractState.cpp:

(JSC::DFG::InPlaceAbstractState::mergeToSuccessors):

dfg/DFGNode.h:

(JSC::DFG::Node::isTerminal):
(JSC::DFG::Node::isPseudoTerminal):
(JSC::DFG::Node::errorType):

dfg/DFGNodeType.h:
dfg/DFGOperations.cpp:
dfg/DFGOperations.h:
dfg/DFGPredictionPropagationPhase.cpp:
dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileThrow):
(JSC::DFG::SpeculativeJIT::compileThrowStaticError):

dfg/DFGSpeculativeJIT.h:

(JSC::DFG::SpeculativeJIT::callOperation):

dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

ftl/FTLLowerDFGToB3.cpp:

(JSC::FTL::DFG::LowerDFGToB3::compileNode):
(JSC::FTL::DFG::LowerDFGToB3::compileThrow):
(JSC::FTL::DFG::LowerDFGToB3::compileThrowStaticError):

jit/JITOperations.h:

9:10 PM Changeset in webkit [221471] by achristensen@apple.com

2 edits in trunk/Source/WebCore

Fix Windows build after r221422
https://bugs.webkit.org/show_bug.cgi?id=174924

platform/text/win/LocaleWin.cpp:

(WebCore::LocaleWin::getLocaleInfoString):
StringVector is now the type that can be adopted by String::adopt.

8:05 PM Changeset in webkit [221470] by sbarati@apple.com

3 edits
1 add in trunk

Graph::methodOfGettingAValueProfileFor compares NodeOrigin instead of the semantic CodeOrigin
https://bugs.webkit.org/show_bug.cgi?id=176206

Reviewed by Keith Miller.

JSTests:

stress/compare-semantic-origin-op-negate-method-of-getting-a-value-profile.js: Added.

(a):
(b):
(foo):

Source/JavaScriptCore:

Mark fixed the main issue in Graph::methodOfGettingAValueProfileFor in r208560
when he fixed it from overwriting invalid parts of the ArithProfile when the
currentNode and the operandNode are from the same bytecode. However, the
mechanism used to determine same bytecode was comparing NodeOrigin. That's
slightly wrong. We need to compare semantic origin, since two NodeOrigins can
have the same semantic origin, but differ only in exitOK. For example,
in the below IR, the DoubleRep and the Phi have the same semantic
origin, but different NodeOrigins.

43 Phi(JS|PureInt, NonBoolInt32|NonIntAsdouble, W:SideState, bc#63, ExitInvalid)
58 ExitOK(MustGen, W:SideState, bc#63)
51 DoubleRep(Check:Number:Kill:@43, Double|PureInt, BytecodeDouble, Exits, bc#63)
54 ArithNegate(DoubleRep:Kill:@51<Double>, Double|UseAsOther|MayHaveDoubleResult, AnyIntAsDouble|NonIntAsdouble, NotSet, Exits, bc#63)

dfg/DFGGraph.cpp:

(JSC::DFG::Graph::methodOfGettingAValueProfileFor):

7:59 PM Changeset in webkit [221469] by dbates@webkit.org

2 edits in trunk/Source/WebCore

Another attempt to fix the Apple Windows build following <https://trac.webkit.org/changeset/221459>
(https://bugs.webkit.org/show_bug.cgi?id=176171)

Temporarily weaken the size check for RenderStyle from a strict equality to <=.

rendering/style/RenderStyle.cpp:

7:52 PM Changeset in webkit [221468] by fpizlo@apple.com

22 edits
3 adds in trunk/Tools

WSL should support loading from arrays
https://bugs.webkit.org/show_bug.cgi?id=176207

Reviewed by Saam Barati.

Getting a test that loads from arrays to work required doing a lot of things:

a[i] now parses to ^{(operator\[](a, i)).}
added operator\[] for four array reference types.
to make thread|threadgroup|device T[] work, you need T:primitive.
so this adds the magical primitive protocol.

This required a little bit of rejuggling in the name resolver and type checker. The main thing
is that to prevent the rewriter from copying the types referenced by some function, you need to
make sure that when you add a reference to a type, you wrap it in a TypeRef. This doesn't
completely feel right, but I'm sure we'll figure out the balance eventually. See bug 176208.

WebGPUShadingLanguageRI/All.js:
WebGPUShadingLanguageRI/Checker.js:

(Checker.prototype.visitProtocolDecl.set throw):

WebGPUShadingLanguageRI/EArrayRef.js: Added.

(EArrayRef):
(EArrayRef.prototype.get ptr):
(EArrayRef.prototype.get length):
(EArrayRef.prototype.toString):

WebGPUShadingLanguageRI/EPtr.js:

(EPtr.prototype.plus):
(EPtr.prototype.toString):
(EPtr):

WebGPUShadingLanguageRI/Evaluator.js:

(Evaluator.prototype.visitUintLiteral):

WebGPUShadingLanguageRI/FuncInstantiator.js:

(FuncInstantiator.prototype.getUnique.Instantiate.prototype.visitNativeFunc):
(FuncInstantiator.prototype.getUnique.Instantiate):
(FuncInstantiator.prototype.getUnique):
(FuncInstantiator):

WebGPUShadingLanguageRI/Intrinsics.js:

(Intrinsics):

WebGPUShadingLanguageRI/Lexer.js:

(Lexer.prototype.next):
(Lexer):

WebGPUShadingLanguageRI/NameContext.js:

(NameContext.prototype.recognizeIntrinsics):

WebGPUShadingLanguageRI/NameResolver.js:

(NameResolver.prototype.visitProtocolRef):

WebGPUShadingLanguageRI/NativeFuncInstance.js:

(NativeFuncInstance.prototype.get isNative):

WebGPUShadingLanguageRI/Parse.js:

(parseTerm):
(parseTypeDef):
(parseNative):
(parsePossibleSuffix):
(parse):

WebGPUShadingLanguageRI/ProtocolDecl.js:

(ProtocolDecl):

WebGPUShadingLanguageRI/ProtocolRef.js:

(ProtocolRef.prototype.get isPrimitive):
(ProtocolRef):

WebGPUShadingLanguageRI/PtrType.js:

(PtrType.prototype.populateDefaultValue): Deleted.

WebGPUShadingLanguageRI/ReferenceType.js:

(ReferenceType.prototype.populateDefaultValue):
(ReferenceType):

WebGPUShadingLanguageRI/Rewriter.js:

(Rewriter.prototype.visitUintLiteral):
(Rewriter.prototype.visitFunc): Deleted.
(Rewriter.prototype.visitTypeVariable): Deleted.
(Rewriter.prototype.visitConstexprTypeParameter): Deleted.

WebGPUShadingLanguageRI/StandardLibrary.js:
WebGPUShadingLanguageRI/Test.js:

(TEST_threadArrayLoad):
(TEST_deviceArrayLoad):

WebGPUShadingLanguageRI/TypeRef.js:

(TypeRef.prototype.get instantiatedType):

WebGPUShadingLanguageRI/TypeVariable.js:

(TypeVariable.prototype.toString):
(TypeVariable):

WebGPUShadingLanguageRI/UintLiteral.js: Added.

(UintLiteral):
(UintLiteral.prototype.get value):
(UintLiteral.prototype.get isConstexpr):
(UintLiteral.prototype.toString):

WebGPUShadingLanguageRI/Visitor.js:

(Visitor.prototype.visitNativeFuncInstance):
(Visitor.prototype.visitTypeVariable):
(Visitor.prototype.visitPtrType):
(Visitor.prototype.visitArrayRefType):
(Visitor.prototype.visitUintLiteral):

WebGPUShadingLanguageRI/WTrapError.js: Added.

(WTrapError):

7:01 PM Changeset in webkit [221467] by dbates@webkit.org

2 edits in trunk/Source/WebCore

Attempt to fix the Apple Windows and WinCairo build following <https://trac.webkit.org/changeset/221459>
(https://bugs.webkit.org/show_bug.cgi?id=176171)

Explicitly cast PseudoIds to unsigned before computing a difference between two PseudoIds.

rendering/style/RenderStyle.h:

6:47 PM Changeset in webkit [221466] by achristensen@apple.com

10 edits in trunk

Add WKUIDelegatePrivate equivalent of WKPageUIClient's isPlayingAudioDidChange
https://bugs.webkit.org/show_bug.cgi?id=176203
<rdar://problem/29270035>

Reviewed by Tim Horton.

Source/WebKit:

UIProcess/API/APIUIClient.h:

(API::UIClient::isPlayingMediaDidChange):
(API::UIClient::isPlayingAudioDidChange): Deleted.

UIProcess/API/C/WKPage.cpp:

(WKPageSetPageUIClient):

UIProcess/API/Cocoa/WKUIDelegatePrivate.h:
UIProcess/Cocoa/UIDelegate.h:
UIProcess/Cocoa/UIDelegate.mm:

(WebKit::UIDelegate::setDelegate):
(WebKit::UIDelegate::UIClient::isPlayingMediaDidChange):

UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::isPlayingMediaDidChange):

Tools:

TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:

(-[MediaDelegate _webView:isPlayingMediaDidChange:]):
(-[MediaDelegate webView:didFinishNavigation:]):
(TEST):

6:46 PM Changeset in webkit [221465] by achristensen@apple.com

21 edits
1 add in trunk

Add ObjC SPI corresponding to WKPageLoaderClient's webGLLoadPolicy and resolveWebGLLoadPolicy
https://bugs.webkit.org/show_bug.cgi?id=175779
<rdar://problem/22367975>

Reviewed by Tim Horton.

Source/WebCore:

Covered by new API tests.

loader/FrameLoaderClient.h:

Source/WebKit:

UIProcess/API/APINavigationClient.h:

(API::NavigationClient::webGLLoadPolicy const):
(API::NavigationClient::resolveWebGLLoadPolicy const):

UIProcess/API/Cocoa/WKNavigationDelegatePrivate.h:
UIProcess/Cocoa/NavigationState.h:
UIProcess/Cocoa/NavigationState.mm:

(WebKit::NavigationState::setNavigationDelegate):
(WebKit::toWebCoreWebGLLoadPolicy):
(WebKit::NavigationState::NavigationClient::webGLLoadPolicy const):
(WebKit::NavigationState::NavigationClient::resolveWebGLLoadPolicy const):

UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::webGLPolicyForURL):
(WebKit::WebPageProxy::resolveWebGLPolicyForURL):

UIProcess/WebPageProxy.h:
UIProcess/WebPageProxy.messages.in:
WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::webGLPolicyForURL const):
(WebKit::WebFrameLoaderClient::resolveWebGLPolicyForURL const):

WebProcess/WebCoreSupport/WebFrameLoaderClient.h:
WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::webGLPolicyForURL):
(WebKit::WebPage::resolveWebGLPolicyForURL):

WebProcess/WebPage/WebPage.h:
WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::webGLPolicyForURL):
(WebKit::WebPage::resolveWebGLPolicyForURL):

WebProcess/WebPage/mac/WebPageMac.mm:

(WebKit::WebPage::webGLPolicyForURL):
(WebKit::WebPage::resolveWebGLPolicyForURL):

Source/WebKitLegacy/mac:

WebCoreSupport/WebFrameLoaderClient.h:
WebCoreSupport/WebFrameLoaderClient.mm:

(WebFrameLoaderClient::webGLPolicyForURL const):
(WebFrameLoaderClient::resolveWebGLPolicyForURL const):

Tools:

TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
TestWebKitAPI/Tests/WebKitCocoa/WebGLPolicy.mm: Added.

(-[WebGLTestDelegate webView:startURLSchemeTask:]):
(-[WebGLTestDelegate webView:stopURLSchemeTask:]):
(-[WebGLTestDelegate _webView:webGLLoadPolicyForURL:decisionHandler:]):
(-[WebGLTestDelegate _webView:resolveWebGLLoadPolicyForURL:decisionHandler:]):
(-[WebGLTestDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
(urlsEqual):
(runTest):
(TEST):

6:17 PM Changeset in webkit [221464] by akling@apple.com

7 edits in trunk/Source/WebCore

Element focus appearance update should be either immediate or a post-layout task
https://bugs.webkit.org/show_bug.cgi?id=176193

Reviewed by Antti Koivisto.

This change removes an old mechanism for avoiding element focus appearance updates
while we might be in the middle of attaching a renderer.

Focus appearance updates depend on a clean layout, since they want to be able to
scroll the element into the visible viewport if needed.
We now simply do the updates either immediately after layout in Element::focus(),
or as a post-layout callback when needed for HTMLInputElement::didAttachRenderers().

dom/Document.cpp:

(WebCore::Document::Document):
(WebCore::Document::updateFocusAppearanceSoon): Deleted.
(WebCore::Document::cancelFocusAppearanceUpdate): Deleted.
(WebCore::Document::updateFocusAppearanceTimerFired): Deleted.

dom/Document.h:
dom/Element.cpp:

(WebCore::Element::focus):
(WebCore::Element::blur):
(WebCore::Element::clearStyleDerivedDataBeforeDetachingRenderer):
(WebCore::Element::updateFocusAppearanceAfterAttachIfNeeded): Deleted.
(WebCore::Element::cancelFocusAppearanceUpdate): Deleted.

dom/Element.h:
dom/ElementRareData.h:

(WebCore::ElementRareData::ElementRareData):
(WebCore::ElementRareData::needsFocusAppearanceUpdateSoonAfterAttach const): Deleted.
(WebCore::ElementRareData::setNeedsFocusAppearanceUpdateSoonAfterAttach): Deleted.

html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::didAttachRenderers):

5:36 PM Changeset in webkit [221463] by don.olmstead@sony.com

19 edits in trunk

[CMake] Make USE_CF conditional within Windows
https://bugs.webkit.org/show_bug.cgi?id=176173

Reviewed by Alex Christensen.

Source/cmake/OptionsAppleWin.cmake:
Source/cmake/OptionsWinCairo.cmake:

Source/JavaScriptCore:

PlatformWin.cmake:

Source/WebCore:

No new tests. No change in behavior.

PlatformWin.cmake:
WebCorePrefix.h:
testing/js/WebCoreTestSupportPrefix.h:

Source/WebKitLegacy:

PlatformWin.cmake:

Source/WTF:

wtf/Platform.h:
wtf/PlatformWin.cmake:

Tools:

DumpRenderTree/config.h:
MiniBrowser/win/CMakeLists.txt:
MiniBrowser/win/stdafx.h:
TestWebKitAPI/PlatformWin.cmake:

5:21 PM Changeset in webkit [221462] by commit-queue@webkit.org

27 edits
2 copies
7 adds in trunk

Implement DOMMatrix2DInit for setTransform()/addPath()
https://bugs.webkit.org/show_bug.cgi?id=176048

Patch by Sam Weinig <sam@webkit.org> on 2017-08-31
Reviewed by Simon Fraser.

LayoutTests/imported/w3c:

web-platform-tests/css/geometry-1/DOMMatrix-001.html:
web-platform-tests/css/geometry-1/DOMMatrix-css-string.worker.js:

(string_appeared_here.forEach.constr.test):

web-platform-tests/css/geometry-1/DOMMatrixInit-validate-fixup-expected.txt: Added.
web-platform-tests/css/geometry-1/DOMMatrixInit-validate-fixup.html: Added.
web-platform-tests/css/geometry-1/historical.html:
web-platform-tests/css/geometry-1/interfaces-expected.txt: Added.
web-platform-tests/css/geometry-1/interfaces.html: Added.
web-platform-tests/css/geometry-1/interfaces.worker-expected.txt: Added.
web-platform-tests/css/geometry-1/interfaces.worker.html: Added.
web-platform-tests/css/geometry-1/interfaces.worker.js: Added.
web-platform-tests/css/geometry-1/structured-serialization.html:
web-platform-tests/css/geometry-1/w3c-import.log:

Pull latest web-platform-tests/css/geometry-1/ and rebase the results.

Source/WebCore:

DerivedSources.make:
WebCore.xcodeproj/project.pbxproj:
CMakeLists.txt:

Add new files.

bindings/js/CallTracerTypes.h:
inspector/InspectorCanvas.cpp:

Swap out DOMMatrixInit for DOMMatrix2DInit in canvas tracing infrastructure.

css/DOMMatrix2DInit.h: Added.
css/DOMMatrix2DInit.idl: Added.
css/DOMMatrixInit.h:
css/DOMMatrixInit.idl:

Split DOMMatrixInit in two, with the 2D bits going into DOMMatrix2DInit.

css/DOMMatrixReadOnly.cpp:
css/DOMMatrixReadOnly.h:

Add a validateAndFixup overload for DOMMatrix2DInit.

html/canvas/CanvasRenderingContext2D.cpp:
html/canvas/CanvasRenderingContext2D.h:

Swap out DOMMatrixInit for DOMMatrix2DInit in setTransform. This
should have no observable difference, since we ignored the 3D prior.

html/canvas/DOMPath.cpp:
html/canvas/DOMPath.h:
html/canvas/DOMPath.idl:

Update DOMPath (actually called Path2D) to take an optional DOMMatrix2DInit
rather than an SVGMatrix. Passing an SVGMatrix is still valid, as it conforms
as a DOMMatrix2DInit dictionary (having the necessary properties), so the
risk of compatibility issues is minimal.

LayoutTests:

fast/canvas/canvas-path-addPath-expected.txt:
fast/canvas/canvas-path-addPath.html:

Update test / results now that the transform is for the path is an optional dictionary.
Mostly this means we throw a little less.

5:12 PM Changeset in webkit [221461] by beidson@apple.com

24 edits
1 copy in trunk

Add (entirely incorrect) fetching of ServiceWorker scripts.
https://bugs.webkit.org/show_bug.cgi?id=176179

Reviewed by Andy Estes.

Source/WebCore:

No new tests (Covered by changes to existing tests).

When the Storage process is running the "Update" algorithm and a ServiceWorker script file needs to be fetched, this patch:

Messages back to the WebContent process that started the register/update job
Executes a FetchLoad in that script context for the script
Sends the results back to the Storage process

We don't do anything with the results yet.

Soon.

WebCore.xcodeproj/project.pbxproj:

workers/service/ServiceWorkerContainer.cpp:

(WebCore::ServiceWorkerContainer::startScriptFetchForJob):
(WebCore::ServiceWorkerContainer::jobFinishedLoadingScript):
(WebCore::ServiceWorkerContainer::jobFailedLoadingScript):

workers/service/ServiceWorkerContainer.h:

workers/service/ServiceWorkerFetchResult.h: Copied from Source/WebCore/workers/service/server/SWClientConnection.h.

(WebCore::ServiceWorkerFetchResult::encode const):
(WebCore::ServiceWorkerFetchResult::decode):

workers/service/ServiceWorkerJob.cpp:

(WebCore::ServiceWorkerJob::startScriptFetch):
(WebCore::ServiceWorkerJob::fetchScriptWithContext):
(WebCore::ServiceWorkerJob::didReceiveResponse):
(WebCore::ServiceWorkerJob::didReceiveData):
(WebCore::ServiceWorkerJob::didSucceed):
(WebCore::ServiceWorkerJob::didFail):

workers/service/ServiceWorkerJob.h:

workers/service/ServiceWorkerJobClient.h:

workers/service/server/SWClientConnection.cpp:

(WebCore::SWClientConnection::finishedFetchingScript):
(WebCore::SWClientConnection::failedFetchingScript):
(WebCore::SWClientConnection::startScriptFetchForServer):

workers/service/server/SWClientConnection.h:

workers/service/server/SWServer.cpp:

(WebCore::SWServer::Connection::finishFetchingScriptInServer):
(WebCore::SWServer::startScriptFetch):
(WebCore::SWServer::scriptFetchFinished):

workers/service/server/SWServer.h:

workers/service/server/SWServerRegistration.cpp:

(WebCore::SWServerRegistration::scriptFetchFinished):
(WebCore::SWServerRegistration::runUpdateJob):
(WebCore::SWServerRegistration::startScriptFetchFromMainThread):
(WebCore::SWServerRegistration::startScriptFetchForCurrentJob):

workers/service/server/SWServerRegistration.h:

Source/WebKit:

StorageProcess/ServiceWorker/WebSWServerConnection.cpp:

(WebKit::WebSWServerConnection::startScriptFetchInClient):

StorageProcess/ServiceWorker/WebSWServerConnection.h:
StorageProcess/ServiceWorker/WebSWServerConnection.messages.in:

WebProcess/Storage/WebSWClientConnection.cpp:

(WebKit::WebSWClientConnection::finishFetchingScriptInServer):

WebProcess/Storage/WebSWClientConnection.h:
WebProcess/Storage/WebSWClientConnection.messages.in:

LayoutTests:

http/tests/workers/service/basic-register-expected.txt:
http/tests/workers/service/resources/basic-register.js:
http/tests/workers/service/resources/registration-task-queue-scheduling-1.js:

5:09 PM Changeset in webkit [221460] by fpizlo@apple.com

14 edits
2 adds in trunk/Tools

WSL should support makeptr (\)
https://bugs.webkit.org/show_bug.cgi?id=176197

Reviewed by Saam Barati.

This required introducing some sanity about how pointers are carried around in the evaluator.
It turns out that we need to be careful about when a pointer to an rvalue is dereferenced. It
should be dereferenced basically immediately. If it cannot be, then we need to snapshot the
value. To do that, we need to know the types of things in a few more places. That's what this
change accomplishes.

WebGPUShadingLanguageRI/All.js:
WebGPUShadingLanguageRI/CallFunction.js:

(callFunction):

WebGPUShadingLanguageRI/Checker.js:

(Checker.prototype.visitProtocolDecl.set throw):

WebGPUShadingLanguageRI/DereferenceExpression.js:

(DereferenceExpression.prototype.get isLValue):

WebGPUShadingLanguageRI/Evaluator.js:

(Evaluator.prototype._snapshot):
(Evaluator.prototype.runBody):
(Evaluator.prototype.visitFunctionLikeBlock):
(Evaluator.prototype.visitDereferenceExpression):
(Evaluator.prototype.visitMakePtrExpression):
(Evaluator.prototype.visitCommaExpression):
(Evaluator.prototype.visitCallExpression):
(Evaluator):
(Evaluator.prototype._dereference): Deleted.

WebGPUShadingLanguageRI/FuncInstantiator.js:

(FuncInstantiator.prototype.getUnique.Instantiate.prototype.visitFuncDef):
(FuncInstantiator.prototype.getUnique.Instantiate.prototype.visitNativeFunc):
(FuncInstantiator.prototype.getUnique.Instantiate):
(FuncInstantiator.prototype.getUnique):
(FuncInstantiator):

WebGPUShadingLanguageRI/FunctionLikeBlock.js:

(FunctionLikeBlock):
(FunctionLikeBlock.prototype.get returnType):
(FunctionLikeBlock.prototype.toString):

WebGPUShadingLanguageRI/Inliner.js:

(Inliner.prototype.visitCallExpression):
(Inliner):

WebGPUShadingLanguageRI/MakePtrExpression.js: Added.

(MakePtrExpression):
(MakePtrExpression.prototype.get lValue):
(MakePtrExpression.prototype.toString):

WebGPUShadingLanguageRI/NativeFuncInstance.js: Added.

(NativeFuncInstance):
(NativeFuncInstance.prototype.get func):
(NativeFuncInstance.prototype.toString):

WebGPUShadingLanguageRI/Rewriter.js:

(Rewriter.prototype.visitMakePtrExpression):
(Rewriter.prototype.visitCallExpression):

WebGPUShadingLanguageRI/Test.js:

(TEST_dereferenceStore):
(TEST_simpleMakePtr):

WebGPUShadingLanguageRI/Value.js:

(Value.prototype.get isLValue):
(Value):

WebGPUShadingLanguageRI/VariableRef.js:

(VariableRef.prototype.get isLValue):
(VariableRef.prototype.get addressSpace):

WebGPUShadingLanguageRI/Visitor.js:

(Visitor.prototype.visitMakePtrExpression):
(Visitor.prototype.visitCallExpression):

4:55 PM Changeset in webkit [221459] by dbates@webkit.org

3 edits in trunk/Source/WebCore

Make RenderStyle's non-inherited flags more human friendly
https://bugs.webkit.org/show_bug.cgi?id=176171

Reviewed by Antti Koivisto.

Revert r166465 as we never followed through and made the CSS JIT update
RenderStyle's non-inherited flags directly.

rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::RenderStyle):
(WebCore::RenderStyle::hashForTextAutosizing const):
(WebCore::RenderStyle::equalForTextAutosizing const):
(WebCore::RenderStyle::changeRequiresLayout const):

rendering/style/RenderStyle.h:

(WebCore::RenderStyle::styleType const):
(WebCore::RenderStyle::setStyleType):
(WebCore::RenderStyle::setHasViewportUnits):
(WebCore::RenderStyle::hasViewportUnits const):
(WebCore::RenderStyle::affectedByHover const):
(WebCore::RenderStyle::affectedByActive const):
(WebCore::RenderStyle::affectedByDrag const):
(WebCore::RenderStyle::setAffectedByHover):
(WebCore::RenderStyle::setAffectedByActive):
(WebCore::RenderStyle::setAffectedByDrag):
(WebCore::RenderStyle::isFloating const):
(WebCore::RenderStyle::display const):
(WebCore::RenderStyle::position const):
(WebCore::RenderStyle::floating const):
(WebCore::RenderStyle::overflowX const):
(WebCore::RenderStyle::overflowY const):
(WebCore::RenderStyle::verticalAlign const):
(WebCore::RenderStyle::unicodeBidi const):
(WebCore::RenderStyle::clear const):
(WebCore::RenderStyle::tableLayout const):
(WebCore::RenderStyle::hasExplicitlySetDirection const):
(WebCore::RenderStyle::isLink const):
(WebCore::RenderStyle::setDisplay):
(WebCore::RenderStyle::setOriginalDisplay):
(WebCore::RenderStyle::setPosition):
(WebCore::RenderStyle::setFloating):
(WebCore::RenderStyle::setOverflowX):
(WebCore::RenderStyle::setOverflowY):
(WebCore::RenderStyle::setVerticalAlign):
(WebCore::RenderStyle::setUnicodeBidi):
(WebCore::RenderStyle::setClear):
(WebCore::RenderStyle::setTableLayout):
(WebCore::RenderStyle::setHasExplicitlySetDirection):
(WebCore::RenderStyle::setIsLink):
(WebCore::RenderStyle::hasExplicitlySetWritingMode const):
(WebCore::RenderStyle::setHasExplicitlySetWritingMode):
(WebCore::RenderStyle::hasExplicitlySetTextAlign const):
(WebCore::RenderStyle::setHasExplicitlySetTextAlign):
(WebCore::RenderStyle::unique const):
(WebCore::RenderStyle::setUnique):
(WebCore::RenderStyle::emptyState const):
(WebCore::RenderStyle::setEmptyState):
(WebCore::RenderStyle::firstChildState const):
(WebCore::RenderStyle::setFirstChildState):
(WebCore::RenderStyle::lastChildState const):
(WebCore::RenderStyle::setLastChildState):
(WebCore::RenderStyle::setHasExplicitlyInheritedProperties):
(WebCore::RenderStyle::hasExplicitlyInheritedProperties const):
(WebCore::RenderStyle::inheritUnicodeBidiFrom):
(WebCore::RenderStyle::NonInheritedFlags::operator!= const):
(WebCore::RenderStyle::NonInheritedFlags::hasAnyPublicPseudoStyles const):
(WebCore::RenderStyle::originalDisplay const):
(WebCore::RenderStyle::NonInheritedFlags::operator== const):
(WebCore::RenderStyle::NonInheritedFlags::copyNonInheritedFrom):
(WebCore::RenderStyle::NonInheritedFlags::hasPseudoStyle const):
(WebCore::RenderStyle::NonInheritedFlags::setHasPseudoStyle):
(WebCore::RenderStyle::NonInheritedFlags::overflowX const): Deleted.
(WebCore::RenderStyle::NonInheritedFlags::setOverflowX): Deleted.
(WebCore::RenderStyle::NonInheritedFlags::overflowY const): Deleted.
(WebCore::RenderStyle::NonInheritedFlags::setOverflowY): Deleted.
(WebCore::RenderStyle::NonInheritedFlags::clear const): Deleted.
(WebCore::RenderStyle::NonInheritedFlags::setClear): Deleted.
(WebCore::RenderStyle::NonInheritedFlags::effectiveDisplay const): Deleted.
(WebCore::RenderStyle::NonInheritedFlags::setEffectiveDisplay): Deleted.
(WebCore::RenderStyle::NonInheritedFlags::position const): Deleted.
(WebCore::RenderStyle::NonInheritedFlags::setPosition): Deleted.
(WebCore::RenderStyle::NonInheritedFlags::originalDisplay const): Deleted.
(WebCore::RenderStyle::NonInheritedFlags::setOriginalDisplay): Deleted.
(WebCore::RenderStyle::NonInheritedFlags::unicodeBidi const): Deleted.
(WebCore::RenderStyle::NonInheritedFlags::setUnicodeBidi): Deleted.
(WebCore::RenderStyle::NonInheritedFlags::hasViewportUnits const): Deleted.
(WebCore::RenderStyle::NonInheritedFlags::setHasViewportUnits): Deleted.
(WebCore::RenderStyle::NonInheritedFlags::verticalAlign const): Deleted.
(WebCore::RenderStyle::NonInheritedFlags::setVerticalAlign): Deleted.
(WebCore::RenderStyle::NonInheritedFlags::hasExplicitlyInheritedProperties const): Deleted.
(WebCore::RenderStyle::NonInheritedFlags::setHasExplicitlyInheritedProperties): Deleted.
(WebCore::RenderStyle::NonInheritedFlags::isFloating const): Deleted.
(WebCore::RenderStyle::NonInheritedFlags::floating const): Deleted.
(WebCore::RenderStyle::NonInheritedFlags::setFloating): Deleted.
(WebCore::RenderStyle::NonInheritedFlags::tableLayout const): Deleted.
(WebCore::RenderStyle::NonInheritedFlags::setTableLayout): Deleted.
(WebCore::RenderStyle::NonInheritedFlags::styleType const): Deleted.
(WebCore::RenderStyle::NonInheritedFlags::setStyleType): Deleted.
(WebCore::RenderStyle::NonInheritedFlags::isUnique const): Deleted.
(WebCore::RenderStyle::NonInheritedFlags::setIsUnique): Deleted.
(WebCore::RenderStyle::NonInheritedFlags::emptyState const): Deleted.
(WebCore::RenderStyle::NonInheritedFlags::setEmptyState): Deleted.
(WebCore::RenderStyle::NonInheritedFlags::firstChildState const): Deleted.
(WebCore::RenderStyle::NonInheritedFlags::setFirstChildState): Deleted.
(WebCore::RenderStyle::NonInheritedFlags::lastChildState const): Deleted.
(WebCore::RenderStyle::NonInheritedFlags::setLastChildState): Deleted.
(WebCore::RenderStyle::NonInheritedFlags::affectedByHover const): Deleted.
(WebCore::RenderStyle::NonInheritedFlags::setAffectedByHover): Deleted.
(WebCore::RenderStyle::NonInheritedFlags::affectedByActive const): Deleted.
(WebCore::RenderStyle::NonInheritedFlags::setAffectedByActive): Deleted.
(WebCore::RenderStyle::NonInheritedFlags::affectedByDrag const): Deleted.
(WebCore::RenderStyle::NonInheritedFlags::setAffectedByDrag): Deleted.
(WebCore::RenderStyle::NonInheritedFlags::isLink const): Deleted.
(WebCore::RenderStyle::NonInheritedFlags::setIsLink): Deleted.
(WebCore::RenderStyle::NonInheritedFlags::hasExplicitlySetDirection const): Deleted.
(WebCore::RenderStyle::NonInheritedFlags::setHasExplicitlySetDirection): Deleted.
(WebCore::RenderStyle::NonInheritedFlags::hasExplicitlySetWritingMode const): Deleted.
(WebCore::RenderStyle::NonInheritedFlags::setHasExplicitlySetWritingMode): Deleted.
(WebCore::RenderStyle::NonInheritedFlags::hasExplicitlySetTextAlign const): Deleted.
(WebCore::RenderStyle::NonInheritedFlags::setHasExplicitlySetTextAlign): Deleted.
(WebCore::RenderStyle::NonInheritedFlags::flagsMemoryOffset): Deleted.
(WebCore::RenderStyle::NonInheritedFlags::flagIsaffectedByActive): Deleted.
(WebCore::RenderStyle::NonInheritedFlags::flagIsaffectedByHover): Deleted.
(WebCore::RenderStyle::NonInheritedFlags::flagPseudoStyle): Deleted.
(WebCore::RenderStyle::NonInheritedFlags::setFirstChildStateFlags): Deleted.
(WebCore::RenderStyle::NonInheritedFlags::setLastChildStateFlags): Deleted.
(WebCore::RenderStyle::NonInheritedFlags::flagIsUnique): Deleted.
(WebCore::RenderStyle::NonInheritedFlags::flagFirstChildState): Deleted.
(WebCore::RenderStyle::NonInheritedFlags::flagLastChildState): Deleted.
(WebCore::RenderStyle::NonInheritedFlags::NonInheritedFlags): Deleted.
(WebCore::RenderStyle::NonInheritedFlags::setHasPseudoStyles): Deleted.
(WebCore::RenderStyle::NonInheritedFlags::updateBoolean): Deleted.
(WebCore::RenderStyle::NonInheritedFlags::getBoolean const): Deleted.
(WebCore::RenderStyle::NonInheritedFlags::updateValue): Deleted.
(WebCore::RenderStyle::InheritedFlags::operator== const): Deleted.
(WebCore::RenderStyle::NonInheritedFlags::getValue const): Deleted.
(WebCore::adjustForAbsoluteZoom): Deleted.
(WebCore::adjustFloatForAbsoluteZoom): Deleted.
(WebCore::adjustLayoutUnitForAbsoluteZoom): Deleted.
(WebCore::collapsedBorderStyle): Deleted.
(WebCore::RenderStyle::hasBackground const): Deleted.
(WebCore::RenderStyle::autoWrap): Deleted.
(WebCore::RenderStyle::preserveNewline): Deleted.
(WebCore::RenderStyle::collapseWhiteSpace): Deleted.
(WebCore::RenderStyle::isCollapsibleWhiteSpace const): Deleted.
(WebCore::RenderStyle::breakOnlyAfterWhiteSpace const): Deleted.
(WebCore::RenderStyle::breakWords const): Deleted.
(WebCore::RenderStyle::hasInlineColumnAxis const): Deleted.
(WebCore::RenderStyle::imageOrientation const): Deleted.
(WebCore::RenderStyle::setLogicalWidth): Deleted.
(WebCore::RenderStyle::setLogicalHeight): Deleted.
(WebCore::RenderStyle::setBorderRadius): Deleted.
(WebCore::RenderStyle::setZoom): Deleted.
(WebCore::RenderStyle::setEffectiveZoom): Deleted.
(WebCore::RenderStyle::setTextOrientation): Deleted.
(WebCore::RenderStyle::adjustBackgroundLayers): Deleted.
(WebCore::RenderStyle::adjustMaskLayers): Deleted.
(WebCore::RenderStyle::clearAnimations): Deleted.
(WebCore::RenderStyle::clearTransitions): Deleted.
(WebCore::RenderStyle::setShapeOutside): Deleted.
(WebCore::RenderStyle::setShapeImageThreshold): Deleted.
(WebCore::RenderStyle::setClipPath): Deleted.
(WebCore::RenderStyle::willChangeCreatesStackingContext const): Deleted.
(WebCore::RenderStyle::isDisplayRegionType const): Deleted.
(WebCore::RenderStyle::setWritingMode): Deleted.
(WebCore::RenderStyle::getShadowInlineDirectionExtent const): Deleted.
(WebCore::RenderStyle::getShadowBlockDirectionExtent const): Deleted.
(WebCore::RenderStyle::isDisplayReplacedType): Deleted.
(WebCore::RenderStyle::isDisplayInlineType): Deleted.
(WebCore::RenderStyle::isDisplayFlexibleBox): Deleted.
(WebCore::RenderStyle::isDisplayGridBox): Deleted.
(WebCore::RenderStyle::isDisplayFlexibleOrGridBox): Deleted.
(WebCore::RenderStyle::hasAnyPublicPseudoStyles const): Deleted.
(WebCore::RenderStyle::hasPseudoStyle const): Deleted.
(WebCore::RenderStyle::setHasPseudoStyle): Deleted.
(WebCore::RenderStyle::setHasPseudoStyles): Deleted.
(WebCore::RenderStyle::setBoxReflect): Deleted.
(WebCore::pseudoElementRendererIsNeeded): Deleted.

4:44 PM Changeset in webkit [221458] by Ryan Haddad

3 edits in trunk/JSTests

Skip two slow JSC tests after r221422.

Unreviewed test gardening.

stress/regexp-prototype-match-on-too-long-rope.js:
stress/regexp-prototype-test-on-too-long-rope.js:

4:31 PM Changeset in webkit [221457] by Megan Gardner

2 edits in trunk/Source/WebKit

Fix error in protocol revving
https://bugs.webkit.org/show_bug.cgi?id=176191

Protocol definition was mastered out of later iOS submissions, causing them to not build.

Reviewed by Tim Horton.

UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView changeSelectionWithGestureAt:withGesture:withState:]):

4:27 PM Changeset in webkit [221456] by Antti Koivisto

26 edits
1 delete in trunk

Remove newBlockInsideInlineModel and anonymous inline block
https://bugs.webkit.org/show_bug.cgi?id=176181

Reviewed by Zalan Bujtas.

Source/WebCore:

Anonymous inline block exists to support newBlockInsideInlineModel which was planned as the replacement for continuations.
It has never been enabled and it is time to remove it.

page/Settings.in:
rendering/InlineElementBox.cpp:

(WebCore::InlineElementBox::paint):
(WebCore::InlineElementBox::nodeAtPoint):

rendering/InlineFlowBox.cpp:

(WebCore::InlineFlowBox::addToLine):
(WebCore::InlineFlowBox::placeBoxesInBlockDirection):
(WebCore::InlineFlowBox::nodeAtPoint):
(WebCore::InlineFlowBox::paint):
(WebCore::InlineFlowBox::anonymousInlineBlock const): Deleted.

rendering/InlineFlowBox.h:

(WebCore::InlineFlowBox::InlineFlowBox):
(WebCore::InlineFlowBox::hasAnonymousInlineBlock const): Deleted.
(WebCore::InlineFlowBox::setHasAnonymousInlineBlock): Deleted.

rendering/RenderBlock.cpp:

(WebCore::RenderBlock::lineHeight const):
(WebCore::RenderBlock::baselinePosition const):
(WebCore::RenderBlock::renderName const):

rendering/RenderBlockFlow.cpp:

(WebCore::RenderBlockFlow::rebuildFloatingObjectSetFromIntrudingFloats):
(WebCore::RenderBlockFlow::childrenPreventSelfCollapsing const):
(WebCore::RenderBlockFlow::adjustLinePositionForPagination):
(WebCore::RenderBlockFlow::computeInlinePreferredLogicalWidths const):

rendering/RenderBlockFlow.h:
rendering/RenderBlockLineLayout.cpp:

(WebCore::updateLogicalInlinePositions):
(WebCore::RenderBlockFlow::computeInlineDirectionPositionsForLine):
(WebCore::RenderBlockFlow::layoutRunsAndFloats):
(WebCore::RenderBlockFlow::layoutRunsAndFloatsInRange):
(WebCore::RenderBlockFlow::layoutLineBoxes):
(WebCore::RenderBlockFlow::determineStartPosition):
(WebCore::RenderBlockFlow::matchedEndLine):
(WebCore::RenderBlockFlow::marginCollapseLinesFromStart): Deleted.

rendering/RenderBox.cpp:

(WebCore::RenderBox::sizesLogicalWidthToFitContent const):
(WebCore::RenderBox::createsNewFormattingContext const):
(WebCore::RenderBox::avoidsFloats const):

rendering/RenderInline.cpp:

(WebCore::RenderInline::addChildIgnoringContinuation):

rendering/RenderObject.cpp:

(WebCore::RenderObject::isAnonymousInlineBlock const): Deleted.

rendering/RenderObject.h:

(WebCore::RenderObject::isAnonymousBlock const):

rendering/RootInlineBox.cpp:

(WebCore::RootInlineBox::alignBoxesInBlockDirection):
(WebCore::RootInlineBox::ascentAndDescentForBox const):

rendering/line/BreakingContext.h:

(WebCore::BreakingContext::BreakingContext):
(WebCore::BreakingContext::handleReplaced):

rendering/line/LineBreaker.cpp:

(WebCore::LineBreaker::nextLineBreak):

rendering/line/LineBreaker.h:
rendering/line/LineLayoutState.h:

(WebCore::LineLayoutState::marginInfo):
(WebCore::LineLayoutState::prevFloatBottomFromAnonymousInlineBlock): Deleted.
(WebCore::LineLayoutState::maxFloatBottomFromAnonymousInlineBlock): Deleted.

LayoutTests:

TestExpectations:
fast/block/inside-inlines/crash-on-first-line-change.html:

Don't set newBlockInsideInlineModel.

fast/block/inside-inlines/new-model: Removed.
fast/block/inside-inlines/new-model/basic-float-intrusion-expected.html: Removed.
fast/block/inside-inlines/new-model/basic-float-intrusion.html: Removed.
fast/block/inside-inlines/new-model/block-width-check-expected.html: Removed.
fast/block/inside-inlines/new-model/block-width-check.html: Removed.
fast/block/inside-inlines/new-model/breaking-behavior-expected.html: Removed.
fast/block/inside-inlines/new-model/breaking-behavior.html: Removed.
fast/block/inside-inlines/new-model/empty-block-expected.html: Removed.
fast/block/inside-inlines/new-model/empty-block.html: Removed.
fast/block/inside-inlines/new-model/margin-collapse: Removed.
fast/block/inside-inlines/new-model/margin-collapse/001-expected.html: Removed.
fast/block/inside-inlines/new-model/margin-collapse/001.html: Removed.
fast/block/inside-inlines/new-model/margin-collapse/002-expected.html: Removed.
fast/block/inside-inlines/new-model/margin-collapse/002.html: Removed.
fast/block/inside-inlines/new-model/margin-collapse/003-expected.html: Removed.
fast/block/inside-inlines/new-model/margin-collapse/003.html: Removed.
fast/block/inside-inlines/new-model/margin-collapse/004-expected.html: Removed.
fast/block/inside-inlines/new-model/margin-collapse/004.html: Removed.
fast/block/inside-inlines/new-model/margins-pushing-below-float-expected.html: Removed.
fast/block/inside-inlines/new-model/margins-pushing-below-float.html: Removed.
fast/block/inside-inlines/new-model/paint-order-expected.html: Removed.
fast/block/inside-inlines/new-model/paint-order.html: Removed.
fast/block/inside-inlines/new-model/self-collapsing-test-expected.html: Removed.
fast/block/inside-inlines/new-model/self-collapsing-test.html: Removed.

These are reftests comparing newBlockInsideInlineModel and the current model and don't have value anymore.

fast/block/inside-inlines/opacity-on-inline.html:

Don't set newBlockInsideInlineModel.
Marked this as failing since it only worked with newBlockInsideInlineModel enabled.
The test passes in Firefox and fails in Chrome.

4:25 PM Changeset in webkit [221455] by Ryan Haddad

13 edits
1 delete in trunk

Unreviewed, rolling out r221445.

This change broke Sierra Release builds.

Reverted changeset:

"Switch HTMLMediaElement to release logging"
https://bugs.webkit.org/show_bug.cgi?id=176065
http://trac.webkit.org/changeset/221445

4:20 PM Changeset in webkit [221454] by commit-queue@webkit.org

19 edits in trunk/Source

Update CacheStorage caches only if it is updated
https://bugs.webkit.org/show_bug.cgi?id=176135

Patch by Youenn Fablet <youenn@apple.com> on 2017-08-31
Reviewed by Alex Christensen.

Source/WebCore:

Covered by existing tests.

When retrieving caches from the engine, CacheStorage gets an update counter.
When this counter is different from the previous received one, CacheStorage will update its cache list.
Otherwise it will skip this update step.

Modules/cache/CacheStorage.cpp:

(WebCore::CacheStorage::retrieveCaches):

Modules/cache/CacheStorage.h:
Modules/cache/CacheStorageConnection.cpp:

(WebCore::CacheStorageConnection::retrieveCaches):

Modules/cache/CacheStorageConnection.h:

(WebCore::CacheStorageConnection::doRetrieveCaches):

Modules/cache/DOMCache.cpp:

(WebCore::DOMCache::CacheInfos::isolatedCopy):

Modules/cache/DOMCache.h:

(WebCore::DOMCache::CacheInfos::encode const):
(WebCore::DOMCache::CacheInfos::decode):

Modules/cache/WorkerCacheStorageConnection.cpp:

(WebCore::WorkerCacheStorageConnection::doRetrieveCaches):

Modules/cache/WorkerCacheStorageConnection.h:

Source/WebKit:

For each change to CacheStorageEngineCaches list of cache, CacheStorageEngineCaches increments a counter.
When sending the list of caches, CacheStorageEngineCaches will compare its counter with the one provided.
If they sare the same, CacheStorageEngineCaches will return nothing.
Otherwise it returns the whole list of caches.

NetworkProcess/cache/CacheStorageEngine.cpp:

(WebKit::CacheStorage::Engine::retrieveCaches):

NetworkProcess/cache/CacheStorageEngine.h:
NetworkProcess/cache/CacheStorageEngineCaches.cpp:

(WebKit::CacheStorage::Caches::initialize):
(WebKit::CacheStorage::Caches::open):
(WebKit::CacheStorage::Caches::remove):
(WebKit::CacheStorage::Caches::clearMemoryRepresentation):
(WebKit::CacheStorage::Caches::cacheInfos const):

NetworkProcess/cache/CacheStorageEngineCaches.h:

(WebKit::CacheStorage::Caches::updateCounter const):

NetworkProcess/cache/CacheStorageEngineConnection.cpp:

(WebKit::CacheStorageEngineConnection::caches):

NetworkProcess/cache/CacheStorageEngineConnection.h:
NetworkProcess/cache/CacheStorageEngineConnection.messages.in:
WebProcess/Cache/WebCacheStorageConnection.cpp:

(WebKit::WebCacheStorageConnection::doRetrieveCaches):

WebProcess/Cache/WebCacheStorageConnection.h:

4:19 PM Changeset in webkit [221453] by sbarati@apple.com

2 edits in trunk/Source/JavaScriptCore

useSeparatedWXHeap should never be true when not on iOS
https://bugs.webkit.org/show_bug.cgi?id=176190

Reviewed by JF Bastien.

If you set useSeparatedWXHeap to true on X86_64, and launch the jsc shell,
the process insta-crashes. Let's silently ignore that option and set it
to false when not on iOS.

runtime/Options.cpp:

(JSC::recomputeDependentOptions):

4:19 PM Changeset in webkit [221452] by jmarcell@apple.com

7 edits in branches/safari-604-branch/Source

Versioning.

4:18 PM Changeset in webkit [221451] by jmarcell@apple.com

1 copy in tags/Safari-604.2.7

Tag Safari-604.2.7.

4:00 PM Changeset in webkit [221450] by fpizlo@apple.com

10 edits
1 add in trunk/Tools

WSL should support dereference (^{)

https://bugs.webkit.org/show_bug.cgi?id=176192}

Reviewed by Myles Maxfield.

This implements DereferenceExpression.

It also renames Evaluator.prototype.visitFunctionBody, because that name confusingly implies
that there is a class named FunctionBody. It's now called runBody.

I made the check to see if a type is a pointer type be the isPtr method, so that we can have
other pointer types that are implemented via something other than PtrType. We might want it if
for example we wanted a pointer type that is generic over address space.

WebGPUShadingLanguageRI/All.js:
WebGPUShadingLanguageRI/CallFunction.js:

(callFunction):

WebGPUShadingLanguageRI/Checker.js:

(Checker.prototype.visitProtocolDecl.set throw):

WebGPUShadingLanguageRI/DereferenceExpression.js: Added.

(DereferenceExpression):
(DereferenceExpression.prototype.get ptr):
(DereferenceExpression.prototype.toString):

WebGPUShadingLanguageRI/Evaluator.js:

(Evaluator.prototype.visitFunctionLikeBlock):
(Evaluator.prototype._dereference):
(Evaluator.prototype.visitDereferenceExpression):
(Evaluator.prototype.visitFunctionBody): Deleted.

WebGPUShadingLanguageRI/PtrType.js:

(PtrType.prototype.get isPtr):
(PtrType.prototype.populateDefaultValue):

WebGPUShadingLanguageRI/Rewriter.js:

(Rewriter.prototype.visitAssignment):
(Rewriter.prototype.visitDereferenceExpression):

WebGPUShadingLanguageRI/Test.js:

(TEST_simpleDereference):

WebGPUShadingLanguageRI/Type.js:

(Type.prototype.get isPtr):

WebGPUShadingLanguageRI/Visitor.js:

(Visitor.prototype.visitDereferenceExpression):

3:22 PM Changeset in webkit [221449] by fpizlo@apple.com

4 edits in trunk/Tools

There should only be one callFunction API in WSL
https://bugs.webkit.org/show_bug.cgi?id=176189

Reviewed by Saam Barati.

This removes the need for callFunctionByRef, which was weird. It's now the case the TypedValue
is always a tuple of type and ePtr, and TypedValue has a super simple API for boxing and
unboxing single-cell values like ints.

WebGPUShadingLanguageRI/CallFunction.js:

(callFunction):
(callFunctionByRef): Deleted.

WebGPUShadingLanguageRI/Test.js:

(makeInt):

WebGPUShadingLanguageRI/TypedValue.js:

(TypedValue):
(TypedValue.prototype.get type):
(TypedValue.prototype.get ePtr):
(TypedValue.box):
(TypedValue.prototype.get value):
(TypedValue.prototype.toString):

3:15 PM Changeset in webkit [221448] by fpizlo@apple.com

11 edits
1 delete in trunk/Tools

WSL EPtr does not need to carry around the type
https://bugs.webkit.org/show_bug.cgi?id=176188

Reviewed by Saam Barati.

To validate that the interpreter is modeling a statically typed execution environment, it's
really best if values don't know their types at all. A pointer is just a pointer (i.e a buffer
and offset in our world), and it's the job of the AST node that uses it to figure out what its
type should be.

I think this makes the code simpler overall.

WebGPUShadingLanguageRI/All.js:
WebGPUShadingLanguageRI/CallFunction.js:

(callFunctionByRef):
(callFunction):

WebGPUShadingLanguageRI/Checker.js:

(Checker.prototype.visitProtocolDecl.set throw):

WebGPUShadingLanguageRI/EBufferBuilder.js:

(EBufferBuilder.prototype._createEPtr):

WebGPUShadingLanguageRI/EPtr.js:

(EPtr):
(EPtr.box):
(EPtr.prototype.copyFrom):
(EPtr.prototype.toString):

WebGPUShadingLanguageRI/EValue.js: Removed.
WebGPUShadingLanguageRI/Evaluator.js:

(Evaluator.prototype.visitFunctionLikeBlock):
(Evaluator.prototype.visitVariableDecl):
(Evaluator.prototype.visitAssignment):
(Evaluator.prototype.visitIntLiteral):

WebGPUShadingLanguageRI/Intrinsics.js:

(Intrinsics):

WebGPUShadingLanguageRI/Rewriter.js:

(Rewriter.prototype.visitAssignment):

WebGPUShadingLanguageRI/StructType.js:

(StructType.prototype.instantiate):

WebGPUShadingLanguageRI/Test.js:

(checkInt):

2:55 PM Changeset in webkit [221447] by commit-queue@webkit.org

7 edits
1 add in trunk/Source/WebKit

Introduce CacheStorageEngineCache to handle cache records
https://bugs.webkit.org/show_bug.cgi?id=176137

Patch by Youenn Fablet <youenn@apple.com> on 2017-08-31
Reviewed by Alex Christensen.

CacheStorageEngineCache is the equivalent of WebCore Cache.
It contains a list of records that it needs to manage (add, update, remove).
Moving the logic of this management from CacheStorageEngine to this new class so as to ease future development.

CMakeLists.txt:
NetworkProcess/cache/CacheStorageEngine.cpp:

(WebKit::CacheStorage::Engine::open):
(WebKit::CacheStorage::Engine::remove):
(WebKit::CacheStorage::Engine::retrieveRecords):
(WebKit::CacheStorage::Engine::putRecords):
(WebKit::CacheStorage::Engine::deleteMatchingRecords):
(WebKit::CacheStorage::Engine::cache):
(WebKit::CacheStorage::Engine::writeCacheRecords): Deleted.
(WebKit::CacheStorage::Engine::removeCacheRecords): Deleted.
(WebKit::CacheStorage::Engine::queryCache): Deleted.

NetworkProcess/cache/CacheStorageEngine.h:
NetworkProcess/cache/CacheStorageEngineCache.cpp: Added.
NetworkProcess/cache/CacheStorageEngineCache.h:

(WebKit::CacheStorage::Cache::identifier const):
(WebKit::CacheStorage::Cache::name const):
(WebKit::CacheStorage::Cache::info const):

NetworkProcess/cache/CacheStorageEngineCaches.cpp:

(WebKit::CacheStorage::Caches::find):
(WebKit::CacheStorage::Caches::open):
(WebKit::CacheStorage::Caches::remove):
(WebKit::CacheStorage::encodeCacheNames):
(WebKit::CacheStorage::Caches::readCachesFromDisk):
(WebKit::CacheStorage::Caches::cacheInfos const):

WebKit.xcodeproj/project.pbxproj:

2:50 PM Changeset in webkit [221446] by fpizlo@apple.com

7 edits
1 add
2 deletes in trunk/Tools

WSL doesn't need to wrap primitives like ints and floats in specialized classes like EInt and EFloat
https://bugs.webkit.org/show_bug.cgi?id=176184

Reviewed by Saam Barati.

The only use for EInt and EFloat was that users of the interpreter want to be able to reason
about values that know their type. But for the actual interpreter, it makes most sense for
EBuffer to hold values directly - for example, ints in the case of values of type int. Then,
all of the logic of doing math on those things can be implemented in Intrinsics.js.

So, this removes EInt and EFloat but introduces a new TypedValue class that is used only on the
boundary of the interpreter. You can either use the interpreter by speaking its internal
language (EPtr to an EBuffer that has the values) or by using the simple API (which uses
TypedValue as a trade-off between power and convenience).

WebGPUShadingLanguageRI/All.js:
WebGPUShadingLanguageRI/CallFunction.js:

(callFunction):

WebGPUShadingLanguageRI/EFloat.js: Removed.
WebGPUShadingLanguageRI/EInt.js: Removed.
WebGPUShadingLanguageRI/EPtr.js:

(EPtr.box):

WebGPUShadingLanguageRI/Evaluator.js:

(Evaluator.prototype.visitIntLiteral):

WebGPUShadingLanguageRI/Intrinsics.js:

(Intrinsics):

WebGPUShadingLanguageRI/Test.js:

(makeInt):
(checkInt):
(TEST_add1):
(TEST_simpleGeneric):
(TEST_simpleAssignment):
(TEST_simpleDefault):

WebGPUShadingLanguageRI/TypedValue.js: Added.

(TypedValue):
(TypedValue.prototype.toString):

2:41 PM Changeset in webkit [221445] by eric.carlson@apple.com

11 edits
1 add in trunk

Switch HTMLMediaElement to release logging
https://bugs.webkit.org/show_bug.cgi?id=176065

Reviewed by Jer Noble.

Source/WebCore:

dom/Document.cpp:

(WebCore::Document::privateBrowsingStateDidChange): Disable the logger when private browsing
mode is enabled.
(WebCore::Document::logger const):

dom/Document.h:

Convert debug-only logging to configurable release logging.

html/HTMLMediaElement.cpp:

(PAL::LogArgument<WebCore::URL>::toString): Logger template for URL that returns the url as a
String when only when the LOG_DISABLED build flag is not defined. Returns "[url]" when it is.

html/HTMLMediaElement.h:

Source/WTF:

wtf/MediaTime.cpp:

(WTF::MediaTime::dump const): Use toString.
(WTF::MediaTime::toString const): New.

wtf/MediaTime.h:

(PAL::LogArgument<WTF::MediaTime>::toString): Logger template.

2:26 PM Changeset in webkit [221444] by commit-queue@webkit.org

17 edits in trunk

WKNavigationDelegatePrivate client redirect SPI needs to be able to detect redirects scheduled before the document finishes loading
https://bugs.webkit.org/show_bug.cgi?id=176128
rdar://problem/34068476

Patch by David Quesada <david_quesada@apple.com> on 2017-08-31
Reviewed by Brady Eidson.

Source/WebCore:

Removed FrameLoaderClient::dispatchDidPerformClientRedirect() since no client cares about this event anymore.
Also removed FrameLoader::performClientRedirect() since it wouldn't do anything but call changeLocation().

No new tests - no change in functionality.

loader/FrameLoader.cpp:
loader/FrameLoader.h:
loader/FrameLoaderClient.h:
loader/NavigationScheduler.cpp:

Source/WebKit:

_webView:didPerformClientRedirect: isn't useful for delegates that want to know about client redirects
started before the document is finished loading. This is because the method would be called after the
navigation scheduler's timer fires and the navigation for the redirect has begun. Since this happens in
a later iteration of the run loop, the document has already finished loading. Address this by replacing
the method with two that give the navigation delegate more information about when client redirects are
scheduled and canceled.

UIProcess/API/APINavigationClient.h:

(API::NavigationClient::willPerformClientRedirect):
(API::NavigationClient::didCancelClientRedirect):

UIProcess/API/Cocoa/WKNavigationDelegatePrivate.h:
UIProcess/Cocoa/NavigationState.h:
UIProcess/Cocoa/NavigationState.mm:

(WebKit::NavigationState::setNavigationDelegate):
(WebKit::NavigationState::NavigationClient::willPerformClientRedirect):
(WebKit::NavigationState::NavigationClient::didCancelClientRedirect):

UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::willPerformClientRedirectForFrame):
(WebKit::WebPageProxy::didCancelClientRedirectForFrame):

UIProcess/WebPageProxy.h:
UIProcess/WebPageProxy.messages.in:
WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::dispatchDidCancelClientRedirect):
(WebKit::WebFrameLoaderClient::dispatchWillPerformClientRedirect):

WebProcess/WebCoreSupport/WebFrameLoaderClient.h:

Tools:

Removed API test for the deleted WKNavigationDelegatePrivate method,
and added two new tests for the two new methods.

TestWebKitAPI/Tests/WebKitCocoa/Navigation.mm:

(-[ClientRedirectNavigationDelegate _webView:willPerformClientRedirectToURL:delay:]):
(-[ClientRedirectNavigationDelegate _webViewDidCancelClientRedirect:]):
(-[ClientRedirectNavigationDelegate webView:didFinishNavigation:]):
(TEST):

2:13 PM Changeset in webkit [221443] by Megan Gardner

5 edits in trunk/Source/WebKit

Remove IsBlockSelection flag
https://bugs.webkit.org/show_bug.cgi?id=176141

Reviewed by Dean Jackson.

Block selection is disabled. Removed code associated with this flag to allow removal of the
flag in UIKit.

No tests for a removed feature.

Platform/spi/ios/UIKitSPI.h:
Shared/ios/GestureTypes.h:
UIProcess/ios/WKContentViewInteraction.mm:

(toUIWKSelectionFlags):

WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::rangeForWebSelectionAtPosition):
(WebKit::WebPage::selectWithGesture):
(WebKit::WebPage::contractedRangeFromHandle):
(WebKit::WebPage::computeExpandAndShrinkThresholdsForHandle):
(WebKit::WebPage::updateBlockSelectionWithTouch):
(WebKit::WebPage::updateSelectionWithTouches):

1:57 PM Changeset in webkit [221442] by fpizlo@apple.com

8 edits in trunk/Tools

WSL should handle variable assignments and variable declarations
https://bugs.webkit.org/show_bug.cgi?id=176180

Reviewed by Saam Barati.

Just fills in VariableDecl and Assignment logic so that we can test variables.

WebGPUShadingLanguageRI/Checker.js:

(Checker.prototype.visitProtocolDecl.set throw):

WebGPUShadingLanguageRI/EBufferBuilder.js:

(EBufferBuilder.prototype._createEPtrForNode):
(EBufferBuilder.prototype.visitFuncParameter):
(EBufferBuilder.prototype.visitVariableDecl):
(EBufferBuilder):

WebGPUShadingLanguageRI/Evaluator.js:

(Evaluator.prototype.visitVariableDecl):
(Evaluator.prototype.visitAssignment):

WebGPUShadingLanguageRI/NameResolver.js:

(NameResolver.prototype.visitVariableDecl):

WebGPUShadingLanguageRI/Rewriter.js:

(Rewriter.prototype.visitFuncParameter):
(Rewriter.prototype.visitVariableDecl):

WebGPUShadingLanguageRI/Test.js:

(makeInt):
(TEST_add1):
(TEST_simpleGeneric):
(TEST_simpleAssignment):
(TEST_simpleDefault):

WebGPUShadingLanguageRI/Visitor.js:

(Visitor.prototype.visitVariableDecl):

1:53 PM Changeset in webkit [221441] by Chris Dumez

14 edits in trunk

getFileMetadata() does not work as expected for symbolic links
https://bugs.webkit.org/show_bug.cgi?id=176143

Reviewed by Andreas Kling.

Source/WebCore:

getFileMetadata() does not work as expected for symbolic links:
On POSIX, getFileMetadata() always followed symlinks, which meant that FileMetadata.type could
never be TypeSymbolicLink. On Windows, the function properly did not follow symlinks but failed to set
FileMetadata.type to TypeSymbolicLink when the file was a symbolic link.

This patch adds a new ShouldFollowSymbolicLinks parameter to getFileMetadata() so that
the call site can decide the behavior it wants. If getFileMetadata() is called on a
symbolic link with ShouldFollowSymbolicLinks::No as parameter, FileMetadata.type is now
properly set to TypeSymbolicLink.

No new tests, covered by new API test.

Modules/entriesapi/DOMFileSystem.cpp:

(WebCore::listDirectoryWithMetadata):
It is important we do not follow symlinks here since the code wants to discard them
and does so by checking FileMetadata.type.

WebCore.xcodeproj/project.pbxproj:
fileapi/File.cpp:

(WebCore::File::isDirectory const):

html/FileListCreator.cpp:

(WebCore::appendDirectoryFiles):
(WebCore::FileListCreator::createFileList):
It is important we do not follow symlinks here since the code wants to discard them
and does so by checking FileMetadata.type.

platform/FileSystem.cpp:

(WebCore::fileIsDirectory):

platform/FileSystem.h:
platform/glib/FileSystemGlib.cpp:

(WebCore::getFileLStat):
(WebCore::getFileMetadata):

platform/posix/FileSystemPOSIX.cpp:

(WebCore::getFileMetadata):
(WebCore::createSymbolicLink):

platform/win/FileSystemWin.cpp:

(WebCore::getFinalPathName):
(WebCore::getFileMetadata):
(WebCore::createSymbolicLink):

Add new createSymbolicLink() function for testing purposes.
On Posix, call lstat() instead of stat if ShouldFollowSymbolicLinks::No.
On Windows, since FindFirstFileW() does not follow symlinks, resolve final path using GetFinalPathNameByHandleW() if ShouldFollowSymbolicLinks::Yes.
On Windows, properly set FileMetadata.type to TypeSymbolicLink if the file is a symbolic link.

Tools:

Add API test coverage.

TestWebKitAPI/Tests/WebCore/FileSystem.cpp:

(TestWebKitAPI::TEST_F):

1:50 PM Changeset in webkit [221440] by fpizlo@apple.com

2 edits in trunk/Source/JavaScriptCore

Fix debug crashes.

Rubber stamped by Mark Lam.

runtime/JSArrayBufferView.cpp:

(JSC::JSArrayBufferView::ConstructionContext::ConstructionContext):

1:46 PM Changeset in webkit [221439] by fpizlo@apple.com

12 edits in trunk

All of the different ArrayBuffer::data's should be CagedPtr<>
https://bugs.webkit.org/show_bug.cgi?id=175515

Reviewed by Michael Saboff.

Source/JavaScriptCore:

This straightforwardly implements what the title says.

runtime/ArrayBuffer.cpp:

(JSC::SharedArrayBufferContents::~SharedArrayBufferContents):
(JSC::ArrayBufferContents::destroy):
(JSC::ArrayBufferContents::tryAllocate):
(JSC::ArrayBufferContents::makeShared):
(JSC::ArrayBufferContents::copyTo):
(JSC::ArrayBuffer::createFromBytes):
(JSC::ArrayBuffer::transferTo):

runtime/ArrayBuffer.h:

(JSC::SharedArrayBufferContents::data const):
(JSC::ArrayBufferContents::data const):
(JSC::ArrayBuffer::data):
(JSC::ArrayBuffer::data const):

runtime/ArrayBufferView.h:

(JSC::ArrayBufferView::baseAddress const):

runtime/CagedBarrierPtr.h: Added a specialization so that CagedBarrierPtr<Gigacage::Foo, void> is valid.
runtime/DataView.h:

(JSC::DataView::get):
(JSC::DataView::set):

runtime/JSArrayBufferView.cpp:

(JSC::JSArrayBufferView::ConstructionContext::ConstructionContext):

runtime/JSArrayBufferView.h:

(JSC::JSArrayBufferView::ConstructionContext::vector const):
(JSC::JSArrayBufferView::vector const):

runtime/JSGenericTypedArrayViewInlines.h:

(JSC::JSGenericTypedArrayView<Adaptor>::visitChildren):

Source/WTF:

Added a specialization so that CagedPtr<void> is valid.

wtf/CagedPtr.h:

1:09 PM Changeset in webkit [221438] by Michael Catanzaro

2 edits in trunk/Source/WebCore

REGRESSION(r221226): [SOUP] libsoup-CRITICAL : soup_cookies_to_cookie_header: assertion 'cookies != NULL' failed
https://bugs.webkit.org/show_bug.cgi?id=176140

Reviewed by Carlos Garcia Campos.

This should fix unexpected stderr output in several tests.

platform/network/soup/CookieJarSoup.cpp:

(WebCore::cookiesForSession):

1:03 PM Changeset in webkit [221437] by commit-queue@webkit.org

15 edits
2 moves
10 adds in trunk

Add support for Request body stream cloning
https://bugs.webkit.org/show_bug.cgi?id=176148

Patch by Youenn Fablet <youenn@apple.com> on 2017-08-31
Reviewed by Alex Christensen.

Source/WebCore:

Tests: http/wpt/fetch/request-clone.html

http/wpt/fetch/request-consume-stream.html
http/wpt/fetch/request-stream-disturbed-1.html
http/wpt/fetch/request-stream-disturbed-2.html
http/wpt/fetch/request-stream-disturbed-3.html

Adding support for ReadableStream teeing for cloning fetch bodies.
Adding support for pushing request body data to its ReadableStream.
Renamed FetchResponseSource to FetchBodySource for that purpose.

Tests extracting body from a ReadableStream through JS API pass.
Tests extracting data stored in a ReadableStream to resolve fetch body promises are failing.
There is no support yet, this will be added as a follow-up.

CMakeLists.txt:
Modules/fetch/FetchBody.cpp:

(WebCore::FetchBody::consume):
(WebCore::FetchBody::consumeAsStream):
(WebCore::FetchBody::clone):

Modules/fetch/FetchBody.h:
Modules/fetch/FetchBodyConsumer.h:
Modules/fetch/FetchBodyOwner.cpp:

(WebCore::FetchBodyOwner::cloneBody):
(WebCore::FetchBodyOwner::loadBlob):
(WebCore::FetchBodyOwner::readableStream):
(WebCore::FetchBodyOwner::consumeBodyAsStream):

Modules/fetch/FetchBodyOwner.h:

(WebCore::FetchBodyOwner::feedStream):
(WebCore::FetchBodyOwner::cancel):

Modules/fetch/FetchBodySource.cpp: Renamed from Source/WebCore/Modules/fetch/FetchResponseSource.cpp.
Modules/fetch/FetchBodySource.h: Renamed from Source/WebCore/Modules/fetch/FetchResponseSource.h.
Modules/fetch/FetchResponse.cpp:

(WebCore::FetchResponse::consumeBodyAsStream):
(WebCore::FetchResponse::createReadableStream):

Modules/fetch/FetchResponse.h:
Modules/fetch/FetchResponse.idl:
Modules/fetch/FetchResponse.js:

(getter.body):
(clone):

WebCore.xcodeproj/project.pbxproj:
bindings/js/ReadableStream.cpp:

(WebCore::ReadableStream::tee):

bindings/js/ReadableStream.h:
bindings/js/WebCoreBuiltinNames.h:

LayoutTests:

http/wpt/fetch/request-clone-expected.txt: Added.
http/wpt/fetch/request-clone.html: Added.
http/wpt/fetch/request-consume-stream-expected.txt: Added.
http/wpt/fetch/request-consume-stream.html: Added.
http/wpt/fetch/request-stream-disturbed-1-expected.txt: Added.
http/wpt/fetch/request-stream-disturbed-1.html: Added.
http/wpt/fetch/request-stream-disturbed-2-expected.txt: Added.
http/wpt/fetch/request-stream-disturbed-2.html: Added.
http/wpt/fetch/request-stream-disturbed-3-expected.txt: Added.
http/wpt/fetch/request-stream-disturbed-3.html: Added.

12:51 PM Changeset in webkit [221436] by fpizlo@apple.com

3 edits in trunk/Tools

WSL parser should pass the token as the origin to the AST
https://bugs.webkit.org/show_bug.cgi?id=176177

Reviewed by Keith Miller.

Parse.js was sometimes passing token.origin as the origin, but that's just the filename
component of the origin. This fixes the problem and adds a test. The test previously failed
because instead of reporting the origin of the type error as "<test>:1", it reported undefined.

WebGPUShadingLanguageRI/Parse.js:

(parseProtocolRef):
(consumeEndOfTypeArgs):
(parseTypeParameters):
(parseTerm):
(parseTypeArguments):
(parseType):
(parseTypeDef):
(parseNative):
(parseLeftOperatorCall):
(parsePossibleSuffix):
(parsePossiblePrefix):
(parsePossibleRelationalEquality):
(parseLeftLogicalExpression):
(parsePossibleTernaryConditional):
(parsePossibleAssignment):
(genericParseCommaExpression):
(parseReturn):
(parseVariableDecls):
(parseBlock):

WebGPUShadingLanguageRI/Test.js:

(checkFail):
(TEST_nameResolutionFailure):

12:42 PM Changeset in webkit [221435] by keith_miller@apple.com

2 edits in trunk/Tools

Add a filter argument to WSL test suite.
https://bugs.webkit.org/show_bug.cgi?id=176176

Reviewed by Filip Pizlo.

WebGPUShadingLanguageRI/Test.js:

(this.string_appeared_here.i.switch):
(let.s.in.this.s.startsWith.string_appeared_here.s.match):
(let.s.in.this.s.startsWith): Deleted.

12:33 PM Changeset in webkit [221434] by fpizlo@apple.com

18 edits in trunk/Tools

WSL should be able to run a program that uses generics
https://bugs.webkit.org/show_bug.cgi?id=176152

Reviewed by Keith Miller.

This fixes the WSL parser and type checker to the point that we can:

Parse a function call!
Type check a generic function call with an inferred type parameter.
Instantiate a generic function.
Inline a function call.
Evaluate an inlined function call.

This also changes the test suite so that it's a little nicer to add new tests. Functions whose
names start with "TEST_" are tests.

WebGPUShadingLanguageRI/Checker.js:

(Checker.prototype.visitProtocolDecl.set throw):

WebGPUShadingLanguageRI/EBufferBuilder.js:

(EBufferBuilder.prototype.visitFuncParameter):
(EBufferBuilder):

WebGPUShadingLanguageRI/Evaluator.js:

(Evaluator.prototype.visitFunctionLikeBlock):

WebGPUShadingLanguageRI/FuncDef.js:

(FuncDef.prototype.toString):
(FuncDef):

WebGPUShadingLanguageRI/FuncInstantiator.js:

(FuncInstantiator.prototype.getUnique):
(FuncInstantiator):

WebGPUShadingLanguageRI/Inliner.js:

(Inliner.prototype.visitCallExpression):
(Inliner):

WebGPUShadingLanguageRI/Lexer.js:

(Lexer):

WebGPUShadingLanguageRI/NameContext.js:

(NameContext):
(NameContext.prototype.add):
(NameContext.prototype.get let):
(NameContext.prototype.defineAll):
(NameContext.get intrinsics): Deleted.
(NameContext.set program): Deleted.
(NameContext.get program): Deleted.

WebGPUShadingLanguageRI/NameResolver.js:

(NameResolver.prototype.visitProgram):

WebGPUShadingLanguageRI/Parse.js:

(parseTerm):
(parsePossibleSuffix):
(genericParseCommaExpression):
(parseReturn):

WebGPUShadingLanguageRI/Program.js:

(Program.prototype.resolveFuncOverload):

WebGPUShadingLanguageRI/ProtocolDecl.js:

(ProtocolDecl.prototype.inherits):

WebGPUShadingLanguageRI/ResolveOverloadImpl.js:

(resolveOverloadImpl):

WebGPUShadingLanguageRI/Rewriter.js:

(Rewriter.prototype.visitFuncParameter):
(Rewriter.prototype.visitCallExpression):
(Rewriter.prototype._map): Deleted.

WebGPUShadingLanguageRI/Test.js:

(checkInt):
(TEST_add1):
(TEST_simpleGeneric):
(let.s.in.this.s.startsWith):
(load): Deleted.

WebGPUShadingLanguageRI/TypeVariable.js:

(TypeVariable.prototype.typeVariableUnify):

WebGPUShadingLanguageRI/UnificationContext.js:

(UnificationContext.prototype.union):

12:20 PM Changeset in webkit [221433] by achristensen@apple.com

7 edits
1 add in trunk

Add WKUIDelegatePrivate equivalent of WKPageUIClient's didClickAutoFillButton
https://bugs.webkit.org/show_bug.cgi?id=176139
<rdar://problem/29270035>

Reviewed by Tim Horton.

Source/WebKit:

Covered by a cool new API test!

UIProcess/API/Cocoa/WKUIDelegatePrivate.h:
UIProcess/Cocoa/UIDelegate.h:
UIProcess/Cocoa/UIDelegate.mm:

(WebKit::UIDelegate::setDelegate):
(WebKit::UIDelegate::UIClient::didClickAutoFillButton):

Tools:

TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
TestWebKitAPI/Tests/WebKitCocoa/ClickAutoFillButton.mm: Added.

(didClickAutoFillButton):
(-[ClickAutoFillButton webProcessPlugIn:didCreateBrowserContextController:]):

TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:

(-[AutoFillDelegate _webView:didClickAutoFillButtonWithUserInfo:]):
(-[AutoFillDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
(TEST):

12:09 PM WebKitGTK/Gardening/Calendar edited by clopez@igalia.com

(diff)

12:05 PM Changeset in webkit [221432] by clopez@igalia.com

3 edits in trunk/LayoutTests

[GTK][WPE] Mark test media/event-queue-crash as flaky
https://bugs.webkit.org/show_bug.cgi?id=176174

Unreviewed gardening.

platform/gtk/TestExpectations:
platform/wpe/TestExpectations:

11:52 AM Changeset in webkit [221431] by Chris Dumez

5 edits in trunk/Source

Use WTF::crossThreadCopy() in more places
https://bugs.webkit.org/show_bug.cgi?id=176169

Reviewed by Andreas Kling.

Use WTF::crossThreadCopy() in more places to make code more concise.

Source/WebCore:

Modules/indexeddb/IDBValue.cpp:

(WebCore::IDBValue::setAsIsolatedCopy):

Source/WebKit:

UIProcess/WebResourceLoadStatisticsStore.cpp:

(WebKit::WebResourceLoadStatisticsStore::removeDataRecords):
(WebKit::WebResourceLoadStatisticsStore::grandfatherExistingWebsiteData):
(WebKit::WebResourceLoadStatisticsStore::scheduleCookiePartitioningUpdateForDomains):
(WebKit::WebResourceLoadStatisticsStore::updateCookiePartitioning):
(WebKit::WebResourceLoadStatisticsStore::updateCookiePartitioningForDomains):

UIProcess/WebsiteData/WebsiteDataStore.cpp:

(WebKit::WebsiteDataStore::fetchDataForTopPrivatelyControlledDomains):

11:48 AM Changeset in webkit [221430] by jer.noble@apple.com

3 edits in trunk/Source/WebCore

MSE-to-Canvas painting can become "stuck" during heavy workloads
https://bugs.webkit.org/show_bug.cgi?id=176170

Reviewed by Eric Carlson.

During heavy workloads, the trigger from CMBufferQueue notifying us that we have dipped below
the "low-water mark" of decoded (and decoding) frames will not fire. Instead of using a trigger
(since it will not fire when the number of "frames being decoded" changes, just the number of
decoded frames), just call maybeBecomeReadyForMoreMediaData() whenever the number of frames in
the decoded queue decreases, or when the number of frames being decoded decreases.

platform/graphics/cocoa/WebCoreDecompressionSession.h:
platform/graphics/cocoa/WebCoreDecompressionSession.mm:

(WebCore::WebCoreDecompressionSession::maybeBecomeReadyForMoreMediaData):
(WebCore::WebCoreDecompressionSession::enqueueSample):
(WebCore::WebCoreDecompressionSession::decodeSample):
(WebCore::WebCoreDecompressionSession::handleDecompressionOutput):
(WebCore::WebCoreDecompressionSession::getFirstVideoFrame):
(WebCore::WebCoreDecompressionSession::automaticDequeue):
(WebCore::WebCoreDecompressionSession::imageForTime):
(WebCore::WebCoreDecompressionSession::maybeBecomeReadyForMoreMediaDataCallback): Deleted.

11:37 AM Changeset in webkit [221429] by Jonathan Bedard

2 edits in trunk/LayoutTests

iOS should include both iPad and iPhone when running layout tests
https://bugs.webkit.org/show_bug.cgi?id=176172
<rdar://problem/34190219>

Reviewed by Tim Horton.

resources/ui-helper.js:

(window.UIHelper.isIOS):

11:31 AM Changeset in webkit [221428] by commit-queue@webkit.org

3 edits
4 adds in trunk

Take into account removed caches in Caches::remove assertion
https://bugs.webkit.org/show_bug.cgi?id=176164

Patch by Youenn Fablet <youenn@apple.com> on 2017-08-31
Reviewed by Alex Christensen.

Source/WebKit:

NetworkProcess/cache/CacheStorageEngineCaches.cpp:

(WebKit::CacheStorage::Caches::remove):

LayoutTests:

http/wpt/cache-storage/cache-remove-twice-expected.txt: Added.
http/wpt/cache-storage/cache-remove-twice.html: Added.
http/wpt/cache-storage/resources/cache-remove-twice-iframe.html: Added.

11:21 AM Changeset in webkit [221427] by commit-queue@webkit.org

6 edits in trunk/Source/WebCore

Move consume promise from FetchBody to FetchBodyConsumer
https://bugs.webkit.org/show_bug.cgi?id=176121

Patch by Youenn Fablet <youenn@apple.com> on 2017-08-31
Reviewed by Alex Christensen.

No change of behavior.

FetchBodyConsumer should be made responsible for data consumption through promise getters and ReadableStream.
This will allow making data consumption consistent for Request and Response.
This patch is doing the first step.

Modules/fetch/FetchBody.cpp:

(WebCore::FetchBody::consumeOnceLoadingFinished):
(WebCore::FetchBody::consumeBlob):
(WebCore::FetchBody::loadingFailed):
(WebCore::FetchBody::loadingSucceeded):
(WebCore::FetchBody::clone const):

Modules/fetch/FetchBody.h:

(WebCore::FetchBody::cleanConsumer):
(WebCore::FetchBody::cleanConsumePromise): Deleted.

Modules/fetch/FetchBodyConsumer.cpp:

(WebCore::FetchBodyConsumer::setConsumePromise):
(WebCore::FetchBodyConsumer::loadingFailed):
(WebCore::FetchBodyConsumer::loadingSucceeded):
(WebCore::FetchBodyConsumer::clean):

Modules/fetch/FetchBodyConsumer.h:

(WebCore::FetchBodyConsumer::clean): Deleted.

Modules/fetch/FetchBodyOwner.cpp:

(WebCore::FetchBodyOwner::stop):

11:19 AM Changeset in webkit [221426] by commit-queue@webkit.org

7 edits in trunk/Source/WebKit

Do not create a salt if the CacheStorage engine should not persist
https://bugs.webkit.org/show_bug.cgi?id=176138

Patch by Youenn Fablet <youenn@apple.com> on 2017-08-31
Reviewed by Alex Christensen.

NetworkProcess/cache/CacheStorageEngine.cpp:

(WebKit::CacheStorage::Engine::~Engine): Ensuring that Caches will not try using the engine if it goes away.
(WebKit::CacheStorage::Engine::initialize): Removing making a salt if engine data is not persistent.

NetworkProcess/cache/CacheStorageEngine.h: Check persistency according the root path. If it is null, caches should not try to do persistency.
NetworkProcess/cache/CacheStorageEngineCaches.cpp:

(WebKit::CacheStorage::cachesRootPath):
(WebKit::CacheStorage::Caches::initialize):
(WebKit::CacheStorage::Caches::detach):
(WebKit::CacheStorage::Caches::readCachesFromDisk):
(WebKit::CacheStorage::Caches::writeCachesToDisk):

NetworkProcess/cache/CacheStorageEngineCaches.h:

(WebKit::CacheStorage::Caches::shouldPersist const):

NetworkProcess/cache/NetworkCacheData.cpp: Making makeSalt private again.

(WebKit::NetworkCache::makeSalt):

NetworkProcess/cache/NetworkCacheData.h:

11:15 AM Changeset in webkit [221425] by pvollan@apple.com

2 edits in trunk/Source/WTF

[Win] Crash under WorkQueue::performWorkOnRegisteredWorkThread in layout tests.
https://bugs.webkit.org/show_bug.cgi?id=176163

Reviewed by Alex Christensen.

My previous attempt at fixing this crash in <http://trac.webkit.org/changeset/221323>
was incorrect, since it is still crashing on the bot(s). The current theory of why this
is failing is that the WorkQueue object deletes itself in the middle of the
performWorkOnRegisteredWorkThread method when calling deref(). There is no need to
increase the reference count of the work queue for each function we want to call on the
work thread. It is sufficient to increase it for every work thread we start, and then
dereference it when the thread ends. We should also not attempt to access members after
the deref() call, which can potentially be unsafe.

wtf/win/WorkQueueWin.cpp:

(WTF::WorkQueue::workThreadCallback):
(WTF::WorkQueue::performWorkOnRegisteredWorkThread):
(WTF::WorkQueue::dispatch):

11:09 AM Changeset in webkit [221424] by Michael Catanzaro

2 edits in trunk/LayoutTests

Unreviewed, remove crash expectation for hopefully-fixed test
https://bugs.webkit.org/show_bug.cgi?id=175577

platform/gtk/TestExpectations:

9:55 AM Changeset in webkit [221423] by Darin Adler

6 edits in trunk

REGRESSION (r220052): ASSERTION FAILED: !frame().isMainFrame()

!needsStyleRecalcOrLayout() in WebCore::FrameView::updateLayoutAndStyleIfNeededRecursive()

https://bugs.webkit.org/show_bug.cgi?id=175270

Reviewed by Simon Fraser and Antti Koivisto.

Source/WebCore:

dom/Document.cpp:

(WebCore::Document::Document): Initialize m_styleRecalcTimer with a lamdba so it can work
with a function that returns a bool and ignore the return value.
(WebCore::Document::updateStyleIfNeeded): Added a boolean return value indicating if the
function did any work or not.

dom/Document.h: Updated for above change.

page/FrameView.cpp:

(WebCore::appendRenderedChildren): Added helper that will later replace the
FrameView::renderedChildFrameViews function and is used below.
(WebCore::FrameView::updateLayoutAndStyleIfNeededRecursive): Instead of always doing two
passes of style and layout update do up to 25 passes, but stop as soon as a pass does
no work. This is slightly more efficient in cases where no layout and style update is
needed, and works correctly when a additional passes are needed, which is what happens
in the test that was failing. We can eventually improve this further, but this resolves
the immediate problem we are seeing in the test.

LayoutTests:

platform/mac-wk2/TestExpectations: Re-enable the disabled test.

9:38 AM Changeset in webkit [221422] by fpizlo@apple.com

42 edits
3 adds in trunk

JSTests:
Unreviewed, skipping slow tests.

These tests are now timing out. They would have always been slow. The timeouts are probably because OOMs
work differently now.

stress/regexp-prototype-exec-on-too-long-rope.js:
stress/string-prototype-charCodeAt-on-too-long-rope.js:

Source/bmalloc:
Strings need to be in some kind of gigacage
https://bugs.webkit.org/show_bug.cgi?id=174924

Reviewed by Oliver Hunt.

This adds a StringGigacage.

bmalloc/Gigacage.cpp:
bmalloc/Gigacage.h:

(Gigacage::name):
(Gigacage::basePtr):
(Gigacage::forEachKind):

bmalloc/HeapKind.h:

(bmalloc::isGigacage):
(bmalloc::gigacageKind):
(bmalloc::heapKind):

Source/JavaScriptCore:
Strings need to be in some kind of gigacage
https://bugs.webkit.org/show_bug.cgi?id=174924

Reviewed by Oliver Hunt.

runtime/JSString.cpp:

(JSC::JSRopeString::resolveRopeToAtomicString const):
(JSC::JSRopeString::resolveRope const):

runtime/JSString.h:

(JSC::JSString::create):
(JSC::JSString::createHasOtherOwner):

runtime/JSStringBuilder.h:
runtime/VM.h:

(JSC::VM::gigacageAuxiliarySpace):

Source/WebCore:
Strings need to be in some kind of gigacage
https://bugs.webkit.org/show_bug.cgi?id=174924

Reviewed by Oliver Hunt.

No new tests because no new behavior.

html/canvas/CanvasRenderingContext2D.cpp:

(WebCore::normalizeSpaces):

Source/WTF:
Strings need to be in some kind of gigacage
https://bugs.webkit.org/show_bug.cgi?id=174924

Reviewed by Oliver Hunt.

This makes all strings allocations come from the string gigacage. Because we expect string allocation
to be a hot path, I created specialized allocation paths for the string gigacage. These paths are
accessible via <wtf/text/StringMalloc.h>. However, those paths are equivalent to saying
Gigacage::malloc and friends with the Gigacage::String kind.

WTF.xcodeproj/project.pbxproj:
wtf/CMakeLists.txt:
wtf/Deque.h:
wtf/FastMalloc.cpp:

(WTF::fastFree):

wtf/FastMalloc.h:

(WTF::FastMalloc::malloc):
(WTF::FastMalloc::tryMalloc):
(WTF::FastMalloc::realloc):
(WTF::FastMalloc::free):

wtf/Forward.h:
wtf/Gigacage.cpp:

(Gigacage::tryMalloc):

wtf/Gigacage.h:

(Gigacage::name):

wtf/Vector.h:

(WTF::VectorBufferBase::allocateBuffer):
(WTF::VectorBufferBase::tryAllocateBuffer):
(WTF::VectorBufferBase::reallocateBuffer):
(WTF::VectorBufferBase::deallocateBuffer):
(WTF::Malloc>::Vector):
(WTF::=):
(WTF::Malloc>::contains const):
(WTF::Malloc>::findMatching const):
(WTF::Malloc>::find const):
(WTF::Malloc>::reverseFind const):
(WTF::Malloc>::appendIfNotContains):
(WTF::Malloc>::fill):
(WTF::Malloc>::appendRange):
(WTF::Malloc>::expandCapacity):
(WTF::Malloc>::tryExpandCapacity):
(WTF::Malloc>::resize):
(WTF::Malloc>::resizeToFit):
(WTF::Malloc>::shrink):
(WTF::Malloc>::grow):
(WTF::Malloc>::asanSetInitialBufferSizeTo):
(WTF::Malloc>::asanSetBufferSizeToFullCapacity):
(WTF::Malloc>::asanBufferSizeWillChangeTo):
(WTF::Malloc>::reserveCapacity):
(WTF::Malloc>::tryReserveCapacity):
(WTF::Malloc>::reserveInitialCapacity):
(WTF::Malloc>::shrinkCapacity):
(WTF::Malloc>::append):
(WTF::Malloc>::tryAppend):
(WTF::Malloc>::constructAndAppend):
(WTF::Malloc>::tryConstructAndAppend):
(WTF::Malloc>::appendSlowCase):
(WTF::Malloc>::constructAndAppendSlowCase):
(WTF::Malloc>::tryConstructAndAppendSlowCase):
(WTF::Malloc>::uncheckedAppend):
(WTF::Malloc>::appendVector):
(WTF::Malloc>::insert):
(WTF::Malloc>::insertVector):
(WTF::Malloc>::remove):
(WTF::Malloc>::removeFirst):
(WTF::Malloc>::removeFirstMatching):
(WTF::Malloc>::removeAll):
(WTF::Malloc>::removeAllMatching):
(WTF::Malloc>::reverse):
(WTF::Malloc>::map const):
(WTF::Malloc>::releaseBuffer):
(WTF::Malloc>::checkConsistency):
(WTF::swap):
(WTF::operator==):
(WTF::operator!=):
(WTF::removeRepeatedElements):
(WTF::minCapacity>::Vector): Deleted.
(WTF::minCapacity>::contains const): Deleted.
(WTF::minCapacity>::findMatching const): Deleted.
(WTF::minCapacity>::find const): Deleted.
(WTF::minCapacity>::reverseFind const): Deleted.
(WTF::minCapacity>::appendIfNotContains): Deleted.
(WTF::minCapacity>::fill): Deleted.
(WTF::minCapacity>::appendRange): Deleted.
(WTF::minCapacity>::expandCapacity): Deleted.
(WTF::minCapacity>::tryExpandCapacity): Deleted.
(WTF::minCapacity>::resize): Deleted.
(WTF::minCapacity>::resizeToFit): Deleted.
(WTF::minCapacity>::shrink): Deleted.
(WTF::minCapacity>::grow): Deleted.
(WTF::minCapacity>::asanSetInitialBufferSizeTo): Deleted.
(WTF::minCapacity>::asanSetBufferSizeToFullCapacity): Deleted.
(WTF::minCapacity>::asanBufferSizeWillChangeTo): Deleted.
(WTF::minCapacity>::reserveCapacity): Deleted.
(WTF::minCapacity>::tryReserveCapacity): Deleted.
(WTF::minCapacity>::reserveInitialCapacity): Deleted.
(WTF::minCapacity>::shrinkCapacity): Deleted.
(WTF::minCapacity>::append): Deleted.
(WTF::minCapacity>::tryAppend): Deleted.
(WTF::minCapacity>::constructAndAppend): Deleted.
(WTF::minCapacity>::tryConstructAndAppend): Deleted.
(WTF::minCapacity>::appendSlowCase): Deleted.
(WTF::minCapacity>::constructAndAppendSlowCase): Deleted.
(WTF::minCapacity>::tryConstructAndAppendSlowCase): Deleted.
(WTF::minCapacity>::uncheckedAppend): Deleted.
(WTF::minCapacity>::appendVector): Deleted.
(WTF::minCapacity>::insert): Deleted.
(WTF::minCapacity>::insertVector): Deleted.
(WTF::minCapacity>::remove): Deleted.
(WTF::minCapacity>::removeFirst): Deleted.
(WTF::minCapacity>::removeFirstMatching): Deleted.
(WTF::minCapacity>::removeAll): Deleted.
(WTF::minCapacity>::removeAllMatching): Deleted.
(WTF::minCapacity>::reverse): Deleted.
(WTF::minCapacity>::map const): Deleted.
(WTF::minCapacity>::releaseBuffer): Deleted.
(WTF::minCapacity>::checkConsistency): Deleted.

wtf/text/AtomicStringImpl.h:
wtf/text/CString.cpp:

(WTF::CStringBuffer::createUninitialized):

wtf/text/CString.h:
wtf/text/StringBuffer.h:

(WTF::StringBuffer::StringBuffer):
(WTF::StringBuffer::~StringBuffer):
(WTF::StringBuffer::resize):

wtf/text/StringImpl.cpp:

(WTF::StringImpl::~StringImpl):
(WTF::StringImpl::destroy):
(WTF::StringImpl::createUninitializedInternalNonEmpty):
(WTF::StringImpl::reallocateInternal):
(WTF::StringImpl::releaseAssertCaged const):

wtf/text/StringImpl.h:

(WTF::StringImpl::createSubstringSharingImpl):
(WTF::StringImpl::tryCreateUninitialized):
(WTF::StringImpl::adopt):
(WTF::StringImpl::bufferOwnership const):
(WTF::StringImpl::assertCaged const):

wtf/text/StringMalloc.cpp: Added.

(WTF::tryStringMalloc):
(WTF::stringMalloc):
(WTF::stringRealloc):
(WTF::stringFree):

wtf/text/StringMalloc.h: Added.

(WTF::StringMalloc::malloc):
(WTF::StringMalloc::tryMalloc):
(WTF::StringMalloc::realloc):
(WTF::StringMalloc::free):

wtf/text/StringVector.h: Added.
wtf/text/SymbolImpl.h:
wtf/text/UniquedStringImpl.h:
wtf/text/WTFString.h:

(WTF::String::adopt):
(WTF::String::assertCaged const):
(WTF::String::releaseAssertCaged const):

8:23 AM Changeset in webkit [221421] by jmarcell@apple.com

2 edits in branches/safari-604-branch/Tools

Cherry-pick r220296. rdar://problem/34177414

7:10 AM Changeset in webkit [221420] by Carlos Garcia Campos

4 edits in trunk

[GTK] Several InputMethodFilter tests are failing and crashing
https://bugs.webkit.org/show_bug.cgi?id=176158

Reviewed by Carlos Alberto Lopez Perez.

Source/WebKit:

UIProcess/gtk/InputMethodFilter.cpp:

(WebKit::InputMethodFilter::confirmCurrentComposition): Return early in testing mode because the page is not available.
(WebKit::InputMethodFilter::logHandleKeyboardEventWithCompositionResultsForTesting): Use hexadecimal numbers for
logging key codes.

Tools:

This started to happen after the GTK+ upgrade from 3.16 to 3.22 in the internal jhbuild. Now, GtkIMContext
doesn't emit the preedit signals when using the compose key (GDK_KEY_Multi_key). The composition results are
committed directly when they are ready. The test InputMethodFilterComposeKey was failing because it expected
preedit events that no longer happen. Tests InputMethodFilterContextFocusOutDuringOngoingComposition and
InputMethodFilterContextMouseClickDuringOngoingComposition were crashing because InputMethodFilter::confirmCurrentComposition()
accessed the WebPageProxy unconditionally, that is not available in testing mode. I wonder how this ever
worked. Other tests results have also been updated because logHandleKeyboardEventWithCompositionResultsForTesting()
now uses hexadecimal numbers for the key codes, for consistency with all other event logs.

TestWebKitAPI/Tests/WebKit/gtk/InputMethodFilter.cpp:

(TestWebKitAPI::TestInputMethodFilter::TestInputMethodFilter):
(TestWebKitAPI::TEST):
(TestWebKitAPI::verifyCanceledComposition): Deleted.

7:07 AM Changeset in webkit [221419] by Carlos Garcia Campos

8 edits in trunk

[GTK][Wayland] Crash when gdk_keymap_get_entries_for_keyval returns TRUE but n_keys=0
https://bugs.webkit.org/show_bug.cgi?id=176154

Reviewed by Carlos Alberto Lopez Perez.

Source/WebKit:

In Wayland gdk_keymap_get_entries_for_keyval() can return TRUE with n_keys=0. We have several places in WebKit
where we just check the return value of gdk_keymap_get_entries_for_keyval() and then use the returned array to
get the first position assuming it has at least one item. This has always worked in X11 because the GDK X11
backend does the right thing, but it's crashing in Wayland now. It should be fixed in GTK+ but in the meantime
it's easy to workaround by also checking n_keys > 0.

UIProcess/Automation/gtk/WebAutomationSessionGtk.cpp:

(WebKit::doKeyStrokeEvent):

Tools:

Also check the n_keys > 0 when using gdk_keymap_get_entries_for_keyval().

TestWebKitAPI/Tests/WebKit/gtk/InputMethodFilter.cpp:

(TestWebKitAPI::TestInputMethodFilter::sendKeyEventToFilter):

TestWebKitAPI/Tests/WebKitGtk/TestPrinting.cpp: Remove duplicated code and use WebViewTest::keyStroke instead.
TestWebKitAPI/glib/WebKitGLib/gtk/WebViewTestGtk.cpp:

(WebViewTest::keyStroke):

TestWebKitAPI/gtk/PlatformWebViewGtk.cpp:

(TestWebKitAPI::doKeyStroke):

WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:

(WTR::EventSenderProxy::keyDown):

5:57 AM Changeset in webkit [221418] by commit-queue@webkit.org

2 edits in trunk/LayoutTests

[GTK] Mark some tests as passing.
https://bugs.webkit.org/show_bug.cgi?id=176156

Unreviewed test gardening.

Patch by Ms2ger <Ms2ger@igalia.com> on 2017-08-31

platform/gtk/TestExpectations:
- fast/hidpi/percent-height-image-nested.html: passing since test change in r217943.
- fast/ruby/bopomofo.html: passing since r216874.
- fast/ruby/bopomofo-letter-spacing.html: passing since r216874.
- fast/ruby/bopomofo-rl.html: passing since r216874.
- fast/sub-pixel/sub-pixel-composited-layers.html: passing since r215179.
- fast/text/font-weight-download-2.html: passing since r216944.
- fast/text/justify-ideograph-vertical.html: passing since r216874.
- fast/text/multiglyph-characters.html: passing since r216817.
- http/tests/misc/will-send-request-returns-null-on-redirect.html: passing since r214245.
- http/tests/security/contentSecurityPolicy/video-with-https-url-allowed-by-csp-media-src-star.html: passing since r211627.
- imported/w3c/web-platform-tests/css/css-ui-3/text-overflow-005.html: has been passing all along on GTK.
- imported/w3c/web-platform-tests/fetch/api/basic/error-after-response.html: passing since r218269-r218276.
- imported/w3c/web-platform-tests/fetch/api/redirect/redirect-count-cross-origin.html: matching expectations since rebaseline in r215164.
- imported/w3c/web-platform-tests/fetch/api/redirect/redirect-count-cross-origin-worker.html: matching expectations since rebaseline in r215164.
- imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/readyState_during_canplaythrough.html: passing since r218248.

3:04 AM Changeset in webkit [221417] by Yusuke Suzuki

58 edits
4 adds in trunk

[JSC] Use reifying system for "name" property of builtin JSFunction
https://bugs.webkit.org/show_bug.cgi?id=175260

Reviewed by Saam Barati.

JSTests:

stress/accessors-get-set-prefix.js:
stress/builtin-function-name.js: Added.

(shouldBe):
(shouldThrow):
(shouldBe.JSON.stringify.Object.getOwnPropertyDescriptor):
(shouldBe.JSON.stringify.Object.getOwnPropertyNames.Array.prototype.filter.sort):

stress/private-name-as-anonymous-builtin.js: Added.

(shouldBe):
(NotPromise):

Source/JavaScriptCore:

Currently builtin JSFunction uses direct property for "name", which is different
from usual JSFunction. Usual JSFunction uses reifying system for "name". We would like
to apply this reifying mechanism to builtin JSFunction to simplify code and drop
JSFunction::createBuiltinFunction.

We would like to store the "correct" name in FunctionExecutable. For example,
we would like to store the name like "get [Symbol.species]" to FunctionExecutable
instead of specifying name when creating JSFunction. To do so, we add a new
annotations, @getter and @overriddenName. When @getter is specified, the name of
the function becomes "get xxx". And when @overriddenName="xxx" is specified,
the name of the function becomes "xxx".

We also treat @xxx as anonymous builtin functions that cannot be achieved in
the current JS without privilege.

Scripts/builtins/builtins_generate_combined_header.py:

(generate_section_for_code_table_macro):

Scripts/builtins/builtins_generate_combined_implementation.py:

(BuiltinsCombinedImplementationGenerator.generate_secondary_header_includes):

Scripts/builtins/builtins_generate_separate_header.py:

(generate_section_for_code_table_macro):

Scripts/builtins/builtins_generate_separate_implementation.py:

(BuiltinsSeparateImplementationGenerator.generate_secondary_header_includes):

Scripts/builtins/builtins_model.py:

(BuiltinFunction.init):
(BuiltinFunction.fromString):

Scripts/builtins/builtins_templates.py:
Scripts/tests/builtins/JavaScriptCore-Builtin.prototype-Combined.js:

(overriddenName.string_appeared_here.match):
(intrinsic.RegExpTestIntrinsic.test):

Scripts/tests/builtins/JavaScriptCore-Builtin.prototype-Separate.js:

(overriddenName.string_appeared_here.match):
(intrinsic.RegExpTestIntrinsic.test):

Scripts/tests/builtins/expected/JavaScriptCore-Builtin.Promise-Combined.js-result:
Scripts/tests/builtins/expected/JavaScriptCore-Builtin.Promise-Separate.js-result:
Scripts/tests/builtins/expected/JavaScriptCore-Builtin.prototype-Combined.js-result:
Scripts/tests/builtins/expected/JavaScriptCore-Builtin.prototype-Separate.js-result:
Scripts/tests/builtins/expected/JavaScriptCore-BuiltinConstructor-Combined.js-result:
Scripts/tests/builtins/expected/JavaScriptCore-BuiltinConstructor-Separate.js-result:
Scripts/tests/builtins/expected/JavaScriptCore-InternalClashingNames-Combined.js-result:
Scripts/tests/builtins/expected/WebCore-AnotherGuardedInternalBuiltin-Separate.js-result:
Scripts/tests/builtins/expected/WebCore-ArbitraryConditionalGuard-Separate.js-result:
Scripts/tests/builtins/expected/WebCore-GuardedBuiltin-Separate.js-result:
Scripts/tests/builtins/expected/WebCore-GuardedInternalBuiltin-Separate.js-result:
Scripts/tests/builtins/expected/WebCore-UnguardedBuiltin-Separate.js-result:
Scripts/tests/builtins/expected/WebCore-xmlCasingTest-Separate.js-result:
builtins/AsyncIteratorPrototype.js:

(symbolAsyncIteratorGetter): Deleted.

builtins/BuiltinExecutables.cpp:

(JSC::BuiltinExecutables::BuiltinExecutables):

builtins/BuiltinExecutables.h:
builtins/BuiltinNames.h:
builtins/FunctionPrototype.js:

(symbolHasInstance): Deleted.

builtins/GlobalOperations.js:

(globalPrivate.speciesGetter): Deleted.

builtins/IteratorPrototype.js:

(symbolIteratorGetter): Deleted.

builtins/PromiseConstructor.js:

(all.newResolveElement.return.resolve):
(all.newResolveElement):
(all):

builtins/PromiseOperations.js:

(globalPrivate.newPromiseCapability.executor):
(globalPrivate.newPromiseCapability):
(globalPrivate.createResolvingFunctions.resolve):
(globalPrivate.createResolvingFunctions.reject):
(globalPrivate.createResolvingFunctions):

builtins/RegExpPrototype.js:

(match): Deleted.
(replace): Deleted.
(search): Deleted.
(split): Deleted.

jsc.cpp:

(functionCreateBuiltin):

runtime/AsyncIteratorPrototype.cpp:

(JSC::AsyncIteratorPrototype::finishCreation):

runtime/FunctionPrototype.cpp:

(JSC::FunctionPrototype::addFunctionProperties):

runtime/IteratorPrototype.cpp:

(JSC::IteratorPrototype::finishCreation):

runtime/JSFunction.cpp:

(JSC::JSFunction::finishCreation):
(JSC::JSFunction::getOwnNonIndexPropertyNames):
(JSC::JSFunction::reifyLazyBoundNameIfNeeded):
(JSC::JSFunction::createBuiltinFunction): Deleted.

runtime/JSFunction.h:
runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::init):

runtime/JSObject.cpp:

(JSC::JSObject::putDirectBuiltinFunction):
(JSC::JSObject::putDirectBuiltinFunctionWithoutTransition):

runtime/JSTypedArrayViewPrototype.cpp:

(JSC::JSTypedArrayViewPrototype::finishCreation):

runtime/Lookup.cpp:

(JSC::reifyStaticAccessor):

runtime/MapPrototype.cpp:

(JSC::MapPrototype::finishCreation):

runtime/RegExpPrototype.cpp:

(JSC::RegExpPrototype::finishCreation):

runtime/SetPrototype.cpp:

(JSC::SetPrototype::finishCreation):

Source/WebCore:

Test: js/dom/builtin-getter-name.html

Use @getter for JSBuiltin getters.

Modules/fetch/FetchResponse.js:

(bodyUsed): Deleted.
(body): Deleted.

Modules/streams/ReadableByteStreamController.js:

(byobRequest): Deleted.
(desiredSize): Deleted.

Modules/streams/ReadableStream.js:

(locked): Deleted.

Modules/streams/ReadableStreamBYOBReader.js:

(closed): Deleted.

Modules/streams/ReadableStreamBYOBRequest.js:

(view): Deleted.

Modules/streams/ReadableStreamDefaultController.js:

(desiredSize): Deleted.

Modules/streams/ReadableStreamDefaultReader.js:

(closed): Deleted.

Modules/streams/WritableStream.js:

(closed): Deleted.
(ready): Deleted.
(state): Deleted.

bindings/js/JSDOMBuiltinConstructor.h:

(WebCore::JSDOMBuiltinConstructor<JSClass>::finishCreation):

LayoutTests:

js/dom/builtin-getter-name-expected.txt: Added.
js/dom/builtin-getter-name.html: Added.

1:15 AM Changeset in webkit [221416] by Carlos Garcia Campos

2 edits in trunk/Tools

Unreviewed. Fix GTK+ test /webkit2/WebKitAutomationSession/request-session.

It fails when comparing the browser version if micro version is 0 (or if both micro and minor are 0 too).

TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp: Use a helper method to convert major, minor, micro

numbers into a version string, using the same approach as WebKitAutomationSession.

Note: See TracTimeline for information about the timeline view.

Download in other formats:

RSS Feed