Timeline
Sep 3, 2017:
- 11:52 PM Changeset in webkit [221574] by
-
- 2 edits in trunk/Source/WebKit
[Threaded Compositor] Deadlock in ThreadedDisplayRefreshMonitor
https://bugs.webkit.org/show_bug.cgi?id=176296
Reviewed by Žan Doberšek.
The main thread tries to schedule a display refresh monitor from RAF, requestDisplayRefreshMonitorUpdate() tries
to take the attributes lock to update coordinateUpdateCompletionWithClient. The compositing thread has finished
a frame and sceneUpdateFinished() takes the attributes lock to update clientRendersNextFrame and then asks the
display refresh monitor if it requires a new callback. ThreadedDisplayRefreshMonitor::requiresDisplayRefreshCallback()
takes its lock to check the state, and requestDisplayRefreshMonitorUpdate() was called by
ThreadedDisplayRefreshMonitor::requestRefreshCallback() with the display refresh monitor lock taken. So,
the compositing thread has the attributes lock and wants the display refresh monitor one, and main thread has the
display refresh monitor lock and wants the attributes one.
- Shared/CoordinatedGraphics/threadedcompositor/ThreadedDisplayRefreshMonitor.cpp:
(WebKit::ThreadedDisplayRefreshMonitor::requestRefreshCallback): Release the mutex before calling
ThreadedCompositor::requestDisplayRefreshMonitorUpdate().
- 11:09 PM WebKitGTK/2.18.x edited by
- (diff)
- 11:07 PM Changeset in webkit [221573] by
-
- 3 edits in trunk/Source/WebCore
Use StringView in DOMFileSystem::evaluatePath()
https://bugs.webkit.org/show_bug.cgi?id=176324
Reviewed by Darin Adler.
Use StringView in DOMFileSystem::evaluatePath() for performance.
- Modules/entriesapi/DOMFileSystem.cpp:
(WebCore::resolveRelativeVirtualPath):
(WebCore::DOMFileSystem::evaluatePath):
- Modules/entriesapi/DOMFileSystem.h:
- 11:04 PM Changeset in webkit [221572] by
-
- 4 edits1 add in trunk/Source
[GTK] Libgcrypt warning: missing initialization - please fix the application
https://bugs.webkit.org/show_bug.cgi?id=171230
Reviewed by Michael Catanzaro.
Source/WebCore/PAL:
Add the Initialization.h header, containing the single initialize() static
function that initializes the libgcrypt library. This header only includes
the default libgcrypt header, and nothing else.
It's not added to the existing Utilities.h header because that one pulls in
other unnecessary headers that for instance use the new() operator, but that
collides with the implementation files that define WebKit process entrypoints
and intentionally don't include the config.h that brings in FastMalloc to
properly define the new() and delete() operators, resulting in compilation
errors due to the new and delete operators being defined to warning strings
in always-included WebKit2Prefix.h.
- pal/crypto/gcrypt/Initialization.h: Copied from Source/WebKit/WebProcess/EntryPoint/unix/WebProcessMain.cpp.
(PAL::GCrypt::initialize):
Source/WebKit:
Replicate the libgcrypt initialization in the NetworkProcess entrypoint.
This is required due to libgcrypt being used through digest operations
originating from the certificate hash computation in SoupNetworkSession.
The initialization is moved to the PAL library, and the initialize()
function is now leveraged in both NetworkProcess and WebProcess entrypoints.
- NetworkProcess/EntryPoint/unix/NetworkProcessMain.cpp:
(main):
- WebProcess/EntryPoint/unix/WebProcessMain.cpp:
(main):
- 11:03 PM Changeset in webkit [221571] by
-
- 2 edits in trunk/Source/WebKit
[WPE] Use the device scale factor value in WebPageCreationParameters
https://bugs.webkit.org/show_bug.cgi?id=175377
Reviewed by Michael Catanzaro.
- WebProcess/WebPage/AcceleratedDrawingArea.cpp:
(WebKit::AcceleratedDrawingArea::AcceleratedDrawingArea):
WebPageCreationParameters::deviceScaleFactor value should be used
to set the device scale factor on the given WebPage object. This
enables correctly leveraging the scale factor for the WPE port
which enters accelerated mode unconditionally and as such doesn't
wait for the backing store update that would provide that value
otherwise.
- 10:58 PM Changeset in webkit [221570] by
-
- 2 edits in trunk/Source/WebKit
[WK2][iOS] Remove unnecessary IOHIDEventServiceFastPathUserClient access
https://bugs.webkit.org/show_bug.cgi?id=175947
<rdar://problem/33353627>
Reviewed by Darin Adler.
- Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:
- 9:08 PM Changeset in webkit [221569] by
-
- 2 edits in trunk/Source/WebCore/PAL
[Cocoa] Tidy up PassKitSPI.h
https://bugs.webkit.org/show_bug.cgi?id=176323
Reviewed by Darin Adler.
- pal/spi/cocoa/PassKitSPI.h: Moved the declarations of requiredShippingContactFields and requiredBillingContactFields to where other PKPaymentRequest properties are declared, and changed the guard to relate to the SDK version. Replaced use of has_include with checking for the version of the Apple internal SDK in which the typedefs first appeared.
- 8:33 PM Changeset in webkit [221568] by
-
- 2 edits in trunk/Source/WebKit
WKContentViewInteraction.mm includes redundant declaration of UIPreviewItemController's presentationSecondaryGestureRecognizer
https://bugs.webkit.org/show_bug.cgi?id=176322
Reviewed by Darin Adler.
- UIProcess/ios/WKContentViewInteraction.mm: Removed the declaration, which is already made in the SDK or in UIKitSPI.h.
- 8:27 PM Changeset in webkit [221567] by
-
- 2 edits in trunk/Tools
Make webkit-patch post --no-review enable EWS just like webkit-patch post-commits --no-review
https://bugs.webkit.org/show_bug.cgi?id=176321
Patch by Sam Weinig <sam@webkit.org> on 2017-09-03
Reviewed by Darin Adler.
- Scripts/webkitpy/tool/commands/upload.py:
Add the SubmitToEWS step to Post command
- 8:01 PM Changeset in webkit [221566] by
-
- 2 edits in trunk/Source/WebKit
Try to fix the iOS build
- UIProcess/RemoteLayerTree/ios/RemoteLayerTreeHostIOS.mm:
(-[WKRemoteView initWithFrame:contextID:]):
- 7:51 PM Changeset in webkit [221565] by
-
- 2 edits in trunk/Source/JavaScriptCore
Try to fix Windows build.
- runtime/JSGlobalObjectFunctions.cpp: #include <unicode/utf8.h>.
- 7:12 PM Changeset in webkit [221564] by
-
- 2 edits in trunk/Source/WebCore/PAL
[Cocoa] Remove use of has_include in CoreAudioSPI.h
https://bugs.webkit.org/show_bug.cgi?id=176320
Reviewed by Tim Horton.
- pal/spi/cf/CoreAudioSPI.h: AudioHardwarePriv.h is available in all Apple internal SDKs and only in Apple internal SDKs. AudioHardwareBase.h is available only in the macOS SDK, where it is included by AudioHardware.h.
- 6:40 PM Changeset in webkit [221563] by
-
- 13 edits in trunk/Source
Fix some style issues in the Remote Layer Tree code
https://bugs.webkit.org/show_bug.cgi?id=176298
Reviewed by Dan Bernstein.
Source/WebCore/PAL:
- pal/spi/cocoa/QuartzCoreSPI.h:
Source/WebKit:
In bugs 176273 and 176297, the style bot noticed some existing style
issues in the UI-side compositing code. Fix them, because there aren't
many and they're straightforward.
- Shared/RemoteLayerTree/RemoteLayerBackingStore.h:
- Shared/RemoteLayerTree/RemoteLayerBackingStoreCollection.h:
- Shared/RemoteLayerTree/RemoteLayerTreeTransaction.h:
- Shared/RemoteLayerTree/RemoteScrollingCoordinatorTransaction.h:
- UIProcess/RemoteLayerTree/RemoteLayerTreeDrawingAreaProxy.mm:
- UIProcess/RemoteLayerTree/RemoteLayerTreeScrollingPerformanceData.h:
- UIProcess/RemoteLayerTree/RemoteScrollingCoordinatorProxy.h:
- UIProcess/RemoteLayerTree/RemoteScrollingTree.h:
- UIProcess/RemoteLayerTree/ios/RemoteLayerTreeHostIOS.mm:
- UIProcess/RemoteLayerTree/ios/ScrollingTreeOverflowScrollingNodeIOS.h:
- 6:38 PM Changeset in webkit [221562] by
-
- 5 edits in trunk/Source
String#utf8() allocates new CString
https://bugs.webkit.org/show_bug.cgi?id=176302
Reviewed by Sam Weinig.
Source/WebCore:
Several places uses String#utf8() like an accessor. In reality, it allocates new CString per call.
It is very costly. Furthermore, some places uses this incorrectly. For example,
std::vector<char>(srtpAuth.utf8().data(), srtpAuth.utf8().data() + srtpAuth.utf8().length());
is incorrect since each time strpAuth.utf8() allocates different CString.
This patch calls utf8() first and use it.
- Modules/websockets/WebSocketChannel.cpp:
(WebCore::WebSocketChannel::startClosingHandshake):
- platform/wpe/PlatformPasteboardWPE.cpp:
(WebCore::PlatformPasteboard::write):
Source/WebKit:
- NetworkProcess/webrtc/NetworkRTCSocket.cpp:
(WebKit::NetworkRTCSocket::sendTo):
- 6:37 PM Changeset in webkit [221561] by
-
- 2 edits in trunk/Source/WebCore
[SOUP] Use fastMalloced SoupBuffer in ResourcehandleSoup
https://bugs.webkit.org/show_bug.cgi?id=176311
Reviewed by Michael Catanzaro.
Use fastMalloced memory instead of g_malloc for SoupBuffer.
- platform/network/soup/ResourceHandleSoup.cpp:
(WebCore::ResourceHandle::ensureReadBuffer):
- 6:00 PM Changeset in webkit [221560] by
-
- 4 edits in trunk/Source
[WTF] Add C++03 allocator interface for GCC < 6
https://bugs.webkit.org/show_bug.cgi?id=176301
Reviewed by Darin Adler.
Source/JavaScriptCore:
- dfg/DFGObjectAllocationSinkingPhase.cpp:
Source/WTF:
Unfortunately, std::list in GCC < 6 does not support C++11 allocator interface.
This patch adds C++03 allocator interface to FastAllocator to make it usable
for std::list. It also allows us to use FastAllocator for data structures that
only support C++03 interface.
- wtf/FastMalloc.h:
(WTF::FastAllocator::allocate):
(WTF::FastAllocator::construct):
(WTF::FastAllocator::destroy):
(WTF::FastAllocator::max_size const):
(WTF::FastAllocator::select_on_container_copy_construction const):
- 3:28 PM Changeset in webkit [221559] by
-
- 6 edits in trunk/Source/WebKitLegacy/mac
[Cocoa] Tidy a few things in legacy WebHTMLView
https://bugs.webkit.org/show_bug.cgi?id=176280
Reviewed by Dan Bernstein.
- WebCoreSupport/WebChromeClient.mm:
(WebChromeClient::attachRootGraphicsLayer): Made this function Mac-only, because the
methods it calls on WebHTMLView were doing nothing on iOS.
- WebView/WebFrame.mm:
(-[WebFrame _paintBehaviorForDestinationContext:]): Changed iOS code so that it no longer
depends on -[WebHTMLView _web_isDrawingIntoLayer], which always returned YES on iOS.
- WebView/WebHTMLView.mm: Define WebEvent on both iOS and Mac so more event handling
code can be shared without #if below. Use #if PLATFORM(MAC) instead of #if !PLATFORM(IOS)
in a lot more places. Move many of the SPI declarations up to the top in alphabetical
order. Removed all sorts of unused things. Made more code and fields Mac-only where
what was compiled was doing nothing on iOS and it makes the resulting code simpler.
Use RetainPtr instead of writing retain/release wherever possible.
(+[WebMenuTarget sharedMenuTarget]): Moved global inside this method and used C++
initialization for it. Removed various unused methods and declarations of methods.
(promisedDataClient): Use NeverDestroyed instead of just doing a "new" on the heap.
(-[WebHTMLView _imageExistsAtPaths:]): Deleted.
(-[WebHTMLView _documentFragmentWithPaths:]): Use RetainPtr and modern for loop.
(+[WebHTMLView _excludedElementsForAttributedStringConversion]): Use C++ initialization,
and remove CFRetain no longer needed since we don't support garbage collection any more.
(uniqueURLWithRelativePart): Simplified using [NSUUID UUID].
(-[WebHTMLView _plainTextFromPasteboard:]): Simplified with RetainPtr.
(-[WebHTMLView _pasteWithPasteboard:allowPlainText:]): Ditto.
(-[WebHTMLView _pasteAsPlainTextWithPasteboard:]): Ditto.
(-[WebHTMLView _removeWindowObservers]): Removed code dealing with empty
methods windowWillOrderOnScreen: and windowWillOrderOffScreen:.
(-[WebHTMLView _shouldDeleteRange:]): Deleted. Was unused.
(-[WebHTMLView _writeSelectionWithPasteboardTypes:toPasteboard:cachedAttributedString:]):
Simplified with stringByReplacingOccurrencesOfString and modern string literal syntax.
(-[WebHTMLView _setMouseDownEvent:]): Ditto.
(-[WebHTMLView _web_setPrintingModeRecursive:adjustViewSize:]): Added. Helper method so
the next three methhods can be super-simple. Used RetainPtr and a modern for loop to make
this method simpler than the functions it replaced. Also got rid of the enumeratingSubviews
debug flag; we haven't used it for years and it's not clearly helpful.
(-[WebHTMLView _web_setPrintingModeRecursive]): Turned into a one-liner with the above.
(-[WebHTMLView _web_clearPrintingModeRecursive]): Ditto.
(-[WebHTMLView _web_setPrintingModeRecursiveAndAdjustViewSize]): Ditto.
(-[WebHTMLView _web_makePluginSubviewsPerformSelector:withObject:]): Moved from the
WebInternal category to the WebHTMLViewFileInternal category so it can be called by
two additional methods in the WebPrivate category and still be called by the two
methods in the WebInternal category that were already using it.
(-[WebHTMLView didAddSubview:]): Deleted.
(-[WebHTMLView _insideAnotherHTMLView]): Deleted.
(-[WebHTMLView _clearLastHitViewIfSelf]): Deleted. Inlined the implementation in the one
place this was called, the close method.
(-[WebHTMLView _setToolTip:]): Simplified with RetainPtr.
(-[WebHTMLView pasteboard:provideDataForType:]): Ditto.
(-[WebHTMLView _autoscroll]): Simplified by making this Mac-only.
(-[WebHTMLView _hasHTMLDocument]): Deleted. The one caller was removed a long time ago.
(-[WebHTMLView _web_documentFragmentFromPasteboard:pasteboardType:imageMIMEType:]):
Added helper method to make the one below simpler.
(-[WebHTMLView _documentFragmentFromPasteboard:forType:inContext:subresources:]):
Compared pasteboard type strings using isEqualToString: rather than using == since
we want to actually compare the string contents. Also updated to use modern for loop,
renamed a local variable from "s" to "localSubresources", and factored out the handling
of three image types to use the helper method above.
(-[WebHTMLView _pauseNullEventsForAllNetscapePlugins]): Rewrite using the
_web_makePluginSubviewsPerformSelector:withObject: method.
(-[WebHTMLView _resumeNullEventsForAllNetscapePlugins]): Ditto.
(-[NSView _web_addDescendentWebHTMLViewsToArray:]): Fixed spelling to use the adjective
"descendent" rather than the noun "descendant". Also removed Mac-only optimization to
not call the -[NSView subviews] method to make this identical on both platforms and used
a modern for loop.
(-[NSMutableDictionary _web_setObjectIfNotNil:forKey:]): Deleted.
(-[WebHTMLView acceptsFirstResponder]): Reduced amount of platform-specific code by
defining WebEventMouseDown as a synonym for NSEventTypeLeftMouseDown on Mac.
(-[WebHTMLView addWindowObservers]): Removed code dealing with empty
methods windowWillOrderOnScreen: and windowWillOrderOffScreen:.
(-[WebHTMLView willRemoveSubview:]): Removed the enumeratingSubviews check.
(-[WebHTMLView drawSingleRect:]): Rearranged this method to make it clearer that most
of it is Mac-only.
(-[WebHTMLView windowWillOrderOnScreen:]): Deleted. All the current version of this
method did was call itself on the main thread, and do nothing if called on main thread.
(-[WebHTMLView windowWillOrderOffScreen:]): Deleted. Ditto.
(-[WebHTMLView _isSelectionEvent:]): Merged macOS and iOS versions.
(-[WebHTMLView resignFirstResponder]): Removed iOS-specific code in the macOS-specific
half of this method.
(-[WebHTMLView setDataSource:]): Simplified using RetainPtr.
(-[WebHTMLView _setPrinting:minimumPageLogicalWidth:logicalHeight:originalPageWidth:originalPageHeight:maximumShrinkRatio:adjustViewSize:paginateScreenContent:]):
Simplified using a modern for loop and RetainPtr.
(-[WebHTMLView knowsPageRange:]): Simplified using RetainPtr.
(-[WebHTMLView keyDown:]): Ditto.
(-[WebHTMLView _selectionStartFontAttributesAsRTF]): Ditto.
(-[WebHTMLView performKeyEquivalent:]): Ditto.
(-[WebHTMLView _styleForAttributeChange:]): Ditto.
(-[WebHTMLView complete:]): Ditto.
(-[WebHTMLView _windowChangedKeyState]): Removed iOS-specific code since this method is
now macOS-only.
(-[WebHTMLView _selectionChanged]): Removed call to _updateSelectionForInputManager on
iOS since that is now macOS-only.
(-[WebHTMLView promisedDragTIFFDataSource]): Deleted.
(-[WebHTMLView _startAutoscrollTimer:]): Moved this into an internal category instead of
a private one because it is not used or needed outside WebKit. Also made it macOS-only
and reorganized to use early return.
(-[WebHTMLView _stopAutoscrollTimer]): Moved into internal category. It remains a no-op
on iOS, but kept there so we don't have to do #if at every call site.
(-[WebHTMLView _pluginController]): Moved into internal category.
(-[WebHTMLView validAttributesForMarkedText]): Simplified by removing CFRetain that was
there only for GC, using C++ initialization, removing obsolete comment.
(-[WebHTMLView _updateSelectionForInputManager]): Made this macOS-only and removed
peculiar iOS-only comment.
(+[NSURL _web_uniqueWebDataURL]): Simplified using [NSUUID UUID].
- WebView/WebHTMLViewInternal.h: Removed unused promisedDragTIFFDataSource method.
Made attachRootLayer:, detachRootLayer, _web_isDrawingIntoLayer,
_web_isDrawingIntoAcceleratedLayer all macOS-only. Moved _startAutoscrollTimer:,
_stopAutoscrollTimer, and _pluginController here from SPI header since they aren't
needed or used as SPI. And made _startAutoscrollTimer macOS-only.
- WebView/WebHTMLViewPrivate.h: Removed unneeded and unused SPI: _insideAnotherHTMLView,
_clearLastHitViewIfSelf, _pluginController, _startAutoscrollTimer:, and _stopAutoscrollTimer.
Made _transparentBackground and _setTransparentBackground: macOS-only. These probably
are not needed on macOS either, but I wasn't able to make absolutely sure I could remove
them at this time.
- 3:03 PM Changeset in webkit [221558] by
-
- 13 edits in trunk
Have getFileMetadata() return a std::optional<FileMetadata>
https://bugs.webkit.org/show_bug.cgi?id=176293
Reviewed by Darin Adler.
Source/WebCore:
Have getFileMetadata() return a std::optional<FileMetadata> instead of
using an out parameter for the metadata.
- Modules/entriesapi/DOMFileSystem.cpp:
(WebCore::listDirectoryWithMetadata):
(WebCore::validatePathIsExpectedType):
(WebCore::DOMFileSystem::getEntry):
- html/FileListCreator.cpp:
(WebCore::appendDirectoryFiles):
- platform/FileSystem.cpp:
(WebCore::fileIsDirectory):
- platform/FileSystem.h:
- platform/glib/FileSystemGlib.cpp:
(WebCore::getFileMetadata):
- platform/network/BlobDataFileReference.cpp:
(WebCore::BlobDataFileReference::startTrackingModifications):
- platform/network/mac/BlobDataFileReferenceMac.mm:
(WebCore::BlobDataFileReference::generateReplacementFile):
- platform/posix/FileSystemPOSIX.cpp:
(WebCore::getFileMetadata):
- platform/win/FileSystemWin.cpp:
(WebCore::getFileMetadata):
Tools:
- TestWebKitAPI/Tests/WebCore/FileSystem.cpp:
(TestWebKitAPI::TEST_F):
- 2:55 PM Changeset in webkit [221557] by
-
- 2 edits in trunk/Source/JavaScriptCore
Unreviewed, rolling out r221555.
Did not fix Windows build
Reverted changeset:
"Unreviewed attempt to fix Windows build."
http://trac.webkit.org/changeset/221555
- 2:49 PM Changeset in webkit [221556] by
-
- 6 edits5 copies25 moves8 adds3 deletes in trunk/LayoutTests
Consolidate entries-api tests under entries-api/ folders
https://bugs.webkit.org/show_bug.cgi?id=176315
Reviewed by Darin Adler.
Consolidate entries-api tests under entries-api/ folders, for clarity.
Also drop an older test for directory upload which did not pass because
it was missing its resources. We now have good coverage for this feature
so this test is not needed.
- editing/pasteboard/enties-api/datatransfer-items-drop-directoryReader-error-expected.txt: Renamed from LayoutTests/editing/pasteboard/datatransfer-items-drop-directoryReader-error-expected.txt.
- editing/pasteboard/enties-api/datatransfer-items-drop-directoryReader-error.html: Renamed from LayoutTests/editing/pasteboard/datatransfer-items-drop-directoryReader-error.html.
- editing/pasteboard/enties-api/datatransfer-items-drop-directoryReader-expected.txt: Renamed from LayoutTests/editing/pasteboard/datatransfer-items-drop-directoryReader-expected.txt.
- editing/pasteboard/enties-api/datatransfer-items-drop-directoryReader-root-expected.txt: Renamed from LayoutTests/editing/pasteboard/datatransfer-items-drop-directoryReader-root-expected.txt.
- editing/pasteboard/enties-api/datatransfer-items-drop-directoryReader-root.html: Renamed from LayoutTests/editing/pasteboard/datatransfer-items-drop-directoryReader-root.html.
- editing/pasteboard/enties-api/datatransfer-items-drop-directoryReader.html: Renamed from LayoutTests/editing/pasteboard/datatransfer-items-drop-directoryReader.html.
- editing/pasteboard/enties-api/datatransfer-items-drop-fileEntry-file-expected.txt: Renamed from LayoutTests/editing/pasteboard/datatransfer-items-drop-fileEntry-file-expected.txt.
- editing/pasteboard/enties-api/datatransfer-items-drop-fileEntry-file.html: Renamed from LayoutTests/editing/pasteboard/datatransfer-items-drop-fileEntry-file.html.
- editing/pasteboard/enties-api/datatransfer-items-drop-getAsEntry-expected.txt: Renamed from LayoutTests/editing/pasteboard/datatransfer-items-drop-getAsEntry-expected.txt.
- editing/pasteboard/enties-api/datatransfer-items-drop-getAsEntry.html: Renamed from LayoutTests/editing/pasteboard/datatransfer-items-drop-getAsEntry.html.
- editing/pasteboard/enties-api/datatransfer-items-drop-getDirectory-expected.txt: Renamed from LayoutTests/editing/pasteboard/datatransfer-items-drop-getDirectory-expected.txt.
- editing/pasteboard/enties-api/datatransfer-items-drop-getDirectory.html: Renamed from LayoutTests/editing/pasteboard/datatransfer-items-drop-getDirectory.html.
- editing/pasteboard/enties-api/datatransfer-items-drop-getFile-expected.txt: Renamed from LayoutTests/editing/pasteboard/datatransfer-items-drop-getFile-expected.txt.
- editing/pasteboard/enties-api/datatransfer-items-drop-getFile.html: Renamed from LayoutTests/editing/pasteboard/datatransfer-items-drop-getFile.html.
- editing/pasteboard/enties-api/datatransfer-items-drop-getParent-expected.txt: Renamed from LayoutTests/editing/pasteboard/datatransfer-items-drop-getParent-expected.txt.
- editing/pasteboard/enties-api/datatransfer-items-drop-getParent-root-expected.txt: Renamed from LayoutTests/editing/pasteboard/datatransfer-items-drop-getParent-root-expected.txt.
- editing/pasteboard/enties-api/datatransfer-items-drop-getParent-root.html: Renamed from LayoutTests/editing/pasteboard/datatransfer-items-drop-getParent-root.html.
- editing/pasteboard/enties-api/datatransfer-items-drop-getParent.html: Renamed from LayoutTests/editing/pasteboard/datatransfer-items-drop-getParent.html.
- editing/pasteboard/enties-api/datatransfer-items-drop-getParent2-expected.txt: Renamed from LayoutTests/editing/pasteboard/datatransfer-items-drop-getParent2-expected.txt.
- editing/pasteboard/enties-api/datatransfer-items-drop-getParent2.html: Renamed from LayoutTests/editing/pasteboard/datatransfer-items-drop-getParent2.html.
- fast/forms/file/entries-api/resources/testFiles/file1.txt: Renamed from LayoutTests/fast/forms/file/resources/testFiles/file1.txt.
- fast/forms/file/entries-api/resources/testFiles/file2.txt: Renamed from LayoutTests/fast/forms/file/resources/testFiles/file2.txt.
- fast/forms/file/entries-api/resources/testFiles/subfolder1/file3.txt: Renamed from LayoutTests/fast/forms/file/resources/testFiles/subfolder1/file3.txt.
- fast/forms/file/entries-api/resources/testFiles/subfolder2/file4.txt: Renamed from LayoutTests/fast/forms/file/resources/testFiles/subfolder2/file4.txt.
- fast/forms/file/entries-api/resources/testFiles/subfolder2/subfolder2a/file5.txt: Renamed from LayoutTests/fast/forms/file/resources/testFiles/subfolder2/subfolder2a/file5.txt.
- fast/forms/file/entries-api/webkitdirectory-drag-folder-expected.txt: Renamed from LayoutTests/fast/forms/file/webkitdirectory-drag-folder-expected.txt.
- fast/forms/file/entries-api/webkitdirectory-drag-folder.html: Renamed from LayoutTests/fast/forms/file/webkitdirectory-drag-folder.html.
- fast/forms/file/entries-api/webkitdirectory-open-panel-expected.txt: Renamed from LayoutTests/fast/forms/file/webkitdirectory-open-panel-expected.txt.
- fast/forms/file/entries-api/webkitdirectory-open-panel.html: Renamed from LayoutTests/fast/forms/file/webkitdirectory-open-panel.html.
- fast/forms/file/input-file-directory-upload-expected.txt: Removed.
- fast/forms/file/input-file-directory-upload.html: Removed.
- platform/ios/TestExpectations:
- platform/mac-wk1/fast/forms/file/entries-api/webkitdirectory-open-panel-expected.txt: Renamed from LayoutTests/platform/mac-wk1/fast/forms/file/webkitdirectory-open-panel-expected.txt.
- platform/mac/TestExpectations:
- platform/win/TestExpectations:
- platform/wk2/TestExpectations:
- 1:38 PM Changeset in webkit [221555] by
-
- 2 edits in trunk/Source/JavaScriptCore
Unreviewed attempt to fix Windows build.
- runtime/JSGlobalObjectFunctions.cpp:
- 12:08 PM Changeset in webkit [221554] by
-
- 3 edits2 copies8 moves1 add1 delete in trunk/Source/WebKit
Move shared part of the Remote Layer Tree code out of a Mac-specific directory
https://bugs.webkit.org/show_bug.cgi?id=176297
Reviewed by Dan Bernstein.
UI-side compositing works on all Cocoa platforms, so the code should
not live inside Mac/. Also merge the Scrolling directory in here,
since those files are very related.
- PlatformMac.cmake:
- Shared/RemoteLayerTree/RemoteLayerBackingStore.h: Renamed from Shared/mac/RemoteLayerBackingStore.h.
- Shared/RemoteLayerTree/RemoteLayerBackingStore.mm: Renamed from Shared/mac/RemoteLayerBackingStore.mm.
- Shared/RemoteLayerTree/RemoteLayerBackingStoreCollection.h: Renamed from Shared/mac/RemoteLayerBackingStoreCollection.h.
- Shared/RemoteLayerTree/RemoteLayerBackingStoreCollection.mm: Renamed from Shared/mac/RemoteLayerBackingStoreCollection.mm.
- Shared/RemoteLayerTree/RemoteLayerTreePropertyApplier.h: Renamed from Shared/mac/RemoteLayerTreePropertyApplier.h.
- Shared/RemoteLayerTree/RemoteLayerTreePropertyApplier.mm: Renamed from Shared/mac/RemoteLayerTreePropertyApplier.mm.
- Shared/RemoteLayerTree/RemoteLayerTreeTransaction.h: Renamed from Shared/mac/RemoteLayerTreeTransaction.h.
- Shared/RemoteLayerTree/RemoteLayerTreeTransaction.mm: Renamed from Shared/mac/RemoteLayerTreeTransaction.mm.
- Shared/RemoteLayerTree/RemoteScrollingCoordinatorTransaction.cpp: Renamed from Shared/Scrolling/RemoteScrollingCoordinatorTransaction.cpp.
- Shared/RemoteLayerTree/RemoteScrollingCoordinatorTransaction.h: Renamed from Shared/Scrolling/RemoteScrollingCoordinatorTransaction.h.
- WebKit.xcodeproj/project.pbxproj:
- 11:54 AM Changeset in webkit [221553] by
-
- 4 edits in trunk/Source
Unreviewed, rolling out r221552.
Broke the build
Reverted changeset:
"[WTF] Add C++03 allocator interface for GCC < 6"
https://bugs.webkit.org/show_bug.cgi?id=176301
http://trac.webkit.org/changeset/221552
- 11:49 AM Changeset in webkit [221552] by
-
- 4 edits in trunk/Source
[WTF] Add C++03 allocator interface for GCC < 6
https://bugs.webkit.org/show_bug.cgi?id=176301
Reviewed by Darin Adler.
Source/JavaScriptCore:
- dfg/DFGObjectAllocationSinkingPhase.cpp:
Source/WTF:
Unfortunately, std::list in GCC < 6 does not support C++11 allocator interface.
This patch adds C++03 allocator interface to FastAllocator to make it usable
for std::list. It also allows us to use FastAllocator for data structures that
only support C++03 interface.
- wtf/FastMalloc.h:
(WTF::FastAllocator::allocate):
(WTF::FastAllocator::construct):
(WTF::FastAllocator::destroy):
(WTF::FastAllocator::max_size const):
(WTF::FastAllocator::select_on_container_copy_construction const):
- 10:51 AM Changeset in webkit [221551] by
-
- 5 edits in trunk/Source/JavaScriptCore
[JSC] Clean up BytecodeLivenessAnalysis
https://bugs.webkit.org/show_bug.cgi?id=176295
Reviewed by Saam Barati.
Previously, computeDefsForBytecodeOffset was a bit customizable.
This is used for try-catch handler's liveness analysis. But after
careful generatorification implementation, it is now not necessary.
This patch drops this customizability.
- bytecode/BytecodeGeneratorification.cpp:
(JSC::GeneratorLivenessAnalysis::computeDefsForBytecodeOffset): Deleted.
(JSC::GeneratorLivenessAnalysis::computeUsesForBytecodeOffset): Deleted.
- bytecode/BytecodeLivenessAnalysis.cpp:
(JSC::BytecodeLivenessAnalysis::computeKills):
(JSC::BytecodeLivenessAnalysis::computeDefsForBytecodeOffset): Deleted.
(JSC::BytecodeLivenessAnalysis::computeUsesForBytecodeOffset): Deleted.
- bytecode/BytecodeLivenessAnalysis.h:
- bytecode/BytecodeLivenessAnalysisInlines.h:
(JSC::BytecodeLivenessPropagation::stepOverInstruction):
(JSC::BytecodeLivenessPropagation::computeLocalLivenessForBytecodeOffset):
(JSC::BytecodeLivenessPropagation::computeLocalLivenessForBlock):
(JSC::BytecodeLivenessPropagation::getLivenessInfoAtBytecodeOffset):
(JSC::BytecodeLivenessPropagation::runLivenessFixpoint):
(JSC::BytecodeLivenessPropagation<DerivedAnalysis>::stepOverInstruction): Deleted.
(JSC::BytecodeLivenessPropagation<DerivedAnalysis>::computeLocalLivenessForBytecodeOffset): Deleted.
(JSC::BytecodeLivenessPropagation<DerivedAnalysis>::computeLocalLivenessForBlock): Deleted.
(JSC::BytecodeLivenessPropagation<DerivedAnalysis>::getLivenessInfoAtBytecodeOffset): Deleted.
(JSC::BytecodeLivenessPropagation<DerivedAnalysis>::runLivenessFixpoint): Deleted.
- 10:46 AM Changeset in webkit [221550] by
-
- 25 edits3 adds in trunk/Tools
WSL should support structs
https://bugs.webkit.org/show_bug.cgi?id=176290
Reviewed by Mylex Maxfield.
This adds parsing of struct types and makes them work.
This required adding a struct layout phase, which in turn required being a bit more careful
about how we instantiate functions and types. We cannot have any instantiation TypeRefs left
once we're doing struct layout.
- WebGPUShadingLanguageRI/All.js:
- WebGPUShadingLanguageRI/CallFunction.js:
(callFunction):
- WebGPUShadingLanguageRI/Checker.js:
(Checker.prototype.visitProtocolDecl.set throw):
- WebGPUShadingLanguageRI/DotExpression.js: Added.
(DotExpression):
(DotExpression.prototype.get struct):
(DotExpression.prototype.get fieldName):
(DotExpression.prototype.get isLValue):
(DotExpression.prototype.toString):
- WebGPUShadingLanguageRI/EBufferBuilder.js:
(EBufferBuilder.prototype._createEPtr):
- WebGPUShadingLanguageRI/EPtr.js:
(EPtr.prototype.copyFrom): Deleted.
(EPtr.prototype.toString): Deleted.
- WebGPUShadingLanguageRI/Evaluator.js:
(Evaluator.prototype.visitAssignment):
(Evaluator.prototype.visitDotExpression):
- WebGPUShadingLanguageRI/Field.js:
(Field):
- WebGPUShadingLanguageRI/FuncDef.js:
(FuncDef.prototype.rewrite):
- WebGPUShadingLanguageRI/FuncInstantiator.js:
(FuncInstantiator.prototype.getUnique):
(FuncInstantiator):
- WebGPUShadingLanguageRI/Inline.js:
(inline):
(_inlineFunction):
(resolveInlinedFunction):
- WebGPUShadingLanguageRI/Inliner.js:
(Inliner.prototype.visitDotExpression):
- WebGPUShadingLanguageRI/InstantiateImmediates.js:
(InstantiateImmediates.prototype.visitTypeRef):
(InstantiateImmediates.prototype.visitVariableDecl):
(InstantiateImmediates):
- WebGPUShadingLanguageRI/NameResolver.js:
(NameResolver.prototype._resolveTypeArguments):
(NameResolver.prototype.visitTypeRef):
- WebGPUShadingLanguageRI/Node.js:
(Node.prototype.visit):
- WebGPUShadingLanguageRI/OverloadResolutionFailure.js: Added.
(OverloadResolutionFailure):
(OverloadResolutionFailure.prototype.get func):
(OverloadResolutionFailure.prototype.get reason):
(OverloadResolutionFailure.prototype.toString):
- WebGPUShadingLanguageRI/Parse.js:
(parsePossibleSuffix):
(parseField):
(parseStructType):
(parse):
- WebGPUShadingLanguageRI/ResolveOverloadImpl.js:
(resolveOverloadImpl):
- WebGPUShadingLanguageRI/Rewriter.js:
(Rewriter.prototype.visitDotExpression):
(Rewriter.prototype.visitVariableRef):
- WebGPUShadingLanguageRI/StructLayoutBuilder.js: Added.
(StructLayoutBuilder):
(StructLayoutBuilder.prototype.visitStructType):
(StructLayoutBuilder.prototype.get offset):
(StructLayoutBuilder.prototype.visitField):
(StructLayoutBuilder.prototype.visitVariableRef):
(StructLayoutBuilder.prototype.visitVariableDecl):
- WebGPUShadingLanguageRI/StructType.js:
(StructType.prototype.add):
(StructType.prototype.instantiate):
(StructType.prototype.populateDefaultValue):
- WebGPUShadingLanguageRI/Substitution.js:
(Substitution.prototype.visitTypeRef):
(Substitution.prototype.visitVariableRef):
(Substitution):
- WebGPUShadingLanguageRI/Test.js:
(TEST_genericStructInstance):
- WebGPUShadingLanguageRI/Type.js:
(Type.prototype.inherits):
- WebGPUShadingLanguageRI/TypeRef.js:
(TypeRef.instantiate):
- WebGPUShadingLanguageRI/VariableRef.js:
(VariableRef.wrap):
- WebGPUShadingLanguageRI/Visitor.js:
(Visitor.prototype.visitTypeRef):
(Visitor.prototype.visitDotExpression):
(Visitor.prototype.visitVariableRef):
- 10:43 AM Changeset in webkit [221549] by
-
- 21 edits4 adds in trunk/Tools
WSL NullType should be a special type variable so it can unify with any pointer type
https://bugs.webkit.org/show_bug.cgi?id=176235
Reviewed by Myles Maxfield.
Null is just a type variable that plays by weird rules:
- Other type variables don't recognize it, so if it's unified with T, it fails.
- It behaves like a type variable for pointer and array reference types.
- It arises only in argument (RHS) position.
- Once Checker finds it to be equals to something, we need to remember what that was.
I refactored some of the type system code to allow for the possibility of type variables being
unified during equals() tests. It turns out that we were playing fast and loose here; I needed
to beef up UnificationContext.prototype.verify. I added tests for this.
I added an equalsWithCommit() that triggers commitUnification(), which allows NullType to
remember what type it got unified with.
NullLiteral then just instantiates its own NullType, which is what Checker uses as the type of
the NullLiteral. Everything else just works.
This adds a bunch of tests to make sure we generate type errors in various weird cases while
also accepting a number of safe cases.
I also added a way to run the tests in-browser.
- WebGPUShadingLanguageRI/All.js:
- WebGPUShadingLanguageRI/ArrayRefType.js:
(ArrayRefType.prototype.get isArrayRef):
- WebGPUShadingLanguageRI/Checker.js:
(Checker.prototype.visitProtocolDecl.set throw):
- WebGPUShadingLanguageRI/ConstexprTypeParameter.js:
(ConstexprTypeParameter.prototype.typeVariableUnify):
- WebGPUShadingLanguageRI/Evaluator.js:
(Evaluator.prototype.visitDereferenceExpression):
(Evaluator.prototype.visitNullLiteral):
- WebGPUShadingLanguageRI/Func.js:
(Func.prototype.toString):
(Func):
- WebGPUShadingLanguageRI/Intrinsics.js:
(Intrinsics):
- WebGPUShadingLanguageRI/NativeFunc.js:
(NativeFunc.prototype.toDeclString):
(NativeFunc):
(NativeFunc.prototype.toString): Deleted.
- WebGPUShadingLanguageRI/NativeFuncInstance.js:
(NativeFuncInstance.prototype.toDeclString):
(NativeFuncInstance):
(NativeFuncInstance.prototype.toString): Deleted.
- WebGPUShadingLanguageRI/Node.js:
(Node.unify):
(Node.prototype._typeVariableUnifyImpl):
(Node.prototype.equals):
- WebGPUShadingLanguageRI/NullLiteral.js: Added.
(NullLiteral):
(NullLiteral.prototype.toString):
- WebGPUShadingLanguageRI/NullType.js:
(NullType):
(NullType.prototype.get isPrimitive):
(NullType.prototype.get isUnifiable):
(NullType.prototype.typeVariableUnify):
(NullType.prototype.unifyImpl):
(NullType.prototype.verifyAsArgument):
(NullType.prototype.verifyAsParameter):
(NullType.prototype.toString):
- WebGPUShadingLanguageRI/Parse.js:
(parseTerm):
(parseType.getAddressSpace):
(parseType):
- WebGPUShadingLanguageRI/Rewriter.js:
(Rewriter.prototype.visitNullLiteral):
- WebGPUShadingLanguageRI/Test.html: Added.
- WebGPUShadingLanguageRI/Test.js:
(this.window.this.print):
(TEST_doubleGenericCallsSingleGeneric):
(TEST_dereferenceDefaultNull):
(TEST_dereferenceDefaultNullArrayRef):
(doTest):
(let.s.in.this.s.startsWith.string_appeared_here.s.match): Deleted.
- WebGPUShadingLanguageRI/Type.js:
(Type.prototype.get isArrayRef):
- WebGPUShadingLanguageRI/TypeVariable.js:
(TypeVariable.prototype.typeVariableUnify):
- WebGPUShadingLanguageRI/UnificationContext.js:
(UnificationContext.prototype.verify):
(UnificationContext):
(UnificationContext.prototype.isUnunified): Deleted.
- WebGPUShadingLanguageRI/VariableRef.js:
(VariableRef.prototype.get unifyNode):
- WebGPUShadingLanguageRI/Visitor.js:
(Visitor.prototype.visitNullLiteral):
- 3:31 AM Changeset in webkit [221548] by
-
- 3 edits in trunk/Source/bmalloc
Large virtual memory region allocation requires MMAP_NORESERVE in Linux
https://bugs.webkit.org/show_bug.cgi?id=176211
Reviewed by Geoffrey Garen.
In Linux, we cannot allocate very large memory region without MMAP_NORESERVE.
Linux kernel needs to reserve swap area for allocated memory region. If the
swap area is exhausted, kernel fails to allocate the memory region with ENOMEM.
This patch adds MMAP_NORESERVE to mmap flags in Linux. By adding this flag,
mmap does not need to reserve swap area for the reserved memory region.
This allows us to reserve very large memory region that is necessary for Gigacage.
- bmalloc/BPlatform.h:
- bmalloc/VMAllocate.h:
(bmalloc::tryVMAllocate):
- 1:42 AM Changeset in webkit [221547] by
-
- 25 edits3 deletes in trunk
Remove CanvasProxy
https://bugs.webkit.org/show_bug.cgi?id=176288
Patch by Sam Weinig <sam@webkit.org> on 2017-09-03
Reviewed by Yusuke Suzuki.
CanvasProxy does not appear to be in any current HTML spec
and was disabled and unimplemented in our tree. Time to
get rid of it.
.:
- Source/cmake/OptionsMac.cmake:
- Source/cmake/OptionsWin.cmake:
- Source/cmake/WebKitFeatures.cmake:
- Source/cmake/tools/vsprops/FeatureDefines.props:
- Source/cmake/tools/vsprops/FeatureDefinesCairo.props:
Source/JavaScriptCore:
- Configurations/FeatureDefines.xcconfig:
Source/WebCore:
- CMakeLists.txt:
- Configurations/FeatureDefines.xcconfig:
- DerivedSources.cpp:
- DerivedSources.make:
- WebCore.xcodeproj/project.pbxproj:
- html/canvas/CanvasProxy.cpp: Removed.
- html/canvas/CanvasProxy.h: Removed.
- html/canvas/CanvasProxy.idl: Removed.
Source/WebCore/PAL:
- Configurations/FeatureDefines.xcconfig:
Source/WebKit:
- Configurations/FeatureDefines.xcconfig:
Source/WebKitLegacy/mac:
- Configurations/FeatureDefines.xcconfig:
Source/WTF:
- wtf/FeatureDefines.h:
Tools:
- Scripts/webkitperl/FeatureList.pm:
- TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
Sep 2, 2017:
- 9:42 PM Changeset in webkit [221546] by
-
- 4 edits in trunk/Source/JavaScriptCore
Need an API to get the global context from JSObjectRef
https://bugs.webkit.org/show_bug.cgi?id=176291
Reviewed by Saam Barati.
Very simple additional API, starting off as SPI on principle.
- API/JSObjectRef.cpp:
(JSObjectGetGlobalContext):
- API/JSObjectRefPrivate.h:
- API/tests/testapi.c:
(main):
- 9:05 PM Changeset in webkit [221545] by
-
- 4 edits in trunk
DOMMatrix/DOMMatrixReadOnly validation is incorrect for NaN values
https://bugs.webkit.org/show_bug.cgi?id=176287
Patch by Sam Weinig <sam@webkit.org> on 2017-09-02
Reviewed by Chris Dumez.
LayoutTests/imported/w3c:
- web-platform-tests/css/geometry-1/DOMMatrixInit-validate-fixup-expected.txt:
Update test results.
Source/WebCore:
- css/DOMMatrixReadOnly.cpp:
(WebCore::sameValueZero): Added.
(WebCore::DOMMatrixReadOnly::validateAndFixup):
Switch from using standard != to added sameValueZero helper
which implements https://tc39.github.io/ecma262/#sec-samevaluezero
- 9:02 PM Changeset in webkit [221544] by
-
- 8 edits2 adds in trunk
Implement FileSystemFileEntry.file()
https://bugs.webkit.org/show_bug.cgi?id=176166
<rdar://problem/34187756>
Reviewed by Sam Weinig.
Source/WebCore:
Implement FileSystemFileEntry.file():
Test: editing/pasteboard/datatransfer-items-drop-fileEntry-file.html
- Modules/entriesapi/DOMFileSystem.cpp:
(WebCore::validatePathIsExpectedType):
(WebCore::DOMFileSystem::listDirectory):
(WebCore::DOMFileSystem::getParent):
(WebCore::DOMFileSystem::getFile):
- Modules/entriesapi/DOMFileSystem.h:
- Modules/entriesapi/FileSystemFileEntry.cpp:
(WebCore::FileSystemFileEntry::file):
LayoutTests:
Add layout test coverage. I have verified that this test passes in Chrome as well.
- editing/pasteboard/datatransfer-items-drop-fileEntry-file-expected.txt: Added.
- editing/pasteboard/datatransfer-items-drop-fileEntry-file.html: Added.
- platform/wk2/TestExpectations:
- 8:43 PM Changeset in webkit [221543] by
-
- 20 edits in trunk/Source
[CA] Upstream QuartzCore-related WebKitSystemInterface functions
https://bugs.webkit.org/show_bug.cgi?id=176270
Reviewed by Tim Horton.
Source/WebCore:
- platform/graphics/ca/cocoa/PlatformCALayerCocoa.mm:
(PlatformCALayerCocoa::enumerateRectsBeingDrawn):
- platform/graphics/cocoa/WebCoreCALayerExtras.h:
- platform/graphics/cocoa/WebCoreCALayerExtras.mm:
(+[CALayer _web_renderLayerWithContextID:]):
- platform/ios/WebCoreSystemInterfaceIOS.mm:
- platform/mac/WebCoreSystemInterface.h:
- platform/mac/WebCoreSystemInterface.mm:
Source/WebCore/PAL:
- pal/spi/cocoa/QuartzCoreSPI.h:
Source/WebKit:
- Platform/mac/LayerHostingContext.mm:
(WebKit::LayerHostingContext::createForPort):
(WebKit::LayerHostingContext::createForExternalHostingProcess):
- UIProcess/mac/PageClientImpl.mm:
(WebKit::PageClientImpl::enterAcceleratedCompositingMode):
(WebKit::PageClientImpl::updateAcceleratedCompositingMode):
- UIProcess/mac/RemoteLayerTreeHost.mm:
(WebKit::RemoteLayerTreeHost::createLayer):
- WebProcess/Plugins/Netscape/mac/PluginProxyMac.mm:
(WebKit::makeRenderLayer):
- WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:
(InitWebCoreSystemInterface):
Source/WebKitLegacy/mac:
- Plugins/Hosted/NetscapePluginHostManager.mm:
(WebKit::NetscapePluginHostManager::spawnPluginHost):
- Plugins/Hosted/WebHostedNetscapePluginView.h:
- Plugins/Hosted/WebHostedNetscapePluginView.mm:
(WebKit::SoftwareCARenderer::SoftwareCARenderer):
(WebKit::SoftwareCARenderer::~SoftwareCARenderer):
(WebKit::SoftwareCARenderer::context const):
(WebKit::SoftwareCARenderer::renderContext const):
(WebKit::SoftwareCARenderer::render):
(-[WebHostedNetscapePluginView createPlugin]):
(-[WebHostedNetscapePluginView createPluginLayer]):
(-[WebHostedNetscapePluginView destroyPlugin]):
(-[WebHostedNetscapePluginView drawRect:]):
- WebCoreSupport/WebSystemInterface.mm:
(InitWebCoreSystemInterface):
- 7:31 PM Changeset in webkit [221542] by
-
- 9 edits in trunk
Wrong getComputedStyle result for pseudo-elements in display: none subtrees.
https://bugs.webkit.org/show_bug.cgi?id=176259
Patch by Emilio Cobos Álvarez <emilio> on 2017-09-02
Reviewed by Antti Koivisto.
LayoutTests/imported/w3c:
- web-platform-tests/cssom/getComputedStyle-pseudo-expected.txt:
Source/WebCore:
Before this patch, we were wrongly returning the parent style when there wasn't
a cached pseudo style.
With this, the only remaining failures in getComputedStyle-pseudo is a
serialisation bug for the "content" property, and the display: contents test,
which is because we don't support pseudo-elements of display: contents elements
yet.
Tests: imported/w3c/web-platform-tests/cssom/getComputedStyle-pseudo.html
- dom/Document.cpp:
(WebCore::Document::styleForElementIgnoringPendingStylesheets):
- dom/Document.h:
- dom/Element.cpp:
(WebCore::Element::resolvePseudoElementStyle):
(WebCore::Element::computedStyle):
- dom/Element.h:
- 4:52 PM Changeset in webkit [221541] by
-
- 4 edits6 copies9 moves2 adds1 delete in trunk/Source/WebKit
Move UI Process part of the Remote Layer Tree code out of a Mac-specific directory
https://bugs.webkit.org/show_bug.cgi?id=176273
Reviewed by Dan Bernstein.
UI-side compositing works on all Cocoa platforms, so the code should
not live inside Mac/. Also merge the Scrolling directory in here,
since those files are very related.
- UIProcess/RemoteLayerTree/RemoteLayerTreeDrawingAreaProxy.h: Renamed from SourceebKit/UIProcess/mac/RemoteLayerTreeDrawingAreaProxy.h.
- UIProcess/RemoteLayerTree/RemoteLayerTreeDrawingAreaProxy.messages.in: Renamed from UIProcess/mac/RemoteLayerTreeDrawingAreaProxy.messages.in.
- UIProcess/RemoteLayerTree/RemoteLayerTreeDrawingAreaProxy.mm: Renamed from UIProcess/mac/RemoteLayerTreeDrawingAreaProxy.mm.
- UIProcess/RemoteLayerTree/RemoteLayerTreeHost.h: Renamed from UIProcess/mac/RemoteLayerTreeHost.h.
- UIProcess/RemoteLayerTree/RemoteLayerTreeHost.mm: Renamed from UIProcess/mac/RemoteLayerTreeHost.mm.
- UIProcess/RemoteLayerTree/RemoteLayerTreeScrollingPerformanceData.h: Renamed from UIProcess/Cocoa/RemoteLayerTreeScrollingPerformanceData.h.
- UIProcess/RemoteLayerTree/RemoteLayerTreeScrollingPerformanceData.mm: Renamed from UIProcess/Cocoa/RemoteLayerTreeScrollingPerformanceData.mm.
- UIProcess/RemoteLayerTree/RemoteScrollingCoordinatorProxy.cpp: Renamed from UIProcess/Scrolling/RemoteScrollingCoordinatorProxy.cpp.
- UIProcess/RemoteLayerTree/RemoteScrollingCoordinatorProxy.h: Renamed from UIProcess/Scrolling/RemoteScrollingCoordinatorProxy.h.
- UIProcess/RemoteLayerTree/RemoteScrollingTree.cpp: Renamed from UIProcess/Scrolling/RemoteScrollingTree.cpp.
- UIProcess/RemoteLayerTree/RemoteScrollingTree.h: Renamed from UIProcess/Scrolling/RemoteScrollingTree.h.
- UIProcess/RemoteLayerTree/ios/RemoteLayerTreeHostIOS.mm: Renamed from UIProcess/ios/RemoteLayerTreeHostIOS.mm.
- UIProcess/RemoteLayerTree/ios/RemoteScrollingCoordinatorProxyIOS.mm: Renamed from UIProcess/ios/RemoteScrollingCoordinatorProxyIOS.mm.
- UIProcess/RemoteLayerTree/ios/ScrollingTreeOverflowScrollingNodeIOS.h: Renamed from UIProcess/Scrolling/ios/ScrollingTreeOverflowScrollingNodeIOS.h.
- UIProcess/RemoteLayerTree/ios/ScrollingTreeOverflowScrollingNodeIOS.mm: Renamed from UIProcess/Scrolling/ios/ScrollingTreeOverflowScrollingNodeIOS.mm.
- WebKit.xcodeproj/project.pbxproj:
- 2:31 PM Changeset in webkit [221540] by
-
- 7 edits2 adds in trunk
Implement FileSystemDirectoryEntry.getDirectory()
https://bugs.webkit.org/show_bug.cgi?id=176168
<rdar://problem/34187787>
Reviewed by Darin Adler.
Source/WebCore:
Implement FileSystemDirectoryEntry.getDirectory() as per:
Test: editing/pasteboard/datatransfer-items-drop-getDirectory.html
- Modules/entriesapi/DOMFileSystem.cpp:
(WebCore::isValidVirtualPath):
(WebCore::resolveRelativeVirtualPath):
(WebCore::DOMFileSystem::getEntry):
- Modules/entriesapi/DOMFileSystem.h:
- Modules/entriesapi/FileSystemDirectoryEntry.cpp:
(WebCore::FileSystemDirectoryEntry::getEntry):
(WebCore::FileSystemDirectoryEntry::getFile):
(WebCore::FileSystemDirectoryEntry::getDirectory):
- Modules/entriesapi/FileSystemDirectoryEntry.h:
LayoutTests:
Add layout test coverage.
- editing/pasteboard/datatransfer-items-drop-getDirectory-expected.txt: Added.
- editing/pasteboard/datatransfer-items-drop-getDirectory.html: Added.
- platform/wk2/TestExpectations:
- 11:31 AM Changeset in webkit [221539] by
-
- 7 edits in trunk/Source/WebCore
Performance / PerformanceObserver leaks seen on bots
https://bugs.webkit.org/show_bug.cgi?id=176269
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2017-09-02
Reviewed by Darin Adler.
- page/DOMWindow.cpp:
(WebCore::DOMWindow::removeAllEventListeners):
- workers/WorkerGlobalScope.cpp:
(WebCore::WorkerGlobalScope::removeAllEventListeners):
Also use this opportunity to break up the reference cycle
between PerformanceObservers and the Performance object.
- page/Performance.h:
- page/Performance.cpp:
(WebCore::Performance::removeAllObservers):
Disassociate and clear observers.
- page/PerformanceObserver.h:
- page/PerformanceObserver.cpp:
(WebCore::PerformanceObserver::disassociate):
Clear the back-reference to the Performance object to
break the cycle.
- 11:29 AM Changeset in webkit [221538] by
-
- 2 edits in trunk/Source/WebKit
Web Automation: -[_WKAutomationSession init] leaks
https://bugs.webkit.org/show_bug.cgi?id=176268
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2017-09-02
Reviewed by Darin Adler.
- UIProcess/API/Cocoa/_WKAutomationSession.mm:
(-[_WKAutomationSession init]):
- 3:48 AM Changeset in webkit [221537] by
-
- 12 edits in trunk/Source/WebKit
Fix some style issues in the Web Process part of the Remote Layer Tree code
https://bugs.webkit.org/show_bug.cgi?id=176272
Reviewed by Dan Bernstein.
In bug 176271, the style bot noticed some existing style issues in the UI-side
compositing code. Fix them, because there aren't many and they're straightforward.
- WebProcess/WebPage/Cocoa/RemoteLayerTree/GraphicsLayerCARemote.cpp:
- WebProcess/WebPage/Cocoa/RemoteLayerTree/PlatformCAAnimationRemote.h:
- WebProcess/WebPage/Cocoa/RemoteLayerTree/PlatformCAAnimationRemote.mm:
(WebKit::PlatformCAAnimationRemote::setValues):
- WebProcess/WebPage/Cocoa/RemoteLayerTree/PlatformCALayerRemote.cpp:
(WebKit::PlatformCALayerRemote::appendSublayer):
(WebKit::PlatformCALayerRemote::insertSublayer):
(WebKit::PlatformCALayerRemote::replaceSublayer):
- WebProcess/WebPage/Cocoa/RemoteLayerTree/PlatformCALayerRemote.h:
- WebProcess/WebPage/Cocoa/RemoteLayerTree/PlatformCALayerRemoteCustom.mm:
(WebKit::PlatformCALayerRemoteCustom::clone const):
- WebProcess/WebPage/Cocoa/RemoteLayerTree/PlatformCALayerRemoteTiledBacking.h:
- WebProcess/WebPage/Cocoa/RemoteLayerTree/RemoteLayerTreeContext.h:
- WebProcess/WebPage/Cocoa/RemoteLayerTree/RemoteLayerTreeDrawingArea.mm:
(WebKit::RemoteLayerTreeDrawingArea::flushLayers):
- WebProcess/WebPage/Cocoa/RemoteLayerTree/RemoteScrollingCoordinator.h:
- WebProcess/WebPage/Cocoa/RemoteLayerTree/RemoteScrollingCoordinator.mm:
- 2:38 AM Changeset in webkit [221536] by
-
- 4 edits3 copies16 moves1 add1 delete in trunk/Source/WebKit
Move Web Process part of the Remote Layer Tree code out of a Mac-specific directory
https://bugs.webkit.org/show_bug.cgi?id=176271
Rubber-stamped by Dan Bernstein.
UI-side compositing works on all Cocoa platforms, so the code should
not live inside Mac/. Also merge the Scrolling directory in here,
since those files are very related.
- WebKit.xcodeproj/project.pbxproj:
- DerivedSources.make:
- PlatformMac.cmake:
- WebProcess/WebPage/RemoteLayerTree/GraphicsLayerCARemote.cpp: Renamed from WebProcess/WebPage/mac/GraphicsLayerCARemote.cpp.
- WebProcess/WebPage/RemoteLayerTree/GraphicsLayerCARemote.h: Renamed from WebProcess/WebPage/mac/GraphicsLayerCARemote.h.
- WebProcess/WebPage/RemoteLayerTree/PlatformCAAnimationRemote.h: Renamed from WebProcess/WebPage/mac/PlatformCAAnimationRemote.h.
- WebProcess/WebPage/RemoteLayerTree/PlatformCAAnimationRemote.mm: Renamed from WebProcess/WebPage/mac/PlatformCAAnimationRemote.mm.
- WebProcess/WebPage/RemoteLayerTree/PlatformCALayerRemote.cpp: Renamed from WebProcess/WebPage/mac/PlatformCALayerRemote.cpp.
- WebProcess/WebPage/RemoteLayerTree/PlatformCALayerRemote.h: Renamed from WebProcess/WebPage/mac/PlatformCALayerRemote.h.
- WebProcess/WebPage/RemoteLayerTree/PlatformCALayerRemoteCustom.h: Renamed from WebProcess/WebPage/mac/PlatformCALayerRemoteCustom.h.
- WebProcess/WebPage/RemoteLayerTree/PlatformCALayerRemoteCustom.mm: Renamed from WebProcess/WebPage/mac/PlatformCALayerRemoteCustom.mm.
- WebProcess/WebPage/RemoteLayerTree/PlatformCALayerRemoteTiledBacking.cpp: Renamed from WebProcess/WebPage/mac/PlatformCALayerRemoteTiledBacking.cpp.
- WebProcess/WebPage/RemoteLayerTree/PlatformCALayerRemoteTiledBacking.h: Renamed from WebProcess/WebPage/mac/PlatformCALayerRemoteTiledBacking.h.
- WebProcess/WebPage/RemoteLayerTree/RemoteLayerTreeContext.h: Renamed from WebProcess/WebPage/mac/RemoteLayerTreeContext.h.
- WebProcess/WebPage/RemoteLayerTree/RemoteLayerTreeContext.mm: Renamed from WebProcess/WebPage/mac/RemoteLayerTreeContext.mm.
- WebProcess/WebPage/RemoteLayerTree/RemoteLayerTreeDisplayRefreshMonitor.h: Renamed from WebProcess/WebPage/Cocoa/RemoteLayerTreeDisplayRefreshMonitor.h.
- WebProcess/WebPage/RemoteLayerTree/RemoteLayerTreeDisplayRefreshMonitor.mm: Renamed from WebProcess/WebPage/Cocoa/RemoteLayerTreeDisplayRefreshMonitor.mm.
- WebProcess/WebPage/RemoteLayerTree/RemoteLayerTreeDrawingArea.h: Renamed from WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.h.
- WebProcess/WebPage/RemoteLayerTree/RemoteLayerTreeDrawingArea.mm: Renamed from WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.mm.
- WebProcess/WebPage/RemoteLayerTree/RemoteScrollingCoordinator.h: Renamed from WebProcess/Scrolling/RemoteScrollingCoordinator.h.
- WebProcess/WebPage/RemoteLayerTree/RemoteScrollingCoordinator.messages.in: Renamed from WebProcess/Scrolling/RemoteScrollingCoordinator.messages.in.
- WebProcess/WebPage/RemoteLayerTree/RemoteScrollingCoordinator.mm: Renamed from WebProcess/Scrolling/RemoteScrollingCoordinator.mm.
- 2:14 AM Changeset in webkit [221535] by
-
- 6 edits in releases/WebKitGTK/webkit-2.18
Merge r221501 - Wrong getComputedStyle behavior for pseudo-elements for layout-dependent properties.
https://bugs.webkit.org/show_bug.cgi?id=175936
Patch by Emilio Cobos Álvarez <emilio> on 2017-09-01
Reviewed by Antti Koivisto.
LayoutTests/imported/w3c:
- web-platform-tests/cssom/getComputedStyle-pseudo-expected.txt:
- web-platform-tests/cssom/getComputedStyle-pseudo.html: Sync test with upstream.
Source/WebCore:
Before this patch we may wrongly end up using the wrong renderer to resolve
this.
Tests: imported/w3c/web-platform-tests/cssom/getComputedStyle-pseudo.html
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::ComputedStyleExtractor::styledElement const):
(WebCore::ComputedStyleExtractor::styledRenderer const):
(WebCore::ComputedStyleExtractor::propertyValue):
- css/CSSComputedStyleDeclaration.h:
- 2:13 AM Changeset in webkit [221534] by
-
- 3 edits2 adds in releases/WebKitGTK/webkit-2.18
transformCanLikelyUseFastPath() can read off the end of a string
https://bugs.webkit.org/show_bug.cgi?id=176232
rdar://problem/33851237
Reviewed by Tim Horton.
Source/WebCore:
Code added in r220382 could read one byte past the end of the string when looking for the 'z'
of a rotateZ() function. The code was actually incorrect, testing for the 'z at i+6 after
already incrementing i by 6. This patch makes the code correctly detect rotateZ().
Also, rotate functions at the end of a string could be ignored because kShortestValidTransformStringLength
was too long, so set it to the length of "rotate(0)", the shortest transform function that we currently
fast-parse.
There's an implicit assumption in this code that chars is not indexed past i+kShortestValidTransformStringLength.
If the 'translate' path is taken, i is incremented by 9 (==kShortestValidTransformStringLength), but that's
OK because WTF::find() doesn't index into chars if i >= length.
Test: fast/css/transform-fast-paths.html
- css/parser/CSSParserFastPaths.cpp:
(WebCore::transformCanLikelyUseFastPath):
LayoutTests:
- fast/css/transform-fast-paths-expected.txt: Added.
- fast/css/transform-fast-paths.html: Added.
- 2:13 AM Changeset in webkit [221533] by
-
- 3 edits in releases/WebKitGTK/webkit-2.18/Tools
Merge r221474 - [GTK] Improve the way unit test are run and the results reported
https://bugs.webkit.org/show_bug.cgi?id=176104
Reviewed by Carlos Alberto Lopez Perez.
There are several issues with the way unit tests are run by run-gtk-tests and also with the way results are
reported:
- The results summary only mentions the test binaries, not the actual test cases, so you always have to scroll up to find the actual test cases failing.
- The number of reported failures is the number of test binaries that failed, so if a new test case fails for the same binary in a new revision, we won't notice it just looking at the number of failures.
- We show detailed information about skipped test in the results summary, which is just noise.
- In the case of glib tests, when a test case times out, we finish the test suite, instead of continuing with the rest of the test cases like we do for normal failures or crashes. If a new test case fails after a test case that timed out we will not notice it until we fix or skip the test cases timing out.
- In the case of glib tests, the timeout is applied to the whole suite, instead of per test case, we have a hack to make it longer only for that. It has worked so far, but it doesn't scale, and it's an ugly hack.
- It's not currently possible to detect flaky tests, because again, we know the binaries/suites that failed but not the actual test cases.
This patch fixes all these issues and makes it possible to add support for flaky tests in a follow up patch.
- BuildSlaveSupport/build.webkit.org-config/master.cfg:
(RunGtkAPITests.commandComplete): Update the RunGtkAPITests step to parse the new output.
- Scripts/run-gtk-tests:
(TestRunner._start_timeout): Helper to start the timeout if needed.
(TestRunner._start_timeout._alarm_handler): Raise timeout exception.
(TestRunner._stop_timeout): Helper to stop the timeout if needed.
(TestRunner._waitpid): Merged waitpid and return_code_from_exit_status.
(TestRunner._run_test_glib): Do not double the timeout anymore, we now start/stop the timeout for every test
case. Return a dictionary where keys are test cases and values the results only in case of failures.
(TestRunner._run_test_glib.parse_line): Update the parser to also detect test cases and the results.
(TestRunner._run_test_glib.parse_line.set_test_result): Helper to set the result of a test case.
(TestRunner._run_google_test): Return a dictionary where key is the test case and value is the result only in
case of failure.
(TestRunner._run_google_test_suite): Updated now that _run_google_test returns a dictionary.
(TestRunner.run_tests): Handle the results dictionary and show the results with information about test cases
failing and grouped by test binaries.
- 1:53 AM Changeset in webkit [221532] by
-
- 2 edits in releases/WebKitGTK/webkit-2.18/Source/WebCore
Merge r221469 - Another attempt to fix the Apple Windows build following <https://trac.webkit.org/changeset/221459>
(https://bugs.webkit.org/show_bug.cgi?id=176171)
Temporarily weaken the size check for RenderStyle from a strict equality to <=.
- rendering/style/RenderStyle.cpp:
- 1:53 AM Changeset in webkit [221531] by
-
- 2 edits in releases/WebKitGTK/webkit-2.18/Source/WebCore
Merge r221467 - Attempt to fix the Apple Windows and WinCairo build following <https://trac.webkit.org/changeset/221459>
(https://bugs.webkit.org/show_bug.cgi?id=176171)
Explicitly cast PseudoIds to unsigned before computing a difference between two PseudoIds.
- rendering/style/RenderStyle.h:
- 1:53 AM Changeset in webkit [221530] by
-
- 3 edits in releases/WebKitGTK/webkit-2.18/Source/WebCore
Merge r221459 - Make RenderStyle's non-inherited flags more human friendly
https://bugs.webkit.org/show_bug.cgi?id=176171
Reviewed by Antti Koivisto.
Revert r166465 as we never followed through and made the CSS JIT update
RenderStyle's non-inherited flags directly.
- rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::RenderStyle):
(WebCore::RenderStyle::hashForTextAutosizing const):
(WebCore::RenderStyle::equalForTextAutosizing const):
(WebCore::RenderStyle::changeRequiresLayout const):
- rendering/style/RenderStyle.h:
(WebCore::RenderStyle::styleType const):
(WebCore::RenderStyle::setStyleType):
(WebCore::RenderStyle::setHasViewportUnits):
(WebCore::RenderStyle::hasViewportUnits const):
(WebCore::RenderStyle::affectedByHover const):
(WebCore::RenderStyle::affectedByActive const):
(WebCore::RenderStyle::affectedByDrag const):
(WebCore::RenderStyle::setAffectedByHover):
(WebCore::RenderStyle::setAffectedByActive):
(WebCore::RenderStyle::setAffectedByDrag):
(WebCore::RenderStyle::isFloating const):
(WebCore::RenderStyle::display const):
(WebCore::RenderStyle::position const):
(WebCore::RenderStyle::floating const):
(WebCore::RenderStyle::overflowX const):
(WebCore::RenderStyle::overflowY const):
(WebCore::RenderStyle::verticalAlign const):
(WebCore::RenderStyle::unicodeBidi const):
(WebCore::RenderStyle::clear const):
(WebCore::RenderStyle::tableLayout const):
(WebCore::RenderStyle::hasExplicitlySetDirection const):
(WebCore::RenderStyle::isLink const):
(WebCore::RenderStyle::setDisplay):
(WebCore::RenderStyle::setOriginalDisplay):
(WebCore::RenderStyle::setPosition):
(WebCore::RenderStyle::setFloating):
(WebCore::RenderStyle::setOverflowX):
(WebCore::RenderStyle::setOverflowY):
(WebCore::RenderStyle::setVerticalAlign):
(WebCore::RenderStyle::setUnicodeBidi):
(WebCore::RenderStyle::setClear):
(WebCore::RenderStyle::setTableLayout):
(WebCore::RenderStyle::setHasExplicitlySetDirection):
(WebCore::RenderStyle::setIsLink):
(WebCore::RenderStyle::hasExplicitlySetWritingMode const):
(WebCore::RenderStyle::setHasExplicitlySetWritingMode):
(WebCore::RenderStyle::hasExplicitlySetTextAlign const):
(WebCore::RenderStyle::setHasExplicitlySetTextAlign):
(WebCore::RenderStyle::unique const):
(WebCore::RenderStyle::setUnique):
(WebCore::RenderStyle::emptyState const):
(WebCore::RenderStyle::setEmptyState):
(WebCore::RenderStyle::firstChildState const):
(WebCore::RenderStyle::setFirstChildState):
(WebCore::RenderStyle::lastChildState const):
(WebCore::RenderStyle::setLastChildState):
(WebCore::RenderStyle::setHasExplicitlyInheritedProperties):
(WebCore::RenderStyle::hasExplicitlyInheritedProperties const):
(WebCore::RenderStyle::inheritUnicodeBidiFrom):
(WebCore::RenderStyle::NonInheritedFlags::operator!= const):
(WebCore::RenderStyle::NonInheritedFlags::hasAnyPublicPseudoStyles const):
(WebCore::RenderStyle::originalDisplay const):
(WebCore::RenderStyle::NonInheritedFlags::operator== const):
(WebCore::RenderStyle::NonInheritedFlags::copyNonInheritedFrom):
(WebCore::RenderStyle::NonInheritedFlags::hasPseudoStyle const):
(WebCore::RenderStyle::NonInheritedFlags::setHasPseudoStyle):
(WebCore::RenderStyle::NonInheritedFlags::overflowX const): Deleted.
(WebCore::RenderStyle::NonInheritedFlags::setOverflowX): Deleted.
(WebCore::RenderStyle::NonInheritedFlags::overflowY const): Deleted.
(WebCore::RenderStyle::NonInheritedFlags::setOverflowY): Deleted.
(WebCore::RenderStyle::NonInheritedFlags::clear const): Deleted.
(WebCore::RenderStyle::NonInheritedFlags::setClear): Deleted.
(WebCore::RenderStyle::NonInheritedFlags::effectiveDisplay const): Deleted.
(WebCore::RenderStyle::NonInheritedFlags::setEffectiveDisplay): Deleted.
(WebCore::RenderStyle::NonInheritedFlags::position const): Deleted.
(WebCore::RenderStyle::NonInheritedFlags::setPosition): Deleted.
(WebCore::RenderStyle::NonInheritedFlags::originalDisplay const): Deleted.
(WebCore::RenderStyle::NonInheritedFlags::setOriginalDisplay): Deleted.
(WebCore::RenderStyle::NonInheritedFlags::unicodeBidi const): Deleted.
(WebCore::RenderStyle::NonInheritedFlags::setUnicodeBidi): Deleted.
(WebCore::RenderStyle::NonInheritedFlags::hasViewportUnits const): Deleted.
(WebCore::RenderStyle::NonInheritedFlags::setHasViewportUnits): Deleted.
(WebCore::RenderStyle::NonInheritedFlags::verticalAlign const): Deleted.
(WebCore::RenderStyle::NonInheritedFlags::setVerticalAlign): Deleted.
(WebCore::RenderStyle::NonInheritedFlags::hasExplicitlyInheritedProperties const): Deleted.
(WebCore::RenderStyle::NonInheritedFlags::setHasExplicitlyInheritedProperties): Deleted.
(WebCore::RenderStyle::NonInheritedFlags::isFloating const): Deleted.
(WebCore::RenderStyle::NonInheritedFlags::floating const): Deleted.
(WebCore::RenderStyle::NonInheritedFlags::setFloating): Deleted.
(WebCore::RenderStyle::NonInheritedFlags::tableLayout const): Deleted.
(WebCore::RenderStyle::NonInheritedFlags::setTableLayout): Deleted.
(WebCore::RenderStyle::NonInheritedFlags::styleType const): Deleted.
(WebCore::RenderStyle::NonInheritedFlags::setStyleType): Deleted.
(WebCore::RenderStyle::NonInheritedFlags::isUnique const): Deleted.
(WebCore::RenderStyle::NonInheritedFlags::setIsUnique): Deleted.
(WebCore::RenderStyle::NonInheritedFlags::emptyState const): Deleted.
(WebCore::RenderStyle::NonInheritedFlags::setEmptyState): Deleted.
(WebCore::RenderStyle::NonInheritedFlags::firstChildState const): Deleted.
(WebCore::RenderStyle::NonInheritedFlags::setFirstChildState): Deleted.
(WebCore::RenderStyle::NonInheritedFlags::lastChildState const): Deleted.
(WebCore::RenderStyle::NonInheritedFlags::setLastChildState): Deleted.
(WebCore::RenderStyle::NonInheritedFlags::affectedByHover const): Deleted.
(WebCore::RenderStyle::NonInheritedFlags::setAffectedByHover): Deleted.
(WebCore::RenderStyle::NonInheritedFlags::affectedByActive const): Deleted.
(WebCore::RenderStyle::NonInheritedFlags::setAffectedByActive): Deleted.
(WebCore::RenderStyle::NonInheritedFlags::affectedByDrag const): Deleted.
(WebCore::RenderStyle::NonInheritedFlags::setAffectedByDrag): Deleted.
(WebCore::RenderStyle::NonInheritedFlags::isLink const): Deleted.
(WebCore::RenderStyle::NonInheritedFlags::setIsLink): Deleted.
(WebCore::RenderStyle::NonInheritedFlags::hasExplicitlySetDirection const): Deleted.
(WebCore::RenderStyle::NonInheritedFlags::setHasExplicitlySetDirection): Deleted.
(WebCore::RenderStyle::NonInheritedFlags::hasExplicitlySetWritingMode const): Deleted.
(WebCore::RenderStyle::NonInheritedFlags::setHasExplicitlySetWritingMode): Deleted.
(WebCore::RenderStyle::NonInheritedFlags::hasExplicitlySetTextAlign const): Deleted.
(WebCore::RenderStyle::NonInheritedFlags::setHasExplicitlySetTextAlign): Deleted.
(WebCore::RenderStyle::NonInheritedFlags::flagsMemoryOffset): Deleted.
(WebCore::RenderStyle::NonInheritedFlags::flagIsaffectedByActive): Deleted.
(WebCore::RenderStyle::NonInheritedFlags::flagIsaffectedByHover): Deleted.
(WebCore::RenderStyle::NonInheritedFlags::flagPseudoStyle): Deleted.
(WebCore::RenderStyle::NonInheritedFlags::setFirstChildStateFlags): Deleted.
(WebCore::RenderStyle::NonInheritedFlags::setLastChildStateFlags): Deleted.
(WebCore::RenderStyle::NonInheritedFlags::flagIsUnique): Deleted.
(WebCore::RenderStyle::NonInheritedFlags::flagFirstChildState): Deleted.
(WebCore::RenderStyle::NonInheritedFlags::flagLastChildState): Deleted.
(WebCore::RenderStyle::NonInheritedFlags::NonInheritedFlags): Deleted.
(WebCore::RenderStyle::NonInheritedFlags::setHasPseudoStyles): Deleted.
(WebCore::RenderStyle::NonInheritedFlags::updateBoolean): Deleted.
(WebCore::RenderStyle::NonInheritedFlags::getBoolean const): Deleted.
(WebCore::RenderStyle::NonInheritedFlags::updateValue): Deleted.
(WebCore::RenderStyle::InheritedFlags::operator== const): Deleted.
(WebCore::RenderStyle::NonInheritedFlags::getValue const): Deleted.
(WebCore::adjustForAbsoluteZoom): Deleted.
(WebCore::adjustFloatForAbsoluteZoom): Deleted.
(WebCore::adjustLayoutUnitForAbsoluteZoom): Deleted.
(WebCore::collapsedBorderStyle): Deleted.
(WebCore::RenderStyle::hasBackground const): Deleted.
(WebCore::RenderStyle::autoWrap): Deleted.
(WebCore::RenderStyle::preserveNewline): Deleted.
(WebCore::RenderStyle::collapseWhiteSpace): Deleted.
(WebCore::RenderStyle::isCollapsibleWhiteSpace const): Deleted.
(WebCore::RenderStyle::breakOnlyAfterWhiteSpace const): Deleted.
(WebCore::RenderStyle::breakWords const): Deleted.
(WebCore::RenderStyle::hasInlineColumnAxis const): Deleted.
(WebCore::RenderStyle::imageOrientation const): Deleted.
(WebCore::RenderStyle::setLogicalWidth): Deleted.
(WebCore::RenderStyle::setLogicalHeight): Deleted.
(WebCore::RenderStyle::setBorderRadius): Deleted.
(WebCore::RenderStyle::setZoom): Deleted.
(WebCore::RenderStyle::setEffectiveZoom): Deleted.
(WebCore::RenderStyle::setTextOrientation): Deleted.
(WebCore::RenderStyle::adjustBackgroundLayers): Deleted.
(WebCore::RenderStyle::adjustMaskLayers): Deleted.
(WebCore::RenderStyle::clearAnimations): Deleted.
(WebCore::RenderStyle::clearTransitions): Deleted.
(WebCore::RenderStyle::setShapeOutside): Deleted.
(WebCore::RenderStyle::setShapeImageThreshold): Deleted.
(WebCore::RenderStyle::setClipPath): Deleted.
(WebCore::RenderStyle::willChangeCreatesStackingContext const): Deleted.
(WebCore::RenderStyle::isDisplayRegionType const): Deleted.
(WebCore::RenderStyle::setWritingMode): Deleted.
(WebCore::RenderStyle::getShadowInlineDirectionExtent const): Deleted.
(WebCore::RenderStyle::getShadowBlockDirectionExtent const): Deleted.
(WebCore::RenderStyle::isDisplayReplacedType): Deleted.
(WebCore::RenderStyle::isDisplayInlineType): Deleted.
(WebCore::RenderStyle::isDisplayFlexibleBox): Deleted.
(WebCore::RenderStyle::isDisplayGridBox): Deleted.
(WebCore::RenderStyle::isDisplayFlexibleOrGridBox): Deleted.
(WebCore::RenderStyle::hasAnyPublicPseudoStyles const): Deleted.
(WebCore::RenderStyle::hasPseudoStyle const): Deleted.
(WebCore::RenderStyle::setHasPseudoStyle): Deleted.
(WebCore::RenderStyle::setHasPseudoStyles): Deleted.
(WebCore::RenderStyle::setBoxReflect): Deleted.
(WebCore::pseudoElementRendererIsNeeded): Deleted.
- 1:39 AM Changeset in webkit [221529] by
-
- 5 edits in releases/WebKitGTK/webkit-2.18
Merge r221423 - REGRESSION (r220052): ASSERTION FAILED: !frame().isMainFrame() !needsStyleRecalcOrLayout() in WebCore::FrameView::updateLayoutAndStyleIfNeededRecursive() https://bugs.webkit.org/show_bug.cgi?id=175270
Reviewed by Simon Fraser and Antti Koivisto.
Source/WebCore:
- dom/Document.cpp:
(WebCore::Document::Document): Initialize m_styleRecalcTimer with a lamdba so it can work
with a function that returns a bool and ignore the return value.
(WebCore::Document::updateStyleIfNeeded): Added a boolean return value indicating if the
function did any work or not.
- dom/Document.h: Updated for above change.
- page/FrameView.cpp:
(WebCore::appendRenderedChildren): Added helper that will later replace the
FrameView::renderedChildFrameViews function and is used below.
(WebCore::FrameView::updateLayoutAndStyleIfNeededRecursive): Instead of always doing two
passes of style and layout update do up to 25 passes, but stop as soon as a pass does
no work. This is slightly more efficient in cases where no layout and style update is
needed, and works correctly when a additional passes are needed, which is what happens
in the test that was failing. We can eventually improve this further, but this resolves
the immediate problem we are seeing in the test.
LayoutTests:
- platform/mac-wk2/TestExpectations: Re-enable the disabled test.
- 1:35 AM Changeset in webkit [221528] by
-
- 27 edits5 adds in trunk
[DFG] Relax arity requirement
https://bugs.webkit.org/show_bug.cgi?id=175523
Reviewed by Saam Barati.
JSTests:
- stress/arity-mismatch-arguments-length.js: Added.
(shouldBe):
(test1):
(test):
- stress/arity-mismatch-get-argument.js: Added.
(shouldBe):
(builtin.createBuiltin):
(test):
- stress/arity-mismatch-inlining-extra-slots.js: Added.
(shouldBe):
(inlineTarget):
(test):
- stress/arity-mismatch-inlining.js: Added.
(shouldBe):
(inlineTarget):
(test):
- stress/arity-mismatch-rest.js: Added.
(shouldBe):
(test2):
(test1):
(test):
Source/JavaScriptCore:
Our DFG pipeline gives up inlining when the arity of the target function is more than the number of the arguments.
It effectively prevents us from inlining and optimizing functions, which takes some optional arguments in the form
of the pre-ES6.
This patch removes the above restriction by performing the arity fixup in DFG.
SixSpeed shows improvement when we can inline arity-mismatched functions. (For example, calling generator.next()).
baseline patched
defaults.es5 1232.1226+-20.6775 442.3326+-26.1883 definitely 2.7855x faster
rest.es6 5.3406+-0.8588 3.5812+-0.5388 definitely 1.4913x faster
spread-generator.es6 320.9107+-12.4808 310.4295+-12.0047 might be 1.0338x faster
generator.es6 318.3514+-9.6023 286.4974+-12.6203 definitely 1.1112x faster
- bytecode/InlineCallFrame.cpp:
(JSC::InlineCallFrame::dumpInContext const):
- bytecode/InlineCallFrame.h:
(JSC::InlineCallFrame::InlineCallFrame):
- dfg/DFGAbstractInterpreterInlines.h:
(JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):
- dfg/DFGArgumentsEliminationPhase.cpp:
- dfg/DFGArgumentsUtilities.cpp:
(JSC::DFG::argumentsInvolveStackSlot):
(JSC::DFG::emitCodeToGetArgumentsArrayLength):
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::setLocal):
(JSC::DFG::ByteCodeParser::setArgument):
(JSC::DFG::ByteCodeParser::findArgumentPositionForLocal):
(JSC::DFG::ByteCodeParser::flush):
(JSC::DFG::ByteCodeParser::getArgumentCount):
(JSC::DFG::ByteCodeParser::inliningCost):
(JSC::DFG::ByteCodeParser::inlineCall):
(JSC::DFG::ByteCodeParser::attemptToInlineCall):
(JSC::DFG::ByteCodeParser::parseBlock):
(JSC::DFG::ByteCodeParser::InlineStackEntry::InlineStackEntry):
- dfg/DFGCommonData.cpp:
(JSC::DFG::CommonData::validateReferences):
- dfg/DFGConstantFoldingPhase.cpp:
(JSC::DFG::ConstantFoldingPhase::foldConstants):
- dfg/DFGGraph.cpp:
(JSC::DFG::Graph::isLiveInBytecode):
- dfg/DFGGraph.h:
(JSC::DFG::Graph::forAllLocalsLiveInBytecode):
- dfg/DFGOSRAvailabilityAnalysisPhase.cpp:
(JSC::DFG::LocalOSRAvailabilityCalculator::executeNode):
- dfg/DFGOSRExit.cpp:
(JSC::DFG::OSRExit::emitRestoreArguments):
- dfg/DFGOSRExitCompilerCommon.cpp:
(JSC::DFG::reifyInlinedCallFrames):
- dfg/DFGPreciseLocalClobberize.h:
(JSC::DFG::PreciseLocalClobberizeAdaptor::readTop):
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::emitGetLength):
(JSC::DFG::SpeculativeJIT::compileCreateDirectArguments):
- dfg/DFGStackLayoutPhase.cpp:
(JSC::DFG::StackLayoutPhase::run):
- ftl/FTLCompile.cpp:
(JSC::FTL::compile):
- ftl/FTLLowerDFGToB3.cpp:
(JSC::FTL::DFG::LowerDFGToB3::compileGetMyArgumentByVal):
(JSC::FTL::DFG::LowerDFGToB3::getArgumentsLength):
- ftl/FTLOperations.cpp:
(JSC::FTL::operationMaterializeObjectInOSR):
- interpreter/StackVisitor.cpp:
(JSC::StackVisitor::readInlinedFrame):
- jit/AssemblyHelpers.h:
(JSC::AssemblyHelpers::argumentsStart):
- jit/SetupVarargsFrame.cpp:
(JSC::emitSetupVarargsFrameFastCase):
- runtime/ClonedArguments.cpp:
(JSC::ClonedArguments::createWithInlineFrame):
- runtime/CommonSlowPaths.h:
(JSC::CommonSlowPaths::numberOfExtraSlots):
(JSC::CommonSlowPaths::numberOfStackPaddingSlots):
(JSC::CommonSlowPaths::numberOfStackPaddingSlotsWithExtraSlots):
(JSC::CommonSlowPaths::arityCheckFor):
- runtime/StackAlignment.h:
(JSC::stackAlignmentBytes):
(JSC::stackAlignmentRegisters):
- 1:20 AM Changeset in webkit [221527] by
-
- 4 edits in releases/WebKitGTK/webkit-2.18
Merge r221420 - [GTK] Several InputMethodFilter tests are failing and crashing
https://bugs.webkit.org/show_bug.cgi?id=176158
Reviewed by Carlos Alberto Lopez Perez.
Source/WebKit:
- UIProcess/gtk/InputMethodFilter.cpp:
(WebKit::InputMethodFilter::confirmCurrentComposition): Return early in testing mode because the page is not available.
(WebKit::InputMethodFilter::logHandleKeyboardEventWithCompositionResultsForTesting): Use hexadecimal numbers for
logging key codes.
Tools:
This started to happen after the GTK+ upgrade from 3.16 to 3.22 in the internal jhbuild. Now, GtkIMContext
doesn't emit the preedit signals when using the compose key (GDK_KEY_Multi_key). The composition results are
committed directly when they are ready. The test InputMethodFilterComposeKey was failing because it expected
preedit events that no longer happen. Tests InputMethodFilterContextFocusOutDuringOngoingComposition and
InputMethodFilterContextMouseClickDuringOngoingComposition were crashing because InputMethodFilter::confirmCurrentComposition()
accessed the WebPageProxy unconditionally, that is not available in testing mode. I wonder how this ever
worked. Other tests results have also been updated because logHandleKeyboardEventWithCompositionResultsForTesting()
now uses hexadecimal numbers for the key codes, for consistency with all other event logs.
- TestWebKitAPI/Tests/WebKit/gtk/InputMethodFilter.cpp:
(TestWebKitAPI::TestInputMethodFilter::TestInputMethodFilter):
(TestWebKitAPI::TEST):
(TestWebKitAPI::verifyCanceledComposition): Deleted.
- 1:20 AM Changeset in webkit [221526] by
-
- 8 edits in releases/WebKitGTK/webkit-2.18
Merge r221419 - [GTK][Wayland] Crash when gdk_keymap_get_entries_for_keyval returns TRUE but n_keys=0
https://bugs.webkit.org/show_bug.cgi?id=176154
Reviewed by Carlos Alberto Lopez Perez.
Source/WebKit:
In Wayland gdk_keymap_get_entries_for_keyval() can return TRUE with n_keys=0. We have several places in WebKit
where we just check the return value of gdk_keymap_get_entries_for_keyval() and then use the returned array to
get the first position assuming it has at least one item. This has always worked in X11 because the GDK X11
backend does the right thing, but it's crashing in Wayland now. It should be fixed in GTK+ but in the meantime
it's easy to workaround by also checking n_keys > 0.
- UIProcess/Automation/gtk/WebAutomationSessionGtk.cpp:
(WebKit::doKeyStrokeEvent):
Tools:
Also check the n_keys > 0 when using gdk_keymap_get_entries_for_keyval().
- TestWebKitAPI/Tests/WebKit/gtk/InputMethodFilter.cpp:
(TestWebKitAPI::TestInputMethodFilter::sendKeyEventToFilter):
- TestWebKitAPI/Tests/WebKitGtk/TestPrinting.cpp: Remove duplicated code and use WebViewTest::keyStroke instead.
- TestWebKitAPI/glib/WebKitGLib/gtk/WebViewTestGtk.cpp:
(WebViewTest::keyStroke):
- TestWebKitAPI/gtk/PlatformWebViewGtk.cpp:
(TestWebKitAPI::doKeyStroke):
- WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
(WTR::EventSenderProxy::keyDown):
- 1:16 AM Changeset in webkit [221525] by
-
- 2 edits in releases/WebKitGTK/webkit-2.18/Tools
Merge r221416 - Unreviewed. Fix GTK+ test /webkit2/WebKitAutomationSession/request-session.
It fails when comparing the browser version if micro version is 0 (or if both micro and minor are 0 too).
- TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp: Use a helper method to convert major, minor, micro
numbers into a version string, using the same approach as WebKitAutomationSession.
- 1:15 AM Changeset in webkit [221524] by
-
- 2 edits in releases/WebKitGTK/webkit-2.18/Source/WebCore/platform/gtk/po
Merge r221411 - [l10n] [pt_BR] Updated Brazilian Portuguese translation
https://bugs.webkit.org/show_bug.cgi?id=176107
Patch by Rafael Fontenelle <rafaelff@gnome.org> on 2017-08-30
Rubber-stamped by Michael Catanzaro.
- pt_BR.po:
- 1:14 AM Changeset in webkit [221523] by
-
- 3 edits2 adds in releases/WebKitGTK/webkit-2.18
Merge r221408 - Previous elements with lang= can affect fonts selected for subsequent elements
https://bugs.webkit.org/show_bug.cgi?id=175959
<rdar://problem/33785853>
Reviewed by Zalan Bujtas.
Source/WebCore:
FontCascade::update() was erroneously getting a cache hit. Elements with different lang=
should be distinct inside the FontCascadeCache. We should be keying off of the locale
string instead of the script enum because the string is the thing we actually pass to the
platform APIs when performing font selection. This is a regression because we only
recently (within the past few years) started making font selection sensitive to lang= at
all.
Test: fast/text/lang-font-selection-cache.html
- platform/graphics/FontCache.h:
(WebCore::FontDescriptionKey::FontDescriptionKey):
(WebCore::FontDescriptionKey::operator== const):
(WebCore::FontDescriptionKey::computeHash const):
LayoutTests:
- fast/text/lang-font-selection-cache-expected.html: Added.
- fast/text/lang-font-selection-cache.html: Added.
- 1:10 AM Changeset in webkit [221522] by
-
- 3 edits2 adds in releases/WebKitGTK/webkit-2.18
Merge r221400 - semicolon is being interpreted as an = in the LiteralParser
https://bugs.webkit.org/show_bug.cgi?id=176114
Reviewed by Oliver Hunt.
JSTests:
- stress/jsonp-literal-parser-semicolon-is-not-assignment.js: Added.
- stress/resources/literal-parser-test-case.js: Added.
Source/JavaScriptCore:
When lexing a semicolon in the LiteralParser, we were properly
setting the TokenType on the current token, however, we were
*returning* the wrong TokenType. The lex function both returns
the TokenType and sets it on the current token. Semicolon was
setting the TokenType to semicolon, but returning the TokenType
for '='. This caused programs likex;123to be interpreted as
x=123.
- runtime/LiteralParser.cpp:
(JSC::LiteralParser<CharType>::Lexer::lex):
(JSC::LiteralParser<CharType>::Lexer::next):
- 1:10 AM Changeset in webkit [221521] by
-
- 5 edits in trunk/Source
[GTK][Wayland] Use fast malloc to allocate backing store cairo surfaces data
https://bugs.webkit.org/show_bug.cgi?id=176226
Reviewed by Michael Catanzaro.
Source/WebCore:
It reduces the memory consumption and improves the performance. Also, since performance is better we don't need
to keep the scroll surface allocated all the time, we can create it on demand and keep it allocated only while
scrolling too fast.
- platform/graphics/cairo/BackingStoreBackendCairoImpl.cpp:
(WebCore::createCairoImageSurfaceWithFastMalloc): Helper to create a cairo image surface using fast malloc.
(WebCore::BackingStoreBackendCairoImpl::BackingStoreBackendCairoImpl): Create the main surface, but no the
scroll one. Initialize the hysteresis activity to discard the scroll surface after scrolling.
(WebCore::BackingStoreBackendCairoImpl::scroll): Create the scroll surface only if it's nullptr, and notify the
hysteresis activity.
- platform/graphics/cairo/BackingStoreBackendCairoImpl.h:
Source/WebKit:
Do not create the cairo surface for BackingStoreBackendCairoImpl. When not using X11 we are going to use an
image surface anyway, so we don't really need to use the create similar. This way we only need to pass the size
and device scale factor to BackingStoreBackendCairoImpl that will create the image surface using fast malloc to
allocate the data.
- UIProcess/cairo/BackingStoreCairo.cpp:
(WebKit::BackingStore::createBackend):
- 1:01 AM Changeset in webkit [221520] by
-
- 27 edits7 adds in releases/WebKitGTK/webkit-2.18
Merge r221377 - The SVG fragment identifier is not respected if it is a part of an HTTP URL
https://bugs.webkit.org/show_bug.cgi?id=163811
Patch by Said Abou-Hallawa <sabouhallawa@apple.com> on 2017-08-30
Reviewed by Darin Adler.
Source/WebCore:
If an image is referenced more than once in a page and the URL to that
image is an HTTP URL, one CachedImage is created for all the renderers
even if the original URLs have different fragmentIdentifiers. In this
case the fragment will be removed from the request which is associated
with the shared CachedImage. This CachedImage creates an SVGImage with
a URL but without a fragmentIdentifier. So SVGImage::draw() does not call
FrameView::scrollToFragment() and therefore the viewport is not setup
correctly for displaying the SVG in this case.
The fix is to move the url from the SVGImage to SVGImageForContainer.
Because there is one SVGImageForContainer created for every renderer,
we can move the full URL there. The drawing of an SVGImage has to start
from the SVGImageForContainer::draw() because the SVGImage may not have
an intrinsic size and the SVGImageForContainer is the one which knows
the destination rectangle. So SVGImageForContainer can pass the full url
to SVGImage::drawForContainer() which can be used to scrollToFragment()
before calling SVGImage::draw().
For clarity and consistency, all setContainerSizeForRenderer() will be
changed to setContainerContext() and the pair SizeAndZoom will be replaced
by the struct ContainerContext.
Tests: http/tests/svg/svg-fragment-background.html
http/tests/svg/svg-fragment-image.html
- css/CSSCursorImageValue.h:
- css/CSSImageSetValue.cpp:
(WebCore::CSSImageSetValue::fillImageSet):
- css/CSSImageSetValue.h:
- loader/cache/CachedImage.cpp:
(WebCore::CachedImage::didRemoveClient):
(WebCore::CachedImage::switchClientsToRevalidatedResource):
(WebCore::CachedImage::allClientsRemoved):
(WebCore::CachedImage::setContainerContextForClient):
(WebCore::CachedImage::clear):
(WebCore::CachedImage::createImage):
(WebCore::CachedImage::setContainerSizeForRenderer): Deleted.
- loader/cache/CachedImage.h:
- rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::calculateBackgroundImageGeometry const):
(WebCore::RenderBoxModelObject::paintNinePieceImage):
- rendering/RenderImage.cpp:
(WebCore::RenderImage::updateInnerContentRect):
(WebCore::RenderImage::repaintOrMarkForLayout):
- rendering/RenderImageResource.cpp:
(WebCore::RenderImageResource::setContainerContext):
(WebCore::RenderImageResource::setContainerSizeForRenderer): Deleted.
- rendering/RenderImageResource.h:
- rendering/RenderImageResourceStyleImage.cpp:
(WebCore::RenderImageResourceStyleImage::setContainerContext):
(WebCore::RenderImageResourceStyleImage::setContainerSizeForRenderer): Deleted.
- rendering/RenderImageResourceStyleImage.h:
- rendering/RenderListMarker.cpp:
(WebCore::RenderListMarker::updateContent):
- rendering/shapes/ShapeOutsideInfo.cpp:
(WebCore::ShapeOutsideInfo::createShapeForImage const):
- rendering/style/StyleCachedImage.cpp:
(WebCore::StyleCachedImage::imageURL):
(WebCore::StyleCachedImage::setContainerContextForRenderer):
(WebCore::StyleCachedImage::setContainerSizeForRenderer): Deleted.
- rendering/style/StyleCachedImage.h:
- rendering/style/StyleGeneratedImage.h:
- rendering/style/StyleImage.h:
- rendering/svg/RenderSVGImage.cpp:
(WebCore::RenderSVGImage::updateImageViewport):
- svg/SVGImageElement.h:
- svg/graphics/SVGImage.cpp:
(WebCore::SVGImage::SVGImage):
(WebCore::SVGImage::drawForContainer):
(WebCore::SVGImage::drawPatternForContainer):
(WebCore::SVGImage::draw):
(WebCore::SVGImage::dump const): Deleted.
- svg/graphics/SVGImage.h:
- svg/graphics/SVGImageCache.cpp:
(WebCore::SVGImageCache::setContainerContextForClient):
(WebCore::SVGImageCache::setContainerSizeForRenderer): Deleted.
- svg/graphics/SVGImageCache.h:
- svg/graphics/SVGImageForContainer.cpp:
(WebCore::SVGImageForContainer::size const):
(WebCore::SVGImageForContainer::draw):
(WebCore::SVGImageForContainer::drawPattern):
- svg/graphics/SVGImageForContainer.h:
LayoutTests:
- http/tests/svg/resources/rgb-icons-1.svg: Added.
- http/tests/svg/resources/rgb-icons-2.svg: Added.
- http/tests/svg/resources/rgb-icons-3.svg: Added.
- http/tests/svg/svg-fragment-background-expected.html: Added.
- http/tests/svg/svg-fragment-background.html: Added.
- http/tests/svg/svg-fragment-image-expected.html: Added.
- http/tests/svg/svg-fragment-image.html: Added.
- 12:50 AM Changeset in webkit [221519] by
-
- 3 edits2 adds in releases/WebKitGTK/webkit-2.18
Merge r221335 - Assertion failure when opening a file with a missing tag closing bracket
https://bugs.webkit.org/show_bug.cgi?id=176061
Patch by Said Abou-Hallawa <sabouhallawa@apple.com> on 2017-08-29
Reviewed by Darin Adler.
Source/WebCore:
If a tag is missing its closing bracket, the tokenizer just needs to advance()
the character position without checking m_currentCharacter != '\n'. Newline
character is a valid ending for partially closed tags.
Test: fast/tokenizer/missing-script-tag-closing-bracket.html
- html/parser/HTMLTokenizer.cpp:
(WebCore::HTMLTokenizer::commitToPartialEndTag):
LayoutTests:
- fast/tokenizer/missing-script-tag-closing-bracket-expected.txt: Added.
- fast/tokenizer/missing-script-tag-closing-bracket.html: Added.
- 12:48 AM Changeset in webkit [221518] by
-
- 3 edits in releases/WebKitGTK/webkit-2.18/Tools
Merge r221295 - Unreviewed. REGRESSION(r221219): Fix unit tests using resources from WebKit directory.
The WebKit2 directory was renamed as WebKit in r221219, but neither run-gtk-tests script nor
Test::getResourcesDir() were updated to use the new name.
- Scripts/run-gtk-tests:
(TestRunner._setup_testing_environment):
- TestWebKitAPI/glib/WebKitGLib/TestMain.h:
(Test::getResourcesDir):
- 12:47 AM Changeset in webkit [221517] by
-
- 4 edits250 moves3 adds in releases/WebKitGTK/webkit-2.18/Tools
Merge r221219 - Rename TestWebKitAPI/Tests/WebKit2* to WebKit* following Source directory rename.
Rubber-stamped by Brady Eidson.
- TestWebKitAPI/PlatformGTK.cmake:
- TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
- TestWebKitAPI/Tests/WebKit2Cocoa: Removed.
- TestWebKitAPI/Tests/WebKit2Cocoa/AdditionalReadAccessAllowedURLs.mm: Removed.
- TestWebKitAPI/Tests/WebKit2Cocoa/AdditionalReadAccessAllowedURLsPlugin.mm: Removed.
- TestWebKitAPI/Tests/WebKit2Cocoa/AdditionalReadAccessAllowedURLsProtocol.h: Removed.
- TestWebKitAPI/Tests/WebKit2Cocoa/AllAhem.svg: Removed.
- TestWebKitAPI/Tests/WebKit2Cocoa/AlwaysRevalidatedURLSchemes.mm: Removed.
- TestWebKitAPI/Tests/WebKit2Cocoa/AnimatedResize.mm: Removed.
- TestWebKitAPI/Tests/WebKit2Cocoa/ApplicationCache.db: Removed.
- TestWebKitAPI/Tests/WebKit2Cocoa/ApplicationCache.db-shm: Removed.
- TestWebKitAPI/Tests/WebKit2Cocoa/ApplicationCache.db-wal: Removed.
- TestWebKitAPI/Tests/WebKit2Cocoa/AutoLayoutIntegration.mm: Removed.
- TestWebKitAPI/Tests/WebKit2Cocoa/BundleEditingDelegate.mm: Removed.
- TestWebKitAPI/Tests/WebKit2Cocoa/BundleEditingDelegatePlugIn.mm: Removed.
- TestWebKitAPI/Tests/WebKit2Cocoa/BundleEditingDelegateProtocol.h: Removed.
- TestWebKitAPI/Tests/WebKit2Cocoa/BundleParameters.mm: Removed.
- TestWebKitAPI/Tests/WebKit2Cocoa/BundleParametersPlugIn.mm: Removed.
- TestWebKitAPI/Tests/WebKit2Cocoa/BundleRangeHandle.mm: Removed.
- TestWebKitAPI/Tests/WebKit2Cocoa/BundleRangeHandlePlugIn.mm: Removed.
- TestWebKitAPI/Tests/WebKit2Cocoa/BundleRangeHandleProtocol.h: Removed.
- TestWebKitAPI/Tests/WebKit2Cocoa/CancelFontSubresource.mm: Removed.
- TestWebKitAPI/Tests/WebKit2Cocoa/CancelFontSubresourcePlugIn.mm: Removed.
- TestWebKitAPI/Tests/WebKit2Cocoa/Coding.mm: Removed.
- TestWebKitAPI/Tests/WebKit2Cocoa/CommandBackForward.mm: Removed.
- TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.h: Removed.
- TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.html: Removed.
- TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.mm: Removed.
- TestWebKitAPI/Tests/WebKit2Cocoa/ContentFilteringPlugIn.mm: Removed.
- TestWebKitAPI/Tests/WebKit2Cocoa/CookieAcceptPolicy.mm: Removed.
- TestWebKitAPI/Tests/WebKit2Cocoa/CookieMessage.html: Removed.
- TestWebKitAPI/Tests/WebKit2Cocoa/Copying.mm: Removed.
- TestWebKitAPI/Tests/WebKit2Cocoa/DataDetection.mm: Removed.
- TestWebKitAPI/Tests/WebKit2Cocoa/DecidePolicyForNavigationAction.mm: Removed.
- TestWebKitAPI/Tests/WebKit2Cocoa/DoAfterNextPresentationUpdateAfterCrash.mm: Removed.
- TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm: Removed.
- TestWebKitAPI/Tests/WebKit2Cocoa/DownloadRequestBlobURL.html: Removed.
- TestWebKitAPI/Tests/WebKit2Cocoa/DownloadRequestOriginalURL.html: Removed.
- TestWebKitAPI/Tests/WebKit2Cocoa/DownloadRequestOriginalURL2.html: Removed.
- TestWebKitAPI/Tests/WebKit2Cocoa/DownloadRequestOriginalURLFrame.html: Removed.
- TestWebKitAPI/Tests/WebKit2Cocoa/DuplicateCompletionHandlerCalls.mm: Removed.
- TestWebKitAPI/Tests/WebKit2Cocoa/EditorStateTests.mm: Removed.
- TestWebKitAPI/Tests/WebKit2Cocoa/EmptyGrandfatheredResourceLoadStatistics.plist: Removed.
- TestWebKitAPI/Tests/WebKit2Cocoa/FindInPage.mm: Removed.
- TestWebKitAPI/Tests/WebKit2Cocoa/FixedLayoutSize.mm: Removed.
- TestWebKitAPI/Tests/WebKit2Cocoa/FullscreenDelegate.html: Removed.
- TestWebKitAPI/Tests/WebKit2Cocoa/FullscreenDelegate.mm: Removed.
- TestWebKitAPI/Tests/WebKit2Cocoa/FullscreenLayoutConstraints.html: Removed.
- TestWebKitAPI/Tests/WebKit2Cocoa/FullscreenLayoutConstraints.mm: Removed.
- TestWebKitAPI/Tests/WebKit2Cocoa/FullscreenTopContentInset.html: Removed.
- TestWebKitAPI/Tests/WebKit2Cocoa/FullscreenTopContentInset.mm: Removed.
- TestWebKitAPI/Tests/WebKit2Cocoa/Geolocation.mm: Removed.
- TestWebKitAPI/Tests/WebKit2Cocoa/GeolocationGetCurrentPositionResult.html: Removed.
- TestWebKitAPI/Tests/WebKit2Cocoa/IDBDeleteRecovery.html: Removed.
- TestWebKitAPI/Tests/WebKit2Cocoa/IDBDeleteRecovery.mm: Removed.
- TestWebKitAPI/Tests/WebKit2Cocoa/IDBDeleteRecovery.sqlite3: Removed.
- TestWebKitAPI/Tests/WebKit2Cocoa/IDBDeleteRecovery.sqlite3-shm: Removed.
- TestWebKitAPI/Tests/WebKit2Cocoa/IDBDeleteRecovery.sqlite3-wal: Removed.
- TestWebKitAPI/Tests/WebKit2Cocoa/IDBIndexUpgradeToV2.html: Removed.
- TestWebKitAPI/Tests/WebKit2Cocoa/IDBIndexUpgradeToV2.mm: Removed.
- TestWebKitAPI/Tests/WebKit2Cocoa/IconLoadingDelegate.mm: Removed.
- TestWebKitAPI/Tests/WebKit2Cocoa/IndexUpgrade.blob: Removed.
- TestWebKitAPI/Tests/WebKit2Cocoa/IndexUpgrade.sqlite3: Removed.
- TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBDatabaseProcessKill-1.html: Removed.
- TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBDatabaseProcessKill.mm: Removed.
- TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBMultiProcess-1.html: Removed.
- TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBMultiProcess-2.html: Removed.
- TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBMultiProcess-3.html: Removed.
- TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBMultiProcess.mm: Removed.
- TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBPersistence-1.html: Removed.
- TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBPersistence-2.html: Removed.
- TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBPersistence.mm: Removed.
- TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBStructuredCloneBackwardCompatibility.mm: Removed.
- TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBStructuredCloneBackwardCompatibility.sqlite3: Removed.
- TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBStructuredCloneBackwardCompatibility.sqlite3-shm: Removed.
- TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBStructuredCloneBackwardCompatibility.sqlite3-wal: Removed.
- TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBStructuredCloneBackwardCompatibilityRead.html: Removed.
- TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBStructuredCloneBackwardCompatibilityWrite.html: Removed.
- TestWebKitAPI/Tests/WebKit2Cocoa/InitialWarmedProcessUsed.mm: Removed.
- TestWebKitAPI/Tests/WebKit2Cocoa/InteractionDeadlockAfterCrash.mm: Removed.
- TestWebKitAPI/Tests/WebKit2Cocoa/LineBreaking.html: Removed.
- TestWebKitAPI/Tests/WebKit2Cocoa/LoadAlternateHTMLString.mm: Removed.
- TestWebKitAPI/Tests/WebKit2Cocoa/LoadDataWithNilMIMEType.mm: Removed.
- TestWebKitAPI/Tests/WebKit2Cocoa/LoadInvalidURLRequest.mm: Removed.
- TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageClear.html: Removed.
- TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageClear.mm: Removed.
- TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageNullEntries.html: Removed.
- TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageNullEntries.localstorage: Removed.
- TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageNullEntries.localstorage-shm: Removed.
- TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageNullEntries.mm: Removed.
- TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageQuirkEnabled.html: Removed.
- TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageQuirkTest.mm: Removed.
- TestWebKitAPI/Tests/WebKit2Cocoa/ModalAlerts.mm: Removed.
- TestWebKitAPI/Tests/WebKit2Cocoa/NSFileManagerExtras.mm: Removed.
- TestWebKitAPI/Tests/WebKit2Cocoa/Navigation.mm: Removed.
- TestWebKitAPI/Tests/WebKit2Cocoa/NowPlayingControlsTests.mm: Removed.
- TestWebKitAPI/Tests/WebKit2Cocoa/ObservedRenderingProgressEventsAfterCrash.mm: Removed.
- TestWebKitAPI/Tests/WebKit2Cocoa/OpenAndCloseWindow.mm: Removed.
- TestWebKitAPI/Tests/WebKit2Cocoa/OverrideContentSecurityPolicy.mm: Removed.
- TestWebKitAPI/Tests/WebKit2Cocoa/PictureInPictureDelegate.html: Removed.
- TestWebKitAPI/Tests/WebKit2Cocoa/PictureInPictureDelegate.mm: Removed.
- TestWebKitAPI/Tests/WebKit2Cocoa/PluginLoadClientPolicies.mm: Removed.
- TestWebKitAPI/Tests/WebKit2Cocoa/Preferences.mm: Removed.
- TestWebKitAPI/Tests/WebKit2Cocoa/PrepareForMoveToWindow.mm: Removed.
- TestWebKitAPI/Tests/WebKit2Cocoa/ProvisionalURLNotChange.mm: Removed.
- TestWebKitAPI/Tests/WebKit2Cocoa/QuickLook.mm: Removed.
- TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.h: Removed.
- TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.mm: Removed.
- TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistryPlugIn.mm: Removed.
- TestWebKitAPI/Tests/WebKit2Cocoa/RenderedImageWithOptions.mm: Removed.
- TestWebKitAPI/Tests/WebKit2Cocoa/RenderedImageWithOptionsPlugIn.mm: Removed.
- TestWebKitAPI/Tests/WebKit2Cocoa/RenderedImageWithOptionsProtocol.h: Removed.
- TestWebKitAPI/Tests/WebKit2Cocoa/RequiresUserActionForPlayback.mm: Removed.
- TestWebKitAPI/Tests/WebKit2Cocoa/ResourceLoadStatistics.mm: Removed.
- TestWebKitAPI/Tests/WebKit2Cocoa/RunOpenPanel.mm: Removed.
- TestWebKitAPI/Tests/WebKit2Cocoa/ShouldOpenExternalURLsInNewWindowActions.mm: Removed.
- TestWebKitAPI/Tests/WebKit2Cocoa/ShrinkToFit.mm: Removed.
- TestWebKitAPI/Tests/WebKit2Cocoa/SnapshotStore.mm: Removed.
- TestWebKitAPI/Tests/WebKit2Cocoa/StoreBlobThenDelete.mm: Removed.
- TestWebKitAPI/Tests/WebKit2Cocoa/StoreBlobToBeDeleted.html: Removed.
- TestWebKitAPI/Tests/WebKit2Cocoa/UIDelegate.mm: Removed.
- TestWebKitAPI/Tests/WebKit2Cocoa/UserContentController.mm: Removed.
- TestWebKitAPI/Tests/WebKit2Cocoa/UserContentWorld.mm: Removed.
- TestWebKitAPI/Tests/WebKit2Cocoa/UserContentWorldPlugIn.mm: Removed.
- TestWebKitAPI/Tests/WebKit2Cocoa/UserContentWorldProtocol.h: Removed.
- TestWebKitAPI/Tests/WebKit2Cocoa/UserInitiatedActionInNavigationAction.mm: Removed.
- TestWebKitAPI/Tests/WebKit2Cocoa/UserMediaDisabled.mm: Removed.
- TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm: Removed.
- TestWebKitAPI/Tests/WebKit2Cocoa/VisibleContentRect.mm: Removed.
- TestWebKitAPI/Tests/WebKit2Cocoa/WKContentExtensionStore.mm: Removed.
- TestWebKitAPI/Tests/WebKit2Cocoa/WKContentViewEditingActions.mm: Removed.
- TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStore.mm: Removed.
- TestWebKitAPI/Tests/WebKit2Cocoa/WKNSNumber.mm: Removed.
- TestWebKitAPI/Tests/WebKit2Cocoa/WKObject.mm: Removed.
- TestWebKitAPI/Tests/WebKit2Cocoa/WKPDFView.mm: Removed.
- TestWebKitAPI/Tests/WebKit2Cocoa/WKPDFViewResizeCrash.mm: Removed.
- TestWebKitAPI/Tests/WebKit2Cocoa/WKPDFViewStablePresentationUpdateCallback.mm: Removed.
- TestWebKitAPI/Tests/WebKit2Cocoa/WKRequestActivatedElementInfo.mm: Removed.
- TestWebKitAPI/Tests/WebKit2Cocoa/WKURLSchemeHandler-1.mm: Removed.
- TestWebKitAPI/Tests/WebKit2Cocoa/WKURLSchemeHandler-leaks.mm: Removed.
- TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewCandidateTests.mm: Removed.
- TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewDefaultNavigationDelegate.mm: Removed.
- TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewDiagnosticLogging.mm: Removed.
- TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewDoesNotLogDuringInitialization.mm: Removed.
- TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewEvaluateJavaScript.mm: Removed.
- TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewGetContents.mm: Removed.
- TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewSnapshot.mm: Removed.
- TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewTextInput.mm: Removed.
- TestWebKitAPI/Tests/WebKit2Cocoa/WebProcessKillIDBCleanup-1.html: Removed.
- TestWebKitAPI/Tests/WebKit2Cocoa/WebProcessKillIDBCleanup-2.html: Removed.
- TestWebKitAPI/Tests/WebKit2Cocoa/WebProcessKillIDBCleanup.mm: Removed.
- TestWebKitAPI/Tests/WebKit2Cocoa/WebsiteDataStoreCustomPaths.html: Removed.
- TestWebKitAPI/Tests/WebKit2Cocoa/WebsiteDataStoreCustomPaths.mm: Removed.
- TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm: Removed.
- TestWebKitAPI/Tests/WebKit2Cocoa/_WKUserContentExtensionStore.mm: Removed.
- TestWebKitAPI/Tests/WebKit2Cocoa/apple.gif: Removed.
- TestWebKitAPI/Tests/WebKit2Cocoa/attachment-element.html: Removed.
- TestWebKitAPI/Tests/WebKit2Cocoa/autofocus-contenteditable.html: Removed.
- TestWebKitAPI/Tests/WebKit2Cocoa/autofocused-text-input.html: Removed.
- TestWebKitAPI/Tests/WebKit2Cocoa/autoplaying-video-with-audio.html: Removed.
- TestWebKitAPI/Tests/WebKit2Cocoa/background-image-link-and-input.html: Removed.
- TestWebKitAPI/Tests/WebKit2Cocoa/blinking-div.html: Removed.
- TestWebKitAPI/Tests/WebKit2Cocoa/change-video-source-on-click.html: Removed.
- TestWebKitAPI/Tests/WebKit2Cocoa/change-video-source-on-end.html: Removed.
- TestWebKitAPI/Tests/WebKit2Cocoa/compressed-files.zip: Removed.
- TestWebKitAPI/Tests/WebKit2Cocoa/contenteditable-and-target.html: Removed.
- TestWebKitAPI/Tests/WebKit2Cocoa/contenteditable-and-textarea.html: Removed.
- TestWebKitAPI/Tests/WebKit2Cocoa/contenteditable-in-iframe.html: Removed.
- TestWebKitAPI/Tests/WebKit2Cocoa/disableGetUserMedia.html: Removed.
- TestWebKitAPI/Tests/WebKit2Cocoa/div-and-large-image.html: Removed.
- TestWebKitAPI/Tests/WebKit2Cocoa/double-click-does-not-select-trailing-space.html: Removed.
- TestWebKitAPI/Tests/WebKit2Cocoa/dragstart-change-selection-offscreen.html: Removed.
- TestWebKitAPI/Tests/WebKit2Cocoa/dragstart-clear-selection.html: Removed.
- TestWebKitAPI/Tests/WebKit2Cocoa/duplicate-completion-handler-calls.html: Removed.
- TestWebKitAPI/Tests/WebKit2Cocoa/editable-body.html: Removed.
- TestWebKitAPI/Tests/WebKit2Cocoa/editor-state-test-harness.html: Removed.
- TestWebKitAPI/Tests/WebKit2Cocoa/enormous-video-with-sound.html: Removed.
- TestWebKitAPI/Tests/WebKit2Cocoa/enormous.svg: Removed.
- TestWebKitAPI/Tests/WebKit2Cocoa/file-uploading.html: Removed.
- TestWebKitAPI/Tests/WebKit2Cocoa/focus-inputs.html: Removed.
- TestWebKitAPI/Tests/WebKit2Cocoa/full-size-autoplaying-video-with-audio.html: Removed.
- TestWebKitAPI/Tests/WebKit2Cocoa/gif-and-file-input.html: Removed.
- TestWebKitAPI/Tests/WebKit2Cocoa/image-and-contenteditable.html: Removed.
- TestWebKitAPI/Tests/WebKit2Cocoa/image-and-textarea.html: Removed.
- TestWebKitAPI/Tests/WebKit2Cocoa/image-in-link-and-input.html: Removed.
- TestWebKitAPI/Tests/WebKit2Cocoa/image-map.html: Removed.
- TestWebKitAPI/Tests/WebKit2Cocoa/input-field-in-scrollable-document.html: Removed.
- TestWebKitAPI/Tests/WebKit2Cocoa/large-input-field-focus-onload.html: Removed.
- TestWebKitAPI/Tests/WebKit2Cocoa/large-red-square.png: Removed.
- TestWebKitAPI/Tests/WebKit2Cocoa/large-video-hides-controls-after-seek-to-end.html: Removed.
- TestWebKitAPI/Tests/WebKit2Cocoa/large-video-mutes-onplaying.html: Removed.
- TestWebKitAPI/Tests/WebKit2Cocoa/large-video-offscreen.html: Removed.
- TestWebKitAPI/Tests/WebKit2Cocoa/large-video-playing-scroll-away.html: Removed.
- TestWebKitAPI/Tests/WebKit2Cocoa/large-video-seek-after-ending.html: Removed.
- TestWebKitAPI/Tests/WebKit2Cocoa/large-video-seek-to-beginning-and-play-after-ending.html: Removed.
- TestWebKitAPI/Tests/WebKit2Cocoa/large-video-test-now-playing.html: Removed.
- TestWebKitAPI/Tests/WebKit2Cocoa/large-video-with-audio.html: Removed.
- TestWebKitAPI/Tests/WebKit2Cocoa/large-video-with-audio.mp4: Removed.
- TestWebKitAPI/Tests/WebKit2Cocoa/large-video-without-audio.html: Removed.
- TestWebKitAPI/Tests/WebKit2Cocoa/large-videos-autoplaying-click-to-pause.html: Removed.
- TestWebKitAPI/Tests/WebKit2Cocoa/large-videos-autoplaying-scroll-to-video.html: Removed.
- TestWebKitAPI/Tests/WebKit2Cocoa/large-videos-paused-video-hides-controls.html: Removed.
- TestWebKitAPI/Tests/WebKit2Cocoa/large-videos-playing-muted-video-hides-controls.html: Removed.
- TestWebKitAPI/Tests/WebKit2Cocoa/large-videos-playing-video-keeps-controls.html: Removed.
- TestWebKitAPI/Tests/WebKit2Cocoa/large-videos-with-audio-autoplay.html: Removed.
- TestWebKitAPI/Tests/WebKit2Cocoa/large-videos-with-audio.html: Removed.
- TestWebKitAPI/Tests/WebKit2Cocoa/link-and-input.html: Removed.
- TestWebKitAPI/Tests/WebKit2Cocoa/link-and-target-div.html: Removed.
- TestWebKitAPI/Tests/WebKit2Cocoa/offscreen-iframe-of-media-document.html: Removed.
- TestWebKitAPI/Tests/WebKit2Cocoa/open-multiple-external-url.html: Removed.
- TestWebKitAPI/Tests/WebKit2Cocoa/page-with-csp-iframe.html: Removed.
- TestWebKitAPI/Tests/WebKit2Cocoa/page-with-csp.html: Removed.
- TestWebKitAPI/Tests/WebKit2Cocoa/page-without-csp-iframe.html: Removed.
- TestWebKitAPI/Tests/WebKit2Cocoa/page-without-csp.html: Removed.
- TestWebKitAPI/Tests/WebKit2Cocoa/password-protected.pages: Removed.
- TestWebKitAPI/Tests/WebKit2Cocoa/play-audio-on-click.html: Removed.
- TestWebKitAPI/Tests/WebKit2Cocoa/prevent-operation.html: Removed.
- TestWebKitAPI/Tests/WebKit2Cocoa/prevent-start.html: Removed.
- TestWebKitAPI/Tests/WebKit2Cocoa/rendered-image-excluding-overflow.html: Removed.
- TestWebKitAPI/Tests/WebKit2Cocoa/rich-and-plain-text.html: Removed.
- TestWebKitAPI/Tests/WebKit2Cocoa/silence-long.m4a: Removed.
- TestWebKitAPI/Tests/WebKit2Cocoa/skinny-autoplaying-video-with-audio.html: Removed.
- TestWebKitAPI/Tests/WebKit2Cocoa/text-and-password-inputs.html: Removed.
- TestWebKitAPI/Tests/WebKit2Cocoa/textarea-to-input.html: Removed.
- TestWebKitAPI/Tests/WebKit2Cocoa/two-paragraph-contenteditable.html: Removed.
- TestWebKitAPI/Tests/WebKit2Cocoa/wide-autoplaying-video-with-audio.html: Removed.
- TestWebKitAPI/Tests/WebKit2Gtk: Removed.
- TestWebKitAPI/Tests/WebKit2Gtk/AccessibilityTestServer.cpp: Removed.
- TestWebKitAPI/Tests/WebKit2Gtk/AutocleanupsTest.cpp: Removed.
- TestWebKitAPI/Tests/WebKit2Gtk/DOMClientRectTest.cpp: Removed.
- TestWebKitAPI/Tests/WebKit2Gtk/DOMDOMWindowTest.cpp: Removed.
- TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeFilterTest.cpp: Removed.
- TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeTest.cpp: Removed.
- TestWebKitAPI/Tests/WebKit2Gtk/DOMXPathNSResolverTest.cpp: Removed.
- TestWebKitAPI/Tests/WebKit2Gtk/EditorTest.cpp: Removed.
- TestWebKitAPI/Tests/WebKit2Gtk/InspectorTestServer.cpp: Removed.
- TestWebKitAPI/Tests/WebKit2Gtk/TestAutocleanups.cpp: Removed.
- TestWebKitAPI/Tests/WebKit2Gtk/TestContextMenu.cpp: Removed.
- TestWebKitAPI/Tests/WebKit2Gtk/TestDOMClientRect.cpp: Removed.
- TestWebKitAPI/Tests/WebKit2Gtk/TestDOMDOMWindow.cpp: Removed.
- TestWebKitAPI/Tests/WebKit2Gtk/TestDOMNode.cpp: Removed.
- TestWebKitAPI/Tests/WebKit2Gtk/TestDOMNodeFilter.cpp: Removed.
- TestWebKitAPI/Tests/WebKit2Gtk/TestDOMXPathNSResolver.cpp: Removed.
- TestWebKitAPI/Tests/WebKit2Gtk/TestEditor.cpp: Removed.
- TestWebKitAPI/Tests/WebKit2Gtk/TestInspector.cpp: Removed.
- TestWebKitAPI/Tests/WebKit2Gtk/TestInspectorServer.cpp: Removed.
- TestWebKitAPI/Tests/WebKit2Gtk/TestOptionMenu.cpp: Removed.
- TestWebKitAPI/Tests/WebKit2Gtk/TestPrinting.cpp: Removed.
- TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitAccessibility.cpp: Removed.
- TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitVersion.cpp: Removed.
- TestWebKitAPI/Tests/WebKit2Gtk/TestWebViewEditor.cpp: Removed.
- TestWebKitAPI/Tests/WebKit2ObjC: Removed.
- TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsInvalidScheme.mm: Removed.
- TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsInvalidScheme_Bundle.cpp: Removed.
- TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm: Removed.
- TestWebKitAPI/Tests/WebKit2ObjC/PreventImageLoadWithAutoResizing.mm: Removed.
- TestWebKitAPI/Tests/WebKit2ObjC/PreventImageLoadWithAutoResizing_Bundle.cpp: Removed.
- TestWebKitAPI/Tests/WebKit2ObjC/UserContentTest.mm: Removed.
- TestWebKitAPI/Tests/WebKit2ObjC/WKBrowsingContextGroupTest.mm: Removed.
- TestWebKitAPI/Tests/WebKit2ObjC/WKBrowsingContextLoadDelegateTest.mm: Removed.
- TestWebKitAPI/Tests/WebKitCocoa: Copied from TestWebKitAPI/Tests/WebKit2Cocoa.
- TestWebKitAPI/Tests/WebKitGtk: Copied from TestWebKitAPI/Tests/WebKit2Gtk.
- TestWebKitAPI/Tests/WebKitObjC: Copied from TestWebKitAPI/Tests/WebKit2ObjC.
- TestWebKitAPI/glib/PlatformGTK.cmake:
- 12:42 AM Changeset in webkit [221516] by
-
- 5 edits202 moves3 adds in releases/WebKitGTK/webkit-2.18/Tools
Merge r221218 - Rename TestWebKitAPI/Tests/WebKit2 to WebKit following Source directory rename.
Rubber-stamped by Brady Eidson.
- TestWebKitAPI/CMakeLists.txt:
- TestWebKitAPI/PlatformGTK.cmake:
- TestWebKitAPI/PlatformWin.cmake:
- TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
- TestWebKitAPI/Tests/WebKit: Copied from TestWebKitAPI/Tests/WebKit2.
- TestWebKitAPI/Tests/WebKit2: Removed.
- TestWebKitAPI/Tests/WebKit2/18-characters.html: Removed.
- TestWebKitAPI/Tests/WebKit2/AboutBlankLoad.cpp: Removed.
- TestWebKitAPI/Tests/WebKit2/Ahem.ttf: Removed.
- TestWebKitAPI/Tests/WebKit2/CanHandleRequest.cpp: Removed.
- TestWebKitAPI/Tests/WebKit2/CanHandleRequest_Bundle.cpp: Removed.
- TestWebKitAPI/Tests/WebKit2/CloseFromWithinCreatePage.cpp: Removed.
- TestWebKitAPI/Tests/WebKit2/CloseThenTerminate.cpp: Removed.
- TestWebKitAPI/Tests/WebKit2/CookieManager.cpp: Removed.
- TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionBasic.cpp: Removed.
- TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionBasic_Bundle.cpp: Removed.
- TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionNoCache.cpp: Removed.
- TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionNoCache_Bundle.cpp: Removed.
- TestWebKitAPI/Tests/WebKit2/DeferredViewInWindowStateChange.mm: Removed.
- TestWebKitAPI/Tests/WebKit2/DidAssociateFormControls.cpp: Removed.
- TestWebKitAPI/Tests/WebKit2/DidAssociateFormControls_Bundle.cpp: Removed.
- TestWebKitAPI/Tests/WebKit2/DidNotHandleKeyDown.cpp: Removed.
- TestWebKitAPI/Tests/WebKit2/DidRemoveFrameFromHiearchyInPageCache.cpp: Removed.
- TestWebKitAPI/Tests/WebKit2/DidRemoveFrameFromHiearchyInPageCache_Bundle.cpp: Removed.
- TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash.cpp: Removed.
- TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash_Bundle.cpp: Removed.
- TestWebKitAPI/Tests/WebKit2/DownloadDecideDestinationCrash.cpp: Removed.
- TestWebKitAPI/Tests/WebKit2/EnumerateMediaDevices.cpp: Removed.
- TestWebKitAPI/Tests/WebKit2/EnvironmentUtilitiesTest.cpp: Removed.
- TestWebKitAPI/Tests/WebKit2/EphemeralSessionPushStateNoHistoryCallback.cpp: Removed.
- TestWebKitAPI/Tests/WebKit2/EvaluateJavaScript.cpp: Removed.
- TestWebKitAPI/Tests/WebKit2/EventModifiers.cpp: Removed.
- TestWebKitAPI/Tests/WebKit2/FailedLoad.cpp: Removed.
- TestWebKitAPI/Tests/WebKit2/Find.cpp: Removed.
- TestWebKitAPI/Tests/WebKit2/FindMatches.mm: Removed.
- TestWebKitAPI/Tests/WebKit2/ForceRepaint.cpp: Removed.
- TestWebKitAPI/Tests/WebKit2/FrameHandle.cpp: Removed.
- TestWebKitAPI/Tests/WebKit2/FrameMIMETypeHTML.cpp: Removed.
- TestWebKitAPI/Tests/WebKit2/FrameMIMETypePNG.cpp: Removed.
- TestWebKitAPI/Tests/WebKit2/Geolocation.cpp: Removed.
- TestWebKitAPI/Tests/WebKit2/GetInjectedBundleInitializationUserDataCallback.cpp: Removed.
- TestWebKitAPI/Tests/WebKit2/GetInjectedBundleInitializationUserDataCallback_Bundle.cpp: Removed.
- TestWebKitAPI/Tests/WebKit2/GetUserMediaNavigation.mm: Removed.
- TestWebKitAPI/Tests/WebKit2/HitTestResultNodeHandle.cpp: Removed.
- TestWebKitAPI/Tests/WebKit2/HitTestResultNodeHandle_Bundle.cpp: Removed.
- TestWebKitAPI/Tests/WebKit2/InjectedBundleBasic.cpp: Removed.
- TestWebKitAPI/Tests/WebKit2/InjectedBundleBasic_Bundle.cpp: Removed.
- TestWebKitAPI/Tests/WebKit2/InjectedBundleFrameHitTest.cpp: Removed.
- TestWebKitAPI/Tests/WebKit2/InjectedBundleFrameHitTest_Bundle.cpp: Removed.
- TestWebKitAPI/Tests/WebKit2/InjectedBundleInitializationUserDataCallbackWins.cpp: Removed.
- TestWebKitAPI/Tests/WebKit2/InjectedBundleInitializationUserDataCallbackWins_Bundle.cpp: Removed.
- TestWebKitAPI/Tests/WebKit2/InjectedBundleMakeAllShadowRootsOpen.cpp: Removed.
- TestWebKitAPI/Tests/WebKit2/InjectedBundleMakeAllShadowRootsOpen_Bundle.cpp: Removed.
- TestWebKitAPI/Tests/WebKit2/LayoutMilestonesWithAllContentInFrame.cpp: Removed.
- TestWebKitAPI/Tests/WebKit2/LimitTitleSize.cpp: Removed.
- TestWebKitAPI/Tests/WebKit2/LoadAlternateHTMLStringWithNonDirectoryURL.cpp: Removed.
- TestWebKitAPI/Tests/WebKit2/LoadCanceledNoServerRedirectCallback.cpp: Removed.
- TestWebKitAPI/Tests/WebKit2/LoadCanceledNoServerRedirectCallback_Bundle.cpp: Removed.
- TestWebKitAPI/Tests/WebKit2/LoadPageOnCrash.cpp: Removed.
- TestWebKitAPI/Tests/WebKit2/MediaStreamTrackDetached.mm: Removed.
- TestWebKitAPI/Tests/WebKit2/MenuTypesForMouseEvents.cpp: Removed.
- TestWebKitAPI/Tests/WebKit2/ModalAlertsSPI.cpp: Removed.
- TestWebKitAPI/Tests/WebKit2/MouseMoveAfterCrash.cpp: Removed.
- TestWebKitAPI/Tests/WebKit2/MouseMoveAfterCrash_Bundle.cpp: Removed.
- TestWebKitAPI/Tests/WebKit2/NavigationClientDefaultCrypto.cpp: Removed.
- TestWebKitAPI/Tests/WebKit2/NetworkProcessCrashWithPendingConnection.mm: Removed.
- TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayout.cpp: Removed.
- TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFails.cpp: Removed.
- TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFails_Bundle.cpp: Removed.
- TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutForImages.cpp: Removed.
- TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutForImages_Bundle.cpp: Removed.
- TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFrames.cpp: Removed.
- TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFrames_Bundle.cpp: Removed.
- TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayout_Bundle.cpp: Removed.
- TestWebKitAPI/Tests/WebKit2/PageGroup.cpp: Removed.
- TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp: Removed.
- TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp: Removed.
- TestWebKitAPI/Tests/WebKit2/ParentFrame.cpp: Removed.
- TestWebKitAPI/Tests/WebKit2/ParentFrame_Bundle.cpp: Removed.
- TestWebKitAPI/Tests/WebKit2/PasteboardNotifications.mm: Removed.
- TestWebKitAPI/Tests/WebKit2/PasteboardNotifications_Bundle.cpp: Removed.
- TestWebKitAPI/Tests/WebKit2/PendingAPIRequestURL.cpp: Removed.
- TestWebKitAPI/Tests/WebKit2/PreventEmptyUserAgent.cpp: Removed.
- TestWebKitAPI/Tests/WebKit2/PrivateBrowsingPushStateNoHistoryCallback.cpp: Removed.
- TestWebKitAPI/Tests/WebKit2/ProcessDidTerminate.cpp: Removed.
- TestWebKitAPI/Tests/WebKit2/ProvisionalURLAfterWillSendRequestCallback.cpp: Removed.
- TestWebKitAPI/Tests/WebKit2/ProvisionalURLAfterWillSendRequestCallback_Bundle.cpp: Removed.
- TestWebKitAPI/Tests/WebKit2/ReloadPageAfterCrash.cpp: Removed.
- TestWebKitAPI/Tests/WebKit2/ResizeReversePaginatedWebView.cpp: Removed.
- TestWebKitAPI/Tests/WebKit2/ResizeWindowAfterCrash.cpp: Removed.
- TestWebKitAPI/Tests/WebKit2/ResponsivenessTimer.cpp: Removed.
- TestWebKitAPI/Tests/WebKit2/ResponsivenessTimerDoesntFireEarly.cpp: Removed.
- TestWebKitAPI/Tests/WebKit2/ResponsivenessTimerDoesntFireEarly_Bundle.cpp: Removed.
- TestWebKitAPI/Tests/WebKit2/RestoreSessionState.cpp: Removed.
- TestWebKitAPI/Tests/WebKit2/RestoreSessionStateContainingFormData.cpp: Removed.
- TestWebKitAPI/Tests/WebKit2/RestoreSessionStateWithoutNavigation.cpp: Removed.
- TestWebKitAPI/Tests/WebKit2/ScrollPinningBehaviors.cpp: Removed.
- TestWebKitAPI/Tests/WebKit2/ShouldGoToBackForwardListItem.cpp: Removed.
- TestWebKitAPI/Tests/WebKit2/ShouldGoToBackForwardListItem_Bundle.cpp: Removed.
- TestWebKitAPI/Tests/WebKit2/ShouldKeepCurrentBackForwardListItemInList.cpp: Removed.
- TestWebKitAPI/Tests/WebKit2/SpacebarScrolling.cpp: Removed.
- TestWebKitAPI/Tests/WebKit2/StopLoadingDuringDidFailProvisionalLoad.cpp: Removed.
- TestWebKitAPI/Tests/WebKit2/StopLoadingDuringDidFailProvisionalLoad_bundle.cpp: Removed.
- TestWebKitAPI/Tests/WebKit2/TerminateTwice.cpp: Removed.
- TestWebKitAPI/Tests/WebKit2/TextFieldDidBeginAndEndEditing.cpp: Removed.
- TestWebKitAPI/Tests/WebKit2/TextFieldDidBeginAndEndEditing_Bundle.cpp: Removed.
- TestWebKitAPI/Tests/WebKit2/UserMedia.cpp: Removed.
- TestWebKitAPI/Tests/WebKit2/UserMessage.cpp: Removed.
- TestWebKitAPI/Tests/WebKit2/UserMessage_Bundle.cpp: Removed.
- TestWebKitAPI/Tests/WebKit2/ViewportSizeForViewportUnits.mm: Removed.
- TestWebKitAPI/Tests/WebKit2/WKBackForwardList.mm: Removed.
- TestWebKitAPI/Tests/WebKit2/WKBundleFileHandle.cpp: Removed.
- TestWebKitAPI/Tests/WebKit2/WKBundleFileHandle_Bundle.cpp: Removed.
- TestWebKitAPI/Tests/WebKit2/WKImageCreateCGImageCrash.cpp: Removed.
- TestWebKitAPI/Tests/WebKit2/WKPageConfiguration.cpp: Removed.
- TestWebKitAPI/Tests/WebKit2/WKPageCopySessionStateWithFiltering.cpp: Removed.
- TestWebKitAPI/Tests/WebKit2/WKPageGetScaleFactorNotZero.cpp: Removed.
- TestWebKitAPI/Tests/WebKit2/WKPageIsPlayingAudio.cpp: Removed.
- TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp: Removed.
- TestWebKitAPI/Tests/WebKit2/WKRetainPtr.cpp: Removed.
- TestWebKitAPI/Tests/WebKit2/WKString.cpp: Removed.
- TestWebKitAPI/Tests/WebKit2/WKStringJSString.cpp: Removed.
- TestWebKitAPI/Tests/WebKit2/WKThumbnailView.mm: Removed.
- TestWebKitAPI/Tests/WebKit2/WKURL.cpp: Removed.
- TestWebKitAPI/Tests/WebKit2/WebArchive.cpp: Removed.
- TestWebKitAPI/Tests/WebKit2/WebArchive_Bundle.cpp: Removed.
- TestWebKitAPI/Tests/WebKit2/WebCoreStatisticsWithNoWebProcess.cpp: Removed.
- TestWebKitAPI/Tests/WebKit2/WillLoad.cpp: Removed.
- TestWebKitAPI/Tests/WebKit2/WillLoad_Bundle.cpp: Removed.
- TestWebKitAPI/Tests/WebKit2/WillSendSubmitEvent.cpp: Removed.
- TestWebKitAPI/Tests/WebKit2/WillSendSubmitEvent_Bundle.cpp: Removed.
- TestWebKitAPI/Tests/WebKit2/all-content-in-one-iframe.html: Removed.
- TestWebKitAPI/Tests/WebKit2/associate-form-controls.html: Removed.
- TestWebKitAPI/Tests/WebKit2/auto-submitting-form.html: Removed.
- TestWebKitAPI/Tests/WebKit2/autoplay-check-frame.html: Removed.
- TestWebKitAPI/Tests/WebKit2/autoplay-check-in-iframe.html: Removed.
- TestWebKitAPI/Tests/WebKit2/autoplay-check.html: Removed.
- TestWebKitAPI/Tests/WebKit2/autoplay-inherits-gesture-from-document.html: Removed.
- TestWebKitAPI/Tests/WebKit2/autoplay-muted-with-controls.html: Removed.
- TestWebKitAPI/Tests/WebKit2/autoplay-no-audio-check.html: Removed.
- TestWebKitAPI/Tests/WebKit2/autoplay-with-controls.html: Removed.
- TestWebKitAPI/Tests/WebKit2/autoplay-zero-volume-check.html: Removed.
- TestWebKitAPI/Tests/WebKit2/bundle-file.html: Removed.
- TestWebKitAPI/Tests/WebKit2/chinese-character-with-image.html: Removed.
- TestWebKitAPI/Tests/WebKit2/close-from-within-create-page.html: Removed.
- TestWebKitAPI/Tests/WebKit2/closed-shadow-tree-test.html: Removed.
- TestWebKitAPI/Tests/WebKit2/cocoa: Removed.
- TestWebKitAPI/Tests/WebKit2/cocoa/WeakObjCPtr.mm: Removed.
- TestWebKitAPI/Tests/WebKit2/contentBlockerCheck.html: Removed.
- TestWebKitAPI/Tests/WebKit2/custom-protocol-sync-xhr.html: Removed.
- TestWebKitAPI/Tests/WebKit2/encrypted.pdf: Removed.
- TestWebKitAPI/Tests/WebKit2/enumerateMediaDevices.html: Removed.
- TestWebKitAPI/Tests/WebKit2/execCopy.html: Removed.
- TestWebKitAPI/Tests/WebKit2/file-with-anchor.html: Removed.
- TestWebKitAPI/Tests/WebKit2/file-with-mse.html: Removed.
- TestWebKitAPI/Tests/WebKit2/file-with-video.html: Removed.
- TestWebKitAPI/Tests/WebKit2/find.html: Removed.
- TestWebKitAPI/Tests/WebKit2/findRanges.html: Removed.
- TestWebKitAPI/Tests/WebKit2/geolocationGetCurrentPosition.html: Removed.
- TestWebKitAPI/Tests/WebKit2/geolocationGetCurrentPositionWithHighAccuracy.html: Removed.
- TestWebKitAPI/Tests/WebKit2/geolocationWatchPosition.html: Removed.
- TestWebKitAPI/Tests/WebKit2/geolocationWatchPositionWithHighAccuracy.html: Removed.
- TestWebKitAPI/Tests/WebKit2/getUserMedia.html: Removed.
- TestWebKitAPI/Tests/WebKit2/gtk: Removed.
- TestWebKitAPI/Tests/WebKit2/gtk/InputMethodFilter.cpp: Removed.
- TestWebKitAPI/Tests/WebKit2/icon.png: Removed.
- TestWebKitAPI/Tests/WebKit2/input-focus-blur.html: Removed.
- TestWebKitAPI/Tests/WebKit2/js-autoplay-audio.html: Removed.
- TestWebKitAPI/Tests/WebKit2/js-play-with-controls.html: Removed.
- TestWebKitAPI/Tests/WebKit2/large-red-square-image.html: Removed.
- TestWebKitAPI/Tests/WebKit2/link-with-download-attribute-with-slashes.html: Removed.
- TestWebKitAPI/Tests/WebKit2/link-with-download-attribute.html: Removed.
- TestWebKitAPI/Tests/WebKit2/link-with-title.html: Removed.
- TestWebKitAPI/Tests/WebKit2/lots-of-iframes.html: Removed.
- TestWebKitAPI/Tests/WebKit2/lots-of-images.html: Removed.
- TestWebKitAPI/Tests/WebKit2/lots-of-text-vertical-lr.html: Removed.
- TestWebKitAPI/Tests/WebKit2/lots-of-text.html: Removed.
- TestWebKitAPI/Tests/WebKit2/mac: Removed.
- TestWebKitAPI/Tests/WebKit2/mac/AttributedSubstringForProposedRangeWithImage.mm: Removed.
- TestWebKitAPI/Tests/WebKit2/mac/ContextMenuDownload.mm: Removed.
- TestWebKitAPI/Tests/WebKit2/mac/EditorCommands.mm: Removed.
- TestWebKitAPI/Tests/WebKit2/mac/GetBackingScaleFactor.mm: Removed.
- TestWebKitAPI/Tests/WebKit2/mac/GetBackingScaleFactor_Bundle.mm: Removed.
- TestWebKitAPI/Tests/WebKit2/mac/GetPIDAfterAbortedProcessLaunch.cpp: Removed.
- TestWebKitAPI/Tests/WebKit2/mac/InjectedBundleAppleEvent.cpp: Removed.
- TestWebKitAPI/Tests/WebKit2/mac/InjectedBundleAppleEvent_Bundle.cpp: Removed.
- TestWebKitAPI/Tests/WebKit2/mac/RestoreStateAfterTermination.mm: Removed.
- TestWebKitAPI/Tests/WebKit2/many-iframes.html: Removed.
- TestWebKitAPI/Tests/WebKit2/mediastreamtrack-detached.html: Removed.
- TestWebKitAPI/Tests/WebKit2/modal-alerts-in-new-about-blank-window.html: Removed.
- TestWebKitAPI/Tests/WebKit2/mouse-button-listener.html: Removed.
- TestWebKitAPI/Tests/WebKit2/mouse-move-listener.html: Removed.
- TestWebKitAPI/Tests/WebKit2/navigation-client-default-crypto.html: Removed.
- TestWebKitAPI/Tests/WebKit2/no-autoplay-with-controls.html: Removed.
- TestWebKitAPI/Tests/WebKit2/open-and-close-window.html: Removed.
- TestWebKitAPI/Tests/WebKit2/push-state.html: Removed.
- TestWebKitAPI/Tests/WebKit2/set-long-title.html: Removed.
- TestWebKitAPI/Tests/WebKit2/should-open-external-schemes.html: Removed.
- TestWebKitAPI/Tests/WebKit2/simple-accelerated-compositing.html: Removed.
- TestWebKitAPI/Tests/WebKit2/simple-form.html: Removed.
- TestWebKitAPI/Tests/WebKit2/simple-iframe.html: Removed.
- TestWebKitAPI/Tests/WebKit2/simple-tall.html: Removed.
- TestWebKitAPI/Tests/WebKit2/simple.html: Removed.
- TestWebKitAPI/Tests/WebKit2/simple2.html: Removed.
- TestWebKitAPI/Tests/WebKit2/simple3.html: Removed.
- TestWebKitAPI/Tests/WebKit2/spacebar-scrolling.html: Removed.
- TestWebKitAPI/Tests/WebKit2/test-mse.mp4: Removed.
- TestWebKitAPI/Tests/WebKit2/test-without-audio-track.mp4: Removed.
- TestWebKitAPI/Tests/WebKit2/test.mp4: Removed.
- TestWebKitAPI/Tests/WebKit2/test.pdf: Removed.
- TestWebKitAPI/Tests/WebKit2/webfont.html: Removed.
- 12:38 AM Changeset in webkit [221515] by
-
- 2 edits11 moves3 adds in releases/WebKitGTK/webkit-2.18/Tools
Merge r221217 - Rename TestWebKitAPI/Tests/WebKit to WebKitLegacy following Source directory rename.
Rubber-stamped by Brady Eidson.
- TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
- TestWebKitAPI/Tests/WebKit: Removed.
- TestWebKitAPI/Tests/WebKit/ios: Removed.
- TestWebKitAPI/Tests/WebKit/ios/AudioSessionCategoryIOS.mm: Removed.
- TestWebKitAPI/Tests/WebKit/ios/SnapshotViaRenderInContext.mm: Removed.
- TestWebKitAPI/Tests/WebKit/ios/audio-only.html: Removed.
- TestWebKitAPI/Tests/WebKit/ios/video-with-audio.html: Removed.
- TestWebKitAPI/Tests/WebKit/ios/video-with-audio.mp4: Removed.
- TestWebKitAPI/Tests/WebKit/ios/video-with-muted-audio-and-webaudio.html: Removed.
- TestWebKitAPI/Tests/WebKit/ios/video-with-muted-audio.html: Removed.
- TestWebKitAPI/Tests/WebKit/ios/video-without-audio.html: Removed.
- TestWebKitAPI/Tests/WebKit/ios/video-without-audio.mp4: Removed.
- TestWebKitAPI/Tests/WebKit/win: Removed.
- TestWebKitAPI/Tests/WebKit/win/ScaleWebView.cpp: Removed.
- TestWebKitAPI/Tests/WebKit/win/WebViewDestruction.cpp: Removed.
- TestWebKitAPI/Tests/WebKitLegacy: Copied from TestWebKitAPI/Tests/WebKit.
- 12:05 AM Changeset in webkit [221514] by
-
- 5 edits in trunk/Source/WebKit
[GTK][Wayland] Opening FedoraProject's pastebin chews CPU
https://bugs.webkit.org/show_bug.cgi?id=175942
Reviewed by Žan Doberšek.
This regressed when we introduced the display refresh monitor. The monitor schedules updates immediately,
because we removed the option to not do frame sync in X11 to let swapBuffers do the throttling, but that's
not happening in Wayland because the nested compositor is dispatching frame callbacks on surface commit.
We need to ensure that frame callbacks are dispatched on every monitor refresh, because swapBuffers waits for
frame callbacks to be queued on display.
- UIProcess/gtk/WaylandCompositor.cpp:
(WebKit::WaylandCompositor::Surface::~Surface): Destroy pending frame callbacks too.
(WebKit::WaylandCompositor::Surface::setWebPage): Add a tick callback to the web view widget to flush all
committed frame callbacks on every frame update.
(WebKit::WaylandCompositor::Surface::requestFrame): Add the callbacks to m_pendingFrameCallbackList.
(WebKit::WaylandCompositor::Surface::flushFrameCallbacks): Dispatch all committed frame callabcks.
(WebKit::WaylandCompositor::Surface::flushPendingFrameCallbacks): Dispatch all pending frame callbacks.
(WebKit::WaylandCompositor::Surface::commit): Do not dispatch frame callbacks here, move them to the list of
committed frame callbacks that will be dispatched on the next frame clock update.
- UIProcess/gtk/WaylandCompositor.h:
(WebKit::WaylandCompositor::Surface::setWebPage): Moved to the cpp.
- WebProcess/WebPage/gtk/AcceleratedSurfaceWayland.cpp:
(WebKit::AcceleratedSurfaceWayland::AcceleratedSurfaceWayland): Move surface initialization and destruction to
the compositing thread.
(WebKit::AcceleratedSurfaceWayland::initialize):
(WebKit::AcceleratedSurfaceWayland::finalize):
(WebKit::AcceleratedSurfaceWayland::~AcceleratedSurfaceWayland): Deleted.
- WebProcess/WebPage/gtk/AcceleratedSurfaceWayland.h:
