Timeline

Sep 6, 2017:

11:20 PM Changeset in webkit [221719] by Carlos Garcia Campos

• 2 edits in trunk/Source/WebCore

Unreviewed. Temporary disable the changes introduced in r221670 for WPE.

It caused a lot of test failures. Once WPE upgrades to Freetype 2.8 and removes the 2.4.11 patch, we can enable
it again.

• platform/graphics/freetype/SimpleFontDataFreeType.cpp:

(WebCore::Font::platformInit):

10:58 PM Changeset in webkit [221718] by zandobersek@gmail.com

• 4 edits in trunk/Source/WebCore

[GStreamer] Implement MediaPlayerPrivateGStreamerMSE::attempToDecryptWithInstance()
​https://bugs.webkit.org/show_bug.cgi?id=176445

Reviewed by Xabier Rodriguez-Calvar.

Implement MediaPlayerPrivateGStreamerMSE::attempToDecryptWithInstance(), also
adding support for dispatching ClearKey keys into the append pipelines.

CDMInstanceClearKey::Key is added, containing key ID and value buffers as well
as the key status value. Vector of keys for a specific CDMInstance is
accessible through the CDMInstanceClearKey::keys() getter.

In MediaPlayerPrivateGStreamerMSE, that Vector is retrieved and then iterated
over, constructing corresponding key ID and key value lists that contain
GstBuffer objects into which each key ID and value data is copied. Both lists
are then set on the 'drm-cipher-clearkey' structure before it's dispatched
against each AppendPipeline object.

• platform/encryptedmedia/clearkey/CDMClearKey.h:
• platform/graphics/gstreamer/mse/MediaPlayerPrivateGStreamerMSE.cpp:

(WebCore::MediaPlayerPrivateGStreamerMSE::attemptToDecryptWithInstance):

• platform/graphics/gstreamer/mse/MediaPlayerPrivateGStreamerMSE.h:

9:23 PM Changeset in webkit [221717] by aakash_jain@apple.com

• 5 edits in trunk/Websites/perf.webkit.org

Add initSyncers method in BuildbotTriggerable
​https://bugs.webkit.org/show_bug.cgi?id=176125

Reviewed by Ryosuke Niwa.

• tools/sync-buildbot.js:

(syncLoop): Use initSyncers() which returns a promise. Modified to handle the promise.

• tools/js/buildbot-triggerable.js:

(BuildbotTriggerable): Invokes initSyncers() appropriately.
(BuildbotTriggerable.prototype.initSyncers): Returns a promise which initialize all the syncers.

• server-tests/tools-buildbot-triggerable-tests.js: Updated tests to handle initSyncers().
• server-tests/tools-sync-buildbot-integration-tests.js: Ditto.

9:05 PM Changeset in webkit [221716] by commit-queue@webkit.org

• 3 edits
  7 adds in trunk

Fetch's Response.statusText is unexpectedly the full http status line for HTTP/2 responses
​https://bugs.webkit.org/show_bug.cgi?id=176479

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2017-09-06
Reviewed by Alexey Proskuryakov.

Source/WebCore:

Test: http/wpt/fetch/response-status-text.html

HTTP/2 doesn't include a status reason phrase. So the "status line"
ends up just being the version and status code. Fallback to the empty
string instead of the full line.

• platform/network/HTTPParsers.cpp:

(WebCore::extractReasonPhraseFromHTTPStatusLine):

LayoutTests:

• http/wpt/fetch/resources/status-garbage.asis: Added.
• http/wpt/fetch/resources/status-normal.txt: Added.
• http/wpt/fetch/resources/status-with-message.asis: Added.
• http/wpt/fetch/resources/status-without-message.asis: Added.

Various text HTTP responses with different status lines.

• http/wpt/fetch/response-status-text-expected.txt: Added.
• http/wpt/fetch/response-status-text.html: Added.

Test the Fetch Response's status / statusText for different HTTP status lines.
The status without a message is similiar to HTTP/2 because HTTP/2 only
has a :status pseudo-header and lacks a reason phrase.

9:02 PM Changeset in webkit [221715] by commit-queue@webkit.org

• 1 edit
  1 delete in trunk/Tools

Remove new-run-webkit-httpd as it appears to be old
​https://bugs.webkit.org/show_bug.cgi?id=176493

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2017-09-06
Reviewed by Alexey Proskuryakov.

• Scripts/new-run-webkit-httpd: Removed.

8:42 PM Changeset in webkit [221714] by achristensen@apple.com

• 6 edits in trunk

Add WKUIDelegatePrivate equivalent of WKPageUIClient's pageDidScroll
​https://bugs.webkit.org/show_bug.cgi?id=176482
<rdar://problem/29270035>

Reviewed by Tim Horton.
Source/WebKit:

Covered by a new API test!

• UIProcess/API/Cocoa/WKUIDelegatePrivate.h:
• UIProcess/Cocoa/UIDelegate.h:
• UIProcess/Cocoa/UIDelegate.mm:

(WebKit::UIDelegate::setDelegate):
(WebKit::UIDelegate::UIClient::pageDidScroll):

Tools:

• TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:

(-[DidScrollDelegate _webViewDidScroll:]):
(TEST):

8:29 PM Changeset in webkit [221713] by Matt Baker

• 3 edits in trunk/Source/WebInspectorUI

Web Inspector: Relax the maximum sidebar width
​https://bugs.webkit.org/show_bug.cgi?id=175808
<rdar://problem/34005339>

Reviewed by Devin Rousso.

This patch introduces a constant, minimumContentBrowserWidth, which
constrains the maximum width of either sidebar:

maxSidebarWidth = window.innerWidth - minimumContentBrowserWidth - otherSidebarWidth

A value of 100px for minimumContentBrowserWidth leaves enough space for
three NavigationItems at their minimum width (32px), with a few pixels
left over for good measure. For most tabs this will ensure that the buttons
for showing the sidebars will be visible, along with an addition button.

• UserInterface/Base/Main.js:
• UserInterface/Views/Sidebar.js:

(WI.Sidebar.prototype.get maximumWidth):

7:32 PM Changeset in webkit [221712] by eric.carlson@apple.com

• 11 edits in trunk

Require LoggingHelper overrides to provide identifier
​https://bugs.webkit.org/show_bug.cgi?id=176477

Reviewed by Jer Noble.

Source/WebCore:

No new tests, updated API test.

• html/HTMLMediaElement.cpp:

(WebCore::nextLogIdentifier): New.
(WebCore::HTMLMediaElement::HTMLMediaElement): Initialize m_logIdendifier. LOGTHIS -> LOGIDENTIFIER.
(WebCore::HTMLMediaElement::~HTMLMediaElement): Ditto.

• html/HTMLMediaElement.h:

Source/WebCore/PAL:

• pal/Logger.h:

(PAL::Logger::LogSiteIdentifier::LogSiteIdentifier):
(PAL::LogArgument<Logger::LogSiteIdentifier>::toString):
(PAL::Logger::notice const): Deleted.
(PAL::Logger::MethodAndPointer::MethodAndPointer): Deleted.
(PAL::LogArgument<Logger::MethodAndPointer>::toString): Deleted.

• pal/LoggerHelper.h:

Source/WTF:

• wtf/Assertions.cpp: No more WTFLogLevelNotice.
• wtf/Assertions.h: Ditto.

Tools:

• TestWebKitAPI/Tests/WebCore/Logging.cpp:

(TestWebKitAPI::TEST_F):

5:57 PM Changeset in webkit [221711] by mark.lam@apple.com

• 3 edits
  1 add in trunk

constructGenericTypedArrayViewWithArguments() is missing an exception check.
​https://bugs.webkit.org/show_bug.cgi?id=176485
<rdar://problem/33898874>

Reviewed by Keith Miller.

JSTests:

• stress/regress-176485.js: Added.

Source/JavaScriptCore:

• runtime/JSGenericTypedArrayViewConstructorInlines.h:

(JSC::constructGenericTypedArrayViewWithArguments):

5:03 PM Changeset in webkit [221710] by commit-queue@webkit.org

• 24 edits
  2 adds in trunk

NetworkProcess Cache and Caches should be cleared when the last related WebProcess Cache or CacheStorage is destroyed
​https://bugs.webkit.org/show_bug.cgi?id=176249

Patch by Youenn Fablet <​youenn@apple.com> on 2017-09-06
Reviewed by Alex Christensen.

Source/WebCore:

Test: http/tests/cache-storage/cache-representation.https.html

Each Cache construction/destruction is notified to the CacheStorageConnection
so that the WebKit2 engine can handle memory management accordingly.

Adding an internal API to grab the representation of an engine at any time.

• Modules/cache/Cache.cpp:

(WebCore::Cache::Cache):
(WebCore::Cache::~Cache):

• Modules/cache/CacheStorageConnection.h:

(WebCore::CacheStorageConnection::reference):
(WebCore::CacheStorageConnection::dereference):

• Modules/cache/WorkerCacheStorageConnection.cpp:

(WebCore::WorkerCacheStorageConnection::reference):
(WebCore::WorkerCacheStorageConnection::dereference):

• Modules/cache/WorkerCacheStorageConnection.h:
• testing/Internals.cpp:

(WebCore::Internals::cacheStorageEngineRepresentation):

• testing/Internals.h:
• testing/Internals.idl:

Source/WebKit:

CacheStorageEngineConnection will store the number of Caches references for its related WebProcess.
For a new reference, CacheStorageEngineConnection will notify its engine to lock the related Cache.
When the last reference is gone, CacheStorageEngineConnection will ask the engine to release the lock.

CacheStorageEngine will keep locks as a counter for each Cache object.
When the counter goes to zero, the engine asks the Cache to dispose itself.
Disposal is done by its parent Caches as only Caches knows whether the Cache is persistent or has been removed.

The Caches will remove the Cache from memory.
For removed caches, all information will be lost.
For caches that are not removed, they will keep their identifiers but all in-memory record information will be discarded.
If there is a need to reopen the Cache, it will need to read its information from the filesystem.
If the Caches has no longer any active Cache object, it will ask the engine to release itself.

WebProcess crashing is handled correctly as the CacheStorageEngineConnection will release its locks at destruction
time of the connection to the web process.

Adding the possiblity to grab an engine representation for test purposes.

• NetworkProcess/cache/CacheStorageEngine.cpp:

(WebKit::CacheStorage::Engine::readCachesFromDisk):
(WebKit::CacheStorage::Engine::removeCaches):
(WebKit::CacheStorage::Engine::lock):
(WebKit::CacheStorage::Engine::unlock):

• NetworkProcess/cache/CacheStorageEngine.h:
• NetworkProcess/cache/CacheStorageEngineCache.cpp:

(WebKit::CacheStorage::Cache::Cache):
(WebKit::CacheStorage::Cache::dispose):
(WebKit::CacheStorage::Cache::clearMemoryRepresentation):

• NetworkProcess/cache/CacheStorageEngineCache.h:

(WebKit::CacheStorage::Cache::isActive const):

• NetworkProcess/cache/CacheStorageEngineCaches.cpp:

(WebKit::CacheStorage::Caches::Caches):
(WebKit::CacheStorage::Caches::open):
(WebKit::CacheStorage::Caches::dispose):
(WebKit::CacheStorage::Caches::readCachesFromDisk):
(WebKit::CacheStorage::Caches::clearMemoryRepresentation):

• NetworkProcess/cache/CacheStorageEngineCaches.h:

(WebKit::CacheStorage::Caches::create):

• NetworkProcess/cache/CacheStorageEngineConnection.cpp:

(WebKit::CacheStorageEngineConnection::~CacheStorageEngineConnection):
(WebKit::CacheStorageEngineConnection::reference):
(WebKit::CacheStorageEngineConnection::dereference):

• NetworkProcess/cache/CacheStorageEngineConnection.h:
• NetworkProcess/cache/CacheStorageEngineConnection.messages.in:
• WebProcess/Cache/WebCacheStorageConnection.cpp:

(WebKit::WebCacheStorageConnection::reference):
(WebKit::WebCacheStorageConnection::dereference):

• WebProcess/Cache/WebCacheStorageConnection.h:

LayoutTests:

• http/tests/cache-storage/cache-representation.https-expected.txt: Added.
• http/tests/cache-storage/cache-representation.https.html: Added.
• http/tests/cache-storage/resources/cache-persistency-iframe.html:

5:02 PM Changeset in webkit [221709] by mrajca@apple.com

• 2 edits in trunk/Source/WebCore

Support new autoplay quirk for arbitrary user gestures.
​https://bugs.webkit.org/show_bug.cgi?id=176402

Reviewed by Eric Carlson.

This quirk allows any user gesture to allow autoplay in a document.

No new tests because this specifically targets one host.

• html/MediaElementSession.cpp:

(WebCore::needsArbitraryUserGestureAutoplayQuirk):
(WebCore::MediaElementSession::playbackPermitted const):

4:33 PM Changeset in webkit [221708] by Matt Lewis

• 3 edits in trunk/LayoutTests

Marked media/video-main-content-allow-then-scroll.html as flaky on macOS and failing on iOS.
​https://bugs.webkit.org/show_bug.cgi?id=161491

Unreviewed test gardening.

• platform/ios-wk2/TestExpectations:
• platform/mac/TestExpectations:

4:27 PM Changeset in webkit [221707] by achristensen@apple.com

• 11 edits in trunk

Add WKUIDelegatePrivate equivalent of WKPageUIClient's pinnedStateDidChange
​https://bugs.webkit.org/show_bug.cgi?id=176474
<rdar://problem/29270035>

Reviewed by Tim Horton.

Source/WebKit:

Rather than telling the UIClient that the pinned state changed and having the application check 4 bools
like we do with WKPage, I made a KVO property on the WKWebView. I introduce _WKRectEdge for this purpose,
which is like UIRectEdge but unfortunately NSRectEdge and CGRectEdge cannot be used as NS_OPTIONS/flags.
This same structure is used for rubber band state.

Covered by a new API test.

• UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _pinnedState]):
(-[WKWebView _rubberBandState]):
(-[WKWebView _setRubberBandState:]):

• UIProcess/API/Cocoa/WKWebViewPrivate.h:
• UIProcess/Cocoa/WebViewImpl.h:
• UIProcess/Cocoa/WebViewImpl.mm:

(WebKit::WebViewImpl::pinnedState):
(WebKit::WebViewImpl::rubberBandState):
(WebKit::WebViewImpl::setRubberBandState):

• UIProcess/PageClient.h:

(WebKit::PageClient::pinnedStateWillChange):
(WebKit::PageClient::pinnedStateDidChange):

• UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::didChangeScrollOffsetPinningForMainFrame):

• UIProcess/mac/PageClientImplMac.h:
• UIProcess/mac/PageClientImplMac.mm:

(WebKit::PageClientImpl::pinnedStateWillChange):
(WebKit::PageClientImpl::pinnedStateDidChange):

Tools:

• TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:

(-[PinnedStateObserver observeValueForKeyPath:ofObject:change:context:]):
(TEST):

3:01 PM Changeset in webkit [221706] by mitz@apple.com

• 9 copies
  1 add in releases/Apple/Safari Technology Preview 39

Added a tag for Safari Technology Preview release 39.

2:37 PM Changeset in webkit [221705] by commit-queue@webkit.org

• 5 edits in trunk/Source/WebKit

Introduce asynchronous opening of CacheStorageEngine cache
​https://bugs.webkit.org/show_bug.cgi?id=176425

Patch by Youenn Fablet <​youenn@apple.com> on 2017-09-06
Reviewed by Alex Christensen.

Introducing Cache::open to allow reading from the filesystem to fill the Cache.
This is called by Caches when engine requests to open an existing Cache.

• NetworkProcess/cache/CacheStorageEngineCache.cpp:

(WebKit::CacheStorage::Cache::Cache):
(WebKit::CacheStorage::Cache::open):
(WebKit::CacheStorage::Cache::finishOpening):
(WebKit::CacheStorage::Cache::readRecordsList):

• NetworkProcess/cache/CacheStorageEngineCache.h:
• NetworkProcess/cache/CacheStorageEngineCaches.cpp:

(WebKit::CacheStorage::Caches::find):
(WebKit::CacheStorage::Caches::open):
(WebKit::CacheStorage::Caches::remove):
(WebKit::CacheStorage::Caches::readCachesFromDisk):
(WebKit::CacheStorage::Caches::find const): Deleted.

• NetworkProcess/cache/CacheStorageEngineCaches.h:

2:25 PM Changeset in webkit [221704] by commit-queue@webkit.org

• 24 edits
  5 adds in trunk

Support caching of Response with a ReadableStream body
​https://bugs.webkit.org/show_bug.cgi?id=176462

Patch by Youenn Fablet <​youenn@apple.com> on 2017-09-06
Reviewed by Alex Christensen.

LayoutTests/imported/w3c:

• web-platform-tests/service-workers/cache-storage/worker/cache-put.https-expected.txt:

Source/WebCore:

Tests: http/wpt/cache-storage/cache-put-stream.https.any.html

http/wpt/cache-storage/cache-put-stream.https.any.worker.html

Making FetchResponse use more of ReadableStream:

• Cloning of its body is done through ReadableStream.
• Computation of disturbed and locked is done through ReadableStream.
• Storing of the ReadableStream body given at constructor time is done in FetchBody for FetchResponse.

This allows making FetchResponse closer to FetchRequest.
This also allows to correctly compute disturbed and locked in clone cases.

Adding the ability to consume a Response ReadableStream body as a SharedBuffer.
Using that ability in DOMCache.

• Modules/cache/DOMCache.cpp:

(WebCore::DOMCache::putWithResponseData):
(WebCore::DOMCache::put):

• Modules/cache/DOMCache.h:
• Modules/fetch/FetchBody.h:

(WebCore::FetchBody::readableStream const):

• Modules/fetch/FetchBodyConsumer.cpp:

(WebCore::FetchBodyConsumer::extract):

• Modules/fetch/FetchBodyConsumer.h:
• Modules/fetch/FetchBodyOwner.cpp:

(WebCore::FetchBodyOwner::isDisturbed const):
(WebCore::FetchBodyOwner::isDisturbedOrLocked const):

• Modules/fetch/FetchBodyOwner.h:

(WebCore::FetchBodyOwner::hasReadableStreamBody const):

• Modules/fetch/FetchBodySource.cpp:
• Modules/fetch/FetchBodySource.h:
• Modules/fetch/FetchResponse.cpp:

(WebCore::FetchResponse::consumeBodyFromReadableStream):
(WebCore::FetchResponse::consumeBodyWhenLoaded):
(WebCore::FetchResponse::consumeBodyAsStream):

• Modules/fetch/FetchResponse.h:
• Modules/fetch/FetchResponse.idl:
• Modules/fetch/FetchResponse.js:

(initializeFetchResponse):
(clone):

• bindings/js/ReadableStream.cpp:

(WebCore::callFunction):
(WebCore::ReadableStream::pipeTo):
(WebCore::ReadableStream::tee):
(WebCore::checkReadableStream):
(WebCore::ReadableStream::isLocked const):
(WebCore::ReadableStream::isDisturbed const):
(WebCore::ReadableStream::isDisturbed):

• bindings/js/ReadableStream.h:
• bindings/js/ReadableStreamDefaultController.cpp:
• bindings/js/ReadableStreamDefaultController.h:
• bindings/js/WebCoreBuiltinNames.h:
• testing/Internals.cpp:

(WebCore::Internals::isReadableStreamDisturbed):

LayoutTests:

• TestExpectations: Removing flakiness expectation for cache-put tests.
• http/wpt/cache-storage/cache-put-stream.https.any-expected.txt: Added.
• http/wpt/cache-storage/cache-put-stream.https.any.html: Added.
• http/wpt/cache-storage/cache-put-stream.https.any.js: Added.

(cache_test.):
(cache_test):
(string_appeared_here.cache_test.return.reader.read.then.):
(string_appeared_here.cache_test):

• http/wpt/cache-storage/cache-put-stream.https.any.worker-expected.txt: Added.
• http/wpt/cache-storage/cache-put-stream.https.any.worker.html: Added.

2:04 PM Changeset in webkit [221703] by sbarati@apple.com

• 7 edits in trunk/Source/JavaScriptCore

Air should have a Vector of prologue generators instead of a HashMap representing an optional prologue generator
​https://bugs.webkit.org/show_bug.cgi?id=176346

Reviewed by Mark Lam.

• b3/B3Procedure.cpp:

(JSC::B3::Procedure::Procedure):
(JSC::B3::Procedure::setNumEntrypoints):

• b3/B3Procedure.h:

(JSC::B3::Procedure::setNumEntrypoints): Deleted.

• b3/air/AirCode.cpp:

(JSC::B3::Air::defaultPrologueGenerator):
(JSC::B3::Air::Code::Code):
(JSC::B3::Air::Code::setNumEntrypoints):

• b3/air/AirCode.h:

(JSC::B3::Air::Code::setPrologueForEntrypoint):
(JSC::B3::Air::Code::prologueGeneratorForEntrypoint):
(JSC::B3::Air::Code::setEntrypoints):
(JSC::B3::Air::Code::setEntrypointLabels):

• b3/air/AirGenerate.cpp:

(JSC::B3::Air::generate):

• ftl/FTLLowerDFGToB3.cpp:

(JSC::FTL::DFG::LowerDFGToB3::lower):

1:54 PM Changeset in webkit [221702] by achristensen@apple.com

• 11 edits in trunk

Unreviewed, rolling out r221694.

broke build

Reverted changeset:

"Add WKUIDelegatePrivate equivalent of WKPageUIClient's
pinnedStateDidChange"
​https://bugs.webkit.org/show_bug.cgi?id=176474
​http://trac.webkit.org/changeset/221694

1:51 PM Changeset in webkit [221701] by sbarati@apple.com

• 2 edits in trunk/Source/JavaScriptCore

ASSERTION FAILED: op() == CheckStructure in Source/JavaScriptCore/dfg/DFGNode.h(443)
​https://bugs.webkit.org/show_bug.cgi?id=176470

Reviewed by Mark Lam.

Update Node::convertToCheckStructureImmediate's assertion to allow
the node to either be a CheckStructure or CheckStructureOrEmpty.

• dfg/DFGNode.h:

(JSC::DFG::Node::convertToCheckStructureImmediate):

1:48 PM Changeset in webkit [221700] by pvollan@apple.com

• 2 edits in trunk/Tools

[Win] test-webkitpy test timeout_context_unittest is failing.
​https://bugs.webkit.org/show_bug.cgi?id=176471

Reviewed by Brent Fulgham.

This assert failure is possibly caused by different time resolution on
various platforms.

• Scripts/webkitpy/common/timeout_context_unittest.py:

(TimeoutContextTests.test_timeout_data):

1:40 PM Changeset in webkit [221699] by Ryan Haddad

• 24 edits
  1 delete in trunk

Unreviewed, rolling out r221461.

The LayoutTest added with this change crashes under
GuardMalloc.

Reverted changeset:

"Add (entirely incorrect) fetching of ServiceWorker scripts."
​https://bugs.webkit.org/show_bug.cgi?id=176179
​http://trac.webkit.org/changeset/221461

1:26 PM Changeset in webkit [221698] by achristensen@apple.com

• 5 edits in trunk/Source/WebKit

Add modern decoders for POD types
​https://bugs.webkit.org/show_bug.cgi?id=176456

Reviewed by Geoffrey Garen.

• Platform/IPC/Decoder.cpp:

(IPC::Decoder::getOptional):
(IPC::Decoder::operator>>):

• Platform/IPC/Decoder.h:
• Shared/NavigationActionData.cpp:

(WebKit::NavigationActionData::decode):

• Shared/NavigationActionData.h:

1:24 PM Changeset in webkit [221697] by matthew_hanson@apple.com

• 7 edits in branches/safari-604-branch/Source

Versioning.

1:21 PM Changeset in webkit [221696] by aakash_jain@apple.com

• 2 edits in trunk/Tools

status-bubbles turn orange after checking relevance of patch
​https://bugs.webkit.org/show_bug.cgi?id=176457

Reviewed by Alexey Proskuryakov.

• QueueStatusServer/handlers/statusbubble.py: Added "Checked relevance of patch" as a progress_statuses.

1:16 PM Changeset in webkit [221695] by webkit@devinrousso.com

• 16 edits
  1 add in trunk

Web Inspector: Support overloaded CanvasRenderingContext2D actions with identical parameter counts
​https://bugs.webkit.org/show_bug.cgi?id=176178
<rdar://problem/34192229>

Reviewed by Matt Baker.

Source/WebCore:

Update existing tests.

• WebCore.xcodeproj/project.pbxproj:

• inspector/InspectorCanvas.cpp:

(WebCore::buildArrayForVector):
(WebCore::InspectorCanvas::buildAction):
Add another array to each action that contains a swizzle type for each parameter. This is
used by the frontend to determine how to regenerate the value from what is given in the JSON.

• inspector/RecordingSwizzleTypes.h: Added.

Contains a value-specified enum of types that translate into int values, which are mirrored
by an object in the frontend, that indicate the type of each parameter. This enum matches
the values in WI.Recording.Swizzle.

Source/WebInspectorUI:

• UserInterface/Models/Recording.js:

(WI.Recording.displayNameForSwizzleType):
(WI.Recording.prototype.swizzle):
Replace WI.Recording.Swizzle with an object of swizzle type keys to int values. This object
matches the values in WebCore::RecordingSwizzleTypes.h.

• UserInterface/Models/RecordingAction.js:

(WI.RecordingAction):
(WI.RecordingAction.fromPayload):
(WI.RecordingAction.prototype.get swizzleTypes):
(WI.RecordingAction.prototype.swizzle):
(WI.RecordingAction.prototype.toJSON):
(WI.RecordingAction.prototype.parameterSwizzleTypeForTypeAtIndex): Deleted.
Replace WI.RecordingAction._parameterSwizzleTypeForTypeAtIndex with an array of parameter
types sent in the payload. This gives more control over the swizzling to the JSON, but also
simplifies the way we regenerate the data in the frontend.

• UserInterface/Views/RecordingActionTreeElement.js:

(WI.RecordingActionTreeElement._generateDOM):

• UserInterface/Views/RecordingContentView.js:

(WI.RecordingContentView.prototype._generateContentCanvas2D):
(WI.RecordingContentView.prototype._applyAction):

• UserInterface/Views/RecordingNavigationSidebarPanel.css:

(.sidebar > .panel.navigation.recording > .content .action.invalid:not(.selected, .initial-state) > .titles :matches(.name, .parameter.invalid)):
(.sidebar > .panel.navigation.recording > .content .action.invalid:not(.selected, .initial-state) > .titles .name,): Deleted.

LayoutTests:

• inspector/canvas/recording-2d-expected.txt:
• inspector/canvas/recording-webgl-expected.txt:
• inspector/canvas/recording-webgl-snapshots-expected.txt:
• inspector/model/recording-expected.txt:
• inspector/model/recording.html:

1:15 PM Changeset in webkit [221694] by achristensen@apple.com

• 11 edits in trunk

Add WKUIDelegatePrivate equivalent of WKPageUIClient's pinnedStateDidChange
​https://bugs.webkit.org/show_bug.cgi?id=176474
<rdar://problem/29270035>

Reviewed by Tim Horton.

Source/WebKit:

Rather than telling the UIClient that the pinned state changed and having the application check 4 bools
like we do with WKPage, I made a KVO property on the WKWebView. I introduce _WKRectEdge for this purpose,
which is like UIRectEdge but unfortunately NSRectEdge and CGRectEdge cannot be used as NS_OPTIONS/flags.
This same structure is used for rubber band state.

Covered by a new API test.

• UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _pinnedState]):
(-[WKWebView _rubberBandState]):
(-[WKWebView _setRubberBandState:]):

• UIProcess/API/Cocoa/WKWebViewPrivate.h:
• UIProcess/Cocoa/WebViewImpl.h:
• UIProcess/Cocoa/WebViewImpl.mm:

(WebKit::WebViewImpl::pinnedState):
(WebKit::WebViewImpl::rubberBandState):
(WebKit::WebViewImpl::setRubberBandState):

• UIProcess/PageClient.h:

(WebKit::PageClient::pinnedStateWillChange):
(WebKit::PageClient::pinnedStateDidChange):

• UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::didChangeScrollOffsetPinningForMainFrame):

• UIProcess/mac/PageClientImplMac.h:
• UIProcess/mac/PageClientImplMac.mm:

(WebKit::PageClientImpl::pinnedStateWillChange):
(WebKit::PageClientImpl::pinnedStateDidChange):

Tools:

• TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:

(-[PinnedStateObserver observeValueForKeyPath:ofObject:change:context:]):
(TEST):

1:09 PM Changeset in webkit [221693] by pvollan@apple.com

• 8 edits
  1 move in trunk/Source

[Win] WebCore failed to build, InbandTextTrackPrivateAVF: base class undefined.
​https://bugs.webkit.org/show_bug.cgi?id=176431

Reviewed by Alex Christensen.

Source/WebCore:

AVFoundation header detection should be done in WebCore because of build dependencies.

No new tests, covered by existing tests.

• AVFoundationSupport.py: Copied from Source/WTF/AVFoundationSupport.py.
• PlatformWin.cmake:
• config.h:
• platform/graphics/ca/win/PlatformCALayerWin.cpp:
• platform/graphics/ca/win/PlatformCALayerWinInternal.cpp:

Source/WTF:

AVFoundation header detection should be done in WebCore because of build dependencies.

• AVFoundationSupport.py: Removed.
• wtf/Platform.h:
• wtf/PlatformWin.cmake:

1:03 PM Changeset in webkit [221692] by fpizlo@apple.com

• 5 edits in trunk/Tools

WSL: Inliner doesn't allow double-negation
​https://bugs.webkit.org/show_bug.cgi?id=176440

Reviewed by Mylex Maxfield.

The problem was that we were visiting the operands to calls while inside doVisit. This is too strict
since it rejects nested calls like foo(foo(x)). The solution is to visit the operands to calls before
entering doVisit.

This also fixes some other issues in the parser that made the Inliner's error really strange.

• WebGPUShadingLanguageRI/Func.js:

(Func):

• WebGPUShadingLanguageRI/Inliner.js:

(Inliner.prototype.visitCallExpression):
(Inliner):

• WebGPUShadingLanguageRI/Parse.js:

(parseOperatorFuncDefValues):
(parseNonOperatorFuncDefValues):
(parseGenericFuncDefValues):
(parseFuncDecl):

• WebGPUShadingLanguageRI/Test.js:
• WebGPUShadingLanguageRI/VisitingSet.js:

(VisitingSet.prototype.doVisit):
(VisitingSet):

12:46 PM Changeset in webkit [221691] by commit-queue@webkit.org

• 6 edits in trunk/Source/WebInspectorUI

Web Inspector: ⌘E and ⌘G do not work in main content area when quick console drawer is open
​https://bugs.webkit.org/show_bug.cgi?id=176433

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2017-09-06
Reviewed by Brian Burg.

Make the ⌘E and ⌘G keyboard shortcuts behave more like the global ⌘K clear shortcut.
Instead of keeping them inside of FindBanner, and enabling/disabling them when they
make sense to apply, we make a single global instance of the keyboard shortcut and
apply it to whatever content view / content browser is active. This avoids conflicts
in situations where there are two ContentViews that are visible and each can handle
the keyboard shortcut.

• UserInterface/Base/Main.js:

(WI.contentLoaded):
New keyboard shortcuts.

(WI._populateFind):
(WI._findNext):
(WI._findPrevious):
Perform the shortcut on the active content view or content browser.

• UserInterface/Views/ContentBrowser.js:

(WI.ContentBrowser.prototype.shown):
(WI.ContentBrowser.prototype.hidden):
(WI.ContentBrowser.prototype.handlePopulateFindShortcut):
(WI.ContentBrowser.prototype.handleFindNextShortcut):
(WI.ContentBrowser.prototype.handleFindPreviousShortcut):
(WI.ContentBrowser.prototype.findBannerSearchQueryForSelection): Deleted.

• UserInterface/Views/LogContentView.js:

(WI.LogContentView.prototype.handlePopulateFindShortcut):
(WI.LogContentView.prototype.handleFindNextShortcut):
(WI.LogContentView.prototype.handleFindPreviousShortcut):
ContentBrowser and LogContentView (the only content view with a custom find banner)
now each handle the global keyboard shortcut handlers to do the right thing for
their respective cases.

• UserInterface/Views/FindBanner.js:

(WI.FindBanner.prototype.enableKeyboardShortcuts): Deleted.
(WI.FindBanner.prototype.disableKeyboardShortcuts): Deleted.
(WI.FindBanner.prototype._populateSearchQueryFromSelection): Deleted.
Move keyboard shortcut handling up to Main.js to be global.

• UserInterface/Views/ContentView.js:

(WI.ContentView.prototype.searchQueryWithSelection):
Default implementation should grab the selected text from the selection.
Previously shortcut selections only worked for selections in text editors.

12:34 PM Changeset in webkit [221690] by mmaxfield@apple.com

• 1 edit
  2 adds in trunk/Tools

WSL should support the bool type
​https://bugs.webkit.org/show_bug.cgi?id=176285

Reviewed by Filip Pizlo.

I forgot to commit a couple files.

• WebGPUShadingLanguageRI/StandardLibraryEpilogue.js: Added.

(const.standardLibraryEpilogue.operator.bool.T.Equatable):

• WebGPUShadingLanguageRI/StandardLibraryPrologue.js: Added.

(operator.T.T):

11:49 AM Changeset in webkit [221689] by commit-queue@webkit.org

• 3 edits
  4 adds in trunk

REGRESSION (r221598): Legacy "round" and "bevel" options can no longer be used with the legacy CanvasRenderingContext2D setLineJoin operation
​https://bugs.webkit.org/show_bug.cgi?id=176461

Patch by Sam Weinig <​sam@webkit.org> on 2017-09-06
Reviewed by Alex Christensen.

Source/WebCore:

Tests: fast/canvas/canvas-strokePath-cap-join-legacy-functions-match-attribute.html

fast/canvas/canvas-strokePath-cap-join-legacy.html

• html/canvas/CanvasRenderingContext2D.cpp:

(WebCore::CanvasRenderingContext2D::setLineJoin):

Fix silly typo, ifs -> else ifs.

LayoutTests:

Add tests showing that the legacy setLineJoin and setLineCap operations are correct
and match the corresponding standard attributes.

• fast/canvas/canvas-strokePath-cap-join-legacy-functions-match-attribute-expected.html: Added.
• fast/canvas/canvas-strokePath-cap-join-legacy-functions-match-attribute.html: Added.
• fast/canvas/canvas-strokePath-cap-join-legacy-expected.txt: Added.
• fast/canvas/canvas-strokePath-cap-join-legacy.html: Added.

11:45 AM Changeset in webkit [221688] by pvollan@apple.com

• 2 edits in trunk/LayoutTests

Rebaseline printing/width-overflow.html after r219121.

Unreviewed test gardening.

• platform/win/printing/width-overflow-expected.txt:

11:26 AM Changeset in webkit [221687] by Matt Lewis

• 2 edits in trunk/LayoutTests

Marked js/arraybuffer-wrappers.html as flaky.
​https://bugs.webkit.org/show_bug.cgi?id=155092

Unreviewed test gardening.

• platform/ios/TestExpectations:

11:25 AM Changeset in webkit [221686] by mmaxfield@apple.com

• 18 edits
  1 copy
  1 delete in trunk/Tools

WSL should correctly handle the interaction between casting operators and complex types
​https://bugs.webkit.org/show_bug.cgi?id=176316

Reviewed by Filip Pizlo.

This allows the standard library to include all identity cast operators for all exsting
and yet-to-exist types. The standard library now has a function with the signature:
operator T<><T>(T). This means "for all T, define a cast operator from T to T<>." The
duplicate <>s lets us say things like operator OutputVector<T><T>(InputVector<T> x).

For testing, this patch also adds the ability to cast an arbitrary Equatable type to bool,
by comparing the value to the default value for that type.

• WebGPUShadingLanguageRI/All.js:
• WebGPUShadingLanguageRI/CastExpression.js: Copied from Tools/WebGPUShadingLanguageRI/NativeFuncInstance.js.

(CastExpression):
(CastExpression.prototype.get functionName):
(CastExpression.prototype.get returnType):
(CastExpression.prototype.toString):

• WebGPUShadingLanguageRI/Checker.js:
• WebGPUShadingLanguageRI/Func.js:

(Func.prototype.toDeclString):

• WebGPUShadingLanguageRI/FuncInstantiator.js:

(FuncInstantiator.prototype.getUnique.Instantiate.prototype.visitNativeFunc):
(FuncInstantiator.prototype.getUnique.Instantiate):
(FuncInstantiator.prototype.getUnique):
(FuncInstantiator):

• WebGPUShadingLanguageRI/Inliner.js:

(Inliner.prototype.visitCastExpression):
(Inliner):

• WebGPUShadingLanguageRI/Intrinsics.js:

(Intrinsics):

• WebGPUShadingLanguageRI/NativeFunc.js:
• WebGPUShadingLanguageRI/NativeFuncInstance.js:

(NativeFuncInstance):

• WebGPUShadingLanguageRI/Parse.js:

(parsePossiblePrefix):
(parseFuncDecl):
(parseOperatorFuncDefValues): Deleted.
(parseNonOperatorFuncDefValues): Deleted.
(parseGenericFuncDefValues): Deleted.

• WebGPUShadingLanguageRI/Prepare.js:

(prepare):

• WebGPUShadingLanguageRI/Program.js:

(Program.prototype.resolveFuncOverload):

• WebGPUShadingLanguageRI/ResolveOverloadImpl.js:

(resolveOverloadImpl):

• WebGPUShadingLanguageRI/Rewriter.js:

(Rewriter.prototype.processDerivedCallData):
(Rewriter.prototype.visitCastExpression):
(Rewriter.prototype.visitCallExpression):

• WebGPUShadingLanguageRI/StandardLibrary.js: Removed.
• WebGPUShadingLanguageRI/Test.html:
• WebGPUShadingLanguageRI/Test.js:
• WebGPUShadingLanguageRI/TypeDefResolver.js:

(TypeDefResolver):
(TypeDefResolver.prototype.visitFuncDef): Deleted.

• WebGPUShadingLanguageRI/Visitor.js:

(Visitor.prototype.visitCastExpression):

11:16 AM Changeset in webkit [221685] by fpizlo@apple.com

• 1 edit
  5 adds in trunk/PerformanceTests

We should have more tests of tail calls
​https://bugs.webkit.org/show_bug.cgi?id=175754

Reviewed by Sam Weinig.

This introduces a new test suite called TailBench9000, which will have benchmarks written in
JavaScript that avoid all looping except by tail call. As a warmup, I wrote a mergesort
benchmark and I proted n-body to use tail calls instead of for loops.

• TailBench9000: Added.
• TailBench9000/merge-sort-run.js: Added.
• TailBench9000/merge-sort.js: Added.

(TEST_mergeSort.createRNG):
(TEST_mergeSort.):
(TEST_mergeSort.merge):
(TEST_mergeSort.mergeSorted):
(TEST_mergeSort.checkSorted.check):
(TEST_mergeSort.checkSorted):
(TEST_mergeSort.add):
(TEST_mergeSort.build):
(TEST_mergeSort.compare):
(TEST_mergeSort.checkSpectrum):
(TEST_mergeSort.buildArray):
(TEST_mergeSort):

• TailBench9000/n-body-run.js: Added.
• TailBench9000/n-body.js: Added.

(TEST_nBody.Body):
(TEST_nBody.Body.prototype.offsetMomentum):
(TEST_nBody.Jupiter):
(TEST_nBody.Saturn):
(TEST_nBody.Uranus):
(TEST_nBody.Neptune):
(TEST_nBody.Sun):
(TEST_nBody.NBodySystem):
(TEST_nBody.NBodySystem.prototype.advance):
(TEST_nBody.NBodySystem.prototype.energy):
(TEST_nBody):

10:47 AM Changeset in webkit [221684] by pvollan@apple.com

• 2 edits in trunk/Source/WebCore

[Win] Compile errors in Document::updateTitleElement.
​https://bugs.webkit.org/show_bug.cgi?id=176381

Reviewed by Alex Christensen.

MSVC is not able to compile the statement:
'auto result = boolExpression ? lambda1 : lambda2;'
where 'lambda1' and 'lambda2' have the same signature.

• dom/Document.cpp:

(WebCore::findHTMLTitle):
(WebCore::isHTMLTitle):
(WebCore::isHTMLTitleEligible):
(WebCore::findSVGTitle):
(WebCore::isSVGTitle):
(WebCore::isSVGTitleEligible):
(WebCore::Document::updateTitleElement):

10:30 AM Changeset in webkit [221683] by Brent Fulgham

• 15 edits
  2 adds in trunk

Deny third-party cookie creation for prevalent resources without interaction
​https://bugs.webkit.org/show_bug.cgi?id=175232
<rdar://problem/33709386>

Reviewed by Alex Christensen.

Source/WebCore:

Prior to Intelligent Tracking Prevention, WebKit would deny the ability to create a third party cookie if the user's
settings prohibited it. Due to the internal mechanics of cookie partitioning, we now accept the third party cookie,
but destroy it at some arbitrary moment which is difficult for websites to work with.

This patch revises WebKit so that attempts to set third party cookies without user interaction fails immediately,
which is what sites are expecting from Safari.

Tests: http/tests/loading/resourceLoadStatistics/third-party-cookie-with-and-without-user-interaction.html

• platform/network/NetworkStorageSession.h:
• platform/network/cf/NetworkStorageSessionCFNet.cpp:

(WebCore::NetworkStorageSession::shouldPartitionCookies const): Revise for new naming.
(WebCore::NetworkStorageSession::shouldAllowThirdPartyCookies const): Allow third party cookies when the
user interaction property applies.
(WebCore::NetworkStorageSession::shouldBlockCookies const): Deny cookies for origins that are not allowed by
user interaction, and that are not being partitioned.
(WebCore::NetworkStorageSession::setPrevalentDomainsWithAndWithoutInteraction): Revise for new naming, and
to track prevalent origins with and without user interaction.
(WebCore::NetworkStorageSession::setShouldPartitionCookiesForHosts): Renamed to setPrevalentDomainsWithAndWithoutInteraction.
(WebCore::NetworkStorageSession::removePrevalentDomains): New helper function for testing.

Source/WebKit:

Prior to Intelligent Tracking Prevention, WebKit would deny the ability to create a third party cookie if the user's
settings prohibited it. Due to the internal mechanics of cookie partitioning, we now accept the third party cookie,
but destroy it at some arbitrary moment which is difficult for websites to work with.

This patch revises WebKit so that attempts to set third party cookies without user interaction fails immediately,
which is what sites are expecting from Safari.

• NetworkProcess/NetworkProcess.cpp:

(WebKit::NetworkProcess::updatePrevalentDomainsWithAndWithoutInteraction):
(WebKit::NetworkProcess::updateCookiePartitioningForTopPrivatelyOwnedDomains): Renamed to updatePrevalentDomainsWithAndWithoutInteraction.

• NetworkProcess/NetworkProcess.h:
• NetworkProcess/NetworkProcess.messages.in: Renamed the UpdateCookiePartitioningForTopPrivatelyOwnedDomains message

to UpdatePrevalentDomainsWithAndWithoutInteraction.

• NetworkProcess/cocoa/NetworkDataTaskCocoa.mm:

(WebKit::NetworkDataTaskCocoa::NetworkDataTaskCocoa): Recognize cases where a network session should block cookies, and
use the stateless session so we fail immediately when attempting an invalid cookie set operation.

• UIProcess/API/Cocoa/WKWebsiteDataStore.mm:

(WebKit::WKWebsiteDataStore::_resourceLoadStatisticsSetShouldPartitionCookies): Use new helper function to clear partitioning state.

• UIProcess/WebResourceLoadStatisticsStore.cpp:

(WebKit::WebResourceLoadStatisticsStore::WebResourceLoadStatisticsStore): Update for revised naming.
(WebKit::WebResourceLoadStatisticsStore::updateCookiePartitioning): Track domains with and without interaction so that we can recognize
domains that should be immediately blocked from setting cookies.
(WebKit::WebResourceLoadStatisticsStore::updateCookiePartitioningForDomains): Update for revised naming.
(WebKit::WebResourceLoadStatisticsStore::scheduleClearPartitioningStateForDomains): Added helper function for testing.

• UIProcess/WebResourceLoadStatisticsStore.h:
• UIProcess/WebsiteData/WebsiteDataStore.cpp:

(WebKit::WebsiteDataStore::updatePrevalentDomainsWithAndWithoutInteraction): Update for revised naming.
(WebKit::WebsiteDataStore::enableResourceLoadStatisticsAndSetTestingCallback): Ditto.
(WebKit::WebsiteDataStore::updateCookiePartitioningForTopPrivatelyOwnedDomains): Renamed to updatePrevalentDomainsWithAndWithoutInteraction.

• UIProcess/WebsiteData/WebsiteDataStore.h:

LayoutTests:

• http/tests/loading/resourceLoadStatistics/third-party-cookie-with-and-without-user-interaction-expected.txt: Added.
• http/tests/loading/resourceLoadStatistics/third-party-cookie-with-and-without-user-interaction.html: Added.
• platform/mac-highsierra-wk2/TestExpectations: Add new test expectation.

10:24 AM Changeset in webkit [221682] by pvollan@apple.com

• 2 edits in trunk/LayoutTests

Layout Test http/tests/preload/single_download_preload.html is flaky.
​https://bugs.webkit.org/show_bug.cgi?id=176465.

Unreviewed test gardening.

• platform/win/TestExpectations:

10:05 AM Changeset in webkit [221681] by Adrian Perez de Castro

• 2 edits in trunk/Source/WebKit

[WPE][CMake] Fix path to the WebKitApplicationInfo.h header.

Unreviewed build fix.

This doesn't really make a difference for the build bots, but it makes
it possible to craft working release tarballs of WPE.

• PlatformWPE.cmake: Use the WPE version of WebKitApplicationInfo.h

10:02 AM Changeset in webkit [221680] by commit-queue@webkit.org

• 2 edits
  10 adds in trunk/LayoutTests

[WPE] Add missing test expectations
​https://bugs.webkit.org/show_bug.cgi?id=176453

Unreviewed test gardening.

Patch by Ms2ger <​Ms2ger@igalia.com> on 2017-09-06

• platform/wpe/TestExpectations:
• platform/wpe/fast/events/context-no-deselect-expected.txt: Added.
• platform/wpe/fast/events/event-listener-on-link-expected.txt: Added.
• platform/wpe/fast/events/ghostly-mousemoves-in-subframe-expected.txt: Added.
• platform/wpe/fast/events/onload-re-entry-expected.txt: Added.
• platform/wpe/fast/events/pointer-events-2-expected.txt: Added.
• platform/wpe/fast/events/resize-events-expected.txt: Added.
• platform/wpe/fast/events/reveal-link-when-focused-expected.txt: Added.
• platform/wpe/fast/events/updateLayoutForHitTest-expected.txt: Added.
• platform/wpe/fast/inspector-support/matchedrules-expected.txt: Added.

9:55 AM Changeset in webkit [221679] by dbates@webkit.org

• 2 edits in trunk/Tools

Copy WebKit Permalink may generate wrong URL with SVN checkout
​https://bugs.webkit.org/show_bug.cgi?id=176427

Reviewed by Darin Adler.

Fixes an issue where Copy WebKit Permalink would generate an incorrect URL for
any file not in the top-level directory of the repository when using an SVN
checkout of WebKit.

Copy WebKit Permalink changes directories to the containing directory D of the
active Xcode document F before running "svn info <path to F>". Currently we use
the value of "Path" from the output of "svn info" when generating the permalink.
This path is relative to D. But we want the path to F relative to the top-level
checkout directory. We need to explicitly compute this.

• CopyPermalink/Copy WebKit Permalink.workflow/Contents/document.wflow:

9:39 AM Changeset in webkit [221678] by Carlos Garcia Campos

• 1800 edits in trunk/LayoutTests

Unreviewed GTK+ gardening. Rebaseline tests after Freetype version bump in r221670. Part 7.

9:37 AM Changeset in webkit [221677] by tpopela@redhat.com

• 2 edits in trunk/Source/WebCore

Missing break in URLParser
​https://bugs.webkit.org/show_bug.cgi?id=176357

Reviewed by Darin Adler.

Add a missing break so the currently set state is not overwritten
after the block. Found by Coverity scan.

• platform/URLParser.cpp:

(WebCore::URLParser::parse):

9:25 AM Changeset in webkit [221676] by Carlos Garcia Campos

• 945 edits
  304 adds in trunk/LayoutTests

Unreviewed GTK+ gardening. Rebaseline tests after Freetype version bump in r221670. Part 6.

9:15 AM Changeset in webkit [221675] by Carlos Garcia Campos

• 1457 edits
  1 copy
  4 adds in trunk/LayoutTests

Unreviewed GTK+ gardening. Rebaseline tests after Freetype version bump in r221670. Part 5.

9:11 AM WebKitGTK/Gardening/Calendar edited by Ms2ger@igalia.com

(diff)

9:04 AM Changeset in webkit [221674] by Carlos Garcia Campos

• 1806 edits
  1 copy
  2 adds in trunk/LayoutTests

Unreviewed GTK+ gardening. Rebaseline tests after Freetype version bump in r221670. Part 4.

8:51 AM Changeset in webkit [221673] by Carlos Garcia Campos

• 1791 edits in trunk/LayoutTests

Unreviewed GTK+ gardening. Rebaseline tests after Freetype version bump in r221670. Part 3.

8:37 AM Changeset in webkit [221672] by Carlos Garcia Campos

• 1562 edits in trunk/LayoutTests

Unreviewed GTK+ gardening. Rebaseline tests after Freetype version bump in r221670. Part 2.

8:25 AM Changeset in webkit [221671] by Carlos Garcia Campos

• 1853 edits in trunk/LayoutTests

Unreviewed GTK+ gardening. Rebaseline tests after Freetype version bump in r221670. Part 1.

8:10 AM Changeset in webkit [221670] by Carlos Garcia Campos

• 4 edits
  1 delete in trunk

[GTK] Bump freetype version to 2.8.0
​https://bugs.webkit.org/show_bug.cgi?id=176351

Source/WebCore:

Patch by Dominik Röttsches <​dominik.rottsches@intel.com> on 2017-09-06
Reviewed by Carlos Alberto Lopez Perez.

Retrieving line spacing info without metrics hinting - FreeType's metric hinting
uses rounding which results in the sum of ascent and descent being larger
than the line height. To work around this without globally disabling font metrics
hinting, I am temporarily creating a new cairo scaled font with metrics hinting
off and retrieving the height values from this one.

• platform/graphics/freetype/SimpleFontDataFreeType.cpp:

(WebCore::scaledFontWithoutMetricsHinting): New function to clone the existing font, only with metrics hinting
disabled.
(WebCore::Font::platformInit): Get height info from non-metrics hinted font, disable rounding for linespacing.

Tools:

Reviewed by Carlos Alberto Lopez Perez.

Remove the patch we were using since it was reverted upstream.

• gtk/jhbuild.modules:
• gtk/patches/freetype6-2.4.11-truetype-font-height-fix.patch: Removed.

7:52 AM WebKitGTK/2.16.x edited by Michael Catanzaro

(diff)

5:42 AM Changeset in webkit [221669] by commit-queue@webkit.org

• 7 edits
  4 adds in trunk/Source

Introduce ScrollingTreeScrollingNodeDelegateIOS to share code between overflow and frame scrolling
​https://bugs.webkit.org/show_bug.cgi?id=174097

Patch by Frédéric Wang <​fwang@igalia.com> on 2017-09-06
Reviewed by Darin Adler.

Source/WebCore:

No new tests, behavior unchanged.

• WebCore.xcodeproj/project.pbxproj: Add ScrollingTreeScrollingNodeDelegate.
• page/scrolling/ScrollingTreeScrollingNode.h: Make ScrollingTreeScrollingNodeDelegate a

friend so that it can access private members.

• page/scrolling/ScrollingTreeScrollingNodeDelegate.cpp: Added. New delegate class for a

scrolling node, which is used by the UI process.
(WebCore::ScrollingTreeScrollingNodeDelegate::ScrollingTreeScrollingNodeDelegate):
Constructor, taking the scrolling node as a parameter.
(WebCore::ScrollingTreeScrollingNodeDelegate::~ScrollingTreeScrollingNodeDelegate):
(WebCore::ScrollingTreeScrollingNodeDelegate::scrollingTree const): Expose the scrolling
tree containing the scrolling node.
(WebCore::ScrollingTreeScrollingNodeDelegate::lastCommittedScrollPosition const): Expose
the last committed scroll position of the scrolling node.

• page/scrolling/ScrollingTreeScrollingNodeDelegate.h: Added.

(WebCore::ScrollingTreeScrollingNodeDelegate::scrollingNode): Expose the scrolling node.
(WebCore::ScrollingTreeScrollingNodeDelegate::scrollingNode const): Ditto.

Source/WebKit:

This patch introduces a new ScrollingTreeScrollingNodeDelegateIOS that can be used by
WKOverflowScrollViewDelegate to communicate to the scrolling tree and nodes. It can also be
used as a helper class by ScrollingTreeOverflowScrollingNodeIOS. For now, only the non-
overriden member functions of ScrollingTreeOverflowScrollingNodeIOS are moved to that new
class. In follow-up commits, WKOverflowScrollViewDelegate can become a generic
ScrollViewDelegate and more code can be moved into the ScrollingTreeScrollingNodeDelegateIOS
file. Frame scrolling nodes will then be able to share the same UI code as overflow:auto when
iOS frame scrolling is implemented (bug 149264).

• UIProcess/RemoteLayerTree/ios/ScrollingTreeOverflowScrollingNodeIOS.h: Move non-overriden member

functions and m_updatingFromStateNode into the delegate class. Also define a member to store
that delegate.

• UIProcess/RemoteLayerTree/ios/ScrollingTreeOverflowScrollingNodeIOS.mm: Use the node delegate to

communicate to the scrolling tree and node.
(-[WKOverflowScrollViewDelegate initWithScrollingTreeNodeDelegate:]): Init with a delegate.
(-[WKOverflowScrollViewDelegate scrollViewDidScroll:]): Call the delegate function.
(-[WKOverflowScrollViewDelegate scrollViewWillBeginDragging:]): Ditto.
(-[WKOverflowScrollViewDelegate scrollViewWillEndDragging:withVelocity:targetContentOffset:]):
Use the delegate functions or pass by ScrollingTreeScrollingNodeDelegateIOS::scrollingNode().
(-[WKOverflowScrollViewDelegate scrollViewDidEndDragging:willDecelerate:]): Use the delegate
functions.
(-[WKOverflowScrollViewDelegate scrollViewDidEndDecelerating:]): Ditto.
(WebKit::ScrollingTreeOverflowScrollingNodeIOS::ScrollingTreeOverflowScrollingNodeIOS):
Init the delegate for this class.
(WebKit::ScrollingTreeOverflowScrollingNodeIOS::commitStateAfterChildren): Use the delegate.
(WebKit::ScrollingTreeOverflowScrollingNodeIOS::setScrollLayerPosition): Use the delegate
function.
(WebKit::ScrollingTreeOverflowScrollingNodeIOS::updateLayersAfterDelegatedScroll): Ditto.
(-[WKOverflowScrollViewDelegate initWithScrollingTreeNode:]): Deleted. This is renamed
initWithScrollingTreeNodeDelegate and accepts a delegate.
(WebKit::ScrollingTreeOverflowScrollingNodeIOS::updateChildNodesAfterScroll): Deleted. Moved
to ScrollingTreeScrollingNodeDelegateIOS.
(WebKit::ScrollingTreeOverflowScrollingNodeIOS::overflowScrollWillStart): Ditto.
(WebKit::ScrollingTreeOverflowScrollingNodeIOS::overflowScrollDidEnd): Ditto.
(WebKit::ScrollingTreeOverflowScrollingNodeIOS::overflowScrollViewWillStartPanGesture): Ditto.
(WebKit::ScrollingTreeOverflowScrollingNodeIOS::scrollViewDidScroll): Ditto.
(WebKit::ScrollingTreeOverflowScrollingNodeIOS::currentSnapPointIndicesDidChange): Ditto.

• UIProcess/RemoteLayerTree/ios/ScrollingTreeScrollingNodeDelegateIOS.h: Added. New delegate class

for ScrollingTreeOverflowScrollingNodeIOS. The members used by WKOverflowScrollViewDelegate
are public and the others are private. ScrollingTreeOverflowScrollingNodeIOS is a friend of
ScrollingTreeScrollingNodeDelegateIOS so that it can access private members e.g.
updateChildNodesAfterScroll() or m_updatingFromStateNode.

• UIProcess/RemoteLayerTree/ios/ScrollingTreeScrollingNodeDelegateIOS.mm: Added.

(WebKit::ScrollingTreeScrollingNodeDelegateIOS::ScrollingTreeScrollingNodeDelegateIOS):
(WebKit::ScrollingTreeScrollingNodeDelegateIOS::~ScrollingTreeScrollingNodeDelegateIOS):
(WebKit::ScrollingTreeScrollingNodeDelegateIOS::updateChildNodesAfterScroll): Code extracted
from ScrollingTreeOverflowScrollingNodeIOS.
(WebKit::ScrollingTreeScrollingNodeDelegateIOS::scrollWillStart): Ditto.
(WebKit::ScrollingTreeScrollingNodeDelegateIOS::scrollDidEnd): Ditto.
(WebKit::ScrollingTreeScrollingNodeDelegateIOS::scrollViewWillStartPanGesture): Ditto.
(WebKit::ScrollingTreeScrollingNodeDelegateIOS::scrollViewDidScroll): Ditto.
(WebKit::ScrollingTreeScrollingNodeDelegateIOS::currentSnapPointIndicesDidChange): Ditto.

• WebKit.xcodeproj/project.pbxproj: Add ScrollingTreeScrollingNodeDelegateIOS files to the

build system.

3:54 AM WebKitGTK/Debugging edited by tpopela@redhat.com

(diff)

2:59 AM Changeset in webkit [221668] by Manuel Rego Casasnovas

• 8 edits
  2 adds in trunk

[css-grid] grid shorthand should not reset the gutter properties
​https://bugs.webkit.org/show_bug.cgi?id=176375

Reviewed by Sergio Villar Senin.

LayoutTests/imported/w3c:

Import new test from WPT.

• web-platform-tests/css/css-grid-1/grid-definition/grid-shorthand-001-expected.txt: Added.
• web-platform-tests/css/css-grid-1/grid-definition/grid-shorthand-001.html: Added.
• web-platform-tests/css/css-grid-1/grid-definition/w3c-import.log:

Source/WebCore:

The CSS WG has resolved that the "grid" shorthand shouldn't reset
the gutter properties anymore:
​https://github.com/w3c/csswg-drafts/issues/1036

This was originally implemented in r195529, so this is somehow
a revert of that change.

Test: imported/w3c/web-platform-tests/css/css-grid-1/grid-definition/grid-shorthand-001.html

• css/CSSProperties.json:
• css/parser/CSSPropertyParser.cpp:

(WebCore::CSSPropertyParser::consumeGridShorthand):

LayoutTests:

Update the test to check the new behavior.

• fast/css-grid-layout/grid-shorthand-get-set-expected.txt:
• fast/css-grid-layout/grid-shorthand-get-set.html:

1:17 AM Changeset in webkit [221667] by zandobersek@gmail.com

• 11 edits
  2 adds in trunk

[WebGL2] Implement getActiveUniforms()
​https://bugs.webkit.org/show_bug.cgi?id=175203

Reviewed by Darin Adler.

Source/WebCore:

Align getActiveUniforms() WebIDL signature with the spec -- making it
return a WebGLAny object, making the program parameter non-nullable,
and making the uniformIndices parameter a sequence on GLuint values.

The getActiveUniforms() implementation in WebGL2RenderingContext
validates the passed-in program and parameter name and then calls the
GraphicsContext3D::getActiveUniforms() method, retrieving an array of
integers that represent values of the requested parameter name for
each uniform whose index was passed through uniformIndices.

Test: fast/canvas/webgl/webgl2-getActiveUniforms.html

• bindings/js/JSDOMConvertWebGL.cpp:

(WebCore::convertToJSValue):

• html/canvas/WebGL2RenderingContext.cpp:

(WebCore::WebGL2RenderingContext::getActiveUniforms):

• html/canvas/WebGL2RenderingContext.h:
• html/canvas/WebGL2RenderingContext.idl:
• html/canvas/WebGLAny.h:
• platform/graphics/GraphicsContext3D.h:
• platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:

(WebCore::GraphicsContext3D::getActiveUniforms):

LayoutTests:

Add a basic gl.getActiveUniforms() test that checks proper return values
for a mat4 uniform in the simple vertex shader that's used when creating
the 'standard' program through webgl-test.js utilities. The test remains
skipped on GTK+ and Windows (WebGL 2.0 disabled). Mac port skips it as
well since the shader can't be compiled properly. WPE and iOS run the
test and are passing it.

• fast/canvas/webgl/webgl2-getActiveUniforms-expected.txt: Added.
• fast/canvas/webgl/webgl2-getActiveUniforms.html: Added.
• platform/gtk/TestExpectations:
• platform/mac/TestExpectations:

12:23 AM Changeset in webkit [221666] by commit-queue@webkit.org

• 2 edits in trunk/Tools

[Win] Tools/TestWebKitAPI/Tests/WTF/PriorityQueue.cpp fails to compile with MSVC 2015
​https://bugs.webkit.org/show_bug.cgi?id=176442

Patch by Yoshiaki Jitsukawa <​Yoshiaki.Jitsukawa@sony.com> on 2017-09-06
Reviewed by Keith Miller.

• TestWebKitAPI/Tests/WTF/PriorityQueue.cpp:

(TEST):

Sep 5, 2017:

11:48 PM Changeset in webkit [221665] by zandobersek@gmail.com

• 57 edits in trunk/Source/WebCore

[WebCrypto] Downcast parameters and keys at the platform operation callsites
​https://bugs.webkit.org/show_bug.cgi?id=176392

Reviewed by Sam Weinig.

Downcast to algorithm-specific parameter and key types in the shared
code that then invokes platform-specific operation implementations.
This reduces the duplicated downcasts across different implementations
that don't differ at all in this behavior.

Covered by existing tests.

• crypto/algorithms/CryptoAlgorithmAES_CBC.cpp:

(WebCore::CryptoAlgorithmAES_CBC::encrypt):
(WebCore::CryptoAlgorithmAES_CBC::decrypt):

• crypto/algorithms/CryptoAlgorithmAES_CBC.h:
• crypto/algorithms/CryptoAlgorithmAES_CFB.cpp:

(WebCore::CryptoAlgorithmAES_CFB::encrypt):
(WebCore::CryptoAlgorithmAES_CFB::decrypt):

• crypto/algorithms/CryptoAlgorithmAES_CFB.h:
• crypto/algorithms/CryptoAlgorithmAES_CTR.cpp:

(WebCore::CryptoAlgorithmAES_CTR::encrypt):
(WebCore::CryptoAlgorithmAES_CTR::decrypt):

• crypto/algorithms/CryptoAlgorithmAES_CTR.h:
• crypto/algorithms/CryptoAlgorithmAES_GCM.cpp:

(WebCore::CryptoAlgorithmAES_GCM::encrypt):
(WebCore::CryptoAlgorithmAES_GCM::decrypt):

• crypto/algorithms/CryptoAlgorithmAES_GCM.h:
• crypto/algorithms/CryptoAlgorithmAES_KW.cpp:

(WebCore::CryptoAlgorithmAES_KW::wrapKey):
(WebCore::CryptoAlgorithmAES_KW::unwrapKey):

• crypto/algorithms/CryptoAlgorithmAES_KW.h:
• crypto/algorithms/CryptoAlgorithmECDH.cpp:

(WebCore::CryptoAlgorithmECDH::deriveBits):

• crypto/algorithms/CryptoAlgorithmECDH.h:
• crypto/algorithms/CryptoAlgorithmECDSA.cpp:

(WebCore::CryptoAlgorithmECDSA::sign):
(WebCore::CryptoAlgorithmECDSA::verify):

• crypto/algorithms/CryptoAlgorithmECDSA.h:
• crypto/algorithms/CryptoAlgorithmHKDF.cpp:

(WebCore::CryptoAlgorithmHKDF::deriveBits):

• crypto/algorithms/CryptoAlgorithmHKDF.h:
• crypto/algorithms/CryptoAlgorithmHMAC.cpp:

(WebCore::CryptoAlgorithmHMAC::sign):
(WebCore::CryptoAlgorithmHMAC::verify):

• crypto/algorithms/CryptoAlgorithmHMAC.h:
• crypto/algorithms/CryptoAlgorithmPBKDF2.cpp:

(WebCore::CryptoAlgorithmPBKDF2::deriveBits):

• crypto/algorithms/CryptoAlgorithmPBKDF2.h:
• crypto/algorithms/CryptoAlgorithmRSAES_PKCS1_v1_5.cpp:

(WebCore::CryptoAlgorithmRSAES_PKCS1_v1_5::encrypt):
(WebCore::CryptoAlgorithmRSAES_PKCS1_v1_5::decrypt):

• crypto/algorithms/CryptoAlgorithmRSAES_PKCS1_v1_5.h:
• crypto/algorithms/CryptoAlgorithmRSASSA_PKCS1_v1_5.cpp:

(WebCore::CryptoAlgorithmRSASSA_PKCS1_v1_5::sign):
(WebCore::CryptoAlgorithmRSASSA_PKCS1_v1_5::verify):

• crypto/algorithms/CryptoAlgorithmRSASSA_PKCS1_v1_5.h:
• crypto/algorithms/CryptoAlgorithmRSA_OAEP.cpp:

(WebCore::CryptoAlgorithmRSA_OAEP::encrypt):
(WebCore::CryptoAlgorithmRSA_OAEP::decrypt):

• crypto/algorithms/CryptoAlgorithmRSA_OAEP.h:
• crypto/algorithms/CryptoAlgorithmRSA_PSS.cpp:

(WebCore::CryptoAlgorithmRSA_PSS::sign):
(WebCore::CryptoAlgorithmRSA_PSS::verify):

• crypto/algorithms/CryptoAlgorithmRSA_PSS.h:
• crypto/gcrypt/CryptoAlgorithmAES_CBCGCrypt.cpp:

(WebCore::CryptoAlgorithmAES_CBC::platformEncrypt):
(WebCore::CryptoAlgorithmAES_CBC::platformDecrypt):

• crypto/gcrypt/CryptoAlgorithmAES_CFBGCrypt.cpp:

(WebCore::CryptoAlgorithmAES_CFB::platformEncrypt):
(WebCore::CryptoAlgorithmAES_CFB::platformDecrypt):

• crypto/gcrypt/CryptoAlgorithmAES_CTRGCrypt.cpp:

(WebCore::CryptoAlgorithmAES_CTR::platformEncrypt):
(WebCore::CryptoAlgorithmAES_CTR::platformDecrypt):

• crypto/gcrypt/CryptoAlgorithmAES_GCMGCrypt.cpp:

(WebCore::CryptoAlgorithmAES_GCM::platformEncrypt):
(WebCore::CryptoAlgorithmAES_GCM::platformDecrypt):

• crypto/gcrypt/CryptoAlgorithmAES_KWGCrypt.cpp:

(WebCore::CryptoAlgorithmAES_KW::platformWrapKey):
(WebCore::CryptoAlgorithmAES_KW::platformUnwrapKey):

• crypto/gcrypt/CryptoAlgorithmECDHGCrypt.cpp:

(WebCore::CryptoAlgorithmECDH::platformDeriveBits):

• crypto/gcrypt/CryptoAlgorithmECDSAGCrypt.cpp:

(WebCore::CryptoAlgorithmECDSA::platformSign):
(WebCore::CryptoAlgorithmECDSA::platformVerify):

• crypto/gcrypt/CryptoAlgorithmHKDFGCrypt.cpp:

(WebCore::CryptoAlgorithmHKDF::platformDeriveBits):

• crypto/gcrypt/CryptoAlgorithmHMACGCrypt.cpp:

(WebCore::CryptoAlgorithmHMAC::platformSign):
(WebCore::CryptoAlgorithmHMAC::platformVerify):

• crypto/gcrypt/CryptoAlgorithmPBKDF2GCrypt.cpp:

(WebCore::CryptoAlgorithmPBKDF2::platformDeriveBits):

• crypto/gcrypt/CryptoAlgorithmRSAES_PKCS1_v1_5GCrypt.cpp:

(WebCore::CryptoAlgorithmRSAES_PKCS1_v1_5::platformEncrypt):
(WebCore::CryptoAlgorithmRSAES_PKCS1_v1_5::platformDecrypt):

• crypto/gcrypt/CryptoAlgorithmRSASSA_PKCS1_v1_5GCrypt.cpp:

(WebCore::CryptoAlgorithmRSASSA_PKCS1_v1_5::platformSign):
(WebCore::CryptoAlgorithmRSASSA_PKCS1_v1_5::platformVerify):

• crypto/gcrypt/CryptoAlgorithmRSA_OAEPGCrypt.cpp:

(WebCore::CryptoAlgorithmRSA_OAEP::platformEncrypt):
(WebCore::CryptoAlgorithmRSA_OAEP::platformDecrypt):

• crypto/gcrypt/CryptoAlgorithmRSA_PSSGCrypt.cpp:

(WebCore::CryptoAlgorithmRSA_PSS::platformSign):
(WebCore::CryptoAlgorithmRSA_PSS::platformVerify):

• crypto/mac/CryptoAlgorithmAES_CBCMac.cpp:

(WebCore::CryptoAlgorithmAES_CBC::platformEncrypt):
(WebCore::CryptoAlgorithmAES_CBC::platformDecrypt):

• crypto/mac/CryptoAlgorithmAES_CFBMac.cpp:

(WebCore::CryptoAlgorithmAES_CFB::platformEncrypt):
(WebCore::CryptoAlgorithmAES_CFB::platformDecrypt):

• crypto/mac/CryptoAlgorithmAES_CTRMac.cpp:

(WebCore::CryptoAlgorithmAES_CTR::platformEncrypt):
(WebCore::CryptoAlgorithmAES_CTR::platformDecrypt):

• crypto/mac/CryptoAlgorithmAES_GCMMac.cpp:

(WebCore::CryptoAlgorithmAES_GCM::platformEncrypt):
(WebCore::CryptoAlgorithmAES_GCM::platformDecrypt):

• crypto/mac/CryptoAlgorithmAES_KWMac.cpp:

(WebCore::CryptoAlgorithmAES_KW::platformWrapKey):
(WebCore::CryptoAlgorithmAES_KW::platformUnwrapKey):

• crypto/mac/CryptoAlgorithmECDHMac.cpp:

(WebCore::CryptoAlgorithmECDH::platformDeriveBits):

• crypto/mac/CryptoAlgorithmECDSAMac.cpp:

(WebCore::CryptoAlgorithmECDSA::platformSign):
(WebCore::CryptoAlgorithmECDSA::platformVerify):

• crypto/mac/CryptoAlgorithmHKDFMac.cpp:

(WebCore::CryptoAlgorithmHKDF::platformDeriveBits):

• crypto/mac/CryptoAlgorithmHMACMac.cpp:

(WebCore::CryptoAlgorithmHMAC::platformSign):
(WebCore::CryptoAlgorithmHMAC::platformVerify):

• crypto/mac/CryptoAlgorithmPBKDF2Mac.cpp:

(WebCore::CryptoAlgorithmPBKDF2::platformDeriveBits):

• crypto/mac/CryptoAlgorithmRSAES_PKCS1_v1_5Mac.cpp:

(WebCore::CryptoAlgorithmRSAES_PKCS1_v1_5::platformEncrypt):
(WebCore::CryptoAlgorithmRSAES_PKCS1_v1_5::platformDecrypt):

• crypto/mac/CryptoAlgorithmRSASSA_PKCS1_v1_5Mac.cpp:

(WebCore::CryptoAlgorithmRSASSA_PKCS1_v1_5::platformSign):
(WebCore::CryptoAlgorithmRSASSA_PKCS1_v1_5::platformVerify):

• crypto/mac/CryptoAlgorithmRSA_OAEPMac.cpp:

(WebCore::CryptoAlgorithmRSA_OAEP::platformEncrypt):
(WebCore::CryptoAlgorithmRSA_OAEP::platformDecrypt):

• crypto/mac/CryptoAlgorithmRSA_PSSMac.cpp:

(WebCore::CryptoAlgorithmRSA_PSS::platformSign):
(WebCore::CryptoAlgorithmRSA_PSS::platformVerify):

10:25 PM Changeset in webkit [221664] by rniwa@webkit.org

• 2 edits in trunk/Websites/perf.webkit.org

Add a button to show two weeks of data to perf dashboard
​https://bugs.webkit.org/show_bug.cgi?id=176438

Reviewed by Saam Barati.

Add "2W" button to show 14 days of data on dashboard pages.

• public/v3/pages/dashboard-toolbar.js:

(DashboardToolbar):

10:02 PM Changeset in webkit [221663] by Chris Dumez

• 3 edits in trunk/LayoutTests

Unreviewed, rebaseline test after r221639.

• fast/forms/file/entries-api/drag-folder-webkitEntries-expected.txt:
• fast/forms/file/entries-api/drag-folder-webkitEntries.html:

8:55 PM Changeset in webkit [221662] by Nikita Vasilyev

• 3 edits in trunk/Source/WebInspectorUI

Web Inspector: Styles Redesign: display "Inherited From" section headers
​https://bugs.webkit.org/show_bug.cgi?id=176033
<rdar://problem/34116930>

Reviewed by Devin Rousso.

Compared to the old styles sidebar, the new "Inherited From" sections are more compact.
One of the goals of the styles redesign is to make it fit more data vertically.

The contrast is inceased. The text is darker while the background stayed the same.

• UserInterface/Views/SpreadsheetRulesStyleDetailsPanel.css:

(.spreadsheet-style-panel .section-inherited):
(.spreadsheet-style-panel .section-inherited .node-link):
(.spreadsheet-style-panel .section-inherited .node-link:hover):

• UserInterface/Views/SpreadsheetRulesStyleDetailsPanel.js:

(WI.SpreadsheetRulesStyleDetailsPanel):
(WI.SpreadsheetRulesStyleDetailsPanel.prototype.refresh):
Don't show two identical "Inherited From" sections.

8:35 PM Changeset in webkit [221661] by Darin Adler

• 13 edits in trunk

Fix a few minor problems found while working toward removing unneeded calls to updateStyle
​https://bugs.webkit.org/show_bug.cgi?id=176279

Reviewed by Antti Koivisto.

Source/WebCore:

• dom/Document.cpp:

(WebCore::Document::updateTitleElement): Fix the algorithm so that an SVG title won't
ever become the title when the document element is not an SVG element. We had this wrong
before but we were passing the test because SVGTitleElement::insertedInto had a bug that
hid the problem.
(WebCore::Document::titleElementAdded): Pass a reference instead of a pointer.
(WebCore::Document::titleElementRemoved): Pass a reference instead of nullptr since we
want to know which element is being removed.

• dom/Document.h: Update the argument name and type for updateTitleElement.

• html/HTMLTitleElement.cpp:

(WebCore::HTMLTitleElement::insertedInto): Call titleElementAdded unconditionally.
The checks to see if the title element is connected to the document and not in the
shadow tree are now handled by the Document class.
(WebCore::HTMLTitleElement::removedFrom): Same for titleElementRemoved.

• platform/mock/MockRealtimeVideoSource.cpp:

(WebCore::MockRealtimeVideoSource::applySize): Removed incorrect caching of FontCascade
objects; these need to be created each time we draw.
(WebCore::MockRealtimeVideoSource::drawText): Create all the fonts here. Since this is
a mock for testing, there is no real performance concern with doing this.

• platform/mock/MockRealtimeVideoSource.h: Removed the FontCascade data members.

• rendering/RenderTreeAsText.cpp:

(WebCore::updateLayoutIgnoringPendingStylesheetsIncludingSubframes): Added. Used below
to update layout more thoroughly.
(WebCore::externalRepresentation): Update layout of all descendant frames, not just
the top level frame.

• svg/SVGTitleElement.cpp:

(WebCore::SVGTitleElement::insertedInto): Removed bogus firstChild check, bogus isSVGDocument
check, and unneeded isConnected check and call titleElementAdded unconditionally. The checks
are now handled by the Document class.
(WebCore::SVGTitleElement::removedFrom): Same for titleElementRemoved.

• testing/Internals.cpp:

(WebCore::Internals::layerTreeAsText const): Added missing updateLayoutIgnorePendingStylesheets,
since dumping the layer tree without first doing a layout will yield stale results.
(WebCore::Internals::layerIDForElement): Added missing updateLayoutIgnorePendingStylesheets,
since using a renderer to check if a layer exists without first doing a layout will yield stale results.
(WebCore::Internals::setElementUsesDisplayListDrawing): Ditto.
(WebCore::Internals::setElementTracksDisplayListReplay): Ditto.
(WebCore::Internals::displayListForElement): Ditto.
(WebCore::Internals::replayDisplayListForElement): Ditto.
(WebCore::Internals::isSelectPopupVisible): Added missing updateLayoutIgnorePendingStylesheets,
since working with the RenderMenuList without first doing a layout will yield stale results.
Also removed unneeded strict handling of null renderer, instead just returning false.
(WebCore::Internals::isPluginUnavailabilityIndicatorObscured): Removed unnneeded check of
renderer class, since the HTMLPlugInElement::isReplacementObscured already handles that correctly.
(WebCore::Internals::pageOverlayLayerTreeAsText const): Use updateLayoutIgnorePendingStylesheets
instead of the normal updateLayout for consistency with the behavior of the other functions in this
file, and because we need a real answer here.
(WebCore::Internals::scrollSnapOffsets): Ditto. Also rearranged the code so the renderer check is
done after updating the renderer tree.

Tools:

• WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:

(WTR::AccessibilityUIElement::setSelectedChild const): Handle null here. The old code instead
would trigger an Objective-C exception unnecessarily.

LayoutTests:

• svg/hittest/svg-tooltip.svg: Made this test easier to run outside of WebKitTestRunnner,

by removing some overzealous checks.

7:41 PM Changeset in webkit [221660] by Wenson Hsieh

• 21 edits
  1 add in trunk

[iOS WK2] Add plumbing for WKContentView to ask the web process for additional drag items
​https://bugs.webkit.org/show_bug.cgi?id=176348
Work towards <rdar://problem/31144674>

Reviewed by Tim Horton.

Source/WebKit:

Adds boilerplate plumbing to request additional items to an existing session. This implements some UI-side logic
in WKContentView to send an additional drag items request and handle a response from the web process.
To start, WebPageProxy::requestAdditionalItemsForDragSession is invoked by -_dragInteraction:
itemsForAddingToSession:withTouchAtPoint:completion: in WKContentView, and the response from the web process is
handled in -[WKContentView _didHandleAdditionalDragItemsRequest:].

• UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _simulateItemsForAddingToSession:atLocation:completion:]):

• UIProcess/API/Cocoa/WKWebViewPrivate.h:

Add SPI to simulate a request for additional drag items. See Tools/ChangeLog for more detail.

• UIProcess/PageClient.h:
• UIProcess/WebPageProxy.h:
• UIProcess/WebPageProxy.messages.in:

Add an IPC message handler for the additional drag items response from the web process.

• UIProcess/ios/DragDropInteractionState.h:

(WebKit::DragDropInteractionState::BlockPtr<void):

• UIProcess/ios/DragDropInteractionState.mm:

(WebKit::DragDropInteractionState::shouldRequestAdditionalItemForDragSession const):
(WebKit::DragDropInteractionState::dragSessionWillRequestAdditionalItem):

Invoke the new additional items completion handler when tearing down to avoid getting UIKit into a bad state.

(WebKit::DragDropInteractionState::dragAndDropSessionsDidEnd):

• UIProcess/ios/PageClientImplIOS.h:
• UIProcess/ios/PageClientImplIOS.mm:

(WebKit::PageClientImpl::didHandleAdditionalDragItemsRequest):

• UIProcess/ios/WKContentViewInteraction.h:
• UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView _didHandleAdditionalDragItemsRequest:]):
(-[WKContentView _itemsForBeginningOrAddingToSessionWithRegistrationList:stagedDragSource:]):

Factors common logic to convert a staged WebItemProviderRegistrationInfoList and DragSourceState into a list of
drag items, invoking the private UI delegate in the process. This is called both when starting a drag session,
and adding items to an existing drag session.

(-[WKContentView _dragInteraction:itemsForAddingToSession:withTouchAtPoint:completion:]):

Implements a (proposed) additional drag item delegate that serves as an asynchronous alternative to the API
variant, -_dragInteraction:itemsForAddingToSession:withTouchAtPoint:. See <rdar://problem/33146803> for more
information.

(-[WKContentView dragInteraction:itemsForBeginningSession:]):

Refactored to use -_itemsForBeginningOrAddingToSessionWithRegistrationList:stagedDragSource:.

(-[WKContentView _simulateItemsForAddingToSession:atLocation:completion:]):

• UIProcess/ios/WebPageProxyIOS.mm:

(WebKit::WebPageProxy::didHandleAdditionalDragItemsRequest):
(WebKit::WebPageProxy::requestAdditionalItemsForDragSession):

• WebProcess/WebPage/WebPage.h:
• WebProcess/WebPage/WebPage.messages.in:

Add an IPC message handler for the additional drag items request from the UI process.

• WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::requestAdditionalItemsForDragSession):

Tools:

Introduces new test infrastructure to simulate tapping to add additional items to the current drag session. We
add -[DataInteractionSimulator runFrom:to:additionalItemRequestLocations:], for which the last argument is a
dictionary mapping progress (a double between 0 and 1) to NSValues representing the location from which the drag
and drop simulation will request an additional drag item. During the simulated drag and drop, when the progress
value exceeds a value in the map of remaining additional item request locations, we halt drag simulation
progress for that runloop and instead request additional items from the location specified.

The only (useful) passing test we can create using the new machinery is one that verifies that preventDefault()
on dragstart works as expected, preventing additional items from being added. While this trivially passes now,
since the web-process-side of the additional items flow is not yet implemented, it should continue to pass after
the web process portion is implemented.

• TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
• TestWebKitAPI/Tests/WebKitCocoa/selected-text-image-link-and-editable.html: Added.

Add a new test page that contains some non-editable text, an image, a link, and a rich text editable area.

• TestWebKitAPI/Tests/ios/DataInteractionTests.mm:

(TestWebKitAPI::TEST):

• TestWebKitAPI/ios/DataInteractionSimulator.h:
• TestWebKitAPI/ios/DataInteractionSimulator.mm:

(-[MockDragDropSession addItems:]):

Convenience method to add additional mock drag items to a drag or drop session.

(-[DataInteractionSimulator _resetSimulatedState]):
(-[DataInteractionSimulator runFrom:to:]):

Converted into a convenience wrapper around the latter version, passing in nil for the additional item request
locations dictionary.

(-[DataInteractionSimulator runFrom:to:additionalItemRequestLocations:]):
(-[DataInteractionSimulator _enqueuePendingAdditionalItemRequestLocations]):
(-[DataInteractionSimulator _sendQueuedAdditionalItemRequest]):

New helper methods to detect when and where additional items should be "added", and subsequently simulate adding
drag items at these given locations.

(-[DataInteractionSimulator _advanceProgress]):

7:37 PM Changeset in webkit [221659] by rniwa@webkit.org

• 4 edits in trunk/PerformanceTests

Compute the final score using geometric mean in Speedometer 2.0
​https://bugs.webkit.org/show_bug.cgi?id=172968

Reviewed by Saam Barati.

Make Speedometer 2.0 use the geometric mean of the subtotal of each test suite instead of the total..

In Speedometer 1.0, we used the total time to compute the final score because we wanted to make
the slowest framework and library faster. The fastest suite (FlightJS) still accounted for ~6% and
the slowest case (React) accounted for ~25% so we felt the total time, or the arithmetic mean with
a constant factor, was a good metric to track.

In the latest version of Speedometer 2.0, however, the fastest suite (Preact) runs in ~55ms whereas
the slowest suite (Inferno) takes 1.5s on Safari. Since the total time is 6.5s, Preact's suite only
accounts for ~0.8% of the total score while Inferno's suite accounts for ~23% of the total score.
Since the goal of Speedometer is to approximate different kinds of DOM API use patterns on the Web,
we want each framework & library to have some measurement impact on the overall benchmark score.

Furthermore, after r221205, we're testing both debug build of Ember.js as well as release build.
Since debug build is 4x slower, using the total time or the arithmetic mean thereof will effectively
give 4x as much weight to debug build of Ember.js relative to release build of Ember.js. Given only
~5% of websites that deploy Ember.js use debug build, this weighting is clearly not right.

This patch, therefore, replaces the arithmetic mean by the geometric mean to compute the final score.
It also moves the code to compute the final score to BenchmarkRunner to be shared between main.js
and InteractiveRunner.html.

• Speedometer/InteractiveRunner.html:

(.didRunSuites): Show geometric mean, arithmetic mean, total, as well as the score for completeness
since this is a debugging page for developers.

• Speedometer/resources/benchmark-runner.js:

(BenchmarkRunner.prototype.step): Added mean, geomean, and score as measuredValues' properties.
(BenchmarkRunner.prototype._runTestAndRecordResults): Removed the dead code.
(BenchmarkRunner.prototype._finalize): Compute and add total, arithmetic mean (just mean in the code),
and geometric mean (geomean) to measuredValues.

• Speedometer/resources/main.js:

(window.benchmarkClient): Replaced testsCount by stepsCount and _timeValues by _measuredValuesList.
(window.benchmarkClient.willRunTest):
(window.benchmarkClient.didRunTest):
(window.benchmarkClient.didRunSuites): Store measuredValues object instead of just the total time.
(window.benchmarkClient.didFinishLastIteration):
(window.benchmarkClient._computeResults):
(window.benchmarkClient._computeResults.valueForUnit): Renamed from totalTimeInDisplayUnit. Now simply
retrieves the values computed by BenchmarkRunner's_finalize.
(startBenchmark):
(computeScore): Deleted.

6:23 PM Changeset in webkit [221658] by commit-queue@webkit.org

• 13 edits in trunk

Add WKUIDelegatePrivate equivalent of WKPageUIClient's mouseDidMoveOverElement
​https://bugs.webkit.org/show_bug.cgi?id=176428
<rdar://problem/29270035>

Patch by Alex Christensen <​achristensen@webkit.org> on 2017-09-05
Reviewed by Tim Horton.

Source/WebKit:

Covered by a new API test.

• UIProcess/API/APIUIClient.h:

(API::UIClient::mouseDidMoveOverElement):

• UIProcess/API/C/WKPage.cpp:

(WKPageSetPageUIClient):

• UIProcess/API/Cocoa/WKUIDelegatePrivate.h:
• UIProcess/Cocoa/UIDelegate.h:
• UIProcess/Cocoa/UIDelegate.mm:

(WebKit::UIDelegate::setDelegate):
(WebKit::UIDelegate::ContextMenuClient::menuFromProposedMenu):
(WebKit::UIDelegate::UIClient::createNewPageCommon):
(WebKit::UIDelegate::UIClient::runJavaScriptAlert):
(WebKit::UIDelegate::UIClient::runJavaScriptConfirm):
(WebKit::UIDelegate::UIClient::runJavaScriptPrompt):
(WebKit::UIDelegate::UIClient::runBeforeUnloadConfirmPanel):
(WebKit::UIDelegate::UIClient::takeFocus):
(WebKit::UIDelegate::UIClient::focus):
(WebKit::UIDelegate::UIClient::unfocus):
(WebKit::UIDelegate::UIClient::didExceedBackgroundResourceLimitWhileInForeground):
(WebKit::UIDelegate::UIClient::didNotHandleWheelEvent):
(WebKit::toNSEventModifierFlags):
(WebKit::UIDelegate::UIClient::mouseDidMoveOverElement):
(WebKit::UIDelegate::UIClient::toolbarsAreVisible):
(WebKit::UIDelegate::UIClient::didClickAutoFillButton):
(WebKit::UIDelegate::UIClient::handleAutoplayEvent):
(WebKit::requestUserMediaAuthorizationForDevices):
(WebKit::UIDelegate::UIClient::decidePolicyForUserMediaPermissionRequest):
(WebKit::UIDelegate::UIClient::checkUserMediaPermissionForOrigin):
(WebKit::UIDelegate::UIClient::printFrame):
(WebKit::UIDelegate::UIClient::close):
(WebKit::UIDelegate::UIClient::fullscreenMayReturnToInline):
(WebKit::UIDelegate::UIClient::didEnterFullscreen):
(WebKit::UIDelegate::UIClient::didExitFullscreen):
(WebKit::UIDelegate::UIClient::requestPointerLock):
(WebKit::UIDelegate::UIClient::didLosePointerLock):
(WebKit::UIDelegate::UIClient::hasVideoInPictureInPictureDidChange):

• UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::mouseDidMoveOverElement):

• UIProcess/WebPageProxy.h:

Tools:

• TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:

(-[MouseMoveOverElementDelegate _webView:mouseDidMoveOverElement:withFlags:userInfo:]):
(TEST):

• TestWebKitAPI/cocoa/TestWKWebView.h:
• TestWebKitAPI/cocoa/TestWKWebView.mm:

(-[TestWKWebView mouseMoveToPoint:withFlags:]):

6:18 PM Changeset in webkit [221657] by sbarati@apple.com

• 3 edits
  1 add in trunk

isNotCellSpeculation is wrong with respect to SpecEmpty
​https://bugs.webkit.org/show_bug.cgi?id=176429

Reviewed by Michael Saboff.

JSTests:

• microbenchmarks/is-not-cell-speculation-for-empty-value.js: Added.

(Foo):

Source/JavaScriptCore:

The isNotCellSpeculation(SpeculatedType t) function was not taking into account
SpecEmpty in the set for t. It should return false when SpecEmpty is present, since
the empty value will fail a NotCell check. This bug would cause us to erroneously
generate NotCellUse UseKinds for inputs that are the empty value, causing repeated OSR exits.

• bytecode/SpeculatedType.h:

(JSC::isNotCellSpeculation):

6:01 PM Changeset in webkit [221656] by commit-queue@webkit.org

• 4 edits in trunk/Tools

Benchmark Runner WebDriver maximize window on browser launch
​https://bugs.webkit.org/show_bug.cgi?id=175702

Patch by Matthew Stewart <​matthew_r_stewart@apple.com> on 2017-09-05
Reviewed by Stephanie Lewis.

• Scripts/webkitpy/benchmark_runner/browser_driver/linux_browser_driver.py:

(LinuxBrowserDriver.launch_webdriver): added driver.maximize_window()

• Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:

(OSXBrowserDriver._launch_webdriver): added driver.maximize_window()

• Scripts/webkitpy/benchmark_runner/webdriver_benchmark_runner.py:

(WebDriverBenchmarkRunner._run_one_test): added driver.quit()

6:00 PM Changeset in webkit [221655] by commit-queue@webkit.org

• 7 edits in trunk/Tools

Fix Benchmark Runner selenium autoinstall imports
​https://bugs.webkit.org/show_bug.cgi?id=175727

Patch by Matthew Stewart <​matthew_r_stewart@apple.com> on 2017-09-05
Reviewed by Stephanie Lewis.

This fixes run-benchmark taking a long time to start with WebDriver.

Inside webdriver's init.py file, it imports many other modules.
So if we try to directly import autoinstalled.selenium.webdriver, it
will re-run the autoinstall init.py for each new imported module
that contains ".selenium"
TODO: fix this inside the autoinstall code, to only do one install per
import.

• Scripts/webkitpy/benchmark_runner/browser_driver/linux_chrome_driver.py:

(LinuxChromeDriver.launch_driver):

• Scripts/webkitpy/benchmark_runner/browser_driver/linux_firefox_driver.py:

(LinuxFirefoxDriver.launch_driver):

• Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py:

(OSXChromeDriver.launch_driver):
(OSXChromeCanaryDriver.launch_driver):
(create_chrome_options):

• Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py:

(OSXFirefoxDriver.launch_driver):
(OSXFirefoxNightlyDriver.launch_driver):

• Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:

(OSXSafariDriver.launch_driver):

• Scripts/webkitpy/benchmark_runner/webdriver_benchmark_runner.py:

(WebDriverBenchmarkRunner._run_one_test):

5:58 PM Changeset in webkit [221654] by matthew_hanson@apple.com

• 2 edits in tags/Safari-605.1.4.1/Source/WebKit

Cherry-pick r221457. rdar://problem/34186977

5:58 PM Changeset in webkit [221653] by matthew_hanson@apple.com

• 7 edits in tags/Safari-605.1.4.1/Source

Versioning.

5:53 PM Changeset in webkit [221652] by matthew_hanson@apple.com

• 1 copy in tags/Safari-605.1.4.1

New Tag.

5:10 PM Changeset in webkit [221651] by matthew_hanson@apple.com

• 1 copy in tags/Safari-604.1.38.1.7

Tag Safari-604.1.38.1.7.

5:09 PM Changeset in webkit [221650] by matthew_hanson@apple.com

• 1 copy in tags/Safari-604.2.8

Tag Safari-604.2.8.

4:54 PM Changeset in webkit [221649] by aakash_jain@apple.com

• 3 edits in trunk/Tools

EWS should report when a step succeeds
​https://bugs.webkit.org/show_bug.cgi?id=176332
<rdar://problem/25224607>

Reviewed by Sam Weinig.

Most of the EWSes report only if a step fails, but do not report when a step succeed. For e.g.: If a build succeeds,
EWS does not report it. Information about a step passing is sometimes very valuable, especially when waiting for a
patch to complete processing. Sometimes, patch authors know that their changes are not covered by any tests. Having EWS
display that build was successful and it is currently running tests is valuable.

• Scripts/webkitpy/tool/commands/earlywarningsystem.py:

(AbstractEarlyWarningSystem.command_passed): Update the EWS status server when a command pass. This is
similar to what is done in Commit Queue and Style Queue.

• Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:

(EarlyWarningSystemTest._default_expected_logs): Updated unit-tests appropriately.

4:38 PM Changeset in webkit [221648] by Nikita Vasilyev

• 4 edits in trunk/Source/WebInspectorUI

Web Inspector: Layout flashing for internal View.prototype.layout
​https://bugs.webkit.org/show_bug.cgi?id=176389

Reviewed by Matt Baker.

Add a checkbox to Settings (Debug panel) to draw an orange outline around an element every time View.prototype.layout is called.
This is similar to paint flashing, except this is only for View.prototype.layout.

• UserInterface/Base/Setting.js:
• UserInterface/Views/SettingsTabContentView.js:

(WI.SettingsTabContentView.prototype._createDebugSettingsView):

• UserInterface/Views/View.js:

(WI.View.prototype._layoutSubtree):
(WI.View.prototype._drawLayoutFlashingOutline):

4:36 PM Changeset in webkit [221647] by Brent Fulgham

• 3 edits in trunk/Source/WebKit

Relax keychain access to permit users to permanently allow client certificates
​https://bugs.webkit.org/show_bug.cgi?id=175857
<rdar://problem/32293867>

Reviewed by Alex Christensen.

Further relax the write permissions on the user's Keychain directory to support local certificates.

• NetworkProcess/mac/com.apple.WebKit.NetworkProcess.sb.in:
• WebProcess/com.apple.WebProcess.sb.in:

4:33 PM Changeset in webkit [221646] by Ryan Haddad

• 7 edits in trunk/Source/WebCore

Unreviewed, rolling out r221495.

This change introduced assertion failures on El Capitan Debug
WK2.

Reverted changeset:

"Move ServiceWorkerJob from FetchLoader to ThreadableLoader."
​https://bugs.webkit.org/show_bug.cgi?id=176231
​http://trac.webkit.org/changeset/221495

4:28 PM Changeset in webkit [221645] by Chris Dumez

• 11 edits
  7 adds in trunk

Add support for input.webkitEntries
​https://bugs.webkit.org/show_bug.cgi?id=176257
<rdar://problem/34218671>

Reviewed by Andreas Kling.

Source/WebCore:

Add support for input.webkitEntries as per:

• ​https://wicg.github.io/entries-api/#html-forms

Our behavior matches Chrome and Firefox, rather than the specification. This means
that webkitEntries is only populated if the webkitdirectory flag is unset.

Tests: fast/forms/file/entries-api/drag-folder-webkitEntries.html

fast/forms/file/entries-api/webkitdirectory-drag-folder-webkitEntries.html

• CMakeLists.txt:
• DerivedSources.make:
• Modules/entriesapi/HTMLInputElementEntriesAPI.cpp: Added.

(WebCore::HTMLInputElementEntriesAPI::webkitEntries):

• Modules/entriesapi/HTMLInputElementEntriesAPI.h: Added.
• Modules/entriesapi/HTMLInputElementEntriesAPI.idl: Added.
• WebCore.xcodeproj/project.pbxproj:
• bindings/scripts/generate-bindings.pl:
• bindings/scripts/test/JS/JSTestInterface.cpp:

(WebCore::jsTestInterfaceReflectAttributeGetter):
(WebCore::jsTestInterfaceReflectAttribute):
(WebCore::setJSTestInterfaceReflectAttributeSetter):
(WebCore::setJSTestInterfaceReflectAttribute):

• bindings/scripts/test/TestSupplemental.idl:
• html/HTMLInputElement.idl:

LayoutTests:

Add layout test coverage.

• fast/forms/file/entries-api/drag-folder-webkitEntries-expected.txt: Added.
• fast/forms/file/entries-api/drag-folder-webkitEntries.html: Added.
• fast/forms/file/entries-api/webkitdirectory-drag-folder-webkitEntries-expected.txt: Added.
• fast/forms/file/entries-api/webkitdirectory-drag-folder-webkitEntries.html: Added.
• http/wpt/entries-api/interfaces-expected.txt:
• platform/wk2/TestExpectations:

4:25 PM Changeset in webkit [221644] by matthew_hanson@apple.com

• 7 edits in tags/Safari-605.1.4/Source

Revert r221640. rdar://problem/34186977

4:25 PM Changeset in webkit [221643] by matthew_hanson@apple.com

• 2 edits in tags/Safari-605.1.4/Source/WebKit

Revert r221641. rdar://problem/34186977

4:18 PM Changeset in webkit [221642] by pvollan@apple.com

• 2 edits in trunk/LayoutTests

Marked imported/w3c/web-platform-tests/html/browsers/history/the-history-interface/joint_session_history/001.html as slow.

Unreviewed test gardening.

• platform/win/TestExpectations:

4:04 PM Changeset in webkit [221641] by matthew_hanson@apple.com

• 2 edits in tags/Safari-605.1.4/Source/WebKit

Cherry-pick r221457. rdar://problem/34186977

4:01 PM Changeset in webkit [221640] by matthew_hanson@apple.com

• 7 edits in tags/Safari-605.1.4/Source

Versioning.

3:53 PM Changeset in webkit [221639] by Chris Dumez

• 6 edits
  5 adds in trunk

FileSystemEntry API should ignore hidden files
​https://bugs.webkit.org/show_bug.cgi?id=176292
<rdar://problem/34257666>

Reviewed by Andreas Kling.

Source/WebCore:

FileSystemEntry API should ignore hidden files as the user likely does not mean
to expose those when drag'n dropping a folder.

Test: editing/pasteboard/enties-api/datatransfer-items-drop-hidden-file.html

• Modules/entriesapi/DOMFileSystem.cpp:

(WebCore::listDirectoryWithMetadata):
(WebCore::validatePathIsExpectedType):
(WebCore::fileType):
(WebCore::DOMFileSystem::getEntry):

LayoutTests:

Add layout test coverage.

• editing/pasteboard/enties-api/datatransfer-items-drop-getAsEntry-expected.txt:
• editing/pasteboard/enties-api/datatransfer-items-drop-getAsEntry.html:
• editing/pasteboard/enties-api/datatransfer-items-drop-hidden-file-expected.txt: Added.
• editing/pasteboard/enties-api/datatransfer-items-drop-hidden-file.html: Added.
• fast/forms/file/entries-api/resources/testFiles/.hidden.txt: Added.
• fast/forms/file/entries-api/resources/testFiles/.hidden/hidden.txt: Added.
• platform/win/TestExpectations:

3:36 PM Changeset in webkit [221638] by Matt Lewis

• 2 edits in trunk/LayoutTests

Marked svg/as-image/svg-image-with-data-uri-background.html as flaky.
​https://bugs.webkit.org/show_bug.cgi?id=172877

Unreviewed test gardening.

• platform/mac-wk1/TestExpectations:

2:30 PM Changeset in webkit [221637] by sbarati@apple.com

• 16 edits in trunk/Source/JavaScriptCore

Make the distinction between entrypoints and CFG roots more clear by naming things better
​https://bugs.webkit.org/show_bug.cgi?id=176336

Reviewed by Mark Lam and Keith Miller and Michael Saboff.

This patch does renaming to make the distinction between Graph::m_entrypoints
and Graph::m_numberOfEntrypoints more clear. The source of confusion is that
Graph::m_entrypoints.size() is not equivalent to Graph::m_numberOfEntrypoints.
Graph::m_entrypoints is really just the CFG roots. In CPS, this vector has
size >= 1. In SSA, the size is always 1. This patch renames Graph::m_entrypoints
to Graph::m_roots. To be consistent, this patch also renames Graph's m_entrypointToArguments
field to m_rootToArguments.

Graph::m_numberOfEntrypoints retains its name. This field is only used in SSA
when compiling with EntrySwitch. It represents the logical number of entrypoints
the compilation will end up with. Each EntrySwitch has m_numberOfEntrypoints
cases.

• dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::parseBlock):
(JSC::DFG::ByteCodeParser::parseCodeBlock):

• dfg/DFGCFG.h:

(JSC::DFG::CFG::roots):
(JSC::DFG::CPSCFG::CPSCFG):

• dfg/DFGCPSRethreadingPhase.cpp:

(JSC::DFG::CPSRethreadingPhase::specialCaseArguments):

• dfg/DFGDCEPhase.cpp:

(JSC::DFG::DCEPhase::run):

• dfg/DFGGraph.cpp:

(JSC::DFG::Graph::dump):
(JSC::DFG::Graph::determineReachability):
(JSC::DFG::Graph::blocksInPreOrder):
(JSC::DFG::Graph::blocksInPostOrder):
(JSC::DFG::Graph::methodOfGettingAValueProfileFor):

• dfg/DFGGraph.h:

(JSC::DFG::Graph::isRoot):
(JSC::DFG::Graph::isEntrypoint): Deleted.

• dfg/DFGInPlaceAbstractState.cpp:

(JSC::DFG::InPlaceAbstractState::initialize):

• dfg/DFGLoopPreHeaderCreationPhase.cpp:

(JSC::DFG::createPreHeader):

• dfg/DFGMaximalFlushInsertionPhase.cpp:

(JSC::DFG::MaximalFlushInsertionPhase::run):
(JSC::DFG::MaximalFlushInsertionPhase::treatRegularBlock):

• dfg/DFGOSREntrypointCreationPhase.cpp:

(JSC::DFG::OSREntrypointCreationPhase::run):

• dfg/DFGPredictionInjectionPhase.cpp:

(JSC::DFG::PredictionInjectionPhase::run):

• dfg/DFGSSAConversionPhase.cpp:

(JSC::DFG::SSAConversionPhase::run):

• dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::checkArgumentTypes):
(JSC::DFG::SpeculativeJIT::linkOSREntries):

• dfg/DFGTypeCheckHoistingPhase.cpp:

(JSC::DFG::TypeCheckHoistingPhase::run):

• dfg/DFGValidate.cpp:

2:18 PM Changeset in webkit [221636] by jfbastien@apple.com

• 2 edits in trunk/PerformanceTests

StitchMarker: build fix

2:17 PM Changeset in webkit [221635] by pvollan@apple.com

• 2 edits in trunk/LayoutTests

DataTransferItem tests are timing out on Windows.
​https://bugs.webkit.org/show_bug.cgi?id=176423.

Unreviewed test gardening.

• platform/win/TestExpectations:

2:11 PM Changeset in webkit [221634] by mmaxfield@apple.com

• 16 edits
  2 copies in trunk/Tools

WSL should support the bool type
​https://bugs.webkit.org/show_bug.cgi?id=176285

Reviewed by Filip Pizlo.

Very similar to the int and uint types. This patch also adds support for a logical negation expression "!x".
This patch also reverts the ability of the program author to create their own "operator!()", and instead
adds the ability of the program author to create their own "operator bool()". The code is generic, so
programmers can make two arbitrary types Foo and Bar, and implement a "operator Bar(Foo)." The logical
negation expression is a built-in, and requires its argument be a bool.

• WebGPUShadingLanguageRI/All.js:
• WebGPUShadingLanguageRI/BoolLiteral.js: Copied from Tools/WebGPUShadingLanguageRI/NativeFunc.js.

(BoolLiteral):
(BoolLiteral.prototype.get value):
(BoolLiteral.prototype.get isConstexpr):
(BoolLiteral.prototype.toString):

• WebGPUShadingLanguageRI/Checker.js:
• WebGPUShadingLanguageRI/Evaluator.js:

(Evaluator.prototype.visitBoolLiteral):
(Evaluator.prototype.visitLogicalNot):

• WebGPUShadingLanguageRI/Func.js:

(Func):
(Func.prototype.get isCast):
(Func.prototype.toDeclString):

• WebGPUShadingLanguageRI/FuncDef.js:

(FuncDef):
(FuncDef.prototype.get body):
(FuncDef.prototype.rewrite):

• WebGPUShadingLanguageRI/Intrinsics.js:

(Intrinsics):

• WebGPUShadingLanguageRI/Lexer.js:

(Lexer.prototype.next):
(Lexer):

• WebGPUShadingLanguageRI/LogicalNot.js: Copied from Tools/WebGPUShadingLanguageRI/NativeFunc.js.

(LogicalNot):
(LogicalNot.prototype.get operand):
(LogicalNot.prototype.toString):

• WebGPUShadingLanguageRI/NativeFunc.js:

(NativeFunc):

• WebGPUShadingLanguageRI/Parse.js:

(parseTerm):
(parsePossiblePrefix):
(parsePossibleRelationalEquality):
(parseFuncName):
(parseOperatorFuncDefValues):
(parseNonOperatorFuncDefValues):
(parseGenericFuncDefValues):
(parseFuncDecl):
(parseProtocolFuncDecl):
(parseFuncDef):
(parseNative):
(parse):

• WebGPUShadingLanguageRI/Rewriter.js:

(Rewriter.prototype.visitBoolLiteral):
(Rewriter.prototype.visitLogicalNot):
(Rewriter):

• WebGPUShadingLanguageRI/StandardLibrary.js:
• WebGPUShadingLanguageRI/Test.html:
• WebGPUShadingLanguageRI/Test.js:

(makeUInt):
(makeBool):
(checkUInt):
(checkBool):
(TEST_literalBool):
(TEST_identityBool):
(TEST_intSimpleMath):
(TEST_uintSimpleMath):
(TEST_equality):
(TEST_logicalNegation):
(TEST_notEquality):
(TEST_equalityTypeFailure):
(TEST_add1): Deleted.

• WebGPUShadingLanguageRI/TypeDefResolver.js:

(TypeDefResolver.prototype.visitFuncDef):

• WebGPUShadingLanguageRI/Visitor.js:

(Visitor.prototype.visitBoolLiteral):
(Visitor.prototype.visitLogicalNot):

2:00 PM Changeset in webkit [221633] by commit-queue@webkit.org

• 5 edits
  2 adds in trunk

Cache Storage Engine should not mix different origin caches
​https://bugs.webkit.org/show_bug.cgi?id=176394

Patch by Youenn Fablet <​youenn@apple.com> on 2017-09-05
Reviewed by Alex Christensen.

Source/WebKit:

• NetworkProcess/cache/CacheStorageEngine.cpp:

(WebKit::CacheStorage::Engine::readCachesFromDisk): Initializing the salt before creating the Caches object
so that its persistency path is correctly computed.

• NetworkProcess/cache/CacheStorageEngineCaches.cpp:

(WebKit::CacheStorage::cachesRootPath): Setting origin as partition string.

LayoutTests:

• http/tests/cache-storage/cache-origins.https-expected.txt: Added.
• http/tests/cache-storage/cache-origins.https.html: Added.
• http/tests/cache-storage/resources/cache-persistency-iframe.html:

1:41 PM Changeset in webkit [221632] by Brent Fulgham

• 4 edits in trunk/Source/WebKit

Use a single network storage session for stateless connections
​https://bugs.webkit.org/show_bug.cgi?id=176386
<rdar://problem/34262148>

Reviewed by Alex Christensen.

Change the name of 'm_dataTaskMapWithoutCredentials' to 'm_dataTaskMapWithoutState'
to reflect that the data tasks do not involve credential or cookie storage. Ditto for
the change from 'm_sessionWIthoutCredentialStorage' to 'm_statelessSession'.

This update should not change behavior, unless some stateless sessions were depending
on cookies to be persistent (which would be a bug!)

• NetworkProcess/cocoa/NetworkDataTaskCocoa.mm:

(WebKit::NetworkDataTaskCocoa::NetworkDataTaskCocoa): Update for new variable names.
(WebKit::NetworkDataTaskCocoa::~NetworkDataTaskCocoa): Ditto.

• NetworkProcess/cocoa/NetworkSessionCocoa.h:
• NetworkProcess/cocoa/NetworkSessionCocoa.mm:

(WebKit::NetworkSessionCocoa::NetworkSessionCocoa): Update the configuration to block
cookies as well.
(WebKit::NetworkSessionCocoa::invalidateAndCancel): Update for new names.
(WebKit::NetworkSessionCocoa::clearCredentials): Ditto.
(WebKit::NetworkSessionCocoa::dataTaskForIdentifier): Ditto.

1:19 PM Changeset in webkit [221631] by pvollan@apple.com

• 2 edits in trunk/LayoutTests

Unskip two tests which was skipped by mistake.

Unreviewed test gardening.

• platform/win/TestExpectations:

12:57 PM Changeset in webkit [221630] by mmaxfield@apple.com

• 4 edits
  2 adds in trunk

Update font selection algorithm to match latest CSS spec
​https://bugs.webkit.org/show_bug.cgi?id=175236

Reviewed by Darin Adler.

Source/WebCore:

The CSS WG tweaked the generalization of the font selection
algorithm between levels 3 and 4. In particular, the behavior
of weights between 400 and 500 works a little differently.

​https://github.com/w3c/csswg-drafts/commit/f6973a21847f1c200ed38bff05dc543cebe1c827

Test: fast/text/variations/font-selection-font-weight.html

• platform/graphics/FontSelectionAlgorithm.cpp:

(WebCore::FontSelectionAlgorithm::weightDistance const):

• platform/graphics/FontSelectionAlgorithm.h:

(WebCore::lowerWeightSearchThreshold):
(WebCore::upperWeightSearchThreshold):
(WebCore::weightSearchThreshold): Deleted.

LayoutTests:

• fast/text/variations/font-selection-font-weight-expected.html: Added.
• fast/text/variations/font-selection-font-weight.html: Added.

12:56 PM Changeset in webkit [221629] by Matt Lewis

• 2 edits in trunk/LayoutTests

Marked media/W3C/video/events/event_progress.html as flaky.
​https://bugs.webkit.org/show_bug.cgi?id=175678

Unreviewed test gardening.

• platform/wk2/TestExpectations:

12:02 PM Changeset in webkit [221628] by pvollan@apple.com

• 2 edits in trunk/Source/WebCore

[Win] Compile errors in pathByAppendingComponents.
​https://bugs.webkit.org/show_bug.cgi?id=176387

Reviewed by Brent Fulgham.

The pathByAppendingComponents function has changed signature.

• platform/win/FileSystemWin.cpp:

(WebCore::pathByAppendingComponents):

11:17 AM Changeset in webkit [221627] by Simon Fraser

• 4 edits in trunk/Source/WebCore

Fix capitalization of scheduleinvalidateStyleAndLayerComposition
​https://bugs.webkit.org/show_bug.cgi?id=176266

Reviewed by Antti Koivisto.

• html/HTMLFrameOwnerElement.cpp:

(WebCore::HTMLFrameOwnerElement::scheduleInvalidateStyleAndLayerComposition):
(WebCore::HTMLFrameOwnerElement::scheduleinvalidateStyleAndLayerComposition): Deleted.

• html/HTMLFrameOwnerElement.h:
• rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::attachRootLayer):
(WebCore::RenderLayerCompositor::detachRootLayer):
(WebCore::RenderLayerCompositor::notifyIFramesOfCompositingChange):

11:15 AM Changeset in webkit [221626] by Matt Lewis

• 13 edits in trunk

Unreviewed, rolling out r221603.

This caused accessibility/mac/select-element-selection-with-
optgroups.html to consistently timeout on macOS

Reverted changeset:

"Fix a few minor problems found while working toward removing
unneeded calls to updateStyle"
​https://bugs.webkit.org/show_bug.cgi?id=176279
​http://trac.webkit.org/changeset/221603

11:08 AM Changeset in webkit [221625] by commit-queue@webkit.org

• 2 edits
  12 adds in trunk/Source/WebKit

[WinCairo] Add Network Process files for wincairo webkit
​https://bugs.webkit.org/show_bug.cgi?id=176069

Patch by Yousuke Kimoto <​yousuke.kimoto@sony.com> on 2017-09-05
Reviewed by Alex Christensen.

• NetworkProcess/Downloads/curl/DownloadCurl.cpp: Added.

(WebKit::Download::resume):
(WebKit::Download::platformDidFinish):
(WebKit::Download::startNetworkLoadWithHandle):
(WebKit::Download::startNetworkLoad):
(WebKit::Download::platformInvalidate):

• NetworkProcess/EntryPoint/win/NetworkProcessMain.cpp: Added.

(main):

• NetworkProcess/curl/NetworkProcessCurl.cpp: Added.

(WebKit::NetworkProcess::platformInitializeNetworkProcess):
(WebKit::NetworkProcess::platformSetURLCacheSize):
(WebKit::NetworkProcess::allowSpecificHTTPSCertificateForHost):
(WebKit::NetworkProcess::clearCacheForAllOrigins):
(WebKit::NetworkProcess::clearDiskCache):
(WebKit::NetworkProcess::platformTerminate):

• NetworkProcess/curl/RemoteNetworkingContextCurl.cpp: Added.

(WebKit::RemoteNetworkingContext::~RemoteNetworkingContext):
(WebKit::RemoteNetworkingContext::isValid const):
(WebKit::RemoteNetworkingContext::ensurePrivateBrowsingSession):
(WebKit::RemoteNetworkingContext::ensureWebsiteDataStoreSession):
(WebKit::RemoteNetworkingContext::storageSession const):
(WebKit::RemoteNetworkingContext::blockedError const):

• NetworkProcess/win/NetworkProcessMainWin.cpp: Added.

(WebKit::NetworkProcessMainWin):

• NetworkProcess/win/NetworkProcessMainWin.h: Added.
• NetworkProcess/win/SystemProxyWin.cpp: Added.

(WindowsSystemProxy::getSystemHttpProxy):
(WindowsSystemProxy::setCurlHttpProxy):
(WindowsSystemProxy::parseProxyString):

• NetworkProcess/win/SystemProxyWin.h: Added.
• PlatformWin.cmake:

10:52 AM Changeset in webkit [221624] by commit-queue@webkit.org

• 18 edits in trunk/Source

Allow retrieving Cache Storage records for a given URL only
​https://bugs.webkit.org/show_bug.cgi?id=176202

Patch by Youenn Fablet <​youenn@apple.com> on 2017-09-05
Reviewed by Alex Christensen.

Source/WebCore:

No observable change of behavior.

Adding a URL parameter to CacheStorageConnection::retrieveRecords.
If given URL is null, all records will be retrieved, which is useful for the keys method.
Other operations only need records that share the same URL (modulo query string and frag id).

• Modules/cache/Cache.cpp:

(WebCore::Cache::matchAll):
(WebCore::Cache::keys):
(WebCore::Cache::retrieveRecords):
(WebCore::Cache::queryCache):

• Modules/cache/Cache.h:
• Modules/cache/CacheStorageConnection.cpp:

(WebCore::CacheStorageConnection::retrieveRecords):

• Modules/cache/CacheStorageConnection.h:

(WebCore::CacheStorageConnection::doRetrieveRecords):

• Modules/cache/WorkerCacheStorageConnection.cpp:

(WebCore::WorkerCacheStorageConnection::doRetrieveRecords):

• Modules/cache/WorkerCacheStorageConnection.h:
• platform/URL.h:

Source/WebKit:

Update CacheStorageEngineCache to store records as a map URL -> Vector of Records.
This allows regular record retrieval to be faster.
Retrieval of all records is less efficient but this should happen less often.

• NetworkProcess/cache/CacheStorageEngine.cpp:

(WebKit::CacheStorage::Engine::retrieveRecords):

• NetworkProcess/cache/CacheStorageEngine.h:
• NetworkProcess/cache/CacheStorageEngineCache.cpp:

(WebKit::CacheStorage::queryCache):
(WebKit::CacheStorage::Cache::retrieveRecords const):
(WebKit::CacheStorage::computeKeyURL):
(WebKit::CacheStorage::Cache::addNewURLRecord):
(WebKit::CacheStorage::Cache::recordsFromURL):
(WebKit::CacheStorage::Cache::recordsFromURL const):
(WebKit::CacheStorage::Cache::put):
(WebKit::CacheStorage::Cache::remove):

• NetworkProcess/cache/CacheStorageEngineCache.h:
• NetworkProcess/cache/CacheStorageEngineConnection.cpp:

(WebKit::CacheStorageEngineConnection::retrieveRecords):

• NetworkProcess/cache/CacheStorageEngineConnection.h:
• NetworkProcess/cache/CacheStorageEngineConnection.messages.in:
• WebProcess/Cache/WebCacheStorageConnection.cpp:

(WebKit::WebCacheStorageConnection::doRetrieveRecords):

• WebProcess/Cache/WebCacheStorageConnection.h:

10:48 AM Changeset in webkit [221623] by commit-queue@webkit.org

• 5 edits in trunk

WebKitTestRunner should set the cache storage directory path
​https://bugs.webkit.org/show_bug.cgi?id=176373

Patch by Youenn Fablet <​youenn@apple.com> on 2017-09-05
Reviewed by Chris Dumez.

Source/WebKit:

• UIProcess/API/C/WKContextConfigurationRef.cpp:

(WKContextConfigurationCopyCacheStorageDirectory):
(WKContextConfigurationSetCacheStorageDirectory):

• UIProcess/API/C/WKContextConfigurationRef.h:

Tools:

• WebKitTestRunner/TestController.cpp:

(WTR::TestController::generateContextConfiguration const):

10:43 AM Changeset in webkit [221622] by commit-queue@webkit.org

• 20 edits
  1 add in trunk

test262: Completion values for control flow do not match the spec
​https://bugs.webkit.org/show_bug.cgi?id=171265

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2017-09-05
Reviewed by Saam Barati.

JSTests:

• stress/completion-value.js:

Condensed test for completion values in top level statements.

• stress/super-get-by-id.js:

ClassDeclaration when evaled no longer produce values. Convert
these to ClassExpressions so they produce the class value.

• ChakraCore/test/GlobalFunctions/evalreturns3.baseline-jsc:

This is a progression for currect spec behavior.

• mozilla/mozilla-tests.yaml:

This test is now outdated, so mark it as failing for that reason.

• test262.yaml:

Passing all "cptn" completion value tests.

Source/JavaScriptCore:

• bytecompiler/BytecodeGenerator.h:

(JSC::BytecodeGenerator::shouldBeConcernedWithCompletionValue):
When we care about having proper completion values (global code
in programs, modules, and eval) insert undefined results for
control flow statements.

• bytecompiler/NodesCodegen.cpp:

(JSC::SourceElements::emitBytecode):
Reduce writing a default undefined value to the completion result to
only once before the last statement we know will produce a value.

(JSC::IfElseNode::emitBytecode):
(JSC::WithNode::emitBytecode):
(JSC::WhileNode::emitBytecode):
(JSC::ForNode::emitBytecode):
(JSC::ForInNode::emitBytecode):
(JSC::ForOfNode::emitBytecode):
(JSC::SwitchNode::emitBytecode):
Insert an undefined to handle cases where code may break out of an
if/else or with statement (break/continue).

(JSC::TryNode::emitBytecode):
Same handling for break cases. Also, finally block statement completion
values are always ignored for the try statement result.

(JSC::ClassDeclNode::emitBytecode):
Class declarations, like function declarations, produce an empty result.

• parser/Nodes.cpp:

(JSC::SourceElements::lastStatement):
(JSC::SourceElements::hasCompletionValue):
(JSC::SourceElements::hasEarlyBreakOrContinue):
(JSC::BlockNode::lastStatement):
(JSC::BlockNode::singleStatement):
(JSC::BlockNode::hasCompletionValue):
(JSC::BlockNode::hasEarlyBreakOrContinue):
(JSC::ScopeNode::singleStatement):
(JSC::ScopeNode::hasCompletionValue):
(JSC::ScopeNode::hasEarlyBreakOrContinue):
The only non-trivial cases need to loop through their list of statements
to determine if this has a completion value or not. Likewise for
determining if there is an early break / continue, meaning a break or
continue statement with no preceding statement that has a completion value.

• parser/Nodes.h:

(JSC::StatementNode::next):
(JSC::StatementNode::hasCompletionValue):
Helper to check if a statement nodes produces a completion value or not.

Tools:

• Scripts/run-jsc-stress-tests:

Include a :failDueToOutdatedOrBadTest to mark failures with justification.

LayoutTests:

• js/eval-throw-return-expected.txt:
• js/kde/completion-expected.txt:
• js/kde/script-tests/completion.js:
• js/script-tests/eval-throw-return.js:
• sputnik/Conformance/12_Statement/12.6_Iteration_Statements/12.6.3_The_for_Statement/S12.6.3_A9-expected.txt:
• sputnik/Conformance/12_Statement/12.6_Iteration_Statements/12.6.3_The_for_Statement/S12.6.3_A9.1-expected.txt:

Rebaseline expectations. These are all outdated. In fact the sputnik
tests were imported into test262 and modified for ES2015.

• js/script-tests/function-toString-vs-name.js:

ClassDeclarations on their own don't produce a value. So output
the class value so the test behaves as expected.

10:36 AM Changeset in webkit [221621] by achristensen@apple.com

• 11 edits in trunk

Add WKUIDelegatePrivate equivalent of WKPageUIClient's unavailablePluginButtonClicked
​https://bugs.webkit.org/show_bug.cgi?id=176274
<rdar://problem/29270035>

Reviewed by Darin Adler.

Source/WebKit:

• UIProcess/API/APIUIClient.h:

(API::UIClient::unavailablePluginButtonClicked):

• UIProcess/API/C/WKPage.cpp:

(WKPageSetPageUIClient):

• UIProcess/API/Cocoa/WKPreferences.mm:

(-[WKPreferences _setPluginsEnabled:]):
(-[WKPreferences _pluginsEnabled]):

• UIProcess/API/Cocoa/WKPreferencesPrivate.h:
• UIProcess/API/Cocoa/WKUIDelegatePrivate.h:
• UIProcess/Cocoa/UIDelegate.h:
• UIProcess/Cocoa/UIDelegate.mm:

(WebKit::UIDelegate::setDelegate):
(WebKit::toWKPluginUnavailabilityReason):
(WebKit::UIDelegate::UIClient::unavailablePluginButtonClicked):

• UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::unavailablePluginButtonClicked):

Tools:

• TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:

(-[PluginDelegate _webView:unavailablePluginButtonClickedWithReason:pluginInfo:]):
(TEST):

10:33 AM Changeset in webkit [221620] by achristensen@apple.com

• 6 edits in trunk/Source/WebKit

Allow classes to have modern and legacy decoders to aid transition
​https://bugs.webkit.org/show_bug.cgi?id=176186

Reviewed by Zan Dobersek.

To illustrate this, I made legacy and modern decoders to WTF::String and transitioned one String decoder.

• Platform/IPC/ArgumentCoder.h:
• Platform/IPC/ArgumentCoders.cpp:

(IPC::ArgumentCoder<String>::decode):

• Platform/IPC/ArgumentCoders.h:
• Platform/IPC/Decoder.h:
• Shared/WebPageCreationParameters.cpp:

(WebKit::WebPageCreationParameters::decode):

10:19 AM Changeset in webkit [221619] by jmarcell@apple.com

• 17 edits in branches/safari-604-branch

Cherry-pick r221444. rdar://problem/34215746

9:44 AM Changeset in webkit [221618] by commit-queue@webkit.org

• 3 edits in trunk/LayoutTests

[WPE] Test gardening.
​https://bugs.webkit.org/show_bug.cgi?id=176370

Unreviewed test gardening.

Patch by Charlie Turner <​cturner@igalia.com> on 2017-09-05

• platform/wpe/TestExpectations: Updated accordingly.
• platform/wpe/js/dom/global-constructors-attributes-expected.txt: Rebaselined

8:52 AM Changeset in webkit [221617] by timothy_horton@apple.com

• 8 edits
  17 deletes in trunk/Source

Remove some unused bits of code and resources
​https://bugs.webkit.org/show_bug.cgi?id=176275

Reviewed by Dan Bernstein.

Source/WebCore:

No new tests, just removing things.

• Resources/textAreaResizeCorner.tiff: Removed.
• Resources/missingImage.tiff: Removed.

These files have PNG versions that include more resolutions.

• Resources/hScrollControl_left.png: Removed.
• Resources/hScrollControl_middle.png: Removed.
• Resources/hScrollControl_right.png: Removed.
• Resources/vScrollControl_bottom.png: Removed.
• Resources/vScrollControl_middle.png: Removed.
• Resources/vScrollControl_top.png: Removed.
• Resources/decrementArrow.tiff: Removed.
• Resources/incrementArrow.tiff: Removed.
• Resources/markedLeft.png: Removed.
• Resources/markedMiddle.png: Removed.
• Resources/markedRight.png: Removed.

These were added in r161638 as part of the iOS upstreaming, but were
unused even then.

• Resources/inputSpeech.tiff: Removed.

The feature this image was for was removed in r172259; the PNG version
of this image was removed in r172384.

• WebCore.xcodeproj/project.pbxproj:
• platform/ios/FileSystemIOS.h: Removed.
• platform/ios/FileSystemIOS.mm: Removed.

Remove FileSystemIOS; one function is unused, the other is not at all
iOS-specific and can be folded into FileSystemCocoa.

• platform/FileSystem.h:
• platform/cocoa/FileSystemCocoa.mm:

(WebCore::createTemporaryDirectory):
Move this in from FileSystemIOS.

• platform/PlatformEvent.cpp: Removed.

Remove this unused file.

• platform/ios/QuickLook.mm:
• platform/ios/WebItemProviderPasteboard.mm:

Include FileSystem instead of FileSystemIOS.

Source/WebKitLegacy/mac:

• Misc/WebNSFileManagerExtras.mm:

Include FileSystem instead of FileSystemIOS.

8:44 AM Changeset in webkit [221616] by pvollan@apple.com

• 2 edits in trunk/LayoutTests

Skip service workers tests on Windows.

Unreviewed test gardening.

• platform/win/TestExpectations:

7:01 AM WebKitGTK/Gardening/Calendar edited by cturner@igalia.com

(diff)

6:58 AM WebKitGTK/Gardening/Calendar edited by cturner@igalia.com

(diff)

6:38 AM Changeset in webkit [221615] by commit-queue@webkit.org

• 8 edits
  4 adds in trunk

Use TilesBacking for iframes when async frame scrolling is enabled
​https://bugs.webkit.org/show_bug.cgi?id=173644

Patch by Frederic Wang <​fwang@igalia.com> on 2017-09-05
Reviewed by Simon Fraser.

Source/WebCore:

This patch adds creation of TilesBacking for non-main frames when async frame scrolling is
enabled. RenderLayerBacking::m_isMainFrameLayerWithTiledBacking is also renamed to reflect
that tiled backing is not exclusive to the main frame. More adjustments might be needed for
non-main frames and will be handled in follow-up commits.

Test: compositing/tiling/tiled-drawing-async-frame-scrolling.html

• rendering/RenderLayerBacking.cpp: Rename m_isMainFrameLayerWithTiledBacking
• rendering/RenderLayerBacking.h: Rename isMainFrameLayerWithTiledBacking and

m_isMainFrameLayerWithTiledBacking.

• rendering/RenderLayerCompositor.cpp: Use isFrameLayerWithTiledBacking

Source/WebKit:

This patch adds creation of TilesBacking for non-main frames when async frame scrolling is
enabled. RenderLayerBacking::m_isMainFrameLayerWithTiledBacking is also renamed to reflect
that tiled backing is not exclusive to the main frame. More adjustments might be needed for
non-main frames and will be handled in follow-up commits.

• WebProcess/WebPage/RemoteLayerTree/RemoteLayerTreeDrawingArea.mm:

(WebKit::RemoteLayerTreeDrawingArea::shouldUseTiledBackingForFrameView): Also use tiled
backing when asyncFrameScrollingEnabled is true.

• WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:

(WebKit::TiledCoreAnimationDrawingArea::shouldUseTiledBackingForFrameView): Ditto.

LayoutTests:

This patch adds a test to verify the graphic layers created for frames when async scrolling
is enabled. On iOS and macOS and WK2, new layers appear for the tiled content, scroll bars...

• compositing/tiling/tiled-drawing-async-frame-scrolling-expected.txt: Added.
• compositing/tiling/tiled-drawing-async-frame-scrolling.html: Added.
• platform/ios-wk2/compositing/tiling/tiled-drawing-async-frame-scrolling-expected.txt: Added.
• platform/mac-wk2/compositing/tiling/tiled-drawing-async-frame-scrolling-expected.txt: Added.

4:31 AM Changeset in webkit [221614] by zandobersek@gmail.com

• 2 edits in trunk/Source/WebCore

HTMLMediaElement: attach any existing EME CDMInstance in mediaEngineWasUpdated()
​https://bugs.webkit.org/show_bug.cgi?id=176354

Reviewed by Xabier Rodriguez-Calvar.

It's common for MediaKeys to be set on an HTMLMediaElement object before
any resource is loaded for that element, meaning no underlying MediaPlayer
exists at that point. In order to not stall the pipeline when encrypted
content is finally loaded, the CDMInstance object of the current MediaKeys
set on this element should be attached in mediaEngineWasUpdated() that's
called whenever the underlying MediaPlayerPrivate object is replaced.

• html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::mediaEngineWasUpdated):

4:29 AM Changeset in webkit [221613] by zandobersek@gmail.com

• 2 edits in trunk/Source/WebCore

[EME] HTMLMediaElement: setMediaKeys() should attach CDMInstance from the arriving MediaKeys
​https://bugs.webkit.org/show_bug.cgi?id=176352

Reviewed by Xabier Rodriguez-Calvar.

In HTMLMediaElement::setMediaKeys(), use the incoming MediaKeys object
to retrieve the CDMInstance that is then attached to the current
MediaPlayer, if any.

Covered by existing W3C tests that focus on multi-key use cases.

• html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::setMediaKeys):

1:20 AM Changeset in webkit [221612] by commit-queue@webkit.org

• 4 edits in trunk/Source

[Win] Fix the wincairo build after r221558 and r221583
​https://bugs.webkit.org/show_bug.cgi?id=176353

Patch by Yoshiaki Jitsukawa <​Yoshiaki.Jitsukawa@sony.com> on 2017-09-05
Reviewed by Yusuke Suzuki.

Source/WebCore:

• platform/win/FileSystemWin.cpp:

(WebCore::isSymbolicLink): Fix a "missing type specifier" error
(WebCore::findDataToFileMetadata): Fix a narrowing convertion error

Source/WTF:

• wtf/Assertions.cpp:

1:17 AM Changeset in webkit [221611] by commit-queue@webkit.org

• 3 edits in trunk/PerformanceTests

Speedometer 2.0: Add dummy node to notify app is ready for Backbone suite
​https://bugs.webkit.org/show_bug.cgi?id=176142

Patch by Shiyu Zhang <​shiyu.zhang@intel.com> on 2017-09-05
Reviewed by Ryosuke Niwa.

Create a dummy node to notify that app is ready for Backbone suite. It prevents Speedometer injecting items before app.js is loaded.

• Speedometer/resources/tests.js:

(Suites.push.prepare):

• Speedometer/resources/todomvc/architecture-examples/backbone/js/app.js:

12:59 AM WebKitGTK/2.16.x edited by tpopela@redhat.com

(diff)

12:39 AM Changeset in webkit [221610] by Carlos Garcia Campos

• 15 edits
  1 copy
  1 add
  1 delete in trunk/Source/WebKit

[GTK] Rename PLUGIN_ARCHITECTURE(X11) as PLUGIN_ARCHITECTURE(UNIX)
​https://bugs.webkit.org/show_bug.cgi?id=176330

Reviewed by Michael Catanzaro.

It's no longer X11 specific since it's also used in Wayland when the X11 target is enabled. It should be renamed
as UNIX and make it available when building the wayland target even if the X11 on is disabled.

• PlatformGTK.cmake:
• PlatformWPE.cmake:
• PluginProcess/unix/PluginProcessMainUnix.cpp:
• Shared/Plugins/Netscape/NetscapePluginModule.cpp:

(WebKit::NetscapePluginModule::tryLoad):

• Shared/Plugins/Netscape/NetscapePluginModule.h:
• Shared/Plugins/Netscape/unix/NetscapePluginModuleUnix.cpp: Renamed from Source/WebKit/Shared/Plugins/Netscape/x11/NetscapePluginModuleX11.cpp.
• UIProcess/Plugins/PluginProcessProxy.h:
• UIProcess/Plugins/gtk/PluginInfoCache.cpp:

(WebKit::PluginInfoCache::getPluginInfo):
(WebKit::PluginInfoCache::updatePluginInfo):

• UIProcess/Plugins/unix/PluginProcessProxyUnix.cpp:

(WebKit::PluginProcessProxy::scanPlugin):

• WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp:

(WebKit::NPN_InvalidateRect):

• WebProcess/Plugins/Netscape/NetscapePlugin.cpp:

(WebKit::NetscapePlugin::initialize):
(WebKit::NetscapePlugin::destroy):
(WebKit::NetscapePlugin::geometryDidChange):

• WebProcess/Plugins/Netscape/NetscapePlugin.h:
• WebProcess/Plugins/Netscape/unix/NetscapePluginUnix.cpp:
• WebProcess/Plugins/Netscape/unix/NetscapePluginUnix.h:
• config.h:

12:19 AM WebKitGTK/2.18.x edited by calvaris@igalia.com

(diff)

12:16 AM Changeset in webkit [221609] by Carlos Garcia Campos

• 26 edits
  1 copy
  1 add
  1 delete in trunk

[GTK] Wrong use of PLUGIN_ARCHITECTURE(X11) in several places
​https://bugs.webkit.org/show_bug.cgi?id=176329

Reviewed by Michael Catanzaro.

.:

Only define MOZ_X11 if X11 target is enabled and always define XP_UNIX if NETSCAPE_PLUGIN_API is enabled.

• Source/cmake/OptionsGTK.cmake:

Source/WebKit:

We are using PLUGIN_ARCHITECTURE(X11) in several places where we should actually be using PLATFORM(X11). This is
confusing because PLUGIN_ARCHITECTURE(X11) is no longer specific to X11, it will be renamed as UNIX in a follow
up patch. Because of this we only support plugins in Wayland when building with both X11 and Wayland targets
enabled.

• PluginProcess/PluginControllerProxy.cpp:
• PluginProcess/PluginControllerProxy.h:
• PluginProcess/unix/PluginProcessMainUnix.cpp:
• Shared/Plugins/Netscape/x11/NetscapePluginModuleX11.cpp:

(WebKit::NetscapePluginModule::determineQuirks):

• Shared/Plugins/PluginQuirks.h:
• UIProcess/WebPageProxy.h:
• UIProcess/WebPageProxy.messages.in:
• UIProcess/gtk/WebPageProxyGtk.cpp:
• WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp:

(WebKit::NPN_GetValue):

• WebProcess/Plugins/Netscape/NetscapePlugin.cpp:

(WebKit::NetscapePlugin::shouldLoadSrcURL):
(WebKit::NetscapePlugin::initialize):

• WebProcess/Plugins/Netscape/unix/NetscapePluginUnix.cpp:

(WebKit::NetscapePlugin::platformHandleMouseEvent):

• WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp:
• WebProcess/Plugins/Netscape/x11/NetscapePluginX11.h:
• WebProcess/Plugins/PluginController.h:
• WebProcess/Plugins/PluginProxy.cpp:
• WebProcess/Plugins/PluginProxy.h:
• WebProcess/Plugins/PluginProxy.messages.in:
• WebProcess/Plugins/PluginView.cpp:
• WebProcess/Plugins/PluginView.h:

Tools:

• CMakeLists.txt: Build TestNetscapePlugIn when NETSCAPE_PLUGIN_API is enabled and only link to X11 libraries

when building the X11 target.

• DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
• DumpRenderTree/TestNetscapePlugIn/Tests/unix/CallInvalidateRectWithNullNPPArgument.cpp: Renamed from Tools/DumpRenderTree/TestNetscapePlugIn/Tests/x11/CallInvalidateRectWithNullNPPArgument.cpp.
• DumpRenderTree/TestNetscapePlugIn/main.cpp:

(NP_Initialize):
(NPP_HandleEvent):
(NPP_GetValue):