Timeline
Sep 7, 2017:
- 11:31 PM Changeset in webkit [221779] by
-
- 2 edits in trunk/Source/WebKit
[GTK][WPE] UI process crash in WebBackForwardList::restoreFromState
https://bugs.webkit.org/show_bug.cgi?id=176303
Reviewed by Michael Catanzaro.
Ensure the current index provided by the session state is not out of actual item list bounds. This is a bug in
the session state decoder, but WebBackForwardList::backForwardListState() is already doing the check and using
the last item index instead, so it's not easy to know where the actual problem is. In any case we should
still protect the decoder.
- UIProcess/API/glib/WebKitWebViewSessionState.cpp:
(decodeSessionState):
- 11:21 PM Changeset in webkit [221778] by
-
- 8 edits2 adds in trunk
WebKit should claim that it can show responses for a broader range of JSON MIMETypes
https://bugs.webkit.org/show_bug.cgi?id=176252
<rdar://problem/34212885>
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2017-09-07
Reviewed by Ryosuke Niwa.
Source/WebCore:
- platform/MIMETypeRegistry.h:
- platform/MIMETypeRegistry.cpp:
(WebCore::MIMETypeRegistry::canShowMIMEType):
Extend this to support JavaScript and JSON MIMETypes that WebKit
knows how to treat as text.
Tools:
- TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
- TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm: Added.
(-[WKNavigationResponseTestNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
(-[WKNavigationResponseTestNavigationDelegate webView:didCommitNavigation:]):
(-[WKNavigationResponseTestSchemeHandler webView:startURLSchemeTask:]):
(-[WKNavigationResponseTestSchemeHandler webView:stopURLSchemeTask:]):
(TEST):
Test for canShowMIMEType with multiple JSON mime types and a garbage mime type.
Previously canShowMIMEType would have been YES for "application/json" but
NO for "application/vnd.api+json". Now it shows YES for both.
- TestWebKitAPI/PlatformGTK.cmake:
- TestWebKitAPI/PlatformWPE.cmake:
- TestWebKitAPI/PlatformWin.cmake:
- TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
- TestWebKitAPI/Tests/WebCore/MIMETypeRegistry.cpp: Added.
(TestWebKitAPI::TEST):
Tests for MIMETypeRegistry's dynamic JSON mime type detection.
- 7:58 PM Changeset in webkit [221777] by
-
- 1 edit15 adds in trunk/Tools
Add Live PLT implemented with WebDriver
https://bugs.webkit.org/show_bug.cgi?id=176436
Patch by Matthew Stewart <matthew_r_stewart@apple.com> on 2017-09-07
Reviewed by Stephanie Lewis.
Adds a new PLT that runs on live websites.
- Scripts/run-webdriver-plt.py: Added.
(parse_args):
(start):
(make_suites):
(main):
- Scripts/webkitpy/webdriver_plt/init.py: Added.
- Scripts/webkitpy/webdriver_plt/liveplt.py: Added.
(PageLoadTest):
(PageLoadTest.init):
(PageLoadTest.start):
(PageLoadTest.run_suite):
(PageLoadTest._get_driver_for_browser):
(PageLoadTest._setup_browser_window):
(PageLoadTest.run_one_test):
(PageLoadTest.get_results):
- Scripts/webkitpy/webdriver_plt/pltresults.py: Added.
(PLTResults):
(PLTResults.init):
(PLTResults.add):
(PLTResults.add_timing_result):
(PLTResults.mean):
(PLTResults.geometric_mean):
(PLTResults.mean_coef_variance):
(PLTResults.print_results):
(PLTResults.print_url_results):
(PLTResults._format_time):
- Scripts/webkitpy/webdriver_plt/suites/init.py: Added.
- Scripts/webkitpy/webdriver_plt/suites/arabic.suite: Added.
- Scripts/webkitpy/webdriver_plt/suites/cjk.suite: Added.
- Scripts/webkitpy/webdriver_plt/suites/news.suite: Added.
- Scripts/webkitpy/webdriver_plt/suites/search.suite: Added.
- Scripts/webkitpy/webdriver_plt/suites/shopping.suite: Added.
- Scripts/webkitpy/webdriver_plt/suites/social.suite: Added.
- Scripts/webkitpy/webdriver_plt/suites/suite.py: Added.
(Suite):
(Suite.init):
(Suite.get_available_suites):
- Scripts/webkitpy/webdriver_plt/urlresults.py: Added.
(URLResults):
(URLResults.init):
(URLResults.add):
(URLResults.mean):
(URLResults.coef_variance):
(URLResults.print_results):
(URLResults._format_time):
- 7:57 PM Changeset in webkit [221776] by
-
- 12 edits1 copy in trunk/Tools
Add "if" statements to WSL
https://bugs.webkit.org/show_bug.cgi?id=176294
Reviewed by Filip Pizlo.
Fairly straightforward implementation. ReturnChecker only returns true iff there is an else block,
and both the if body and the else body recursively return true.
In order to accept both syntaxes:
if (foo)
bar;
... and ...
if (foo) {
bar;
}
This patch lets parseStatement() call parseBlock(). This means that the following is valid:
int x = 7;
if (foo) {
int x = 8;
x is 8 here!
}
x is 7 here!
This production means that these blocks don't require "if" statements, so you can just have:
int foo() {
int x = 7;
{
int x = 8;
x is 8 here!
}
x is 7 here!
}
However, this patch doesn't touch the following use-case:
if (int x = bar()) {
use x here
}
- WebGPUShadingLanguageRI/All.js:
- WebGPUShadingLanguageRI/Checker.js:
- WebGPUShadingLanguageRI/Evaluator.js:
(Evaluator.prototype.visitIfStatement):
- WebGPUShadingLanguageRI/IfStatement.js: Copied from Tools/WebGPUShadingLanguageRI/TypeDef.js.
(IfStatement):
(IfStatement.prototype.get origin):
(IfStatement.prototype.get conditional):
(IfStatement.prototype.get body):
(IfStatement.prototype.get elseBody):
(IfStatement.prototype.toString):
- WebGPUShadingLanguageRI/NameResolver.js:
(NameResolver.prototype.visitIfStatement):
- WebGPUShadingLanguageRI/Parse.js:
(parseTypeParameters):
(parseIfStatement):
(parseStatement):
- WebGPUShadingLanguageRI/ReturnChecker.js:
(ReturnChecker.prototype.visitIfStatement):
- WebGPUShadingLanguageRI/Rewriter.js:
(Rewriter.prototype.visitIfStatement):
(Rewriter):
- WebGPUShadingLanguageRI/Test.html:
- WebGPUShadingLanguageRI/Test.js:
(TEST_variableShadowing):
(TEST_ifStatement):
(TEST_ifElseStatement):
(TEST_ifElseIfStatement):
(TEST_ifElseIfElseStatement):
(TEST_returnIf):
(TEST_protocolMonoPolySigDoublePolyDefExplicit): Deleted.
- WebGPUShadingLanguageRI/TypeDef.js:
(TypeDef.prototype.toString):
(TypeDef):
- WebGPUShadingLanguageRI/Visitor.js:
(Visitor.prototype.visitIfStatement):
- 6:49 PM Changeset in webkit [221775] by
-
- 1 edit in trunk/Tools/ChangeLog
Test commit after server upgrade from subversion 1.9.5 to 1.9.7
- 6:14 PM Changeset in webkit [221774] by
-
- 35 edits1 add in trunk/Source/JavaScriptCore
Use JIT probes for DFG OSR exit.
https://bugs.webkit.org/show_bug.cgi?id=175144
<rdar://problem/33437050>
Reviewed by Saam Barati.
This patch does the following:
- Replaces osrExitGenerationThunkGenerator() with osrExitThunkGenerator(). While osrExitGenerationThunkGenerator() generates a thunk that compiles a unique OSR offramp for each DFG OSR exit site, osrExitThunkGenerator() generates a thunk that just executes the OSR exit.
The osrExitThunkGenerator() generated thunk works by using a single JIT probe
to call OSRExit::executeOSRExit(). The JIT probe takes care of preserving
CPU registers, and providing the Probe::Stack mechanism for modifying the
stack frame.
OSRExit::executeOSRExit() replaces OSRExit::compileOSRExit() and
OSRExit::compileExit(). It is basically a re-write of those functions to
execute the OSR exit work instead of compiling code to execute the work.
As a result, we get the following savings:
- no more OSR exit ramp compilation time.
- no use of JIT executable memory for storing each unique OSR exit ramp.
On the negative side, we incur these costs:
- the OSRExit::executeOSRExit() ramp may be a little slower than the compiled version of the ramp. However, OSR exits are rare. Hence, this small difference should not matter much. It is also offset by the savings from (a).
- the Probe::Stack allocates 1K pages for memory for buffering stack modifcations. The number of these pages depends on the span of stack memory that the OSR exit ramp reads from and writes to. Since the OSR exit ramp tends to only modify values in the current DFG frame and the current VMEntryRecord, the number of pages tends to only be 1 or 2.
Using the jsc tests as a workload, the vast majority of tests that do OSR
exit, uses 3 or less 1K pages (with the overwhelming number using just 1 page).
A few tests that are pathological uses up to 14 pages, and one particularly
bad test (function-apply-many-args.js) uses 513 pages.
Similar to the old code, the OSR exit ramp still has 2 parts: 1 part that is
only executed once to compute some values for the exit site that is used by
all exit operations from that site, and a 2nd part to execute the exit. The
1st part is protected by a checking if exit.exitState has already been
initialized. The computed values are cached in exit.exitState.
Because the OSR exit thunk no longer compiles an OSR exit off-ramp, we no
longer need the facility to patch the site that jumps to the OSR exit ramp.
The DFG::JITCompiler has been modified to remove this patching code.
- Fixed the bottom most Probe::Context and Probe::Stack get/set methods to use std::memcpy to avoid strict aliasing issues.
Also optimized the implementation of Probe::Stack::physicalAddressFor().
- Miscellaneous convenience methods added to make the Probe::Context easier of use.
- Added a Probe::Frame class that makes it easier to get/set operands and arguments in a given frame using the deferred write properties of the Probe::Stack. Probe::Frame makes it easier to do some of the recovery work in the OSR exit ramp.
- Cloned or converted some functions needed by the OSR exit ramp. The original JIT versions of these functions are still left in place because they are still needed for FTL OSR exit. A FIXME comment has been added to remove them later. These functions include:
DFGOSRExitCompilerCommon.cpp's handleExitCounts() ==>
CodeBlock::updateOSRExitCounterAndCheckIfNeedToReoptimize()
DFGOSRExitCompilerCommon.cpp's reifyInlinedCallFrames() ==>
DFGOSRExit.cpp's reifyInlinedCallFrames()
DFGOSRExitCompilerCommon.cpp's adjustAndJumpToTarget() ==>
DFGOSRExit.cpp's adjustAndJumpToTarget()
MethodOfGettingAValueProfile::emitReportValue() ==>
MethodOfGettingAValueProfile::reportValue()
DFGOperations.cpp's operationCreateDirectArgumentsDuringExit() ==>
DFGOSRExit.cpp's createDirectArgumentsDuringExit()
DFGOperations.cpp's operationCreateClonedArgumentsDuringExit() ==>
DFGOSRExit.cpp's createClonedArgumentsDuringExit()
- JavaScriptCore.xcodeproj/project.pbxproj:
- assembler/MacroAssembler.cpp:
(JSC::stdFunctionCallback):
- assembler/MacroAssemblerPrinter.cpp:
(JSC::Printer::printCallback):
- assembler/ProbeContext.h:
(JSC::Probe::CPUState::gpr const):
(JSC::Probe::CPUState::spr const):
(JSC::Probe::Context::Context):
(JSC::Probe::Context::arg):
(JSC::Probe::Context::gpr):
(JSC::Probe::Context::spr):
(JSC::Probe::Context::fpr):
(JSC::Probe::Context::gprName):
(JSC::Probe::Context::sprName):
(JSC::Probe::Context::fprName):
(JSC::Probe::Context::gpr const):
(JSC::Probe::Context::spr const):
(JSC::Probe::Context::fpr const):
(JSC::Probe::Context::pc):
(JSC::Probe::Context::fp):
(JSC::Probe::Context::sp):
(JSC::Probe:: const): Deleted.
- assembler/ProbeFrame.h: Added.
(JSC::Probe::Frame::Frame):
(JSC::Probe::Frame::getArgument):
(JSC::Probe::Frame::getOperand):
(JSC::Probe::Frame::get):
(JSC::Probe::Frame::setArgument):
(JSC::Probe::Frame::setOperand):
(JSC::Probe::Frame::set):
- assembler/ProbeStack.cpp:
(JSC::Probe::Page::Page):
- assembler/ProbeStack.h:
(JSC::Probe::Page::get):
(JSC::Probe::Page::set):
(JSC::Probe::Page::physicalAddressFor):
(JSC::Probe::Stack::lowWatermark):
(JSC::Probe::Stack::get):
(JSC::Probe::Stack::set):
- bytecode/ArithProfile.cpp:
- bytecode/ArithProfile.h:
- bytecode/ArrayProfile.h:
(JSC::ArrayProfile::observeArrayMode):
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::updateOSRExitCounterAndCheckIfNeedToReoptimize):
- bytecode/CodeBlock.h:
(JSC::CodeBlock::addressOfOSRExitCounter): Deleted.
- bytecode/ExecutionCounter.h:
(JSC::ExecutionCounter::hasCrossedThreshold const):
(JSC::ExecutionCounter::setNewThresholdForOSRExit):
- bytecode/MethodOfGettingAValueProfile.cpp:
(JSC::MethodOfGettingAValueProfile::reportValue):
- bytecode/MethodOfGettingAValueProfile.h:
- dfg/DFGDriver.cpp:
(JSC::DFG::compileImpl):
- dfg/DFGJITCode.cpp:
(JSC::DFG::JITCode::findPC): Deleted.
- dfg/DFGJITCode.h:
- dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::linkOSRExits):
(JSC::DFG::JITCompiler::link):
- dfg/DFGOSRExit.cpp:
(JSC::DFG::jsValueFor):
(JSC::DFG::restoreCalleeSavesFor):
(JSC::DFG::saveCalleeSavesFor):
(JSC::DFG::restoreCalleeSavesFromVMEntryFrameCalleeSavesBuffer):
(JSC::DFG::copyCalleeSavesToVMEntryFrameCalleeSavesBuffer):
(JSC::DFG::saveOrCopyCalleeSavesFor):
(JSC::DFG::createDirectArgumentsDuringExit):
(JSC::DFG::createClonedArgumentsDuringExit):
(JSC::DFG::OSRExit::OSRExit):
(JSC::DFG::emitRestoreArguments):
(JSC::DFG::OSRExit::executeOSRExit):
(JSC::DFG::reifyInlinedCallFrames):
(JSC::DFG::adjustAndJumpToTarget):
(JSC::DFG::printOSRExit):
(JSC::DFG::OSRExit::setPatchableCodeOffset): Deleted.
(JSC::DFG::OSRExit::getPatchableCodeOffsetAsJump const): Deleted.
(JSC::DFG::OSRExit::codeLocationForRepatch const): Deleted.
(JSC::DFG::OSRExit::correctJump): Deleted.
(JSC::DFG::OSRExit::emitRestoreArguments): Deleted.
(JSC::DFG::OSRExit::compileOSRExit): Deleted.
(JSC::DFG::OSRExit::compileExit): Deleted.
(JSC::DFG::OSRExit::debugOperationPrintSpeculationFailure): Deleted.
- dfg/DFGOSRExit.h:
(JSC::DFG::OSRExitState::OSRExitState):
(JSC::DFG::OSRExit::considerAddingAsFrequentExitSite):
- dfg/DFGOSRExitCompilerCommon.cpp:
- dfg/DFGOSRExitCompilerCommon.h:
- dfg/DFGOperations.cpp:
- dfg/DFGOperations.h:
- dfg/DFGThunks.cpp:
(JSC::DFG::osrExitThunkGenerator):
(JSC::DFG::osrExitGenerationThunkGenerator): Deleted.
- dfg/DFGThunks.h:
- jit/AssemblyHelpers.cpp:
(JSC::AssemblyHelpers::debugCall): Deleted.
- jit/AssemblyHelpers.h:
- jit/JITOperations.cpp:
- jit/JITOperations.h:
- profiler/ProfilerOSRExit.h:
(JSC::Profiler::OSRExit::incCount):
- runtime/JSCJSValue.h:
- runtime/JSCJSValueInlines.h:
- runtime/VM.h:
- 5:24 PM Changeset in webkit [221773] by
-
- 11 edits in trunk/Source
[Mac] Upstream QTKit-related WebKitSystemInterface functions
https://bugs.webkit.org/show_bug.cgi?id=176472
Reviewed by Eric Carlson.
Source/WebCore:
- platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
(WebCore::disableComponentsOnce):
(WebCore::MediaPlayerPrivateQTKit::createQTMovie):
(WebCore::MediaPlayerPrivateQTKit::hasClosedCaptions const):
(WebCore::MediaPlayerPrivateQTKit::setClosedCaptionsVisible):
(WebCore::selectPreferredAlternateTrackForMediaType):
(WebCore::selectPreferredAlternates):
(WebCore::MediaPlayerPrivateQTKit::updateStates):
(WebCore::mimeModernTypesCache):
(WebCore::MediaPlayerPrivateQTKit::originsInMediaCache):
(WebCore::MediaPlayerPrivateQTKit::clearMediaCache):
(WebCore::MediaPlayerPrivateQTKit::clearMediaCacheForOrigins):
(WebCore::MediaPlayerPrivateQTKit::hasSingleSecurityOrigin const):
(WebCore::MediaPlayerPrivateQTKit::movieLoadType const):
(WebCore::MediaPlayerPrivateQTKit::canSaveMediaData const):
- platform/mac/WebCoreSystemInterface.h:
- platform/mac/WebCoreSystemInterface.mm:
- platform/mac/WebVideoFullscreenHUDWindowController.mm:
(createMediaUIControl):
(createControlWithMediaUIControlType):
(createMediaUIBackgroundView):
(-[WebVideoFullscreenHUDWindowController windowDidLoad]):
Source/WebCore/PAL:
- pal/spi/mac/QTKitSPI.h:
Source/WebKit:
- WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:
(InitWebCoreSystemInterface):
Source/WebKitLegacy/mac:
- WebCoreSupport/WebSystemInterface.mm:
(InitWebCoreSystemInterface):
- 4:23 PM Changeset in webkit [221772] by
-
- 24 edits in trunk
Align FetchResponse and FetchRequest body handling
https://bugs.webkit.org/show_bug.cgi?id=176539
Patch by Youenn Fablet <youenn@apple.com> on 2017-09-07
Reviewed by Alex Christensen.
LayoutTests/imported/w3c:
- web-platform-tests/fetch/api/request/request-consume-empty-expected.txt:
- web-platform-tests/fetch/api/request/request-consume-expected.txt:
- web-platform-tests/fetch/api/request/request-idl-expected.txt:
- web-platform-tests/fetch/api/request/request-structure-expected.txt:
- web-platform-tests/fetch/api/response/response-consume-empty-expected.txt:
- web-platform-tests/fetch/api/response/response-consume-expected.txt:
- web-platform-tests/url/urlencoded-parser-expected.txt:
Source/WebCore:
Covered by rebased tests.
Removing most of FetchResponse JS Builtins now that ReadableStream has full support.
Implementing FetchResponse body cloning through ReadableStream.
Cloning a loading FetchResponse still requires to create a ReadableStream for the purpose of teeing.
Moving exposure of the body from FetchResponse to FetchBodyOwner.
This is controlled by a boolean flag set according response tainting.
Moving handling of body ReadableStream consuming from FetchResponse to FetchBodyConsumer.
For that purpose, a loading boolean flag is added to FetchBodyConsumer so that it will resolve consume promises
when loading is finished.
Added support for getting a body in case the request/response body is already consumed.
In that case, a locked ReadableStream is returned.
- Modules/cache/DOMCache.cpp:
(WebCore::DOMCache::doMatch):
(WebCore::DOMCache::matchAll):
- Modules/fetch/FetchBody.h:
(WebCore::FetchBody::loadingBody):
(WebCore::FetchBody::FetchBody):
- Modules/fetch/FetchBody.idl:
- Modules/fetch/FetchBodyConsumer.cpp:
(WebCore::FetchBodyConsumer::resolve):
(WebCore::FetchBodyConsumer::loadingFailed):
(WebCore::FetchBodyConsumer::loadingSucceeded):
- Modules/fetch/FetchBodyConsumer.h:
(WebCore::FetchBodyConsumer::setAsLoading):
- Modules/fetch/FetchBodyOwner.cpp:
(WebCore::FetchBodyOwner::arrayBuffer):
(WebCore::FetchBodyOwner::blob):
(WebCore::FetchBodyOwner::formData):
(WebCore::FetchBodyOwner::json):
(WebCore::FetchBodyOwner::text):
(WebCore::FetchBodyOwner::readableStream):
- Modules/fetch/FetchBodyOwner.h:
(WebCore::FetchBodyOwner::isBodyNullOrOpaque const):
(WebCore::FetchBodyOwner::setBodyAsOpaque):
(WebCore::FetchBodyOwner::isBodyOpaque const):
- Modules/fetch/FetchInternals.js:
(fillFetchHeaders):
- Modules/fetch/FetchResponse.cpp:
(WebCore::FetchResponse::clone):
(WebCore::FetchResponse::fetch):
(WebCore::FetchResponse::BodyLoader::didReceiveResponse):
(WebCore::FetchResponse::setBodyData):
(WebCore::FetchResponse::consumeChunk):
(WebCore::FetchResponse::consumeBodyAsStream):
- Modules/fetch/FetchResponse.h:
- Modules/fetch/FetchResponse.idl:
- Modules/fetch/FetchResponse.js:
(initializeFetchResponse):
- bindings/js/ReadableStream.cpp:
(WebCore::ReadableStream::create):
(WebCore::ReadableStream::lock):
- bindings/js/ReadableStream.h:
- bindings/js/WebCoreBuiltinNames.h:
- 4:18 PM Changeset in webkit [221771] by
-
- 9 edits in trunk/Source/WebKit
Clean up API::UIClient
https://bugs.webkit.org/show_bug.cgi?id=176568
Reviewed by Brady Eidson.
We don't need createNewPage and createNewPageAsync.
An async version can support synchronous delegate calls by just calling the completion handler synchronously.
- UIProcess/API/APIUIClient.h:
(API::UIClient::createNewPage):
(API::UIClient::createNewPageAsync): Deleted.
(API::UIClient::canCreateNewPageAsync): Deleted.
- UIProcess/API/C/WKPage.cpp:
(WKPageSetPageUIClient):
- UIProcess/API/glib/WebKitUIClient.cpp:
- UIProcess/API/glib/WebKitUIClient.h:
- UIProcess/Cocoa/UIDelegate.h:
- UIProcess/Cocoa/UIDelegate.mm:
(WebKit::UIDelegate::UIClient::createNewPage):
(WebKit::UIDelegate::UIClient::createNewPageCommon): Deleted.
(WebKit::UIDelegate::UIClient::canCreateNewPageAsync): Deleted.
(WebKit::UIDelegate::UIClient::createNewPageAsync): Deleted.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::createNewPage):
- UIProcess/WebPageProxy.h:
- 4:16 PM Changeset in webkit [221770] by
-
- 6 edits in trunk/Source/WebKit
Make DragControllerAction an enum class
https://bugs.webkit.org/show_bug.cgi?id=176565
Reviewed by Andy Estes.
- Shared/DragControllerAction.h:
(): Deleted.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::dragEntered):
(WebKit::WebPageProxy::dragUpdated):
(WebKit::WebPageProxy::dragExited):
(WebKit::WebPageProxy::performDragOperation):
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::performDragControllerAction):
- WebProcess/WebPage/WebPage.h:
- WebProcess/WebPage/WebPage.messages.in:
- 4:13 PM Changeset in webkit [221769] by
-
- 18 edits3 adds in trunk
Add support for RegExp named capture groups
https://bugs.webkit.org/show_bug.cgi?id=176435
Reviewed by Filip Pizlo.
Source/JavaScriptCore:
Added parsing for both naming a captured parenthesis as well and using a named group in
a back reference. Also added support for using named groups with String.prototype.replace().
This patch does not throw Syntax Errors as described in the current spec text for the two
cases of malformed back references in String.prototype.replace() as I believe that it
is inconsistent with the current semantics for handling of other malformed replacement
tokens. I filed an issue for the requested change to the proposed spec and also filed
a FIXME bug https://bugs.webkit.org/show_bug.cgi?id=176434.
This patch does not implement strength reduction in the optimizing JITs for named capture
groups. Filed https://bugs.webkit.org/show_bug.cgi?id=176464.
- dfg/DFGAbstractInterpreterInlines.h:
(JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):
- dfg/DFGStrengthReductionPhase.cpp:
(JSC::DFG::StrengthReductionPhase::handleNode):
- runtime/CommonIdentifiers.h:
- runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::init):
(JSC::JSGlobalObject::haveABadTime):
- runtime/JSGlobalObject.h:
(JSC::JSGlobalObject::regExpMatchesArrayWithGroupsStructure const):
- runtime/RegExp.cpp:
(JSC::RegExp::finishCreation):
- runtime/RegExp.h:
- runtime/RegExpMatchesArray.cpp:
(JSC::createStructureImpl):
(JSC::createRegExpMatchesArrayWithGroupsStructure):
(JSC::createRegExpMatchesArrayWithGroupsSlowPutStructure):
- runtime/RegExpMatchesArray.h:
(JSC::createRegExpMatchesArray):
- runtime/StringPrototype.cpp:
(JSC::substituteBackreferencesSlow):
(JSC::replaceUsingRegExpSearch):
- yarr/YarrParser.h:
(JSC::Yarr::Parser::CharacterClassParserDelegate::atomNamedBackReference):
(JSC::Yarr::Parser::parseEscape):
(JSC::Yarr::Parser::parseParenthesesBegin):
(JSC::Yarr::Parser::tryConsumeUnicodeEscape):
(JSC::Yarr::Parser::tryConsumeIdentifierCharacter):
(JSC::Yarr::Parser::isIdentifierStart):
(JSC::Yarr::Parser::isIdentifierPart):
(JSC::Yarr::Parser::tryConsumeGroupName):
- yarr/YarrPattern.cpp:
(JSC::Yarr::YarrPatternConstructor::atomParenthesesSubpatternBegin):
(JSC::Yarr::YarrPatternConstructor::atomNamedBackReference):
(JSC::Yarr::YarrPattern::errorMessage):
- yarr/YarrPattern.h:
(JSC::Yarr::YarrPattern::reset):
- yarr/YarrSyntaxChecker.cpp:
(JSC::Yarr::SyntaxChecker::atomParenthesesSubpatternBegin):
(JSC::Yarr::SyntaxChecker::atomNamedBackReference):
Source/WebCore:
Implemented stub routines to support named capture groups. These are no-ops
just like for number capture group.
No new tests as this is covered by existing tests.
- contentextensions/URLFilterParser.cpp:
(WebCore::ContentExtensions::PatternParser::atomNamedBackReference):
(WebCore::ContentExtensions::PatternParser::atomParenthesesSubpatternBegin):
LayoutTests:
New regression tests.
- js/regexp-named-capture-groups-expected.txt: Added.
- js/regexp-named-capture-groups.html: Added.
- js/script-tests/regexp-named-capture-groups.js: Added.
- 4:11 PM Changeset in webkit [221768] by
-
- 44 edits5 moves1 delete in trunk/Source
[PAL] Unify PlatformUserPreferredLanguages.h with Language.h
https://bugs.webkit.org/show_bug.cgi?id=176561
Reviewed by Brent Fulgham.
Source/JavaScriptCore:
- runtime/IntlObject.cpp:
(JSC::defaultLocale):
Source/WebCore:
No new tests because there is no behavior change.
- CMakeLists.txt:
- WebCore.xcodeproj/project.pbxproj:
- accessibility/AccessibilitySVGElement.cpp:
- bindings/js/JSDOMWindowBase.cpp:
- bindings/js/JSWorkerGlobalScopeBase.cpp:
- dom/Document.cpp:
- html/HTMLInputElement.cpp:
- html/HTMLMediaElement.cpp:
- html/shadow/MediaControlElements.cpp:
- html/track/TrackBase.cpp:
- page/CaptionUserPreferences.cpp:
- page/CaptionUserPreferencesMediaAF.cpp:
- page/DOMWindow.cpp:
- page/Navigator.cpp:
- page/NavigatorBase.cpp:
- platform/graphics/FontGenericFamilies.cpp:
- platform/graphics/avfoundation/MediaSelectionGroupAVFObjC.mm:
- platform/network/HTTPParsers.cpp:
- platform/text/PlatformLocale.h:
- platform/text/cf/HyphenationCF.cpp:
- platform/text/mac/LocaleMac.mm:
- svg/SVGTests.cpp:
- testing/InternalSettings.cpp:
- testing/Internals.cpp:
(WebCore::Internals::resetToConsistentState):
(WebCore::Internals::userPreferredLanguages const):
(WebCore::Internals::setUserPreferredLanguages):
Source/WebKit:
- UIProcess/WebProcessPool.cpp:
- WebProcess/WebProcess.cpp:
(WebKit::WebProcess::userPreferredLanguagesChanged const):
Source/WebKitLegacy/mac:
- Misc/WebNSUserDefaultsExtras.mm:
Source/WTF:
WebCore/platform/Language was the only* user of PlatformUserPreferredLanguages (with 1 exception).
That exception is that JavaScriptCore needed the functionality of WebCore/platform/Language, but it
couldn't get it because of the layering violation, so instead it erroneously called into
PlatformUserPreferredLanguages instead. This patch merges these two files into WTF so JSC gets the
right function and the PAL effort has one less file to move from WebCore/platform into PAL.
- WTF.xcodeproj/project.pbxproj:
- wtf/CMakeLists.txt:
- wtf/Language.cpp: Renamed from Source/WebCore/platform/Language.cpp.
(WTF::addLanguageChangeObserver):
(WTF::userPreferredLanguages):
- wtf/Language.h: Renamed from Source/WebCore/platform/Language.h.
- wtf/PlatformGTK.cmake:
- wtf/PlatformJSCOnly.cmake:
- wtf/PlatformMac.cmake:
- wtf/PlatformUserPreferredLanguages.h: Removed.
- wtf/PlatformWPE.cmake:
- wtf/PlatformWin.cmake:
- wtf/cf/LanguageCF.cpp: Renamed from Source/WTF/wtf/PlatformUserPreferredLanguagesMac.mm.
(WTF::httpStyleLanguageCode):
(WTF::languagePreferencesDidChange):
(WTF::platformUserPreferredLanguages):
- wtf/unix/LanguageUnix.cpp: Renamed from Source/WTF/wtf/PlatformUserPreferredLanguagesUnix.cpp.
- wtf/win/LanguageWin.cpp: Renamed from Source/WTF/wtf/PlatformUserPreferredLanguagesWin.cpp.
- 4:06 PM Changeset in webkit [221767] by
-
- 2 edits in trunk/Source/WebKit
Remove entry from CacheStorageEngineConnection lock map when unlocking a Cache
https://bugs.webkit.org/show_bug.cgi?id=176548
Patch by Youenn Fablet <youenn@apple.com> on 2017-09-07
Reviewed by Alex Christensen.
- NetworkProcess/cache/CacheStorageEngineConnection.cpp:
(WebKit::CacheStorageEngineConnection::dereference):
- 3:49 PM Changeset in webkit [221766] by
-
- 16 edits in trunk
[WK2] Add C API to retrieve the originating page of a WKDownload
https://bugs.webkit.org/show_bug.cgi?id=176557
<rdar://problem/34314776>
Reviewed by Alex Christensen.
Source/WebKit:
Add C API to retrieve the original page of a WKDownload. This is the C API equivalent to
_WKDownload.originatingWebView which already exists in ObjC. The pointer is weak so as
to not keep alive the page for the duration of the download.
- UIProcess/API/C/WKDownload.cpp:
(WKDownloadGetOriginatingPage):
- UIProcess/API/C/WKDownload.h:
- UIProcess/API/Cocoa/_WKDownload.mm:
(-[_WKDownload originatingWebView]):
- UIProcess/API/Cocoa/_WKDownloadInternal.h:
- UIProcess/Downloads/DownloadProxy.cpp:
(WebKit::DownloadProxy::originatingPage const):
(WebKit::DownloadProxy::setOriginatingPage):
- UIProcess/Downloads/DownloadProxy.h:
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::receivedPolicyDecision):
- UIProcess/WebProcessPool.cpp:
(WebKit::WebProcessPool::download):
(WebKit::WebProcessPool::resumeDownload):
(WebKit::WebProcessPool::createDownloadProxy):
- UIProcess/WebProcessPool.h:
- UIProcess/ios/PageClientImplIOS.mm:
(WebKit::PageClientImpl::handleDownloadRequest):
- UIProcess/mac/PageClientImplMac.mm:
(WebKit::PageClientImpl::handleDownloadRequest):
Tools:
Add layout test coverage for both the ObjC and C API.
- TestWebKitAPI/Tests/WebKit/mac/ContextMenuDownload.mm:
(TestWebKitAPI::decideDestinationWithSuggestedFilename):
(TestWebKitAPI::TEST):
- TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
(-[RedirectedDownloadDelegate _downloadDidStart:]):
(TEST):
- 3:22 PM Changeset in webkit [221765] by
-
- 6 edits2 adds in trunk
Augmented Inspector: Provide a way to inspect a DOM Node (DOM.inspect)
https://bugs.webkit.org/show_bug.cgi?id=176563
<rdar://problem/19639583>
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2017-09-07
Reviewed by Matt Baker.
Source/JavaScriptCore:
- inspector/protocol/DOM.json:
Add an event that is useful for augmented inspectors to inspect
a node. Web pages will still prefer Inspector.inspect.
Source/WebInspectorUI:
- UserInterface/Base/Main.js:
(WI.contentLoaded):
Always create the element search toolbar icon. Only show it if the DOM domain
is available. With augmented agents the DOM domain may be activated later.
- UserInterface/Protocol/DOMObserver.js:
(WI.DOMObserver.prototype.inspect):
Select the node in the DOM tree outline.
LayoutTests:
- inspector/dom/inspect-expected.txt: Added.
- inspector/dom/inspect.html: Added.
Test the frontend on receiving DOM.inspect events.
- 3:20 PM Changeset in webkit [221764] by
-
- 17 edits in trunk/Source/WebKit
Clean up Geolocation request handling
https://bugs.webkit.org/show_bug.cgi?id=176562
Reviewed by Tim Horton.
Instead of passing a GeolocationPermissionRequestProxy& to each client and returning a bool if the request will be handled,
pass a Function<void(bool)>&& completionHandler and return the function if it won't be handled.
This allows to temporarily support our UIClient/PageClient hybrid design while moving towards a sane design.
- UIProcess/API/APIUIClient.h:
(API::UIClient::Function<void):
(API::UIClient::decidePolicyForGeolocationPermissionRequest): Deleted.
- UIProcess/API/C/WKAPICast.h:
- UIProcess/API/C/WKGeolocationPermissionRequest.cpp:
(WKGeolocationPermissionRequestGetTypeID):
- UIProcess/API/C/WKPage.cpp:
(WKPageSetPageUIClient):
- UIProcess/GeolocationPermissionRequestProxy.cpp:
(WebKit::GeolocationPermissionRequestProxy::allow):
(WebKit::GeolocationPermissionRequestProxy::deny):
(WebKit::GeolocationPermissionRequestProxy::invalidate):
- UIProcess/GeolocationPermissionRequestProxy.h:
(WebKit::GeolocationPermissionRequest::create):
(WebKit::GeolocationPermissionRequest::allow):
(WebKit::GeolocationPermissionRequest::deny):
(WebKit::GeolocationPermissionRequest::GeolocationPermissionRequest):
- UIProcess/PageClient.h:
(WebKit::PageClient::decidePolicyForGeolocationPermissionRequest): Deleted.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::requestGeolocationPermissionForFrame):
- UIProcess/ios/PageClientImplIOS.h:
- UIProcess/ios/PageClientImplIOS.mm:
(WebKit::Function<void):
(WebKit::PageClientImpl::decidePolicyForGeolocationPermissionRequest): Deleted.
- UIProcess/ios/WKContentView.h:
- UIProcess/ios/WKGeolocationProviderIOS.h:
- UIProcess/ios/WKGeolocationProviderIOS.mm:
(-[WKGeolocationProviderIOS decidePolicyForGeolocationRequestFromOrigin:frame:completionHandler:view:]):
(-[WKGeolocationProviderIOS geolocationAuthorizationGranted]):
(-[WKGeolocationProviderIOS geolocationAuthorizationDenied]):
(-[WKWebAllowDenyPolicyListener initWithCompletionHandler:]):
(-[WKWebAllowDenyPolicyListener allow]):
(-[WKWebAllowDenyPolicyListener deny]):
(-[WKGeolocationProviderIOS decidePolicyForGeolocationRequestFromOrigin:frame:request:view:]): Deleted.
(-[WKWebAllowDenyPolicyListener initWithPermissionRequestProxy:]): Deleted.
- 3:08 PM Changeset in webkit [221763] by
-
- 2 edits in trunk/LayoutTests
Marked http/tests/misc/delete-frame-during-readystatechange.html as flaky on Windows.
https://bugs.webkit.org/show_bug.cgi?id=176564
Unreviewed test gardening.
- platform/win/TestExpectations:
- 3:01 PM Changeset in webkit [221762] by
-
- 11 edits6 adds in trunk
[WebGL] accelerated texImage2D for video doesn't respect flipY
https://bugs.webkit.org/show_bug.cgi?id=176491
<rdar://problem/33833511>
Reviewed by Jer Noble.
Source/WebCore:
Previously, if UNPACK_FLIP_Y_WEBGL was set to true, we'd either fall
back to software or fail to upload texture data. Fix this by intercepting
the texImage2D call, checking the orientation of the video, and running
a small shader program to flip it if necessary.
While there, implement UNPACK_PREMULTIPLY_ALPHA_WEBGL as well, although
none of our media decoders support video with alpha, so unfortunately
this will have no visible change.
Tests: fast/canvas/webgl/texImage2D-video-flipY-false.html
fast/canvas/webgl/texImage2D-video-flipY-true.html
- platform/cocoa/CoreVideoSoftLink.cpp: Add link to CVOpenGL(ES)TextureGetCleanTexCoords,
which is used to check the orientation of the source video.
- platform/cocoa/CoreVideoSoftLink.h:
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::copyVideoTextureToPlatformTexture): We can
now handle flipped or premultiplied requests.
- platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::copyVideoTextureToPlatformTexture): Ditto.
- platform/graphics/cv/VideoTextureCopierCV.cpp:
(WebCore::VideoTextureCopierCV::VideoTextureCopierCV): Rename readFramebuffer to
simply framebuffer.
(WebCore::VideoTextureCopierCV::~VideoTextureCopierCV): Delete the program and buffer
if they were created.
(WebCore::VideoTextureCopierCV::initializeContextObjects): Sets up the shader program
and the vertex buffer for drawing. Also records the location of the uniforms.
(WebCore::VideoTextureCopierCV::copyVideoTextureToPlatformTexture): Create a new
framebuffer object, and render the video texture into that framebuffer using a
shader that can flip the coordinates.
(WebCore::VideoTextureCopierCV::GC3DStateSaver::GC3DStateSaver): Helper to restore
the state of the user's GraphicsContext3D while we're intercepting calls.
(WebCore::VideoTextureCopierCV::GC3DStateSaver::~GC3DStateSaver):
- platform/graphics/cv/VideoTextureCopierCV.h:
- platform/graphics/GraphicsContext3D.h: Add two new entry points, for direct shader
compilation and attribute access. This avoids going through ANGLE.
- platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:
(WebCore::GraphicsContext3D::compileShader):
(WebCore::GraphicsContext3D::compileShaderDirect):
(WebCore::GraphicsContext3D::getAttribLocationDirect):
LayoutTests:
Test that exercises UNPACK_FLIP_Y_WEBGL for video on the accelerated
path.
- fast/canvas/webgl/resources/orientation-flipped.mp4: Added.
- fast/canvas/webgl/resources/orientation-normal.mp4: Added.
- fast/canvas/webgl/texImage2D-video-flipY-false-expected.txt: Added.
- fast/canvas/webgl/texImage2D-video-flipY-false.html: Added.
- fast/canvas/webgl/texImage2D-video-flipY-true-expected.txt: Added.
- fast/canvas/webgl/texImage2D-video-flipY-true.html: Added.
- platform/ios/TestExpectations:
- 2:58 PM Changeset in webkit [221761] by
-
- 2 edits in trunk/LayoutTests
Mark imported/w3c/web-platform-tests/resource-timing/rt-cors.worker.html as slow.
Unreviewed test gardening.
- platform/win/TestExpectations:
- 2:57 PM Changeset in webkit [221760] by
-
- 5 edits in trunk/Source/WebKit
Allow modern decoding of enums and OptionSets
https://bugs.webkit.org/show_bug.cgi?id=176480
Reviewed by Andy Estes.
- Platform/IPC/ArgumentCoders.h:
(IPC::ArgumentCoder<OptionSet<T>>::decode):
- Platform/IPC/Decoder.h:
(IPC::Decoder::operator>>):
- Platform/IPC/Encoder.h:
- Shared/WebsitePolicies.h:
(WebKit::WebsitePolicies::encode const):
(WebKit::WebsitePolicies::decode):
- 2:52 PM Changeset in webkit [221759] by
-
- 2 edits in trunk/LayoutTests
Marked media/video-controls-drop-and-restore-timeline.html as flaky on macOS WK2.
https://bugs.webkit.org/show_bug.cgi?id=176122
Unreviewed test gardening.
- platform/mac-wk2/TestExpectations:
- 2:38 PM Changeset in webkit [221758] by
-
- 2 edits in trunk/LayoutTests
Marked imported/w3c/web-platform-tests/IndexedDB/idbobjectstore-query-exception-order.html as flaky on El Capitan.
https://bugs.webkit.org/show_bug.cgi?id=176229
Unreviewed test gardening.
- platform/mac-elcapitan/TestExpectations:
- 2:18 PM Changeset in webkit [221757] by
-
- 7 edits1 add in trunk/Tools
WSL Node.prototype.visit should probably do memoization
https://bugs.webkit.org/show_bug.cgi?id=176286
Reviewed by Mark Lam.
Visitors can sometimes revisit the same thing. For example, we may visit a FuncDef because it belongs
to Program and we may visit it again because a CallExpression resolved to it. That's just plain silly.
Our tests don't currently do this, so it's not a performance problem, yet. Also, we usually avoid that
kind of repetitive visiting inside the visitor implementations. But as far as I can tell, this is an
emergent property rather than a deliberate design.
This change just makes the policy super explicit. If you visit something more than once with the same
visitor, you get the same answer back. This is achieved by means of a memo table inside each visitor.
- WebGPUShadingLanguageRI/All.js:
- WebGPUShadingLanguageRI/FuncInstantiator.js:
- WebGPUShadingLanguageRI/Node.js:
(Node.prototype.visit):
- WebGPUShadingLanguageRI/Rewriter.js:
(Rewriter):
- WebGPUShadingLanguageRI/Test.html:
- WebGPUShadingLanguageRI/Visitor.js:
(Visitor):
- WebGPUShadingLanguageRI/VisitorBase.js: Added.
(VisitorBase):
- 1:55 PM Changeset in webkit [221756] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: Canvas RecordingAction tree outline virtualization is broken
https://bugs.webkit.org/show_bug.cgi?id=176547
Reviewed by Joseph Pecoraro.
- UserInterface/Views/TreeOutline.js:
(WI.TreeOutline.prototype.updateVirtualizedElements.walk):
(WI.TreeOutline.prototype.updateVirtualizedElements):
Pass the currentcountto each recursive call ofwalkso that the cumulative index of a
TreeElement in any given sub-tree is correct.
Drive-by: if there is a focused TreeElement when scrolling, only change the current
scrollTopif it is not already visible. Also rewrote some loops for clarity.
- 1:46 PM Changeset in webkit [221755] by
-
- 7 edits in branches/safari-604-branch/Source
Versioning.
- 1:41 PM Changeset in webkit [221754] by
-
- 1 copy in tags/Safari-604.2.9
Tag Safari-604.2.9.
- 1:21 PM Changeset in webkit [221753] by
-
- 7 edits in trunk/Source
Move more code from ScrollingTreeScrollingNodeDelegateIOS to ScrollingTreeScrollingNodeDelegate
https://bugs.webkit.org/show_bug.cgi?id=174130
Reviewed by Simon Fraser.
- UIProcess/RemoteLayerTree/ios/ScrollingTreeOverflowScrollingNodeIOS.h: Remove some members, headers and pre-declaration that are moved into the delegate. (WebKit::ScrollingTreeOverflowScrollingNodeIOS::scrollLayer): Deleted.
- UIProcess/RemoteLayerTree/ios/ScrollingTreeOverflowScrollingNodeIOS.mm: Remove some headers and WKOverflowScrollViewDelegate since they are moved into the delegate file. Also fix the comment to closing the WebKit namespace. (WebKit::ScrollingTreeOverflowScrollingNodeIOS::~ScrollingTreeOverflowScrollingNodeIOS): Remove some code moved into the delegate and call the corresponding helper function to preserve the current behavior. (WebKit::ScrollingTreeOverflowScrollingNodeIOS::commitStateBeforeChildren): Ditto. Note that it is only necessary to cast the parameter to a ScrollingStateTreeNode. (WebKit::ScrollingTreeOverflowScrollingNodeIOS::commitStateAfterChildren): Ditto. (WebKit::ScrollingTreeOverflowScrollingNodeIOS::updateLayersAfterAncestorChange): Ditto. (WebKit::ScrollingTreeOverflowScrollingNodeIOS::scrollPosition): Ditto. (WebKit::ScrollingTreeOverflowScrollingNodeIOS::setScrollLayerPosition): Ditto. (-[WKOverflowScrollViewDelegate initWithScrollingTreeNodeDelegate:]): Deleted. (-[WKOverflowScrollViewDelegate scrollViewDidScroll:]): Deleted. (-[WKOverflowScrollViewDelegate scrollViewWillBeginDragging:]): Deleted. (-[WKOverflowScrollViewDelegate scrollViewWillEndDragging:withVelocity:targetContentOffset:]): Deleted. (-[WKOverflowScrollViewDelegate scrollViewDidEndDragging:willDecelerate:]): Deleted. (-[WKOverflowScrollViewDelegate scrollViewDidEndDecelerating:]): Deleted.
- UIProcess/RemoteLayerTree/ios/ScrollingTreeScrollingNodeDelegateIOS.h: Import headers and members from ScrollingTreeOverflowScrollingNodeIOS. Define new helper functions for the code imported from ScrollingTreeOverflowScrollingNodeIOS. Remove the friendship with ScrollingTreeOverflowScrollingNodeIOS and only makes public the function used by that class. (WebKit::ScrollingTreeScrollingNodeDelegateIOS::scrollLayer): This function is moved from ScrollingTreeOverflowScrollingNodeIOS.
- UIProcess/RemoteLayerTree/ios/ScrollingTreeScrollingNodeDelegateIOS.mm: Add headers, WKOverflowScrollViewDelegate (renamed WKScrollingNodeScrollViewDelegate) and some helper code imported from ScrollingTreeOverflowScrollingNodeIOS. (-[WKScrollingNodeScrollViewDelegate scrollViewDidScroll:]): Moved from ScrollingTreeOverflowScrollingNodeIOS. (-[WKScrollingNodeScrollViewDelegate scrollViewWillBeginDragging:]): Ditto. (-[WKScrollingNodeScrollViewDelegate scrollViewWillEndDragging:withVelocity:targetContentOffset:]): Ditto. (-[WKScrollingNodeScrollViewDelegate scrollViewDidEndDragging:willDecelerate:]): Ditto. (-[WKScrollingNodeScrollViewDelegate scrollViewDidEndDecelerating:]): Ditto. (WebKit::ScrollingTreeScrollingNodeDelegateIOS::~ScrollingTreeScrollingNodeDelegateIOS): Import code from ScrollingTreeOverflowScrollingNodeIOS. (WebKit::ScrollingTreeScrollingNodeDelegateIOS::resetScrollViewDelegate): New helper function importing code from ScrollingTreeOverflowScrollingNodeIOS. (WebKit::ScrollingTreeScrollingNodeDelegateIOS::commitStateBeforeChildren): Ditto. (WebKit::ScrollingTreeScrollingNodeDelegateIOS::commitStateAfterChildren): Ditto. (WebKit::ScrollingTreeScrollingNodeDelegateIOS::updateLayersAfterAncestorChange): Ditto. (WebKit::ScrollingTreeScrollingNodeDelegateIOS::scrollPosition): Ditto. (WebKit::ScrollingTreeScrollingNodeDelegateIOS::setScrollLayerPosition): Ditto.
Patch by Frederic Wang <fwang@igalia.com> on 2017-09-07
- 1:12 PM Changeset in webkit [221752] by
-
- 2 edits in trunk/LayoutTests
[Win] tests/security/contentSecurityPolicy/report-only.php is flaky.
https://bugs.webkit.org/show_bug.cgi?id=176541
Reviewed by Brent Fulgham.
The function call rename will sometimes fail on Windows because one of the files is
opened by another process. If rename fails, wait, and try again.
- http/tests/security/contentSecurityPolicy/resources/save-report.php:
- 1:12 PM Changeset in webkit [221751] by
-
- 6 edits1 add in trunk
[Directory Upload] Extend drag and drop support to iOS
https://bugs.webkit.org/show_bug.cgi?id=176492
<rdar://problem/34291584>
Reviewed by Tim Horton.
Source/WebCore:
Adds support for accepting dropped folders on iOS.
Tests: DataInteractionTests.ExternalSourceDataTransferItemGetFolderAsEntry
DataInteractionTests.ExternalSourceDataTransferItemGetPlainTextFileAsEntry
- platform/ios/PasteboardIOS.mm:
(WebCore::Pasteboard::supportedFileUploadPasteboardTypes):
Add "public.folder" as a compatible pasteboard type for drops on iOS. This means file inputs and custom drop
targets that preventDefault() will, by default, be able to accept incoming folders.
- platform/ios/WebItemProviderPasteboard.mm:
(linkTemporaryItemProviderFilesToDropStagingDirectory):
Tweak temporaryFileURLForDataInteractionContent to also hard link UIKit's temporary files instead, and return
a non-null destination URL only if the necessary file operations succeeded. Also renames this helper to
linkTemporaryItemProviderFilesToDropStagingDirectory to better reflect its new purpose. This makes logic much
cleaner at the call site, which no longer checks against various conditions before proceeding to set the data
transfer URL.
(-[WebItemProviderPasteboard doAfterLoadingProvidedContentIntoFileURLs:synchronousTimeout:]):
(temporaryFileURLForDataInteractionContent): Deleted.
Tools:
Adds two new iOS drag and drop unit tests, which both exercise the DataTransferItem.webKitGetAsEntry codepath
upon drop. (...)GetFolderAsEntry creates a new folder in the temporary directory and uses it to generate an item
provider. This item provider is then dropped over a custom drop handling element, which writes information about
the exposed FileSystemEntries into a textarea. (...)ExternalSourceDataTransferItemGetPlainTextFileAsEntry does
something similar, except that it only drops a plain text file instead.
- TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
- TestWebKitAPI/Tests/WebKitCocoa/DataTransferItem-getAsEntry.html: Added.
Introduce a new test page that dumps information about DataTransferItems' file system entries upon drop.
- TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
(runTestWithTemporaryTextFile):
(runTestWithTemporaryFolder):
Introduce helpers to set up and tear down temporary files and folders over the duration of a test.
(TestWebKitAPI::setUpTestWebViewForDataTransferItems):
(TestWebKitAPI::TEST):
- 12:56 PM Changeset in webkit [221750] by
-
- 5 edits2 adds in trunk/Tools
WSL should check recursion
https://bugs.webkit.org/show_bug.cgi?id=176553
Reviewed by Michael Saboff and Mark Lam.
This adds a recursion checker. Previously, we would only check for recursion during inlining, but that
generally only happens when we call the function.
- WebGPUShadingLanguageRI/All.js:
- WebGPUShadingLanguageRI/CheckRecursion.js: Added.
(checkRecursion):
- WebGPUShadingLanguageRI/Prepare.js:
(prepare):
- WebGPUShadingLanguageRI/RecursionChecker.js: Added.
(RecursionChecker):
(RecursionChecker.prototype.visitFuncDef):
(RecursionChecker.prototype.visitCallExpression):
- WebGPUShadingLanguageRI/Test.html:
- WebGPUShadingLanguageRI/Test.js:
(TEST_simpleRecursion):
- 12:51 PM Changeset in webkit [221749] by
-
- 21 edits2 adds in trunk
[WK2] Notify client when downloads are redirected
https://bugs.webkit.org/show_bug.cgi?id=176481
<rdar://problem/34309065>
Reviewed by Geoffrey Garen.
Source/WebKit:
Notify client when downloads are redirected via both ObjC and C
API.
- NetworkProcess/Downloads/Download.cpp:
(WebKit::Download::willSendRedirectedRequest):
- NetworkProcess/Downloads/Download.h:
- NetworkProcess/Downloads/mac/DownloadMac.mm:
(-[WKDownloadAsDelegate download:willSendRequest:redirectResponse:]):
- UIProcess/API/APIDownloadClient.h:
(API::DownloadClient::willSendRequest):
- UIProcess/API/C/WKContext.cpp:
(WKContextSetDownloadClient):
- UIProcess/API/C/WKContextDownloadClient.h:
- UIProcess/API/Cocoa/_WKDownloadDelegate.h:
- UIProcess/Cocoa/DownloadClient.h:
- UIProcess/Cocoa/DownloadClient.mm:
(WebKit::DownloadClient::DownloadClient):
(WebKit::DownloadClient::willSendRequest):
- UIProcess/Downloads/DownloadProxy.cpp:
(WebKit::DownloadProxy::willSendRequest):
- UIProcess/Downloads/DownloadProxy.h:
- UIProcess/Downloads/DownloadProxy.messages.in:
- UIProcess/mac/WebContextMenuProxyMac.mm:
(WebKit::WebContextMenuProxyMac::showContextMenuWithItems):
Set menu proxy before calling menuFromProposedMenu() client delegate.
This allows me to perform one of the menu item's action from the
menuFromProposedMenu() client delegate in my API test.
Tools:
- TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
(-[UIDownloadAsFileTestDelegate _webView:contextMenu:forElement:]):
(-[RedirectedDownloadDelegate _download:decideDestinationWithSuggestedFilename:allowOverwrite:]):
(-[RedirectedDownloadDelegate _download:didReceiveServerRedirectToURL:]):
(-[RedirectedDownloadDelegate _downloadDidFinish:]):
(TEST):
Add API test coverage.
- WebKitTestRunner/TestController.cpp:
(WTR::TestController::createWebViewWithOptions):
(WTR::TestController::downloadDidReceiveServerRedirectToURL):
- WebKitTestRunner/TestController.h:
Add layout test infrastructure.
LayoutTests:
Add layout test coverage.
- http/tests/download/anchor-download-redirect-expected.txt: Added.
- http/tests/download/anchor-download-redirect.html: Added.
- platform/ios-wk2/TestExpectations:
- platform/mac-wk1/TestExpectations:
- 12:39 PM Changeset in webkit [221748] by
-
- 32 edits in trunk/Source/WebInspectorUI
Unreviewed, change my copyright email.
- Scripts/copy-user-interface-resources.pl:
- UserInterface/Controllers/CodeMirrorSpringEditingController.js:
- UserInterface/Images/AnimationPlayStatePaused.svg:
- UserInterface/Images/AnimationPlayStateRunning.svg:
- UserInterface/Images/CSSVariable.svg:
- UserInterface/Images/ListStylePositionInside.svg:
- UserInterface/Images/ListStylePositionOutside.svg:
- UserInterface/Images/StyleRule.svg:
- UserInterface/Images/StyleRulePseudoElement.svg:
- UserInterface/Models/Collection.js:
- UserInterface/Models/ResourceCollection.js:
- UserInterface/Views/CollectionContentView.css:
- UserInterface/Views/CollectionContentView.js:
- UserInterface/Views/ContextMenuUtilities.js:
- UserInterface/Views/GeneralTabBarItem.js:
- UserInterface/Views/GradientEditor.css:
- UserInterface/Views/GradientEditor.js:
- UserInterface/Views/InlineSwatch.css:
- UserInterface/Views/InlineSwatch.js:
- UserInterface/Views/PinnedTabBarItem.js:
- UserInterface/Views/SettingsTabContentView.css:
- UserInterface/Views/SettingsTabContentView.js:
- UserInterface/Views/SpringEditor.css:
- UserInterface/Views/SpringEditor.js:
- UserInterface/Views/StyleRuleIcons.css:
- UserInterface/Views/TabBarItem.js:
- UserInterface/Views/TitleView.css:
- UserInterface/Views/TitleView.js:
- UserInterface/Views/VisualStyleBackgroundPicker.css:
- UserInterface/Views/VisualStyleBackgroundPicker.js:
- UserInterface/Views/VisualStyleBasicInput.js:
- 12:31 PM Changeset in webkit [221747] by
-
- 3 edits in trunk/JSTests
[Win32] 10 JSC stress tests are failing.
https://bugs.webkit.org/show_bug.cgi?id=176538
Reviewed by Mark Lam.
Skip tests on Windows to make the bots green.
- ChakraCore.yaml:
- stress/date-relaxed.js:
- 12:30 PM Changeset in webkit [221746] by
-
- 8 edits in trunk
[Win] fast/canvas/2d.getPath.modification.html is failing.
https://bugs.webkit.org/show_bug.cgi?id=176534
Reviewed by Alex Christensen.
We need to enable Inspector additions at runtime in order to expose the getPath function.
Source/WebKitLegacy/win:
- Interfaces/IWebPreferencesPrivate.idl:
- WebPreferenceKeysPrivate.h:
- WebPreferences.cpp:
(WebPreferences::initializeDefaultSettings):
(WebPreferences::setDataTransferItemsEnabled):
(WebPreferences::inspectorAdditionsEnabled):
(WebPreferences::setInspectorAdditionsEnabled):
- WebPreferences.h:
- WebView.cpp:
(WebView::notifyPreferencesChanged):
Tools:
- DumpRenderTree/win/DumpRenderTree.cpp:
(resetWebPreferencesToConsistentValues):
- 12:25 PM Changeset in webkit [221745] by
-
- 2 edits1 add in trunk/Tools
WSL tests should run in run-javascriptcore-tests
https://bugs.webkit.org/show_bug.cgi?id=176550
Reviewed by Keith Miller.
- Scripts/run-javascriptcore-tests:
(runJSCStressTests):
- WebGPUShadingLanguageRI/wsl-tests.yaml: Added.
- 12:16 PM Changeset in webkit [221744] by
-
- 2 edits in trunk/LayoutTests
Marked imported/w3c/web-platform-tests/html/semantics/embedded-content/the-iframe-element/cross_origin_parentage.html as slow.
Unreviewed test gardening.
- platform/win/TestExpectations:
- 12:01 PM Changeset in webkit [221743] by
-
- 42 edits in trunk/Source
Modernize Geolocation code
https://bugs.webkit.org/show_bug.cgi?id=176496
Reviewed by Andy Estes.
Source/WebCore:
No change in behavior. Just more references instead of pointers.
- Modules/geolocation/Geolocation.cpp:
(WebCore::createPositionError):
(WebCore::Geolocation::resetAllGeolocationPermission):
(WebCore::Geolocation::stop):
(WebCore::Geolocation::requestPermission):
(WebCore::Geolocation::setError):
(WebCore::Geolocation::startUpdating):
(WebCore::Geolocation::stopUpdating):
- Modules/geolocation/Geolocation.h:
- Modules/geolocation/GeolocationClient.h:
- Modules/geolocation/GeolocationController.cpp:
(WebCore::GeolocationController::addObserver):
(WebCore::GeolocationController::removeObserver):
(WebCore::GeolocationController::requestPermission):
(WebCore::GeolocationController::cancelPermissionRequest):
(WebCore::GeolocationController::positionChanged):
(WebCore::GeolocationController::errorOccurred):
(WebCore::GeolocationController::activityStateDidChange):
(WebCore::provideGeolocationTo):
- Modules/geolocation/GeolocationController.h:
Source/WebKit:
Making the GeolocationPermissionRequestManager take a reference instead of a pointer
spilled into making the other supplement constructors do the same.
- NetworkProcess/CustomProtocols/LegacyCustomProtocolManager.cpp:
(WebKit::LegacyCustomProtocolManager::LegacyCustomProtocolManager):
(WebKit::LegacyCustomProtocolManager::startLoading):
(WebKit::LegacyCustomProtocolManager::stopLoading):
- NetworkProcess/CustomProtocols/LegacyCustomProtocolManager.h:
- NetworkProcess/NetworkProcess.h:
(WebKit::NetworkProcess::addSupplement):
- Shared/Authentication/AuthenticationManager.cpp:
(WebKit::AuthenticationManager::AuthenticationManager):
(WebKit::AuthenticationManager::didReceiveAuthenticationChallenge):
- Shared/Authentication/AuthenticationManager.h:
- UIProcess/API/APIUIClient.h:
(API::UIClient::decidePolicyForGeolocationPermissionRequest):
- UIProcess/API/C/WKPage.cpp:
(WKPageSetPageUIClient):
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::requestGeolocationPermissionForFrame):
- WebProcess/Cookies/WebCookieManager.cpp:
(WebKit::WebCookieManager::WebCookieManager):
(WebKit::WebCookieManager::getHostnamesWithCookies):
(WebKit::WebCookieManager::deleteCookie):
(WebKit::WebCookieManager::deleteAllCookiesModifiedSince):
(WebKit::WebCookieManager::getAllCookies):
(WebKit::WebCookieManager::getCookies):
(WebKit::WebCookieManager::setCookie):
(WebKit::WebCookieManager::setCookies):
(WebKit::WebCookieManager::notifyCookiesDidChange):
(WebKit::WebCookieManager::setHTTPCookieAcceptPolicy):
(WebKit::WebCookieManager::getHTTPCookieAcceptPolicy):
- WebProcess/Cookies/WebCookieManager.h:
- WebProcess/Geolocation/GeolocationPermissionRequestManager.cpp:
(WebKit::GeolocationPermissionRequestManager::GeolocationPermissionRequestManager):
(WebKit::GeolocationPermissionRequestManager::startRequestForGeolocation):
(WebKit::GeolocationPermissionRequestManager::cancelRequestForGeolocation):
- WebProcess/Geolocation/GeolocationPermissionRequestManager.h:
- WebProcess/Geolocation/WebGeolocationManager.cpp:
(WebKit::WebGeolocationManager::WebGeolocationManager):
(WebKit::WebGeolocationManager::registerWebPage):
(WebKit::WebGeolocationManager::unregisterWebPage):
(WebKit::WebGeolocationManager::setEnableHighAccuracyForPage):
(WebKit::WebGeolocationManager::didChangePosition):
(WebKit::WebGeolocationManager::didFailToDeterminePosition):
(WebKit::WebGeolocationManager::resetPermissions):
- WebProcess/Geolocation/WebGeolocationManager.h:
- WebProcess/MediaCache/WebMediaKeyStorageManager.h:
(WebKit::WebMediaKeyStorageManager::WebMediaKeyStorageManager):
- WebProcess/Notifications/WebNotificationManager.cpp:
(WebKit::WebNotificationManager::WebNotificationManager):
(WebKit::WebNotificationManager::show):
(WebKit::WebNotificationManager::cancel):
(WebKit::WebNotificationManager::clearNotifications):
(WebKit::WebNotificationManager::didDestroyNotification):
- WebProcess/Notifications/WebNotificationManager.h:
- WebProcess/WebCoreSupport/WebGeolocationClient.cpp:
(WebKit::WebGeolocationClient::requestPermission):
(WebKit::WebGeolocationClient::cancelPermissionRequest):
- WebProcess/WebCoreSupport/WebGeolocationClient.h:
(WebKit::WebGeolocationClient::WebGeolocationClient):
- WebProcess/WebPage/WebPage.cpp:
(WebKit::m_cpuLimit):
- WebProcess/WebProcess.h:
(WebKit::WebProcess::addSupplement):
- WebProcess/cocoa/UserMediaCaptureManager.cpp:
(WebKit::UserMediaCaptureManager::UserMediaCaptureManager):
- WebProcess/cocoa/UserMediaCaptureManager.h:
Source/WebKitLegacy/mac:
- WebCoreSupport/WebGeolocationClient.h:
- WebCoreSupport/WebGeolocationClient.mm:
(WebGeolocationClient::requestPermission):
(-[WebGeolocationPolicyListener initWithGeolocation:]):
(-[WebGeolocationPolicyListener initWithGeolocation:forWebView:]):
(-[WebGeolocationProviderInitializationListener initWithGeolocation:]):
- WebView/WebView.mm:
(-[WebView _commonInitializationWithFrameName:groupName:]):
(-[WebView _geolocationDidFailWithMessage:]):
Source/WebKitLegacy/win:
- WebCoreSupport/WebGeolocationClient.cpp:
(WebGeolocationClient::requestPermission):
- WebCoreSupport/WebGeolocationClient.h:
(WebGeolocationClient::setEnableHighAccuracy): Deleted.
(WebGeolocationClient::cancelPermissionRequest): Deleted.
- WebGeolocationPolicyListener.h:
- WebView.cpp:
(WebView::initWithFrame):
(WebView::geolocationDidFailWithError):
- 11:52 AM WebKitGTK/2.18.x edited by
- (diff)
- 11:22 AM Changeset in webkit [221742] by
-
- 2 edits in trunk/Source/WebCore
[ARM] Building FELightningNEON.cpp fails due to missing {Point,Spot}LightSource declarations
https://bugs.webkit.org/show_bug.cgi?id=176531
Reviewed by Žan Doberšek.
The m_lightSource member is a Ref<LightSource>, and its get() method returns
a reference, therefore the casts have to be done to the corresponding reference
types.
- platform/graphics/cpu/arm/filters/FELightingNEON.h:
(WebCore::FELighting::platformApplyNeon): Adjust casts and member accesses accordingly.
- 10:56 AM Changeset in webkit [221741] by
-
- 2 edits in trunk/Tools
bisect-builds started failing with invalid json
https://bugs.webkit.org/show_bug.cgi?id=176478
Once we hit 1000 items in our dynamoDB, we ran into an upper limit on the AWS API Gateway looping mechanism.
This prevented us from doing a body mapping template to reformat the json. This fix is to simply return the raw json,
and adjust the json parsing in our code. The AWS rest API has been fixed, and updated to v2.
This change is for the script which operates against the endpoint.
Reviewed by Aakash Jain.
- Scripts/bisect-builds:
(get_sorted_revisions):
- 10:53 AM Changeset in webkit [221740] by
-
- 4 edits in trunk/Tools
[WSL] Rationalize how protocol inheritance deals with type parameters
https://bugs.webkit.org/show_bug.cgi?id=176334
Reviewed by Mark Lam.
This adds a bunch of tests for structs, protocols, and functions interacting in interesting
ways. The most complex of these tests triggers the case where the protocol contains a function
with one type parameter and the real function has more than one. This should give a WTypeError,
and now it does.
- WebGPUShadingLanguageRI/ProtocolDecl.js:
(ProtocolDecl.prototype.hasHeir): Fix the handling of a mismatch of number of type parameters by actually passing the type parameters and then correctly handling the error.
- WebGPUShadingLanguageRI/Test.js: Add a bunch of tests for this case and a lot of other protocol cases.
(TEST_protocolMonoSigPolyDef):
(TEST_protocolPolySigPolyDef):
(TEST_protocolDoublePolySigDoublePolyDef):
(TEST_protocolDoublePolySigDoublePolyDefExplicit):
(TEST_protocolMonoPolySigDoublePolyDefExplicit):
- WebGPUShadingLanguageRI/TypeVariable.js:
(TypeVariable.prototype.get origin): This wasn't implemented before, which made error reporting harder.
- 10:20 AM Changeset in webkit [221739] by
-
- 2 edits in tags/Safari-605.1.5/Source/WebCore/PAL
Cherry-pick r221738. rdar://problem/34296289
- 10:03 AM Changeset in webkit [221738] by
-
- 2 edits in trunk/Source/WebCore/PAL
[Mac] Stop importing NSFunctionBar_Private.h in NSTouchBarSPI.h on the macOS 10.13+ SDK
https://bugs.webkit.org/show_bug.cgi?id=176521
<rdar://problem/34296289>
Reviewed by Andy Estes.
We don't need to import NSFunctionBar_Private.h when building against the macOS 10.13 SDK, or later. Guard this
header import with an SDK version check.
- pal/spi/cocoa/NSTouchBarSPI.h:
- 9:43 AM Changeset in webkit [221737] by
-
- 2 edits in trunk/Tools
[Win] Dashboard test is failing.
https://bugs.webkit.org/show_bug.cgi?id=176527
Reviewed by Brent Fulgham.
Skip test on Windows since WebKitTestRunner is required, but not built on Windows.
- BuildSlaveSupport/build.webkit.org-config/master.cfg:
(TestFactory.init):
- 9:40 AM Changeset in webkit [221736] by
-
- 2 edits in trunk/LayoutTests
Marked svg/animations/smil-leak-elements.svg as flaky on macOS WK1.
https://bugs.webkit.org/show_bug.cgi?id=174180
Unreviewed test gardening.
- platform/mac-wk1/TestExpectations:
- 9:20 AM Changeset in webkit [221735] by
-
- 2 edits in trunk/PerformanceTests
Optimize the call to browserPrefix() in MotionMark
https://bugs.webkit.org/show_bug.cgi?id=176489
Patch by Said Abou-Hallawa <sabouhallawa@apple.com> on 2017-09-07
Reviewed by Jon Lee.
This function is expensive and it does not change for the browser. No need
to recalculate it every time it is called; just cache the returned value.
- MotionMark/resources/extensions.js:
(Utilities.browserPrefix):
- 9:00 AM Changeset in webkit [221734] by
-
- 2 edits3 adds in trunk
[WPE][CMake] Add "dist" and "distcheck" targets
https://bugs.webkit.org/show_bug.cgi?id=176448
Reviewed by Carlos Garcia Campos.
Add "dist" and "distcheck" CMake targets, which create release tarballs.
These are available only when configuring with -DDEVELOPER_MODE=TRUE.
.:
- Source/PlatformWPE.cmake: Added.
- Source/cmake/FindXz.cmake: Added.
Tools:
- wpe/manifest.txt.in: Added.
- 8:55 AM Changeset in webkit [221733] by
-
- 8 edits in trunk
[Win] Enable DatatransferItems in DRT.
https://bugs.webkit.org/show_bug.cgi?id=176424
Reviewed by Brent Fulgham.
Source/WebKitLegacy/win:
- Interfaces/IWebPreferencesPrivate.idl:
- WebPreferenceKeysPrivate.h:
- WebPreferences.cpp:
(WebPreferences::initializeDefaultSettings):
(WebPreferences::QueryInterface):
(WebPreferences::isSecureContextAttributeEnabled):
(WebPreferences::dataTransferItemsEnabled):
(WebPreferences::setDataTransferItemsEnabled):
- WebPreferences.h:
- WebView.cpp:
(WebView::notifyPreferencesChanged):
Tools:
- DumpRenderTree/win/DumpRenderTree.cpp:
(resetWebPreferencesToConsistentValues):
- 8:42 AM Changeset in webkit [221732] by
-
- 3 edits3 deletes in trunk
Unreviewed, rolling out r221716.
This change caused assertion failures on macOS Debug WK2.
Reverted changeset:
"Fetch's Response.statusText is unexpectedly the full http
status line for HTTP/2 responses"
https://bugs.webkit.org/show_bug.cgi?id=176479
http://trac.webkit.org/changeset/221716
- 8:39 AM Changeset in webkit [221731] by
-
- 2 edits in trunk/LayoutTests
Update test expectations for failing tests on Windows.
Unreviewed test gardening.
- platform/win/TestExpectations:
- 8:30 AM Changeset in webkit [221730] by
-
- 1 copy in tags/Safari-605.1.5
Tag Safari-605.1.5.
- 7:53 AM Changeset in webkit [221729] by
-
- 7 edits in trunk/Source
Versioning.
- 5:57 AM Changeset in webkit [221728] by
-
- 2 edits in trunk/Source/WebCore
[EME] CDMClearKey: implement remaining methods of CDMPrivate derivative
https://bugs.webkit.org/show_bug.cgi?id=176495
Reviewed by Xabier Rodriguez-Calvar.
Implement the remaining CDMPrivateClearKey methods, following the
ClearKey specification:
- server certificates are not supported, but sessions are;
- 'keyids' init data in JSON format is acceptable;
- JSON responses are acceptable;
- session IDs must use the 32-bit integer format.
No new tests -- covered by imported W3C tests that utilize ClearKey.
- platform/encryptedmedia/clearkey/CDMClearKey.cpp:
(WebCore::parseJSONObject):
(WebCore::CDMPrivateClearKey::loadAndInitialize):
(WebCore::CDMPrivateClearKey::supportsServerCertificates const):
(WebCore::CDMPrivateClearKey::supportsSessions const):
(WebCore::CDMPrivateClearKey::supportsInitData const):
(WebCore::CDMPrivateClearKey::sanitizeResponse const):
(WebCore::CDMPrivateClearKey::sanitizeSessionId const):
- 5:14 AM Changeset in webkit [221727] by
-
- 9 edits3 adds in trunk
[GTK] Bump libxml2 version to 1.9.5
https://bugs.webkit.org/show_bug.cgi?id=176502
Reviewed by Carlos Alberto Lopez Perez.
Tools:
It has been released very recently, but it fixes the issues that prevented us from upgrading to 1.9.4.
- gtk/jhbuild.modules:
LayoutTests:
Rebaselines several tests where only the line number changed in error messages.
- platform/gtk/fast/dom/adopt-attribute-crash-expected.txt:
- platform/gtk/fast/parser/xml-colon-entity-expected.txt: Added.
- platform/gtk/fast/parser/xml-declaration-missing-ending-mark-expected.txt: Added.
- platform/gtk/fast/xsl/xslt-extra-content-at-end-expected.txt:
- platform/gtk/fast/xsl/xslt-missing-namespace-in-xslt-expected.txt:
- platform/gtk/svg/custom/bug78807-expected.txt: Added.
- platform/gtk/svg/custom/missing-xlink-expected.txt:
- platform/gtk/svg/custom/path-bad-data-expected.txt:
- platform/gtk/svg/custom/use-font-face-crash-expected.txt:
- 3:43 AM WebDriverStatus created by
- 3:12 AM WebKitGTK/2.18.x edited by
- (diff)
- 2:17 AM Changeset in webkit [221726] by
-
- 2 edits in trunk/LayoutTests
Unreviewed GTK+ gardening. Marking some service-worker related tests as crashing.
- platform/gtk/TestExpectations:
- 2:04 AM Changeset in webkit [221725] by
-
- 996 edits1 add in trunk/LayoutTests
Unreviewed GTK+ gardening. Rebaseline tests after r221724.
- 1:52 AM Changeset in webkit [221724] by
-
- 2 edits in trunk/Source/WebCore
[GTK] Bring back line height rounding when computing font metrics
https://bugs.webkit.org/show_bug.cgi?id=176497
Reviewed by Žan Doberšek.
In r221670 we changed the way we get the metrics to avoid rounding that was causing a negative line gap to be
computed. Since the font metrics value is indeed a float value, we also removed the rounding when setting the
line height. However, this caused some test failures because now we report non integer line heights.
- platform/graphics/freetype/SimpleFontDataFreeType.cpp:
(WebCore::Font::platformInit):
- 1:40 AM WebKitGTK/2.16.x edited by
- (diff)
- 1:40 AM WebKitGTK/2.18.x edited by
- (diff)
- 1:36 AM WebKitGTK/2.16.x edited by
- (diff)
- 1:36 AM WebKitGTK/2.18.x edited by
- (diff)
- 1:21 AM WebKitGTK/2.16.x edited by
- (diff)
- 1:20 AM WebKitGTK/2.18.x edited by
- (diff)
- 1:14 AM Changeset in webkit [221723] by
-
- 4 edits in trunk/Source/JavaScriptCore
[JSC] Remove "malloc" and "free" from JSC/API
https://bugs.webkit.org/show_bug.cgi?id=176331
Reviewed by Keith Miller.
Remove "malloc" and "free" manual calls in JSC/API.
- API/JSValue.mm:
(createStructHandlerMap):
- API/JSWrapperMap.mm:
(parsePropertyAttributes):
(makeSetterName):
(copyPrototypeProperties):
Use RetainPtr<NSString> to keep NSString. We avoid repeated "char*" to "NSString" conversion.
- API/ObjcRuntimeExtras.h:
(adoptSystem):
Add adoptSystem to automate calling system free().
(protocolImplementsProtocol):
(forEachProtocolImplementingProtocol):
(forEachMethodInClass):
(forEachMethodInProtocol):
(forEachPropertyInProtocol):
(StringRange::StringRange):
(StringRange::operator const char* const):
(StringRange::get const):
Use CString for backend.
(StructBuffer::StructBuffer):
(StructBuffer::~StructBuffer):
(StringRange::~StringRange): Deleted.
Use fastAlignedMalloc/astAlignedFree to get aligned memory.
- 12:35 AM Changeset in webkit [221722] by
-
- 7 edits in tags/Safari-605.1.4.0.1/Source
Versioning.
- 12:32 AM Changeset in webkit [221721] by
-
- 1 copy in tags/Safari-605.1.4.0.1
New Tag.
- 12:32 AM Changeset in webkit [221720] by
-
- 27 edits in trunk/LayoutTests
Unreviewed GTK+ gardening. Rebaseline more tests after Freetype version bump in r221670.
- platform/gtk/editing/execCommand/print-expected.png:
- platform/gtk/editing/execCommand/print-expected.txt:
- platform/gtk/fast/forms/large-toggle-elements-expected.png:
- platform/gtk/fast/forms/large-toggle-elements-expected.txt:
- platform/gtk/fast/forms/number/number-size-spinbutton-nocover-expected.png:
- platform/gtk/fast/forms/number/number-size-spinbutton-nocover-expected.txt:
- platform/gtk/fast/frames/scrolling-iframe-out-of-viewport-expected.png:
- platform/gtk/fast/frames/scrolling-iframe-out-of-viewport-expected.txt:
- platform/gtk/fonts/complex-text-shadows-expected.png:
- platform/gtk/fonts/complex-text-shadows-expected.txt:
- platform/gtk/fonts/custom-font-missing-glyphs-expected.png:
- platform/gtk/fonts/custom-font-missing-glyphs-expected.txt:
- platform/gtk/fonts/font-face-with-complex-text-expected.png:
- platform/gtk/fonts/font-face-with-complex-text-expected.txt:
- platform/gtk/fonts/font-with-no-valid-encoding-expected.png:
- platform/gtk/fonts/font-with-no-valid-encoding-expected.txt:
- platform/gtk/fonts/fontconfig-aliasing-settings-expected.png:
- platform/gtk/fonts/fontconfig-aliasing-settings-expected.txt:
- platform/gtk/fonts/non-bmp-characters-expected.png:
- platform/gtk/fonts/non-bmp-characters-expected.txt:
- platform/gtk/fonts/xsettings_antialias_settings-expected.png:
- platform/gtk/fonts/xsettings_antialias_settings-expected.txt:
- platform/gtk/fonts/zero-pixel-sized-fonts-expected.png:
- platform/gtk/fonts/zero-pixel-sized-fonts-expected.txt:
- platform/gtk/transitions/svg-text-shadow-transition-expected.png:
- platform/gtk/transitions/svg-text-shadow-transition-expected.txt:
Sep 6, 2017:
- 11:20 PM Changeset in webkit [221719] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed. Temporary disable the changes introduced in r221670 for WPE.
It caused a lot of test failures. Once WPE upgrades to Freetype 2.8 and removes the 2.4.11 patch, we can enable
it again.
- platform/graphics/freetype/SimpleFontDataFreeType.cpp:
(WebCore::Font::platformInit):
- 10:58 PM Changeset in webkit [221718] by
-
- 4 edits in trunk/Source/WebCore
[GStreamer] Implement MediaPlayerPrivateGStreamerMSE::attempToDecryptWithInstance()
https://bugs.webkit.org/show_bug.cgi?id=176445
Reviewed by Xabier Rodriguez-Calvar.
Implement MediaPlayerPrivateGStreamerMSE::attempToDecryptWithInstance(), also
adding support for dispatching ClearKey keys into the append pipelines.
CDMInstanceClearKey::Key is added, containing key ID and value buffers as well
as the key status value. Vector of keys for a specific CDMInstance is
accessible through the CDMInstanceClearKey::keys() getter.
In MediaPlayerPrivateGStreamerMSE, that Vector is retrieved and then iterated
over, constructing corresponding key ID and key value lists that contain
GstBuffer objects into which each key ID and value data is copied. Both lists
are then set on the 'drm-cipher-clearkey' structure before it's dispatched
against each AppendPipeline object.
- platform/encryptedmedia/clearkey/CDMClearKey.h:
- platform/graphics/gstreamer/mse/MediaPlayerPrivateGStreamerMSE.cpp:
(WebCore::MediaPlayerPrivateGStreamerMSE::attemptToDecryptWithInstance):
- platform/graphics/gstreamer/mse/MediaPlayerPrivateGStreamerMSE.h:
- 9:23 PM Changeset in webkit [221717] by
-
- 5 edits in trunk/Websites/perf.webkit.org
Add initSyncers method in BuildbotTriggerable
https://bugs.webkit.org/show_bug.cgi?id=176125
Reviewed by Ryosuke Niwa.
- tools/sync-buildbot.js:
(syncLoop): Use initSyncers() which returns a promise. Modified to handle the promise.
- tools/js/buildbot-triggerable.js:
(BuildbotTriggerable): Invokes initSyncers() appropriately.
(BuildbotTriggerable.prototype.initSyncers): Returns a promise which initialize all the syncers.
- server-tests/tools-buildbot-triggerable-tests.js: Updated tests to handle initSyncers().
- server-tests/tools-sync-buildbot-integration-tests.js: Ditto.
- 9:05 PM Changeset in webkit [221716] by
-
- 3 edits7 adds in trunk
Fetch's Response.statusText is unexpectedly the full http status line for HTTP/2 responses
https://bugs.webkit.org/show_bug.cgi?id=176479
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2017-09-06
Reviewed by Alexey Proskuryakov.
Source/WebCore:
Test: http/wpt/fetch/response-status-text.html
HTTP/2 doesn't include a status reason phrase. So the "status line"
ends up just being the version and status code. Fallback to the empty
string instead of the full line.
- platform/network/HTTPParsers.cpp:
(WebCore::extractReasonPhraseFromHTTPStatusLine):
LayoutTests:
- http/wpt/fetch/resources/status-garbage.asis: Added.
- http/wpt/fetch/resources/status-normal.txt: Added.
- http/wpt/fetch/resources/status-with-message.asis: Added.
- http/wpt/fetch/resources/status-without-message.asis: Added.
Various text HTTP responses with different status lines.
- http/wpt/fetch/response-status-text-expected.txt: Added.
- http/wpt/fetch/response-status-text.html: Added.
Test the Fetch Response's status / statusText for different HTTP status lines.
The status without a message is similiar to HTTP/2 because HTTP/2 only
has a :status pseudo-header and lacks a reason phrase.
- 9:02 PM Changeset in webkit [221715] by
-
- 1 edit1 delete in trunk/Tools
Remove new-run-webkit-httpd as it appears to be old
https://bugs.webkit.org/show_bug.cgi?id=176493
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2017-09-06
Reviewed by Alexey Proskuryakov.
- Scripts/new-run-webkit-httpd: Removed.
- 8:42 PM Changeset in webkit [221714] by
-
- 6 edits in trunk
Add WKUIDelegatePrivate equivalent of WKPageUIClient's pageDidScroll
https://bugs.webkit.org/show_bug.cgi?id=176482
<rdar://problem/29270035>
Reviewed by Tim Horton.
Source/WebKit:
Covered by a new API test!
- UIProcess/API/Cocoa/WKUIDelegatePrivate.h:
- UIProcess/Cocoa/UIDelegate.h:
- UIProcess/Cocoa/UIDelegate.mm:
(WebKit::UIDelegate::setDelegate):
(WebKit::UIDelegate::UIClient::pageDidScroll):
Tools:
- TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
(-[DidScrollDelegate _webViewDidScroll:]):
(TEST):
- 8:29 PM Changeset in webkit [221713] by
-
- 3 edits in trunk/Source/WebInspectorUI
Web Inspector: Relax the maximum sidebar width
https://bugs.webkit.org/show_bug.cgi?id=175808
<rdar://problem/34005339>
Reviewed by Devin Rousso.
This patch introduces a constant,
minimumContentBrowserWidth, which
constrains the maximum width of either sidebar:
maxSidebarWidth = window.innerWidth - minimumContentBrowserWidth - otherSidebarWidth
A value of 100px for
minimumContentBrowserWidthleaves enough space for
three NavigationItems at their minimum width (32px), with a few pixels
left over for good measure. For most tabs this will ensure that the buttons
for showing the sidebars will be visible, along with an addition button.
- UserInterface/Base/Main.js:
- UserInterface/Views/Sidebar.js:
(WI.Sidebar.prototype.get maximumWidth):
- 7:32 PM Changeset in webkit [221712] by
-
- 11 edits in trunk
Require LoggingHelper overrides to provide identifier
https://bugs.webkit.org/show_bug.cgi?id=176477
Reviewed by Jer Noble.
Source/WebCore:
No new tests, updated API test.
- html/HTMLMediaElement.cpp:
(WebCore::nextLogIdentifier): New.
(WebCore::HTMLMediaElement::HTMLMediaElement): Initialize m_logIdendifier. LOGTHIS -> LOGIDENTIFIER.
(WebCore::HTMLMediaElement::~HTMLMediaElement): Ditto.
- html/HTMLMediaElement.h:
Source/WebCore/PAL:
- pal/Logger.h:
(PAL::Logger::LogSiteIdentifier::LogSiteIdentifier):
(PAL::LogArgument<Logger::LogSiteIdentifier>::toString):
(PAL::Logger::notice const): Deleted.
(PAL::Logger::MethodAndPointer::MethodAndPointer): Deleted.
(PAL::LogArgument<Logger::MethodAndPointer>::toString): Deleted.
- pal/LoggerHelper.h:
Source/WTF:
- wtf/Assertions.cpp: No more WTFLogLevelNotice.
- wtf/Assertions.h: Ditto.
Tools:
- TestWebKitAPI/Tests/WebCore/Logging.cpp:
(TestWebKitAPI::TEST_F):
- 5:57 PM Changeset in webkit [221711] by
-
- 3 edits1 add in trunk
constructGenericTypedArrayViewWithArguments() is missing an exception check.
https://bugs.webkit.org/show_bug.cgi?id=176485
<rdar://problem/33898874>
Reviewed by Keith Miller.
JSTests:
- stress/regress-176485.js: Added.
Source/JavaScriptCore:
- runtime/JSGenericTypedArrayViewConstructorInlines.h:
(JSC::constructGenericTypedArrayViewWithArguments):
- 5:03 PM Changeset in webkit [221710] by
-
- 24 edits2 adds in trunk
NetworkProcess Cache and Caches should be cleared when the last related WebProcess Cache or CacheStorage is destroyed
https://bugs.webkit.org/show_bug.cgi?id=176249
Patch by Youenn Fablet <youenn@apple.com> on 2017-09-06
Reviewed by Alex Christensen.
Source/WebCore:
Test: http/tests/cache-storage/cache-representation.https.html
Each Cache construction/destruction is notified to the CacheStorageConnection
so that the WebKit2 engine can handle memory management accordingly.
Adding an internal API to grab the representation of an engine at any time.
- Modules/cache/Cache.cpp:
(WebCore::Cache::Cache):
(WebCore::Cache::~Cache):
- Modules/cache/CacheStorageConnection.h:
(WebCore::CacheStorageConnection::reference):
(WebCore::CacheStorageConnection::dereference):
- Modules/cache/WorkerCacheStorageConnection.cpp:
(WebCore::WorkerCacheStorageConnection::reference):
(WebCore::WorkerCacheStorageConnection::dereference):
- Modules/cache/WorkerCacheStorageConnection.h:
- testing/Internals.cpp:
(WebCore::Internals::cacheStorageEngineRepresentation):
- testing/Internals.h:
- testing/Internals.idl:
Source/WebKit:
CacheStorageEngineConnection will store the number of Caches references for its related WebProcess.
For a new reference, CacheStorageEngineConnection will notify its engine to lock the related Cache.
When the last reference is gone, CacheStorageEngineConnection will ask the engine to release the lock.
CacheStorageEngine will keep locks as a counter for each Cache object.
When the counter goes to zero, the engine asks the Cache to dispose itself.
Disposal is done by its parent Caches as only Caches knows whether the Cache is persistent or has been removed.
The Caches will remove the Cache from memory.
For removed caches, all information will be lost.
For caches that are not removed, they will keep their identifiers but all in-memory record information will be discarded.
If there is a need to reopen the Cache, it will need to read its information from the filesystem.
If the Caches has no longer any active Cache object, it will ask the engine to release itself.
WebProcess crashing is handled correctly as the CacheStorageEngineConnection will release its locks at destruction
time of the connection to the web process.
Adding the possiblity to grab an engine representation for test purposes.
- NetworkProcess/cache/CacheStorageEngine.cpp:
(WebKit::CacheStorage::Engine::readCachesFromDisk):
(WebKit::CacheStorage::Engine::removeCaches):
(WebKit::CacheStorage::Engine::lock):
(WebKit::CacheStorage::Engine::unlock):
- NetworkProcess/cache/CacheStorageEngine.h:
- NetworkProcess/cache/CacheStorageEngineCache.cpp:
(WebKit::CacheStorage::Cache::Cache):
(WebKit::CacheStorage::Cache::dispose):
(WebKit::CacheStorage::Cache::clearMemoryRepresentation):
- NetworkProcess/cache/CacheStorageEngineCache.h:
(WebKit::CacheStorage::Cache::isActive const):
- NetworkProcess/cache/CacheStorageEngineCaches.cpp:
(WebKit::CacheStorage::Caches::Caches):
(WebKit::CacheStorage::Caches::open):
(WebKit::CacheStorage::Caches::dispose):
(WebKit::CacheStorage::Caches::readCachesFromDisk):
(WebKit::CacheStorage::Caches::clearMemoryRepresentation):
- NetworkProcess/cache/CacheStorageEngineCaches.h:
(WebKit::CacheStorage::Caches::create):
- NetworkProcess/cache/CacheStorageEngineConnection.cpp:
(WebKit::CacheStorageEngineConnection::~CacheStorageEngineConnection):
(WebKit::CacheStorageEngineConnection::reference):
(WebKit::CacheStorageEngineConnection::dereference):
- NetworkProcess/cache/CacheStorageEngineConnection.h:
- NetworkProcess/cache/CacheStorageEngineConnection.messages.in:
- WebProcess/Cache/WebCacheStorageConnection.cpp:
(WebKit::WebCacheStorageConnection::reference):
(WebKit::WebCacheStorageConnection::dereference):
- WebProcess/Cache/WebCacheStorageConnection.h:
LayoutTests:
- http/tests/cache-storage/cache-representation.https-expected.txt: Added.
- http/tests/cache-storage/cache-representation.https.html: Added.
- http/tests/cache-storage/resources/cache-persistency-iframe.html:
- 5:02 PM Changeset in webkit [221709] by
-
- 2 edits in trunk/Source/WebCore
Support new autoplay quirk for arbitrary user gestures.
https://bugs.webkit.org/show_bug.cgi?id=176402
Reviewed by Eric Carlson.
This quirk allows any user gesture to allow autoplay in a document.
No new tests because this specifically targets one host.
- html/MediaElementSession.cpp:
(WebCore::needsArbitraryUserGestureAutoplayQuirk):
(WebCore::MediaElementSession::playbackPermitted const):
- 4:33 PM Changeset in webkit [221708] by
-
- 3 edits in trunk/LayoutTests
Marked media/video-main-content-allow-then-scroll.html as flaky on macOS and failing on iOS.
https://bugs.webkit.org/show_bug.cgi?id=161491
Unreviewed test gardening.
- platform/ios-wk2/TestExpectations:
- platform/mac/TestExpectations:
- 4:27 PM Changeset in webkit [221707] by
-
- 11 edits in trunk
Add WKUIDelegatePrivate equivalent of WKPageUIClient's pinnedStateDidChange
https://bugs.webkit.org/show_bug.cgi?id=176474
<rdar://problem/29270035>
Reviewed by Tim Horton.
Source/WebKit:
Rather than telling the UIClient that the pinned state changed and having the application check 4 bools
like we do with WKPage, I made a KVO property on the WKWebView. I introduce _WKRectEdge for this purpose,
which is like UIRectEdge but unfortunately NSRectEdge and CGRectEdge cannot be used as NS_OPTIONS/flags.
This same structure is used for rubber band state.
Covered by a new API test.
- UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _pinnedState]):
(-[WKWebView _rubberBandState]):
(-[WKWebView _setRubberBandState:]):
- UIProcess/API/Cocoa/WKWebViewPrivate.h:
- UIProcess/Cocoa/WebViewImpl.h:
- UIProcess/Cocoa/WebViewImpl.mm:
(WebKit::WebViewImpl::pinnedState):
(WebKit::WebViewImpl::rubberBandState):
(WebKit::WebViewImpl::setRubberBandState):
- UIProcess/PageClient.h:
(WebKit::PageClient::pinnedStateWillChange):
(WebKit::PageClient::pinnedStateDidChange):
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::didChangeScrollOffsetPinningForMainFrame):
- UIProcess/mac/PageClientImplMac.h:
- UIProcess/mac/PageClientImplMac.mm:
(WebKit::PageClientImpl::pinnedStateWillChange):
(WebKit::PageClientImpl::pinnedStateDidChange):
Tools:
- TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
(-[PinnedStateObserver observeValueForKeyPath:ofObject:change:context:]):
(TEST):
- 3:01 PM Changeset in webkit [221706] by
-
- 9 copies1 add in releases/Apple/Safari Technology Preview 39
Added a tag for Safari Technology Preview release 39.
- 2:37 PM Changeset in webkit [221705] by
-
- 5 edits in trunk/Source/WebKit
Introduce asynchronous opening of CacheStorageEngine cache
https://bugs.webkit.org/show_bug.cgi?id=176425
Patch by Youenn Fablet <youenn@apple.com> on 2017-09-06
Reviewed by Alex Christensen.
Introducing Cache::open to allow reading from the filesystem to fill the Cache.
This is called by Caches when engine requests to open an existing Cache.
- NetworkProcess/cache/CacheStorageEngineCache.cpp:
(WebKit::CacheStorage::Cache::Cache):
(WebKit::CacheStorage::Cache::open):
(WebKit::CacheStorage::Cache::finishOpening):
(WebKit::CacheStorage::Cache::readRecordsList):
- NetworkProcess/cache/CacheStorageEngineCache.h:
- NetworkProcess/cache/CacheStorageEngineCaches.cpp:
(WebKit::CacheStorage::Caches::find):
(WebKit::CacheStorage::Caches::open):
(WebKit::CacheStorage::Caches::remove):
(WebKit::CacheStorage::Caches::readCachesFromDisk):
(WebKit::CacheStorage::Caches::find const): Deleted.
- NetworkProcess/cache/CacheStorageEngineCaches.h:
- 2:25 PM Changeset in webkit [221704] by
-
- 24 edits5 adds in trunk
Support caching of Response with a ReadableStream body
https://bugs.webkit.org/show_bug.cgi?id=176462
Patch by Youenn Fablet <youenn@apple.com> on 2017-09-06
Reviewed by Alex Christensen.
LayoutTests/imported/w3c:
- web-platform-tests/service-workers/cache-storage/worker/cache-put.https-expected.txt:
Source/WebCore:
Tests: http/wpt/cache-storage/cache-put-stream.https.any.html
http/wpt/cache-storage/cache-put-stream.https.any.worker.html
Making FetchResponse use more of ReadableStream:
- Cloning of its body is done through ReadableStream.
- Computation of disturbed and locked is done through ReadableStream.
- Storing of the ReadableStream body given at constructor time is done in FetchBody for FetchResponse.
This allows making FetchResponse closer to FetchRequest.
This also allows to correctly compute disturbed and locked in clone cases.
Adding the ability to consume a Response ReadableStream body as a SharedBuffer.
Using that ability in DOMCache.
- Modules/cache/DOMCache.cpp:
(WebCore::DOMCache::putWithResponseData):
(WebCore::DOMCache::put):
- Modules/cache/DOMCache.h:
- Modules/fetch/FetchBody.h:
(WebCore::FetchBody::readableStream const):
- Modules/fetch/FetchBodyConsumer.cpp:
(WebCore::FetchBodyConsumer::extract):
- Modules/fetch/FetchBodyConsumer.h:
- Modules/fetch/FetchBodyOwner.cpp:
(WebCore::FetchBodyOwner::isDisturbed const):
(WebCore::FetchBodyOwner::isDisturbedOrLocked const):
- Modules/fetch/FetchBodyOwner.h:
(WebCore::FetchBodyOwner::hasReadableStreamBody const):
- Modules/fetch/FetchBodySource.cpp:
- Modules/fetch/FetchBodySource.h:
- Modules/fetch/FetchResponse.cpp:
(WebCore::FetchResponse::consumeBodyFromReadableStream):
(WebCore::FetchResponse::consumeBodyWhenLoaded):
(WebCore::FetchResponse::consumeBodyAsStream):
- Modules/fetch/FetchResponse.h:
- Modules/fetch/FetchResponse.idl:
- Modules/fetch/FetchResponse.js:
(initializeFetchResponse):
(clone):
- bindings/js/ReadableStream.cpp:
(WebCore::callFunction):
(WebCore::ReadableStream::pipeTo):
(WebCore::ReadableStream::tee):
(WebCore::checkReadableStream):
(WebCore::ReadableStream::isLocked const):
(WebCore::ReadableStream::isDisturbed const):
(WebCore::ReadableStream::isDisturbed):
- bindings/js/ReadableStream.h:
- bindings/js/ReadableStreamDefaultController.cpp:
- bindings/js/ReadableStreamDefaultController.h:
- bindings/js/WebCoreBuiltinNames.h:
- testing/Internals.cpp:
(WebCore::Internals::isReadableStreamDisturbed):
LayoutTests:
- TestExpectations: Removing flakiness expectation for cache-put tests.
- http/wpt/cache-storage/cache-put-stream.https.any-expected.txt: Added.
- http/wpt/cache-storage/cache-put-stream.https.any.html: Added.
- http/wpt/cache-storage/cache-put-stream.https.any.js: Added.
(cache_test.):
(cache_test):
(string_appeared_here.cache_test.return.reader.read.then.):
(string_appeared_here.cache_test):
- http/wpt/cache-storage/cache-put-stream.https.any.worker-expected.txt: Added.
- http/wpt/cache-storage/cache-put-stream.https.any.worker.html: Added.
- 2:04 PM Changeset in webkit [221703] by
-
- 7 edits in trunk/Source/JavaScriptCore
Air should have a Vector of prologue generators instead of a HashMap representing an optional prologue generator
https://bugs.webkit.org/show_bug.cgi?id=176346
Reviewed by Mark Lam.
- b3/B3Procedure.cpp:
(JSC::B3::Procedure::Procedure):
(JSC::B3::Procedure::setNumEntrypoints):
- b3/B3Procedure.h:
(JSC::B3::Procedure::setNumEntrypoints): Deleted.
- b3/air/AirCode.cpp:
(JSC::B3::Air::defaultPrologueGenerator):
(JSC::B3::Air::Code::Code):
(JSC::B3::Air::Code::setNumEntrypoints):
- b3/air/AirCode.h:
(JSC::B3::Air::Code::setPrologueForEntrypoint):
(JSC::B3::Air::Code::prologueGeneratorForEntrypoint):
(JSC::B3::Air::Code::setEntrypoints):
(JSC::B3::Air::Code::setEntrypointLabels):
- b3/air/AirGenerate.cpp:
(JSC::B3::Air::generate):
- ftl/FTLLowerDFGToB3.cpp:
(JSC::FTL::DFG::LowerDFGToB3::lower):
- 1:54 PM Changeset in webkit [221702] by
-
- 11 edits in trunk
Unreviewed, rolling out r221694.
broke build
Reverted changeset:
"Add WKUIDelegatePrivate equivalent of WKPageUIClient's
pinnedStateDidChange"
https://bugs.webkit.org/show_bug.cgi?id=176474
http://trac.webkit.org/changeset/221694
- 1:51 PM Changeset in webkit [221701] by
-
- 2 edits in trunk/Source/JavaScriptCore
ASSERTION FAILED: op() == CheckStructure in Source/JavaScriptCore/dfg/DFGNode.h(443)
https://bugs.webkit.org/show_bug.cgi?id=176470
Reviewed by Mark Lam.
Update Node::convertToCheckStructureImmediate's assertion to allow
the node to either be a CheckStructure or CheckStructureOrEmpty.
- dfg/DFGNode.h:
(JSC::DFG::Node::convertToCheckStructureImmediate):
- 1:48 PM Changeset in webkit [221700] by
-
- 2 edits in trunk/Tools
[Win] test-webkitpy test timeout_context_unittest is failing.
https://bugs.webkit.org/show_bug.cgi?id=176471
Reviewed by Brent Fulgham.
This assert failure is possibly caused by different time resolution on
various platforms.
- Scripts/webkitpy/common/timeout_context_unittest.py:
(TimeoutContextTests.test_timeout_data):
- 1:40 PM Changeset in webkit [221699] by
-
- 24 edits1 delete in trunk
Unreviewed, rolling out r221461.
The LayoutTest added with this change crashes under
GuardMalloc.
Reverted changeset:
"Add (entirely incorrect) fetching of ServiceWorker scripts."
https://bugs.webkit.org/show_bug.cgi?id=176179
http://trac.webkit.org/changeset/221461
- 1:26 PM Changeset in webkit [221698] by
-
- 5 edits in trunk/Source/WebKit
Add modern decoders for POD types
https://bugs.webkit.org/show_bug.cgi?id=176456
Reviewed by Geoffrey Garen.
- Platform/IPC/Decoder.cpp:
(IPC::Decoder::getOptional):
(IPC::Decoder::operator>>):
- Platform/IPC/Decoder.h:
- Shared/NavigationActionData.cpp:
(WebKit::NavigationActionData::decode):
- Shared/NavigationActionData.h:
- 1:24 PM Changeset in webkit [221697] by
-
- 7 edits in branches/safari-604-branch/Source
Versioning.
- 1:21 PM Changeset in webkit [221696] by
-
- 2 edits in trunk/Tools
status-bubbles turn orange after checking relevance of patch
https://bugs.webkit.org/show_bug.cgi?id=176457
Reviewed by Alexey Proskuryakov.
- QueueStatusServer/handlers/statusbubble.py: Added "Checked relevance of patch" as a progress_statuses.
- 1:16 PM Changeset in webkit [221695] by
-
- 16 edits1 add in trunk
Web Inspector: Support overloaded CanvasRenderingContext2D actions with identical parameter counts
https://bugs.webkit.org/show_bug.cgi?id=176178
<rdar://problem/34192229>
Reviewed by Matt Baker.
Source/WebCore:
Update existing tests.
- WebCore.xcodeproj/project.pbxproj:
- inspector/InspectorCanvas.cpp:
(WebCore::buildArrayForVector):
(WebCore::InspectorCanvas::buildAction):
Add another array to each action that contains a swizzle type for each parameter. This is
used by the frontend to determine how to regenerate the value from what is given in the JSON.
- inspector/RecordingSwizzleTypes.h: Added.
Contains a value-specified enum of types that translate into int values, which are mirrored
by an object in the frontend, that indicate the type of each parameter. This enum matches
the values in WI.Recording.Swizzle.
Source/WebInspectorUI:
- UserInterface/Models/Recording.js:
(WI.Recording.displayNameForSwizzleType):
(WI.Recording.prototype.swizzle):
Replace WI.Recording.Swizzle with an object of swizzle type keys to int values. This object
matches the values in WebCore::RecordingSwizzleTypes.h.
- UserInterface/Models/RecordingAction.js:
(WI.RecordingAction):
(WI.RecordingAction.fromPayload):
(WI.RecordingAction.prototype.get swizzleTypes):
(WI.RecordingAction.prototype.swizzle):
(WI.RecordingAction.prototype.toJSON):
(WI.RecordingAction.prototype.parameterSwizzleTypeForTypeAtIndex): Deleted.
Replace WI.RecordingAction._parameterSwizzleTypeForTypeAtIndex with an array of parameter
types sent in the payload. This gives more control over the swizzling to the JSON, but also
simplifies the way we regenerate the data in the frontend.
- UserInterface/Views/RecordingActionTreeElement.js:
(WI.RecordingActionTreeElement._generateDOM):
- UserInterface/Views/RecordingContentView.js:
(WI.RecordingContentView.prototype._generateContentCanvas2D):
(WI.RecordingContentView.prototype._applyAction):
- UserInterface/Views/RecordingNavigationSidebarPanel.css:
(.sidebar > .panel.navigation.recording > .content .action.invalid:not(.selected, .initial-state) > .titles :matches(.name, .parameter.invalid)):
(.sidebar > .panel.navigation.recording > .content .action.invalid:not(.selected, .initial-state) > .titles .name,): Deleted.
LayoutTests:
- inspector/canvas/recording-2d-expected.txt:
- inspector/canvas/recording-webgl-expected.txt:
- inspector/canvas/recording-webgl-snapshots-expected.txt:
- inspector/model/recording-expected.txt:
- inspector/model/recording.html:
- 1:15 PM Changeset in webkit [221694] by
-
- 11 edits in trunk
Add WKUIDelegatePrivate equivalent of WKPageUIClient's pinnedStateDidChange
https://bugs.webkit.org/show_bug.cgi?id=176474
<rdar://problem/29270035>
Reviewed by Tim Horton.
Source/WebKit:
Rather than telling the UIClient that the pinned state changed and having the application check 4 bools
like we do with WKPage, I made a KVO property on the WKWebView. I introduce _WKRectEdge for this purpose,
which is like UIRectEdge but unfortunately NSRectEdge and CGRectEdge cannot be used as NS_OPTIONS/flags.
This same structure is used for rubber band state.
Covered by a new API test.
- UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _pinnedState]):
(-[WKWebView _rubberBandState]):
(-[WKWebView _setRubberBandState:]):
- UIProcess/API/Cocoa/WKWebViewPrivate.h:
- UIProcess/Cocoa/WebViewImpl.h:
- UIProcess/Cocoa/WebViewImpl.mm:
(WebKit::WebViewImpl::pinnedState):
(WebKit::WebViewImpl::rubberBandState):
(WebKit::WebViewImpl::setRubberBandState):
- UIProcess/PageClient.h:
(WebKit::PageClient::pinnedStateWillChange):
(WebKit::PageClient::pinnedStateDidChange):
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::didChangeScrollOffsetPinningForMainFrame):
- UIProcess/mac/PageClientImplMac.h:
- UIProcess/mac/PageClientImplMac.mm:
(WebKit::PageClientImpl::pinnedStateWillChange):
(WebKit::PageClientImpl::pinnedStateDidChange):
Tools:
- TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
(-[PinnedStateObserver observeValueForKeyPath:ofObject:change:context:]):
(TEST):
- 1:09 PM Changeset in webkit [221693] by
-
- 8 edits1 move in trunk/Source
[Win] WebCore failed to build, InbandTextTrackPrivateAVF: base class undefined.
https://bugs.webkit.org/show_bug.cgi?id=176431
Reviewed by Alex Christensen.
Source/WebCore:
AVFoundation header detection should be done in WebCore because of build dependencies.
No new tests, covered by existing tests.
- AVFoundationSupport.py: Copied from Source/WTF/AVFoundationSupport.py.
- PlatformWin.cmake:
- config.h:
- platform/graphics/ca/win/PlatformCALayerWin.cpp:
- platform/graphics/ca/win/PlatformCALayerWinInternal.cpp:
Source/WTF:
AVFoundation header detection should be done in WebCore because of build dependencies.
- AVFoundationSupport.py: Removed.
- wtf/Platform.h:
- wtf/PlatformWin.cmake:
- 1:03 PM Changeset in webkit [221692] by
-
- 5 edits in trunk/Tools
WSL: Inliner doesn't allow double-negation
https://bugs.webkit.org/show_bug.cgi?id=176440
Reviewed by Mylex Maxfield.
The problem was that we were visiting the operands to calls while inside doVisit. This is too strict
since it rejects nested calls like foo(foo(x)). The solution is to visit the operands to calls before
entering doVisit.
This also fixes some other issues in the parser that made the Inliner's error really strange.
- WebGPUShadingLanguageRI/Func.js:
(Func):
- WebGPUShadingLanguageRI/Inliner.js:
(Inliner.prototype.visitCallExpression):
(Inliner):
- WebGPUShadingLanguageRI/Parse.js:
(parseOperatorFuncDefValues):
(parseNonOperatorFuncDefValues):
(parseGenericFuncDefValues):
(parseFuncDecl):
- WebGPUShadingLanguageRI/Test.js:
- WebGPUShadingLanguageRI/VisitingSet.js:
(VisitingSet.prototype.doVisit):
(VisitingSet):
- 12:46 PM Changeset in webkit [221691] by
-
- 6 edits in trunk/Source/WebInspectorUI
Web Inspector: ⌘E and ⌘G do not work in main content area when quick console drawer is open
https://bugs.webkit.org/show_bug.cgi?id=176433
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2017-09-06
Reviewed by Brian Burg.
Make the ⌘E and ⌘G keyboard shortcuts behave more like the global ⌘K clear shortcut.
Instead of keeping them inside of FindBanner, and enabling/disabling them when they
make sense to apply, we make a single global instance of the keyboard shortcut and
apply it to whatever content view / content browser is active. This avoids conflicts
in situations where there are two ContentViews that are visible and each can handle
the keyboard shortcut.
- UserInterface/Base/Main.js:
(WI.contentLoaded):
New keyboard shortcuts.
(WI._populateFind):
(WI._findNext):
(WI._findPrevious):
Perform the shortcut on the active content view or content browser.
- UserInterface/Views/ContentBrowser.js:
(WI.ContentBrowser.prototype.shown):
(WI.ContentBrowser.prototype.hidden):
(WI.ContentBrowser.prototype.handlePopulateFindShortcut):
(WI.ContentBrowser.prototype.handleFindNextShortcut):
(WI.ContentBrowser.prototype.handleFindPreviousShortcut):
(WI.ContentBrowser.prototype.findBannerSearchQueryForSelection): Deleted.
- UserInterface/Views/LogContentView.js:
(WI.LogContentView.prototype.handlePopulateFindShortcut):
(WI.LogContentView.prototype.handleFindNextShortcut):
(WI.LogContentView.prototype.handleFindPreviousShortcut):
ContentBrowser and LogContentView (the only content view with a custom find banner)
now each handle the global keyboard shortcut handlers to do the right thing for
their respective cases.
- UserInterface/Views/FindBanner.js:
(WI.FindBanner.prototype.enableKeyboardShortcuts): Deleted.
(WI.FindBanner.prototype.disableKeyboardShortcuts): Deleted.
(WI.FindBanner.prototype._populateSearchQueryFromSelection): Deleted.
Move keyboard shortcut handling up to Main.js to be global.
- UserInterface/Views/ContentView.js:
(WI.ContentView.prototype.searchQueryWithSelection):
Default implementation should grab the selected text from the selection.
Previously shortcut selections only worked for selections in text editors.
- 12:34 PM Changeset in webkit [221690] by
-
- 1 edit2 adds in trunk/Tools
WSL should support the bool type
https://bugs.webkit.org/show_bug.cgi?id=176285
Reviewed by Filip Pizlo.
I forgot to commit a couple files.
- WebGPUShadingLanguageRI/StandardLibraryEpilogue.js: Added.
(const.standardLibraryEpilogue.operator.bool.T.Equatable):
- WebGPUShadingLanguageRI/StandardLibraryPrologue.js: Added.
(operator.T.T):
- 11:49 AM Changeset in webkit [221689] by
-
- 3 edits4 adds in trunk
REGRESSION (r221598): Legacy "round" and "bevel" options can no longer be used with the legacy CanvasRenderingContext2D setLineJoin operation
https://bugs.webkit.org/show_bug.cgi?id=176461
Patch by Sam Weinig <sam@webkit.org> on 2017-09-06
Reviewed by Alex Christensen.
Source/WebCore:
Tests: fast/canvas/canvas-strokePath-cap-join-legacy-functions-match-attribute.html
fast/canvas/canvas-strokePath-cap-join-legacy.html
- html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::setLineJoin):
Fix silly typo, ifs -> else ifs.
LayoutTests:
Add tests showing that the legacy setLineJoin and setLineCap operations are correct
and match the corresponding standard attributes.
- fast/canvas/canvas-strokePath-cap-join-legacy-functions-match-attribute-expected.html: Added.
- fast/canvas/canvas-strokePath-cap-join-legacy-functions-match-attribute.html: Added.
- fast/canvas/canvas-strokePath-cap-join-legacy-expected.txt: Added.
- fast/canvas/canvas-strokePath-cap-join-legacy.html: Added.
- 11:45 AM Changeset in webkit [221688] by
-
- 2 edits in trunk/LayoutTests
Rebaseline printing/width-overflow.html after r219121.
Unreviewed test gardening.
- platform/win/printing/width-overflow-expected.txt:
- 11:26 AM Changeset in webkit [221687] by
-
- 2 edits in trunk/LayoutTests
Marked js/arraybuffer-wrappers.html as flaky.
https://bugs.webkit.org/show_bug.cgi?id=155092
Unreviewed test gardening.
- platform/ios/TestExpectations:
- 11:25 AM Changeset in webkit [221686] by
-
- 18 edits1 copy1 delete in trunk/Tools
WSL should correctly handle the interaction between casting operators and complex types
https://bugs.webkit.org/show_bug.cgi?id=176316
Reviewed by Filip Pizlo.
This allows the standard library to include all identity cast operators for all exsting
and yet-to-exist types. The standard library now has a function with the signature:
operator T<><T>(T). This means "for all T, define a cast operator from T to T<>." The
duplicate <>s lets us say things like operator OutputVector<T><T>(InputVector<T> x).
For testing, this patch also adds the ability to cast an arbitrary Equatable type to bool,
by comparing the value to the default value for that type.
- WebGPUShadingLanguageRI/All.js:
- WebGPUShadingLanguageRI/CastExpression.js: Copied from Tools/WebGPUShadingLanguageRI/NativeFuncInstance.js.
(CastExpression):
(CastExpression.prototype.get functionName):
(CastExpression.prototype.get returnType):
(CastExpression.prototype.toString):
- WebGPUShadingLanguageRI/Checker.js:
- WebGPUShadingLanguageRI/Func.js:
(Func.prototype.toDeclString):
- WebGPUShadingLanguageRI/FuncInstantiator.js:
(FuncInstantiator.prototype.getUnique.Instantiate.prototype.visitNativeFunc):
(FuncInstantiator.prototype.getUnique.Instantiate):
(FuncInstantiator.prototype.getUnique):
(FuncInstantiator):
- WebGPUShadingLanguageRI/Inliner.js:
(Inliner.prototype.visitCastExpression):
(Inliner):
- WebGPUShadingLanguageRI/Intrinsics.js:
(Intrinsics):
- WebGPUShadingLanguageRI/NativeFunc.js:
- WebGPUShadingLanguageRI/NativeFuncInstance.js:
(NativeFuncInstance):
- WebGPUShadingLanguageRI/Parse.js:
(parsePossiblePrefix):
(parseFuncDecl):
(parseOperatorFuncDefValues): Deleted.
(parseNonOperatorFuncDefValues): Deleted.
(parseGenericFuncDefValues): Deleted.
- WebGPUShadingLanguageRI/Prepare.js:
(prepare):
- WebGPUShadingLanguageRI/Program.js:
(Program.prototype.resolveFuncOverload):
- WebGPUShadingLanguageRI/ResolveOverloadImpl.js:
(resolveOverloadImpl):
- WebGPUShadingLanguageRI/Rewriter.js:
(Rewriter.prototype.processDerivedCallData):
(Rewriter.prototype.visitCastExpression):
(Rewriter.prototype.visitCallExpression):
- WebGPUShadingLanguageRI/StandardLibrary.js: Removed.
- WebGPUShadingLanguageRI/Test.html:
- WebGPUShadingLanguageRI/Test.js:
- WebGPUShadingLanguageRI/TypeDefResolver.js:
(TypeDefResolver):
(TypeDefResolver.prototype.visitFuncDef): Deleted.
- WebGPUShadingLanguageRI/Visitor.js:
(Visitor.prototype.visitCastExpression):
- 11:16 AM Changeset in webkit [221685] by
-
- 1 edit5 adds in trunk/PerformanceTests
We should have more tests of tail calls
https://bugs.webkit.org/show_bug.cgi?id=175754
Reviewed by Sam Weinig.
This introduces a new test suite called TailBench9000, which will have benchmarks written in
JavaScript that avoid all looping except by tail call. As a warmup, I wrote a mergesort
benchmark and I proted n-body to use tail calls instead of for loops.
- TailBench9000: Added.
- TailBench9000/merge-sort-run.js: Added.
- TailBench9000/merge-sort.js: Added.
(TEST_mergeSort.createRNG):
(TEST_mergeSort.):
(TEST_mergeSort.merge):
(TEST_mergeSort.mergeSorted):
(TEST_mergeSort.checkSorted.check):
(TEST_mergeSort.checkSorted):
(TEST_mergeSort.add):
(TEST_mergeSort.build):
(TEST_mergeSort.compare):
(TEST_mergeSort.checkSpectrum):
(TEST_mergeSort.buildArray):
(TEST_mergeSort):
- TailBench9000/n-body-run.js: Added.
- TailBench9000/n-body.js: Added.
(TEST_nBody.Body):
(TEST_nBody.Body.prototype.offsetMomentum):
(TEST_nBody.Jupiter):
(TEST_nBody.Saturn):
(TEST_nBody.Uranus):
(TEST_nBody.Neptune):
(TEST_nBody.Sun):
(TEST_nBody.NBodySystem):
(TEST_nBody.NBodySystem.prototype.advance):
(TEST_nBody.NBodySystem.prototype.energy):
(TEST_nBody):
- 10:47 AM Changeset in webkit [221684] by
-
- 2 edits in trunk/Source/WebCore
[Win] Compile errors in Document::updateTitleElement.
https://bugs.webkit.org/show_bug.cgi?id=176381
Reviewed by Alex Christensen.
MSVC is not able to compile the statement:
'auto result = boolExpression ? lambda1 : lambda2;'
where 'lambda1' and 'lambda2' have the same signature.
- dom/Document.cpp:
(WebCore::findHTMLTitle):
(WebCore::isHTMLTitle):
(WebCore::isHTMLTitleEligible):
(WebCore::findSVGTitle):
(WebCore::isSVGTitle):
(WebCore::isSVGTitleEligible):
(WebCore::Document::updateTitleElement):
- 10:30 AM Changeset in webkit [221683] by
-
- 15 edits2 adds in trunk
Deny third-party cookie creation for prevalent resources without interaction
https://bugs.webkit.org/show_bug.cgi?id=175232
<rdar://problem/33709386>
Reviewed by Alex Christensen.
Source/WebCore:
Prior to Intelligent Tracking Prevention, WebKit would deny the ability to create a third party cookie if the user's
settings prohibited it. Due to the internal mechanics of cookie partitioning, we now accept the third party cookie,
but destroy it at some arbitrary moment which is difficult for websites to work with.
This patch revises WebKit so that attempts to set third party cookies without user interaction fails immediately,
which is what sites are expecting from Safari.
Tests: http/tests/loading/resourceLoadStatistics/third-party-cookie-with-and-without-user-interaction.html
- platform/network/NetworkStorageSession.h:
- platform/network/cf/NetworkStorageSessionCFNet.cpp:
(WebCore::NetworkStorageSession::shouldPartitionCookies const): Revise for new naming.
(WebCore::NetworkStorageSession::shouldAllowThirdPartyCookies const): Allow third party cookies when the
user interaction property applies.
(WebCore::NetworkStorageSession::shouldBlockCookies const): Deny cookies for origins that are not allowed by
user interaction, and that are not being partitioned.
(WebCore::NetworkStorageSession::setPrevalentDomainsWithAndWithoutInteraction): Revise for new naming, and
to track prevalent origins with and without user interaction.
(WebCore::NetworkStorageSession::setShouldPartitionCookiesForHosts): Renamed to setPrevalentDomainsWithAndWithoutInteraction.
(WebCore::NetworkStorageSession::removePrevalentDomains): New helper function for testing.
Source/WebKit:
Prior to Intelligent Tracking Prevention, WebKit would deny the ability to create a third party cookie if the user's
settings prohibited it. Due to the internal mechanics of cookie partitioning, we now accept the third party cookie,
but destroy it at some arbitrary moment which is difficult for websites to work with.
This patch revises WebKit so that attempts to set third party cookies without user interaction fails immediately,
which is what sites are expecting from Safari.
- NetworkProcess/NetworkProcess.cpp:
(WebKit::NetworkProcess::updatePrevalentDomainsWithAndWithoutInteraction):
(WebKit::NetworkProcess::updateCookiePartitioningForTopPrivatelyOwnedDomains): Renamed to updatePrevalentDomainsWithAndWithoutInteraction.
- NetworkProcess/NetworkProcess.h:
- NetworkProcess/NetworkProcess.messages.in: Renamed the UpdateCookiePartitioningForTopPrivatelyOwnedDomains message
to UpdatePrevalentDomainsWithAndWithoutInteraction.
- NetworkProcess/cocoa/NetworkDataTaskCocoa.mm:
(WebKit::NetworkDataTaskCocoa::NetworkDataTaskCocoa): Recognize cases where a network session should block cookies, and
use the stateless session so we fail immediately when attempting an invalid cookie set operation.
- UIProcess/API/Cocoa/WKWebsiteDataStore.mm:
(WebKit::WKWebsiteDataStore::_resourceLoadStatisticsSetShouldPartitionCookies): Use new helper function to clear partitioning state.
- UIProcess/WebResourceLoadStatisticsStore.cpp:
(WebKit::WebResourceLoadStatisticsStore::WebResourceLoadStatisticsStore): Update for revised naming.
(WebKit::WebResourceLoadStatisticsStore::updateCookiePartitioning): Track domains with and without interaction so that we can recognize
domains that should be immediately blocked from setting cookies.
(WebKit::WebResourceLoadStatisticsStore::updateCookiePartitioningForDomains): Update for revised naming.
(WebKit::WebResourceLoadStatisticsStore::scheduleClearPartitioningStateForDomains): Added helper function for testing.
- UIProcess/WebResourceLoadStatisticsStore.h:
- UIProcess/WebsiteData/WebsiteDataStore.cpp:
(WebKit::WebsiteDataStore::updatePrevalentDomainsWithAndWithoutInteraction): Update for revised naming.
(WebKit::WebsiteDataStore::enableResourceLoadStatisticsAndSetTestingCallback): Ditto.
(WebKit::WebsiteDataStore::updateCookiePartitioningForTopPrivatelyOwnedDomains): Renamed to updatePrevalentDomainsWithAndWithoutInteraction.
- UIProcess/WebsiteData/WebsiteDataStore.h:
LayoutTests:
- http/tests/loading/resourceLoadStatistics/third-party-cookie-with-and-without-user-interaction-expected.txt: Added.
- http/tests/loading/resourceLoadStatistics/third-party-cookie-with-and-without-user-interaction.html: Added.
- platform/mac-highsierra-wk2/TestExpectations: Add new test expectation.
- 10:24 AM Changeset in webkit [221682] by
-
- 2 edits in trunk/LayoutTests
Layout Test http/tests/preload/single_download_preload.html is flaky.
https://bugs.webkit.org/show_bug.cgi?id=176465.
Unreviewed test gardening.
- platform/win/TestExpectations:
- 10:05 AM Changeset in webkit [221681] by
-
- 2 edits in trunk/Source/WebKit
[WPE][CMake] Fix path to the WebKitApplicationInfo.h header.
Unreviewed build fix.
This doesn't really make a difference for the build bots, but it makes
it possible to craft working release tarballs of WPE.
- PlatformWPE.cmake: Use the WPE version of WebKitApplicationInfo.h
- 10:02 AM Changeset in webkit [221680] by
-
- 2 edits10 adds in trunk/LayoutTests
[WPE] Add missing test expectations
https://bugs.webkit.org/show_bug.cgi?id=176453
Unreviewed test gardening.
Patch by Ms2ger <Ms2ger@igalia.com> on 2017-09-06
- platform/wpe/TestExpectations:
- platform/wpe/fast/events/context-no-deselect-expected.txt: Added.
- platform/wpe/fast/events/event-listener-on-link-expected.txt: Added.
- platform/wpe/fast/events/ghostly-mousemoves-in-subframe-expected.txt: Added.
- platform/wpe/fast/events/onload-re-entry-expected.txt: Added.
- platform/wpe/fast/events/pointer-events-2-expected.txt: Added.
- platform/wpe/fast/events/resize-events-expected.txt: Added.
- platform/wpe/fast/events/reveal-link-when-focused-expected.txt: Added.
- platform/wpe/fast/events/updateLayoutForHitTest-expected.txt: Added.
- platform/wpe/fast/inspector-support/matchedrules-expected.txt: Added.
- 9:55 AM Changeset in webkit [221679] by
-
- 2 edits in trunk/Tools
Copy WebKit Permalink may generate wrong URL with SVN checkout
https://bugs.webkit.org/show_bug.cgi?id=176427
Reviewed by Darin Adler.
Fixes an issue where Copy WebKit Permalink would generate an incorrect URL for
any file not in the top-level directory of the repository when using an SVN
checkout of WebKit.
Copy WebKit Permalink changes directories to the containing directory D of the
active Xcode document F before running "svn info <path to F>". Currently we use
the value of "Path" from the output of "svn info" when generating the permalink.
This path is relative to D. But we want the path to F relative to the top-level
checkout directory. We need to explicitly compute this.
- CopyPermalink/Copy WebKit Permalink.workflow/Contents/document.wflow:
- 9:39 AM Changeset in webkit [221678] by
-
- 1800 edits in trunk/LayoutTests
Unreviewed GTK+ gardening. Rebaseline tests after Freetype version bump in r221670. Part 7.
- 9:37 AM Changeset in webkit [221677] by
-
- 2 edits in trunk/Source/WebCore
Missing break in URLParser
https://bugs.webkit.org/show_bug.cgi?id=176357
Reviewed by Darin Adler.
Add a missing break so the currently set state is not overwritten
after the block. Found by Coverity scan.
- platform/URLParser.cpp:
(WebCore::URLParser::parse):
- 9:25 AM Changeset in webkit [221676] by
-
- 945 edits304 adds in trunk/LayoutTests
Unreviewed GTK+ gardening. Rebaseline tests after Freetype version bump in r221670. Part 6.
- 9:15 AM Changeset in webkit [221675] by
-
- 1457 edits1 copy4 adds in trunk/LayoutTests
Unreviewed GTK+ gardening. Rebaseline tests after Freetype version bump in r221670. Part 5.
- 9:11 AM WebKitGTK/Gardening/Calendar edited by
- (diff)
- 9:04 AM Changeset in webkit [221674] by
-
- 1806 edits1 copy2 adds in trunk/LayoutTests
Unreviewed GTK+ gardening. Rebaseline tests after Freetype version bump in r221670. Part 4.
- 8:51 AM Changeset in webkit [221673] by
-
- 1791 edits in trunk/LayoutTests
Unreviewed GTK+ gardening. Rebaseline tests after Freetype version bump in r221670. Part 3.
- 8:37 AM Changeset in webkit [221672] by
-
- 1562 edits in trunk/LayoutTests
Unreviewed GTK+ gardening. Rebaseline tests after Freetype version bump in r221670. Part 2.
- 8:25 AM Changeset in webkit [221671] by
-
- 1853 edits in trunk/LayoutTests
Unreviewed GTK+ gardening. Rebaseline tests after Freetype version bump in r221670. Part 1.
- 8:10 AM Changeset in webkit [221670] by
-
- 4 edits1 delete in trunk
[GTK] Bump freetype version to 2.8.0
https://bugs.webkit.org/show_bug.cgi?id=176351
Source/WebCore:
Patch by Dominik Röttsches <dominik.rottsches@intel.com> on 2017-09-06
Reviewed by Carlos Alberto Lopez Perez.
Retrieving line spacing info without metrics hinting - FreeType's metric hinting
uses rounding which results in the sum of ascent and descent being larger
than the line height. To work around this without globally disabling font metrics
hinting, I am temporarily creating a new cairo scaled font with metrics hinting
off and retrieving the height values from this one.
- platform/graphics/freetype/SimpleFontDataFreeType.cpp:
(WebCore::scaledFontWithoutMetricsHinting): New function to clone the existing font, only with metrics hinting
disabled.
(WebCore::Font::platformInit): Get height info from non-metrics hinted font, disable rounding for linespacing.
Tools:
Reviewed by Carlos Alberto Lopez Perez.
Remove the patch we were using since it was reverted upstream.
- gtk/jhbuild.modules:
- gtk/patches/freetype6-2.4.11-truetype-font-height-fix.patch: Removed.
- 7:52 AM WebKitGTK/2.16.x edited by
- (diff)
- 5:42 AM Changeset in webkit [221669] by
-
- 7 edits4 adds in trunk/Source
Introduce ScrollingTreeScrollingNodeDelegateIOS to share code between overflow and frame scrolling
https://bugs.webkit.org/show_bug.cgi?id=174097
Patch by Frédéric Wang <fwang@igalia.com> on 2017-09-06
Reviewed by Darin Adler.
Source/WebCore:
No new tests, behavior unchanged.
- WebCore.xcodeproj/project.pbxproj: Add ScrollingTreeScrollingNodeDelegate.
- page/scrolling/ScrollingTreeScrollingNode.h: Make ScrollingTreeScrollingNodeDelegate a
friend so that it can access private members.
- page/scrolling/ScrollingTreeScrollingNodeDelegate.cpp: Added. New delegate class for a
scrolling node, which is used by the UI process.
(WebCore::ScrollingTreeScrollingNodeDelegate::ScrollingTreeScrollingNodeDelegate):
Constructor, taking the scrolling node as a parameter.
(WebCore::ScrollingTreeScrollingNodeDelegate::~ScrollingTreeScrollingNodeDelegate):
(WebCore::ScrollingTreeScrollingNodeDelegate::scrollingTree const): Expose the scrolling
tree containing the scrolling node.
(WebCore::ScrollingTreeScrollingNodeDelegate::lastCommittedScrollPosition const): Expose
the last committed scroll position of the scrolling node.
- page/scrolling/ScrollingTreeScrollingNodeDelegate.h: Added.
(WebCore::ScrollingTreeScrollingNodeDelegate::scrollingNode): Expose the scrolling node.
(WebCore::ScrollingTreeScrollingNodeDelegate::scrollingNode const): Ditto.
Source/WebKit:
This patch introduces a new ScrollingTreeScrollingNodeDelegateIOS that can be used by
WKOverflowScrollViewDelegate to communicate to the scrolling tree and nodes. It can also be
used as a helper class by ScrollingTreeOverflowScrollingNodeIOS. For now, only the non-
overriden member functions of ScrollingTreeOverflowScrollingNodeIOS are moved to that new
class. In follow-up commits, WKOverflowScrollViewDelegate can become a generic
ScrollViewDelegate and more code can be moved into the ScrollingTreeScrollingNodeDelegateIOS
file. Frame scrolling nodes will then be able to share the same UI code as overflow:auto when
iOS frame scrolling is implemented (bug 149264).
- UIProcess/RemoteLayerTree/ios/ScrollingTreeOverflowScrollingNodeIOS.h: Move non-overriden member
functions and m_updatingFromStateNode into the delegate class. Also define a member to store
that delegate.
- UIProcess/RemoteLayerTree/ios/ScrollingTreeOverflowScrollingNodeIOS.mm: Use the node delegate to
communicate to the scrolling tree and node.
(-[WKOverflowScrollViewDelegate initWithScrollingTreeNodeDelegate:]): Init with a delegate.
(-[WKOverflowScrollViewDelegate scrollViewDidScroll:]): Call the delegate function.
(-[WKOverflowScrollViewDelegate scrollViewWillBeginDragging:]): Ditto.
(-[WKOverflowScrollViewDelegate scrollViewWillEndDragging:withVelocity:targetContentOffset:]):
Use the delegate functions or pass by ScrollingTreeScrollingNodeDelegateIOS::scrollingNode().
(-[WKOverflowScrollViewDelegate scrollViewDidEndDragging:willDecelerate:]): Use the delegate
functions.
(-[WKOverflowScrollViewDelegate scrollViewDidEndDecelerating:]): Ditto.
(WebKit::ScrollingTreeOverflowScrollingNodeIOS::ScrollingTreeOverflowScrollingNodeIOS):
Init the delegate for this class.
(WebKit::ScrollingTreeOverflowScrollingNodeIOS::commitStateAfterChildren): Use the delegate.
(WebKit::ScrollingTreeOverflowScrollingNodeIOS::setScrollLayerPosition): Use the delegate
function.
(WebKit::ScrollingTreeOverflowScrollingNodeIOS::updateLayersAfterDelegatedScroll): Ditto.
(-[WKOverflowScrollViewDelegate initWithScrollingTreeNode:]): Deleted. This is renamed
initWithScrollingTreeNodeDelegate and accepts a delegate.
(WebKit::ScrollingTreeOverflowScrollingNodeIOS::updateChildNodesAfterScroll): Deleted. Moved
to ScrollingTreeScrollingNodeDelegateIOS.
(WebKit::ScrollingTreeOverflowScrollingNodeIOS::overflowScrollWillStart): Ditto.
(WebKit::ScrollingTreeOverflowScrollingNodeIOS::overflowScrollDidEnd): Ditto.
(WebKit::ScrollingTreeOverflowScrollingNodeIOS::overflowScrollViewWillStartPanGesture): Ditto.
(WebKit::ScrollingTreeOverflowScrollingNodeIOS::scrollViewDidScroll): Ditto.
(WebKit::ScrollingTreeOverflowScrollingNodeIOS::currentSnapPointIndicesDidChange): Ditto.
- UIProcess/RemoteLayerTree/ios/ScrollingTreeScrollingNodeDelegateIOS.h: Added. New delegate class
for ScrollingTreeOverflowScrollingNodeIOS. The members used by WKOverflowScrollViewDelegate
are public and the others are private. ScrollingTreeOverflowScrollingNodeIOS is a friend of
ScrollingTreeScrollingNodeDelegateIOS so that it can access private members e.g.
updateChildNodesAfterScroll() or m_updatingFromStateNode.
- UIProcess/RemoteLayerTree/ios/ScrollingTreeScrollingNodeDelegateIOS.mm: Added.
(WebKit::ScrollingTreeScrollingNodeDelegateIOS::ScrollingTreeScrollingNodeDelegateIOS):
(WebKit::ScrollingTreeScrollingNodeDelegateIOS::~ScrollingTreeScrollingNodeDelegateIOS):
(WebKit::ScrollingTreeScrollingNodeDelegateIOS::updateChildNodesAfterScroll): Code extracted
from ScrollingTreeOverflowScrollingNodeIOS.
(WebKit::ScrollingTreeScrollingNodeDelegateIOS::scrollWillStart): Ditto.
(WebKit::ScrollingTreeScrollingNodeDelegateIOS::scrollDidEnd): Ditto.
(WebKit::ScrollingTreeScrollingNodeDelegateIOS::scrollViewWillStartPanGesture): Ditto.
(WebKit::ScrollingTreeScrollingNodeDelegateIOS::scrollViewDidScroll): Ditto.
(WebKit::ScrollingTreeScrollingNodeDelegateIOS::currentSnapPointIndicesDidChange): Ditto.
- WebKit.xcodeproj/project.pbxproj: Add ScrollingTreeScrollingNodeDelegateIOS files to the
build system.
- 3:54 AM WebKitGTK/Debugging edited by
- (diff)
- 2:59 AM Changeset in webkit [221668] by
-
- 8 edits2 adds in trunk
[css-grid] grid shorthand should not reset the gutter properties
https://bugs.webkit.org/show_bug.cgi?id=176375
Reviewed by Sergio Villar Senin.
LayoutTests/imported/w3c:
Import new test from WPT.
- web-platform-tests/css/css-grid-1/grid-definition/grid-shorthand-001-expected.txt: Added.
- web-platform-tests/css/css-grid-1/grid-definition/grid-shorthand-001.html: Added.
- web-platform-tests/css/css-grid-1/grid-definition/w3c-import.log:
Source/WebCore:
The CSS WG has resolved that the "grid" shorthand shouldn't reset
the gutter properties anymore:
https://github.com/w3c/csswg-drafts/issues/1036
This was originally implemented in r195529, so this is somehow
a revert of that change.
Test: imported/w3c/web-platform-tests/css/css-grid-1/grid-definition/grid-shorthand-001.html
- css/CSSProperties.json:
- css/parser/CSSPropertyParser.cpp:
(WebCore::CSSPropertyParser::consumeGridShorthand):
LayoutTests:
Update the test to check the new behavior.
- fast/css-grid-layout/grid-shorthand-get-set-expected.txt:
- fast/css-grid-layout/grid-shorthand-get-set.html:
- 1:17 AM Changeset in webkit [221667] by
-
- 11 edits2 adds in trunk
[WebGL2] Implement getActiveUniforms()
https://bugs.webkit.org/show_bug.cgi?id=175203
Reviewed by Darin Adler.
Source/WebCore:
Align getActiveUniforms() WebIDL signature with the spec -- making it
return a WebGLAny object, making the program parameter non-nullable,
and making the uniformIndices parameter a sequence on GLuint values.
The getActiveUniforms() implementation in WebGL2RenderingContext
validates the passed-in program and parameter name and then calls the
GraphicsContext3D::getActiveUniforms() method, retrieving an array of
integers that represent values of the requested parameter name for
each uniform whose index was passed through uniformIndices.
Test: fast/canvas/webgl/webgl2-getActiveUniforms.html
- bindings/js/JSDOMConvertWebGL.cpp:
(WebCore::convertToJSValue):
- html/canvas/WebGL2RenderingContext.cpp:
(WebCore::WebGL2RenderingContext::getActiveUniforms):
- html/canvas/WebGL2RenderingContext.h:
- html/canvas/WebGL2RenderingContext.idl:
- html/canvas/WebGLAny.h:
- platform/graphics/GraphicsContext3D.h:
- platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:
(WebCore::GraphicsContext3D::getActiveUniforms):
LayoutTests:
Add a basic gl.getActiveUniforms() test that checks proper return values
for a mat4 uniform in the simple vertex shader that's used when creating
the 'standard' program through webgl-test.js utilities. The test remains
skipped on GTK+ and Windows (WebGL 2.0 disabled). Mac port skips it as
well since the shader can't be compiled properly. WPE and iOS run the
test and are passing it.
- fast/canvas/webgl/webgl2-getActiveUniforms-expected.txt: Added.
- fast/canvas/webgl/webgl2-getActiveUniforms.html: Added.
- platform/gtk/TestExpectations:
- platform/mac/TestExpectations:
- 12:23 AM Changeset in webkit [221666] by
-
- 2 edits in trunk/Tools
[Win] Tools/TestWebKitAPI/Tests/WTF/PriorityQueue.cpp fails to compile with MSVC 2015
https://bugs.webkit.org/show_bug.cgi?id=176442
Patch by Yoshiaki Jitsukawa <Yoshiaki.Jitsukawa@sony.com> on 2017-09-06
Reviewed by Keith Miller.
- TestWebKitAPI/Tests/WTF/PriorityQueue.cpp:
(TEST):
