⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Oct 2, 2017:

11:42 PM Changeset in webkit [222771] by mmaxfield@apple.com
  • 8 edits
    2 moves in trunk/Source

Move LineEnding.{h,cpp} from WebCore/platform/text to wtf/text
​https://bugs.webkit.org/show_bug.cgi?id=176575

Reviewed by Alex Christensen.

Source/WebCore:

No new tests because there is no behavior change.

  • WebCore.xcodeproj/project.pbxproj:
  • fileapi/BlobBuilder.cpp:
  • html/FormDataList.cpp:

Source/WTF:

As part of the PAL effort, we're trying to move everything out of WebCore/platform, one-by-one.
These LineEnding files belong in WTF.

  • WTF.xcodeproj/project.pbxproj:
  • wtf/text/LineEnding.cpp: Renamed from Source/WebCore/platform/text/LineEnding.cpp.

(WTF::normalizeLineEndingsToCRLF):

  • wtf/text/LineEnding.h: Renamed from Source/WebCore/platform/text/LineEnding.h.
11:36 PM Changeset in webkit [222770] by mmaxfield@apple.com
  • 2 edits in trunk/Tools

Make WSL demo compatible with Microsoft Edge
​https://bugs.webkit.org/show_bug.cgi?id=177643

Reviewed by Saam Barati.

This patch does two things. The first is it migrates a loop over ParentNode.children to a legacy style loop
because Microsoft Edge throws an exception when trying to use a for...of loop with it. This patch also hides
the compilation behind a setTimeout(0) so there is some indication that something is happening during a
compile.

  • Tools/WebGPUShadingLanguageRI/index.html:
10:31 PM Changeset in webkit [222769] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebCore

Web Inspector: Rename methods ending in *Json() as *JSON()
​https://bugs.webkit.org/show_bug.cgi?id=177793

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2017-10-02
Reviewed by Matt Baker.

  • inspector/InspectorNetworkAgent.cpp:

(WebCore::InspectorNetworkAgent::buildObjectForCachedResource):
(WebCore::InspectorNetworkAgent::willSendRequest):
(WebCore::InspectorNetworkAgent::didReceiveResponse):

  • inspector/InspectorPageAgent.cpp:

(WebCore::InspectorPageAgent::resourceTypeJSON):
(WebCore::InspectorPageAgent::cachedResourceTypeJSON):
(WebCore::InspectorPageAgent::buildObjectForFrameTree):
(WebCore::InspectorPageAgent::resourceTypeJson): Deleted.
(WebCore::InspectorPageAgent::cachedResourceTypeJson): Deleted.

  • inspector/InspectorPageAgent.h:
10:10 PM Changeset in webkit [222768] by Wenson Hsieh
  • 5 edits
    2 adds in trunk

REGRESSION(r222595): Intermittent crash while accessing DataTransferItemList
​https://bugs.webkit.org/show_bug.cgi?id=177791
<rdar://problem/34781456>

Reviewed by Ryosuke Niwa.

Source/WebCore:

DataTransfer::moveDragState() currently attempts to move the other DataTransfer's DataTransferItemList and
DragImageLoader as members of its own. This is incorrect, since both of these entities hold raw references of
some form to the other DataTransfer, yet they are held as unique_ptrs in the new DataTransfer. To fix this, we
(1) remove the line of code that moves the item list, since item lists will be lazily generated on the new
DataTransfer anyways, and (2) update the DataTransfer pointer on the old DataTransfer's DragImageLoader after
moving it to the new DataTransfer.

Test: editing/pasteboard/drag-end-crash-accessing-item-list.html

  • dom/DataTransfer.cpp:

(WebCore::DragImageLoader::moveToDataTransfer):
(WebCore::DataTransfer::moveDragState):

LayoutTests:

Add a new layout test that simulates the crash encountered in this bug by forcing a garbage collection sweep
right before accessing the pasteboard in a "dragend" event handler.

  • TestExpectations:
  • editing/pasteboard/drag-end-crash-accessing-item-list-expected.txt: Added.
  • editing/pasteboard/drag-end-crash-accessing-item-list.html: Added.
  • platform/mac-wk1/TestExpectations:
9:35 PM Changeset in webkit [222767] by Chris Dumez
  • 5 edits in trunk/Source/WebCore

Rename computeSharedStringHash() overload taking a URL to computedVisitedLinkHash()
​https://bugs.webkit.org/show_bug.cgi?id=177776

Reviewed by Alex Christensen.

  • dom/VisitedLinkState.cpp:

(WebCore::linkHashForElement):
(WebCore::VisitedLinkState::determineLinkStateSlowCase):

  • html/HTMLAnchorElement.h:

(WebCore::HTMLAnchorElement::visitedLinkHash const):

  • platform/SharedStringHash.cpp:

(WebCore::computeVisitedLinkHash):

  • platform/SharedStringHash.h:
8:07 PM Changeset in webkit [222766] by Brent Fulgham
  • 1 edit
    6 adds in trunk/LayoutTests

Merge three Blink test cases
​https://bugs.webkit.org/show_bug.cgi?id=177797
<rdar://problem/27331975>

Unreviewed merge of Blink test cases.

Merge three test cases from the following Blink change:

​https://chromium.googlesource.com/chromium/blink/+/17c5b48f130e4ebb796f9db89628f887624db4ef

Relevant fixes had been made in WebKit over the years, but we did not include proper
test coverage.

  • fast/dom/assertion-on-node-removal-expected.txt: Added.
  • fast/dom/assertion-on-node-removal.html: Added.
  • fast/forms/control-detach-crash-expected.txt: Added.
  • fast/forms/control-detach-crash.html: Added.
  • svg/custom/assert-on-node-removal-expected.txt: Added.
  • svg/custom/assert-on-node-removal.html: Added.
6:02 PM Changeset in webkit [222765] by jdiggs@igalia.com
  • 5 edits
    2 adds in trunk

AX: [ATK] The value of aria-level is not exposed on non-heading roles
​https://bugs.webkit.org/show_bug.cgi?id=177775

Reviewed by Chris Fleizach.

Source/WebCore:

Expose the value of aria-level via the "level" AtkObject attribute, as is currently
done for headings.

Test: accessibility/gtk/aria-level.html

  • accessibility/atk/WebKitAccessibleWrapperAtk.cpp:

(webkitAccessibleGetAttributes):

Tools:

  • WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:

(WTR::AccessibilityUIElement::hierarchicalLevel const):

LayoutTests:

  • accessibility/gtk/aria-level-expected.txt: Added.
  • accessibility/gtk/aria-level.html: Added.
5:42 PM Changeset in webkit [222764] by ggaren@apple.com
  • 4 edits in trunk

WeakPtr should have a move constructor
​https://bugs.webkit.org/show_bug.cgi?id=177789

Reviewed by Chris Dumez.

Source/WTF:

  • wtf/WeakPtr.h: Now that we just have a RefPtr data member,

the default operators are sufficient.

Tools:

Chris made me write an API test. It wasn't that painful.

  • TestWebKitAPI/Tests/WTF/WeakPtr.cpp:

(TestWebKitAPI::TEST):

5:37 PM Changeset in webkit [222763] by aestes@apple.com
  • 5 edits in trunk

[Payment Request] Validate payment method identifiers
​https://bugs.webkit.org/show_bug.cgi?id=177794

Reviewed by Sam Weinig.

LayoutTests/imported/w3c:

  • web-platform-tests/payment-request/payment-request-ctor-pmi-handling.https-expected.txt:

Source/WebCore:

  • Modules/paymentrequest/PaymentRequest.cpp:

(WebCore::isValidStandardizedPaymentMethodIdentifier):
(WebCore::isValidURLBasedPaymentMethodIdentifier):
(WebCore::convertAndValidatePaymentMethodIdentifier):
(WebCore::PaymentRequest::create):

  • Modules/paymentrequest/PaymentRequest.h:
5:29 PM Changeset in webkit [222762] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Escape more characters in posix string conversion
​https://bugs.webkit.org/show_bug.cgi?id=177761
<rdar://problem/34506832>

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2017-10-02
Reviewed by Brian Burg.

  • UserInterface/Models/Resource.js:

(WI.Resource.prototype.generateCURLCommand.escapeStringPosix):
Escape '!' to '\041' in posix strings ($'...') since '!' may have special behavior at times.

5:22 PM Changeset in webkit [222761] by rniwa@webkit.org
  • 10 edits in trunk/Source

Move more code into PasteboardCustomData
​https://bugs.webkit.org/show_bug.cgi?id=177795

Reviewed by Wenson Hsieh.

Source/WebCore:

Moved sharedBufferFromCustomData, customDataFromSharedBuffer, and customWebKitPasteboardDataType into
PasteboardCustomData as createSharedBuffer, fromSharedBuffer, and cocoaType respectively.

  • platform/Pasteboard.cpp:

(WebCore::PasteboardCustomData::createSharedBuffer const): Renamed from sharedBufferFromCustomData.
(WebCore::PasteboardCustomData::fromSharedBuffer): Renamed from customDataFromSharedBuffer.

  • platform/Pasteboard.h:
  • platform/StaticPasteboard.cpp:

(WebCore::StaticPasteboard::commitToPasteboard): Now initializes with an empty origin string.

  • platform/cocoa/PasteboardCocoa.mm:

(WebCore::PasteboardCustomData::cocoaType): Moved here from Pasteboard.h
(WebCore::Pasteboard::readStringInCustomData):

  • platform/ios/PlatformPasteboardIOS.mm:

(WebCore::PlatformPasteboard::typesSafeForDOMToReadAndWrite const):
(WebCore::PlatformPasteboard::write):

  • platform/ios/WebItemProviderPasteboard.mm:

(-[WebItemProviderPasteboard typeIdentifiersToLoadForRegisteredTypeIdentfiers:]):

  • platform/mac/PlatformPasteboardMac.mm:

(WebCore::PlatformPasteboard::typesSafeForDOMToReadAndWrite const):
(WebCore::PlatformPasteboard::write):

Source/WebKit:

Added the support for encoding and decoding the origin string in PasteboardCustomData.

  • Shared/WebCoreArgumentCoders.cpp:

(IPC::ArgumentCoder<PasteboardCustomData>::encode):
(IPC::ArgumentCoder<PasteboardCustomData>::decode):

5:13 PM Changeset in webkit [222760] by Brent Fulgham
  • 6 edits in trunk

[Mac] Use safer decoding practices for NSKeyedUnarchiver
​https://bugs.webkit.org/show_bug.cgi?id=175887
<rdar://problem/33435281>

Reviewed by Daniel Bates.

Source/WebCore:

  • loader/archive/cf/LegacyWebArchiveMac.mm:

(WebCore::LegacyWebArchive::createResourceResponseFromMacArchivedData): Use NSSecureCoding to unarchive.
(WebCore::LegacyWebArchive::createPropertyListRepresentation): Ditto for archiving.

  • testing/cocoa/WebArchiveDumpSupport.mm:

(WebCoreTestSupport::createCFURLResponseFromResponseData): Update to use NSSecureCoding if possible.

LayoutTests:

Mark two tests as flaky for now, until the relevant CFNetwork changes are available on the test systems.

  1. webarchive/loading/cache-expired-subresource.html
  2. webarchive/loading/test-loading-archive-subresource-null-mimetype.html
  • platform/ios/TestExpectations:
  • platform/mac/TestExpectations:
5:09 PM WebKitGTK/2.18.x edited by Adrian Perez de Castro
(diff)
4:55 PM Changeset in webkit [222759] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebInspectorUI

Web Inspector: Selecting child layers with keyboard causes Compositing Reason popover to become misaligned
​https://bugs.webkit.org/show_bug.cgi?id=150551

Patch by Ross Kirsling <Ross Kirsling> on 2017-10-02
Reviewed by Matt Baker.

content setter should only be used when NOT repositioning the popover.
presentNewContentWithFrame exists to update content and position at once.

  • UserInterface/Views/LayerDetailsSidebarPanel.js:

(WI.LayerDetailsSidebarPanel.prototype._showPopoverForSelectedNode):
(WI.LayerDetailsSidebarPanel.prototype._presentPopover):
Fix new sidebar.

  • UserInterface/Views/LayerTreeDetailsSidebarPanel.js:

(WI.LayerTreeDetailsSidebarPanel.prototype._updatePopoverForSelectedNode):
Fix legacy sidebar.

4:44 PM Changeset in webkit [222758] by dbates@webkit.org
  • 3 edits in trunk/Source/WebCore

Use InlineTextBox::lineFont() in more places
​https://bugs.webkit.org/show_bug.cgi?id=177749

Reviewed by Zalan Bujtas.

Currently InlineTextBox::paint() calls InlineTextBox::lineFont() to compute the font for the
line and then passes this value to various paint helper functions. The computation is not
expensive and it is sufficient to have the individual paint helper functions compute it
directly. We should have the individual paint helper functions compute it directly. This
will help towards sharing more code throughout InlineTextBox by reducing the noise of
passing the font for the line.

No functionality changed. So, no new tests.

  • rendering/InlineTextBox.cpp:

(WebCore::InlineTextBox::paint):
(WebCore::InlineTextBox::paintSelection):
(WebCore::InlineTextBox::paintTextSubrangeBackground):
(WebCore::InlineTextBox::paintCompositionBackground):
(WebCore::InlineTextBox::paintTextMatchMarker):
(WebCore::InlineTextBox::paintDecoration):
(WebCore::InlineTextBox::paintDocumentMarker):
(WebCore::InlineTextBox::paintDocumentMarkers):

  • rendering/InlineTextBox.h:
4:40 PM Changeset in webkit [222757] by jmarcell@apple.com
  • 7 edits in branches/safari-604-branch/Source

Versioning.

4:34 PM Changeset in webkit [222756] by commit-queue@webkit.org
  • 8 edits in trunk/Source/WebCore

[Curl] Implement missing async method in RecourceHandle and make it actually async
​https://bugs.webkit.org/show_bug.cgi?id=173964

Patch by Basuke Suzuki <Basuke Suzuki> on 2017-10-02
Reviewed by Alex Christensen.

  • platform/network/ResourceHandle.cpp:

(WebCore::ResourceHandle::continueWillSendRequest): Deleted.
(WebCore::ResourceHandle::continueDidReceiveResponse): Deleted.
(WebCore::ResourceHandle::continueCanAuthenticateAgainstProtectionSpace): Deleted.

  • platform/network/curl/CurlRequest.cpp:

(WebCore::CurlRequest::start):
(WebCore::CurlRequest::cancel):
(WebCore::CurlRequest::suspend):
(WebCore::CurlRequest::resume):
(WebCore::CurlRequest::didReceiveHeader):
(WebCore::CurlRequest::didReceiveData):
(WebCore::CurlRequest::didCompleteTransfer):
(WebCore::CurlRequest::didCancelTransfer):
(WebCore::CurlRequest::finalizeTransfer):
(WebCore::CurlRequest::invokeDidReceiveResponseForFile):
(WebCore::CurlRequest::invokeDidReceiveResponse):
(WebCore::CurlRequest::completeDidReceiveResponse):
(WebCore::CurlRequest::setRequestPaused):
(WebCore::CurlRequest::setCallbackPaused):
(WebCore::CurlRequest::pausedStatusChanged):
(WebCore::CurlRequest::setPaused): Deleted.

  • platform/network/curl/CurlRequest.h:

(WebCore::CurlRequest::needToInvokeDidReceiveResponse const):
(WebCore::CurlRequest::isPaused const):

  • platform/network/curl/ResourceHandleCurl.cpp:

(WebCore::ResourceHandle::receivedRequestToContinueWithoutCredential):
(WebCore::ResourceHandle::continueDidReceiveResponse):
(WebCore::ResourceHandle::platformContinueSynchronousDidReceiveResponse):

  • platform/network/curl/ResourceHandleCurlDelegate.cpp:

(WebCore::ResourceHandleCurlDelegate::curlDidReceiveResponse):
(WebCore::ResourceHandleCurlDelegate::continueDidReceiveResponse):
(WebCore::ResourceHandleCurlDelegate::platformContinueSynchronousDidReceiveResponse):
(WebCore::ResourceHandleCurlDelegate::continueAfterDidReceiveResponse):
(WebCore::ResourceHandleCurlDelegate::shouldRedirectAsGET):

  • platform/network/curl/ResourceHandleCurlDelegate.h:
  • platform/network/curl/ResourceResponseCurl.cpp:

(WebCore::ResourceResponse::shouldRedirect):
(WebCore::ResourceResponse::isMovedPermanently const):
(WebCore::ResourceResponse::isFound const):
(WebCore::ResourceResponse::isSeeOther const):
(WebCore::ResourceResponse::isNotModified const):
(WebCore::ResourceResponse::isUnauthorized const):

4:33 PM Changeset in webkit [222755] by jmarcell@apple.com
  • 1 copy in tags/Safari-604.3.4

Tag Safari-604.3.4.

4:04 PM Changeset in webkit [222754] by aestes@apple.com
  • 10 edits
    18 adds in trunk/LayoutTests

[Payment Request] Update payment-request imported tests
​https://bugs.webkit.org/show_bug.cgi?id=177786

Reviewed by Zalan Bujtas.

LayoutTests/imported/w3c:

  • resources/import-expectations.json:
  • web-platform-tests/payment-request/PaymentAddress/attributes-and-toJSON-method-manual.https.html: Added.
  • web-platform-tests/payment-request/PaymentAddress/w3c-import.log: Added.
  • web-platform-tests/payment-request/algorithms-manual.https.html: Added.
  • web-platform-tests/payment-request/change-shipping-option-manual.https.html: Added.
  • web-platform-tests/payment-request/payment-request-canmakepayment-method.https.html:
  • web-platform-tests/payment-request/payment-request-constructor.https-expected.txt:
  • web-platform-tests/payment-request/payment-request-constructor.https.html:
  • web-platform-tests/payment-request/payment-request-ctor-pmi-handling.https.html:
  • web-platform-tests/payment-request/payment-response/complete-method-manual.https.html: Added.
  • web-platform-tests/payment-request/payment-response/helpers.js:

(async.runManualTest):

  • web-platform-tests/payment-request/payment-response/methodName-attribute-manual.https.html: Added.
  • web-platform-tests/payment-request/payment-response/payerEmail-attribute-manual.https.html: Added.
  • web-platform-tests/payment-request/payment-response/payerName-attribute-manual.https.html: Added.
  • web-platform-tests/payment-request/payment-response/payerPhone-attribute-manual.https.html: Added.
  • web-platform-tests/payment-request/payment-response/requestId-attribute-manual.https.html: Added.
  • web-platform-tests/payment-request/payment-response/shippingAddress-attribute-manual.https.html: Added.
  • web-platform-tests/payment-request/payment-response/shippingOption-attribute-manual.https.html: Added.
  • web-platform-tests/payment-request/rejects_if_not_active.https.html: Added.
  • web-platform-tests/payment-request/shipping-address-changed-manual.https.html: Added.
  • web-platform-tests/payment-request/updateWith-method-pmi-handling-manual.https.html: Added.
  • web-platform-tests/payment-request/user-abort-algorithm-manual.https.html: Added.
  • web-platform-tests/payment-request/user-accepts-payment-request-algo-manual.https.html: Added.
  • web-platform-tests/payment-request/w3c-import.log:

LayoutTests:

  • platform/mac-wk2/TestExpectations:
3:28 PM Changeset in webkit [222753] by Matt Lewis
  • 2 edits
    1 move
    2 adds
    1 delete in trunk/LayoutTests

Additional rebaselining of js/dom/global-constructors-attributes.html.

Unreviewed test gardening.

  • platform/mac-sierra-wk1/js/dom/global-constructors-attributes-expected.txt: Renamed from LayoutTests/platform/mac-sierra-wk2/js/dom/global-constructors-attributes-expected.txt.
  • platform/mac-wk1/js/dom/global-constructors-attributes-expected.txt:
  • platform/mac-wk2/js/dom/global-constructors-attributes-expected.txt: Removed.
3:21 PM Changeset in webkit [222752] by ggaren@apple.com
  • 2 edits in trunk/Source/WTF

NULL WeakPtr should not malloc!
​https://bugs.webkit.org/show_bug.cgi?id=177773

Reviewed by Antti Koivisto.

Translating NULL into malloc is... inefficient.

  • wtf/WeakPtr.h:

(WTF::WeakPtr::WeakPtr):
(WTF::WeakPtr::operator=):
(WTF::WeakPtr::clear): Make m_ref lazy so that a NULL m_ref can represent
a NULL pointer. Normal dereference is no slower because we can rely on
the fact that dereference of NULL should crash. operator bool() and get()
incur an extra branch. That's probably worth it to avoid malloc
for NULL.

3:10 PM Changeset in webkit [222751] by fpizlo@apple.com
  • 7 edits in trunk/Tools

WSL should be *
​https://bugs.webkit.org/show_bug.cgi?id=177705

Rubber stamped by Keith Miller.

When I first wrote the prototype, I thought it would be cool to use for pointers. Nobody agrees. I've
gotten so much feedback to use *. This changes pointers to use *.

  • WebGPUShadingLanguageRI/DereferenceExpression.js:

(DereferenceExpression.prototype.toString):
(DereferenceExpression):

  • WebGPUShadingLanguageRI/Intrinsics.js:

(Intrinsics):

  • WebGPUShadingLanguageRI/Parse.js:

(parseType):
(parsePossiblePrefix):

  • WebGPUShadingLanguageRI/PtrType.js:

(PtrType.prototype.toString):
(PtrType):

  • WebGPUShadingLanguageRI/StandardLibrary.js:
  • WebGPUShadingLanguageRI/Test.js:

(tests.simpleDereference):
(tests.dereferenceStore):
(tests.simpleMakePtr):
(tests.loadNull):
(tests.storeNull):
(tests.returnNull):
(tests.dereferenceDefaultNull):
(tests.defaultInitializedNull):
(tests.passNullToPtrMonomorphic):
(tests.passNullToPtrPolymorphic):
(tests.passNullAndNotNull):
(tests.passNullAndNotNullFullPoly):
(tests.passNullAndNotNullFullPolyReverse):
(tests.chainGeneric):
(tests.chainStruct):
(tests.chainStructNewlyValid):
(tests.chainStructDevice):
(tests.paramChainStructDevice):
(tests.simpleProtocolExtends):
(tests.protocolExtendsTwo):
(tests.overrideSubscriptStruct):
(tests.overrideSubscriptStructAndDoStores):
(tests.overrideSubscriptStructAndUsePointers):
(tests.overrideSubscriptStructAndUsePointersIncorrectly):
(tests.makeArrayRefFromPointer):
(tests.nonArrayRefArrayLengthFail):
(tests.constexprIsNotLValuePtr):
(tests.genericAccessors):
(tests.nestedSubscriptLValueEmulationSimple):
(tests.nestedSubscriptLValueEmulationGeneric):
(tests.shaderTypes):
(tests.enumPtrBase):
(tests.mutuallyRecursiveStructWithPointersBroken):
(tests.mutuallyRecursiveStructWithPointers):
(tests.linkedList):
(tests.pointerToPointer):
(tests.pointerGetter):
(tests.operatorCastWithTypeVariableInferredFromReturnType):
(tests.loneSetterPointer):
(tests.anderWithNothingWrong):
(tests.anderWithWrongNumberOfArguments):
(tests.anderDoesntReturnPointer):
(tests.anderDoesntTakeReference):
(tests.anderWithArrayRef):
(tests.pointerIndexGetter):
(tests.loneIndexSetterPointer):
(tests.indexAnderWithNothingWrong):
(tests.indexAnderWithWrongNumberOfArguments):
(tests.indexAnderDoesntReturnPointer):
(tests.indexAnderDoesntTakeReference):
(tests.indexAnderWithArrayRef):
(tests.devicePtrPtr):
(tests.threadgroupPtrPtr):
(tests.constantPtrPtr):
(tests.pointerIndexGetterInProtocol):
(tests.loneIndexSetterPointerInProtocol):
(tests.indexAnderWithNothingWrongInProtocol):
(tests.indexAnderWithWrongNumberOfArgumentsInProtocol):
(tests.indexAnderDoesntReturnPointerInProtocol):
(tests.indexAnderDoesntTakeReferenceInProtocol):
(tests.indexAnderWithArrayRefInProtocol):
(tests.andReturnedArrayRef):

3:01 PM Changeset in webkit [222750] by fpizlo@apple.com
  • 8 edits in trunk/Tools

WSL should be fine with &foo()[i] if foo() returns a []
​https://bugs.webkit.org/show_bug.cgi?id=177704

Reviewed by Saam Barati.

Previously, we'd determine if a property access expression (base.field or base[index]) was an lvalue by
asking if its base was an lvalue. This is right in all cases except if the base is of type []. Then, the
property access expression is an lvalue so long as there is a setter or ander.

This fixes the issue and adds a test.

Also, this makes error messages in the case that something is not an lvalue a lot better. If something
is not an lvalue because we could not find anders or setters, then we will tell you why we could not
find them.

  • WebGPUShadingLanguageRI/Checker.js:

(Checker.prototype.visitAssignment):
(Checker.prototype.visitReadModifyWriteExpression):
(Checker.prototype.visitMakePtrExpression):
(Checker.prototype._finishVisitingPropertyAccess):

  • WebGPUShadingLanguageRI/DotExpression.js:

(DotExpression.prototype.get fieldName):
(DotExpression.prototype.get isLValue): Deleted.
(DotExpression.prototype.get addressSpace): Deleted.

  • WebGPUShadingLanguageRI/IndexExpression.js:

(IndexExpression.prototype.get index):
(IndexExpression.prototype.get isLValue): Deleted.
(IndexExpression.prototype.get addressSpace): Deleted.

  • WebGPUShadingLanguageRI/PropertyAccessExpression.js:

(PropertyAccessExpression):
(PropertyAccessExpression.prototype.get isLValue):
(PropertyAccessExpression.prototype.set isLValue):

  • WebGPUShadingLanguageRI/PropertyResolver.js:

(PropertyResolver.prototype._visitRValuesWithinLValue.RValueFinder.prototype.visitMakeArrayRefExpression):
(PropertyResolver.prototype._visitRValuesWithinLValue.RValueFinder):
(PropertyResolver.prototype._visitRValuesWithinLValue):

  • WebGPUShadingLanguageRI/Test.js:

(tests.storeNullArrayRef):
(tests.andReturnedArrayRef):

3:00 PM Changeset in webkit [222749] by Adrian Perez de Castro
  • 2 edits in trunk/Source/WebKit

[GTK] Do not hardcode font family in served remote inspector HTML snippets
​https://bugs.webkit.org/show_bug.cgi?id=177742

Reviewed by Carlos Garcia Campos.

Instead of hardcoding Cantarell as the font used for the HTML snippets served
by the remote inspector handler, use "font: menu" to obtain the system UI
font, plus a "font-size" rule for adjusting the size.

  • UIProcess/API/gtk/WebKitRemoteInspectorProtocolHandler.cpp:

(WebKit::RemoteInspectorProtocolHandler::handleRequest): Change the
CSS rules in the served snippet.

2:58 PM Changeset in webkit [222748] by keith_miller@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

VMTraps shouldn't crash if it sees an exception it doesn't understand.
​https://bugs.webkit.org/show_bug.cgi?id=177780

Reviewed by Mark Lam.

VMTraps could see a JIT breakpoint (SegV) for any number of
reasons it doesn't understand. e.g. a bug in JIT code, Wasm OOB,
etc. This patch makes it handle that case gracefully. It's worth
noting that this means there's no way to know if, due to a bug, we
didn't accurately track all the VMTraps we installed. I'm not sure
if there is a good solution to that problem though.

  • runtime/VMTraps.cpp:
2:46 PM Changeset in webkit [222747] by pvollan@apple.com
  • 2 edits in trunk/Source/WebKitLegacy

[Win] Link error: cannot open file 'WebKitGUID.lib'
​https://bugs.webkit.org/show_bug.cgi?id=177759

Reviewed by Alex Christensen.

For backward compatibility reasons, this library should not be renamed from
WebKitGUID.lib to WebKitLegacyGUID.lib.

  • PlatformWin.cmake:
2:44 PM Changeset in webkit [222746] by rniwa@webkit.org
  • 3 edits in trunk/Source/WebCore

PasteImage tests are failing on debug builds
​https://bugs.webkit.org/show_bug.cgi?id=177778

Reviewed by Wenson Hsieh.

After r222702, PlatformPasteboard is no longer responsible for adding "Files" as a type"
as DataTransfer takes care of it now. Removed the code to do this from PlatformPasteboardIOS.mm
and PlatformPasteboardMac.mm so that we don't fail assertions in debug builds.

  • platform/ios/PlatformPasteboardIOS.mm:

(WebCore::safeTypeForDOMToReadAndWriteForPlatformType):

  • platform/mac/PlatformPasteboardMac.mm:

(WebCore::safeTypeForDOMToReadAndWriteForPlatformType):
(WebCore::PlatformPasteboard::typesSafeForDOMToReadAndWrite const):

2:42 PM Changeset in webkit [222745] by dbates@webkit.org
  • 2 edits in trunk/Source/WebCore

No need to truncate text after calling InlineTextBox::text()
​https://bugs.webkit.org/show_bug.cgi?id=177748

Reviewed by Zalan Bujtas.

Following r222670 it is no longer necessary to explicitly truncate the text run length
as InlineTextBox::text() returns a text run with respect to the truncation of the text box.

No functionality changed. So, no new tests.

  • rendering/InlineTextBox.cpp:

(WebCore::InlineTextBox::paint):

2:40 PM Changeset in webkit [222744] by sbarati@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Unreviewed. Add missing exception check for the custom-get-set-inline-caching-one-level-up-proto-chain.js
test that I added. It uncovered a pre-existing missing exception check.

  • runtime/JSObject.cpp:

(JSC::JSObject::putInlineSlow):

2:31 PM Changeset in webkit [222743] by Wenson Hsieh
  • 2 edits in trunk/Tools

Guard iOS webkitGetAsEntry API tests on older iOS versions

Unreviewed test gardening. After r222688, these tests require custom pasteboard data to be enabled by default,
so don't run them against shipping iOS.

  • TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
2:31 PM Changeset in webkit [222742] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Ensure popovers are not malformed on window resize.
​https://bugs.webkit.org/show_bug.cgi?id=177771

Patch by Ross Kirsling <Ross Kirsling> on 2017-10-02
Reviewed by Joseph Pecoraro.

  • UserInterface/Views/Popover.js:

Ensure stale arrow-* CSS classes are removed on update, even if our content didn't change.

2:31 PM Changeset in webkit [222741] by Antti Koivisto
  • 4 edits in trunk/Source

Add makeWeakPtr variant that takes pointer
​https://bugs.webkit.org/show_bug.cgi?id=177767

Reviewed by Zalan Bujtas.

Source/WebCore:

Use it.

  • rendering/SelectionRangeData.h:

(WebCore::SelectionRangeData::Context::Context):

Source/WTF:

  • wtf/WeakPtr.h:

(WTF::makeWeakPtr):

This version deals with the nullptr.

2:15 PM WebKitGTK/2.18.x edited by Adrian Perez de Castro
(diff)
2:06 PM Changeset in webkit [222740] by Antti Koivisto
  • 6 edits in trunk/Source/WebCore

Make RenderPtr a type alias of std::unique_ptr
​https://bugs.webkit.org/show_bug.cgi?id=177739

Reviewed by Sam Weinig.

It just needs a custom deleter.

  • page/FrameView.h:
  • rendering/RenderElement.cpp:

(WebCore::RenderElement::insertChildInternal):

  • rendering/RenderMultiColumnFlow.cpp:

(WebCore::RenderMultiColumnFlow::fragmentedFlowDescendantInserted):
(WebCore::RenderMultiColumnFlow::handleSpannerRemoval):

  • rendering/RenderObject.cpp:

(WebCore::RenderObjectDeleter::operator() const):
(WebCore::RenderObject::willBeDestroyed):

  • rendering/RenderPtr.h:

(WebCore::createRenderer):
(WebCore::static_pointer_cast):

Make this safer with downcast.

(WebCore::RenderPtr::RenderPtr): Deleted.
(WebCore::RenderPtr::~RenderPtr): Deleted.
(WebCore::RenderPtr::get const): Deleted.
(WebCore::RenderPtr::operator* const): Deleted.
(WebCore::RenderPtr::operator-> const): Deleted.
(WebCore::RenderPtr::operator! const): Deleted.
(WebCore::RenderPtr::operator UnspecifiedBoolType const): Deleted.
(WebCore::RenderPtr::operator=): Deleted.
(WebCore::RenderPtr::swap): Deleted.
(WebCore::RenderPtr::operator==): Deleted.
(WebCore::RenderPtr::operator!=): Deleted.
(WebCore::RenderPtr<T>::clear): Deleted.
(WebCore::RenderPtr<T>::leakPtr): Deleted.
(WebCore::RenderPtr<T>::RenderPtr): Deleted.
(WebCore::=): Deleted.
(WebCore::swap): Deleted.
(WebCore::operator==): Deleted.
(WebCore::operator!=): Deleted.
(WebCore::getPtr): Deleted.
(WTF::HashTraits<WebCore::RenderPtr<T>>::emptyValue): Deleted.
(WTF::HashTraits<WebCore::RenderPtr<T>>::peek): Deleted.

We already have hash traits for std::unique_ptr.

1:24 PM Changeset in webkit [222739] by Joseph Pecoraro
  • 40 edits
    7 adds in trunk

Web Inspector: Include Beacon and Ping requests in Network tab
​https://bugs.webkit.org/show_bug.cgi?id=177641
<rdar://problem/33086839>

Reviewed by Chris Dumez.

Source/JavaScriptCore:

  • inspector/protocol/Page.json:

Include new "Beacon" and "Ping" resource types.

Source/WebCore:

Tests: http/tests/inspector/network/beacon-type.html

http/tests/inspector/network/ping-type.html

  • Modules/beacon/NavigatorBeacon.cpp:

(WebCore::NavigatorBeacon::sendBeacon):
Fix a typo.

  • loader/PingLoader.cpp:

(WebCore::PingLoader::startPingLoad):

  • loader/cache/CachedResource.cpp:

(WebCore::CachedResource::load):
Include InspectorInstrumentation hooks for ping network loads.

  • loader/LoaderStrategy.h:
  • platform/network/PingHandle.h:

Include an optional ResourceResponse in the ping load completion callback.
If available this will be enough for Web Inspector to include details such
as the response statusCode.

  • inspector/InspectorInstrumentation.cpp:

(WebCore::InspectorInstrumentation::willSendRequestOfTypeImpl):
(WebCore::InspectorInstrumentation::continueAfterPingLoaderImpl): Deleted.

  • inspector/InspectorInstrumentation.h:

(WebCore::InspectorInstrumentation::willSendRequestOfType):
(WebCore::InspectorInstrumentation::continueAfterPingLoader): Deleted.

  • inspector/InspectorNetworkAgent.cpp:

(WebCore::resourceTypeForCachedResource):
(WebCore::resourceTypeForLoadType):
(WebCore::InspectorNetworkAgent::willSendRequest):
(WebCore::InspectorNetworkAgent::willSendRequestOfType):

  • inspector/InspectorNetworkAgent.h:

Make a general willSendRequestOfType hook when sending a request that does
not go through normal CachedResource loading. The Ping and Beacon requests
go through this process, we may also use this path for Preflight requests.

  • inspector/InspectorPageAgent.cpp:

(WebCore::InspectorPageAgent::resourceTypeJson):
(WebCore::InspectorPageAgent::cachedResourceType):

  • inspector/InspectorPageAgent.h:

Small refactoring.

Source/WebInspectorUI:

  • Localizations/en.lproj/localizedStrings.js:

New strings for Beacon/Ping.

  • UserInterface/Images/Beacon.svg: Added.
  • UserInterface/Views/ResourceIcons.css:

(.resource-icon.resource-type-ping .icon,):
(body:not(.mac-platform, .windows-platform) .resource-icon.resource-type-ping .icon,):
(body:not(.mac-platform, .windows-platform) .large .resource-icon.resource-type-ping .icon,):
New icon for Beacon/Ping. They share an icon since they are similiar in concept:
a request that is sent and the page doesn't expect a response.

  • UserInterface/Controllers/FrameResourceManager.js:

(WI.FrameResourceManager.prototype._addNewResourceToFrameOrTarget):
When a sub-resource and a main-resource have the same URL we were not
distinguishing them. Use the resource type to distinguish them better.

  • UserInterface/Models/SourceCode.js:

(WI.SourceCode.prototype._processContent):
Safer handling if the body was base64 encoded but an empty string.

  • UserInterface/Models/Resource.js:

(WI.Resource.displayNameForType):

  • UserInterface/Models/ResourceCollection.js:

(WI.ResourceCollection.verifierForType):

  • UserInterface/Views/NetworkTableContentView.js:

(WI.NetworkTableContentView.shortDisplayNameForResourceType):

  • UserInterface/Views/ResourceClusterContentView.js:

(WI.ResourceClusterContentView.prototype.get responseContentView):
New resource types.

  • UserInterface/Views/ResourceContentView.js:

(WI.ResourceContentView.prototype.showMessage):

  • UserInterface/Views/TextResourceContentView.js:

(WI.TextResourceContentView.prototype._contentDidPopulate):
Nicer display for empty content, which may be common for these requests.

Source/WebKit:

  • NetworkProcess/NetworkConnectionToWebProcess.cpp:

(WebKit::NetworkConnectionToWebProcess::loadPing):
(WebKit::NetworkConnectionToWebProcess::didFinishPingLoad):

  • NetworkProcess/NetworkConnectionToWebProcess.h:
  • NetworkProcess/PingLoad.cpp:

(WebKit::PingLoad::PingLoad):
(WebKit::PingLoad::didFinish):
(WebKit::PingLoad::didReceiveResponseNetworkSession):

  • NetworkProcess/PingLoad.h:
  • WebProcess/Network/NetworkProcessConnection.cpp:

(WebKit::NetworkProcessConnection::didFinishPingLoad):

  • WebProcess/Network/NetworkProcessConnection.h:
  • WebProcess/Network/NetworkProcessConnection.messages.in:
  • WebProcess/Network/WebLoaderStrategy.cpp:

(WebKit::WebLoaderStrategy::networkProcessCrashed):
(WebKit::WebLoaderStrategy::startPingLoad):
(WebKit::WebLoaderStrategy::didFinishPingLoad):

  • WebProcess/Network/WebLoaderStrategy.h:

Pass an optional ResourceResponse back to the ping completion handler.

LayoutTests:

  • http/tests/inspector/network/beacon-type-expected.txt: Added.
  • http/tests/inspector/network/beacon-type.html: Added.
  • http/tests/inspector/network/ping-type-expected.txt: Added.
  • http/tests/inspector/network/ping-type.html: Added.
  • http/tests/inspector/network/resources/beacon.php: Added.
  • http/tests/inspector/network/resources/ping.php: Added.

Test for Beacon and Ping resource loads.

  • platform/mac-wk1/TestExpectations:
  • platform/mac-wk2/TestExpectations:
  • platform/win/TestExpectations:

Skip beacon tests where beacon is not supported.

1:06 PM Changeset in webkit [222738] by Alan Bujtas
  • 5 edits in trunk/Source/WebCore

SelectionRangeData should not hold raw RenderObject pointers
​https://bugs.webkit.org/show_bug.cgi?id=177677
<rdar://problem/34763060>

Reviewed by Sam Weinig.

SelectionRangeData::Context start and end renderers' lifetime is not strictly tied
to the lifetime of SelectionRangeData.

Covered by existing tests.

  • editing/FrameSelection.cpp:

(WebCore::FrameSelection::updateAppearance):

  • platform/DragImage.cpp:

(WebCore::createDragImageForRange):

  • rendering/SelectionRangeData.cpp:

(WebCore::isValidRendererForSelection):
(WebCore::collect):
(WebCore::SelectionRangeData::set):
(WebCore::SelectionRangeData::clear):
(WebCore::SelectionRangeData::repaint const):
(WebCore::SelectionRangeData::collectBounds const):
(WebCore::SelectionRangeData::apply):

  • rendering/SelectionRangeData.h:

(WebCore::SelectionRangeData::Context::Context):
(WebCore::SelectionRangeData::Context::start const):
(WebCore::SelectionRangeData::Context::end const):
(WebCore::SelectionRangeData::Context::startPosition const):
(WebCore::SelectionRangeData::Context::endPosition const):
(WebCore::SelectionRangeData::Context::operator== const):
(WebCore::SelectionRangeData::start const):
(WebCore::SelectionRangeData::end const):
(WebCore::SelectionRangeData::startPosition const):
(WebCore::SelectionRangeData::endPosition const):

1:04 PM October 2017 Meeting edited by rniwa@webkit.org
Add clipboard API as a topic for 2017 contributor's meeting (diff)
1:00 PM Changeset in webkit [222737] by commit-queue@webkit.org
  • 4 edits in trunk

[WPE] Remove GnuTLS dependency
​https://bugs.webkit.org/show_bug.cgi?id=177750

Patch by Olivier Blin <Olivier Blin> on 2017-10-02
Reviewed by Michael Catanzaro.

libgcrypt is used by default instead of GnuTLS.
See bug 163125

.:

  • Source/cmake/OptionsWPE.cmake:

Source/WebCore:

  • PlatformWPE.cmake:
12:49 PM Changeset in webkit [222736] by achristensen@apple.com
  • 2 edits in trunk/Source/WebKit

REGRESSION: API tests WebKit.ProcessDidTerminateRequestedByClient and WebKit.ProcessDidTerminateWithReasonCrash are timing out
​https://bugs.webkit.org/show_bug.cgi?id=177764

Reviewed by Chris Dumez.

  • UIProcess/API/C/WKPage.cpp:

(WKPageSetPageNavigationClient):
I shouldn't have reverted the A API telling the listener to continue if there's no client function.

12:48 PM Changeset in webkit [222735] by Carlos Garcia Campos
  • 4 edits in trunk

[WPE][GTK] Crash in webkit_web_resource_get_data_finish()
​https://bugs.webkit.org/show_bug.cgi?id=177107

Reviewed by Michael Catanzaro.

Source/WebKit:

Handle errors in webkit_web_resource_get_data() callback.

  • UIProcess/API/glib/WebKitWebResource.cpp:

(resourceDataCallback):
(webkit_web_resource_get_data):

Tools:

Add a test case to check we handle errors when webkit_web_resource_get_data() fails.

  • TestWebKitAPI/Tests/WebKitGLib/TestResources.cpp:

(webViewloadChanged):
(testWebResourceGetDataError):
(beforeAll):

12:40 PM Changeset in webkit [222734] by jiewen_tan@apple.com
  • 3 edits in trunk/LayoutTests

Mark imported/w3c/web-platform-tests/WebCryptoAPI/generateKey/successes_RSA-PSS.worker.html as slow
​https://bugs.webkit.org/show_bug.cgi?id=177615

Unreviewed test gardening.

12:34 PM Changeset in webkit [222733] by Alan Bujtas
  • 2 edits in trunk/Source/WebCore

Addressing post-review comments after r222621
​https://bugs.webkit.org/show_bug.cgi?id=177610

Reviewed by Darin Adler.

  • rendering/RenderMenuList.cpp:

(RenderMenuList::didUpdateActiveOption):

12:23 PM Changeset in webkit [222732] by dbates@webkit.org
  • 5 edits in trunk/Source/WebCore

Remove length argument from TextPainter::paint()
​https://bugs.webkit.org/show_bug.cgi?id=177758

Reviewed by Alex Christensen.

Have TextPainter.paint() use the length of the specified TextRun as opposed to
taking an explicit argument for the length of the TextRun.

Following r222670 InlineTextBox creates a TextRun with respect to the truncated
line. Prior to r222670 InlineTextBox did not do this and hence it had to pass both
the TextRun and truncated length to TextPainter.paint() to have the line painted.
Code that needs to paint a substring of a TextRun can still do so by using TextPainter.paintRange().

No functionality changed. So, no new tests.

  • rendering/InlineTextBox.cpp:

(WebCore::InlineTextBox::paint):

  • rendering/SimpleLineLayoutFunctions.cpp:

(WebCore::SimpleLineLayout::paintFlow):

  • rendering/TextPainter.cpp:

(WebCore::TextPainter::paint):

  • rendering/TextPainter.h:
12:20 PM Changeset in webkit [222731] by Yusuke Suzuki
  • 2 edits in trunk/Source/bmalloc

[Linux] Enable Gigacage in x64 Linux environment
​https://bugs.webkit.org/show_bug.cgi?id=177745

Reviewed by Carlos Garcia Campos.

This patch enables Gigacage in x64 Linux environment.
Gigacage enforces a caged pointer to reference to the
specific memory region. This reduces the effectiveness
of some types of attacks setting a pointer to ArrayBuffer
and modifying arbitrary memory region.

  • bmalloc/Gigacage.h:
12:04 PM Changeset in webkit [222730] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[curl] Crashes in CurlRequest::setupPUT()
​https://bugs.webkit.org/show_bug.cgi?id=177733

Patch by Fujii Hironori <Fujii Hironori> on 2017-10-02
Reviewed by Alex Christensen.

Tests: http/tests/xmlhttprequest/xmlhttprequest-open-method-allowed.html

  • platform/network/curl/CurlRequest.cpp:

(WebCore::CurlRequest::setupPUT): Null-check the result of request.httpBody().

12:02 PM Changeset in webkit [222729] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit

[WPE] Fix UIProcess build with GStreamer and without VIDEO
​https://bugs.webkit.org/show_bug.cgi?id=177753

Patch by Olivier Blin <Olivier Blin> on 2017-10-02
Reviewed by Michael Catanzaro.

GStreamer builds fail when WebAudio is enabled but VIDEO disabled.
This is the WPE counterpart of bug 153135.

  • UIProcess/API/wpe/PageClientImpl.h:
12:00 PM Changeset in webkit [222728] by commit-queue@webkit.org
  • 10 edits in trunk/Source/WebCore

[CURL] Should handle redirects in WebCore
​https://bugs.webkit.org/show_bug.cgi?id=21242

Patch by Basuke Suzuki <Basuke Suzuki> on 2017-10-02
Reviewed by Alex Christensen.

  • platform/network/ResourceHandle.cpp:
  • platform/network/curl/CurlContext.cpp:

(WebCore::CurlHandle::enableAutoReferer): Deleted.

  • platform/network/curl/CurlContext.h:
  • platform/network/curl/CurlRequest.cpp:

(WebCore::CurlRequest::setupTransfer):
(WebCore::CurlRequest::didReceiveHeader):
(WebCore::CurlRequest::didReceiveData):

  • platform/network/curl/ResourceHandleCurl.cpp:

(WebCore::ResourceHandle::start):
(WebCore::ResourceHandle::continueDidReceiveResponse):
(WebCore::ResourceHandle::continueWillSendRequest):

  • platform/network/curl/ResourceHandleCurlDelegate.cpp:

(WebCore::ResourceHandleCurlDelegate::curlDidReceiveResponse):
(WebCore::ResourceHandleCurlDelegate::shouldRedirectAsGET):
(WebCore::ResourceHandleCurlDelegate::willSendRequest):
(WebCore::ResourceHandleCurlDelegate::continueWillSendRequest):
(WebCore::ResourceHandleCurlDelegate::continueAfterWillSendRequest):

  • platform/network/curl/ResourceHandleCurlDelegate.h:
  • platform/network/curl/ResourceResponse.h:
  • platform/network/curl/ResourceResponseCurl.cpp:

(WebCore::ResourceResponse::shouldRedirect):
(WebCore::ResourceResponse::isMovedPermanently const):
(WebCore::ResourceResponse::isFound const):
(WebCore::ResourceResponse::isSeeOther const):
(WebCore::ResourceResponse::isRedirection const): Deleted.

11:58 AM Changeset in webkit [222727] by commit-queue@webkit.org
  • 2 edits in trunk

[WPE] Do not require XSLT if disabled
​https://bugs.webkit.org/show_bug.cgi?id=177752

Patch by Olivier Blin <Olivier Blin> on 2017-10-02
Reviewed by Michael Catanzaro.

  • Source/cmake/OptionsWPE.cmake: libxslt is not a hard dep
11:29 AM Changeset in webkit [222726] by Antti Koivisto
  • 2 edits in trunk/Source/WebCore

Crashes with guard malloc under RenderFullScreen::unwrapRenderer
​https://bugs.webkit.org/show_bug.cgi?id=177760

Unreviewed.

  • rendering/RenderFullScreen.cpp:

(WebCore::RenderFullScreen::unwrapRenderer):

The assert accesses 'this' after it has been deleted. It is not very valuable so remove the assert.

11:17 AM Changeset in webkit [222725] by zandobersek@gmail.com
  • 3 edits in trunk/Source/WebCore

GraphicsContext: remove unused ENABLE(3D_TRANSFORMS) && USE(TEXTURE_MAPPER)
​https://bugs.webkit.org/show_bug.cgi?id=177757

Reviewed by Michael Catanzaro.

Remove three methods from the GraphicsContext class that were conditioned
with the ENABLE(3D_TRANSFORMS) and USE(TEXTURE_MAPPER) guards. These aren't
used anywhere at this point, but apparently used to be in the TextureMapper
implementation.

  • platform/graphics/GraphicsContext.h:
  • platform/graphics/cairo/GraphicsContextCairo.cpp:

(WebCore::GraphicsContext::get3DTransform const): Deleted.
(WebCore::GraphicsContext::concat3DTransform): Deleted.
(WebCore::GraphicsContext::set3DTransform): Deleted.

11:15 AM Changeset in webkit [222724] by Caio Lima
  • 4 edits in trunk

ChakraCore/test/Function/apply3.js is resulting wrong result in x86_64
​https://bugs.webkit.org/show_bug.cgi?id=175642

Reviewed by Darin Adler.

JSTests:

  • ChakraCore/test/Function/apply3.baseline-jsc:

Source/JavaScriptCore:

According JS spec, the ToLength operation[1] has a range of 0..(253)

  • 1. In Interpreter.cpp::sizeFrameForVarargs, the call to

sizeOfVarargs() was being assigned to "unsigned length", forcing a
type cast that results in different value among architectures JSC supports.
For instance, in x86_64 "4294967295 + 1" results in 0, while in ARMv6 it
results 4294967295. This patch is changing "sizeOfVarargs" to clamp the
result from "toLength" to unsigned and then get desired behavior for
all supported platforms.

[1] - ​https://tc39.github.io/ecma262/#sec-tolength

  • interpreter/Interpreter.cpp:

(JSC::sizeOfVarargs):

  • interpreter/Interpreter.h:
11:08 AM Changeset in webkit [222723] by commit-queue@webkit.org
  • 5 edits
    2 adds in trunk/Source/WebCore

[GLib] NetworkStateNotifier implementation missing
​https://bugs.webkit.org/show_bug.cgi?id=177741

Patch by Gustavo Noronha Silva <​gustavo.noronha@collabora.co.uk> on 2017-10-02
Reviewed by Carlos Garcia Campos.

No new tests. The DOM support is already being tested, but we would need a way
of simulating a network outage to test GNetworkMonitor.

  • PlatformGTK.cmake: add new file.
  • PlatformWPE.cmake: add new file.
  • platform/network/NetworkStateNotifier.cpp: no longer need the empty implementations, all platforms covered.
  • platform/network/NetworkStateNotifier.h:
  • platform/network/glib/NetworkStateNotifierGLib.cpp: Added.

(WebCore::NetworkStateNotifier::updateStateWithoutNotifying): update the network state using GNetworkMonitor's availability.
(WebCore::NetworkStateNotifier::networkChangedCallback): when network-changed is emitted, trigger a state update.
(WebCore::NetworkStateNotifier::startObserving): watch GNetworkMonitor's network-changed signal.

11:04 AM Changeset in webkit [222722] by Matt Lewis
  • 2 edits in trunk/LayoutTests

Rebaseline of js/dom/global-constructors-attributes-dedicated-worker.html after r222692.

Unreviewed test gardening.

  • platform/mac-wk1/js/dom/global-constructors-attributes-dedicated-worker-expected.txt:
10:59 AM Changeset in webkit [222721] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

Fix build with MathML disabled
​https://bugs.webkit.org/show_bug.cgi?id=177744

Patch by Olivier Blin <Olivier Blin> on 2017-10-02
Reviewed by Michael Catanzaro.

These are regressions from r217549 (StyleResolver) and r221379 (RenderBlockFlow), which do not guard MathML usage.

  • css/StyleResolver.cpp:

(WebCore::hasEffectiveDisplayNoneForDisplayContents):

  • rendering/RenderBlockFlow.cpp:

(WebCore::RenderBlockFlow::willCreateColumns const):

10:58 AM Changeset in webkit [222720] by zandobersek@gmail.com
  • 2 edits in trunk/LayoutTests

Unreviewed WPE gardening.

  • platform/wpe/TestExpectations: Unskip some more tests, and add

failure expectations for whatever is still failing from that subset.

10:52 AM Changeset in webkit [222719] by Yusuke Suzuki
  • 3 edits in trunk/Source/WebCore

Use ThreadIdentifier instead of thread::this_thread::get_id
​https://bugs.webkit.org/show_bug.cgi?id=177729

Reviewed by Sam Weinig.

We can use WTF::ThreadIdentifier instead of thread::this_thread::get_id
to make use of ThreadIdentifier consistent in WebKit. In the other places,
we use ThreadIdentifier for this debugging purpose. And this is the only
place using thread::this_thread::get_id for the exact same purpose.
Furthermore, thread::this_thread::get_id in Windows platform. So we prefer
using ThreadIdentifier than thread::this_thread::get_id.

  • Modules/webdatabase/DatabaseDetails.h:

(WebCore::DatabaseDetails::DatabaseDetails):
(WebCore::DatabaseDetails::threadID const):

  • Modules/webdatabase/DatabaseManager.cpp:

(WebCore::DatabaseManager::detailsForNameAndOrigin):

10:35 AM Changeset in webkit [222718] by achristensen@apple.com
  • 2 edits in trunk/Tools

Fix build after r222715
​https://bugs.webkit.org/show_bug.cgi?id=177697

  • TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:

(TEST):
Use the public API instead of the removed SPI.

10:26 AM Changeset in webkit [222717] by Jon Davis
  • 1 edit
    1 add in trunk/Websites/webkit.org

Add a WebKit Build Archives page
​https://bugs.webkit.org/show_bug.cgi?id=177654

Reviewed by Alexey Proskuryakov.

  • wp-content/themes/webkit/build-archives.php: Added.
10:22 AM Changeset in webkit [222716] by Matt Lewis
  • 4 edits in trunk/LayoutTests

Rebaseline of js/dom/global-constructors-attributes.html after r222692.

Unreviewed test gardening.

  • platform/mac-elcapitan-wk2/js/dom/global-constructors-attributes-expected.txt:
  • platform/mac-sierra/js/dom/global-constructors-attributes-expected.txt:
  • platform/mac/js/dom/global-constructors-attributes-expected.txt:
10:13 AM Changeset in webkit [222715] by achristensen@apple.com
  • 3 edits in trunk/Source/WebKit

Expose more WKPreferences SPI to match C SPI
​https://bugs.webkit.org/show_bug.cgi?id=177697

  • UIProcess/API/Cocoa/WKPreferences.mm:

(-[WKPreferences _javaEnabledForLocalFiles]):
(-[WKPreferences _setPlugInsEnabled:]): Deleted.
(-[WKPreferences _plugInsEnabled]): Deleted.

  • UIProcess/API/Cocoa/WKPreferencesPrivate.h:

_javaEnabledForLocalFiles should return the correct value.
_plugInsEnabled has public API. This SPI is not needed.

10:09 AM Changeset in webkit [222714] by achristensen@apple.com
  • 15 edits
    1 add in trunk

REGRESSION(r214201): WebProcess hangs during policy decisions
​https://bugs.webkit.org/show_bug.cgi?id=177590
<rdar://problem/33362929>

Reviewed by Andy Estes.

Source/WebKit:

This is like r222431 but for trunk instead of a branch.
It includes the same regression API test so I don't make the same mistake again.

  • UIProcess/API/C/WKPage.cpp:

(WKPageSetPageNavigationClient):

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::receivedPolicyDecision):
(WebKit::WebPageProxy::decidePolicyForNavigationAction):
(WebKit::WebPageProxy::decidePolicyForResponseSync):

  • UIProcess/WebPageProxy.h:
  • UIProcess/WebPageProxy.messages.in:
  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::dispatchDecidePolicyForResponse):
(WebKit::WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction):
(WebKit::WebFrameLoaderClient::applyToDocumentLoader):
(WebKit::WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.h:
  • WebProcess/WebPage/WebDocumentLoader.cpp:

(WebKit::WebDocumentLoader::setNavigationID):

  • WebProcess/WebPage/WebFrame.cpp:

(WebKit::WebFrame::setUpPolicyListener):
(WebKit::WebFrame::invalidatePolicyListener):
(WebKit::WebFrame::didReceivePolicyDecision):

  • WebProcess/WebPage/WebFrame.h:
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::didReceivePolicyDecision):

  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebPage/WebPage.messages.in:

Tools:

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/Tests/WebKitCocoa/JavaScriptDuringNavigation.mm: Added.

(-[JSNavigationDelegate webView:didFinishNavigation:]):
(-[JSNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
(-[JSNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
(-[JSNavigationDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
(TEST):

10:09 AM Changeset in webkit [222713] by sbarati@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Unreviewed. Fix debug assertion after r222671.

JSTestCustomGetterSetter::finishCreation needs to call its base's finishCreation implementation.

  • jsc.cpp:

(JSTestCustomGetterSetter::finishCreation):

9:54 AM Changeset in webkit [222712] by achristensen@apple.com
  • 3 edits in trunk/Source/WebKit

Remove unnecessary copy of SessionID in WebPageProxy
​https://bugs.webkit.org/show_bug.cgi?id=177702

Reviewed by Darin Adler.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::sessionID const):
(WebKit::WebPageProxy::creationParameters):

  • UIProcess/WebPageProxy.h:

(WebKit::WebPageProxy::sessionID const): Deleted.

9:50 AM Changeset in webkit [222711] by achristensen@apple.com
  • 3 edits in trunk/Source/WebKit

Expose more WKPreferences SPI to match C SPI
​https://bugs.webkit.org/show_bug.cgi?id=177697
<rdar://problem/24110556>

Reviewed by Darin Adler.

  • UIProcess/API/Cocoa/WKPreferences.mm:

(-[WKPreferences _setJavaEnabledForLocalFiles:]):
(-[WKPreferences _javaEnabledForLocalFiles]):
(-[WKPreferences _setCanvasUsesAcceleratedDrawing:]):
(-[WKPreferences _canvasUsesAcceleratedDrawing]):
(-[WKPreferences _setAcceleratedCompositingEnabled:]):
(-[WKPreferences _acceleratedCompositingEnabled]):
(-[WKPreferences _setDefaultTextEncodingName:]):
(-[WKPreferences _defaultTextEncodingName]):
(-[WKPreferences _setNeedsSiteSpecificQuirks:]):
(-[WKPreferences _needsSiteSpecificQuirks]):
(-[WKPreferences _setAuthorAndUserStylesEnabled:]):
(-[WKPreferences _authorAndUserStylesEnabled]):
(-[WKPreferences _setDOMTimersThrottlingEnabled:]):
(-[WKPreferences _domTimersThrottlingEnabled]):
(-[WKPreferences _setWebArchiveDebugModeEnabled:]):
(-[WKPreferences _webArchiveDebugModeEnabled]):
(-[WKPreferences _setLocalFileContentSniffingEnabled:]):
(-[WKPreferences _localFileContentSniffingEnabled]):
(-[WKPreferences _setUsesPageCache:]):
(-[WKPreferences _usesPageCache]):
(-[WKPreferences _setPageCacheSupportsPlugins:]):
(-[WKPreferences _pageCacheSupportsPlugins]):
(-[WKPreferences _setShouldPrintBackgrounds:]):
(-[WKPreferences _shouldPrintBackgrounds]):
(-[WKPreferences _setWebSecurityEnabled:]):
(-[WKPreferences _webSecurityEnabled]):
(-[WKPreferences _setUniversalAccessFromFileURLsAllowed:]):
(-[WKPreferences _universalAccessFromFileURLsAllowed]):
(-[WKPreferences _setAVFoundationEnabled:]):
(-[WKPreferences _avFoundationEnabled]):
(-[WKPreferences _setSuppressesIncrementalRendering:]):
(-[WKPreferences _suppressesIncrementalRendering]):
(-[WKPreferences _setAsynchronousPluginInitializationEnabled:]):
(-[WKPreferences _asynchronousPluginInitializationEnabled]):
(-[WKPreferences _setArtificialPluginInitializationDelayEnabled:]):
(-[WKPreferences _artificialPluginInitializationDelayEnabled]):
(-[WKPreferences _setCookieEnabled:]):
(-[WKPreferences _cookieEnabled]):
(-[WKPreferences _setPlugInSnapshottingEnabled:]):
(-[WKPreferences _plugInSnapshottingEnabled]):
(-[WKPreferences _setQTKitEnabled:]):
(-[WKPreferences _qtKitEnabled]):
(-[WKPreferences _setSubpixelCSSOMElementMetricsEnabled:]):
(-[WKPreferences _subpixelCSSOMElementMetricsEnabled]):
(-[WKPreferences _setMediaSourceEnabled:]):
(-[WKPreferences _mediaSourceEnabled]):
(-[WKPreferences _setViewGestureDebuggingEnabled:]):
(-[WKPreferences _viewGestureDebuggingEnabled]):
(-[WKPreferences _setCSSAnimationTriggersEnabled:]):
(-[WKPreferences _cssAnimationTriggersEnabled]):
(-[WKPreferences _setStandardFontFamily:]):
(-[WKPreferences _standardFontFamily]):
(-[WKPreferences _setNotificationsEnabled:]):
(-[WKPreferences _notificationsEnabled]):
(-[WKPreferences _setBackspaceKeyNavigationEnabled:]):
(-[WKPreferences _backspaceKeyNavigationEnabled]):

  • UIProcess/API/Cocoa/WKPreferencesPrivate.h:
9:00 AM Changeset in webkit [222710] by Antti Koivisto
  • 2 edits in trunk/Source/WebCore

Fix memory leaks in RenderMultiColumnFlow
​https://bugs.webkit.org/show_bug.cgi?id=177735

Reviewed by Zalan Bujtas.

  • rendering/RenderMultiColumnFlow.cpp:

(WebCore::RenderMultiColumnFlow::evacuateAndDestroy):

Switch from destroy() to removeFromParentAndDestroy() (they are currently equivalent in practice).

(WebCore::RenderMultiColumnFlow::fragmentedFlowDescendantInserted):

Destroy the placeholders instead of leaking them.

(WebCore::RenderMultiColumnFlow::handleSpannerRemoval):

Destroy the placeholder instead of leaking it.

7:59 AM Changeset in webkit [222709] by Jonathan Bedard
  • 2 edits
    1 add in trunk/Tools

Log stack-trace for run-webkit-tests when interrupted
​https://bugs.webkit.org/show_bug.cgi?id=176393
<rdar://problem/34262310>

Reviewed by Darin Adler.

When run-webkit-tests is stuck, it is difficult to immediately tell
why. Saving a stack-trace when run-webkit-tests is terminated
or stopped with CNTRL-C will make such issues easier to debug.

  • Scripts/webkitpy/common/interupt_debugging.py: Added.

(log_stack_trace): Given a Python frame object, log a stack trace to
the provided file.
(log_stack_trace_on_term): Attach a listener to SIGTERM so that a
stack-trace can be logged when a program is terminated.
(log_stack_trace_on_cntrl_c): Attach a listener to SIGINT so that a
stack-trace can be logged when a program is CNTRL-Ced.

  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:

(main): Set handlers to log stack trace on interruption.

7:32 AM Changeset in webkit [222708] by Carlos Garcia Campos
  • 2 edits in trunk/Source/WebKit

[GTK][WPE] Enable interactive forms validation by default
​https://bugs.webkit.org/show_bug.cgi?id=177737

Reviewed by Michael Catanzaro.

It's currently disabled for no reason.

  • Shared/WebPreferencesDefinitions.h:
6:17 AM Changeset in webkit [222707] by cturner@igalia.com
  • 2 edits in trunk/Source/WebCore

Try to play AVC codec even if H.264 decoder only advertises byte-stream profile.
​https://bugs.webkit.org/show_bug.cgi?id=177550

GStreamer's element factory filters will claim they can't play videos with AVC
codec strings, but the elements really are capable of playing them when filters
like videoconvert are inserted by playbin. Videos of this variety are in the YouTube
2018 EME conformance tests.

Also replace std::array with a stack array, this saves having to count
the number of elements (the compiler does that now) and reduces braces.

Reviewed by Carlos Alberto Lopez Perez.

  • platform/graphics/gstreamer/mse/MediaPlayerPrivateGStreamerMSE.cpp:

(WebCore::codecSet):

5:55 AM Changeset in webkit [222706] by tpopela@redhat.com
  • 4 edits in trunk/Source/WebCore

[SOUP] Default kerberos authentication credentials are used in ephemeral (private) mode
​https://bugs.webkit.org/show_bug.cgi?id=177738

Reviewed by Carlos Garcia Campos.

If the session is ephemeral then don't enable the Negotiate support in
our SoupSession.

  • platform/network/soup/NetworkStorageSessionSoup.cpp: Pass the

session ID if it's known to the SoupNetworkSession.
(WebCore::NetworkStorageSession::ensurePrivateBrowsingSession):
(WebCore::NetworkStorageSession::getOrCreateSoupNetworkSession const):

  • platform/network/soup/SoupNetworkSession.cpp:

(WebCore::SoupNetworkSession::SoupNetworkSession): If the session is
ephemeral (based on given session ID) then don't activate the
Negotiate support in SoupSession.

  • platform/network/soup/SoupNetworkSession.h:

Change the constructor to accept the PAL::SessionID with the default
value set to PAL::SessionID::emptySessionID.

5:17 AM Changeset in webkit [222705] by jdiggs@igalia.com
  • 2 edits in trunk/Source/WebCore

REGRESSION(r222640) [GTK] Build broken with ATK 2.14
​https://bugs.webkit.org/show_bug.cgi?id=177634

Reviewed by Michael Catanzaro.

Use ATK_CHECK_VERSION to prevent the build failure.

No new tests. This fixes a downstream build failure.

  • accessibility/atk/AXObjectCacheAtk.cpp:

(WebCore::AXObjectCache::postPlatformNotification):

5:05 AM Changeset in webkit [222704] by Michael Catanzaro
  • 15 edits in trunk

Remove ENABLE_CSS_REGIONS
​https://bugs.webkit.org/show_bug.cgi?id=177689

Reviewed by Darin Adler.

.:

  • Source/cmake/OptionsGTK.cmake:
  • Source/cmake/OptionsMac.cmake:
  • Source/cmake/OptionsWPE.cmake:
  • Source/cmake/OptionsWin.cmake:
  • Source/cmake/WebKitFeatures.cmake:
  • Source/cmake/tools/vsprops/FeatureDefines.props:
  • Source/cmake/tools/vsprops/FeatureDefinesCairo.props:

Source/WebKit:

  • WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMDeprecated.cpp:

(webkit_dom_element_get_webkit_region_overset):

  • WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMDeprecated.h:
  • WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMElement.cpp:

(webkit_dom_element_get_webkit_region_overset): Deleted.

  • WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMElement.h:

Tools:

  • Scripts/webkitperl/FeatureList.pm:
2:09 AM Changeset in webkit [222703] by Carlos Garcia Campos
  • 2 edits in trunk/Source/WebDriver

WebDriver: HTTP status code is not correct for some of the errors
​https://bugs.webkit.org/show_bug.cgi?id=177354

Reviewed by Brian Burg.

I think this changed in the spec at some point. The thing is that no such alert, frame and window and stale
element reference errors should return 404 instead of 400.

​https://w3c.github.io/webdriver/webdriver-spec.html#handling-errors

  • CommandResult.cpp:

(WebDriver::CommandResult::httpStatusCode const):

1:55 AM Changeset in webkit [222702] by rniwa@webkit.org
  • 8 edits in trunk/Source/WebCore

Pasteboard shouldn't add "Files" as a type
​https://bugs.webkit.org/show_bug.cgi?id=177731

Reviewed by Wenson Hsieh.

Removed the platform specific code to add "Files" when there is a file present in platform's pasteboard.
DataTransfer::types now adds "Files" automatically when Pasteboard::containsFiles returns true.

No new tests since there should be no behavioral change.

  • dom/DataTransfer.cpp:

(WebCore::DataTransfer::types const):

  • platform/gtk/PasteboardGtk.cpp:

(WebCore::Pasteboard::typesForLegacyUnsafeBindings):

  • platform/ios/PasteboardIOS.mm:

(WebCore::Pasteboard::addHTMLClipboardTypesForCocoaType):

  • platform/mac/PasteboardMac.mm:

(WebCore::Pasteboard::addHTMLClipboardTypesForCocoaType):

  • platform/win/PasteboardWin.cpp:

(WebCore::addMimeTypesForFormat): Removed the code to add "Text" and "URL" as separate types since
this is not what the rest of ports do, and this type normalization is now taken care of by DataTransfer
since r221063.

1:25 AM Changeset in webkit [222701] by rniwa@webkit.org
  • 5 edits in trunk/Source/WebCore

Another attempt to fix Windows build after r222697.

  • editing/FrameSelection.cpp:

(WebCore::FrameSelection::updateAppearance):

  • platform/DragImage.cpp:

(WebCore::createDragImageForRange):

  • rendering/SelectionRangeData.cpp:

(WebCore::SelectionRangeData::clear):

  • rendering/SelectionRangeData.h:

(WebCore::SelectionRangeData::Context::Context):

12:26 AM Changeset in webkit [222700] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebCore

Windows build fix attempt after r222697.

  • platform/DragImage.cpp:

(WebCore::createDragImageForRange):

12:03 AM Changeset in webkit [222699] by rniwa@webkit.org
  • 10 edits in trunk/Source/WebCore

Merge readFilenames() and read(PasteboardFileReader)
​https://bugs.webkit.org/show_bug.cgi?id=177728
<rdar://problem/34761725>

Reviewed by Sam Weinig.

Generalized PasteboardFileReader to return multiple files instead of just one file, and replaced the use
of Pasteboard::readFilenames() with it. Because eliminates the need for finding the list of types to read
as files in addition to file names, this patch also removes Pasteboard::typesTreatedAsFiles().

Note that Pasteboard::readFilenames() continues to exist in macOS and iOS as it's internally used by
Pasteboard::read(PasteboardFileReader) in PasteboardCocoa.mm.

No new tests since there should be no behavioral change.

  • dom/DataTransfer.cpp:

(WebCore::DataTransfer::files const): Now makes a single call to Pasteboard::read(PasteboardFileReader)
instead of reading filenames and then falling back to it. Also got rid of if-def for drag drop checks
since forDrag() and forFileDrag() are always defined since r222688.
(WebCore::PasteboardFileTypeReader): Added. Gets the list of all file types.
(WebCore::PasteboardFileTypeReader::readFilename): Added. Gets the list of all file types.
(WebCore::PasteboardFileTypeReader::readBuffer): Added. Gets the list of all file types.
(WebCore::DataTransfer::hasFileOfType): Reimplemented using PasteboardFileTypeReader.

  • editing/WebCorePasteboardFileReader.cpp:

(WebCore::WebCorePasteboardFileReader::readFilename): Added.
(WebCore::WebCorePasteboardFileReader::readBuffer): Renamed from read.

  • editing/WebCorePasteboardFileReader.h:
  • platform/Pasteboard.h:

(WebCore::PasteboardFileReader): Removed the constructor since we no longer specify a specific type to
read off of pasteboard, and renamed the existing read function to readBuffer, and added a new variant
which takes a filename.

  • platform/StaticPasteboard.h:
  • platform/cocoa/PasteboardCocoa.mm:

(WebCore::imageTypeToFakeFilename): Return "image/png" for ImageType::TIFF (to do TIFF-to-PNG conversion;
see r222656 for why this is needed) now that this function is used to convert directly from image type
converted from cocoa type instead of the one reverse-converted from MIME type.
(WebCore::mimeTypeToImageType): Deleted.
(WebCore::Pasteboard::typesTreatedAsFiles): Deleted.
(WebCore::Pasteboard::typesForLegacyUnsafeBindings): Use newly added readTypesWithSecurityCheck.
(WebCore::convertTIFFToPNG): Extracted out of read(PasteboardFileReader).
(WebCore::Pasteboard::read): Generalized to add filenames as well as image buffers as files. Because now
we're concerting Cocoa types to ImageType, we no longer have to detect when TIFF-as-PNG conversion is
happening here. We just treat ImageType::TIFF as PNG and do the conversion.
(WebCore::Pasteboard::readStringInCustomData): Use newly added readBufferForTypeWithSecurityCheck.
(WebCore::Pasteboard::readTypesWithSecurityCheck): Added.
(WebCore::Pasteboard::readBufferForTypeWithSecurityCheck): Added.

  • platform/gtk/PasteboardGtk.cpp:

(WebCore::Pasteboard::read): Implemented.
(WebCore::Pasteboard::typesTreatedAsFiles): Deleted.
(WebCore::Pasteboard::containsFiles): Implemented without calling readFilenames, which has been deleted.
(WebCore::Pasteboard::readFilenames): Deleted.

  • platform/win/PasteboardWin.cpp:

(WebCore::Pasteboard::typesTreatedAsFiles): Deleted.
(WebCore::PasteboardFileCounter): Added. Used to counts the number of files in the pasteboard.
(WebCore::PasteboardFileCounter::readFilename):
(WebCore::PasteboardFileCounter::readBuffer):
(WebCore::Pasteboard::containsFiles):
(WebCore::Pasteboard::read): Moved the code to extract filenames out of readFilenames.
(WebCore::Pasteboard::readFilenames): Deleted.

  • platform/wpe/PasteboardWPE.cpp:

(WebCore::Pasteboard::typesTreatedAsFiles): Deleted.
(WebCore::Pasteboard::readFilenames): Deleted.

Oct 1, 2017:

11:02 PM Changeset in webkit [222698] by commit-queue@webkit.org
  • 10 edits
    1 add in trunk/Source/WebCore

[Settings] Move remaining simple settings to Settings.in
​https://bugs.webkit.org/show_bug.cgi?id=177730

Patch by Sam Weinig <​sam@webkit.org> on 2017-10-01
Reviewed by Darin Adler.

  • Adds new option type for Settings.in, 'getter', which allows you to specify a custom name for the setting's getter. For instance, the setting javaEnabled has a custom getter name, 'isJavaEnabled'.
  • Adds support for WTF::Seconds as a type of setting. Used by only timeWithoutMouseMovementBeforeHidingControls at the moment.
  • Moves non-generated settings from Settings.h/cpp that don't require custom action when set, to Settings.in
  • Scripts/GenerateSettings/GenerateInternalSettingsImplementationFile.py:
  • Scripts/GenerateSettings/GenerateSettingsHeaderFile.py:
  • Scripts/GenerateSettings/Settings.py:

Add support for 'getter' and the Seconds type.

  • WebCore.xcodeproj/project.pbxproj:
  • platform/text/FontRenderingMode.h: Copied from Source/WebCore/platform/text/TextFlags.h.
  • platform/text/TextFlags.h:

Add FontRenderingMode.h. Moved out of TextFlags.h to be accessible by
the settings generator.

  • page/Settings.cpp:

(WebCore::Settings::Settings):
(WebCore::Settings::setJavaEnabled): Deleted.
(WebCore::Settings::setJavaEnabledForLocalFiles): Deleted.
(WebCore::Settings::setPreferMIMETypeForImages): Deleted.
(WebCore::Settings::setForcePendingWebGLPolicy): Deleted.
(WebCore::Settings::setNeedsAdobeFrameReloadingQuirk): Deleted.
(WebCore::Settings::setFontRenderingMode): Deleted.
(WebCore::Settings::fontRenderingMode const): Deleted.
(WebCore::Settings::setShowTiledScrollingIndicator): Deleted.
(WebCore::Settings::setFontFallbackPrefersPictographs): Deleted.
(WebCore::Settings::setWebFontsAlwaysFallBack): Deleted.

  • page/Settings.h:

(WebCore::Settings::isJavaEnabled const): Deleted.
(WebCore::Settings::isJavaEnabledForLocalFiles const): Deleted.
(WebCore::Settings::preferMIMETypeForImages const): Deleted.
(WebCore::Settings::needsAcrobatFrameReloadingQuirk const): Deleted.
(WebCore::Settings::showTiledScrollingIndicator const): Deleted.
(WebCore::Settings::setTouchEventEmulationEnabled): Deleted.
(WebCore::Settings::isTouchEventEmulationEnabled const): Deleted.
(WebCore::Settings::setTimeWithoutMouseMovementBeforeHidingControls): Deleted.
(WebCore::Settings::timeWithoutMouseMovementBeforeHidingControls const): Deleted.
(WebCore::Settings::fontFallbackPrefersPictographs const): Deleted.
(WebCore::Settings::webFontsAlwaysFallBack const): Deleted.
(WebCore::Settings::setMediaKeysStorageDirectory): Deleted.
(WebCore::Settings::mediaKeysStorageDirectory const): Deleted.
(WebCore::Settings::setMediaDeviceIdentifierStorageDirectory): Deleted.
(WebCore::Settings::mediaDeviceIdentifierStorageDirectory const): Deleted.
(WebCore::Settings::applePayEnabled const): Deleted.
(WebCore::Settings::setApplePayEnabled): Deleted.
(WebCore::Settings::applePayCapabilityDisclosureAllowed const): Deleted.
(WebCore::Settings::setApplePayCapabilityDisclosureAllowed): Deleted.
(WebCore::Settings::isForcePendingWebGLPolicy const): Deleted.

  • page/Settings.in:

Moved hand-written settings to be Settings.in based.

9:46 PM Changeset in webkit [222697] by Alan Bujtas
  • 16 edits
    2 adds
    2 deletes in trunk/Source/WebCore

RenderView does not need to be a SelectionSubtreeRoot
​https://bugs.webkit.org/show_bug.cgi?id=177713

Reviewed by Darin Adler and Antti Koivisto.

  1. SelectionSubtreeRoot -> SelectionRangeData
  2. Move all selection logic from RenderView to SelectionRangeData
  3. class RenderView : public SelectionSubtreeRoot -> SelectionRangeData m_selection;
  4. Remove redundant code
  5. General modernization

No change in functionality.

  • editing/FrameSelection.cpp:

(WebCore::FrameSelection::setNeedsSelectionUpdate):
(WebCore::DragCaretController::nodeWillBeRemoved):
(WebCore::FrameSelection::respondToNodeModification):
(WebCore::FrameSelection::prepareForDestruction):
(WebCore::FrameSelection::focusedOrActiveStateChanged):
(WebCore::FrameSelection::updateAppearance):
(WebCore::FrameSelection::selectionBounds const):

  • page/FrameView.cpp:

(WebCore::FrameView::paintContentsForSnapshot):

  • platform/DragImage.cpp:

(WebCore::ScopedFrameSelectionState::ScopedFrameSelectionState):
(WebCore::ScopedFrameSelectionState::~ScopedFrameSelectionState):
(WebCore::createDragImageForRange):

  • rendering/InlineTextBox.cpp:

(WebCore::InlineTextBox::selectionState):
(WebCore::InlineTextBox::selectionStartEnd const):

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::isSelectionRoot const):

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::isSelectionBorder const):

  • rendering/RenderObject.h:
  • rendering/RenderReplaced.cpp:

(WebCore::RenderReplaced::isSelected const):

  • rendering/RenderText.cpp:

(WebCore::RenderText::collectSelectionRectsForLineBoxes):

  • rendering/RenderTextLineBoxes.cpp:

(WebCore::RenderTextLineBoxes::setSelectionState):

  • rendering/RenderView.cpp:

(WebCore::RenderView::RenderView):
(WebCore::SelectionIterator::SelectionIterator): Deleted.
(WebCore::SelectionIterator::current const): Deleted.
(WebCore::SelectionIterator::next): Deleted.
(WebCore::SelectionIterator::checkForSpanner): Deleted.
(WebCore::rendererAfterPosition): Deleted.
(WebCore::RenderView::selectionBounds const): Deleted.
(WebCore::RenderView::subtreeSelectionBounds const): Deleted.
(WebCore::RenderView::repaintSelection const): Deleted.
(WebCore::RenderView::repaintSubtreeSelection const): Deleted.
(WebCore::RenderView::setSelection): Deleted.
(WebCore::isValidObjectForNewSelection): Deleted.
(WebCore::RenderView::clearSubtreeSelection const): Deleted.
(WebCore::RenderView::applySubtreeSelection): Deleted.
(WebCore::RenderView::getSelection const): Deleted.
(WebCore::RenderView::clearSelection): Deleted.

  • rendering/RenderView.h:
  • rendering/SelectionSubtreeRoot.cpp:

(WebCore::rendererAfterPosition):
(WebCore::SelectionIterator::SelectionIterator):
(WebCore::SelectionIterator::current const):
(WebCore::SelectionIterator::next):
(WebCore::SelectionIterator::checkForSpanner):
(WebCore::SelectionRangeData::SelectionRangeData):
(WebCore::SelectionRangeData::set):
(WebCore::SelectionRangeData::clear):
(WebCore::SelectionRangeData::repaint const):
(WebCore::SelectionRangeData::bounds const):
(WebCore::SelectionRangeData::collectAndClear const):
(WebCore::SelectionRangeData::apply):
(WebCore::SelectionRangeData::isValidRendererForNewSelection const):
(WebCore::SelectionSubtreeRoot::SelectionSubtreeRoot): Deleted.

  • rendering/SelectionSubtreeRoot.h:

(WebCore::SelectionRangeData::Context::operator== const):
(WebCore::SelectionRangeData::get const):
(WebCore::SelectionRangeData::start const):
(WebCore::SelectionRangeData::end const):
(WebCore::SelectionRangeData::startPosition const):
(WebCore::SelectionRangeData::endPosition const):
(WebCore::SelectionSubtreeRoot::OldSelectionData::OldSelectionData): Deleted.
(WebCore::SelectionSubtreeRoot::SelectionSubtreeData::SelectionSubtreeData): Deleted.
(WebCore::SelectionSubtreeRoot::SelectionSubtreeData::selectionStart const): Deleted.
(WebCore::SelectionSubtreeRoot::SelectionSubtreeData::selectionStartPos const): Deleted.
(WebCore::SelectionSubtreeRoot::SelectionSubtreeData::selectionEnd const): Deleted.
(WebCore::SelectionSubtreeRoot::SelectionSubtreeData::selectionEndPos const): Deleted.
(WebCore::SelectionSubtreeRoot::SelectionSubtreeData::selectionStartEndPositions const): Deleted.
(WebCore::SelectionSubtreeRoot::SelectionSubtreeData::clearSelection): Deleted.
(WebCore::SelectionSubtreeRoot::selectionData): Deleted.
(WebCore::SelectionSubtreeRoot::selectionData const): Deleted.
(WebCore::SelectionSubtreeRoot::setSelectionData): Deleted.

8:33 PM Changeset in webkit [222696] by jmarcell@apple.com
  • 3 edits
    2 adds in branches/safari-604-branch

Cherry-pick r222588. rdar://problem/34717517

8:17 PM Changeset in webkit [222695] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebCore

[Settings] Enums should not be passed by const reference
​https://bugs.webkit.org/show_bug.cgi?id=177727

Patch by Sam Weinig <​sam@webkit.org> on 2017-10-01
Reviewed by Darin Adler.

  • Scripts/GenerateSettings/GenerateSettingsImplementationFile.py:
  • Scripts/GenerateSettings/GenerateSettingsHeaderFile.py:

(printGetterAndSetter):

Use the new typeIsAggregate predicate to determine whether to
use const reference or not.

(includeForSetting): Deleted.

Move includeForSetting to Settings.py with the rest of the Setting
helpers.

  • Scripts/GenerateSettings/Settings.py:

(mapToIDLType):
(typeIsPrimitive):
(typeIsAggregate):

Add predicate to determine if a setting's type is an aggregate (struct or class)
or a primitive. Remove references to size_t, which is not used.

6:35 PM Changeset in webkit [222694] by weinig@apple.com
  • 2 edits in trunk/LayoutTests

Skip failing tests from r222692 that have different output on each run.


Skips imported/w3c/web-platform-tests/fetch/api/abort/general.any.html
and imported/w3c/web-platform-tests/fetch/api/abort/general.any.worker.html

6:28 PM Changeset in webkit [222693] by weinig@apple.com
  • 1 edit
    2 adds in trunk/LayoutTests/imported/w3c

Add missing results from r222690.

  • web-platform-tests/XMLHttpRequest/responseType-document-in-worker-expected.txt: Added.
  • web-platform-tests/XMLHttpRequest/responseXML-unavailable-in-worker-expected.txt: Added.
3:32 PM Changeset in webkit [222692] by weinig@apple.com
  • 16 edits
    6 adds in trunk

Add support for DOM aborting (​https://dom.spec.whatwg.org/#aborting-ongoing-activities)
​https://bugs.webkit.org/show_bug.cgi?id=177718

Reviewed by Darin Adler.

LayoutTests/imported/w3c:

  • web-platform-tests/dom/abort/event.any-expected.txt:
  • web-platform-tests/dom/abort/event.any.worker-expected.txt:
  • web-platform-tests/dom/interface-objects-expected.txt:
  • web-platform-tests/dom/interfaces-expected.txt:
  • web-platform-tests/fetch/api/abort/cache.https-expected.txt:
  • web-platform-tests/fetch/api/abort/general.any-expected.txt:
  • web-platform-tests/fetch/api/abort/general.any.worker-expected.txt:
  • web-platform-tests/payment-request/interfaces.https-expected.txt:

Update test results.

Source/WebCore:

Adds standalone support for AbortController and AbortSignal. No integration
with other specs yet.

  • CMakeLists.txt:
  • DerivedSources.make:
  • WebCore.xcodeproj/project.pbxproj:


Add new files.


  • dom/AbortController.cpp: Added.
  • dom/AbortController.h: Added.
  • dom/AbortController.idl: Added.
  • dom/AbortSignal.cpp: Added.
  • dom/AbortSignal.h: Added.
  • dom/AbortSignal.idl: Added.


Add basic support AbortController and AbortSignal.


  • dom/EventTargetFactory.in:


Add AbortSignal to the list of EventTargets.

LayoutTests:

  • js/dom/global-constructors-attributes-dedicated-worker-expected.txt:

Update test results.

2:24 PM Changeset in webkit [222691] by Antti Koivisto
  • 4 edits in trunk/Source/WebCore

Use WeakPtr for first-letter memory management
​https://bugs.webkit.org/show_bug.cgi?id=177716

Reviewed by Darin Adler.

  • rendering/RenderElement.cpp:

(WebCore::RenderElement::destroyLeftoverChildren):

Remove first-letter special case.
Use removeAndDestroyChild instead of calling destroy() directly. The latter should
eventually stop calling takeChild and assert that the renderer is not in the tree.

  • rendering/RenderTextFragment.cpp:

(WebCore::RenderTextFragment::willBeDestroyed):
(WebCore::RenderTextFragment::setText):

  • rendering/RenderTextFragment.h:

Use WeakPtr.

2:12 PM Changeset in webkit [222690] by commit-queue@webkit.org
  • 6 edits
    4 adds in trunk

XMLHttpRequest's responseXML should be annotated with [Exposed=Window]
​https://bugs.webkit.org/show_bug.cgi?id=177714

Patch by Sam Weinig <​sam@webkit.org> on 2017-10-01
Reviewed by Darin Adler.

LayoutTests/imported/w3c:

  • web-platform-tests/XMLHttpRequest/resources/responseType-document-in-worker.js: Added.
  • web-platform-tests/XMLHttpRequest/resources/responseXML-unavailable-in-worker.js: Added.
  • web-platform-tests/XMLHttpRequest/resources/w3c-import.log:
  • web-platform-tests/XMLHttpRequest/responseType-document-in-worker.html: Added.
  • web-platform-tests/XMLHttpRequest/responseXML-unavailable-in-worker.html: Added.
  • web-platform-tests/XMLHttpRequest/w3c-import.log:

Import latest XMLHttpRequest tests that include tests for responseXML not
being available in workers and setting a responseType of 'document' being
a no-op in workers.

Source/WebCore:

Tests: imported/w3c/web-platform-tests/XMLHttpRequest/responseType-document-in-worker.html

imported/w3c/web-platform-tests/XMLHttpRequest/responseXML-unavailable-in-worker.html

  • xml/XMLHttpRequest.cpp:

(WebCore::XMLHttpRequest::responseXML):

Replace returning null for non-document contexts with an assertion now
that the bindings layer ensures this doesn't get called.

(WebCore::XMLHttpRequest::setResponseType):

Match the spec and turn attempts to set a responseType of 'document' in
non-documents contexts as a no-op.

  • xml/XMLHttpRequest.idl:

Address FIXME and annotate responseXML with [Exposed=Window] now that it
is supported.

10:23 AM Changeset in webkit [222689] by commit-queue@webkit.org
  • 36 edits
    2 deletes in trunk

Unreviewed, rolling out r222564.
​https://bugs.webkit.org/show_bug.cgi?id=177720

"It regressed JetStream by 2% on iOS caused by a 50%
regression on the bigfib subtest" (Requested by saamyjoon on
#webkit).

Reverted changeset:

"Add Above/Below comparisons for UInt32 patterns"
​https://bugs.webkit.org/show_bug.cgi?id=177281
​http://trac.webkit.org/changeset/222564

Note: See TracTimeline for information about the timeline view.