Timeline
Oct 9, 2017:
- 10:53 PM Changeset in webkit [223124] by
-
- 9 edits6 adds in trunk
asyncshould be able to be used as an imported binding name
https://bugs.webkit.org/show_bug.cgi?id=176573
Reviewed by Saam Barati.
JSTests:
- modules/import-default-async.js: Added.
- modules/import-named-async-as.js: Added.
- modules/import-named-async.js: Added.
- modules/import-named-async/target.js: Added.
- modules/import-namespace-async.js: Added.
- test262.yaml:
Source/JavaScriptCore:
Previously, we have ASYNC keyword in the parser. This is introduced only for performance,
and ECMA262 spec does not categorize "async" to keyword. This makes parser code complicated,
since ASYNC should be handled as IDENT. If we missed this ASYNC keyword, we cause a bug.
For example, import declaration failed to bind imported binding to the name "async" because
the parser considered ASYNC as keyword.
This patch removes ASYNC keyword from the parser. By carefully handling ASYNC, we can keep
the current performance without using this ASYNC keyword.
We also add
escapedfield to token data since contextual keyword is valid only if it does
not contain any escape sequences. We fix bunch of contextual keyword use with this fix too
e.g.of in for-of. This improves test262 score.
- parser/Keywords.table:
- parser/Lexer.cpp:
(JSC::Lexer<LChar>::parseIdentifier):
(JSC::Lexer<UChar>::parseIdentifier):
(JSC::Lexer<CharacterType>::parseIdentifierSlowCase):
- parser/Parser.cpp:
(JSC::Parser<LexerType>::parseStatementListItem):
(JSC::Parser<LexerType>::parseForStatement):
(JSC::Parser<LexerType>::parseStatement):
(JSC::Parser<LexerType>::maybeParseAsyncFunctionDeclarationStatement):
(JSC::Parser<LexerType>::parseClass):
(JSC::Parser<LexerType>::parseExportDeclaration):
(JSC::Parser<LexerType>::parseAssignmentExpression):
(JSC::Parser<LexerType>::parseProperty):
(JSC::Parser<LexerType>::parsePrimaryExpression):
(JSC::Parser<LexerType>::parseMemberExpression):
(JSC::Parser<LexerType>::printUnexpectedTokenText):
- parser/Parser.h:
(JSC::Parser::matchContextualKeyword):
- parser/ParserTokens.h:
- runtime/CommonIdentifiers.h:
- 10:11 PM Changeset in webkit [223123] by
-
- 4 edits in trunk/Source/JavaScriptCore
We don't need to clearEmptyObjectStructureForPrototype because JSGlobalObject* is part of the cache's key
https://bugs.webkit.org/show_bug.cgi?id=177987
Reviewed by Filip Pizlo.
- runtime/JSProxy.cpp:
(JSC::JSProxy::setTarget):
- runtime/PrototypeMap.cpp:
(JSC::PrototypeMap::clearEmptyObjectStructureForPrototype): Deleted.
- runtime/PrototypeMap.h:
- 9:44 PM Changeset in webkit [223122] by
-
- 4 edits in trunk
Vector should be able to easily create from a list of movable only items
https://bugs.webkit.org/show_bug.cgi?id=176432
Patch by Youenn Fablet <youenn@apple.com> on 2017-10-09
Reviewed by Darin Adler.
Source/WTF:
Adding static from method to construct a Vector from movable-only items.
This may also be used instead of initializer list constructor for types that would benefit of being moved.
- wtf/Vector.h:
(WTF::Vector::Vector):
(WTF::Vector::from):
(WTF::Vector::uncheckedInitialize): Introduced as an optimization to set the vector size once.
(WTF::Malloc>::reserveInitialCapacity):
Tools:
- TestWebKitAPI/Tests/WTF/Vector.cpp:
(TestWebKitAPI::TEST):
- 9:28 PM Changeset in webkit [223121] by
-
- 6 edits2 adds in trunk/Source/bmalloc
Use one virtual allocation for all gigacages and their runways
https://bugs.webkit.org/show_bug.cgi?id=178050
Reviewed by Saam Barati.
- bmalloc/Gigacage.cpp:
(Gigacage::ensureGigacage):
(Gigacage::runway): Deleted.
(Gigacage::totalSize): Deleted.
- bmalloc/Gigacage.h:
- 9:12 PM Changeset in webkit [223120] by
-
- 3 edits in branches/safari-604-branch/Source/WebCore
Cherry-pick r221430. rdar://problem/34770998
- 9:12 PM Changeset in webkit [223119] by
-
- 2 edits in branches/safari-604-branch/Source/WebCore
Cherry-pick r222995. rdar://problem/34891302
- 9:10 PM Changeset in webkit [223118] by
-
- 5 edits in trunk
Calling fileSystemDirectoryEntry.getDirectory() with empty path should not fail
https://bugs.webkit.org/show_bug.cgi?id=178114
Reviewed by Ryosuke Niwa.
Source/WebCore:
Calling fileSystemDirectoryEntry.getDirectory() with empty/null/undefined path should not fail as per:
The empty string is a valid path as per:
This aligns out behavior with Chrome.
No new tests, updated existing test.
- Modules/entriesapi/DOMFileSystem.cpp:
(WebCore::isValidVirtualPath):
(WebCore::resolveRelativeVirtualPath):
LayoutTests:
Extend layout test coverage.
- editing/pasteboard/entries-api/datatransfer-items-drop-getDirectory-expected.txt:
- editing/pasteboard/entries-api/datatransfer-items-drop-getDirectory.html:
- 8:19 PM Changeset in webkit [223117] by
-
- 5 edits in trunk
It should not be possible to submit a form that is disconnected
https://bugs.webkit.org/show_bug.cgi?id=178099
Reviewed by Sam Weinig.
LayoutTests/imported/w3c:
Rebaseline several WPT tests now that more checks are passing.
- web-platform-tests/dom/events/Event-dispatch-click-expected.txt:
- web-platform-tests/html/semantics/forms/the-button-element/button-click-submits-expected.txt:
Source/WebCore:
It should not be possible to submit a form that is disconnected. Both Firefox and Chrome agree with the specification.
This is as per:
https://html.spec.whatwg.org/multipage/form-control-infrastructure.html#form-submission-algorithm (step 1)
which refers to:
https://html.spec.whatwg.org/multipage/links.html#cannot-navigate
Form cannot navigate when it is disconnected.
No new tests, rebaselined existing tests.
- html/HTMLFormElement.cpp:
(WebCore::HTMLFormElement::prepareForSubmission):
- 7:48 PM Changeset in webkit [223116] by
-
- 2 edits in trunk/Source/JavaScriptCore
JSCell::didBecomePrototype is racy
https://bugs.webkit.org/show_bug.cgi?id=178110
Reviewed by Saam Barati.
The indexing type can be modified by any thread using CAS. So, we need to use atomics when
modifying it. We don't need to use atomics when reading it though (since it's just one field).
- runtime/JSCellInlines.h:
(JSC::JSCell::didBecomePrototype):
- 7:14 PM Changeset in webkit [223115] by
-
- 3 edits in trunk/LayoutTests
Mark http/tests/paymentrequest/payment-request-abort-method.https.html as flaky.
https://bugs.webkit.org/show_bug.cgi?id=178107
Unreviewed test gardening.
- platform/ios-wk2/TestExpectations:
- platform/mac-wk2/TestExpectations:
- 7:05 PM Changeset in webkit [223114] by
-
- 2 edits2 deletes in trunk/LayoutTests
Rebaseline imported/w3c/web-platform-tests/dom/events/EventTarget-dispatchEvent.html for iOS.
Unreviewed test gardening.
- platform/ios-simulator-wk2/imported/w3c/web-platform-tests/dom/events/EventTarget-dispatchEvent-expected.txt: Removed.
- platform/ios-wk2/imported/w3c/web-platform-tests/dom/events/EventTarget-dispatchEvent-expected.txt: Removed.
- platform/ios/imported/w3c/web-platform-tests/dom/events/EventTarget-dispatchEvent-expected.txt:
- 6:40 PM Changeset in webkit [223113] by
-
- 21 edits4 adds in trunk
Enable gigacage on iOS
https://bugs.webkit.org/show_bug.cgi?id=177586
Reviewed by JF Bastien.
JSTests:
Add tests for when Gigacage gets runtime disabled.
- stress/disable-gigacage-arrays.js: Added.
(foo):
- stress/disable-gigacage-strings.js: Added.
(foo):
- stress/disable-gigacage-typed-arrays.js: Added.
(foo):
Source/bmalloc:
Introduce the ability to disable gigacage at runtime if allocation fails. If any step of gigacage
allocation fails, we free all of the gigacages and turn off gigacage support.
Reland this after confirming that the 20% Kraken regression was a one-bot fluke. Local testing on the
same kind of system did not show the regression. Saam and I both tried independently.
- CMakeLists.txt:
- bmalloc.xcodeproj/project.pbxproj:
- bmalloc/Cache.cpp:
(bmalloc::Cache::scavenge):
- bmalloc/Cache.h:
(bmalloc::Cache::tryAllocate):
(bmalloc::Cache::allocate):
(bmalloc::Cache::deallocate):
(bmalloc::Cache::reallocate):
- bmalloc/Gigacage.cpp:
(Gigacage::ensureGigacage):
(Gigacage::runway):
(Gigacage::totalSize):
(Gigacage::shouldBeEnabled):
(): Deleted.
(Gigacage::Callback::Callback): Deleted.
(Gigacage::Callback::function): Deleted.
(Gigacage::PrimitiveDisableCallbacks::PrimitiveDisableCallbacks): Deleted.
- bmalloc/Gigacage.h:
(Gigacage::wasEnabled):
(Gigacage::isEnabled):
(Gigacage::runway): Deleted.
(Gigacage::totalSize): Deleted.
- bmalloc/HeapKind.cpp: Added.
(bmalloc::isActiveHeapKind):
(bmalloc::mapToActiveHeapKind):
- bmalloc/HeapKind.h:
(bmalloc::isActiveHeapKindAfterEnsuringGigacage):
(bmalloc::mapToActiveHeapKindAfterEnsuringGigacage):
- bmalloc/Scavenger.cpp:
(bmalloc::Scavenger::scavenge):
- bmalloc/bmalloc.h:
(bmalloc::api::tryLargeMemalignVirtual):
(bmalloc::api::freeLargeVirtual):
(bmalloc::api::isEnabled):
Source/JavaScriptCore:
The hardest part of enabling Gigacage on iOS is that it requires loading global variables while
executing JS, so the LLInt needs to know how to load from global variables on all platforms that
have Gigacage. So, this teaches ARM64 how to load from global variables.
Also, this makes the code handle disabling the gigacage a bit better.
- ftl/FTLLowerDFGToB3.cpp:
(JSC::FTL::DFG::LowerDFGToB3::caged):
- jit/AssemblyHelpers.h:
(JSC::AssemblyHelpers::cage):
(JSC::AssemblyHelpers::cageConditionally):
- offlineasm/arm64.rb:
- offlineasm/asm.rb:
- offlineasm/instructions.rb:
Tools:
Add a mode to test disabling Gigacage.
- Scripts/run-jsc-stress-tests:
- Scripts/webkitruby/jsc-stress-test-writer-default.rb:
- 6:30 PM Changeset in webkit [223112] by
-
- 2 edits in trunk/Source/JavaScriptCore
Evaluate the benefit of skipping dead code in the DFGByteCodeParser when a function returns in its first block
https://bugs.webkit.org/show_bug.cgi?id=177925
Reviewed by Saam Barati.
We used to do a rather weird "optimisation" in the bytecode parser: when a function would return in its first block,
the rest of the function was skipped. Since it has no actual impact on any benchmarks from what I could see, I removed
that code. It allows some changes to parseBlock(), since it now returns void and no-longer bool (it was returning a boolean that said whether that case happened or not).
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::parseBlock):
(JSC::DFG::ByteCodeParser::parseCodeBlock):
- 6:20 PM Changeset in webkit [223111] by
-
- 2 edits in trunk/Source/WTF
Disable INPUT_TYPE_COLOR in FeatureDefines.h
https://bugs.webkit.org/show_bug.cgi?id=178103
<rdar://problem/34872127>
Reviewed by Simon Fraser.
- wtf/FeatureDefines.h:
Because FeatureDefines.h overrides features that are not enabled in
FeatureDefines.xcconfig, you currently have to turn INPUT_TYPE_COLOR
off in two places. Since we only ever want it on for Mac, it's OK
to depend on the xcconfig defining it.
- 6:15 PM Changeset in webkit [223110] by
-
- 6 edits3 adds in trunk
Delete button doesn't fully delete certain emoji
https://bugs.webkit.org/show_bug.cgi?id=178096
<rdar://problem/34785106>
Reviewed by Simon Fraser.
Source/WebCore:
System infrastructure for handling emoji changes every year. Instead of having
custom code to specifically walk over codepoints, we should delegate to the
system handling.
Test: editing/deleting/delete-emoji.html
- rendering/RenderText.cpp:
(WebCore::RenderText::previousOffset const):
(WebCore::RenderText::previousOffsetForBackwardDeletion const):
(WebCore::RenderText::nextOffset const):
(WebCore::isHangulLVT): Deleted.
(WebCore::isMark): Deleted.
(WebCore::isRegionalIndicator): Deleted.
(WebCore::isInArmenianToLimbuRange): Deleted.
LayoutTests:
- editing/deleting/delete-emoji-2.html:
- platform/mac/editing/deleting/delete-emoji-expected.txt:
- platform/mac/editing/deleting/delete-emoji-2-expected.txt:
- platform/ios/editing/deleting/delete-emoji-expected.txt:
- platform/ios/editing/deleting/delete-emoji-2-expected.txt:
- platform/win/TestExpectations:
- 5:19 PM Changeset in webkit [223109] by
-
- 1 edit in trunk/Source/WebCore/testing/Internals.cpp
Fix two test crashes caused by r223076.
- testing/Internals.cpp:
(WebCore::Internals::Internals):
- 5:08 PM Changeset in webkit [223108] by
-
- 2 edits in branches/safari-604-branch/Source/WebCore
Cherry-pick r222786. rdar://problem/34820881
- 5:08 PM Changeset in webkit [223107] by
-
- 6 edits in branches/safari-604-branch
Cherry-pick r222779. rdar://problem/34820881
- 5:08 PM Changeset in webkit [223106] by
-
- 20 edits2 adds in branches/safari-604-branch
Cherry-pick r220412. rdar://problem/34771061
- 5:08 PM Changeset in webkit [223105] by
-
- 8 edits3 adds in branches/safari-604-branch
Cherry-pick r221098. rdar://problem/34771028
- 5:08 PM Changeset in webkit [223104] by
-
- 12 edits in branches/safari-604-branch/Source/WebCore
Cherry-pick r221046. rdar://problem/34891067
- 5:08 PM Changeset in webkit [223103] by
-
- 7 edits10 adds in branches/safari-604-branch
Cherry-pick r222402. rdar://problem/34770839
- 5:08 PM Changeset in webkit [223102] by
-
- 2 edits in branches/safari-604-branch/Source/JavaScriptCore
Cherry-pick r222748. rdar://problem/34820919
- 5:08 PM Changeset in webkit [223101] by
-
- 2 edits in branches/safari-604-branch/Source/WebCore
Apply patch. rdar://problem/34770842
Cherry-pick r221083. rdar://problem/34770842, rdar://problem/34770849
- 5:08 PM Changeset in webkit [223100] by
-
- 3 edits1 add in branches/safari-604-branch
Cherry-pick r222598. rdar://problem/34771434
- 5:08 PM Changeset in webkit [223099] by
-
- 14 edits in branches/safari-604-branch
Cherry-pick r222190. rdar://problem/34771470
- 5:08 PM Changeset in webkit [223098] by
-
- 3 edits in branches/safari-604-branch/Source/WebCore
Cherry-pick r221100. rdar://problem/34771028
- 5:08 PM Changeset in webkit [223097] by
-
- 2 edits in branches/safari-604-branch/Source/WebKit
Cherry-pick r221036. rdar://problem/34771044
- 5:08 PM Changeset in webkit [223096] by
-
- 4 edits2 adds in branches/safari-604-branch
Cherry-pick r221016. rdar://problem/34770830
- 5:08 PM Changeset in webkit [223095] by
-
- 3 edits2 deletes in branches/safari-604-branch
Cherry-pick r220484. rdar://problem/34770810
- 5:07 PM Changeset in webkit [223094] by
-
- 14 edits2 adds in branches/safari-604-branch
Cherry-pick r220302. rdar://problem/34770803
- 5:07 PM Changeset in webkit [223093] by
-
- 3 edits2 adds in branches/safari-604-branch
Cherry-pick r221400. rdar://problem/34771396
- 5:07 PM Changeset in webkit [223092] by
-
- 4 edits2 adds in branches/safari-604-branch
Cherry-pick r221128. rdar://problem/34771005
- 5:07 PM Changeset in webkit [223091] by
-
- 13 edits in trunk/Source/WebCore
Image data should be coalesced if it comes in small chunks before updating the ImageSource
https://bugs.webkit.org/show_bug.cgi?id=175890
Patch by Said Abou-Hallawa <sabouhallawa@apple.com> on 2017-10-09
Reviewed by Simon Fraser.
Coalesce the updates, which an Image makes when receiving encoded data in
small chunks, for all platforms. Ensure the clients of the CachedImage
won't be notified unless an update in the ImageSource happens.
I need to change some functions' names to better implement this patch.
The names of these functions have been confusing:
CachedImage::addData(SharedBuffer&)
CachedImage::addDataBuffer(const char* data, unsigned)
CachedImage::addIncrementalDataBuffer(SharedBuffer&)
The image data is not buffered incrementally into the CachedImage. When
new data is received, SubresourceLoader calls CachedImage to "update" its
m_data with either a SharedBuffer or a data pointer. In either case the
SharedBuffer or the pointer contains all the loaded data. SubresourceLoader
calls CachedImage to update its m_data, to ensure its m_image is created
and to notify its clients with the new data.
The verb "add" in the functions' name is misleading. I am suggesting the
following names instead:
CachedImage::updateBuffer(SharedBuffer&)
CachedImage::updateData(const char*, unsigned)
CachedImage::doUpdateBuffer(SharedBuffer&)
The first two are the virtual ones. They are called form SubresourceLoader.
The third one is the internal implementation to update the m_data member.
The same names will be used in the following classes:
CachedResource which is the base class of CachedImage
CachedRawResource which is derived from CachedResource
CachedTextTrack which is derived from CachedResource
- html/ImageDocument.cpp:
(WebCore::ImageDocument::updateDuringParsing):
- loader/SubresourceLoader.cpp:
(WebCore::SubresourceLoader::didReceiveDataOrBuffer):
- loader/cache/CachedImage.cpp:
(WebCore::CachedImage::clearImage): Reset the update back off members.
(WebCore::CachedImage::doUpdateBuffer): Don't update CachedImage with
the new data if it comes in small chunks with fast rate.
(WebCore::CachedImage::shouldDeferUpdateImageData const): This code is moved
from ImageSource::dataChanged().
(WebCore::CachedImage::didUpdateImageData): Ditto.
(WebCore::CachedImage::updateImageData):
(WebCore::CachedImage::updateBuffer):
(WebCore::CachedImage::updateData):
(WebCore::CachedImage::finishLoading):
(WebCore::CachedImage::addIncrementalDataBuffer): Deleted.
(WebCore::CachedImage::setImageDataBuffer): Deleted.
(WebCore::CachedImage::addDataBuffer): Deleted.
(WebCore::CachedImage::addData): Deleted.
- loader/cache/CachedImage.h:
- loader/cache/CachedRawResource.cpp:
(WebCore::CachedRawResource::updateBuffer):
(WebCore::CachedRawResource::updateData):
(WebCore::CachedRawResource::addDataBuffer): Deleted.
(WebCore::CachedRawResource::addData): Deleted.
- loader/cache/CachedRawResource.h:
- loader/cache/CachedResource.cpp:
(WebCore::CachedResource::updateBuffer):
(WebCore::CachedResource::updateData):
(WebCore::CachedResource::addDataBuffer): Deleted.
(WebCore::CachedResource::addData): Deleted.
- loader/cache/CachedResource.h:
- loader/cache/CachedTextTrack.cpp:
(WebCore::CachedTextTrack::doUpdateBuffer): Rename updateData() to doUpdateBuffer().
(WebCore::CachedTextTrack::updateBuffer): Rename addDataBuffer() to updateBuffer().
(WebCore::CachedTextTrack::finishLoading): Call the internal function doUpdateBuffer().
(WebCore::CachedTextTrack::updateData): Deleted.
(WebCore::CachedTextTrack::addDataBuffer): Deleted.
- loader/cache/CachedTextTrack.h:
- platform/graphics/ImageSource.cpp:
(WebCore::ImageSource::dataChanged): Move the update back off code to CachedImage::updateData().
- platform/graphics/ImageSource.h:
- 5:07 PM Changeset in webkit [223090] by
-
- 2 edits in branches/safari-604-branch/Source/WebCore
Cherry-pick r221116. rdar://problem/34771068
- 5:07 PM Changeset in webkit [223089] by
-
- 19 edits in branches/safari-604-branch
Cherry-pick r220718. rdar://problem/34771041
- 5:07 PM Changeset in webkit [223088] by
-
- 6 edits in branches/safari-604-branch/Source
Cherry-pick r220496. rdar://problem/34770816
- 5:05 PM Changeset in webkit [223087] by
-
- 3 edits in trunk/LayoutTests/imported/w3c
usemap-casing.html test passes in browser, fails in LayoutTests because it is taller than 600px
https://bugs.webkit.org/show_bug.cgi?id=178053
Reviewed by Youenn Fablet.
Re-sync html/semantics/embedded-content/the-img-element/usemap-casing.html after:
- web-platform-tests/html/semantics/embedded-content/the-img-element/usemap-casing-expected.txt:
- web-platform-tests/html/semantics/embedded-content/the-img-element/usemap-casing.html:
- 4:55 PM Changeset in webkit [223086] by
-
- 6 edits in trunk/Source/JavaScriptCore
Refactor the inliner to simplify block linking
https://bugs.webkit.org/show_bug.cgi?id=177922
Reviewed by Saam Barati.
The biggest refactor changes the way blocks are linked. In DFGByteCodeParser, most terminals (such as Jump or Branch) jump to nullptr initially, and have
some metadata indicating the bytecode index corresponding to their targets. They are later linked to the right basic block using two fields of InlineStackEntry:
- m_unlinkedBlocks is just a worklist of blocks with a terminal that needs to be linked
- m_linkingTargets is a dictionary from bytecode indices to BasicBlock*
Before refactoring, every block was automatically added to both of these fields, for the InlineStackEntry of whatever function allocated it.
This created a significant number of corner cases, such as blocks allocated in a caller, with a terminal written by an inlined callee and pointing to a block in the callee,
or blocks allocated in an inline callee, with a terminal written by the caller after it returns and pointing to a block in the caller, or blocks with a manually linked
terminal that needs to be taken off m_unlinkedBlocks.
I changed things so that blocks are only added to m_unlinkedBlocks when their terminal gets written (see the LAST_OPCODE macro) making it a lot easier to be in the "right" InlineStackEntry,
that is the one that holds their target in its m_linkingTargets field.
There are a few much smaller refactors in this patch:
- parse() is now of type void insted of bool (it was always returning true)
- The 7 and 8 arguments of handleCall were inlined in its 3 arguments version for readability
- The 9 argument version was cleaned up and simplified
- I made separate allocateBlock routines because the little dance with adoptRef(* new BasicBlock(...)) was being repeated in lots of places, and typos in that were a major source of bugs during other refactorings
- Jumps are now created with explicit addJumpTo() functions, providing some sanity checking through asserts and didLink()
- Blocks are only added to m_unlinkedBlocks if they end in a terminal that linkBlock works with (see LAST_OPCODE)
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::addToGraph):
(JSC::DFG::ByteCodeParser::handleCall):
(JSC::DFG::ByteCodeParser::refineStatically):
(JSC::DFG::ByteCodeParser::handleRecursiveTailCall):
(JSC::DFG::ByteCodeParser::handleVarargsCall):
(JSC::DFG::ByteCodeParser::inlineCall):
(JSC::DFG::ByteCodeParser::attemptToInlineCall):
(JSC::DFG::ByteCodeParser::handleInlining):
(JSC::DFG::ByteCodeParser::handleIntrinsicCall):
(JSC::DFG::ByteCodeParser::handleConstantInternalFunction):
(JSC::DFG::ByteCodeParser::parseBlock):
(JSC::DFG::ByteCodeParser::parseCodeBlock):
(JSC::DFG::ByteCodeParser::parse):
(JSC::DFG::parse):
(JSC::DFG::ByteCodeParser::cancelLinkingForBlock): Deleted.
- dfg/DFGByteCodeParser.h:
- dfg/DFGPlan.cpp:
(JSC::DFG::Plan::compileInThreadImpl):
- 4:45 PM Changeset in webkit [223085] by
-
- 1 copy in tags/Safari-604.3.5.0.1
Tag Safari-604.3.5.0.1.
- 4:35 PM Changeset in webkit [223084] by
-
- 13 edits1 add in branches/safari-604.3.5.0-branch
Apply patch. rdar://problem/34857459
Apply patch. rdar://problem/34857459
- 4:27 PM Changeset in webkit [223083] by
-
- 2 edits in trunk/Source/WebKit
Fix typo of virtual keyword in PageClientImplIOS.h
https://bugs.webkit.org/show_bug.cgi?id=178088
Patch by Jeremy Jones <jeremyj@apple.com> on 2017-10-09
Reviewed by Simon Fraser.
This compile error happens when FULLSCREEN_API is enabled for iOS.
Remove the redundant virtual keyword since function is marked override.
- UIProcess/ios/PageClientImplIOS.h:
- 4:27 PM Changeset in webkit [223082] by
-
- 2 edits in trunk/Source/WebKit
[iOS][WK2] Tiles outsides the viewport are sometimes missing after relaunching a crashes WebProcess
https://bugs.webkit.org/show_bug.cgi?id=178095
<rdar://problem/34415016>
Reviewed by Simon Fraser.
Make sure we reset WKWebView._hasScheduledVisibleRectUpdate to NO in WKWebView._processDidExit.
_scheduleVisibleContentRectUpdateAfterScrollInView would otherwise return early because
WKWebView._hasScheduledVisibleRectUpdate is always YES. Normally,
_addUpdateVisibleContentRectPreCommitHandler sets a CATransaction commit handler that
resets _hasScheduledVisibleRectUpdate to NO, but it does not do so when ![webView _isValid]
(which is true when the WebProcess has crashed.
Also reset WKWebView._commitDidRestoreScrollPosition to NO in WKWebView._processDidExit even
though it does not seem to be the cause of this bug. It seems to make sense to reset this member
when the process crashes.
- UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _processDidExit]):
- 4:14 PM Changeset in webkit [223081] by
-
- 15 edits17 adds in trunk
Implement RegExp Unicode property escapes
https://bugs.webkit.org/show_bug.cgi?id=172069
Reviewed by JF Bastien.
JSTests:
Enabled Unicode Property tests.
- test262.yaml:
Source/JavaScriptCore:
Added Unicode Properties by extending the existing CharacterClass processing.
Introduced a new Python script, generateYarrUnicodePropertyTables.py, that parses
Unicode Database files to create character class data. The result is a set of functions
that return character classes, one for each of the required Unicode properties.
There are many cases where many properties are handled by one function, primarily due to
property aliases, but also due to Script_Extension properties that are the same as the
Script property for the same script value.
Extended the BuiltInCharacterClassID enum so it can be used also for Unicode property
character classes. Unicode properties are the enum value BaseUnicodePropertyID plus a
zero based value, that value being the index to the corrensponding character class
function. The generation script also creates static hashing tables similar to what we
use for the generated .lut.h lookup table files. These hashing tables map property
names to the function index. Using these hashing tables, we can lookup a property
name and if present convert it to a function index. We add that index to
BaseUnicodePropertyID to create a BuiltInCharacterClassID.
When we do syntax parsing, we convert the property to its corresponding BuiltInCharacterClassID.
When doing real parsing we takes the returned BuiltInCharacterClassID and use it to get
the actual character class by calling the corresponding generated function.
Added a new CharacterClass constructor that can take literal arrays for ranges and matches
to make the creation of large static character classes more efficent.
Since the Unicode character classes typically have more matches and ranges, the character
class matching in the interpreter has been updated to use binary searching for matches and
ranges with more than 6 entries.
- CMakeLists.txt:
- DerivedSources.make:
- JavaScriptCore.xcodeproj/project.pbxproj:
- Scripts/generateYarrUnicodePropertyTables.py: Added.
(openOrExit):
(openUCDFileOrExit):
(verifyUCDFilesExist):
(ceilingToPowerOf2):
(Aliases):
(Aliases.init):
(Aliases.parsePropertyAliasesFile):
(Aliases.parsePropertyValueAliasesFile):
(Aliases.globalAliasesFor):
(Aliases.generalCategoryAliasesFor):
(Aliases.generalCategoryForAlias):
(Aliases.scriptAliasesFor):
(Aliases.scriptNameForAlias):
(PropertyData):
(PropertyData.init):
(PropertyData.setAliases):
(PropertyData.makeCopy):
(PropertyData.getIndex):
(PropertyData.getCreateFuncName):
(PropertyData.addMatch):
(PropertyData.addRange):
(PropertyData.addMatchUnorderedForMatchesAndRanges):
(PropertyData.addRangeUnorderedForMatchesAndRanges):
(PropertyData.addMatchUnordered):
(PropertyData.addRangeUnordered):
(PropertyData.removeMatchFromRanges):
(PropertyData.removeMatch):
(PropertyData.dumpMatchData):
(PropertyData.dump):
(PropertyData.dumpAll):
(PropertyData.dumpAll.std):
(PropertyData.createAndDumpHashTable):
(Scripts):
(Scripts.init):
(Scripts.parseScriptsFile):
(Scripts.parseScriptExtensionsFile):
(Scripts.dump):
(GeneralCategory):
(GeneralCategory.init):
(GeneralCategory.createSpecialPropertyData):
(GeneralCategory.findPropertyGroupFor):
(GeneralCategory.addNextCodePoints):
(GeneralCategory.parse):
(GeneralCategory.dump):
(BinaryProperty):
(BinaryProperty.init):
(BinaryProperty.parsePropertyFile):
(BinaryProperty.dump):
- Scripts/hasher.py: Added.
(stringHash):
- Sources.txt:
- ucd/DerivedBinaryProperties.txt: Added.
- ucd/DerivedCoreProperties.txt: Added.
- ucd/DerivedNormalizationProps.txt: Added.
- ucd/PropList.txt: Added.
- ucd/PropertyAliases.txt: Added.
- ucd/PropertyValueAliases.txt: Added.
- ucd/ScriptExtensions.txt: Added.
- ucd/Scripts.txt: Added.
- ucd/UnicodeData.txt: Added.
- ucd/emoji-data.txt: Added.
- yarr/Yarr.h:
- yarr/YarrInterpreter.cpp:
(JSC::Yarr::Interpreter::testCharacterClass):
- yarr/YarrParser.h:
(JSC::Yarr::Parser::parseEscape):
(JSC::Yarr::Parser::parseTokens):
(JSC::Yarr::Parser::isUnicodePropertyValueExpressionChar):
(JSC::Yarr::Parser::tryConsumeUnicodePropertyExpression):
- yarr/YarrPattern.cpp:
(JSC::Yarr::CharacterClassConstructor::appendInverted):
(JSC::Yarr::YarrPatternConstructor::atomBuiltInCharacterClass):
(JSC::Yarr::YarrPatternConstructor::atomCharacterClassBuiltIn):
(JSC::Yarr::YarrPattern::errorMessage):
(JSC::Yarr::PatternTerm::dump):
- yarr/YarrPattern.h:
(JSC::Yarr::CharacterRange::CharacterRange):
(JSC::Yarr::CharacterClass::CharacterClass):
(JSC::Yarr::YarrPattern::reset):
(JSC::Yarr::YarrPattern::unicodeCharacterClassFor):
- yarr/YarrUnicodeProperties.cpp: Added.
(JSC::Yarr::HashTable::entry const):
(JSC::Yarr::unicodeMatchPropertyValue):
(JSC::Yarr::unicodeMatchProperty):
(JSC::Yarr::createUnicodeCharacterClassFor):
- yarr/YarrUnicodeProperties.h: Added.
Source/WebCore:
Refactoring change - Added BuiltInCharacterClassID:: prefix to uses of the enum.
- contentextensions/URLFilterParser.cpp:
(WebCore::ContentExtensions::PatternParser::atomBuiltInCharacterClass):
LayoutTests:
New test.
- js/regexp-unicode-properties-expected.txt: Added.
- js/regexp-unicode-properties.html: Added.
- js/script-tests/regexp-unicode-properties.js: Added.
- 3:58 PM Changeset in webkit [223080] by
-
- 7 edits in branches/safari-604.3.5.0-branch/Source
Versioning.
- 3:49 PM Changeset in webkit [223079] by
-
- 4 edits in trunk/LayoutTests/imported/w3c
ImageBitmap test gardening after https://bugs.webkit.org/show_bug.cgi?id=177963
- web-platform-tests/imagebitmap-renderingcontext/bitmaprenderer-as-imagesource-expected.txt:
- web-platform-tests/imagebitmap-renderingcontext/context-creation-expected.txt:
- web-platform-tests/imagebitmap-renderingcontext/context-preserves-canvas-expected.txt:
- 3:47 PM Changeset in webkit [223078] by
-
- 3 edits in trunk/Source/WebInspectorUI
Web Inspector: Network Tab - Include remote address in the Headers view
https://bugs.webkit.org/show_bug.cgi?id=178094
<rdar://problem/34895221>
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2017-10-09
Reviewed by Devin Rousso.
- Localizations/en.lproj/localizedStrings.js:
- UserInterface/Views/ResourceHeadersContentView.js:
(WI.ResourceHeadersContentView.prototype._refreshSummarySection):
(WI.ResourceHeadersContentView.prototype._resourceMetricsDidChange):
- 3:44 PM Changeset in webkit [223077] by
-
- 7 edits in branches/safari-604.3.5.1-branch/Source
Versioning.
- 3:40 PM Changeset in webkit [223076] by
-
- 19 edits3 copies5 adds2 deletes in trunk
[Payment Request] Implement PaymentRequest.show() and PaymentRequest.hide()
https://bugs.webkit.org/show_bug.cgi?id=178043
<rdar://problem/34076639>
Reviewed by Tim Horton.
LayoutTests/imported/w3c:
- web-platform-tests/payment-request/payment-request-abort-method.https-expected.txt: Removed.
- web-platform-tests/payment-request/payment-request-show-method.https-expected.txt: Removed.
Source/WebCore:
Tests: http/tests/paymentrequest/payment-request-abort-method.https.html
http/tests/paymentrequest/payment-request-show-method.https.html
- Modules/applepay/PaymentCoordinator.h:
- Modules/applepay/PaymentSession.h: Virtually inherited from PaymentSessionBase to
accommodate ApplePayPaymentHandler inheriting from both this and PaymentHandler.
(WebCore::PaymentSession::~PaymentSession): Deleted.
- Modules/applepay/paymentrequest/ApplePayPaymentHandler.cpp:
(WebCore::paymentCoordinator): Virtually inherited from PaymentSessionBase to accommodate
ApplePayPaymentHandler inheriting from both this and PaymentSession.
(WebCore::ApplePayPaymentHandler::hasActiveSession): Added. Calls PaymentCoordinator::hasActiveSession().
(WebCore::ApplePayPaymentHandler::show): Added. Calls PaymentCoordinator::beginPaymentSession().
(WebCore::ApplePayPaymentHandler::hide): Added. Calls PaymentCoordinator::abortPaymentSession().
- Modules/applepay/paymentrequest/ApplePayPaymentHandler.h: Inherited from PaymentSession in
addition to PaymentHandler so that this can be PaymentCoordinator active session.
- Modules/paymentrequest/PaymentHandler.cpp:
(WebCore::PaymentHandler::create):
(WebCore::PaymentHandler::hasActiveSession):
- Modules/paymentrequest/PaymentHandler.h:
- Modules/paymentrequest/PaymentRequest.cpp:
(WebCore::PaymentRequest::~PaymentRequest):
(WebCore::PaymentRequest::show): Rejected the promise if PaymentCoordinator has an active session.
(WebCore::PaymentRequest::abort): Called stop().
(WebCore::PaymentRequest::canSuspendForDocumentSuspension const): Returned true if state is
Interactive and there is an active handler showing.
(WebCore::PaymentRequest::stop): Hid the active session if it's showing, then set state to
Closed and rejected the show promise.
- Modules/paymentrequest/PaymentRequest.h:
- Modules/paymentrequest/PaymentSessionBase.h: Added. Inherits from
RefCounted<PaymentSessionBase> and defines a virtual destructor. This allows subclasses to
virtually inherit a single ref-count to support multiple inheritance.
- WebCore.xcodeproj/project.pbxproj:
- bindings/scripts/CodeGeneratorJS.pm:
(GetGnuVTableOffsetForType): Added ApplePaySession to the list of classes that need a vtable
offset of 3.
- page/MainFrame.cpp:
(WebCore::MainFrame::setPaymentCoordinator): Added a setter for m_paymentCoordinator.
- page/MainFrame.h:
- testing/Internals.cpp:
(WebCore::Internals::Internals): Set the main frame's payment coordinator to a new
PaymentCoordinator with MockPaymentCoordinator as its client.
- testing/MockPaymentCoordinator.cpp: Added a mock PaymentCoordinatorClient for testing.
(WebCore::MockPaymentCoordinator::supportsVersion):
(WebCore::MockPaymentCoordinator::canMakePayments):
(WebCore::MockPaymentCoordinator::canMakePaymentsWithActiveCard):
(WebCore::MockPaymentCoordinator::openPaymentSetup):
(WebCore::MockPaymentCoordinator::showPaymentUI):
(WebCore::MockPaymentCoordinator::paymentCoordinatorDestroyed):
- testing/MockPaymentCoordinator.h: Added.
LayoutTests:
Copied payment-request-abort-method.https.html and payment-request-show-method.https.html
from web-platform-tests/payment-request/ and changed the payment method from basic-card to
Apple Pay. This needs to eventually be upstreamed back to WPT.
- TestExpectations:
- http/tests/paymentrequest/payment-request-abort-method.https-expected.txt: Added.
- http/tests/paymentrequest/payment-request-abort-method.https.html: Added.
- http/tests/paymentrequest/payment-request-show-method.https-expected.txt: Added.
- http/tests/paymentrequest/payment-request-show-method.https.html: Added.
- platform/ios-wk2/TestExpectations:
- platform/mac-wk2/TestExpectations:
- 3:30 PM Changeset in webkit [223075] by
-
- 1 copy in branches/safari-604.3.5.0-branch
New branch.
- 3:28 PM Changeset in webkit [223074] by
-
- 1 copy in branches/safari-604.3.5.1-branch
New branch.
- 3:17 PM Changeset in webkit [223073] by
-
- 31 edits3 adds in trunk
Add quota to cache API
https://bugs.webkit.org/show_bug.cgi?id=177552
Patch by Youenn Fablet <youenn@apple.com> on 2017-10-09
Reviewed by Alex Christensen.
Source/WebCore:
Tests: http/wpt/cache-storage/cache-quota.any.html
Storing padded opaque response body sizes within FetchResponse and CacheStorageConnection.
See https://github.com/whatwg/storage/issues/31 for the rationale about this padding.
Storing in CacheStorageConnection is needed for handling cloned network fetched created responses.
Storing in FetchResponse is needed for handling cloned cache-storage created opaque responses.
Adding internals to query and set the fuzzed size of a response.
- Modules/cache/CacheStorageConnection.cpp:
(WebCore::computeRealBodySize):
(WebCore::CacheStorageConnection::computeRecordBodySize):
(WebCore::CacheStorageConnection::setResponseBodySizeWithPadding):
(WebCore::CacheStorageConnection::responseBodySizeWithPadding const):
- Modules/cache/CacheStorageConnection.h:
- Modules/cache/DOMCache.cpp:
(WebCore::DOMCache::toConnectionRecord):
(WebCore::DOMCache::updateRecords):
- Modules/cache/DOMCache.h:
- Modules/cache/DOMCacheEngine.cpp:
(WebCore::DOMCacheEngine::errorToException):
(WebCore::DOMCacheEngine::Record::copy const):
- Modules/cache/DOMCacheEngine.h:
- Modules/cache/WorkerCacheStorageConnection.cpp:
(WebCore::toCrossThreadRecordData):
(WebCore::fromCrossThreadRecordData):
- Modules/fetch/FetchResponse.cpp:
(WebCore::FetchResponse::clone):
(WebCore::FetchResponse::BodyLoader::didReceiveResponse):
- Modules/fetch/FetchResponse.h:
- Modules/fetch/FetchResponse.idl:
- testing/Internals.cpp:
(WebCore::Internals::setResponseSizeWithPadding):
(WebCore::Internals::responseSizeWithPadding const):
- testing/Internals.h:
- testing/Internals.idl:
Source/WebKit:
Adding support for quota checking in CacheStorage::Caches.
It is passed to NetworkProcess at creation time.
Default quota size is configured to 400Ko by origin per default.
This value is suitable for testing.
Future patch should raise this default value and allows configuring it.
Quota is computed based on the response body size.
This size is padded at WebCore for opaque responses.
Size is stored persistently as opaque response padded size should remain stable.
See https://github.com/whatwg/storage/issues/31 for the rationale about this padding.
In case of putting several records at the same time, the size of all records
is computed so that all records will be written or rejected together.
Sending QuotaExceeded error when quota is exceeded.
Future effort should allow asking UIProcess for quota extension.
- NetworkProcess/NetworkProcess.cpp:
(WebKit::NetworkProcess::cacheStoragePerOriginQuota const):
- NetworkProcess/NetworkProcess.h:
- NetworkProcess/NetworkProcessCreationParameters.cpp:
(WebKit::NetworkProcessCreationParameters::encode const):
(WebKit::NetworkProcessCreationParameters::decode):
- NetworkProcess/NetworkProcessCreationParameters.h:
- NetworkProcess/cache/CacheStorageEngine.cpp:
(WebKit::CacheStorage::Engine::readCachesFromDisk):
- NetworkProcess/cache/CacheStorageEngineCache.cpp:
(WebKit::CacheStorage::Cache::toRecordInformation):
(WebKit::CacheStorage::isolatedCopy):
(WebKit::CacheStorage::Cache::open):
(WebKit::CacheStorage::Cache::storeRecords):
(WebKit::CacheStorage::Cache::put):
(WebKit::CacheStorage::Cache::writeRecordToDisk):
(WebKit::CacheStorage::Cache::updateRecordToDisk):
(WebKit::CacheStorage::Cache::removeRecordFromDisk):
(WebKit::CacheStorage::Cache::encode):
(WebKit::CacheStorage::Cache::decodeRecordHeader):
(WebKit::CacheStorage::Cache::decode):
- NetworkProcess/cache/CacheStorageEngineCache.h:
- NetworkProcess/cache/CacheStorageEngineCaches.cpp:
(WebKit::CacheStorage::Caches::Caches):
(WebKit::CacheStorage::Caches::initialize):
(WebKit::CacheStorage::Caches::initializeSize):
(WebKit::CacheStorage::Caches::requestSpace):
(WebKit::CacheStorage::Caches::writeRecord):
(WebKit::CacheStorage::Caches::removeRecord):
(WebKit::CacheStorage::Caches::removeCacheEntry):
- NetworkProcess/cache/CacheStorageEngineCaches.h:
(WebKit::CacheStorage::Caches::create):
(WebKit::CacheStorage::Caches::hasEnoughSpace const):
- NetworkProcess/cache/NetworkCacheStorage.cpp:
(WebKit::NetworkCache::Storage::traverse):
- NetworkProcess/cocoa/NetworkProcessCocoa.mm:
(WebKit::NetworkProcess::platformInitializeNetworkProcessCocoa):
- Shared/WebCoreArgumentCoders.cpp:
(IPC::ArgumentCoder<DOMCacheEngine::Record>::encode):
(IPC::ArgumentCoder<DOMCacheEngine::Record>::decode):
- UIProcess/API/APIProcessPoolConfiguration.cpp:
(API::ProcessPoolConfiguration::copy):
- UIProcess/API/APIProcessPoolConfiguration.h:
- UIProcess/WebProcessPool.cpp:
(WebKit::WebProcessPool::ensureNetworkProcess):
LayoutTests:
- http/wpt/cache-storage/cache-quota.https.any-expected.txt: Added.
- http/wpt/cache-storage/cache-quota.https.any.html: Added.
- http/wpt/cache-storage/cache-quota.https.any.js: Added.
- 2:57 PM Changeset in webkit [223072] by
-
- 5 edits in trunk/Source/WebCore
Remove redundant RenderObject::virtualContinuation
https://bugs.webkit.org/show_bug.cgi?id=178091
<rdar://problem/34892906>
Reviewed by Antti Koivisto.
virtualContinuation sounds like a feature of continuation, while it's just a (not super useful)helper override.
No change in functionality.
- rendering/RenderBlock.cpp:
(WebCore::canMergeContiguousAnonymousBlocks):
(WebCore::RenderBlock::takeChild):
- rendering/RenderBlock.h:
- rendering/RenderInline.h:
- rendering/RenderObject.h:
(WebCore::RenderObject::isBlockElementContinuation const):
(WebCore::RenderObject::virtualContinuation const): Deleted.
- 2:49 PM Changeset in webkit [223071] by
-
- 2 edits in trunk/LayoutTests
Unskipped http/tests/cache/disk-cache/disk-cache-validation-no-body.html
https://bugs.webkit.org/show_bug.cgi?id=178019
Unreviewed test gardening.
- platform/mac-wk2/TestExpectations:
- 2:17 PM Changeset in webkit [223070] by
-
- 2 edits in trunk/Source/WebKitLegacy
[Win] Link error: cannot open input file 'WebKitLegacyGUID.lib'
https://bugs.webkit.org/show_bug.cgi?id=178087
Reviewed by Alexey Proskuryakov.
For compatibility reasons, the library still has the name WebKitGUID.lib.
- PlatformWin.cmake:
- 2:17 PM Changeset in webkit [223069] by
-
- 21 edits4 deletes in trunk
Unreviewed, rolling out r223015 and r223025.
https://bugs.webkit.org/show_bug.cgi?id=178093
Regressed Kraken on iOS by 20% (Requested by keith_mi_ on
#webkit).
Reverted changesets:
"Enable gigacage on iOS"
https://bugs.webkit.org/show_bug.cgi?id=177586
http://trac.webkit.org/changeset/223015
"Unreviewed, disable Gigacage on ARM64 Linux"
https://bugs.webkit.org/show_bug.cgi?id=177586
http://trac.webkit.org/changeset/223025
- 1:57 PM Changeset in webkit [223068] by
-
- 2 edits in trunk/Source/WebInspectorUI
Unreviewed, minified WebInspector opens blank.
<rdar://problem/34892307>
- UserInterface/Views/ResourceHeadersContentView.js:
(WI.ResourceHeadersContentView.prototype._refreshRequestHeadersSection):
Regression introduced in r223006. The minified build has a SyntaxError
causing WebInspector top open blank. Add the missing semicolon.
- 1:46 PM Changeset in webkit [223067] by
-
- 2 edits in trunk/JSTests
Update expectations for test262 tests that pass after r223043.
https://bugs.webkit.org/show_bug.cgi?id=176685
Unreviewed test gardening.
- test262.yaml:
- 1:45 PM Changeset in webkit [223066] by
-
- 2 edits in trunk/Source/JavaScriptCore
Unreviewed, sort unified sources again now that they are numbered numerically rather than lexicographically.
- JavaScriptCore.xcodeproj/project.pbxproj:
- 1:38 PM Changeset in webkit [223065] by
-
- 10 edits2 adds in trunk/Source/WebInspectorUI
Web Inspector: Network Tab - Filter resources based on URL / Text Content
https://bugs.webkit.org/show_bug.cgi?id=178071
<rdar://problem/34071562>
Reviewed by Brian Burg.
- Localizations/en.lproj/localizedStrings.js:
New strings.
- UserInterface/Views/FilterBar.css:
(.filter-bar.active > input[type="search"]::-webkit-search-decoration):
(.filter-bar.indicating-progress > input[type="search"]::-webkit-search-decoration):
New icon for progress / active states.
- UserInterface/Views/FilterBar.js:
(WI.FilterBar.prototype.get inputField):
(WI.FilterBar.prototype.get placeholder):
(WI.FilterBar.prototype.set placeholder):
(WI.FilterBar.prototype.get incremental):
(WI.FilterBar.prototype.set incremental):
(WI.FilterBar.prototype.get indicatingProgress):
(WI.FilterBar.prototype.set indicatingProgress):
(WI.FilterBar.prototype.get indicatingActive):
(WI.FilterBar.prototype.set indicatingActive):
(WI.FilterBar.prototype._handleFilterInputEvent):
When incremental is set to false on the FilterBar still dispatch an
event when the textfield clears.
- UserInterface/Images/FilterFieldActiveGlyph.svg: Added.
- UserInterface/Images/gtk/FilterFieldActiveGlyph.svg: Added.
New blue icon for active state.
- UserInterface/Controllers/FrameResourceManager.js:
(WI.FrameResourceManager.prototype.resourceForIdentifier):
Accessor for arbitrary resource.
- UserInterface/Views/NetworkTableContentView.css:
(.content-view.network .navigation-bar .filter-bar):
(.content-view.network .warning-banner):
(body[dir=ltr] .content-view.network .warning-banner):
(body[dir=rtl] .content-view.network .warning-banner):
(.content-view.network .warning-banner > a):
Warning banner when the filter produces no results. This matches the
warning in the Debugger tab when breakpoints are disabled.
- UserInterface/Views/ScopeBar.js:
(WI.ScopeBar.prototype.resetToDefault):
Provide a way to easily reset a scope bar to the default item.
- UserInterface/Views/RadioButtonNavigationItem.css:
(.navigation-bar .item.radio.button.text-only:active):
- UserInterface/Views/ScopeBar.css:
(.scope-bar > li:active):
Cleanup some styles that should be using a variable.
- UserInterface/Views/NetworkTableContentView.js:
(WI.NetworkTableContentView):
(WI.NetworkTableContentView.prototype.get filterNavigationItems):
(WI.NetworkTableContentView.prototype.layout):
(WI.NetworkTableContentView.prototype._processPendingEntries):
(WI.NetworkTableContentView.prototype._checkTextFilterAgainstFinishedResource):
(WI.NetworkTableContentView.prototype._checkTextFilterAgainstFailedResource):
(WI.NetworkTableContentView.prototype._updateTextFilterActiveIndicator):
(WI.NetworkTableContentView.prototype._updateEmptyFilterResultsWarning):
(WI.NetworkTableContentView.prototype._showEmptyFilterResultsWarning):
(WI.NetworkTableContentView.prototype._hideEmptyFilterResultsWarning):
(WI.NetworkTableContentView.prototype._positionEmptyFilterMessage):
(WI.NetworkTableContentView.prototype._resourceLoadingDidFinish):
(WI.NetworkTableContentView.prototype._resourceLoadingDidFail):
(WI.NetworkTableContentView.prototype._networkTimelineRecordAdded):
(WI.NetworkTableContentView.prototype._insertResourceAndReloadTable):
(WI.NetworkTableContentView.prototype._hasTypeFilter):
(WI.NetworkTableContentView.prototype._hasTextFilter):
(WI.NetworkTableContentView.prototype._hasActiveFilter):
(WI.NetworkTableContentView.prototype._passTypeFilter):
(WI.NetworkTableContentView.prototype._passTextFilter):
(WI.NetworkTableContentView.prototype._passFilter):
(WI.NetworkTableContentView.prototype._updateFilteredEntries):
(WI.NetworkTableContentView.prototype._resetFilters):
(WI.NetworkTableContentView.prototype._textFilterDidChange):
(WI.NetworkTableContentView.prototype._tableNameColumnDidChangeWidth):
There are now two filters.
- FilterBar - Filters URL and Full Text Content
- ScopeBar - Filters Resource Type
The text content filter is asynchronous. We reuse the existing Search
functionality when filtering on text. We need to defer text content
filtering until the resource finishes loading.
- 1:23 PM Changeset in webkit [223064] by
-
- 2 edits17 adds in trunk/LayoutTests/imported/w3c
REGRESSION: Some bots fail to run LayoutTests due to a WPT Server error
https://bugs.webkit.org/show_bug.cgi?id=178017
Patch by Youenn Fablet <youenn@apple.com> on 2017-10-09
Reviewed by Sam Weinig.
- resources/import-expectations.json:
- web-platform-tests/tools/six/: Added.
- 1:16 PM Changeset in webkit [223063] by
-
- 2 edits in trunk/Source/WebCore
[WebGL] Third IOSurface buffer might be allocated with the wrong size
https://bugs.webkit.org/show_bug.cgi?id=178092
<rdar://problem/34893173>
Reviewed by Jer Noble.
If the WebGL canvas resizes after the third buffer was allocated, it
was never getting told that its backing store should be thrown away.
- platform/graphics/cocoa/WebGLLayer.mm: Allocate the third buffer at
the same time as the first two.
(-[WebGLLayer allocateIOSurfaceBackingStoreWithSize:usingAlpha:]):
(-[WebGLLayer bindFramebufferToNextAvailableSurface]):
- 1:02 PM Changeset in webkit [223062] by
-
- 6 edits5 deletes in trunk
Unreviewed, rolling out r223022.
This change introduced 18 test262 failures.
Reverted changeset:
"
asyncshould be able to be used as an imported binding
name"
https://bugs.webkit.org/show_bug.cgi?id=176573
http://trac.webkit.org/changeset/223022
- 1:01 PM Changeset in webkit [223061] by
-
- 10 edits in trunk
Make HashMap::keys() and HashMap::values() work with WTF::map/WTF::copyToVector
https://bugs.webkit.org/show_bug.cgi?id=178072
Patch by Sam Weinig <sam@webkit.org> on 2017-10-09
Reviewed by Darin Adler.
Source/WebCore:
- platform/graphics/avfoundation/MediaSelectionGroupAVFObjC.h:
(WebCore::MediaSelectionGroupAVFObjC::options):
Update for type change for HashMap::values().
Source/WebKit:
- Shared/AsyncRequest.h:
(WebKit::AsyncRequestMap::values):
- UIProcess/WebProcessProxy.h:
(WebKit::WebProcessProxy::pages const):
Update for type change for HashMap::values().
Source/WTF:
Introduce SizedIteratorRange, a variant of IteratorRange that includes
a reference to a backing container in order to get the size of container.
This is useful for algorithms like WTF::map and WTF::copyToVector, that
can use the size to efficiently allocate things of the correct size.
The main beneficiary are HashMap's keys() and values() functions which
used to return IteratorRanges and now return SizedIteratorRange. This
allows us to remove (in a future change) copyKeysToVector() and
copyValuesToVector() by replacing them with copyToVector(map.keys()) and
copyToVector(map.values()) respectively.
- wtf/HashMap.h:
- wtf/IteratorRange.h:
(WTF::SizedIteratorRange::SizedIteratorRange):
(WTF::SizedIteratorRange::size const):
(WTF::SizedIteratorRange::begin const):
(WTF::SizedIteratorRange::end const):
(WTF::makeSizedIteratorRange):
Tools:
- TestWebKitAPI/Tests/WTF/Vector.cpp:
(TestWebKitAPI::TEST):
Add tests for HashMap::keys() and HashMap::values() working with copyToVector.
- 12:55 PM Changeset in webkit [223060] by
-
- 2 edits14 adds in trunk/LayoutTests/imported/w3c
Import WPT imagebitmap-renderingcontext
https://bugs.webkit.org/show_bug.cgi?id=177963
Reviewed by Sam Weinig.
- resources/import-expectations.json:
- web-platform-tests/imagebitmap-renderingcontext/bitmaprenderer-as-imagesource-expected.txt: Added.
- web-platform-tests/imagebitmap-renderingcontext/bitmaprenderer-as-imagesource.html: Added.
- web-platform-tests/imagebitmap-renderingcontext/context-creation-expected.txt: Added.
- web-platform-tests/imagebitmap-renderingcontext/context-creation-with-alpha-expected.txt: Added.
- web-platform-tests/imagebitmap-renderingcontext/context-creation-with-alpha.html: Added.
- web-platform-tests/imagebitmap-renderingcontext/context-creation.html: Added.
- web-platform-tests/imagebitmap-renderingcontext/context-preserves-canvas-expected.txt: Added.
- web-platform-tests/imagebitmap-renderingcontext/context-preserves-canvas.html: Added.
- web-platform-tests/imagebitmap-renderingcontext/tranferFromImageBitmap-null-expected.txt: Added.
- web-platform-tests/imagebitmap-renderingcontext/tranferFromImageBitmap-null.html: Added.
- web-platform-tests/imagebitmap-renderingcontext/transferFromImageBitmap-detached-expected.txt: Added.
- web-platform-tests/imagebitmap-renderingcontext/transferFromImageBitmap-detached.html: Added.
- web-platform-tests/imagebitmap-renderingcontext/w3c-import.log: Added.
- 12:32 PM Changeset in webkit [223059] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: Network Tab: Row wrapping (waterfall displaying behind next row's name)
https://bugs.webkit.org/show_bug.cgi?id=178015
<rdar://problem/34858720>
Reviewed by Brian Burg.
- UserInterface/Views/Table.css:
(.table > .header):
(.table > .data-container > .data-list > li):
Disallow wrapping.
- 12:32 PM Changeset in webkit [223058] by
-
- 12 edits1 copy4 adds in trunk
Web Inspector: Network Tab - Cookies Detail View
https://bugs.webkit.org/show_bug.cgi?id=177988
<rdar://problem/34071927>
Reviewed by Brian Burg.
Source/WebInspectorUI:
- Localizations/en.lproj/localizedStrings.js:
- UserInterface/Main.html:
- UserInterface/Test.html:
New strings and resources.
- UserInterface/Models/Cookie.js: Added.
(WI.Cookie):
(WI.Cookie.parseCookieRequestHeader):
(WI.Cookie.parseSetCookieResponseHeader):
Encapsulation for Cookie attributes.
- UserInterface/Models/Resource.js:
(WI.Resource.prototype.get requestCookies):
(WI.Resource.prototype.get responseCookies):
(WI.Resource.prototype.updateForRedirectResponse):
(WI.Resource.prototype.updateForResponse):
(WI.Resource.prototype.updateWithMetrics):
New computed accessors for requestCookies and responseCookies.
- UserInterface/Views/NetworkResourceDetailView.js:
(WI.NetworkResourceDetailView.prototype._showContentViewForNavigationItem):
Show the new Cookie View.
- UserInterface/Views/NetworkTableContentView.css:
(.content-view.network .network-table .icon):
(.network-table li:not(.filler) .cell.name):
(.network-table .cache-type):
(.network-table .error):
(body[dir=ltr] .network-table .cell.name > .status):
(body[dir=rtl] .network-table .cell.name > .status):
(.network-table .cell.name > .status .indeterminate-progress-spinner):
(.showing-detail .network-table .cell:not(.name)):
(.showing-detail .network-table .resizer:not(:first-of-type)):
(.network-table :not(.header) .cell:first-of-type):
Rework these styles to be specific to the .network-table.
- UserInterface/Views/Table.css:
(.table :not(.header) .cell:first-of-type): Deleted.
Move this to the network table styles, it shouldn't apply to all tables.
- UserInterface/Views/ResourceCookiesContentView.css:
(.resource-cookies > section > .details.has-table):
(.resource-cookies .table):
(.resource-cookies .table > .header):
Styles for Cookies view and table.
- UserInterface/Views/ResourceCookiesContentView.js: Added.
(WI.ResourceCookiesContentView):
(WI.ResourceCookiesContentView.prototype.tableNumberOfRows):
(WI.ResourceCookiesContentView.prototype.tableSortChanged):
(WI.ResourceCookiesContentView.prototype.tablePopulateCell):
(WI.ResourceCookiesContentView.prototype.initialLayout):
(WI.ResourceCookiesContentView.prototype._incompleteSectionWithMessage):
(WI.ResourceCookiesContentView.prototype._incompleteSectionWithLoadingIndicator):
(WI.ResourceCookiesContentView.prototype._dataSourceForTable):
(WI.ResourceCookiesContentView.prototype._generateSortComparator):
(WI.ResourceCookiesContentView.prototype._refreshRequestCookiesSection):
(WI.ResourceCookiesContentView.prototype._refreshResponseCookiesSection):
(WI.ResourceCookiesContentView.prototype._sizeForTable):
(WI.ResourceCookiesContentView.prototype._resourceRequestHeadersDidChange):
(WI.ResourceCookiesContentView.prototype._resourceResponseReceived):
Tables for Request and Response cookies. They are simliar with slightly different columns.
Handle simple display and sorting for the tables.
- UserInterface/Views/ResourceHeadersContentView.js:
(WI.ResourceHeadersContentView.prototype._refreshResponseHeadersSection):
Break out Set-Cookie headers as multiple headers. THey should never be combined.
- UserInterface/Views/Table.js:
(WI.Table.prototype.showColumn):
(WI.Table.prototype.hideColumn):
(WI.Table.prototype._handleHeaderContextMenu):
- UserInterface/Views/TableColumn.js:
(WI.TableColumn.prototype.get hideable):
(WI.TableColumn.prototype.set hidden):
(WI.TableColumn):
(WI.TableColumn.prototype.setHidden): Deleted.
Make it so some columns can not be hidden. For example the "value" column
in the Cookie tables.
LayoutTests:
- inspector/unit-tests/cookie-expected.txt: Added.
- inspector/unit-tests/cookie.html: Added.
- 12:27 PM Changeset in webkit [223057] by
-
- 5 edits in trunk/Source/WebInspectorUI
Web Inspector: Network Tab - Search Headers Detail View
https://bugs.webkit.org/show_bug.cgi?id=177981
Reviewed by Brian Burg.
- UserInterface/Base/Main.js:
- UserInterface/Views/LogContentView.js:
(WI.LogContentView.prototype.performSearch):
Rename "Dom" to "DOM" in utility function.
- UserInterface/Views/ResourceHeadersContentView.css:
(.resource-headers.showing-find-banner .search-highlight):
Search highlight styles.
- UserInterface/Views/ResourceHeadersContentView.js:
(WI.ResourceHeadersContentView.prototype.get supportsSearch):
(WI.ResourceHeadersContentView.prototype.get numberOfSearchResults):
(WI.ResourceHeadersContentView.prototype.get hasPerformedSearch):
(WI.ResourceHeadersContentView.prototype.set automaticallyRevealFirstSearchResult):
(WI.ResourceHeadersContentView.prototype.performSearch):
(WI.ResourceHeadersContentView.prototype.searchCleared):
(WI.ResourceHeadersContentView.prototype.revealPreviousSearchResult):
(WI.ResourceHeadersContentView.prototype.revealNextSearchResult):
(WI.ResourceHeadersContentView.prototype._perfomSearchOnKeyValuePairs):
(WI.ResourceHeadersContentView.prototype._revealSearchResult):
Implement ContentView search behavior.
- 11:37 AM Changeset in webkit [223056] by
-
- 3 edits in trunk/JSTests
3 poly-proto JSC tests timing out on debug after r222827
https://bugs.webkit.org/show_bug.cgi?id=177880
<rdar://problem/34817122>
Unreviewed.
I'm skipping these type profiler tests on debug since they are long running.
- typeProfiler/deltablue-for-of.js:
- typeProfiler/getter-richards.js:
- 11:13 AM Changeset in webkit [223055] by
-
- 2 edits in trunk/LayoutTests
Marked inspector/dom/csp-big5-hash.html as flaky.
https://bugs.webkit.org/show_bug.cgi?id=177608
Unreviewed test garding.
- platform/mac/TestExpectations:
- 11:04 AM Changeset in webkit [223054] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed, another build fix attempt after r223031
The default constructor of DragTargetResponse is also invoked via initializer list in EventHandler.cpp, so we'll
need to explicitly declare this constructor in the header.
- page/EventHandler.h:
- 11:01 AM Changeset in webkit [223053] by
-
- 15 edits2 adds2 deletes in trunk
Unreviewed, rolling out r223021.
LayoutTests added with this change are failing.
Reverted changeset:
"[Payment Request] Implement PaymentRequest.show() and
PaymentRequest.hide()"
https://bugs.webkit.org/show_bug.cgi?id=178043
http://trac.webkit.org/changeset/223021
- 10:56 AM Changeset in webkit [223052] by
-
- 2 edits in trunk/Source/WebCore
Blurry captions on retina screens.
https://bugs.webkit.org/show_bug.cgi?id=177560
rdar://problem/17913388
Patch by Jeremy Jones <jeremyj@apple.com> on 2017-10-09
Reviewed by Jer Noble.
No new tests because the contents scale of the captions layer is not exposed to the DOM.
The captions layer contents scale needs to take into account the device screen scale to get the correct resolution for captions.
- html/shadow/MediaControlElements.cpp:
(WebCore::MediaControlTextTrackContainerElement::updateTextTrackRepresentation):
(WebCore::MediaControlTextTrackContainerElement::updateSizes):
- 10:54 AM Changeset in webkit [223051] by
-
- 2 edits in trunk/Source/WebKit
Incorrect fullscreen animation when element has a transform.
https://bugs.webkit.org/show_bug.cgi?id=177558
rdar://problem/29603741
Patch by Jeremy Jones <jeremyj@apple.com> on 2017-10-09
Reviewed by Jer Noble.
Use a bit of code from element fullscreen to do this correctly for video fullscreen.
The key is to get the absolute quad from the renderer. This will work for scaling,
But since we still take the bounding box, it won't work for rotations.
- WebProcess/cocoa/VideoFullscreenManager.mm:
(WebKit::inlineVideoFrame):
- 10:52 AM WebKitGTK/2.18.x edited by
- (diff)
- 10:27 AM Changeset in webkit [223050] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed, fix the Windows build after r223031
Speculative build fix; no change in behavior.
- page/EventHandler.h:
(WebCore::EventHandler::DragTargetResponse::DragTargetResponse):
- 10:24 AM Changeset in webkit [223049] by
-
- 2 edits in trunk/Source/WebCore
Reduce includes in Document.h
https://bugs.webkit.org/show_bug.cgi?id=178035
Reviewed by Darin Adler.
- dom/Document.h:
- 10:12 AM Changeset in webkit [223048] by
-
- 6 edits2 adds in trunk
AX: [ATK] Explicitly-set aria-sort value of "none" should be exposed as an object attribute
https://bugs.webkit.org/show_bug.cgi?id=177955
Reviewed by Chris Fleizach.
Source/WebCore:
Expose "none" as the value of aria-sort when the attribute is present and not
one of the other valid sort types. Also add a new AccessibilitySortDirection,
SortDirectionInvalid. This is currently only being used when the sort direction
is sought for a role which does not support this ARIA attribute, but might come
in handy if we want to add further sanity checks on the author-provided values.
Test: accessibility/gtk/aria-sort-values.html
- accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::sortDirection const):
- accessibility/AccessibilityObject.h:
- accessibility/atk/WebKitAccessibleWrapperAtk.cpp:
(webkitAccessibleGetAttributes):
- accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
(-[WebAccessibilityObjectWrapper additionalAccessibilityAttributeNames]):
LayoutTests:
- accessibility/gtk/aria-sort-values-expected.txt: Added.
- accessibility/gtk/aria-sort-values.html: Added.
- 9:49 AM Changeset in webkit [223047] by
-
- 50 edits in trunk/Source
Source/JavaScriptCore:
Make the names of the options consistent
https://bugs.webkit.org/show_bug.cgi?id=177933
Reviewed by Saam Barati.
I added an alias so the old spelling still works.
I also fixed a bunch of typos in comments all around the codebase.
- b3/B3LowerToAir.cpp:
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::parseBlock):
- dfg/DFGIntegerRangeOptimizationPhase.cpp:
- dfg/DFGOperations.h:
- dfg/DFGSSAConversionPhase.h:
- dfg/DFGSpeculativeJIT.h:
- ftl/FTLLowerDFGToB3.cpp:
(JSC::FTL::DFG::LowerDFGToB3::lower):
- ftl/FTLOSREntry.cpp:
(JSC::FTL::prepareOSREntry):
- jit/CallFrameShuffler.cpp:
(JSC::CallFrameShuffler::prepareForTailCall):
- parser/Nodes.h:
- parser/Parser.cpp:
(JSC::Parser<LexerType>::parseExportDeclaration):
- runtime/Options.h:
Source/WebCore:
Make the names of the options consistent
https://bugs.webkit.org/show_bug.cgi?id=177933
Reviewed by Saam Barati.
No functional change, just fixing comments.
- Modules/mediasource/MediaSource.cpp:
(WebCore::MediaSource::buffered const):
(WebCore::MediaSource::monitorSourceBuffers):
- Modules/webaudio/AudioBufferSourceNode.cpp:
(WebCore::AudioBufferSourceNode::process):
- bindings/scripts/generate-bindings.pl:
- css/StyleResolver.cpp:
(WebCore::StyleResolver::adjustRenderStyle):
- editing/BreakBlockquoteCommand.cpp:
(WebCore::BreakBlockquoteCommand::doApply):
- editing/ReplaceSelectionCommand.cpp:
(WebCore::ReplaceSelectionCommand::doApply):
- editing/VisibleSelection.cpp:
(WebCore::VisibleSelection::setStartAndEndFromBaseAndExtentRespectingGranularity):
- editing/VisibleUnits.cpp:
(WebCore::closestWordBoundaryForPosition):
- html/parser/AtomicHTMLToken.h:
- html/parser/HTMLDocumentParser.cpp:
(WebCore::HTMLDocumentParser::end):
- inspector/InspectorOverlayPage.js:
(reset):
- page/ViewportConfiguration.cpp:
(WebCore::ViewportConfiguration::layoutWidth const):
(WebCore::ViewportConfiguration::layoutHeight const):
- platform/graphics/FloatPolygon.h:
- platform/graphics/avfoundation/InbandTextTrackPrivateAVF.cpp:
(WebCore::InbandTextTrackPrivateAVF::processCueAttributes):
- platform/graphics/filters/FilterOperation.h:
- platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:
(WebCore::GraphicsContext3D::texImage2D):
- platform/mac/WidgetMac.mm:
(WebCore::safeRemoveFromSuperview):
- rendering/RenderBlockFlow.cpp:
(WebCore::RenderBlockFlow::collapseMarginsWithChildInfo):
- rendering/RenderBlockFlow.h:
- rendering/RenderBox.cpp:
(WebCore::RenderBox::computePositionedLogicalWidthReplaced const):
- rendering/RenderObject.cpp:
(WebCore::RenderObject::propagateRepaintToParentWithOutlineAutoIfNeeded const):
- rendering/RenderTheme.cpp:
(WebCore::RenderTheme::disabledTextColor const):
- style/ClassChangeInvalidation.cpp:
(WebCore::Style::computeClassChange):
- style/StyleScope.cpp:
(WebCore::Style::Scope::didChangeStyleSheetEnvironment):
- svg/SVGAltGlyphDefElement.cpp:
(WebCore::SVGAltGlyphDefElement::hasValidGlyphElements const):
Source/WebKit:
Make the names of the options consistent
https://bugs.webkit.org/show_bug.cgi?id=177933
Reviewed by Saam Barati.
- NetworkProcess/capture/json.hpp:
- Platform/IPC/Connection.cpp:
(IPC::Connection::connectionDidClose):
- UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _keyboardWillHide:]):
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::runModal):
- UIProcess/mac/WebInspectorProxyMac.mm:
(WebKit::WebInspectorProxy::inspectedViewFrameDidChange):
- WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::selectWithGesture):
Source/WebKitLegacy/mac:
Make the names of the options consistent
https://bugs.webkit.org/show_bug.cgi?id=177933
Reviewed by Saam Barati.
- WebView/WebFrame.h:
- WebView/WebHTMLView.mm:
(-[WebHTMLView setMarkedText:selectedRange:]):
- WebView/WebView.h:
- 9:37 AM Changeset in webkit [223046] by
-
- 2 edits in trunk/LayoutTests
Mark media/media-source/media-source-paint-to-canvas.html as failing.
https://bugs.webkit.org/show_bug.cgi?id=178083
Unreviewed test gardening.
- platform/mac/TestExpectations:
- 9:04 AM Changeset in webkit [223045] by
-
- 6 edits in trunk
[WPE][GTK] Propagate libepoxy compiler flags obtained from pkg-config
https://bugs.webkit.org/show_bug.cgi?id=178081
Reviewed by Carlos Alberto Lopez Perez.
.:
- Source/cmake/FindLibEpoxy.cmake: Define the ${LIBEPOXY_DEFINITIONS} variable when libepoxy
is found by pkg-config. This contains the value of the "Cflags" field from "epoxy.pc".
Source/WebCore:
No new tests needed.
- CMakeLists.txt: Use ${LIBEPOXY_DEFINITIONS} for building WebCore.
Source/WebKit:
- CMakeLists.txt: Use ${LIBEPOXY_DEFINITIONS} for building WebKit.
- 5:53 AM Changeset in webkit [223044] by
-
- 3 edits in trunk/Source/WebCore
[Readable Streams API] Implement canCloseOrEnqueue
https://bugs.webkit.org/show_bug.cgi?id=178005
Reviewed by Youenn Fablet.
Implemented readableStreamDefaultControllerCanCloseOrEnqueue [1]. This is
just a refactoring (based on spec) aiming at factorizing a set of tests
that are done at multiple places.
[1] https://streams.spec.whatwg.org/#readable-stream-default-controller-can-close-or-enqueue
No new tests (refactoring, no new behavior).
- Modules/streams/ReadableStreamDefaultController.js:
(enqueue): Updated.
(close): Updated.
- Modules/streams/ReadableStreamInternals.js:
(readableStreamDefaultControllerClose): Updated.
(readableStreamDefaultControllerCanCloseOrEnqueue): Added.
- 5:48 AM WebKitGTK/2.18.x edited by
- (diff)
- 5:46 AM WebKitGTK/2.16.x edited by
- (diff)
- 2:59 AM Changeset in webkit [223043] by
-
- 5 edits in trunk
Safari 10 /11 problem with if (!await get(something)).
https://bugs.webkit.org/show_bug.cgi?id=176685
Reviewed by Saam Barati.
JSTests:
- stress/async-await-basic.js:
(awaitEpression.async):
- stress/async-await-syntax.js:
(testTopLevelAsyncAwaitSyntaxSloppyMode.testSyntax):
(prototype.testTopLevelAsyncAwaitSyntaxStrictMode):
Source/JavaScriptCore:
Using unary operator before
awaitlead to count it as identifier.
According to spec https://tc39.github.io/ecma262/#sec-async-function-definitions
and Note 1awaitis as AwaitExpression and it is allowed to use unary operator
- parser/Parser.cpp:
(JSC::Parser<LexerType>::parsePrimaryExpression):
- 2:08 AM Changeset in webkit [223042] by
-
- 9 edits1 add1 delete in trunk
Remove WOFF2 from Source/ThirdParty.
https://bugs.webkit.org/show_bug.cgi?id=177862
Patch by Frederic Wang <fwang@igalia.com> on 2017-10-05
Reviewed by Michael Catanzaro.
.:
- Source/CMakeLists.txt: Do not build the woff2 source.
- Source/cmake/FindWOFF2Dec.cmake: Added. New cmake module for woff2.
- Source/cmake/OptionsGTK.cmake: Load the woff2 package.
Source/ThirdParty:
- woff2/CMakeLists.txt: Removed.
- woff2/LICENSE: Removed.
- woff2/README.webkit: Removed.
- woff2/include/woff2/decode.h: Removed.
- woff2/include/woff2/encode.h: Removed.
- woff2/include/woff2/output.h: Removed.
- woff2/src/buffer.h: Removed.
- woff2/src/convert_woff2ttf_*.cc: Removed.
- woff2/src/file.h: Removed.
- woff2/src/font.cc: Removed.
- woff2/src/font.h: Removed.
- woff2/src/glyph.cc: Removed.
- woff2/src/glyph.h: Removed.
- woff2/src/normalize.cc: Removed.
- woff2/src/normalize.h: Removed.
- woff2/src/port.h: Removed.
- woff2/src/round.h: Removed.
- woff2/src/store_bytes.h: Removed.
- woff2/src/table_tags.cc: Removed.
- woff2/src/table_tags.h: Removed.
- woff2/src/transform.cc: Removed.
- woff2/src/transform.h: Removed.
- woff2/src/variable_length.cc: Removed.
- woff2/src/variable_length.h: Removed.
- woff2/src/woff2_common.cc: Removed.
- woff2/src/woff2_common.h: Removed.
- woff2/src/woff2_compress.cc: Removed.
- woff2/src/woff2_dec.cc: Removed.
- woff2/src/woff2_decompress.cc: Removed.
- woff2/src/woff2_enc.cc: Removed.
- woff2/src/woff2_info.cc: Removed.
- woff2/src/woff2_out.cc: Removed.
- woff2/update.sh: Removed.
Source/WebCore:
No new tests, already covered by existing tests.
- CMakeLists.txt: Use the system brotli/woff2 headers/libraries.
Tools:
- Scripts/webkitpy/style/checker.py: Remove woff2.
- gtk/jhbuild.modules: Add new jhbuild module for woff2.
Oct 8, 2017:
- 9:08 PM Changeset in webkit [223041] by
-
- 4 edits in trunk
It should be possible to create a ListHashSet with a std::initializer_list.
https://bugs.webkit.org/show_bug.cgi?id=178070
Patch by Sam Weinig <sam@webkit.org> on 2017-10-08
Reviewed by Darin Adler.
Source/WTF:
- wtf/ListHashSet.h:
(WTF::U>::ListHashSet):
Add a constructor that takes a std::initializer_list.
Tools:
- TestWebKitAPI/Tests/WTF/ListHashSet.cpp:
(TestWebKitAPI::TEST):
Add a test for using std::initializer_list with ListHashSet.
- 8:43 PM Changeset in webkit [223040] by
-
- 2 edits in trunk/Source/WTF
Address additional feedback from Darin for r223039 and sort the using declarations.
- wtf/Vector.h:
- 8:08 PM Changeset in webkit [223039] by
-
- 4 edits in trunk
There should be a version of copyToVector that returns a Vector, rather than using an out parameter
https://bugs.webkit.org/show_bug.cgi?id=177732
Patch by Sam Weinig <sam@webkit.org> on 2017-10-08
Reviewed by Saam Barati.
Source/WTF:
Add two new helper functions, copyToVector and copyToVectorOf, which will be able to
replace the existing out parameter taking copyToVector. Like it's ancestral namesake,
copyToVector takes an object that is both iterable (supports begin() and end()) and
has a size, and returns a Vector with a copy of all the items iterated. The copyToVectorOf
variant allow the user to specify a type to convert to, so if you have a HashSet<int>
but want those as floats in a Vector, you can do:
auto floatVector = copyToVectorOf<float>(intSet);
- wtf/Vector.h:
(WTF::copyToVector):
(WTF::copyToVectorOf):
Tools:
- TestWebKitAPI/Tests/WTF/Vector.cpp:
(TestWebKitAPI::TEST):
Add tests for the new copyToVector and copyToVectorOf functions.
- 6:10 PM Changeset in webkit [223038] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: add autocompletion for min/max within a CSS calc
https://bugs.webkit.org/show_bug.cgi?id=178068
Reviewed by Joseph Pecoraro.
- UserInterface/Models/CSSKeywordCompletions.js:
(WI.CSSKeywordCompletions.forFunction):
- 5:44 PM Changeset in webkit [223037] by
-
- 3 edits in trunk/JSTests
Unreviewed. Make some type profiler tests run for less time to avoid debug timeouts.
- typeProfiler/deltablue-for-of.js:
- typeProfiler/getter-richards.js:
- 5:11 PM Changeset in webkit [223036] by
-
- 10 edits in trunk
Update HTMLOListElement.start to behavior from latest HTML specification
https://bugs.webkit.org/show_bug.cgi?id=178057
Reviewed by Chris Dumez.
LayoutTests/imported/w3c:
- web-platform-tests/html/semantics/grouping-content/the-ol-element/grouping-ol-expected.txt:
- web-platform-tests/html/semantics/grouping-content/the-ol-element/ol.start-reflection-2-expected.txt:
Updated to expect more tests to pass.
Source/WebCore:
- html/HTMLOListElement.cpp:
(optionalValue): Added. Helper function that we can put into Expected.h later
if we like; makes it easier to turn Expected into std::optional.
(WebCore::HTMLOListElement::HTMLOListElement): Moved data member initialization
into class definition so it doesn't have to be done here.
(WebCore::HTMLOListElement::parseAttribute): Simplified using the new
optionalValue function. Moved the call to update values in here since it's
a trivial one-liner (albeit done twice).
(WebCore::HTMLOListElement::updateItemValues): Deleted. Moved this into the
parseAttribute function.
(WebCore::HTMLOListElement::itemCount): Updated to use std::optional instead
of a separate m_shouldRecalculateItemCount flag. Also inlined the
recalculateItemCount function since it's a trivial one-liner.
(WebCore::HTMLOListElement::itemCountAfterLayout): Deleted. The only use of
this was to implement the now-obsolete behavior of the start attribute.
(WebCore::HTMLOListElement::recalculateItemCount): Deleted. Moved this into
the itemCount function.
- html/HTMLOListElement.h: Changed startForBindings to return 1 when start
is not specified; this what the HTML specification now calls for. Updated
for the changes above. Merged m_itemCount and m_shouldRecalculateItemCount
into a single optional m_itemCount, and made it mutable so it can be
computed as a side effect of calling the const member function start.
LayoutTests:
- fast/lists/ol-reversed-simple-expected.txt:
- fast/lists/ol-reversed-simple.html:
- fast/lists/ol-reversed-simple.xhtml:
Updated test and results to expect the new behavior.
- 3:17 PM Changeset in webkit [223035] by
-
- 18 edits in trunk
Fix bugs related to setting reflected floating point DOM attributes
https://bugs.webkit.org/show_bug.cgi?id=178061
Reviewed by Sam Weinig.
LayoutTests/imported/w3c:
- web-platform-tests/html/dom/reflection-forms-expected.txt:
Updated to expect meter reflection tests to pass.
Source/WebCore:
- html/HTMLProgressElement.cpp:
(WebCore::HTMLProgressElement::setValue): Changed the semantics to match what
the HTML specification calls for. When a caller passes a negative number or
zero, the value does get set on the element. Negative numbers are not allowed
when you get the current value, but are allowed to be set.
(WebCore::HTMLProgressElement::setMax): Changed the semantics to match what
the HTML specification calls for. When a caller passes a negative number or
zero, this should leave the attribute unchanged.
- html/shadow/MediaControlElementTypes.cpp:
(WebCore::MediaControlVolumeSliderElement::setVolume): Use
String::numberToStringECMAScript instead of String::number since that is what
we want any time we are setting an attribute value from a floating point value.
- html/shadow/MediaControlElements.cpp:
(WebCore::MediaControlTimelineElement::setPosition): Ditto.
(WebCore::MediaControlTimelineElement::setDuration): Removed unneeded check
of std::isfinite since the single caller already checks that.
Source/WTF:
- wtf/dtoa.cpp:
(WTF::formatStringTruncatingTrailingZerosIfNeeded): Fix a bug where
this function would remove trailing zeroes from the exponent if
present instead of from the mantissa. This meant that it would
format 1e10 as "1.00000e+1" instead of "1e+10". Added regression
tests for this to TestWebKitAPI.
- wtf/dtoa/utils.h:
(WTF::double_conversion::StringBuilder::RemoveCharacters): Added.
Used by the fix above.
- wtf/text/AtomicString.cpp:
(WTF::AtomicString::number): Note: This function is used by code
that sets the values of reflected floating point DOM attributes.
Changed the function to use the rules from numberToString rather
ones from numberToFixedPrecisionString. This is analogous to
String::numberToStringECMAScript, and in the future we should change
String and StringBuilder so this "ECMAScript" semantic is the default
way to convert a floating point number to a string, and rename the fixed
precision version that is currently called String::number. I audited
the small number of sites calling AtomicString::number, by temporarily
renaming it, and discovered that this is the correct behavior for all;
none needed fixed precision. Also, fixed a mistake where this explicitly
converted to String. That was defeating the purpose of having these
functions in AtomicString: It would allocate a new String and then
destroy it in the case where an equal string was already in the
AtomicString table.
Tools:
- TestWebKitAPI/Tests/WTF/AtomicString.cpp: Added a test of the
AtomicString::number function, based on the test cases we already
had for String::numberToStringECMAScript, and with some additional
cases with powers of 10 that check handling of trailng zeroes.
- TestWebKitAPI/Tests/WTF/WTFString.cpp: Added test cases to the
existing tests of the String::numberToStringECMAScript function
as above. Also added tests for String::number and for
String::numberToStringFixedWidth. Also changed the tests to all use
EXPECT instead of ASSERT macros since these are all non-fatal.
- WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
(WTR::dumpFrameScrollPosition): Use StringBuilder::appendECMAScriptNumber
instead of String::number.
LayoutTests:
- fast/dom/HTMLProgressElement/set-progress-properties-expected.txt: Updated test to expect
setting HTMLProgressElement.max to 0 to have no effect, rather than setting max to "1".
- fast/dom/HTMLProgressElement/set-progress-properties.html: Ditto.
- platform/ios-wk2/imported/w3c/web-platform-tests/html/dom/reflection-forms-expected.txt:
Updated to expect meter reflection tests to pass.
- 2:58 PM Changeset in webkit [223034] by
-
- 11 edits4 adds in trunk
DataTransfer.items does not contain items for custom types supplied via add or setData
https://bugs.webkit.org/show_bug.cgi?id=178016
Reviewed by Darin Adler.
Source/WebCore:
Minor tweaks to expose pasteboard types and data through DataTransfer's item list. This patch fixes two primary
issues: (1) custom pasteboard data is not exposed through the item list in any way, and (2) the "Files"
compatibility type is exposed as a separate data transfer item of kind 'string' when dropping or pasting files.
Tests: editing/pasteboard/data-transfer-items-add-custom-data.html
editing/pasteboard/data-transfer-items-drop-file.html
- dom/DataTransfer.cpp:
(WebCore::normalizeType):
Use stripLeadingAndTrailingHTMLSpaces instead of stripWhitespace.
(WebCore::shouldReadOrWriteTypeAsCustomData):
(WebCore::DataTransfer::getDataForItem const):
(WebCore::DataTransfer::getData const):
Add getDataForItem, a version of getData that does not normalize types before reading from the pasteboard. This
normalization step is only needed for backwards compatibility with legacy types (such as "text" and "url")
written to and read from using getData and setData; when using DataTransferItemList.add to set data, adding data
for these types should instead write as custom pasteboard data.
(WebCore::DataTransfer::setDataFromItemList):
(WebCore::DataTransfer::types const):
(WebCore::DataTransfer::typesForItemList const):
Add typesForItemList, which fetches the list of types to expose as items on the DataTransfer. Importantly, this
does not include the "Files" type added for compatibility when accessing DataTransfer.types, instead returning
an empty array. The actual files are added separately, by iterating over DataTransfer's files in ensureItems.
Note that when starting a drag or copying, we will still expose the full list of file and string types to
bindings and not just file-backed items. Since all of this information is supplied by the page in the first
place, we don't have to worry about exposing information, such as file paths, that may exist on the pasteboard.
- dom/DataTransfer.h:
- dom/DataTransferItem.cpp:
(WebCore::DataTransferItem::getAsString const):
- dom/DataTransferItemList.cpp:
(WebCore::shouldExposeTypeInItemList):
(WebCore::DataTransferItemList::add):
(WebCore::DataTransferItemList::ensureItems const):
(WebCore::isSupportedType): Deleted.
LayoutTests:
Adds new layout tests to check DataTransfer.items when dropping a file, and when copying and pasting with custom
pasteboard data types. Tweaks an existing test to adjust for normalizeType stripping HTML whitespace rather than
ASCII whitespace.
- TestExpectations:
- editing/pasteboard/data-transfer-get-data-non-normalized-types-expected.txt:
- editing/pasteboard/data-transfer-get-data-non-normalized-types.html:
- editing/pasteboard/data-transfer-items-add-custom-data-expected.txt: Added.
- editing/pasteboard/data-transfer-items-add-custom-data.html: Added.
- editing/pasteboard/data-transfer-items-drop-file-expected.txt: Added.
- editing/pasteboard/data-transfer-items-drop-file.html: Added.
- platform/ios-simulator-wk1/TestExpectations:
- platform/mac-wk1/TestExpectations:
- 1:30 PM Changeset in webkit [223033] by
-
- 2 edits in trunk/Tools
Make sort-Xcode-project file handle UnifiedSources
https://bugs.webkit.org/show_bug.cgi?id=178042
Reviewed by Sam Weinig.
Sort the UnifiedSource(\d+) files by number rather
than alphabetically.
- Scripts/sort-Xcode-project-file:
(sortChildrenByFileName):
(sortFilesByFileName):
- 10:18 AM Changeset in webkit [223032] by
-
- 7 edits in trunk
CustomElementRegistry.define was throwing a JavaScript syntax error instead of a DOM syntax error
https://bugs.webkit.org/show_bug.cgi?id=178055
Reviewed by Sam Weinig.
LayoutTests/imported/w3c:
- web-platform-tests/custom-elements/custom-element-registry/define-expected.txt:
Updated to expect more tests to pass.
Source/WebCore:
Both the JavaScript language and the DOM have "syntax error" exceptions, but
they are not the same thing.
Also, since the time a while back where we moved JavaScript error handling to
use WebCore::Exception and WebCore::ExceptionOr, there are a number of functions
that are no longer used and can be deleted.
- bindings/js/JSCustomElementRegistryCustom.cpp:
(WebCore::validateCustomElementNameAndThrowIfNeeded): Call throwDOMSyntaxError
instead of throwSyntaxError.
- bindings/js/JSDOMExceptionHandling.cpp:
(WebCore::reportDeprecatedGetterError): Deleted. Unused.
(WebCore::reportDeprecatedSetterError): Deleted. Unused.
(WebCore::throwNotSupportedError): Deleted the overload without an error message,
since it's unused. Changed the other overload to take an ASCIILiteral, since
that is what all the callers need.
(WebCore::throwInvalidStateError): Take ASCIILiteral as above.
(WebCore::throwArrayElementTypeError): Deleted. Unused.
(WebCore::throwDOMSyntaxError): Added an ASCIILiteral message argument. This
function was unused; it's now being used above, always with a literal message.
(WebCore::throwIndexSizeError): Deleted. Unused.
(WebCore::throwTypeMismatchError): Deleted. Unused.
- bindings/js/JSDOMExceptionHandling.h: Updated for the changes above.
- bindings/js/JSHTMLElementCustom.cpp:
(WebCore::constructJSHTMLElement): Fixed a typo in the error message.
- 3:08 AM Changeset in webkit [223031] by
-
- 10 edits2 adds in trunk
dragenter and dragleave shouldn't use the same data transfer object
https://bugs.webkit.org/show_bug.cgi?id=178056
Reviewed by Darin Adler.
Source/WebCore:
This patch fixes the bug that we were using a single DataTransfer to fire dragleave and dragenter events
when the drag target moves from one element to another.
It alos refactors DragController and EventHandler code so that the construction of DataTransfer object
happens in EventHandler instead of DragController, and extracts createForUpdatingDropTarget out of
createForDrop to have a better encapsulation over the data store mode.
drag related functions in EventHandler now takes std::unique_ptr<Pasteboard>&&, drag operation mask set
by the drag source, and a boolean indicating whether this drag & drop is for files or not. updateDragAndDrop
takes a closure which makes a pasteboard because it has to create two instances of DataTransfer one for
dragleave event and another one for dragenter event in some cases.
Test: editing/pasteboard/data-transfer-is-unique-for-dragenter-and-dragleave.html
- dom/DataTransfer.cpp:
(WebCore::DataTransfer::createForDrop): Now takes Pasteboard instead of DragData.
(WebCore::DataTransfer::createForUpdatingDropTarget): Extracted out of createForDrop. Moved the code to
use Readonly mode in dashboad here from createDataTransferToUpdateDrag in DragController.cpp.
- dom/DataTransfer.h:
- page/DragController.cpp:
(WebCore::createDataTransferToUpdateDrag): Deleted.
(WebCore::DragController::dragExited):
(WebCore::DragController::performDragOperation):
(WebCore::DragController::tryDHTMLDrag):
- page/EventHandler.cpp:
(WebCore::EventHandler::dispatchDragEvent): Made this fucntion take DataTransfer& instead of DataTransfer*.
(WebCore::findDropZone): Ditto.
(WebCore::EventHandler::dispatchDragEnterOrDragOverEvent): Added.
(WebCore::EventHandler::updateDragAndDrop):
(WebCore::EventHandler::cancelDragAndDrop):
(WebCore::EventHandler::performDragAndDrop):
(WebCore::EventHandler::dispatchDragSrcEvent):
(WebCore::EventHandler::dispatchDragStartEventOnSourceElement):
- page/EventHandler.h:
LayoutTests:
Added a regression test for checking the uniqueness of dataTransfer object for dragenter and dragleave events.
Unfortunately, the test is only runnable in Mac WebKit1 port due to the lack of support in WebKitTestRunner.
- TestExpectations:
- editing/pasteboard/data-transfer-is-unique-for-dragenter-and-dragleave-expected.txt: Added.
- editing/pasteboard/data-transfer-is-unique-for-dragenter-and-dragleave.html: Added.
- platform/mac-wk1/TestExpectations:
- 1:00 AM Changeset in webkit [223030] by
-
- 2 edits in trunk/Source/WebKit
mediaPlaybackRequiresUserAction API replacement annotation is wrong
https://bugs.webkit.org/show_bug.cgi?id=178063
Reviewed by Dan Bernstein.
- UIProcess/API/Cocoa/WKWebViewConfiguration.h:
mediaPlaybackRequiresUserAction suggests that you should use
requiresUserActionForMediaPlayback instead, but that is also deprecated.
Instead, follow the chain and suggest mediaTypesRequiringUserActionForPlayback.
- 12:52 AM Changeset in webkit [223029] by
-
- 5 edits1 copy1 add in trunk
SourceBuffer remove throws out way more content than requested
https://bugs.webkit.org/show_bug.cgi?id=177884
<rdar://problem/34817104>
Reviewed by Darin Adler.
Source/WebCore:
Test: media/media-source/media-source-remove-too-much.html
The end parameter is exclusive, not inclusive, of the range to be removed.
- Modules/mediasource/SourceBuffer.cpp:
(WebCore::SourceBuffer::removeCodedFrames):
LayoutTests:
- media/media-source/media-source-remove-decodeorder-crash-expected.txt:
- media/media-source/media-source-remove-decodeorder-crash.html:
- media/media-source/media-source-remove-too-much-expected.txt: Added.
- media/media-source/media-source-remove-too-much.html: Added.
- 12:47 AM Changeset in webkit [223028] by
-
- 3 edits2 adds in trunk
Nullptr deref in WebCore::Node::computeEditability
https://bugs.webkit.org/show_bug.cgi?id=177905
<rdar://problem/34138402>
Reviewed by Darin Adler.
Source/WebCore:
Script can run when setting focus, because a blur event and a focus event are generated.
A handler for one of these events can cause the focused element to be cleared. We should
handle this possibility gracefully.
Test: fast/dom/focus-shift-crash.html
- dom/Document.cpp:
(WebCore::Document::setFocusedElement):
LayoutTests:
- fast/dom/focus-shift-crash-expected.txt: Added.
- fast/dom/focus-shift-crash.html: Added.
