Timeline

Oct 10, 2017:

10:48 PM Changeset in webkit [223168] by calvaris@igalia.com

• 2 edits in trunk/Source/WebCore

[GStreamer] Fix double seek requested by downloadbuffer GStreamer element in webkibwebsrc
​https://bugs.webkit.org/show_bug.cgi?id=178079

Reviewed by Žan Doberšek.

When the downloadbuffer GStreamer element requests two seeks too
close to each other there's some rare race condition where our
source answers that it is not seekable and ends up with
downloadbuffer element to seek beyond the file size, which causes
the server to issue a 416 HTTP error code eventually, causing our
MediaPlayer to stop.

• platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:

(webKitWebSrcStop): We only unset he seekable attribute if we are
not seeking.

9:12 PM Changeset in webkit [223167] by rniwa@webkit.org

• 22 edits in trunk

Enable custom pasteboard data in DumpRenderTree and WebKitTestRunner
​https://bugs.webkit.org/show_bug.cgi?id=178154

Reviewed by Wenson Hsieh.

Source/WebCore:

Extracted the logic to compute the default enabled-ness of custom pasteboard data as
Settings::defaultCustomPasteboardDataEnabled() to be called by WebKit1 and WebKit2 layers.

• page/Settings.cpp:

(WebCore::Settings::defaultCustomPasteboardDataEnabled): Extracted from customPasteboardDataEnabled.
(WebCore::Settings::customPasteboardDataEnabled): Deleted. Now inlined in the header file.

• page/Settings.h:

(WebCore::Settings::customPasteboardDataEnabled):

• platform/cocoa/PasteboardCocoa.mm:

(WebCore::Pasteboard::read): Fixed a bug that we were adding MIME type to the map before checking that
we could actually read the buffer. We shouldn't skip a type (NSTIFFPboardType and kUTTypeTIFF for now)
if an equivalent type had failed to read.

Source/WebKit:

Plumbed customPasteboardDataEnabled flag to be used in WebKitTestRunner.

• Shared/WebPreferencesDefinitions.h:
• UIProcess/API/C/WKPreferences.cpp:

(WKPreferencesSetCustomPasteboardDataEnabled):
(WKPreferencesGetCustomPasteboardDataEnabled):

• UIProcess/API/C/WKPreferencesRefPrivate.h:
• WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::updatePreferences):

Source/WebKitLegacy/mac:

Enable custom pasteboard data by default.

• WebView/WebPreferenceKeysPrivate.h:
• WebView/WebPreferences.mm:

(+[WebPreferences initialize]):
(-[WebPreferences customPasteboardDataEnabled]): Added.
(-[WebPreferences setCustomPasteboardDataEnabled:]): Added.

• WebView/WebPreferencesPrivate.h:
• WebView/WebView.mm:

(-[WebView _preferencesChanged:]):

Tools:

Fixed the bug that LocalPasteboard would fail to load the promise type if data is set after declaring types
by delaying the call to provideDataForType until when dataForType is called.

Without this fix, fast/events/dropzone-002.html would start failing after enabling custom pasteboard data.
With this fix, fast/events/dropzone-005.html also starts passing.

• DumpRenderTree/mac/DumpRenderTree.mm:

(resetWebPreferencesToConsistentValues):

• DumpRenderTree/mac/DumpRenderTreePasteboard.mm:

(-[LocalPasteboard addTypes:owner:]):
(-[LocalPasteboard dataForType:]):

• WebKitTestRunner/TestController.cpp:

(WTR::TestController::resetPreferencesToConsistentValues):

LayoutTests:

• editing/pasteboard/dataTransfer-setData-getData-expected.txt: Rebaselined. One more test case is passing now.
• fast/events/dropzone-002.html: Fixed the test to accept an image since we no longer drop URLs when dropping

an image avoid leaking local file paths.

• platform/mac/TestExpectations: Enabled dropzone-005.html since it started passing after fixing LocalPasteboard.

8:49 PM Changeset in webkit [223166] by jmarcell@apple.com

• 2 edits in branches/safari-604-branch/LayoutTests

Cherry-pick r222450. rdar://problem/34920294

8:49 PM Changeset in webkit [223165] by jmarcell@apple.com

• 13 edits
  1 add in branches/safari-604-branch

Cherry-pick r223084. rdar://problem/34857469

8:16 PM Changeset in webkit [223164] by BJ Burg

• 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Quick Open: source mapped files are not shown as search results
​https://bugs.webkit.org/show_bug.cgi?id=178151
<rdar://problem/31561718>

Reviewed by Joseph Pecoraro.

• UserInterface/Views/OpenResourceDialog.js:

(WI.OpenResourceDialog.prototype._addResource):
Also consider matching the query string against SourceMapResources
attached to a resource's source maps.

7:57 PM Changeset in webkit [223163] by aestes@apple.com

• 15 edits in trunk

[Payment Request] Validate that all PaymentCurrencyAmounts use the same currency code when using Apple Pay
​https://bugs.webkit.org/show_bug.cgi?id=178150

Reviewed by Tim Horton.

Source/WebCore:

Apple Pay requires a single currency code, but the Payment Request API allows the client to
specify a currency code for each PaymentCurrencyAmount.

Instead of having a required currencyCode property on ApplePayRequest and ignoring the
currency property on PaymentCurrencyAmount, validate that all PaymentCurrencyAmounts use the
same currency code and use that as ApplePaySessionPaymentRequest's currencyCode.

Added test cases to http/tests/ssl/applepay/PaymentRequest.https.html.

• Modules/applepay/ApplePayPaymentRequest.h:
• Modules/applepay/ApplePayPaymentRequest.idl:
• Modules/applepay/ApplePayRequestBase.cpp:

(WebCore::convertAndValidate):

• Modules/applepay/ApplePayRequestBase.h:
• Modules/applepay/ApplePayRequestBase.idl:
• Modules/applepay/ApplePaySession.cpp:

(WebCore::convertAndValidate):

• Modules/applepay/paymentrequest/ApplePayPaymentHandler.cpp:

(WebCore::validate):
(WebCore::convertAndValidate):
(WebCore::ApplePayPaymentHandler::show):

• Modules/applepay/paymentrequest/ApplePayRequest.idl:

LayoutTests:

• http/tests/paymentrequest/payment-request-abort-method.https.html:
• http/tests/paymentrequest/payment-request-canmakepayment-method.https.html:
• http/tests/paymentrequest/payment-request-show-method.https.html:
• http/tests/ssl/applepay/PaymentRequest.https-expected.txt:
• http/tests/ssl/applepay/PaymentRequest.https.html:

6:01 PM Changeset in webkit [223162] by Adrian Perez de Castro

• 4 edits in trunk

[WPE] Remove the possibility of installing the old WebKit2 C API
​https://bugs.webkit.org/show_bug.cgi?id=178125

Reviewed by Michael Catanzaro.

.:

• Source/cmake/OptionsWPE.cmake: Remove definition of the EXPORT_DEPRECATED_WEBKIT2_C_API

build option.

Source/WebKit:

• PlatformWPE.cmake: Remove support for installing the deprecated C API.

5:53 PM Changeset in webkit [223161] by sbarati@apple.com

• 5 edits in trunk/Source/JavaScriptCore

Prototype structure transition should be a deferred transition
​https://bugs.webkit.org/show_bug.cgi?id=177734

Reviewed by Keith Miller.

Absence ObjectPropertyConditions work by verifying both that the Structure
does not have a particular property and that its prototype has
remained constant. However, the prototype transition was firing
the transition watchpoint before setting the object's structure.
This meant that isValid for Absence would never return false because
the prototype changed. Clearly this is wrong. The reason this didn't
break OPCs in general is that we'd also check if we could still watch
the OPC. In this case, we can't still watch it because we're inspecting
a structure with an invalidated transition watchpoint. To fix
this weird quirk of the code, I'm making it so that doing a prototype
transition uses the DeferredStructureTransitionWatchpointFire machinery.

This patch also fixes some dead code that I left in regarding
poly proto in OPC.

• bytecode/PropertyCondition.cpp:

(JSC::PropertyCondition::isStillValidAssumingImpurePropertyWatchpoint const):

• runtime/JSObject.cpp:

(JSC::JSObject::setPrototypeDirect):

• runtime/Structure.cpp:

(JSC::Structure::changePrototypeTransition):

• runtime/Structure.h:

5:37 PM Changeset in webkit [223160] by aestes@apple.com

• 16 edits
  2 adds
  1 delete in trunk

[Payment Request] Implement PaymentRequest.canMakePayment()
​https://bugs.webkit.org/show_bug.cgi?id=178048

Reviewed by Youenn Fablet.

LayoutTests/imported/w3c:

• web-platform-tests/payment-request/payment-request-canmakepayment-method.https-expected.txt: Removed.

Source/WebCore:

Test: http/tests/paymentrequest/payment-request-canmakepayment-method.https.html

• Modules/applepay/paymentrequest/ApplePayPaymentHandler.cpp:

(WebCore::ApplePayPaymentHandler::convertData): Moved
ApplePayRequest-to-ApplePaySessionPaymentRequest conversion from here to show().
(WebCore::ApplePayPaymentHandler::show): Returned an exception if
ApplePaySessionPaymentRequest conversion fails.
(WebCore::shouldDiscloseApplePayCapability): Checked if we are in an ephimeral session or if
Settings::applePayCapabilityDisclosureAllowed() is false.
(WebCore::ApplePayPaymentHandler::canMakePayment): Called
PaymentCoordinator::canMakePayments() or PaymentCoordinator::canMakePaymentsWithActiveCard()
depending on shouldDiscloseApplePayCapability().

• Modules/applepay/paymentrequest/ApplePayPaymentHandler.h:
• Modules/applepay/paymentrequest/ApplePayRequest.h:
• Modules/applepay/paymentrequest/ApplePayRequest.idl: Defined merchantIdentifier.
• Modules/paymentrequest/PaymentHandler.h:
• Modules/paymentrequest/PaymentRequest.cpp:

(WebCore::parse): Moved JSON-parsing to here from show().
(WebCore::PaymentRequest::show): Returned the exception from PaymentHandler::show().
(WebCore::PaymentRequest::canMakePayment): For each payment method, try to create a
PaymentHandler.
For the first valid PaymentHandler, call canMakePayment() and pass a lambda that resolves
the promise.

• Modules/paymentrequest/PaymentRequest.h:
• Modules/paymentrequest/PaymentRequest.idl: Added CallWith=Document annotations to show()

and canMakePayment().

LayoutTests:

• http/tests/paymentrequest/payment-request-canmakepayment-method.https-expected.txt: Added.
• http/tests/paymentrequest/payment-request-canmakepayment-method.https.html: Added.
• http/tests/ssl/applepay/PaymentRequest.https.html:
• platform/ios-wk2/TestExpectations:
• platform/mac-wk2/TestExpectations:

5:09 PM Changeset in webkit [223159] by rmorisset@apple.com

• 2 edits in trunk/Source/JavaScriptCore

Avoid allocating useless landingBlocks in DFGByteCodeParser::handleInlining()
​https://bugs.webkit.org/show_bug.cgi?id=177926

Reviewed by Saam Barati.

When doing polyvariant inlining, there used to be a landing block for each callee, each of which was then linked to a continuation block.
With this change, we allocate the continuation block first, and pass it to the inlining routine so that op_ret in the callee link directly to it.
The only subtlety is that when inlining an intrinsic we must do the jump by hand, and also remember to call processSetLocalQueue with nextOffset before it.

• dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::inlineCall):
(JSC::DFG::ByteCodeParser::attemptToInlineCall):
(JSC::DFG::ByteCodeParser::handleInlining):
(JSC::DFG::ByteCodeParser::InlineStackEntry::InlineStackEntry):
(JSC::DFG::ByteCodeParser::parse):

5:01 PM Changeset in webkit [223158] by Chris Dumez

• 10 edits in trunk/Source/WebKit

[WK2] Add API to clear service worker registrations
​https://bugs.webkit.org/show_bug.cgi?id=178085
<rdar://problem/34866025>

Reviewed by Ryosuke Niwa.

Add API to clear service worker registrations. Although the request to
clear the registration is passed on to the StorageProcess, it is currently
a no-op on StorageProcess side until we actually persist service worker
registrations on disk.

• Shared/WebsiteData/WebsiteDataType.h:
• StorageProcess/StorageProcess.cpp:

(WebKit::StorageProcess::fetchWebsiteData):
(WebKit::StorageProcess::deleteWebsiteData):
(WebKit::StorageProcess::deleteWebsiteDataForOrigins):

• UIProcess/API/C/WKWebsiteDataStoreRef.cpp:

(WKWebsiteDataStoreRemoveAllServiceWorkerRegistrations):

• UIProcess/API/C/WKWebsiteDataStoreRef.h:
• UIProcess/API/Cocoa/WKWebsiteDataRecord.h:
• UIProcess/API/Cocoa/WKWebsiteDataRecord.mm:

(dataTypesToString):

• UIProcess/API/Cocoa/WKWebsiteDataRecordInternal.h:

(WebKit::toWebsiteDataType):
(WebKit::toWKWebsiteDataTypes):

• UIProcess/API/Cocoa/WKWebsiteDataStore.mm:

(+[WKWebsiteDataStore allWebsiteDataTypes]):

• UIProcess/WebsiteData/WebsiteDataStore.cpp:

(WebKit::WebsiteDataStore::fetchDataAndApply):
(WebKit::WebsiteDataStore::removeData):

4:46 PM Changeset in webkit [223157] by jmarcell@apple.com

• 18 edits
  2 copies
  2 adds in branches/safari-604-branch

Cherry-pick r222478. rdar://problem/34771020

4:40 PM Changeset in webkit [223156] by Chris Dumez

• 2 edits in trunk/Source/WebCore

Unreviewed, really fix the build with certain SDKs.

Follow-up to r223154, which fixed the wrong lambda.

• Modules/entriesapi/DOMFileSystem.cpp:

(WebCore::DOMFileSystem::getEntry):
(WebCore::DOMFileSystem::getFile):

4:14 PM Changeset in webkit [223155] by guijemont@igalia.com

• 3 edits in trunk/Source/JavaScriptCore

Fix compilation when MASM_PROBE (and therefore DFG) are disabled
​https://bugs.webkit.org/show_bug.cgi?id=178134

Reviewed by Saam Barati.

• bytecode/CodeBlock.cpp:
• bytecode/CodeBlock.h:

Disable some code when building without DFG_JIT.

4:09 PM Changeset in webkit [223154] by Chris Dumez

• 2 edits in trunk/Source/WebCore

Unreviewed, fix build with certain SDKs.

Stop capturing |this| unnecessarily in lambda.

• Modules/entriesapi/DOMFileSystem.cpp:

(WebCore::DOMFileSystem::getEntry):

3:59 PM Changeset in webkit [223153] by Matt Lewis

• 3 edits in trunk/Source/WebCore

Unreviewed, rolling out r223148.

This caused build failures.

Reverted changeset:

"Fix MSVC build with ENCRYPTED_MEDIA enabled"
​https://bugs.webkit.org/show_bug.cgi?id=177803
​http://trac.webkit.org/changeset/223148

3:59 PM Changeset in webkit [223152] by Michael Catanzaro

• 2 edits in trunk

[WPE] Expose ENABLE_XSLT option
​https://bugs.webkit.org/show_bug.cgi?id=177857

Reviewed by Carlos Alberto Lopez Perez.

• Source/cmake/OptionsWPE.cmake:

3:47 PM Changeset in webkit [223151] by Alan Bujtas

• 9 edits in trunk/Source/WebCore

AccessibilityRenderObject should not hold a raw pointer to RenderObject
​https://bugs.webkit.org/show_bug.cgi?id=178144
<rdar://problem/34919287>

Reviewed by Chris Fleizach.

m_renderer's lifetime is not directly tied to the AX wrapper object's lifetime.

Covered by existing tests.

• accessibility/AccessibilityListBox.cpp:

(WebCore::AccessibilityListBox::elementAccessibilityHitTest const):

• accessibility/AccessibilityMathMLElement.cpp:

(WebCore::AccessibilityMathMLElement::isMathFenceOperator const):
(WebCore::AccessibilityMathMLElement::isMathSeparatorOperator const):
(WebCore::AccessibilityMathMLElement::mathLineThickness const):

• accessibility/AccessibilityMenuList.cpp:

(WebCore::AccessibilityMenuList::press):
(WebCore::AccessibilityMenuList::isCollapsed const):

• accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::AccessibilityRenderObject):
(WebCore::AccessibilityRenderObject::renderBoxModelObject const):
(WebCore::AccessibilityRenderObject::setRenderer):
(WebCore::AccessibilityRenderObject::previousSibling const):
(WebCore::AccessibilityRenderObject::anchorElement const):
(WebCore::AccessibilityRenderObject::helpText const):
(WebCore::AccessibilityRenderObject::boundingBoxRect const):
(WebCore::AccessibilityRenderObject::supportsPath const):
(WebCore::AccessibilityRenderObject::elementPath const):
(WebCore::AccessibilityRenderObject::computeAccessibilityIsIgnored const):
(WebCore::AccessibilityRenderObject::index const):
(WebCore::AccessibilityRenderObject::handleActiveDescendantChanged):
(WebCore::AccessibilityRenderObject::observableObject const):
(WebCore::AccessibilityRenderObject::determineAccessibilityRole):
(WebCore::AccessibilityRenderObject::textChanged):
(WebCore::AccessibilityRenderObject::remoteSVGRootElement const):
(WebCore::AccessibilityRenderObject::roleValueForMSAA const):
(WebCore::AccessibilityRenderObject::getScrollableAreaIfScrollable const):
(WebCore::AccessibilityRenderObject::scrollTo const):

• accessibility/AccessibilityRenderObject.h:

(WebCore::AccessibilityRenderObject::setRenderObject):

• accessibility/AccessibilitySlider.cpp:

(WebCore::AccessibilitySlider::elementAccessibilityHitTest const):

• accessibility/AccessibilityTable.cpp:

(WebCore::AccessibilityTable::addChildren):

• accessibility/AccessibilityTableCell.cpp:

(WebCore::AccessibilityTableCell::computeAccessibilityIsIgnored const):
(WebCore::AccessibilityTableCell::parentTable const):
(WebCore::AccessibilityTableCell::rowIndexRange const):
(WebCore::AccessibilityTableCell::columnIndexRange const):
(WebCore::AccessibilityTableCell::titleUIElement const):

3:37 PM Changeset in webkit [223150] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebKit

Unreviewed, rolling out r223130.
​https://bugs.webkit.org/show_bug.cgi?id=178147

Breaks the build when EGLNativeWindowType is a pointer
(Requested by aperezdc on #webkit).

Reverted changeset:

"[WPE] Build failure due to invalid cast of
EGLNativeWindowType when targetting 64-bit ARM"
​https://bugs.webkit.org/show_bug.cgi?id=178090
​http://trac.webkit.org/changeset/223130

3:13 PM Changeset in webkit [223149] by commit-queue@webkit.org

• 42 edits in trunk/Source

Replace copyKeysToVector/copyValuesToVector with copyToVector(map.keys())/copyToVector(map.values())
​https://bugs.webkit.org/show_bug.cgi?id=178102

Patch by Sam Weinig <​sam@webkit.org> on 2017-10-10
Reviewed by Tim Horton.

Source/JavaScriptCore:

• inspector/agents/InspectorDebuggerAgent.cpp:

(Inspector::InspectorDebuggerAgent::clearInspectorBreakpointState):

Source/WebCore:

• Modules/geolocation/Geolocation.cpp:

(WebCore::Geolocation::Watchers::getNotifiersVector const):

• Modules/indexeddb/IDBTransaction.cpp:

(WebCore::IDBTransaction::connectionClosedFromServer):

• Modules/indexeddb/client/IDBConnectionProxy.cpp:

(WebCore::IDBClient::IDBConnectionProxy::connectionToServerLost):

• Modules/indexeddb/server/UniqueIDBDatabase.cpp:

(WebCore::IDBServer::UniqueIDBDatabase::immediateCloseForUserDelete):

• Modules/mediastream/MediaStream.cpp:

(WebCore::MediaStream::getTracks const):

• bindings/js/ScriptController.cpp:

(WebCore::ScriptController::windowProxies):

• css/CSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::item const):

• dom/Document.cpp:

(WebCore::Document::prepareForDestruction):

• dom/DocumentMarkerController.cpp:

(WebCore::DocumentMarkerController::removeMarkers):

• inspector/InspectorWorkerAgent.cpp:

(WebCore::InspectorWorkerAgent::disconnectFromAllWorkerInspectorProxies):

• inspector/NetworkResourcesData.cpp:
• loader/DocumentLoader.cpp:

(WebCore::cancelAll):
(WebCore::setAllDefersLoading):
(WebCore::areAllLoadersPageCacheAcceptable):

• loader/cache/MemoryCache.cpp:

(WebCore::MemoryCache::forEachSessionResource):

• loader/mac/DocumentLoaderMac.cpp:

(WebCore::scheduleAll):
(WebCore::unscheduleAll):

• page/ResourceUsageThread.cpp:

(WebCore::ResourceUsageThread::notifyObservers):

• platform/mediastream/MediaStreamPrivate.cpp:

(WebCore::MediaStreamPrivate::tracks const):

Replace copyKeysToVector / copyValuesToVector with copyToVector(map.keys()) / copyToVector(map.values())

Source/WebDriver:

• SessionHost.cpp:

(WebDriver::SessionHost::inspectorDisconnected):

Source/WebKit:

• NetworkProcess/NetworkConnectionToWebProcess.cpp:

(WebKit::NetworkConnectionToWebProcess::didClose):

• Shared/RemoteLayerTree/RemoteLayerTreeTransaction.mm:

(WebKit::dumpChangedLayers):

• UIProcess/API/glib/WebKitWebContext.cpp:

(webkitWebContextInvalidateCustomProtocolRequests):

• UIProcess/API/gtk/WebKitWebViewBase.cpp:

(webkitWebViewBaseContainerForall):

• UIProcess/Cocoa/WKWebViewContentProviderRegistry.mm:

(-[WKWebViewContentProviderRegistry _mimeTypesWithCustomContentProviders]):

• UIProcess/GenericCallback.h:

(WebKit::invalidateCallbackMap):

• UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::shutDown):
(WebKit::WebProcessProxy::didClose):
(WebKit::WebProcessProxy::didBecomeUnresponsive):
(WebKit::WebProcessProxy::didBecomeResponsive):
(WebKit::WebProcessProxy::willChangeIsResponsive):
(WebKit::WebProcessProxy::didChangeIsResponsive):
(WebKit::WebProcessProxy::disconnectFramesFromPage):
(WebKit::WebProcessProxy::frameCountInPage const):
(WebKit::WebProcessProxy::requestTermination):

• WebProcess/Plugins/Netscape/NPRuntimeObjectMap.cpp:

(WebKit::NPRuntimeObjectMap::invalidate):

• WebProcess/Plugins/Netscape/NetscapePlugin.cpp:

(WebKit::NetscapePlugin::stopAllStreams):

• WebProcess/Plugins/PluginView.cpp:

(WebKit::PluginView::cancelAllStreams):

• WebProcess/WebPage/RemoteLayerTree/RemoteLayerTreeContext.mm:

(WebKit::RemoteLayerTreeContext::buildTransaction):

• WebProcess/WebProcess.cpp:

(WebKit::WebProcess::didClose):

Source/WebKitLegacy:

• WebCoreSupport/WebResourceLoadScheduler.cpp:

(WebResourceLoadScheduler::servePendingRequests):

Source/WebKitLegacy/mac:

• History/WebHistory.mm:

(-[WebHistoryPrivate rebuildHistoryByDayIfNeeded:]):

• Plugins/Hosted/NetscapePluginInstanceProxy.mm:

(WebKit::NetscapePluginInstanceProxy::stopAllStreams):

• WebCoreSupport/WebUserMediaClient.mm:

(WebUserMediaClient::pageDestroyed):

Source/WTF:

• wtf/HashMap.h:

(WTF::copyKeysToVector): Deleted.
(WTF::copyValuesToVector): Deleted.

Remove copyKeysToVector and copyValuesToVector which are no longer used.

2:51 PM Changeset in webkit [223148] by commit-queue@webkit.org

• 3 edits in trunk/Source/WebCore

Fix MSVC build with ENCRYPTED_MEDIA enabled
​https://bugs.webkit.org/show_bug.cgi?id=177803

Patch by Yoshiaki Jitsukawa <​Yoshiaki.Jitsukawa@sony.com> on 2017-10-10
Reviewed by Alex Christensen.

As a workaround for MSVC, a weak pointer of "this" is captured
at the outermost lambda expression.

• Modules/encryptedmedia/MediaKeySession.cpp:

(WebCore::MediaKeySession::generateRequest):
(WebCore::MediaKeySession::load):
(WebCore::MediaKeySession::update):
(WebCore::MediaKeySession::close):
(WebCore::MediaKeySession::remove):

• platform/encryptedmedia/clearkey/CDMClearKey.cpp:

(WebCore::CDMInstanceClearKey::updateLicense):
(WebCore::CDMInstanceClearKey::loadSession):
(WebCore::CDMInstanceClearKey::removeSessionData):

2:40 PM Changeset in webkit [223147] by commit-queue@webkit.org

• 4 edits in trunk/Source/WebInspectorUI

Web Inspector: Network Tab - Set column initial widths to try allow waterfall column to expand more by default
​https://bugs.webkit.org/show_bug.cgi?id=178142
<rdar://problem/34918233>

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2017-10-10
Reviewed by Brian Burg.

• UserInterface/Views/NetworkTableContentView.js:

(WI.NetworkTableContentView.prototype.initialLayout):
Provide initial widths for many columns where the max could fit
but we'd prefer a smaller than max initial width in wide cases.

• UserInterface/Views/Table.js:

(WI.Table.prototype._resizeColumnsAndFiller):
When auto sizing all columns use the preferred initial widths.

• UserInterface/Views/TableColumn.js:

(WI.TableColumn.prototype.get preferredInitialWidth):
Save the initial width.

2:32 PM Changeset in webkit [223146] by Adrian Perez de Castro

• 2 edits in trunk/Source/WebKit

[WPE] Header cairo.h is used in GLib API headers but cannot be found
​https://bugs.webkit.org/show_bug.cgi?id=178100

Reviewed by Michael Catanzaro.

• wpe/wpe-webkit.pc.in: Add Cairo to the "Requires" field, so its flags get pulled

in and the "cairo.h", used in the WPE WebKit GLib API headers, can be found.

2:29 PM Changeset in webkit [223145] by jdiggs@igalia.com

• 6 edits in trunk

AX: [ATK] ARIA form role should be mapped to ATK_ROLE_LANDMARK; not ATK_ROLE_FORM
​https://bugs.webkit.org/show_bug.cgi?id=178137

Reviewed by Chris Fleizach.

Source/WebCore:

Expose the ARIA form role as ATK_ROLE_LANDMARK; continue to expose the HTML form
element as ATK_ROLE_FORM.

No new tests needed due to existing coverage. Update expectations for roles-exposed.html.

• accessibility/atk/WebKitAccessibleWrapperAtk.cpp:

(atkRole):

Tools:

Add handling for ATK_ROLE_LANDMARK resulting from the ARIA form role.

• WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:

LayoutTests:

• platform/gtk/accessibility/roles-exposed-expected.txt: Updated expectations.

2:29 PM WebKitGTK/2.18.x edited by Michael Catanzaro

(diff)

2:26 PM Changeset in webkit [223144] by mrajca@apple.com

• 4 edits
  4 adds in trunk

Respect audio rate change restrictions in HTMLMediaElement::setVolume.
​https://bugs.webkit.org/show_bug.cgi?id=178140

Reviewed by Eric Carlson.

Source/WebCore:

Tests: media/audio-playback-volume-changes-with-restrictions-and-user-gestures.html

media/audio-playback-volume-changes-with-restrictions.html

It's currently possible for a website to start auto-playing media with a zero volume and then
programmatically set the volume to a non-zero value without a user gesture. This code path didn't
have to be considered previously because volume changes are not supported on iOS.

We currently pause media when an audio track comes in after an element has already started playing silently
in mediaPlayerDidAddAudioTrack. This patch does the same when a non-zero volume is set after a media
element already began playing silently and there is an audio rate change restriction.

• html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::setVolume):

LayoutTests:

• media/audio-playback-volume-changes-with-restrictions-and-user-gestures-expected.txt: Added.
• media/audio-playback-volume-changes-with-restrictions-and-user-gestures.html: Added.
• media/audio-playback-volume-changes-with-restrictions-expected.txt: Added.
• media/audio-playback-volume-changes-with-restrictions.html: Added.
• platform/ios/TestExpectations:

2:24 PM October 2017 Meeting edited by Jon Davis

(diff)

2:24 PM Changeset in webkit [223143] by Michael Catanzaro

• 2 edits in trunk/Source/WebKit

CSS constant properties should not be enabled by default
​https://bugs.webkit.org/show_bug.cgi?id=177416

Reviewed by Darin Adler.

• Shared/WebPreferencesDefinitions.h:

2:10 PM Changeset in webkit [223142] by msaboff@apple.com

• 2 edits in trunk/Source/JavaScriptCore

Unreviewed build fix.

Removed unused lambda capture.

• yarr/YarrPattern.cpp:

(JSC::Yarr::CharacterClassConstructor::appendInverted):

2:03 PM Changeset in webkit [223141] by beidson@apple.com

• 5 edits in trunk/Source/WebKit

Random StorageProcess and SWServer cleanup.
​https://bugs.webkit.org/show_bug.cgi?id=178141

Reviewed by Andy Estes.

-StorageProcess should own the set of SWServers
-Some renaming and cleanup

• StorageProcess/StorageProcess.cpp:

(WebKit::StorageProcess::createStorageToWebProcessConnection):
(WebKit::StorageProcess::swServerForSession):

• StorageProcess/StorageProcess.h:

(WebKit::StorageProcess::queue):

• StorageProcess/StorageToWebProcessConnection.cpp:

(WebKit::StorageToWebProcessConnection::establishSWServerConnection):

• StorageProcess/StorageToWebProcessConnection.h:

1:50 PM Changeset in webkit [223140] by rniwa@webkit.org

• 13 edits in trunk

Loading should be disabled while constructing the fragment in WebContentReader::readWebArchive
​https://bugs.webkit.org/show_bug.cgi?id=178118

Reviewed by Antti Koivisto.

Source/WebCore:

Disable image loading while constructing the document fragment in WebContentReader::readWebArchive
as we do in createFragmentAndAddResources for RTF/RTFD. This refactoring is needed to start using
blob URL in the pasted document fragment for webkit.org/b/124391.

Also modified WebContentReader::readWebArchive to take a reference to SharedBuffer instead of a pointer.

No new tests since existing tests have been updated to cover this behavior change.

• editing/WebContentReader.h:
• editing/cocoa/WebContentReaderCocoa.mm:

(WebCore::WebContentReader::readWebArchive): Use DeferredLoadingScope to disable the loader and images
while constructing the document fragment.

• platform/Pasteboard.h:
• platform/ios/PasteboardIOS.mm:

(WebCore::readPasteboardWebContentDataForType):

• platform/mac/PasteboardMac.mm:

(WebCore::Pasteboard::read):

LayoutTests:

Updated the existing tests to wait for images to load in each step explicitly instead of relying on
them being loaded synchronously or that it's loaded within 100-200ms.

• editing/pasteboard/4641033.html:
• editing/pasteboard/4947130.html:
• editing/pasteboard/4989774.html:
• editing/pasteboard/drag-selected-image-to-contenteditable.html:
• editing/selection/drag-to-contenteditable-iframe.html:
• platform/ios/TestExpectations: Skipped editing/selection/drag-to-contenteditable-iframe.html on iOS

since we don't support testing drag & drop on iOS. Also added [ Skip ] to other entires there.

1:36 PM Changeset in webkit [223139] by Antti Koivisto

• 4 edits in trunk/Source/WebCore

Layers should be destroyed by RenderLayerModelObject
​https://bugs.webkit.org/show_bug.cgi?id=178139

Reviewed by Simon Fraser.

Clean up some FIXMEs.

• rendering/RenderLayerModelObject.cpp:

(WebCore::RenderLayerModelObject::willBeDestroyed):
(WebCore::RenderLayerModelObject::destroyLayer):

• rendering/RenderLayerModelObject.h:
• rendering/RenderObject.cpp:

(WebCore::RenderObject::willBeDestroyed):

12:41 PM Changeset in webkit [223138] by Michael Catanzaro

• 4 edits in trunk/Source/WebKit

Unreviewed, rolling out r223136.

Forgot to update GTK API header

Reverted changeset:

"[WPE] Header cairo.h is used in GLib API headers but cannot
be found"
​https://bugs.webkit.org/show_bug.cgi?id=178100
​http://trac.webkit.org/changeset/223136

12:24 PM Changeset in webkit [223137] by commit-queue@webkit.org

• 10 edits in trunk/Source/WebInspectorUI

Web Inspector: Views should explicitly remove event listeners from managers/Frame
​https://bugs.webkit.org/show_bug.cgi?id=175951

Patch by Ross Kirsling <Ross Kirsling> on 2017-10-10
Reviewed by Brian Burg.

• UserInterface/Views/ApplicationCacheDetailsSidebarPanel.js:

(WI.ApplicationCacheDetailsSidebarPanel.prototype.closed):

• UserInterface/Views/DOMNodeDetailsSidebarPanel.js:

(WI.DOMNodeDetailsSidebarPanel.prototype.closed):

• UserInterface/Views/DebuggerDashboardView.js:

(WI.DebuggerDashboardView.prototype.closed):

• UserInterface/Views/LogContentView.js:

(WI.LogContentView.prototype.closed):

• UserInterface/Views/NetworkGridContentView.js:

(WI.NetworkGridContentView.prototype.closed):

• UserInterface/Views/ProbeDetailsSidebarPanel.js:

(WI.ProbeDetailsSidebarPanel.prototype.closed):

• UserInterface/Views/QuickConsole.js:

(WI.QuickConsole.prototype.closed):

• UserInterface/Views/ScopeChainDetailsSidebarPanel.js:

(WI.ScopeChainDetailsSidebarPanel.prototype.closed):

• UserInterface/Views/TimelineOverview.js:

(WI.TimelineOverview.prototype.closed):

12:09 PM Changeset in webkit [223136] by Adrian Perez de Castro

• 4 edits in trunk/Source/WebKit

[WPE] Header cairo.h is used in GLib API headers but cannot be found
​https://bugs.webkit.org/show_bug.cgi?id=178100

Reviewed by Žan Doberšek.

Instead of including <cairo.h>, it is better to forward-declare cairo_surface_t,
which is the one and only Cairo declaration needed by the WPE API header.

• UIProcess/API/glib/WebKitFaviconDatabase.cpp: Add inclusion of <cairo.h>.
• UIProcess/API/glib/WebKitWebView.cpp: Add inclusion of <cairo.h>.
• UIProcess/API/wpe/WebKitFaviconDatabase.h: Add forward declaration of cairo_surface_t.

11:42 AM Changeset in webkit [223135] by Chris Dumez

• 7 edits in trunk

Entries API should recognize path starting with 2 slashes as valid absolute path
​https://bugs.webkit.org/show_bug.cgi?id=178135

Reviewed by Ryosuke Niwa.

Source/WebCore:

Entries API should recognize paths starting with 2 slashes as valid absolute paths to match Chrome's behavior.
See ​https://github.com/WICG/entries-api/commit/990454758005a6039655835503d551015e346d9d

This was causing us to fail some manual web-platform-tests.

No new tests, updated existing tests.

• Modules/entriesapi/DOMFileSystem.cpp:

(WebCore::isValidPathSegment):
(WebCore::isZeroOrMorePathSegmentsSeparatedBySlashes):
(WebCore::isValidRelativeVirtualPath):
(WebCore::isValidVirtualPath):

LayoutTests:

Add layout test coverage.

• editing/pasteboard/entries-api/datatransfer-items-drop-getDirectory-expected.txt:
• editing/pasteboard/entries-api/datatransfer-items-drop-getDirectory.html:
• editing/pasteboard/entries-api/datatransfer-items-drop-getFile-expected.txt:
• editing/pasteboard/entries-api/datatransfer-items-drop-getFile.html:

10:58 AM Changeset in webkit [223134] by Matt Lewis

• 6 edits
  3 deletes in trunk

Unreviewed, rolling out r223110.

This caused consistent failures and timeouts on multiple
platforms.

Reverted changeset:

"Delete button doesn't fully delete certain emoji"
​https://bugs.webkit.org/show_bug.cgi?id=178096
​http://trac.webkit.org/changeset/223110

10:44 AM Changeset in webkit [223133] by Adrian Perez de Castro

• 2 edits in trunk/Source/WebKit

[WPE] Cannot link against libWPEWebkit due to wrong contents of wpe-webkit.pc
​https://bugs.webkit.org/show_bug.cgi?id=178133

Reviewed by Žan Doberšek.

• wpe/wpe-webkit.pc.in: Remove "-lWPE" and replace "Requires.private" with a plain "Requires".

10:08 AM WebKitGTK/2.18.x edited by clopez@igalia.com

(diff)

9:08 AM October 2017 Meeting edited by Jon Davis

Proposed schedule (diff)

8:58 AM Changeset in webkit [223132] by Jonathan Bedard

• 5 edits in trunk/Tools

run-webkit-tests: upload test results to multiple servers
​https://bugs.webkit.org/show_bug.cgi?id=178012
<rdar://problem/34856501>

Reviewed by Lucas Forschler.

Allowing uploading of results to multiple servers makes developing new results
databases much easier, and does not complicate uploading logic.

• Scripts/webkitpy/layout_tests/controllers/manager.py:

(Manager.upload_results): Iterate through the list of results server hosts and
send results to each one.

• Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:

(JSONLayoutResultsGenerator.init): Accept a list of test results servers.

• Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:

(JSONResultsGenerator.init): Accept a list of test results servers.
(JSONResultsGenerator.get_json): Pick which server to download from by index.
(JSONResultsGenerator.upload_json_files): Upload the JSON to each results server.
(JSONResultsGenerator._get_archived_json_results): Pick which server to download from.

• Scripts/webkitpy/layout_tests/run_webkit_tests.py:

(parse_args): Allow multiple test-results-servers and results-server-hosts to be
passed to run-webkit-tests.

6:02 AM Changeset in webkit [223131] by Antti Koivisto

• 14 edits in trunk

RenderObject::destroy() should only be invoked after renderer has been removed from the tree
​https://bugs.webkit.org/show_bug.cgi?id=178075

Reviewed by Zalan Bujtas.

Source/WebCore:

This patch fixes the remaining cases where the renderer is still in the tree while destroy()
is called and adds the assert.

• rendering/RenderBlock.cpp:

(WebCore::RenderBlock::removeLeftoverAnonymousBlock):
(WebCore::RenderBlock::takeChild):

• rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::willBeDestroyed):

• rendering/RenderLayer.cpp:

(WebCore::RenderLayer::~RenderLayer):

Null the parent pointers for m_scrollCorner/m_resizer.

(WebCore::RenderLayer::calculateClipRects const):

• rendering/RenderLayer.h:
• rendering/RenderObject.cpp:

(WebCore::RenderObject::willBeDestroyed):
(WebCore::RenderObject::removeFromParentAndDestroyCleaningUpAnonymousWrappers):
(WebCore::RenderObject::destroy):

Use RELEASE_ASSERT as these are cheap and important checks.
Also turn isBeingDestroyed test into RELEASE_ASSERT.
Remove AX call that no longer does anything.

(WebCore::RenderObject::destroyAndCleanupAnonymousWrappers): Deleted.

• rendering/RenderObject.h:
• rendering/RenderRubyBase.cpp:

(WebCore::RenderRubyBase::moveBlockChildren):

• rendering/RenderTableRow.cpp:

(WebCore::RenderTableRow::collapseAndDestroyAnonymousSiblingRows):
(WebCore::RenderTableRow::destroyAndCollapseAnonymousSiblingRows): Deleted.

Renamed and made this no longer destroy itself. The caller now takes care of that.
Removed an unnecessary lambda.

• rendering/RenderTableRow.h:
• style/RenderTreeUpdater.cpp:

(WebCore::RenderTreeUpdater::tearDownRenderers):
(WebCore::RenderTreeUpdater::tearDownRenderer):

• style/RenderTreeUpdaterListItem.cpp:

(WebCore::RenderTreeUpdater::ListItem::updateMarker):

LayoutTests:

• accessibility/mac/textbox-role-reports-notifications.html:

This passed because spurious AXValueChanged notifications. Force layout to prevent coalescing between mutations.

5:47 AM Changeset in webkit [223130] by Adrian Perez de Castro

• 2 edits in trunk/Source/WebKit

[WPE] Build failure due to invalid cast of EGLNativeWindowType when targetting 64-bit ARM
​https://bugs.webkit.org/show_bug.cgi?id=178090

Reviewed by Žan Doberšek.

• WebProcess/WebPage/wpe/AcceleratedSurfaceWPE.cpp:

(WebKit::AcceleratedSurfaceWPE::window const): Use static_cast instead of reinterpret_cast,
this way extending values of EGLNativeWindowType to 64 bits is allowed.

5:02 AM Changeset in webkit [223129] by Adrian Perez de Castro

• 2 edits in trunk/Source/WebKit

[WPE] GLib API headers WebKitScriptDialog.h and WebKitFileChooserRequest.h are not installed
​https://bugs.webkit.org/show_bug.cgi?id=178104

Reviewed by Žan Doberšek.

• PlatformWPE.cmake: Add missing header paths to the WPE_API_INSTALLED_HEADERS variable.

4:27 AM Changeset in webkit [223128] by Adrian Perez de Castro

• 2 edits in trunk/Source/WebKit

[WPE][CMake] The “install” target should install all public API headers
​https://bugs.webkit.org/show_bug.cgi?id=176475

Reviewed by Žan Doberšek.

Install the WPE port GLib-based API headers. The deprecated C API is still available,
but disabled by default behind the "EXPORT_DEPRECATED_WEBKIT2_C_API" CMake option.

• PlatformWPE.cmake: Always install "wpe-webkit.pc" and the GLib C API for WPE.

3:38 AM Changeset in webkit [223127] by Antti Koivisto

• 8 edits in trunk/Source/WebCore

Add isContinuation bit
​https://bugs.webkit.org/show_bug.cgi?id=178084

Reviewed by Zalan Bujtas.

Currently continuations are identified indirectly by comparing renderer pointer with the element renderer pointer.
This is bug prone and fails to cover anonymous continuations.

• accessibility/AccessibilityRenderObject.cpp:

(WebCore::firstChildConsideringContinuation):
(WebCore::startOfContinuations):
(WebCore::firstChildIsInlineContinuation):
(WebCore::AccessibilityRenderObject::computeAccessibilityIsIgnored const):

Ignore first-letter fragment. This worked before because first-letter renderers
were mistakenly considered inline element continuations (see below).

• rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::setContinuation):

• rendering/RenderElement.cpp:

(WebCore::RenderElement::RenderElement):

• rendering/RenderElement.h:

(WebCore::RenderElement::hasContinuation const):
(WebCore::RenderElement::isContinuation const):
(WebCore::RenderElement::setIsContinuation):

The new bit.

(WebCore::RenderElement::isElementContinuation const):
(WebCore::RenderElement::isInlineElementContinuation const):

• rendering/RenderInline.cpp:

(WebCore::RenderInline::addChildIgnoringContinuation):
(WebCore::RenderInline::cloneAsContinuation const):
(WebCore::RenderInline::splitInlines):
(WebCore::RenderInline::childBecameNonInline):
(WebCore::RenderInline::clone const): Deleted.

• rendering/RenderInline.h:
• rendering/RenderObject.h:

(WebCore::RenderObject::isAnonymousBlock const):
(WebCore::RenderObject::isElementContinuation const): Deleted.

The old continuation test was 'node() && node()->renderer() != this'
This was fragile as nulling the renderer will make it fail.
It was also wrong for first-letter renderers (isElementContinuation was true for them).

(WebCore::RenderObject::isInlineElementContinuation const): Deleted.

Move to RenderElement.

(WebCore::RenderObject::isBlockElementContinuation const): Deleted.

1:55 AM Changeset in webkit [223126] by jdiggs@igalia.com

• 5 edits
  2 adds in trunk

AX: [ATK] STATE_CHECKABLE should be removed from radio buttons in radiogroups with aria-readonly="true"
​https://bugs.webkit.org/show_bug.cgi?id=177931

Reviewed by Chris Fleizach.

Source/WebCore:

Add a check in canSetValueAttribute() for readonly radiogroup ancestors of
radio buttons.

Test: accessibility/gtk/aria-readonly-radiogroup.html

• accessibility/AccessibilityNodeObject.cpp:

(WebCore::AccessibilityNodeObject::canSetValueAttribute const):

• accessibility/AccessibilityObject.cpp:

(WebCore::AccessibilityObject::radioGroupAncestor const):

• accessibility/AccessibilityObject.h:

LayoutTests:

• accessibility/gtk/aria-readonly-radiogroup-expected.txt: Added.
• accessibility/gtk/aria-readonly-radiogroup.html: Added.

12:58 AM Changeset in webkit [223125] by sbarati@apple.com

• 16 edits
  2 moves
  1 add in trunk

The prototype cache should be aware of the Executable it generates a Structure for
​https://bugs.webkit.org/show_bug.cgi?id=177907

Reviewed by Filip Pizlo.

JSTests:

• microbenchmarks/dont-confuse-structures-from-different-executable-as-poly-proto.js: Added.

(assert):
(foo.C):
(foo):
(bar.C):
(bar):
(access):
(makeLongChain):
(accessY):

Source/JavaScriptCore:

This patch renames PrototypeMap to StructureCache because
it is no longer a map of the prototypes in the VM. It's
only used to cache Structures during object construction.

The main change of this patch is to guarantee that Structures generated
by the create_this originating from different two different Executables'
bytecode won't hash-cons to the same thing. Previously, we could hash-cons
them depending on the JSObject* prototype pointer. This would cause the last
thing that hash-consed to overwrite the Structure's poly proto watchpoint. This
happened because when we initialize a JSFunction's ObjectAllocationProfile,
we set the resulting Structure's poly proto watchpoint. This could cause a Structure
generating from some Executable e1 to end up with the poly proto watchpoint
for another Executable e2 simply because JSFunctions backed by e1 and e2
shared the same prototype. Then, based on profiling information, we may fire the
wrong Executable's poly proto watchpoint. This patch fixes this bug by
guaranteeing that Structures generating from create_this for different
Executables are unique even if they share the same prototype by adding
the FunctionExecutable* as another field in PrototypeKey.

• JavaScriptCore.xcodeproj/project.pbxproj:
• Sources.txt:
• bytecode/InternalFunctionAllocationProfile.h:

(JSC::InternalFunctionAllocationProfile::createAllocationStructureFromBase):

• bytecode/ObjectAllocationProfile.cpp:

(JSC::ObjectAllocationProfile::initializeProfile):

• dfg/DFGOperations.cpp:
• runtime/CommonSlowPaths.cpp:

(JSC::SLOW_PATH_DECL):

• runtime/InternalFunction.cpp:

(JSC::InternalFunction::createSubclassStructureSlow):

• runtime/IteratorOperations.cpp:

(JSC::createIteratorResultObjectStructure):

• runtime/JSBoundFunction.cpp:

(JSC::getBoundFunctionStructure):

• runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::init):

• runtime/ObjectConstructor.h:

(JSC::constructEmptyObject):

• runtime/PrototypeKey.h:

(JSC::PrototypeKey::PrototypeKey):
(JSC::PrototypeKey::executable const):
(JSC::PrototypeKey::operator== const):
(JSC::PrototypeKey::hash const):

• runtime/PrototypeMap.cpp: Removed.
• runtime/PrototypeMap.h: Removed.
• runtime/StructureCache.cpp: Copied from Source/JavaScriptCore/runtime/PrototypeMap.cpp.

(JSC::StructureCache::createEmptyStructure):
(JSC::StructureCache::emptyStructureForPrototypeFromBaseStructure):
(JSC::StructureCache::emptyObjectStructureForPrototype):
(JSC::PrototypeMap::createEmptyStructure): Deleted.
(JSC::PrototypeMap::emptyStructureForPrototypeFromBaseStructure): Deleted.
(JSC::PrototypeMap::emptyObjectStructureForPrototype): Deleted.

• runtime/StructureCache.h: Copied from Source/JavaScriptCore/runtime/PrototypeMap.h.

(JSC::StructureCache::StructureCache):
(JSC::PrototypeMap::PrototypeMap): Deleted.

• runtime/VM.cpp:

(JSC::VM::VM):

• runtime/VM.h:

Oct 9, 2017:

10:53 PM Changeset in webkit [223124] by Yusuke Suzuki

• 9 edits
  6 adds in trunk

async should be able to be used as an imported binding name
​https://bugs.webkit.org/show_bug.cgi?id=176573

Reviewed by Saam Barati.

JSTests:

• modules/import-default-async.js: Added.
• modules/import-named-async-as.js: Added.
• modules/import-named-async.js: Added.
• modules/import-named-async/target.js: Added.
• modules/import-namespace-async.js: Added.
• test262.yaml:

Source/JavaScriptCore:

Previously, we have ASYNC keyword in the parser. This is introduced only for performance,
and ECMA262 spec does not categorize "async" to keyword. This makes parser code complicated,
since ASYNC should be handled as IDENT. If we missed this ASYNC keyword, we cause a bug.
For example, import declaration failed to bind imported binding to the name "async" because
the parser considered ASYNC as keyword.

This patch removes ASYNC keyword from the parser. By carefully handling ASYNC, we can keep
the current performance without using this ASYNC keyword.

We also add escaped field to token data since contextual keyword is valid only if it does
not contain any escape sequences. We fix bunch of contextual keyword use with this fix too
e.g. of in for-of. This improves test262 score.

• parser/Keywords.table:
• parser/Lexer.cpp:

(JSC::Lexer<LChar>::parseIdentifier):
(JSC::Lexer<UChar>::parseIdentifier):
(JSC::Lexer<CharacterType>::parseIdentifierSlowCase):

• parser/Parser.cpp:

(JSC::Parser<LexerType>::parseStatementListItem):
(JSC::Parser<LexerType>::parseForStatement):
(JSC::Parser<LexerType>::parseStatement):
(JSC::Parser<LexerType>::maybeParseAsyncFunctionDeclarationStatement):
(JSC::Parser<LexerType>::parseClass):
(JSC::Parser<LexerType>::parseExportDeclaration):
(JSC::Parser<LexerType>::parseAssignmentExpression):
(JSC::Parser<LexerType>::parseProperty):
(JSC::Parser<LexerType>::parsePrimaryExpression):
(JSC::Parser<LexerType>::parseMemberExpression):
(JSC::Parser<LexerType>::printUnexpectedTokenText):

• parser/Parser.h:

(JSC::Parser::matchContextualKeyword):

• parser/ParserTokens.h:
• runtime/CommonIdentifiers.h:

10:11 PM Changeset in webkit [223123] by sbarati@apple.com

• 4 edits in trunk/Source/JavaScriptCore

We don't need to clearEmptyObjectStructureForPrototype because JSGlobalObject* is part of the cache's key
​https://bugs.webkit.org/show_bug.cgi?id=177987

Reviewed by Filip Pizlo.

• runtime/JSProxy.cpp:

(JSC::JSProxy::setTarget):

• runtime/PrototypeMap.cpp:

(JSC::PrototypeMap::clearEmptyObjectStructureForPrototype): Deleted.

• runtime/PrototypeMap.h:

9:44 PM Changeset in webkit [223122] by commit-queue@webkit.org

• 4 edits in trunk

Vector should be able to easily create from a list of movable only items
​https://bugs.webkit.org/show_bug.cgi?id=176432

Patch by Youenn Fablet <​youenn@apple.com> on 2017-10-09
Reviewed by Darin Adler.

Source/WTF:

Adding static from method to construct a Vector from movable-only items.
This may also be used instead of initializer list constructor for types that would benefit of being moved.

• wtf/Vector.h:

(WTF::Vector::Vector):
(WTF::Vector::from):
(WTF::Vector::uncheckedInitialize): Introduced as an optimization to set the vector size once.
(WTF::Malloc>::reserveInitialCapacity):

Tools:

• TestWebKitAPI/Tests/WTF/Vector.cpp:

(TestWebKitAPI::TEST):

9:28 PM Changeset in webkit [223121] by fpizlo@apple.com

• 6 edits
  2 adds in trunk/Source/bmalloc

Use one virtual allocation for all gigacages and their runways
​https://bugs.webkit.org/show_bug.cgi?id=178050

Reviewed by Saam Barati.

• bmalloc/Gigacage.cpp:

(Gigacage::ensureGigacage):
(Gigacage::runway): Deleted.
(Gigacage::totalSize): Deleted.

• bmalloc/Gigacage.h:

9:12 PM Changeset in webkit [223120] by jmarcell@apple.com

• 3 edits in branches/safari-604-branch/Source/WebCore

Cherry-pick r221430. rdar://problem/34770998

9:12 PM Changeset in webkit [223119] by jmarcell@apple.com

• 2 edits in branches/safari-604-branch/Source/WebCore

Cherry-pick r222995. rdar://problem/34891302

9:10 PM Changeset in webkit [223118] by Chris Dumez

• 5 edits in trunk

Calling fileSystemDirectoryEntry.getDirectory() with empty path should not fail
​https://bugs.webkit.org/show_bug.cgi?id=178114

Reviewed by Ryosuke Niwa.

Source/WebCore:

Calling fileSystemDirectoryEntry.getDirectory() with empty/null/undefined path should not fail as per:

• ​https://wicg.github.io/entries-api/#dom-filesystemdirectoryentry-getdirectory

The empty string is a valid path as per:

• ​https://wicg.github.io/entries-api/#valid-path

This aligns out behavior with Chrome.

No new tests, updated existing test.

• Modules/entriesapi/DOMFileSystem.cpp:

(WebCore::isValidVirtualPath):
(WebCore::resolveRelativeVirtualPath):

LayoutTests:

Extend layout test coverage.

• editing/pasteboard/entries-api/datatransfer-items-drop-getDirectory-expected.txt:
• editing/pasteboard/entries-api/datatransfer-items-drop-getDirectory.html:

8:19 PM Changeset in webkit [223117] by Chris Dumez

• 5 edits in trunk

It should not be possible to submit a form that is disconnected
​https://bugs.webkit.org/show_bug.cgi?id=178099

Reviewed by Sam Weinig.

LayoutTests/imported/w3c:

Rebaseline several WPT tests now that more checks are passing.

• web-platform-tests/dom/events/Event-dispatch-click-expected.txt:
• web-platform-tests/html/semantics/forms/the-button-element/button-click-submits-expected.txt:

Source/WebCore:

It should not be possible to submit a form that is disconnected. Both Firefox and Chrome agree with the specification.

This is as per:
​https://html.spec.whatwg.org/multipage/form-control-infrastructure.html#form-submission-algorithm (step 1)
which refers to:
​https://html.spec.whatwg.org/multipage/links.html#cannot-navigate

Form cannot navigate when it is disconnected.

No new tests, rebaselined existing tests.

• html/HTMLFormElement.cpp:

(WebCore::HTMLFormElement::prepareForSubmission):

7:48 PM Changeset in webkit [223116] by fpizlo@apple.com

• 2 edits in trunk/Source/JavaScriptCore

JSCell::didBecomePrototype is racy
​https://bugs.webkit.org/show_bug.cgi?id=178110

Reviewed by Saam Barati.

The indexing type can be modified by any thread using CAS. So, we need to use atomics when
modifying it. We don't need to use atomics when reading it though (since it's just one field).

• runtime/JSCellInlines.h:

(JSC::JSCell::didBecomePrototype):

7:14 PM Changeset in webkit [223115] by Ryan Haddad

• 3 edits in trunk/LayoutTests

Mark http/tests/paymentrequest/payment-request-abort-method.https.html as flaky.
​https://bugs.webkit.org/show_bug.cgi?id=178107

Unreviewed test gardening.

• platform/ios-wk2/TestExpectations:
• platform/mac-wk2/TestExpectations:

7:05 PM Changeset in webkit [223114] by Ryan Haddad

• 2 edits
  2 deletes in trunk/LayoutTests

Rebaseline imported/w3c/web-platform-tests/dom/events/EventTarget-dispatchEvent.html for iOS.

Unreviewed test gardening.

• platform/ios-simulator-wk2/imported/w3c/web-platform-tests/dom/events/EventTarget-dispatchEvent-expected.txt: Removed.
• platform/ios-wk2/imported/w3c/web-platform-tests/dom/events/EventTarget-dispatchEvent-expected.txt: Removed.
• platform/ios/imported/w3c/web-platform-tests/dom/events/EventTarget-dispatchEvent-expected.txt:

6:40 PM Changeset in webkit [223113] by fpizlo@apple.com

• 21 edits
  4 adds in trunk

Enable gigacage on iOS
​https://bugs.webkit.org/show_bug.cgi?id=177586

Reviewed by JF Bastien.
JSTests:

Add tests for when Gigacage gets runtime disabled.

• stress/disable-gigacage-arrays.js: Added.

(foo):

• stress/disable-gigacage-strings.js: Added.

(foo):

• stress/disable-gigacage-typed-arrays.js: Added.

(foo):

Source/bmalloc:

Introduce the ability to disable gigacage at runtime if allocation fails. If any step of gigacage
allocation fails, we free all of the gigacages and turn off gigacage support.

Reland this after confirming that the 20% Kraken regression was a one-bot fluke. Local testing on the
same kind of system did not show the regression. Saam and I both tried independently.

• CMakeLists.txt:
• bmalloc.xcodeproj/project.pbxproj:
• bmalloc/Cache.cpp:

(bmalloc::Cache::scavenge):

• bmalloc/Cache.h:

(bmalloc::Cache::tryAllocate):
(bmalloc::Cache::allocate):
(bmalloc::Cache::deallocate):
(bmalloc::Cache::reallocate):

• bmalloc/Gigacage.cpp:

(Gigacage::ensureGigacage):
(Gigacage::runway):
(Gigacage::totalSize):
(Gigacage::shouldBeEnabled):
(): Deleted.
(Gigacage::Callback::Callback): Deleted.
(Gigacage::Callback::function): Deleted.
(Gigacage::PrimitiveDisableCallbacks::PrimitiveDisableCallbacks): Deleted.

• bmalloc/Gigacage.h:

(Gigacage::wasEnabled):
(Gigacage::isEnabled):
(Gigacage::runway): Deleted.
(Gigacage::totalSize): Deleted.

• bmalloc/HeapKind.cpp: Added.

(bmalloc::isActiveHeapKind):
(bmalloc::mapToActiveHeapKind):

• bmalloc/HeapKind.h:

(bmalloc::isActiveHeapKindAfterEnsuringGigacage):
(bmalloc::mapToActiveHeapKindAfterEnsuringGigacage):

• bmalloc/Scavenger.cpp:

(bmalloc::Scavenger::scavenge):

• bmalloc/bmalloc.h:

(bmalloc::api::tryLargeMemalignVirtual):
(bmalloc::api::freeLargeVirtual):
(bmalloc::api::isEnabled):

Source/JavaScriptCore:

The hardest part of enabling Gigacage on iOS is that it requires loading global variables while
executing JS, so the LLInt needs to know how to load from global variables on all platforms that
have Gigacage. So, this teaches ARM64 how to load from global variables.

Also, this makes the code handle disabling the gigacage a bit better.

• ftl/FTLLowerDFGToB3.cpp:

(JSC::FTL::DFG::LowerDFGToB3::caged):

• jit/AssemblyHelpers.h:

(JSC::AssemblyHelpers::cage):
(JSC::AssemblyHelpers::cageConditionally):

• offlineasm/arm64.rb:
• offlineasm/asm.rb:
• offlineasm/instructions.rb:

Tools:

Add a mode to test disabling Gigacage.

• Scripts/run-jsc-stress-tests:
• Scripts/webkitruby/jsc-stress-test-writer-default.rb:

6:30 PM Changeset in webkit [223112] by rmorisset@apple.com

• 2 edits in trunk/Source/JavaScriptCore

Evaluate the benefit of skipping dead code in the DFGByteCodeParser when a function returns in its first block
​https://bugs.webkit.org/show_bug.cgi?id=177925

Reviewed by Saam Barati.

We used to do a rather weird "optimisation" in the bytecode parser: when a function would return in its first block,
the rest of the function was skipped. Since it has no actual impact on any benchmarks from what I could see, I removed
that code. It allows some changes to parseBlock(), since it now returns void and no-longer bool (it was returning a boolean that said whether that case happened or not).

• dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::parseBlock):
(JSC::DFG::ByteCodeParser::parseCodeBlock):

6:20 PM Changeset in webkit [223111] by timothy_horton@apple.com

• 2 edits in trunk/Source/WTF

Disable INPUT_TYPE_COLOR in FeatureDefines.h
​https://bugs.webkit.org/show_bug.cgi?id=178103
<rdar://problem/34872127>

Reviewed by Simon Fraser.

• wtf/FeatureDefines.h:

Because FeatureDefines.h overrides features that are not enabled in
FeatureDefines.xcconfig, you currently have to turn INPUT_TYPE_COLOR
off in two places. Since we only ever want it on for Mac, it's OK
to depend on the xcconfig defining it.

6:15 PM Changeset in webkit [223110] by mmaxfield@apple.com

• 6 edits
  3 adds in trunk

Delete button doesn't fully delete certain emoji
​https://bugs.webkit.org/show_bug.cgi?id=178096
<rdar://problem/34785106>

Reviewed by Simon Fraser.

Source/WebCore:

System infrastructure for handling emoji changes every year. Instead of having
custom code to specifically walk over codepoints, we should delegate to the
system handling.

Test: editing/deleting/delete-emoji.html

• rendering/RenderText.cpp:

(WebCore::RenderText::previousOffset const):
(WebCore::RenderText::previousOffsetForBackwardDeletion const):
(WebCore::RenderText::nextOffset const):
(WebCore::isHangulLVT): Deleted.
(WebCore::isMark): Deleted.
(WebCore::isRegionalIndicator): Deleted.
(WebCore::isInArmenianToLimbuRange): Deleted.

LayoutTests:

• editing/deleting/delete-emoji-2.html:
• platform/mac/editing/deleting/delete-emoji-expected.txt:
• platform/mac/editing/deleting/delete-emoji-2-expected.txt:
• platform/ios/editing/deleting/delete-emoji-expected.txt:
• platform/ios/editing/deleting/delete-emoji-2-expected.txt:
• platform/win/TestExpectations:

5:19 PM Changeset in webkit [223109] by aestes@apple.com

• 1 edit in trunk/Source/WebCore/testing/Internals.cpp

Fix two test crashes caused by r223076.

• testing/Internals.cpp:

(WebCore::Internals::Internals):

5:08 PM Changeset in webkit [223108] by jmarcell@apple.com

• 2 edits in branches/safari-604-branch/Source/WebCore

Cherry-pick r222786. rdar://problem/34820881

5:08 PM Changeset in webkit [223107] by jmarcell@apple.com

• 6 edits in branches/safari-604-branch

Cherry-pick r222779. rdar://problem/34820881

5:08 PM Changeset in webkit [223106] by jmarcell@apple.com

• 20 edits
  2 adds in branches/safari-604-branch

Cherry-pick r220412. rdar://problem/34771061

5:08 PM Changeset in webkit [223105] by jmarcell@apple.com

• 8 edits
  3 adds in branches/safari-604-branch

Cherry-pick r221098. rdar://problem/34771028

5:08 PM Changeset in webkit [223104] by jmarcell@apple.com

• 12 edits in branches/safari-604-branch/Source/WebCore

Cherry-pick r221046. rdar://problem/34891067

5:08 PM Changeset in webkit [223103] by jmarcell@apple.com

• 7 edits
  10 adds in branches/safari-604-branch

Cherry-pick r222402. rdar://problem/34770839

5:08 PM Changeset in webkit [223102] by jmarcell@apple.com

• 2 edits in branches/safari-604-branch/Source/JavaScriptCore

Cherry-pick r222748. rdar://problem/34820919

5:08 PM Changeset in webkit [223101] by jmarcell@apple.com

• 2 edits in branches/safari-604-branch/Source/WebCore

Apply patch. rdar://problem/34770842

Cherry-pick r221083. rdar://problem/34770842, rdar://problem/34770849

5:08 PM Changeset in webkit [223100] by jmarcell@apple.com

• 3 edits
  1 add in branches/safari-604-branch

Cherry-pick r222598. rdar://problem/34771434

5:08 PM Changeset in webkit [223099] by jmarcell@apple.com

• 14 edits in branches/safari-604-branch

Cherry-pick r222190. rdar://problem/34771470

5:08 PM Changeset in webkit [223098] by jmarcell@apple.com

• 3 edits in branches/safari-604-branch/Source/WebCore

Cherry-pick r221100. rdar://problem/34771028

5:08 PM Changeset in webkit [223097] by jmarcell@apple.com

• 2 edits in branches/safari-604-branch/Source/WebKit

Cherry-pick r221036. rdar://problem/34771044

5:08 PM Changeset in webkit [223096] by jmarcell@apple.com

• 4 edits
  2 adds in branches/safari-604-branch

Cherry-pick r221016. rdar://problem/34770830

5:08 PM Changeset in webkit [223095] by jmarcell@apple.com

• 3 edits
  2 deletes in branches/safari-604-branch

Cherry-pick r220484. rdar://problem/34770810

5:07 PM Changeset in webkit [223094] by jmarcell@apple.com

• 14 edits
  2 adds in branches/safari-604-branch

Cherry-pick r220302. rdar://problem/34770803

5:07 PM Changeset in webkit [223093] by jmarcell@apple.com

• 3 edits
  2 adds in branches/safari-604-branch

Cherry-pick r221400. rdar://problem/34771396

5:07 PM Changeset in webkit [223092] by jmarcell@apple.com

• 4 edits
  2 adds in branches/safari-604-branch

Cherry-pick r221128. rdar://problem/34771005

5:07 PM Changeset in webkit [223091] by commit-queue@webkit.org

• 13 edits in trunk/Source/WebCore

Image data should be coalesced if it comes in small chunks before updating the ImageSource
​https://bugs.webkit.org/show_bug.cgi?id=175890

Patch by Said Abou-Hallawa <​sabouhallawa@apple.com> on 2017-10-09
Reviewed by Simon Fraser.

Coalesce the updates, which an Image makes when receiving encoded data in
small chunks, for all platforms. Ensure the clients of the CachedImage
won't be notified unless an update in the ImageSource happens.

I need to change some functions' names to better implement this patch.
The names of these functions have been confusing:

CachedImage::addData(SharedBuffer&)
CachedImage::addDataBuffer(const char* data, unsigned)
CachedImage::addIncrementalDataBuffer(SharedBuffer&)

The image data is not buffered incrementally into the CachedImage. When
new data is received, SubresourceLoader calls CachedImage to "update" its
m_data with either a SharedBuffer or a data pointer. In either case the
SharedBuffer or the pointer contains all the loaded data. SubresourceLoader
calls CachedImage to update its m_data, to ensure its m_image is created
and to notify its clients with the new data.

The verb "add" in the functions' name is misleading. I am suggesting the
following names instead:

CachedImage::updateBuffer(SharedBuffer&)
CachedImage::updateData(const char*, unsigned)
CachedImage::doUpdateBuffer(SharedBuffer&)

The first two are the virtual ones. They are called form SubresourceLoader.
The third one is the internal implementation to update the m_data member.
The same names will be used in the following classes:

CachedResource which is the base class of CachedImage
CachedRawResource which is derived from CachedResource
CachedTextTrack which is derived from CachedResource

• html/ImageDocument.cpp:

(WebCore::ImageDocument::updateDuringParsing):

• loader/SubresourceLoader.cpp:

(WebCore::SubresourceLoader::didReceiveDataOrBuffer):

• loader/cache/CachedImage.cpp:

(WebCore::CachedImage::clearImage): Reset the update back off members.
(WebCore::CachedImage::doUpdateBuffer): Don't update CachedImage with
the new data if it comes in small chunks with fast rate.
(WebCore::CachedImage::shouldDeferUpdateImageData const): This code is moved
from ImageSource::dataChanged().
(WebCore::CachedImage::didUpdateImageData): Ditto.
(WebCore::CachedImage::updateImageData):
(WebCore::CachedImage::updateBuffer):
(WebCore::CachedImage::updateData):
(WebCore::CachedImage::finishLoading):
(WebCore::CachedImage::addIncrementalDataBuffer): Deleted.
(WebCore::CachedImage::setImageDataBuffer): Deleted.
(WebCore::CachedImage::addDataBuffer): Deleted.
(WebCore::CachedImage::addData): Deleted.

• loader/cache/CachedImage.h:
• loader/cache/CachedRawResource.cpp:

(WebCore::CachedRawResource::updateBuffer):
(WebCore::CachedRawResource::updateData):
(WebCore::CachedRawResource::addDataBuffer): Deleted.
(WebCore::CachedRawResource::addData): Deleted.

• loader/cache/CachedRawResource.h:
• loader/cache/CachedResource.cpp:

(WebCore::CachedResource::updateBuffer):
(WebCore::CachedResource::updateData):
(WebCore::CachedResource::addDataBuffer): Deleted.
(WebCore::CachedResource::addData): Deleted.

• loader/cache/CachedResource.h:
• loader/cache/CachedTextTrack.cpp:

(WebCore::CachedTextTrack::doUpdateBuffer): Rename updateData() to doUpdateBuffer().
(WebCore::CachedTextTrack::updateBuffer): Rename addDataBuffer() to updateBuffer().
(WebCore::CachedTextTrack::finishLoading): Call the internal function doUpdateBuffer().
(WebCore::CachedTextTrack::updateData): Deleted.
(WebCore::CachedTextTrack::addDataBuffer): Deleted.

• loader/cache/CachedTextTrack.h:
• platform/graphics/ImageSource.cpp:

(WebCore::ImageSource::dataChanged): Move the update back off code to CachedImage::updateData().

• platform/graphics/ImageSource.h:

5:07 PM Changeset in webkit [223090] by jmarcell@apple.com

• 2 edits in branches/safari-604-branch/Source/WebCore

Cherry-pick r221116. rdar://problem/34771068

5:07 PM Changeset in webkit [223089] by jmarcell@apple.com

• 19 edits in branches/safari-604-branch

Cherry-pick r220718. rdar://problem/34771041

5:07 PM Changeset in webkit [223088] by jmarcell@apple.com

• 6 edits in branches/safari-604-branch/Source

Cherry-pick r220496. rdar://problem/34770816

5:05 PM Changeset in webkit [223087] by Chris Dumez

• 3 edits in trunk/LayoutTests/imported/w3c

usemap-casing.html test passes in browser, fails in LayoutTests because it is taller than 600px
​https://bugs.webkit.org/show_bug.cgi?id=178053

Reviewed by Youenn Fablet.

Re-sync html/semantics/embedded-content/the-img-element/usemap-casing.html after:

• ​https://github.com/w3c/web-platform-tests/commit/881052cae58edb7a79157e99c80c5c70253ec976

• web-platform-tests/html/semantics/embedded-content/the-img-element/usemap-casing-expected.txt:
• web-platform-tests/html/semantics/embedded-content/the-img-element/usemap-casing.html:

4:55 PM Changeset in webkit [223086] by rmorisset@apple.com

• 6 edits in trunk/Source/JavaScriptCore

Refactor the inliner to simplify block linking
​https://bugs.webkit.org/show_bug.cgi?id=177922

Reviewed by Saam Barati.

The biggest refactor changes the way blocks are linked. In DFGByteCodeParser, most terminals (such as Jump or Branch) jump to nullptr initially, and have
some metadata indicating the bytecode index corresponding to their targets. They are later linked to the right basic block using two fields of InlineStackEntry:

• m_unlinkedBlocks is just a worklist of blocks with a terminal that needs to be linked
• m_linkingTargets is a dictionary from bytecode indices to BasicBlock*

Before refactoring, every block was automatically added to both of these fields, for the InlineStackEntry of whatever function allocated it.
This created a significant number of corner cases, such as blocks allocated in a caller, with a terminal written by an inlined callee and pointing to a block in the callee,
or blocks allocated in an inline callee, with a terminal written by the caller after it returns and pointing to a block in the caller, or blocks with a manually linked
terminal that needs to be taken off m_unlinkedBlocks.
I changed things so that blocks are only added to m_unlinkedBlocks when their terminal gets written (see the LAST_OPCODE macro) making it a lot easier to be in the "right" InlineStackEntry,
that is the one that holds their target in its m_linkingTargets field.

There are a few much smaller refactors in this patch:

• parse() is now of type void insted of bool (it was always returning true)
• The 7 and 8 arguments of handleCall were inlined in its 3 arguments version for readability
• The 9 argument version was cleaned up and simplified
• I made separate allocateBlock routines because the little dance with adoptRef(* new BasicBlock(...)) was being repeated in lots of places, and typos in that were a major source of bugs during other refactorings
• Jumps are now created with explicit addJumpTo() functions, providing some sanity checking through asserts and didLink()
• Blocks are only added to m_unlinkedBlocks if they end in a terminal that linkBlock works with (see LAST_OPCODE)

• dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::addToGraph):
(JSC::DFG::ByteCodeParser::handleCall):
(JSC::DFG::ByteCodeParser::refineStatically):
(JSC::DFG::ByteCodeParser::handleRecursiveTailCall):
(JSC::DFG::ByteCodeParser::handleVarargsCall):
(JSC::DFG::ByteCodeParser::inlineCall):
(JSC::DFG::ByteCodeParser::attemptToInlineCall):
(JSC::DFG::ByteCodeParser::handleInlining):
(JSC::DFG::ByteCodeParser::handleIntrinsicCall):
(JSC::DFG::ByteCodeParser::handleConstantInternalFunction):
(JSC::DFG::ByteCodeParser::parseBlock):
(JSC::DFG::ByteCodeParser::parseCodeBlock):
(JSC::DFG::ByteCodeParser::parse):
(JSC::DFG::parse):
(JSC::DFG::ByteCodeParser::cancelLinkingForBlock): Deleted.

• dfg/DFGByteCodeParser.h:
• dfg/DFGPlan.cpp:

(JSC::DFG::Plan::compileInThreadImpl):

4:45 PM Changeset in webkit [223085] by jmarcell@apple.com

• 1 copy in tags/Safari-604.3.5.0.1

Tag Safari-604.3.5.0.1.

4:35 PM Changeset in webkit [223084] by jmarcell@apple.com

• 13 edits
  1 add in branches/safari-604.3.5.0-branch

Apply patch. rdar://problem/34857459

Apply patch. rdar://problem/34857459

4:27 PM Changeset in webkit [223083] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebKit

Fix typo of virtual keyword in PageClientImplIOS.h
​https://bugs.webkit.org/show_bug.cgi?id=178088

Patch by Jeremy Jones <​jeremyj@apple.com> on 2017-10-09
Reviewed by Simon Fraser.

This compile error happens when FULLSCREEN_API is enabled for iOS.
Remove the redundant virtual keyword since function is marked override.

• UIProcess/ios/PageClientImplIOS.h:

4:27 PM Changeset in webkit [223082] by Chris Dumez

• 2 edits in trunk/Source/WebKit

[iOS][WK2] Tiles outsides the viewport are sometimes missing after relaunching a crashes WebProcess
​https://bugs.webkit.org/show_bug.cgi?id=178095
<rdar://problem/34415016>

Reviewed by Simon Fraser.

Make sure we reset WKWebView._hasScheduledVisibleRectUpdate to NO in WKWebView._processDidExit.
_scheduleVisibleContentRectUpdateAfterScrollInView would otherwise return early because
WKWebView._hasScheduledVisibleRectUpdate is always YES. Normally,
_addUpdateVisibleContentRectPreCommitHandler sets a CATransaction commit handler that
resets _hasScheduledVisibleRectUpdate to NO, but it does not do so when ![webView _isValid]
(which is true when the WebProcess has crashed.

Also reset WKWebView._commitDidRestoreScrollPosition to NO in WKWebView._processDidExit even
though it does not seem to be the cause of this bug. It seems to make sense to reset this member
when the process crashes.

• UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _processDidExit]):

4:14 PM Changeset in webkit [223081] by msaboff@apple.com

• 15 edits
  17 adds in trunk

Implement RegExp Unicode property escapes
​https://bugs.webkit.org/show_bug.cgi?id=172069

Reviewed by JF Bastien.

JSTests:

Enabled Unicode Property tests.

• test262.yaml:

Source/JavaScriptCore:

Added Unicode Properties by extending the existing CharacterClass processing.

Introduced a new Python script, generateYarrUnicodePropertyTables.py, that parses
Unicode Database files to create character class data. The result is a set of functions
that return character classes, one for each of the required Unicode properties.
There are many cases where many properties are handled by one function, primarily due to
property aliases, but also due to Script_Extension properties that are the same as the
Script property for the same script value.

Extended the BuiltInCharacterClassID enum so it can be used also for Unicode property
character classes. Unicode properties are the enum value BaseUnicodePropertyID plus a
zero based value, that value being the index to the corrensponding character class
function. The generation script also creates static hashing tables similar to what we
use for the generated .lut.h lookup table files. These hashing tables map property
names to the function index. Using these hashing tables, we can lookup a property
name and if present convert it to a function index. We add that index to
BaseUnicodePropertyID to create a BuiltInCharacterClassID.

When we do syntax parsing, we convert the property to its corresponding BuiltInCharacterClassID.
When doing real parsing we takes the returned BuiltInCharacterClassID and use it to get
the actual character class by calling the corresponding generated function.

Added a new CharacterClass constructor that can take literal arrays for ranges and matches
to make the creation of large static character classes more efficent.

Since the Unicode character classes typically have more matches and ranges, the character
class matching in the interpreter has been updated to use binary searching for matches and
ranges with more than 6 entries.

• CMakeLists.txt:
• DerivedSources.make:
• JavaScriptCore.xcodeproj/project.pbxproj:
• Scripts/generateYarrUnicodePropertyTables.py: Added.

(openOrExit):
(openUCDFileOrExit):
(verifyUCDFilesExist):
(ceilingToPowerOf2):
(Aliases):
(Aliases.init):
(Aliases.parsePropertyAliasesFile):
(Aliases.parsePropertyValueAliasesFile):
(Aliases.globalAliasesFor):
(Aliases.generalCategoryAliasesFor):
(Aliases.generalCategoryForAlias):
(Aliases.scriptAliasesFor):
(Aliases.scriptNameForAlias):
(PropertyData):
(PropertyData.init):
(PropertyData.setAliases):
(PropertyData.makeCopy):
(PropertyData.getIndex):
(PropertyData.getCreateFuncName):
(PropertyData.addMatch):
(PropertyData.addRange):
(PropertyData.addMatchUnorderedForMatchesAndRanges):
(PropertyData.addRangeUnorderedForMatchesAndRanges):
(PropertyData.addMatchUnordered):
(PropertyData.addRangeUnordered):
(PropertyData.removeMatchFromRanges):
(PropertyData.removeMatch):
(PropertyData.dumpMatchData):
(PropertyData.dump):
(PropertyData.dumpAll):
(PropertyData.dumpAll.std):
(PropertyData.createAndDumpHashTable):
(Scripts):
(Scripts.init):
(Scripts.parseScriptsFile):
(Scripts.parseScriptExtensionsFile):
(Scripts.dump):
(GeneralCategory):
(GeneralCategory.init):
(GeneralCategory.createSpecialPropertyData):
(GeneralCategory.findPropertyGroupFor):
(GeneralCategory.addNextCodePoints):
(GeneralCategory.parse):
(GeneralCategory.dump):
(BinaryProperty):
(BinaryProperty.init):
(BinaryProperty.parsePropertyFile):
(BinaryProperty.dump):

• Scripts/hasher.py: Added.

(stringHash):

• Sources.txt:
• ucd/DerivedBinaryProperties.txt: Added.
• ucd/DerivedCoreProperties.txt: Added.
• ucd/DerivedNormalizationProps.txt: Added.
• ucd/PropList.txt: Added.
• ucd/PropertyAliases.txt: Added.
• ucd/PropertyValueAliases.txt: Added.
• ucd/ScriptExtensions.txt: Added.
• ucd/Scripts.txt: Added.
• ucd/UnicodeData.txt: Added.
• ucd/emoji-data.txt: Added.
• yarr/Yarr.h:
• yarr/YarrInterpreter.cpp:

(JSC::Yarr::Interpreter::testCharacterClass):

• yarr/YarrParser.h:

(JSC::Yarr::Parser::parseEscape):
(JSC::Yarr::Parser::parseTokens):
(JSC::Yarr::Parser::isUnicodePropertyValueExpressionChar):
(JSC::Yarr::Parser::tryConsumeUnicodePropertyExpression):

• yarr/YarrPattern.cpp:

(JSC::Yarr::CharacterClassConstructor::appendInverted):
(JSC::Yarr::YarrPatternConstructor::atomBuiltInCharacterClass):
(JSC::Yarr::YarrPatternConstructor::atomCharacterClassBuiltIn):
(JSC::Yarr::YarrPattern::errorMessage):
(JSC::Yarr::PatternTerm::dump):

• yarr/YarrPattern.h:

(JSC::Yarr::CharacterRange::CharacterRange):
(JSC::Yarr::CharacterClass::CharacterClass):
(JSC::Yarr::YarrPattern::reset):
(JSC::Yarr::YarrPattern::unicodeCharacterClassFor):

• yarr/YarrUnicodeProperties.cpp: Added.

(JSC::Yarr::HashTable::entry const):
(JSC::Yarr::unicodeMatchPropertyValue):
(JSC::Yarr::unicodeMatchProperty):
(JSC::Yarr::createUnicodeCharacterClassFor):

• yarr/YarrUnicodeProperties.h: Added.

Source/WebCore:

Refactoring change - Added BuiltInCharacterClassID:: prefix to uses of the enum.

• contentextensions/URLFilterParser.cpp:

(WebCore::ContentExtensions::PatternParser::atomBuiltInCharacterClass):

LayoutTests:

New test.

• js/regexp-unicode-properties-expected.txt: Added.
• js/regexp-unicode-properties.html: Added.
• js/script-tests/regexp-unicode-properties.js: Added.

3:58 PM Changeset in webkit [223080] by jmarcell@apple.com

• 7 edits in branches/safari-604.3.5.0-branch/Source

Versioning.

3:49 PM Changeset in webkit [223079] by dino@apple.com

• 4 edits in trunk/LayoutTests/imported/w3c

ImageBitmap test gardening after ​https://bugs.webkit.org/show_bug.cgi?id=177963

• web-platform-tests/imagebitmap-renderingcontext/bitmaprenderer-as-imagesource-expected.txt:
• web-platform-tests/imagebitmap-renderingcontext/context-creation-expected.txt:
• web-platform-tests/imagebitmap-renderingcontext/context-preserves-canvas-expected.txt:

3:47 PM Changeset in webkit [223078] by commit-queue@webkit.org

• 3 edits in trunk/Source/WebInspectorUI

Web Inspector: Network Tab - Include remote address in the Headers view
​https://bugs.webkit.org/show_bug.cgi?id=178094
<rdar://problem/34895221>

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2017-10-09
Reviewed by Devin Rousso.

• Localizations/en.lproj/localizedStrings.js:
• UserInterface/Views/ResourceHeadersContentView.js:

(WI.ResourceHeadersContentView.prototype._refreshSummarySection):
(WI.ResourceHeadersContentView.prototype._resourceMetricsDidChange):

3:44 PM Changeset in webkit [223077] by jmarcell@apple.com

• 7 edits in branches/safari-604.3.5.1-branch/Source

Versioning.

3:40 PM Changeset in webkit [223076] by aestes@apple.com

• 19 edits
  3 copies
  5 adds
  2 deletes in trunk

[Payment Request] Implement PaymentRequest.show() and PaymentRequest.hide()
​https://bugs.webkit.org/show_bug.cgi?id=178043
<rdar://problem/34076639>

Reviewed by Tim Horton.

LayoutTests/imported/w3c:

• web-platform-tests/payment-request/payment-request-abort-method.https-expected.txt: Removed.
• web-platform-tests/payment-request/payment-request-show-method.https-expected.txt: Removed.

Source/WebCore:

Tests: http/tests/paymentrequest/payment-request-abort-method.https.html

http/tests/paymentrequest/payment-request-show-method.https.html

• Modules/applepay/PaymentCoordinator.h:
• Modules/applepay/PaymentSession.h: Virtually inherited from PaymentSessionBase to

accommodate ApplePayPaymentHandler inheriting from both this and PaymentHandler.
(WebCore::PaymentSession::~PaymentSession): Deleted.

• Modules/applepay/paymentrequest/ApplePayPaymentHandler.cpp:

(WebCore::paymentCoordinator): Virtually inherited from PaymentSessionBase to accommodate
ApplePayPaymentHandler inheriting from both this and PaymentSession.
(WebCore::ApplePayPaymentHandler::hasActiveSession): Added. Calls PaymentCoordinator::hasActiveSession().
(WebCore::ApplePayPaymentHandler::show): Added. Calls PaymentCoordinator::beginPaymentSession().
(WebCore::ApplePayPaymentHandler::hide): Added. Calls PaymentCoordinator::abortPaymentSession().

• Modules/applepay/paymentrequest/ApplePayPaymentHandler.h: Inherited from PaymentSession in

addition to PaymentHandler so that this can be PaymentCoordinator active session.

• Modules/paymentrequest/PaymentHandler.cpp:

(WebCore::PaymentHandler::create):
(WebCore::PaymentHandler::hasActiveSession):

• Modules/paymentrequest/PaymentHandler.h:
• Modules/paymentrequest/PaymentRequest.cpp:

(WebCore::PaymentRequest::~PaymentRequest):
(WebCore::PaymentRequest::show): Rejected the promise if PaymentCoordinator has an active session.
(WebCore::PaymentRequest::abort): Called stop().
(WebCore::PaymentRequest::canSuspendForDocumentSuspension const): Returned true if state is
Interactive and there is an active handler showing.
(WebCore::PaymentRequest::stop): Hid the active session if it's showing, then set state to
Closed and rejected the show promise.

• Modules/paymentrequest/PaymentRequest.h:
• Modules/paymentrequest/PaymentSessionBase.h: Added. Inherits from

RefCounted<PaymentSessionBase> and defines a virtual destructor. This allows subclasses to
virtually inherit a single ref-count to support multiple inheritance.

• WebCore.xcodeproj/project.pbxproj:
• bindings/scripts/CodeGeneratorJS.pm:

(GetGnuVTableOffsetForType): Added ApplePaySession to the list of classes that need a vtable
offset of 3.

• page/MainFrame.cpp:

(WebCore::MainFrame::setPaymentCoordinator): Added a setter for m_paymentCoordinator.

• page/MainFrame.h:
• testing/Internals.cpp:

(WebCore::Internals::Internals): Set the main frame's payment coordinator to a new
PaymentCoordinator with MockPaymentCoordinator as its client.

• testing/MockPaymentCoordinator.cpp: Added a mock PaymentCoordinatorClient for testing.

(WebCore::MockPaymentCoordinator::supportsVersion):
(WebCore::MockPaymentCoordinator::canMakePayments):
(WebCore::MockPaymentCoordinator::canMakePaymentsWithActiveCard):
(WebCore::MockPaymentCoordinator::openPaymentSetup):
(WebCore::MockPaymentCoordinator::showPaymentUI):
(WebCore::MockPaymentCoordinator::paymentCoordinatorDestroyed):

• testing/MockPaymentCoordinator.h: Added.

LayoutTests:

Copied payment-request-abort-method.https.html and payment-request-show-method.https.html
from web-platform-tests/payment-request/ and changed the payment method from basic-card to
Apple Pay. This needs to eventually be upstreamed back to WPT.

• TestExpectations:
• http/tests/paymentrequest/payment-request-abort-method.https-expected.txt: Added.
• http/tests/paymentrequest/payment-request-abort-method.https.html: Added.
• http/tests/paymentrequest/payment-request-show-method.https-expected.txt: Added.
• http/tests/paymentrequest/payment-request-show-method.https.html: Added.
• platform/ios-wk2/TestExpectations:
• platform/mac-wk2/TestExpectations:

3:30 PM Changeset in webkit [223075] by jmarcell@apple.com

• 1 copy in branches/safari-604.3.5.0-branch

New branch.

3:28 PM Changeset in webkit [223074] by jmarcell@apple.com

• 1 copy in branches/safari-604.3.5.1-branch

New branch.

3:17 PM Changeset in webkit [223073] by commit-queue@webkit.org

• 31 edits
  3 adds in trunk

Add quota to cache API
​https://bugs.webkit.org/show_bug.cgi?id=177552

Patch by Youenn Fablet <​youenn@apple.com> on 2017-10-09
Reviewed by Alex Christensen.

Source/WebCore:

Tests: http/wpt/cache-storage/cache-quota.any.html

Storing padded opaque response body sizes within FetchResponse and CacheStorageConnection.
See ​https://github.com/whatwg/storage/issues/31 for the rationale about this padding.
Storing in CacheStorageConnection is needed for handling cloned network fetched created responses.
Storing in FetchResponse is needed for handling cloned cache-storage created opaque responses.

Adding internals to query and set the fuzzed size of a response.

• Modules/cache/CacheStorageConnection.cpp:

(WebCore::computeRealBodySize):
(WebCore::CacheStorageConnection::computeRecordBodySize):
(WebCore::CacheStorageConnection::setResponseBodySizeWithPadding):
(WebCore::CacheStorageConnection::responseBodySizeWithPadding const):

• Modules/cache/CacheStorageConnection.h:
• Modules/cache/DOMCache.cpp:

(WebCore::DOMCache::toConnectionRecord):
(WebCore::DOMCache::updateRecords):

• Modules/cache/DOMCache.h:
• Modules/cache/DOMCacheEngine.cpp:

(WebCore::DOMCacheEngine::errorToException):
(WebCore::DOMCacheEngine::Record::copy const):

• Modules/cache/DOMCacheEngine.h:
• Modules/cache/WorkerCacheStorageConnection.cpp:

(WebCore::toCrossThreadRecordData):
(WebCore::fromCrossThreadRecordData):

• Modules/fetch/FetchResponse.cpp:

(WebCore::FetchResponse::clone):
(WebCore::FetchResponse::BodyLoader::didReceiveResponse):

• Modules/fetch/FetchResponse.h:
• Modules/fetch/FetchResponse.idl:
• testing/Internals.cpp:

(WebCore::Internals::setResponseSizeWithPadding):
(WebCore::Internals::responseSizeWithPadding const):

• testing/Internals.h:
• testing/Internals.idl:

Source/WebKit:

Adding support for quota checking in CacheStorage::Caches.
It is passed to NetworkProcess at creation time.
Default quota size is configured to 400Ko by origin per default.
This value is suitable for testing.
Future patch should raise this default value and allows configuring it.

Quota is computed based on the response body size.
This size is padded at WebCore for opaque responses.
Size is stored persistently as opaque response padded size should remain stable.
See ​https://github.com/whatwg/storage/issues/31 for the rationale about this padding.

In case of putting several records at the same time, the size of all records
is computed so that all records will be written or rejected together.

Sending QuotaExceeded error when quota is exceeded.
Future effort should allow asking UIProcess for quota extension.

• NetworkProcess/NetworkProcess.cpp:

(WebKit::NetworkProcess::cacheStoragePerOriginQuota const):

• NetworkProcess/NetworkProcess.h:
• NetworkProcess/NetworkProcessCreationParameters.cpp:

(WebKit::NetworkProcessCreationParameters::encode const):
(WebKit::NetworkProcessCreationParameters::decode):

• NetworkProcess/NetworkProcessCreationParameters.h:
• NetworkProcess/cache/CacheStorageEngine.cpp:

(WebKit::CacheStorage::Engine::readCachesFromDisk):

• NetworkProcess/cache/CacheStorageEngineCache.cpp:

(WebKit::CacheStorage::Cache::toRecordInformation):
(WebKit::CacheStorage::isolatedCopy):
(WebKit::CacheStorage::Cache::open):
(WebKit::CacheStorage::Cache::storeRecords):
(WebKit::CacheStorage::Cache::put):
(WebKit::CacheStorage::Cache::writeRecordToDisk):
(WebKit::CacheStorage::Cache::updateRecordToDisk):
(WebKit::CacheStorage::Cache::removeRecordFromDisk):
(WebKit::CacheStorage::Cache::encode):
(WebKit::CacheStorage::Cache::decodeRecordHeader):
(WebKit::CacheStorage::Cache::decode):

• NetworkProcess/cache/CacheStorageEngineCache.h:
• NetworkProcess/cache/CacheStorageEngineCaches.cpp:

(WebKit::CacheStorage::Caches::Caches):
(WebKit::CacheStorage::Caches::initialize):
(WebKit::CacheStorage::Caches::initializeSize):
(WebKit::CacheStorage::Caches::requestSpace):
(WebKit::CacheStorage::Caches::writeRecord):
(WebKit::CacheStorage::Caches::removeRecord):
(WebKit::CacheStorage::Caches::removeCacheEntry):

• NetworkProcess/cache/CacheStorageEngineCaches.h:

(WebKit::CacheStorage::Caches::create):
(WebKit::CacheStorage::Caches::hasEnoughSpace const):

• NetworkProcess/cache/NetworkCacheStorage.cpp:

(WebKit::NetworkCache::Storage::traverse):

• NetworkProcess/cocoa/NetworkProcessCocoa.mm:

(WebKit::NetworkProcess::platformInitializeNetworkProcessCocoa):

• Shared/WebCoreArgumentCoders.cpp:

(IPC::ArgumentCoder<DOMCacheEngine::Record>::encode):
(IPC::ArgumentCoder<DOMCacheEngine::Record>::decode):

• UIProcess/API/APIProcessPoolConfiguration.cpp:

(API::ProcessPoolConfiguration::copy):

• UIProcess/API/APIProcessPoolConfiguration.h:
• UIProcess/WebProcessPool.cpp:

(WebKit::WebProcessPool::ensureNetworkProcess):

LayoutTests:

• http/wpt/cache-storage/cache-quota.https.any-expected.txt: Added.
• http/wpt/cache-storage/cache-quota.https.any.html: Added.
• http/wpt/cache-storage/cache-quota.https.any.js: Added.

2:57 PM Changeset in webkit [223072] by Alan Bujtas

• 5 edits in trunk/Source/WebCore

Remove redundant RenderObject::virtualContinuation
​https://bugs.webkit.org/show_bug.cgi?id=178091
<rdar://problem/34892906>

Reviewed by Antti Koivisto.

virtualContinuation sounds like a feature of continuation, while it's just a (not super useful)helper override.

No change in functionality.

• rendering/RenderBlock.cpp:

(WebCore::canMergeContiguousAnonymousBlocks):
(WebCore::RenderBlock::takeChild):

• rendering/RenderBlock.h:
• rendering/RenderInline.h:
• rendering/RenderObject.h:

(WebCore::RenderObject::isBlockElementContinuation const):
(WebCore::RenderObject::virtualContinuation const): Deleted.

2:49 PM Changeset in webkit [223071] by Matt Lewis

• 2 edits in trunk/LayoutTests

Unskipped http/tests/cache/disk-cache/disk-cache-validation-no-body.html
​https://bugs.webkit.org/show_bug.cgi?id=178019

Unreviewed test gardening.

• platform/mac-wk2/TestExpectations:

2:17 PM Changeset in webkit [223070] by pvollan@apple.com

• 2 edits in trunk/Source/WebKitLegacy

[Win] Link error: cannot open input file 'WebKitLegacyGUID.lib'
​https://bugs.webkit.org/show_bug.cgi?id=178087

Reviewed by Alexey Proskuryakov.

For compatibility reasons, the library still has the name WebKitGUID.lib.

• PlatformWin.cmake:

2:17 PM Changeset in webkit [223069] by commit-queue@webkit.org

• 21 edits
  4 deletes in trunk

Unreviewed, rolling out r223015 and r223025.
​https://bugs.webkit.org/show_bug.cgi?id=178093

Regressed Kraken on iOS by 20% (Requested by keith_mi_ on
#webkit).

Reverted changesets:

"Enable gigacage on iOS"
​https://bugs.webkit.org/show_bug.cgi?id=177586
​http://trac.webkit.org/changeset/223015

"Unreviewed, disable Gigacage on ARM64 Linux"
​https://bugs.webkit.org/show_bug.cgi?id=177586
​http://trac.webkit.org/changeset/223025

1:57 PM Changeset in webkit [223068] by Joseph Pecoraro

• 2 edits in trunk/Source/WebInspectorUI

Unreviewed, minified WebInspector opens blank.
<rdar://problem/34892307>

• UserInterface/Views/ResourceHeadersContentView.js:

(WI.ResourceHeadersContentView.prototype._refreshRequestHeadersSection):
Regression introduced in r223006. The minified build has a SyntaxError
causing WebInspector top open blank. Add the missing semicolon.

1:46 PM Changeset in webkit [223067] by Ryan Haddad

• 2 edits in trunk/JSTests

Update expectations for test262 tests that pass after r223043.
​https://bugs.webkit.org/show_bug.cgi?id=176685

Unreviewed test gardening.

• test262.yaml:

1:45 PM Changeset in webkit [223066] by keith_miller@apple.com

• 2 edits in trunk/Source/JavaScriptCore

Unreviewed, sort unified sources again now that they are numbered numerically rather than lexicographically.

• JavaScriptCore.xcodeproj/project.pbxproj:

1:38 PM Changeset in webkit [223065] by Joseph Pecoraro

• 10 edits
  2 adds in trunk/Source/WebInspectorUI

Web Inspector: Network Tab - Filter resources based on URL / Text Content
​https://bugs.webkit.org/show_bug.cgi?id=178071
<rdar://problem/34071562>

Reviewed by Brian Burg.

• Localizations/en.lproj/localizedStrings.js:

New strings.

• UserInterface/Views/FilterBar.css:

(.filter-bar.active > input[type="search"]::-webkit-search-decoration):
(.filter-bar.indicating-progress > input[type="search"]::-webkit-search-decoration):
New icon for progress / active states.

• UserInterface/Views/FilterBar.js:

(WI.FilterBar.prototype.get inputField):
(WI.FilterBar.prototype.get placeholder):
(WI.FilterBar.prototype.set placeholder):
(WI.FilterBar.prototype.get incremental):
(WI.FilterBar.prototype.set incremental):
(WI.FilterBar.prototype.get indicatingProgress):
(WI.FilterBar.prototype.set indicatingProgress):
(WI.FilterBar.prototype.get indicatingActive):
(WI.FilterBar.prototype.set indicatingActive):
(WI.FilterBar.prototype._handleFilterInputEvent):
When incremental is set to false on the FilterBar still dispatch an
event when the textfield clears.

• UserInterface/Images/FilterFieldActiveGlyph.svg: Added.
• UserInterface/Images/gtk/FilterFieldActiveGlyph.svg: Added.

New blue icon for active state.

• UserInterface/Controllers/FrameResourceManager.js:

(WI.FrameResourceManager.prototype.resourceForIdentifier):
Accessor for arbitrary resource.

• UserInterface/Views/NetworkTableContentView.css:

(.content-view.network .navigation-bar .filter-bar):
(.content-view.network .warning-banner):
(body[dir=ltr] .content-view.network .warning-banner):
(body[dir=rtl] .content-view.network .warning-banner):
(.content-view.network .warning-banner > a):
Warning banner when the filter produces no results. This matches the
warning in the Debugger tab when breakpoints are disabled.

• UserInterface/Views/ScopeBar.js:

(WI.ScopeBar.prototype.resetToDefault):
Provide a way to easily reset a scope bar to the default item.

• UserInterface/Views/RadioButtonNavigationItem.css:

(.navigation-bar .item.radio.button.text-only:active):

• UserInterface/Views/ScopeBar.css:

(.scope-bar > li:active):
Cleanup some styles that should be using a variable.

• UserInterface/Views/NetworkTableContentView.js:

(WI.NetworkTableContentView):
(WI.NetworkTableContentView.prototype.get filterNavigationItems):
(WI.NetworkTableContentView.prototype.layout):
(WI.NetworkTableContentView.prototype._processPendingEntries):
(WI.NetworkTableContentView.prototype._checkTextFilterAgainstFinishedResource):
(WI.NetworkTableContentView.prototype._checkTextFilterAgainstFailedResource):
(WI.NetworkTableContentView.prototype._updateTextFilterActiveIndicator):
(WI.NetworkTableContentView.prototype._updateEmptyFilterResultsWarning):
(WI.NetworkTableContentView.prototype._showEmptyFilterResultsWarning):
(WI.NetworkTableContentView.prototype._hideEmptyFilterResultsWarning):
(WI.NetworkTableContentView.prototype._positionEmptyFilterMessage):
(WI.NetworkTableContentView.prototype._resourceLoadingDidFinish):
(WI.NetworkTableContentView.prototype._resourceLoadingDidFail):
(WI.NetworkTableContentView.prototype._networkTimelineRecordAdded):
(WI.NetworkTableContentView.prototype._insertResourceAndReloadTable):
(WI.NetworkTableContentView.prototype._hasTypeFilter):
(WI.NetworkTableContentView.prototype._hasTextFilter):
(WI.NetworkTableContentView.prototype._hasActiveFilter):
(WI.NetworkTableContentView.prototype._passTypeFilter):
(WI.NetworkTableContentView.prototype._passTextFilter):
(WI.NetworkTableContentView.prototype._passFilter):
(WI.NetworkTableContentView.prototype._updateFilteredEntries):
(WI.NetworkTableContentView.prototype._resetFilters):
(WI.NetworkTableContentView.prototype._textFilterDidChange):
(WI.NetworkTableContentView.prototype._tableNameColumnDidChangeWidth):
There are now two filters.

• FilterBar - Filters URL and Full Text Content
• ScopeBar - Filters Resource Type

The text content filter is asynchronous. We reuse the existing Search
functionality when filtering on text. We need to defer text content
filtering until the resource finishes loading.

1:23 PM Changeset in webkit [223064] by commit-queue@webkit.org

• 2 edits
  17 adds in trunk/LayoutTests/imported/w3c

REGRESSION: Some bots fail to run LayoutTests due to a WPT Server error
​https://bugs.webkit.org/show_bug.cgi?id=178017

Patch by Youenn Fablet <​youenn@apple.com> on 2017-10-09
Reviewed by Sam Weinig.

• resources/import-expectations.json:
• web-platform-tests/tools/six/: Added.

1:16 PM Changeset in webkit [223063] by dino@apple.com

• 2 edits in trunk/Source/WebCore

[WebGL] Third IOSurface buffer might be allocated with the wrong size
​https://bugs.webkit.org/show_bug.cgi?id=178092
<rdar://problem/34893173>

Reviewed by Jer Noble.

If the WebGL canvas resizes after the third buffer was allocated, it
was never getting told that its backing store should be thrown away.

• platform/graphics/cocoa/WebGLLayer.mm: Allocate the third buffer at

the same time as the first two.
(-[WebGLLayer allocateIOSurfaceBackingStoreWithSize:usingAlpha:]):
(-[WebGLLayer bindFramebufferToNextAvailableSurface]):

1:02 PM Changeset in webkit [223062] by Ryan Haddad

• 6 edits
  5 deletes in trunk

Unreviewed, rolling out r223022.

This change introduced 18 test262 failures.

Reverted changeset:

"async should be able to be used as an imported binding
name"
​https://bugs.webkit.org/show_bug.cgi?id=176573
​http://trac.webkit.org/changeset/223022

1:01 PM Changeset in webkit [223061] by commit-queue@webkit.org

• 10 edits in trunk

Make HashMap::keys() and HashMap::values() work with WTF::map/WTF::copyToVector
​https://bugs.webkit.org/show_bug.cgi?id=178072

Patch by Sam Weinig <​sam@webkit.org> on 2017-10-09
Reviewed by Darin Adler.

Source/WebCore:

• platform/graphics/avfoundation/MediaSelectionGroupAVFObjC.h:

(WebCore::MediaSelectionGroupAVFObjC::options):

Update for type change for HashMap::values().

Source/WebKit:

• Shared/AsyncRequest.h:

(WebKit::AsyncRequestMap::values):

• UIProcess/WebProcessProxy.h:

(WebKit::WebProcessProxy::pages const):

Update for type change for HashMap::values().

Source/WTF:

Introduce SizedIteratorRange, a variant of IteratorRange that includes
a reference to a backing container in order to get the size of container.
This is useful for algorithms like WTF::map and WTF::copyToVector, that
can use the size to efficiently allocate things of the correct size.

The main beneficiary are HashMap's keys() and values() functions which
used to return IteratorRanges and now return SizedIteratorRange. This
allows us to remove (in a future change) copyKeysToVector() and
copyValuesToVector() by replacing them with copyToVector(map.keys()) and
copyToVector(map.values()) respectively.

• wtf/HashMap.h:
• wtf/IteratorRange.h:

(WTF::SizedIteratorRange::SizedIteratorRange):
(WTF::SizedIteratorRange::size const):
(WTF::SizedIteratorRange::begin const):
(WTF::SizedIteratorRange::end const):
(WTF::makeSizedIteratorRange):

Tools:

• TestWebKitAPI/Tests/WTF/Vector.cpp:

(TestWebKitAPI::TEST):

Add tests for HashMap::keys() and HashMap::values() working with copyToVector.

12:55 PM Changeset in webkit [223060] by dino@apple.com

• 2 edits
  14 adds in trunk/LayoutTests/imported/w3c

Import WPT imagebitmap-renderingcontext
​https://bugs.webkit.org/show_bug.cgi?id=177963

Reviewed by Sam Weinig.

• resources/import-expectations.json:
• web-platform-tests/imagebitmap-renderingcontext/bitmaprenderer-as-imagesource-expected.txt: Added.
• web-platform-tests/imagebitmap-renderingcontext/bitmaprenderer-as-imagesource.html: Added.
• web-platform-tests/imagebitmap-renderingcontext/context-creation-expected.txt: Added.
• web-platform-tests/imagebitmap-renderingcontext/context-creation-with-alpha-expected.txt: Added.
• web-platform-tests/imagebitmap-renderingcontext/context-creation-with-alpha.html: Added.
• web-platform-tests/imagebitmap-renderingcontext/context-creation.html: Added.
• web-platform-tests/imagebitmap-renderingcontext/context-preserves-canvas-expected.txt: Added.
• web-platform-tests/imagebitmap-renderingcontext/context-preserves-canvas.html: Added.
• web-platform-tests/imagebitmap-renderingcontext/tranferFromImageBitmap-null-expected.txt: Added.
• web-platform-tests/imagebitmap-renderingcontext/tranferFromImageBitmap-null.html: Added.
• web-platform-tests/imagebitmap-renderingcontext/transferFromImageBitmap-detached-expected.txt: Added.
• web-platform-tests/imagebitmap-renderingcontext/transferFromImageBitmap-detached.html: Added.
• web-platform-tests/imagebitmap-renderingcontext/w3c-import.log: Added.

12:32 PM Changeset in webkit [223059] by Joseph Pecoraro

• 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Network Tab: Row wrapping (waterfall displaying behind next row's name)
​https://bugs.webkit.org/show_bug.cgi?id=178015
<rdar://problem/34858720>

Reviewed by Brian Burg.

• UserInterface/Views/Table.css:

(.table > .header):
(.table > .data-container > .data-list > li):
Disallow wrapping.

12:32 PM Changeset in webkit [223058] by Joseph Pecoraro

• 12 edits
  1 copy
  4 adds in trunk

Web Inspector: Network Tab - Cookies Detail View
​https://bugs.webkit.org/show_bug.cgi?id=177988
<rdar://problem/34071927>

Reviewed by Brian Burg.

Source/WebInspectorUI:

• Localizations/en.lproj/localizedStrings.js:
• UserInterface/Main.html:
• UserInterface/Test.html:

New strings and resources.

• UserInterface/Models/Cookie.js: Added.

(WI.Cookie):
(WI.Cookie.parseCookieRequestHeader):
(WI.Cookie.parseSetCookieResponseHeader):
Encapsulation for Cookie attributes.

• UserInterface/Models/Resource.js:

(WI.Resource.prototype.get requestCookies):
(WI.Resource.prototype.get responseCookies):
(WI.Resource.prototype.updateForRedirectResponse):
(WI.Resource.prototype.updateForResponse):
(WI.Resource.prototype.updateWithMetrics):
New computed accessors for requestCookies and responseCookies.

• UserInterface/Views/NetworkResourceDetailView.js:

(WI.NetworkResourceDetailView.prototype._showContentViewForNavigationItem):
Show the new Cookie View.

• UserInterface/Views/NetworkTableContentView.css:

(.content-view.network .network-table .icon):
(.network-table li:not(.filler) .cell.name):
(.network-table .cache-type):
(.network-table .error):
(body[dir=ltr] .network-table .cell.name > .status):
(body[dir=rtl] .network-table .cell.name > .status):
(.network-table .cell.name > .status .indeterminate-progress-spinner):
(.showing-detail .network-table .cell:not(.name)):
(.showing-detail .network-table .resizer:not(:first-of-type)):
(.network-table :not(.header) .cell:first-of-type):
Rework these styles to be specific to the .network-table.

• UserInterface/Views/Table.css:

(.table :not(.header) .cell:first-of-type): Deleted.
Move this to the network table styles, it shouldn't apply to all tables.

• UserInterface/Views/ResourceCookiesContentView.css:

(.resource-cookies > section > .details.has-table):
(.resource-cookies .table):
(.resource-cookies .table > .header):
Styles for Cookies view and table.

• UserInterface/Views/ResourceCookiesContentView.js: Added.

(WI.ResourceCookiesContentView):
(WI.ResourceCookiesContentView.prototype.tableNumberOfRows):
(WI.ResourceCookiesContentView.prototype.tableSortChanged):
(WI.ResourceCookiesContentView.prototype.tablePopulateCell):
(WI.ResourceCookiesContentView.prototype.initialLayout):
(WI.ResourceCookiesContentView.prototype._incompleteSectionWithMessage):
(WI.ResourceCookiesContentView.prototype._incompleteSectionWithLoadingIndicator):
(WI.ResourceCookiesContentView.prototype._dataSourceForTable):
(WI.ResourceCookiesContentView.prototype._generateSortComparator):
(WI.ResourceCookiesContentView.prototype._refreshRequestCookiesSection):
(WI.ResourceCookiesContentView.prototype._refreshResponseCookiesSection):
(WI.ResourceCookiesContentView.prototype._sizeForTable):
(WI.ResourceCookiesContentView.prototype._resourceRequestHeadersDidChange):
(WI.ResourceCookiesContentView.prototype._resourceResponseReceived):
Tables for Request and Response cookies. They are simliar with slightly different columns.
Handle simple display and sorting for the tables.

• UserInterface/Views/ResourceHeadersContentView.js:

(WI.ResourceHeadersContentView.prototype._refreshResponseHeadersSection):
Break out Set-Cookie headers as multiple headers. THey should never be combined.

• UserInterface/Views/Table.js:

(WI.Table.prototype.showColumn):
(WI.Table.prototype.hideColumn):
(WI.Table.prototype._handleHeaderContextMenu):

• UserInterface/Views/TableColumn.js:

(WI.TableColumn.prototype.get hideable):
(WI.TableColumn.prototype.set hidden):
(WI.TableColumn):
(WI.TableColumn.prototype.setHidden): Deleted.
Make it so some columns can not be hidden. For example the "value" column
in the Cookie tables.

LayoutTests:

• inspector/unit-tests/cookie-expected.txt: Added.
• inspector/unit-tests/cookie.html: Added.

12:27 PM Changeset in webkit [223057] by Joseph Pecoraro

• 5 edits in trunk/Source/WebInspectorUI

Web Inspector: Network Tab - Search Headers Detail View
​https://bugs.webkit.org/show_bug.cgi?id=177981

Reviewed by Brian Burg.

• UserInterface/Base/Main.js:
• UserInterface/Views/LogContentView.js:

(WI.LogContentView.prototype.performSearch):
Rename "Dom" to "DOM" in utility function.

• UserInterface/Views/ResourceHeadersContentView.css:

(.resource-headers.showing-find-banner .search-highlight):
Search highlight styles.

• UserInterface/Views/ResourceHeadersContentView.js:

(WI.ResourceHeadersContentView.prototype.get supportsSearch):
(WI.ResourceHeadersContentView.prototype.get numberOfSearchResults):
(WI.ResourceHeadersContentView.prototype.get hasPerformedSearch):
(WI.ResourceHeadersContentView.prototype.set automaticallyRevealFirstSearchResult):
(WI.ResourceHeadersContentView.prototype.performSearch):
(WI.ResourceHeadersContentView.prototype.searchCleared):
(WI.ResourceHeadersContentView.prototype.revealPreviousSearchResult):
(WI.ResourceHeadersContentView.prototype.revealNextSearchResult):
(WI.ResourceHeadersContentView.prototype._perfomSearchOnKeyValuePairs):
(WI.ResourceHeadersContentView.prototype._revealSearchResult):
Implement ContentView search behavior.

11:37 AM Changeset in webkit [223056] by sbarati@apple.com

• 3 edits in trunk/JSTests

3 poly-proto JSC tests timing out on debug after r222827
​https://bugs.webkit.org/show_bug.cgi?id=177880
<rdar://problem/34817122>

Unreviewed.

I'm skipping these type profiler tests on debug since they are long running.

• typeProfiler/deltablue-for-of.js:
• typeProfiler/getter-richards.js:

11:13 AM Changeset in webkit [223055] by Matt Lewis

• 2 edits in trunk/LayoutTests

Marked inspector/dom/csp-big5-hash.html as flaky.
​https://bugs.webkit.org/show_bug.cgi?id=177608

Unreviewed test garding.

• platform/mac/TestExpectations:

11:04 AM Changeset in webkit [223054] by Wenson Hsieh

• 2 edits in trunk/Source/WebCore

Unreviewed, another build fix attempt after r223031

The default constructor of DragTargetResponse is also invoked via initializer list in EventHandler.cpp, so we'll
need to explicitly declare this constructor in the header.

• page/EventHandler.h:

11:01 AM Changeset in webkit [223053] by Ryan Haddad

• 15 edits
  2 adds
  2 deletes in trunk

Unreviewed, rolling out r223021.

LayoutTests added with this change are failing.

Reverted changeset:

"[Payment Request] Implement PaymentRequest.show() and
PaymentRequest.hide()"
​https://bugs.webkit.org/show_bug.cgi?id=178043
​http://trac.webkit.org/changeset/223021

10:56 AM Changeset in webkit [223052] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebCore

Blurry captions on retina screens.
​https://bugs.webkit.org/show_bug.cgi?id=177560
rdar://problem/17913388

Patch by Jeremy Jones <​jeremyj@apple.com> on 2017-10-09
Reviewed by Jer Noble.

No new tests because the contents scale of the captions layer is not exposed to the DOM.

The captions layer contents scale needs to take into account the device screen scale to get the correct resolution for captions.

• html/shadow/MediaControlElements.cpp:

(WebCore::MediaControlTextTrackContainerElement::updateTextTrackRepresentation):
(WebCore::MediaControlTextTrackContainerElement::updateSizes):

10:54 AM Changeset in webkit [223051] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebKit

Incorrect fullscreen animation when element has a transform.
​https://bugs.webkit.org/show_bug.cgi?id=177558
rdar://problem/29603741

Patch by Jeremy Jones <​jeremyj@apple.com> on 2017-10-09
Reviewed by Jer Noble.

Use a bit of code from element fullscreen to do this correctly for video fullscreen.
The key is to get the absolute quad from the renderer. This will work for scaling,
But since we still take the bounding box, it won't work for rotations.

• WebProcess/cocoa/VideoFullscreenManager.mm:

(WebKit::inlineVideoFrame):

10:52 AM WebKitGTK/2.18.x edited by Adrian Perez de Castro

(diff)

10:27 AM Changeset in webkit [223050] by Wenson Hsieh

• 2 edits in trunk/Source/WebCore

Unreviewed, fix the Windows build after r223031

Speculative build fix; no change in behavior.

• page/EventHandler.h:

(WebCore::EventHandler::DragTargetResponse::DragTargetResponse):

10:24 AM Changeset in webkit [223049] by achristensen@apple.com

• 2 edits in trunk/Source/WebCore

Reduce includes in Document.h
​https://bugs.webkit.org/show_bug.cgi?id=178035

Reviewed by Darin Adler.

• dom/Document.h:

10:12 AM Changeset in webkit [223048] by jdiggs@igalia.com

• 6 edits
  2 adds in trunk

AX: [ATK] Explicitly-set aria-sort value of "none" should be exposed as an object attribute
​https://bugs.webkit.org/show_bug.cgi?id=177955

Reviewed by Chris Fleizach.

Source/WebCore:

Expose "none" as the value of aria-sort when the attribute is present and not
one of the other valid sort types. Also add a new AccessibilitySortDirection,
SortDirectionInvalid. This is currently only being used when the sort direction
is sought for a role which does not support this ARIA attribute, but might come
in handy if we want to add further sanity checks on the author-provided values.

Test: accessibility/gtk/aria-sort-values.html

• accessibility/AccessibilityObject.cpp:

(WebCore::AccessibilityObject::sortDirection const):

• accessibility/AccessibilityObject.h:
• accessibility/atk/WebKitAccessibleWrapperAtk.cpp:

(webkitAccessibleGetAttributes):

• accessibility/mac/WebAccessibilityObjectWrapperMac.mm:

(-[WebAccessibilityObjectWrapper additionalAccessibilityAttributeNames]):

LayoutTests:

• accessibility/gtk/aria-sort-values-expected.txt: Added.
• accessibility/gtk/aria-sort-values.html: Added.

9:49 AM Changeset in webkit [223047] by rmorisset@apple.com

• 50 edits in trunk/Source

Source/JavaScriptCore:
Make the names of the options consistent
​https://bugs.webkit.org/show_bug.cgi?id=177933

Reviewed by Saam Barati.

I added an alias so the old spelling still works.
I also fixed a bunch of typos in comments all around the codebase.

• b3/B3LowerToAir.cpp:
• dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::parseBlock):

• dfg/DFGIntegerRangeOptimizationPhase.cpp:
• dfg/DFGOperations.h:
• dfg/DFGSSAConversionPhase.h:
• dfg/DFGSpeculativeJIT.h:
• ftl/FTLLowerDFGToB3.cpp:

(JSC::FTL::DFG::LowerDFGToB3::lower):

• ftl/FTLOSREntry.cpp:

(JSC::FTL::prepareOSREntry):

• jit/CallFrameShuffler.cpp:

(JSC::CallFrameShuffler::prepareForTailCall):

• parser/Nodes.h:
• parser/Parser.cpp:

(JSC::Parser<LexerType>::parseExportDeclaration):

• runtime/Options.h:

Source/WebCore:
Make the names of the options consistent
​https://bugs.webkit.org/show_bug.cgi?id=177933

Reviewed by Saam Barati.

No functional change, just fixing comments.

• Modules/mediasource/MediaSource.cpp:

(WebCore::MediaSource::buffered const):
(WebCore::MediaSource::monitorSourceBuffers):

• Modules/webaudio/AudioBufferSourceNode.cpp:

(WebCore::AudioBufferSourceNode::process):

• bindings/scripts/generate-bindings.pl:
• css/StyleResolver.cpp:

(WebCore::StyleResolver::adjustRenderStyle):

• editing/BreakBlockquoteCommand.cpp:

(WebCore::BreakBlockquoteCommand::doApply):

• editing/ReplaceSelectionCommand.cpp:

(WebCore::ReplaceSelectionCommand::doApply):

• editing/VisibleSelection.cpp:

(WebCore::VisibleSelection::setStartAndEndFromBaseAndExtentRespectingGranularity):

• editing/VisibleUnits.cpp:

(WebCore::closestWordBoundaryForPosition):

• html/parser/AtomicHTMLToken.h:
• html/parser/HTMLDocumentParser.cpp:

(WebCore::HTMLDocumentParser::end):

• inspector/InspectorOverlayPage.js:

(reset):

• page/ViewportConfiguration.cpp:

(WebCore::ViewportConfiguration::layoutWidth const):
(WebCore::ViewportConfiguration::layoutHeight const):

• platform/graphics/FloatPolygon.h:
• platform/graphics/avfoundation/InbandTextTrackPrivateAVF.cpp:

(WebCore::InbandTextTrackPrivateAVF::processCueAttributes):

• platform/graphics/filters/FilterOperation.h:
• platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:

(WebCore::GraphicsContext3D::texImage2D):

• platform/mac/WidgetMac.mm:

(WebCore::safeRemoveFromSuperview):

• rendering/RenderBlockFlow.cpp:

(WebCore::RenderBlockFlow::collapseMarginsWithChildInfo):

• rendering/RenderBlockFlow.h:
• rendering/RenderBox.cpp:

(WebCore::RenderBox::computePositionedLogicalWidthReplaced const):

• rendering/RenderObject.cpp:

(WebCore::RenderObject::propagateRepaintToParentWithOutlineAutoIfNeeded const):

• rendering/RenderTheme.cpp:

(WebCore::RenderTheme::disabledTextColor const):

• style/ClassChangeInvalidation.cpp:

(WebCore::Style::computeClassChange):

• style/StyleScope.cpp:

(WebCore::Style::Scope::didChangeStyleSheetEnvironment):

• svg/SVGAltGlyphDefElement.cpp:

(WebCore::SVGAltGlyphDefElement::hasValidGlyphElements const):

Source/WebKit:
Make the names of the options consistent
​https://bugs.webkit.org/show_bug.cgi?id=177933

Reviewed by Saam Barati.

• NetworkProcess/capture/json.hpp:
• Platform/IPC/Connection.cpp:

(IPC::Connection::connectionDidClose):

• UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _keyboardWillHide:]):

• UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::runModal):

• UIProcess/mac/WebInspectorProxyMac.mm:

(WebKit::WebInspectorProxy::inspectedViewFrameDidChange):

• WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::selectWithGesture):

Source/WebKitLegacy/mac:
Make the names of the options consistent
​https://bugs.webkit.org/show_bug.cgi?id=177933

Reviewed by Saam Barati.

• WebView/WebFrame.h:
• WebView/WebHTMLView.mm:

(-[WebHTMLView setMarkedText:selectedRange:]):

• WebView/WebView.h:

9:37 AM Changeset in webkit [223046] by Ryan Haddad

• 2 edits in trunk/LayoutTests

Mark media/media-source/media-source-paint-to-canvas.html as failing.
​https://bugs.webkit.org/show_bug.cgi?id=178083

Unreviewed test gardening.

• platform/mac/TestExpectations:

9:04 AM Changeset in webkit [223045] by Adrian Perez de Castro

• 6 edits in trunk

[WPE][GTK] Propagate libepoxy compiler flags obtained from pkg-config
​https://bugs.webkit.org/show_bug.cgi?id=178081

Reviewed by Carlos Alberto Lopez Perez.

.:

• Source/cmake/FindLibEpoxy.cmake: Define the ${LIBEPOXY_DEFINITIONS} variable when libepoxy

is found by pkg-config. This contains the value of the "Cflags" field from "epoxy.pc".

Source/WebCore:

No new tests needed.

• CMakeLists.txt: Use ${LIBEPOXY_DEFINITIONS} for building WebCore.

Source/WebKit:

• CMakeLists.txt: Use ${LIBEPOXY_DEFINITIONS} for building WebKit.

5:53 AM Changeset in webkit [223044] by romain.bellessort@crf.canon.fr

• 3 edits in trunk/Source/WebCore

[Readable Streams API] Implement canCloseOrEnqueue
​https://bugs.webkit.org/show_bug.cgi?id=178005

Reviewed by Youenn Fablet.

Implemented readableStreamDefaultControllerCanCloseOrEnqueue [1]. This is
just a refactoring (based on spec) aiming at factorizing a set of tests
that are done at multiple places.

[1] ​https://streams.spec.whatwg.org/#readable-stream-default-controller-can-close-or-enqueue

No new tests (refactoring, no new behavior).

• Modules/streams/ReadableStreamDefaultController.js:

(enqueue): Updated.
(close): Updated.

• Modules/streams/ReadableStreamInternals.js:

(readableStreamDefaultControllerClose): Updated.
(readableStreamDefaultControllerCanCloseOrEnqueue): Added.

5:48 AM WebKitGTK/2.18.x edited by clopez@igalia.com

(diff)

5:46 AM WebKitGTK/2.16.x edited by clopez@igalia.com

(diff)

2:59 AM Changeset in webkit [223043] by gskachkov@gmail.com

• 5 edits in trunk

Safari 10 /11 problem with if (!await get(something)).
​https://bugs.webkit.org/show_bug.cgi?id=176685

Reviewed by Saam Barati.

JSTests:

• stress/async-await-basic.js:

(awaitEpression.async):

• stress/async-await-syntax.js:

(testTopLevelAsyncAwaitSyntaxSloppyMode.testSyntax):
(prototype.testTopLevelAsyncAwaitSyntaxStrictMode):

Source/JavaScriptCore:

Using unary operator before await lead to count it as identifier.
According to spec ​https://tc39.github.io/ecma262/#sec-async-function-definitions
and Note 1 await is as AwaitExpression and it is allowed to use unary operator

• parser/Parser.cpp:

(JSC::Parser<LexerType>::parsePrimaryExpression):

2:08 AM Changeset in webkit [223042] by fred.wang@free.fr

• 9 edits
  1 add
  1 delete in trunk

Remove WOFF2 from Source/ThirdParty.
​https://bugs.webkit.org/show_bug.cgi?id=177862

Patch by Frederic Wang <​fwang@igalia.com> on 2017-10-05
Reviewed by Michael Catanzaro.

.:

• Source/CMakeLists.txt: Do not build the woff2 source.
• Source/cmake/FindWOFF2Dec.cmake: Added. New cmake module for woff2.
• Source/cmake/OptionsGTK.cmake: Load the woff2 package.

Source/ThirdParty:

• woff2/CMakeLists.txt: Removed.
• woff2/LICENSE: Removed.
• woff2/README.webkit: Removed.
• woff2/include/woff2/decode.h: Removed.
• woff2/include/woff2/encode.h: Removed.
• woff2/include/woff2/output.h: Removed.
• woff2/src/buffer.h: Removed.
• woff2/src/convert_woff2ttf_*.cc: Removed.
• woff2/src/file.h: Removed.
• woff2/src/font.cc: Removed.
• woff2/src/font.h: Removed.
• woff2/src/glyph.cc: Removed.
• woff2/src/glyph.h: Removed.
• woff2/src/normalize.cc: Removed.
• woff2/src/normalize.h: Removed.
• woff2/src/port.h: Removed.
• woff2/src/round.h: Removed.
• woff2/src/store_bytes.h: Removed.
• woff2/src/table_tags.cc: Removed.
• woff2/src/table_tags.h: Removed.
• woff2/src/transform.cc: Removed.
• woff2/src/transform.h: Removed.
• woff2/src/variable_length.cc: Removed.
• woff2/src/variable_length.h: Removed.
• woff2/src/woff2_common.cc: Removed.
• woff2/src/woff2_common.h: Removed.
• woff2/src/woff2_compress.cc: Removed.
• woff2/src/woff2_dec.cc: Removed.
• woff2/src/woff2_decompress.cc: Removed.
• woff2/src/woff2_enc.cc: Removed.
• woff2/src/woff2_info.cc: Removed.
• woff2/src/woff2_out.cc: Removed.
• woff2/update.sh: Removed.

Source/WebCore:

No new tests, already covered by existing tests.

• CMakeLists.txt: Use the system brotli/woff2 headers/libraries.

Tools:

• Scripts/webkitpy/style/checker.py: Remove woff2.
• gtk/jhbuild.modules: Add new jhbuild module for woff2.