⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Oct 13, 2017:

9:45 PM Changeset in webkit [223316] by commit-queue@webkit.org
  • 28 edits in trunk/Source/WTF

Adopt type trait template aliases everywhere in WTF
​https://bugs.webkit.org/show_bug.cgi?id=178299

Patch by Sam Weinig <​sam@webkit.org> on 2017-10-13
Reviewed by Yusuke Suzuki.

Adopt type trait template aliases (e.g. replace 'typename std::make_unsigned<Source>::type'
with 'std::make_unsigned_t<Source>'). Also adopt using over typedef consistently.

  • wtf/Atomics.h:
  • wtf/CagedUniquePtr.h:
  • wtf/CheckedArithmetic.h:
  • wtf/CompletionHandler.h:
  • wtf/Function.h:
  • wtf/HashCountedSet.h:
  • wtf/HashFunctions.h:
  • wtf/HashMap.h:
  • wtf/HashSet.h:
  • wtf/HashTable.h:
  • wtf/HashTraits.h:
  • wtf/IndexedContainerIterator.h:
  • wtf/IteratorAdaptors.h:
  • wtf/KeyValuePair.h:
  • wtf/LEBDecoder.h:
  • wtf/ListHashSet.h:
  • wtf/MathExtras.h:
  • wtf/NeverDestroyed.h:
  • wtf/OptionSet.h:
  • wtf/RetainPtr.h:
  • wtf/SizeLimits.cpp:
  • wtf/StdLibExtras.h:
  • wtf/SystemFree.h:
  • wtf/ThreadSpecific.h:
  • wtf/TypeCasts.h:
  • wtf/Vector.h:
  • wtf/text/IntegerToStringConversion.h:
7:38 PM Changeset in webkit [223315] by jer.noble@apple.com
  • 7 edits
    1 add in trunk/Source

Performance: Skip texture upload if source image and destination texture haven't changed
​https://bugs.webkit.org/show_bug.cgi?id=178254
<rdar://problem/34968181>

Reviewed by Dean Jackson.

Source/WebCore:

Update GraphicsContext3D to track which texture is bound to which texture unit, and also to
track when those bound textures have their backing stores modified. This new "seed" value
will be used to determine whether a given texture which has previously had image data
uploaded to it needs to be re-updated.

In VideoTextureCopierCV, track whether the texture's seed changed, whether the IOSurface is
the same, whether the IOSurface's seed has changed, and whether the "flipY" parameter
changed since the last time the copier was asked to upload to the texture.

  • platform/graphics/GraphicsContext3D.h:

(WebCore::GraphicsContext3D::textureSeed):
(WebCore::GraphicsContext3D::GraphicsContext3DState::currentBoundTexture):
(WebCore::GraphicsContext3D::GraphicsContext3DState::boundTexture):
(WebCore::GraphicsContext3D::GraphicsContext3DState::setBoundTexture):

  • platform/graphics/cv/VideoTextureCopierCV.cpp:

(WebCore::VideoTextureCopierCV::copyImageToPlatformTexture):

  • platform/graphics/cv/VideoTextureCopierCV.h:

(WebCore::VideoTextureCopierCV::lastTextureSeed):

  • platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:

(WebCore::GraphicsContext3D::prepareTexture):
(WebCore::GraphicsContext3D::bindTexture):
(WebCore::GraphicsContext3D::texStorage2D):
(WebCore::GraphicsContext3D::texStorage3D):
(WebCore::GraphicsContext3D::framebufferTexture2D):
(WebCore::GraphicsContext3D::texSubImage2D):
(WebCore::GraphicsContext3D::compressedTexImage2D):
(WebCore::GraphicsContext3D::compressedTexSubImage2D):
(WebCore::GraphicsContext3D::createTexture):
(WebCore::GraphicsContext3D::deleteTexture):
(WebCore::GraphicsContext3D::texImage2DDirect):

Source/WTF:

Add a new class, UnsafePointer, for safely holding pointers to objects with uncontrolled lifetimes.

  • WTF.xcodeproj/project.pbxproj:
  • wtf/UnsafePointer.h: Added.

(WTF::UnsafePointer::UnsafePointer):
(WTF::UnsafePointer::operator== const):
(WTF::UnsafePointer::operator!= const):
(WTF::UnsafePointer::operator bool const):
(WTF::operator==):
(WTF::operator!=):

5:50 PM Changeset in webkit [223314] by pvollan@apple.com
  • 10 edits in trunk/Source

[Win] When built with VS2017, MiniBrowser crashes on startup.
​https://bugs.webkit.org/show_bug.cgi?id=175209

Reviewed by Daniel Bates.

Source/WebCore:

Generated StaticStringImpl objects are not initialized compile-time with VS2017.
When compiling with VS2017, the global, static, StaticStringImpl objects needs to
be defined with the constexpr specifier, in order for the objects to be initialized
at compile time. Since the StaticStringImpl objects will be const then, we need to
be able to create an AtomicString object from a const StaticStringImpl object.
This constructor has been added to the AtomicString class.

No new tests, covered by existing tests.

  • bindings/scripts/StaticString.pm:

(GenerateStrings):
(GenerateStringAsserts):

  • dom/QualifiedName.cpp:

(WebCore::createQualifiedName):

  • dom/QualifiedName.h:
  • dom/make_names.pl:

(printDefinitions):

Source/WTF:

Add AtomicString(const StaticStringImpl*) constructor. This is needed since
this patch adds constexpr to the static, global StaticStringImpl objects
generated in WebCore/bindings/scripts/StaticString.pm.

  • wtf/text/AtomicString.h:

(WTF::AtomicString::AtomicString):

  • wtf/text/AtomicStringImpl.cpp:

(WTF::addStatic):
(WTF::AtomicStringImpl::add):

  • wtf/text/AtomicStringImpl.h:
  • wtf/text/StringImpl.h:

(WTF::StringImpl::assertHashIsCorrect const):
(WTF::StringImpl::assertHashIsCorrect): Deleted.

5:44 PM Changeset in webkit [223313] by Brent Fulgham
  • 3 edits
    2 adds in trunk

Protect FrameView during style calculations
​https://bugs.webkit.org/show_bug.cgi?id=178300
<rdar://problem/34869329>

Reviewed by Ryosuke Niwa.

Source/WebCore:

Protect the FrameView during layout and style updates in case arbitrary script
is run that might clear it.

Test: fast/html/marquee-reparent-check.html

  • page/FrameView.cpp:

(WebCore::FrameView::updateLayoutAndStyleIfNeededRecursive):

LayoutTests:

  • fast/html/marquee-reparent-check-expected.txt: Added.
  • fast/html/marquee-reparent-check.html: Added.
5:42 PM Changeset in webkit [223312] by Ryan Haddad
  • 2 edits in trunk/LayoutTests

Mark http/tests/cache-storage/cache-clearing-origin.https.html as flaky.
​https://bugs.webkit.org/show_bug.cgi?id=178305

Unreviewed test gardening.

  • platform/mac/TestExpectations:
5:25 PM Changeset in webkit [223311] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

http/tests/cache-storage/cache-clearing-origin.https.html is flaky on Sierra
​https://bugs.webkit.org/show_bug.cgi?id=178303

Unreviewed.

Patch by Youenn Fablet <​youenn@apple.com> on 2017-10-13

5:05 PM Changeset in webkit [223310] by webkit@devinrousso.com
  • 4 edits in trunk/Source/WebInspectorUI

Web Inspector: make split console full width of view
​https://bugs.webkit.org/show_bug.cgi?id=176635

Reviewed by Timothy Hatcher.

  • UserInterface/Main.html:
  • UserInterface/Views/Main.css:

(#main):
(#content):

  • UserInterface/Views/CSSStyleDetailsSidebarPanel.css:

(.sidebar > .panel.details.css-style > .content ~ :matches(.options-container, .class-list-container)):
(.sidebar > .panel.details.css-style > .content ~ .options-container):

5:02 PM Changeset in webkit [223309] by pvollan@apple.com
  • 2 edits in trunk/Source/WebCore

Crash under ResourceHandleCFURLConnectionDelegateWithOperationQueue::didSendBodyData
​https://bugs.webkit.org/show_bug.cgi?id=178279

Reviewed by Alex Christensen.

Check if the connection is valid before calling ResourceHandleClient::didSendData.

No new tests, covered by existing tests.

  • platform/network/cf/ResourceHandleCFURLConnectionDelegateWithOperationQueue.cpp:

(WebCore::ResourceHandleCFURLConnectionDelegateWithOperationQueue::didSendBodyData):

4:52 PM Changeset in webkit [223308] by webkit@devinrousso.com
  • 64 edits in trunk/Source/WebInspectorUI

Web Inspector: fix ESLint errors
​https://bugs.webkit.org/show_bug.cgi?id=175065

Reviewed by Joseph Pecoraro.

Removed trailing whitespace, extra parenthesis, and some unnecessary escape characters.
Added missing semicolons, spacing around default values for parameters, and changed == to
=== where applicable.

Specific changes to each file were removed for brevity.

  • .eslintrc:

Alphabetize each list of global variables and add some missing utility functions.

  • UserInterface/Base/EventListener.js:
  • UserInterface/Base/EventListenerSet.js:
  • UserInterface/Base/Main.js:
  • UserInterface/Base/Setting.js:
  • UserInterface/Base/TextUtilities.js:
  • UserInterface/Base/URLUtilities.js:
  • UserInterface/Base/Utilities.js:
  • UserInterface/Base/YieldableTask.js:
  • UserInterface/Controllers/AppControllerBase.js:
  • UserInterface/Controllers/CanvasManager.js:
  • UserInterface/Controllers/CodeMirrorCompletionController.js:
  • UserInterface/Controllers/DOMDebuggerManager.js:
  • UserInterface/Controllers/JavaScriptRuntimeCompletionProvider.js:
  • UserInterface/Controllers/RuntimeManager.js:
  • UserInterface/Controllers/SourceMapManager.js:
  • UserInterface/Debug/DebugContentView.js:
  • UserInterface/Debug/UncaughtExceptionReporter.js:
  • UserInterface/Models/CSSKeywordCompletions.js:
  • UserInterface/Models/DOMNode.js:
  • UserInterface/Models/DOMNodeStyles.js:
  • UserInterface/Models/KeyboardShortcut.js:
  • UserInterface/Models/ProfileNode.js:
  • UserInterface/Models/Resource.js:
  • UserInterface/Models/ResourceCollection.js:
  • UserInterface/Models/Script.js:
  • UserInterface/Models/ScriptSyntaxTree.js:
  • UserInterface/Models/ScriptTimelineRecord.js:
  • UserInterface/Protocol/Connection.js:
  • UserInterface/Test/FrontendTestHarness.js:
  • UserInterface/Test/TestHarness.js:
  • UserInterface/Views/CSSStyleDeclarationSection.js:
  • UserInterface/Views/ChartDetailsSectionRow.js:
  • UserInterface/Views/CodeMirrorAdditions.js:
  • UserInterface/Views/CodeMirrorFormatters.js:
  • UserInterface/Views/CodeMirrorRegexMode.js:
  • UserInterface/Views/ContentBrowserTabContentView.js:
  • UserInterface/Views/DataGrid.js:
  • UserInterface/Views/DataGridNode.js:
  • UserInterface/Views/FindBanner.js:
  • UserInterface/Views/GroupNavigationItem.js:
  • UserInterface/Views/HierarchicalPathNavigationItem.js:
  • UserInterface/Views/NetworkTableContentView.js:
  • UserInterface/Views/NetworkTimelineView.js:
  • UserInterface/Views/ObjectTreePropertyTreeElement.js:
  • UserInterface/Views/ObjectTreeView.js:
  • UserInterface/Views/RecordingContentView.js:
  • UserInterface/Views/RenderingFrameTimelineOverviewGraph.js:
  • UserInterface/Views/ResourceCookiesContentView.js:
  • UserInterface/Views/ResourceDetailsSection.js:
  • UserInterface/Views/ResourceHeadersContentView.js:
  • UserInterface/Views/ResourceTimelineDataGridNode.js:
  • UserInterface/Views/SettingEditor.js:
  • UserInterface/Views/Sidebar.js:
  • UserInterface/Views/SpreadsheetCSSStyleDeclarationSection.js:
  • UserInterface/Views/Table.js:
  • UserInterface/Views/TextEditor.js:
  • UserInterface/Views/TimelineDataGridNode.js:
  • UserInterface/Views/TreeElement.js:
  • UserInterface/Views/TreeOutline.js:
  • UserInterface/Views/WebSocketDataGridNode.js:
  • UserInterface/Workers/Formatter/EsprimaFormatter.js:
  • UserInterface/Workers/Formatter/FormatterWorker.js:
4:28 PM Changeset in webkit [223307] by Brent Fulgham
  • 6 edits
    5 adds in trunk

CMD+R / CMD+Q keyboard shortcuts are treated as user interaction with page
​https://bugs.webkit.org/show_bug.cgi?id=178183
<rdar://problem/33327730>

Reviewed by Ryosuke Niwa.

Source/WebCore:

Key events are granted user interaction credit (in terms of updating the last time of user
interaction), even if the key event was not handled. Instead, we should defer granting
access until the key event has been handled.

Add a new default constructor argument to UserGestureIndicator to be used when handling key
events, so we can delay a decision about whether to grant ResourceLoadStatistics
'hasHadUserInteraction' until we confirm that the event was handled by the page.

This change does not affect other aspects of user interaction.

Tests: fast/events

http/tests/resourceLoadStatistics/prevalent-resource-handled-keydown.html
http/tests/resourceLoadStatistics/prevalent-resource-unhandled-keydown.html

  • dom/UserGestureIndicator.cpp:

(WebCore::UserGestureIndicator::UserGestureIndicator): Add check based on constructor argument.
Also: Drive by fix to avoid calling 'currentToken' when not on the main thread.

  • dom/UserGestureIndicator.h:
  • page/EventHandler.cpp:

(WebCore::EventHandler::keyEvent): If the key event was handled, grant user interaction credit
for ResourceLoadStatistics processing.
(WebCore::EventHandler::internalKeyEvent): Use the new UserGestureIndicator constructor argument.

LayoutTests:

  • http/tests/resourceLoadStatistics/prevalent-resource-handled-keydown-expected.txt: Added.
  • http/tests/resourceLoadStatistics/prevalent-resource-handled-keydown.html: Added.
  • http/tests/resourceLoadStatistics/prevalent-resource-unhandled-keydown-expected.txt: Added.
  • http/tests/resourceLoadStatistics/prevalent-resource-unhandled-keydown.html: Added.
  • http/tests/resourceLoadStatistics/resources: Added.
  • http/tests/resourceLoadStatistics/resources/onclick.html: Added.
  • platform/ios/TestExpectations: Skip tests that require 'keyDown' support, since this is not available on iOS.
4:05 PM DOM Security Mitigation.key attached to October 2017 Meeting by rniwa@webkit.org
DOM Security Mitigation Slides
4:04 PM clipboard-talk.key attached to October 2017 Meeting by rniwa@webkit.org
Clipboard Talk Slides
3:36 PM Changeset in webkit [223306] by Chris Dumez
  • 4 edits in trunk

DOMTokenList shouldn't add empty attributes
​https://bugs.webkit.org/show_bug.cgi?id=178280

Reviewed by Ryosuke Niwa.

LayoutTests/imported/w3c:

Rebaseline web-platform-test now that all checks are passing.

  • web-platform-tests/dom/nodes/Element-classlist-expected.txt:

Source/WebCore:

DOMTokenList shouldn't add empty attributes after:

Firefox and Chrome follow the latest spec.

No new tests, updating existing test.

  • html/DOMTokenList.cpp:

(WebCore::DOMTokenList::updateAssociatedAttributeFromTokens):
Implement the first step of ​https://dom.spec.whatwg.org/#concept-dtl-update

3:33 PM October 2017 Meeting edited by Jon Davis
(diff)
3:26 PM Changeset in webkit [223305] by jmarcell@apple.com
  • 5 edits in branches/safari-604-branch/Source/WebCore

Apply patch. rdar://problem/34891297

Cherry-pick of r222803 <rdar://problem/34745579>

2017-10-03 Jer Noble <​jer.noble@apple.com>

Implement quality-of-service tiers in WebCoreDecompressionSession
​https://bugs.webkit.org/show_bug.cgi?id=177769

Reviewed by Dean Jackson.

VTDecompressionSession will suggest quality-of-service tiers to be used when decompression
can't keep up with playback speed. Use a simple exponential-moving-average heuristic to
determine when to move up and down the tiers.

Drive-by fix: When frames are so late that they miss the display deadline, mark them as
dropped rather than just delayed.

  • platform/graphics/cocoa/WebCoreDecompressionSession.h:
  • platform/graphics/cocoa/WebCoreDecompressionSession.mm: (WebCore::WebCoreDecompressionSession::ensureDecompressionSessionForSample): (WebCore::WebCoreDecompressionSession::decodeSample): (WebCore::WebCoreDecompressionSession::handleDecompressionOutput): (WebCore::WebCoreDecompressionSession::automaticDequeue): (WebCore::WebCoreDecompressionSession::enqueueDecodedSample): (WebCore::WebCoreDecompressionSession::resetQosTier): (WebCore::WebCoreDecompressionSession::increaseQosTier): (WebCore::WebCoreDecompressionSession::decreaseQosTier): (WebCore::WebCoreDecompressionSession::updateQosWithDecodeTimeStatistics):
  • platform/cocoa/VideoToolboxSoftLink.cpp:
  • platform/cocoa/VideoToolboxSoftLink.h:
3:26 PM Changeset in webkit [223304] by jmarcell@apple.com
  • 6 edits in branches/safari-604-branch/Source/WebCore

Apply patch. rdar://problem/34891297

Partial cherry-pick of r222225 <rdar://problem/34745579>, only the changes to WebCoreDecompressionSession.

2017-09-19 Jer Noble <​jer.noble@apple.com>

[Cocoa] Add an ImageDecoder subclass backed by AVFoundation
​https://bugs.webkit.org/show_bug.cgi?id=176825

Reviewed by Eric Carlson.

Modify WebCoreDecompressionSession so that it can emit frames which have been converted from
YUV -> RGB as part of the decode operation. Also, add a synchronous decoding operation
method, for use in ImageDecoderAVFObjC.

  • platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm: (WebCore::MediaPlayerPrivateMediaSourceAVFObjC::ensureDecompressionSession):
  • platform/graphics/cocoa/WebCoreDecompressionSession.h: (WebCore::WebCoreDecompressionSession::createOpenGL): (WebCore::WebCoreDecompressionSession::createRGB):
  • platform/graphics/cocoa/WebCoreDecompressionSession.mm: (WebCore::WebCoreDecompressionSession::WebCoreDecompressionSession): (WebCore::WebCoreDecompressionSession::ensureDecompressionSessionForSample): (WebCore::WebCoreDecompressionSession::decodeSample): (WebCore::WebCoreDecompressionSession::decodeSampleSync):
3:07 PM Changeset in webkit [223303] by jmarcell@apple.com
  • 7 edits in branches/safari-604-branch/Source

Versioning.

3:06 PM Changeset in webkit [223302] by jmarcell@apple.com
  • 1 copy in tags/Safari-604.4.3

Tag Safari-604.4.3.

3:03 PM Changeset in webkit [223301] by Adrian Perez de Castro
  • 2 edits in trunk/Tools

[WPE] Fontconfig fails build in JHBuild with “error: conflicting types for ‘FcObjectTypeHash’”
​https://bugs.webkit.org/show_bug.cgi?id=178283

Reviewed by Žan Doberšek.

  • wpe/jhbuild.modules: Flag Fontconfig to be built inside the source directory, otherwise

compilation fails. While at it, pass "--disable-docs" to cut a bit on build time.

2:58 PM Changeset in webkit [223300] by Matt Lewis
  • 2 edits in trunk/LayoutTests

Marked http/tests/inspector/network/resource-sizes-memory-cache.html as flaky.
​https://bugs.webkit.org/show_bug.cgi?id=177687

Unreviewed test gardening.

  • platform/mac-wk2/TestExpectations:
2:04 PM October 2017 Meeting edited by Jon Davis
(diff)
2:04 PM NextGenerationLayoutAndRendering created by Jon Davis
1:45 PM October 2017 Meeting edited by Jon Davis
(diff)
1:31 PM Changeset in webkit [223299] by commit-queue@webkit.org
  • 16 edits in trunk

Implement listing origins for which CacheStorage is storing data
​https://bugs.webkit.org/show_bug.cgi?id=178236

Patch by Youenn Fablet <​youenn@apple.com> on 2017-10-13
Reviewed by Chris Dumez.

Source/WebKit:

Cache storage is split on per-origin folders which name is obfuscated through salting.
To retrieve the origin for each folder, an origin file is now stored within each folder.
This file contains the actual origin.

Adding support to get the list of origin by iterating through each folder and
getting the actual origin by reading the content of the 'origin' file.

Adding C API for WebKitTestRunner.

  • NetworkProcess/cache/CacheStorageEngine.cpp:

(WebKit::CacheStorage::Engine::fetchEntries):
(WebKit::CacheStorage::ReadOriginsTaskCounter::create):
(WebKit::CacheStorage::ReadOriginsTaskCounter::~ReadOriginsTaskCounter):
(WebKit::CacheStorage::ReadOriginsTaskCounter::addOrigin):
(WebKit::CacheStorage::ReadOriginsTaskCounter::ReadOriginsTaskCounter):

  • NetworkProcess/cache/CacheStorageEngine.h:
  • NetworkProcess/cache/CacheStorageEngineCaches.cpp:

(WebKit::CacheStorage::cachesOriginFilename):
(WebKit::CacheStorage::Caches::retrieveOriginFromDirectory):
(WebKit::CacheStorage::Caches::Caches):
(WebKit::CacheStorage::Caches::storeOrigin):
(WebKit::CacheStorage::Caches::readOrigin):
(WebKit::CacheStorage::Caches::initialize):

  • NetworkProcess/cache/CacheStorageEngineCaches.h:

(WebKit::CacheStorage::Caches::origin const):

  • UIProcess/API/C/WKWebsiteDataStoreRef.cpp:

(WKWebsiteDataStoreGetFetchCacheOrigins):

  • UIProcess/API/C/WKWebsiteDataStoreRef.h:

Tools:

Adding hasDOMCache API for checking whether origin is storing data through Cache API.

  • WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
  • WebKitTestRunner/InjectedBundle/TestRunner.cpp:

(WTR::TestRunner::hasDOMCache):

  • WebKitTestRunner/InjectedBundle/TestRunner.h:
  • WebKitTestRunner/TestController.cpp:

(WTR::FetchCacheOriginsCallbackContext::FetchCacheOriginsCallbackContext):
(WTR::fetchCacheOriginsCallback):
(WTR::TestController::hasDOMCache):

  • WebKitTestRunner/TestController.h:
  • WebKitTestRunner/TestInvocation.cpp:

(WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):

LayoutTests:

  • http/tests/cache-storage/cache-clearing-origin.https.html:
1:24 PM Changeset in webkit [223298] by jer.noble@apple.com
  • 2 edits in trunk/Source/WebCore

Unreviewed build fix; wrap more functions in USE(IOSURFACE) so that
they do not generate "unused function" errors.

  • platform/graphics/cv/VideoTextureCopierCV.cpp:
1:14 PM October 2017 Meeting edited by Jon Davis
(diff)
1:13 PM WebKitGoalsFor2018 created by Jon Davis
1:12 PM October 2017 Meeting edited by Jon Davis
(diff)
1:08 PM October 2017 Meeting edited by Jon Davis
(diff)
1:06 PM OptimizingzlibforARM created by Jon Davis
12:55 PM Changeset in webkit [223297] by jer.noble@apple.com
  • 2 edits in trunk/Source/WebCore

One last unreviewed build fix; since the IOSurface APIs don't exist at
all on the simulator, just wrap the entirety of the implementation of
copyImageToPlatformTexture() in a #if USE(IOSURFACE) check.

  • platform/graphics/cv/VideoTextureCopierCV.cpp:

(WebCore::VideoTextureCopierCV::copyImageToPlatformTexture):

12:08 PM WebKitGTK/2.18.x edited by Adrian Perez de Castro
(diff)
12:04 PM Changeset in webkit [223296] by Adrian Perez de Castro
  • 3 edits
    2 adds in trunk/Source/WebCore/PAL

[WPE][GTK] Provide an implementation of PAL::logLevelString()
​https://bugs.webkit.org/show_bug.cgi?id=178263

Reviewed by Carlos Alberto Lopez Perez.

Provide an implementation of PAL::logLevelString() which picks the value from the
WEBCORE_DEBUG environment variable. Logging of notImplemented() calls is always enabled,
which is the same behavior as in WebCore::logLevelString().

  • pal/PlatformGTK.cmake: Add LoggingUnix.cpp to the list of sources.
  • pal/PlatformWPE.cmake: Add LoggingUnix.cpp to the list of sources.
  • pal/unix/LoggingUnix.cpp: Added.

(PAL::logLevelString):

11:55 AM Changeset in webkit [223295] by jer.noble@apple.com
  • 2 edits in trunk/Source/WebCore

Unreviewed build fix for the previous build fix; use the right PAL path for IOSurfaceSPI.h.

  • platform/graphics/cv/VideoTextureCopierCV.cpp:
11:48 AM Changeset in webkit [223294] by jer.noble@apple.com
  • 4 edits in trunk/Source/WebCore

Unreviewed build fix; add definitions for IOSurface methods missing on some platforms.

Source/WebCore:

  • platform/graphics/cv/VideoTextureCopierCV.cpp:

Source/WebCore/PAL:

  • pal/spi/cocoa/IOSurfaceSPI.h:
11:47 AM October 2017 Meeting edited by Simon Fraser
(diff)
11:45 AM October 2017 Meeting edited by Simon Fraser
(diff)
11:45 AM October 2017 Meeting edited by Simon Fraser
(diff)
11:43 AM Changeset in webkit [223293] by jmarcell@apple.com
  • 2 edits
    2 adds in tags/Safari-605.1.10.1/Source/WebCore/PAL

Cherry-pick r223241. rdar://problem/34974253

11:42 AM Changeset in webkit [223292] by jmarcell@apple.com
  • 7 edits in tags/Safari-605.1.10.1/Source

Versioning.

11:23 AM Changeset in webkit [223291] by achristensen@apple.com
  • 7 edits
    1 delete in trunk

Remove Editor::simplifyMarkup
​https://bugs.webkit.org/show_bug.cgi?id=178271

Reviewed by Wenson Hsieh.

Source/WebCore:

An API test became flaky, and it turns out this isn't used anywhere, so let's remove it!
It was used in Mountain Lion, Mavericks, and Yosemite, but not since then.
See <rdar://problem/10726177>

  • editing/Editor.cpp:

(WebCore::Editor::simplifyMarkup): Deleted.

  • editing/Editor.h:

Source/WebKitLegacy/mac:

  • WebView/WebView.mm:

(-[WebView _simplifyMarkup:endNode:]):

Tools:

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/Tests/mac/SimplifyMarkup.mm: Removed.
11:17 AM Changeset in webkit [223290] by jmarcell@apple.com
  • 1 copy in tags/Safari-605.1.10.1

New tag.

11:16 AM Changeset in webkit [223289] by jer.noble@apple.com
  • 3 edits in trunk/Source/WebCore

Unreviewed build fix; forward declare the type of IOSurfaceRef.

  • platform/cocoa/CoreVideoSoftLink.cpp:
  • platform/cocoa/CoreVideoSoftLink.h:
11:03 AM Changeset in webkit [223288] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

http/tests/cache-storage/cache-origins.https.html is flaky
​https://bugs.webkit.org/show_bug.cgi?id=178266

Unreviewed.

Patch by Youenn Fablet <​youenn@apple.com> on 2017-10-13

  • http/tests/cache-storage/cache-clearing-origin.https.html:
10:41 AM Changeset in webkit [223287] by jer.noble@apple.com
  • 3 edits in trunk/Source/WebCore

Unreviewed build fix; add soft link macros for newly called CoreVideo methods.

  • platform/cocoa/CoreVideoSoftLink.cpp:
  • platform/cocoa/CoreVideoSoftLink.h:
10:30 AM Changeset in webkit [223286] by achristensen@apple.com
  • 3 edits in trunk/Source/WebKit

Fix API tests after r223269.
​https://bugs.webkit.org/show_bug.cgi?id=178246

  • UIProcess/API/APIContentRuleListStore.cpp:

(API::ContentRuleListStore::getContentRuleListSource):
Version 10 also has the ability to recover content rule list source.

10:30 AM Changeset in webkit [223285] by jer.noble@apple.com
  • 2 edits in trunk/Source/WebCore

Unreviewed build fix; add UNUSED_PARAM macros.

  • platform/graphics/cocoa/GraphicsContext3DCocoa.mm:

(WebCore::GraphicsContext3D::texImageIOSurface2D):

10:19 AM Changeset in webkit [223284] by commit-queue@webkit.org
  • 3 edits in trunk/LayoutTests

Modernize LayoutTests/http/tests/cache-storage/cache-clearing-*.https.html
​https://bugs.webkit.org/show_bug.cgi?id=178245

Patch by Youenn Fablet <​youenn@apple.com> on 2017-10-13
Reviewed by Chris Dumez.

Using await/async to improve the testing.
Taking benefit of clearDOMCache to wait for completion to simplify both tests as well.

  • http/tests/cache-storage/cache-clearing-all.https.html:
  • http/tests/cache-storage/cache-clearing-origin.https.html:
10:14 AM Changeset in webkit [223283] by Nikita Vasilyev
  • 6 edits in trunk/Source/WebInspectorUI

Web Inspector: Styles Redesign: hook up autocompletion to property names and values
​https://bugs.webkit.org/show_bug.cgi?id=177313
<rdar://problem/34577057>

Reviewed by Joseph Pecoraro.

  • Arrow Right accept the current completion item and places the text caret after it.
  • Arrow Left hides the completion popover.
  • Arrow Up selects the previous completion item.
  • Arrow Down selects the next completion item.
  • Enter and Tab accept the current completion item and navigate to the next focusable item.
  • Escape hides the completion popover, if there is one.
  • UserInterface/Views/CompletionSuggestionsView.js:

(WI.CompletionSuggestionsView):
(WI.CompletionSuggestionsView.prototype._mouseDown):
Add a preventBlur option so clicking on an completion item doesn't change the focus and
doesn't cause "blur" event on the target text field.

  • UserInterface/Views/SpreadsheetCSSStyleDeclarationEditor.css:

(.spreadsheet-style-declaration-editor .completion-hint):

  • UserInterface/Views/SpreadsheetCSSStyleDeclarationEditor.js:

(WI.SpreadsheetCSSStyleDeclarationEditor):
(WI.SpreadsheetCSSStyleDeclarationEditor.prototype.layout):
(WI.SpreadsheetCSSStyleDeclarationEditor.prototype.detached):
Call detached on every SpreadsheetTextField to hide CompletionSuggestionsView once
SpreadsheetCSSStyleDeclarationEditor is removed from the DOM.

(WI.SpreadsheetCSSStyleDeclarationEditor.prototype._addBlankProperty):
Remove index argument since it is no longer used.

  • UserInterface/Views/SpreadsheetStyleProperty.js:

(WI.SpreadsheetStyleProperty):
(WI.SpreadsheetStyleProperty.prototype.detached):
(WI.SpreadsheetStyleProperty.prototype._remove):
(WI.SpreadsheetStyleProperty.prototype._update):
(WI.SpreadsheetStyleProperty.prototype._nameCompletionDataProvider):
(WI.SpreadsheetStyleProperty.prototype._valueCompletionDataProvider):
Add an extra parameter to SpreadsheetTextField to pass a completion data provider.

  • UserInterface/Views/SpreadsheetTextField.js:

(WI.SpreadsheetTextField):
(WI.SpreadsheetTextField.prototype.get suggestionHint):
(WI.SpreadsheetTextField.prototype.set suggestionHint):
(WI.SpreadsheetTextField.prototype.startEditing):
(WI.SpreadsheetTextField.prototype.stopEditing):
(WI.SpreadsheetTextField.prototype.detached):
(WI.SpreadsheetTextField.prototype.completionSuggestionsSelectedCompletion):
(WI.SpreadsheetTextField.prototype.completionSuggestionsClickedCompletion):
(WI.SpreadsheetTextField.prototype._getPrefix):
(WI.SpreadsheetTextField.prototype._handleBlur):
(WI.SpreadsheetTextField.prototype._handleKeyDown):
(WI.SpreadsheetTextField.prototype._handleKeyDownForSuggestionView):
(WI.SpreadsheetTextField.prototype._handleInput):
(WI.SpreadsheetTextField.prototype._updateCompletions):
(WI.SpreadsheetTextField.prototype._getCaretRect):
(WI.SpreadsheetTextField.prototype._getCompletionPrefix):
(WI.SpreadsheetTextField.prototype._applyCompletionHint):
(WI.SpreadsheetTextField.prototype._hideCompletions):
Provide text completion based on the existing CompletionSuggestionsView when completionProvider is passed to SpreadsheetTextField.

10:07 AM Changeset in webkit [223282] by Gustavo Noronha Silva
  • 8 edits in trunk

[GLib] WebKitNavigationAction should tell whether it is a redirect
​https://bugs.webkit.org/show_bug.cgi?id=178178

Source/WebKit:

There is no good way to know whether a given navigation action has been caused
by a redirect through the glib API. This is necessary to implement some app mode
heuristics for Epiphany.

Reviewed by Carlos Garcia Campos.

  • UIProcess/API/glib/WebKitNavigationAction.cpp:

(webkit_navigation_action_is_redirect): returns whether the navigation action is a redirect.

  • UIProcess/API/glib/WebKitNavigationActionPrivate.h: add isRedirect to the wrapper object.

(_WebKitNavigationAction::_WebKitNavigationAction):

  • UIProcess/API/gtk/WebKitNavigationAction.h: add the new API.
  • UIProcess/API/gtk/docs/webkit2gtk-4.0-sections.txt: ditto.
  • UIProcess/API/wpe/WebKitNavigationAction.h: ditto.

Tools:

Test that WebKitNavigationAction properly reports being a redirect.

Reviewed by Carlos Garcia Campos.

  • TestWebKitAPI/Tests/WebKitGLib/TestWebKitPolicyClient.cpp:

(testNavigationPolicy): test that loading /redirect leads to a redirect WebKitNavigationAction.
(serverCallback): add a /redirect path to the server, which causes a redirect.

10:05 AM Changeset in webkit [223281] by Chris Dumez
  • 2 edits in trunk/Tools

Unreviewed, fix webkitpy failure after r223273

  • Scripts/webkitpy/w3c/test_importer_unittest.py:

(TestImporterTest.test_harnesslinks_conversion):

9:32 AM Changeset in webkit [223280] by jer.noble@apple.com
  • 11 edits in trunk/Source/WebCore

Performance: do pixel conformance and texturing in a single step.
​https://bugs.webkit.org/show_bug.cgi?id=178219
<rdar://problem/34937237>

Reviewed by Dean Jackson.

No new tests; performance improvements should have no behavior change.

Rather than asking the VTDecompressionSession to conform the output CVPixelBuffer into a
pixel format compatible with OpenGL (& ES), don't constrain the output at all, and only do a
conformance step if the output is not already compatible with OpenGL. This eliminates one
copy (in hardware) operation.

Move the TextureCacheCV object into VideoTextureCopierCV; it will be conditionally used to
create the texture if the pixel buffer is compatible.

Refactor copyVideoTextureToPlatformTexture(CVOpenGLTextureRef) in VideoTextureCopierCV. The
new entry point, copyImageToPlatformTexture(), will attempt to use the texture cache first,
and call a new common copyVideoTextureToPlatformTexture(Platform3DObject) with the result.

The new copyImageToPlatformTexture() will pull planar YUV frames into two textures, and combine
the two with a color transfer function when drawing to the output texture.

  • platform/graphics/GraphicsContext3D.h:
  • platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:

(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::copyVideoTextureToPlatformTexture):

  • platform/graphics/cocoa/GraphicsContext3DCocoa.mm:

(WebCore::GraphicsContext3D::texImageIOSurface2D):

  • platform/graphics/cocoa/WebCoreDecompressionSession.mm:

(WebCore::WebCoreDecompressionSession::ensureDecompressionSessionForSample):

  • platform/graphics/cv/TextureCacheCV.h:
  • platform/graphics/cv/TextureCacheCV.mm:

(WebCore::TextureCacheCV::textureFromImage):

  • platform/graphics/cv/VideoTextureCopierCV.cpp:

(WebCore::pixelRangeFromPixelFormat):
(WebCore::transferFunctionFromString):
(WebCore::YCbCrToRGBMatrixForRangeAndTransferFunction):
(WebCore::VideoTextureCopierCV::~VideoTextureCopierCV):
(WebCore::VideoTextureCopierCV::initializeUVContextObjects):
(WebCore::VideoTextureCopierCV::copyImageToPlatformTexture):
(WebCore::VideoTextureCopierCV::copyVideoTextureToPlatformTexture):

  • platform/graphics/cv/VideoTextureCopierCV.h:
9:03 AM October 2017 Meeting edited by yoav@yoav.ws
(diff)
9:02 AM October 2017 Meeting edited by yoav@yoav.ws
(diff)
9:02 AM October 2017 Meeting edited by yoav@yoav.ws
(diff)
8:32 AM October 2017 Meeting edited by Jon Davis
(diff)
8:20 AM October 2017 Meeting edited by Jon Davis
(diff)
7:46 AM October 2017 Meeting edited by Jon Davis
(diff)
7:45 AM October 2017 Meeting edited by Jon Davis
(diff)
7:36 AM October 2017 Meeting edited by Jon Davis
(diff)
7:35 AM October 2017 Meeting edited by Jon Davis
(diff)
6:38 AM October 2017 Meeting edited by cavalcantii@gmail.com
(diff)
2:22 AM Changeset in webkit [223279] by romain.bellessort@crf.canon.fr
  • 7 edits in trunk

[Readable Streams API] Align queue with spec for ReadableStreamDefaultController
​https://bugs.webkit.org/show_bug.cgi?id=178082

Reviewed by Xabier Rodriguez-Calvar.

LayoutTests/imported/w3c:

Updated test expectations for tests that were previously failing but now pass.

  • web-platform-tests/streams/readable-streams/floating-point-total-queue-size-expected.txt:
  • web-platform-tests/streams/readable-streams/floating-point-total-queue-size.dedicatedworker-expected.txt:

Source/WebCore:

Implemented new queue behavior for dequeueValue (used by ReadableStreamDefaultController),
which fixes rounding errors (as described in ​https://github.com/whatwg/streams/pull/661).
Also aligned ReadableByteStreamController queue so that both queues are implemented in
the same way.

No new tests (covered by existing tests, especially WPT tests that now pass).

  • Modules/streams/ReadableByteStreamInternals.js:

(privateInitializeReadableByteStreamController): Aligned queue with RSDC.
(readableByteStreamControllerCancel): Aligned queue with RSDC.
(readableByteStreamControllerError): Aligned queue with RSDC.
(readableByteStreamControllerClose): Aligned queue with RSDC.
(readableByteStreamControllerHandleQueueDrain): Aligned queue with RSDC.
(readableByteStreamControllerPull): Aligned queue with RSDC.
(readableByteStreamControllerEnqueue): Aligned queue with RSDC.
(readableByteStreamControllerEnqueueChunk): Aligned queue with RSDC.
(readableByteStreamControllerProcessPullDescriptors): Aligned queue with RSDC.
(readableByteStreamControllerFillDescriptorFromQueue): Aligned queue with RSDC.
(readableByteStreamControllerPullInto): Aligned queue with RSDC.

  • Modules/streams/StreamInternals.js:

(dequeueValue): Updated to match spec.

  • bindings/js/WebCoreBuiltinNames.h: Removed now useless "totalQueuedBytes".
12:14 AM Changeset in webkit [223278] by Wenson Hsieh
  • 5 edits
    7 moves in trunk

"text/html" data is not exposed when dragging and dropping across origins
​https://bugs.webkit.org/show_bug.cgi?id=178253
<rdar://problem/34971203>

Reviewed by Ryosuke Niwa.

Source/WebCore:

Minor tweak to DataTransfer::setDataFromItemList to allow "text/html" written from bindings to transfer across
origins without requiring a sanitized representation. Currently, sanitizedData is null, which limits "text/html"
to being treated as custom data, inaccessible across origins. We should instead treat markup supplied via
bindings the same way as we do "text/plain" supplied via bindings.

Modified Tests: editing/pasteboard/data-transfer-set-data-sanitize-url-when-copying-in-null-origin.html

editing/pasteboard/data-transfer-set-data-sanitize-url-when-dragging-in-null-origin.html

  • dom/DataTransfer.cpp:

(WebCore::DataTransfer::setDataFromItemList):

LayoutTests:

Renames some existing layout tests, and also augments two tests to verify that "text/html" is preserved when
copying and dragging across origins that don't match.

  • TestExpectations:
  • editing/pasteboard/data-transfer-set-data-ignore-copied-malformed-url-in-null-expected.txt: Renamed from LayoutTests/editing/pasteboard/data-transfer-set-data-ignore-copied-walformed-url-in-null-expected.txt.
  • editing/pasteboard/data-transfer-set-data-ignore-copied-malformed-url-in-null-origin-expected.txt: Renamed from LayoutTests/editing/pasteboard/data-transfer-set-data-ignore-copied-walformed-url-in-null-origin-expected.txt.
  • editing/pasteboard/data-transfer-set-data-ignore-copied-malformed-url-in-null-origin.html: Renamed from LayoutTests/editing/pasteboard/data-transfer-set-data-ignore-copied-walformed-url-in-null-origin.html.
  • editing/pasteboard/data-transfer-set-data-sanitize-url-when-copying-in-null-origin-expected.txt: Renamed from LayoutTests/editing/pasteboard/data-transfer-set-data-sanitlize-url-when-copying-in-null-origin-expected.txt.
  • editing/pasteboard/data-transfer-set-data-sanitize-url-when-copying-in-null-origin.html: Renamed from LayoutTests/editing/pasteboard/data-transfer-set-data-sanitlize-url-when-copying-in-null-origin.html.
  • editing/pasteboard/data-transfer-set-data-sanitize-url-when-dragging-in-null-origin-expected.txt: Renamed from LayoutTests/editing/pasteboard/data-transfer-set-data-sanitlize-url-when-dragging-in-null-origin-expected.txt.
  • editing/pasteboard/data-transfer-set-data-sanitize-url-when-dragging-in-null-origin.html: Renamed from LayoutTests/editing/pasteboard/data-transfer-set-data-sanitlize-url-when-dragging-in-null-origin.html.
  • platform/mac-wk1/TestExpectations:

Oct 12, 2017:

11:44 PM Changeset in webkit [223277] by beidson@apple.com
  • 15 edits
    4 copies
    2 adds in trunk

SW "Hello world".
​https://bugs.webkit.org/show_bug.cgi?id=178187

Reviewed by Andy Estes.

Source/WebCore:

No new tests (Covered by changes to existing tests).

With this patch, SW scripts are actually compiled and run inside a ServiceWorkerGlobalScope environment
in the SW context process.

  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/WorkerScriptController.cpp:

(WebCore::WorkerScriptController::initScript):

  • dom/EventTargetFactory.in:
  • workers/WorkerGlobalScope.h:

(WebCore::WorkerGlobalScope::isServiceWorkerGlobalScope const):

  • workers/service/ServiceWorkerContextData.cpp: Copied from Source/WebCore/workers/service/ServiceWorkerGlobalScope.cpp.

(WebCore::ServiceWorkerContextData::isolatedCopy const):

  • workers/service/ServiceWorkerContextData.h:

(WebCore::ServiceWorkerContextData::encode const):
(WebCore::ServiceWorkerContextData::decode):

  • workers/service/ServiceWorkerGlobalScope.cpp:

(WebCore::ServiceWorkerGlobalScope::ServiceWorkerGlobalScope):
(WebCore::ServiceWorkerGlobalScope::~ServiceWorkerGlobalScope):
(WebCore::ServiceWorkerGlobalScope::registration):
(WebCore::ServiceWorkerGlobalScope::eventTargetInterface const):

  • workers/service/ServiceWorkerGlobalScope.h:

(WebCore::ServiceWorkerGlobalScope::create):
(WebCore::ServiceWorkerGlobalScope::serverConnectionIdentifier const):

  • workers/service/context/SWContextManager.cpp: Copied from Source/WebCore/workers/service/ServiceWorkerGlobalScope.cpp.

(WebCore::SWContextManager::singleton):
(WebCore::SWContextManager::SWContextManager):
(WebCore::SWContextManager::startServiceWorkerContext):

  • workers/service/context/SWContextManager.h: Copied from Source/WebCore/workers/service/ServiceWorkerGlobalScope.h.
  • workers/service/context/ServiceWorkerThread.cpp: Added.

(WebCore::ServiceWorkerThreadProxy::sharedDummyProxy):
(WebCore::ServiceWorkerThread::ServiceWorkerThread):
(WebCore::m_workerObjectProxy):
(WebCore::ServiceWorkerThread::~ServiceWorkerThread):
(WebCore::ServiceWorkerThread::createWorkerGlobalScope):
(WebCore::ServiceWorkerThread::runEventLoop):

  • workers/service/context/ServiceWorkerThread.h: Copied from Source/WebCore/workers/service/ServiceWorkerGlobalScope.h.

(WebCore::ServiceWorkerThread::create):
(WebCore::ServiceWorkerThread::workerObjectProxy const):

  • workers/service/server/SWServer.cpp:

(WebCore::SWServer::createWorker):

Source/WebKit:

  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::startServiceWorkerContext):

LayoutTests:

  • http/tests/workers/service/basic-register-exceptions-expected.txt:
  • http/tests/workers/service/basic-register-expected.txt:
  • http/tests/workers/service/registration-task-queue-scheduling-1-expected.txt:
10:35 PM Changeset in webkit [223276] by jmarcell@apple.com
  • 4 edits
    4 adds in branches/safari-604-branch

Cherry-pick r223144. rdar://problem/34958765

10:35 PM Changeset in webkit [223275] by jmarcell@apple.com
  • 9 edits
    8 deletes in branches/safari-604-branch

Cherry-pick r222627. rdar://problem/34938437

7:13 PM Changeset in webkit [223274] by Yusuke Suzuki
  • 9 edits in trunk

WebAssembly: Wasm functions should have either JSFunctionType or TypeOfShouldCallGetCallData
​https://bugs.webkit.org/show_bug.cgi?id=178210

Reviewed by Saam Barati.

JSTests:

  • wasm/function-tests/trap-from-start-async.js:

(async.StartTrapsAsync):

  • wasm/function-tests/trap-from-start.js:

(StartTraps):

  • wasm/js-api/web-assembly-function.js:

(assert.eq.Object.getPrototypeOf):

  • wasm/js-api/wrapper-function.js:

(return.new.WebAssembly.Module):
(assert.throws.makeInstance): Deleted.
(assert.throws.Bar): Deleted.
(assert.throws): Deleted.

Source/JavaScriptCore:

In Wasm, we have two JS functions exposed to users: WebAssemblyFunction and WebAssemblyWrapperFunction.
The former is an exported wasm function and the latter is an imported & exported function. Since they
have Call, they should be categorized into "function" in typeof operation.

However, these functions do not implement our function protocol correctly. They inherit JSFunction.
But JSType of WebAssemblyFunction is WebAssemblyFunctionType, and one of WebAssemblyWrapperFunction is
ObjectType. Since both do not have TypeOfShouldCallGetCallData, they return "object" when performing
typeof operation.

In this patch, we address the above issue by the following 2 fixes.

  1. We add TypeOfShouldCallGetCallData to WebAssemblyFunction. This is the same way how we implement

InternalFunction. Since WebAssemblyFunction requires WebAssemblyFunctionType for fast checking in Wasm
implementation, we cannot make this JSFunctionType.

  1. On the other hand, WebAssemblyWrapperFunction does not require a specific JSType. So this patch

changes JSType of WebAssemblyWrapperFunction to JSFunctionType. JSFunctionType can be usable for derived
classes of JSFunction (e.g. JSCustomGetterSetterFunction).

  • wasm/js/WebAssemblyFunction.h:

(JSC::WebAssemblyFunction::signatureIndex const): Deleted.
(JSC::WebAssemblyFunction::wasmEntrypointLoadLocation const): Deleted.
(JSC::WebAssemblyFunction::callableFunction const): Deleted.
(JSC::WebAssemblyFunction::jsEntrypoint): Deleted.
(JSC::WebAssemblyFunction::offsetOfWasmEntrypointLoadLocation): Deleted.

  • wasm/js/WebAssemblyWrapperFunction.cpp:

(JSC::WebAssemblyWrapperFunction::createStructure):

  • wasm/js/WebAssemblyWrapperFunction.h:

(JSC::WebAssemblyWrapperFunction::signatureIndex const): Deleted.
(JSC::WebAssemblyWrapperFunction::wasmEntrypointLoadLocation const): Deleted.
(JSC::WebAssemblyWrapperFunction::callableFunction const): Deleted.
(JSC::WebAssemblyWrapperFunction::function): Deleted.

7:04 PM Changeset in webkit [223273] by Chris Dumez
  • 523 edits in trunk

import-w3c-tests modifies test sources and sometimes causes them to fail
​https://bugs.webkit.org/show_bug.cgi?id=178234

Reviewed by Ryosuke Niwa.

LayoutTests/imported/w3c:

Resync tests now that they no longer get re-written by the importer.
Most changes are about casing and spacing.

Also note that some tests are now passing and that they have been rebaselined.

  • web-platform-tests/FileAPI/url/multi-global-origin-serialization.sub.html:
  • web-platform-tests/IndexedDB/abort-in-initial-upgradeneeded.html:
  • web-platform-tests/IndexedDB/close-in-upgradeneeded.html:
  • web-platform-tests/IndexedDB/cursor-overloads.htm:
  • web-platform-tests/IndexedDB/idbkeyrange_incorrect.htm:
  • web-platform-tests/IndexedDB/key_invalid.htm:
  • web-platform-tests/IndexedDB/key_valid.html:
  • web-platform-tests/IndexedDB/keyorder.htm:
  • web-platform-tests/IndexedDB/keypath.htm:
  • web-platform-tests/IndexedDB/keypath_invalid.htm:
  • web-platform-tests/IndexedDB/string-list-ordering.htm:
  • web-platform-tests/WebIDL/current-realm.html:
  • web-platform-tests/css/css-display-3/display-contents-before-after-001.html:
  • web-platform-tests/css/css-display-3/display-contents-dynamic-before-after-001.html:
  • web-platform-tests/css/css-display-3/display-contents-dynamic-flex-002-inline-expected.html:
  • web-platform-tests/css/css-display-3/display-contents-dynamic-flex-002-inline.html:
  • web-platform-tests/css/css-display-3/display-contents-dynamic-flex-002-none-expected.html:
  • web-platform-tests/css/css-display-3/display-contents-dynamic-flex-002-none.html:
  • web-platform-tests/css/css-display-3/display-contents-dynamic-flex-003-inline-expected.html:
  • web-platform-tests/css/css-display-3/display-contents-dynamic-flex-003-inline.html:
  • web-platform-tests/css/css-display-3/display-contents-dynamic-flex-003-none-expected.html:
  • web-platform-tests/css/css-display-3/display-contents-dynamic-flex-003-none.html:
  • web-platform-tests/css/css-display-3/display-contents-dynamic-inline-flex-001-inline-expected.html:
  • web-platform-tests/css/css-display-3/display-contents-dynamic-inline-flex-001-inline.html:
  • web-platform-tests/css/css-display-3/display-contents-dynamic-inline-flex-001-none-expected.html:
  • web-platform-tests/css/css-display-3/display-contents-dynamic-inline-flex-001-none.html:
  • web-platform-tests/css/css-display-3/display-contents-dynamic-list-001-inline-expected.html:
  • web-platform-tests/css/css-display-3/display-contents-dynamic-list-001-inline.html:
  • web-platform-tests/css/css-display-3/display-contents-dynamic-list-001-none-expected.html:
  • web-platform-tests/css/css-display-3/display-contents-dynamic-list-001-none.html:
  • web-platform-tests/css/css-display-3/display-contents-dynamic-multicol-001-inline-expected.html:
  • web-platform-tests/css/css-display-3/display-contents-dynamic-multicol-001-inline.html:
  • web-platform-tests/css/css-display-3/display-contents-dynamic-multicol-001-none-expected.html:
  • web-platform-tests/css/css-display-3/display-contents-dynamic-multicol-001-none.html:
  • web-platform-tests/css/css-display-3/display-contents-dynamic-table-001-inline-expected.html:
  • web-platform-tests/css/css-display-3/display-contents-dynamic-table-001-inline.html:
  • web-platform-tests/css/css-display-3/display-contents-dynamic-table-001-none-expected.html:
  • web-platform-tests/css/css-display-3/display-contents-dynamic-table-001-none.html:
  • web-platform-tests/css/css-display-3/display-contents-dynamic-table-002-inline-expected.html:
  • web-platform-tests/css/css-display-3/display-contents-dynamic-table-002-inline.html:
  • web-platform-tests/css/css-display-3/display-contents-dynamic-table-002-none-expected.html:
  • web-platform-tests/css/css-display-3/display-contents-dynamic-table-002-none.html:
  • web-platform-tests/css/css-display-3/display-contents-flex-002-expected.html:
  • web-platform-tests/css/css-display-3/display-contents-flex-002.html:
  • web-platform-tests/css/css-display-3/display-contents-flex-003-expected.html:
  • web-platform-tests/css/css-display-3/display-contents-flex-003.html:
  • web-platform-tests/css/css-display-3/display-contents-inline-flex-001-expected.html:
  • web-platform-tests/css/css-display-3/display-contents-inline-flex-001.html:
  • web-platform-tests/css/css-display-3/display-contents-list-001-expected.html:
  • web-platform-tests/css/css-display-3/display-contents-list-001.html:
  • web-platform-tests/css/css-display-3/display-contents-multicol-001-expected.html:
  • web-platform-tests/css/css-display-3/display-contents-multicol-001.html:
  • web-platform-tests/css/css-display-3/display-contents-table-001-expected.html:
  • web-platform-tests/css/css-display-3/display-contents-table-001.html:
  • web-platform-tests/css/css-display-3/display-contents-table-002-expected.html:
  • web-platform-tests/css/css-display-3/display-contents-table-002.html:
  • web-platform-tests/css/css-display-3/display-flow-root-001-expected.html:
  • web-platform-tests/css/css-display-3/display-flow-root-001.html:
  • web-platform-tests/css/css-grid-1/grid-definition/fr-unit-expected.html:
  • web-platform-tests/css/css-grid-1/grid-definition/fr-unit-with-percentage-expected.html:
  • web-platform-tests/css/css-grid-1/grid-definition/fr-unit-with-percentage.html:
  • web-platform-tests/css/css-grid-1/grid-definition/fr-unit.html:
  • web-platform-tests/css/css-grid-1/grid-items/grid-minimum-size-grid-items-021.html:
  • web-platform-tests/css/css-grid-1/grid-layout-properties.html:
  • web-platform-tests/css/css-grid-1/grid-model/display-grid-expected.html:
  • web-platform-tests/css/css-grid-1/grid-model/display-grid.html:
  • web-platform-tests/css/css-grid-1/grid-model/display-inline-grid-expected.html:
  • web-platform-tests/css/css-grid-1/grid-model/display-inline-grid.html:
  • web-platform-tests/css/css-grid-1/grid-model/grid-display-grid-001.html:
  • web-platform-tests/css/css-grid-1/grid-model/grid-display-inline-grid-001.html:
  • web-platform-tests/css/css-grid-1/grid-model/grid-float-001.html:
  • web-platform-tests/css/css-grid-1/grid-model/grid-inline-float-001.html:
  • web-platform-tests/css/css-grid-1/grid-model/grid-inline-vertical-align-001.html:
  • web-platform-tests/css/css-grid-1/grid-model/grid-support-display-001.html:
  • web-platform-tests/css/css-grid-1/grid-model/grid-vertical-align-001.html:
  • web-platform-tests/css/css-grid-1/test-plan/index.html:
  • web-platform-tests/css/css-pseudo-4/marker-color-expected.html:
  • web-platform-tests/css/css-pseudo-4/marker-color.html:
  • web-platform-tests/css/css-pseudo-4/marker-font-properties.html:
  • web-platform-tests/css/css-shapes-1/shape-outside-invalid-circle-003.html:
  • web-platform-tests/css/css-shapes-1/shape-outside-invalid-ellipse-001.html:
  • web-platform-tests/css/css-shapes-1/shape-outside-invalid-ellipse-002.html:
  • web-platform-tests/css/css-shapes-1/shape-outside-invalid-ellipse-003.html:
  • web-platform-tests/css/css-shapes-1/shape-outside-invalid-inset-001.html:
  • web-platform-tests/css/css-shapes-1/shape-outside-invalid-inset-002.html:
  • web-platform-tests/css/css-shapes-1/spec-examples/shape-outside-001.html:
  • web-platform-tests/css/css-shapes-1/spec-examples/shape-outside-002.html:
  • web-platform-tests/css/css-shapes-1/spec-examples/shape-outside-003.html:
  • web-platform-tests/css/css-shapes-1/spec-examples/shape-outside-004.html:
  • web-platform-tests/css/css-shapes-1/spec-examples/shape-outside-005.html:
  • web-platform-tests/css/css-shapes-1/spec-examples/shape-outside-006.html:
  • web-platform-tests/css/css-shapes-1/spec-examples/shape-outside-007.html:
  • web-platform-tests/css/css-shapes-1/spec-examples/shape-outside-008.html:
  • web-platform-tests/css/css-shapes-1/spec-examples/shape-outside-010.html:
  • web-platform-tests/css/css-shapes-1/spec-examples/shape-outside-011.html:
  • web-platform-tests/css/css-shapes-1/spec-examples/shape-outside-012.html:
  • web-platform-tests/css/css-shapes-1/spec-examples/shape-outside-013.html:
  • web-platform-tests/css/css-shapes-1/spec-examples/shape-outside-014.html:
  • web-platform-tests/css/css-shapes-1/spec-examples/shape-outside-015.html:
  • web-platform-tests/css/css-shapes-1/spec-examples/shape-outside-016.html:
  • web-platform-tests/css/css-shapes-1/spec-examples/shape-outside-017.html:
  • web-platform-tests/css/css-shapes-1/spec-examples/shape-outside-018.html:
  • web-platform-tests/css/css-shapes-1/spec-examples/shape-outside-019.html:
  • web-platform-tests/css/css-shapes-1/test-plan/index.html:
  • web-platform-tests/css/css-ui-3/cursor-image-001.html:
  • web-platform-tests/css/css-ui-3/cursor-image-002.html:
  • web-platform-tests/css/css-ui-3/cursor-image-003.html:
  • web-platform-tests/css/css-ui-3/cursor-image-004.html:
  • web-platform-tests/css/css-ui-3/cursor-image-005-nfs.html:
  • web-platform-tests/css/css-ui-3/cursor-image-005.html:
  • web-platform-tests/css/css-ui-3/cursor-image-009.html:
  • web-platform-tests/css/css-ui-3/cursor-image-012.html:
  • web-platform-tests/css/css-ui-3/cursor-image-png-012.html:
  • web-platform-tests/css/css-ui-3/cursor-image-png-013.html:
  • web-platform-tests/css/css-ui-3/cursor-image-png-027.html:
  • web-platform-tests/css/css-ui-3/cursor-image-png-028.html:
  • web-platform-tests/css/css-ui-3/resize-015.html:
  • web-platform-tests/css/css-ui-3/resize-018.html:
  • web-platform-tests/css/css-ui-3/support/cursors/woolly-64.svg:
  • web-platform-tests/css/css-ui-3/support/cursors/woolly.svg:
  • web-platform-tests/css/css-ui-3/text-overflow-002-expected.html:
  • web-platform-tests/css/css-ui-3/text-overflow-004-expected.html:
  • web-platform-tests/css/css-ui-3/text-overflow-008.html:
  • web-platform-tests/css/css-ui-3/text-overflow-011.html:
  • web-platform-tests/css/css-ui-3/text-overflow-012.html:
  • web-platform-tests/css/css-ui-3/text-overflow-013.html:
  • web-platform-tests/css/css-ui-3/text-overflow-022.html:
  • web-platform-tests/css/css-ui-3/text-overflow-023.html:
  • web-platform-tests/cssom-view/elementFromPoint.html:
  • web-platform-tests/cssom-view/elementsFromPoint.html:
  • web-platform-tests/cssom-view/interfaces.html:
  • web-platform-tests/cssom-view/scrollingElement-quirks-dynamic-001-expected.html:
  • web-platform-tests/cssom-view/scrollingElement-quirks-dynamic-001.html:
  • web-platform-tests/cssom-view/scrollingElement-quirks-dynamic-002-expected.html:
  • web-platform-tests/cssom-view/scrollingElement-quirks-dynamic-002.html:
  • web-platform-tests/cssom/cssom-fontfacerule-constructors.html:
  • web-platform-tests/cssom/cssstyledeclaration-csstext.html:
  • web-platform-tests/cssom/cssstyledeclaration-mutability.html:
  • web-platform-tests/cssom/interfaces.html:
  • web-platform-tests/cssom/medialist-interfaces-002.html:
  • web-platform-tests/cssom/style-sheet-interfaces-002.html:
  • web-platform-tests/cssom/ttwf-cssom-document-extension.html:
  • web-platform-tests/dom/collections/HTMLCollection-supported-property-indices.html:
  • web-platform-tests/dom/collections/HTMLCollection-supported-property-names.html:
  • web-platform-tests/dom/nodes/DOMImplementation-createHTMLDocument.html:
  • web-platform-tests/dom/nodes/Document-adoptNode.html:
  • web-platform-tests/dom/nodes/Document-characterSet-normalization.html:
  • web-platform-tests/dom/nodes/Document-constructor-svg.svg:
  • web-platform-tests/dom/nodes/Document-constructor-xml.xml:
  • web-platform-tests/dom/nodes/Document-constructor.html:
  • web-platform-tests/dom/nodes/Document-doctype.html:
  • web-platform-tests/dom/nodes/Document-getElementById.html:
  • web-platform-tests/dom/nodes/Element-matches.html:
  • web-platform-tests/dom/nodes/Element-webkitMatchesSelector.html:
  • web-platform-tests/dom/nodes/MutationObserver-characterData-expected.txt:
  • web-platform-tests/dom/nodes/MutationObserver-characterData.html:
  • web-platform-tests/dom/nodes/Node-compareDocumentPosition.html:
  • web-platform-tests/dom/nodes/Node-contains.html:
  • web-platform-tests/dom/nodes/Node-lookupPrefix.xhtml:
  • web-platform-tests/dom/nodes/ParentNode-querySelector-All-content.html:
  • web-platform-tests/dom/nodes/ParentNode-querySelector-All-content.xht:
  • web-platform-tests/dom/nodes/getElementsByClassName-14.htm:
  • web-platform-tests/dom/nodes/getElementsByClassName-28.htm:
  • web-platform-tests/dom/traversal/TreeWalker-acceptNode-filter.html:
  • web-platform-tests/dom/traversal/TreeWalker-basic.html:
  • web-platform-tests/dom/traversal/TreeWalker-currentNode.html:
  • web-platform-tests/dom/traversal/TreeWalker-previousNodeLastChildReject.html:
  • web-platform-tests/dom/traversal/TreeWalker-previousSiblingLastChildSkip.html:
  • web-platform-tests/dom/traversal/TreeWalker-traversal-reject.html:
  • web-platform-tests/dom/traversal/TreeWalker-traversal-skip-most.html:
  • web-platform-tests/dom/traversal/TreeWalker-traversal-skip.html:
  • web-platform-tests/dom/traversal/TreeWalker-walking-outside-a-tree.html:
  • web-platform-tests/encrypted-media/clearkey-check-initdata-type.html:
  • web-platform-tests/encrypted-media/clearkey-events-session-closed-event.html:
  • web-platform-tests/encrypted-media/clearkey-events.html:
  • web-platform-tests/encrypted-media/clearkey-generate-request-disallowed-input.html:
  • web-platform-tests/encrypted-media/clearkey-invalid-license.html:
  • web-platform-tests/encrypted-media/clearkey-keystatuses-multiple-sessions.html:
  • web-platform-tests/encrypted-media/clearkey-keystatuses.html:
  • web-platform-tests/encrypted-media/clearkey-mp4-playback-destroy-persistent-license.html:
  • web-platform-tests/encrypted-media/clearkey-mp4-playback-persistent-license-events.html:
  • web-platform-tests/encrypted-media/clearkey-mp4-playback-persistent-license.html:
  • web-platform-tests/encrypted-media/clearkey-mp4-playback-persistent-usage-record-events.html:
  • web-platform-tests/encrypted-media/clearkey-mp4-playback-persistent-usage-record.html:
  • web-platform-tests/encrypted-media/clearkey-mp4-playback-retrieve-destroy-persistent-license.html:
  • web-platform-tests/encrypted-media/clearkey-mp4-playback-retrieve-persistent-license.html:
  • web-platform-tests/encrypted-media/clearkey-mp4-playback-retrieve-persistent-usage-record.html:
  • web-platform-tests/encrypted-media/clearkey-mp4-playback-temporary-clear-encrypted.html:
  • web-platform-tests/encrypted-media/clearkey-mp4-playback-temporary-encrypted-clear-sources.html:
  • web-platform-tests/encrypted-media/clearkey-mp4-playback-temporary-encrypted-clear.html:
  • web-platform-tests/encrypted-media/clearkey-mp4-playback-temporary-events.html:
  • web-platform-tests/encrypted-media/clearkey-mp4-playback-temporary-multikey-sequential-readyState.html:
  • web-platform-tests/encrypted-media/clearkey-mp4-playback-temporary-multikey-sequential.html:
  • web-platform-tests/encrypted-media/clearkey-mp4-playback-temporary-multikey.html:
  • web-platform-tests/encrypted-media/clearkey-mp4-playback-temporary-multisession.html:
  • web-platform-tests/encrypted-media/clearkey-mp4-playback-temporary-setMediaKeys-after-src.html:
  • web-platform-tests/encrypted-media/clearkey-mp4-playback-temporary-setMediaKeys-after-update.html:
  • web-platform-tests/encrypted-media/clearkey-mp4-playback-temporary-setMediaKeys-immediately.html:
  • web-platform-tests/encrypted-media/clearkey-mp4-playback-temporary-setMediaKeys-onencrypted.html:
  • web-platform-tests/encrypted-media/clearkey-mp4-playback-temporary-two-videos.html:
  • web-platform-tests/encrypted-media/clearkey-mp4-playback-temporary-waitingforkey.html:
  • web-platform-tests/encrypted-media/clearkey-mp4-playback-temporary.html:
  • web-platform-tests/encrypted-media/clearkey-mp4-requestmediakeysystemaccess.html:
  • web-platform-tests/encrypted-media/clearkey-mp4-reset-src-after-setmediakeys.html:
  • web-platform-tests/encrypted-media/clearkey-mp4-setmediakeys-again-after-playback.html:
  • web-platform-tests/encrypted-media/clearkey-mp4-setmediakeys-again-after-resetting-src.html:
  • web-platform-tests/encrypted-media/clearkey-mp4-setmediakeys-at-same-time.html:
  • web-platform-tests/encrypted-media/clearkey-mp4-setmediakeys-multiple-times-with-different-mediakeys.html:
  • web-platform-tests/encrypted-media/clearkey-mp4-setmediakeys-multiple-times-with-the-same-mediakeys.html:
  • web-platform-tests/encrypted-media/clearkey-mp4-setmediakeys-to-multiple-video-elements.html:
  • web-platform-tests/encrypted-media/clearkey-mp4-setmediakeys.html:
  • web-platform-tests/encrypted-media/clearkey-mp4-syntax-mediakeys.html:
  • web-platform-tests/encrypted-media/clearkey-mp4-syntax-mediakeysession.html:
  • web-platform-tests/encrypted-media/clearkey-mp4-syntax-mediakeysystemaccess.html:
  • web-platform-tests/encrypted-media/clearkey-mp4-unique-origin.html:
  • web-platform-tests/encrypted-media/clearkey-mp4-update-disallowed-input.html:
  • web-platform-tests/encrypted-media/clearkey-mp4-waiting-for-a-key.html:
  • web-platform-tests/encrypted-media/clearkey-not-callable-after-createsession.html:
  • web-platform-tests/encrypted-media/clearkey-update-non-ascii-input.html:
  • web-platform-tests/encrypted-media/drm-check-initdata-type.html:
  • web-platform-tests/encrypted-media/drm-events-session-closed-event.html:
  • web-platform-tests/encrypted-media/drm-events.html:
  • web-platform-tests/encrypted-media/drm-expiration.html:
  • web-platform-tests/encrypted-media/drm-generate-request-disallowed-input.html:
  • web-platform-tests/encrypted-media/drm-invalid-license.html:
  • web-platform-tests/encrypted-media/drm-keystatuses-multiple-sessions.html:
  • web-platform-tests/encrypted-media/drm-keystatuses.html:
  • web-platform-tests/encrypted-media/drm-mp4-onencrypted.html:
  • web-platform-tests/encrypted-media/drm-mp4-playback-destroy-persistent-license.html:
  • web-platform-tests/encrypted-media/drm-mp4-playback-persistent-license-events.html:
  • web-platform-tests/encrypted-media/drm-mp4-playback-persistent-license.html:
  • web-platform-tests/encrypted-media/drm-mp4-playback-persistent-usage-record-events.html:
  • web-platform-tests/encrypted-media/drm-mp4-playback-persistent-usage-record.html:
  • web-platform-tests/encrypted-media/drm-mp4-playback-retrieve-destroy-persistent-license.html:
  • web-platform-tests/encrypted-media/drm-mp4-playback-retrieve-persistent-license.html:
  • web-platform-tests/encrypted-media/drm-mp4-playback-retrieve-persistent-usage-record.html:
  • web-platform-tests/encrypted-media/drm-mp4-playback-temporary-clear-encrypted.html:
  • web-platform-tests/encrypted-media/drm-mp4-playback-temporary-encrypted-clear-sources.html:
  • web-platform-tests/encrypted-media/drm-mp4-playback-temporary-encrypted-clear.html:
  • web-platform-tests/encrypted-media/drm-mp4-playback-temporary-events.html:
  • web-platform-tests/encrypted-media/drm-mp4-playback-temporary-expired.html:
  • web-platform-tests/encrypted-media/drm-mp4-playback-temporary-multikey-sequential-readyState.html:
  • web-platform-tests/encrypted-media/drm-mp4-playback-temporary-multikey-sequential.html:
  • web-platform-tests/encrypted-media/drm-mp4-playback-temporary-multikey.html:
  • web-platform-tests/encrypted-media/drm-mp4-playback-temporary-multisession.html:
  • web-platform-tests/encrypted-media/drm-mp4-playback-temporary-setMediaKeys-after-src.html:
  • web-platform-tests/encrypted-media/drm-mp4-playback-temporary-setMediaKeys-after-update.html:
  • web-platform-tests/encrypted-media/drm-mp4-playback-temporary-setMediaKeys-immediately.html:
  • web-platform-tests/encrypted-media/drm-mp4-playback-temporary-setMediaKeys-onencrypted.html:
  • web-platform-tests/encrypted-media/drm-mp4-playback-temporary-two-videos.html:
  • web-platform-tests/encrypted-media/drm-mp4-playback-temporary-waitingforkey.html:
  • web-platform-tests/encrypted-media/drm-mp4-playback-temporary.html:
  • web-platform-tests/encrypted-media/drm-mp4-requestmediakeysystemaccess.html:
  • web-platform-tests/encrypted-media/drm-mp4-reset-src-after-setmediakeys.html:
  • web-platform-tests/encrypted-media/drm-mp4-setmediakeys-again-after-playback.html:
  • web-platform-tests/encrypted-media/drm-mp4-setmediakeys-again-after-resetting-src.html:
  • web-platform-tests/encrypted-media/drm-mp4-setmediakeys-at-same-time.html:
  • web-platform-tests/encrypted-media/drm-mp4-setmediakeys-multiple-times-with-different-mediakeys.html:
  • web-platform-tests/encrypted-media/drm-mp4-setmediakeys-multiple-times-with-the-same-mediakeys.html:
  • web-platform-tests/encrypted-media/drm-mp4-setmediakeys-to-multiple-video-elements.html:
  • web-platform-tests/encrypted-media/drm-mp4-setmediakeys.html:
  • web-platform-tests/encrypted-media/drm-mp4-syntax-mediakeys.html:
  • web-platform-tests/encrypted-media/drm-mp4-syntax-mediakeysession.html:
  • web-platform-tests/encrypted-media/drm-mp4-syntax-mediakeysystemaccess.html:
  • web-platform-tests/encrypted-media/drm-mp4-unique-origin.html:
  • web-platform-tests/encrypted-media/drm-mp4-waiting-for-a-key.html:
  • web-platform-tests/encrypted-media/drm-not-callable-after-createsession.html:
  • web-platform-tests/encrypted-media/drm-temporary-license-type.html:
  • web-platform-tests/encrypted-media/resources/clearkey-retrieve-destroy-persistent-license.html:
  • web-platform-tests/encrypted-media/resources/clearkey-retrieve-persistent-license.html:
  • web-platform-tests/encrypted-media/resources/drm-retrieve-destroy-persistent-license.html:
  • web-platform-tests/encrypted-media/resources/drm-retrieve-persistent-license.html:
  • web-platform-tests/encrypted-media/resources/drm-retrieve-persistent-usage-record.html:
  • web-platform-tests/encrypted-media/resources/retrieve-persistent-usage-record.html:
  • web-platform-tests/eventsource/dedicated-worker/eventsource-close.htm:
  • web-platform-tests/eventsource/dedicated-worker/eventsource-constructor-non-same-origin.htm:
  • web-platform-tests/eventsource/dedicated-worker/eventsource-constructor-url-bogus.htm:
  • web-platform-tests/eventsource/dedicated-worker/eventsource-onmesage.htm:
  • web-platform-tests/eventsource/dedicated-worker/eventsource-onopen.htm:
  • web-platform-tests/eventsource/dedicated-worker/eventsource-prototype.htm:
  • web-platform-tests/eventsource/dedicated-worker/eventsource-url.htm:
  • web-platform-tests/eventsource/eventsource-constructor-document-domain.htm:
  • web-platform-tests/eventsource/eventsource-constructor-non-same-origin.htm:
  • web-platform-tests/eventsource/eventsource-onmessage-trusted.htm:
  • web-platform-tests/eventsource/eventsource-prototype.htm:
  • web-platform-tests/eventsource/format-leading-space.htm:
  • web-platform-tests/eventsource/format-mime-bogus.htm:
  • web-platform-tests/eventsource/format-mime-valid-bogus.htm:
  • web-platform-tests/eventsource/shared-worker/eventsource-close.htm:
  • web-platform-tests/eventsource/shared-worker/eventsource-constructor-non-same-origin.htm:
  • web-platform-tests/eventsource/shared-worker/eventsource-constructor-url-bogus.htm:
  • web-platform-tests/eventsource/shared-worker/eventsource-eventtarget.htm:
  • web-platform-tests/eventsource/shared-worker/eventsource-onmesage.htm:
  • web-platform-tests/eventsource/shared-worker/eventsource-onopen.htm:
  • web-platform-tests/eventsource/shared-worker/eventsource-prototype.htm:
  • web-platform-tests/eventsource/shared-worker/eventsource-url.htm:
  • web-platform-tests/fetch/api/request/multi-globals/url-parsing.html:
  • web-platform-tests/fetch/api/resources/basic.html:
  • web-platform-tests/fetch/api/response/multi-globals/url-parsing.html:
  • web-platform-tests/fetch/api/response/response-trailer.html:
  • web-platform-tests/fetch/nosniff/stylesheet.html:
  • web-platform-tests/html/browsers/browsing-the-web/history-traversal/unset_context_name.html:
  • web-platform-tests/html/browsers/browsing-the-web/navigating-across-documents/012.html:
  • web-platform-tests/html/browsers/browsing-the-web/navigating-across-documents/navigation-unload-form-submit.html:
  • web-platform-tests/html/browsers/browsing-the-web/navigating-across-documents/navigation-unload-same-origin-fragment.html:
  • web-platform-tests/html/browsers/browsing-the-web/scroll-to-fragid/001.html:
  • web-platform-tests/html/browsers/browsing-the-web/scroll-to-fragid/002.html:
  • web-platform-tests/html/browsers/browsing-the-web/scroll-to-fragid/003.html:
  • web-platform-tests/html/browsers/browsing-the-web/scroll-to-fragid/004.html:
  • web-platform-tests/html/browsers/browsing-the-web/scroll-to-fragid/005.html:
  • web-platform-tests/html/browsers/browsing-the-web/scroll-to-fragid/006.html:
  • web-platform-tests/html/browsers/browsing-the-web/scroll-to-fragid/007.html:
  • web-platform-tests/html/browsers/browsing-the-web/scroll-to-fragid/forward-triggers-hashchange.html:
  • web-platform-tests/html/browsers/history/the-history-interface/008.html:
  • web-platform-tests/html/browsers/history/the-location-interface/cross_origin_joined_frame.sub.html:
  • web-platform-tests/html/browsers/history/the-location-interface/location-protocol-setter-non-broken-weird.html:
  • web-platform-tests/html/browsers/history/the-location-interface/location-protocol-setter-non-broken.html:
  • web-platform-tests/html/browsers/history/the-location-interface/location-protocol-setter-with-colon.sub.html:
  • web-platform-tests/html/browsers/history/the-location-interface/location-tojson.html:
  • web-platform-tests/html/browsers/history/the-location-interface/same_origin_frame.html:
  • web-platform-tests/html/browsers/offline/resources/html/clock.html:
  • web-platform-tests/html/browsers/origin/cross-origin-objects/frame.html:
  • web-platform-tests/html/browsers/origin/relaxing-the-same-origin-restriction/document_domain_setter_null.tentative.html:
  • web-platform-tests/html/browsers/origin/relaxing-the-same-origin-restriction/document_domain_setter_srcdoc.html:
  • web-platform-tests/html/browsers/the-window-object/apis-for-creating-and-navigating-browsing-contexts-by-name/open-features-negative-innerwidth-innerheight.html:
  • web-platform-tests/html/browsers/the-window-object/apis-for-creating-and-navigating-browsing-contexts-by-name/open-features-negative-screenx-screeny.html:
  • web-platform-tests/html/browsers/the-window-object/apis-for-creating-and-navigating-browsing-contexts-by-name/open-features-negative-top-left.html:
  • web-platform-tests/html/browsers/the-window-object/apis-for-creating-and-navigating-browsing-contexts-by-name/open-features-negative-width-height.html:
  • web-platform-tests/html/browsers/the-window-object/apis-for-creating-and-navigating-browsing-contexts-by-name/open-features-non-integer-height.html:
  • web-platform-tests/html/browsers/the-window-object/apis-for-creating-and-navigating-browsing-contexts-by-name/open-features-non-integer-innerheight.html:
  • web-platform-tests/html/browsers/the-window-object/apis-for-creating-and-navigating-browsing-contexts-by-name/open-features-non-integer-innerwidth.html:
  • web-platform-tests/html/browsers/the-window-object/apis-for-creating-and-navigating-browsing-contexts-by-name/open-features-non-integer-left.html:
  • web-platform-tests/html/browsers/the-window-object/apis-for-creating-and-navigating-browsing-contexts-by-name/open-features-non-integer-screenx.html:
  • web-platform-tests/html/browsers/the-window-object/apis-for-creating-and-navigating-browsing-contexts-by-name/open-features-non-integer-screeny.html:
  • web-platform-tests/html/browsers/the-window-object/apis-for-creating-and-navigating-browsing-contexts-by-name/open-features-non-integer-top.html:
  • web-platform-tests/html/browsers/the-window-object/apis-for-creating-and-navigating-browsing-contexts-by-name/open-features-non-integer-width.html:
  • web-platform-tests/html/browsers/the-window-object/apis-for-creating-and-navigating-browsing-contexts-by-name/open-features-tokenization-innerheight-innerwidth.html:
  • web-platform-tests/html/browsers/the-window-object/apis-for-creating-and-navigating-browsing-contexts-by-name/open-features-tokenization-screenx-screeny.html:
  • web-platform-tests/html/browsers/the-window-object/apis-for-creating-and-navigating-browsing-contexts-by-name/open-features-tokenization-top-left.html:
  • web-platform-tests/html/browsers/the-window-object/apis-for-creating-and-navigating-browsing-contexts-by-name/open-features-tokenization-width-height.html:
  • web-platform-tests/html/dom/documents/dom-tree-accessors/Document.currentScript.html:
  • web-platform-tests/html/dom/elements/global-attributes/the-lang-attribute-001.html:
  • web-platform-tests/html/dom/elements/global-attributes/the-lang-attribute-002.html:
  • web-platform-tests/html/dom/elements/global-attributes/the-lang-attribute-003.html:
  • web-platform-tests/html/dom/elements/global-attributes/the-lang-attribute-004.html:
  • web-platform-tests/html/dom/elements/global-attributes/the-lang-attribute-005.html:
  • web-platform-tests/html/dom/elements/global-attributes/the-lang-attribute-006.html:
  • web-platform-tests/html/dom/elements/global-attributes/the-lang-attribute-007.html:
  • web-platform-tests/html/dom/elements/global-attributes/the-lang-attribute-008.html:
  • web-platform-tests/html/dom/elements/global-attributes/the-lang-attribute-009.html:
  • web-platform-tests/html/dom/elements/global-attributes/the-lang-attribute-010.html:
  • web-platform-tests/html/dom/interfaces.html:
  • web-platform-tests/html/dom/self-origin.sub.html:
  • web-platform-tests/html/semantics/document-metadata/the-meta-element/the-lang-attribute-012.html:
  • web-platform-tests/html/semantics/embedded-content/media-elements/user-interface/muted.html:
  • web-platform-tests/html/semantics/embedded-content/the-canvas-element/2d.canvas.readonly.html:
  • web-platform-tests/html/semantics/embedded-content/the-canvas-element/2d.canvas.reference.html:
  • web-platform-tests/html/semantics/embedded-content/the-canvas-element/2d.getcontext.exists.html:
  • web-platform-tests/html/semantics/embedded-content/the-canvas-element/2d.getcontext.extraargs.html:
  • web-platform-tests/html/semantics/embedded-content/the-canvas-element/2d.getcontext.shared.html:
  • web-platform-tests/html/semantics/embedded-content/the-canvas-element/2d.getcontext.unique.html:
  • web-platform-tests/html/semantics/embedded-content/the-canvas-element/2d.type.exists.html:
  • web-platform-tests/html/semantics/embedded-content/the-canvas-element/2d.type.extend.html:
  • web-platform-tests/html/semantics/embedded-content/the-canvas-element/2d.type.prototype.html:
  • web-platform-tests/html/semantics/embedded-content/the-canvas-element/2d.type.replace.html:
  • web-platform-tests/html/semantics/embedded-content/the-canvas-element/context.arguments.missing.html:
  • web-platform-tests/html/semantics/embedded-content/the-canvas-element/context.casesensitive.html:
  • web-platform-tests/html/semantics/embedded-content/the-canvas-element/context.emptystring.html:
  • web-platform-tests/html/semantics/embedded-content/the-canvas-element/context.unrecognised.badname.html:
  • web-platform-tests/html/semantics/embedded-content/the-canvas-element/context.unrecognised.badsuffix.html:
  • web-platform-tests/html/semantics/embedded-content/the-canvas-element/context.unrecognised.nullsuffix.html:
  • web-platform-tests/html/semantics/embedded-content/the-canvas-element/context.unrecognised.unicode.html:
  • web-platform-tests/html/semantics/embedded-content/the-canvas-element/fallback.basic.html:
  • web-platform-tests/html/semantics/embedded-content/the-canvas-element/fallback.multiple.html:
  • web-platform-tests/html/semantics/embedded-content/the-canvas-element/fallback.nested.html:
  • web-platform-tests/html/semantics/embedded-content/the-canvas-element/initial.colour.html:
  • web-platform-tests/html/semantics/embedded-content/the-canvas-element/initial.reset.2dstate.html:
  • web-platform-tests/html/semantics/embedded-content/the-canvas-element/initial.reset.clip.html:
  • web-platform-tests/html/semantics/embedded-content/the-canvas-element/initial.reset.different.html:
  • web-platform-tests/html/semantics/embedded-content/the-canvas-element/initial.reset.gradient.html:
  • web-platform-tests/html/semantics/embedded-content/the-canvas-element/initial.reset.path.html:
  • web-platform-tests/html/semantics/embedded-content/the-canvas-element/initial.reset.pattern.html:
  • web-platform-tests/html/semantics/embedded-content/the-canvas-element/initial.reset.same.html:
  • web-platform-tests/html/semantics/embedded-content/the-canvas-element/initial.reset.transform.html:
  • web-platform-tests/html/semantics/embedded-content/the-canvas-element/security.dataURI.html:
  • web-platform-tests/html/semantics/embedded-content/the-canvas-element/security.drawImage.canvas.cross.html:
  • web-platform-tests/html/semantics/embedded-content/the-canvas-element/security.drawImage.canvas.redirect.html:
  • web-platform-tests/html/semantics/embedded-content/the-canvas-element/security.drawImage.image.cross.html:
  • web-platform-tests/html/semantics/embedded-content/the-canvas-element/security.drawImage.image.redirect.html:
  • web-platform-tests/html/semantics/embedded-content/the-canvas-element/security.pattern.canvas.fillStyle.cross.html:
  • web-platform-tests/html/semantics/embedded-content/the-canvas-element/security.pattern.canvas.fillStyle.redirect.html:
  • web-platform-tests/html/semantics/embedded-content/the-canvas-element/security.pattern.canvas.strokeStyle.cross.html:
  • web-platform-tests/html/semantics/embedded-content/the-canvas-element/security.pattern.canvas.strokeStyle.redirect.html:
  • web-platform-tests/html/semantics/embedded-content/the-canvas-element/security.pattern.canvas.timing.cross.html:
  • web-platform-tests/html/semantics/embedded-content/the-canvas-element/security.pattern.canvas.timing.redirect.html:
  • web-platform-tests/html/semantics/embedded-content/the-canvas-element/security.pattern.create.cross.html:
  • web-platform-tests/html/semantics/embedded-content/the-canvas-element/security.pattern.create.redirect.html:
  • web-platform-tests/html/semantics/embedded-content/the-canvas-element/security.pattern.cross.cross.html:
  • web-platform-tests/html/semantics/embedded-content/the-canvas-element/security.pattern.cross.redirect.html:
  • web-platform-tests/html/semantics/embedded-content/the-canvas-element/security.pattern.image.fillStyle.cross.html:
  • web-platform-tests/html/semantics/embedded-content/the-canvas-element/security.pattern.image.fillStyle.redirect.html:
  • web-platform-tests/html/semantics/embedded-content/the-canvas-element/security.pattern.image.strokeStyle.cross.html:
  • web-platform-tests/html/semantics/embedded-content/the-canvas-element/security.pattern.image.strokeStyle.redirect.html:
  • web-platform-tests/html/semantics/embedded-content/the-canvas-element/security.reset.cross.html:
  • web-platform-tests/html/semantics/embedded-content/the-canvas-element/security.reset.redirect.html:
  • web-platform-tests/html/semantics/embedded-content/the-canvas-element/size.attributes.default.html:
  • web-platform-tests/html/semantics/embedded-content/the-canvas-element/size.attributes.idl.html:
  • web-platform-tests/html/semantics/embedded-content/the-canvas-element/size.attributes.idl.set.zero.html:
  • web-platform-tests/html/semantics/embedded-content/the-canvas-element/size.attributes.parse.decimal.html:
  • web-platform-tests/html/semantics/embedded-content/the-canvas-element/size.attributes.parse.em.html:
  • web-platform-tests/html/semantics/embedded-content/the-canvas-element/size.attributes.parse.empty.html:
  • web-platform-tests/html/semantics/embedded-content/the-canvas-element/size.attributes.parse.exp.html:
  • web-platform-tests/html/semantics/embedded-content/the-canvas-element/size.attributes.parse.hex.html:
  • web-platform-tests/html/semantics/embedded-content/the-canvas-element/size.attributes.parse.junk.html:
  • web-platform-tests/html/semantics/embedded-content/the-canvas-element/size.attributes.parse.minus.html:
  • web-platform-tests/html/semantics/embedded-content/the-canvas-element/size.attributes.parse.octal.html:
  • web-platform-tests/html/semantics/embedded-content/the-canvas-element/size.attributes.parse.onlyspace.html:
  • web-platform-tests/html/semantics/embedded-content/the-canvas-element/size.attributes.parse.percent.html:
  • web-platform-tests/html/semantics/embedded-content/the-canvas-element/size.attributes.parse.plus.html:
  • web-platform-tests/html/semantics/embedded-content/the-canvas-element/size.attributes.parse.space.html:
  • web-platform-tests/html/semantics/embedded-content/the-canvas-element/size.attributes.parse.trailingjunk.html:
  • web-platform-tests/html/semantics/embedded-content/the-canvas-element/size.attributes.parse.zero.html:
  • web-platform-tests/html/semantics/embedded-content/the-canvas-element/size.attributes.reflect.setcontent.html:
  • web-platform-tests/html/semantics/embedded-content/the-canvas-element/size.attributes.reflect.setidl.html:
  • web-platform-tests/html/semantics/embedded-content/the-canvas-element/size.attributes.reflect.setidlzero.html:
  • web-platform-tests/html/semantics/embedded-content/the-canvas-element/size.attributes.removed.html:
  • web-platform-tests/html/semantics/embedded-content/the-canvas-element/size.attributes.setAttribute.decimal.html:
  • web-platform-tests/html/semantics/embedded-content/the-canvas-element/size.attributes.setAttribute.em.html:
  • web-platform-tests/html/semantics/embedded-content/the-canvas-element/size.attributes.setAttribute.empty.html:
  • web-platform-tests/html/semantics/embedded-content/the-canvas-element/size.attributes.setAttribute.exp.html:
  • web-platform-tests/html/semantics/embedded-content/the-canvas-element/size.attributes.setAttribute.hex.html:
  • web-platform-tests/html/semantics/embedded-content/the-canvas-element/size.attributes.setAttribute.junk.html:
  • web-platform-tests/html/semantics/embedded-content/the-canvas-element/size.attributes.setAttribute.minus.html:
  • web-platform-tests/html/semantics/embedded-content/the-canvas-element/size.attributes.setAttribute.octal.html:
  • web-platform-tests/html/semantics/embedded-content/the-canvas-element/size.attributes.setAttribute.onlyspace.html:
  • web-platform-tests/html/semantics/embedded-content/the-canvas-element/size.attributes.setAttribute.percent.html:
  • web-platform-tests/html/semantics/embedded-content/the-canvas-element/size.attributes.setAttribute.plus.html:
  • web-platform-tests/html/semantics/embedded-content/the-canvas-element/size.attributes.setAttribute.space.html:
  • web-platform-tests/html/semantics/embedded-content/the-canvas-element/size.attributes.setAttribute.trailingjunk.html:
  • web-platform-tests/html/semantics/embedded-content/the-canvas-element/size.attributes.setAttribute.whitespace.html:
  • web-platform-tests/html/semantics/embedded-content/the-canvas-element/size.attributes.setAttribute.zero.html:
  • web-platform-tests/html/semantics/embedded-content/the-canvas-element/size.attributes.style.html:
  • web-platform-tests/html/semantics/embedded-content/the-canvas-element/toDataURL.arguments.1.html:
  • web-platform-tests/html/semantics/embedded-content/the-canvas-element/toDataURL.arguments.2.html:
  • web-platform-tests/html/semantics/embedded-content/the-canvas-element/toDataURL.arguments.3.html:
  • web-platform-tests/html/semantics/embedded-content/the-canvas-element/toDataURL.bogustype.html:
  • web-platform-tests/html/semantics/embedded-content/the-canvas-element/toDataURL.default.html:
  • web-platform-tests/html/semantics/embedded-content/the-canvas-element/toDataURL.jpeg.alpha.html:
  • web-platform-tests/html/semantics/embedded-content/the-canvas-element/toDataURL.jpeg.primarycolours.html:
  • web-platform-tests/html/semantics/embedded-content/the-canvas-element/toDataURL.jpeg.quality.basic.html:
  • web-platform-tests/html/semantics/embedded-content/the-canvas-element/toDataURL.jpeg.quality.notnumber.html:
  • web-platform-tests/html/semantics/embedded-content/the-canvas-element/toDataURL.jpeg.quality.outsiderange.html:
  • web-platform-tests/html/semantics/embedded-content/the-canvas-element/toDataURL.jpg.html:
  • web-platform-tests/html/semantics/embedded-content/the-canvas-element/toDataURL.lowercase.ascii.html:
  • web-platform-tests/html/semantics/embedded-content/the-canvas-element/toDataURL.lowercase.unicode.html:
  • web-platform-tests/html/semantics/embedded-content/the-canvas-element/toDataURL.nocontext.html:
  • web-platform-tests/html/semantics/embedded-content/the-canvas-element/toDataURL.png.complexcolours.html:
  • web-platform-tests/html/semantics/embedded-content/the-canvas-element/toDataURL.png.html:
  • web-platform-tests/html/semantics/embedded-content/the-canvas-element/toDataURL.png.primarycolours.html:
  • web-platform-tests/html/semantics/embedded-content/the-canvas-element/toDataURL.unrecognised.html:
  • web-platform-tests/html/semantics/embedded-content/the-canvas-element/toDataURL.zeroheight.html:
  • web-platform-tests/html/semantics/embedded-content/the-canvas-element/toDataURL.zerosize.html:
  • web-platform-tests/html/semantics/embedded-content/the-canvas-element/toDataURL.zerowidth.html:
  • web-platform-tests/html/semantics/embedded-content/the-canvas-element/type.delete.html:
  • web-platform-tests/html/semantics/embedded-content/the-canvas-element/type.exists.html:
  • web-platform-tests/html/semantics/embedded-content/the-canvas-element/type.extend.html:
  • web-platform-tests/html/semantics/embedded-content/the-canvas-element/type.name.html:
  • web-platform-tests/html/semantics/embedded-content/the-canvas-element/type.prototype.html:
  • web-platform-tests/html/semantics/embedded-content/the-canvas-element/type.replace.html:
  • web-platform-tests/html/semantics/embedded-content/the-embed-element/embed-in-object-fallback.html:
  • web-platform-tests/html/semantics/embedded-content/the-iframe-element/iframe_sandbox_allow_top_navigation-3.html:
  • web-platform-tests/html/semantics/embedded-content/the-img-element/adoption.html:
  • web-platform-tests/html/semantics/embedded-content/the-img-element/current-pixel-density/basic.html:
  • web-platform-tests/html/semantics/embedded-content/the-img-element/non-active-document.html:
  • web-platform-tests/html/semantics/embedded-content/the-img-element/sizes/sizes-iframed.sub.html:
  • web-platform-tests/html/semantics/embedded-content/the-img-element/srcset/parse-a-srcset-attribute.html:
  • web-platform-tests/html/semantics/embedded-content/the-img-element/srcset/select-an-image-source.html:
  • web-platform-tests/html/semantics/embedded-content/the-img-element/update-the-source-set-expected.txt:
  • web-platform-tests/html/semantics/embedded-content/the-img-element/update-the-source-set.html:
  • web-platform-tests/html/semantics/forms/form-control-infrastructure/form.html:
  • web-platform-tests/html/semantics/forms/the-form-element/form-elements-filter.html:
  • web-platform-tests/html/semantics/forms/the-form-element/form-nameditem.html:
  • web-platform-tests/html/semantics/grouping-content/the-pre-element/grouping-pre-reftest-001.html:
  • web-platform-tests/html/semantics/interactive-elements/the-details-element/details.html:
  • web-platform-tests/html/semantics/interactive-elements/the-dialog-element/centering-iframe.sub.html:
  • web-platform-tests/html/semantics/scripting-1/the-script-element/load-error-events-1.html:
  • web-platform-tests/html/semantics/scripting-1/the-script-element/load-error-events-2.html:
  • web-platform-tests/html/semantics/scripting-1/the-script-element/nomodule-set-on-async-classic-script.html:
  • web-platform-tests/html/semantics/scripting-1/the-script-element/script-charset-01.html:
  • web-platform-tests/html/semantics/scripting-1/the-script-element/script-charset-02.html:
  • web-platform-tests/html/semantics/scripting-1/the-script-element/script-type-and-language-empty.html:
  • web-platform-tests/html/semantics/scripting-1/the-script-element/script-type-and-language-with-params.html:
  • web-platform-tests/html/semantics/selectors/pseudo-classes/checked.html:
  • web-platform-tests/html/semantics/selectors/pseudo-classes/enabled.html:
  • web-platform-tests/html/semantics/selectors/pseudo-classes/inrange-outofrange.html:
  • web-platform-tests/html/semantics/selectors/pseudo-classes/readwrite-readonly.html:
  • web-platform-tests/html/semantics/tabular-data/processing-model-1/span-limits.html:
  • web-platform-tests/html/semantics/text-level-semantics/the-a-element/a.text-getter-01.html:
  • web-platform-tests/html/semantics/text-level-semantics/the-a-element/a.text-setter-01.html:
  • web-platform-tests/html/semantics/text-level-semantics/the-time-element/001.html:
  • web-platform-tests/html/syntax/parsing-html-fragments/the-input-byte-stream-001.html:
  • web-platform-tests/html/syntax/parsing-html-fragments/the-input-byte-stream-007.html:
  • web-platform-tests/html/syntax/parsing-html-fragments/the-input-byte-stream-009.html:
  • web-platform-tests/html/syntax/parsing-html-fragments/the-input-byte-stream-016.html:
  • web-platform-tests/html/syntax/parsing-html-fragments/the-input-byte-stream-018.html:
  • web-platform-tests/html/syntax/parsing-html-fragments/the-input-byte-stream-030.html:
  • web-platform-tests/html/syntax/parsing-html-fragments/the-input-byte-stream-034.html:
  • web-platform-tests/html/syntax/parsing-html-fragments/the-input-byte-stream-037.html:
  • web-platform-tests/html/syntax/parsing-html-fragments/the-input-byte-stream-038.html:
  • web-platform-tests/html/syntax/parsing/Element.getElementsByTagName-foreign-02.html:
  • web-platform-tests/html/syntax/parsing/math-parse03.html:
  • web-platform-tests/html/syntax/parsing/named-character-references.html:
  • web-platform-tests/html/syntax/serializing-html-fragments/serializing-expected.txt:
  • web-platform-tests/html/syntax/serializing-html-fragments/serializing.html:
  • web-platform-tests/html/webappapis/atob/base64.html:
  • web-platform-tests/html/webappapis/scripting/events/eventhandler-cancellation.html:
  • web-platform-tests/html/webappapis/scripting/events/resources/compiled-event-handler-settings-objects-support.html:
  • web-platform-tests/html/webappapis/scripting/processing-model-2/compile-error-in-body-onerror.html:
  • web-platform-tests/html/webappapis/scripting/processing-model-2/window-onerror-parse-error.html:
  • web-platform-tests/html/webappapis/scripting/processing-model-2/window-onerror-runtime-error-throw.html:
  • web-platform-tests/html/webappapis/scripting/processing-model-2/window-onerror-runtime-error.html:
  • web-platform-tests/media-source/mediasource-activesourcebuffers.html:
  • web-platform-tests/media-source/mediasource-addsourcebuffer.html:
  • web-platform-tests/media-source/mediasource-append-buffer.html:
  • web-platform-tests/media-source/mediasource-appendbuffer-quota-exceeded.html:
  • web-platform-tests/media-source/mediasource-appendwindow.html:
  • web-platform-tests/media-source/mediasource-attach-stops-delaying-load-event.html:
  • web-platform-tests/media-source/mediasource-avtracks.html:
  • web-platform-tests/media-source/mediasource-buffered.html:
  • web-platform-tests/media-source/mediasource-closed.html:
  • web-platform-tests/media-source/mediasource-config-change-mp4-a-bitrate.html:
  • web-platform-tests/media-source/mediasource-config-change-mp4-av-audio-bitrate.html:
  • web-platform-tests/media-source/mediasource-config-change-mp4-av-framesize.html:
  • web-platform-tests/media-source/mediasource-config-change-mp4-av-video-bitrate.html:
  • web-platform-tests/media-source/mediasource-config-change-mp4-v-bitrate.html:
  • web-platform-tests/media-source/mediasource-config-change-mp4-v-framerate.html:
  • web-platform-tests/media-source/mediasource-config-change-mp4-v-framesize.html:
  • web-platform-tests/media-source/mediasource-config-change-webm-a-bitrate.html:
  • web-platform-tests/media-source/mediasource-config-change-webm-av-audio-bitrate.html:
  • web-platform-tests/media-source/mediasource-config-change-webm-av-framesize.html:
  • web-platform-tests/media-source/mediasource-config-change-webm-av-video-bitrate.html:
  • web-platform-tests/media-source/mediasource-config-change-webm-v-bitrate.html:
  • web-platform-tests/media-source/mediasource-config-change-webm-v-framerate.html:
  • web-platform-tests/media-source/mediasource-config-change-webm-v-framesize.html:
  • web-platform-tests/media-source/mediasource-detach.html:
  • web-platform-tests/media-source/mediasource-duration-boundaryconditions.html:
  • web-platform-tests/media-source/mediasource-duration.html:
  • web-platform-tests/media-source/mediasource-endofstream-invaliderror.html:
  • web-platform-tests/media-source/mediasource-errors.html:
  • web-platform-tests/media-source/mediasource-getvideoplaybackquality.html:
  • web-platform-tests/media-source/mediasource-is-type-supported.html:
  • web-platform-tests/media-source/mediasource-liveseekable.html:
  • web-platform-tests/media-source/mediasource-multiple-attach.html:
  • web-platform-tests/media-source/mediasource-play-then-seek-back.html:
  • web-platform-tests/media-source/mediasource-play.html:
  • web-platform-tests/media-source/mediasource-preload.html:
  • web-platform-tests/media-source/mediasource-redundant-seek.html:
  • web-platform-tests/media-source/mediasource-remove.html:
  • web-platform-tests/media-source/mediasource-removesourcebuffer.html:
  • web-platform-tests/media-source/mediasource-seek-beyond-duration.html:
  • web-platform-tests/media-source/mediasource-seek-during-pending-seek.html:
  • web-platform-tests/media-source/mediasource-seekable.html:
  • web-platform-tests/media-source/mediasource-sequencemode-append-buffer.html:
  • web-platform-tests/media-source/mediasource-sourcebuffer-mode.html:
  • web-platform-tests/media-source/mediasource-sourcebuffer-trackdefaults.html:
  • web-platform-tests/media-source/mediasource-sourcebufferlist.html:
  • web-platform-tests/media-source/mediasource-timestamp-offset.html:
  • web-platform-tests/media-source/mediasource-trackdefault.html:
  • web-platform-tests/media-source/mediasource-trackdefaultlist.html:
  • web-platform-tests/mediacapture-streams/MediaStream-MediaElement-preload-none.https.html:
  • web-platform-tests/resource-timing/resource-timing.html:
  • web-platform-tests/resource-timing/resources/resource_timing_test0.xml:
  • web-platform-tests/resources/test/tests/iframe-consolidate-errors.html:
  • web-platform-tests/resources/test/tests/iframe-consolidate-tests.html:
  • web-platform-tests/resources/test/tests/iframe-msg.html:
  • web-platform-tests/service-workers/service-worker/fetch-response-taint.https.html:
  • web-platform-tests/service-workers/service-worker/multi-globals/url-parsing.https.html:
  • web-platform-tests/service-workers/service-worker/multiple-update.https.html:
  • web-platform-tests/service-workers/service-worker/resources/appcache-ordering.is-appcached.html:
  • web-platform-tests/service-workers/service-worker/resources/clients-matchall-client-types-iframe.html:
  • web-platform-tests/service-workers/service-worker/update-after-oneday.https.html:
  • web-platform-tests/service-workers/stub-3.1-service-worker-obj.html:
  • web-platform-tests/service-workers/stub-3.1.1-service-worker-scope.html:
  • web-platform-tests/service-workers/stub-3.1.2-service-worker-url.html:
  • web-platform-tests/service-workers/stub-3.1.3-service-worker-state.html:
  • web-platform-tests/service-workers/stub-3.1.4-service-worker-on-state-change.html:
  • web-platform-tests/service-workers/stub-3.2-navigator-service-worker.html:
  • web-platform-tests/service-workers/stub-3.2.1-navigator-service-worker-installing.html:
  • web-platform-tests/service-workers/stub-3.2.10-navigator-service-worker-oncontrollerchange.html:
  • web-platform-tests/service-workers/stub-3.2.11-navigator-service-worker-onreloadpage.html:
  • web-platform-tests/service-workers/stub-3.2.12-navigator-service-worker-onerror.html:
  • web-platform-tests/service-workers/stub-3.2.2-navigator-service-worker-waiting.html:
  • web-platform-tests/service-workers/stub-3.2.3-navigator-service-worker-active.html:
  • web-platform-tests/service-workers/stub-3.2.4-navigator-service-worker-controller.html:
  • web-platform-tests/service-workers/stub-3.2.5-navigator-service-worker-ready.html:
  • web-platform-tests/service-workers/stub-3.2.6-navigator-service-worker-getAll.html:
  • web-platform-tests/service-workers/stub-3.2.7-navigator-service-worker-register.html:
  • web-platform-tests/service-workers/stub-3.2.8-navigator-service-worker-unregister.html:
  • web-platform-tests/service-workers/stub-3.2.9-navigator-service-worker-onupdatefound.html:
  • web-platform-tests/service-workers/stub-4.1-service-worker-global-scope.html:
  • web-platform-tests/service-workers/stub-4.1.1-service-worker-global-scope-caches.html:
  • web-platform-tests/service-workers/stub-4.1.2-service-worker-global-scope-clients.html:
  • web-platform-tests/service-workers/stub-4.1.3-service-worker-global-scope-scope.html:
  • web-platform-tests/service-workers/stub-4.1.4-service-worker-global-scope-fetch.html:
  • web-platform-tests/service-workers/stub-4.1.5-service-worker-global-scope-update.html:
  • web-platform-tests/service-workers/stub-4.1.6-service-worker-global-scope-unregister.html:
  • web-platform-tests/service-workers/stub-4.1.7-service-worker-global-scope-onmessage.html:
  • web-platform-tests/service-workers/stub-4.2-client.html:
  • web-platform-tests/service-workers/stub-4.3-service-worker-clients.html:
  • web-platform-tests/service-workers/stub-4.3.1-get-serviced-method.html:
  • web-platform-tests/service-workers/stub-4.3.2-reloadall-method.html:
  • web-platform-tests/service-workers/stub-4.5-response-objects.html:
  • web-platform-tests/service-workers/stub-4.5.2-response.html:
  • web-platform-tests/service-workers/stub-4.5.4-opaque-response.html:
  • web-platform-tests/service-workers/stub-4.6-cache-objects.html:
  • web-platform-tests/service-workers/stub-4.6.1-cache-lifetimes.html:
  • web-platform-tests/service-workers/stub-4.6.3-cache-storage.html:
  • web-platform-tests/service-workers/stub-4.7.1-install-phase-event.html:
  • web-platform-tests/service-workers/stub-4.7.1.1-wait-until-method.html:
  • web-platform-tests/service-workers/stub-4.7.2-install-event.html:
  • web-platform-tests/service-workers/stub-4.7.2.1-install-event-section.html:
  • web-platform-tests/service-workers/stub-4.7.2.2-replace-method.html:
  • web-platform-tests/service-workers/stub-4.7.3-activate-event.html:
  • web-platform-tests/service-workers/stub-4.7.4.1-fetch-event-section.html:
  • web-platform-tests/service-workers/stub-4.7.4.2-respond-with-method.html:
  • web-platform-tests/service-workers/stub-4.7.4.3-default-method.html:
  • web-platform-tests/service-workers/stub-4.7.4.4-is-reload-attribute.html:
  • web-platform-tests/service-workers/stub-5.1-origin-relativity.html:
  • web-platform-tests/service-workers/stub-5.2-cross-origin-resources.html:
  • web-platform-tests/shadow-dom/leaktests/get-elements.html:
  • web-platform-tests/tools/pywebsocket/src/example/arraybuffer_benchmark.html:
  • web-platform-tests/tools/pywebsocket/src/example/benchmark.html:
  • web-platform-tests/tools/pywebsocket/src/example/console.html:
  • web-platform-tests/tools/pywebsocket/src/example/eventsource.html:
  • web-platform-tests/tools/pywebsocket/src/example/xhr_benchmark.html:
  • web-platform-tests/tools/pywebsocket/src/example/xhr_event_logger.html:
  • web-platform-tests/url/a-element-origin-xhtml.xhtml:
  • web-platform-tests/url/a-element-origin.html:
  • web-platform-tests/url/a-element-xhtml.xhtml:
  • web-platform-tests/url/a-element.html:
  • web-platform-tests/webrtc/RTCConfiguration-iceCandidatePoolSize.html:
  • web-platform-tests/webrtc/RTCPeerConnection-canTrickleIceCandidates.html:
  • web-platform-tests/webrtc/RTCPeerConnection-idl.html:
  • web-platform-tests/webrtc/RTCPeerConnectionIceEvent-constructor.html:
  • web-platform-tests/webrtc/datachannel-emptystring.html:
  • web-platform-tests/webrtc/datachannel-idlharness.html:
  • web-platform-tests/webrtc/getstats.html:
  • web-platform-tests/webrtc/no-media-call.html:
  • web-platform-tests/webrtc/promises-call.html:
  • web-platform-tests/webrtc/simplecall.html:

Tools:

Update import-w3c-tests to stop rewriting tests as this is causing some tests
to fail unexpectedly.

  • Scripts/webkitpy/w3c/test_importer.py:

(TestImporter.import_tests):

6:59 PM Changeset in webkit [223272] by jmarcell@apple.com
  • 1 copy in tags/Safari-604.3.5.0.3

Tag Safari-604.3.5.0.3.

6:55 PM Changeset in webkit [223271] by achristensen@apple.com
  • 48 edits
    4 deletes in trunk

Use asynchronous ResourceHandleClient calls for WebKit1
​https://bugs.webkit.org/show_bug.cgi?id=160677

Reviewed by Brady Eidson.

Source/WebCore:

Covered by existing tests.

  • PlatformAppleWin.cmake:
  • PlatformMac.cmake:
  • WebCore.xcodeproj/project.pbxproj:
  • loader/ResourceLoader.cpp:

(WebCore::ResourceLoader::willSendRequestAsync):
(WebCore::ResourceLoader::didReceiveResponseAsync):
(WebCore::ResourceLoader::canAuthenticateAgainstProtectionSpaceAsync):

  • loader/ResourceLoader.h:
  • loader/appcache/ApplicationCacheGroup.cpp:

(WebCore::ApplicationCacheGroup::didReceiveResponseAsync):
(WebCore::ApplicationCacheGroup::willSendRequestAsync):
(WebCore::ApplicationCacheGroup::canAuthenticateAgainstProtectionSpaceAsync):
(WebCore::ApplicationCacheGroup::didReceiveResponse): Deleted.

  • loader/appcache/ApplicationCacheGroup.h:
  • platform/network/BlobResourceHandle.cpp:

(WebCore::BlobResourceHandle::continueDidReceiveResponse):
(WebCore::BlobResourceHandle::getSizeForNext):
(WebCore::BlobResourceHandle::notifyResponseOnSuccess):
(WebCore::BlobResourceHandle::notifyResponseOnError):

  • platform/network/PingHandle.h:
  • platform/network/ResourceHandle.cpp:

(WebCore::ResourceHandle::didReceiveResponse):
(WebCore::ResourceHandle::usesAsyncCallbacks): Deleted.

  • platform/network/ResourceHandle.h:
  • platform/network/ResourceHandleClient.cpp:

(WebCore::ResourceHandleClient::~ResourceHandleClient):
(WebCore::ResourceHandleClient::willSendRequest): Deleted.
(WebCore::ResourceHandleClient::willSendRequestAsync): Deleted.
(WebCore::ResourceHandleClient::didReceiveResponseAsync): Deleted.
(WebCore::ResourceHandleClient::canAuthenticateAgainstProtectionSpaceAsync): Deleted.

  • platform/network/ResourceHandleClient.h:

(WebCore::ResourceHandleClient::didReceiveAuthenticationChallenge):
(WebCore::ResourceHandleClient::didReceiveResponse): Deleted.
(WebCore::ResourceHandleClient::usesAsyncCallbacks): Deleted.
(WebCore::ResourceHandleClient::canAuthenticateAgainstProtectionSpace): Deleted.

  • platform/network/ResourceHandleInternal.h:

(WebCore::ResourceHandleInternal::ResourceHandleInternal):

  • platform/network/SynchronousLoaderClient.cpp:

(WebCore::SynchronousLoaderClient::willSendRequestAsync):
(WebCore::SynchronousLoaderClient::canAuthenticateAgainstProtectionSpaceAsync):
(WebCore::SynchronousLoaderClient::didReceiveResponseAsync):
(WebCore::SynchronousLoaderClient::didFinishLoading):
(WebCore::SynchronousLoaderClient::didFail):
(WebCore::SynchronousLoaderClient::willSendRequest): Deleted.
(WebCore::SynchronousLoaderClient::canAuthenticateAgainstProtectionSpace): Deleted.
(WebCore::SynchronousLoaderClient::didReceiveResponse): Deleted.

  • platform/network/SynchronousLoaderClient.h:
  • platform/network/cf/ResourceHandleCFNet.cpp:

(WebCore::ResourceHandle::createCFURLConnection):
(WebCore::ResourceHandle::start):
(WebCore::ResourceHandle::willSendRequest):
(WebCore::ResourceHandle::shouldUseCredentialStorage):
(WebCore::ResourceHandle::canAuthenticateAgainstProtectionSpace):
(WebCore::ResourceHandle::platformLoadResourceSynchronously):

  • platform/network/cf/ResourceHandleCFURLConnectionDelegateWithOperationQueue.cpp:

(WebCore::ResourceHandleCFURLConnectionDelegateWithOperationQueue::ResourceHandleCFURLConnectionDelegateWithOperationQueue):
(WebCore::ResourceHandleCFURLConnectionDelegateWithOperationQueue::releaseHandle):
(WebCore::ResourceHandleCFURLConnectionDelegateWithOperationQueue::willSendRequest):
(WebCore::ResourceHandleCFURLConnectionDelegateWithOperationQueue::didReceiveResponse):
(WebCore::ResourceHandleCFURLConnectionDelegateWithOperationQueue::didReceiveData):
(WebCore::ResourceHandleCFURLConnectionDelegateWithOperationQueue::didFinishLoading):
(WebCore::ResourceHandleCFURLConnectionDelegateWithOperationQueue::didFail):
(WebCore::ResourceHandleCFURLConnectionDelegateWithOperationQueue::willCacheResponse):
(WebCore::ResourceHandleCFURLConnectionDelegateWithOperationQueue::didReceiveChallenge):
(WebCore::ResourceHandleCFURLConnectionDelegateWithOperationQueue::didSendBodyData):
(WebCore::ResourceHandleCFURLConnectionDelegateWithOperationQueue::shouldUseCredentialStorage):
(WebCore::ResourceHandleCFURLConnectionDelegateWithOperationQueue::canRespondToProtectionSpace):
(WebCore::ResourceHandleCFURLConnectionDelegateWithOperationQueue::continueCanAuthenticateAgainstProtectionSpace):

  • platform/network/cf/ResourceHandleCFURLConnectionDelegateWithOperationQueue.h:
  • platform/network/cf/SynchronousResourceHandleCFURLConnectionDelegate.cpp: Removed.
  • platform/network/cf/SynchronousResourceHandleCFURLConnectionDelegate.h: Removed.
  • platform/network/mac/ResourceHandleMac.mm:

(WebCore::ResourceHandle::start):
(WebCore::ResourceHandle::schedule):
(WebCore::ResourceHandle::makeDelegate):
(WebCore::ResourceHandle::delegate):
(WebCore::ResourceHandle::platformLoadResourceSynchronously):
(WebCore::ResourceHandle::willSendRequest):
(WebCore::ResourceHandle::continueWillSendRequest):
(WebCore::ResourceHandle::continueDidReceiveResponse):
(WebCore::ResourceHandle::canAuthenticateAgainstProtectionSpace):
(WebCore::ResourceHandle::continueCanAuthenticateAgainstProtectionSpace):
(WebCore::ResourceHandle::continueWillCacheResponse):
(WebCore::ResourceHandle::shouldUseCredentialStorage): Deleted.

  • platform/network/mac/WebCoreResourceHandleAsDelegate.h: Removed.
  • platform/network/mac/WebCoreResourceHandleAsDelegate.mm: Removed.
  • platform/network/mac/WebCoreResourceHandleAsOperationQueueDelegate.h:
  • platform/network/mac/WebCoreResourceHandleAsOperationQueueDelegate.mm:

(-[WebCoreResourceHandleAsOperationQueueDelegate connection:willSendRequest:redirectResponse:]):
(-[WebCoreResourceHandleAsOperationQueueDelegate connection:didReceiveAuthenticationChallenge:]):
(-[WebCoreResourceHandleAsOperationQueueDelegate connection:canAuthenticateAgainstProtectionSpace:]):
(-[WebCoreResourceHandleAsOperationQueueDelegate connection:didReceiveResponse:]):
(-[WebCoreResourceHandleAsOperationQueueDelegate connection:didReceiveData:lengthReceived:]):
(-[WebCoreResourceHandleAsOperationQueueDelegate connection:didSendBodyData:totalBytesWritten:totalBytesExpectedToWrite:]):
(-[WebCoreResourceHandleAsOperationQueueDelegate connection:didFailWithError:]):
(-[WebCoreResourceHandleAsOperationQueueDelegate connection:willCacheResponse:]):

Source/WebKitLegacy:

  • WebCoreSupport/WebResourceLoadScheduler.cpp:

(WebResourceLoadScheduler::createPingHandle):

LayoutTests:

  • TestExpectations:
  • platform/gtk/TestExpectations:
  • platform/ios-wk2/TestExpectations:
  • platform/mac-wk2/TestExpectations:
  • platform/wk2/TestExpectations:

http/tests/cache/iframe-304-crash.html used to deterministically record its didFinishLoading callback,
but only for WK1. It was marked as flaky for all WK2 ports. It is now flaky in WK1 because the order
of the testRunner.notifyDone call and the didFinishLoading logging is no longer deterministic with
asynchronous loading, but the test still verifies that there is no crash.

http/tests/security/cross-origin-modal-dialog-base.html does navigation during showModalDialog, which
probably should've never worked in WK1 and never worked in WK2. WK1 behavior now matches WK2 behavior.
I'm not aware of any complaints about no navigation working during showModalDialog in WK2 and I imagine
nobody will be regressed by this change, but if we do find such a problem, creative use of MessageQueues
like we do with sync xhr in WK1 now could theoretically fix the problem, but we are trying to get
rid of showModalDialog anyway. The test was written to verify that the SecurityOrigin doesn't fall back
to the wrong origin, and it certainly doesn't now.

These tests dump load delegate call order, which are less deterministic now but the tests still behave correctly.
http/tests/svg/svg-use-external.html
http/tests/loading/text-content-type-with-binary-extension.html
http/tests/security/contentSecurityPolicy/block-all-mixed-content/insecure-iframe-in-main-frame.html

6:10 PM Changeset in webkit [223270] by achristensen@apple.com
  • 7 edits in trunk/Source/WebKit

Remove unnecessary includes in WebKit
​https://bugs.webkit.org/show_bug.cgi?id=178235

Reviewed by Tim Horton.

  • Platform/IPC/ArgumentCoders.h:
  • WebProcess/WebProcess.cpp:
  • WebProcess/WebStorage/StorageAreaImpl.h:
6:04 PM Changeset in webkit [223269] by achristensen@apple.com
  • 2 edits in trunk/Source/WebKit

Increment ContentRuleListStore::CurrentContentRuleListFileVersion
​https://bugs.webkit.org/show_bug.cgi?id=178246
<rdar://problem/34890057>

Reviewed by Tim Horton.

  • UIProcess/API/APIContentRuleListStore.h:

Things are crashing. Something isn't binary reverse compatible.
Probably something related to r222602.
This is why we have a version number to update.

6:01 PM October 2017 Meeting edited by Simon Fraser
(diff)
6:01 PM October 2017 Meeting edited by Simon Fraser
(diff)
5:47 PM Changeset in webkit [223268] by commit-queue@webkit.org
  • 5 edits
    2 deletes in trunk/Source/WebInspectorUI

Web Inspector: Switch Clear navigation item back to the Trash icon (Console, Timelines, Network)
​https://bugs.webkit.org/show_bug.cgi?id=178244
<rdar://problem/34966525>

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2017-10-12
Reviewed by Brian Burg.

  • UserInterface/Images/NavigationItemClear.svg: Removed.
  • UserInterface/Images/gtk/NavigationItemClear.svg: Removed.
  • UserInterface/Views/LogContentView.js:

(WI.LogContentView):

  • UserInterface/Views/NetworkGridContentView.js:

(WI.NetworkGridContentView):

  • UserInterface/Views/NetworkTableContentView.js:

(WI.NetworkTableContentView):

  • UserInterface/Views/TimelineRecordingContentView.js:

(WI.TimelineRecordingContentView):
Many users found the new Clear icon confusing. Revert to the Trash icon.

5:41 PM Changeset in webkit [223267] by achristensen@apple.com
  • 8 edits in trunk/Source/WebKit

Expose some of WKView's WebViewImpl accessors through WKWebViewPrivate
​https://bugs.webkit.org/show_bug.cgi?id=178240
<rdar://problem/34962720>

Reviewed by Tim Horton.

Also renamed createFullScreenWindow to fullScreenWindow to reflect the fact that it returns
an autoreleased NSWindow so we don't make the same naming mistake in the WKWebView SPI.

  • UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _dismissContentRelativeChildWindows]):
(-[WKWebView _setFrame:andScrollBy:]):
(-[WKWebView _setTotalHeightOfBanners:]):
(-[WKWebView _totalHeightOfBanners]):
(-[WKWebView _beginDeferringViewInWindowChanges]):
(-[WKWebView _endDeferringViewInWindowChanges]):
(-[WKWebView _endDeferringViewInWindowChangesSync]):
(-[WKWebView _gestureEventWasNotHandledByWebCore:]):
(-[WKWebView _setIgnoresNonWheelEvents:]):
(-[WKWebView _ignoresNonWheelEvents]):
(-[WKWebView _setCustomSwipeViews:]):
(-[WKWebView _setCustomSwipeViewsTopContentInset:]):
(-[WKWebView _tryToSwipeWithEvent:ignoringPinnedState:]):
(-[WKWebView _setDidMoveSwipeSnapshotCallback:]):
(-[WKWebView _fullScreenPlaceholderView]):
(-[WKWebView _fullScreenWindow]):
(-[WKWebView _disableFrameSizeUpdates]):
(-[WKWebView _enableFrameSizeUpdates]):
(-[WKWebView _canChangeFrameLayout:]):
(-[WKWebView _underlayColor]):
(-[WKWebView _setUnderlayColor:]):

  • UIProcess/API/Cocoa/WKWebViewPrivate.h:
  • UIProcess/API/mac/WKView.mm:

(-[WKView createFullScreenWindow]):

  • UIProcess/Cocoa/WebViewImpl.h:
  • UIProcess/Cocoa/WebViewImpl.mm:

(WebKit::WebViewImpl::fullScreenWindowController):
(WebKit::WebViewImpl::fullScreenWindow):
(WebKit::WebViewImpl::createFullScreenWindow): Deleted.

5:39 PM Changeset in webkit [223266] by achristensen@apple.com
  • 4 edits in trunk/Source/WTF

Add Expected, HashMap, HashSet, and SHA1 to wtf/Forward.h
​https://bugs.webkit.org/show_bug.cgi?id=178243

Reviewed by Tim Horton.

  • wtf/Forward.h:
  • wtf/HashMap.h:

Move default parameters to Forward.h like we did with Vector.

  • wtf/HashSet.h:

Also fix indentation.

5:36 PM Changeset in webkit [223265] by commit-queue@webkit.org
  • 11 edits
    1 copy
    1 move
    2 adds in trunk

Layout Test http/tests/cache-storage/cache-clearing.https.html is failing
​https://bugs.webkit.org/show_bug.cgi?id=178200

Patch by Youenn Fablet <​youenn@apple.com> on 2017-10-12
Reviewed by Chris Dumez.

Source/WebKit:

Deleting only the per-origin folders inside the CacheStorage engine root folder.

  • NetworkProcess/cache/CacheStorageEngine.cpp:

(WebKit::CacheStorage::Engine::clearAllCaches):

  • UIProcess/API/C/WKWebsiteDataStoreRef.cpp:

(WKWebsiteDataStoreRemoveAllFetchCaches):
(WKWebsiteDataStoreRemoveFetchCacheForOrigin):

  • UIProcess/API/C/WKWebsiteDataStoreRef.h:

Tools:

Making clearDOMCache wait for removal completion to exit.
This removes the risk to interact with the cache while deleting it which will end up be racy in tests.

  • WebKitTestRunner/InjectedBundle/TestRunner.cpp:

(WTR::TestRunner::clearDOMCache):

  • WebKitTestRunner/TestController.cpp:

(WTR::ClearDOMCacheCallbackContext::ClearDOMCacheCallbackContext):
(WTR::clearDOMCacheCallback):
(WTR::TestController::clearDOMCache):

  • WebKitTestRunner/TestInvocation.cpp:

(WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
(WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):

LayoutTests:

Splitting cache-clearing.https.html in two sub tests and marking them as Pass/Timeout for the moment.

  • platform/win/TestExpectations: Skipping cache/sw tests.
  • TestExpectations:
  • http/tests/cache-storage/cache-clearing.https.html: Removed.
  • http/tests/cache-storage/cache-clearing-all.https-expected.txt: Added.
  • http/tests/cache-storage/cache-clearing-all.https.html: Added.
  • http/tests/cache-storage/cache-clearing-origin.https-expected.txt: Added.
  • http/tests/cache-storage/cache-clearing-origin.https.html: Added.
5:24 PM Changeset in webkit [223264] by Chris Dumez
  • 28 edits in trunk

[Mac] Add support for MouseEvent.buttons
​https://bugs.webkit.org/show_bug.cgi?id=178214

Reviewed by Ryosuke Niwa.

LayoutTests/imported/w3c:

Rebaseline test now that more checks are passing.

  • web-platform-tests/dom/events/Event-subclasses-constructors-expected.txt:

Source/WebCore:

Add support for MouseEvent.buttons on Mac as per:

This is supported by Firefox and Chrome already.

No new tests, rebaselined existing test.

  • dom/Element.cpp:

(WebCore::Element::dispatchMouseEvent):

  • dom/MouseEvent.cpp:

(WebCore::MouseEvent::create):
(WebCore::MouseEvent::MouseEvent):

  • dom/MouseEvent.h:

(WebCore::MouseEvent::buttons const):

  • dom/MouseEvent.idl:
  • dom/MouseEventInit.h:
  • dom/MouseEventInit.idl:
  • dom/SimulatedClick.cpp:
  • dom/WheelEvent.cpp:
  • page/EventHandler.cpp:

(WebCore::EventHandler::dispatchDragEvent):

  • platform/PlatformMouseEvent.h:

(WebCore::PlatformMouseEvent::buttons const):

  • platform/mac/PlatformEventFactoryMac.mm:

(WebCore::currentlyPressedMouseButtons):
(WebCore::PlatformMouseEventBuilder::PlatformMouseEventBuilder):

Source/WebKit:

  • Shared/WebEvent.h:

(WebKit::WebMouseEvent::buttons const):

  • Shared/WebEventConversion.cpp:

(WebKit::WebKit2PlatformMouseEvent::WebKit2PlatformMouseEvent):

  • Shared/WebMouseEvent.cpp:

(WebKit::WebMouseEvent::WebMouseEvent):
(WebKit::WebMouseEvent::encode const):
(WebKit::WebMouseEvent::decode):

  • Shared/mac/WebEventFactory.mm:

(WebKit::currentlyPressedMouseButtons):
(WebKit::WebEventFactory::createWebMouseEvent):

  • WebProcess/Plugins/PDF/PDFPlugin.mm:

(WebKit::PDFPlugin::showContextMenuAtPoint):

  • WebProcess/Plugins/PluginView.cpp:

(WebKit::PluginView::createWebEvent const):

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::navigateToPDFLinkWithSimulatedClick):
(WebKit::WebPage::simulateMouseDown):
(WebKit::WebPage::simulateMouseUp):
(WebKit::WebPage::simulateMouseMotion):

Source/WebKitLegacy/mac:

  • WebView/WebPDFView.mm:

(-[WebPDFView PDFViewWillClickOnLink:withURL:]):

5:19 PM Changeset in webkit [223263] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit

Add API to clean CacheStorage data
​https://bugs.webkit.org/show_bug.cgi?id=178034

Unreviewed.

Patch by Youenn Fablet <​youenn@apple.com> on 2017-10-12

  • Shared/WebsiteData/WebsiteDataType.h: fixing the DOMCache value.
3:39 PM October 2017 Meeting edited by cavalcantii@gmail.com
(diff)
3:36 PM Changeset in webkit [223262] by commit-queue@webkit.org
  • 4 edits
    14 adds in trunk/Source/WebKit

[WinCairo] add WebProcess files for wincairo webkit
​https://bugs.webkit.org/show_bug.cgi?id=178024

Patch by Stephan Szabo <​stephan.szabo@sony.com> on 2017-10-12
Reviewed by Alex Christensen.

  • PlatformWin.cmake:
  • WebProcess/Cookies/curl/WebCookieManagerCurl.cpp: Added.

(WebKit::WebCookieManager::platformSetHTTPCookieAcceptPolicy):
(WebKit::WebCookieManager::platformGetHTTPCookieAcceptPolicy):

  • WebProcess/InjectedBundle/win/InjectedBundleWin.cpp: Added.

(WebKit::InjectedBundle::initialize):
(WebKit::InjectedBundle::setBundleParameter):
(WebKit::InjectedBundle::setBundleParameters):

  • WebProcess/Plugins/Netscape/JSNPObject.cpp:
  • WebProcess/Plugins/Netscape/win/PluginProxyWin.cpp: Added.

(WebKit::PluginProxy::needsBackingStore const):

  • WebProcess/WebCoreSupport/win/WebContextMenuClientWin.cpp: Added.

(WebKit::WebContextMenuClient::lookUpInDictionary):
(WebKit::WebContextMenuClient::isSpeaking):
(WebKit::WebContextMenuClient::speak):
(WebKit::WebContextMenuClient::stopSpeaking):

  • WebProcess/WebCoreSupport/win/WebFrameNetworkingContext.cpp: Added.

(WebKit::WebFrameNetworkingContext::ensurePrivateBrowsingSession):
(WebKit::WebFrameNetworkingContext::ensureWebsiteDataStoreSession):
(WebKit::WebFrameNetworkingContext::WebFrameNetworkingContext):
(WebKit::WebFrameNetworkingContext::storageSession const):
(WebKit::WebFrameNetworkingContext::webFrameLoaderClient const):
(WebKit::WebFrameNetworkingContext::blockedError const):

  • WebProcess/WebCoreSupport/win/WebFrameNetworkingContext.h: Added.

(WebKit::WebFrameNetworkingContext::create):

  • WebProcess/WebCoreSupport/win/WebPopupMenuWin.cpp: Added.

(WebKit::WebPopupMenu::setUpPlatformData):

  • WebProcess/WebPage/win/WebInspectorUIWin.cpp: Added.

(WebKit::WebInspectorUI::canSave):
(WebKit::WebInspectorUI::localizedStringsURL):
(WebKit::RemoteWebInspectorUI::localizedStringsURL):

  • WebProcess/WebPage/win/WebPageWin.cpp: Added.

(WebKit::WebPage::platformInitialize):
(WebKit::WebPage::platformDetach):
(WebKit::WebPage::platformEditorState const):
(WebKit::WebPage::platformPreferencesDidChange):
(WebKit::WebPage::performDefaultBehaviorForKeyEvent):
(WebKit::WebPage::platformHasLocalDataForURL):
(WebKit::WebPage::cachedResponseMIMETypeForURL):
(WebKit::WebPage::platformCanHandleRequest):
(WebKit::WebPage::cachedSuggestedFilenameForURL):
(WebKit::WebPage::cachedResponseDataForURL):
(WebKit::WebPage::platformUserAgent const):
(WebKit::WebPage::interpretKeyEvent):

  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::ensureWebToStorageProcessConnection):

  • WebProcess/win/WebProcessWin.cpp: Added.

(loadResourceIntoBuffer):
(WebKit::WebProcess::platformInitializeWebProcess):
(WebKit::WebProcess::platformTerminate):
(WebKit::WebProcess::platformSetCacheModel):

2:44 PM Changeset in webkit [223261] by ddkilzer@apple.com
  • 4 edits in trunk/Source

[iOS] Fix -Wunused-lambda-capture warnings in WebCore/WebKit with new clang compiler
<​https://webkit.org/b/178226>

Reviewed by Chris Fleizach.

Source/WebCore:

  • accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:

(-[WebAccessibilityObjectWrapper _accessibilityArticleAncestor]):

  • Remove unused lambda variable 'self'.

Source/WebKit:

  • UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView changeSelectionWithTouchAt:withSelectionTouch:baseIsStart:withFlags:]):

  • Remove unused lambda variable 'touch' which was also passed as an argument.

(-[WKContentView changeSelectionWithTouchesFrom:to:withGesture:withState:]):

  • Remove unused lambda variable 'gestureState' which was also passed as an argument.

(-[WKContentView _simulateLongPressActionAtLocation:]):

  • Remove unused lambda variable 'location'.
2:38 PM Changeset in webkit [223260] by dbates@webkit.org
  • 3 edits in trunk/Source/WebCore

Mark more InlineBox member functions as const
​https://bugs.webkit.org/show_bug.cgi?id=178217

Reviewed by Andy Estes.

  • rendering/InlineBox.cpp:

(WebCore::InlineBox::locationIncludingFlipping const): Mark as const. Also fix some style
nits while I am here.
(WebCore::InlineBox::flipForWritingMode const): Mark as const.
(WebCore::InlineBox::locationIncludingFlipping): Deleted.
(WebCore::InlineBox::flipForWritingMode): Deleted.

  • rendering/InlineBox.h:
2:31 PM Changeset in webkit [223259] by dbates@webkit.org
  • 2 edits in trunk/Source/WebCore

Teach InlineTextBox::clampOffset() about combined text and hyphenation
​https://bugs.webkit.org/show_bug.cgi?id=178032

Reviewed by Zalan Bujtas.

Treat combined text and the last character of a word halve plus hyphen as single units.

With regards to combined text, ideally we would allow arbitrary selection inside combined
text. Currently we do not support selection of combined text. To simplify the process of
adding support for selecting combined text we treat combined text as a single unit. Once
we are confident that we correctly implemented such support we can re-evaluate allowing
arbitrary selection of combined text.

With regards to treating the last character of a word halve plus hyphen as a single unit.
This patch extends the targeted fix made for document markers in r223013 to all code that
makes use of clamped offsets as a result the selection rect for inline boxes more accurately
reflect the rectangle(s) that make up the painted selection. This is a step towards reconciling
the difference between the computation of the rectangle that represents an arbitrary
selection and the code that paints the active selection as part of <​https://bugs.webkit.org/show_bug.cgi?id=138913>.

  • rendering/InlineTextBox.cpp:

(WebCore::InlineTextBox::localSelectionRect const): Compute text run, including combined text
or hyphens due to line wrapping now that specified start and end positions are clamped with
respect to combined text and hyphens (computed earlier in this function). Only measure the
text represented by the selection if the start position > 0 or the end position is not equal
to the length of the run.
(WebCore::InlineTextBox::paint): Remove unnecessary code to fix up the selection start and
end positions based on the truncation offset as this is done by clampedOffset(), called by
selectionStartEnd().
(WebCore::InlineTextBox::clampedOffset const): Modified to adjust the clamped offset with
respect to truncation as well as treat combined text or a trailing word halve plus hyphen
as single units. Assert that we are not fully truncated because it does not make sense to
be computing the clamped offset in such a situation since nothing should be painted.
(WebCore::InlineTextBox::selectionStartEnd const): Modified to compute the end of an inside
selection using clampedOffset() to account for truncation, combined text or a hyphen. We
already are using clampedOffset() when computing the start and end position for all other
selection states.
(WebCore::InlineTextBox::paintSelection): Compute text run, including combined text
or hyphens due to line wrapping now that specified start and end positions are clamped with
respect to combined text and hyphens (computed earlier in this function). Remove unnecessary
code to adjust selection end point with respect to truncation, combined text, or an added
hyphen now that selectionStartEnd() takes care of this (via clampedOffset()).
(WebCore::InlineTextBox::paintTextSubrangeBackground): Compute text run, including combined
text or hyphens due to line wrapping now that specified start and end positions are clamped
with respect to combined text and hyphens (computed earlier in this function).
(WebCore::InlineTextBox::paintDocumentMarker): Compute text run, including combined text now
that specified start and end positions are clamped with respect to combined text (computed earlier in this function).
Also remove unnecessary code to adjust end offset of the marker with respect to truncation
and length of the text run as clampedOffset() now does this for us.

2:29 PM Changeset in webkit [223258] by achristensen@apple.com
  • 3 edits in trunk/Source/WTF

Add CompletionHandler and HashCountedSet to wtf/Forward.h
​https://bugs.webkit.org/show_bug.cgi?id=178231

Reviewed by Tim Horton.

  • wtf/Forward.h:
  • wtf/HashCountedSet.h:
2:21 PM Changeset in webkit [223257] by dino@apple.com
  • 2 edits in branches/safari-604-branch/Source/WebCore

Cherry-pick r223063. rdar://problem/34921832

2:16 PM Changeset in webkit [223256] by pvollan@apple.com
  • 2 edits in trunk/LayoutTests

Mark some xhtml tests as failing on Windows.
​https://bugs.webkit.org/show_bug.cgi?id=178230

Unreviewed test gardening.

  • platform/win/TestExpectations:
2:15 PM Changeset in webkit [223255] by dino@apple.com
  • 10 edits in branches/safari-604-branch

Cherry-pick r222961. <rdar://problem/34891070>

2:12 PM Changeset in webkit [223254] by Simon Fraser
  • 3 edits
    2 adds in trunk

Don't assert if mix-blend-mode is set to a non-separable blend mode on a composited layer
​https://bugs.webkit.org/show_bug.cgi?id=178196
rdar://problem/34942337

Reviewed by Dan Bates.

Source/WebCore:

Core Animation doesn't support non-separable blend modes (hue, saturation, color, luminosity)
on layers, but don't assert if we try to use them.

Test: compositing/filters/blend-mode-saturation.html

  • platform/graphics/ca/cocoa/PlatformCAFiltersCocoa.mm:

(PlatformCAFilters::setBlendingFiltersOnLayer):

LayoutTests:

  • compositing/filters/blend-mode-saturation-expected.txt: Added.
  • compositing/filters/blend-mode-saturation.html: Added.
1:13 PM Changeset in webkit [223253] by wilander@apple.com
  • 22 edits
    32 adds in trunk

ResourceLoadObserver::logFrameNavigation() should use redirectResponse.url()
​https://bugs.webkit.org/show_bug.cgi?id=175257
<rdar://problem/33359866>

Reviewed by Brent Fulgham.

Source/WebCore:

This patch was joint work between Michael Specter and John Wilander.

Tests: http/tests/resourceLoadStatistics/non-sandboxed-iframe-redirect-ip-to-localhost-to-ip.html

http/tests/resourceLoadStatistics/non-sandboxed-iframe-redirect-localhost-to-ip-to-localhost.html
http/tests/resourceLoadStatistics/non-sandboxed-nesting-iframe-with-non-sandboxed-iframe-redirect-ip-to-localhost-to-ip.html
http/tests/resourceLoadStatistics/non-sandboxed-nesting-iframe-with-non-sandboxed-iframe-redirect-localhost-to-ip-to-localhost.html
http/tests/resourceLoadStatistics/non-sandboxed-nesting-iframe-with-sandboxed-iframe-redirect-ip-to-localhost-to-ip.html
http/tests/resourceLoadStatistics/non-sandboxed-nesting-iframe-with-sandboxed-iframe-redirect-localhost-to-ip-to-localhost.html
http/tests/resourceLoadStatistics/sandboxed-iframe-redirect-ip-to-localhost-to-ip.html
http/tests/resourceLoadStatistics/sandboxed-iframe-redirect-localhost-to-ip-to-localhost.html
http/tests/resourceLoadStatistics/sandboxed-nesting-iframe-with-non-sandboxed-iframe-redirect-ip-to-localhost-to-ip.html
http/tests/resourceLoadStatistics/sandboxed-nesting-iframe-with-non-sandboxed-iframe-redirect-localhost-to-ip-to-localhost.html
http/tests/resourceLoadStatistics/sandboxed-nesting-iframe-with-sandboxed-iframe-redirect-ip-to-localhost-to-ip.html
http/tests/resourceLoadStatistics/sandboxed-nesting-iframe-with-sandboxed-iframe-redirect-localhost-to-ip-to-localhost.html

  • loader/DocumentLoader.cpp:

(WebCore::DocumentLoader::willSendRequest):

Now sends redirectResponse.url() to WebCore::ResourceLoadObserver::logFrameNavigation().

  • loader/ResourceLoadObserver.cpp:

(WebCore::ResourceLoadObserver::logFrameNavigation):

Now receives the redirect response URL from WebCore::DocumentLoader().

(WebCore::ResourceLoadObserver::nonNullOwnerURL const):

New function to traverse the frame chain upward and find the first non-null URL.

  • loader/ResourceLoadObserver.h:

Source/WebKit:

  • UIProcess/API/Cocoa/WKWebsiteDataStore.mm:

(-[WKWebsiteDataStore _resourceLoadStatisticsIsRegisteredAsSubFrameUnder:topFrameHost:completionHandler:]):
(-[WKWebsiteDataStore _resourceLoadStatisticsIsRegisteredAsRedirectingTo:hostRedirectedTo:completionHandler:]):

Test infrastructure.

  • UIProcess/API/Cocoa/WKWebsiteDataStorePrivate.h:
  • UIProcess/WebResourceLoadStatisticsStore.cpp:

(WebKit::WebResourceLoadStatisticsStore::isRegisteredAsSubFrameUnder):
(WebKit::WebResourceLoadStatisticsStore::isRegisteredAsRedirectingTo):

Test infrastructure.

  • UIProcess/WebResourceLoadStatisticsStore.h:

Tools:

  • WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
  • WebKitTestRunner/InjectedBundle/TestRunner.cpp:

(WTR::TestRunner::isStatisticsRegisteredAsSubFrameUnder):
(WTR::TestRunner::isStatisticsRegisteredAsRedirectingTo):

  • WebKitTestRunner/InjectedBundle/TestRunner.h:
  • WebKitTestRunner/TestController.cpp:

(WTR::TestController::isStatisticsRegisteredAsSubFrameUnder):

Not implemented.

(WTR::TestController::isStatisticsRegisteredAsRedirectingTo):

Not implemented.

  • WebKitTestRunner/TestController.h:
  • WebKitTestRunner/TestInvocation.cpp:

(WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):

  • WebKitTestRunner/cocoa/TestControllerCocoa.mm:

(WTR::TestController::isStatisticsRegisteredAsSubFrameUnder):

Implemented platform-specific.

(WTR::TestController::isStatisticsRegisteredAsRedirectingTo):

Implemented platform-specific.

LayoutTests:

Marked new directory as [ Skip ] since these are WK2-only.

  • http/tests/resourceLoadStatistics: Added.
  • http/tests/resourceLoadStatistics/non-sandboxed-iframe-redirect-ip-to-localhost-to-ip-expected.txt: Added.
  • http/tests/resourceLoadStatistics/non-sandboxed-iframe-redirect-ip-to-localhost-to-ip.html: Added.
  • http/tests/resourceLoadStatistics/non-sandboxed-iframe-redirect-localhost-to-ip-to-localhost-expected.txt: Added.
  • http/tests/resourceLoadStatistics/non-sandboxed-iframe-redirect-localhost-to-ip-to-localhost.html: Added.
  • http/tests/resourceLoadStatistics/non-sandboxed-nesting-iframe-with-non-sandboxed-iframe-redirect-ip-to-localhost-to-ip-expected.txt: Added.
  • http/tests/resourceLoadStatistics/non-sandboxed-nesting-iframe-with-non-sandboxed-iframe-redirect-ip-to-localhost-to-ip.html: Added.
  • http/tests/resourceLoadStatistics/non-sandboxed-nesting-iframe-with-non-sandboxed-iframe-redirect-localhost-to-ip-to-localhost-expected.txt: Added.
  • http/tests/resourceLoadStatistics/non-sandboxed-nesting-iframe-with-non-sandboxed-iframe-redirect-localhost-to-ip-to-localhost.html: Added.
  • http/tests/resourceLoadStatistics/non-sandboxed-nesting-iframe-with-sandboxed-iframe-redirect-ip-to-localhost-to-ip-expected.txt: Added.
  • http/tests/resourceLoadStatistics/non-sandboxed-nesting-iframe-with-sandboxed-iframe-redirect-ip-to-localhost-to-ip.html: Added.
  • http/tests/resourceLoadStatistics/non-sandboxed-nesting-iframe-with-sandboxed-iframe-redirect-localhost-to-ip-to-localhost-expected.txt: Added.
  • http/tests/resourceLoadStatistics/non-sandboxed-nesting-iframe-with-sandboxed-iframe-redirect-localhost-to-ip-to-localhost.html: Added.
  • http/tests/resourceLoadStatistics/resources: Added.
  • http/tests/resourceLoadStatistics/resources/iframe-report-back-loaded.html: Added.
  • http/tests/resourceLoadStatistics/resources/page-with-non-sandboxed-iframe-redirect-ip-to-localhost-to-ip.html: Added.
  • http/tests/resourceLoadStatistics/resources/page-with-non-sandboxed-iframe-redirect-localhost-to-ip-to-localhost.html: Added.
  • http/tests/resourceLoadStatistics/resources/page-with-sandboxed-iframe-redirect-ip-to-localhost-to-ip.html: Added.
  • http/tests/resourceLoadStatistics/resources/page-with-sandboxed-iframe-redirect-localhost-to-ip-to-localhost.html: Added.
  • http/tests/resourceLoadStatistics/resources/redirect.php: Added.
  • http/tests/resourceLoadStatistics/sandboxed-iframe-redirect-ip-to-localhost-to-ip-expected.txt: Added.
  • http/tests/resourceLoadStatistics/sandboxed-iframe-redirect-ip-to-localhost-to-ip.html: Added.
  • http/tests/resourceLoadStatistics/sandboxed-iframe-redirect-localhost-to-ip-to-localhost-expected.txt: Added.
  • http/tests/resourceLoadStatistics/sandboxed-iframe-redirect-localhost-to-ip-to-localhost.html: Added.
  • http/tests/resourceLoadStatistics/sandboxed-nesting-iframe-with-non-sandboxed-iframe-redirect-ip-to-localhost-to-ip-expected.txt: Added.
  • http/tests/resourceLoadStatistics/sandboxed-nesting-iframe-with-non-sandboxed-iframe-redirect-ip-to-localhost-to-ip.html: Added.
  • http/tests/resourceLoadStatistics/sandboxed-nesting-iframe-with-non-sandboxed-iframe-redirect-localhost-to-ip-to-localhost-expected.txt: Added.
  • http/tests/resourceLoadStatistics/sandboxed-nesting-iframe-with-non-sandboxed-iframe-redirect-localhost-to-ip-to-localhost.html: Added.
  • http/tests/resourceLoadStatistics/sandboxed-nesting-iframe-with-sandboxed-iframe-redirect-ip-to-localhost-to-ip-expected.txt: Added.
  • http/tests/resourceLoadStatistics/sandboxed-nesting-iframe-with-sandboxed-iframe-redirect-ip-to-localhost-to-ip.html: Added.
  • http/tests/resourceLoadStatistics/sandboxed-nesting-iframe-with-sandboxed-iframe-redirect-localhost-to-ip-to-localhost-expected.txt: Added.
  • http/tests/resourceLoadStatistics/sandboxed-nesting-iframe-with-sandboxed-iframe-redirect-localhost-to-ip-to-localhost.html: Added.
  • platform/gtk/TestExpectations:

Marked new directory as [ Skip ].

  • platform/wk2/TestExpectations:

Marked new directory as [ Pass ].

  • platform/wpe/TestExpectations:

Marked new directory as [ Skip ].

1:07 PM Changeset in webkit [223252] by jmarcell@apple.com
  • 2 edits in tags/Safari-605.1.10/Source/JavaScriptCore

Cherry-pick r223248. rdar://problem/34956170

1:01 PM Changeset in webkit [223251] by Matt Lewis
  • 2 edits in trunk/LayoutTests

Marked imported/w3c/web-platform-tests/fetch/security/dangling-markup-mitigation-data-url.tentative.sub.html as flaky on iOS.
​https://bugs.webkit.org/show_bug.cgi?id=177547

Unreviewed test gardening.

  • platform/ios/TestExpectations:
12:51 PM Changeset in webkit [223250] by jmarcell@apple.com
  • 7 edits in branches/safari-604-branch/Source

Versioning.

12:48 PM Changeset in webkit [223249] by jmarcell@apple.com
  • 1 copy in tags/Safari-604.4.2

Tag Safari-604.4.2.

12:24 PM Changeset in webkit [223248] by pvollan@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

[Win64] JSC compile error.
​https://bugs.webkit.org/show_bug.cgi?id=178213

Reviewed by Alex Christensen.

Add static cast from int64 to uintptr_t.

  • dfg/DFGOSRExit.cpp:

(JSC::DFG::OSRExit::executeOSRExit):

12:12 PM Changeset in webkit [223247] by aestes@apple.com
  • 5 edits in trunk

[iOS] Conditionally rename DatabaseProcess to StorageProcess when building for iOS devices
​https://bugs.webkit.org/show_bug.cgi?id=178181
<rdar://problem/33660282>

Reviewed by Dan Bernstein.

Source/WebKit:

  • Configurations/BaseTarget.xcconfig:
  • UIProcess/Launcher/mac/ProcessLauncherMac.mm:

(WebKit::serviceName):

  • WebKit.xcodeproj/project.pbxproj:

Tools:

  • WebKitTestRunner/TestController.cpp:

(WTR::TestController::databaseProcessName):

11:45 AM Changeset in webkit [223246] by mmaxfield@apple.com
  • 6 edits
    3 adds in trunk/Tools

Emit SPIR-V from WSL compiler (Part 1)
​https://bugs.webkit.org/show_bug.cgi?id=177998

Reviewed by Filip Pizlo.

This patch implements the first half of a SPIR-V codegen phase for WSL.
This includes all the operations which aren't actually emitting the contents
of functions themselves. For example, this includes things like representing
WSL types with SPIR-V types, and declaring shaders' inputs and outputs. A
future patch will actually emit the contents of functions.

There are two helper visitors here: SPIRVTypeAnalyzer which generates SPIR-V
types from WSL types, and SPIRVPrimitiveVariableAnalyzer which identifies
input and output variables from a shader (and assigns location values to
each one).

This patch is currently pursuing the "logical mode" detailed in
​https://bugs.webkit.org/show_bug.cgi?id=176967. In this mode, each pointer and
array reference operation can be statically traced to the variable or array it
is operating on.

This has the interesting property where accessing a pointer inside an array is
forbidden, because the array index may be computed at runtime, so the compiler
can't know at compile time which variable the pointer operation will be
accessing. However, this isn't true for structs; the program must statically
state which struct member it is accessing. Therefore, pointers or array
references must not transitively appear within an array, but they may appear
within a struct. The same logic applies to array references; those get lowered
to just two indexes in SPIR-V (a lower bound and an upper bound).

So, outside of an array, SPIR-V types don't need to include any pointers because
any operation with the pointer doesn't need access to the runtime value of the
pointer. Inside of an array, pointers are forbidden. Therefore, SPIR-V types
will never include any pointers.

This means that, for example, WSL can represent a linked list in logical mode.
However, a WSL program cannot iterate across the list, because that would require
assigning to a pointer. So instead, a program using a linked list could only say
something like "list.ptr->ptr->ptr->value".

  • WebGPUShadingLanguageRI/LateChecker.js:

(LateChecker.prototype._checkShaderType):

  • WebGPUShadingLanguageRI/SPIR-V.js:

(SPIRV.OperandChecker.prototype._isStar):
(SPIRV.OperandChecker.prototype.nextComparisonType):
(SPIRV.OperandChecker.prototype.finalize):
(SPIRV.OperandChecker):

  • WebGPUShadingLanguageRI/SPIRV.html:
  • WebGPUShadingLanguageRI/SPIRVCodegen.js: Added.

(findEntryPoints):
(emitTypes.doEmitTypes):
(emitTypes):
(ConstantFinder.prototype.visitGenericLiteralType):
(ConstantFinder):
(generateSPIRV):

  • WebGPUShadingLanguageRI/SPIRVTypeAnalyzer.js: Added.

(SPIRVTypeAnalyzer):
(SPIRVTypeAnalyzer.prototype.get program):
(SPIRVTypeAnalyzer.prototype.get typeMap):
(SPIRVTypeAnalyzer.prototype.get currentId):
(SPIRVTypeAnalyzer.prototype.get stack):
(SPIRVTypeAnalyzer.prototype.visitTypeRef):
(SPIRVTypeAnalyzer.prototype._encounterType):
(SPIRVTypeAnalyzer.prototype.visitNullType):
(SPIRVTypeAnalyzer.prototype.visitGenericLiteralType):
(SPIRVTypeAnalyzer.prototype.visitNativeType):
(SPIRVTypeAnalyzer.prototype.visitEnumType):
(SPIRVTypeAnalyzer.prototype.visitPtrType):
(SPIRVTypeAnalyzer.prototype.visitArrayRefType):
(SPIRVTypeAnalyzer.prototype.visitArrayType):
(SPIRVTypeAnalyzer.prototype.visitStructType):

  • WebGPUShadingLanguageRI/SPIRVVariableAnalyzer.js: Added.

(SPIRVPrimitiveVariableAnalyzer):
(SPIRVPrimitiveVariableAnalyzer.prototype.get program):
(SPIRVPrimitiveVariableAnalyzer.prototype.get typeMap):
(SPIRVPrimitiveVariableAnalyzer.prototype.get currentId):
(SPIRVPrimitiveVariableAnalyzer.prototype.get currentLocation):
(SPIRVPrimitiveVariableAnalyzer.prototype.get nameComponents):
(SPIRVPrimitiveVariableAnalyzer.prototype.get result):
(SPIRVPrimitiveVariableAnalyzer.prototype.visitTypeRef):
(SPIRVPrimitiveVariableAnalyzer.prototype.visitNullType):
(SPIRVPrimitiveVariableAnalyzer.prototype.visitGenericLiteralType):
(SPIRVPrimitiveVariableAnalyzer.prototype.visitNativeType):
(SPIRVPrimitiveVariableAnalyzer.prototype.visitEnumType):
(SPIRVPrimitiveVariableAnalyzer.prototype.visitPtrType):
(SPIRVPrimitiveVariableAnalyzer.prototype.visitArrayRefType):
(SPIRVPrimitiveVariableAnalyzer.prototype.visitArrayType):
(SPIRVPrimitiveVariableAnalyzer.prototype.visitStructType):

  • WebGPUShadingLanguageRI/WSL.md:
  • WebGPUShadingLanguageRI/index.html:
11:31 AM Changeset in webkit [223245] by jmarcell@apple.com
  • 5 edits in branches/safari-604-branch

Apply patch. rdar://problem/34891292

11:31 AM Changeset in webkit [223244] by jmarcell@apple.com
  • 11 edits
    4 adds in branches/safari-604-branch

Apply patch. rdar://problem/34893194

11:29 AM Changeset in webkit [223243] by Matt Lewis
  • 2 edits in trunk/LayoutTests

Edited expectations for http/tests/media/video-buffered-range-contains-currentTime.html.
​https://bugs.webkit.org/show_bug.cgi?id=177616

Unreviewed test gardening.

  • platform/mac-wk2/TestExpectations:
11:26 AM Changeset in webkit [223242] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebKit

CacheStorage persistent folder should be in /Library/Cache
​https://bugs.webkit.org/show_bug.cgi?id=178193

Patch by Youenn Fablet <​youenn@apple.com> on 2017-10-12
Reviewed by Brady Eidson.

  • UIProcess/API/Cocoa/APIWebsiteDataStoreCocoa.mm:

(API::WebsiteDataStore::defaultCacheStorageDirectory): Making CacheStorage
directory a subfolder of Caches folder.
(API::WebsiteDataStore::defaultDataStoreConfiguration):

  • UIProcess/WebProcessPool.cpp:

(WebKit::legacyWebsiteDataStoreConfiguration):
(WebKit::WebProcessPool::ensureNetworkProcess): Make sure the web site data store
has the right cache directory path. Also make sure that the quota is set even if there is no folder specified.
Quota may still be useful in case of non persistent sessions.

  • UIProcess/WebsiteData/WebsiteDataStore.cpp:

(WebKit::WebsiteDataStore::resolveDirectoriesIfNecessary):

  • UIProcess/API/glib/APIWebsiteDataStoreGLib.cpp:

(API::WebsiteDataStore::defaultCacheStorageDirectory):

11:21 AM Changeset in webkit [223241] by mmaxfield@apple.com
  • 2 edits
    2 adds in trunk/Source/WebCore/PAL

[Win] Build fix after r223206
​https://bugs.webkit.org/show_bug.cgi?id=171523

Unreviewed.

  • pal/PlatformWin.cmake:
  • pal/win/LoggingWin.cpp: Added.

(PAL::logLevelString):

10:42 AM Changeset in webkit [223240] by fred.wang@free.fr
  • 2 edits in trunk/Source/WebCore

Use less specific cast in ScrollingTree::scrollPositionChangedViaDelegatedScrolling
​https://bugs.webkit.org/show_bug.cgi?id=178211

Patch by Frederic Wang <​fwang@igalia.com> on 2017-10-12
Reviewed by Simon Fraser.

No new tests, behavior is not changed.

ScrollingTree::scrollPositionChangedViaDelegatedScrolling is a generic function that applies
to scrolling nodes. Casting to more specific ScrollingTreeOverflowScrollingNodes is however
not necessary to implement it. This patch moves to the least specific cast necessary so that
this function will be usable for async scrolling of non-main frames in the future. Note that
the function is currently only called from ScrollingTreeScrollingNodeDelegateIOS which in
turn is only used by the ScrollingTreeScrollingOverflowNodeIOS class and so code behavior is
not changed.

  • page/scrolling/ScrollingTree.cpp:

(WebCore::ScrollingTree::scrollPositionChangedViaDelegatedScrolling): Only cast the node to
ScrollingTreeScrollingNode.

9:02 AM Changeset in webkit [223239] by fpizlo@apple.com
  • 22 edits
    6 adds in trunk

Enable gigacage on iOS
​https://bugs.webkit.org/show_bug.cgi?id=177586

Reviewed by JF Bastien.
JSTests:


Add tests for when Gigacage gets runtime disabled.

  • stress/disable-gigacage-arrays.js: Added.

(foo):

  • stress/disable-gigacage-strings.js: Added.

(foo):

  • stress/disable-gigacage-typed-arrays.js: Added.

(foo):

Source/bmalloc:


Introduce the ability to disable gigacage at runtime if allocation fails. If any step of gigacage
allocation fails, we free all of the gigacages and turn off gigacage support.

Roll this back in after discussion.

  • CMakeLists.txt:
  • bmalloc.xcodeproj/project.pbxproj:
  • bmalloc/Cache.cpp:

(bmalloc::Cache::scavenge):

  • bmalloc/Cache.h:

(bmalloc::Cache::tryAllocate):
(bmalloc::Cache::allocate):
(bmalloc::Cache::deallocate):
(bmalloc::Cache::reallocate):

  • bmalloc/Gigacage.cpp:

(Gigacage::ensureGigacage):
(Gigacage::runway):
(Gigacage::totalSize):
(Gigacage::shouldBeEnabled):
(): Deleted.
(Gigacage::Callback::Callback): Deleted.
(Gigacage::Callback::function): Deleted.
(Gigacage::PrimitiveDisableCallbacks::PrimitiveDisableCallbacks): Deleted.

  • bmalloc/Gigacage.h:

(Gigacage::wasEnabled):
(Gigacage::isEnabled):
(Gigacage::runway): Deleted.
(Gigacage::totalSize): Deleted.

  • bmalloc/HeapKind.cpp: Added.

(bmalloc::isActiveHeapKind):
(bmalloc::mapToActiveHeapKind):

  • bmalloc/HeapKind.h:

(bmalloc::isActiveHeapKindAfterEnsuringGigacage):
(bmalloc::mapToActiveHeapKindAfterEnsuringGigacage):

  • bmalloc/Scavenger.cpp:

(bmalloc::Scavenger::scavenge):

  • bmalloc/bmalloc.h:

(bmalloc::api::tryLargeMemalignVirtual):
(bmalloc::api::freeLargeVirtual):
(bmalloc::api::isEnabled):

Source/JavaScriptCore:

The hardest part of enabling Gigacage on iOS is that it requires loading global variables while
executing JS, so the LLInt needs to know how to load from global variables on all platforms that
have Gigacage. So, this teaches ARM64 how to load from global variables.

Also, this makes the code handle disabling the gigacage a bit better.

  • ftl/FTLLowerDFGToB3.cpp:

(JSC::FTL::DFG::LowerDFGToB3::caged):

  • jit/AssemblyHelpers.h:

(JSC::AssemblyHelpers::cage):
(JSC::AssemblyHelpers::cageConditionally):

  • offlineasm/arm64.rb:
  • offlineasm/asm.rb:
  • offlineasm/instructions.rb:

Tools:


Add a mode to test disabling Gigacage.

  • Scripts/run-jsc-stress-tests:
  • Scripts/webkitruby/jsc-stress-test-writer-default.rb:
8:38 AM Changeset in webkit [223238] by weinig@apple.com
  • 54 edits in trunk

Remove out-parameter variants of copyToVector
​https://bugs.webkit.org/show_bug.cgi?id=178155

Reviewed by Tim Horton.

Source/JavaScriptCore:

  • inspector/ScriptDebugServer.cpp:

(Inspector::ScriptDebugServer::dispatchBreakpointActionLog):
(Inspector::ScriptDebugServer::dispatchBreakpointActionSound):
(Inspector::ScriptDebugServer::dispatchBreakpointActionProbe):
(Inspector::ScriptDebugServer::dispatchDidParseSource):
(Inspector::ScriptDebugServer::dispatchFailedToParseSource):
(Inspector::ScriptDebugServer::dispatchFunctionToListeners):

Replace out-parameter based copyToVector, with one that returns a Vector.

Source/WebCore:

  • Modules/geolocation/Geolocation.cpp:

(WebCore::Geolocation::stopTimersForOneShots):
(WebCore::Geolocation::cancelAllRequests):
(WebCore::Geolocation::handleError):
(WebCore::Geolocation::makeSuccessCallbacks):

  • Modules/indexeddb/IDBDatabase.cpp:

(WebCore::IDBDatabase::transaction):

  • Modules/indexeddb/IDBGetAllResult.cpp:

(WebCore::IDBGetAllResult::allBlobFilePaths const):

  • Modules/indexeddb/server/MemoryIndex.cpp:

(WebCore::IDBServer::MemoryIndex::notifyCursorsOfValueChange):
(WebCore::IDBServer::MemoryIndex::notifyCursorsOfAllRecordsChanged):

  • css/CSSFontSelector.cpp:

(WebCore::CSSFontSelector::dispatchInvalidationCallbacks):

  • dom/Document.cpp:

(WebCore::Document::moveNodeIteratorsToNewDocument):
(WebCore::Document::resume):
(WebCore::Document::didAssociateFormControlsTimerFired):

  • dom/IdTargetObserverRegistry.cpp:

(WebCore::IdTargetObserverRegistry::notifyObserversInternal):

  • dom/MutationObserver.cpp:

(WebCore::MutationObserver::notifyMutationObservers):

  • dom/Node.cpp:

(WebCore::Document::invalidateNodeListAndCollectionCaches):

  • dom/RadioButtonGroups.cpp:
  • dom/ScriptExecutionContext.cpp:

(WebCore::ScriptExecutionContext::dispatchMessagePortEvents):
(WebCore::ScriptExecutionContext::stopActiveDOMObjects):

  • loader/appcache/ApplicationCacheGroup.cpp:

(WebCore::ApplicationCacheGroup::checkIfLoadIsComplete):
(WebCore::ApplicationCacheGroup::deliverDelayedMainResources):

  • loader/cache/MemoryCache.cpp:

(WebCore::MemoryCache::forEachResource):
(WebCore::MemoryCache::pruneDeadResourcesToSize):

  • page/DOMWindow.cpp:

(WebCore::DOMWindow::willDestroyCachedFrame):
(WebCore::DOMWindow::willDestroyDocumentInFrame):
(WebCore::DOMWindow::willDetachDocumentFromFrame):
(WebCore::DOMWindow::disconnectDOMWindowProperties):
(WebCore::DOMWindow::reconnectDOMWindowProperties):

  • page/FrameView.cpp:

(WebCore::collectAndProtectWidgets):

  • page/MemoryRelease.cpp:

(WebCore::releaseCriticalMemory):

  • page/Performance.cpp:

(WebCore::Performance::queueEntry):

  • platform/cocoa/PasteboardCocoa.mm:

(WebCore::Pasteboard::typesForLegacyUnsafeBindings):

  • platform/graphics/cocoa/FontCacheCoreText.cpp:

(WebCore::FontCache::systemFontFamilies):

  • platform/ios/PlatformPasteboardIOS.mm:

(WebCore::PlatformPasteboard::typesSafeForDOMToReadAndWrite const):

  • platform/ios/WebCoreMotionManager.mm:

(-[WebCoreMotionManager sendAccelerometerData:]):
(-[WebCoreMotionManager sendMotionData:withHeading:]):

  • platform/mac/PlatformPasteboardMac.mm:

(WebCore::PlatformPasteboard::typesSafeForDOMToReadAndWrite const):

  • platform/network/cocoa/WebCoreNSURLSession.mm:

(-[WebCoreNSURLSession invalidateAndCancel]):

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::endAndCommitUpdateScrollInfoAfterLayoutTransaction):

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::setLogicalWidthForTextRun):

  • rendering/RenderDeprecatedFlexibleBox.cpp:

(WebCore::FlexBoxIterator::next):

  • rendering/RenderTableSection.cpp:

(WebCore::RenderTableSection::paintObject):

Replace out-parameter based copyToVector, with one that returns a Vector.

Source/WebKit:

  • Shared/API/Cocoa/_WKRemoteObjectInterface.mm:

(-[_WKRemoteObjectInterface debugDescription]):

  • Shared/RemoteLayerTree/RemoteScrollingCoordinatorTransaction.cpp:

(WebKit::dump):

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::resetState):

  • UIProcess/WebProcessPool.cpp:

(WebKit::WebProcessPool::createNewWebProcess):

  • UIProcess/WebsiteData/Cocoa/WebsiteDataStoreCocoa.mm:

(WebKit::WebsiteDataStore::parameters):

  • UIProcess/WebsiteData/WebsiteDataStore.cpp:

(WebKit::WebsiteDataStore::pendingCookies const):

  • UIProcess/ios/ProcessAssertionIOS.mm:

(-[WKProcessAssertionBackgroundTaskManager _notifyClientsOfImminentSuspension]):

  • WebProcess/Cookies/WebCookieManager.cpp:

(WebKit::WebCookieManager::getHostnamesWithCookies):

  • WebProcess/Geolocation/WebGeolocationManager.cpp:

(WebKit::WebGeolocationManager::didChangePosition):
(WebKit::WebGeolocationManager::didFailToDeterminePosition):

  • WebProcess/Network/WebLoaderStrategy.cpp:

(WebKit::WebLoaderStrategy::internallyFailedLoadTimerFired):

Replace out-parameter based copyToVector, with one that returns a Vector.

Source/WebKitLegacy/ios:

  • Misc/WebGeolocationProviderIOS.mm:

(-[WebGeolocationProviderIOS _handlePendingInitialPosition:]):
(-[WebGeolocationProviderIOS positionChanged:]):
(-[WebGeolocationProviderIOS errorOccurred:]):
(-[WebGeolocationProviderIOS resetGeolocation]):

Replace out-parameter based copyToVector, with one that returns a Vector.

Source/WebKitLegacy/mac:

  • Plugins/WebNetscapePluginView.mm:

(-[WebNetscapePluginView destroyPlugin]):

  • WebView/WebHTMLRepresentation.mm:

(newArrayWithStrings):

Replace out-parameter based copyToVector, with one that returns a Vector.

Source/WTF:

  • wtf/HashMap.h:

(WTF::copyToVector): Deleted.

  • wtf/HashSet.h:

(WTF::copyToVector): Deleted.

Remove copyToVector.


  • wtf/Vector.h:

(WTF::copyToVectorSpecialization):

Add another version of copyToVector, called copyToVectorSpecialization, that allows
you to specify the entire specialization for the Vector you want to copy to. This
can be useful if you want your resulting Vector to have an inline capacity.

Tools:

  • DumpRenderTree/JavaScriptThreading.cpp:

(stopJavaScriptThreads):

6:12 AM Changeset in webkit [223237] by Yusuke Suzuki
  • 31 edits
    1 copy
    18 adds in trunk

Support integrity="" on module scripts
​https://bugs.webkit.org/show_bug.cgi?id=177959

Reviewed by Sam Weinig.

Source/JavaScriptCore:

This patch adds Subresource Integrity check for module scripts. Currently,
only top-level module can be verified with integrity parameter since there
is no way to perform integrity check onto the imported modules.

In JSC side, we add parameters to the entry point of the module loader
pipeline. This is fetching parameters and used when fetching modules.

We separately pass this parameters to the pipeline along with the script fetcher.
The script fetcher is only one for module graph since this is the initiator of
this module graph loading. On the other hand, this parameters is for each
module fetching. While setting "integrity" parameters to this script fetcher is
sufficient to pass parameters to top-level-module's fetching, it is not enough
for the future extension.

In the future, we will investigate a way to pass parameters to each non-top-level
module. At that time, this parameters should be per-module. This is because
"integrity" value should be different for each module. For example, we will accept
some form of syntax to add parameters to import. Some proposed syntax is like
​https://discourse.wicg.io/t/specifying-nonce-or-integrity-when-importing-modules/1861

import "./xxx.js" integrity "xxxxxxx"

In this case, this parameters will be passed to "./xxx.js" module fetching. This
parameters should be different from the one of top-level-module's one. That's why
we need per-module parameters and why this patch adds parameters to the module pipeline.

On the other hand, we also want to keep script fetcher. This per-module-graph thing
is important to offer module-graph-wide information. For example, import.meta would
have import.meta.scriptElement, which is the script element fetching the module graph
including this. So, we keep the both, script fetcher and parameters.
​https://github.com/tc39/proposal-import-meta

This parameters will be finally used by pipeline's fetch hook, and WebCore side
can use this parameters to fetch modules.

We also further clean up the module pipeline by dropping unnecessary features.

  • JavaScriptCore.xcodeproj/project.pbxproj:
  • Sources.txt:
  • builtins/ModuleLoaderPrototype.js:

(requestFetch):
(requestInstantiate):
(requestSatisfy):
(loadModule):
(loadAndEvaluateModule):
This loadAndEvaluateModule should be implemented by just calling loadModule and
linkAndEvaluateModule. We can drop requestReady and requestLink.

(requestLink): Deleted.
(requestImportModule): Deleted.

  • jsc.cpp:

(GlobalObject::moduleLoaderImportModule):
(GlobalObject::moduleLoaderFetch):
import and fetch hook takes parameters. Currently, we always pass undefined for
import hook. When dynamic import() is extended to accept additional parameters
like integrity, this parameters will be replaced with the actual value.

(functionLoadModule):
(runWithOptions):

  • runtime/Completion.cpp:

(JSC::loadAndEvaluateModule):
(JSC::loadModule):
(JSC::importModule):

  • runtime/Completion.h:
  • runtime/JSGlobalObject.h:
  • runtime/JSGlobalObjectFunctions.cpp:

(JSC::globalFuncImportModule):

  • runtime/JSModuleLoader.cpp:

(JSC::JSModuleLoader::loadAndEvaluateModule):
(JSC::JSModuleLoader::loadModule):
(JSC::JSModuleLoader::requestImportModule):
(JSC::JSModuleLoader::importModule):
(JSC::JSModuleLoader::fetch):

  • runtime/JSModuleLoader.h:
  • runtime/JSScriptFetchParameters.cpp: Added.

(JSC::JSScriptFetchParameters::destroy):

  • runtime/JSScriptFetchParameters.h: Added.

(JSC::JSScriptFetchParameters::createStructure):
(JSC::JSScriptFetchParameters::create):
(JSC::JSScriptFetchParameters::parameters const):
(JSC::JSScriptFetchParameters::JSScriptFetchParameters):
Add ScriptFetchParameters' JSCell wrapper, JSScriptFetchParameters.
It is used in the module pipeline.

  • runtime/JSType.h:
  • runtime/ModuleLoaderPrototype.cpp:

(JSC::moduleLoaderPrototypeFetch):

  • runtime/ScriptFetchParameters.h: Added.

(JSC::ScriptFetchParameters::~ScriptFetchParameters):
Add ScriptFetchParameters. We can define our own custom ScriptFetchParameters
by inheriting this class. WebCore creates ModuleFetchParameters by inheriting
this.

  • runtime/VM.cpp:

(JSC::VM::VM):

  • runtime/VM.h:

Source/WebCore:

This patch extends module hooks to accept fetching parameters.
When starting fetching modules, WebCore creates ModuleFetchParameters.
And this parameters is propagated to the fetch hook. Then, fetch
hook can use this parameters to fetch modules.

This parameters only contains integrity field. This "integrity" is
used to perform subresource integrity check in module loader pipeline.
And this error is just proparaged as errors in module pipeline, which
is the same to the other types of errors in module pipeline.

Test: http/tests/subresource-integrity/sri-module.html

  • ForwardingHeaders/runtime/JSScriptFetchParameters.h: Added.
  • ForwardingHeaders/runtime/ScriptFetchParameters.h: Added.
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/CachedModuleScriptLoader.cpp:

(WebCore::CachedModuleScriptLoader::create):
(WebCore::CachedModuleScriptLoader::CachedModuleScriptLoader):
Take parameters, which includes "integrity".

  • bindings/js/CachedModuleScriptLoader.h:
  • bindings/js/JSDOMWindowBase.cpp:

(WebCore::JSDOMWindowBase::moduleLoaderFetch):
(WebCore::JSDOMWindowBase::moduleLoaderImportModule):
import and fetch hooks take parameters.

  • bindings/js/JSDOMWindowBase.h:
  • bindings/js/JSMainThreadExecState.h:

(WebCore::JSMainThreadExecState::loadModule):

  • bindings/js/ScriptController.cpp:

(WebCore::ScriptController::loadModuleScriptInWorld):
(WebCore::ScriptController::loadModuleScript):
Pass parameters to the entry point of the module pipeline.

  • bindings/js/ScriptController.h:
  • bindings/js/ScriptModuleLoader.cpp:

(WebCore::ScriptModuleLoader::fetch):
If parameters are passed, we set them to CachedModuleScriptLoader.

(WebCore::ScriptModuleLoader::importModule):
Pass parameters to the entry point of dynamic import.

(WebCore::ScriptModuleLoader::notifyFinished):
If script loader has parameters, we perform subresource integrity check here.

  • bindings/js/ScriptModuleLoader.h:
  • dom/LoadableModuleScript.cpp:

(WebCore::LoadableModuleScript::create):
(WebCore::LoadableModuleScript::LoadableModuleScript):
(WebCore::LoadableModuleScript::load):
Create ModuleFetchParameters with "integrity" value.

  • dom/LoadableModuleScript.h:
  • dom/ModuleFetchParameters.h: Copied from Source/WebCore/bindings/js/CachedModuleScriptLoader.h.

(WebCore::ModuleFetchParameters::create):
(WebCore::ModuleFetchParameters::integrity const):
(WebCore::ModuleFetchParameters::ModuleFetchParameters):

  • dom/ScriptElement.cpp:

(WebCore::ScriptElement::requestModuleScript):
Pass "integrity" value to the module script.

LayoutTests:

  • http/tests/subresource-integrity/resources/crossorigin-anon-script-module.js: Added.
  • http/tests/subresource-integrity/resources/crossorigin-creds-script-module.js: Added.
  • http/tests/subresource-integrity/resources/crossorigin-ineligible-script-module.js: Added.
  • http/tests/subresource-integrity/resources/matching-digest-module.js: Added.
  • http/tests/subresource-integrity/resources/non-matching-digest-module.js: Added.
  • http/tests/subresource-integrity/resources/sri-utilities.js:

(add_result_callback):
(SRIModuleTest):
(SRIModuleTest.prototype.execute):

  • http/tests/subresource-integrity/sri-module-expected.txt: Added.
  • http/tests/subresource-integrity/sri-module.html: Added.
  • js/dom/modules/module-inline-ignore-integrity-expected.txt: Added.
  • js/dom/modules/module-inline-ignore-integrity.html: Added.
  • js/dom/modules/module-integrity-non-top-level-expected.txt: Added.
  • js/dom/modules/module-integrity-non-top-level.html: Added.
  • js/dom/modules/script-tests/module-integrity-non-top-level-2.js: Added.
  • js/dom/modules/script-tests/module-integrity-non-top-level.js: Added.
5:45 AM Changeset in webkit [223236] by commit-queue@webkit.org
  • 4 edits in trunk

It should be possible to iterate just the values (and not the counts) of a HashCountedSet
​https://bugs.webkit.org/show_bug.cgi?id=178169

Patch by Sam Weinig <​sam@webkit.org> on 2017-10-12
Reviewed by Daniel Bates.

Source/WTF:

Cleanup (fix indentation, simplify type names, adopt using), and add a values() range to
HashCountedSet. This will allow getting a Vector of all the values (and not the counts)
using the new copyToVector.

  • wtf/HashCountedSet.h:

Tools:

  • TestWebKitAPI/Tests/WTF/HashCountedSet.cpp:

(TestWebKitAPI::TEST):
Add test for HashCountedSet's new values() range.

4:58 AM Changeset in webkit [223235] by tpopela@redhat.com
  • 2 edits in trunk/Source/WebCore

Unreviewed, fix compilation warning

warning: extra tokens at end of #endif directive [-Wendif-labels]

  • rendering/RenderMediaControls.h:
1:37 AM Changeset in webkit [223234] by fred.wang@free.fr
  • 3 edits in trunk/Tools

run-safari --ios-simulator is no longer working with Xcode 9
​https://bugs.webkit.org/show_bug.cgi?id=177595

Patch by Frederic Wang <​fwang@igalia.com> on 2017-10-11
Reviewed by Daniel Bates.

In Xcode 9, the path of the simulator application is now in a new CoreSimulator subdirectory
of the iphoneOS SDK platform. This patch updates webkitdirs.pm to use the new path in
Xcode 9 or higher so that it is possible to run Safari on the iOS simulator again. It also
does some minor code refactoring to improve code reuse.

  • Scripts/configure-xcode-for-ios-development: Move sdkDirectory() and sdkPlatformDirectory()

into webkitdirs.
(sdkDirectory): Deleted.
(sdkPlatformDirectory): Deleted.

  • Scripts/webkitdirs.pm: Expose new sdkDirectory() and sdkPlatformDirectory().

(sdkDirectory): Moved from configure-xcode-for-ios-development.
(sdkPlatformDirectory): Ditto.
(XcodeSDKPath): Rely on sdkDirectory() to implement this function.
(iosSimulatorApplicationsPath): In Xcode 9 or higher use the new path. It is calculated
by relying on sdkPlatformDirectory().

Note: See TracTimeline for information about the timeline view.