Timeline

Oct 18, 2017:

11:35 PM Changeset in webkit [223680] by jmarcell@apple.com

• 4 edits
  1 add in branches/safari-604-branch

Cherry-pick r221921. rdar://problem/35041482

11:07 PM Changeset in webkit [223679] by jmarcell@apple.com

• 21 edits
  1 add in branches/safari-604-branch

Cherry-pick r221607. rdar://problem/35041474

10:44 PM Changeset in webkit [223678] by rniwa@webkit.org

• 27 edits
  9 adds in trunk

Don't expose raw HTML in pasteboard to the web content
​https://bugs.webkit.org/show_bug.cgi?id=178422
Source/WebCore:

<rdar://problem/34567052>

Reviewed by Wenson Hsieh.

This patch enables HTML sanitization added in r223440 when WebKit pastes & concludes edit drag as opposed to
just when dataTransfer.get is used. This is important to avoid leaking privacy sensitive information such as
local file paths and pasting potentially harmful content such as scripts in event handler serialized by
WebKit prior to r223462. In addition, we start using blob URLs in the pasted content instead of retaining
the original URL and overriding the document loader like r222839 for RTFD and r222119 for image files.

To do this, a new superclass FrameWebContentReader of PasteboardWebContentReader and WebContentMarkupReader
is introduced, and helper functions are extracted out of WebContentMarkupReader in WebContentReaderCocoa.mm
to be also used in WebContentReader.

Tests: http/tests/security/clipboard/copy-paste-html-cross-origin-iframe-across-origin.html

http/tests/security/clipboard/copy-paste-html-cross-origin-iframe-in-same-origin.html
http/tests/security/clipboard/drag-drop-html-cross-origin-iframe-in-same-origin.html
PasteWebArchive.SanitizesHTML

• editing/WebContentReader.cpp:

(WebCore::FrameWebContentReader::shouldSanitize const): Moved from WebContentMarkupReader.

• editing/WebContentReader.h:

(WebCore::FrameWebContentReader): Added to share code between WebContentReader and WebContentMarkupReader.
(WebCore::FrameWebContentReader::FrameWebContentReader): Added.

• editing/cocoa/EditorCocoa.mm:

(WebCore::Editor::writeSelectionToPasteboard): Store the content's origin in the pasteboard so that we can
avoid sanitizing the content when pasting into the same document. This is important since converting all URLs
into blob URLs would break editors on the Web which tracks images, etc... in the content using URLs.
(WebCore::Editor::writeSelection): Ditto.

• editing/cocoa/WebContentReaderCocoa.mm:

(WebCore::MarkupAndArchive): Replaced FragmentAndArchive. Now returns the markup string in the archive
instead of the parsed fragment.
(WebCore::extractMarkupAndArchive): Renamed from createFragmentFromWebArchive. Now returns the markup string.
(WebCore::sanitizeMarkupWithArchive): Extracted out of WebContentMarkupReader::readWebArchive to share code
between WebContentReader and WebContentMarkupReader, and added the code to handle subframes recursively.
As inefficient as this code is, we can't delay the conversion of subframes' marksup until later time since
the main frame's markup would contain blob URLs to refer to those subframes.
(WebCore::WebContentReader::readWebArchive): Use sanitizeMarkupWithArchive when shouldSanitize() is true.
Don't add the subresources to the document loader when the content will be loaded into the same origin since
subresouces are mostly likely available in the document anyway.
(WebCore::WebContentMarkupReader::readWebArchive):

• platform/Pasteboard.h:

(WebCore::PasteboardWebContent): Added contentOrigin.

• platform/PasteboardWriterData.h:

(WebCore::PasteboardWriterData): Ditto.

• platform/ios/PasteboardIOS.mm:

(WebCore::Pasteboard::read): Read the origin before branching out to readRespectingUTIFidelities.

• platform/ios/PlatformPasteboardIOS.mm:

(WebCore::PlatformPasteboard::write): Record the content origin into the pasteboard.

• platform/mac/PasteboardMac.mm:

(WebCore::Pasteboard::write): Ditto.

• platform/mac/PasteboardWriter.mm:

(WebCore::createPasteboardWriter): Ditto.

Source/WebKit:

Reviewed by Wenson Hsieh.

Encode & decode the origin string of the copied content written into the system pasteboard.

• Shared/WebCoreArgumentCoders.cpp:

(IPC::ArgumentCoder<PasteboardWebContent>::encode):
(IPC::ArgumentCoder<PasteboardWebContent>::decode):

Tools:

Reviewed by Wenson Hsieh.

Added a test case for sanitizing web archive in the system pasteboard to strip privacy sensitive information
such as local file paths and potentially harmful scripts like event handlers serialized by WebKit prior to r223462.

• TestWebKitAPI/Tests/WebKitCocoa/PasteWebArchive.mm:

(PasteWebArchive.SanitizesHTML):

LayoutTests:

Reviewed by Wenson Hsieh.

Added tests to copy & paste web contents within the same origin as well as cross origin.

• TestExpectations:
• editing/pasteboard/data-transfer-get-data-on-drop-rich-text-expected.txt: Now contains DOCTYPE.
• editing/pasteboard/data-transfer-get-data-on-paste-rich-text-expected.txt: Ditto.
• editing/pasteboard/onpaste-text-html-expected.txt: Rebaselined as now inline styles are stripped.
• editing/pasteboard/onpaste-text-html.html: Strip away the inline style data since they differ on each platform.
• http/tests/misc/copy-resolves-urls-expected.txt:
• http/tests/misc/copy-resolves-urls.html: Now uses blob URL for the pasted image as expected.
• http/tests/security/clipboard/copy-paste-html-cross-origin-iframe-across-origin-expected.txt: Added.
• http/tests/security/clipboard/copy-paste-html-cross-origin-iframe-across-origin.html: Added.
• http/tests/security/clipboard/copy-paste-html-cross-origin-iframe-in-same-origin-expected.txt: Added.
• http/tests/security/clipboard/copy-paste-html-cross-origin-iframe-in-same-origin.html: Added.
• http/tests/security/clipboard/drag-drop-html-cross-origin-iframe-in-same-origin-expected.txt: Added.
• http/tests/security/clipboard/drag-drop-html-cross-origin-iframe-in-same-origin.html: Added.
• http/tests/security/clipboard/resources/content-to-copy.html: Added.
• http/tests/security/clipboard/resources/subdirectory/paste-html.html: Added.
• platform/ios/TestExpectations: Unskip tests that have started passing.
• platform/mac-wk1/TestExpectations: Unskip the drag & drop test which only works in Mac WK1.
• platform/win/TestExpectations: Skip the newly added tests since we don't support custom pasteboard

data on Windows port.

10:15 PM Changeset in webkit [223677] by jmarcell@apple.com

• 3 edits
  4 adds in branches/safari-604-branch

Cherry-pick r223589. rdar://problem/34771462

10:15 PM Changeset in webkit [223676] by jmarcell@apple.com

• 1 edit in branches/safari-604-branch/Source/WebCore/Modules/applepay/cocoa/PaymentContactCocoa.mm

Cherry-pick r223583. rdar://problem/34958773

10:14 PM Changeset in webkit [223675] by jmarcell@apple.com

• 12 edits in branches/safari-604-branch

Cherry-pick r223580. rdar://problem/34958773

10:14 PM Changeset in webkit [223674] by jmarcell@apple.com

• 2 edits in branches/safari-604-branch/Source/WebCore

Cherry-pick r223424. rdar://problem/34745623

10:14 PM Changeset in webkit [223673] by jmarcell@apple.com

• 2 edits in branches/safari-604-branch/Source/WebCore

Cherry-pick r223423. rdar://problem/34745623

10:14 PM Changeset in webkit [223672] by jmarcell@apple.com

• 4 edits in branches/safari-604-branch/Source/WebCore

Cherry-pick r223420. rdar://problem/34745623

10:14 PM Changeset in webkit [223671] by jmarcell@apple.com

• 4 edits in branches/safari-604-branch/Source/WebCore

Cherry-pick r223419. rdar://problem/34745623

10:14 PM Changeset in webkit [223670] by jmarcell@apple.com

• 2 edits in branches/safari-604-branch/Source/JavaScriptCore

Cherry-pick r223409. rdar://problem/34792148

10:14 PM Changeset in webkit [223669] by jmarcell@apple.com

• 7 edits in branches/safari-604-branch/Source/WebCore

Cherry-pick r223228. rdar://problem/35061705

10:14 PM Changeset in webkit [223668] by jmarcell@apple.com

• 5 edits
  2 adds in branches/safari-604-branch

Cherry-pick r223210. rdar://problem/34820936

10:14 PM Changeset in webkit [223667] by jmarcell@apple.com

• 14 edits in branches/safari-604-branch

Cherry-pick r222471. rdar://problem/35061708

10:02 PM Changeset in webkit [223666] by weinig@apple.com

• 3 edits in trunk/Source/WebCore

Another attempt to fix the windows build.

• page/SettingsBase.cpp:

(WebCore::SettingsBase::resourceUsageOverlayVisibleChanged):

• page/SettingsBase.h:

9:42 PM Changeset in webkit [223665] by weinig@apple.com

• 3 edits in trunk/Source/WebCore

Attempt to fix the windows build.

• page/SettingsBase.cpp:

(WebCore::SettingsBase::resourceUsageOverlayVisibleChanged):

• page/SettingsBase.h:

9:30 PM Changeset in webkit [223664] by jmarcell@apple.com

• 5 edits in branches/safari-604-branch/Source/WebCore

Cherry-pick r221971. rdar://problem/34958928

9:30 PM Changeset in webkit [223663] by jmarcell@apple.com

• 1 edit in branches/safari-604-branch/Source/WebCore/platform/graphics/cv/VideoTextureCopierCV.cpp

Apply patch. rdar://problem/34958928

9:30 PM Changeset in webkit [223662] by jmarcell@apple.com

• 7 edits
  1 add in branches/safari-604-branch/Source

Cherry-pick r223315. rdar://problem/34985202

9:29 PM Changeset in webkit [223661] by jmarcell@apple.com

• 2 edits in branches/safari-604-branch/Source/WebCore

Cherry-pick r223298. rdar://problem/34958928

9:29 PM Changeset in webkit [223660] by jmarcell@apple.com

• 2 edits in branches/safari-604-branch/Source/WebCore

Cherry-pick r223297. rdar://problem/34958928

9:29 PM Changeset in webkit [223659] by jmarcell@apple.com

• 2 edits in branches/safari-604-branch/Source/WebCore

Cherry-pick r223295. rdar://problem/34958928

9:29 PM Changeset in webkit [223658] by jmarcell@apple.com

• 4 edits in branches/safari-604-branch/Source/WebCore

Cherry-pick r223294. rdar://problem/34958928

9:29 PM Changeset in webkit [223657] by jmarcell@apple.com

• 3 edits in branches/safari-604-branch/Source/WebCore

Cherry-pick r223289. rdar://problem/34958928

9:29 PM Changeset in webkit [223656] by jmarcell@apple.com

• 3 edits in branches/safari-604-branch/Source/WebCore

Cherry-pick r223287. rdar://problem/34958928

9:29 PM Changeset in webkit [223655] by jmarcell@apple.com

• 2 edits in branches/safari-604-branch/Source/WebCore

Cherry-pick r223285. rdar://problem/34958928

9:29 PM Changeset in webkit [223654] by jmarcell@apple.com

• 11 edits in branches/safari-604-branch/Source/WebCore

Cherry-pick r223280. rdar://problem/34958928

9:08 PM Changeset in webkit [223653] by commit-queue@webkit.org

• 6 edits in trunk/Source/WebCore

[Settings] Convert more settings to be generated
​https://bugs.webkit.org/show_bug.cgi?id=177766

Patch by Sam Weinig <​sam@webkit.org> on 2017-10-18
Reviewed by Dean Jackson.

• Replaces setNeedsStyleRecalcInAllFrames option in Settings.in with a more generic, onChange, which allows you to specify a function in SettingsBase that will be called when the setting changes. setNeedsStyleRecalcInAllFrames is then reimplemented in terms of onChange.
• Moves most (all but two) of the remaining non-static settings from SettingsBase to Settings.in

• Scripts/GenerateSettings/GenerateSettingsImplementationFile.py:

(printSetterBody):

• Scripts/GenerateSettings/Settings.py:

(Setting.init):
(Setting.str):
(Setting.typeIsValueType):
(Setting.setterFunctionName):
(Setting.setterChangeFunctionName):
(Setting.hasComplexSetter):
(parseInput):

Add support for the onChange option.

• page/Settings.in:

Migrate most of the remaining non-static settings to Settings.in.
Adopt onChange option.

• page/SettingsBase.cpp:
• page/SettingsBase.h:

Add helper functions for use by the onChange option.

8:29 PM Changeset in webkit [223652] by Chris Dumez

• 20 edits in trunk

Implement ServiceWorkerRegistration.scope / updateViaCache
​https://bugs.webkit.org/show_bug.cgi?id=178497

Reviewed by Youenn Fablet.

Source/WebCore:

Implement ServiceWorkerRegistration.scope / updateViaCache.

No new tests, updated existing test.

• WebCore.xcodeproj/project.pbxproj:
• workers/service/ServiceWorkerContainer.cpp:

(WebCore::ServiceWorkerContainer::jobResolvedWithRegistration):

• workers/service/ServiceWorkerContainer.h:
• workers/service/ServiceWorkerJob.cpp:

(WebCore::ServiceWorkerJob::resolvedWithRegistration):

• workers/service/ServiceWorkerJob.h:
• workers/service/ServiceWorkerJobClient.h:
• workers/service/ServiceWorkerRegistration.cpp:

(WebCore::ServiceWorkerRegistration::ServiceWorkerRegistration):
(WebCore::ServiceWorkerRegistration::scope const):
(WebCore::ServiceWorkerRegistration::updateViaCache const):
(WebCore::ServiceWorkerRegistration::update):
(WebCore::ServiceWorkerRegistration::unregister):
(WebCore::ServiceWorkerRegistration::scriptExecutionContext const):
(WebCore::ServiceWorkerRegistration::activeDOMObjectName const):
(WebCore::ServiceWorkerRegistration::canSuspendForDocumentSuspension const):

• workers/service/ServiceWorkerRegistration.h:
• workers/service/ServiceWorkerRegistration.idl:
• workers/service/ServiceWorkerRegistrationData.cpp:

(WebCore::ServiceWorkerRegistrationData::isolatedCopy const):

• workers/service/ServiceWorkerRegistrationData.h:

(WebCore::ServiceWorkerRegistrationData::encode const):
(WebCore::ServiceWorkerRegistrationData::decode):

• workers/service/server/SWClientConnection.cpp:

(WebCore::SWClientConnection::jobResolvedInServer):

• workers/service/server/SWClientConnection.h:
• workers/service/server/SWServerRegistration.cpp:

(WebCore::SWServerRegistration::scriptContextStarted):
(WebCore::SWServerRegistration::data const):

Source/WebKit:

• Shared/WebCoreArgumentCoders.h:
• StorageProcess/ServiceWorker/WebSWServerConnection.cpp:

LayoutTests:

Extend layout test coverage.

• http/tests/workers/service/basic-register-expected.txt:
• http/tests/workers/service/resources/basic-register.js:

(then):

7:26 PM Changeset in webkit [223651] by jmarcell@apple.com

• 11 edits
  1 add in branches/safari-604-branch

Cherry-pick r223614. rdar://problem/34920288

7:26 PM Changeset in webkit [223650] by commit-queue@webkit.org

• 34 edits
  2 copies
  1 move
  6 adds
  1 delete in trunk

Add preliminary support for ServiceWorker Handle Fetch
​https://bugs.webkit.org/show_bug.cgi?id=178475

Patch by Youenn Fablet <​youenn@apple.com> on 2017-10-18
Reviewed by Chris Dumez.

Source/WebCore:

Test: http/tests/workers/service/basic-fetch.https.html

Adding parameters to allow WebKit to do loading through Service Worker or through regular networking.
A script context is now storing its selected service worker identifier. This should be fully implemented later on.
This selected service worker identifier is passed to loading code as a ResourceLoaderOptions field.
Service workers mode is also added as a ResourceLoaderOptions field so that the service worker can be bypassed.

• WebCore.xcodeproj/project.pbxproj:
• dom/ScriptExecutionContext.h:

(WebCore::ScriptExecutionContext::selectedServiceWorkerIdentifier const):
(WebCore::ScriptExecutionContext::setSelectedServiceWorkerIdentifier):

• loader/DocumentThreadableLoader.cpp:

(WebCore::DocumentThreadableLoader::DocumentThreadableLoader):

• loader/FetchOptions.h:

(WebCore::isPotentialNavigationOrSubresourceRequest):
(WebCore::isNonSubresourceRequest):

• loader/ResourceLoaderOptions.h:
• loader/WorkerThreadableLoader.cpp:

(WebCore::WorkerThreadableLoader::WorkerThreadableLoader):
(WebCore::WorkerThreadableLoader::MainThreadBridge::MainThreadBridge):

• loader/WorkerThreadableLoader.h:
• platform/network/ResourceRequestBase.h:
• platform/network/ResourceResponseBase.h:
• workers/WorkerThread.h:
• workers/service/ServiceWorkerContainer.cpp:

(WebCore::ServiceWorkerContainer::jobResolvedWithRegistration):

• workers/service/ServiceWorkerProvider.h:
• workers/service/context/SWContextManager.cpp: Removed.
• workers/service/context/ServiceWorkerThread.h:
• workers/service/server/SWServer.h:

Source/WebKit:

Preliminary support of Handle Fetch algorithm and integration with fetch spec.
Adding ServiceWorkerClientFetch as the class responsible to do the load through ServiceWorker.
It is similar to WebResourceLoader that do the load through NetworkProcess.
In case ServiceWorkerClientFetch is not able to load through ServiceWorker,
it will fallback to WebResourceLoader through a fallback callback.

Loading through Service Worker is done currently if:

• There is a service worker registered for that origin
• Request is a subresource
• service workers mode is all

There will be cases where the service worker will not do the loading, for instance when fetch event handler is not set.
Future work should try to reduce the cases where the IPC dance is done unnecessarily.

ServiceWorkerClientFetch is responsible to adapt the ServiceWorker response to ResourceLoader.
In particular, it is calling ResourceLoader error callback if response is of type error.
It should call ResourceLoader redirection callback if response is a redirection response.
This will be done as a follow-up.

Implementing the IPC communication dedicated to fetch between WebProcess and ServiceWorker through StorageProcess.
In the future, WebProcess should create a direct IPC communication to the ServiceWorker process.

Moved SWContextManager from WebCore to WebKit and renamed it to ServiceWorkerContextManager.
This class is moved to WebKit as it will have to handle IPC and having a separation will add some unnecessary boilerplate.

• DerivedSources.make:
• StorageProcess/ServiceWorker/WebSWServerConnection.cpp:

(WebKit::WebSWServerConnection::startFetch):
(WebKit::WebSWServerConnection::didReceiveFetchResponse):
(WebKit::WebSWServerConnection::didReceiveFetchData):
(WebKit::WebSWServerConnection::didFinishFetch):
(WebKit::WebSWServerConnection::failedFetch):

• StorageProcess/ServiceWorker/WebSWServerConnection.h:
• StorageProcess/ServiceWorker/WebSWServerConnection.messages.in:
• StorageProcess/StorageProcess.cpp:

(WebKit::StorageProcess::failedFetch):
(WebKit::StorageProcess::didReceiveFetchResponse):
(WebKit::StorageProcess::didReceiveFetchData):
(WebKit::StorageProcess::didFinishFetch):

• StorageProcess/StorageProcess.h:
• StorageProcess/StorageProcess.messages.in:
• WebKit.xcodeproj/project.pbxproj:
• WebProcess/Network/WebLoaderStrategy.cpp:

(WebKit::WebLoaderStrategy::scheduleLoad):
(WebKit::WebLoaderStrategy::scheduleLoadFromNetworkProcess):

• WebProcess/Network/WebLoaderStrategy.h:
• WebProcess/Storage/ServiceWorkerClientFetch.cpp: Added.

(WebKit::ServiceWorkerClientFetch::didReceiveResponse):
(WebKit::ServiceWorkerClientFetch::didReceiveData):
(WebKit::ServiceWorkerClientFetch::didFinishFetch):
(WebKit::ServiceWorkerClientFetch::didFail):

• WebProcess/Storage/ServiceWorkerClientFetch.h: Added.
• WebProcess/Storage/ServiceWorkerClientFetch.messages.in: Added.
• WebProcess/Storage/ServiceWorkerContextManager.cpp: Renamed from Source/WebCore/workers/service/context/SWContextManager.cpp.

(WebKit::ServiceWorkerContextManager::startServiceWorkerContext):
(WebKit::ServiceWorkerContextManager::startFetch):

• WebProcess/Storage/ServiceWorkerContextManager.h: Renamed from Source/WebCore/workers/service/context/SWContextManager.h.

(WebKit::ServiceWorkerContextManager::ServiceWorkerContextManager):

• WebProcess/Storage/WebSWClientConnection.cpp:

(WebKit::WebSWClientConnection::startFetch):

• WebProcess/Storage/WebSWClientConnection.h:
• WebProcess/Storage/WebServiceWorkerProvider.cpp:

(WebKit::shouldHandleFetch):
(WebKit::WebServiceWorkerProvider::handleFetch):
(WebKit::WebServiceWorkerProvider::didReceiveServiceWorkerClientFetchMessage):

• WebProcess/Storage/WebServiceWorkerProvider.h:
• WebProcess/Storage/WebToStorageProcessConnection.cpp:

(WebKit::WebToStorageProcessConnection::didReceiveMessage):

• WebProcess/WebProcess.cpp:

(WebKit::WebProcess::getWorkerContextConnection):
(WebKit::WebProcess::startServiceWorkerContext):
(WebKit::WebProcess::startFetchInServiceWorker):

• WebProcess/WebProcess.h:
• WebProcess/WebProcess.messages.in:

LayoutTests:

• http/tests/workers/service/basic-fetch.https-expected.txt: Added.
• http/tests/workers/service/basic-fetch.https.html: Added.
• http/tests/workers/service/resources/basic-fetch-worker.js: Added.
• http/tests/workers/service/resources/basic-fetch.js: Added.

7:22 PM Changeset in webkit [223649] by Alan Bujtas

• 2 edits in trunk/Source/WebCore

[FrameView::layout cleanup] Group related pre-layout code to improve readability
​https://bugs.webkit.org/show_bug.cgi?id=178496
<rdar://problem/35065718>

Reviewed by Simon Fraser.

Early returns/asserts/member variable resets etc.

Covered by existing tests.

• page/FrameView.cpp:

(WebCore::FrameView::layout):

7:14 PM Changeset in webkit [223648] by commit-queue@webkit.org

• 9 edits in trunk

TestController should clear all fetch caches when resetting its state
​https://bugs.webkit.org/show_bug.cgi?id=178486

Patch by Youenn Fablet <​youenn@apple.com> on 2017-10-18
Reviewed by Chris Dumez.

Tools:

Adding clearDOMCaches test runner method.
Using that method when resetting state.

• WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
• WebKitTestRunner/InjectedBundle/TestRunner.cpp:

(WTR::TestRunner::clearDOMCaches):

• WebKitTestRunner/InjectedBundle/TestRunner.h:
• WebKitTestRunner/TestInvocation.cpp:

(WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):

LayoutTests:

• http/tests/cache-storage/cache-clearing-all.https.html:

6:39 PM Changeset in webkit [223647] by cpugh@apple.com

• 6 edits in trunk

[iOS] Use new class name from UIKit when checking UITextSuggestion type
​https://bugs.webkit.org/show_bug.cgi?id=178416
Source/WebKit:

<rdar://problem/35010840>

Reviewed by Tim Horton.

Here we start using UITextAutofillSuggestion instead of the old name that was being used for
AutoFill text suggestions.

• Platform/spi/ios/UIKitSPI.h:
• UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView insertTextSuggestion:]): Use UITextAutofillSuggestion when checking the class
and when casting instead of UIKeyboardLoginCredentialsSuggestion.

Tools:

Reviewed by Tim Horton.

This updates our test using/mocking out UITextAutofillSuggestion instead of UIKeyboardLoginCredentialsSuggestion.

• TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:

(-[UITextAutofillSuggestion initWithUsername:password:]): Copied from UIKit's implementation. This will serve as
a mock of this method for builds not containingit.
(+[UITextAutofillSuggestion autofillSuggestionWithUsername:password:]): Ditto.
(TestWebKitAPI::TEST): Use +[UITextAutofillSuggestion autofillSuggestionWithUsername:password:] inline instead of
helper function for creating a new suggestion.
(newUIKeyboardLoginCredentialsSuggestion): Deleted.

• TestWebKitAPI/ios/UIKitSPI.h:

6:22 PM Changeset in webkit [223646] by commit-queue@webkit.org

• 3 edits in trunk/Source/WebInspectorUI

Web Inspector: Layers sidebar footer should not have white background with full-width quick console
​https://bugs.webkit.org/show_bug.cgi?id=178493

Patch by Ross Kirsling <Ross Kirsling> on 2017-10-18
Reviewed by Matt Baker.

• UserInterface/Views/LayerDetailsSidebarPanel.css:

Update CSS for new sidebar.

• UserInterface/Views/LayerTreeDetailsSidebarPanel.css:

Update CSS for legacy sidebar.

6:12 PM Changeset in webkit [223645] by mark.lam@apple.com

• 3 edits
  1 add in trunk

RegExpObject::defineOwnProperty() does not need to compare values if no descriptor value is specified.
​https://bugs.webkit.org/show_bug.cgi?id=177600
<rdar://problem/34710985>

Reviewed by Saam Barati.

JSTests:

• stress/regress-177600.js: Added.

Source/JavaScriptCore:

According to ​http://www.ecma-international.org/ecma-262/8.0/#sec-validateandapplypropertydescriptor,
section 9.1.6.3-7.a.ii, we should only check if the value is the same if the
descriptor value is present.

• runtime/RegExpObject.cpp:

(JSC::RegExpObject::defineOwnProperty):

6:01 PM Changeset in webkit [223644] by jiewen_tan@apple.com

• 135 edits in trunk/Source

Replace some stack raw pointers with RefPtrs within WebCore/html
​https://bugs.webkit.org/show_bug.cgi?id=178201
<rdar://problem/34841692>

Reviewed by Ryosuke Niwa.

Source/WebCore:

This is an effort to reduce raw pointer usage in DOM code. In this patch, raw pointers
that are ref countable are blindly selected to be replaced with RefPtrs with one exception
which is auto*.

Also, this patch occasionally modifies the return type of some methods, and therefore callers
of those methods are modified accordingly.

• Modules/encryptedmedia/legacy/LegacyCDM.cpp:

(WebCore::LegacyCDM::mediaPlayer const):

• Modules/encryptedmedia/legacy/LegacyCDM.h:
• Modules/encryptedmedia/legacy/LegacyCDMPrivateMediaPlayer.cpp:

(WebCore::CDMPrivateMediaPlayer::createSession):

• Modules/encryptedmedia/legacy/WebKitMediaKeys.cpp:

(WebCore::WebKitMediaKeys::cdmMediaPlayer const):

• Modules/encryptedmedia/legacy/WebKitMediaKeys.h:
• Modules/mediacontrols/MediaControlsHost.cpp:

(WebCore::MediaControlsHost::externalDeviceDisplayName const):
(WebCore::MediaControlsHost::externalDeviceType const):

• dom/Element.cpp:

(WebCore::Element::focusDelegate):
(WebCore::Element::userAgentShadowRoot const):
(WebCore::Element::ensureUserAgentShadowRoot):

• dom/Element.h:
• dom/EventContext.cpp:

(WebCore::TouchEventContext::checkReachability const):

• dom/EventPath.cpp:

(WebCore::shouldEventCrossShadowBoundary):
(WebCore::EventPath::setRelatedTarget):
(WebCore::EventPath::retargetTouch):
(WebCore:: const):

• dom/EventTarget.cpp:

(WebCore::EventTarget::toNode):
(WebCore::EventTarget::addEventListener):

• dom/EventTarget.h:
• dom/MouseEvent.cpp:

(WebCore::MouseEvent::toElement const):
(WebCore::MouseEvent::fromElement const):

• dom/MouseEvent.h:
• dom/MouseRelatedEvent.cpp:

(WebCore::MouseRelatedEvent::computeRelativePosition):

• dom/Node.cpp:

(WebCore::Node::toNode):

• dom/Node.h:
• dom/ScopedEventQueue.cpp:
• editing/Editor.cpp:

(WebCore::Editor::selectionForCommand):

• editing/EditorCommand.cpp:

(WebCore::targetFrame):

• editing/TextIterator.cpp:

(WebCore::TextIterator::handleReplacedElement):

• html/BaseChooserOnlyDateAndTimeInputType.cpp:

(WebCore::BaseChooserOnlyDateAndTimeInputType::updateAppearance):

• html/ColorInputType.cpp:

(WebCore::ColorInputType::updateColorSwatch):
(WebCore::ColorInputType::shadowColorSwatch const):

• html/FileInputType.cpp:

(WebCore::FileInputType::disabledAttributeChanged):
(WebCore::FileInputType::multipleAttributeChanged):

• html/FormAssociatedElement.cpp:

(WebCore::FormAssociatedElement::findAssociatedForm):
(WebCore::FormAssociatedElement::formOwnerRemovedFromTree):
(WebCore::FormAssociatedElement::resetFormOwner):
(WebCore::FormAssociatedElement::formAttributeChanged):

• html/FormController.cpp:

(WebCore::recordFormStructure):
(WebCore::FormKeyGenerator::formKey):
(WebCore::FormController::restoreControlStateIn):

• html/HTMLAnchorElement.cpp:

(WebCore::appendServerMapMousePosition):
(WebCore::HTMLAnchorElement::handleClick):

• html/HTMLAppletElement.cpp:

(WebCore::HTMLAppletElement::updateWidget):

• html/HTMLAreaElement.cpp:

(WebCore::HTMLAreaElement::imageElement const):
(WebCore::HTMLAreaElement::isFocusable const):
(WebCore::HTMLAreaElement::setFocus):
(WebCore::HTMLAreaElement::updateFocusAppearance):

• html/HTMLBodyElement.cpp:

(WebCore::HTMLBodyElement::scrollLeft):
(WebCore::HTMLBodyElement::setScrollLeft):
(WebCore::HTMLBodyElement::scrollTop):
(WebCore::HTMLBodyElement::setScrollTop):
(WebCore::HTMLBodyElement::scrollHeight):
(WebCore::HTMLBodyElement::scrollWidth):

• html/HTMLCanvasElement.cpp:

(WebCore::HTMLCanvasElement::createElementRenderer):
(WebCore:: const):

• html/HTMLDocument.cpp:

(WebCore::HTMLDocument::width):
(WebCore::HTMLDocument::height):

• html/HTMLElement.cpp:

(WebCore::HTMLElement::rendererIsNeeded):
(WebCore::setHasDirAutoFlagRecursively):
(WebCore::HTMLElement::directionality const):
(WebCore::HTMLElement::dirAttributeChanged):
(WebCore::HTMLElement::adjustDirectionalityIfNeededAfterChildrenChanged):

• html/HTMLEmbedElement.cpp:

(WebCore::HTMLEmbedElement::renderWidgetLoadingPlugin const):
(WebCore::HTMLEmbedElement::rendererIsNeeded):

• html/HTMLFieldSetElement.cpp:

(WebCore::updateFromControlElementsAncestorDisabledStateUnder):
(WebCore::HTMLFieldSetElement::disabledStateChanged):
(WebCore::HTMLFieldSetElement::childrenChanged):

• html/HTMLFormControlElement.cpp:

(WebCore::HTMLFormControlElement::computeIsDisabledByFieldsetAncestor const):
(WebCore::HTMLFormControlElement::setNeedsWillValidateCheck):
(WebCore::HTMLFormControlElement::didChangeForm):
(WebCore::HTMLFormControlElement::shouldAutocorrect const):
(WebCore::HTMLFormControlElement::autocapitalizeType const):

• html/HTMLFormElement.cpp:

(WebCore::HTMLFormElement::handleLocalEvents):
(WebCore::submitElementFromEvent):
(WebCore::HTMLFormElement::prepareForSubmission):
(WebCore::HTMLFormElement::submit):
(WebCore::HTMLFormElement::reset):
(WebCore::HTMLFormElement::shouldAutocorrect const):
(WebCore::HTMLFormElement::parseAttribute):
(WebCore::HTMLFormElement::resetDefaultButton):
(WebCore::HTMLFormElement::elementFromPastNamesMap const):
(WebCore::HTMLFormElement::namedElements):

• html/HTMLFormElement.h:
• html/HTMLFrameElement.cpp:

(WebCore::HTMLFrameElement::didAttachRenderers):

• html/HTMLFrameElementBase.cpp:

(WebCore::HTMLFrameElementBase::isURLAllowed const):
(WebCore::HTMLFrameElementBase::openURL):
(WebCore::HTMLFrameElementBase::didAttachRenderers):

• html/HTMLFrameOwnerElement.cpp:

(WebCore::HTMLFrameOwnerElement::setContentFrame):
(WebCore::HTMLFrameOwnerElement::clearContentFrame):
(WebCore::HTMLFrameOwnerElement::disconnectContentFrame):
(WebCore::SubframeLoadingDisabler::canLoadFrame):

• html/HTMLFrameSetElement.cpp:

(WebCore::HTMLFrameSetElement::findContaining):
(WebCore::HTMLFrameSetElement::willAttachRenderers):
(WebCore::HTMLFrameSetElement::insertedInto):
(WebCore::HTMLFrameSetElement::removedFrom):

• html/HTMLFrameSetElement.h:
• html/HTMLImageElement.cpp:

(WebCore::HTMLImageElement::bestFitSourceFromPictureElement):
(WebCore::HTMLImageElement::pictureElement const):
(WebCore::HTMLImageElement::destroyImageControls):
(WebCore::HTMLImageElement::hasImageControls const):

• html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::innerTextElement const):
(WebCore::HTMLInputElement::endEditing):
(WebCore::HTMLInputElement::dataList const):
(WebCore::HTMLInputElement::resetListAttributeTargetObserver): Deleted.
(WebCore::HTMLInputElement::listAttributeTargetChanged): Deleted.
(WebCore::HTMLInputElement::isSteppable const): Deleted.
(WebCore::HTMLInputElement::dateType const): Deleted.
(WebCore::HTMLInputElement::isTextButton const): Deleted.
(WebCore::HTMLInputElement::isRadioButton const): Deleted.
(WebCore::HTMLInputElement::isSearchField const): Deleted.
(WebCore::HTMLInputElement::isInputTypeHidden const): Deleted.
(WebCore::HTMLInputElement::isPasswordField const): Deleted.
(WebCore::HTMLInputElement::isCheckbox const): Deleted.
(WebCore::HTMLInputElement::isRangeControl const): Deleted.
(WebCore::HTMLInputElement::isColorControl const): Deleted.
(WebCore::HTMLInputElement::isText const): Deleted.
(WebCore::HTMLInputElement::isEmailField const): Deleted.
(WebCore::HTMLInputElement::isFileUpload const): Deleted.
(WebCore::HTMLInputElement::isImageButton const): Deleted.
(WebCore::HTMLInputElement::isNumberField const): Deleted.
(WebCore::HTMLInputElement::isSubmitButton const): Deleted.
(WebCore::HTMLInputElement::isTelephoneField const): Deleted.
(WebCore::HTMLInputElement::isURLField const): Deleted.
(WebCore::HTMLInputElement::isDateField const): Deleted.
(WebCore::HTMLInputElement::isDateTimeField const): Deleted.
(WebCore::HTMLInputElement::isDateTimeLocalField const): Deleted.
(WebCore::HTMLInputElement::isMonthField const): Deleted.
(WebCore::HTMLInputElement::isTimeField const): Deleted.
(WebCore::HTMLInputElement::isWeekField const): Deleted.
(WebCore::HTMLInputElement::isEnumeratable const): Deleted.
(WebCore::HTMLInputElement::supportLabels const): Deleted.
(WebCore::HTMLInputElement::shouldAppearChecked const): Deleted.
(WebCore::HTMLInputElement::supportsPlaceholder const): Deleted.
(WebCore::HTMLInputElement::updatePlaceholderText): Deleted.
(WebCore::HTMLInputElement::isEmptyValue const): Deleted.
(WebCore::HTMLInputElement::maxLengthAttributeChanged): Deleted.
(WebCore::HTMLInputElement::minLengthAttributeChanged): Deleted.
(WebCore::HTMLInputElement::updateValueIfNeeded): Deleted.
(WebCore::HTMLInputElement::defaultToolTip const): Deleted.
(WebCore::HTMLInputElement::matchesIndeterminatePseudoClass const): Deleted.
(WebCore::HTMLInputElement::shouldAppearIndeterminate const): Deleted.
(WebCore::HTMLInputElement::mediaCaptureType const): Deleted.
(WebCore::HTMLInputElement::isInRequiredRadioButtonGroup): Deleted.
(WebCore:: const): Deleted.
(WebCore::HTMLInputElement::checkedRadioButtonForGroup const): Deleted.
(WebCore::HTMLInputElement::radioButtonGroups const): Deleted.
(WebCore::HTMLInputElement::addToRadioButtonGroup): Deleted.
(WebCore::HTMLInputElement::removeFromRadioButtonGroup): Deleted.
(WebCore::HTMLInputElement::height const): Deleted.
(WebCore::HTMLInputElement::width const): Deleted.
(WebCore::HTMLInputElement::setHeight): Deleted.
(WebCore::HTMLInputElement::setWidth): Deleted.
(WebCore::ListAttributeTargetObserver::ListAttributeTargetObserver): Deleted.
(WebCore::ListAttributeTargetObserver::idTargetChanged): Deleted.
(WebCore::HTMLInputElement::setRangeText): Deleted.
(WebCore::HTMLInputElement::shouldTruncateText const): Deleted.
(WebCore::HTMLInputElement::selectionStartForBindings const): Deleted.
(WebCore::HTMLInputElement::setSelectionStartForBindings): Deleted.
(WebCore::HTMLInputElement::selectionEndForBindings const): Deleted.
(WebCore::HTMLInputElement::setSelectionEndForBindings): Deleted.
(WebCore::HTMLInputElement::selectionDirectionForBindings const): Deleted.
(WebCore::HTMLInputElement::setSelectionDirectionForBindings): Deleted.
(WebCore::HTMLInputElement::setSelectionRangeForBindings): Deleted.
(WebCore::HTMLInputElement::createInnerTextStyle const): Deleted.
(WebCore::HTMLInputElement::setupDateTimeChooserParameters): Deleted.
(WebCore::HTMLInputElement::capsLockStateMayHaveChanged): Deleted.

• html/HTMLInputElement.h:
• html/HTMLKeygenElement.cpp:

(WebCore::HTMLKeygenElement::shadowSelect const):

• html/HTMLLabelElement.cpp:

(WebCore::HTMLLabelElement::defaultEventHandler):

• html/HTMLLinkElement.cpp:

(WebCore::HTMLLinkElement::handleClick):

• html/HTMLMapElement.cpp:

(WebCore::HTMLMapElement::mapMouseEvent):

• html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::selectMediaResource):
(WebCore::HTMLMediaElement::loadResource):
(WebCore::HTMLMediaElement::updateActiveTextTrackCues):
(WebCore::HTMLMediaElement::isSafeToLoadURL):
(WebCore::HTMLMediaElement::controls const):
(WebCore::HTMLMediaElement::layoutSizeChanged):
(WebCore::HTMLMediaElement::enterFullscreen):
(WebCore::HTMLMediaElement::mediaControls const):
(WebCore::HTMLMediaElement::hasMediaControls const):
(WebCore::HTMLMediaElement::mediaPlayerReferrer const):
(WebCore::HTMLMediaElement::mediaPlayerUserAgent const):
(WebCore::HTMLMediaElement::mediaPlayerShouldWaitForResponseToAuthenticationChallenge):
(WebCore::HTMLMediaElement::sourceApplicationIdentifier const):
(WebCore::HTMLMediaElement::getVideoPlaybackQuality):
(WebCore::HTMLMediaElement::session const):

• html/HTMLMediaElement.h:

(WebCore::HTMLMediaElement::player const):

• html/HTMLObjectElement.cpp:

(WebCore::HTMLObjectElement::hasFallbackContent const):

• html/HTMLOptGroupElement.cpp:

(WebCore::HTMLOptGroupElement::ownerSelectElement const):
(WebCore::HTMLOptGroupElement::accessKeyAction):

• html/HTMLOptionElement.cpp:

(WebCore::HTMLOptionElement::setText):
(WebCore::HTMLOptionElement::accessKeyAction):
(WebCore::HTMLOptionElement::index const):
(WebCore::HTMLOptionElement::parseAttribute):
(WebCore::HTMLOptionElement::selected):
(WebCore::HTMLOptionElement::setSelected):
(WebCore::HTMLOptionElement::setSelectedState):
(WebCore::HTMLOptionElement::childrenChanged):
(WebCore::HTMLOptionElement::ownerDataListElement const):
(WebCore::HTMLOptionElement::ownerSelectElement const):
(WebCore::HTMLOptionElement::textIndentedToRespectGroupLabel const):
(WebCore::HTMLOptionElement::insertedInto):
(WebCore::HTMLOptionElement::collectOptionInnerText const):

• html/HTMLPlugInElement.cpp:

(WebCore::HTMLPlugInElement::willDetachRenderers):
(WebCore::HTMLPlugInElement::isKeyboardFocusable const):
(WebCore::HTMLPlugInElement::isUserObservable const):

• html/HTMLPlugInImageElement.cpp:

(WebCore::HTMLPlugInImageElement::partOfSnapshotOverlay const):
(WebCore::HTMLPlugInImageElement::restartSimilarPlugIns):

• html/HTMLSelectElement.cpp:

(WebCore::HTMLSelectElement::add):
(WebCore::HTMLSelectElement::recalcListItems const):
(WebCore::HTMLSelectElement::selectOption):
(WebCore::HTMLSelectElement::reset):
(WebCore::HTMLSelectElement::listBoxDefaultEventHandler):

• html/HTMLSlotElement.cpp:

(WebCore::flattenAssignedNodes):

• html/HTMLSourceElement.cpp:

(WebCore::HTMLSourceElement::removedFrom):

• html/HTMLSummaryElement.cpp:

(WebCore::HTMLSummaryElement::isActiveSummary const):
(WebCore::isClickableControl):
(WebCore::HTMLSummaryElement::defaultEventHandler):

• html/HTMLTableCellElement.cpp:

(WebCore::HTMLTableCellElement::additionalPresentationAttributeStyle const):

• html/HTMLTableColElement.cpp:

(WebCore::HTMLTableColElement::additionalPresentationAttributeStyle const):

• html/HTMLTableElement.cpp:

(WebCore::HTMLTableElement::tHead const):
(WebCore::HTMLTableElement::setTHead):
(WebCore::HTMLTableElement::tFoot const):
(WebCore::HTMLTableElement::createTBody):
(WebCore::HTMLTableElement::lastBody const):
(WebCore::HTMLTableElement::deleteRow):

• html/HTMLTablePartElement.cpp:

(WebCore::HTMLTablePartElement::findParentTable const):

• html/HTMLTableRowsCollection.cpp:

(WebCore::HTMLTableRowsCollection::rowAfter):

• html/HTMLTextAreaElement.cpp:

(WebCore::HTMLTextAreaElement::subtreeHasChanged):
(WebCore::HTMLTextAreaElement::innerTextElement const):

• html/HTMLTextAreaElement.h:
• html/HTMLTextFormControlElement.cpp:

(WebCore::HTMLTextFormControlElement::setSelectionRange):
(WebCore::HTMLTextFormControlElement::indexForVisiblePosition const):
(WebCore::HTMLTextFormControlElement::visiblePositionForIndex const):
(WebCore::HTMLTextFormControlElement::computeSelectionStart const):
(WebCore::HTMLTextFormControlElement::computeSelectionEnd const):
(WebCore::HTMLTextFormControlElement::computeSelectionDirection const):
(WebCore::HTMLTextFormControlElement::selection const):
(WebCore::HTMLTextFormControlElement::updateInnerTextElementEditability):
(WebCore::innerTextValueFrom):
(WebCore::HTMLTextFormControlElement::setInnerTextValue):
(WebCore::HTMLTextFormControlElement::innerTextValue const):
(WebCore::positionForIndex):
(WebCore::HTMLTextFormControlElement::indexForPosition const):
(WebCore::HTMLTextFormControlElement::hidePlaceholder):
(WebCore::HTMLTextFormControlElement::showPlaceholderIfNecessary):
(WebCore::HTMLTextFormControlElement::valueWithHardLineBreaks const):
(WebCore::enclosingTextFormControl):
(WebCore::HTMLTextFormControlElement::adjustInnerTextStyle const):

• html/HTMLTextFormControlElement.h:
• html/HTMLTrackElement.cpp:

(WebCore::HTMLTrackElement::canLoadURL):
(WebCore::HTMLTrackElement::setReadyState):
(WebCore::HTMLTrackElement::mediaElementCrossOriginAttribute const):
(WebCore::HTMLTrackElement::textTrackKindChanged):
(WebCore::HTMLTrackElement::textTrackModeChanged):
(WebCore::HTMLTrackElement::textTrackAddCues):
(WebCore::HTMLTrackElement::textTrackRemoveCues):
(WebCore::HTMLTrackElement::textTrackAddCue):
(WebCore::HTMLTrackElement::textTrackRemoveCue):
(WebCore::HTMLTrackElement::mediaElement const):

• html/HTMLTrackElement.h:
• html/HTMLVideoElement.cpp:

(WebCore::HTMLVideoElement::setDisplayMode):
(WebCore::HTMLVideoElement::paintCurrentFrameInContext):

• html/ImageDocument.cpp:

(WebCore::ImageDocument::createDocumentStructure):
(WebCore::ImageDocument::scale):
(WebCore::ImageDocument::imageFitsInWindow):

• html/InputType.cpp:

(WebCore::InputType::destroyShadowSubtree):

• html/InputType.h:

(WebCore::InputType::innerTextElement const):

• html/MediaDocument.cpp:

(WebCore::MediaDocumentParser::createDocumentStructure):
(WebCore::MediaDocument::defaultEventHandler):

• html/MediaElementSession.cpp:

(WebCore::MediaElementSession::wirelessVideoPlaybackDisabled const):
(WebCore::MediaElementSession::setWirelessVideoPlaybackDisabled):
(WebCore::isMainContentForPurposesOfAutoplay):

• html/NumberInputType.cpp:

(WebCore::NumberInputType::decorationWidth const):

• html/PluginDocument.cpp:

(WebCore::PluginDocumentParser::appendBytes):

• html/RadioInputType.cpp:

(WebCore::RadioInputType::handleKeydownEvent):
(WebCore::RadioInputType::isKeyboardFocusable const):
(WebCore::RadioInputType::didDispatchClick):

• html/RadioNodeList.cpp:

(WebCore::RadioNodeList::checkElementMatchesRadioNodeListFilter const):

• html/RangeInputType.cpp:

(WebCore::RangeInputType::handleMouseDownEvent):
(WebCore::RangeInputType::handleTouchEvent):
(WebCore::RangeInputType::sliderTrackElement const):
(WebCore::RangeInputType::listAttributeTargetChanged):
(WebCore::RangeInputType::updateTickMarkValues):

• html/SearchInputType.cpp:

(WebCore::SearchInputType::createShadowSubtree):

• html/TextFieldInputType.cpp:

(WebCore::TextFieldInputType::isEmptyValue const):
(WebCore::TextFieldInputType::handleKeydownEvent):
(WebCore::TextFieldInputType::handleFocusEvent):
(WebCore::TextFieldInputType::innerTextElement const):
(WebCore::TextFieldInputType::updatePlaceholderText):
(WebCore::TextFieldInputType::didSetValueByUserEdit):
(WebCore::TextFieldInputType::shouldDrawCapsLockIndicator const):

• html/TextFieldInputType.h:
• html/canvas/CanvasRenderingContext2D.cpp:

(WebCore::size):
(WebCore::CanvasRenderingContext2D::drawImage):

• html/canvas/WebGL2RenderingContext.cpp:

(WebCore::WebGL2RenderingContext::copyBufferSubData):
(WebCore::WebGL2RenderingContext::getBufferSubData):

• html/canvas/WebGLFramebuffer.cpp:

(WebCore::WebGLFramebuffer::attach):
(WebCore::WebGLFramebuffer::getAttachmentObject const):
(WebCore::WebGLFramebuffer::removeAttachmentFromBoundFramebuffer):
(WebCore::WebGLFramebuffer::getColorBufferWidth const):
(WebCore::WebGLFramebuffer::getColorBufferHeight const):
(WebCore::WebGLFramebuffer::getColorBufferFormat const):
(WebCore::WebGLFramebuffer::checkStatus const):
(WebCore::WebGLFramebuffer::hasStencilBuffer const):
(WebCore::WebGLFramebuffer::initializeAttachments):

• html/canvas/WebGLRenderingContext.cpp:

(WebCore::WebGLRenderingContext::getFramebufferAttachmentParameter):

• html/canvas/WebGLRenderingContextBase.cpp:

(WebCore::WebGLRenderingContextBase::create):
(WebCore::WebGLRenderingContextBase::bufferData):
(WebCore::WebGLRenderingContextBase::bufferSubData):
(WebCore::WebGLRenderingContextBase::compressedTexImage2D):
(WebCore::WebGLRenderingContextBase::compressedTexSubImage2D):
(WebCore::WebGLRenderingContextBase::copyTexSubImage2D):
(WebCore::WebGLRenderingContextBase::generateMipmap):
(WebCore::WebGLRenderingContextBase::getAttachedShaders):
(WebCore::WebGLRenderingContextBase::getTexParameter):
(WebCore::WebGLRenderingContextBase::linkProgramWithoutInvalidatingAttribLocations):
(WebCore::WebGLRenderingContextBase::texImage2DBase):
(WebCore::WebGLRenderingContextBase::validateTexFunc):
(WebCore::WebGLRenderingContextBase::texSubImage2D):
(WebCore::WebGLRenderingContextBase::texSubImage2DBase):
(WebCore::WebGLRenderingContextBase::copyTexImage2D):
(WebCore::WebGLRenderingContextBase::texImage2D):
(WebCore::WebGLRenderingContextBase::texParameter):
(WebCore::WebGLRenderingContextBase::loseContextImpl):
(WebCore::WebGLRenderingContextBase::checkTextureCompleteness):
(WebCore::WebGLRenderingContextBase::validateTextureBinding):
(WebCore::WebGLRenderingContextBase::maybeRestoreContext):

• html/canvas/WebGPURenderPassColorAttachmentDescriptor.cpp:

(WebCore::WebGPURenderPassColorAttachmentDescriptor::clearColor const):
(WebCore::WebGPURenderPassColorAttachmentDescriptor::setClearColor):

• html/canvas/WebGPURenderPassDepthAttachmentDescriptor.cpp:

(WebCore::WebGPURenderPassDepthAttachmentDescriptor::clearDepth const):
(WebCore::WebGPURenderPassDepthAttachmentDescriptor::setClearDepth):

• html/parser/HTMLConstructionSite.cpp:

(WebCore::executeInsertAlreadyParsedChildTask):
(WebCore::HTMLConstructionSite::insertTextNode):

• html/parser/HTMLFormattingElementList.cpp:

(WebCore::HTMLFormattingElementList::tryToEnsureNoahsArkConditionQuickly):

• html/parser/HTMLParserOptions.cpp:

(WebCore::HTMLParserOptions::HTMLParserOptions):

• html/parser/HTMLParserScheduler.cpp:

(WebCore::HTMLParserScheduler::shouldYieldBeforeExecutingScript):

• html/parser/HTMLTreeBuilder.cpp:

(WebCore::HTMLTreeBuilder::processStartTagForInBody):
(WebCore::HTMLTreeBuilder::callTheAdoptionAgency):
(WebCore::HTMLTreeBuilder::resetInsertionModeAppropriately):

• html/parser/XSSAuditor.cpp:

(WebCore::XSSAuditor::init):

• html/shadow/MediaControlElementTypes.cpp:

(WebCore::parentMediaElement):

• html/shadow/MediaControlElementTypes.h:

(WebCore::parentMediaElement):

• html/shadow/MediaControlElements.cpp:

(WebCore::MediaControlPanelElement::startDrag):
(WebCore::MediaControlPanelElement::endDrag):
(WebCore::MediaControlVolumeSliderContainerElement::defaultEventHandler):
(WebCore::MediaControlClosedCaptionsTrackListElement::defaultEventHandler):
(WebCore::MediaControlClosedCaptionsTrackListElement::updateDisplay):
(WebCore::MediaControlClosedCaptionsTrackListElement::rebuildTrackListMenu):
(WebCore::MediaControlFullscreenButtonElement::defaultEventHandler):
(WebCore::MediaControlTextTrackContainerElement::updateDisplay):
(WebCore::MediaControlTextTrackContainerElement::updateActiveCuesFontSize):
(WebCore::MediaControlTextTrackContainerElement::updateTextStrokeStyle):
(WebCore::MediaControlTextTrackContainerElement::updateTextTrackRepresentation):
(WebCore::MediaControlTextTrackContainerElement::clearTextTrackRepresentation):
(WebCore::MediaControlTextTrackContainerElement::updateSizes):
(WebCore::MediaControlTextTrackContainerElement::createTextTrackRepresentationImage):

• html/shadow/MediaControls.cpp:

(WebCore::MediaControls::containsRelatedTarget):

• html/shadow/SliderThumbElement.cpp:

(WebCore::SliderThumbElement::isDisabledFormControl const):
(WebCore::SliderThumbElement::matchesReadWritePseudoClass const):
(WebCore::SliderThumbElement::focusDelegate):
(WebCore::SliderThumbElement::setPositionFromPoint):
(WebCore::SliderThumbElement::startDragging):
(WebCore::SliderThumbElement::stopDragging):
(WebCore::SliderThumbElement::defaultEventHandler):
(WebCore::SliderThumbElement::willRespondToMouseMoveEvents):
(WebCore::SliderThumbElement::willRespondToMouseClickEvents):
(WebCore::SliderThumbElement::willDetachRenderers):
(WebCore::findTouchWithIdentifier):
(WebCore::SliderThumbElement::handleTouchStart):
(WebCore::SliderThumbElement::handleTouchMove):
(WebCore::SliderThumbElement::handleTouchEndAndCancel):
(WebCore::SliderThumbElement::handleTouchEvent):
(WebCore::SliderThumbElement::hostInput const):

• html/shadow/SliderThumbElement.h:
• html/shadow/SpinButtonElement.cpp:

(WebCore::SpinButtonElement::defaultEventHandler):
(WebCore::SpinButtonElement::releaseCapture):

• html/shadow/TextControlInnerElements.cpp:

(WebCore::TextControlInnerTextElement::defaultEventHandler):
(WebCore::SearchFieldCancelButtonElement::willRespondToMouseClickEvents):

• html/shadow/mac/ImageControlsButtonElementMac.cpp:

(WebCore::ImageControlsButtonElementMac::defaultEventHandler):

• html/track/LoadableTextTrack.cpp:

(WebCore::LoadableTextTrack::trackElementIndex):

• html/track/TextTrack.cpp:

(WebCore::TextTrack::setMode):
(WebCore::TextTrack::hasCue):

• html/track/TextTrackCueGeneric.cpp:

(WebCore::TextTrackCueGenericBoxElement::applyCSSProperties):

• html/track/VTTCue.cpp:

(WebCore::VTTCue::copyWebVTTNodeToDOMTree):
(WebCore::VTTCue::determineTextDirection):
(WebCore::VTTCue::markFutureAndPastNodes):
(WebCore::VTTCue::removeDisplayTree):
(WebCore::VTTCue::cueContentsMatch const):

• inspector/InspectorDOMAgent.cpp:

(WebCore::InspectorDOMAgent::didAddEventListener):
(WebCore::InspectorDOMAgent::willRemoveEventListener):

• loader/FormSubmission.cpp:

(WebCore::FormSubmission::create):

• page/ContextMenuController.cpp:

(WebCore::ContextMenuController::maybeCreateContextMenu):

• rendering/RenderSnapshottedPlugIn.cpp:

(WebCore::RenderSnapshottedPlugIn::handleEvent):

• rendering/RenderTextControl.cpp:

(WebCore::RenderTextControl::innerTextElement const):
(WebCore::RenderTextControl::styleDidChange):
(WebCore::RenderTextControl::textBlockLogicalWidth const):
(WebCore::RenderTextControl::computeLogicalHeight const):
(WebCore::RenderTextControl::hitInnerTextElement):
(WebCore::RenderTextControl::canScroll const):
(WebCore::RenderTextControl::innerLineHeight const):

• rendering/RenderTextControl.h:
• rendering/RenderTextControlSingleLine.cpp:

(WebCore::RenderTextControlSingleLine::nodeAtPoint):
(WebCore::RenderTextControlSingleLine::styleDidChange):

• rendering/RenderTheme.cpp:

(WebCore::RenderTheme::isFocused const):

• rendering/RenderThemeGtk.cpp:

(WebCore::RenderThemeGtk::paintMediaSliderTrack):
(WebCore::RenderThemeGtk::paintMediaVolumeSliderTrack):

• rendering/RenderThemeMac.mm:

(WebCore::RenderThemeMac::paintSliderThumb):

• rendering/RenderVideo.cpp:

(WebCore::RenderVideo::willBeDestroyed):
(WebCore::RenderVideo::calculateIntrinsicSize):
(WebCore::RenderVideo::paintReplaced):
(WebCore::RenderVideo::updatePlayer):
(WebCore::RenderVideo::supportsAcceleratedRendering const):
(WebCore::RenderVideo::acceleratedRenderingStateChanged):
(WebCore::RenderVideo::requiresImmediateCompositing const):
(WebCore::RenderVideo::foregroundIsKnownToBeOpaqueInRect const):

• svg/SVGUseElement.cpp:

(WebCore::SVGUseElement::clearShadowTree):
(WebCore::SVGUseElement::targetClone const):

Source/WebKit:

Change the type of node as toNode() is changed to return RefPtr.

• WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMPrivate.cpp:

(WebKit::wrap):

• WebProcess/WebCoreSupport/gtk/WebEditorClientGtk.cpp:

(WebKit::WebEditorClient::handleKeyboardEvent):

• WebProcess/WebCoreSupport/wpe/WebEditorClientWPE.cpp:

(WebKit::WebEditorClient::handleKeyboardEvent):

• WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::handleEditingKeyboardEvent):

• WebProcess/WebPage/mac/WebPageMac.mm:

(WebKit::frameForEvent):

Source/WebKitLegacy/mac:

• DOM/DOM.mm:

(kit):
Change the type of node as toNode() is changed to return RefPtr.

Source/WebKitLegacy/win:

• WebView.cpp:

(WebView::handleEditingKeyboardEvent):
Change the type of node as toNode() is changed to return RefPtr.

5:46 PM Changeset in webkit [223643] by commit-queue@webkit.org

• 2 edits in trunk/Tools

update-webkit-auxiliary-libs can't download WebKitAuxiliaryLibrary.zip due to 403 Forbidden
​https://bugs.webkit.org/show_bug.cgi?id=178381

Patch by Fujii Hironori <Fujii Hironori> on 2017-10-18
Reviewed by Alexey Proskuryakov.

The web server developer.apple.com seems to reject HTTP requests
without Accept header field.

• Scripts/update-webkit-dependency: Add 'Accept' header field to requests.

4:59 PM Changeset in webkit [223642] by dino@apple.com

• 3 edits in branches/safari-604-branch

Cherry-pick r223640. rdar://problem/35063901

4:52 PM Changeset in webkit [223641] by dino@apple.com

• 4 edits
  2 adds in branches/safari-604-branch

Cherry-pick r223567. rdar://problem/35041476

4:41 PM Changeset in webkit [223640] by dino@apple.com

• 4 edits in trunk

Some older hardware can't actually use renderbuffers at the size they advertise
​https://bugs.webkit.org/show_bug.cgi?id=178417
<rdar://problem/35042291>

Reviewed by Tim Horton.

Source/WebCore:

The change in r223567 caused some older hardware to fail, because even though
they claimed to support a maximum renderbuffer and viewport of 16K, they were
unable to actually handle one. Rather than trying to identify such hardware,
clamp all buffers to a maximum of 8192. This is bigger than the previous value
of 4096, and large enough to have a full-screen buffer on a Retina 5K iMac.

• platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:

(WebCore::GraphicsContext3D::getIntegerv):

LayoutTests:

Unskip webgl/1.0.2/conformance/canvas/drawingbuffer-static-canvas-test.html.

• TestExpectations:

4:14 PM Changeset in webkit [223639] by dbates@webkit.org

• 3 edits
  2 adds in trunk/LayoutTests

Add test to ensure that text-overflow: ellipsis text is scrollable
​https://bugs.webkit.org/show_bug.cgi?id=178395

Reviewed by Zalan Bujtas.

• fast/text/scroll-text-overflow-ellipsis-expected.html: Added.
• fast/text/scroll-text-overflow-ellipsis.html: Added.
• platform/ios-wk1/TestExpectations: For now, skip the test in legacy WebKit on iOS

as eventSender.keyDown() does not seem to be dispatching a keyboard event to the
focused field. See <​https://bugs.webkit.org/show_bug.cgi?id=178490>.

• resources/ui-helper.js:

(window.UIHelper.keyDown.return.new.Promise):
(window.UIHelper.keyDown):

4:09 PM Changeset in webkit [223638] by jmarcell@apple.com

• 16 edits
  2 deletes in tags/Safari-605.1.11.1

Cherry-pick r223618. rdar://problem/35056300

4:09 PM Changeset in webkit [223637] by jmarcell@apple.com

• 27 edits in tags/Safari-605.1.11.1/Source/WTF/wtf

Cherry-pick r223617. rdar://problem/35047351

4:08 PM Changeset in webkit [223636] by jmarcell@apple.com

• 7 edits in tags/Safari-605.1.11.1/Source

Versioning.

4:04 PM Changeset in webkit [223635] by jmarcell@apple.com

• 1 copy in tags/Safari-605.1.11.1

New tag.

3:31 PM Changeset in webkit [223634] by Chris Dumez

• 20 edits
  10 copies
  1 move in trunk/Source

[Service Worker] Add stubs for Client / WindowClient / Clients
​https://bugs.webkit.org/show_bug.cgi?id=178469

Reviewed by Youenn Fablet.

Source/WebCore:

Add stubs for Client / WindowClient / Clients:

• ​https://w3c.github.io/ServiceWorker/v1/#clients
• ​https://w3c.github.io/ServiceWorker/v1/#client-interface

• CMakeLists.txt:
• DerivedSources.make:
• WebCore.xcodeproj/project.pbxproj:
• bindings/js/WebCoreBuiltinNames.h:
• dom/Document.cpp:

(WebCore::Document::visibilityState const):

• dom/Document.h:
• dom/Document.idl:
• dom/VisibilityState.h: Renamed from Source/WebCore/page/PageVisibilityState.h.
• dom/VisibilityState.idl: Copied from Source/WebCore/workers/service/ServiceWorkerGlobalScope.idl.
• page/Page.cpp:

(WebCore::Page::visibilityState const):

• page/Page.h:
• workers/service/ServiceWorkerClient.cpp: Copied from Source/WebCore/workers/service/ServiceWorkerGlobalScope.idl.

(WebCore::ServiceWorkerClient::ServiceWorkerClient):
(WebCore::ServiceWorkerClient::activeDOMObjectName const):
(WebCore::ServiceWorkerClient::canSuspendForDocumentSuspension const):
(WebCore::ServiceWorkerClient::url const):
(WebCore::ServiceWorkerClient::frameType const):
(WebCore::ServiceWorkerClient::id const):
(WebCore::ServiceWorkerClient::postMessage):

• workers/service/ServiceWorkerClient.h: Copied from Source/WebCore/workers/service/ServiceWorkerGlobalScope.idl.
• workers/service/ServiceWorkerClient.idl: Copied from Source/WebCore/workers/service/ServiceWorkerGlobalScope.idl.
• workers/service/ServiceWorkerClients.cpp: Copied from Source/WebCore/workers/service/ServiceWorkerGlobalScope.cpp.

(WebCore::ServiceWorkerClients::ServiceWorkerClients):
(WebCore::ServiceWorkerClients::activeDOMObjectName const):
(WebCore::ServiceWorkerClients::canSuspendForDocumentSuspension const):
(WebCore::ServiceWorkerClients::get):
(WebCore::ServiceWorkerClients::matchAll):
(WebCore::ServiceWorkerClients::openWindow):
(WebCore::ServiceWorkerClients::claim):

• workers/service/ServiceWorkerClients.h: Copied from Source/WebCore/workers/service/ServiceWorkerGlobalScope.h.

(WebCore::ServiceWorkerClients::create):

• workers/service/ServiceWorkerClients.idl: Copied from Source/WebCore/workers/service/ServiceWorkerGlobalScope.idl.
• workers/service/ServiceWorkerGlobalScope.cpp:

(WebCore::ServiceWorkerGlobalScope::ServiceWorkerGlobalScope):

• workers/service/ServiceWorkerGlobalScope.h:

(WebCore::ServiceWorkerGlobalScope::clients):

• workers/service/ServiceWorkerGlobalScope.idl:
• workers/service/ServiceWorkerWindowClient.cpp: Copied from Source/WebCore/workers/service/ServiceWorkerGlobalScope.idl.

(WebCore::ServiceWorkerWindowClient::ServiceWorkerWindowClient):
(WebCore::ServiceWorkerWindowClient::visibilityState const):
(WebCore::ServiceWorkerWindowClient::isFocused const):
(WebCore::ServiceWorkerWindowClient::focus):
(WebCore::ServiceWorkerWindowClient::navigate):

• workers/service/ServiceWorkerWindowClient.h: Copied from Source/WebCore/workers/service/ServiceWorkerGlobalScope.idl.
• workers/service/ServiceWorkerWindowClient.idl: Copied from Source/WebCore/workers/service/ServiceWorkerGlobalScope.idl.

Source/WebKit:

Rename PageVisibilityState to VisibilityState.

• Shared/API/c/WKSharedAPICast.h:

(WebKit::toVisibilityState):

• WebProcess/WebPage/WebPage.h:

Source/WebKitLegacy/mac:

Rename PageVisiblityState to VisibilityState.

• WebView/WebView.mm:

(kit):

3:27 PM Changeset in webkit [223633] by Alan Bujtas

• 2 edits in trunk/Source/WebCore

[FrameView::layout cleanup] Use SetForScope to protect m_needsFullRepaint's value on reentrancy
​https://bugs.webkit.org/show_bug.cgi?id=178479
<rdar://problem/35056950>

Reviewed by Simon Fraser.

No change in functionality.

• page/FrameView.cpp:

(WebCore::FrameView::layout):

3:01 PM Changeset in webkit [223632] by dino@apple.com

• 4 edits
  1 add in trunk/LayoutTests

Make failing WebGL tests produce debug output
​https://bugs.webkit.org/show_bug.cgi?id=178421

Reviewed by Jon Lee.

If a WebGL conformance test fails, we just get the word "FAIL". Instead,
have it log the actual output of the test, so we can see what happens
on bots.

Drive-by fix where I noticed a test file was missing, that causes
two tests to timeout. They may still timeout, but now because they
take a long time to run rather than they have a JS error.

• platform/mac/TestExpectations:
• webgl/1.0.2/resources/webgl_test_files/conformance/resources/iterable-test.js: Added.
• webgl/1.0.2/resources/webkit-webgl-test-harness.js:

(window.webglTestHarness.notifyFinished):

• webgl/resources/webkit-webgl-test-harness.js:

(window.webglTestHarness.notifyFinished):

2:54 PM Changeset in webkit [223631] by Alan Bujtas

• 3 edits in trunk/Source/WebCore

[FrameView::layout cleanup] Remove InPreLayoutStyleUpdate.
​https://bugs.webkit.org/show_bug.cgi?id=178483
<rdar://problem/35058800>

Reviewed by Simon Fraser.

Its client, updateCompositingLayersAfterStyleChange only needs to know if there's a upcoming
layer update (part of FrameView::layout()).

No change in functionality.

• page/FrameView.cpp:

(WebCore::FrameView::updateCompositingLayersAfterStyleChange):
(WebCore::FrameView::layout):

• page/FrameView.h:

2:52 PM Changeset in webkit [223630] by aakash_jain@apple.com

• 2 edits in trunk/Tools

webkitpy tests should have --json-output option
​https://bugs.webkit.org/show_bug.cgi?id=178481

Reviewed by Alexey Proskuryakov.

• Scripts/webkitpy/test/main.py:

(Tester._parse_args): Added json-output argument.
(Tester._run_tests): Write output to json file.

2:37 PM Changeset in webkit [223629] by Chris Dumez

• 2 edits in trunk/Source/WebCore

Global constructors exposed to service workers should go on ServiceWorkerGlobalScope interface
​https://bugs.webkit.org/show_bug.cgi?id=178482

Reviewed by Sam Weinig.

Global constructors exposed to service workers should go on ServiceWorkerGlobalScope interface,
not the ServiceWorker interface.

• bindings/scripts/preprocess-idls.pl:

2:34 PM Changeset in webkit [223628] by rniwa@webkit.org

• 92 edits in trunk/Source/WebCore

Add an argument indicating the type of insertion to Node::insertedInto
​https://bugs.webkit.org/show_bug.cgi?id=178431

Reviewed by Antti Koivisto.

Added InsertionType as the first argument to Node::insertedInto, which contains two booleans indicating
whether the node just become newly connected to a document, and whether node's tree scope had changed or not.

These boolean flags simplifie the logic in insertedInto implementations, and are required to have a better
guarantee about the correctness of node flags during calls to insertedInto. Right now, isConnected() and
isInShadowTree() are both outdated until Node::insertedInto is called.

Also renamed the second argument from insertionPoint to parentOfInsertedTree to make the semantics clear,
and renamed finishedInsertingSubtree to didFinishInsertingNode, and renamed InsertionNotificationRequest
to InsertedIntoResult using enum class.

Note that in some implementations of insertedInto, we check whether isConnected() was false to decide whether
the node is newly connected to a document. This extra check is no longer necessary since no node will be inserted
into a document without first being completely removed after r223458.

No new tests since there should be no behavioral changes.

• dom/ContainerNode.cpp:

(WebCore::ContainerNode::notifyChildInserted):

• dom/ContainerNodeAlgorithms.cpp:

(WebCore::notifyNodeInsertedIntoDocument): Replaced the check that the node had not been disconnected by scripts
by a release assert now that we believe we've eliminated all causes of these unwanted DOM mutations in r223458.
(WebCore::notifyNodeInsertedIntoTree): Removed NoEventDispatchAssertion since notifyChildNodeInserted has it
already since r223458.
(WebCore::notifyChildNodeInserted): Made this function return NodeVector (copy elision).

• dom/ContainerNodeAlgorithms.h:
• dom/Element.cpp:

(WebCore::Element::insertedInto): Use insertionType.connectedToDocument to detect when this element had become
connected to some document. Similarly, use insertionType.treeScopeChanged to detect when this element had been
inserted into a new tree scope. Removed the comment which became obsolete due to this cleanup.
(WebCore::Element::addShadowRoot): Simplified the code here since we never attach a ShadowRoot with children.

• dom/Element.h:
• dom/Node.cpp:

(WebCore::Node::insertedInto):

• dom/Node.h:

(WebCore::Node::InsertedIntoResult): Renamed from InsertionNotificationRequest, and turned into an enum class.
(WebCore::Node::InsertionType): Added. We pass this object by value to insertedInto as a performance optimization
as passing two booleans by value is faster than passing a pointer and then de-referencing it in a virtual callee.
(WebCore::Node::didFinishInsertingNode): Renamed from finishedInsertingSubtree.

• dom/ProcessingInstruction.cpp:

(WebCore::ProcessingInstruction::insertedInto):
(WebCore::ProcessingInstruction::didFinishInsertingNode): Renamed from finishedInsertingSubtree.

• dom/ProcessingInstruction.h:
• dom/ScriptElement.cpp:

(WebCore::ScriptElement::shouldCallFinishedInsertingSubtree): Deleted.
(WebCore::ScriptElement::didFinishInsertingNode): Renamed from finishedInsertingSubtree.

• dom/ScriptElement.h:

(WebCore::ScriptElement::insertedInto const): Added. Extracted from shouldCallFinishedInsertingSubtree.

• dom/ShadowRoot.cpp:

(WebCore::ShadowRoot::insertedInto): The extra isConnected() check is no longer needed. See the description above.

• dom/ShadowRoot.h:
• html/FormAssociatedElement.cpp:

(WebCore::FormAssociatedElement::insertedInto):

• html/FormAssociatedElement.h:
• html/HTMLBaseElement.cpp:

(WebCore::HTMLBaseElement::insertedInto):

• html/HTMLBaseElement.h:
• html/HTMLBodyElement.cpp:

(WebCore::HTMLBodyElement::insertedInto):
(WebCore::HTMLBodyElement::didFinishInsertingNode): Renamed from finishedInsertingSubtree.

• html/HTMLBodyElement.h:
• html/HTMLFormControlElement.cpp:

(WebCore::HTMLFormControlElement::insertedInto):
(WebCore::HTMLFormControlElement::didFinishInsertingNode): Renamed from finishedInsertingSubtree.

• html/HTMLFormControlElement.h:
• html/HTMLFormControlElementWithState.cpp:

(WebCore::HTMLFormControlElementWithState::insertedInto):

• html/HTMLFormControlElementWithState.h:
• html/HTMLFormElement.cpp:

(WebCore::HTMLFormElement::insertedInto):

• html/HTMLFormElement.h:
• html/HTMLFrameElementBase.cpp:

(WebCore::HTMLFrameElementBase::insertedInto):
(WebCore::HTMLFrameElementBase::didFinishInsertingNode): Renamed from finishedInsertingSubtree.

• html/HTMLFrameElementBase.h:
• html/HTMLFrameSetElement.cpp:

(WebCore::HTMLFrameSetElement::insertedInto):

• html/HTMLFrameSetElement.h:
• html/HTMLImageElement.cpp:

(WebCore::HTMLImageElement::insertedInto):

• html/HTMLImageElement.h:
• html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::insertedInto):
(WebCore::HTMLInputElement::didFinishInsertingNode): Renamed from finishedInsertingSubtree.

• html/HTMLInputElement.h:
• html/HTMLLinkElement.cpp:

(WebCore::HTMLLinkElement::insertedInto): The extra isConnected() check is no longer needed. See above.
(WebCore::HTMLLinkElement::didFinishInsertingNode): Renamed from finishedInsertingSubtree.

• html/HTMLLinkElement.h:
• html/HTMLMapElement.cpp:

(WebCore::HTMLMapElement::insertedInto):

• html/HTMLMapElement.h:
• html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::insertedInto):
(WebCore::HTMLMediaElement::didFinishInsertingNode): Renamed from finishedInsertingSubtree.

• html/HTMLMediaElement.h:
• html/HTMLMetaElement.cpp:

(WebCore::HTMLMetaElement::insertedInto):

• html/HTMLMetaElement.h:
• html/HTMLObjectElement.cpp:

(WebCore::HTMLObjectElement::insertedInto):
(WebCore::HTMLObjectElement::didFinishInsertingNode): Renamed from finishedInsertingSubtree.

• html/HTMLObjectElement.h:
• html/HTMLOptionElement.cpp:

(WebCore::HTMLOptionElement::insertedInto):

• html/HTMLOptionElement.h:
• html/HTMLScriptElement.cpp:

(WebCore::HTMLScriptElement::insertedInto):
(WebCore::HTMLScriptElement::didFinishInsertingNode): Renamed from finishedInsertingSubtree.

• html/HTMLScriptElement.h:
• html/HTMLSelectElement.cpp:

(WebCore::HTMLSelectElement::insertedInto):

• html/HTMLSelectElement.h:
• html/HTMLSlotElement.cpp:

(WebCore::HTMLSlotElement::insertedInto): Replaced a cumbersome condition by a boolean check on insertionType's
treeScopeChanged and removed the accompanying comment which is no longer needed.

• html/HTMLSlotElement.h:
• html/HTMLSourceElement.cpp:

(WebCore::HTMLSourceElement::insertedInto):

• html/HTMLSourceElement.h:
• html/HTMLStyleElement.cpp:

(WebCore::HTMLStyleElement::insertedInto): The extra isConnected() check is no longer needed. See above.

• html/HTMLStyleElement.h:
• html/HTMLTextFormControlElement.cpp:

(WebCore::HTMLTextFormControlElement::insertedInto):

• html/HTMLTextFormControlElement.h:
• html/HTMLTitleElement.cpp:

(WebCore::HTMLTitleElement::insertedInto):

• html/HTMLTitleElement.h:
• html/HTMLTrackElement.cpp:

(WebCore::HTMLTrackElement::insertedInto): Added a FIXME since this code is clearly wrong.

• html/HTMLTrackElement.h:
• svg/SVGElement.cpp:

(WebCore::SVGElement::insertedInto):

• svg/SVGElement.h:
• svg/SVGFEImageElement.cpp:

(WebCore::SVGFEImageElement::insertedInto):
(WebCore::SVGFEImageElement::didFinishInsertingNode): Renamed from finishedInsertingSubtree.

• svg/SVGFEImageElement.h:
• svg/SVGFontFaceElement.cpp:

(WebCore::SVGFontFaceElement::insertedInto):

• svg/SVGFontFaceElement.h:
• svg/SVGFontFaceUriElement.cpp:

(WebCore::SVGFontFaceUriElement::insertedInto):

• svg/SVGFontFaceUriElement.h:
• svg/SVGImageElement.cpp:

(WebCore::SVGImageElement::insertedInto):

• svg/SVGImageElement.h:
• svg/SVGMPathElement.cpp:

(WebCore::SVGMPathElement::insertedInto):
(WebCore::SVGMPathElement::didFinishInsertingNode): Renamed from finishedInsertingSubtree.

• svg/SVGMPathElement.h:
• svg/SVGPathElement.cpp:

(WebCore::SVGPathElement::insertedInto):

• svg/SVGPathElement.h:
• svg/SVGSVGElement.cpp:

(WebCore::SVGSVGElement::insertedInto):

• svg/SVGSVGElement.h:
• svg/SVGScriptElement.cpp:

(WebCore::SVGScriptElement::insertedInto):
(WebCore::SVGScriptElement::didFinishInsertingNode): Renamed from finishedInsertingSubtree.

• svg/SVGScriptElement.h:
• svg/SVGStyleElement.cpp:

(WebCore::SVGStyleElement::insertedInto): The extra isConnected() check is no longer needed. See above description.

• svg/SVGStyleElement.h:
• svg/SVGTRefElement.cpp:

(WebCore::SVGTRefElement::insertedInto):
(WebCore::SVGTRefElement::didFinishInsertingNode): Renamed from finishedInsertingSubtree.

• svg/SVGTRefElement.h:
• svg/SVGTextPathElement.cpp:

(WebCore::SVGTextPathElement::insertedInto):
(WebCore::SVGTextPathElement::didFinishInsertingNode): Renamed from finishedInsertingSubtree.

• svg/SVGTextPathElement.h:
• svg/SVGTitleElement.cpp:

(WebCore::SVGTitleElement::insertedInto):

• svg/SVGTitleElement.h:
• svg/SVGUseElement.cpp:

(WebCore::SVGUseElement::insertedInto):

• svg/SVGUseElement.h:
• svg/animation/SVGSMILElement.cpp:

(WebCore::SVGSMILElement::insertedInto):
(WebCore::SVGSMILElement::didFinishInsertingNode): Renamed from finishedInsertingSubtree.

• svg/animation/SVGSMILElement.h:

1:29 PM Changeset in webkit [223627] by mitz@apple.com

• 9 copies
  1 add in releases/Apple/Safari Technology Preview 42

Added a tag for Safari Technology Preview release 42.

1:26 PM Changeset in webkit [223626] by eric.carlson@apple.com

• 5 edits in trunk

Key events should not update Document.lastHandledUserGestureTimestamp unless key event is handled
​https://bugs.webkit.org/show_bug.cgi?id=178473
<rdar://problem/34869935>

Reviewed by Brent Fulgham.

Source/WebCore:

No new tests, updated media/restricted-audio-playback-with-document-gesture.html for this change.

• page/EventHandler.cpp:

(WebCore::EventHandler::keyEvent): Restore the current Document's "lastHandledUserGestureTimestamp"
if the key event was not handled.

LayoutTests:

• media/restricted-audio-playback-with-document-gesture.html: Pass true to runWithKeyDown so

it consumes the keydown event.

• media/video-test.js:

(runWithKeyDown): Take optional parameter which causes event handler to call preventDefault.

1:20 PM Changeset in webkit [223625] by Wenson Hsieh

• 7 edits
  1 add in trunk

Unreviewed, rolling out r223291.

Source/WebCore:

After further investigation, this removed codepath is
something Mail may want to re-adopt. Additionally, the
original breaking change was rolled out in r223408, so
this test once again passes on ToT.

Reverted changeset:

"Remove Editor::simplifyMarkup"
​https://bugs.webkit.org/show_bug.cgi?id=178271
​https://trac.webkit.org/changeset/223291

Source/WebKitLegacy/mac:

See WebCore ChangeLog for more detail.

Reverted changeset:

"Remove Editor::simplifyMarkup"
​https://bugs.webkit.org/show_bug.cgi?id=178271
​https://trac.webkit.org/changeset/223291

Tools:

See WebCore ChangeLog for more detail.

Reverted changeset:

"Remove Editor::simplifyMarkup"
​https://bugs.webkit.org/show_bug.cgi?id=178271
​https://trac.webkit.org/changeset/223291

1:18 PM Changeset in webkit [223624] by commit-queue@webkit.org

• 5 edits in trunk/Source/WebCore

[Settings] Move remaining simple settings to Settings.in
​https://bugs.webkit.org/show_bug.cgi?id=177730
<rdar://problem/34763346>

Patch by Sam Weinig <​sam@webkit.org> on 2017-10-18
Reviewed by Daniel Bates.

• Scripts/GenerateSettings/Settings.py:

(Setting.init):
(Setting.str):
(Setting.getterFunctionName):
(parseInput):

Add support for parsing the 'getter' option.

• page/Settings.in:

Migrate simple settings from SettingsBase to here.

• page/SettingsBase.cpp:

(WebCore::SettingsBase::SettingsBase):
(WebCore::SettingsBase::setJavaEnabled): Deleted.
(WebCore::SettingsBase::setJavaEnabledForLocalFiles): Deleted.
(WebCore::SettingsBase::setPreferMIMETypeForImages): Deleted.
(WebCore::SettingsBase::setForcePendingWebGLPolicy): Deleted.
(WebCore::SettingsBase::setNeedsAdobeFrameReloadingQuirk): Deleted.
(WebCore::SettingsBase::setFontRenderingMode): Deleted.
(WebCore::SettingsBase::fontRenderingMode const): Deleted.
(WebCore::SettingsBase::setShowTiledScrollingIndicator): Deleted.
(WebCore::SettingsBase::setFontFallbackPrefersPictographs): Deleted.

• page/SettingsBase.h:

(WebCore::SettingsBase::isJavaEnabled const): Deleted.
(WebCore::SettingsBase::isJavaEnabledForLocalFiles const): Deleted.
(WebCore::SettingsBase::preferMIMETypeForImages const): Deleted.
(WebCore::SettingsBase::needsAcrobatFrameReloadingQuirk const): Deleted.
(WebCore::SettingsBase::showTiledScrollingIndicator const): Deleted.
(WebCore::SettingsBase::setTouchEventEmulationEnabled): Deleted.
(WebCore::SettingsBase::isTouchEventEmulationEnabled const): Deleted.
(WebCore::SettingsBase::setTimeWithoutMouseMovementBeforeHidingControls): Deleted.
(WebCore::SettingsBase::timeWithoutMouseMovementBeforeHidingControls const): Deleted.
(WebCore::SettingsBase::fontFallbackPrefersPictographs const): Deleted.
(WebCore::SettingsBase::setMediaKeysStorageDirectory): Deleted.
(WebCore::SettingsBase::mediaKeysStorageDirectory const): Deleted.
(WebCore::SettingsBase::setMediaDeviceIdentifierStorageDirectory): Deleted.
(WebCore::SettingsBase::mediaDeviceIdentifierStorageDirectory const): Deleted.
(WebCore::SettingsBase::applePayEnabled const): Deleted.
(WebCore::SettingsBase::setApplePayEnabled): Deleted.
(WebCore::SettingsBase::applePayCapabilityDisclosureAllowed const): Deleted.
(WebCore::SettingsBase::setApplePayCapabilityDisclosureAllowed): Deleted.
(WebCore::SettingsBase::isForcePendingWebGLPolicy const): Deleted.

Remove simple settings.

12:30 PM Changeset in webkit [223623] by mmaxfield@apple.com

• 2 edits in trunk/LayoutTests

editing/deleting/delete-emoji-9.html is failing consistently.
​https://bugs.webkit.org/show_bug.cgi?id=178478

Unreviewed.

• platform/mac/editing/deleting/delete-emoji-9-expected.txt:

12:19 PM Changeset in webkit [223622] by Alan Bujtas

• 3 edits in trunk/Source/WebCore

[FrameView::layout cleanup] Move root/body marking dirty logic to a separate function
​https://bugs.webkit.org/show_bug.cgi?id=178477
<rdar://problem/35056478>

Reviewed by Simon Fraser.

No change in functionality.

• page/FrameView.cpp:

(WebCore::FrameView::markRootOrBodyRendererDirty const):
(WebCore::FrameView::layout):

• page/FrameView.h:

12:14 PM Changeset in webkit [223621] by keith_miller@apple.com

• 18 edits
  5 adds
  1 delete in trunk

Setup WebCore build to start using unified sources.
​https://bugs.webkit.org/show_bug.cgi?id=178362

Reviewed by Tim Horton.

.:

Pass features to the unified source bundler script.

• Source/cmake/WebKitCommon.cmake:
• Source/cmake/WebKitFeatures.cmake:
• Source/cmake/WebKitMacros.cmake:

Source/JavaScriptCore:

Change comments in source list files. Also, pass explicit names for build files.

• CMakeLists.txt:
• PlatformGTK.cmake:
• PlatformMac.cmake:
• Sources.txt:
• SourcesGTK.txt:
• SourcesMac.txt:

Source/WebCore:

This patch adds all the long tooling needed to start adding
unified sources to WebCore. Most of the source list files
are empty to start but will be filled over the next few days.

I started by moving all the non-derived bindings code to
unified sources to make sure everything worked correctly.

• CMakeLists.txt:
• Configurations/GenerateUnifiedSources.xcconfig: Added.
• Configurations/WebCore.xcconfig:
• PlatformMac.cmake:
• Sources.txt: Added.
• SourcesCocoa.txt: Added.
• SourcesIOS.txt: Added.
• SourcesMac.txt: Added.
• WebCore.xcodeproj/project.pbxproj:
• bindings/js/JSMediaStreamCapabilitiesCustom.cpp: Removed. No one seems to use this...

Source/WTF:

There are a number of changes to the bundler script. First, it is
now possible to enable or disable building files based on if the
associated feature flag is enabled or not. The syntax for this is
similar to how we do #ifs in C++ code. e.g.

#if ENABLE_APPLE_PAY

myApplePayFile.cpp

#endif

would enable myApplePayFile.cpp if and only if the APPLE_PAY
feature define is set.

I also changed comments from # to to make it less likely they
would be confused with a #if.

Finally, this patch enables bundling files in the same relative
directory across source list files. Previously, if
SourcesCocoa.txt had platform/cf/foo.cpp and SourcesMac.txt had
platform/cf/bar.cpp those files would not be put in the same
unified source bundle. Now, those files will be put into the same
bundle but bar.cpp will always follow foo.cpp. The idea is that by
putting more specific files after more general files we can avoid
random build failures.

• Scripts/generate-unified-source-bundles.rb:

11:42 AM Changeset in webkit [223620] by jmarcell@apple.com

• 7 edits in branches/safari-604.3.5.1-branch/Source

Versioning.

11:39 AM Changeset in webkit [223619] by commit-queue@webkit.org

• 1 edit
  1 add in trunk/Source/WebInspectorUI

[GTK] Web Inspector: Add Layers.svg
​https://bugs.webkit.org/show_bug.cgi?id=178430

Patch by Fujii Hironori <Fujii Hironori> on 2017-10-18
Reviewed by Michael Catanzaro.

• UserInterface/Images/gtk/Layers.svg: Added.

11:28 AM Changeset in webkit [223618] by commit-queue@webkit.org

• 16 edits
  2 deletes in trunk

Unreviewed, rolling out r223321.
​https://bugs.webkit.org/show_bug.cgi?id=178476

This protocol change broke some internal builds (Requested by
brrian on #webkit).

Reverted changeset:

"Web Inspector: provide a way to enable/disable event
listeners"
​https://bugs.webkit.org/show_bug.cgi?id=177451
​https://trac.webkit.org/changeset/223321

11:23 AM Changeset in webkit [223617] by aestes@apple.com

• 27 edits in trunk/Source/WTF/wtf

Roll out r223316.

11:21 AM Changeset in webkit [223616] by wilander@apple.com

• 2 edits in trunk/Source/WebKit

Check notifyPagesWhenTelemetryWasCaptured before notifying pages if there is no WebPageProxy
​https://bugs.webkit.org/show_bug.cgi?id=178470
<rdar://problem/34417518>

Reviewed by Brian Burg.

• UIProcess/WebResourceLoadStatisticsTelemetry.cpp:

(WebKit::WebResourceLoadStatisticsTelemetry::calculateAndSubmit):

Add a missing check of notifyPagesWhenTelemetryWasCaptured.
The page notification is only for testing purposes.

10:56 AM Changeset in webkit [223615] by jmarcell@apple.com

• 1 copy in tags/Safari-604.3.5.1.1

Tag Safari-604.3.5.1.1.

10:41 AM Changeset in webkit [223614] by mark.lam@apple.com

• 11 edits
  1 add in trunk

The compiler should always register a structure when it adds its transitionWatchPointSet.
​https://bugs.webkit.org/show_bug.cgi?id=178420
<rdar://problem/34814024>

Reviewed by Saam Barati and Filip Pizlo.

JSTests:

• stress/regress-178420.js: Added.

(new.Array.10000.map):

Source/JavaScriptCore:

Instead of invoking addLazily() to add a structure's transitionWatchpointSet, we
now invoke Graph::registerAndWatchStructureTransition() on the structure.
registerAndWatchStructureTransition() both registers the structure and add its
transitionWatchpointSet to the plan desired watchpoints.

Graph::registerAndWatchStructureTransition() is based on Graph::registerStructure()
except registerAndWatchStructureTransition() adds the structure's
transitionWatchpointSet unconditionally.

• dfg/DFGArgumentsEliminationPhase.cpp:
• dfg/DFGArrayMode.cpp:

(JSC::DFG::ArrayMode::refine const):

• dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::handleIntrinsicCall):

• dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode):

• dfg/DFGGraph.cpp:

(JSC::DFG::Graph::registerAndWatchStructureTransition):

• dfg/DFGGraph.h:

• dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileGetByValOnString):

• The second set of addLazily()s is redundant. This set is executed only when prototypeChainIsSane is true, and prototypeChainIsSane can only be true if and only if we've executed the if statement above it. That preceding if statement already registerAndWatchStructureTransition() the same 2 structures. Hence, this second set can be deleted.

• dfg/DFGWatchpointCollectionPhase.cpp:

(JSC::DFG::WatchpointCollectionPhase::addLazily):

• Deleted an unused function.

• ftl/FTLLowerDFGToB3.cpp:

(JSC::FTL::DFG::LowerDFGToB3::compileStringCharAt):

10:16 AM Changeset in webkit [223613] by achristensen@apple.com

• 4 edits in trunk/LayoutTests

http/tests/loading/basic-auth-resend-wrong-credentials.html is still a flaky failure after proposed fix.
​https://bugs.webkit.org/show_bug.cgi?id=178467

Reviewed by Andy Estes.

• http/tests/loading/basic-auth-resend-wrong-credentials-expected.txt:
• http/tests/loading/basic-auth-resend-wrong-credentials.html:
• platform/wk2/http/tests/loading/basic-auth-resend-wrong-credentials-expected.txt:

Use setTimeout to make the loading order deterministic.
The important part of this test is that the passwords shown in the delegate callbacks are correct,
and this doesn't change that.

10:10 AM Changeset in webkit [223612] by commit-queue@webkit.org

• 13 edits
  1 delete in trunk/Source/WebCore

[Settings] Miscellaneous cleanup of the settings generation scripts
​https://bugs.webkit.org/show_bug.cgi?id=178462

Patch by Sam Weinig <​sam@webkit.org> on 2017-10-18
Reviewed by Daniel Bates.

• Stop generating and remove now unused SettingsMacros.h
• Make functions operating on the python Setting object member functions
• Add predicate to determine if a Setting's type is a value type, allowing us to exclude those from using const references.

• CMakeLists.txt:
• DerivedSources.make:
• Scripts/GenerateSettings.py:
• Scripts/GenerateSettings/GenerateInternalSettingsHeaderFile.py:
• Scripts/GenerateSettings/GenerateInternalSettingsIDLFile.py:
• Scripts/GenerateSettings/GenerateInternalSettingsImplementationFile.py:
• Scripts/GenerateSettings/GenerateSettings.py:
• Scripts/GenerateSettings/GenerateSettingsHeaderFile.py:
• Scripts/GenerateSettings/GenerateSettingsImplementationFile.py:
• Scripts/GenerateSettings/GenerateSettingsMacrosHeader.py: Removed.
• Scripts/GenerateSettings/Settings.py:
• WebCoreMacros.cmake:
• WebCore.xcodeproj/project.pbxproj:

9:59 AM Changeset in webkit [223611] by Chris Dumez

• 8 edits in trunk

Align ImageData constructor with the specification
​https://bugs.webkit.org/show_bug.cgi?id=178406

Reviewed by Youenn Fablet.

LayoutTests/imported/w3c:

Rebaseline test now that one more check is passing.

• web-platform-tests/html/semantics/embedded-content/the-canvas-element/imagedata-expected.txt:

Source/WebCore:

Align ImageData constructor with the specification:

• ​https://html.spec.whatwg.org/multipage/canvas.html#dom-imagedata

It sometimes throws the wrong exception.

No new tests, rebaselined existing test.

• html/ImageData.cpp:

(WebCore::ImageData::create):

• html/ImageData.h:
• html/ImageData.idl:

9:54 AM Changeset in webkit [223610] by Chris Dumez

• 2 edits in trunk/Source/WebKit

Unreviewed, fix build error after r223608 with some SDKs.

• StorageProcess/StorageProcess.cpp:

(WebKit::StorageProcess::ensureSWOriginStoreForSession):

9:20 AM Changeset in webkit [223609] by Ms2ger@igalia.com

• 2 edits in trunk/LayoutTests

[GTK] Test gardening.
​https://bugs.webkit.org/show_bug.cgi?id=178461

Unreviewed test gardening.

• platform/gtk/TestExpectations:

9:12 AM Changeset in webkit [223608] by Chris Dumez

• 38 edits
  4 copies in trunk

Add an efficient data structure for WebCore to query if there is a Service Worker registered for a given origin
​https://bugs.webkit.org/show_bug.cgi?id=177876
<rdar://problem/34813129>

Reviewed by Ryosuke Niwa.

Source/WebCore:

No new tests, updatdd existing test.

• dom/Document.h:
• testing/Internals.cpp:

(WebCore::Internals::hasServiceWorkerRegisteredForOrigin):

• testing/Internals.h:
• testing/Internals.idl:
• workers/service/ServiceWorkerProvider.h:
• workers/service/context/SWContextManager.cpp:

(WebCore::SWContextManager::startServiceWorkerContext):

• workers/service/server/SWClientConnection.h:
• workers/service/server/SWServer.cpp:

(WebCore::SWServer::Connection::scriptContextStarted):
(WebCore::SWServer::scriptContextStarted):

• workers/service/server/SWServer.h:
• workers/service/server/SWServerRegistration.cpp:

(WebCore::SWServerRegistration::scriptContextFailedToStart):
(WebCore::SWServerRegistration::scriptContextStarted):

• workers/service/server/SWServerRegistration.h:

Source/WebKit:

Introduce a Service Worker origin store which gets populated / updated on the StorageProcess side
and queried on the WebContent process side via the WebSWOriginTable so that the WebProcess can
efficiently check if there is a ServiceWorker registered for a given origin without actually doing
an IPC to the StorageProcess.

For efficiency, the hash table is backed by SharedMemory so we only pass shared memory handles
between the StorageProcess and the WebProcesses.

We currently add entries to the WebSWOriginStore whenever a service worker registration succeeds
on the StorageProcess side. We also clear this store whenever the API to clear service worker
registrations is called. Code to query the WebSWOriginTable from the WebContent process side is
there but currently only used by Internals for testing. We will later leverage this code when
integrating with Fetch API.

• CMakeLists.txt:
• Shared/SharedStringHashStore.h:

(WebKit::SharedStringHashStore::Client::didUpdateSharedStringHashes):

• Shared/SharedStringHashTable.cpp:

(WebKit::SharedStringHashTable::clear):

• StorageProcess/ServiceWorker/WebSWOriginStore.cpp: Copied from Source/WebKit/WebProcess/Storage/WebServiceWorkerProvider.cpp.

(WebKit::WebSWOriginStore::WebSWOriginStore):
(WebKit::WebSWOriginStore::add):
(WebKit::WebSWOriginStore::remove):
(WebKit::WebSWOriginStore::clear):
(WebKit::WebSWOriginStore::registerSWServerConnection):
(WebKit::WebSWOriginStore::unregisterSWServerConnection):
(WebKit::WebSWOriginStore::sendStoreHandle):
(WebKit::WebSWOriginStore::didInvalidateSharedMemory):

• StorageProcess/ServiceWorker/WebSWOriginStore.h: Copied from Source/WebKit/WebProcess/Storage/WebServiceWorkerProvider.h.
• StorageProcess/ServiceWorker/WebSWServerConnection.cpp:

(WebKit::WebSWServerConnection::WebSWServerConnection):
(WebKit::WebSWServerConnection::resolveJobInClient):

• StorageProcess/ServiceWorker/WebSWServerConnection.h:

(WebKit::WebSWServerConnection::sessionID const):

• StorageProcess/StorageProcess.cpp:

(WebKit::StorageProcess::deleteWebsiteData):
(WebKit::StorageProcess::deleteWebsiteDataForOrigins):
(WebKit::StorageProcess::ensureSWOriginStoreForSession):
(WebKit::StorageProcess::swOriginStoreForSession const):
(WebKit::StorageProcess::serviceWorkerContextStarted):
(WebKit::StorageProcess::registerSWServerConnection):
(WebKit::StorageProcess::unregisterSWServerConnection):

• StorageProcess/StorageProcess.h:
• StorageProcess/StorageProcess.messages.in:
• WebKit.xcodeproj/project.pbxproj:
• WebProcess/Storage/WebSWClientConnection.cpp:

(WebKit::WebSWClientConnection::WebSWClientConnection):
(WebKit::WebSWClientConnection::hasServiceWorkerRegisteredForOrigin const):
(WebKit::WebSWClientConnection::setSWOriginTableSharedMemory):

• WebProcess/Storage/WebSWClientConnection.h:
• WebProcess/Storage/WebSWClientConnection.messages.in:
• WebProcess/Storage/WebSWOriginTable.cpp: Copied from Source/WebKit/WebProcess/Storage/WebServiceWorkerProvider.h.

(WebKit::WebSWOriginTable::contains const):
(WebKit::WebSWOriginTable::setSharedMemory):

• WebProcess/Storage/WebSWOriginTable.h: Copied from Source/WebKit/WebProcess/Storage/WebServiceWorkerProvider.h.
• WebProcess/Storage/WebServiceWorkerProvider.cpp:

(WebKit::WebServiceWorkerProvider::serviceWorkerConnectionForSession):

• WebProcess/Storage/WebServiceWorkerProvider.h:
• WebProcess/Storage/WebToStorageProcessConnection.cpp:

(WebKit::WebToStorageProcessConnection::serviceWorkerConnectionForSession):

• WebProcess/Storage/WebToStorageProcessConnection.h:
• WebProcess/WebProcess.cpp:

(WebKit::WebProcess::startServiceWorkerContext):

Tools:

Clear service worker registrations between test runs to avoid flakiness.

• WebKitTestRunner/TestController.cpp:

(WTR::TestController::resetStateToConsistentValues):

LayoutTests:

Add layout test coverage. Also rebaseline a few tests now that registration succeeds.

• http/tests/workers/service/basic-register-exceptions-expected.txt:
• http/tests/workers/service/basic-register-expected.txt:
• http/tests/workers/service/registration-task-queue-scheduling-1-expected.txt:
• http/tests/workers/service/resources/basic-register.js:
• http/tests/workers/service/resources/registration-task-queue-scheduling-1.js:

8:16 AM Changeset in webkit [223607] by commit-queue@webkit.org

• 3 edits in trunk/Source/WebCore

[Settings] Replace macros in Settings.h/cpp with generated code
​https://bugs.webkit.org/show_bug.cgi?id=178419

Patch by Sam Weinig <​sam@webkit.org> on 2017-10-18
Reviewed by Antti Koivisto.

• Scripts/GenerateSettings/GenerateSettingsHeaderFile.py:
• Scripts/GenerateSettings/GenerateSettingsImplementationFile.py:

Rather than use macros in the generated Settings class, generate the code the macros
would expand to.

7:57 AM Changeset in webkit [223606] by Konstantin Tokarev

• 2 edits in trunk/Source/WTF

REGRESSION(r217771): nullTerminatedWCharToString loses last character of input string
​https://bugs.webkit.org/show_bug.cgi?id=178444

Reviewed by Per Arne Vollan.

• wtf/text/win/WCharStringExtras.h:

(WTF::nullTerminatedWCharToString):

7:18 AM Changeset in webkit [223605] by Alan Bujtas

• 3 edits in trunk/Source/WebCore

[FrameView::layout cleanup] Move frame flattening layout logic to a separate function
​https://bugs.webkit.org/show_bug.cgi?id=178425
<rdar://problem/35045836>

Reviewed by Antti Koivisto.

No change in functionality.

• page/FrameView.cpp:

(WebCore::FrameView::handleLayoutWithFrameFlatteningIfNeeded):
(WebCore::FrameView::layout):
(WebCore::FrameView::startLayoutAtMainFrameViewIfNeeded):

• page/FrameView.h:

6:41 AM Changeset in webkit [223604] by Antti Koivisto

• 12 edits
  2 adds in trunk

Resolve ::before and ::after pseudo elements during style resolution
​https://bugs.webkit.org/show_bug.cgi?id=178339
Source/WebCore:

Reviewed by Ryosuke Niwa.

They are currently resolved during render tree building which creates problems with display:contents and animations.

• dom/PseudoElement.cpp:

(WebCore::PseudoElement::PseudoElement):

Call InspectorInstrumentation from constructor.

• style/RenderTreeUpdater.cpp:

(WebCore::RenderTreeUpdater::Parent::Parent):
(WebCore::RenderTreeUpdater::updateRenderTree):
(WebCore::RenderTreeUpdater::pushParent):

Push the full update to the parent stack.

(WebCore::RenderTreeUpdater::popParent):
(WebCore::RenderTreeUpdater::updateBeforeDescendants):
(WebCore::RenderTreeUpdater::updateAfterDescendants):
(WebCore::RenderTreeUpdater::invalidateWhitespaceOnlyTextSiblingsAfterAttachIfNeeded):

• style/RenderTreeUpdater.h:
• style/RenderTreeUpdaterGeneratedContent.cpp:

(WebCore::RenderTreeUpdater::GeneratedContent::updatePseudoElement):

No need to resolve pseudo style, we have it already.

(WebCore::RenderTreeUpdater::GeneratedContent::needsPseudoElement):
(WebCore::RenderTreeUpdater::GeneratedContent::updateBeforePseudoElement): Deleted.
(WebCore::RenderTreeUpdater::GeneratedContent::updateAfterPseudoElement): Deleted.

• style/RenderTreeUpdaterGeneratedContent.h:
• style/StyleTreeResolver.cpp:

(WebCore::Style::TreeResolver::resolveElement):
(WebCore::Style::TreeResolver::resolvePseudoStyle):

Resolve pseudos.

(WebCore::Style::TreeResolver::createAnimatedElementUpdate):

Make a private member function.

(WebCore::Style::TreeResolver::resolveComposedTree):

• style/StyleTreeResolver.h:
• style/StyleUpdate.cpp:

(WebCore::Style::Update::elementUpdates const):
(WebCore::Style::Update::elementUpdates):

Bundle the style update for an element and the associated before/after pseudos.

(WebCore::Style::Update::elementStyle const):
(WebCore::Style::Update::elementStyle):
(WebCore::Style::Update::addElement):
(WebCore::Style::Update::elementUpdate const): Deleted.
(WebCore::Style::Update::elementUpdate): Deleted.

• style/StyleUpdate.h:

LayoutTests:

<rdar://problem/35025601>

Reviewed by Ryosuke Niwa.

Add a test verifying a crash noticed with earlier version of this patch.

• fast/css-generated-content/svg-use-crash-expected.html: Added.
• fast/css-generated-content/svg-use-crash.html: Added.

5:53 AM Changeset in webkit [223603] by Yusuke Suzuki

• 2 edits in trunk/Source/JavaScriptCore

[JSC] Remove unused private name structure
​https://bugs.webkit.org/show_bug.cgi?id=178436

Reviewed by Sam Weinig.

It is no longer used. This patch just removes it.

• runtime/JSGlobalObject.h:

(JSC::JSGlobalObject::numberObjectStructure const):
(JSC::JSGlobalObject::privateNameStructure const): Deleted.

5:47 AM Changeset in webkit [223602] by Ms2ger@igalia.com

• 4 edits in trunk/Source/WebCore

Update the signatures of texSubImage3D.
​https://bugs.webkit.org/show_bug.cgi?id=178435

Reviewed by Sam Weinig.

Update the signatures of texSubImage3D.

No new tests: not much point in adding tests now; this method doesn't
do anything anyway.

• html/canvas/WebGL2RenderingContext.cpp:

(WebCore::WebGL2RenderingContext::texSubImage3D):

• html/canvas/WebGL2RenderingContext.h:
• html/canvas/WebGL2RenderingContext.idl:

5:04 AM Changeset in webkit [223601] by zandobersek@gmail.com

• 5 edits
  5 deletes in trunk

Remove remnants of OpenWebRTC
​https://bugs.webkit.org/show_bug.cgi?id=178437

Reviewed by Alejandro G. Castro.

.:

Remove the FindOpenWebRTC.cmake file and the searches for it in both
OptionsGTK and OptionsWPE.

• Source/cmake/FindOpenWebRTC.cmake: Removed.
• Source/cmake/OptionsGTK.cmake:
• Source/cmake/OptionsWPE.cmake:

Tools:

Drop OpenWebRTC packages from the GTK's Jhbuild modules file. Relevant
patches are also removed.

• gtk/jhbuild.modules:
• gtk/patches/libnice-0001-TURN-allow-REALM-to-be-empty.patch: Removed.
• gtk/patches/libnice-0001-nicesrc-spin-the-agent-mainloop-in-a-separate-thread.patch: Removed.
• gtk/patches/rtspsrc-timeout-on-udpsrc-is-in-nanoseconds.patch: Removed.
• gtk/patches/udpsrc-improve-timeouts.patch: Removed.

4:05 AM Changeset in webkit [223600] by commit-queue@webkit.org

• 3 edits in trunk/Source/WebCore

Use LazyNeverDestroyed instead of DEFINE_GLOBAL for WebKitFontFamilyNames
​https://bugs.webkit.org/show_bug.cgi?id=175106

Patch by Fujii Hironori <Fujii Hironori> on 2017-10-18
Reviewed by Yusuke Suzuki.

No new tests because there is no behavior change.

• css/CSSFontFaceSet.cpp:

(WebCore::CSSFontFaceSet::familyNameFromPrimitive): Call get() method of LazyNeverDestroyed.

• dom/make_names.pl: Use LazyNeverDestroyed for font names.

3:58 AM Changeset in webkit [223599] by Carlos Garcia Campos

• 1 copy in releases/WebKitGTK/webkit-2.18.1

WebKitGTK+ 2.18.1

3:53 AM Changeset in webkit [223598] by Carlos Garcia Campos

• 4 edits in releases/WebKitGTK/webkit-2.18

Unreviewed. Update OptionsGTK.cmake and NEWS for 2.18.1 release.

.:

• Source/cmake/OptionsGTK.cmake: Bump version numbers.

Source/WebKit:

• gtk/NEWS: Add release notes for 2.18.1.

2:55 AM Changeset in webkit [223597] by Carlos Garcia Campos

• 2 edits in releases/WebKitGTK/webkit-2.18/Source/WebCore

[GTK][Stable] BackingStoreBackendCairoImpl.h:23:10: fatal error: WebCore/HysteresisActivity.h
​https://bugs.webkit.org/show_bug.cgi?id=178407

Reviewed by Žan Doberšek.

Do not use #include <WebCore/Foo.h> inside WebCore.

• platform/graphics/cairo/BackingStoreBackendCairoImpl.h:

1:30 AM Changeset in webkit [223596] by zandobersek@gmail.com

• 11 edits in trunk/Source/WebCore

[MSE] Move SourceBuffer's pending append data into the platform implementations
​https://bugs.webkit.org/show_bug.cgi?id=178003

Reviewed by Jer Noble.

In SourceBuffer::appendBufferTimerFired(), we can use move semantics to
pass the pending append data into the platform layer, where it can then
be used more efficiently.

Resources in the m_pendingAppendData member are moved into the append()
call on the SourceBufferPrivate object. The m_pendingAppendData is still
cleared out manually in case the underlying implementation doesn't clear
it out through a move operation. The SourceBufferPrivate interface is
updated to accept a Vector rvalue reference as the only parameter of the
append() method.

For the GStreamer implementation, signature of the append() method in
MediaSourceClientGStreamerMSE class is also updated. The implementation
now moves the Vector resources over to a on-heap Vector object that is
then wrapped into a GstBuffer object by using the
gst_buffer_new_wrapped_full() API and specifying the custom deleter.

The AVFoundation implementation of SourceBufferPrivate is only updated
to reflect the changes in the interface. The Vector data that is passed
in is still copied into the NSData allocation.

MockSourceBufferPrivate is also updated, with the append data still
being copied into the m_inputBuffer Vector.

No new tests -- no change in behavior.

• Modules/mediasource/SourceBuffer.cpp:

(WebCore::SourceBuffer::appendBufferTimerFired):

• platform/graphics/SourceBufferPrivate.h:
• platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.h:
• platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm:

(WebCore::SourceBufferPrivateAVFObjC::append):

• platform/graphics/gstreamer/mse/MediaSourceClientGStreamerMSE.cpp:

(WebCore::MediaSourceClientGStreamerMSE::append):

• platform/graphics/gstreamer/mse/MediaSourceClientGStreamerMSE.h:
• platform/graphics/gstreamer/mse/SourceBufferPrivateGStreamer.cpp:

(WebCore::SourceBufferPrivateGStreamer::append):

• platform/graphics/gstreamer/mse/SourceBufferPrivateGStreamer.h:
• platform/mock/mediasource/MockSourceBufferPrivate.cpp:

(WebCore::MockSourceBufferPrivate::append):

• platform/mock/mediasource/MockSourceBufferPrivate.h:

1:12 AM Changeset in webkit [223595] by rniwa@webkit.org

• 2 edits in trunk/Source/JavaScriptCore

Fix macOS and iOS builds after r223594.

• JavaScriptCore.xcodeproj/project.pbxproj:

12:12 AM Changeset in webkit [223594] by Yusuke Suzuki

• 37 edits
  13 adds in trunk

[JSC] proto getter should be fast
​https://bugs.webkit.org/show_bug.cgi?id=178067

Reviewed by Saam Barati.

JSTests:

• stress/dfg-object-proto-accessor.js: Added.

(shouldBe):
(shouldThrow):
(target):

• stress/dfg-object-proto-getter.js: Added.

(shouldBe):
(shouldThrow):
(target):

• stress/dfg-object-prototype-of.js: Added.

(shouldBe):
(shouldThrow):
(target):

• stress/dfg-reflect-get-prototype-of.js: Added.

(shouldBe):
(shouldThrow):
(target):

• stress/intrinsic-getter-with-poly-proto.js: Added.

(shouldBe):
(makePolyProtoObject.foo.C):
(makePolyProtoObject.foo):
(makePolyProtoObject):
(target):

• stress/object-get-prototype-of-filtered.js: Added.

(shouldBe):
(shouldThrow):
(target):
(i.Cocoa):

• stress/object-get-prototype-of-mono-proto.js: Added.

(shouldBe):
(makePolyProtoObject.foo.C):
(makePolyProtoObject.foo):
(makePolyProtoObject):
(target):

• stress/object-get-prototype-of-poly-mono-proto.js: Added.

(shouldBe):
(makePolyProtoObject.foo.C):
(makePolyProtoObject.foo):
(makePolyProtoObject):
(target):

• stress/object-get-prototype-of-poly-proto.js: Added.

(shouldBe):
(makePolyProtoObject.foo.C):
(makePolyProtoObject.foo):
(makePolyProtoObject):
(target):

• stress/object-proto-getter-filtered.js: Added.

(shouldBe):
(shouldThrow):
(target):
(i.Cocoa):

• stress/object-proto-getter-poly-mono-proto.js: Added.

(shouldBe):
(makePolyProtoObject.foo.C):
(makePolyProtoObject.foo):
(makePolyProtoObject):
(target):

• stress/object-proto-getter-poly-proto.js: Added.

(shouldBe):
(makePolyProtoObject.foo.C):
(makePolyProtoObject.foo):
(makePolyProtoObject):
(target):

• stress/object-prototype-proto-accessors-should-throw-on-undefined-this.js:
• stress/string-proto.js: Added.

(shouldBe):
(target):

Source/JavaScriptCore:

In our ES6 class implementation, we access proto field to retrieve super constructor.
Currently, it is handled as an usual getter call to a generic function. And DFG just emits
Call node for this. It is inefficient since typically we know the prototype of the given
object when accessing object.__proto__ since we emit CheckStructure for this object.
If Structure has mono proto, we can immediately fold it to constant value. If it is poly proto,
we can still change this to efficient access to poly proto slot.

This patch implements GetPrototypeOf DFG node. This node efficiently accesses to prototype of
the given object. And in AI and ByteCodeParser phase, we attempt to fold it to constant.
ByteCodeParser's folding is a bit important since we have callee.__proto__ code to get super
constructor. If we can change this to constant, we can reify CallLinkInfo with this constant.
This paves the way to optimizing ArrayConstructor super calls[1], which is particularly important
for ARES-6 ML.

And we also optimize Reflect.getPrototypeOf and Object.getPrototypeOf with this GetPrototypeOf node.

Currently, proto access for poly proto object is not handled well in IC. But we add code handling
poly proto in GetPrototypeOf since Reflect.getPrototypeOf and Object.getPrototypeOf can use it.
Once IC starts handling poly proto & intrinsic getter well, this code will be used for that too.

This patch improves SixSpeed super.es6 by 3.42x.

baseline patched

super.es6 123.6666+-3.9917 ^{36.1684+-1.0351} definitely 3.4192x faster

[1]: ​https://bugs.webkit.org/show_bug.cgi?id=178064

• dfg/DFGAbstractInterpreterInlines.h:

(JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):

• dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::handleIntrinsicCall):
(JSC::DFG::ByteCodeParser::handleIntrinsicGetter):
(JSC::DFG::ByteCodeParser::handleGetById):

• dfg/DFGClobberize.h:

(JSC::DFG::clobberize):

• dfg/DFGDoesGC.cpp:

(JSC::DFG::doesGC):

• dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode):
(JSC::DFG::FixupPhase::fixupGetPrototypeOf):

• dfg/DFGHeapLocation.cpp:

(WTF::printInternal):

• dfg/DFGHeapLocation.h:
• dfg/DFGNode.h:

(JSC::DFG::Node::hasHeapPrediction):
(JSC::DFG::Node::shouldSpeculateFunction):

• dfg/DFGNodeType.h:
• dfg/DFGOperations.cpp:
• dfg/DFGOperations.h:
• dfg/DFGPredictionPropagationPhase.cpp:
• dfg/DFGSafeToExecute.h:

(JSC::DFG::safeToExecute):

• dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::speculateFunction):
(JSC::DFG::SpeculativeJIT::speculateFinalObject):
(JSC::DFG::SpeculativeJIT::compileGetPrototypeOf):

• dfg/DFGSpeculativeJIT.h:

(JSC::DFG::SpeculativeJIT::callOperation):

• dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

• dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

• ftl/FTLCapabilities.cpp:

(JSC::FTL::canCompile):

• ftl/FTLLowerDFGToB3.cpp:

(JSC::FTL::DFG::LowerDFGToB3::compileNode):
(JSC::FTL::DFG::LowerDFGToB3::compileGetPrototypeOf):
(JSC::FTL::DFG::LowerDFGToB3::compileInstanceOf):

• jit/IntrinsicEmitter.cpp:

(JSC::IntrinsicGetterAccessCase::canEmitIntrinsicGetter):
(JSC::IntrinsicGetterAccessCase::emitIntrinsicGetter):

• jit/JITOperations.h:
• runtime/Intrinsic.cpp:

(JSC::intrinsicName):

• runtime/Intrinsic.h:
• runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::init):

• runtime/JSGlobalObject.h:

(JSC::JSGlobalObject::booleanPrototype const):
(JSC::JSGlobalObject::numberPrototype const):
(JSC::JSGlobalObject::booleanObjectStructure const):

• runtime/JSGlobalObjectFunctions.cpp:

(JSC::globalFuncProtoGetter):

• runtime/JSGlobalObjectFunctions.h:
• runtime/ObjectConstructor.cpp:
• runtime/ReflectObject.cpp:

LayoutTests:

• js/object-literal-shorthand-construction-expected.txt:
• js/script-tests/object-literal-shorthand-construction.js:

(set 2):
(get 1):

• js/script-tests/sloppy-getter-setter-global-object.js:
• js/sloppy-getter-setter-global-object-expected.txt:

Oct 17, 2017:

11:02 PM Changeset in webkit [223593] by jmarcell@apple.com

• 3 edits
  2 adds in branches/safari-604-branch

Cherry-pick r223313. rdar://problem/35042269

11:02 PM Changeset in webkit [223592] by jmarcell@apple.com

• 2 edits in branches/safari-604-branch/Source/JavaScriptCore

Cherry-pick r222417. rdar://problem/35010839

11:02 PM Changeset in webkit [223591] by jmarcell@apple.com

• 2 edits in branches/safari-604-branch/Source/ThirdParty/libwebrtc

Cherry-pick r222531. rdar://problem/34985199

6:42 PM Changeset in webkit [223590] by Alan Bujtas

• 2 edits in trunk/Source/WebCore

[FrameView::layout cleanup] Remove redundant body->renderer()->setChildNeedsLayout() call
​https://bugs.webkit.org/show_bug.cgi?id=178414
<rdar://problem/35040876>

Reviewed by Simon Fraser.

Since m_size always equals to layoutSize() at this point, we never call setChildNeedsLayout() on the body's renderer.
However a few lines below, when we adjust the frame size and check if oldSize != m_size, we actually
dirty the body's renderer.

Covered by existing tests.

• page/FrameView.cpp:

(WebCore::FrameView::layout):

5:34 PM Changeset in webkit [223589] by mmaxfield@apple.com

• 3 edits
  4 adds in trunk

[Regression] Webkit "-apple-system" font fallback token handles font weights of PingFang incorrectly.
​https://bugs.webkit.org/show_bug.cgi?id=177345
<rdar://problem/32975942>

Reviewed by Jon Lee.

Source/WebCore:

This bug has a fairly insideous cause. In particular, the system font fallback path follows
system conventions, which are not the same as the CSS fallback path. For example, the Chinese
fallback of San Francisco weight 600 is Ping Fang weight 500. This doesn't match our
assumptions in CSS, because Ping Fang does have a 600 weight, which CSS would think is closer.
However, the whole point of system-ui is that it follows the system fallback path, not CSS's.
Therefore, falling back from a bold system-ui request to a non-bold fallback font is correct
and expected, and we shouldn't synthesize bold in this situation.

Test: fast/text/system-ui-chinese-bold-fallback.html

• platform/graphics/cocoa/FontFamilySpecificationCoreText.cpp:

(WebCore::FontFamilySpecificationCoreText::fontRanges const):

LayoutTests:

• fast/text/system-ui-chinese-bold-fallback.html:

5:06 PM Changeset in webkit [223588] by jmarcell@apple.com

• 7 edits in trunk/Source

Versioning.

5:05 PM Changeset in webkit [223587] by dino@apple.com

• 2 edits in trunk/LayoutTests

webgl/1.0.2/conformance/canvas/drawingbuffer-static-canvas-test.html failing
​https://bugs.webkit.org/show_bug.cgi?id=178417
<rdar://problem/35042291>

Skip this test while I work out what causes it to fail on older hardware.

• TestExpectations:

4:49 PM Changeset in webkit [223586] by fpizlo@apple.com

• 2 edits in trunk/Source/bmalloc

You can't vmDeallocate null
<rdar://problem/35038926>

Reviewed by Michael Saboff.

After failing allocation, we would try to deallocate the thing we failed to allocate. The fix is to
not try to deallocate something that is obviously null.

• bmalloc/Gigacage.cpp:

(Gigacage::ensureGigacage):

4:38 PM Changeset in webkit [223585] by cpugh@apple.com

• 2 edits in trunk/Source/WebCore

[iOS] Don't turn fields yellow after filling credentials
​https://bugs.webkit.org/show_bug.cgi?id=178411

Reviewed by Wenson Hsieh.

• editing/ios/AutofillElements.cpp:

(WebCore::AutofillElements::autofill): We don't want to turn fields yellow when filling the user name
and password. Remove the code that was causing that to happen.

4:34 PM Changeset in webkit [223584] by Ryan Haddad

• 36 edits
  13 deletes in trunk

Unreviewed, rolling out r223523.

A test for this change is failing on debug JSC bots.

Reverted changeset:

"[JSC] proto getter should be fast"
​https://bugs.webkit.org/show_bug.cgi?id=178067
​https://trac.webkit.org/changeset/223523

4:10 PM Changeset in webkit [223583] by aestes@apple.com

• 1 edit in trunk/Source/WebCore/Modules/applepay/cocoa/PaymentContactCocoa.mm

Fix the Sierra build after r223580.

• Modules/applepay/cocoa/PaymentContactCocoa.mm:

(WebCore::subLocality):
(WebCore::setSubLocality):
(WebCore::subAdministrativeArea):
(WebCore::setSubAdministrativeArea):

4:03 PM Changeset in webkit [223582] by pvollan@apple.com

• 2 edits in trunk/LayoutTests

Mark fast/text/ellipsis-text-rtl.html as a failure on Windows.
​https://bugs.webkit.org/show_bug.cgi?id=178413

Unreviewed test gardening.

• platform/win/TestExpectations:

2:51 PM Changeset in webkit [223581] by jmarcell@apple.com

• 11 edits in tags/Safari-605.1.11/Source/WebCore

Cherry-pick r223579. rdar://problem/35032527

2:41 PM Changeset in webkit [223580] by aestes@apple.com

• 12 edits in trunk

[Apple Pay] Add subLocality and subAdministrativeArea to ApplePayPaymentContact and ApplePayError
​https://bugs.webkit.org/show_bug.cgi?id=178191
<rdar://problem/34906367>

Reviewed by Tim Horton.

Source/WebCore:

Added test cases to http/tests/ssl/applepay/ApplePaySession.html.

• Modules/applepay/ApplePayError.idl:
• Modules/applepay/ApplePayPaymentContact.h:
• Modules/applepay/ApplePayPaymentContact.idl:
• Modules/applepay/ApplePaySessionPaymentRequest.h:
• Modules/applepay/cocoa/PaymentContactCocoa.mm:

(WebCore::subLocality):
(WebCore::setSubLocality):
(WebCore::subAdministrativeArea):
(WebCore::setSubAdministrativeArea):
(WebCore::convert):

Source/WebKit:

• UIProcess/ApplePay/cocoa/WebPaymentCoordinatorProxyCocoa.mm:

(WebKit::toNSError):

LayoutTests:

• http/tests/ssl/applepay/ApplePayError-expected.txt:
• http/tests/ssl/applepay/ApplePaySession-expected.txt:
• http/tests/ssl/applepay/ApplePaySession.html:

2:29 PM Changeset in webkit [223579] by commit-queue@webkit.org

• 11 edits in trunk/Source/WebCore

Unreviewed, rolling out r223500.
​https://bugs.webkit.org/show_bug.cgi?id=178408

Introduced a crash in CSSAnimationController::updateAnimations
(Requested by rniwa on #webkit).

Reverted changeset:

"Resolve ::before and ::after pseudo elements during style
resolution"
​https://bugs.webkit.org/show_bug.cgi?id=178339
​https://trac.webkit.org/changeset/223500

2:21 PM Changeset in webkit [223578] by mmaxfield@apple.com

• 7 edits
  48 adds in trunk

Delete button doesn't fully delete certain emoji
​https://bugs.webkit.org/show_bug.cgi?id=178096
<rdar://problem/34785106>

Reviewed by Simon Fraser.

Source/WebCore:

System infrastructure for handling emoji changes every year. Instead of having
custom code to specifically walk over codepoints, we should delegate to the
system handling.

Tests: editing/deleting/delete-emoji.html

editing/deleting/delete-emoji-1.html
editing/deleting/delete-emoji-2.html
editing/deleting/delete-emoji-3.html
editing/deleting/delete-emoji-4.html
editing/deleting/delete-emoji-5.html
editing/deleting/delete-emoji-6.html
editing/deleting/delete-emoji-7.html
editing/deleting/delete-emoji-8.html
editing/deleting/delete-emoji-9.html

• rendering/RenderText.cpp:

(WebCore::RenderText::previousOffset const):
(WebCore::RenderText::previousOffsetForBackwardDeletion const):
(WebCore::RenderText::nextOffset const):
(WebCore::isHangulLVT): Deleted.
(WebCore::isMark): Deleted.
(WebCore::isRegionalIndicator): Deleted.
(WebCore::isInArmenianToLimbuRange): Deleted.

LayoutTests:

• editing/deleting/delete-emoji-1.html: Added.
• editing/deleting/delete-emoji-2.html: Added.
• editing/deleting/delete-emoji-3.html: Added.
• editing/deleting/delete-emoji-4.html: Added.
• editing/deleting/delete-emoji-5.html: Added.
• editing/deleting/delete-emoji-6.html: Added.
• editing/deleting/delete-emoji-7.html: Added.
• editing/deleting/delete-emoji-8.html: Added.
• editing/deleting/delete-emoji-9.html: Added.
• editing/deleting/delete-emoji.html:
• platform/ios/editing/deleting/delete-emoji-1-expected.txt: Added.
• platform/ios/editing/deleting/delete-emoji-2-expected.txt: Added.
• platform/ios/editing/deleting/delete-emoji-3-expected.txt: Added.
• platform/ios/editing/deleting/delete-emoji-4-expected.txt: Added.
• platform/ios/editing/deleting/delete-emoji-5-expected.txt: Added.
• platform/ios/editing/deleting/delete-emoji-6-expected.txt: Added.
• platform/ios/editing/deleting/delete-emoji-7-expected.txt: Added.
• platform/ios/editing/deleting/delete-emoji-8-expected.txt: Added.
• platform/ios/editing/deleting/delete-emoji-9-expected.txt: Added.
• platform/ios/editing/deleting/delete-emoji-expected.txt:
• platform/mac-elcapitan/editing/deleting/delete-emoji-2-expected.txt: Added.
• platform/mac-elcapitan/editing/deleting/delete-emoji-3-expected.txt: Added.
• platform/mac-elcapitan/editing/deleting/delete-emoji-4-expected.txt: Added.
• platform/mac-elcapitan/editing/deleting/delete-emoji-5-expected.txt: Added.
• platform/mac-elcapitan/editing/deleting/delete-emoji-6-expected.txt: Added.
• platform/mac-elcapitan/editing/deleting/delete-emoji-7-expected.txt: Added.
• platform/mac-elcapitan/editing/deleting/delete-emoji-8-expected.txt: Added.
• platform/mac-elcapitan/editing/deleting/delete-emoji-9-expected.txt: Added.
• platform/mac-elcapitan/editing/deleting/delete-emoji-expected.txt: Added.
• platform/mac-sierra/editing/deleting/delete-emoji-1-expected.txt: Added.
• platform/mac-sierra/editing/deleting/delete-emoji-2-expected.txt: Added.
• platform/mac-sierra/editing/deleting/delete-emoji-3-expected.txt: Added.
• platform/mac-sierra/editing/deleting/delete-emoji-4-expected.txt: Added.
• platform/mac-sierra/editing/deleting/delete-emoji-5-expected.txt: Added.
• platform/mac-sierra/editing/deleting/delete-emoji-6-expected.txt: Added.
• platform/mac-sierra/editing/deleting/delete-emoji-7-expected.txt: Added.
• platform/mac-sierra/editing/deleting/delete-emoji-8-expected.txt: Added.
• platform/mac-sierra/editing/deleting/delete-emoji-9-expected.txt: Added.
• platform/mac-sierra/editing/deleting/delete-emoji-expected.txt: Added.
• platform/mac/editing/deleting/delete-emoji-1-expected.txt: Added.
• platform/mac/editing/deleting/delete-emoji-2-expected.txt: Added.
• platform/mac/editing/deleting/delete-emoji-3-expected.txt: Added.
• platform/mac/editing/deleting/delete-emoji-4-expected.txt: Added.
• platform/mac/editing/deleting/delete-emoji-5-expected.txt: Added.
• platform/mac/editing/deleting/delete-emoji-6-expected.txt: Added.
• platform/mac/editing/deleting/delete-emoji-7-expected.txt: Added.
• platform/mac/editing/deleting/delete-emoji-8-expected.txt: Added.
• platform/mac/editing/deleting/delete-emoji-9-expected.txt: Added.
• platform/mac/editing/deleting/delete-emoji-expected.txt:
• platform/win/TestExpectations:

2:19 PM Changeset in webkit [223577] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebCore

Add preliminary support for fetch event
​https://bugs.webkit.org/show_bug.cgi?id=178171

Unreviewed.

Patch by Youenn Fablet <​youenn@apple.com> on 2017-10-17

• workers/service/FetchEvent.cpp:

(WebCore::FetchEvent::promiseIsSettled): build fix by removing unnecessary captured this at the moment.

2:16 PM Changeset in webkit [223576] by mmaxfield@apple.com

• 2 edits in trunk/Source/WebCore

[CSS Font Loading] Fonts are erroneously invisible when the policy says they should be visible
​https://bugs.webkit.org/show_bug.cgi?id=178238

Reviewed by Simon Fraser.

When implementing font-display, I added testing infrastructure (so we don't have to wait for
3 second timeouts to occur). This testing infrastructure covered up a real bug where the wrong
font would be reported to CSSFontAccessor. This patch reverts the erroneous testing
infrastructure and replaces it with a real fix to the problem. The replacement fix is covered
by the same tests that I wrote when implementing the feature.

Covered by existing tests.

• css/CSSFontFace.cpp:

(WebCore::CSSFontFace::pump):
(WebCore::visibility):
(WebCore::CSSFontFace::font):

1:55 PM Changeset in webkit [223575] by Nikita Vasilyev

• 4 edits in trunk/Source/WebInspectorUI

Web Inspector: [PARITY] Styles Redesign: Add color picker inline widget
​https://bugs.webkit.org/show_bug.cgi?id=178354

Reviewed by Joseph Pecoraro.

Show color picker using the existing WI.InlineSwatch.

• UserInterface/Models/Color.js:
• UserInterface/Views/SpreadsheetCSSStyleDeclarationEditor.css:

(.spreadsheet-style-declaration-editor .property:not(.disabled) .token-comment):
Syntax highlight comments in values.

• UserInterface/Views/SpreadsheetStyleProperty.js:

(WI.SpreadsheetStyleProperty.prototype._renderValue):
(WI.SpreadsheetStyleProperty.prototype._addColorTokens):
Find colors in CodeMirror tokens and replace them with color token elements.

1:45 PM Changeset in webkit [223574] by weinig@apple.com

• 10 edits
  2 adds
  2 deletes in trunk/Source

[Settings] Generate Settings.h/cpp
​https://bugs.webkit.org/show_bug.cgi?id=178361

Reviewed by Dean Jackson.

Source/WebCore:

This change generates Settings.h and Settings.cpp exactly as they are,
using SettingsMacros.h and everything. In follow up changes, the use of
SettingsMacros.h will be removed.

• CMakeLists.txt:
• DerivedSources.make:
• Scripts/GenerateSettings.py:
• Scripts/GenerateSettings/GenerateSettings.py:
• Scripts/GenerateSettings/GenerateSettingsHeaderFile.py: Added.
• Scripts/GenerateSettings/GenerateSettingsImplementationFile.py: Added.
• WebCore.xcodeproj/project.pbxproj:
• WebCoreMacros.cmake:
• page/Settings.cpp: Removed.
• page/Settings.h: Removed.

Source/WebKit:

• PlatformGTK.cmake:
• PlatformWPE.cmake:

Delete the old Settings.h from the forwarding
headers directory to allow the build to work.

1:35 PM Changeset in webkit [223573] by Ms2ger@igalia.com

• 6 edits in trunk/Source/WebCore

Create bindings for WebGL2's versions of texSubImage2D.
​https://bugs.webkit.org/show_bug.cgi?id=178382

Reviewed by Ryosuke Niwa.

Create bindings for WebGL2's versions of texSubImage2D.

No new tests: not much point in adding tests now; this method doesn't
do anything anyway.

• html/canvas/WebGL2RenderingContext.cpp:

(WebCore::WebGL2RenderingContext::texSubImage2D):

• html/canvas/WebGL2RenderingContext.h:
• html/canvas/WebGL2RenderingContext.idl:
• html/canvas/WebGLRenderingContext.idl:
• html/canvas/WebGLRenderingContextBase.idl:

1:30 PM Changeset in webkit [223572] by Jonathan Bedard

• 2 edits in trunk/Tools

webkitpy: Hang when workers write to the same stack trace file
​https://bugs.webkit.org/show_bug.cgi?id=178402
<rdar://problem/35033432>

Reviewed by Aakash Jain.

Workers can hang if they all write to the same stack trace file when receiving
a SIGTERM. Attach the pid to the stack trace file name so that each worker
writes to a different file.

• Scripts/webkitpy/common/interupt_debugging.py:

(log_stack_trace_on_term.handler): Name stack trace file path/<pid>-filename.
(log_stack_trace_on_cntrl_c.handler): Ditto.

1:24 PM Changeset in webkit [223571] by pvollan@apple.com

• 2 edits in trunk/LayoutTests

Skip service workers tests on Windows.

Unreviewed test gardening.

• platform/win/TestExpectations:

1:18 PM Changeset in webkit [223570] by pvollan@apple.com

• 2 edits in trunk/LayoutTests

Mark animations/play-state-suspend.html as flaky on Windows.
​https://bugs.webkit.org/show_bug.cgi?id=178341

Unreviewed test gardening.

• platform/win/TestExpectations:

1:09 PM Changeset in webkit [223569] by Alan Bujtas

• 7 edits in trunk/Source/WebCore

[FrameView::layout cleanup] Subtree should read subtreeLayout.
​https://bugs.webkit.org/show_bug.cgi?id=178401

Reviewed by Simon Fraser.

Rename some variables to improve readability.

No change in functionality.

• page/FrameView.cpp:

(WebCore::SubtreeLayoutStateMaintainer::SubtreeLayoutStateMaintainer):
(WebCore::SubtreeLayoutStateMaintainer::~SubtreeLayoutStateMaintainer):
(WebCore::SubtreeLayoutStateMaintainer::shouldDisableLayoutStateForSubtree):
(WebCore::FrameView::reset):
(WebCore::FrameView::willDestroyRenderTree):
(WebCore::FrameView::didDestroyRenderTree):
(WebCore::FrameView::calculateScrollbarModesForLayout):
(WebCore::FrameView::layout):
(WebCore::FrameView::convertSubtreeLayoutToFullLayout):
(WebCore::FrameView::scheduleRelayout):
(WebCore::FrameView::scheduleRelayoutOfSubtree):
(WebCore::FrameView::needsLayout const):
(WebCore::FrameView::autoSizeIfEnabled):

• page/FrameView.h:

12:55 PM Changeset in webkit [223568] by jmarcell@apple.com

• 1 copy in tags/Safari-605.1.11

Tag Safari-605.1.11.

12:17 PM Changeset in webkit [223567] by dino@apple.com

• 4 edits
  2 adds in trunk

WebGL clamps drawingBufferWidth to 4096 pixels on a 5120 monitor/canvas
​https://bugs.webkit.org/show_bug.cgi?id=178223
<rdar://problem/34597567>

Reviewed by Antoine Quint.

Source/WebCore:

Remove the limit of 4k on the width/height of the renderbuffer.

Test: fast/canvas/webgl/large-drawing-buffer-resize.html

• html/canvas/WebGLRenderingContextBase.cpp:

(WebCore::WebGLRenderingContextBase::reshape):

LayoutTests:

Test that resizes an already large buffer to make sure it
doesn't get clamped to 4k.

• fast/canvas/webgl/large-drawing-buffer-resize-expected.txt: Added.
• fast/canvas/webgl/large-drawing-buffer-resize.html: Added.

12:04 PM Changeset in webkit [223566] by aestes@apple.com

• 9 edits in trunk

Roll out r223447.

Broke the Sierra build.

11:57 AM Changeset in webkit [223565] by wilander@apple.com

• 29 edits
  6 adds in trunk

Add and remove cookie partition accordingly in intermediary redirect requests
​https://bugs.webkit.org/show_bug.cgi?id=178369
<rdar://problem/34467603>

Reviewed by Brent Fulgham.

Source/WebCore:

Tests: http/tests/resourceLoadStatistics/add-partitioning-to-redirect.html

http/tests/resourceLoadStatistics/remove-partitioning-from-redirect.html

• loader/ResourceLoadObserver.h:

Now exposes notifyObserver() so that it can be triggered
by the TestRunner.
Removed unimplemented ResourceLoadObserver::setShouldThrottleObserverNotifications().

Source/WebKit:

• NetworkProcess/cocoa/NetworkDataTaskCocoa.mm:

(WebKit::shouldChangePartition):

Convenience function. Comment documents the logic.

(WebKit::NetworkDataTaskCocoa::willPerformHTTPRedirection):

Now adds and removes cookie partition based on the
redirect-to URL's domain.

• WebProcess/InjectedBundle/API/c/WKBundle.cpp:

(WKBundleResourceLoadStatisticsNotifyObserver):

Test infrastructure.

• WebProcess/InjectedBundle/API/c/WKBundlePrivate.h:

Tools:

Adds the function statisticsNotifyObserver().

• WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
• WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:

(WTR::InjectedBundle::statisticsNotifyObserver):

• WebKitTestRunner/InjectedBundle/InjectedBundle.h:
• WebKitTestRunner/InjectedBundle/TestRunner.cpp:

(WTR::TestRunner::statisticsNotifyObserver):

• WebKitTestRunner/InjectedBundle/TestRunner.h:

LayoutTests:

This patch adds two new tests, relevant for the code change.
Also makes changes to existing tests to increase speed and
reliability.

• http/tests/resourceLoadStatistics/add-partitioning-to-redirect-expected.txt: Added.
• http/tests/resourceLoadStatistics/add-partitioning-to-redirect.html: Added.
• http/tests/resourceLoadStatistics/non-sandboxed-iframe-redirect-ip-to-localhost-to-ip.html:
• http/tests/resourceLoadStatistics/non-sandboxed-iframe-redirect-localhost-to-ip-to-localhost.html:
• http/tests/resourceLoadStatistics/non-sandboxed-nesting-iframe-with-non-sandboxed-iframe-redirect-ip-to-localhost-to-ip.html:
• http/tests/resourceLoadStatistics/non-sandboxed-nesting-iframe-with-non-sandboxed-iframe-redirect-localhost-to-ip-to-localhost.html:
• http/tests/resourceLoadStatistics/non-sandboxed-nesting-iframe-with-sandboxed-iframe-redirect-ip-to-localhost-to-ip.html:
• http/tests/resourceLoadStatistics/non-sandboxed-nesting-iframe-with-sandboxed-iframe-redirect-localhost-to-ip-to-localhost.html:
• http/tests/resourceLoadStatistics/remove-partitioning-from-redirect-expected.txt: Added.
• http/tests/resourceLoadStatistics/remove-partitioning-from-redirect.html: Added.
• http/tests/resourceLoadStatistics/resources/get-cookies.php: Added.
• http/tests/resourceLoadStatistics/resources/redirect.php:
• http/tests/resourceLoadStatistics/resources/set-cookie.php: Added.
• http/tests/resourceLoadStatistics/sandboxed-iframe-redirect-ip-to-localhost-to-ip.html:
• http/tests/resourceLoadStatistics/sandboxed-iframe-redirect-localhost-to-ip-to-localhost.html:
• http/tests/resourceLoadStatistics/sandboxed-nesting-iframe-with-non-sandboxed-iframe-redirect-ip-to-localhost-to-ip.html:
• http/tests/resourceLoadStatistics/sandboxed-nesting-iframe-with-non-sandboxed-iframe-redirect-localhost-to-ip-to-localhost.html:
• http/tests/resourceLoadStatistics/sandboxed-nesting-iframe-with-sandboxed-iframe-redirect-ip-to-localhost-to-ip.html:
• http/tests/resourceLoadStatistics/sandboxed-nesting-iframe-with-sandboxed-iframe-redirect-localhost-to-ip-to-localhost.html:
• platform/ios/TestExpectations:

The two new tests are marked [ Pass ].

• platform/mac-wk2/TestExpectations:

The two new tests are marked [ Pass ].

• platform/wk2/TestExpectations:

The two new tests are marked [ Skip ] because they require cookie partitioning.

11:53 AM Changeset in webkit [223564] by jer.noble@apple.com

• 2 edits in trunk/Source/WebCore

Corrupted image after looping movie-backed <img>.
​https://bugs.webkit.org/show_bug.cgi?id=178398

Reviewed by Eric Carlson.

Use the decode-order sample cursor rather than the destination sample cursor when generating
the CMSampleBuffer to decode.

• platform/graphics/avfoundation/objc/ImageDecoderAVFObjC.mm:

(WebCore::ImageDecoderAVFObjC::createFrameImageAtIndex):

11:49 AM Changeset in webkit [223563] by Ryan Haddad

• 3 edits
  2 deletes in trunk

Unreviewed, rolling out r223459.

This change introduced LayoutTest failures.

Reverted changeset:

"WebGL clamps drawingBufferWidth to 4096 pixels on a 5120
monitor/canvas"
​https://bugs.webkit.org/show_bug.cgi?id=178223
​https://trac.webkit.org/changeset/223459

11:39 AM Changeset in webkit [223562] by commit-queue@webkit.org

• 17 edits
  3 copies
  14 adds in trunk

Add preliminary support for fetch event
​https://bugs.webkit.org/show_bug.cgi?id=178171

Patch by Youenn Fablet <​youenn@apple.com> on 2017-10-17
Reviewed by Chris Dumez.

Source/JavaScriptCore:

Adding events

• runtime/JSPromise.h:

Source/WebCore:

Test: http/wpt/service-workers/fetchEvent.https.html

http/wpt/service-workers/extendableEvent.https.html

Adding support for ExtendableEvent and FetchEvent as per
​https://w3c.github.io/ServiceWorker/v1/#extendableevent-interface and
​https://w3c.github.io/ServiceWorker/v1/#fetchevent-interface.

Both events need to handle promises as method parameters.
Beefing up DOMPromise for that purpose by exposing status, result and being able to call then.
Adding a new DOMPromise create method that would be the base for ​https://heycam.github.io/webidl/#es-promise
which might be implemented in the binding generator as a follow-up.

This patch makes them exposed on Window for test purposes until they can be fully tested on ServiceWorker environment.
It is also adding two internal methods for the same reason. These should be removed once events can be tested in its environment.

• CMakeLists.txt:
• DerivedSources.make:
• Modules/fetch/FetchResponse.idl:
• WebCore.xcodeproj/project.pbxproj:
• bindings/js/JSDOMPromise.cpp: Added.

(WebCore::callFunction):
(WebCore::DOMPromise::create):
(WebCore::DOMPromise::whenSettled):
(WebCore::DOMPromise::result const):
(WebCore::DOMPromise::status const):

• bindings/js/JSDOMPromise.h:
• bindings/js/WebCoreBuiltinNames.h:
• dom/EventNames.in:
• testing/Internals.cpp:

(WebCore::Internals::waitFetchEventToFinish):
(WebCore::Internals::waitExtendableEventToFinish):

• testing/Internals.h:
• testing/Internals.idl:
• workers/service/ExtendableEvent.cpp: Added.

(WebCore::ExtendableEvent::ExtendableEvent):
(WebCore::ExtendableEvent::waitUntil):
(WebCore::ExtendableEvent::addPendingPromise):

• workers/service/ExtendableEvent.h:

(WebCore::ExtendableEvent::onFinishedWaiting):
(WebCore::ExtendableEvent::promiseSettled):

• workers/service/ExtendableEvent.idl: Added.
• workers/service/ExtendableEventInit.h: Added.
• workers/service/ExtendableEventInit.idl: Added.
• workers/service/FetchEvent.cpp: Added.

(WebCore::FetchEvent::FetchEvent):
(WebCore::FetchEvent::respondWith):
(WebCore::FetchEvent::onResponse):
(WebCore::FetchEvent::respondWithError):
(WebCore::FetchEvent::processResponse):
(WebCore::FetchEvent::promiseSettled):

• workers/service/FetchEvent.h:
• workers/service/FetchEvent.idl:

LayoutTests:

Skipping new tests for WK1 and GTK that do not have SW.

• http/wpt/service-workers/extendableEvent.https-expected.txt: Added.
• http/wpt/service-workers/extendableEvent.https.html: Added.
• http/wpt/service-workers/fetchEvent.https-expected.txt: Added.
• http/wpt/service-workers/fetchEvent.https.html: Added.
• platform/gtk/TestExpectations:
• platform/ios-wk1/TestExpectations:
• platform/mac-wk1/TestExpectations:

11:39 AM Changeset in webkit [223561] by Nikita Vasilyev

• 4 edits in trunk/Source/WebInspectorUI

Web Inspector: Styles: Command-click on a property name should jump to definition in Resources tab
​https://bugs.webkit.org/show_bug.cgi?id=174329
<rdar://problem/33225564>

Reviewed by Joseph Pecoraro.

• UserInterface/Base/Main.js:

Add "meta-key-pressed" class to <body> when Command key is pressed.

• UserInterface/Views/SpreadsheetCSSStyleDeclarationEditor.css:

(.meta-key-pressed .spreadsheet-css-declaration:not(.locked) :matches(.name, .value):not(.editing):hover):
Use the same styles as in CodeMirrorTokenTrackingController.css.

• UserInterface/Views/SpreadsheetStyleProperty.js:

(WI.SpreadsheetStyleProperty.prototype._update):
(WI.SpreadsheetStyleProperty.prototype._setupJumpToSymbol):
This is very similar to WI.CSSStyleDeclarationTextEditor.prototype.tokenTrackingControllerHighlightedRangeWasClicked,
except it doesn't include special cases for CSS variables and links yet.

11:33 AM Changeset in webkit [223560] by jer.noble@apple.com

• 2 edits in trunk/Source/WebCore

Leak of one AVSampleCursor inside ImageDecoderAVFObjC::createFrameImageAtIndex()
​https://bugs.webkit.org/show_bug.cgi?id=178397

Reviewed by Eric Carlson.

Explicitly wrap the return value of -copy in a RetainPtr.

• platform/graphics/avfoundation/objc/ImageDecoderAVFObjC.mm:

(WebCore::ImageDecoderAVFObjC::createFrameImageAtIndex):

11:30 AM Changeset in webkit [223559] by aestes@apple.com

• 3 edits in trunk

Roll out r223247 until we can find a way to not break performance testing.

11:21 AM Changeset in webkit [223558] by commit-queue@webkit.org

• 17 edits in trunk

Cache API implementation should be able to compute storage size for WebKit client applications.
​https://bugs.webkit.org/show_bug.cgi?id=178350

Patch by Youenn Fablet <​youenn@apple.com> on 2017-10-17
Reviewed by Chris Dumez.

Source/WebCore:

• page/SecurityOriginData.h:

(WebCore::SecurityOriginData::equals const):

Source/WebKit:

When gathering data from DOM Cache, we compute the size as follows:

• If Caches object is not persistent, size is zero
• If Caches object is persistent, we use the size computed by NetworkCache::Storage.

Covered by updated tests.

• NetworkProcess/cache/CacheStorageEngine.cpp:

(WebKit::CacheStorage::ReadOriginsTaskCounter::create):
(WebKit::CacheStorage::ReadOriginsTaskCounter::addOrigin):
(WebKit::CacheStorage::Engine::fetchEntries):

• NetworkProcess/cache/CacheStorageEngineCaches.cpp:

(WebKit::CacheStorage::Caches::storageSize const):

• NetworkProcess/cache/CacheStorageEngineCaches.h:
• UIProcess/API/C/WKWebsiteDataStoreRef.cpp:

(WKWebsiteDataStoreGetFetchCacheSizeForOrigin):

• UIProcess/API/C/WKWebsiteDataStoreRef.h:

Tools:

Adding support for a domCacheSize getter.

• WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
• WebKitTestRunner/InjectedBundle/TestRunner.cpp:

(WTR::TestRunner::domCacheSize):

• WebKitTestRunner/InjectedBundle/TestRunner.h:
• WebKitTestRunner/TestController.cpp:

(WTR::FetchCacheSizeForOriginCallbackContext::FetchCacheSizeForOriginCallbackContext):
(WTR::fetchCacheSizeForOriginCallback):
(WTR::TestController::domCacheSize):

• WebKitTestRunner/TestController.h:
• WebKitTestRunner/TestInvocation.cpp:

(WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):

LayoutTests:

• http/tests/cache-storage/cache-clearing-origin.https.html:
• http/tests/cache-storage/cache-representation.https.html:

11:03 AM Changeset in webkit [223557] by Ryan Haddad

• 1 edit
  1 add in trunk/LayoutTests

Add expected result file for fast/css/DOMQuad-points-SameObject.html.
​https://bugs.webkit.org/show_bug.cgi?id=178366

Unreviewed test gardening.

• fast/css/DOMQuad-points-SameObject-expected.txt: Added.

10:41 AM Changeset in webkit [223556] by achristensen@apple.com

• 5 edits in trunk/LayoutTests

de-flakify http/tests/security/cross-frame-access-put.html
​https://bugs.webkit.org/show_bug.cgi?id=178371

Reviewed by Tim Horton.

In the iframe, the test was being run after 0ms. Sometimes, the whole iframe hadn't loaded yet,
so window.innerHeight and window.innerWidth were 0 instead of their intended values. This changes
the test to wait for the iframe to finish loading before running the test, then post a message to
the parent to tell it to finish running its test instead of just relying on setTimeout(..., 0) to
always work after the iframe had finished loading.

• http/tests/security/cross-frame-access-put-expected.txt:
• http/tests/security/cross-frame-access-put.html:
• http/tests/security/resources/cross-frame-iframe-for-put-test.html:
• platform/mac-wk2/TestExpectations:

10:37 AM Changeset in webkit [223555] by achristensen@apple.com

• 4 edits in trunk/LayoutTests

Layout Test http/tests/xmlhttprequest/xmlhttprequest-overridemimetype-invalidstaterror.html is flaky
​https://bugs.webkit.org/show_bug.cgi?id=150095

Reviewed by Tim Horton.

• http/tests/xmlhttprequest/xmlhttprequest-overridemimetype-invalidstaterror-expected.txt:
• http/tests/xmlhttprequest/xmlhttprequest-overridemimetype-invalidstaterror.html:
• platform/mac-wk2/TestExpectations:

We were mixing jsTestIsAsync with testRunner.notifyDone which caused some flakiness.
Calling finishJSTest on the next runloop iteration causes it to no longer be flaky.

10:19 AM Changeset in webkit [223554] by achristensen@apple.com

• 6 edits in trunk/LayoutTests

De-flakify http/tests/loading/basic-auth-resend-wrong-credentials.html
​https://bugs.webkit.org/show_bug.cgi?id=178370

Reviewed by Ryosuke Niwa.

Like r223445, in WebKit2 (and WebKit1 with asynchronous loading) sometimes the iframe would start
loading before the main resource loading finished, sometimes it wouldn't. This isn't a problem,
and the rest of the test is still valid, but in order to make the dumped delegate callbacks deterministic,
we make it so the iframe always starts loading after the main resource is done loading.

• http/tests/loading/basic-auth-resend-wrong-credentials-expected.txt:
• http/tests/loading/basic-auth-resend-wrong-credentials.html:
• platform/ios-wk2/TestExpectations:
• platform/mac-wk2/TestExpectations:
• platform/wk2/http/tests/loading/basic-auth-resend-wrong-credentials-expected.txt:

10:13 AM Changeset in webkit [223553] by dbates@webkit.org

• 3 edits
  2 adds in trunk

ASSERTION FAILED: m_truncation != cFullTruncation in InlineTextBox::clampedOffset()
​https://bugs.webkit.org/show_bug.cgi?id=178322

Reviewed by Darin Adler.

Source/WebCore:

It is acceptable for InlineTextBox::clampedOffset() to be called for a fully truncated box,
say a person clicks on the ellipsis in a truncated text run. Restore the behavior prior to
r223259 and return the clamped offset.

Test: fast/text/click-ellipsis-assertion-failure.html

• rendering/InlineTextBox.cpp:

(WebCore::InlineTextBox::clampedOffset const):

LayoutTests:

Add a test to ensure that clicking on the ellipsis in a truncated text run does not
cause an assertion failure in a debug build.

• fast/text/click-ellipsis-assertion-failure-expected.txt: Added.
• fast/text/click-ellipsis-assertion-failure.html: Added.

10:04 AM Changeset in webkit [223552] by dbates@webkit.org

• 7 edits
  2 adds in trunk

REGRESSION (r222670 and r222732): RTL truncated text may not be drawn
​https://bugs.webkit.org/show_bug.cgi?id=178278
<rdar://problem/34982818>

Reviewed by Darin Adler.

Source/WebCore:

Revert r222732 and partially revert r222670. The underlying font rendering machinery implements
text truncation by taking a TextRun object that represents all of the text in the line fragment
and a subrange of the glyphs to render from this fragment. Only the glyphs in this subrange are
drawn and they are drawn in the same position they would be in had the entire line fragment been
drawn. Following r222670 InlineTextBox applies the truncation to the TextRun in InlineTextBox::text().
Together with r222732, which assumed that the number of glyphs to draw is equal to the length of
the TextRun, a truncated text run would be drawn at the wrong position on screen and could give
the impression that the text is not drawn. Instead InlineTextBox::text() should always return
the text for the entire line fragment without considering truncation and when calling TextPainter::paint()
we need to pass the truncated length of the line fragment.

Test: fast/text/ellipsis-text-rtl.html

• rendering/InlineTextBox.cpp:

(WebCore::InlineTextBox::paint): Compute the truncated length (number of glyphs) and pass this
to TextPainter::paint()
(WebCore::InlineTextBox::text const): Do not apply truncation to the text run. Truncation is
implemented by telling the underlying font rendering machinery to paint the subrange of the
text run that represents the non-truncated (visible) text.

• rendering/InlineTextBox.h:
• rendering/SimpleLineLayoutFunctions.cpp:

(WebCore::SimpleLineLayout::paintFlow): Pass the entire length of the text run as we did prior
to r222732.

• rendering/TextPainter.cpp:

(WebCore::TextPainter::paint): Take a length that represents the number of glyphs to draw from
the text run as we use to take prior to r222732.

• rendering/TextPainter.h:

LayoutTests:

Add a test to ensure that we draw right-to-left truncated text correctly.

• fast/text/ellipsis-text-rtl-expected.html: Added.
• fast/text/ellipsis-text-rtl.html: Added.

9:34 AM Changeset in webkit [223551] by Alan Bujtas

• 2 edits in trunk/Source/WebCore

[FrameView::layout cleanup] Move text auto sizing logic to a separate function
​https://bugs.webkit.org/show_bug.cgi?id=178391
<rdar://problem/35030264>

Reviewed by Antti Koivisto.

No change in functionality.

• page/FrameView.cpp:

(WebCore::applyTextSizingIfNeeded):
(WebCore::FrameView::layout):

9:20 AM Changeset in webkit [223550] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebCore

[Curl] Forward declaration "class Cookie;" in CookieJarCurl.h should be "struct Cookie;"
​https://bugs.webkit.org/show_bug.cgi?id=178378

Patch by Yoshiaki Jitsukawa <​Yoshiaki.Jitsukawa@sony.com> on 2017-10-17
Reviewed by Per Arne Vollan.

No new tests. No change in behaviors.

• platform/network/curl/CookieJarCurl.h:

9:17 AM Changeset in webkit [223549] by Alan Bujtas

• 2 edits in trunk/Source/WebCore

[FrameView::layout cleanup] Merge InPreLayout blocks
​https://bugs.webkit.org/show_bug.cgi?id=178373

Reviewed by Antti Koivisto.

Remove redundant comment and scoping.

No change in functionality.

• page/FrameView.cpp:

(WebCore::FrameView::layout):

7:40 AM WebKitGTK/2.18.x edited by Carlos Garcia Campos

(diff)

7:39 AM Changeset in webkit [223548] by Carlos Garcia Campos

• 5 edits in releases/WebKitGTK/webkit-2.18

Merge r223043 - Safari 10 /11 problem with if (!await get(something)).
​https://bugs.webkit.org/show_bug.cgi?id=176685

Reviewed by Saam Barati.

JSTests:

• stress/async-await-basic.js:

(awaitEpression.async):

• stress/async-await-syntax.js:

(testTopLevelAsyncAwaitSyntaxSloppyMode.testSyntax):
(prototype.testTopLevelAsyncAwaitSyntaxStrictMode):

Source/JavaScriptCore:

Using unary operator before await lead to count it as identifier.
According to spec ​https://tc39.github.io/ecma262/#sec-async-function-definitions
and Note 1 await is as AwaitExpression and it is allowed to use unary operator

• parser/Parser.cpp:

(JSC::Parser<LexerType>::parsePrimaryExpression):

7:36 AM Changeset in webkit [223547] by Carlos Garcia Campos

• 2 edits in releases/WebKitGTK/webkit-2.18/Source/WebCore

Merge r220861 - [GStreamer] GstStructure shouldn't be handled through GRefPtr
​https://bugs.webkit.org/show_bug.cgi?id=175673

Reviewed by Xabier Rodriguez-Calvar.

• platform/graphics/gstreamer/eme/WebKitCommonEncryptionDecryptorGStreamer.cpp:

(webkitMediaCommonEncryptionDecryptTransformCaps): GstStructure isn't
ref-counted, so it should be handled through the GUniquePtr<GstStructure>
smart pointer.

7:35 AM Changeset in webkit [223546] by Carlos Garcia Campos

• 5 edits in releases/WebKitGTK/webkit-2.18

Merge r221372 - [WPE] Enable MEMORY_SAMPLER
​https://bugs.webkit.org/show_bug.cgi?id=176099

Reviewed by Michael Catanzaro.

.:

Enable the otion at build time by default on Linux (currently
there are only Linux and Mac implementations of this feature).

• Source/cmake/OptionsWPE.cmake:
• Source/cmake/OptionsGTK.cmake:

Source/WebKit:

Enable it at runtime if the environment variable WEBKIT_SAMPLE_MEMORY is set.

• UIProcess/API/wpe/WPEView.cpp:

(WKWPE::m_compositingManagerProxy):

7:34 AM Changeset in webkit [223545] by Carlos Garcia Campos

• 5 edits
  1 move
  1 add
  1 delete in releases/WebKitGTK/webkit-2.18

Merge r221075, r221260 - [WPE] Some event handlers not working.
​https://bugs.webkit.org/show_bug.cgi?id=175864

Reviewed by Michael Catanzaro.

Source/WebCore:

Share the EventHandler implementation with the GTK port and add ifdefs where needed.

Covered by existing tests.

• PlatformGTK.cmake:
• PlatformWPE.cmake:
• page/wpe/EventHandlerWPE.cpp: Removed.
• platform/glib/EventHandlerGlib.cpp: Renamed from Source/WebCore/page/gtk/EventHandlerGtk.cpp.

(WebCore::EventHandler::shouldTurnVerticalTicksIntoHorizontal const):

LayoutTests:

Remove expected failures for tests that now pass, add new expectation
for a test that is failing also on GTK+ and rebaseline a test with
the same expected result than on GTK+.

• platform/wpe/TestExpectations:
• platform/wpe/fast/events/focus-label-legend-elements-with-tab-expected.txt: Added.

7:29 AM Changeset in webkit [223544] by Carlos Garcia Campos

• 2 edits in releases/WebKitGTK/webkit-2.18/Source/WebKit

Merge r220585 - [WPE] Build failure with Clang 4.0.1: no matching conversion for functional-style cast from 'pointer' (aka 'unsigned short *') to 'WTF::String'
​https://bugs.webkit.org/show_bug.cgi?id=175477

Reviewed by Žan Doberšek.

• Shared/wpe/WebEventFactory.cpp:

(WebKit::singleCharacterStringForKeyEvent): Cast to UChar* to make
compiler choose the correct WTF::String constructor.

7:27 AM Changeset in webkit [223543] by Carlos Garcia Campos

• 17 edits in releases/WebKitGTK/webkit-2.18

Merge r220595 - [CMake] Fix broken use of REQUIRED with find modules
​https://bugs.webkit.org/show_bug.cgi?id=175427

Reviewed by Michael Catanzaro.

Module name passed to find_package_handle_standard_args() must exactly
match file name of CMake find module including letter case, e.g. "WebP"
must be used in FindWebP.cmake file. Otherwise find_package() arguments
(REQUIRED, QUIET, version) are not processed correctly.

To continue using old XXX_FOUND variables without case changes porting
to new find_package_handle_standard_args syntax which has FOUND_VAR
parameter. Unfortunately, variable name GTK_UNIX_PRINT_FOUND is not
allowed by find_package_handle_standard_args when package name is
GTKUnixPrint, so it's replaced to GTKUnixPrint_FOUND (default).

• Source/cmake/FindGTKUnixPrint.cmake:
• Source/cmake/FindGeoClue2.cmake:
• Source/cmake/FindHyphen.cmake:
• Source/cmake/FindLibEpoxy.cmake:
• Source/cmake/FindLibGBM.cmake:
• Source/cmake/FindLibsecret.cmake:
• Source/cmake/FindLibtasn1.cmake:
• Source/cmake/FindLibxkbcommon.cmake:
• Source/cmake/FindOpenGL.cmake:
• Source/cmake/FindOpenGLES2.cmake:
• Source/cmake/FindOpenWebRTC.cmake:
• Source/cmake/FindWPEBackend-mesa.cmake:
• Source/cmake/FindWPEBackend.cmake:
• Source/cmake/FindWayland.cmake:
• Source/cmake/FindWebP.cmake:
• Source/cmake/OptionsGTK.cmake:

7:25 AM Changeset in webkit [223542] by Carlos Garcia Campos

• 2 edits in releases/WebKitGTK/webkit-2.18/Source/WebKit

Merge r223143 - CSS constant properties should not be enabled by default
​https://bugs.webkit.org/show_bug.cgi?id=177416

Reviewed by Darin Adler.

• Shared/WebPreferencesDefinitions.h:

7:20 AM Changeset in webkit [223541] by Carlos Garcia Campos

• 4 edits in releases/WebKitGTK/webkit-2.18

Merge r223442 - If an origin doesn't have databases in the Databases table we should still remove its information from disk in DatabaseTracker::deleteOrigin()
​https://bugs.webkit.org/show_bug.cgi?id=178281
<rdar://problem/34576132>

Patch by Maureen Daum <​mdaum@apple.com> on 2017-10-16
Reviewed by Brent Fulgham.

Source/WebCore:

New test:
DatabaseTracker.DeleteOriginWithMissingEntryInDatabasesTable

• Modules/webdatabase/DatabaseTracker.cpp:

(WebCore::DatabaseTracker::deleteOrigin):
If databaseNames is empty, don't bail early. Instead, delete everything in the directory
containing the databases for this origin. This condition indicates that we previously
tried to remove the origin but didn't get all of the way through the deletion process.
Because we have lost track of the databases for this origin, we can assume that no
other process is accessing them. This means it should be safe to delete them outright.

Tools:

Verify that if there is an entry in the Origins table but no entries in the Databases
table that we still remove the directory for the origin, and that we remove the
entry from the Origins table.

• TestWebKitAPI/Tests/WebCore/cocoa/DatabaseTrackerTest.mm:

(TestWebKitAPI::TEST):

7:19 AM Changeset in webkit [223540] by Carlos Garcia Campos

• 2 edits in releases/WebKitGTK/webkit-2.18/Source/WebCore

Merge r223438 - Unreviewed attempt to fix the Windows debug build.

• Modules/webdatabase/DatabaseTracker.cpp:

(WebCore::DatabaseTracker::deleteOrigin):

7:19 AM Changeset in webkit [223539] by Carlos Garcia Campos

• 5 edits
  1 add
  1 delete in releases/WebKitGTK/webkit-2.18

Merge r223427 - If we fail to delete any database file, don't remove its information from the tracker database
<rdar://problem/34576132> and ​https://bugs.webkit.org/show_bug.cgi?id=178251

Patch by Maureen Daum <​mdaum@apple.com> on 2017-10-16
Reviewed by Brady Eidson.

Source/WebCore:

New tests:
DatabaseTracker.DeleteDatabase
DatabaseTracker.DeleteDatabaseWhenDatabaseDoesNotExist
DatabaseTracker.DeleteOrigin
DatabaseTracker.DeleteOriginWhenDeletingADatabaseFails
DatabaseTracker.DeleteOriginWhenDatabaseDoesNotExist

• Modules/webdatabase/DatabaseTracker.cpp:

(WebCore::DatabaseTracker::deleteDatabasesModifiedSince):
If the database doesn't exist, we previously deleted it but failed to remove the
information from the tracker database. We still want to delete all of the information
associated with this database from the tracker database, so add it to databaseNamesToDelete.
(WebCore::DatabaseTracker::deleteOrigin):
If a database doesn't exist, don't try to delete it. We don't need to, but more
importantly, deleteDatabaseFile() will fail if the database doesn't exist, which
will cause us to incorrectly think we failed to remove database information from disk.
If we actually fail to delete any database file, return before we remove the origin
information from the tracker database so we don't lose track of the database.
(WebCore::DatabaseTracker::deleteDatabase):
If a database doesn't exist, don't try to delete it. We don't need to, but also it
will cause us to incorrectly think that we were unable to delete a database, so we
would bail before we remove the database information from the tracker database. We
want to remove the database information from the tracker database because the database
doesn't exist.

• Modules/webdatabase/DatabaseTracker.h:

Expose fullPathForDatabase() for use by tests.

• platform/Logging.h:

Add a logging channel.

Tools:

Add tests that verify we correctly delete databases and remove their information from
the tracker database, even if the database doesn't exist. Verify that if we fail to
delete a database, we don't remove its information from the tracker database.

• TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:

Move DatabaseTrackerTest.cpp to DatabaseTrackerTest.mm so that we can use the cocoa
method for creating a temporary directory in the tests.

• TestWebKitAPI/Tests/WebCore/DatabaseTrackerTest.cpp: Removed.

The existing test was copied to DatabaseTrackerTest.mm.

• TestWebKitAPI/Tests/WebCore/cocoa/DatabaseTrackerTest.mm: Added.

(TestWebKitAPI::TEST):
(TestWebKitAPI::addToDatabasesTable):
(TestWebKitAPI::removeDirectoryAndAllContents):
(TestWebKitAPI::createFileAtPath):

7:18 AM Changeset in webkit [223538] by Carlos Garcia Campos

• 2 edits in releases/WebKitGTK/webkit-2.18/Source/WebCore

Merge r223423 - We should wrap the removal of information from the tracker database in a transaction in DatabaseTracker::deleteOrigin()
​https://bugs.webkit.org/show_bug.cgi?id=178274
<rdar://problem/34576132>

Patch by Maureen Daum <​mdaum@apple.com> on 2017-10-16
Reviewed by Tim Horton.

• Modules/webdatabase/DatabaseTracker.cpp:

(WebCore::DatabaseTracker::deleteOrigin):
Wrap the removal of information from the tracker database in a transaction so that
we don't end up in a case where only one of the tables contains information about
an origin.
If anything goes wrong when we're modifying the tracker database, rollback the transaction
before bailing.

7:07 AM Changeset in webkit [223537] by Carlos Garcia Campos

• 2 edits in releases/WebKitGTK/webkit-2.18/Source/WebKit

Merge r223416 - [WPE] Build failure due to invalid cast of EGLNativeWindowType when targetting 64-bit ARM
​https://bugs.webkit.org/show_bug.cgi?id=178090

Reviewed by Michael Catanzaro.

EGLNativeWindowType can be aliased to a different type depending (at least) on the EGL
implementation, its build options, and the libepoxy build options. Using "static_cast"
works when it is a numeric value and the width of the value needs to be optionally
extended to 64 bits (e.g. the EGL type is "int" in a 32-bit CPU) but not for pointers,
and using "reinterpret_cast" works when the size of a pointer is 64 bits but not in other
cases. Therefore it seems reasonable to use a plain C cast expression to solve this
particular situation.

• WebProcess/WebPage/wpe/AcceleratedSurfaceWPE.cpp:

(WebKit::AcceleratedSurfaceWPE::window const): Use a good old plain C cast expression.

6:54 AM Changeset in webkit [223536] by nael.ouedraogo@crf.canon.fr

• 4 edits in trunk/Tools

[GStreamer][GTK][WPE] update-webkit-libs-jhbuild fails to detect changes in included moduleset files
​https://bugs.webkit.org/show_bug.cgi?id=178206

Reviewed by Michael Catanzaro.

The update-webkit-libs-jhbuild scripts computes MD5 sum of GTK/WPE jhbuild configuration files to check if it
needs to rebuild the dependencies libraries. This patch fixes a bug when main GTK/WPE jhbuild modules
configuration file includes additional files (for example GStreamer module). It parses jhbuild.modules file to
check if additional files are included. If any, it computes MD5 sum for each of these included files.

• Scripts/update-webkit-libs-jhbuild:

(getJhbuildIncludedFilePaths): New function that returns included files in jhbuild.modules
(jhbuildConfigurationCheckFile): New function to check if MD5 sum file changes.
(jhbuildConfigurationChanged): Add MD5 sum check for included files.
(saveMd5File): New function to save MD5 sum of a file.
(saveJhbuildMd5): Add saving included files MD5 sum.
(deleteJhbuildMd5): Delete included files MD5 sum

• gtk/install-dependencies: Add perl-libXML lib that is used to parse jhbuild file.
• wpe/install-dependencies: Ditto.

6:14 AM Changeset in webkit [223535] by Carlos Garcia Campos

• 2 edits in releases/WebKitGTK/webkit-2.18

Merge r223313 - Protect FrameView during style calculations
​https://bugs.webkit.org/show_bug.cgi?id=178300
<rdar://problem/34869329>

Reviewed by Ryosuke Niwa.

Source/WebCore:

Protect the FrameView during layout and style updates in case arbitrary script
is run that might clear it.

Test: fast/html/marquee-reparent-check.html

• page/FrameView.cpp:

(WebCore::FrameView::updateLayoutAndStyleIfNeededRecursive):

LayoutTests:

• fast/html/marquee-reparent-check-expected.txt: Added.
• fast/html/marquee-reparent-check.html: Added.

6:05 AM Changeset in webkit [223534] by Carlos Garcia Campos

• 5 edits
  2 adds in releases/WebKitGTK/webkit-2.18

Merge r223210 - Avoid triggering layout from style change
​https://bugs.webkit.org/show_bug.cgi?id=178184
Source/WebCore:

rdar://problem/34699113

Reviewed by Zalan Bujtas.

It's bad for RenderBox::styleDidChange() to scroll RenderLayers, because that
can trigger layout via FrameView::updateWidgetPositions() and ScrollingCoordinator::absoluteEventTrackingRegions().
So postpone the scrolling until after layout.

Test: fast/scrolling/adjust-scroll-offset-on-zoom.html

• rendering/RenderBox.cpp:

(WebCore::RenderBox::styleDidChange):

• rendering/RenderLayer.cpp:

(WebCore::RenderLayer::updateLayerPositions):
(WebCore::RenderLayer::setPostLayoutScrollPosition):
(WebCore::RenderLayer::applyPostLayoutScrollPositionIfNeeded):

• rendering/RenderLayer.h:

LayoutTests:

Reviewed by Zalan Bujtas.

• fast/scrolling/adjust-scroll-offset-on-zoom-expected.txt: Added.
• fast/scrolling/adjust-scroll-offset-on-zoom.html: Added.

5:51 AM Changeset in webkit [223533] by Carlos Garcia Campos

• 6 edits
  2 adds in releases/WebKitGTK/webkit-2.18

Merge r223190 - [ATK] Expose value of aria-keyshortcuts as object attribute
​https://bugs.webkit.org/show_bug.cgi?id=171175

Reviewed by Chris Fleizach.

Source/WebCore:

Expose the author-provided string through the "keyshortcuts" object attribute.

Test: accessibility/gtk/aria-keyshortcuts.html

• accessibility/AccessibilityObject.cpp:

(WebCore::AccessibilityObject::ariaKeyShortcutsValue const):

• accessibility/AccessibilityObject.h:
• accessibility/atk/WebKitAccessibleWrapperAtk.cpp:

(webkitAccessibleGetAttributes):

• html/HTMLAttributeNames.in:

LayoutTests:

• accessibility/gtk/aria-keyshortcuts-expected.txt: Added.
• accessibility/gtk/aria-keyshortcuts.html: Added.

5:32 AM Changeset in webkit [223532] by Carlos Garcia Campos

• 2 edits in releases/WebKitGTK/webkit-2.18/Source/WebCore

Merge r223168 - [GStreamer] Fix double seek requested by downloadbuffer GStreamer element in webkibwebsrc
​https://bugs.webkit.org/show_bug.cgi?id=178079

Reviewed by Žan Doberšek.

When the downloadbuffer GStreamer element requests two seeks too
close to each other there's some rare race condition where our
source answers that it is not seekable and ends up with
downloadbuffer element to seek beyond the file size, which causes
the server to issue a 416 HTTP error code eventually, causing our
MediaPlayer to stop.

• platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:

(webKitWebSrcStop): We only unset he seekable attribute if we are
not seeking.

5:29 AM Changeset in webkit [223531] by Carlos Garcia Campos

• 4 edits in releases/WebKitGTK/webkit-2.18

Merge r223162 - [WPE] Remove the possibility of installing the old WebKit2 C API
​https://bugs.webkit.org/show_bug.cgi?id=178125

Reviewed by Michael Catanzaro.

.:

• Source/cmake/OptionsWPE.cmake: Remove definition of the EXPORT_DEPRECATED_WEBKIT2_C_API

build option.

Source/WebKit:

• PlatformWPE.cmake: Remove support for installing the deprecated C API.

5:26 AM Changeset in webkit [223530] by Carlos Garcia Campos

• 2 edits in releases/WebKitGTK/webkit-2.18

Merge r223152 - [WPE] Expose ENABLE_XSLT option
​https://bugs.webkit.org/show_bug.cgi?id=177857

Reviewed by Carlos Alberto Lopez Perez.

• Source/cmake/OptionsWPE.cmake:

5:26 AM Changeset in webkit [223529] by Carlos Garcia Campos

• 2 edits in releases/WebKitGTK/webkit-2.18/Source/WebKit

Merge r223146 - [WPE] Header cairo.h is used in GLib API headers but cannot be found
​https://bugs.webkit.org/show_bug.cgi?id=178100

Reviewed by Michael Catanzaro.

• wpe/wpe-webkit.pc.in: Add Cairo to the "Requires" field, so its flags get pulled

in and the "cairo.h", used in the WPE WebKit GLib API headers, can be found.

5:25 AM Changeset in webkit [223528] by Carlos Garcia Campos

• 6 edits in releases/WebKitGTK/webkit-2.18

Merge r223145 - AX: [ATK] ARIA form role should be mapped to ATK_ROLE_LANDMARK; not ATK_ROLE_FORM
​https://bugs.webkit.org/show_bug.cgi?id=178137

Reviewed by Chris Fleizach.

Source/WebCore:

Expose the ARIA form role as ATK_ROLE_LANDMARK; continue to expose the HTML form
element as ATK_ROLE_FORM.

No new tests needed due to existing coverage. Update expectations for roles-exposed.html.

• accessibility/atk/WebKitAccessibleWrapperAtk.cpp:

(atkRole):

Tools:

Add handling for ATK_ROLE_LANDMARK resulting from the ARIA form role.

• WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:

LayoutTests:

• platform/gtk/accessibility/roles-exposed-expected.txt: Updated expectations.

5:23 AM Changeset in webkit [223527] by Carlos Garcia Campos

• 2 edits in releases/WebKitGTK/webkit-2.18/Source/WebKit

Merge r223133 - [WPE] Cannot link against libWPEWebkit due to wrong contents of wpe-webkit.pc
​https://bugs.webkit.org/show_bug.cgi?id=178133

Reviewed by Žan Doberšek.

• wpe/wpe-webkit.pc.in: Remove "-lWPE" and replace "Requires.private" with a plain "Requires".

5:21 AM Changeset in webkit [223526] by Carlos Garcia Campos

• 2 edits in releases/WebKitGTK/webkit-2.18/Source/WebKit

Merge r223129 - [WPE] GLib API headers WebKitScriptDialog.h and WebKitFileChooserRequest.h are not installed
​https://bugs.webkit.org/show_bug.cgi?id=178104

Reviewed by Žan Doberšek.

• PlatformWPE.cmake: Add missing header paths to the WPE_API_INSTALLED_HEADERS variable.

5:18 AM Changeset in webkit [223525] by Carlos Garcia Campos

• 2 edits in releases/WebKitGTK/webkit-2.18/Source/WebKit

Merge r223128 - [WPE][CMake] The “install” target should install all public API headers
​https://bugs.webkit.org/show_bug.cgi?id=176475

Reviewed by Žan Doberšek.

Install the WPE port GLib-based API headers. The deprecated C API is still available,
but disabled by default behind the "EXPORT_DEPRECATED_WEBKIT2_C_API" CMake option.

• PlatformWPE.cmake: Always install "wpe-webkit.pc" and the GLib C API for WPE.

5:15 AM Changeset in webkit [223524] by Carlos Garcia Campos

• 5 edits
  2 adds in releases/WebKitGTK/webkit-2.18

Merge r223126 - AX: [ATK] STATE_CHECKABLE should be removed from radio buttons in radiogroups with aria-readonly="true"
​https://bugs.webkit.org/show_bug.cgi?id=177931

Reviewed by Chris Fleizach.

Source/WebCore:

Add a check in canSetValueAttribute() for readonly radiogroup ancestors of
radio buttons.

Test: accessibility/gtk/aria-readonly-radiogroup.html

• accessibility/AccessibilityNodeObject.cpp:

(WebCore::AccessibilityNodeObject::canSetValueAttribute const):

• accessibility/AccessibilityObject.cpp:

(WebCore::AccessibilityObject::radioGroupAncestor const):

• accessibility/AccessibilityObject.h:

LayoutTests:

• accessibility/gtk/aria-readonly-radiogroup-expected.txt: Added.
• accessibility/gtk/aria-readonly-radiogroup.html: Added.

5:02 AM Changeset in webkit [223523] by Yusuke Suzuki

• 36 edits
  13 adds in trunk

[JSC] proto getter should be fast
​https://bugs.webkit.org/show_bug.cgi?id=178067

Reviewed by Saam Barati.

JSTests:

• stress/dfg-object-proto-accessor.js: Added.

(shouldBe):
(shouldThrow):
(target):

• stress/dfg-object-proto-getter.js: Added.

(shouldBe):
(shouldThrow):
(target):

• stress/dfg-object-prototype-of.js: Added.

(shouldBe):
(shouldThrow):
(target):

• stress/dfg-reflect-get-prototype-of.js: Added.

(shouldBe):
(shouldThrow):
(target):

• stress/object-get-prototype-of-filtered.js: Added.

(shouldBe):
(shouldThrow):
(target):
(i.Cocoa):

• stress/object-get-prototype-of-mono-proto.js: Added.

(shouldBe):
(makePolyProtoObject.foo.C):
(makePolyProtoObject.foo):
(makePolyProtoObject):
(target):

• stress/object-get-prototype-of-poly-mono-proto.js: Added.

(shouldBe):
(makePolyProtoObject.foo.C):
(makePolyProtoObject.foo):
(makePolyProtoObject):
(target):

• stress/object-get-prototype-of-poly-proto.js: Added.

(shouldBe):
(makePolyProtoObject.foo.C):
(makePolyProtoObject.foo):
(makePolyProtoObject):
(target):

• stress/object-proto-getter-filtered.js: Added.

(shouldBe):
(shouldThrow):
(target):
(i.Cocoa):

• stress/object-proto-getter-poly-mono-proto.js: Added.

(shouldBe):
(makePolyProtoObject.foo.C):
(makePolyProtoObject.foo):
(makePolyProtoObject):
(target):

• stress/object-proto-getter-poly-proto.js: Added.

(shouldBe):
(makePolyProtoObject.foo.C):
(makePolyProtoObject.foo):
(makePolyProtoObject):
(target):

• stress/object-prototype-proto-accessors-should-throw-on-undefined-this.js:
• stress/string-proto.js: Added.

(shouldBe):
(target):

Source/JavaScriptCore:

In our ES6 class implementation, we access proto field to retrieve super constructor.
Currently, it is handled as an usual getter call to a generic function. And DFG just emits
Call node for this. It is inefficient since typically we know the prototype of the given
object when accessing object.__proto__ since we emit CheckStructure for this object.
If Structure has mono proto, we can immediately fold it to constant value. If it is poly proto,
we can still change this to efficient access to poly proto slot.

This patch implements GetPrototypeOf DFG node. This node efficiently accesses to prototype of
the given object. And in AI and ByteCodeParser phase, we attempt to fold it to constant.
ByteCodeParser's folding is a bit important since we have callee.__proto__ code to get super
constructor. If we can change this to constant, we can reify CallLinkInfo with this constant.
This paves the way to optimizing ArrayConstructor super calls[1], which is particularly important
for ARES-6 ML.

And we also optimize Reflect.getPrototypeOf and Object.getPrototypeOf with this GetPrototypeOf node.

Currently, proto access for poly proto object is not handled well in IC. But we add code handling
poly proto in GetPrototypeOf since Reflect.getPrototypeOf and Object.getPrototypeOf can use it.
Once IC starts handling poly proto & intrinsic getter well, this code will be used for that too.

This patch improves SixSpeed super.es6 by 3.42x.

baseline patched

super.es6 123.6666+-3.9917 ^{36.1684+-1.0351} definitely 3.4192x faster

[1]: ​https://bugs.webkit.org/show_bug.cgi?id=178064

• dfg/DFGAbstractInterpreterInlines.h:

(JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):

• dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::handleIntrinsicCall):
(JSC::DFG::ByteCodeParser::handleIntrinsicGetter):
(JSC::DFG::ByteCodeParser::handleGetById):

• dfg/DFGClobberize.h:

(JSC::DFG::clobberize):

• dfg/DFGDoesGC.cpp:

(JSC::DFG::doesGC):

• dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode):
(JSC::DFG::FixupPhase::fixupGetPrototypeOf):

• dfg/DFGHeapLocation.cpp:

(WTF::printInternal):

• dfg/DFGHeapLocation.h:
• dfg/DFGNode.h:

(JSC::DFG::Node::hasHeapPrediction):
(JSC::DFG::Node::shouldSpeculateFunction):

• dfg/DFGNodeType.h:
• dfg/DFGOperations.cpp:
• dfg/DFGOperations.h:
• dfg/DFGPredictionPropagationPhase.cpp:
• dfg/DFGSafeToExecute.h:

(JSC::DFG::safeToExecute):

• dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::speculateFunction):
(JSC::DFG::SpeculativeJIT::speculateFinalObject):
(JSC::DFG::SpeculativeJIT::compileGetPrototypeOf):

• dfg/DFGSpeculativeJIT.h:
• dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

• dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

• ftl/FTLCapabilities.cpp:

(JSC::FTL::canCompile):

• ftl/FTLLowerDFGToB3.cpp:

(JSC::FTL::DFG::LowerDFGToB3::compileNode):
(JSC::FTL::DFG::LowerDFGToB3::compileGetPrototypeOf):
(JSC::FTL::DFG::LowerDFGToB3::compileInstanceOf):

• jit/IntrinsicEmitter.cpp:

(JSC::IntrinsicGetterAccessCase::canEmitIntrinsicGetter):
(JSC::IntrinsicGetterAccessCase::emitIntrinsicGetter):

• runtime/Intrinsic.cpp:

(JSC::intrinsicName):

• runtime/Intrinsic.h:
• runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::init):

• runtime/JSGlobalObjectFunctions.cpp:

(JSC::globalFuncProtoGetter):

• runtime/JSGlobalObjectFunctions.h:
• runtime/ObjectConstructor.cpp:
• runtime/ReflectObject.cpp:

LayoutTests:

• js/object-literal-shorthand-construction-expected.txt:
• js/script-tests/object-literal-shorthand-construction.js:

(set 2):
(get 1):

• js/script-tests/sloppy-getter-setter-global-object.js:
• js/sloppy-getter-setter-global-object-expected.txt:

4:49 AM Changeset in webkit [223522] by Carlos Garcia Campos

• 6 edits
  2 adds in releases/WebKitGTK/webkit-2.18

AX: [ATK] Explicitly-set aria-sort value of "none" should be exposed as an object attribute
​https://bugs.webkit.org/show_bug.cgi?id=177955

Reviewed by Chris Fleizach.

Source/WebCore:

Expose "none" as the value of aria-sort when the attribute is present and not
one of the other valid sort types. Also add a new AccessibilitySortDirection,
SortDirectionInvalid. This is currently only being used when the sort direction
is sought for a role which does not support this ARIA attribute, but might come
in handy if we want to add further sanity checks on the author-provided values.

Test: accessibility/gtk/aria-sort-values.html

• accessibility/AccessibilityObject.cpp:

(WebCore::AccessibilityObject::sortDirection const):

• accessibility/AccessibilityObject.h:
• accessibility/atk/WebKitAccessibleWrapperAtk.cpp:

(webkitAccessibleGetAttributes):

• accessibility/mac/WebAccessibilityObjectWrapperMac.mm:

(-[WebAccessibilityObjectWrapper additionalAccessibilityAttributeNames]):

LayoutTests:

• accessibility/gtk/aria-sort-values-expected.txt: Added.
• accessibility/gtk/aria-sort-values.html: Added.

4:44 AM Changeset in webkit [223521] by Carlos Garcia Campos

• 6 edits in releases/WebKitGTK/webkit-2.18

Merge r223045 - [WPE][GTK] Propagate libepoxy compiler flags obtained from pkg-config
​https://bugs.webkit.org/show_bug.cgi?id=178081

Reviewed by Carlos Alberto Lopez Perez.

.:

• Source/cmake/FindLibEpoxy.cmake: Define the ${LIBEPOXY_DEFINITIONS} variable when libepoxy

is found by pkg-config. This contains the value of the "Cflags" field from "epoxy.pc".

Source/WebCore:

No new tests needed.

• CMakeLists.txt: Use ${LIBEPOXY_DEFINITIONS} for building WebCore.

Source/WebKit:

• CMakeLists.txt: Use ${LIBEPOXY_DEFINITIONS} for building WebKit.

4:42 AM Changeset in webkit [223520] by Carlos Garcia Campos

• 3 edits
  2 adds in releases/WebKitGTK/webkit-2.18

Merge r223028 - Nullptr deref in WebCore::Node::computeEditability
​https://bugs.webkit.org/show_bug.cgi?id=177905
<rdar://problem/34138402>

Reviewed by Darin Adler.

Source/WebCore:

Script can run when setting focus, because a blur event and a focus event are generated.
A handler for one of these events can cause the focused element to be cleared. We should
handle this possibility gracefully.

Test: fast/dom/focus-shift-crash.html

• dom/Document.cpp:

(WebCore::Document::setFocusedElement):

LayoutTests:

• fast/dom/focus-shift-crash-expected.txt: Added.
• fast/dom/focus-shift-crash.html: Added.

4:37 AM Changeset in webkit [223519] by Carlos Garcia Campos

• 6 edits
  1 delete in releases/WebKitGTK/webkit-2.18/Source/bmalloc

Merge r222982 - Use one Scavenger thread for all Heaps
​https://bugs.webkit.org/show_bug.cgi?id=174973

Reviewed by JF Bastien.

This combines the scavengers from all Heap instances into a single scavenger. It also combines
the accounting for deciding when to run. Each Heap still controls what it means to scavenge
itself (it's all in Heap::scavenge) but the policy decisions are all controlled by Scavenger.
Because Scavenger is also the only thing that needs an AsyncTask, this removes AsyncTask and
moves all of AsyncTask's logic into Scavenger.

This appears to be a 1% progression on JetStream (with high statistical confidence: p = 0.0049).

• bmalloc.xcodeproj/project.pbxproj:
• bmalloc/AsyncTask.h: Removed.
• bmalloc/Heap.cpp:

(bmalloc::Heap::Heap):
(bmalloc::Heap::allocateSmallChunk):
(bmalloc::Heap::allocateSmallPage):
(bmalloc::Heap::deallocateSmallLine):
(bmalloc::Heap::splitAndAllocate):
(bmalloc::Heap::tryAllocateLarge):
(bmalloc::Heap::shrinkLarge):
(bmalloc::Heap::deallocateLarge):
(bmalloc::Heap::concurrentScavenge): Deleted.
(bmalloc::Heap::scheduleScavengerIfUnderMemoryPressure): Deleted.
(bmalloc::Heap::scheduleScavenger): Deleted.

• bmalloc/Heap.h:
• bmalloc/Scavenger.cpp:

(bmalloc::Scavenger::Scavenger):
(bmalloc::Scavenger::run):
(bmalloc::Scavenger::runHoldingLock):
(bmalloc::Scavenger::runSoon):
(bmalloc::Scavenger::runSoonHoldingLock):
(bmalloc::Scavenger::didStartGrowing):
(bmalloc::Scavenger::scheduleIfUnderMemoryPressure):
(bmalloc::Scavenger::scheduleIfUnderMemoryPressureHoldingLock):
(bmalloc::Scavenger::schedule):
(bmalloc::Scavenger::threadEntryPoint):
(bmalloc::Scavenger::threadRunLoop):
(bmalloc::Scavenger::setSelfQOSClass):

• bmalloc/Scavenger.h:

(bmalloc::Scavenger::willRun):
(bmalloc::Scavenger::willRunSoon):

4:36 AM Changeset in webkit [223518] by Carlos Garcia Campos

• 2 edits in releases/WebKitGTK/webkit-2.18/Source/JavaScriptCore

Merge r222981 - Avoid integer overflow in DFGStrengthReduction.cpp
​https://bugs.webkit.org/show_bug.cgi?id=177944

Reviewed by Saam Barati.

The check that we won't do integer overflow by negating INT32_MIN was itself an integer overflow.
I think that signed integer overflow is undefined behaviour in C, so I replace it by an explicit check that value != INT32_MIN instead.

• dfg/DFGStrengthReductionPhase.cpp:

(JSC::DFG::StrengthReductionPhase::handleNode):

4:35 AM Changeset in webkit [223517] by Carlos Garcia Campos

• 34 edits
  3 moves
  2 adds in releases/WebKitGTK/webkit-2.18/Source

Merge r222960 - Update Source/ThirdParty/woff2 to 22c256bc457777744ba14b7325a6e8e0e7dec91c
​https://bugs.webkit.org/show_bug.cgi?id=177994

Patch by Frederic Wang <​fwang@igalia.com> on 2017-10-05
Reviewed by Michael Catanzaro.

Source/ThirdParty:

• woff2/CMakeLists.txt: Also consider the directory for public headers.
• woff2/README.webkit:
• woff2/include/woff2/decode.h: Renamed from Source/ThirdParty/woff2/src/woff2_dec.h.
• woff2/include/woff2/encode.h: Renamed from Source/ThirdParty/woff2/src/woff2_enc.h.

(woff2::WOFF2Params::WOFF2Params):

• woff2/include/woff2/output.h: Renamed from Source/ThirdParty/woff2/src/woff2_out.h.

(woff2::WOFF2Out::~WOFF2Out):
(woff2::WOFF2StringOut::MaxSize):

• woff2/src/buffer.h:
• woff2/src/convert_woff2ttf_*.cc:
• woff2/src/file.h:
• woff2/src/font.cc:
• woff2/src/font.h:
• woff2/src/glyph.cc:
• woff2/src/glyph.h:
• woff2/src/normalize.cc:
• woff2/src/normalize.h:
• woff2/src/port.h:
• woff2/src/round.h:
• woff2/src/store_bytes.h:
• woff2/src/table_tags.cc:
• woff2/src/table_tags.h:
• woff2/src/transform.cc:
• woff2/src/transform.h:
• woff2/src/variable_length.cc:
• woff2/src/variable_length.h:
• woff2/src/woff2_common.cc:
• woff2/src/woff2_common.h:
• woff2/src/woff2_compress.cc:
• woff2/src/woff2_dec.cc:
• woff2/src/woff2_decompress.cc:
• woff2/src/woff2_enc.cc:
• woff2/src/woff2_info.cc:
• woff2/src/woff2_out.cc:
• woff2/update.sh: Also consider directory for public headers.

Source/WebCore:

No new tests, already covered by existing tests.

• CMakeLists.txt: Include the directory for public headers instead.
• platform/graphics/WOFFFileFormat.cpp: Use the public header

woff2/decode.h and do not use the "wOF2" constant from private headers.
(WebCore::isWOFF):
(WebCore::convertWOFFToSfnt):

3:44 AM Changeset in webkit [223516] by Carlos Garcia Campos

• 8 edits in releases/WebKitGTK/webkit-2.18/Source

Merge r222945 - bmalloc mutex should be adaptive
​https://bugs.webkit.org/show_bug.cgi?id=177839

Reviewed by Michael Saboff.

Source/bmalloc:

This pulls the WordLock algorithm into bmalloc, mostly by copy-pasting the code. We need to
copy paste because sometimes we build WTF without bmalloc, so WTF cannot rely on bmalloc for
anything other than malloc.

Reland after fixing ancient WordLock bug: the notify_one has to happen with the lock held
to ensure it doesn't run after that thread has died.

• bmalloc/Algorithm.h:

(bmalloc::compareExchangeWeak):
(bmalloc::compareExchangeStrong):

• bmalloc/PerThread.h:
• bmalloc/StaticMutex.cpp:

(bmalloc::StaticMutex::lockSlow):
(bmalloc::StaticMutex::unlockSlow):
(bmalloc::StaticMutex::lockSlowCase): Deleted.

• bmalloc/StaticMutex.h:

(bmalloc::StaticMutex::try_lock):
(bmalloc::StaticMutex::isLocked const):
(bmalloc::StaticMutex::init):
(bmalloc::StaticMutex::tryLock):
(bmalloc::StaticMutex::lock):
(bmalloc::StaticMutex::unlock):
(bmalloc::sleep): Deleted.
(bmalloc::waitUntilFalse): Deleted.

Source/WTF:

Add some comments that I thought of while copy-pasting this code.

Reland after fixing ancient WordLock bug: the notify_one has to happen with the lock held
to ensure it doesn't run after that thread has died.

• wtf/LockAlgorithmInlines.h:
• wtf/WordLock.cpp:

3:43 AM Changeset in webkit [223515] by Carlos Garcia Campos

• 6 edits in releases/WebKitGTK/webkit-2.18

Merge r222930 - Generate a compile error if release is built without compiler optimizations
​https://bugs.webkit.org/show_bug.cgi?id=177665

Reviewed by Brian Burg.

.:

Default to RelWithDebInfo if CMAKE_BUILD_TYPE is unset.

• CMakeLists.txt:

Source/JavaScriptCore:

Pass -DRELEASE_WITHOUT_OPTIMIZATIONS to testair.cpp and testb3.cpp because
this files are compiled with -O0 for build speed reasons after r195639.

• JavaScriptCore.xcodeproj/project.pbxproj:

Source/WTF:

For GCC and Clang, generate an error at build time that will alert
the developer that she is trying to build Release without any compiler
optimization. A build time error is much better than an unexpected
"oh, WebKit is really slow ..." situation later.

If this was intended, then we tell the developer that she can continue
by just setting -DRELEASE_WITHOUT_OPTIMIZATIONS in the list of build
flags.

The intention of this patch is to ensure that nobody builds Release
without enabling compiler optimization by mistake.

• wtf/Compiler.h:

3:18 AM Changeset in webkit [223514] by Antti Koivisto

• 11 edits in trunk

Text nodes with display:contents parent should render as if they were wrapped in an unstyled <span>
​https://bugs.webkit.org/show_bug.cgi?id=178332

Reviewed by Ryosuke Niwa.

Source/WebCore:

According to ​https://github.com/w3c/csswg-drafts/issues/1118

<div style="display:contents;color:green">text</div>

must result in green text even though div doesn't generate a box.

This patch implements the behavior by wrapping text renderers with display:contents parent element
in an anonymous inline box that receives its style by inheriting from the parent element.

• dom/Document.cpp:

(WebCore::Document::updateTextRenderer):

• rendering/RenderElement.cpp:

(WebCore::RenderElement::computeFirstLineStyle const):

Synthesize the first line style in display:contents parent case.

• rendering/RenderObject.cpp:

(WebCore::findDestroyRootIncludingAnonymous):

Factor into a function.

(WebCore::RenderObject::removeFromParentAndDestroyCleaningUpAnonymousWrappers):

Get rid of the anonymous wrapper if it exists.

• rendering/RenderText.cpp:

(WebCore::inlineWrapperForDisplayContentsMap):
(WebCore::RenderText::RenderText):
(WebCore::RenderText::willBeDestroyed):
(WebCore::RenderText::inlineWrapperForDisplayContents):
(WebCore::RenderText::setInlineWrapperForDisplayContents):

Add a weak member (implemented as a rare data map) for holding the wrapper pointer.

(WebCore::RenderText::findByDisplayContentsInlineWrapperCandidate):

Helper to get the text renderer for a wrapper.

• rendering/RenderText.h:
• style/RenderTreeUpdater.cpp:

(WebCore::createTextRenderer):
(WebCore::RenderTreeUpdater::updateTextRenderer):

Create the wrapper if needed.

• style/StyleTreeResolver.cpp:

(WebCore::Style::TreeResolver::resolveComposedTree):

Compute the wrapper style by inheriting from the display:contents parent.

• style/StyleUpdate.h:

(WebCore::Style::TextUpdate::TextUpdate):

LayoutTests:

• TestExpectations: 10 more display:contents tests pass.

3:05 AM Changeset in webkit [223513] by Carlos Garcia Campos

• 5 edits in releases/WebKitGTK/webkit-2.18/Source/WebCore

Merge r222910 - [GTK][WPE] GIFImageDecoder never clears decoded frames even when told to do so
​https://bugs.webkit.org/show_bug.cgi?id=177864

Reviewed by Carlos Garcia Campos.

Fix GIFImageDecoder::clearFrameBufferCache() so it really deletes decoded buffers, and modify
GIFImageDecoder to be able to decode frames that are not requested in the expected order.

Covered by existent tests.

• platform/image-decoders/gif/GIFImageDecoder.cpp:

(WebCore::GIFImageDecoder::findFirstRequiredFrameToDecode):
(WebCore::GIFImageDecoder::frameBufferAtIndex):
(WebCore::GIFImageDecoder::clearFrameBufferCache):

• platform/image-decoders/gif/GIFImageDecoder.h:
• platform/image-decoders/gif/GIFImageReader.cpp:

(GIFImageReader::decode):

• platform/image-decoders/gif/GIFImageReader.h:

(GIFImageReader::frameContext const):

3:02 AM Changeset in webkit [223512] by Carlos Garcia Campos

• 2 edits in releases/WebKitGTK/webkit-2.18/Source/WebCore

Merge r222906 - Align BitmapImage::LargeAnimationCutoff to a megabyte value
​https://bugs.webkit.org/show_bug.cgi?id=177924

Reviewed by Carlos Garcia Campos.

• platform/graphics/BitmapImage.h: Fix the 1014 multiplier used to calculate

the LargeAnimationCutoff value. It was most likely a typo.

3:00 AM Changeset in webkit [223511] by Carlos Garcia Campos

• 28 edits
  15 adds
  5 deletes in releases/WebKitGTK/webkit-2.18/Source/ThirdParty

Merge r222903 - Upgrade Brotli to version 1.0.1 and WOFF2 to latest upstream
​https://bugs.webkit.org/show_bug.cgi?id=177768

Patch by Frederic Wang <​fwang@igalia.com> on 2017-10-05
Reviewed by Michael Catanzaro.

• brotli/CMakeLists.txt:
• brotli/README.webkit:
• brotli/common/constants.h: Added.
• brotli/common/dictionary.bin: Added.
• brotli/common/dictionary.c: Added.
• brotli/common/dictionary.h: Added.
• brotli/common/version.h: Added.
• brotli/dec/Makefile: Removed.
• brotli/dec/bit_reader.c:
• brotli/dec/bit_reader.h:
• brotli/dec/context.h:
• brotli/dec/decode.c:
• brotli/dec/decode.h: Removed.
• brotli/dec/dictionary.c: Removed.
• brotli/dec/dictionary.h: Removed.
• brotli/dec/huffman.c:
• brotli/dec/huffman.h:
• brotli/dec/port.h:

(BrotliDump):
(BrotliRBit):

• brotli/dec/prefix.h:
• brotli/dec/state.c:
• brotli/dec/state.h:
• brotli/dec/transform.h:
• brotli/dec/types.h: Removed.
• brotli/include/brotli/decode.h: Added.
• brotli/include/brotli/encode.h: Added.
• brotli/include/brotli/port.h: Added.
• brotli/include/brotli/types.h: Added.
• brotli/update.sh:
• woff2/CMakeLists.txt:
• woff2/README.webkit:
• woff2/src/buffer.h:

(woff2::Buffer::Buffer):
(woff2::Buffer::Read):

• woff2/src/convert_woff2ttf_*.cc: Added.
• woff2/src/font.cc:
• woff2/src/glyph.cc:
• woff2/src/normalize.cc:
• woff2/src/port.h:
• woff2/src/store_bytes.h:

(woff2::Store16):

• woff2/src/variable_length.cc:
• woff2/src/woff2_common.cc:
• woff2/src/woff2_dec.cc:
• woff2/src/woff2_decompress.cc:
• woff2/src/woff2_enc.cc:
• woff2/src/woff2_info.cc: Added.

2:55 AM Changeset in webkit [223510] by Carlos Garcia Campos

• 5 edits in releases/WebKitGTK/webkit-2.18/Source/WebKit

Merge r222855 - [GTK] WebKit2GTK+ does not handle touchmove and touchend events correctly
​https://bugs.webkit.org/show_bug.cgi?id=158531

Reviewed by Carlos Alberto Lopez Perez.

Do not bypass WebCore event handling when receiving touch events.

Based on a patch by Andre Moreira Magalhaes <Andre Moreira Magalhaes>.
Thanks to Carlos Garnacho <​carlosg@gnome.org> for helping out reviewing the code.

• UIProcess/API/gtk/PageClientImpl.cpp:

(WebKit::PageClientImpl::doneWithTouchEvent): Make sure touchend reaches gesture controller if touchbegin evet got to it.

• UIProcess/API/gtk/WebKitWebViewBase.cpp:

(webkitWebViewBaseTouchEvent): Do not invoke gesture controller directly by bypassing WebCore event handling.

• UIProcess/gtk/GestureController.cpp:

(WebKit::GestureController::reset): Added.
(WebKit::GestureController::handleEvent): Reset gesture controller when touchpadupdate/end is received without touchbegin.
(WebKit::GestureController::Gesture::reset): Added.

• UIProcess/gtk/GestureController.h:

2:53 AM Changeset in webkit [223509] by Carlos Garcia Campos

• 4 edits in releases/WebKitGTK/webkit-2.18/Source/WebCore

Merge r222836 - [GTK][WPE] Fix playback of GIFs
​https://bugs.webkit.org/show_bug.cgi?id=176089

Reviewed by Carlos Garcia Campos.

Allow GIFImageReader to decode again already decoded frames. Thanks to this, we don't
need to delete the GIFImageReader when GIFImageDecoder::clearFrameBufferCache() is
called, and the we don't need the lock to avoid crashes in that situation.

Covered by existent tests.

• platform/image-decoders/gif/GIFImageDecoder.cpp:

(WebCore::GIFImageDecoder::clearFrameBufferCache):
(WebCore::GIFImageDecoder::decode):

• platform/image-decoders/gif/GIFImageDecoder.h:
• platform/image-decoders/gif/GIFImageReader.cpp:

(GIFImageReader::decode):

2:49 AM Changeset in webkit [223508] by Carlos Garcia Campos

• 3 edits
  2 adds in releases/WebKitGTK/webkit-2.18

Merge r222833 - AX: [ATK] aria-pressed="mixed" should be exposed via ATK_STATE_INDETERMINATE
​https://bugs.webkit.org/show_bug.cgi?id=177807

Reviewed by Chris Fleizach.

Source/WebCore:

Include toggle buttons in the element types for which the mixed state is checked
and exposed via ATK_STATE_INDETERMINATE if found. Also only do the role checks when
AccessibilityObject::isIndeterminate() has returned false.

Test: accessibility/gtk/aria-pressed-mixed-value.html

• accessibility/atk/WebKitAccessibleWrapperAtk.cpp:

(setAtkStateSetFromCoreObject):

LayoutTests:

• accessibility/gtk/aria-pressed-mixed-value-expected.txt: Added.
• accessibility/gtk/aria-pressed-mixed-value.html: Added.

2:48 AM Changeset in webkit [223507] by Carlos Garcia Campos

• 4 edits
  1 add in releases/WebKitGTK/webkit-2.18

Merge r222832 - AX: [ATK] ARIA tabpanel role should be exposed as ATK_ROLE_SCROLL_PANE
​https://bugs.webkit.org/show_bug.cgi?id=177815

Reviewed by Chris Fleizach.

Source/WebCore:

Change the mapping of TabPanelRole from ATK_ROLE_PANEL to ATK_ROLE_SCROLL_PANE.

No new tests because this mapping is already covered by aria-tab-roles.html and
roles-exposed.html. The platform expectations for each test have been updated.

• accessibility/atk/WebKitAccessibleWrapperAtk.cpp:

(atkRole):

LayoutTests:

Updated expectations to reflect new mapping.

• platform/gtk/accessibility/aria-tab-roles-expected.txt: Added.
• platform/gtk/accessibility/roles-exposed-expected.txt: Updated.

2:47 AM Changeset in webkit [223506] by Carlos Garcia Campos

• 3 edits in releases/WebKitGTK/webkit-2.18/Source/WebCore

Merge r222823 - Move scroll snap point unregistration from willBeRemovedFromTree to willBeDestroyed
​https://bugs.webkit.org/show_bug.cgi?id=177830
<rdar://problem/34796065>

Reviewed by Antti Koivisto.

willBeRemovedFromTree is called conditionally, relying on unregistering objects in there is highly error prone.

Covered by existing tests.

• rendering/RenderBox.cpp:

(WebCore::RenderBox::willBeDestroyed):
(WebCore::RenderBox::willBeRemovedFromTree): Deleted.

• rendering/RenderBox.h:

2:40 AM Changeset in webkit [223505] by commit-queue@webkit.org

• 7 edits in trunk

[MSE][GStreamer] Insert parser elements in AppendPipeline when demuxing opus or Vorbis
​https://bugs.webkit.org/show_bug.cgi?id=178076

Patch by Alicia Boya García <​aboya@igalia.com> on 2017-10-17
Reviewed by Xabier Rodriguez-Calvar.

YouTube does not include durations in the WebM container for files
containing Opus audio, so we need to read them from the contained
stream. Fortunately, GStreamer has an element to do that: opusparse.

The same thing happens with Vorbis contained in WebM files from the
W3C tests, which should also be fixed by the GStreamer element
vorbisparse.

This patch adds an opusparse or vorbisparse element to the
AppendPipeline at the sinkpad of the demuxer when either is found.

Tests: updated expectations.

Source/WebCore:

• platform/graphics/gstreamer/mse/AppendPipeline.cpp:

(WebCore::AppendPipeline::appsinkNewSample):
(WebCore::createOptionalParserForFormat):
(WebCore::AppendPipeline::connectDemuxerSrcPadToAppsinkFromAnyThread):
(WebCore::AppendPipeline::disconnectDemuxerSrcPadFromAppsinkFromAnyThread):

• platform/graphics/gstreamer/mse/AppendPipeline.h:
• platform/graphics/gstreamer/mse/GStreamerMediaSample.cpp:

(WebCore::GStreamerMediaSample::GStreamerMediaSample):

• platform/graphics/gstreamer/mse/PlaybackPipeline.cpp:

(WebCore::PlaybackPipeline::attachTrack):

LayoutTests:

• platform/gtk/TestExpectations:

2:39 AM Changeset in webkit [223504] by Carlos Garcia Campos

• 3 edits
  2 adds in releases/WebKitGTK/webkit-2.18

Merge r222822 - AX: [ATK] ARIA menuitems should be exposed with ATK_ROLE_MENU_ITEM even when it's the child of group role
​https://bugs.webkit.org/show_bug.cgi?id=177811

Reviewed by Chris Fleizach.

Source/WebCore:

AccessibilityNodeObject::remapAriaRoleDueToParent() remaps ARIA menuitems to the
MenuButtonRole AccessibilityRole when the menuitem's parent is an ARIA group, but
the ATK code was not handling that remapped role value. As a result, the element
was being exposed as ATK_ROLE_UNKNOWN. Add MenuButtonRole to the AccessibilityRole
types exposed as ATK_ROLE_MENU_ITEM.

Test: accessibility/gtk/menu-with-group-child-tree.html

• accessibility/atk/WebKitAccessibleWrapperAtk.cpp:

(atkRole):

LayoutTests:

• accessibility/gtk/menu-with-group-child-tree-expected.txt: Added.
• accessibility/gtk/menu-with-group-child-tree.html: Added.

2:38 AM Changeset in webkit [223503] by Carlos Garcia Campos

• 3 edits
  2 adds in releases/WebKitGTK/webkit-2.18

Merge r222821 - AX: [ATK] aria-rowindex set on row element is not being exposed
​https://bugs.webkit.org/show_bug.cgi?id=177821

Reviewed by Chris Fleizach.

Source/WebCore:

Expose the value of aria-rowindex when set on a row as an object
attribute, as we already do when it's set on a cell.

Test: accessibility/gtk/aria-rowindex-on-row.html

• accessibility/atk/WebKitAccessibleWrapperAtk.cpp:

(webkitAccessibleGetAttributes):

LayoutTests:

• accessibility/gtk/aria-rowindex-on-row-expected.txt: Added.
• accessibility/gtk/aria-rowindex-on-row.html: Added.

2:38 AM Changeset in webkit [223502] by tpopela@redhat.com

• 2 edits in trunk/Tools

Undefined WK_API_ENABLED warning when compiling COCOA content on WebKitGTK+
​https://bugs.webkit.org/show_bug.cgi?id=178208

Check whether we are on COCOA platform before checking for
WK_API_ENABLED.

Reviewed by Ryosuke Niwa.

• WebKitTestRunner/TestController.cpp:

(WTR::TestController::clearDOMCache):

2:30 AM Changeset in webkit [223501] by Ms2ger@igalia.com

• 4 edits in trunk/Source/WebCore

Add WebGL2 texImage3D overloads.
​https://bugs.webkit.org/show_bug.cgi?id=178119

Reviewed by Ryosuke Niwa.

No new tests: not much point in adding tests now; this method doesn't
do anything anyway.

• html/canvas/WebGL2RenderingContext.cpp:

(WebCore::WebGL2RenderingContext::texImage3D):

• html/canvas/WebGL2RenderingContext.h:
• html/canvas/WebGL2RenderingContext.idl:

2:21 AM Changeset in webkit [223500] by Antti Koivisto

• 11 edits in trunk/Source/WebCore

Resolve ::before and ::after pseudo elements during style resolution
​https://bugs.webkit.org/show_bug.cgi?id=178339

Reviewed by Ryosuke Niwa.

They are currently resolved during render tree building which creates problems with display:contents and animations.

• dom/PseudoElement.cpp:

(WebCore::PseudoElement::PseudoElement):

Call InspectorInstrumentation from constructor.

• style/RenderTreeUpdater.cpp:

(WebCore::RenderTreeUpdater::Parent::Parent):
(WebCore::RenderTreeUpdater::updateRenderTree):
(WebCore::RenderTreeUpdater::pushParent):

Push the full update to the parent stack.

(WebCore::RenderTreeUpdater::popParent):
(WebCore::RenderTreeUpdater::updateBeforeDescendants):
(WebCore::RenderTreeUpdater::updateAfterDescendants):
(WebCore::RenderTreeUpdater::invalidateWhitespaceOnlyTextSiblingsAfterAttachIfNeeded):

• style/RenderTreeUpdater.h:
• style/RenderTreeUpdaterGeneratedContent.cpp:

(WebCore::RenderTreeUpdater::GeneratedContent::updatePseudoElement):

No need to resolve pseudo style, we have it already.

(WebCore::RenderTreeUpdater::GeneratedContent::needsPseudoElement):
(WebCore::RenderTreeUpdater::GeneratedContent::updateBeforePseudoElement): Deleted.
(WebCore::RenderTreeUpdater::GeneratedContent::updateAfterPseudoElement): Deleted.

• style/RenderTreeUpdaterGeneratedContent.h:
• style/StyleTreeResolver.cpp:

(WebCore::Style::TreeResolver::resolveElement):
(WebCore::Style::TreeResolver::resolvePseudoStyle):

Resolve pseudos.

(WebCore::Style::TreeResolver::createAnimatedElementUpdate):

Make a private member function.

(WebCore::Style::TreeResolver::resolveComposedTree):

• style/StyleTreeResolver.h:
• style/StyleUpdate.cpp:

(WebCore::Style::Update::elementUpdates const):
(WebCore::Style::Update::elementUpdates):

Bundle the style update for an element and the associated before/after pseudos.

(WebCore::Style::Update::elementStyle const):
(WebCore::Style::Update::elementStyle):
(WebCore::Style::Update::addElement):
(WebCore::Style::Update::elementUpdate const): Deleted.
(WebCore::Style::Update::elementUpdate): Deleted.

• style/StyleUpdate.h:

1:36 AM Changeset in webkit [223499] by Carlos Garcia Campos

• 3 edits in releases/WebKitGTK/webkit-2.18

Merge r222790 - [AX] Do not trigger redundant layout on tables.
​https://bugs.webkit.org/show_bug.cgi?id=177781
<rdar://problem/34777030>

Reviewed by Antti Koivisto.

Source/WebCore:

RenderTable::forceSectionsRecalc() marks the RenderTable dirty and schedules a layout.
Every time AccessibilityTable asks for the table element (including during construction),
we end up triggering a layout. This call was added (r191357) to ensure RenderTable's m_firstBody is always
up-to-date (in case of anonymous wrapper table renderer). Instead of relying on the m_firstBody,
let's just use the first child to find the table element. The first child always points to a valid
renderer (or nullptr), while m_firstBody is the result of section computation.

Covered by existing tests.

• accessibility/AccessibilityTable.cpp:

(WebCore::AccessibilityTable::tableElement const):

LayoutTests:

• TestExpectations: see webkit.org/b/177799

1:35 AM Changeset in webkit [223498] by Carlos Garcia Campos

• 3 edits
  3 adds in releases/WebKitGTK/webkit-2.18

Merge r222788 - [CSP] Check policy before opening a new window to a JavaScript URL
​https://bugs.webkit.org/show_bug.cgi?id=176815
<rdar://problem/34400057>

Reviewed by Brent Fulgham.

Source/WebCore:

Ensure that the Content Security Policy of the page allows navigation to a JavaScript URL
before opening a new window to it.

Test: http/tests/security/contentSecurityPolicy/window-open-javascript-url-blocked.html

• loader/FrameLoader.cpp:

(WebCore::createWindow):

LayoutTests:

• http/tests/security/contentSecurityPolicy/resources/window-open-javascript-url-blocked.js: Added.
• http/tests/security/contentSecurityPolicy/window-open-javascript-url-blocked-expected.txt: Added.
• http/tests/security/contentSecurityPolicy/window-open-javascript-url-blocked.html: Added.

1:33 AM Changeset in webkit [223497] by Carlos Garcia Campos

• 5 edits
  2 adds in releases/WebKitGTK/webkit-2.18

Merge r222787 - AX: [ATK] ARIA drag-and-drop attribute values should be exposed via AtkObject attributes
​https://bugs.webkit.org/show_bug.cgi?id=177763

Reviewed by Chris Fleizach.

Source/WebCore:

Expose the values of aria-grabbed and aria-dropeffect via the "grabbed" and "dropeffect"
AtkObject attributes.

Test: accessibility/gtk/aria-drag-and-drop.html

• accessibility/atk/WebKitAccessibleWrapperAtk.cpp:

(webkitAccessibleGetAttributes):

Tools:

Implement ariaIsGrabbed() and ariaDropEffects() for ATK.

• WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:

(WTR::AccessibilityUIElement::ariaIsGrabbed const):
(WTR::AccessibilityUIElement::ariaDropEffects const):

LayoutTests:

• accessibility/gtk/aria-drag-and-drop-expected.txt: Added.
• accessibility/gtk/aria-drag-and-drop.html: Added.

1:31 AM Changeset in webkit [223496] by Carlos Garcia Campos

• 5 edits
  2 adds in releases/WebKitGTK/webkit-2.18

Merge r222765 - AX: [ATK] The value of aria-level is not exposed on non-heading roles
​https://bugs.webkit.org/show_bug.cgi?id=177775

Reviewed by Chris Fleizach.

Source/WebCore:

Expose the value of aria-level via the "level" AtkObject attribute, as is currently
done for headings.

Test: accessibility/gtk/aria-level.html

• accessibility/atk/WebKitAccessibleWrapperAtk.cpp:

(webkitAccessibleGetAttributes):

Tools:

• WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:

(WTR::AccessibilityUIElement::hierarchicalLevel const):

LayoutTests:

• accessibility/gtk/aria-level-expected.txt: Added.
• accessibility/gtk/aria-level.html: Added.

1:30 AM Changeset in webkit [223495] by Carlos Garcia Campos

• 2 edits in releases/WebKitGTK/webkit-2.18/Source/WebKit

Merge r222749 - [GTK] Do not hardcode font family in served remote inspector HTML snippets
​https://bugs.webkit.org/show_bug.cgi?id=177742

Reviewed by Carlos Garcia Campos.

Instead of hardcoding Cantarell as the font used for the HTML snippets served
by the remote inspector handler, use "font: menu" to obtain the system UI
font, plus a "font-size" rule for adjusting the size.

• UIProcess/API/gtk/WebKitRemoteInspectorProtocolHandler.cpp:

(WebKit::RemoteInspectorProtocolHandler::handleRequest): Change the
CSS rules in the served snippet.

1:28 AM Changeset in webkit [223494] by Carlos Garcia Campos

• 4 edits in releases/WebKitGTK/webkit-2.18

Merge r222737 - [WPE] Remove GnuTLS dependency
​https://bugs.webkit.org/show_bug.cgi?id=177750

Patch by Olivier Blin <Olivier Blin> on 2017-10-02
Reviewed by Michael Catanzaro.

libgcrypt is used by default instead of GnuTLS.
See bug 163125

.:

• Source/cmake/OptionsWPE.cmake:

Source/WebCore:

• PlatformWPE.cmake:

1:28 AM Changeset in webkit [223493] by Carlos Garcia Campos

• 4 edits in releases/WebKitGTK/webkit-2.18

Merge r222735 - [WPE][GTK] Crash in webkit_web_resource_get_data_finish()
​https://bugs.webkit.org/show_bug.cgi?id=177107

Reviewed by Michael Catanzaro.

Source/WebKit:

Handle errors in webkit_web_resource_get_data() callback.

• UIProcess/API/glib/WebKitWebResource.cpp:

(resourceDataCallback):
(webkit_web_resource_get_data):

Tools:

Add a test case to check we handle errors when webkit_web_resource_get_data() fails.

• TestWebKitAPI/Tests/WebKitGLib/TestResources.cpp:

(webViewloadChanged):
(testWebResourceGetDataError):
(beforeAll):

1:26 AM Changeset in webkit [223492] by Carlos Garcia Campos

• 2 edits in releases/WebKitGTK/webkit-2.18/Source/WebKit

Merge r222729 - [WPE] Fix UIProcess build with GStreamer and without VIDEO
​https://bugs.webkit.org/show_bug.cgi?id=177753

Patch by Olivier Blin <Olivier Blin> on 2017-10-02
Reviewed by Michael Catanzaro.

GStreamer builds fail when WebAudio is enabled but VIDEO disabled.
This is the WPE counterpart of bug 153135.

• UIProcess/API/wpe/PageClientImpl.h:

1:26 AM Changeset in webkit [223491] by Carlos Garcia Campos

• 2 edits in releases/WebKitGTK/webkit-2.18

Merge r222727 - [WPE] Do not require XSLT if disabled
​https://bugs.webkit.org/show_bug.cgi?id=177752

Patch by Olivier Blin <Olivier Blin> on 2017-10-02
Reviewed by Michael Catanzaro.

• Source/cmake/OptionsWPE.cmake: libxslt is not a hard dep

1:24 AM Changeset in webkit [223490] by Carlos Garcia Campos

• 5 edits
  2 adds in releases/WebKitGTK/webkit-2.18/Source/WebCore

Merge r222723 - [GLib] NetworkStateNotifier implementation missing
​https://bugs.webkit.org/show_bug.cgi?id=177741

Patch by Gustavo Noronha Silva <​gustavo.noronha@collabora.co.uk> on 2017-10-02
Reviewed by Carlos Garcia Campos.

No new tests. The DOM support is already being tested, but we would need a way
of simulating a network outage to test GNetworkMonitor.

• PlatformGTK.cmake: add new file.
• PlatformWPE.cmake: add new file.
• platform/network/NetworkStateNotifier.cpp: no longer need the empty implementations, all platforms covered.
• platform/network/NetworkStateNotifier.h:
• platform/network/glib/NetworkStateNotifierGLib.cpp: Added.

(WebCore::NetworkStateNotifier::updateStateWithoutNotifying): update the network state using GNetworkMonitor's availability.
(WebCore::NetworkStateNotifier::networkChangedCallback): when network-changed is emitted, trigger a state update.
(WebCore::NetworkStateNotifier::startObserving): watch GNetworkMonitor's network-changed signal.

1:16 AM Changeset in webkit [223489] by Carlos Garcia Campos

• 2 edits in releases/WebKitGTK/webkit-2.18/Source/WebKit

Merge r222708 - [GTK][WPE] Enable interactive forms validation by default
​https://bugs.webkit.org/show_bug.cgi?id=177737

Reviewed by Michael Catanzaro.

It's currently disabled for no reason.

• Shared/WebPreferencesDefinitions.h:

1:14 AM Changeset in webkit [223488] by Carlos Garcia Campos

• 4 edits in releases/WebKitGTK/webkit-2.18/Source/WebCore

Merge r222706 - [SOUP] Default kerberos authentication credentials are used in ephemeral (private) mode
​https://bugs.webkit.org/show_bug.cgi?id=177738

Reviewed by Carlos Garcia Campos.

If the session is ephemeral then don't enable the Negotiate support in
our SoupSession.

• platform/network/soup/NetworkStorageSessionSoup.cpp: Pass the

session ID if it's known to the SoupNetworkSession.
(WebCore::NetworkStorageSession::ensurePrivateBrowsingSession):
(WebCore::NetworkStorageSession::getOrCreateSoupNetworkSession const):

• platform/network/soup/SoupNetworkSession.cpp:

(WebCore::SoupNetworkSession::SoupNetworkSession): If the session is
ephemeral (based on given session ID) then don't activate the
Negotiate support in SoupSession.

• platform/network/soup/SoupNetworkSession.h:

Change the constructor to accept the PAL::SessionID with the default
value set to PAL::SessionID::emptySessionID.

1:12 AM Changeset in webkit [223487] by Carlos Garcia Campos

• 2 edits in releases/WebKitGTK/webkit-2.18/Source/WebDriver

Merge r222703 - WebDriver: HTTP status code is not correct for some of the errors
​https://bugs.webkit.org/show_bug.cgi?id=177354

Reviewed by Brian Burg.

I think this changed in the spec at some point. The thing is that no such alert, frame and window and stale
element reference errors should return 404 instead of 400.

​https://w3c.github.io/webdriver/webdriver-spec.html#handling-errors

• CommandResult.cpp:

(WebDriver::CommandResult::httpStatusCode const):

1:02 AM Changeset in webkit [223486] by Carlos Garcia Campos

• 12 edits in releases/WebKitGTK/webkit-2.18/Source/WebKit

Merge r222684 - Have IPC::Connection::Client objects consistently invalidate the connection when destroyed
​https://bugs.webkit.org/show_bug.cgi?id=177708

Reviewed by Anders Carlsson.

I ran into an intermittent crash when running regression tests. It looked like a connection
client was being called after it was destroyed. I did an audit of the all the connection
clients to make sure they all invalidate their connection before they are destroyed.

• NetworkProcess/NetworkConnectionToWebProcess.cpp:

(WebKit::NetworkConnectionToWebProcess::~NetworkConnectionToWebProcess): Invalidate the
connection since this object opened the connection. There is no obvious
guarantee that the connection will already be invalid when this is destroyed.

• StorageProcess/StorageToWebProcessConnection.cpp:

(WebKit::StorageToWebProcessConnection::~StorageToWebProcessConnection): Ditto.

• UIProcess/Plugins/PluginProcessProxy.cpp:

(WebKit::PluginProcessProxy::~PluginProcessProxy): Ditto.

• WebProcess/Network/NetworkProcessConnection.cpp:

(WebKit::NetworkProcessConnection::~NetworkProcessConnection): Ditto.

• WebProcess/Storage/WebToStorageProcessConnection.cpp:

(WebKit::WebToStorageProcessConnection::~WebToStorageProcessConnection): Ditto.

• StorageProcess/StorageToWebProcessConnection.h: Derive privately rather than publicly

from IPC::Connection::Client because we can, and this means we don't have to study quite
as much code to understand how this is used as a connection client.

• WebProcess/Databases/IndexedDB/WebIDBConnectionToServer.h: Ditto.
• WebProcess/Storage/WebToStorageProcessConnection.h: Ditto.
• WebProcess/WebPage/WebInspector.h: Ditto.
• WebProcess/WebPage/WebInspectorUI.h: Ditto.

• WebProcess/Databases/IndexedDB/WebIDBConnectionToServer.cpp:

(WebKit::WebIDBConnectionToServer::WebIDBConnectionToServer): Added a comment about a
reference cycle cycle leading to a leak that I believe exists here.

12:57 AM Changeset in webkit [223485] by Carlos Garcia Campos

• 2 edits in releases/WebKitGTK/webkit-2.18/Source/WebCore

Merge r222705 - REGRESSION(r222640) [GTK] Build broken with ATK 2.14
​https://bugs.webkit.org/show_bug.cgi?id=177634

Reviewed by Michael Catanzaro.

Use ATK_CHECK_VERSION to prevent the build failure.

No new tests. This fixes a downstream build failure.

• accessibility/atk/AXObjectCacheAtk.cpp:

(WebCore::AXObjectCache::postPlatformNotification):

12:56 AM Changeset in webkit [223484] by Carlos Garcia Campos

• 7 edits
  10 adds in releases/WebKitGTK/webkit-2.18

Merge r222640 - AX: [ATK] object:state-changed notifications missing for multiple ARIA attributes
​https://bugs.webkit.org/show_bug.cgi?id=177542

Source/WebCore:

Add new notification types to AXObjectCache in order to support the notifications
needed, post the notifications to all platforms, emit the signals for ATK.

Reviewed by Chris Fleizach.

Tests: accessibility/gtk/aria-disabled-changed-notification.html

accessibility/gtk/aria-expanded-changed-notification.html
accessibility/gtk/aria-pressed-changed-notification.html
accessibility/gtk/aria-readonly-changed-notification.html
accessibility/gtk/aria-required-changed-notification.html

• accessibility/AXObjectCache.cpp:

(WebCore::AXObjectCache::handleAttributeChanged):

• accessibility/AXObjectCache.h:
• accessibility/atk/AXObjectCacheAtk.cpp:

(WebCore::AXObjectCache::postPlatformNotification):

Tools:

Add platform support for the notifications. Also add support for getting the
boolean argument indicating whether the state has been set or unset.

Reviewed by Chris Fleizach.

• WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:

LayoutTests:

Reviewed by Chris Fleizach.

• accessibility/gtk/aria-disabled-changed-notification-expected.txt: Added.
• accessibility/gtk/aria-disabled-changed-notification.html: Added.
• accessibility/gtk/aria-expanded-changed-notification-expected.txt: Added.
• accessibility/gtk/aria-expanded-changed-notification.html: Added.
• accessibility/gtk/aria-pressed-changed-notification-expected.txt: Added.
• accessibility/gtk/aria-pressed-changed-notification.html: Added.
• accessibility/gtk/aria-readonly-changed-notification-expected.txt: Added.
• accessibility/gtk/aria-readonly-changed-notification.html: Added.
• accessibility/gtk/aria-required-changed-notification-expected.txt: Added.
• accessibility/gtk/aria-required-changed-notification.html: Added.

12:50 AM Changeset in webkit [223483] by Carlos Garcia Campos

• 8 edits in releases/WebKitGTK/webkit-2.18

Merge r222623 - Add ports 6679 and 6697 (IRC SSL) to port blacklist
​https://bugs.webkit.org/show_bug.cgi?id=177544
<rdar://problem/34666525>

Reviewed by Alex Christensen.

Source/WebCore:

Test: security/block-test.html

• platform/URL.cpp:

(WebCore::portAllowed): Also block port 6679.

LayoutTests:

Update test and expectations for new port.

• security/block-test-expected.txt:
• security/block-test.html:
• platform/gtk/security/block-test-expected.txt:
• platform/mac/security/block-test-expected.txt:
• platform/wpe/security/block-test-expected.txt:

12:49 AM Changeset in webkit [223482] by Carlos Garcia Campos

• 4 edits in releases/WebKitGTK/webkit-2.18/Source/WebCore

Merge r222612 - AX: Defer RenderListBox selectionChanged event until after layout is done.
​https://bugs.webkit.org/show_bug.cgi?id=177589
<rdar://problem/34705785>

Reviewed by Chris Fleizach.

Defer AX update when the selection changed event is followed by a layout.

Covered by existing tests.

• accessibility/AXObjectCache.cpp:

(WebCore::AXObjectCache::remove):
(WebCore::AXObjectCache::performDeferredCacheUpdate):
(WebCore::AXObjectCache::deferSelectedChildrenChangedIfNeeded):

• accessibility/AXObjectCache.h:

(WebCore::AXObjectCache::deferSelectedChildrenChangedIfNeeded):

• rendering/RenderListBox.cpp:

(WebCore::RenderListBox::selectionChanged):

12:46 AM Changeset in webkit [223481] by Carlos Garcia Campos

• 8 edits in releases/WebKitGTK/webkit-2.18/Source

Merge r222610 - [Cairo] Remove the cairo_glyph_t complexity from GlyphBuffer
​https://bugs.webkit.org/show_bug.cgi?id=177598

Reviewed by Carlos Garcia Campos.

Source/WebCore:

Remove the decade-old use of cairo_glyph_t as the underlying type for
Glyph. The former spans 24 bytes in size, while the latte is just 2
bytes. The x and y coordinate attributes of cairo_glyph_t were only
used in FontCascade::drawGlyphs() implementation, where they were
overridden even if the same GlyphBuffer object was used here repeatedly.

FontCascade::drawGlyphs() now creates a new Vector<cairo_glyph_t> object
and fills it only with the glyph index and coordinates data for glyphs
that will actually be drawn. This will likely in the future be leveraged
to pack the necessary data and perform the drawing operations in
parallelized tasks. GlyphBuffer usages that before required USE(CAIRO)
special-casing can now be simplified.

This also removes the need for <cairo.h> header inclusion in the
GlyphBuffer.h header. This further removes Cairo header inclusion in
roughly 600 build targets.

No new tests -- no change in behavior.

• platform/graphics/FontCascade.cpp:

(WebCore::FontCascade::widthForSimpleText const):

• platform/graphics/GlyphBuffer.h:

(WebCore::GlyphBuffer::glyphAt const):
(WebCore::GlyphBuffer::add):

• platform/graphics/cairo/FontCairo.cpp:

(WebCore::drawGlyphsToContext):
(WebCore::drawGlyphsShadow):
(WebCore::FontCascade::drawGlyphs):

• platform/graphics/displaylists/DisplayListItems.cpp:

(WebCore::DisplayList::DrawGlyphs::generateGlyphBuffer const):

Source/WebKit:

• Shared/API/c/cairo/WKImageCairo.cpp: Explicitly include the <cairo.h>

header here now that it's not included in GlyphBuffer.h.

• WebProcess/WebCoreSupport/gtk/WebDragClientGtk.cpp: Ditto.

12:36 AM Changeset in webkit [223480] by Carlos Garcia Campos

• 6 edits in releases/WebKitGTK/webkit-2.18

Merge r222605 - [REGRESSION] word-spacing property is incorrectly applied
​https://bugs.webkit.org/show_bug.cgi?id=142086
<rdar://problem/19985240>

Patch by Fujii Hironori <Fujii Hironori> on 2017-09-27
Reviewed by Zalan Bujtas.

Source/WebCore:

word-spacing property isn't applied to text nodes with starting
with '\n' if the kerning enabled. In Bug 165796, only ' ' and '\t'
are treated for word-spacing, but '\n'. It should be treated as
well.

Test: fast/text/word-space-between-inlines.html

• rendering/RenderBlockLineLayout.cpp:

(WebCore::setLogicalWidthForTextRun): Use
FontCascade::treatAsSpace() instead of checking explicitly by
comparing with ' ' and '\t'.

LayoutTests:

• platform/gtk/TestExpectations: Unmark

fast/text/word-space-between-inlines.html

• platform/mac/TestExpectations: Unmark

fast/css/word-spacing-between-blocks.html,
fast/css/word-spacing-between-inlines.html,
fast/css/word-spacing-characters.html and
fast/text/word-space-between-inlines.html.

• platform/gtk/fast/css/word-space-extra-expected.txt:

Rebaselined.

• platform/mac/fast/css/word-space-extra-expected.png: Ditto.
• platform/mac/fast/css/word-space-extra-expected.txt: Ditto.

12:32 AM Changeset in webkit [223479] by Carlos Garcia Campos

• 4 edits in releases/WebKitGTK/webkit-2.18/Source/WebCore

Merge r222604 - [Cairo] Remove unnecessary cairo.h includes
​https://bugs.webkit.org/show_bug.cgi?id=177540

Reviewed by Carlos Garcia Campos.

Drop unnecessary includes of the cairo.h header from the Font.h,
FontPlatformData.h and Pattern.h headers. For the former two the
header isn't required, while in the last one we can use a forward
declaration for the cairo_pattern_t type instead of including
the whole Cairo headers to have that available.

• platform/graphics/Font.h:
• platform/graphics/FontPlatformData.h:
• platform/graphics/Pattern.h:

12:24 AM Changeset in webkit [223478] by Carlos Garcia Campos

• 11 edits
  1 delete in releases/WebKitGTK/webkit-2.18/Source/WebCore

Merge r222603 - [Cairo] Drop cairo_matrix_t conversion operators for AffineTransform, TransformationMatrix
​https://bugs.webkit.org/show_bug.cgi?id=177539

Reviewed by Carlos Garcia Campos.

Remove the cairo_matrix_t conversion operators from the AffineTransform
and TransformationMatrix classes. These are rarely used, but enforce
including the cairo.h header in both headers, which leads to the Cairo
headers being included in around 800 build targets.

Instead, the toCairoMatrix() function is added to CairoUtilities.h that
creates a cairo_matrix_t object for the given AffineTransform. No
toCairoMatrix() is needed for TransformationMatrix since objects of
that type aren't converted to cairo_matrix_t anywhere in the codebase.

This patch excludes unnecessary Cairo headers from about 550 build
targets (with those headers being included in the other affected 250
targets by some other header inclusion chain). CairoUtilities.h header
is now included where necessary to make toCairoMatrix() available, and
duplicated cairo.h inclusions are removed.

No new tests -- no change in behavior.

• editing/gtk/EditorGtk.cpp: Explicitly include <cairo.h> since it's

necessary for Cairo operations used there.

• platform/Cairo.cmake:
• platform/graphics/cairo/CairoUtilities.cpp:

(WebCore::drawPatternToCairoContext):
(WebCore::toCairoMatrix):

• platform/graphics/cairo/CairoUtilities.h:
• platform/graphics/cairo/GradientCairo.cpp:

(WebCore::Gradient::platformGradient):
(WebCore::Gradient::setPlatformGradientSpaceTransform):

• platform/graphics/cairo/GraphicsContextCairo.cpp:

(WebCore::GraphicsContext::concatCTM):
(WebCore::GraphicsContext::setCTM):

• platform/graphics/cairo/PathCairo.cpp: No need to include AffineTransform.h.

(WebCore::Path::addPath):
(WebCore::Path::transform):

• platform/graphics/cairo/PatternCairo.cpp: Ditto.

(WebCore::Pattern::createPlatformPattern const):

• platform/graphics/cairo/TransformationMatrixCairo.cpp: Removed.
• platform/graphics/transforms/AffineTransform.h:
• platform/graphics/transforms/TransformationMatrix.h:

12:12 AM Changeset in webkit [223477] by commit-queue@webkit.org

• 2 edits
  1 add in trunk/LayoutTests

[GStreamer][MSE] Unreviewed microgardening
​https://bugs.webkit.org/show_bug.cgi?id=178344

Updates the following expectations:

• imported/w3c/web-platform-tests/media-source/mediasource-is-type-supported.html

Updated with current output (as a prerequisite to land this:
​https://bugs.webkit.org/show_bug.cgi?id=178160, which improves the
-expected output a bit)

• imported/w3c/web-platform-tests/media-source/SourceBuffer-abort*.html

Marked them as passing, as they have been passing for a while.

• imported/w3c/web-platform-tests/media-source/mediasource-play-then-seek-back.html imported/w3c/web-platform-tests/media-source/mediasource-sourcebuffer-mode.html

Marked them as passing. They were crashing on the build bot because
the changes of ​https://bugs.webkit.org/show_bug.cgi?id=176804 were
not being built, but Carlos López is already working on that.

Patch by Alicia Boya García <​aboya@igalia.com> on 2017-10-17

• platform/gtk/TestExpectations:

12:10 AM Changeset in webkit [223476] by keith_miller@apple.com

• 418 edits
  2 adds
  2 deletes in trunk

Change WebCore sources to work with unified source builds
​https://bugs.webkit.org/show_bug.cgi?id=178229

Rubber stamped by Tim Horton.

Source/JavaScriptCore:

• Configurations/FeatureDefines.xcconfig:

Source/WebCore:

This patch does the following:

1) Move all “using namespace <name>;” into the WebCore namespace
(They used to go in the global namespace) and change to "using
WebCore::<name>;” in .mm files.

2) Move a bunch of the soft linking library/framework macros out
of the .mm files since those caused name collision problems.

3) Fix minor other naming collisions.

The problem with 1 in a unified source world is generic names
often collide with system header names. For example, WebCore has a
Rect class and that collided with a system header type elsewhere.

This patch shouldn't change behavior so no new tests.

• Configurations/FeatureDefines.xcconfig:
• Modules/cache/CacheStorageConnection.cpp:
• Modules/cache/DOMCache.cpp:
• Modules/cache/DOMCacheStorage.cpp:
• Modules/cache/WorkerCacheStorageConnection.cpp:
• Modules/encryptedmedia/InitDataRegistry.cpp:
• Modules/encryptedmedia/legacy/LegacyCDMSessionClearKey.cpp:
• Modules/indexeddb/IDBCursor.cpp:
• Modules/indexeddb/IDBFactory.cpp:
• Modules/indexeddb/IDBIndex.cpp:
• Modules/indexeddb/IDBKeyRange.cpp:
• Modules/indexeddb/IDBObjectStore.cpp:
• Modules/indexeddb/IDBRequest.cpp:
• Modules/indexeddb/IDBTransaction.cpp:
• Modules/indexeddb/server/MemoryObjectStore.cpp:
• Modules/indexeddb/server/SQLiteIDBBackingStore.cpp:
• Modules/indexeddb/server/UniqueIDBDatabase.cpp:
• Modules/mediasource/MediaSource.cpp:

(WebCore::MediaSource::setReadyState):
(WebCore::toString): Deleted.

• Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp:
• Modules/plugins/QuickTimePluginReplacement.mm:

(WebCore::jsValueWithAVMetadataItemInContext):

• Modules/webdriver/NavigatorWebDriver.cpp:
• PlatformAppleWin.cmake:
• PlatformMac.cmake:
• WebCore.xcodeproj/project.pbxproj:
• accessibility/ios/AccessibilityObjectIOS.mm:

(-[WAKView accessibilityIsIgnored]): Deleted.

• accessibility/ios/WebAccessibilityObjectWrapperIOS.h:
• accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:

(-[WAKView accessibilityIsIgnored]):

• accessibility/win/AXObjectCacheWin.cpp:
• bindings/js/CommonVM.cpp:
• bindings/js/DOMWrapperWorld.cpp:
• bindings/js/GCController.cpp:
• bindings/js/IDBBindingUtilities.cpp:
• bindings/js/JSAudioTrackCustom.cpp:
• bindings/js/JSAudioTrackListCustom.cpp:
• bindings/js/JSBlobCustom.cpp:
• bindings/js/JSCSSRuleCustom.cpp:
• bindings/js/JSCSSRuleListCustom.cpp:
• bindings/js/JSCSSStyleDeclarationCustom.cpp:
• bindings/js/JSCallbackData.cpp:
• bindings/js/JSCanvasRenderingContext2DCustom.cpp:
• bindings/js/JSCustomElementInterface.cpp:
• bindings/js/JSCustomElementRegistryCustom.cpp:
• bindings/js/JSCustomEventCustom.cpp:
• bindings/js/JSDOMBindingSecurity.cpp:
• bindings/js/JSDOMBuiltinConstructorBase.cpp:
• bindings/js/JSDOMConstructorBase.cpp:
• bindings/js/JSDOMConstructorWithDocument.cpp:
• bindings/js/JSDOMConvertDate.cpp:
• bindings/js/JSDOMConvertNumbers.cpp:
• bindings/js/JSDOMConvertStrings.cpp:
• bindings/js/JSDOMConvertWebGL.cpp:
• bindings/js/JSDOMExceptionHandling.cpp:
• bindings/js/JSDOMGlobalObject.cpp:
• bindings/js/JSDOMGlobalObjectTask.cpp:
• bindings/js/JSDOMGuardedObject.cpp:
• bindings/js/JSDOMPromiseDeferred.cpp:
• bindings/js/JSDOMQuadCustom.cpp:
• bindings/js/JSDOMWindowBase.cpp:
• bindings/js/JSDOMWindowCustom.cpp:
• bindings/js/JSDOMWindowProxy.cpp:
• bindings/js/JSDOMWrapper.cpp:
• bindings/js/JSDOMWrapperCache.cpp:
• bindings/js/JSDeprecatedCSSOMValueCustom.cpp:
• bindings/js/JSDocumentCustom.cpp:
• bindings/js/JSDocumentFragmentCustom.cpp:
• bindings/js/JSElementCustom.cpp:
• bindings/js/JSErrorHandler.cpp:
• bindings/js/JSEventCustom.cpp:
• bindings/js/JSEventListener.cpp:
• bindings/js/JSEventTargetCustom.cpp:
• bindings/js/JSFileSystemEntryCustom.cpp:
• bindings/js/JSHTMLCollectionCustom.cpp:
• bindings/js/JSHTMLDocumentCustom.cpp:
• bindings/js/JSHTMLTemplateElementCustom.cpp:
• bindings/js/JSHistoryCustom.cpp:
• bindings/js/JSIDBCursorCustom.cpp:
• bindings/js/JSIDBCursorWithValueCustom.cpp:
• bindings/js/JSIDBIndexCustom.cpp:
• bindings/js/JSIDBObjectStoreCustom.cpp:
• bindings/js/JSIDBTransactionCustom.cpp:
• bindings/js/JSImageDataCustom.cpp:
• bindings/js/JSLazyEventListener.cpp:
• bindings/js/JSLocationCustom.cpp:
• bindings/js/JSMediaStreamCapabilitiesCustom.cpp:
• bindings/js/JSMessageEventCustom.cpp:
• bindings/js/JSMessagePortCustom.cpp:
• bindings/js/JSMutationObserverCustom.cpp:
• bindings/js/JSNodeCustom.cpp:
• bindings/js/JSNodeListCustom.cpp:
• bindings/js/JSPerformanceEntryCustom.cpp:
• bindings/js/JSPluginElementFunctions.cpp:
• bindings/js/JSPopStateEventCustom.cpp:
• bindings/js/JSReadableStreamPrivateConstructors.cpp:
• bindings/js/JSReadableStreamSourceCustom.cpp:
• bindings/js/JSSVGPathSegCustom.cpp:
• bindings/js/JSTextTrackCueCustom.cpp:
• bindings/js/JSTextTrackCustom.cpp:
• bindings/js/JSTextTrackListCustom.cpp:
• bindings/js/JSTrackCustom.cpp:
• bindings/js/JSVideoTrackCustom.cpp:
• bindings/js/JSVideoTrackListCustom.cpp:
• bindings/js/JSWebGL2RenderingContextCustom.cpp:
• bindings/js/JSWebGLRenderingContextCustom.cpp:
• bindings/js/JSWebGPURenderPassAttachmentDescriptorCustom.cpp:
• bindings/js/JSWebGPURenderingContextCustom.cpp:
• bindings/js/JSWorkerGlobalScopeBase.cpp:
• bindings/js/JSWorkerGlobalScopeCustom.cpp:
• bindings/js/JSXMLHttpRequestCustom.cpp:
• bindings/js/JSXPathNSResolverCustom.cpp:
• bindings/js/ReadableStream.cpp:

(WebCore::ReadableStream::pipeTo):
(WebCore::ReadableStream::tee):
(WebCore::checkReadableStream):
(WebCore::callFunction): Deleted.

• bindings/js/ScheduledAction.cpp:
• bindings/js/ScriptCachedFrameData.cpp:
• bindings/js/ScriptController.cpp:
• bindings/js/SerializedScriptValue.cpp:
• bindings/js/StructuredClone.cpp:
• bindings/js/WebCoreJSClientData.cpp:
• bindings/js/WorkerScriptController.cpp:
• bindings/scripts/CodeGeneratorJS.pm:

(GenerateEnumerationImplementation):
(GenerateImplementation):
(GenerateDictionaryImplementation):
(GenerateCallbackFunctionImplementation):
(GenerateCallbackInterfaceImplementation):

• bindings/scripts/test/JS/JSInterfaceName.cpp:
• bindings/scripts/test/JS/JSMapLike.cpp:
• bindings/scripts/test/JS/JSReadOnlyMapLike.cpp:
• bindings/scripts/test/JS/JSTestActiveDOMObject.cpp:
• bindings/scripts/test/JS/JSTestCEReactions.cpp:
• bindings/scripts/test/JS/JSTestCEReactionsStringifier.cpp:
• bindings/scripts/test/JS/JSTestCallTracer.cpp:
• bindings/scripts/test/JS/JSTestCallbackFunction.cpp:
• bindings/scripts/test/JS/JSTestCallbackFunctionRethrow.cpp:
• bindings/scripts/test/JS/JSTestCallbackFunctionWithThisObject.cpp:
• bindings/scripts/test/JS/JSTestCallbackFunctionWithTypedefs.cpp:
• bindings/scripts/test/JS/JSTestCallbackInterface.cpp:
• bindings/scripts/test/JS/JSTestClassWithJSBuiltinConstructor.cpp:
• bindings/scripts/test/JS/JSTestCustomConstructorWithNoInterfaceObject.cpp:
• bindings/scripts/test/JS/JSTestDOMJIT.cpp:
• bindings/scripts/test/JS/JSTestEnabledBySetting.cpp:
• bindings/scripts/test/JS/JSTestEventConstructor.cpp:
• bindings/scripts/test/JS/JSTestEventTarget.cpp:
• bindings/scripts/test/JS/JSTestException.cpp:
• bindings/scripts/test/JS/JSTestGenerateIsReachable.cpp:
• bindings/scripts/test/JS/JSTestGlobalObject.cpp:
• bindings/scripts/test/JS/JSTestIndexedSetterNoIdentifier.cpp:
• bindings/scripts/test/JS/JSTestIndexedSetterThrowingException.cpp:
• bindings/scripts/test/JS/JSTestIndexedSetterWithIdentifier.cpp:
• bindings/scripts/test/JS/JSTestInterface.cpp:
• bindings/scripts/test/JS/JSTestInterfaceLeadingUnderscore.cpp:
• bindings/scripts/test/JS/JSTestIterable.cpp:
• bindings/scripts/test/JS/JSTestJSBuiltinConstructor.cpp:
• bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp:
• bindings/scripts/test/JS/JSTestNamedAndIndexedSetterNoIdentifier.cpp:
• bindings/scripts/test/JS/JSTestNamedAndIndexedSetterThrowingException.cpp:
• bindings/scripts/test/JS/JSTestNamedAndIndexedSetterWithIdentifier.cpp:
• bindings/scripts/test/JS/JSTestNamedConstructor.cpp:
• bindings/scripts/test/JS/JSTestNamedDeleterNoIdentifier.cpp:
• bindings/scripts/test/JS/JSTestNamedDeleterThrowingException.cpp:
• bindings/scripts/test/JS/JSTestNamedDeleterWithIdentifier.cpp:
• bindings/scripts/test/JS/JSTestNamedDeleterWithIndexedGetter.cpp:
• bindings/scripts/test/JS/JSTestNamedGetterCallWith.cpp:
• bindings/scripts/test/JS/JSTestNamedGetterNoIdentifier.cpp:
• bindings/scripts/test/JS/JSTestNamedGetterWithIdentifier.cpp:
• bindings/scripts/test/JS/JSTestNamedSetterNoIdentifier.cpp:
• bindings/scripts/test/JS/JSTestNamedSetterThrowingException.cpp:
• bindings/scripts/test/JS/JSTestNamedSetterWithIdentifier.cpp:
• bindings/scripts/test/JS/JSTestNamedSetterWithIndexedGetter.cpp:
• bindings/scripts/test/JS/JSTestNamedSetterWithIndexedGetterAndSetter.cpp:
• bindings/scripts/test/JS/JSTestNamedSetterWithOverrideBuiltins.cpp:
• bindings/scripts/test/JS/JSTestNamedSetterWithUnforgableProperties.cpp:
• bindings/scripts/test/JS/JSTestNamedSetterWithUnforgablePropertiesAndOverrideBuiltins.cpp:
• bindings/scripts/test/JS/JSTestNode.cpp:
• bindings/scripts/test/JS/JSTestObj.cpp:
• bindings/scripts/test/JS/JSTestOverloadedConstructors.cpp:
• bindings/scripts/test/JS/JSTestOverloadedConstructorsWithSequence.cpp:
• bindings/scripts/test/JS/JSTestOverrideBuiltins.cpp:
• bindings/scripts/test/JS/JSTestPluginInterface.cpp:
• bindings/scripts/test/JS/JSTestPromiseRejectionEvent.cpp:
• bindings/scripts/test/JS/JSTestSerialization.cpp:
• bindings/scripts/test/JS/JSTestSerializationIndirectInheritance.cpp:
• bindings/scripts/test/JS/JSTestSerializationInherit.cpp:
• bindings/scripts/test/JS/JSTestSerializationInheritFinal.cpp:
• bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp:
• bindings/scripts/test/JS/JSTestStandaloneDictionary.cpp:
• bindings/scripts/test/JS/JSTestStandaloneEnumeration.cpp:
• bindings/scripts/test/JS/JSTestStringifier.cpp:
• bindings/scripts/test/JS/JSTestStringifierAnonymousOperation.cpp:
• bindings/scripts/test/JS/JSTestStringifierNamedOperation.cpp:
• bindings/scripts/test/JS/JSTestStringifierOperationImplementedAs.cpp:
• bindings/scripts/test/JS/JSTestStringifierOperationNamedToString.cpp:
• bindings/scripts/test/JS/JSTestStringifierReadOnlyAttribute.cpp:
• bindings/scripts/test/JS/JSTestStringifierReadWriteAttribute.cpp:
• bindings/scripts/test/JS/JSTestTypedefs.cpp:
• bindings/scripts/test/JS/JSTestVoidCallbackFunction.cpp:
• bridge/IdentifierRep.cpp:
• bridge/NP_jsobject.cpp:

(ObjectMap::get): Deleted.
(ObjectMap::add): Deleted.
(ObjectMap::remove): Deleted.
(objectMap): Deleted.
(ObjectMap::RootObjectInvalidationCallback::operator()): Deleted.
(getListFromVariantArgs): Deleted.
(jsAllocate): Deleted.
(jsDeallocate): Deleted.
(_NPN_CreateNoScriptObject): Deleted.
(_NPN_InvokeDefault): Deleted.
(_NPN_Invoke): Deleted.
(_NPN_Evaluate): Deleted.
(_NPN_GetProperty): Deleted.
(_NPN_SetProperty): Deleted.
(_NPN_RemoveProperty): Deleted.
(_NPN_HasProperty): Deleted.
(_NPN_HasMethod): Deleted.
(_NPN_SetException): Deleted.
(_NPN_Enumerate): Deleted.
(_NPN_Construct): Deleted.

• bridge/NP_jsobject.h:
• contentextensions/ContentExtensionParser.cpp:
• crypto/SubtleCrypto.cpp:
• crypto/algorithms/CryptoAlgorithmAES_CBC.cpp:

(WebCore::CryptoAlgorithmAES_CBC::encrypt):
(WebCore::CryptoAlgorithmAES_CBC::decrypt):
(WebCore::CryptoAlgorithmAES_CBC::importKey):
(WebCore::CryptoAlgorithmAES_CBC::exportKey):

• crypto/algorithms/CryptoAlgorithmAES_CFB.cpp:

(WebCore::CryptoAlgorithmAES_CFB::encrypt):
(WebCore::CryptoAlgorithmAES_CFB::decrypt):
(WebCore::CryptoAlgorithmAES_CFB::importKey):
(WebCore::CryptoAlgorithmAES_CFB::exportKey):

• crypto/algorithms/CryptoAlgorithmAES_CTR.cpp:

(WebCore::parametersAreValid):
(WebCore::CryptoAlgorithmAES_CTR::importKey):
(WebCore::CryptoAlgorithmAES_CTR::exportKey):

• crypto/algorithms/CryptoAlgorithmAES_GCM.cpp:

(WebCore::tagLengthIsValid):
(WebCore::CryptoAlgorithmAES_GCM::encrypt):
(WebCore::CryptoAlgorithmAES_GCM::decrypt):
(WebCore::CryptoAlgorithmAES_GCM::importKey):
(WebCore::CryptoAlgorithmAES_GCM::exportKey):

• crypto/algorithms/CryptoAlgorithmAES_KW.cpp:

(WebCore::CryptoAlgorithmAES_KW::importKey):
(WebCore::CryptoAlgorithmAES_KW::exportKey):

• crypto/algorithms/CryptoAlgorithmHMAC.cpp:

(WebCore::CryptoAlgorithmHMAC::importKey):
(WebCore::CryptoAlgorithmHMAC::exportKey):

• crypto/algorithms/CryptoAlgorithmRSASSA_PKCS1_v1_5.cpp:

(WebCore::CryptoAlgorithmRSASSA_PKCS1_v1_5::importKey):
(WebCore::CryptoAlgorithmRSASSA_PKCS1_v1_5::exportKey):

• crypto/algorithms/CryptoAlgorithmRSA_OAEP.cpp:

(WebCore::CryptoAlgorithmRSA_OAEP::importKey):
(WebCore::CryptoAlgorithmRSA_OAEP::exportKey):

• crypto/algorithms/CryptoAlgorithmRSA_PSS.cpp:

(WebCore::CryptoAlgorithmRSA_PSS::importKey):
(WebCore::CryptoAlgorithmRSA_PSS::exportKey):

• crypto/mac/CryptoAlgorithmPBKDF2Mac.cpp:

(WebCore::CryptoAlgorithmPBKDF2::platformDeriveBits):
(WebCore::commonCryptoHMACAlgorithm): Deleted.

• css/CSSBasicShapes.cpp:
• css/CSSPrimitiveValue.cpp:
• css/parser/CSSParser.cpp:
• css/parser/CSSPropertyParser.cpp:
• css/parser/CSSPropertyParserHelpers.cpp:

(WebCore::CSSPropertyParserHelpers::positionFromThreeOrFourValues):
(WebCore::CSSPropertyParserHelpers::consumePosition):
(WebCore::CSSPropertyParserHelpers::createPrimitiveValuePair): Deleted.

• dom/DOMQuad.cpp:
• dom/Document.cpp:
• dom/ErrorEvent.cpp:
• dom/EventListenerMap.cpp:
• dom/EventTarget.cpp:
• dom/PromiseRejectionEvent.cpp:
• dom/RejectedPromiseTracker.cpp:
• dom/ScriptExecutionContext.cpp:
• domjit/JSDocumentDOMJIT.cpp:
• domjit/JSDocumentFragmentDOMJIT.cpp:
• domjit/JSElementDOMJIT.cpp:
• domjit/JSEventDOMJIT.cpp:
• domjit/JSNodeDOMJIT.cpp:
• editing/TextIterator.cpp:
• editing/cocoa/HTMLConverter.mm:
• history/CachedPage.cpp:
• html/HTMLCanvasElement.cpp:
• html/HTMLFontElement.cpp:
• html/HTMLMediaElement.cpp:
• html/HTMLSelectElement.cpp:
• html/TypeAhead.cpp:
• html/parser/HTMLSrcsetParser.cpp:

(WebCore::tokenizeDescriptors):

• html/parser/HTMLTokenizer.cpp:
• html/parser/ParsingUtilities.h:

(WebCore::isNotASCIISpace):

• html/parser/XSSAuditorDelegate.cpp:
• html/track/DataCue.cpp:
• inspector/CommandLineAPIHost.cpp:
• inspector/CommandLineAPIModule.cpp:
• inspector/InspectorApplicationCacheAgent.cpp:
• inspector/InspectorCSSAgent.cpp:
• inspector/InspectorCanvas.cpp:
• inspector/InspectorCanvasAgent.cpp:
• inspector/InspectorClient.cpp:
• inspector/InspectorController.cpp:
• inspector/InspectorDOMAgent.cpp:
• inspector/InspectorDOMDebuggerAgent.cpp:
• inspector/InspectorDOMStorageAgent.cpp:
• inspector/InspectorDatabaseAgent.cpp:
• inspector/InspectorDatabaseResource.cpp:
• inspector/InspectorFrontendClientLocal.cpp:
• inspector/InspectorFrontendHost.cpp:
• inspector/InspectorIndexedDBAgent.cpp:
• inspector/InspectorInstrumentation.cpp:
• inspector/InspectorLayerTreeAgent.cpp:
• inspector/InspectorMemoryAgent.cpp:
• inspector/InspectorNetworkAgent.cpp:
• inspector/InspectorOverlay.cpp:
• inspector/InspectorPageAgent.cpp:
• inspector/InspectorShaderProgram.cpp:
• inspector/InspectorStyleSheet.cpp:
• inspector/InspectorTimelineAgent.cpp:
• inspector/InspectorWorkerAgent.cpp:
• inspector/InstrumentingAgents.cpp:
• inspector/NetworkResourcesData.cpp:
• inspector/PageConsoleAgent.cpp:
• inspector/PageDebuggerAgent.cpp:
• inspector/PageHeapAgent.cpp:
• inspector/PageRuntimeAgent.cpp:
• inspector/PageScriptDebugServer.cpp:
• inspector/TimelineRecordFactory.cpp:
• inspector/WebConsoleAgent.cpp:
• inspector/WebDebuggerAgent.cpp:
• inspector/WebHeapAgent.cpp:
• inspector/WebInjectedScriptHost.cpp:
• inspector/WebInjectedScriptManager.cpp:
• inspector/WorkerConsoleAgent.cpp:
• inspector/WorkerDebuggerAgent.cpp:
• inspector/WorkerInspectorController.cpp:
• inspector/WorkerRuntimeAgent.cpp:
• inspector/WorkerScriptDebugServer.cpp:
• loader/FTPDirectoryParser.cpp:
• loader/TextResourceDecoder.cpp:
• loader/cache/CachedResource.cpp:
• loader/cache/CachedResourceLoader.cpp:
• page/ContextMenuController.cpp:
• page/DOMWindow.cpp:
• page/Navigator.cpp:
• page/PageConsoleClient.cpp:
• page/PageDebuggable.cpp:
• page/cocoa/ResourceUsageOverlayCocoa.mm:
• page/csp/ContentSecurityPolicy.cpp:
• page/csp/ContentSecurityPolicyDirectiveList.cpp:

(WebCore::isNotASCIISpace): Deleted.

• page/csp/ContentSecurityPolicyMediaListDirective.cpp:

(WebCore::isNotASCIISpace): Deleted.

• page/scrolling/ios/ScrollingTreeIOS.cpp:
• page/scrolling/ios/ScrollingTreeIOS.h:
• page/scrolling/mac/ScrollingTreeFixedNode.mm:

(WebCore::ScrollingTreeFixedNode::updateLayersAfterAncestorChange):
(WebCore::operator*): Deleted.

• page/scrolling/mac/ScrollingTreeStickyNode.mm:

(WebCore::ScrollingTreeStickyNode::updateLayersAfterAncestorChange):
(WebCore::operator*): Deleted.

• platform/Length.cpp:
• platform/URL.cpp:

(WebCore::isSchemeFirstChar):
(WebCore::isSchemeChar):
(WebCore::isBadChar):
(WebCore::isTabNewline):

• platform/audio/WebAudioBufferList.cpp:

(WebCore::WebAudioBufferList::WebAudioBufferList):

• platform/audio/mac/AudioSampleDataSource.mm:

(WebCore::AudioSampleDataSource::pushSamples):

• platform/cf/CoreMediaSoftLink.cpp: Removed.
• platform/cf/CoreMediaSoftLink.h: Removed.
• platform/encryptedmedia/clearkey/CDMClearKey.cpp:
• platform/graphics/FloatPolygon.cpp:

(WebCore::areCollinearPoints):
(WebCore::FloatPolygon::FloatPolygon):
(WebCore::VertexPair::intersection const):
(WebCore::determinant): Deleted.

• platform/graphics/FontCache.cpp:
• platform/graphics/FontCascade.cpp:
• platform/graphics/GraphicsContext3DPrivate.cpp:
• platform/graphics/WidthIterator.cpp:
• platform/graphics/avfoundation/AudioSourceProviderAVFObjC.mm:

(WebCore::AudioSourceProviderAVFObjC::process):

• platform/graphics/avfoundation/InbandTextTrackPrivateAVF.cpp:

(WebCore::InbandTextTrackPrivateAVF::processCueAttributes):
(WebCore::InbandTextTrackPrivateAVF::processNativeSamples):
(WebCore::InbandTextTrackPrivateAVF::readNativeSampleBuffer):

• platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.cpp:
• platform/graphics/avfoundation/objc/AVAssetTrackUtilities.mm:

(WebCore::assetTrackMeetsHardwareDecodeRequirements):

• platform/graphics/avfoundation/objc/AVFoundationMIMETypeCache.mm:
• platform/graphics/avfoundation/objc/ImageDecoderAVFObjC.mm:

(WebCore::ImageDecoderAVFObjC::readSampleMetadata):
(WebCore::ImageDecoderAVFObjC::storeSampleBuffer):
(WebCore::ImageDecoderAVFObjC::frameIsCompleteAtIndex const):

• platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:

(WebCore::MediaPlayerPrivateAVFoundationObjC::createImageGenerator):

• platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:
• platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.mm:
• platform/graphics/avfoundation/objc/MediaSampleAVFObjC.mm:
• platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm:
• platform/graphics/ca/win/PlatformCALayerWinInternal.cpp:
• platform/graphics/ca/win/WebTiledBackingLayerWin.cpp:
• platform/graphics/cairo/GraphicsContextCairo.cpp:
• platform/graphics/cairo/ImageBufferCairo.cpp:
• platform/graphics/cg/ImageBufferCG.cpp:

(WebCore::ImageBuffer::ImageBuffer):
(WebCore::releaseImageData): Deleted.

• platform/graphics/cg/ImageBufferDataCG.h:
• platform/graphics/cocoa/WebCoreDecompressionSession.mm:
• platform/graphics/gstreamer/ImageGStreamerCairo.cpp:
• platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
• platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:
• platform/graphics/ios/DisplayRefreshMonitorIOS.mm:
• platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:
• platform/graphics/opentype/OpenTypeMathData.cpp:
• platform/graphics/opentype/OpenTypeVerticalData.cpp:
• platform/graphics/transforms/MatrixTransformOperation.cpp:

(WebCore::MatrixTransformOperation::blend):
(WebCore::createOperation): Deleted.

• platform/graphics/win/FontPlatformDataCairoWin.cpp:
• platform/graphics/win/FontWin.cpp:
• platform/graphics/win/GraphicsContextCGWin.cpp:
• platform/graphics/win/GraphicsContextCairoWin.cpp:
• platform/graphics/win/GraphicsContextDirect2D.cpp:
• platform/graphics/win/GraphicsContextWin.cpp:
• platform/graphics/win/UniscribeController.cpp:
• platform/image-decoders/ScalableImageDecoder.cpp:

(): Deleted.

• platform/ios/LegacyTileLayer.mm:

(-[LegacyTileHostLayer renderInContext:]):

• platform/ios/PlaybackSessionInterfaceAVKit.mm:
• platform/ios/ScrollAnimatorIOS.mm:
• platform/ios/VideoFullscreenInterfaceAVKit.mm:
• platform/ios/WebAVPlayerController.mm:

(-[WebAVPlayerController skipBackwardThirtySeconds:]):
(-[WebAVPlayerController gotoEndOfSeekableRanges:]):
(-[WebAVPlayerController canSeekToBeginning]):
(-[WebAVPlayerController canSeekToEnd]):
(-[WebAVPlayerController observeValueForKeyPath:ofObject:change:context:]):
(-[WebAVPlayerController updateMinMaxTiming]):

• platform/ios/WebEvent.mm:
• platform/ios/WebItemProviderPasteboard.mm:
• platform/ios/wak/WKContentObservation.cpp:
• platform/mac/KeyEventMac.mm:
• platform/mac/PlaybackSessionInterfaceMac.mm:

(WebCore::timeRangesToArray):

• platform/mac/ScrollAnimatorMac.mm:

(macScrollbarTheme): Deleted.
(scrollerImpForScrollbar): Deleted.

• platform/mac/ScrollbarThemeMac.mm:

(WebCore::scrollbarMap):

• platform/mac/VideoFullscreenInterfaceMac.mm:
• platform/mac/WebCoreFullScreenPlaceholderView.mm:
• platform/mac/WebCoreNSURLExtras.mm:

(WebCore::dataForURLComponentType):

• platform/mac/WebPlaybackControlsManager.mm:
• platform/mac/WebVideoFullscreenController.mm:

(SOFT_LINK_CLASS): Deleted.

• platform/mac/WebVideoFullscreenHUDWindowController.mm:
• platform/mac/WebWindowAnimation.mm:

(WebWindowAnimationDurationFromDuration): Deleted.
(scaledRect): Deleted.
(squaredDistance): Deleted.

• platform/mediastream/RealtimeOutgoingVideoSource.cpp:
• platform/mediastream/mac/AVCaptureDeviceManager.mm:
• platform/mediastream/mac/AVMediaCaptureSource.mm:
• platform/mediastream/mac/AVVideoCaptureSource.mm:

(WebCore::AVVideoCaptureSource::applyFrameRate):
(WebCore::AVVideoCaptureSource::processNewFrame):

• platform/mediastream/mac/AudioTrackPrivateMediaStreamCocoa.cpp:
• platform/mediastream/mac/CoreAudioCaptureDevice.cpp:
• platform/mediastream/mac/CoreAudioCaptureDeviceManager.cpp:
• platform/mediastream/mac/CoreAudioCaptureSource.cpp:
• platform/mediastream/mac/MockRealtimeAudioSourceMac.mm:
• platform/mediastream/mac/MockRealtimeVideoSourceMac.mm:

(WebCore::MockRealtimeVideoSourceMac::CMSampleBufferFromPixelBuffer):

• platform/mediastream/mac/RealtimeIncomingAudioSourceCocoa.cpp:
• platform/mediastream/mac/RealtimeIncomingVideoSourceCocoa.cpp:
• platform/mediastream/mac/RealtimeOutgoingVideoSourceCocoa.cpp:
• platform/mediastream/mac/WebAudioSourceProviderAVFObjC.mm:
• platform/network/HTTPParsers.cpp:
• platform/text/LocaleICU.cpp:
• platform/text/TextCodecLatin1.cpp:
• platform/text/TextCodecUTF8.cpp:
• platform/text/TextEncodingRegistry.cpp:
• platform/text/win/LocaleWin.cpp:
• platform/win/BString.cpp:
• platform/win/KeyEventWin.cpp:
• platform/win/ScrollbarThemeWin.cpp:
• rendering/BidiRun.cpp:
• rendering/FloatingObjects.cpp:
• rendering/RenderBlock.cpp:
• rendering/RenderListMarker.cpp:
• rendering/RenderQuote.cpp:
• rendering/RenderText.cpp:
• rendering/RenderThemeWin.cpp:
• testing/Internals.cpp:
• testing/js/WebCoreTestSupport.cpp:
• workers/WorkerConsoleClient.cpp:
• workers/WorkerGlobalScope.cpp:
• workers/WorkerInspectorProxy.cpp:
• xml/SoftLinkLibxslt.cpp: Added.
• xml/SoftLinkLibxslt.h: Added.
• xml/XPathGrammar.cpp:
• xml/XPathParser.cpp:
• xml/XSLStyleSheetLibxslt.cpp:
• xml/XSLTExtensions.cpp:
• xml/XSLTProcessorLibxslt.cpp:
• xml/XSLTUnicodeSort.cpp:

(xsltTransformErrorTrampoline):
(WebCore::xsltUnicodeSortFunction):

• xml/parser/XMLDocumentParser.cpp:

(WebCore::XMLDocumentParser::updateLeafTextNode):
(WebCore::toString): Deleted.

Source/WebCore/PAL:

Move soft linking code from WebCore to PAL.

• Configurations/FeatureDefines.xcconfig:
• pal/cf/CoreMediaSoftLink.cpp:
• pal/cf/CoreMediaSoftLink.h:
• pal/spi/cocoa/NSAttributedStringSPI.h:

Source/WebKit:

• Configurations/FeatureDefines.xcconfig:

Source/WebKitLegacy/mac:

• Configurations/FeatureDefines.xcconfig:

Source/WTF:

• wtf/Platform.h:
• wtf/cocoa/SoftLinking.h:

Tools:

• TestWebKitAPI/Configurations/FeatureDefines.xcconfig:

12:05 AM Changeset in webkit [223475] by Carlos Garcia Campos

• 3 edits
  1 add in releases/WebKitGTK/webkit-2.18

Merge r222601 - REGRESSION(210837): RegExp containing failed non-zero minimum greedy groups incorrectly match
​https://bugs.webkit.org/show_bug.cgi?id=177570

Reviewed by Filip Pizlo.

JSTests:

New regression test.

• stress/regress-177570.js: Added.

Source/JavaScriptCore:

The change in r210837 neglected to change the check in Interpreter::backtrackParentheses() that
greedy parenthesis have backtracked as far as possible. Prior to r210837 when non-zero minimum greedy
parenthesis were factored into a fixed component and then a zero-based variable component. After
r210837, the variable component is not zero based and the check needs to compare the
backTrack->matchAmount with the quantity iminimum count.

• yarr/YarrInterpreter.cpp:

(JSC::Yarr::Interpreter::backtrackParentheses):

12:04 AM Changeset in webkit [223474] by Carlos Garcia Campos

• 3 edits
  1 add in releases/WebKitGTK/webkit-2.18

Merge r222598 - JSArray::canFastCopy() should fail if the source and destination arrays are the same.
​https://bugs.webkit.org/show_bug.cgi?id=177584
<rdar://problem/34463903>

Reviewed by Saam Barati.

JSTests:

• stress/regress-177584.js: Added.

(assertEqual):
(Array.prototype.Symbol.species):

Source/JavaScriptCore:

If the source and destination arrays are the same, we may be copying overlapping
regions. Hence, we need to take the slow path.

• runtime/JSArrayInlines.h:

(JSC::JSArray::canFastCopy):

12:00 AM Changeset in webkit [223473] by Carlos Garcia Campos

• 5 edits in releases/WebKitGTK/webkit-2.18

Merge r222594 - Deferred image size change makes image-load-on-delay.html flaky.
​https://bugs.webkit.org/show_bug.cgi?id=177520
<rdar://problem/34674299>

Reviewed by Dean Jackson.

Source/WebCore:

Only defer recomputeIsIgnored when the image change actually triggers layout.

• accessibility/AXObjectCache.cpp:

(WebCore::rendererNeedsDeferredUpdate):
(WebCore::AXObjectCache::deferRecomputeIsIgnoredIfNeeded):
(WebCore::AXObjectCache::deferTextChangedIfNeeded):

• accessibility/AXObjectCache.h:

(WebCore::AXObjectCache::deferRecomputeIsIgnoredIfNeeded):

• rendering/RenderImage.cpp:

(WebCore::RenderImage::imageChanged):

LayoutTests:

• platform/mac/TestExpectations:

12:00 AM Changeset in webkit [223472] by Carlos Garcia Campos

• 4 edits in releases/WebKitGTK/webkit-2.18

Merge r222546 - AX: Defer RenderImage's imageChanged event until after layout is done.
​https://bugs.webkit.org/show_bug.cgi?id=177446

Reviewed by Dean Jackson.

Source/WebCore:

This is to avoid unintentional tree mutation during layout.

Covered by existing tests.

• rendering/RenderImage.cpp:

(WebCore::RenderImage::imageChanged):

LayoutTests:

• accessibility/image-load-on-delay.html: