Timeline
Oct 23, 2017:
- 10:13 PM Changeset in webkit [223880] by
-
- 6 edits in trunk/Source/WebKit
[Cocoa] Web Automation: add SPI to tell whether the automation session is currently simulating user interactions
https://bugs.webkit.org/show_bug.cgi?id=178616
Reviewed by Joseph Pecoraro.
This is needed to disambiguate whether an action (such as selectAll:) came from
a user clicking on "Edit > Select All" in a menu or whether it was produced by
simulating the keystrokes to produce the chord for "Command + a". Some clients,
such as Safari, would allow the latter but not the former during automation.
- UIProcess/API/Cocoa/_WKAutomationSession.h:
- UIProcess/API/Cocoa/_WKAutomationSession.mm:
(-[_WKAutomationSession isSimulatingUserInteraction]):
Add new SPI property that's backed by the same WebAutomationSession method.
- UIProcess/Automation/WebAutomationSession.h:
- UIProcess/Automation/WebAutomationSession.cpp:
(WebKit::WebAutomationSession::keyboardEventsFlushedForPage):
(WebKit::WebAutomationSession::performMouseInteraction):
(WebKit::WebAutomationSession::performKeyboardInteractions):
Set m_simulatingUserInteraction prior to sending the synthesized events. It will
be cleared when keyboardEventsFlushedForPage() is called by WebPageProxy.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::didReceiveEvent):
Notify the automation session that the key event queue was flushed *after* giving
delegates a chance to do something with the key event. This is necessary so that
any actions that are created from the NSEvent by the delegates are handled prior
to the automation session finishing its keyboard interaction command.
- 9:23 PM WebKitGTK/Gardening/Calendar edited by
- (diff)
- 9:21 PM Changeset in webkit [223879] by
-
- 2 edits in trunk/LayoutTests
Unreviewed WPE test gardening
- platform/wpe/TestExpectations:
- 9:17 PM Changeset in webkit [223878] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed, restore unneeded all in ones.
- CMakeLists.txt:
- 8:32 PM Changeset in webkit [223877] by
-
- 2 edits in trunk/Source/bmalloc
Unreviewed, roll out r222731
https://bugs.webkit.org/show_bug.cgi?id=177745
<rdar://problem/34773148>
Unfortunately Gigacage has broken core dump generation.
- bmalloc/Gigacage.h:
- 8:26 PM Changeset in webkit [223876] by
-
- 4 edits in trunk/Source/WebCore
Unreviewed, rolling out r223870 and r223871.
https://bugs.webkit.org/show_bug.cgi?id=178702
broke the windows build (Requested by keith_miller on
#webkit).
Reverted changesets:
"Add html, inspector, loader to unified sources"
https://bugs.webkit.org/show_bug.cgi?id=178695
https://trac.webkit.org/changeset/223870
"Unrievwed, fix windows build."
https://trac.webkit.org/changeset/223871
- 8:20 PM Changeset in webkit [223875] by
-
- 19 edits in trunk/Source/JavaScriptCore
Unreviewed, reland r223866
Didn't break the windows build...
Restored changeset:
"WebAssembly: topEntryFrame on Wasm::Instance"
https://bugs.webkit.org/show_bug.cgi?id=178690
https://trac.webkit.org/changeset/223866
- 7:33 PM Changeset in webkit [223874] by
-
- 19 edits in trunk/Source/JavaScriptCore
Unreviewed, rolling out r223866.
https://bugs.webkit.org/show_bug.cgi?id=178699
Probably broke the windows build (Requested by keith_miller on
#webkit).
Reverted changeset:
"WebAssembly: topEntryFrame on Wasm::Instance"
https://bugs.webkit.org/show_bug.cgi?id=178690
https://trac.webkit.org/changeset/223866
- 6:44 PM Changeset in webkit [223873] by
-
- 3 edits in trunk/LayoutTests
Unreviewed test gardening. Try to reduce flakiness of inspector/network/har tests.
- http/tests/inspector/network/har/har-page-expected.txt:
- http/tests/inspector/network/har/har-page.html:
Remove properties which may sometimes be optional.
Filter contents which are shared across tests and might change.
- 6:42 PM Changeset in webkit [223872] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed, attempt to fix initializeSupportedImageMIMETypes after r223860
https://bugs.webkit.org/show_bug.cgi?id=178618
<rdar://problem/35108852>
- platform/MIMETypeRegistry.cpp:
(WebCore::initializeSupportedImageMIMETypes):
- 6:31 PM Changeset in webkit [223871] by
-
- 2 edits in trunk/Source/WebCore
Unrievwed, fix windows build.
- CMakeLists.txt:
- 6:25 PM Changeset in webkit [223870] by
-
- 4 edits in trunk/Source/WebCore
Add html, inspector, loader to unified sources
https://bugs.webkit.org/show_bug.cgi?id=178695
Rubber-stamped by Tim Horton.
- CMakeLists.txt:
- Sources.txt:
- WebCore.xcodeproj/project.pbxproj:
- 6:16 PM Changeset in webkit [223869] by
-
- 3 edits in trunk/Source/WebKit
[Mac] Web Automation: key modifiers for synthesized NSEvents are incorrect
https://bugs.webkit.org/show_bug.cgi?id=178615
Reviewed by Joseph Pecoraro.
In both PLATFORM(MAC) platform methods for simulating keyboard interactions,
we errantly relied on +[NSEvent modifierFlags] to get the current state of
sticky modifiers when creating synthesized events. This is incorrect for two reasons:
modifierFlags is never updated when simulating a sequence of events (because
all the events are synthesized before any are delivered); and the NSEvent class
method only reflects the modifier state of the primary physical keyboard, which
is not affected by synthesized NSEvents that happen to have modifier flags.
Instead, just keep our own m_currentModifiers state in the session and compute
the necessary NSEventModifierFlags to put on each synthesized event. This aligns
the implementation with the treatment of sticky keys in the iOS and GTK platform methods.
- UIProcess/Automation/WebAutomationSession.h: Every port gets this variable now.
- UIProcess/Automation/mac/WebAutomationSessionMac.mm:
(WebKit::WebAutomationSession::platformSimulateKeyStroke):
(WebKit::WebAutomationSession::platformSimulateKeySequence):
Use and update m_currentModifiers.
- 5:55 PM Changeset in webkit [223868] by
-
- 14 edits2 deletes in trunk/Source
Web Inspector: Remove unused Console.setMonitoringXHREnabled
https://bugs.webkit.org/show_bug.cgi?id=178617
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2017-10-23
Reviewed by Sam Weinig.
Source/JavaScriptCore:
- JavaScriptCore.xcodeproj/project.pbxproj:
- Sources.txt:
- inspector/agents/InspectorConsoleAgent.h:
- inspector/agents/JSGlobalObjectConsoleAgent.cpp: Removed.
- inspector/agents/JSGlobalObjectConsoleAgent.h: Removed.
- inspector/protocol/Console.json:
Removed files and method.
- inspector/JSGlobalObjectInspectorController.cpp:
(Inspector::JSGlobalObjectInspectorController::JSGlobalObjectInspectorController):
This can use the base ConsoleAgent now.
Source/WebCore:
- inspector/InspectorInstrumentation.cpp:
(WebCore::InspectorInstrumentation::didFinishXHRLoadingImpl):
- inspector/InspectorInstrumentation.h:
(WebCore::InspectorInstrumentation::didFinishXHRLoading):
- inspector/WebConsoleAgent.cpp:
(WebCore::WebConsoleAgent::setMonitoringXHREnabled): Deleted.
(WebCore::WebConsoleAgent::didFinishXHRLoading): Deleted.
- inspector/WebConsoleAgent.h:
Remove XHR monitoring code.
- xml/XMLHttpRequest.h:
- xml/XMLHttpRequest.cpp:
(WebCore::XMLHttpRequest::send):
(WebCore::XMLHttpRequest::didFinishLoading):
(WebCore::XMLHttpRequest::setLastSendLineAndColumnNumber): Deleted.
- xml/XMLHttpRequest.idl:
Remove now unused state on XHR and ExecState requirement for send().
- 5:35 PM Changeset in webkit [223867] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: Styles Redesign: Inline widgets don't hide when starting editing by tabbing from property name
https://bugs.webkit.org/show_bug.cgi?id=178638
Reviewed by Joseph Pecoraro.
- UserInterface/Views/SpreadsheetStyleProperty.js:
(WI.SpreadsheetStyleProperty.prototype.spreadsheetTextFieldDidBlur):
Blur event on the property name text field caused WI.SpreadsheetStyleProperty.prototype._renderValue,
which displayed inline swatches. Display inline swatches only after blur event on the property value.
- 5:29 PM Changeset in webkit [223866] by
-
- 19 edits in trunk/Source/JavaScriptCore
WebAssembly: topEntryFrame on Wasm::Instance
https://bugs.webkit.org/show_bug.cgi?id=178690
Reviewed by Saam Barati.
topEntryFrame is usually on VM, but for a no-VM WebAssembly we
need to hold topEntryFrame elsewhere, and generated code cannot
hard-code where topEntryFrame live. Do this at creation time of
Wasm::Instance, and then generated code will just load from
wherever Wasm::Instance was told topEntryFrame is. In a JavaScript
embedding this is still from VM, so all of the unwinding machinery
stays the same.
- dfg/DFGOSREntry.cpp:
(JSC::DFG::prepareOSREntry):
- dfg/DFGOSRExit.cpp:
(JSC::DFG::restoreCalleeSavesFromVMEntryFrameCalleeSavesBuffer):
(JSC::DFG::copyCalleeSavesToVMEntryFrameCalleeSavesBuffer):
- ftl/FTLOSRExitCompiler.cpp:
(JSC::FTL::compileStub):
- interpreter/Interpreter.cpp:
(JSC::UnwindFunctor::copyCalleeSavesToEntryFrameCalleeSavesBuffer const):
- jit/AssemblyHelpers.cpp:
(JSC::AssemblyHelpers::restoreCalleeSavesFromEntryFrameCalleeSavesBuffer):
(JSC::AssemblyHelpers::copyCalleeSavesToEntryFrameCalleeSavesBufferImpl):
- jit/AssemblyHelpers.h:
(JSC::AssemblyHelpers::copyCalleeSavesToEntryFrameCalleeSavesBuffer):
The default parameter was never non-defaulted from any of the
callers. The new version calls the impl directly because it
doesn't have VM and doesn't hard-code the address of
topEntryFrame.
- jit/RegisterSet.cpp:
(JSC::RegisterSet::vmCalleeSaveRegisterOffsets): This was weird on
VM because it's not really VM-specific.
- jit/RegisterSet.h:
- runtime/VM.cpp:
(JSC::VM::getAllCalleeSaveRegisterOffsets): Deleted.
- runtime/VM.h:
(JSC::VM::getCTIStub):
- wasm/WasmB3IRGenerator.cpp:
(JSC::Wasm::B3IRGenerator::B3IRGenerator):
(JSC::Wasm::B3IRGenerator::addCall):
(JSC::Wasm::B3IRGenerator::addCallIndirect):
- wasm/WasmInstance.cpp:
(JSC::Wasm::Instance::Instance):
- wasm/WasmInstance.h: topEntryFramePointer will eventually live
here for real. Right now it's mirrored in JSWebAssemblyInstance
because that's the acting Context.
(JSC::Wasm::Instance::create):
(JSC::Wasm::Instance::offsetOfTopEntryFramePointer):
- wasm/WasmThunks.cpp:
(JSC::Wasm::throwExceptionFromWasmThunkGenerator):
- wasm/js/JSWebAssemblyInstance.cpp:
(JSC::JSWebAssemblyInstance::JSWebAssemblyInstance):
- wasm/js/JSWebAssemblyInstance.h: Mirror Wasm::Instance temporarily.
(JSC::JSWebAssemblyInstance::offsetOfCallee):
(JSC::JSWebAssemblyInstance::offsetOfTopEntryFramePointer):
(JSC::JSWebAssemblyInstance::offsetOfVM): Deleted.
- wasm/js/WebAssemblyInstanceConstructor.cpp:
(JSC::constructJSWebAssemblyInstance):
- wasm/js/WebAssemblyPrototype.cpp:
(JSC::instantiate):
- 5:27 PM Changeset in webkit [223865] by
-
- 4 edits in trunk/Source/WebCore
Add dom, editing, fileapi, and history to unified sources
https://bugs.webkit.org/show_bug.cgi?id=178694
Rubber-stamped by Tim Horton.
- CMakeLists.txt:
- Sources.txt:
- WebCore.xcodeproj/project.pbxproj:
- 5:22 PM Changeset in webkit [223864] by
-
- 4 edits in trunk/Websites/perf.webkit.org
Update perf dashboard upload logic to support uploading binaries from owned commits.
https://bugs.webkit.org/show_bug.cgi?id=178610
Reviewed by Ryosuke Niwa.
Update build requests to 'completed' only when all commit set items are satisfied.
Extend 'repositoryList' parameter to be able to specified own commit information.
Items in 'repositoryList' can either be a string for top level repository,
or a dictionary with two keys: 'ownerRepository' and 'ownedRepository'.
- public/api/upload-root.php: Extend upload logic for support uploading binaries from owned commits.
- server-tests/api-upload-root-tests.js: Added unit tests.
- server-tests/tools-sync-buildbot-integration-tests.js: Added unit tests.
- 5:08 PM Changeset in webkit [223863] by
-
- 4 edits in trunk/Source/WebCore
Move bridge, contentextensions, crypto, and css to unified sources.
https://bugs.webkit.org/show_bug.cgi?id=178691
Reviewed by Tim Horton.
- CMakeLists.txt:
- Sources.txt:
- WebCore.xcodeproj/project.pbxproj:
- 4:40 PM Changeset in webkit [223862] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed, fix the Windows build after r223860
UTIUtilities only exists on Cocoa platforms, so we need to guard it accordingly.
- platform/MIMETypeRegistry.cpp:
(WebCore::initializeSupportedImageMIMETypes):
- 4:23 PM Changeset in webkit [223861] by
-
- 2 edits in trunk/Source/WebKit
Fix ASAN test after r222824
https://bugs.webkit.org/show_bug.cgi?id=178688
<rdar://problem/35104706>
Reviewed by Tim Horton.
- UIProcess/WebBackForwardList.cpp:
(WebKit::WebBackForwardList::clear):
Resizing a list of Ref<T> after we've WTFMoved all the elements doesn't make ASAN happy.
- 4:17 PM AddingFiles edited by
- (diff)
- 4:12 PM AddingFiles edited by
- (diff)
- 4:11 PM AddingFiles edited by
- (diff)
- 4:03 PM AddingFiles edited by
- (diff)
- 3:37 PM Changeset in webkit [223860] by
-
- 3 edits in trunk/Source/WebCore
[iOS] DocumentWriter::createDocument can spend ~100ms unnecessarily converting image UTIs to MIME types
https://bugs.webkit.org/show_bug.cgi?id=178618
<rdar://problem/35108852>
Reviewed by Said Abou-Hallawa.
Currently, in setting up a new Document, DocumentWriter::createDocument() always asks whether or not the
Document should be a PDF document by calling MIMETypeRegistry::isPDFMIMEType(), which forces lazy initialization
of every MIME type dictionary (e.g. image types, PDF types, JavaScript types, etc.). As evidenced by traces,
this can be an expensive operation on certain devices.
This patch implements two optimizations. First, we refactor the initializeSupportedImageMIMETypes() helper to
stop asking for MIMETypeForImageSourceType for each of the supported UTIs. This is because the known MIME types
corresponding to these hard-coded UTI types is a fixed set anyways, so we can simply iterate over a constant
array of MIME types and populate the supported image (and image resource) types. Also, add assertions to ensure
that we keep allowed image MIME types in sync with allowed image UTIs.
The second optimization removes initializeMIMETypeRegistry() altogether in favor of calling just the
initialize*MIMETypes() functions needed to ensure the information required. For instance, getPDFMIMETypes()
currently calls initializeMIMETypeRegistry() if the pdfMIMETypes dictionary doesn't exist, when it really only
needs to ensure that the pdfMIMETypes is initialized, for which initializePDFMIMETypes() is sufficient.
- platform/MIMETypeRegistry.cpp:
(WebCore::initializeSupportedImageMIMETypes):
(WebCore::initializeSupportedJavaScriptMIMETypes):
(WebCore::initializePDFMIMETypes):
(WebCore::initializeSupportedNonImageMimeTypes):
(WebCore::initializeUnsupportedTextMIMETypes):
Move MIME type dictionary creation into initialize*MIMETypes() helpers. Additionally, remove
initializePDFAndPostScriptMIMETypes, which is no longer necessary.
(WebCore::MIMETypeRegistry::isSupportedImageMIMEType):
(WebCore::MIMETypeRegistry::isSupportedImageResourceMIMEType):
(WebCore::MIMETypeRegistry::isSupportedJavaScriptMIMEType):
(WebCore::MIMETypeRegistry::isSupportedNonImageMIMEType):
(WebCore::MIMETypeRegistry::isUnsupportedTextMIMEType):
(WebCore::MIMETypeRegistry::isPDFOrPostScriptMIMEType):
Tweak to check that the type isPDFMIMEType(), or that it's otherwise "application/postscript".
(WebCore::MIMETypeRegistry::isPDFMIMEType):
(WebCore::MIMETypeRegistry::getSupportedImageMIMETypes):
(WebCore::MIMETypeRegistry::getSupportedImageResourceMIMETypes):
(WebCore::MIMETypeRegistry::getSupportedNonImageMIMETypes):
(WebCore::MIMETypeRegistry::getPDFMIMETypes):
(WebCore::MIMETypeRegistry::getUnsupportedTextMIMETypes):
Call only the relevant MIME type initializers when needed.
(WebCore::initializePostScriptMIMETypes): Deleted.
(WebCore::initializeMIMETypeRegistry): Deleted.
(WebCore::MIMETypeRegistry::getPDFAndPostScriptMIMETypes): Deleted.
Remove an unused and unexported function.
- platform/MIMETypeRegistry.h:
- 3:30 PM Changeset in webkit [223859] by
-
- 2 edits in trunk/LayoutTests
Multiple imported layout tests are crashing and timing out.
https://bugs.webkit.org/show_bug.cgi?id=178685
Unreviewed.
Patch by Youenn Fablet <youenn@apple.com> on 2017-10-23
- TestExpectations: skipping cache storage tests in service worker context until it is functional.
- 3:14 PM Changeset in webkit [223858] by
-
- 2 edits in trunk/Source/WebCore
[Payment Request] Take the JSC API lock before creating the PaymentResponse.details object
https://bugs.webkit.org/show_bug.cgi?id=178686
Reviewed by Keith Miller.
This fixes several flaky crashes in http/tests/paymentrequest/ after r223855.
- Modules/applepay/paymentrequest/ApplePayPaymentHandler.cpp:
(WebCore::ApplePayPaymentHandler::didAuthorizePayment):
- 2:58 PM Changeset in webkit [223857] by
-
- 3 edits in trunk/Source/WebKit
Stop using _UIApplicationUsesLegacyUI()
https://bugs.webkit.org/show_bug.cgi?id=178680
<rdar://problem/35131949>
Reviewed by Dan Bernstein.
- Platform/spi/ios/UIKitSPI.h:
- UIProcess/ios/forms/WKFormSelectPopover.mm:
(-[WKSelectTableViewController tableView:cellForRowAtIndexPath:]):
(-[WKSelectPopover initWithView:hasGroups:]):
Resolve _UIApplicationUsesLegacyUI to false and simplify.
- 2:34 PM Changeset in webkit [223856] by
-
- 22 edits6 adds in trunk
Web Inspector: Please support HAR Export for network traffic
https://bugs.webkit.org/show_bug.cgi?id=146692
<rdar://problem/7463672>
Reviewed by Brian Burg.
Source/JavaScriptCore:
- inspector/protocol/Network.json:
Add a walltime to each send request.
Source/WebCore:
Tests: http/tests/inspector/network/har/har-basic.html
http/tests/inspector/network/har/har-page.html
- inspector/InspectorNetworkAgent.cpp:
(WebCore::InspectorNetworkAgent::willSendRequest):
Include the wall time when sending a request. This is needed for HAR to
include a wall time, and can be used for Cookie expiration time calculation
as well.
Source/WebInspectorUI:
- UserInterface/Main.html:
- UserInterface/Test.html:
New resources.
- UserInterface/Base/Platform.js:
Include a build number as well.
- UserInterface/Base/URLUtilities.js:
(parseLocationQueryParameters): Deleted.
Remove unused function.
- UserInterface/Controllers/FrameResourceManager.js:
(WI.FrameResourceManager.prototype.frameDidNavigate):
(WI.FrameResourceManager.prototype.resourceRequestWillBeSent):
(WI.FrameResourceManager.prototype.resourceRequestWasServedFromMemoryCache):
(WI.FrameResourceManager.prototype.resourceRequestDidReceiveResponse):
(WI.FrameResourceManager.prototype._addNewResourceToFrameOrTarget):
Pass along a walltime.
- UserInterface/Protocol/NetworkObserver.js:
(WI.NetworkObserver.prototype.requestWillBeSent):
Pass along a walltime. This new parameter shifts old parameters.
- UserInterface/Controllers/HARBuilder.js: Added.
(WI.HARBuilder.async.buildArchive):
(WI.HARBuilder.creator):
(WI.HARBuilder.pages):
(WI.HARBuilder.pageTimings):
(WI.HARBuilder.entry):
(WI.HARBuilder.request):
(WI.HARBuilder.response):
(WI.HARBuilder.cookies):
(WI.HARBuilder.headers):
(WI.HARBuilder.content):
(WI.HARBuilder.postData):
(WI.HARBuilder.cache):
(WI.HARBuilder.timings):
(WI.HARBuilder.ipAddress):
(WI.HARBuilder.date):
(WI.HARBuilder.fetchType):
HAR construction and helpers.
- UserInterface/Models/Cookie.js:
(WI.Cookie.prototype.expirationDate):
- UserInterface/Models/Resource.js:
(WI.Resource.prototype.get queryStringParameters):
(WI.Resource.prototype.get requestFormParameters):
(WI.Resource.prototype.get requestSentWalltime):
(WI.Resource.prototype.get requestSentDate):
(WI.Resource.prototype.hasRequestFormParameters):
Helpers for HAR generation and sub-sets of data.
- UserInterface/Models/SourceCode.js:
(WI.SourceCode.prototype._processContent):
Capture the raw, unmodified, base64 encoded flag and content. This ends
up getting used by HAR generation and is otherwise lost.
- UserInterface/Test/TestHarness.js:
(TestHarness.prototype.json):
Helper for just logging JSON data with a filter. This defaults to
a reasonable 2 space indent for JSON logs in our test output.
- UserInterface/Views/DOMTreeContentView.js:
(WI.DOMTreeContentView.prototype.get saveData):
(WI.DOMTreeContentView.get saveData.saveHandler): Deleted.
Drive-by simplify while looking at other save handlers.
- UserInterface/Views/NetworkTableContentView.js:
(WI.NetworkTableContentView.prototype.get supportsSave):
(WI.NetworkTableContentView.prototype.get saveData):
(WI.NetworkTableContentView.prototype.tableCellContextMenuClicked):
(WI.NetworkTableContentView.prototype._HARResources):
(WI.NetworkTableContentView.prototype._exportHAR):
Provide a context menu and save keyboard handler to export a HAR.
This matches other browsers.
- UserInterface/Views/ResourceClusterContentView.js:
(WI.ResourceClusterContentView.prototype._canShowRequestContentView):
Use code that is now available in Resource.
LayoutTests:
- http/tests/inspector/network/har/har-basic-expected.txt: Added.
- http/tests/inspector/network/har/har-basic.html: Added.
- http/tests/inspector/network/har/har-page-expected.txt: Added.
- http/tests/inspector/network/har/har-page.html: Added.
Tests with mock resources / data and real resources.
- platform/mac-wk1/TestExpectations:
- platform/mac/TestExpectations:
- platform/win/TestExpectations:
Skip on platforms that cannot provide complete metrics, so some optional
fields may be missing.
- 2:00 PM Changeset in webkit [223855] by
-
- 23 edits6 copies14 adds in trunk
[Payment Request] Resolve PaymentRequest.show()'s accept promise when a payment is authorized
https://bugs.webkit.org/show_bug.cgi?id=178609
<rdar://problem/33542813>
Reviewed by Alex Christensen.
Source/WebCore:
This patch implements the logic for resolving PaymentRequest.show()'s accept promise when
the user authorizes a payment, and implements PaymentResponse.complete().
Tests: http/tests/paymentrequest/payment-address-attributes-and-toJSON-method.https.html
http/tests/paymentrequest/payment-response-complete-method.https.html
http/tests/paymentrequest/payment-response-methodName-attribute.https.html
http/tests/paymentrequest/payment-response-payerEmail-attribute.https.html
http/tests/paymentrequest/payment-response-payerName-attribute.https.html
http/tests/paymentrequest/payment-response-payerPhone-attribute.https.html
- DerivedSources.make:
- Modules/applepay/ApplePayPaymentContact.h:
- Modules/applepay/Payment.h:
(WebCore::Payment::Payment): Deleted.
(WebCore::Payment::pkPayment const): Deleted.
- Modules/applepay/PaymentContact.h:
(WebCore::PaymentContact::PaymentContact): Deleted.
(WebCore::PaymentContact::pkContact const): Deleted.
- Modules/applepay/cocoa/PaymentContactCocoa.mm:
(WebCore::convert):
- Modules/applepay/paymentrequest/ApplePayPaymentHandler.cpp:
(WebCore::ApplePayPaymentHandler::hasActiveSession):
(WebCore::ApplePayPaymentHandler::ApplePayPaymentHandler):
(WebCore::ApplePayPaymentHandler::document):
(WebCore::ApplePayPaymentHandler::paymentCoordinator):
(WebCore::ApplePayPaymentHandler::convertData):
(WebCore::ApplePayPaymentHandler::show):
(WebCore::ApplePayPaymentHandler::hide):
(WebCore::ApplePayPaymentHandler::canMakePayment):
(WebCore::ApplePayPaymentHandler::complete):
(WebCore::convert):
(WebCore::ApplePayPaymentHandler::didAuthorizePayment):
(WebCore::ApplePayPaymentHandler::didSelectShippingMethod):
(WebCore::ApplePayPaymentHandler::didSelectShippingContact):
- Modules/applepay/paymentrequest/ApplePayPaymentHandler.h:
- Modules/paymentrequest/PaymentAddress.h:
- Modules/paymentrequest/PaymentAddress.idl:
- Modules/paymentrequest/PaymentHandler.cpp:
(WebCore::PaymentHandler::create):
- Modules/paymentrequest/PaymentHandler.h:
- Modules/paymentrequest/PaymentRequest.cpp:
(WebCore::PaymentRequest::show):
(WebCore::PaymentRequest::stop):
(WebCore::PaymentRequest::canMakePayment):
(WebCore::PaymentRequest::canSuspendForDocumentSuspension const):
(WebCore::PaymentRequest::shippingAddressChanged):
(WebCore::PaymentRequest::shippingOptionChanged):
(WebCore::PaymentRequest::accept):
(WebCore::PaymentRequest::complete):
- Modules/paymentrequest/PaymentRequest.h:
- Modules/paymentrequest/PaymentResponse.cpp:
(WebCore::PaymentResponse::PaymentResponse):
(WebCore::PaymentResponse::complete):
- Modules/paymentrequest/PaymentResponse.h:
- WebCore.xcodeproj/project.pbxproj:
- testing/Internals.cpp:
(WebCore::Internals::Internals):
(WebCore::Internals::mockPaymentCoordinator const):
- testing/Internals.h:
- testing/Internals.idl:
- testing/MockPayment.h: Added.
- testing/MockPaymentAddress.h: Added.
- testing/MockPaymentAddress.idl: Added.
- testing/MockPaymentContact.h: Added.
- testing/MockPaymentCoordinator.cpp:
(WebCore::MockPaymentCoordinator::canMakePaymentsWithActiveCard):
(WebCore::MockPaymentCoordinator::openPaymentSetup):
(WebCore::dispatchIfShowing):
(WebCore::MockPaymentCoordinator::showPaymentUI):
(WebCore::MockPaymentCoordinator::completeMerchantValidation):
(WebCore::MockPaymentCoordinator::completePaymentSession):
(WebCore::MockPaymentCoordinator::abortPaymentSession):
(WebCore::MockPaymentCoordinator::cancelPaymentSession):
(WebCore::MockPaymentCoordinator::paymentCoordinatorDestroyed):
- testing/MockPaymentCoordinator.h:
- testing/MockPaymentCoordinator.idl: Added.
LayoutTests:
- http/tests/paymentrequest/payment-address-attributes-and-toJSON-method.https-expected.txt: Added.
- http/tests/paymentrequest/payment-address-attributes-and-toJSON-method.https.html: Copied from imported/w3c/web-platform-tests/payment-request/PaymentAddress/attributes-and-toJSON-method-manual.https.html.
- http/tests/paymentrequest/payment-response-complete-method.https-expected.txt: Added.
- http/tests/paymentrequest/payment-response-complete-method.https.html: Copied from imported/w3c/web-platform-tests/payment-request/payment-response/complete-method-manual.https.html.
- http/tests/paymentrequest/payment-response-methodName-attribute.https-expected.txt: Added.
- http/tests/paymentrequest/payment-response-methodName-attribute.https.html: Copied from imported/w3c/web-platform-tests/payment-request/payment-response/methodName-attribute-manual.https.html.
- http/tests/paymentrequest/payment-response-payerEmail-attribute.https-expected.txt: Added.
- http/tests/paymentrequest/payment-response-payerEmail-attribute.https.html: Copied from imported/w3c/web-platform-tests/payment-request/payment-response/payerEmail-attribute-manual.https.html.
- http/tests/paymentrequest/payment-response-payerName-attribute.https-expected.txt: Added.
- http/tests/paymentrequest/payment-response-payerName-attribute.https.html: Copied from imported/w3c/web-platform-tests/payment-request/payment-response/payerName-attribute-manual.https.html.
- http/tests/paymentrequest/payment-response-payerPhone-attribute.https-expected.txt: Added.
- http/tests/paymentrequest/payment-response-payerPhone-attribute.https.html: Copied from imported/w3c/web-platform-tests/payment-request/payment-response/payerPhone-attribute-manual.https.html.
- http/tests/paymentrequest/resources/helpers.js: Copied from imported/w3c/web-platform-tests/payment-request/payment-response/helpers.js.
(test):
(async.getPaymentResponse):
(async.getPaymentRequestResponse):
(async.runTest):
- 1:59 PM Changeset in webkit [223854] by
-
- 2 edits in trunk/Source/WebCore
Attempt to stop iOS Simulator tests from failing because
we don't support Accelerated ImageBuffer.
- html/ImageBitmap.cpp:
- 1:42 PM Changeset in webkit [223853] by
-
- 3 edits in trunk/Source/WebCore
[FrameView::layout cleanup] Make m_subtreeLayoutRoot weak.
https://bugs.webkit.org/show_bug.cgi?id=178621
<rdar://problem/35110321>
Reviewed by Simon Fraser.
This patch turn m_subtreeLayoutRoot into a weak pointer to handle both the optional and the mutation cases.
Covered by existing cases.
- page/FrameView.cpp:
(WebCore::FrameView::reset):
(WebCore::FrameView::willDestroyRenderTree):
(WebCore::FrameView::didDestroyRenderTree):
(WebCore::FrameView::calculateScrollbarModesForLayout):
(WebCore::FrameView::handleLayoutWithFrameFlatteningIfNeeded):
(WebCore::FrameView::canPerformLayout const):
(WebCore::FrameView::layout): WeakPtr<RenderElement> protects us from recursive layouts triggering UAF on layoutRoot.
(WebCore::FrameView::convertSubtreeLayoutToFullLayout):
(WebCore::FrameView::scheduleRelayout):
(WebCore::FrameView::scheduleRelayoutOfSubtree):
(WebCore::FrameView::needsLayout const):
(WebCore::FrameView::autoSizeIfEnabled):
- page/FrameView.h:
- 1:40 PM Changeset in webkit [223852] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed, fix windows build.
- CMakeLists.txt:
- 1:37 PM WebKitGTK/2.18.x edited by
- (diff)
- 1:32 PM Changeset in webkit [223851] by
-
- 2 edits in trunk/Source/WebKit
Unreviewed, suppress deprecation warnings to fix the build.
<rdar://problem/35131949>
- UIProcess/ios/forms/WKFormSelectPopover.mm:
(-[WKSelectTableViewController tableView:cellForRowAtIndexPath:]):
(-[WKSelectPopover initWithView:hasGroups:]):
- 1:23 PM Changeset in webkit [223850] by
-
- 4 edits in trunk/Source/WebCore
Move shared accessibility and animiations files to unified sources.
https://bugs.webkit.org/show_bug.cgi?id=178677
Reviewed by Tim Horton.
- Sources.txt:
- WebCore.xcodeproj/project.pbxproj:
- 12:36 PM Changeset in webkit [223849] by
-
- 16 edits2 adds in trunk
Drop confusing Event::dispatched() method
https://bugs.webkit.org/show_bug.cgi?id=178670
Reviewed by Youenn Fablet.
Source/WebCore:
Drop confusing Event::dispatched() method. What the call sites want to do is check
that the Event's "dispatch" flag is set:
This flag gets set at the beginning of dispatchEvent() and unset at the end of
dispatchEvent():
See as an example event.initEvent():
The right way to check the Event's "dispatch" flag is the Event::isBeingDispatched()
method, so use this instead. One side effect of this change is that it is now
possible to call the init*Event() method on events that have already been dispatched
in order to dispatch them again, as per the specification.
Test: fast/events/initEvent-after-dispatching.html
- dom/CompositionEvent.cpp:
(WebCore::CompositionEvent::initCompositionEvent):
- dom/DeviceMotionEvent.cpp:
(WebCore::DeviceMotionEvent::initDeviceMotionEvent):
- dom/DeviceOrientationEvent.cpp:
(WebCore::DeviceOrientationEvent::initDeviceOrientationEvent):
- dom/Event.h:
- dom/HashChangeEvent.h:
- dom/KeyboardEvent.cpp:
(WebCore::KeyboardEvent::initKeyboardEvent):
- dom/MessageEvent.cpp:
(WebCore::MessageEvent::initMessageEvent):
- dom/MouseEvent.cpp:
(WebCore::MouseEvent::initMouseEvent):
- dom/OverflowEvent.cpp:
(WebCore::OverflowEvent::initOverflowEvent):
- dom/TextEvent.cpp:
(WebCore::TextEvent::initTextEvent):
- dom/TouchEvent.cpp:
(WebCore::TouchEvent::initTouchEvent):
- dom/UIEvent.cpp:
(WebCore::UIEvent::initUIEvent):
- dom/WheelEvent.cpp:
(WebCore::WheelEvent::initWheelEvent):
- storage/StorageEvent.cpp:
(WebCore::StorageEvent::initStorageEvent):
LayoutTests:
Add layout test coverage.
- fast/events/initEvent-after-dispatching-expected.txt: Added.
- fast/events/initEvent-after-dispatching.html: Added.
- 11:59 AM Changeset in webkit [223848] by
-
- 8 edits in trunk
Remember previous child renderer during render tree update
https://bugs.webkit.org/show_bug.cgi?id=178659
Reviewed by Zalan Bujtas.
Source/WebCore:
We shouldn't need to recompute the previous renderer, we know it already.
- style/RenderTreePosition.cpp:
(WebCore::RenderTreePosition::previousSiblingRenderer const): Deleted.
No longer needed. This was also subtly wrong as doesn't take display:contents into account.
- style/RenderTreePosition.h:
- style/RenderTreeUpdater.cpp:
(WebCore::RenderTreeUpdater::updateRenderTree):
(WebCore::RenderTreeUpdater::textRendererIsNeeded):
Use the saved previous renderer.
(WebCore::RenderTreeUpdater::updateTextRenderer):
(WebCore::RenderTreeUpdater::storePreviousRenderer):
Save the previous renderere as we walk the tree.
(WebCore::textRendererIsNeeded): Deleted.
- style/RenderTreeUpdater.h:
LayoutTests:
- fast/block/float/float-not-removed-from-pre-block-expected.txt:
- platform/mac/fast/css-generated-content/details-summary-before-after-expected.txt:
- 11:57 AM Changeset in webkit [223847] by
-
- 4 edits in trunk/Source/WebCore
Add Shared Modules files to the unified source build.
https://bugs.webkit.org/show_bug.cgi?id=178675
Reviewed by Tim Horton.
This patch all the Modules sources files shared across all ports to
unified sources.
- CMakeLists.txt:
- Sources.txt:
- WebCore.xcodeproj/project.pbxproj:
- 11:42 AM Changeset in webkit [223846] by
-
- 2 edits in trunk/Tools
<rdar://problem/35045445>
Update README to reference WebKit build archives, instead of 'nightly'
Reviewed by Aakash Jain.
- WebKitArchiveSupport/README:
- 11:10 AM Changeset in webkit [223845] by
-
- 3 edits4 adds in trunk/LayoutTests
Add tests to ensure spelling error dots are drawn in the correct place in bottom-to-top
and right-to-left writing modes
https://bugs.webkit.org/show_bug.cgi?id=178671
Reviewed by Simon Fraser.
- fast/writing-mode/english-bt-text-with-spelling-marker-expected.html: Added.
- fast/writing-mode/english-bt-text-with-spelling-marker.html: Added.
- fast/writing-mode/english-rl-text-with-spelling-marker-expected.html: Added.
- fast/writing-mode/english-rl-text-with-spelling-marker.html: Added.
- platform/ios/TestExpectations: Skip the test on iOS as it does not support spelling and grammar
marker painting.
- platform/mac-wk2/TestExpectations: Mark the test as an image failure until we fix <https://bugs.webkit.org/show_bug.cgi?id=105616>.
- 10:56 AM Changeset in webkit [223844] by
-
- 2 edits in trunk/Source/bmalloc
bmalloc::api::tryLargeMemalignVirtual() shouldn't assert on a failed allocation
https://bugs.webkit.org/show_bug.cgi?id=178654
Reviewed by Geoffrey Garen.
- bmalloc/bmalloc.h:
(bmalloc::api::tryLargeMemalignVirtual): Call Heap::tryAllocateLarge()
instead of Heap::allocateLarge(). The former will return a null pointer
upon a failed allocation, allowing the caller to fail gracefully just as
the API entrypoint implies, while the latter currently provokes a crash
in these circumstances.
- 10:51 AM Changeset in webkit [223843] by
-
- 9 edits4 adds in trunk
Implement drawImage(ImageBitmap) on 2d canvas
https://bugs.webkit.org/show_bug.cgi?id=178653
<rdar://problem/35104360>
Reviewed by Antoine Quint.
LayoutTests/imported/w3c:
Update expected results now that drawImage is implemented.
- web-platform-tests/2dcontext/imagebitmap/createImageBitmap-drawImage-expected.txt:
Source/WebCore:
Implement CanvasRenderingContext2D::drawImage with ImageBitmap.
It's probably not going to be a very common operation, but
it importantly allows us to test the ImageBitmap creation
code.
Test: http/wpt/2dcontext/imagebitmap/drawImage-ImageBitmap.html
- html/ImageBitmap.cpp:
(WebCore::taintsOrigin): New helper function to determine if a
CachedImage would provide a clean origin.
(WebCore::ImageBitmap::createPromise): Set the flag that records
if this ImageBitmap has a clean origin.
- html/ImageBitmap.h:
(WebCore::ImageBitmap::buffer): Exposes the ImageBuffer backing
store, allowing access to the data for drawing.
(WebCore::ImageBitmap::originClean const): Is this ImageBitmap
going to taint a destination.
- html/canvas/CanvasRenderingContext.cpp:
(WebCore::CanvasRenderingContext::wouldTaintOrigin): Implement
the ImageBitmap version of this template function.
- html/canvas/CanvasRenderingContext.h:
- html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::drawImage): Implement the
actual drawing of an ImageBitmap.
LayoutTests:
Add a new test that exercises drawImage(ImageBitmap)
that will be contributed back to Web Platform Tests.
- http/wpt/2dcontext/imagebitmap/common.js: Copied (mostly) from WPT.
(create9x9CanvasWith2dContext): New helper function to create a canvas
and provide a rendering context.
- http/wpt/2dcontext/imagebitmap/drawImage-ImageBitmap-expected.txt: Added.
- http/wpt/2dcontext/imagebitmap/drawImage-ImageBitmap.html: Added.
- http/wpt/2dcontext/imagebitmap/target-blue-dot.png: Added.
- 10:49 AM Changeset in webkit [223842] by
-
- 3 edits4 adds in trunk/LayoutTests
Add tests to ensure spelling error dots are drawn in the correct place for overlapping lines
https://bugs.webkit.org/show_bug.cgi?id=178611
<rdar://problem/35105805>
Reviewed by Zalan Bujtas.
Add tests to ensure that we paint the spelling error dots in the correct place for
overlapping lines.
- editing/spelling/spelling-markers-in-overlapping-lines-expected.html: Added.
- editing/spelling/spelling-markers-in-overlapping-lines-large-font-expected.html: Added.
- editing/spelling/spelling-markers-in-overlapping-lines-large-font.html: Added.
- editing/spelling/spelling-markers-in-overlapping-lines.html: Added.
- platform/ios/TestExpectations: Skip the test on iOS as it does not support spelling and grammar
marker painting.
- platform/mac-wk2/TestExpectations: Mark the test as an image failure until we fix <https://bugs.webkit.org/show_bug.cgi?id=105616>.
- 10:35 AM Changeset in webkit [223841] by
-
- 2 edits839 adds in trunk/LayoutTests
Unreviewed WPE gardening. Unskip the SVG tests and generate the
required platform-specific baselines.
- platform/wpe/TestExpectations:
- platform/wpe/svg: Added ~800 baselines.
- 10:28 AM Changeset in webkit [223840] by
-
- 3 edits in trunk/Source/WebCore
Unreviewed, rolling out r223699.
Caused regressions with right-to-left text selection and
painting of markers in flipped writing mode and in overlapping
lines. Will investigate offline.
Reverted changeset:
"Share logic in InlineTextBox to compute selection rect"
https://bugs.webkit.org/show_bug.cgi?id=178232
https://trac.webkit.org/changeset/223699
- 10:25 AM Changeset in webkit [223839] by
-
- 27 edits2 copies2 adds in trunk
Source/WebCore:
Create a Fetch event when ServiceWorker has to handle a fetch
https://bugs.webkit.org/show_bug.cgi?id=178491
Patch by Youenn Fablet <youenn@apple.com> on 2017-10-23
Reviewed by Chris Dumez.
Covered by existing test.
Updating FetchEvent to pass a FetchResponse* within its onResponse callback.
Making it a CompletionHandler.
Fixing a check on respondWith to ensure that event is dispatched when respondWith is called.
Adding ServiceWorkerFetch class to handle the creation of the fetch event, waiting for the fetch event to be responded
and processing when fetch event is responded.
ServiceWorkerFetchTask takes a client to which will be sent the response body or the error.
WebKit implementation of it will be to send the related IPC message back to the WebProcess that made the fetch request.
Adding a method to ServiceWorkerThread to create the fetch event on worker thread and dispatch on the global scope.
- WebCore.xcodeproj/project.pbxproj:
- platform/network/ResourceResponseBase.h:
- testing/Internals.cpp:
(WebCore::Internals::waitForFetchEventToFinish):
- workers/service/FetchEvent.cpp:
(WebCore::FetchEvent::~FetchEvent):
(WebCore::FetchEvent::respondWith):
(WebCore::FetchEvent::onResponse):
(WebCore::FetchEvent::respondWithError):
(WebCore::FetchEvent::processResponse):
(WebCore::FetchEvent::promiseIsSettled):
- workers/service/FetchEvent.h:
- workers/service/context/ServiceWorkerFetch.cpp: Added.
(WebCore::ServiceWorkerFetch::dispatchFetchTask):
(WebCore::ServiceWorkerFetch::processResponse):
- workers/service/context/ServiceWorkerFetch.h: Added.
- workers/service/context/ServiceWorkerThread.cpp:
(WebCore::m_workerObjectProxy):
(WebCore::ServiceWorkerThread::dispatchFetchEvent):
- workers/service/context/ServiceWorkerThread.h:
Source/WebKit:
TestController should clear all fetch caches when resetting its state
https://bugs.webkit.org/show_bug.cgi?id=178486
<rdar://problem/35066305>
Patch by Youenn Fablet <youenn@apple.com> on 2017-10-23
Reviewed by Chris Dumez.
Adding a new DidNotHandle message to disambiguate with the DidFail fetch case.
With DidNotHandle, the loading should go the network process.
With DidFail, the loading should return a network error.
On receiving an order to start a fetch, ServiceWorkerThread will dispatch a fetch event.
The client of this event will retrieve the response and return it to the WebProcess through IPC.
- StorageProcess/ServiceWorker/WebSWServerConnection.cpp:
(WebKit::WebSWServerConnection::didNotHandleFetch):
- StorageProcess/ServiceWorker/WebSWServerConnection.h:
- StorageProcess/StorageProcess.cpp:
(WebKit::StorageProcess::didNotHandleFetch):
- StorageProcess/StorageProcess.h:
- StorageProcess/StorageProcess.messages.in:
- WebKit.xcodeproj/project.pbxproj:
- WebProcess/Storage/ServiceWorkerClientFetch.cpp:
(WebKit::ServiceWorkerClientFetch::didFail):
(WebKit::ServiceWorkerClientFetch::didNotHandle):
- WebProcess/Storage/ServiceWorkerClientFetch.h:
- WebProcess/Storage/ServiceWorkerClientFetch.messages.in:
- WebProcess/Storage/ServiceWorkerContextManager.cpp:
(WebKit::ServiceWorkerContextManager::startFetch):
- WebProcess/Storage/ServiceWorkerContextManager.h:
- WebProcess/Storage/WebServiceWorkerFetchTaskClient.cpp: Added.
(WebKit::WebServiceWorkerFetchTaskClient::~WebServiceWorkerFetchTaskClient):
(WebKit::WebServiceWorkerFetchTaskClient::WebServiceWorkerFetchTaskClient):
(WebKit::WebServiceWorkerFetchTaskClient::didReceiveResponse):
(WebKit::WebServiceWorkerFetchTaskClient::didReceiveData):
(WebKit::WebServiceWorkerFetchTaskClient::didFail):
(WebKit::WebServiceWorkerFetchTaskClient::didFinish):
- WebProcess/Storage/WebServiceWorkerFetchTaskClient.h: Added.
- WebProcess/WebProcess.cpp:
(WebKit::WebProcess::startFetchInServiceWorker):
- WebProcess/WebProcess.h:
LayoutTests:
TestController should clear all fetch caches when resetting its state
https://bugs.webkit.org/show_bug.cgi?id=178486
<rdar://problem/35066305>
Patch by Youenn Fablet <youenn@apple.com> on 2017-10-23
Reviewed by Chris Dumez.
Beefing up the test by using fetch event handler to return responses
previously hard coded in ServiceWorkerContextManager.
- http/tests/workers/service/basic-fetch.https-expected.txt:
- http/tests/workers/service/resources/basic-fetch-worker.js:
(event.event.request.url.indexOf):
- http/tests/workers/service/resources/basic-fetch.js:
- 10:21 AM Changeset in webkit [223838] by
-
- 5 edits in trunk/Source/WebCore
[Curl] Fix authentication related bugs
https://bugs.webkit.org/show_bug.cgi?id=178652
Patch by Basuke Suzuki <Basuke Suzuki> on 2017-10-23
Reviewed by Alex Christensen.
- platform/network/curl/AuthenticationChallengeCurl.cpp:
(WebCore::AuthenticationChallenge::protectionSpaceFromHandle):
- platform/network/curl/CurlContext.cpp:
(WebCore::CurlHandle::setHttpAuthUserPass):
- platform/network/curl/CurlRequest.cpp:
(WebCore::CurlRequest::setUserPass):
(WebCore::CurlRequest::setupTransfer):
(WebCore::CurlRequest::didReceiveHeader):
- platform/network/curl/CurlRequest.h:
- 10:10 AM Changeset in webkit [223837] by
-
- 2 edits in trunk/LayoutTests
Mark compositing/visible-rect/iframe-no-layers.html as a flaky failure.
https://bugs.webkit.org/show_bug.cgi?id=178669
Unreviewed test gardening.
- platform/ios/TestExpectations:
- 9:44 AM Changeset in webkit [223836] by
-
- 14 edits2 adds in trunk/Source
Unreviewed, rolling out r223820.
This caused a build break on Windows.
Reverted changeset:
"Web Inspector: Remove unused Console.setMonitoringXHREnabled"
https://bugs.webkit.org/show_bug.cgi?id=178617
https://trac.webkit.org/changeset/223820
- 8:57 AM Changeset in webkit [223835] by
-
- 4 edits in trunk/Source/WebCore
Call FrameView::scheduleSelectionUpdate when selection needs repainting after layout instead of setting the RenderView dirty.
https://bugs.webkit.org/show_bug.cgi?id=178651
<rdar://problem/35117448>
Reviewed by Antti Koivisto.
Calling setNeedsLayout() on the RenderView to trigger selection update is problematic in 2 different ways:
- marking the root renderer dirty does not trigger layout (this is very specific to the root,
other renderers do trigger layout). It means that it works as long as someone else schedules a layout.
- when a subtree layout is already scheduled and we mark the root renderer dirty, the root gets stuck with
the dirty flag (since the entry point for the subsequent layout is a descendant of the root and not the root itself).
This patch addresses these issues by scheduling/converting subtree layout when needed.
Covered by fast/dynamic/remove-invisible-node-inside-selection.html/remove-node-inside-selection.html
- editing/FrameSelection.cpp:
(WebCore::FrameSelection::respondToNodeModification):
- page/FrameView.cpp:
(WebCore::FrameView::scheduleSelectionUpdate):
- page/FrameView.h:
- 4:50 AM Changeset in webkit [223834] by
-
- 6 edits4 adds in trunk
[JSC] Use fastJoin in Array#toString
https://bugs.webkit.org/show_bug.cgi?id=178062
Reviewed by Darin Adler.
JSTests:
- microbenchmarks/contiguous-array-to-string.js: Added.
(target):
- microbenchmarks/double-array-to-string.js: Added.
(target):
- microbenchmarks/int32-array-to-string.js: Added.
(target):
Source/JavaScriptCore:
Array#toString()'s fast path uses original join operation.
But this should use fastJoin if possible.
This patch adds a fast path using fastJoin in Array#toString.
And we also extend fastJoin to perform fast joining for int32
arrays.
baseline patched
double-array-to-string 126.6157+-5.8625 103.7343+-4.4968 definitely 1.2206x faster
int32-array-to-string 64.7792+-2.6524 61.2390+-2.1749 might be 1.0578x faster
contiguous-array-to-string 62.6224+-2.6388 56.9899+-2.0852 definitely 1.0988x faster
- runtime/ArrayPrototype.cpp:
(JSC::fastJoin):
(JSC::arrayProtoFuncToString):
(JSC::arrayProtoFuncToLocaleString):
- runtime/JSStringJoiner.h:
(JSC::JSStringJoiner::appendWithoutSideEffects):
(JSC::JSStringJoiner::appendInt32):
(JSC::JSStringJoiner::appendDouble):
Source/WTF:
A bit cleaning up to use StringImpl::copyChars instead of
using for-loop directly.
- wtf/text/StringView.h:
(WTF::StringView::getCharactersWithUpconvert const):
- 3:11 AM Changeset in webkit [223833] by
-
- 6 edits in trunk/Source/WebCore
[TexMap] Remove GraphicsContext3D usage from TextureMapperShaderProgram
https://bugs.webkit.org/show_bug.cgi?id=175425
Reviewed by Žan Doberšek.
Remove usage of the GraphicsContext3D class in TextureMapperShaderProgram.
Direct OpenGL API calls, types and constants are used instead.
By removing GraphicsContext3D, we don't use ANGLE anymore to perform the
shader adaptation to the used OpenGL/GLES2 version, so we need to do that
inside TextureMapperShaderProgram. The main changes required for this are
adding the #version directive and use in/out to define input/output parameters
when using OpenGL >= 3.2, and defining the default precision only when using
GLES2.
Besides that, now that VideoTextureCopierGStreamer doesn't have its own
GraphicsContext3D, we need to add a VAO to it when using OpenGL >= 3.2.
Based on a previous patch by Žan Doberšek <zdobersek@igalia.com>.
No behavior change.
- platform/graphics/gstreamer/VideoTextureCopierGStreamer.cpp:
(WebCore::VideoTextureCopierGStreamer::VideoTextureCopierGStreamer):
(WebCore::VideoTextureCopierGStreamer::~VideoTextureCopierGStreamer):
(WebCore::VideoTextureCopierGStreamer::copyVideoTextureToPlatformTexture):
- platform/graphics/gstreamer/VideoTextureCopierGStreamer.h:
- platform/graphics/texmap/TextureMapperGL.cpp:
(WebCore::TextureMapperGLData::getShaderProgram):
(WebCore::prepareFilterProgram):
(WebCore::TextureMapperGL::drawTexture):
(WebCore::TextureMapperGL::drawFiltered):
- platform/graphics/texmap/TextureMapperShaderProgram.cpp:
(WebCore::TextureMapperShaderProgram::create):
(WebCore::getShaderLog):
(WebCore::getProgramLog):
(WebCore::TextureMapperShaderProgram::TextureMapperShaderProgram):
(WebCore::TextureMapperShaderProgram::~TextureMapperShaderProgram):
(WebCore::TextureMapperShaderProgram::setMatrix):
(WebCore::TextureMapperShaderProgram::getLocation):
- platform/graphics/texmap/TextureMapperShaderProgram.h:
(WebCore::TextureMapperShaderProgram::programID const):
Oct 22, 2017:
- 10:27 PM Changeset in webkit [223832] by
-
- 2 edits in trunk/JSTests
stress/check-string-ident.js is improperly skipped
https://bugs.webkit.org/show_bug.cgi?id=178642
Reviewed by Saam Barati.
- stress/check-string-ident.js: Drop the defaultNoEagerRun directive
since it enforces the run-jsc-stress-tests script to still set up the
test to run, despite the skip directive that's used before.
- 10:26 PM Changeset in webkit [223831] by
-
- 2 edits in trunk/Source/JavaScriptCore
[JSC] Remove !(OS(LINUX) && CPU(ARM64)) guards in RegisterState.h
https://bugs.webkit.org/show_bug.cgi?id=178452
Reviewed by Yusuke Suzuki.
- heap/RegisterState.h: Re-enable the custom RegisterState and
ALLOCATE_AND_GET_REGISTER_STATE definitions on ARM64 Linux. These don't
cause any crashes nowadays.
- 8:38 PM Changeset in webkit [223830] by
-
- 7 edits in tags/Safari-604.4.5.1/Source
Versioning.
- 8:24 PM Changeset in webkit [223829] by
-
- 1 copy in tags/Safari-604.4.5.1
New tag.
- 8:13 PM Changeset in webkit [223828] by
-
- 5 edits8 adds3 deletes in trunk/Source/WebCore
[Settings] Replace current Settings generation with template file based approach
https://bugs.webkit.org/show_bug.cgi?id=178634
Patch by Sam Weinig <sam@webkit.org> on 2017-10-22
Reviewed by Joseph Pecoraro.
This replaces the recently added python based Settings generation with a generator
built in ruby, so we can take advantage of ERB for templating. The result has much
of the logic in the templates and as a result feels much easier to follow and cleaner.
Since I was moving things to ruby, I took the opertunity to switch the Settings definition
file from our .in format to yaml, which is quite a bit easier to read.
- CMakeLists.txt:
- DerivedSources.make:
- Scripts/GenerateSettings: Removed.
- Scripts/GenerateSettings.py: Removed.
- Scripts/GenerateSettings.rb: Added.
- Scripts/GenerateSettings/GenerateInternalSettingsHeaderFile.py: Removed.
- Scripts/GenerateSettings/GenerateInternalSettingsIDLFile.py: Removed.
- Scripts/GenerateSettings/GenerateInternalSettingsImplementationFile.py: Removed.
- Scripts/GenerateSettings/GenerateSettings.py: Removed.
- Scripts/GenerateSettings/GenerateSettingsHeaderFile.py: Removed.
- Scripts/GenerateSettings/GenerateSettingsImplementationFile.py: Removed.
- Scripts/GenerateSettings/Settings.py: Removed.
- Scripts/GenerateSettings/init.py: Removed.
- Scripts/SettingsTemplates: Added.
- Scripts/SettingsTemplates/InternalSettingsGenerated.cpp.erb: Added.
- Scripts/SettingsTemplates/InternalSettingsGenerated.h.erb: Added.
- Scripts/SettingsTemplates/InternalSettingsGenerated.idl.erb: Added.
- Scripts/SettingsTemplates/Settings.cpp.erb: Added.
- Scripts/SettingsTemplates/Settings.h.erb: Added.
- WebCore.xcodeproj/project.pbxproj:
- WebCoreMacros.cmake:
- page/Settings.in: Removed.
- page/Settings.yaml: Added.
- 7:20 PM Changeset in webkit [223827] by
-
- 6 edits in trunk/Source/WebKit
[iOS] WebProcess::initializeWebProcess spends ~150ms spinning up AVSystemController on some devices
https://bugs.webkit.org/show_bug.cgi?id=178640
<rdar://problem/35113105>
Reviewed by Youenn Fablet.
In r213933, we added a mechanism to allow the web process to drive media capture, by setting an attribute on the
shared AVSystemController. This requires us to fault in the Celestial framework, which is a slight performance
hit on some hardware. Instead of doing this at the start of every web process launch, we can just do this work
lazily, the first time the web process requests permissions for user media access.
- WebProcess/WebCoreSupport/WebUserMediaClient.cpp:
(WebKit::WebUserMediaClient::requestUserMediaAccess):
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::prepareToSendUserMediaPermissionRequest):
- WebProcess/WebPage/WebPage.h:
- WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::prepareToSendUserMediaPermissionRequest):
- WebProcess/cocoa/WebProcessCocoa.mm:
(WebKit::WebProcess::platformInitializeWebProcess):
- 5:43 PM Changeset in webkit [223826] by
-
- 5 edits2 adds in trunk
REGRESSION(r219675): Web Inspector: CommandLineAPI getEventListeners does not work
https://bugs.webkit.org/show_bug.cgi?id=178650
<rdar://problem/35116347>
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2017-10-22
Reviewed by Sam Weinig.
Source/WebCore:
Test: inspector/console/command-line-api-getEventListeners.html
- inspector/CommandLineAPIHost.cpp:
(WebCore::listenerEntriesFromListenerInfo):
Fix typo.
(WebCore::CommandLineAPIHost::getEventListeners):
Fix incorrect early return.
- inspector/CommandLineAPIHost.h:
- inspector/CommandLineAPIHost.idl:
Add more attributes about the listener. These new attributes match output from Chrome.
LayoutTests:
- inspector/console/command-line-api-getEventListeners-expected.txt: Added.
- inspector/console/command-line-api-getEventListeners.html: Added.
- 2:31 PM Changeset in webkit [223825] by
-
- 10 edits2 adds in trunk
[Web Animations] Add animations to the timeline
https://bugs.webkit.org/show_bug.cgi?id=178643
Patch by Antoine Quint <Antoine Quint> on 2017-10-22
Reviewed by Dean Jackson.
Source/WebCore:
If a timeline is provided as a parameter to the Animation constructor,
add it to the timeline, and remove it when the object is destroyed.
We also start the basic mechanism to dump the contents of a timeline
as text for testing purposes, currently only logging the number of
animations in a timeline and just logging the class name for animation
themselves.
Test: webanimations/animation-creation-addition.html
- animation/AnimationTimeline.cpp:
(WebCore::AnimationTimeline::description):
- animation/AnimationTimeline.h:
- animation/AnimationTimeline.idl:
- animation/WebAnimation.cpp:
(WebCore::WebAnimation::create):
(WebCore::WebAnimation::~WebAnimation):
(WebCore::WebAnimation::description):
- animation/WebAnimation.h:
- testing/Internals.cpp:
(WebCore::Internals::timelineDescription):
- testing/Internals.h:
- testing/Internals.idl:
LayoutTests:
Add a new test that checks that animations created with a timeline
are added to the provided timeline.
- webanimations/animation-creation-addition-expected.txt: Added.
- webanimations/animation-creation-addition.html: Added.
- 11:28 AM Changeset in webkit [223824] by
-
- 11 edits in trunk/Source/JavaScriptCore
[JSC][Baseline] Use linkAllSlowCasesForBytecodeOffset as much as possible to simplify slow cases handling
https://bugs.webkit.org/show_bug.cgi?id=178647
Reviewed by Saam Barati.
There is much code counting slow cases in fast paths to call
linkSlowCasecarefully. This is really error-prone
since the number of slow cases depends on values of instruction's metadata. We have linkAllSlowCasesForBytecodeOffset,
which drains all slow cases for a specified bytecode offset. In typical cases like just calling a slow path function,
this is enough. We use linkAllSlowCasesForBytecodeOffset as much as possible. It significantly simplifies the code.
- jit/JIT.h:
(JSC::JIT::linkAllSlowCases):
- jit/JITArithmetic.cpp:
(JSC::JIT::emitSlow_op_unsigned):
(JSC::JIT::emit_compareAndJump):
(JSC::JIT::emit_compareAndJumpSlow):
(JSC::JIT::emitSlow_op_inc):
(JSC::JIT::emitSlow_op_dec):
(JSC::JIT::emitSlow_op_mod):
(JSC::JIT::emitSlow_op_negate):
(JSC::JIT::emitSlow_op_bitand):
(JSC::JIT::emitSlow_op_bitor):
(JSC::JIT::emitSlow_op_bitxor):
(JSC::JIT::emitSlow_op_lshift):
(JSC::JIT::emitSlow_op_rshift):
(JSC::JIT::emitSlow_op_urshift):
(JSC::JIT::emitSlow_op_add):
(JSC::JIT::emitSlow_op_div):
(JSC::JIT::emitSlow_op_mul):
(JSC::JIT::emitSlow_op_sub):
- jit/JITArithmetic32_64.cpp:
(JSC::JIT::emit_compareAndJumpSlow):
(JSC::JIT::emitSlow_op_unsigned):
(JSC::JIT::emitSlow_op_inc):
(JSC::JIT::emitSlow_op_dec):
(JSC::JIT::emitSlow_op_mod):
- jit/JITCall.cpp:
(JSC::JIT::compileCallEvalSlowCase):
(JSC::JIT::compileOpCallSlowCase):
- jit/JITCall32_64.cpp:
(JSC::JIT::compileCallEvalSlowCase):
(JSC::JIT::compileOpCallSlowCase):
- jit/JITInlines.h:
(JSC::JIT::linkAllSlowCasesForBytecodeOffset):
- jit/JITOpcodes.cpp:
(JSC::JIT::emitSlow_op_new_object):
(JSC::JIT::emitSlow_op_create_this):
(JSC::JIT::emitSlow_op_check_tdz):
(JSC::JIT::emitSlow_op_to_this):
(JSC::JIT::emitSlow_op_to_primitive):
(JSC::JIT::emitSlow_op_not):
(JSC::JIT::emitSlow_op_eq):
(JSC::JIT::emitSlow_op_neq):
(JSC::JIT::emitSlow_op_stricteq):
(JSC::JIT::emitSlow_op_nstricteq):
(JSC::JIT::emitSlow_op_instanceof):
(JSC::JIT::emitSlow_op_instanceof_custom):
(JSC::JIT::emitSlow_op_to_number):
(JSC::JIT::emitSlow_op_to_string):
(JSC::JIT::emitSlow_op_loop_hint):
(JSC::JIT::emitSlow_op_check_traps):
(JSC::JIT::emitSlow_op_has_indexed_property):
(JSC::JIT::emitSlow_op_get_direct_pname):
(JSC::JIT::emitSlow_op_has_structure_property):
- jit/JITOpcodes32_64.cpp:
(JSC::JIT::emitSlow_op_new_object):
(JSC::JIT::emitSlow_op_instanceof):
(JSC::JIT::emitSlow_op_instanceof_custom):
(JSC::JIT::emitSlow_op_to_primitive):
(JSC::JIT::emitSlow_op_not):
(JSC::JIT::emitSlow_op_stricteq):
(JSC::JIT::emitSlow_op_nstricteq):
(JSC::JIT::emitSlow_op_to_number):
(JSC::JIT::emitSlow_op_to_string):
(JSC::JIT::emitSlow_op_create_this):
(JSC::JIT::emitSlow_op_to_this):
(JSC::JIT::emitSlow_op_check_tdz):
(JSC::JIT::emitSlow_op_has_indexed_property):
(JSC::JIT::emitSlow_op_get_direct_pname):
- jit/JITPropertyAccess.cpp:
(JSC::JIT::emitSlow_op_try_get_by_id):
(JSC::JIT::emitSlow_op_get_by_id):
(JSC::JIT::emitSlow_op_get_by_id_with_this):
(JSC::JIT::emitSlow_op_put_by_id):
(JSC::JIT::emitSlow_op_resolve_scope):
(JSC::JIT::emitSlow_op_get_from_scope):
(JSC::JIT::emitSlow_op_put_to_scope):
- jit/JITPropertyAccess32_64.cpp:
(JSC::JIT::emitSlow_op_try_get_by_id):
(JSC::JIT::emitSlow_op_get_by_id):
(JSC::JIT::emitSlow_op_get_by_id_with_this):
(JSC::JIT::emitSlow_op_put_by_id):
(JSC::JIT::emitSlow_op_resolve_scope):
(JSC::JIT::emitSlow_op_get_from_scope):
(JSC::JIT::emitSlow_op_put_to_scope):
- 9:47 AM Changeset in webkit [223823] by
-
- 9 edits in trunk/Source/JavaScriptCore
[JSC] Clean up baseline slow path
https://bugs.webkit.org/show_bug.cgi?id=178646
Reviewed by Saam Barati.
If the given op is just calling a slow path function, we should use DEFINE_SLOW_OP instead.
It is good since (1) we can reduce the manual emitting code and (2) it can clarify which
function is implemented as a slow path call. This patch is an attempt to reduce 32bit specific
code in baseline JIT.
- jit/JIT.cpp:
(JSC::JIT::privateCompileMainPass):
- jit/JIT.h:
- jit/JITArithmetic.cpp:
(JSC::JIT::emit_op_pow): Deleted.
- jit/JITArithmetic32_64.cpp:
(JSC::JIT::emitSlow_op_mod):
- jit/JITOpcodes.cpp:
(JSC::JIT::emit_op_strcat): Deleted.
(JSC::JIT::emit_op_push_with_scope): Deleted.
(JSC::JIT::emit_op_assert): Deleted.
(JSC::JIT::emit_op_create_lexical_environment): Deleted.
(JSC::JIT::emit_op_throw_static_error): Deleted.
(JSC::JIT::emit_op_new_array_with_spread): Deleted.
(JSC::JIT::emit_op_spread): Deleted.
(JSC::JIT::emit_op_get_enumerable_length): Deleted.
(JSC::JIT::emit_op_has_generic_property): Deleted.
(JSC::JIT::emit_op_get_property_enumerator): Deleted.
(JSC::JIT::emit_op_to_index_string): Deleted.
(JSC::JIT::emit_op_create_direct_arguments): Deleted.
(JSC::JIT::emit_op_create_scoped_arguments): Deleted.
(JSC::JIT::emit_op_create_cloned_arguments): Deleted.
(JSC::JIT::emit_op_create_rest): Deleted.
(JSC::JIT::emit_op_unreachable): Deleted.
- jit/JITOpcodes32_64.cpp:
(JSC::JIT::emit_op_strcat): Deleted.
(JSC::JIT::emit_op_push_with_scope): Deleted.
(JSC::JIT::emit_op_assert): Deleted.
(JSC::JIT::emit_op_create_lexical_environment): Deleted.
- jit/JITPropertyAccess.cpp:
(JSC::JIT::emit_op_put_by_val_with_this): Deleted.
(JSC::JIT::emit_op_get_by_val_with_this): Deleted.
(JSC::JIT::emit_op_put_by_id_with_this): Deleted.
(JSC::JIT::emit_op_resolve_scope_for_hoisting_func_decl_in_eval): Deleted.
(JSC::JIT::emit_op_define_data_property): Deleted.
(JSC::JIT::emit_op_define_accessor_property): Deleted.
- jit/JITPropertyAccess32_64.cpp:
(JSC::JIT::emit_op_resolve_scope_for_hoisting_func_decl_in_eval): Deleted.
(JSC::JIT::emit_op_get_by_val_with_this): Deleted.
(JSC::JIT::emit_op_put_by_id_with_this): Deleted.
(JSC::JIT::emit_op_put_by_val_with_this): Deleted.
