Timeline

Nov 4, 2017:

10:40 PM Changeset in webkit [224465] by Simon Fraser

• 3 edits in trunk/Source/WebCore

Move code that maps a CompositeOperator and BlendMode to a CGBlendMode into a helper function
​https://bugs.webkit.org/show_bug.cgi?id=179290

Reviewed by Darin Adler.

Move the code, and use nested switch rather than conditionals.

• platform/graphics/GraphicsTypes.h:
• platform/graphics/cg/GraphicsContextCG.cpp:

(WebCore::compositeAndBlendToCGBlendMode):
(WebCore::GraphicsContext::setPlatformCompositeOperation):

5:54 PM Changeset in webkit [224464] by Chris Dumez

• 9 edits in trunk

Index properties on cross origin Window objects should be enumerable
​https://bugs.webkit.org/show_bug.cgi?id=179289

Reviewed by Darin Adler.

LayoutTests/imported/w3c:

Re-sync WPT test after:

• ​https://github.com/w3c/web-platform-tests/pull/8045

Rebaseline a couple of WPT tests now that more checks are passing.

• web-platform-tests/html/browsers/origin/cross-origin-objects/cross-origin-objects-expected.txt:
• web-platform-tests/html/browsers/origin/cross-origin-objects/cross-origin-objects.html:
• web-platform-tests/html/browsers/the-window-object/window-indexed-properties-expected.txt:

Source/WebCore:

Index properties on cross origin Window objects should be enumerable:

• ​https://github.com/whatwg/html/pull/3186
• ​https://github.com/w3c/web-platform-tests/pull/8045

All exposed properties used to be enumerable but we had to revert this in
r224287 because it was not Web-compatible. The HTML specification has now
been updated so that only index properties are enumerable cross origin.

No new tests, rebaselined existing tests.

• bindings/js/JSDOMWindowCustom.cpp:

(WebCore::JSDOMWindow::getOwnPropertySlotByIndex):
(WebCore::JSDOMWindow::getOwnPropertyNames):

LayoutTests:

Update / rebaseline existing test to match new expected behavior.

• js/dom/getOwnPropertyDescriptor-expected.txt:
• js/resources/getOwnPropertyDescriptor.js:

4:43 PM Changeset in webkit [224463] by Simon Fraser

• 14 edits
  2 adds in trunk/Source/WebCore

Add a GraphicsContextImpl and use it for DispayList::Recorder
​https://bugs.webkit.org/show_bug.cgi?id=179286

Reviewed by Sam Weinig.

Start moving towards a model when GraphicsContext has a pointer to an implementation
("pimpl") by adding GraphicsContextImpl, and converting display list recording to
be an implementation of a GraphicsContextImpl.

No behavior change.

• Sources.txt:
• WebCore.xcodeproj/project.pbxproj:
• html/canvas/CanvasRenderingContext2D.cpp:

(WebCore::DisplayListDrawingContext::DisplayListDrawingContext):

• platform/graphics/GraphicsContext.cpp:

(WebCore::GraphicsContext::GraphicsContext):
(WebCore::GraphicsContext::save):
(WebCore::GraphicsContext::restore):
(WebCore::GraphicsContext::setStrokeThickness):
(WebCore::GraphicsContext::setStrokeStyle):
(WebCore::GraphicsContext::setStrokeColor):
(WebCore::GraphicsContext::setShadow):
(WebCore::GraphicsContext::setLegacyShadow):
(WebCore::GraphicsContext::clearShadow):
(WebCore::GraphicsContext::setFillColor):
(WebCore::GraphicsContext::setShadowsIgnoreTransforms):
(WebCore::GraphicsContext::setShouldAntialias):
(WebCore::GraphicsContext::setShouldSmoothFonts):
(WebCore::GraphicsContext::setShouldSubpixelQuantizeFonts):
(WebCore::GraphicsContext::setImageInterpolationQuality):
(WebCore::GraphicsContext::setStrokePattern):
(WebCore::GraphicsContext::setFillPattern):
(WebCore::GraphicsContext::setStrokeGradient):
(WebCore::GraphicsContext::setFillRule):
(WebCore::GraphicsContext::setFillGradient):
(WebCore::GraphicsContext::beginTransparencyLayer):
(WebCore::GraphicsContext::endTransparencyLayer):
(WebCore::GraphicsContext::drawGlyphs):
(WebCore::GraphicsContext::drawImage):
(WebCore::GraphicsContext::drawTiledImage):
(WebCore::GraphicsContext::setTextDrawingMode):
(WebCore::GraphicsContext::fillRect):
(WebCore::GraphicsContext::fillRoundedRect):
(WebCore::GraphicsContext::setAlpha):
(WebCore::GraphicsContext::setCompositeOperation):
(WebCore::GraphicsContext::setDrawLuminanceMask):
(WebCore::GraphicsContext::applyDeviceScaleFactor):
(WebCore::GraphicsContext::fillEllipse):
(WebCore::GraphicsContext::strokeEllipse):

• platform/graphics/GraphicsContext.h:

(WebCore::GraphicsContext::hasPlatformContext const):
(WebCore::GraphicsContext::paintingDisabled const):
(WebCore::GraphicsContext::setDisplayListRecorder): Deleted.
(WebCore::GraphicsContext::isRecording const): Deleted.

• platform/graphics/GraphicsContextImpl.cpp: Added.

(WebCore::GraphicsContextImpl::GraphicsContextImpl):
(WebCore::GraphicsContextImpl::~GraphicsContextImpl):

• platform/graphics/GraphicsContextImpl.h: Added.

(WebCore::GraphicsContextImpl::graphicsContext const):

• platform/graphics/ca/GraphicsLayerCA.cpp:

(WebCore::GraphicsLayerCA::recursiveCommitChanges):

• platform/graphics/cairo/GraphicsContextCairo.cpp:

(WebCore::GraphicsContext::getCTM const):
(WebCore::GraphicsContext::savePlatformState):
(WebCore::GraphicsContext::restorePlatformState):
(WebCore::GraphicsContext::drawRect):
(WebCore::GraphicsContext::drawNativeImage):
(WebCore::GraphicsContext::drawLine):
(WebCore::GraphicsContext::drawEllipse):
(WebCore::GraphicsContext::fillPath):
(WebCore::GraphicsContext::strokePath):
(WebCore::GraphicsContext::fillRect):
(WebCore::GraphicsContext::clip):
(WebCore::GraphicsContext::clipPath):
(WebCore::GraphicsContext::clipBounds const):
(WebCore::GraphicsContext::drawLinesForText):
(WebCore::GraphicsContext::roundToDevicePixels):
(WebCore::GraphicsContext::translate):
(WebCore::GraphicsContext::setPlatformStrokeThickness):
(WebCore::GraphicsContext::setPlatformStrokeStyle):
(WebCore::GraphicsContext::concatCTM):
(WebCore::GraphicsContext::setCTM):
(WebCore::GraphicsContext::beginPlatformTransparencyLayer):
(WebCore::GraphicsContext::endPlatformTransparencyLayer):
(WebCore::GraphicsContext::clearRect):
(WebCore::GraphicsContext::strokeRect):
(WebCore::GraphicsContext::setLineCap):
(WebCore::GraphicsContext::setLineDash):
(WebCore::GraphicsContext::setLineJoin):
(WebCore::GraphicsContext::setMiterLimit):
(WebCore::GraphicsContext::clipOut):
(WebCore::GraphicsContext::rotate):
(WebCore::GraphicsContext::scale):
(WebCore::GraphicsContext::platformFillRoundedRect):
(WebCore::GraphicsContext::fillRectWithRoundedHole):
(WebCore::GraphicsContext::drawPattern):
(WebCore::GraphicsContext::setPlatformShouldAntialias):
(WebCore::GraphicsContext::setPlatformImageInterpolationQuality):
(WebCore::GraphicsContext::isAcceleratedContext const):

• platform/graphics/cg/GraphicsContextCG.cpp:

(WebCore::GraphicsContext::savePlatformState):
(WebCore::GraphicsContext::restorePlatformState):
(WebCore::GraphicsContext::drawNativeImage):
(WebCore::GraphicsContext::drawPattern):
(WebCore::GraphicsContext::drawRect):
(WebCore::GraphicsContext::drawLine):
(WebCore::GraphicsContext::drawEllipse):
(WebCore::GraphicsContext::applyStrokePattern):
(WebCore::GraphicsContext::applyFillPattern):
(WebCore::GraphicsContext::drawPath):
(WebCore::GraphicsContext::fillPath):
(WebCore::GraphicsContext::strokePath):
(WebCore::GraphicsContext::fillRect):
(WebCore::GraphicsContext::platformFillRoundedRect):
(WebCore::GraphicsContext::fillRectWithRoundedHole):
(WebCore::GraphicsContext::clip):
(WebCore::GraphicsContext::clipOut):
(WebCore::GraphicsContext::clipPath):
(WebCore::GraphicsContext::clipBounds const):
(WebCore::GraphicsContext::beginPlatformTransparencyLayer):
(WebCore::GraphicsContext::endPlatformTransparencyLayer):
(WebCore::GraphicsContext::setPlatformShadow):
(WebCore::GraphicsContext::setMiterLimit):
(WebCore::GraphicsContext::clearRect):
(WebCore::GraphicsContext::strokeRect):
(WebCore::GraphicsContext::setLineCap):
(WebCore::GraphicsContext::setLineDash):
(WebCore::GraphicsContext::setLineJoin):
(WebCore::GraphicsContext::scale):
(WebCore::GraphicsContext::rotate):
(WebCore::GraphicsContext::translate):
(WebCore::GraphicsContext::concatCTM):
(WebCore::GraphicsContext::setCTM):
(WebCore::GraphicsContext::getCTM const):
(WebCore::GraphicsContext::roundToDevicePixels):
(WebCore::GraphicsContext::drawLinesForText):
(WebCore::GraphicsContext::setURLForRect):
(WebCore::GraphicsContext::setIsCALayerContext):
(WebCore::GraphicsContext::isCALayerContext const):
(WebCore::GraphicsContext::setIsAcceleratedContext):
(WebCore::GraphicsContext::isAcceleratedContext const):
(WebCore::GraphicsContext::setPlatformTextDrawingMode):
(WebCore::GraphicsContext::setPlatformStrokeColor):
(WebCore::GraphicsContext::setPlatformStrokeThickness):
(WebCore::GraphicsContext::setPlatformFillColor):
(WebCore::GraphicsContext::setPlatformShouldAntialias):
(WebCore::GraphicsContext::setPlatformShouldSmoothFonts):
(WebCore::GraphicsContext::setPlatformAlpha):
(WebCore::GraphicsContext::setPlatformCompositeOperation):
(WebCore::GraphicsContext::platformApplyDeviceScaleFactor):
(WebCore::GraphicsContext::platformFillEllipse):
(WebCore::GraphicsContext::platformStrokeEllipse):
(WebCore::GraphicsContext::setDestinationForRect):
(WebCore::GraphicsContext::addDestinationAtPoint):

• platform/graphics/cocoa/GraphicsContextCocoa.mm:

(WebCore::GraphicsContext::drawFocusRing):

• platform/graphics/displaylists/DisplayListRecorder.cpp:

(WebCore::DisplayList::Recorder::Recorder):
(WebCore::DisplayList::Recorder::updateItemExtent const):
(WebCore::DisplayList::Recorder::extentFromLocalBounds const):

• platform/graphics/displaylists/DisplayListRecorder.h:

(WebCore::DisplayList::Recorder::itemCount const):

• rendering/RenderTheme.cpp:

(WebCore::RenderTheme::paint):

4:01 PM Changeset in webkit [224462] by Chris Dumez

• 4 edits in trunk/Source/WebKit

REGRESSION(r223718): Leaking WebProcessPool after reconfiguration
​https://bugs.webkit.org/show_bug.cgi?id=179123
<rdar://problem/35294685>

Reviewed by Geoff Garen.

Make sure we destroy the ServiceWorker WebProcess once all other WebProcesses
go away at there is no use keeping it running at this point. Also, this prevents
leaking the WebProcessPool since the WebProcessProxy holds a strong reference
to the WebProcessPool.

• UIProcess/WebProcessPool.cpp:

(WebKit::WebProcessPool::disconnectProcess):

3:02 PM Changeset in webkit [224461] by Alan Bujtas

• 6 edits in trunk/Source/WebCore

[LayoutState cleanup] Move all LayoutState* classes to LayoutState.h/cpp
​https://bugs.webkit.org/show_bug.cgi?id=179280
<rdar://problem/35348452>

Reviewed by Antti Koivisto.

No change in functionality.

• page/LayoutContext.cpp:

(WebCore::SubtreeLayoutStateMaintainer::SubtreeLayoutStateMaintainer): Deleted.
(WebCore::SubtreeLayoutStateMaintainer::~SubtreeLayoutStateMaintainer): Deleted.
(WebCore::SubtreeLayoutStateMaintainer::shouldDisableLayoutStateForSubtree): Deleted.

• rendering/LayoutState.cpp:

(WebCore::LayoutStateMaintainer::LayoutStateMaintainer):
(WebCore::LayoutStateMaintainer::~LayoutStateMaintainer):
(WebCore::LayoutStateMaintainer::push):
(WebCore::LayoutStateMaintainer::pop):
(WebCore::LayoutStateDisabler::LayoutStateDisabler):
(WebCore::LayoutStateDisabler::~LayoutStateDisabler):
(WebCore::shouldDisableLayoutStateForSubtree):
(WebCore::SubtreeLayoutStateMaintainer::SubtreeLayoutStateMaintainer):
(WebCore::SubtreeLayoutStateMaintainer::~SubtreeLayoutStateMaintainer):
(WebCore::PaginatedLayoutStateMaintainer::PaginatedLayoutStateMaintainer):
(WebCore::PaginatedLayoutStateMaintainer::~PaginatedLayoutStateMaintainer):

• rendering/LayoutState.h:

(WebCore::LayoutStateMaintainer::didPush const):

• rendering/RenderBlockFlow.cpp:

(WebCore::PaginatedLayoutStateMaintainer::PaginatedLayoutStateMaintainer): Deleted.
(WebCore::PaginatedLayoutStateMaintainer::~PaginatedLayoutStateMaintainer): Deleted.
(): Deleted.

• rendering/RenderView.h:

(WebCore::LayoutStateMaintainer::LayoutStateMaintainer): Deleted.
(WebCore::LayoutStateMaintainer::~LayoutStateMaintainer): Deleted.
(WebCore::LayoutStateMaintainer::push): Deleted.
(WebCore::LayoutStateMaintainer::pop): Deleted.
(WebCore::LayoutStateMaintainer::didPush const): Deleted.
(WebCore::LayoutStateDisabler::LayoutStateDisabler): Deleted.
(WebCore::LayoutStateDisabler::~LayoutStateDisabler): Deleted.

2:41 PM Changeset in webkit [224460] by Alan Bujtas

• 3 edits in trunk/Source/WebCore

[LayoutState cleanup] Move offset/cliprect/pagination code to dedicate methods
​https://bugs.webkit.org/show_bug.cgi?id=179279
<rdar://problem/35348171>

Reviewed by Antti Koivisto.

This is in preparation for creating the initial LayoutSate through LayoutStateMaintainer.

Moving code around. No change in functionality.

• rendering/LayoutState.cpp:

(WebCore::LayoutState::LayoutState):
(WebCore::LayoutState::computeOffsets):
(WebCore::LayoutState::computeClipRect):
(WebCore::LayoutState::computePaginationInformation):

• rendering/LayoutState.h:

2:19 PM Changeset in webkit [224459] by Darin Adler

• 61 edits
  2 deletes in trunk/Source

Simplify event dispatch code and make it a bit more consistent
​https://bugs.webkit.org/show_bug.cgi?id=178991

Reviewed by Chris Dumez.

Source/WebCore:

Straighten out event dispatch code in three ways:

1) Add an Event::resetAfterDispatch function, and use it instead of the multiple

separate functions that were used before to reset after dispatching. This fixed
an extremely minor bug where we would leave some kinds of state on some event
objects in unusual cases after dispatching the events.

2) Remove IDBEventDispatcher and make its callers use EventDispatcher instead.

This leaves us with one less event dispatch code path to maintain, more shared code.

3) Remove boolean return values from functions that take event objects and

dispatch the events. The return values are redundant with various things that
can be checked by looking at the event itself. The legacy return value indicates
whether the event has its "canceled flag" set, which means that the default
behavior should be prevented. If that is what we need to check, it's easier
to read the code and see that it's correct if it calls the named function
"defaultPrevented" directly. More importantly, callers can also call whatever
other function is appropriate to ask the specific relevant question to their needs.
The general rule is that default behavior that we want to allow even with an
untrusted event can be inside a default event handler function. Default behavior
that should only happen for the browser-generated event can and should be done
after dispatching the event, in the code that dispatches it; but that requires
explicitly checking "defaultPrevented".

• Modules/indexeddb/IDBDatabase.cpp:

(WebCore::IDBDatabase::dispatchEvent): Removed boolean return value.

• Modules/indexeddb/IDBDatabase.h: Ditto.

• Modules/indexeddb/IDBEventDispatcher.cpp: Removed.
• Modules/indexeddb/IDBEventDispatcher.h: Removed.

• Modules/indexeddb/IDBOpenDBRequest.cpp:

(WebCore::IDBOpenDBRequest::dispatchEvent): Removed boolean return value.
Added protection for "this" since the function accesses it after dispatching the event.

• Modules/indexeddb/IDBOpenDBRequest.h: Ditto.

• Modules/indexeddb/IDBRequest.cpp:

(WebCore::IDBRequest::dispatchEvent): Removed boolean return value. Instead of using
IDBEventDispatcher, use EventDispatcher's new function that takes an initializer_list
with a list of event targets. Added protection for "this" since the function accesses
it after dispatching the event.

• Modules/indexeddb/IDBRequest.h: Ditto.
• Modules/indexeddb/IDBTransaction.cpp:

(WebCore::IDBTransaction::dispatchEvent): Ditto.

• Modules/indexeddb/IDBTransaction.h: Ditto.

• Modules/mediastream/RTCPeerConnection.cpp:

(WebCore::RTCPeerConnection::dispatchEvent): Removed boolean return value.

• Modules/mediastream/RTCPeerConnection.h: Ditto.
• Modules/paymentrequest/PaymentRequest.cpp:

(WebCore::PaymentRequest::shippingAddressChanged): Don't dispatch an event if
m_isUpdating is true; preserves behavior that was implemented in
PaymentRequest::dispatchEvent before. Since this is the source of the trusted
event, cleaner to implement the rule here instead of overriding dispatchEvent.
(WebCore::PaymentRequest::shippingOptionChanged): Ditto.
(WebCore::PaymentRequest::dispatchEvent): Deleted.

• Modules/paymentrequest/PaymentRequest.h: Ditto.

• Sources.txt: Removed IDBEventDispatcher.cpp.
• WebCore.xcodeproj/project.pbxproj: Removed IDBEventDispatcher.h/cpp.

• dom/Element.cpp:

(WebCore::Element::dispatchMouseEvent): Updated to call defaultPrevented
directly instead of using the return value of dispatchEvent.
(WebCore::Element::dispatchWheelEvent): Ditto.
(WebCore::Element::dispatchKeyEvent): Ditto.
(WebCore::Element::dispatchFocusInEvent): Removed assertion, since the
underlying event dispatching takes care of it.
(WebCore::Element::dispatchFocusOutEvent): Ditto.
(WebCore::Element::dispatchFocusEvent): Call dispatchEvent instead of
calling EventDispatcher::dispatchEvent. There is no good reason to use
EventDispatcher directly.
(WebCore::Element::dispatchBlurEvent): Ditto.

• dom/Event.cpp:

(WebCore::Event::eventInterface const): Deleted. Moved into header since this is
short and if called in a non-polymorphic context it's good to have it be inlined.
(WebCore::Event::isUIEvent const): Ditto.
(WebCore::Event::isMouseEvent const): Ditto.
(WebCore::Event::isFocusEvent const): Ditto.
(WebCore::Event::isKeyboardEvent const): Ditto.
(WebCore::Event::isInputEvent const): Ditto.
(WebCore::Event::isCompositionEvent const): Ditto.
(WebCore::Event::isTouchEvent const): Ditto.
(WebCore::Event::isClipboardEvent const): Ditto.
(WebCore::Event::isBeforeTextInsertedEvent const): Ditto.
(WebCore::Event::isBeforeUnloadEvent const): Ditto.
(WebCore::Event::isErrorEvent const): Ditto.
(WebCore::Event::isTextEvent const): Ditto.
(WebCore::Event::isWheelEvent const): Ditto.
(WebCore::Event::receivedTarget): Ditto.
(WebCore::Event::resetAfterDispatch): Added. Replaces functions like
clearEventPath and resetPropagationFlags, covering all the things we need to clear
after dispatching an event.

• dom/Event.h: Removed some unneeded includes and forward declarations. Moved bodies

of multi-line inline member functions out of the class definition. Changed argument
type of setEventPhase and m_eventPhase to an enum rather than just an integer, since
only the getter is for use from the bindings. Removed clearEventPath, srcElement, and
resetPropagationFlags. Sorted the isXXX functions alphabetically and removed previous
attempts to make categories out of them. Marked the constructor explicit since it has
a single argument. Moved trivially short bodies into the class definition.

• dom/Event.idl: Use ImplementedAs to implement srcElement so we don't need it in

the C++ code.

• dom/EventContext.cpp:

(WebCore::EventContext::EventContext): Removed assertion since we now handle event
contexts without nodes so we can use this to dispatch events for IDB, for example.
(WebCore::EventContext::handleLocalEvents const): Add code to handle non-node event
targets by calling fireEventListeners directly.
(WebCore::MouseOrFocusEventContext::MouseOrFocusEventContext): Take a reference
insetad of a pointer for the node.
(WebCore::TouchEventContext::TouchEventContext): Ditto.
(WebCore::TouchEventContext::handleLocalEvents const): Streamline a bit by improving
the checkReachability function to be easier to call. Also removed an unneeded assertion
just before calling downcast<>, the same assertion that downcast<> itself does.
(WebCore::TouchEventContext::checkReachability const): Chagned argument type to take
a Ref& so the caller doesn't have to call get() or ptr().

• dom/EventContext.h: Removed unneeded FIXME and currentTargetSameAsTarget function.

Changed arguemnt types to use Node& instead of Node* as appropriate. Removed unused
functions from TouchEventContext, made more private, and changed data members to Ref
instead of RefPtr. Removed unused NotTouchList value from TouchListType enumeration.
Changed touchList function to return a reference instead of a pointer.

• dom/EventDispatcher.cpp: Removed unneeded includes.

(WebCore::dispatchEventInDOM): Removed use of currentTargetSameAsTarget since it's
clearer if written out.
(WebCore::EventDispatcher::dispatchEvent): Changed no-event dispatch assertion to
use RELEASE_ASSERT_WITH_SECURITY_IMPLICATION since the style checker says so, but
it still doesn't assert anything in release builds because the check in
NoEventDispatchAssertion itself is debug-only. Moved the calls to EventPath's
setRelatedTarget and retargetTouchLists functions inside the EventPath constructor.
Removed the second no-event dispatch assertion because we only need one. Replaced
calls to clearEventPath, setCurrentTarget(nullptr), resetPropagationFlags,
and setEventPhase(NONE) and with a call to resetAfterDispatch. Moved the code that
temporarily sets the target to a different value when calling default event handlers
into the block that calls the default event handlers. Added a new overload that
takes an initializer list of event targets so we can dispatch events that are not
being sent to nodes.

• dom/EventDispatcher.h: Fixed misleading copyright dates and names since this file

just contains a couple of function declarations. Added new overload of dispatchEvent.

• dom/EventPath.cpp:

(WebCore::WindowEventContext::WindowEventContext): Take references instead of pointers.
(WebCore::EventPath::EventPath): Moved the bulk of construction into a new function
named buildPath, so it can still use "return" without skipping the additions here.
Added calls to setRelatedTarget and retargetTouchLists and now both can be private.
Also added a new overload that takes event targets that are not nodes.
(WebCore::EventPath::buildPath): Added. Contains what used to be in the constructor.
But use some references instead of pointers and refactor a bit using lambdas.
(WebCore::EventPath::retargetTouchList): Added. Makes the retargetTouchLists function
shorter and less repetetive.
(WebCore::EventPath::retargetTouchLists): Updated to call retargetTouchList.
(WebCore::EventPath::hasEventListeners const): Deleted. This was unused.

• dom/EventPath.h: Added a constructor that takes an initializer list of event targets.

Made retargetTouchEvents and setRelatedTarget private and used them in the constructor
insead of expecting clients to call them. Removed unused hasEventListeners and
lastContextIfExists functions. Moved body of the eventTargetRespectingTargetRules
function out of the class definition.

• dom/EventTarget.cpp:

(WebCore::EventTarget::dispatchEventForBindings): Updated so it does not expect
dispatchEvent to return a boolean. Instead call a function on the event after dispatching.
Decided to use legacyReturnValue instead of !defaultPrevented, because this is exactly
the return value that the returnValue property is referring to.
(WebCore::EventTarget::dispatchEvent): Removed return value. Replaced calls to
resetPropagationFlags and setEventPhase(NONE) with a call to resetAfterDispatch.
I noticed that there was a local boolean here named "defaultPrevented", which was
backwards; the value in that local was "default not prevented". Doesn't matter since
the boolean return value was removed.
(WebCore::EventTarget::fireEventListeners): Removed the boolean return value.

• dom/EventTarget.h: Added initial values to members of ListenerOptions and

AddEventListenerOptions; maybe we can get rid of the constructors some day.
Removed booelan return values from dispatchEvent and fireEventListeners.

• dom/KeyboardEvent.cpp: Removed unneeded include of EventDispatcher.h.

• dom/Node.cpp:

(WebCore::Node::dispatchEvent): Got rid of boolean return value.
Removed special case code that sometimes called dispatchTouchEvent, since that
just turns around and calls EventDispatcher::dispatchEvent just like this function.
(WebCore::Node::dispatchDOMActivateEvent): Removed boolean return value, removed
integer detail argument and moved the logic to compute the value of the detail
peroprty and to call setDefaultHandled on the underlying click event in here.
This is a private helper function used only in one place.
(WebCore::Node::dispatchTouchEvent): Deleted.
(WebCore::Node::defaultEventHandler): Updated for change to dispatchDOMActivateEvent.

• dom/Node.h: Updated for the above changes.

• dom/RejectedPromiseTracker.cpp:

(WebCore::RejectedPromiseTracker::reportUnhandledRejections): Use defaultPrevented
directly instead of the return value from dispatchEvent.

• dom/ScopedEventQueue.cpp:

(WebCore::ScopedEventQueue::enqueueEvent): Moved assertions here ...
(WebCore::ScopedEventQueue::dispatchEvent const): ... from here. Also changed this
to call Node::dispatchEvent instead of calling EventDispatcher::dispatchEvent directly.

• dom/SimulatedClick.cpp:

(WebCore::simulateMouseEvent): Call Element::dispatchEvent instead of calling
EventDispatcher::dispatchEvent directly.

• editing/Editor.cpp:

(WebCore::dispatchBeforeInputEvent): Use defaultPrevented directly instead of the
return value from dispatchEvent.

• editing/FrameSelection.cpp:

(WebCore::FrameSelection::selectAll): Ditto.
(WebCore::FrameSelection::dispatchSelectStart): Ditto.

• html/CheckboxInputType.cpp:

(WebCore::CheckboxInputType::didDispatchClick): Take a reference instead of a pointer.

• html/CheckboxInputType.h: Updated for above and to use final instead of override.

• html/HTMLFormControlElement.cpp:

(WebCore::HTMLFormControlElement::checkValidity): Use defaultPrevented directly instead
of the return value from dispatchEvent.

• html/HTMLFormElement.cpp:

(WebCore::HTMLFormElement::prepareForSubmission): Use defaultPrevented directly instead
of the return value from dispatchEvent.
(WebCore::HTMLFormElement::reset): Ditto.

• html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::didDispatchClickEvent): Updated to pass references instead
of pointer.

• html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::dispatchEvent): Got rid of boolean return value.

• html/HTMLMediaElement.h: Ditto.

• html/HTMLPlugInElement.h: Use "delete" instead of just a private function for something

that should never be called.

• html/InputType.cpp:

(WebCore::InputType::didDispatchClick): Take a reference instead of a pointer.

• html/InputType.h: Ditto.
• html/RadioInputType.cpp:

(WebCore::RadioInputType::didDispatchClick): Ditto.

• html/RadioInputType.h: Updated for above and to use final instead of override.

• html/track/TextTrackCue.cpp:

(WebCore::TextTrackCue::dispatchEvent): Got rid of boolean return value.

• html/track/TextTrackCue.h: Ditto.

• inspector/InspectorInstrumentation.cpp: Removed unneeded include of EventDispatcher.h.

• page/DOMWindow.cpp:

(WebCore::DOMWindow::dispatchLoadEvent): Streamlined code a bit so we only have a single
call to dispatchEvent. Improved comments.
(WebCore::DOMWindow::dispatchEvent): Removed return value. Added comments. Replaced
calls to setCurrentTarget(null), setEventPhase(NONE), and resetPropagationFlags with
a call to resetAfterDispatch.

• page/DOMWindow.h: Updated to get rid of the boolean return value.

• page/DragController.cpp:

(WebCore::DragController::dispatchTextInputEventFor): Use defaultPrevented directly instead
of the return value from dispatchEvent.

• page/EventHandler.cpp:

(WebCore::dispatchSelectStart): Use defaultPrevented directly instead
of the return value from dispatchEvent.
(WebCore::EventHandler::accessibilityPreventsEventPropagation): Fixed spelling error in the
name of this function.
(WebCore::EventHandler::dispatchDragSrcEvent): Got rid of boolean return value.
(WebCore::EventHandler::handleTouchEvent): Call dispatchEvent instead of dispatchTouchEvent;
there was no difference between the two except that dispatchTouchEvent required downcasting
and might some day lead to us missing some behavior implemented in an override to dispatchEvent.

• page/EventHandler.h: Updated for above changes.

• platform/graphics/filters/FilterOperation.h:

(WebCore::FilterOperation::clone): Removed dead code that was causing a compiler warning.

• workers/WorkerMessagingProxy.cpp:

(WebCore::WorkerMessagingProxy::postExceptionToWorkerObject): Use defaultPrevented
directly instead of the return value from dispatchEvent.

Source/WebKit:

• WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMEvent.cpp:

(webkit_dom_event_get_src_element): Call target instead of srcElement.

Source/WebKitLegacy/mac:

• DOM/DOMEvent.mm:

(-[DOMEvent srcElement]): Call target instead of srcElement.

9:47 AM Changeset in webkit [224458] by Michael Catanzaro

• 2 edits in trunk/Tools

[GTK] Fix gtk-doc generation with gtk-doc master
​https://bugs.webkit.org/show_bug.cgi?id=179252

Reviewed by Carlos Garcia Campos.

gtkdoc-scangobj has changed to no longer use a shell when executing its subcommands. In
particular, this means we can no longer rely on shell stuff in our run command that we use
to run the scanner. We currently use the RUN envvar to set LD_LIBRARY_PATH, and the end
result is gtkdoc-scangobj now attempts to execute our environment variable instead of the
scanner itself. We can just set LD_LIBRARY_PATH directly, instead of using RUN, in order to
make documentation generation work again.

• gtk/gtkdoc.py:

(GTKDoc._run_gtkdoc_scangobj):

1:20 AM Changeset in webkit [224457] by commit-queue@webkit.org

• 26 edits
  3 copies
  2 adds in trunk

[Touch Bar Web API] Add support for menuitem tag
​https://bugs.webkit.org/show_bug.cgi?id=179020

Patch by Aishwarya Nirmal <​anirmal@apple.com> on 2017-11-04
Reviewed by Ryosuke Niwa.

Source/WebCore:

The Touch Bar Web API will make use of the menu and menuitem tags
to represent the NSTouchBar and NSTouchBarItem respectively.
Since WebKit currently does not offer support for the menuitem tag,
this change adds it in. There is a runtime flag for this tag, which
is set to false by default.

A specification for the menuitem element can be found at
​https://www.w3.org/TR/2013/WD-html51-20130528/interactive-elements.html#the-menuitem-element.
More attributes of this element will be implemented in future patches.

Test: fast/html/menuitem-element.html

• CMakeLists.txt:
• DerivedSources.cpp:
• DerivedSources.make:
• Sources.txt:
• WebCore.xcodeproj/project.pbxproj:
• bindings/js/WebCoreBuiltinNames.h:
• html/HTMLElementsAllInOne.cpp:
• html/HTMLMenuItemElement.cpp: Added.

(WebCore::HTMLMenuItemElement::HTMLMenuItemElement):
(WebCore::HTMLMenuItemElement::create):

• html/HTMLMenuItemElement.h: Added.
• html/HTMLMenuItemElement.idl: Added.
• html/HTMLTagNames.in:
• page/RuntimeEnabledFeatures.h:

(WebCore::RuntimeEnabledFeatures::setMenuItemElementEnabled):
(WebCore::RuntimeEnabledFeatures::menuItemElementEnabled const):

Source/WebKit:

Adds in the MenuItemElementEnabled flag so that the menu item element is a runtime-
enabled feature. It has a default value of false.

• Shared/WebPreferences.yaml:
• UIProcess/API/C/WKPreferences.cpp:

(WKPreferencesSetMenuItemElementEnabled):
(WKPreferencesGetMenuItemElementEnabled):

• UIProcess/API/C/WKPreferencesRefPrivate.h:

Source/WebKitLegacy/mac:

Adds in properties and methods that allow the menuitem runtime feature
to be enabled or disabled.

• WebView/WebPreferenceKeysPrivate.h:
• WebView/WebPreferences.mm:

(-[WebPreferences menuItemElementEnabled]):
(-[WebPreferences setMenuItemElementEnabled:]):

• WebView/WebPreferencesPrivate.h:
• WebView/WebView.mm:

(-[WebView _preferencesChanged:]):

Tools:

Defines flags for the menu item test so that the element is recognized
only while its test is being run.

• DumpRenderTree/TestOptions.h:
• DumpRenderTree/TestOptions.mm:

(TestOptions::TestOptions):

• DumpRenderTree/mac/DumpRenderTree.mm:

(setWebPreferencesForTestOptions):

• WebKitTestRunner/TestController.cpp:

(WTR::TestController::resetPreferencesToConsistentValues):
(WTR::updateTestOptionsFromTestHeader):

• WebKitTestRunner/TestOptions.h:

(WTR::TestOptions::hasSameInitializationOptions const):

LayoutTests:

This test ensures that the menuitem element is recognized when
its runtime feature is turned on.

• fast/html/menuitem-element-expected.txt: Added.
• fast/html/menuitem-element.html: Added.

1:03 AM Changeset in webkit [224456] by webkit@devinrousso.com

• 5 edits in trunk/Source/WebInspectorUI

Web Inspector: add contextmenu item to arbitrarily add HTML/Child to DOMTree
​https://bugs.webkit.org/show_bug.cgi?id=179042

Reviewed by Joseph Pecoraro.

• Localizations/en.lproj/localizedStrings.js:

• UserInterface/Models/DOMNode.js:

(WI.DOMNode.prototype.insertAdjacentHTML.inspectedPage_node_insertAdjacentHTML):
(WI.DOMNode.prototype.insertAdjacentHTML):
Call-through to insertAdjacentHTML on the corresponding node in the inspected page.

• UserInterface/Views/DOMTreeElement.js:

(WI.DOMTreeElement):
(WI.DOMTreeElement.prototype._populateNodeContextMenu):
(WI.DOMTreeElement.prototype._startEditingAsHTML.dispose):
(WI.DOMTreeElement.prototype._startEditingAsHTML):
(WI.DOMTreeElement.prototype._insertAdjacentHTML.commitCallback):
(WI.DOMTreeElement.prototype._insertAdjacentHTML):
(WI.DOMTreeElement.prototype.updateTitle):
(WI.DOMTreeElement.prototype._singleTextChild):
(WI.DOMTreeElement.prototype._nodeTitleInfo):
(WI.DOMTreeElement.prototype._addHTML):
(WI.DOMTreeElement.prototype._addPreviousSibling):
(WI.DOMTreeElement.prototype._addNextSibling):
(WI.DOMTreeElement.prototype._editAsHTML):
Adjust where the editing element is placed depending on the options passed to _editAsHTML.
If the placement is as a child, put it inside the child list. If the placement is as a
sibling, place it before/after the selected TreeElement. Otherwise, add it as a child.

• UserInterface/Views/DOMTreeOutline.css:

(.tree-outline.dom):
(.tree-outline.dom li):
(.tree-outline.dom li:not(.editing)):
(.tree-outline.dom li.editing):
(body[dir=ltr] .tree-outline.dom li): Deleted.
(body[dir=rtl] .tree-outline.dom li): Deleted.
Don't add padding when the list item is being edited.

Nov 3, 2017:

10:40 PM Changeset in webkit [224455] by Alan Bujtas

• 5 edits in trunk/Source/WebCore

LayoutState should take RenderBox reference.
​https://bugs.webkit.org/show_bug.cgi?id=179272
<rdar://problem/35345247>

Reviewed by Simon Fraser.

No change in functionality.

• rendering/LayoutState.cpp:

(WebCore::LayoutState::LayoutState):
(WebCore::LayoutState::propagateLineGridInfo):
(WebCore::LayoutState::establishLineGrid):

• rendering/LayoutState.h: type tightening.
• rendering/RenderBlock.cpp:

(WebCore::RenderBlock::offsetFromLogicalTopOfFirstPage const):

• rendering/RenderView.cpp:

(WebCore::RenderView::pushLayoutState):

• rendering/RenderView.h:

10:19 PM Changeset in webkit [224454] by Chris Dumez

• 3 edits in trunk/Source/WebKit

Unreviewed, rolling out r224438.

Has caused assertions on the bots

Reverted changeset:

"REGRESSION(r223718): Leaking WebProcessPool after
reconfiguration"
​https://bugs.webkit.org/show_bug.cgi?id=179123
​https://trac.webkit.org/changeset/224438

7:12 PM Changeset in webkit [224453] by Chris Dumez

• 20 edits
  4 adds in trunk

Implement ServiceWorkerContainer.getRegistration
​https://bugs.webkit.org/show_bug.cgi?id=179253

Patch by Youenn Fablet <​youenn@apple.com> on 2017-11-03
Reviewed by Chris Dumez.

LayoutTests/imported/w3c:

• web-platform-tests/service-workers/service-worker/activation.https-expected.txt:
• web-platform-tests/service-workers/service-worker/claim-affect-other-registration.https-expected.txt:
• web-platform-tests/service-workers/service-worker/claim-with-redirect.https-expected.txt:
• web-platform-tests/service-workers/service-worker/getregistration.https-expected.txt:
• web-platform-tests/service-workers/service-worker/multi-globals/url-parsing.https-expected.txt:
• web-platform-tests/service-workers/service-worker/navigate-window.https-expected.txt:
• web-platform-tests/service-workers/service-worker/registration-iframe.https-expected.txt:
• web-platform-tests/service-workers/service-worker/skip-waiting-without-using-registration.https-expected.txt:
• web-platform-tests/service-workers/service-worker/synced-state.https-expected.txt:

Source/WebCore:

Test: http/tests/workers/service/service-worker-getRegistration.html

Added a map of ServiceWorkerRegistration in ServiceWorkerContainer.
Removing a similar map from SWClientConnection as it is more convenient to have this map per ScriptExecutionContext.

This map allows returning the same JS object for different getRegistration.
Delegating the actual matching to SWServer::Connection which is implemented on the StorageProcess through IPC.

• workers/service/ServiceWorkerContainer.cpp:

(WebCore::ServiceWorkerContainer::getRegistration):
(WebCore::ServiceWorkerContainer::jobResolvedWithRegistration):
(WebCore::ServiceWorkerContainer::jobDidFinish):

• workers/service/ServiceWorkerContainer.h:
• workers/service/ServiceWorkerContainer.idl:
• workers/service/ServiceWorkerRegistration.cpp:

(WebCore::ServiceWorkerRegistration::ServiceWorkerRegistration):
(WebCore::ServiceWorkerRegistration::~ServiceWorkerRegistration):

• workers/service/ServiceWorkerRegistration.h:
• workers/service/server/SWClientConnection.cpp:

(WebCore::SWClientConnection::updateRegistrationState):
(WebCore::SWClientConnection::addServiceWorkerRegistration): Deleted.
(WebCore::SWClientConnection::removeServiceWorkerRegistration): Deleted.

• workers/service/server/SWClientConnection.h:

LayoutTests:

• TestExpectations:
• http/tests/workers/service/resources/service-worker-getRegistration-worker.js: Added.
• http/tests/workers/service/resources/service-worker-getRegistration.js: Added.
• http/tests/workers/service/service-worker-getRegistration-expected.txt: Added.
• http/tests/workers/service/service-worker-getRegistration.html: Added.

6:57 PM Changeset in webkit [224452] by Chris Dumez

• 2 edits in trunk/Source/WebCore

[iOS-WK1] Fix thread safety issue in WebSQLiteDatabaseTrackerClient
​https://bugs.webkit.org/show_bug.cgi?id=179190

Reviewed by David Kilzer.

WebSQLiteDatabaseTrackerClient and its HystererisActivity member are constructed on the UIThread. The
HystererisActivity activity also fires on the UIThread, which means that WebSQLiteDatabaseTrackerClient::hysteresisUpdated()
gets called on the UIThread.

However, the code in WebSQLiteDatabaseTrackerClient::willBeginFirstTransaction() / WebSQLiteDatabaseTrackerClient::didFinishLastTransaction()
uses callOnMainThread() before calling methods on the HysteresisActivity. callOnMainThread() dispatches to the WebThread on WK1 iOS, which
would lead to crashes when calling methods of the HystererisActivity object:
* -[CFRunLoopTimer respondsToSelector:]: message sent to deallocated instance 0x1c0b6a500

To address the issue, we now dispatch_async() to the main queue in willBeginFirstTransaction() / didFinishLastTransaction()
instead of using callOnMainThread(). I also added assertions to catch issues like these.

• platform/ios/WebSQLiteDatabaseTrackerClient.mm:

(WebCore::WebSQLiteDatabaseTrackerClient::willBeginFirstTransaction):
(WebCore::WebSQLiteDatabaseTrackerClient::didFinishLastTransaction):
(WebCore::WebSQLiteDatabaseTrackerClient::hysteresisUpdated):

6:14 PM Changeset in webkit [224451] by jmarcell@apple.com

• 1 copy in tags/Safari-604.4.7.0.1

Tag Safari-604.4.7.0.1.

5:52 PM Changeset in webkit [224450] by jmarcell@apple.com

• 1 copy in tags/Safari-604.4.7.0.2

Tag Safari-604.4.7.0.2.

5:51 PM Changeset in webkit [224449] by jmarcell@apple.com

• 1 delete in tags/Safari-604.4.7.0.2

Deleting tag.

5:50 PM Changeset in webkit [224448] by jmarcell@apple.com

• 7 edits in branches/safari-604.4.7.0-branch/Source

Versioning.

5:40 PM Changeset in webkit [224447] by jmarcell@apple.com

• 1 copy in tags/Safari-604.4.7.1.2

Tag Safari-604.4.7.1.2.

5:39 PM Changeset in webkit [224446] by jmarcell@apple.com

• 1 copy in tags/Safari-604.4.7.0.2

Tag Safari-604.4.7.0.2.

5:36 PM Changeset in webkit [224445] by jmarcell@apple.com

• 1 copy in tags/Safari-604.4.7.10.2

Tag Safari-604.4.7.10.2.

5:36 PM Changeset in webkit [224444] by rniwa@webkit.org

• 3 edits in trunk/Source/WebCore

ASSERTION FAILED: NoEventDispatchAssertion::InMainThread::isEventAllowed()

(frameView && frameView->isInChildFrameWithFrameFlattening())

​https://bugs.webkit.org/show_bug.cgi?id=179259

Reviewed by Youenn Fablet.

Avoid updating the layout inside HTMLMediaElement::stop() and MediaElementSession::~MediaElementSession

No new tests since existing tests cover this.

• html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::userCancelledLoad): Don't update VTT cues when the active DOM objects are being stopped.

• platform/audio/mac/MediaSessionManagerMac.mm:

(WebCore::MediaSessionManagerMac::removeSession): Update the updateNowPlayingInfo asynchronously
since this function can be called inside HTMLMediaElement::~HTMLMediaElement.

5:35 PM Changeset in webkit [224443] by achristensen@apple.com

• 2 edits in trunk/Source/WebCore

Add WEBCORE_EXPORT to CachedResourceHandleBase
​https://bugs.webkit.org/show_bug.cgi?id=179251

• loader/cache/CachedResourceHandle.h:

(WebCore::CachedResourceHandleBase::get const): Deleted.
(WebCore::CachedResourceHandleBase::operator! const): Deleted.
(WebCore::CachedResourceHandleBase::operator UnspecifiedBoolType const): Deleted.
(WebCore::CachedResourceHandleBase::operator=): Deleted.
I'll need this soon for bug 179251, and having to touch CachedResourceHandle.h causes me to rebuild everything.
Committing it separately greatly increases my debugging and comparison speed.

4:32 PM Changeset in webkit [224442] by Ryan Haddad

• 12 edits
  1 delete in trunk/Source

Unreviewed, rolling out r224428, r224435, and r224440.
​https://bugs.webkit.org/show_bug.cgi?id=179274

Broke iOS and internal builds (Requested by ryanhaddad on
#webkit).

Reverted changesets:

"Use VCP H264 encoder for platforms supporting it"
​https://bugs.webkit.org/show_bug.cgi?id=179076
​https://trac.webkit.org/changeset/224428

"Use VCP H264 encoder for platforms supporting it"
​https://bugs.webkit.org/show_bug.cgi?id=179076
​https://trac.webkit.org/changeset/224435

"Use VCP H264 encoder for platforms supporting it"
​https://bugs.webkit.org/show_bug.cgi?id=179076
​https://trac.webkit.org/changeset/224440

Patch by Commit Queue <​commit-queue@webkit.org> on 2017-11-03

4:31 PM Changeset in webkit [224441] by Nikita Vasilyev

• 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Uncaught Exception: null is not an object (evaluating 'selector.specificity.map') (at SpreadsheetCSSStyleDeclarationSection.js:199:51)
​https://bugs.webkit.org/show_bug.cgi?id=179225
<rdar://problem/35329019>

Reviewed by Joseph Pecoraro.

• UserInterface/Views/SpreadsheetCSSStyleDeclarationSection.js:

(WI.SpreadsheetCSSStyleDeclarationSection.prototype._renderSelector):
selector.specificity may not exist when the selector is dynamic and doesn't match the selected element.

4:21 PM Changeset in webkit [224440] by commit-queue@webkit.org

• 2 edits in trunk/Source/ThirdParty/libwebrtc

Use VCP H264 encoder for platforms supporting it
​https://bugs.webkit.org/show_bug.cgi?id=179076
rdar://problem/35180773

Unreviewed.

Patch by Youenn Fablet <​youenn@apple.com> on 2017-11-03

• Source/webrtc/sdk/objc/Framework/Classes/VideoProcessing/encoder_vcp.h: build fix for iOS.

4:09 PM Changeset in webkit [224439] by commit-queue@webkit.org

• 11 edits
  4 adds in trunk

Requests handled by Service Worker should not go through preflighting
​https://bugs.webkit.org/show_bug.cgi?id=179250

Patch by Youenn Fablet <​youenn@apple.com> on 2017-11-03
Reviewed by Alex Christensen.

Source/WebCore:

Test: http/tests/workers/service/service-worker-crossorigin-fetch.html
In case of cross origin requests needed preflighting that may be served through SW, the following is done:

• Bypass preflight
• Put service workers mode as Only so that if SW is not handling the request, the load will fail
• If load fails, restart DocumentThreadableLoader load with preflight.

Additional testing should be added when we properly handle the case where no fetch event handler is registered in the service worker.

• loader/DocumentThreadableLoader.cpp:

(WebCore::DocumentThreadableLoader::makeCrossOriginAccessRequest):
(WebCore::DocumentThreadableLoader::didFail):

• loader/DocumentThreadableLoader.h:
• loader/ResourceLoaderOptions.h:
• loader/cache/CachedResourceRequest.cpp:

(WebCore::CachedResourceRequest::setSelectedServiceWorkerIdentifierIfNeeded):

• platform/network/ResourceErrorBase.h:

Source/WebKit:

• WebProcess/Network/WebLoaderStrategy.cpp:

(WebKit::WebLoaderStrategy::scheduleLoad):

• WebProcess/Storage/WebSWClientConnection.cpp:

(WebKit::WebSWClientConnection::startFetch):

• WebProcess/Storage/WebServiceWorkerProvider.cpp:

(WebKit::shouldHandleFetch):

LayoutTests:

• http/tests/workers/service/resources/service-worker-crossorigin-fetch-worker.js: Added.

(event.event.request.url.indexOf):
(event.event.request.url.endsWith):

• http/tests/workers/service/resources/service-worker-crossorigin-fetch.js: Added.

(done):
(async.logStatus):
(async.test):

• http/tests/workers/service/service-worker-crossorigin-fetch-expected.txt: Added.
• http/tests/workers/service/service-worker-crossorigin-fetch.html: Added.

4:02 PM Changeset in webkit [224438] by Chris Dumez

• 3 edits in trunk/Source/WebKit

REGRESSION(r223718): Leaking WebProcessPool after reconfiguration
​https://bugs.webkit.org/show_bug.cgi?id=179123
<rdar://problem/35294685>

Reviewed by Geoffrey Garen.

Make sure we destroy the ServiceWorker WebProcess once all other WebProcesses
go away at there is no use keeping it running at this point. Also, this prevents
leaking the WebProcessPool since the WebProcessProxy holds a strong reference
to the WebProcessPool.

• UIProcess/WebProcessPool.cpp:

(WebKit::WebProcessPool::disconnectProcess):

3:49 PM Changeset in webkit [224437] by aestes@apple.com

• 2 edits in trunk/Tools

[iOS] Append the platform name to the product directory on all embedded platforms
​https://bugs.webkit.org/show_bug.cgi?id=179271

Reviewed by Joseph Pecoraro.

• Scripts/webkitdirs.pm:

(determineConfigurationProductDir):

3:42 PM Changeset in webkit [224436] by Alan Bujtas

• 14 edits in trunk/Source/WebCore

Remove redundant LayoutStateMaintainer argument (RenderView&)
​https://bugs.webkit.org/show_bug.cgi?id=179269
<rdar://problem/35344397>

Reviewed by Simon Fraser.

No change in functionality.

• rendering/RenderBlock.cpp:

(WebCore::RenderBlock::simplifiedLayout):

• rendering/RenderBlockFlow.cpp:

(WebCore::RenderBlockFlow::layoutBlock):

• rendering/RenderBox.cpp:

(WebCore::RenderBox::layout):

• rendering/RenderDeprecatedFlexibleBox.cpp:

(WebCore::RenderDeprecatedFlexibleBox::layoutBlock):

• rendering/RenderEmbeddedObject.cpp:

(WebCore::RenderEmbeddedObject::layout):

• rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::layoutBlock):

• rendering/RenderGrid.cpp:

(WebCore::RenderGrid::layoutBlock):

• rendering/RenderImage.cpp:

(WebCore::RenderImage::layoutShadowControls):

• rendering/RenderTable.cpp:

(WebCore::RenderTable::layout):

• rendering/RenderTableRow.cpp:

(WebCore::RenderTableRow::layout):

• rendering/RenderTableSection.cpp:

(WebCore::RenderTableSection::layout):
(WebCore::RenderTableSection::layoutRows):

• rendering/RenderVTTCue.cpp:

(WebCore::RenderVTTCue::layout):

• rendering/RenderView.h:

(WebCore::LayoutStateMaintainer::LayoutStateMaintainer):

3:03 PM Changeset in webkit [224435] by commit-queue@webkit.org

• 2 edits in trunk/Source/ThirdParty/libwebrtc

Use VCP H264 encoder for platforms supporting it
​https://bugs.webkit.org/show_bug.cgi?id=179076
rdar://problem/35180773

Unreviewed.

Patch by Youenn Fablet <​youenn@apple.com> on 2017-11-03

• Source/webrtc/sdk/objc/Framework/Classes/VideoProcessing/encoder_vcp.h: build fix.

2:53 PM Changeset in webkit [224434] by Ross Kirsling

• 3 edits in trunk/Source/WebInspectorUI

Web Inspector: Move Show Compositing Borders/Paint Flashing buttons from Elements tab to Layers tab
​https://bugs.webkit.org/show_bug.cgi?id=179211

Reviewed by Joseph Pecoraro.

• UserInterface/Views/DOMTreeContentView.js:

(WI.DOMTreeContentView.prototype.get navigationItems):
(WI.DOMTreeContentView.prototype._updateCompositingBordersButtonToMatchPageSettings):
Guard old buttons with experimental flag.

• UserInterface/Views/Layers3DContentView.js:

(WI.Layers3DContentView):
(WI.Layers3DContentView.prototype.get navigationItems):
(WI.Layers3DContentView.prototype.shown):
(WI.Layers3DContentView.prototype.closed):
(WI.Layers3DContentView.prototype._showPaintRectsSettingChanged):
(WI.Layers3DContentView.prototype._togglePaintFlashing):
(WI.Layers3DContentView.prototype._updateCompositingBordersButtonState):
(WI.Layers3DContentView.prototype._toggleCompositingBorders):
Add buttons to new home.
No need to guard for get/setCompositingBordersVisible anymore, as these were introduced in iOS 7.

2:43 PM Changeset in webkit [224433] by webkit@devinrousso.com

• 20 edits in trunk/Source/WebInspectorUI

Web Inspector: move top-level namespace functions in ImageUtilities to static class
​https://bugs.webkit.org/show_bug.cgi?id=179207

Reviewed by Brian Burg.

• .eslintrc:
• UserInterface/Base/ImageUtilities.js:

(WI.ImageUtilities.useSVGSymbol):
(WI.ImageUtilities.scratchCanvasContext2D):
(WI.ImageUtilities.imageFromImageData):
(WI.ImageUtilities.imageFromCanvasGradient):
(WI.ImageUtilities):
(useSVGSymbol): Deleted.
(WI.scratchCanvasContext2D): Deleted.
(WI.imageFromImageData): Deleted.
(WI.imageFromCanvasGradient): Deleted.

• UserInterface/Models/Recording.js:

(WI.Recording.prototype.async swizzle):

• UserInterface/Views/ButtonNavigationItem.js:

(WI.ButtonNavigationItem.prototype.set image):

• UserInterface/Views/CallFrameTreeElement.js:

(WI.CallFrameTreeElement.prototype._updateStatus):

• UserInterface/Views/DOMNodeDetailsSidebarPanel.js:

(WI.DOMNodeDetailsSidebarPanel.prototype.initialLayout):

• UserInterface/Views/DOMTreeElement.js:

(WI.DOMTreeElement.prototype._updateBreakpointStatus):

• UserInterface/Views/MultipleScopeBarItem.js:

(WI.MultipleScopeBarItem):

• UserInterface/Views/RecordingActionTreeElement.js:

(WI.RecordingActionTreeElement._generateDOM):
(WI.RecordingActionTreeElement.prototype._handleHasVisibleEffectChanged):

• UserInterface/Views/RecordingStateDetailsSidebarPanel.js:

(WI.RecordingStateDetailsSidebarPanel.prototype._generateDetailsCanvas2D):

• UserInterface/Views/ResourceMetricsContentView.js:

(WI.ResourceMetricsContentView.prototype._refreshResourceSizeSection):

• UserInterface/Views/ScopeRadioButtonNavigationItem.js:

(WI.ScopeRadioButtonNavigationItem):

• UserInterface/Views/ThreadTreeElement.js:

(WI.ThreadTreeElement.prototype._updateStatus):

• UserInterface/Views/TimelineTreeElement.js:

(WI.TimelineTreeElement.prototype._showCloseButton):

• UserInterface/Views/VisualStyleCommaSeparatedKeywordEditor.js:

(WI.VisualStyleCommaSeparatedKeywordEditor):

• UserInterface/Views/VisualStyleKeywordIconList.js:

(WI.VisualStyleKeywordIconList):

• UserInterface/Views/VisualStylePropertyEditorLink.js:

(WI.VisualStylePropertyEditorLink):

• UserInterface/Views/VisualStyleSelectorSection.js:

(WI.VisualStyleSelectorSection):

• UserInterface/Views/WebSocketDataGridNode.js:

(WI.WebSocketDataGridNode.prototype.createCellContent):

2:30 PM Changeset in webkit [224432] by achristensen@apple.com

• 4 edits in trunk/LayoutTests

LayoutTest http/tests/loading/basic-auth-resend-wrong-credentials.html is flaky on WK2
​https://bugs.webkit.org/show_bug.cgi?id=159884

Reviewed by Darin Adler.

• http/tests/loading/basic-auth-resend-wrong-credentials-expected.txt:
• http/tests/loading/basic-auth-resend-wrong-credentials.html:
• platform/wk2/http/tests/loading/basic-auth-resend-wrong-credentials-expected.txt:

2:26 PM Changeset in webkit [224431] by Ross Kirsling

• 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Hide legacy Layers sidebar on Search tab
​https://bugs.webkit.org/show_bug.cgi?id=179257

Reviewed by Joseph Pecoraro.

• UserInterface/Views/SearchTabContentView.js:

(WI.SearchTabContentView):

2:26 PM Changeset in webkit [224430] by Ryan Haddad

• 2 edits in trunk/LayoutTests

Mark http/tests/security/mixedContent/insecure-css-with-secure-cookies.html as flaky.
​https://bugs.webkit.org/show_bug.cgi?id=175998

Unreviewed test gardening.

• platform/mac/TestExpectations:

2:26 PM Changeset in webkit [224429] by Ryan Haddad

• 2 edits in trunk/LayoutTests

Mark imported/w3c/web-platform-tests/service-workers/service-worker/fetch-event-within-sw.https.html as flaky.
​https://bugs.webkit.org/show_bug.cgi?id=179248

Unreviewed test gardening.

• TestExpectations:

2:13 PM Changeset in webkit [224428] by commit-queue@webkit.org

• 12 edits
  1 copy
  2 adds in trunk/Source

Use VCP H264 encoder for platforms supporting it
​https://bugs.webkit.org/show_bug.cgi?id=179076
rdar://problem/35180773

Patch by Youenn Fablet <​youenn@apple.com> on 2017-11-03
Reviewed by Eric Carlson.

Source/ThirdParty/libwebrtc:

• Configurations/libwebrtc.iOS.exp:
• Configurations/libwebrtc.iOSsim.exp:
• Configurations/libwebrtc.mac.exp:
• Source/webrtc/sdk/objc/Framework/Classes/VideoProcessing/encoder_vcp.h: Added.

(webrtc::H264VideoToolboxEncoderVCP::SetActive):

• Source/webrtc/sdk/objc/Framework/Classes/VideoProcessing/encoder_vcp.mm: Copied from Source/ThirdParty/libwebrtc/Source/webrtc/sdk/objc/Framework/Classes/VideoToolbox/encoder.mm.
• Source/webrtc/sdk/objc/Framework/Classes/VideoToolbox/encoder.mm:

(internal::CFStringToString):
(internal::SetVTSessionProperty):
(internal::CopyVideoFrameToPixelBuffer):
(internal::CreatePixelBuffer):
(internal::VTCompressionOutputCallback):
(internal::ExtractProfile):

• Source/webrtc/sdk/objc/Framework/Classes/VideoToolbox/videocodecfactory.h:
• Source/webrtc/sdk/objc/Framework/Classes/VideoToolbox/videocodecfactory.mm:

(webrtc::VideoToolboxVideoEncoderFactory::VideoToolboxVideoEncoderFactory):
(webrtc::VideoToolboxVideoEncoderFactory::CreateSupportedVideoEncoder):

• libwebrtc.xcodeproj/project.pbxproj:

Source/WebCore:

Covered by existing test coverage.

• platform/mediastream/libwebrtc/VideoToolBoxEncoderFactory.cpp:

(WebCore::VideoToolboxVideoEncoderFactory::setActive):
(WebCore::VideoToolboxVideoEncoderFactory::CreateSupportedVideoEncoder):
(WebCore::VideoToolboxVideoEncoderFactory::DestroyVideoEncoder):

• platform/mediastream/libwebrtc/VideoToolBoxEncoderFactory.h:

2:04 PM Changeset in webkit [224427] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebCore

[Curl] Fix build after r224373
​https://bugs.webkit.org/show_bug.cgi?id=179265

Unreviewed build fix.

Patch by Basuke Suzuki <Basuke Suzuki> on 2017-11-03

• platform/network/curl/ResourceHandleCurl.cpp:

(WebCore::ResourceHandle::continueWillSendRequest): Deleted.

1:45 PM Changeset in webkit [224426] by msaboff@apple.com

• 2 edits in trunk/Source/JavaScriptCore

The Abstract Interpreter needs to change similar to clobberize() in r224366
​https://bugs.webkit.org/show_bug.cgi?id=179267

Reviewed by Saam Barati.

Add clobberWorld() to HasGenericProperty, HasStructureProperty & GetPropertyEnumerator
cases in the abstract interpreter to match what was done for r224366.

• dfg/DFGAbstractInterpreterInlines.h:

(JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):

1:31 PM Changeset in webkit [224425] by keith_miller@apple.com

• 1 edit
  1 add in trunk/JSTests

Add test for ic with side effects
​https://bugs.webkit.org/show_bug.cgi?id=179268

Reviewed by Saam Barati.

• stress/put-inline-cache-side-effects.js: Added.

(let.i.of.objs.keys):
(f):

1:19 PM Changeset in webkit [224424] by jmarcell@apple.com

• 6 edits
  2 adds in branches/safari-604.4.7.10-branch

Cherry-pick r224405. rdar://problem/35339755

1:19 PM Changeset in webkit [224423] by jmarcell@apple.com

• 3 edits
  2 adds in branches/safari-604.4.7.10-branch

Cherry-pick r224398. rdar://problem/35329712

1:13 PM Changeset in webkit [224422] by jmarcell@apple.com

• 6 edits
  2 adds in branches/safari-604.4.7.0-branch

Cherry-pick r224405. rdar://problem/35296405

1:13 PM Changeset in webkit [224421] by jmarcell@apple.com

• 3 edits
  2 adds in branches/safari-604.4.7.0-branch

Cherry-pick r224398. rdar://problem/35329714

1:12 PM Changeset in webkit [224420] by jmarcell@apple.com

• 6 edits
  2 adds in branches/safari-604.4.7.1-branch

Cherry-pick r224405. rdar://problem/35296404

1:12 PM Changeset in webkit [224419] by jmarcell@apple.com

• 3 edits
  2 adds in branches/safari-604.4.7.1-branch

Cherry-pick r224398. rdar://problem/35329684

1:12 PM Changeset in webkit [224418] by beidson@apple.com

• 2 edits in trunk/Source/WebCore

Remove an invalid ASSERT that is seen intermittently.
​https://bugs.webkit.org/show_bug.cgi?id=179186

Unreviewed.

• workers/service/server/SWServerRegistration.cpp:

(WebCore::SWServerRegistration::removeClientServiceWorkerRegistration): This is an invalid ASSERT,

it's definitely racey over IPC.

1:02 PM Changeset in webkit [224417] by achristensen@apple.com

• 4 edits in trunk/LayoutTests

Remove Yosemite test expectations
​https://bugs.webkit.org/show_bug.cgi?id=179143

Reviewed by Ryosuke Niwa.

We only test back to El Capitan. Everything is Yosemite+. Marking tests as failing only on Yosemite isn't useful any more.

• platform/mac-wk1/TestExpectations:
• platform/mac-wk2/TestExpectations:
• platform/mac/TestExpectations:

12:57 PM Changeset in webkit [224416] by keith_miller@apple.com

• 3 edits in trunk/Source/JavaScriptCore

PutProperytSlot should inform the IC about the property before effects.
​https://bugs.webkit.org/show_bug.cgi?id=179262

Reviewed by Mark Lam.

This patch fixes an issue where we choose to cache setters based on
incorrect information. If we did so we might end up OSR exiting
more than we would otherwise need to. The new model is that the
PutPropertySlot should inform the IC of what the property looked
like before any potential side effects might have occurred.

• runtime/JSObject.cpp:

(JSC::JSObject::putInlineSlow):

• runtime/Lookup.h:

(JSC::putEntry):

12:40 PM Changeset in webkit [224415] by zandobersek@gmail.com

• 2 edits
  1 add in trunk/LayoutTests

Unreviewed GTK+ gardening. Mark a few failures, posting along the relevant
bug entries. Add a platform-specific baseline for one HTTP test.

• platform/gtk/TestExpectations:
• platform/gtk/http/tests/security/module-no-mime-type-expected.txt: Added.

12:26 PM Changeset in webkit [224414] by pvollan@apple.com

• 6 edits in trunk/LayoutTests

[Win] Update test expectations after r224324.

Unreviewed test gardening.

• platform/win/css3/selectors3/html/css3-modsel-166-expected.txt:
• platform/win/css3/selectors3/html/css3-modsel-166a-expected.txt:
• platform/win/css3/selectors3/html/css3-modsel-39-expected.txt:
• platform/win/css3/selectors3/html/css3-modsel-39b-expected.txt:
• platform/win/fast/css/first-letter-float-after-float-expected.txt:

12:09 PM Changeset in webkit [224413] by commit-queue@webkit.org

• 2 edits in trunk/Tools

[WinCairo] Add --wincairo option to run-webkit-tests
​https://bugs.webkit.org/show_bug.cgi?id=179217

Patch by Basuke Suzuki <Basuke Suzuki> on 2017-11-03
Reviewed by Alex Christensen.

• Scripts/webkitpy/port/factory.py:

(platform_options):

11:57 AM Changeset in webkit [224412] by Michael Catanzaro

• 3 edits in trunk/Source/WebCore

[WPE] Remove unneeded USE(LIBEPOXY) guards
​https://bugs.webkit.org/show_bug.cgi?id=179228

Reviewed by Carlos Garcia Campos.

USE(LIBEPOXY) is already mandatory for WPE.

• platform/graphics/egl/GLContextEGLWPE.cpp:
• platform/graphics/wpe/PlatformDisplayWPE.cpp:

11:47 AM Changeset in webkit [224411] by Matt Lewis

• 2 edits in trunk/LayoutTests

Marked js/intl-datetimeformat.html as failing on High Sierra.
​https://bugs.webkit.org/show_bug.cgi?id=179208

Unreviewed test gardening.

• platform/mac-wk2/TestExpectations:

11:42 AM Changeset in webkit [224410] by Michael Catanzaro

• 4 edits
  1 move
  1 add in trunk

[WPE][GTK] Avoid duplicating code for dist and distcheck targets
​https://bugs.webkit.org/show_bug.cgi?id=179154

Reviewed by Carlos Garcia Campos.

.:

This commit just reduces some CMake code duplication between GTK and WPE.

• Source/PlatformGTK.cmake:
• Source/PlatformWPE.cmake:
• Source/cmake/WebKitDist.cmake: Added.

Tools:

Move the script out of Tools/gtk because it is already used by WPE. Also, drop the .py
prefix because it is executable.

• Scripts/make-dist: Renamed from Tools/gtk/make-dist.py.

11:32 AM Changeset in webkit [224409] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebCore

Layout viewport rect is too wide after window resize
​https://bugs.webkit.org/show_bug.cgi?id=175235

Fix a formatting mistake that was introduced by r224241.

Patch by Ali Juma <​ajuma@chromium.org> on 2017-11-03
Reviewed by Simon Fraser.

No change in behavior.

• platform/ScrollView.cpp:

(WebCore::ScrollView::updateScrollbars):

11:21 AM Changeset in webkit [224408] by commit-queue@webkit.org

• 32 edits
  2 adds in trunk

Implement Service Worker Matching Registration algorithm
​https://bugs.webkit.org/show_bug.cgi?id=178882

Patch by Youenn Fablet <​youenn@apple.com> on 2017-11-03
Reviewed by Chris Dumez.

LayoutTests/imported/w3c:

• web-platform-tests/service-workers/service-worker/multi-globals/url-parsing.https-expected.txt:
• web-platform-tests/service-workers/service-worker/multiple-register.https-expected.txt:
• web-platform-tests/service-workers/service-worker/registration-basic.https-expected.txt:
• web-platform-tests/service-workers/service-worker/registration-scope.https-expected.txt:
• web-platform-tests/service-workers/service-worker/serviceworkerobject-scripturl.https-expected.txt:
• web-platform-tests/service-workers/service-worker/unregister-controller.https-expected.txt:
• web-platform-tests/service-workers/service-worker/unregister.https-expected.txt:

Source/WebCore:

Test: http/tests/workers/service/service-worker-clear.html

Adding support for scope as part of the ServiceWorkerRegistrationKey to disambiguate several service workers registered with different scopes.
Adding the Service Worker Registration algorithm in SWServer and adding internals API to test it.
Making ServiceWorkerRegistrationKey a class to protect its internal field to be reused in wrong places.

Added preliminary support for clearing service workers for a given session ID as this is needed by WTR for stable testing.

• testing/Internals.cpp:

(WebCore::Internals::hasServiceWorkerRegistration):

• testing/Internals.h:
• testing/Internals.idl:
• workers/service/ServiceWorkerJobData.cpp:

(WebCore::ServiceWorkerJobData::registrationKey const):

• workers/service/ServiceWorkerRegistration.h:
• workers/service/ServiceWorkerRegistrationKey.cpp:

(WebCore::ServiceWorkerRegistrationKey::hash const):
(WebCore::ServiceWorkerRegistrationKey::operator== const):
(WebCore::ServiceWorkerRegistrationKey::isolatedCopy const):

• workers/service/ServiceWorkerRegistrationKey.h:

(WebCore::ServiceWorkerRegistrationKey::encode const):
(WebCore::ServiceWorkerRegistrationKey::decode):

• workers/service/server/SWClientConnection.h:
• workers/service/server/SWServer.cpp:

(WebCore::SWServer::clear):
(WebCore::SWServer::doRegistrationMatching const):

• workers/service/server/SWServer.h:

(WebCore::SWServer::Connection::doRegistrationMatching const):

• workers/service/server/SWServerJobQueue.cpp:

(WebCore::SWServerJobQueue::~SWServerJobQueue):

• workers/service/server/SWServerRegistration.h:

Source/WebKit:

Added IPC plumbery for matchRegistration request and response.
Added some limited clearing of workers and registrations.

• StorageProcess/ServiceWorker/WebSWServerConnection.cpp:

(WebKit::WebSWServerConnection::matchRegistration):

• StorageProcess/ServiceWorker/WebSWServerConnection.h:
• StorageProcess/ServiceWorker/WebSWServerConnection.messages.in:
• StorageProcess/StorageProcess.cpp:

(WebKit::StorageProcess::deleteWebsiteData):
(WebKit::StorageProcess::deleteWebsiteDataForOrigins):

• WebProcess/Storage/WebSWClientConnection.cpp:

(WebKit::WebSWClientConnection::didMatchRegistration):
(WebKit::WebSWClientConnection::matchRegistration):

• WebProcess/Storage/WebSWClientConnection.h:
• WebProcess/Storage/WebSWClientConnection.messages.in:
• WebProcess/Storage/WebServiceWorkerProvider.h:

LayoutTests:

• TestExpectations:
• http/tests/workers/service/basic-register-exceptions-expected.txt:
• http/tests/workers/service/resources/basic-register.js: Fixing flakiness.
• http/tests/workers/service/service-worker-clear-expected.txt: Added.
• http/tests/workers/service/service-worker-clear.html: Added.

11:05 AM Changeset in webkit [224407] by dino@apple.com

• 9 edits
  6 adds in trunk

Add basic OffscreenCanvas interface
​https://bugs.webkit.org/show_bug.cgi?id=179213
<rdar://problem/35326778>

Reviewed by Sam Weinig.

Source/WebCore:

Add the basic infrastructure for the OffscreenCanvas
object, so it can be created from script.

Test: http/wpt/offscreen-canvas/offscreencanvas.constructor.html

• DerivedSources.make:
• Sources.txt:
• WebCore.xcodeproj/project.pbxproj:
• bindings/js/JSEventTargetCustom.cpp:
• dom/EventTargetFactory.in:
• html/OffscreenCanvas.cpp: Added.

(WebCore::OffscreenCanvas::create):
(WebCore::OffscreenCanvas::OffscreenCanvas):
(WebCore::OffscreenCanvas::width const):
(WebCore::OffscreenCanvas::setWidth):
(WebCore::OffscreenCanvas::height const):
(WebCore::OffscreenCanvas::setHeight):

• html/OffscreenCanvas.h: Added.
• html/OffscreenCanvas.idl: Added.

LayoutTests:

Very basic test that exercises object construction.

• http/wpt/offscreen-canvas/offscreencanvas.constructor-expected.txt: Added.
• http/wpt/offscreen-canvas/offscreencanvas.constructor.html: Added.

11:03 AM Changeset in webkit [224406] by commit-queue@webkit.org

• 3 edits in trunk/Source/WebKit

Element fullscreen should use FloatRects instead of IntRects in beganEnterFullScreenWithInitialFrame
​https://bugs.webkit.org/show_bug.cgi?id=179033
rdar://problem/35309279

Patch by Jeremy Jones <​jeremyj@apple.com> on 2017-11-03
Reviewed by Darin Adler.

Screen coordinates are floats, so use NSRect instead of IntRect on Mac.

• UIProcess/mac/WKFullScreenWindowController.h:
• UIProcess/mac/WKFullScreenWindowController.mm:

(-[WKFullScreenWindowController beganEnterFullScreenWithInitialFrame:finalFrame:]):
(-[WKFullScreenWindowController beganExitFullScreenWithInitialFrame:finalFrame:]):

10:10 AM Changeset in webkit [224405] by rniwa@webkit.org

• 12 edits
  2 adds in trunk

Crash inside ChildListMutationAccumulator::enqueueMutationRecord()
​https://bugs.webkit.org/show_bug.cgi?id=179234
<rdar://problem/35287748>

Reviewed by Darin Adler.

Source/WebCore:

Fixed the crash by keeping MutationObserver referenced by MutationObserverInterestGroup alive.

Also added hasCallback() virtual function on MutationObserver to check whether the callback is alive
to work around the bug that JS function referenced by MutationObserver isn't kept alive.
We'll address this bug separately in ​https://webkit.org/b/179224.

Test: fast/dom/MutationObserver/disconnect-observer-while-mutation-records-are-enqueued-crash.html

• bindings/scripts/CodeGeneratorJS.pm:

(GenerateCallbackHeaderContent): Added an override for the newly added virtual hasCallback().

• dom/MutationCallback.h:
• dom/MutationObserver.cpp:

(WebCore::MutationObserver::deliver): Added the aforementioned workaround.

• dom/MutationObserverInterestGroup.cpp:

(WebCore::MutationObserverInterestGroup::MutationObserverInterestGroup): Fixed the crash by using Ref.
(WebCore::MutationObserverInterestGroup::enqueueMutationRecord): Ditto.

• dom/MutationObserverInterestGroup.h:
• dom/NativeNodeFilter.cpp:

(WebCore::NativeNodeFilter::hasCallback const): Always return true here. This function is never called
but we still need to implement it since NodeFilter has a pure virtual hasCallback() now.

• dom/NativeNodeFilter.h:
• dom/Node.cpp:

(WebCore::collectMatchingObserversForMutation): Use Ref to fix the crash.
(WebCore::Node::registeredMutationObservers): Ditto.

• dom/Node.h:
• dom/NodeFilter.h:

LayoutTests:

Added a regression test.

• fast/dom/MutationObserver/disconnect-observer-while-mutation-records-are-enqueued-crash-expected.txt: Added.
• fast/dom/MutationObserver/disconnect-observer-while-mutation-records-are-enqueued-crash.html: Added.

9:59 AM Changeset in webkit [224404] by Alan Bujtas

• 19 edits in trunk/Source/WebCore

RenderObject::*positioned() naming cleanup
​https://bugs.webkit.org/show_bug.cgi?id=179206
<rdar://problem/35325254>

Reviewed by Darin Adler.

+isFixedPositioned()
+isAbsolutelyPositioned()
isRelPositioned() -> isRelativelyPositioned()

Covered by existing tests.

• css/CSSComputedStyleDeclaration.cpp:

(WebCore::positionOffsetValue):

• dom/Element.cpp:

(WebCore::layoutOverflowRectContainsAllDescendants):

• rendering/LayoutState.cpp:

(WebCore::LayoutState::LayoutState):

• rendering/LayoutState.h:
• rendering/RenderBlock.cpp:

(WebCore::RenderBlock::renderName const):

• rendering/RenderBox.cpp:

(WebCore::RenderBox::fixedElementLaysOutRelativeToFrame const):
(WebCore::RenderBox::foregroundIsKnownToBeOpaqueInRect const):
(WebCore::RenderBox::mapLocalToContainer const):
(WebCore::RenderBox::pushMappingToContainer const):
(WebCore::RenderBox::mapAbsoluteToLocalPoint const):
(WebCore::RenderBox::offsetFromContainer const):
(WebCore::RenderBox::containingBlockLogicalWidthForPositioned const):
(WebCore::RenderBox::containingBlockLogicalHeightForPositioned const):

• rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::adjustedPositionRelativeToOffsetParent const):
(WebCore::RenderBoxModelObject::offsetForInFlowPosition const):

• rendering/RenderDeprecatedFlexibleBox.cpp:

(WebCore::RenderDeprecatedFlexibleBox::renderName const):

• rendering/RenderFragmentedFlow.cpp:

(WebCore::RenderFragmentedFlow::adjustedPositionRelativeToOffsetParent const):

• rendering/RenderGeometryMap.cpp:

(WebCore::canMapBetweenRenderersViaLayers):

• rendering/RenderGrid.cpp:

(WebCore::RenderGrid::renderName const):

• rendering/RenderInline.cpp:

(WebCore::RenderInline::renderName const):

• rendering/RenderLayer.cpp:

(WebCore::RenderLayer::paintLayer):
(WebCore::RenderLayer::calculateClipRects const):

• rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::updateCompositedBounds):

• rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::updateBacking):
(WebCore::RenderLayerCompositor::computeExtent const):
(WebCore::RenderLayerCompositor::reasonsForCompositing const):
(WebCore::RenderLayerCompositor::isViewportConstrainedFixedOrStickyLayer const):
(WebCore::RenderLayerCompositor::updateScrollCoordinatedLayer):
(WebCore::RenderLayerCompositor::registerAllViewportConstrainedLayers):

• rendering/RenderObject.cpp:

(WebCore::RenderObject::containingBlock const):
(WebCore::RenderObject::outputRenderObject const):
(WebCore::RenderObject::offsetParent const):

• rendering/RenderObject.h:

(WebCore::RenderObject::isPositioned const):
(WebCore::RenderObject::isInFlowPositioned const):
(WebCore::RenderObject::isFixedPositioned const):
(WebCore::RenderObject::isAbsolutePositioned const):
(WebCore::RenderObject::isRelativePositioned const):
(WebCore::RenderObject::isStickyPositioned const):
(WebCore::RenderObject::RenderObjectBitfields::RenderObjectBitfields):
(WebCore::RenderObject::RenderObjectBitfields::isRelativePositioned const):
(WebCore::RenderObject::RenderObjectBitfields::isPositioned const):
(WebCore::RenderObject::isRelPositioned const): Deleted.
(WebCore::RenderObject::RenderObjectBitfields::isRelPositioned const): Deleted.

9:37 AM Changeset in webkit [224403] by Chris Dumez

• 45 edits
  1 copy
  1 add in trunk/Source

Use a single identifier type to identify Service Workers
​https://bugs.webkit.org/show_bug.cgi?id=179192

Reviewed by Brady Eidson.

Source/WebCore:

Use a single identifier type to identify Service Workers. We had both a String
identifier and a uint64_t identifier for each service worker. We now consistently
use a ServiceWorkerIdentifier which is a strongly typed identifier backed by a
uint64_t.

• WebCore.xcodeproj/project.pbxproj:
• loader/ResourceLoaderOptions.h:
• loader/cache/CachedResourceRequest.cpp:

(WebCore::CachedResourceRequest::setSelectedServiceWorkerIdentifierIfNeeded):

• loader/cache/CachedResourceRequest.h:
• workers/service/ServiceWorker.cpp:

(WebCore::ServiceWorker::ServiceWorker):

• workers/service/ServiceWorker.h:
• workers/service/ServiceWorkerClient.cpp:

(WebCore::ServiceWorkerClient::postMessage):

• workers/service/ServiceWorkerContainer.cpp:

(WebCore::ServiceWorkerContainer::jobResolvedWithRegistration):

• workers/service/ServiceWorkerContextData.cpp:

(WebCore::ServiceWorkerContextData::isolatedCopy const):

• workers/service/ServiceWorkerContextData.h:

(WebCore::ServiceWorkerContextData::encode const):
(WebCore::ServiceWorkerContextData::decode):

• workers/service/ServiceWorkerIdentifier.h: Copied from Source/WebCore/workers/service/ServiceWorkerContextData.cpp.
• workers/service/ServiceWorkerRegistrationData.h:

(WebCore::ServiceWorkerRegistrationData::decode):

• workers/service/context/SWContextManager.cpp:

(WebCore::SWContextManager::serviceWorkerThreadProxy const):
(WebCore::SWContextManager::postMessageToServiceWorkerGlobalScope):

• workers/service/context/SWContextManager.h:
• workers/service/context/ServiceWorkerThread.cpp:

(WebCore::ServiceWorkerThread::ServiceWorkerThread):

• workers/service/context/ServiceWorkerThread.h:

(WebCore::ServiceWorkerThread::identifier const):

• workers/service/context/ServiceWorkerThreadProxy.h:
• workers/service/server/SWClientConnection.cpp:

(WebCore::SWClientConnection::postMessageToServiceWorkerClient):

• workers/service/server/SWClientConnection.h:
• workers/service/server/SWServer.cpp:

(WebCore::generateServiceWorkerIdentifier):
(WebCore::SWServer::Connection::scriptContextFailedToStart):
(WebCore::SWServer::Connection::scriptContextStarted):
(WebCore::SWServer::scriptContextFailedToStart):
(WebCore::SWServer::scriptContextStarted):
(WebCore::SWServer::updateWorker):

• workers/service/server/SWServer.h:
• workers/service/server/SWServerJobQueue.cpp:

(WebCore::SWServerJobQueue::scriptContextFailedToStart):
(WebCore::SWServerJobQueue::scriptContextStarted):

• workers/service/server/SWServerJobQueue.h:
• workers/service/server/SWServerRegistration.h:

(WebCore::SWServerRegistration::setActiveServiceWorkerIdentifier):

• workers/service/server/SWServerWorker.cpp:

(WebCore::SWServerWorker::SWServerWorker):

• workers/service/server/SWServerWorker.h:

(WebCore::SWServerWorker::create):
(WebCore::SWServerWorker::identifier const):

Source/WebKit:

Use a single identifier type to identify Service Workers. We had both a String
identifier and a uint64_t identifier for each service worker. We now consistently
use a ServiceWorkerIdentifier which is a strongly typed identifier backed by a
uint64_t.

• Scripts/webkit/messages.py:

(forward_declarations_and_headers):
(forward_declarations_and_headers.templates):

• StorageProcess/ServiceWorker/WebSWServerConnection.cpp:

(WebKit::WebSWServerConnection::startFetch):
(WebKit::WebSWServerConnection::postMessageToServiceWorkerGlobalScope):
(WebKit::WebSWServerConnection::postMessageToServiceWorkerClient):

• StorageProcess/ServiceWorker/WebSWServerConnection.h:
• StorageProcess/ServiceWorker/WebSWServerConnection.messages.in:
• StorageProcess/StorageProcess.cpp:

(WebKit::StorageProcess::serviceWorkerContextFailedToStart):
(WebKit::StorageProcess::serviceWorkerContextStarted):
(WebKit::StorageProcess::postMessageToServiceWorkerClient):

• StorageProcess/StorageProcess.h:
• StorageProcess/StorageProcess.messages.in:
• WebProcess/Storage/WebSWClientConnection.cpp:

(WebKit::WebSWClientConnection::postMessageToServiceWorkerGlobalScope):
(WebKit::WebSWClientConnection::postMessageToServiceWorkerClient):

• WebProcess/Storage/WebSWClientConnection.h:
• WebProcess/Storage/WebSWClientConnection.messages.in:
• WebProcess/Storage/WebSWContextManagerConnection.cpp:

(WebKit::WebSWContextManagerConnection::updateServiceWorker):
(WebKit::WebSWContextManagerConnection::serviceWorkerStartedWithMessage):
(WebKit::WebSWContextManagerConnection::startFetch):
(WebKit::WebSWContextManagerConnection::postMessageToServiceWorkerGlobalScope):
(WebKit::WebSWContextManagerConnection::postMessageToServiceWorkerClient):

• WebProcess/Storage/WebSWContextManagerConnection.h:
• WebProcess/Storage/WebSWContextManagerConnection.messages.in:

Source/WTF:

Introduce class for strongly typed identifiers. This avoids mixing up
different types of identifiers.

• WTF.xcodeproj/project.pbxproj:
• wtf/ObjectIdentifier.h: Added.

(WTF::ObjectIdentifier::encode const):
(WTF::ObjectIdentifier::decode):
(WTF::ObjectIdentifier::operator== const):
(WTF::ObjectIdentifier::operator!= const):
(WTF::ObjectIdentifier::ObjectIdentifier):
(WTF::makeObjectIdentifier):
(WTF::ObjectIdentifierHash::hash):
(WTF::ObjectIdentifierHash::equal):
(WTF::HashTraits<ObjectIdentifier<T>>::emptyValue):
(WTF::HashTraits<ObjectIdentifier<T>>::constructDeletedValue):
(WTF::HashTraits<ObjectIdentifier<T>>::isDeletedValue):

9:35 AM Changeset in webkit [224402] by aestes@apple.com

• 19 edits
  1 add in trunk

[Payment Request] show() should only be called with user activation
​https://bugs.webkit.org/show_bug.cgi?id=179056

Reviewed by Sam Weinig.

Source/WebCore:

Updated existing tests to call PaymentRequest.show() with user activation.

• Modules/paymentrequest/PaymentRequest.cpp:

(WebCore::PaymentRequest::show):

LayoutTests:

• http/tests/paymentrequest/payment-address-attributes-and-toJSON-method.https.html:
• http/tests/paymentrequest/payment-request-canmakepayment-method.https.html:
• http/tests/paymentrequest/payment-request-change-shipping-address.https.html:
• http/tests/paymentrequest/payment-request-change-shipping-option.https.html:
• http/tests/paymentrequest/payment-request-show-method.https.html:
• http/tests/paymentrequest/payment-response-complete-method.https.html:
• http/tests/paymentrequest/payment-response-methodName-attribute.https.html:
• http/tests/paymentrequest/payment-response-payerEmail-attribute.https.html:
• http/tests/paymentrequest/payment-response-payerName-attribute.https.html:
• http/tests/paymentrequest/payment-response-payerPhone-attribute.https.html:
• http/tests/paymentrequest/resources/helpers.js:

(async.getPaymentRequestResponse):

• http/tests/paymentrequest/updateWith-method-pmi-handling.https.html:
• http/tests/resources/payment-request.js: Added.

(activateThen):

• http/tests/ssl/applepay/ApplePayMerchantValidationEvent.https.html:
• http/tests/ssl/applepay/ApplePayPaymentMethodUpdateEvent.https.html:
• http/tests/ssl/applepay/PaymentRequest.https.html:
• resources/ui-helper.js:

(window.UIHelper.activateElement):

9:33 AM Changeset in webkit [224401] by Jonathan Bedard

• 2 edits in trunk/Tools

TestController platformAdjustContext should use provided WKContext for Mac
​https://bugs.webkit.org/show_bug.cgi?id=179124
<rdar://problem/35295176>

Reviewed by Darin Adler.

• WebKitTestRunner/cocoa/TestControllerCocoa.mm:

(WTR::initializeWebViewConfiguration): Use the provided WKContext, since that is
a WebProcessPool, instead of creating a second one.

9:27 AM Changeset in webkit [224400] by Ms2ger@igalia.com

• 4 edits in trunk/LayoutTests

LayoutTests/imported/w3c:
Update Event-timestamp-high-resolution.html.
​https://bugs.webkit.org/show_bug.cgi?id=179242

Reviewed by Darin Adler.

Synchronise with upstream to make the test more robust.

• web-platform-tests/dom/events/Event-timestamp-high-resolution.html:

LayoutTests:
[WPE] Update Event-timestamp-high-resolution.html expectations.
​https://bugs.webkit.org/show_bug.cgi?id=179242

Reviewed by Darin Adler.

The test now deals more gracefully with the fact that GamepadEvent is
not defined.

• platform/wpe/imported/w3c/web-platform-tests/dom/events/Event-timestamp-high-resolution-expected.txt:

9:03 AM Changeset in webkit [224399] by mark.lam@apple.com

• 5 edits
  1 add in trunk

CachedCall (and its clients) needs overflow checks.
​https://bugs.webkit.org/show_bug.cgi?id=179185

Reviewed by JF Bastien.

JSTests:

• stress/regress-179185.js: Added.

Source/JavaScriptCore:

• interpreter/CachedCall.h:

(JSC::CachedCall::CachedCall):
(JSC::CachedCall::hasOverflowedArguments):

• runtime/ArgList.h:

(JSC::MarkedArgumentBuffer::clear):

• runtime/StringPrototype.cpp:

(JSC::replaceUsingRegExpSearch):

8:41 AM Changeset in webkit [224398] by dbates@webkit.org

• 3 edits
  2 adds in trunk

Invalidate node list when associated form control element is removed
​https://bugs.webkit.org/show_bug.cgi?id=179232
<rdar://problem/35308269>

Reviewed by Ryosuke Niwa.

Source/WebCore:

A node list represents a live view of the DOM. Invalidate the node list
associated with a form element whenever one of its associated form control
elements is removed.

Test: fast/forms/node-list-remove-button-from-form.html

• html/HTMLFormElement.cpp:

(WebCore::HTMLFormElement::removeFormElement):

LayoutTests:

Add a test to ensure the node list returned by HTMLFormElement.elements stays synchronized
with the document.

• fast/forms/node-list-remove-button-from-form-expected.txt: Added.
• fast/forms/node-list-remove-button-from-form.html: Added.

8:24 AM Changeset in webkit [224397] by Antti Koivisto

• 2 edits in trunk/Source/WebKit

Enable display:contents by default as experimental feature
​https://bugs.webkit.org/show_bug.cgi?id=179239
<rdar://problem/35334612>

Reviewed by Darin Adler.

We pass most of the WPT tests. What remains is mostly flexbox related edge cases.

• Shared/WebPreferences.yaml:

8:11 AM Changeset in webkit [224396] by fred.wang@free.fr

• 3 edits in trunk/Source/WebKit

Use WK_IOS_TBA instead of WK_MAC_TBA to indicate availability of private functions on iOS
​https://bugs.webkit.org/show_bug.cgi?id=179238

Patch by Frederic Wang <​fwang@igalia.com> on 2017-11-03
Reviewed by Darin Adler.

• UIProcess/API/Cocoa/WKWebViewPrivate.h:
• UIProcess/API/Cocoa/WKWebsiteDataStorePrivate.h:

8:01 AM Changeset in webkit [224395] by fred.wang@free.fr

• 5 edits in trunk/Source/WebCore

Add USE(APPLE_INTERNAL_SDK)-guards around SPI in ResourceHandle code
​https://bugs.webkit.org/show_bug.cgi?id=136107

Based on patch by Daniel Bates <​dabates@apple.com>
Patch by Frederic Wang <​fwang@igalia.com> on 2017-11-03
Reviewed by Darin Adler.

No new tests, behavior unchanged.

• platform/network/ResourceHandleClient.h: Replace includes of private headers with CFNetworkSPI.h.
• platform/network/ResourceHandleInternal.h: Ditto.
• platform/network/ios/ResourceHandleIOS.mm: Add USE(APPLE_INTERNAL_SDK)-guard around SPI

headers and forward declare NSURLRequest SPI and constant _kCFStreamSSLTrustedLeafCertificates
for clients that build without the internal SDK. Add BSD license block to file.
(WebCore::ResourceHandle::createSSLPropertiesFromNSURLRequest): Fix code style issues; use
nullptr instead of 0, use reinterpret_cast instead of C-style cast, remove unnecessary
"using namespace WebCore"
and rename variables to improve readability.

• platform/network/mac/ResourceErrorMac.mm: Add USE(APPLE_INTERNAL_SDK)-guard around private

headers and add typedef for CFCachedURLResponseRef for clients that build without the
internal SDK.

7:46 AM Changeset in webkit [224394] by Antti Koivisto

• 5 edits
  4 adds in trunk

Crash in WebCore::RenderStyle::overflowX with display:contents
​https://bugs.webkit.org/show_bug.cgi?id=178857
<rdar://problem/35201120>

Reviewed by Zalan Bujtas.

LayoutTests/imported/w3c:

• web-platform-tests/css/css-display-3/display-contents-computed-style-expected.txt:

Source/WebCore:

Crash test by Renata Hodovan.

Tests: fast/css/display-contents-all.html

fast/css/display-contents-document-element.html

• css/StyleResolver.cpp:

(WebCore::adjustDisplayContentsStyle):

For document element 'display:contents' should adjust to 'display:block' like it does for other display types.

LayoutTests:

• fast/css/display-contents-all-expected.html: Added.
• fast/css/display-contents-all.html: Added.
• fast/css/display-contents-document-element-expected.txt: Added.
• fast/css/display-contents-document-element.html: Added.

4:44 AM Changeset in webkit [224393] by Ms2ger@igalia.com

• 2 edits
  6 adds in trunk/LayoutTests

[WPE] Enable the dom/ directory of web-platform-tests.
​https://bugs.webkit.org/show_bug.cgi?id=179180

Reviewed by Carlos Alberto Lopez Perez.

• platform/wpe/TestExpectations: Enable tests; copy expected timeout from generic expectation file.
• platform/wpe/imported/w3c/web-platform-tests/dom/events/Event-timestamp-high-resolution-expected.txt: Added; GamepadEvent is not enabled. (The fragility of the test is fixed upstream.)
• platform/wpe/imported/w3c/web-platform-tests/dom/events/EventTarget-dispatchEvent-expected.txt: Added; more subtests pass than in the generic expectation file.
• platform/wpe/imported/w3c/web-platform-tests/dom/nodes/Document-createEvent-expected.txt: Added; more subtests pass than in the generic expectation file.

4:21 AM WebKitGTK/Gardening/Howto edited by clopez@igalia.com

(diff)

3:23 AM Changeset in webkit [224392] by zandobersek@gmail.com

• 25 edits in trunk/LayoutTests

Unreviewed WPE gardening. Rebaselining tests affected by r224324.

• platform/wpe/css1/pseudo/firstletter-expected.txt:
• platform/wpe/css1/pseudo/multiple_pseudo_elements-expected.txt:
• platform/wpe/css2.1/t051202-c24-first-lttr-00-b-expected.txt:
• platform/wpe/css2.1/t051202-c26-psudo-nest-00-c-expected.txt:
• platform/wpe/css3/selectors3/html/css3-modsel-166-expected.txt:
• platform/wpe/css3/selectors3/html/css3-modsel-166a-expected.txt:
• platform/wpe/css3/selectors3/html/css3-modsel-39-expected.txt:
• platform/wpe/css3/selectors3/html/css3-modsel-39b-expected.txt:
• platform/wpe/css3/selectors3/xhtml/css3-modsel-166-expected.txt:
• platform/wpe/css3/selectors3/xhtml/css3-modsel-166a-expected.txt:
• platform/wpe/css3/selectors3/xhtml/css3-modsel-39-expected.txt:
• platform/wpe/css3/selectors3/xhtml/css3-modsel-39b-expected.txt:
• platform/wpe/css3/selectors3/xml/css3-modsel-166-expected.txt:
• platform/wpe/css3/selectors3/xml/css3-modsel-166a-expected.txt:
• platform/wpe/css3/selectors3/xml/css3-modsel-39-expected.txt:
• platform/wpe/css3/selectors3/xml/css3-modsel-39b-expected.txt:
• platform/wpe/fast/dynamic/first-letter-display-change-expected.txt:
• platform/wpe/ietestcenter/css3/text/textshadow-004-expected.txt:
• platform/wpe/svg/W3C-SVG-1.1/fonts-glyph-02-t-expected.txt:
• platform/wpe/svg/custom/glyph-selection-arabic-forms-expected.txt:
• platform/wpe/svg/text/select-textLength-spacingAndGlyphs-squeeze-2-expected.txt:
• platform/wpe/svg/text/select-textLength-spacingAndGlyphs-squeeze-3-expected.txt:
• platform/wpe/svg/text/select-textLength-spacingAndGlyphs-stretch-2-expected.txt:
• platform/wpe/svg/text/select-textLength-spacingAndGlyphs-stretch-3-expected.txt:

3:02 AM WebKitGTK/Gardening/Calendar edited by Ms2ger@igalia.com

(diff)

3:00 AM Changeset in webkit [224391] by commit-queue@webkit.org

• 3 edits in trunk/Source/WebInspectorUI

Web Inspector: Network Table - Include a secure lock indicator in the domain column
​https://bugs.webkit.org/show_bug.cgi?id=179233
<rdar://problem/34070883>

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2017-11-03
Reviewed by Devin Rousso.

• UserInterface/Views/NetworkTableContentView.css:

(.network-table .cell.domain > .lock):

• UserInterface/Views/NetworkTableContentView.js:

(WI.NetworkTableContentView.prototype.tablePopulateCell):
(WI.NetworkTableContentView.prototype._populateDomainCell):
Add a small lock icon by the domain if the request was https/wss.

2:32 AM Changeset in webkit [224390] by jiewen_tan@apple.com

• 68 edits in trunk/Source/WebCore

Replace some auto* with RefPtr within WebCore/html
​https://bugs.webkit.org/show_bug.cgi?id=179218
<rdar://problem/35102567>

Reviewed by Ryosuke Niwa.

No changes in behaviors.

In this patch, it replace some auto* pointers with RefPtrs. The way it achieves this goal is to wrap
the RHS with makeRefPtr(). Also, some methods have been modified to return RefPtrs directly. Those
include:

HTMLInputElement::list,
HTMLInputElement::dataList,
HTMLLabelElement::control,
HTMLLegendElement::associatedControl,
HTMLSummaryElement::detailsElement,
HTMLTableElement::tHead,
HTMLTableElement::tFoot,
HTMLTablePartElement::findParentTable,
HTMLTableRowElement.cpp::findTable, local function
RadioNodeList.cpp::toRadioButtonInputElement, local function
CanvasStyle::canvasGradient,
CanvasStyle::canvasPattern,
WebGLRenderingContextBase::validateTextureBinding,
GraphicsContext::strokeGradient,
GraphicsContext::fillGradient.

• accessibility/AXObjectCache.cpp:

(WebCore::AXObjectCache::labelChanged):

• accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::correspondingControlForLabelElement const):

• accessibility/AccessibilityTable.cpp:

(WebCore::AccessibilityTable::addChildren):
(WebCore::AccessibilityTable::title const):

• accessibility/atk/WebKitAccessibleInterfaceTable.cpp:

(webkitAccessibleTableGetCaption):

• html/ColorInputType.cpp:

(WebCore::ColorInputType::suggestions const):

• html/FTPDirectoryDocument.cpp:

(WebCore::FTPDirectoryDocumentParser::loadDocumentTemplate):

• html/FileInputType.cpp:

(WebCore::FileInputType::appendFormData const):
(WebCore::FileInputType::disabledAttributeChanged):
(WebCore::FileInputType::multipleAttributeChanged):

• html/FormAssociatedElement.cpp:

(WebCore::FormAssociatedElement::formOwnerRemovedFromTree):

• html/HTMLBodyElement.cpp:

(WebCore::HTMLBodyElement::insertedIntoAncestor):
(WebCore::HTMLBodyElement::didFinishInsertingNode):
(WebCore::HTMLBodyElement::scrollTo):

• html/HTMLDetailsElement.cpp:

(WebCore::HTMLDetailsElement::isActiveSummary const):
(WebCore::HTMLDetailsElement::parseAttribute):

• html/HTMLDocument.cpp:

(WebCore::HTMLDocument::namedItem):

• html/HTMLElement.cpp:

(WebCore::HTMLElement::editabilityFromContentEditableAttr):

• html/HTMLFormControlElement.cpp:

(WebCore::HTMLFormControlElement::didAttachRenderers):

• html/HTMLFrameOwnerElement.cpp:

(WebCore:: const):

• html/HTMLFrameSetElement.cpp:

(WebCore::HTMLFrameSetElement::namedItem):

• html/HTMLHtmlElement.cpp:

(WebCore::HTMLHtmlElement::insertedByParser):

• html/HTMLImageElement.cpp:

(WebCore::HTMLImageElement::bestFitSourceFromPictureElement):

• html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::defaultEventHandler):
(WebCore::HTMLInputElement::list const):
(WebCore::HTMLInputElement::dataList const):
(WebCore::HTMLInputElement::setupDateTimeChooserParameters):

• html/HTMLInputElement.h:
• html/HTMLLabelElement.cpp:

(WebCore::firstElementWithIdIfLabelable):
(WebCore::HTMLLabelElement::control const):
(WebCore::HTMLLabelElement::form const):
(WebCore::HTMLLabelElement::setActive):
(WebCore::HTMLLabelElement::setHovered):
(WebCore::HTMLLabelElement::willRespondToMouseClickEvents):
(WebCore::HTMLLabelElement::focus):
(WebCore::HTMLLabelElement::accessKeyAction):

• html/HTMLLabelElement.h:
• html/HTMLLegendElement.cpp:

(WebCore::HTMLLegendElement::associatedControl):
(WebCore::HTMLLegendElement::focus):
(WebCore::HTMLLegendElement::accessKeyAction):
(WebCore::HTMLLegendElement::form const):

• html/HTMLLegendElement.h:
• html/HTMLLinkElement.cpp:

(WebCore::HTMLLinkElement::setCSSStyleSheet):
(WebCore::HTMLLinkElement::addSubresourceAttributeURLs const):

• html/HTMLMediaElement.cpp:

(WebCore::needsAutoplayPlayPauseEventsQuirk):
(WebCore::HTMLMediaElement::loadResource):
(WebCore::HTMLMediaElement::updateActiveTextTrackCues):
(WebCore::HTMLMediaElement::removeTextTrack):
(WebCore::HTMLMediaElement::layoutSizeChanged):

• html/HTMLObjectElement.cpp:

(WebCore::shouldBeExposed):
(WebCore::HTMLObjectElement::appendFormData):

• html/HTMLOptGroupElement.cpp:

(WebCore::HTMLOptGroupElement::recalcSelectOptions):

• html/HTMLPictureElement.cpp:

(WebCore::HTMLPictureElement::viewportChangeAffectedPicture const):

• html/HTMLPlugInElement.cpp:

(WebCore::HTMLPlugInElement::bindingsInstance):

• html/HTMLPlugInImageElement.cpp:

(WebCore::HTMLPlugInImageElement::isImageType):
(WebCore::HTMLPlugInImageElement::willDetachRenderers):
(WebCore::HTMLPlugInImageElement::partOfSnapshotOverlay const):
(WebCore::HTMLPlugInImageElement::checkSizeChangeForSnapshotting):

• html/HTMLSlotElement.cpp:

(WebCore::HTMLSlotElement::attributeChanged):
(WebCore:: const):

• html/HTMLSourceElement.cpp:

(WebCore::HTMLSourceElement::parseAttribute):

• html/HTMLStyleElement.cpp:

(WebCore::HTMLStyleElement::addSubresourceAttributeURLs const):

• html/HTMLSummaryElement.cpp:

(WebCore::HTMLSummaryElement::detailsElement const):

• html/HTMLSummaryElement.h:
• html/HTMLTableElement.cpp:

(WebCore::HTMLTableElement::caption const):
(WebCore::HTMLTableElement::tHead const):
(WebCore::HTMLTableElement::tFoot const):
(WebCore::HTMLTableElement::createTHead):
(WebCore::HTMLTableElement::deleteTHead):
(WebCore::HTMLTableElement::createTFoot):
(WebCore::HTMLTableElement::deleteTFoot):
(WebCore::HTMLTableElement::createCaption):
(WebCore::HTMLTableElement::deleteCaption):

• html/HTMLTableElement.h:
• html/HTMLTablePartElement.cpp:

(WebCore::HTMLTablePartElement::findParentTable const):

• html/HTMLTablePartElement.h:
• html/HTMLTableRowElement.cpp:

(WebCore::findTable):
(WebCore::HTMLTableRowElement::rowIndex const):
(WebCore::findRows):

• html/HTMLTableSectionElement.cpp:

(WebCore::HTMLTableSectionElement::additionalPresentationAttributeStyle const):

• html/HTMLTrackElement.cpp:

(WebCore::HTMLTrackElement::mediaElement const):

• html/LinkIconCollector.cpp:

(WebCore::LinkIconCollector::iconsOfTypes):

• html/MediaDocument.cpp:

(WebCore::MediaDocumentParser::createDocumentStructure):
(WebCore::MediaDocument::replaceMediaElementTimerFired):

• html/MediaElementSession.cpp:

(WebCore::needsArbitraryUserGestureAutoplayQuirk):
(WebCore::isElementRectMostlyInMainFrame):
(WebCore::isElementLargeRelativeToMainFrame):

• html/PluginDocument.cpp:

(WebCore::PluginDocumentParser::createDocumentStructure):
(WebCore::PluginDocumentParser::appendBytes):

• html/RadioNodeList.cpp:

(WebCore::toRadioButtonInputElement):
(WebCore::RadioNodeList::value const):
(WebCore::RadioNodeList::setValue):

• html/RangeInputType.cpp:

(WebCore::RangeInputType::updateTickMarkValues):

• html/canvas/CanvasRenderingContext.cpp:

(WebCore::CanvasRenderingContext::wouldTaintOrigin):

• html/canvas/CanvasRenderingContext2D.cpp:

(WebCore::CanvasRenderingContext2D::setStrokeStyle):
(WebCore::CanvasRenderingContext2D::setFillStyle):
(WebCore::CanvasRenderingContext2D::fillInternal):
(WebCore::CanvasRenderingContext2D::strokeInternal):
(WebCore::CanvasRenderingContext2D::fillRect):
(WebCore::CanvasRenderingContext2D::strokeRect):
(WebCore::toStyle):
(WebCore::CanvasRenderingContext2D::drawTextInternal):

• html/canvas/CanvasStyle.h:

(WebCore::CanvasStyle::canvasGradient const):
(WebCore::CanvasStyle::canvasPattern const):

• html/canvas/WebGL2RenderingContext.cpp:

(WebCore::WebGL2RenderingContext::texStorage2D):
(WebCore::WebGL2RenderingContext::getFramebufferAttachmentParameter):
(WebCore::WebGL2RenderingContext::validateIndexArrayConservative):

• html/canvas/WebGLBuffer.h:
• html/canvas/WebGLRenderingContext.cpp:

(WebCore::WebGLRenderingContext::getFramebufferAttachmentParameter):
(WebCore::WebGLRenderingContext::validateIndexArrayConservative):

• html/canvas/WebGLRenderingContextBase.cpp:

(WebCore::WebGLRenderingContextBase::compressedTexImage2D):
(WebCore::WebGLRenderingContextBase::compressedTexSubImage2D):
(WebCore::WebGLRenderingContextBase::copyTexSubImage2D):
(WebCore::WebGLRenderingContextBase::generateMipmap):
(WebCore::WebGLRenderingContextBase::getTexParameter):
(WebCore::WebGLRenderingContextBase::texImage2DBase):
(WebCore::WebGLRenderingContextBase::validateTexFunc):
(WebCore::WebGLRenderingContextBase::texSubImage2D):
(WebCore::WebGLRenderingContextBase::texSubImage2DBase):
(WebCore::WebGLRenderingContextBase::copyTexImage2D):
(WebCore::WebGLRenderingContextBase::texImage2D):
(WebCore::WebGLRenderingContextBase::texParameter):
(WebCore::WebGLRenderingContextBase::validateTextureBinding):

• html/canvas/WebGLRenderingContextBase.h:
• html/parser/HTMLConstructionSite.cpp:

(WebCore::executeReparentTask):
(WebCore::executeTakeAllChildrenAndReparentTask):
(WebCore::HTMLConstructionSite::dispatchDocumentElementAvailableIfNeeded):
(WebCore::HTMLConstructionSite::createHTMLElementOrFindCustomElementInterface):
(WebCore::HTMLConstructionSite::findFosterSite):

• html/parser/HTMLPreloadScanner.cpp:

(WebCore::TokenPreloadScanner::StartTagScanner::processAttribute):

• html/parser/XSSAuditorDelegate.cpp:

(WebCore::XSSAuditorDelegate::generateViolationReport):

• html/shadow/TextControlInnerElements.cpp:

(WebCore::SearchFieldResultsButtonElement::defaultEventHandler):

• html/track/InbandGenericTextTrack.cpp:

(WebCore::InbandGenericTextTrack::updateGenericCue):
(WebCore::InbandGenericTextTrack::removeGenericCue):

• html/track/InbandTextTrack.cpp:

(WebCore::InbandTextTrack::willRemove):

• html/track/TextTrack.cpp:

(WebCore::TextTrack::addCue):
(WebCore::TextTrack::addRegion):

• html/track/VideoTrack.cpp:

(WebCore::VideoTrack::willRemove):

• inspector/InspectorCanvas.cpp:

(WebCore::InspectorCanvas::buildInitialState):

• platform/graphics/GraphicsContext.h:

(WebCore::GraphicsContext::strokeGradient const):
(WebCore::GraphicsContext::fillGradient const):

• rendering/svg/RenderSVGPath.cpp:

(WebCore::useStrokeStyleToFill):

12:04 AM Changeset in webkit [224389] by webkit@devinrousso.com

• 17 edits in trunk

Web Inspector: Canvas2D Profiling: highlight expensive context commands in the captured command log
​https://bugs.webkit.org/show_bug.cgi?id=178302
<rdar://problem/33158849>

Reviewed by Brian Burg.

Source/JavaScriptCore:

• inspector/protocol/Recording.json:

Add duration to each Frame that represents the total time of all the recorded actions.

Source/WebCore:

No new tests, updated existing tests.

• inspector/InspectorCanvas.h:
• inspector/InspectorCanvas.cpp:

(WebCore::InspectorCanvas::recordAction):
(WebCore::InspectorCanvas::finalizeFrame):
(WebCore::InspectorCanvas::markNewFrame): Deleted.

• inspector/InspectorCanvasAgent.cpp:

(WebCore::InspectorCanvasAgent::didFinishRecordingCanvasFrame):

Source/WebInspectorUI:

• UserInterface/Models/RecordingFrame.js:

(WI.RecordingFrame):
(WI.RecordingFrame.fromPayload):
(WI.RecordingFrame.prototype.get duration):
(WI.RecordingFrame.prototype.toJSON):

• UserInterface/Views/RecordingNavigationSidebarPanel.js:

(WI.RecordingNavigationSidebarPanel.prototype.set recording):

• UserInterface/Views/RecordingNavigationSidebarPanel.css:

(.sidebar > .panel.navigation.recording > .content > .tree-outline .item.folder-icon > .status):

LayoutTests:

• inspector/canvas/recording-2d-expected.txt:
• inspector/canvas/recording-webgl-expected.txt:
• inspector/canvas/recording-webgl-snapshots-expected.txt:
• inspector/canvas/resources/recording-utilities.js:

(TestPage.registerInitializer):

• inspector/model/recording-expected.txt:
• inspector/model/recording.html: