Timeline

Nov 10, 2017:

10:15 PM Changeset in webkit [224724] by Chris Dumez

• 13 edits in trunk/LayoutTests

Unreviewed, unskip & rebaseline several service worker tests

LayoutTests/imported/w3c:

• web-platform-tests/service-workers/service-worker/ServiceWorkerGlobalScope/unregister.https-expected.txt:
• web-platform-tests/service-workers/service-worker/ServiceWorkerGlobalScope/update.https-expected.txt:
• web-platform-tests/service-workers/service-worker/import-scripts-updated-flag.https-expected.txt:
• web-platform-tests/service-workers/service-worker/navigation-redirect.https-expected.txt:
• web-platform-tests/service-workers/service-worker/registration-script.https-expected.txt:
• web-platform-tests/service-workers/service-worker/registration-service-worker-attributes.https-expected.txt:
• web-platform-tests/service-workers/service-worker/registration-updateviacache.https-expected.txt:
• web-platform-tests/service-workers/service-worker/unregister-controller.https-expected.txt:
• web-platform-tests/service-workers/service-worker/unregister-then-register-new-script.https-expected.txt:
• web-platform-tests/service-workers/service-worker/update-bytecheck.https-expected.txt:

LayoutTests:

• TestExpectations:

9:15 PM Changeset in webkit [224723] by Chris Dumez

• 10 edits
  3 adds in trunk

[Service Workers] Registration promise should be rejected when the service worker fails to start
​https://bugs.webkit.org/show_bug.cgi?id=179566

Reviewed by Brady Eidson.

LayoutTests/imported/w3c:

Rebaseline WPT tests now that we properly reject registration promises when the worker script
fails to evaluate.

• web-platform-tests/service-workers/service-worker/ServiceWorkerGlobalScope/registration-attribute.https-expected.txt:
• web-platform-tests/service-workers/service-worker/navigation-redirect.https-expected.txt:
• web-platform-tests/service-workers/service-worker/redirected-response.https-expected.txt:
• web-platform-tests/service-workers/service-worker/update.https-expected.txt:

Source/WebCore:

Registration promise should be rejected when the service worker fails to start.

Though our code intended to do this, there were several issues:

• Our code failed to properly detect when the script failed to evaluate. This is because it relied on the exception message being non-null but it was always null when same origin due to a bug.
• Our scriptContextFailedToStart() handler failed to rejected the promise and finish the job as per:
  • ​https://w3c.github.io/ServiceWorker/#update-algorithm (step 9.7)

Test: http/tests/workers/service/worker-fails-to-start.html

• bindings/js/WorkerScriptController.cpp:

(WebCore::WorkerScriptController::evaluate):

• workers/service/server/SWServerJobQueue.cpp:

(WebCore::SWServerJobQueue::scriptContextFailedToStart):

LayoutTests:

Add layout test coverage.

• TestExpectations: Mark test as flaky as the console lines sometimes change order.
• http/tests/workers/service/resources/worker-fails-to-start-worker.js: Added.
• http/tests/workers/service/worker-fails-to-start-expected.txt: Added.
• http/tests/workers/service/worker-fails-to-start.html: Added.

8:32 PM Changeset in webkit [224722] by commit-queue@webkit.org

• 2 edits in trunk/Tools

check-webkit-style: AttributeError: 'NoneType' object has no attribute 'major'
​https://bugs.webkit.org/show_bug.cgi?id=179522

Patch by Fujii Hironori <Fujii Hironori> on 2017-11-10
Reviewed by Aakash Jain.

IOSSimulatorPort.ios_version should return a Version object.

• Scripts/webkitpy/port/ios_simulator.py:

(IOSSimulatorPort.ios_version): Return a Version object.

6:45 PM Changeset in webkit [224721] by jer.noble@apple.com

• 2 edits in trunk/Source/WebCore

Unreviewed Win Debug build fix; add FourCC.cpp to the cmake source list for Windows.

• PlatformWin.cmake:

6:35 PM Changeset in webkit [224720] by commit-queue@webkit.org

• 2 edits in trunk/Tools

[Win] The way to detect Windows 10 is wrong
​https://bugs.webkit.org/show_bug.cgi?id=179344

Patch by Basuke Suzuki <Basuke Suzuki> on 2017-11-10
Reviewed by Alex Christensen.

• Scripts/webkitpy/common/system/platforminfo.py:

(PlatformInfo._determine_win_version):

5:43 PM Changeset in webkit [224719] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebCore

[CG] PDF document cached image is regenerated every time the destination rectangle changes
​https://bugs.webkit.org/show_bug.cgi?id=179516

Patch by Said Abou-Hallawa <​sabouhallawa@apple.com> on 2017-11-10
Reviewed by Tim Horton.

The PDF document cached image was regenerated if m_cachedImageRect didn't
contain the dirty rectangle. When moving the image, its new rectangle is
invalidated. This will set a new dirty rectangle outside m_cachedImageRect
which may not be fully inside m_cachedImageRect.

The PDF document cached image should be reused if we still draw the same
part of the image (srcRet did not change) and we use the same zooming factor
(dstSize did not change).

• platform/graphics/cg/PDFDocumentImage.cpp:

(WebCore::PDFDocumentImage::cacheParametersMatch const): Remove a check
that was added mainly to force recalculating m_cachedImageRect when the
dirty rectangle changes.

(WebCore::PDFDocumentImage::updateCachedImageIfNeeded): Recalculate
m_cachedImageRect every time this function is called regardless the cached
image will be regenerated or not.

5:22 PM Changeset in webkit [224718] by Ryan Haddad

• 3 edits in trunk/LayoutTests

Update TestExpectations for imported/w3c/web-platform-tests/html/browsers/origin/relaxing-the-same-origin-restriction/document_domain_setter_null.tentative.html.
​https://bugs.webkit.org/show_bug.cgi?id=177440

Unreviewed test gardening.

• TestExpectations:
• platform/wk2/TestExpectations:

5:16 PM Changeset in webkit [224717] by Ryan Haddad

• 2 edits in trunk/LayoutTests

Mark http/tests/websocket/tests/hybi/contentextensions/upgrade-worker.html as flaky.
​https://bugs.webkit.org/show_bug.cgi?id=179557

Unreviewed test gardening.

• platform/mac-wk2/TestExpectations:

5:07 PM Changeset in webkit [224716] by Simon Fraser

• 2 edits in trunk/Source/WebCore

Compositing layers in UIWebView are often missing content after scrolling
​https://bugs.webkit.org/show_bug.cgi?id=179564
rdar://problem/33885639

Reviewed by Tim Horton.

When dropping backing store for layers outside the viewport, we rely on a compositing
layer flush to compute layer visibility and bring the backing store back when necessary.

In UIWebView, we have a mechanism to trigger flushing on user scrolling but it only triggers
when there are tiled layers. Remove that condition so it triggers always, now that
backing store availability also depends on this.

• page/ios/FrameIOS.mm:

(WebCore::Frame::viewportOffsetChanged):
(WebCore::anyFrameHasTiledLayers): Deleted.

5:07 PM Changeset in webkit [224715] by Simon Fraser

• 3 edits
  2 adds in trunk

Contents of composited overflow-scroll are missing when newly added
​https://bugs.webkit.org/show_bug.cgi?id=179556
rdar://problem/20368294

Reviewed by Tim Horton.

Source/WebCore:

When content is appended to an oveflow:scroll, we do a subtree layout. That triggered
a compositing code path that failed to call updateAfterDescendants() which is where
we compute whether we can be a simple composited layer without backing store. Fix to
call that after the updateGeometry() call, as we do elsewhere.

Test: compositing/backing/overflow-gains-content.html

• rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::updateAfterLayout):

LayoutTests:

• compositing/backing/overflow-gains-content-expected.html: Added.
• compositing/backing/overflow-gains-content.html: Added.

4:20 PM Changeset in webkit [224714] by commit-queue@webkit.org

• 4 edits in trunk/Tools

[WinCairo] LayoutTests doesn't read TextExpectations files correctly
​https://bugs.webkit.org/show_bug.cgi?id=179219

Patch by Basuke Suzuki <Basuke Suzuki> on 2017-11-10
Reviewed by Alex Christensen.

• Scripts/webkitpy/layout_tests/models/test_expectations.py:

(TestExpectationParser._parse_line):

• Scripts/webkitpy/port/apple.py:

(ApplePort.init):
(ApplePort._allowed_port_names):
(ApplePort):
(ApplePort._future_port_name):
(ApplePort._generate_all_test_configurations):

• Scripts/webkitpy/port/win.py:

(WinCairoPort.default_baseline_search_path):
(WinCairoPort):
(WinCairoPort._future_port_name):

4:18 PM Changeset in webkit [224713] by commit-queue@webkit.org

• 2 edits in trunk/Tools

[WinCairo] Treat 'future' version correctly
​https://bugs.webkit.org/show_bug.cgi?id=179345

Patch by Basuke Suzuki <Basuke Suzuki> on 2017-11-10
Reviewed by Alex Christensen.

• Scripts/webkitpy/port/win.py:

(WinCairoPort.default_baseline_search_path):

4:15 PM Changeset in webkit [224712] by Simon Fraser

• 6 edits in trunk/Source/WebCore

Remove the 'CompositingChildrenOnly' flag which was always on
​https://bugs.webkit.org/show_bug.cgi?id=179546

Reviewed by Antoine Quint.

All calls to updateAfterLayout() passed the CompositingChildrenOnly flag, so all calls
to updateCompositingDescendantGeometry() had compositedChildrenOnly=true, so remove
these flags.

Also use an OptionSet<>.

• rendering/RenderLayer.cpp:

(WebCore::RenderLayer::updateLayerPositions):

• rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::updateAfterLayout):
(WebCore::RenderLayerBacking::contentChanged):

• rendering/RenderLayerBacking.h:
• rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::updateCompositingDescendantGeometry):

• rendering/RenderLayerCompositor.h:

4:03 PM Changeset in webkit [224711] by Chris Dumez

• 3 edits in trunk/Source/WebCore

Remove dead code from ServiceWorkerRegistration
​https://bugs.webkit.org/show_bug.cgi?id=179555

Reviewed by Ryosuke Niwa.

• workers/service/ServiceWorkerRegistration.cpp:

(WebCore::ServiceWorkerRegistration::setInstallingWorker): Deleted.
(WebCore::ServiceWorkerRegistration::setWaitingWorker): Deleted.
(WebCore::ServiceWorkerRegistration::setActiveWorker): Deleted.

• workers/service/ServiceWorkerRegistration.h:

4:00 PM Changeset in webkit [224710] by Chris Dumez

• 5 edits
  2 adds in trunk

[Service Workers] Implement better support for "Clear Registration" algorithm
​https://bugs.webkit.org/show_bug.cgi?id=179441

Reviewed by Brady Eidson.

LayoutTests/imported/w3c:

Rebaseline WPT test due to behavior change. Unfortunately, the check goes from PASS to FAIL.
The reason is that we do not implement "Try Clear Registration" algorithm, only the "Clear
Registration" one. The test expects that a registration object does not get cleared after
unregistration because it is "in use". However, because we do not yet support checking if
a registration is "in use" in try clear, we proceed to clearing the registration and marking
its service workers as redundant.

Previously, the test was passing because even though we were clearing the registration, we
did not mark its service workers as redundant yet. As a result, we would still report that
the registration as having an active worker with "activated" state and the test would think
we did not clear the registration, even though we did.

• web-platform-tests/service-workers/service-worker/getregistrations.https-expected.txt:

Source/WebCore:

Implement better support for "Clear Registration" algorithm as per:

• ​https://w3c.github.io/ServiceWorker/#clear-registration-algorithm

In particular, we now properly clear the service workers on the ServiceWorkerRegistration
object and we properly update its service workers' state to "redundant".

Test: http/tests/workers/service/registration-clear-redundant-worker.html

• workers/service/server/SWServerJobQueue.cpp:

(WebCore::SWServerJobQueue::clearRegistration):

LayoutTests:

Add layout test coverage.

• http/tests/workers/service/registration-clear-redundant-worker-expected.txt: Added.
• http/tests/workers/service/registration-clear-redundant-worker.html: Added.

3:44 PM Changeset in webkit [224709] by Ryan Haddad

• 21 edits
  4 deletes in trunk

Unreviewed, rolling out r224705.

Introduced a LayoutTest crash on WK1.

Reverted changeset:

"[Web Animations] Implement getAnimations()"
​https://bugs.webkit.org/show_bug.cgi?id=179535
​https://trac.webkit.org/changeset/224705

3:13 PM Changeset in webkit [224708] by Wenson Hsieh

• 2 edits in trunk/Tools

Finish rolling out r224544

Rubber-stamped by Tim Horton.

Now that ​https://bugs.webkit.org/show_bug.cgi?id=179431 has been fixed, we can once again allow one of the API
tests added in r224512 (WKAttachmentTests.AttachmentUpdatesWhenChangingFontStyles) to test toggling underline
style with a selected attachment element.

• TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:

(TestWebKitAPI::TEST):

3:02 PM Changeset in webkit [224707] by jer.noble@apple.com

• 20 edits
  8 copies
  1 move
  14 adds
  1 delete in trunk

Add a FairPlay Streaming based CDM for Modern EME
​https://bugs.webkit.org/show_bug.cgi?id=179499
<rdar://problem/35445033>

Reviewed by Eric Carlson.

Source/WebCore:

Tests: platform/mac/media/encrypted-media/fps-createMediaKeys.html

platform/mac/media/encrypted-media/fps-requestMediaKeySystemAccess.html

Add new CDMFairPlayStreaming and CDMInstanceFairPlayStreamingAVFObjC platform classes which implement
the basics of FairPlay Streaming support in Modern EME.

Drive-by fixes:

• Add a != operator to FourCC
• Add a virtual setStorageDirectory() method to CDMInstance (and default implementations to CDMClearKey and MockCDM)
• Move ISOVTTCue into the platform/graphics/iso directory and update all the places where it is called.

• Modules/encryptedmedia/MediaKeySession.cpp:

(WebCore::MediaKeySession::mediaKeysStorageDirectory const):

• Modules/encryptedmedia/MediaKeySession.h:
• Sources.txt:
• WebCore.xcodeproj/project.pbxproj:
• platform/encryptedmedia/CDMFactory.cpp:
• platform/encryptedmedia/CDMInstance.h:
• platform/encryptedmedia/CDMRestrictions.h:
• platform/encryptedmedia/clearkey/CDMClearKey.cpp:

(WebCore::CDMInstanceClearKey::setStorageDirectory):

• platform/encryptedmedia/clearkey/CDMClearKey.h:
• platform/graphics/FourCC.h:

(WebCore::FourCC::operator!= const):

• platform/graphics/iso/ISOBox.cpp: Added.

(WebCore::ISOBox::peekBox):
(WebCore::ISOBox::read):
(WebCore::ISOBox::parse):
(WebCore::ISOFullBox::parse):

• platform/graphics/iso/ISOBox.h: Added.

(WebCore::ISOBox::minimumBoxSize):
(WebCore::ISOBox::size const):
(WebCore::ISOBox::boxType const):
(WebCore::ISOBox::extendedType const):
(WebCore::ISOBox::checkedRead):
(WebCore::ISOFullBox::version const):
(WebCore::ISOFullBox::flags const):

• platform/graphics/iso/ISOOriginalFormatBox.cpp: Added.

(WebCore::ISOOriginalFormatBox::parse):

• platform/graphics/iso/ISOOriginalFormatBox.h: Added.

(WebCore::ISOOriginalFormatBox::boxTypeName):
(WebCore::ISOOriginalFormatBox::dataFormat const):

• platform/graphics/iso/ISOProtectionSchemeInfoBox.cpp: Added.

(WebCore::ISOProtectionSchemeInfoBox::parse):

• platform/graphics/iso/ISOProtectionSchemeInfoBox.h: Added.

(WebCore::ISOProtectionSchemeInfoBox::boxTypeName):
(WebCore::ISOProtectionSchemeInfoBox::schemeTypeBox const):
(WebCore::ISOProtectionSchemeInfoBox::schemeInformationBox const):

• platform/graphics/iso/ISOSchemeInformationBox.cpp: Added.

(WebCore::ISOSchemeInformationBox::parse):

• platform/graphics/iso/ISOSchemeInformationBox.h: Added.

(WebCore::ISOSchemeInformationBox::boxTypeName):
(WebCore::ISOSchemeInformationBox::schemeSpecificData const):

• platform/graphics/iso/ISOSchemeTypeBox.cpp: Added.

(WebCore::ISOSchemeTypeBox::parse):

• platform/graphics/iso/ISOSchemeTypeBox.h: Added.

(WebCore::ISOSchemeTypeBox::boxTypeName):
(WebCore::ISOSchemeTypeBox::schemeType const):
(WebCore::ISOSchemeTypeBox::schemeVersion const):

• platform/graphics/iso/ISOTrackEncryptionBox.cpp: Added.

(WebCore::ISOTrackEncryptionBox::parse):

• platform/graphics/iso/ISOTrackEncryptionBox.h: Added.

(WebCore::ISOTrackEncryptionBox::boxTypeName):
(WebCore::ISOTrackEncryptionBox::defaultCryptByteBlock const):
(WebCore::ISOTrackEncryptionBox::defaultSkipByteBlock const):
(WebCore::ISOTrackEncryptionBox::defaultIsProtected const):
(WebCore::ISOTrackEncryptionBox::defaultPerSampleIVSize const):
(WebCore::ISOTrackEncryptionBox::defaultKID const):
(WebCore::ISOTrackEncryptionBox::defaultConstantIV const):

• platform/graphics/iso/ISOVTTCue.cpp: Added.

(WebCore::ISOStringBox::contents):
(WebCore::vttIdBoxType):
(WebCore::vttSettingsBoxType):
(WebCore::vttPayloadBoxType):
(WebCore::vttCurrentTimeBoxType):
(WebCore::vttCueSourceIDBoxType):
(WebCore::ISOWebVTTCue::ISOWebVTTCue):
(WebCore::ISOWebVTTCue::parse):

• platform/graphics/iso/ISOVTTCue.h: Renamed from Source/WebCore/platform/graphics/ISOVTTCue.h.

(WebCore::ISOWebVTTCue::boxTypeName):
(WebCore::ISOWebVTTCue::presentationTime const):
(WebCore::ISOWebVTTCue::duration const):
(WebCore::ISOWebVTTCue::sourceID const):
(WebCore::ISOWebVTTCue::id const):
(WebCore::ISOWebVTTCue::originalStartTime const):
(WebCore::ISOWebVTTCue::settings const):
(WebCore::ISOWebVTTCue::cueText const):

• platform/graphics/avfoundation/CDMFairPlayStreaming.cpp: Added.

(WebCore::extractSinfData):
(WebCore::extractSchemeAndKeyIdFromSinf):
(WebCore::extractKeyIDsSinf):
(WebCore::sanitizeSinf):
(WebCore::CDMFactory::platformRegisterFactories):
(WebCore::CDMFactoryFairPlayStreaming::singleton):
(WebCore::CDMFactoryFairPlayStreaming::createCDM):
(WebCore::CDMFactoryFairPlayStreaming::supportsKeySystem):
(WebCore::CDMPrivateFairPlayStreaming::supportsInitDataType const):
(WebCore::CDMPrivateFairPlayStreaming::supportsConfiguration const):
(WebCore::CDMPrivateFairPlayStreaming::supportsConfigurationWithRestrictions const):
(WebCore::CDMPrivateFairPlayStreaming::supportsSessionTypeWithConfiguration const):
(WebCore::CDMPrivateFairPlayStreaming::supportsRobustness const):
(WebCore::CDMPrivateFairPlayStreaming::distinctiveIdentifiersRequirement const):
(WebCore::CDMPrivateFairPlayStreaming::persistentStateRequirement const):
(WebCore::CDMPrivateFairPlayStreaming::distinctiveIdentifiersAreUniquePerOriginAndClearable const):
(WebCore::CDMPrivateFairPlayStreaming::createInstance):
(WebCore::CDMPrivateFairPlayStreaming::loadAndInitialize):
(WebCore::CDMPrivateFairPlayStreaming::supportsServerCertificates const):
(WebCore::CDMPrivateFairPlayStreaming::supportsSessions const):
(WebCore::CDMPrivateFairPlayStreaming::supportsInitData const):
(WebCore::CDMPrivateFairPlayStreaming::sanitizeResponse const):
(WebCore::CDMPrivateFairPlayStreaming::sanitizeSessionId const):

• platform/graphics/avfoundation/CDMFairPlayStreaming.h: Added.
• platform/graphics/avfoundation/objc/CDMInstanceFairPlayStreamingAVFObjC.h: Added.
• platform/graphics/avfoundation/objc/CDMInstanceFairPlayStreamingAVFObjC.mm: Added.

(-[WebCoreFPSContentKeySessionDelegate initWithParent:]):
(-[WebCoreFPSContentKeySessionDelegate invalidate]):
(-[WebCoreFPSContentKeySessionDelegate contentKeySession:didProvideContentKeyRequest:]):
(-[WebCoreFPSContentKeySessionDelegate contentKeySession:didProvideRenewingContentKeyRequest:]):
(-[WebCoreFPSContentKeySessionDelegate contentKeySession:didProvidePersistableContentKeyRequest:]):
(-[WebCoreFPSContentKeySessionDelegate contentKeySession:didUpdatePersistableContentKey:forContentKeyIdentifier:]):
(-[WebCoreFPSContentKeySessionDelegate contentKeySession:contentKeyRequest:didFailWithError:]):
(-[WebCoreFPSContentKeySessionDelegate contentKeySession:shouldRetryContentKeyRequest:reason:]):
(-[WebCoreFPSContentKeySessionDelegate contentKeySessionContentProtectionSessionIdentifierDidChange:]):
(WebCore::CDMInstanceFairPlayStreamingAVFObjC::CDMInstanceFairPlayStreamingAVFObjC):
(WebCore::CDMInstanceFairPlayStreamingAVFObjC::~CDMInstanceFairPlayStreamingAVFObjC):
(WebCore::CDMInstanceFairPlayStreamingAVFObjC::supportsPersistableState):
(WebCore::CDMInstanceFairPlayStreamingAVFObjC::supportsPersistentKeys):
(WebCore::CDMInstanceFairPlayStreamingAVFObjC::mimeTypeIsPlayable):
(WebCore::CDMInstanceFairPlayStreamingAVFObjC::initializeWithConfiguration):
(WebCore::CDMInstanceFairPlayStreamingAVFObjC::setDistinctiveIdentifiersAllowed):
(WebCore::CDMInstanceFairPlayStreamingAVFObjC::setPersistentStateAllowed):
(WebCore::CDMInstanceFairPlayStreamingAVFObjC::setServerCertificate):
(WebCore::CDMInstanceFairPlayStreamingAVFObjC::setStorageDirectory):
(WebCore::CDMInstanceFairPlayStreamingAVFObjC::isLicenseTypeSupported const):
(WebCore::CDMInstanceFairPlayStreamingAVFObjC::requestLicense):
(WebCore::CDMInstanceFairPlayStreamingAVFObjC::updateLicense):
(WebCore::CDMInstanceFairPlayStreamingAVFObjC::loadSession):
(WebCore::CDMInstanceFairPlayStreamingAVFObjC::closeSession):
(WebCore::CDMInstanceFairPlayStreamingAVFObjC::removeSessionData):
(WebCore::CDMInstanceFairPlayStreamingAVFObjC::storeRecordOfKeyUsage):
(WebCore::CDMInstanceFairPlayStreamingAVFObjC::keySystem const):
(WebCore::CDMInstanceFairPlayStreamingAVFObjC::didProvideRequest):
(WebCore::CDMInstanceFairPlayStreamingAVFObjC::didProvideRenewingRequest):
(WebCore::CDMInstanceFairPlayStreamingAVFObjC::didProvidePersistableRequest):
(WebCore::CDMInstanceFairPlayStreamingAVFObjC::didFailToProvideRequest):
(WebCore::CDMInstanceFairPlayStreamingAVFObjC::shouldRetryRequestForReason):
(WebCore::CDMInstanceFairPlayStreamingAVFObjC::sessionIdentifierChanged):

• platform/graphics/avfoundation/InbandTextTrackPrivateAVF.cpp:

(WebCore::InbandTextTrackPrivateAVF::processNativeSamples):
(WebCore::InbandTextTrackPrivateAVF::readNativeSampleBuffer):

• testing/MockCDMFactory.cpp:

(WebCore::MockCDMInstance::setStorageDirectory):

• testing/MockCDMFactory.h:

Source/WTF:

• wtf/Platform.h:

LayoutTests:

• platform/mac/TestExpectations:
• platform/mac/media/encrypted-media/fps-createMediaKeys-expected.txt: Added.
• platform/mac/media/encrypted-media/fps-createMediaKeys.html: Added.
• platform/mac/media/encrypted-media/fps-requestMediaKeySystemAccess-expected.txt: Added.
• platform/mac/media/encrypted-media/fps-requestMediaKeySystemAccess.html: Added.

2:36 PM Changeset in webkit [224706] by Megan Gardner

• 5 edits in trunk/LayoutTests

Rebase some layout tests
​https://bugs.webkit.org/show_bug.cgi?id=179519

Reviewed by Alex Christensen and Tim Horton.

In helping with cleaning up tests, rebase tests that have only been effected by font changes
and other similarly irrelevant changes. Also turning back on a few tests that actually do work
now.

• platform/ios-wk2/TestExpectations:
• platform/ios/editing/selection/3690703-2-expected.txt:
• platform/ios/editing/selection/3690703-expected.txt:
• platform/ios/editing/selection/3690719-expected.txt:

2:12 PM Changeset in webkit [224705] by graouts@webkit.org

• 21 edits
  1 copy
  7 adds in trunk

[Web Animations] Implement getAnimations()
​https://bugs.webkit.org/show_bug.cgi?id=179535
<rdar://problem/34932475>

Reviewed by Simon Fraser.

Source/WebCore:

We now allow a list of animations for a document, with Document.getAnimations(), or for an
element, with Animatable.getAnimations(), to be returned. In order to support this, we maintain
a map on AnimationTimeline of all animations for a given element. This map is invalidated
when an animation's timeline changes and when an animation's effect changes. Note that the
Web Animations spec mandates that an AnimationEffect can only be a single animation's effect.

Additionally, we ensure that the Document-to-DocumentTimeline relationship is cleared when
is being prepared for teardown to avoid a ref-cycle.

Tests: http/wpt/wk-web-animations/interfaces/document-get-animations.html

http/wpt/wk-web-animations/interfaces/element-get-animations.html
http/wpt/wk-web-animations/timing-model/animation-effect-unique-relationship.html

• CMakeLists.txt: Add Animatable.idl.
• DerivedSources.make: Add Animatable.idl.
• WebCore.xcodeproj/project.pbxproj: Add Animatable.idl.
• animation/Animatable.idl: A new interface that Element implements and which currently only exposes

getAnimations(), the animate() method will be added later.

• animation/AnimationEffect.h: Add a new m_animation member to reference the animation using this

effect. This relationship is required so we guarantee that an effect is associated with a single
animation at most.
(WebCore::AnimationEffect::animation const):
(WebCore::AnimationEffect::setAnimation):

• animation/AnimationTimeline.cpp:

(WebCore::AnimationTimeline::animationWasAddedToElement): New method to notify the timeline that an
animation registered with this timeline has been associated with a new element through its effect.
(WebCore::AnimationTimeline::animationWasRemovedFromElement): New method to notify the timeline that an
animation registered with this timeline has been disassociated with an element through its effect.
(WebCore::AnimationTimeline::animationsForElement): New method returning all animations registered with
this timeline for a given element.

• animation/AnimationTimeline.h:

(WebCore::AnimationTimeline::animations const): All animations registered with this timeline.

• animation/DocumentTimeline.cpp:

(WebCore::DocumentTimeline::DocumentTimeline):
(WebCore::DocumentTimeline::detachFromDocument): Clear the reference between this timeline and its document.

• animation/DocumentTimeline.h:
• animation/WebAnimation.cpp:

(WebCore::WebAnimation::create):
(WebCore::WebAnimation::setEffect): As an animation's effect changes, we need to ensure that the old
effect no longer has an associated animation, and that the new effect is associated with this animation.
Additionally, we update the element-to-animations map on the animation's timeline.
(WebCore::WebAnimation::setTimeline): Update the element-to-animations map on the former and new timeline.

• dom/Document.cpp:

(WebCore::Document::prepareForDestruction): Clear the relationship between this document and its timeline.
(WebCore::Document::getAnimations): Obtain all animations associated with this document's timeline.

• dom/Document.h:
• dom/Document.idl:
• dom/Element.cpp:

(WebCore::Element::getAnimations): Obtain all animations associated with this element.

• dom/Element.h:
• dom/Element.idl:
• testing/Internals.cpp:

LayoutTests:

Update WPT expectations per new progressions and add three new tests that check the behavior of
Document.getAnimations(), Element.getAnimations() and the unique relationship between an Animation
and an AnimationEffect.

• http/wpt/web-animations/interfaces/Animatable/animate-expected.txt:
• http/wpt/web-animations/interfaces/Animatable/getAnimations-expected.txt:
• http/wpt/web-animations/interfaces/Document/getAnimations-expected.txt:
• http/wpt/wk-web-animations/interfaces/document-get-animations-expected.txt: Added.
• http/wpt/wk-web-animations/interfaces/document-get-animations.html: Added.
• http/wpt/wk-web-animations/interfaces/element-get-animations-expected.txt: Added.
• http/wpt/wk-web-animations/interfaces/element-get-animations.html: Added.
• http/wpt/wk-web-animations/timing-model/animation-effect-unique-relationship-expected.txt: Added.
• http/wpt/wk-web-animations/timing-model/animation-effect-unique-relationship.html: Added.

2:10 PM Changeset in webkit [224704] by commit-queue@webkit.org

• 4 edits in trunk/Source

Web Inspector: Make http status codes be "integer" instead of "number" in protocol
​https://bugs.webkit.org/show_bug.cgi?id=179543

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2017-11-10
Reviewed by Antoine Quint.

Source/JavaScriptCore:

• inspector/protocol/Network.json:

Use a better type for the status code.

Source/WebCore:

• inspector/agents/InspectorNetworkAgent.cpp:

(WebCore::InspectorNetworkAgent::buildObjectForResourceResponse):
No need for the temporary or type change.

2:03 PM Changeset in webkit [224703] by Ryan Haddad

• 3 edits
  2 deletes in trunk

Unreviewed, rolling out r224602 and r224697.
​https://bugs.webkit.org/show_bug.cgi?id=179545

The LayoutTest for this change is flaky. (Requested by
ryanhaddad on #webkit).

Reverted changesets:

"Add tests to ensure that <source> tags are only preloaded
when the type"
​https://bugs.webkit.org/show_bug.cgi?id=179231
​https://trac.webkit.org/changeset/224602

"Fix race conditions with setBackingScaleFactor, page refresh
and preloader"
​https://bugs.webkit.org/show_bug.cgi?id=179488
​https://trac.webkit.org/changeset/224697

Patch by Commit Queue <​commit-queue@webkit.org> on 2017-11-10

12:30 PM Changeset in webkit [224702] by Chris Dumez

• 19 edits
  3 adds in trunk

[Service Workers] Implement "Try Activate" / "Activate" algorithms
​https://bugs.webkit.org/show_bug.cgi?id=179436

Reviewed by Brady Eidson.

Source/WebCore:

Implement proper "Try Activate" / "Activate" algorithms as per:

• ​https://w3c.github.io/ServiceWorker/#try-activate-algorithm
• ​https://w3c.github.io/ServiceWorker/#activation-algorithm

Test: http/tests/workers/service/basic-activate-event.html

• workers/service/context/SWContextManager.cpp:

(WebCore::SWContextManager::fireActivateEvent):

• workers/service/context/SWContextManager.h:
• workers/service/context/ServiceWorkerThread.cpp:

(WebCore::ServiceWorkerThread::fireActivateEvent):

• workers/service/context/ServiceWorkerThread.h:
• workers/service/server/SWServer.cpp:

(WebCore::SWServer::Connection::didFinishActivation):
(WebCore::SWServer::didFinishActivation):
(WebCore::SWServer::fireActivateEvent):

• workers/service/server/SWServer.h:
• workers/service/server/SWServerJobQueue.cpp:

(WebCore::SWServerJobQueue::didFinishInstall):
(WebCore::SWServerJobQueue::tryActivate):
(WebCore::SWServerJobQueue::activate):
(WebCore::SWServerJobQueue::didFinishActivation):

• workers/service/server/SWServerJobQueue.h:

Source/WebKit:

Implement proper "Try Activate" / "Activate" algorithms as per:

• ​https://w3c.github.io/ServiceWorker/#try-activate-algorithm
• ​https://w3c.github.io/ServiceWorker/#activation-algorithm

• StorageProcess/ServiceWorker/WebSWServerConnection.cpp:

(WebKit::WebSWServerConnection::fireActivateEvent):

• StorageProcess/ServiceWorker/WebSWServerConnection.h:
• StorageProcess/StorageProcess.cpp:

(WebKit::StorageProcess::didFinishServiceWorkerActivation):

• StorageProcess/StorageProcess.h:
• StorageProcess/StorageProcess.messages.in:
• WebProcess/Storage/WebSWContextManagerConnection.cpp:

(WebKit::WebSWContextManagerConnection::fireActivateEvent):
(WebKit::WebSWContextManagerConnection::didFinishActivation):

• WebProcess/Storage/WebSWContextManagerConnection.h:
• WebProcess/Storage/WebSWContextManagerConnection.messages.in:

LayoutTests:

Add layout test coverage.

• http/tests/workers/service/basic-activate-event-expected.txt: Added.
• http/tests/workers/service/basic-activate-event.html: Added.
• http/tests/workers/service/resources/basic-activate-event-worker.js: Added.

12:11 PM Changeset in webkit [224701] by achristensen@apple.com

• 2 edits in trunk/Source/WebCore

Fix debug build after r224700
​https://bugs.webkit.org/show_bug.cgi?id=179460

• platform/text/TextEncodingRegistry.cpp:

(WebCore::addToTextEncodingNameMap):

11:26 AM Changeset in webkit [224700] by mjs@apple.com

• 5 edits
  2 adds in trunk

Remove TEC decoders that duplicate ICU decoders
​https://bugs.webkit.org/show_bug.cgi?id=179460

Reviewed by Darin Adler.

Source/WebCore:

Test: fast/encoding/duplicate-tec-encodings.html

• platform/text/TextEncodingRegistry.cpp:

(WebCore::checkExistingName): Deleted.
(WebCore::addToTextEncodingNameMap): Move the check from checkExistingName here,
and make it an ASSERT, since we should now be guaranteed no duplicate encodings.

• platform/text/mac/mac-encodings.txt: Remove encodings that duplicate ones we

implement with ICU.

• platform/text/TextCodecICU.cpp: Add some extra encoding aliases that only TEC

knew about.

LayoutTests:

• fast/encoding/duplicate-tec-encodings-expected.txt: Added.
• fast/encoding/duplicate-tec-encodings.html: Added.

11:23 AM Changeset in webkit [224699] by achristensen@apple.com

• 16 edits in trunk/Source/WebCore

Make CachedResource::redirectReceived asynchronous
​https://bugs.webkit.org/show_bug.cgi?id=179503

Reviewed by Antti Koivisto.

There were a few loops where we called redirectReceived many times in a row,
and these are replaced with a completion handler that recursively calls the next
redirectReceived or the code after the loop.

No change in behavior.

• loader/DocumentLoader.cpp:

(WebCore::DocumentLoader::redirectReceived):

• loader/DocumentLoader.h:

(WebCore::DocumentLoader::setLastCheckedRequest):

• loader/DocumentThreadableLoader.cpp:

(WebCore::DocumentThreadableLoader::redirectReceived):

• loader/DocumentThreadableLoader.h:
• loader/MediaResourceLoader.cpp:

(WebCore::MediaResource::redirectReceived):

• loader/MediaResourceLoader.h:
• loader/PolicyChecker.cpp:

(WebCore::PolicyChecker::checkNavigationPolicy):

• loader/SubresourceLoader.cpp:

(WebCore::SubresourceLoader::willSendRequestInternal):

• loader/cache/CachedRawResource.cpp:

(WebCore::iterate):
(WebCore::CachedRawResource::didAddClient):
(WebCore::CachedRawResource::redirectReceived):

• loader/cache/CachedRawResource.h:
• loader/cache/CachedRawResourceClient.h:

(WebCore::CachedRawResourceClient::redirectReceived):

• loader/cache/CachedResource.cpp:

(WebCore::CachedResource::redirectReceived):

• loader/cache/CachedResource.h:
• platform/graphics/PlatformMediaResourceLoader.h:

(WebCore::PlatformMediaResourceClient::redirectReceived):

• platform/network/cocoa/WebCoreNSURLSession.mm:

(WebCore::WebCoreNSURLSessionDataTaskClient::redirectReceived):

11:06 AM Changeset in webkit [224698] by Brent Fulgham

• 6 edits in trunk/Source

Ignore HSTS for partitioned, cross-origin subresource requests
​https://bugs.webkit.org/show_bug.cgi?id=178993
<rdar://problem/34962462>

Patch by John Wilander <​wilander@apple.com> on 2017-11-10
Reviewed by Brent Fulgham.

Source/WebCore:

No new tests. HSTS is not supported in layout tests.
Tested manually.

• platform/network/mac/WebCoreURLResponse.mm:

(WebCore::synthesizeRedirectResponseIfNecessary):

Source/WebCore/PAL:

• pal/spi/cf/CFNetworkSPI.h:

Added

• (BOOL)_schemeWasUpgradedDueToDynamicHSTS
• (BOOL)_preventHSTSStorage
• (BOOL)_ignoreHSTS
• (void)_setPreventHSTSStorage:(BOOL)preventHSTSStorage
• (void)_setIgnoreHSTS:(BOOL)ignoreHSTS

Source/WebKit:

• NetworkProcess/cocoa/NetworkSessionCocoa.mm:

(downgradeRequest):

Convenience function to downgrade a request if
CFNetwork as already upgraded it during
canonicalization. This allows the rest of
WebKit's processing to function, such as UIR
and mixed content blocking.

(updateIgnoreStrictTransportSecuritySettingIfNecessary):

Adds and removed the ignore request accordingly.

(-[WKNetworkSessionDelegate URLSession:task:willPerformHTTPRedirection:newRequest:completionHandler:]):

Now asks CFNetwork to ignore HSTS on resource loads we
partition cookies for.

(-[WKNetworkSessionDelegate URLSession:task:_schemeUpgraded:completionHandler:]):

Now asks CFNetwork to ignore HSTS on resource loads we
partition cookies for.

11:01 AM Changeset in webkit [224697] by commit-queue@webkit.org

• 3 edits in trunk/LayoutTests

Fix race conditions with setBackingScaleFactor, page refresh and preloader
​https://bugs.webkit.org/show_bug.cgi?id=179488

Patch by Colin Bendell <colin> on 2017-11-10
Reviewed by Darin Adler.

• http/tests/preload/picture-type-expected.txt: remove DPR test
• http/tests/preload/picture-type.html: updated srcset to account for

testRunners with DPR > 1

10:45 AM Changeset in webkit [224696] by achristensen@apple.com

• 4 edits in trunk

_WKThumbnailView initialization with WKWebView needs to call correct initWithFrame
​https://bugs.webkit.org/show_bug.cgi?id=179537
<rdar://problem/35275219>

Reviewed by Darin Adler.

Source/WebKit:

I introduced this in r223439 and made an ObjC mistake. This is what I get for adding SPI with no tests.
I fixed this by making the existing WKView/_WKThumbnailView API tests work with WKWebView.

• UIProcess/API/Cocoa/_WKThumbnailView.mm:

(-[_WKThumbnailView initWithFrame:fromWKWebView:]):

Tools:

• TestWebKitAPI/Tests/WebKit/WKThumbnailView.mm:

(-[WKThumbnailViewDelegate webView:didFinishNavigation:]):
(TestWebKitAPI::TEST):

10:30 AM Changeset in webkit [224695] by Jonathan Bedard

• 4 edits in trunk/Tools

webkitpy: Remove find_system_pid from port classes
​https://bugs.webkit.org/show_bug.cgi?id=179514
<rdar://problem/35456900>

Reviewed by David Kilzer.

Removing dead code.

• Scripts/webkitpy/port/base.py:

(Port.find_system_pid): Deleted.

• Scripts/webkitpy/port/server_process.py:

(ServerProcess._start):

• Scripts/webkitpy/port/win.py:

(WinPort.find_system_pid): Deleted.

10:06 AM Changeset in webkit [224694] by matthew_hanson@apple.com

• 10 edits
  1 add in tags/Safari-605.1.13.1

Cherry-pick r224687. rdar://problem/35445245

10:02 AM Changeset in webkit [224693] by matthew_hanson@apple.com

• 7 edits in tags/Safari-605.1.13.1/Source

Versioning.

9:59 AM Changeset in webkit [224692] by matthew_hanson@apple.com

• 1 copy in tags/Safari-605.1.13.1

New tag.

9:46 AM Changeset in webkit [224691] by aakash_jain@apple.com

• 4 edits in trunk/Tools

fix style failures in webkitpy: multiple statements on one line (semicolon)
​https://bugs.webkit.org/show_bug.cgi?id=179530

Reviewed by Alex Christensen.

• Scripts/webkitpy/common/net/buildbot/buildbot.py: Removed semicolon.
• Scripts/webkitpy/layout_tests/controllers/test_result_writer.py: Ditto.
• Scripts/webkitpy/tool/steps/runtests.py: Ditto.

9:44 AM Changeset in webkit [224690] by Ryan Haddad

• 2 edits in trunk/LayoutTests

Mark http/wpt/beacon/contentextensions tests as flaky.
​https://bugs.webkit.org/show_bug.cgi?id=179256

Unreviewed test gardening.

• platform/mac-wk2/TestExpectations:

9:39 AM Changeset in webkit [224689] by rmorisset@apple.com

• 6 edits in trunk/Source/JavaScriptCore

The memory consumption of DFG::BasicBlock can be easily reduced a bit
​https://bugs.webkit.org/show_bug.cgi?id=179528

Reviewed by Saam Barati.

A few changes here:

• Reordering some fields of DFG::BasicBlock to reduce padding
• Making the enum fields that are glorified booleans fit into a u8
• Make each Operands object have a single vector that holds all arguments followed by all locals, instead of two vectors. This change works because we never increase the number of arguments after allocating an Operands object. It lets us avoid one extra capacity field and one extra pointer field per Operands, and more importantly one allocation per Operands whenever both vectors would have overflowed their inlined buffer. Additionally, if a single vector would have overflowed its inline buffer, while the other would have had some free space, we have a chance to avoid an allocation.
• Finally, the three methods argumentForIndex, variableForIndex and indexForOperand were deleted since they were dead code.

• bytecode/Operands.h:

(JSC::Operands::Operands):
(JSC::Operands::numberOfArguments const):
(JSC::Operands::numberOfLocals const):
(JSC::Operands::argument):
(JSC::Operands::argument const):
(JSC::Operands::local):
(JSC::Operands::local const):
(JSC::Operands::ensureLocals):
(JSC::Operands::setLocal):
(JSC::Operands::getLocal):
(JSC::Operands::setArgumentFirstTime):
(JSC::Operands::setLocalFirstTime):
(JSC::Operands::operand):
(JSC::Operands::setOperand):
(JSC::Operands::size const):
(JSC::Operands::at const):
(JSC::Operands::at):
(JSC::Operands::isArgument const):
(JSC::Operands::isVariable const):
(JSC::Operands::virtualRegisterForIndex const):
(JSC::Operands::fill):
(JSC::Operands::operator== const):
(JSC::Operands::argumentForIndex const): Deleted.
(JSC::Operands::variableForIndex const): Deleted.
(JSC::Operands::indexForOperand const): Deleted.

• dfg/DFGBasicBlock.cpp:

(JSC::DFG::BasicBlock::BasicBlock):

• dfg/DFGBasicBlock.h:
• dfg/DFGBranchDirection.h:
• dfg/DFGStructureClobberState.h:

9:39 AM Changeset in webkit [224688] by aakash_jain@apple.com

• 8 edits in trunk/Tools

fix style failures in webkitpy: expected 2 blank lines found 1
​https://bugs.webkit.org/show_bug.cgi?id=179529

Reviewed by Alex Christensen.

• Scripts/webkitpy/benchmark_runner/run_benchmark.py: Added a blank line to follow style guidelines.
• Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py: Ditto.
• Scripts/webkitpy/common/system/platforminfo_mock.py: Ditto.
• Scripts/webkitpy/common/version.py: Ditto.
• Scripts/webkitpy/layout_tests/models/test_failures.py: Ditto.
• Scripts/webkitpy/port/mac_unittest.py: Ditto.
• Scripts/webkitpy/port/simulator_process.py: Ditto.

9:30 AM Changeset in webkit [224687] by achristensen@apple.com

• 10 edits
  1 add in trunk

REGRESSION(r224267): WebViews scheduled with custom run loop modes don't load
​https://bugs.webkit.org/show_bug.cgi?id=179515
Source/WebCore:

<rdar://problem/35445245>

Reviewed by Andy Estes.

Covered by a new API test which would have timed out without this change.

• platform/network/mac/WebCoreResourceHandleAsOperationQueueDelegate.mm:

(schedulePairHashSet):
Collect run loop modes from the NetworkingContext similarly to how we did before ​https://trac.webkit.org/changeset/224267/webkit#file40
(-[WebCoreResourceHandleAsOperationQueueDelegate connection:willSendRequest:redirectResponse:]):
(-[WebCoreResourceHandleAsOperationQueueDelegate connection:didReceiveAuthenticationChallenge:]):
(-[WebCoreResourceHandleAsOperationQueueDelegate connection:canAuthenticateAgainstProtectionSpace:]):
(-[WebCoreResourceHandleAsOperationQueueDelegate connection:didReceiveResponse:]):
(-[WebCoreResourceHandleAsOperationQueueDelegate connection:didReceiveData:lengthReceived:]):
(-[WebCoreResourceHandleAsOperationQueueDelegate connection:didSendBodyData:totalBytesWritten:totalBytesExpectedToWrite:]):
(-[WebCoreResourceHandleAsOperationQueueDelegate connectionDidFinishLoading:]):
(-[WebCoreResourceHandleAsOperationQueueDelegate connection:didFailWithError:]):
(-[WebCoreResourceHandleAsOperationQueueDelegate connection:willCacheResponse:]):

Source/WTF:

<rdar://problem/35445245>

Reviewed by Andy Estes.

• wtf/MainThread.cpp:

(WTF::callOnMainThread):

• wtf/MainThread.h:

(WTF::callOnMainThread):
(WTF::scheduleDispatchFunctionsOnMainThread):

• wtf/generic/MainThreadGeneric.cpp:

(WTF::scheduleDispatchFunctionsOnMainThread):

• wtf/mac/MainThreadMac.mm:

(WTF::scheduleDispatchFunctionsOnMainThread):

• wtf/win/MainThreadWin.cpp:

(WTF::scheduleDispatchFunctionsOnMainThread):
Add an optional parameter which is an array of run loop mode names to pass to performSelectorOnMainThread.

Tools:

Reviewed by Andy Estes.

• TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
• TestWebKitAPI/Tests/mac/WebViewScheduleInRunLoop.mm: Added.

(-[ScheduleInRunLoopDelegate webView:didFinishLoadForFrame:]):
(TestWebKitAPI::TEST):

9:23 AM Changeset in webkit [224686] by Chris Dumez

• 4 edits in trunk/Source/WebCore

Simplify SWServerRegistration::forEachConnection()
​https://bugs.webkit.org/show_bug.cgi?id=179523

Reviewed by Alex Christensen.

Simplify SWServerRegistration::forEachConnection() by dropping the hack
introduced in r224590 to work around the fact that we had a race
between Storage & WebProcess processes during registration. After
r224652, we do an IPC handshake between those 2 processes after
resolving the registration promise so we know for sure the
ServiceWorkerRegistration object has registered itself with the
Storage process before we keep going with the install steps.

No new tests, no expected Web-facing behavior change.

• workers/service/server/SWServerJobQueue.cpp:

(WebCore::SWServerJobQueue::scriptFetchFinished):
(WebCore::SWServerJobQueue::install):
(WebCore::SWServerJobQueue::didResolveRegistrationPromise):
(WebCore::SWServerJobQueue::didFinishInstall):
(WebCore::SWServerJobQueue::runRegisterJob):
(WebCore::SWServerJobQueue::runUnregisterJob):

• workers/service/server/SWServerRegistration.cpp:

(WebCore::SWServerRegistration::updateRegistrationState):
(WebCore::SWServerRegistration::updateWorkerState):
(WebCore::SWServerRegistration::fireUpdateFoundEvent):
(WebCore::SWServerRegistration::forEachConnection):

• workers/service/server/SWServerRegistration.h:

9:02 AM Changeset in webkit [224685] by Jonathan Bedard

• 2 edits in trunk/Tools

[webkitpy] Fix PlatformInfo._win_version since r224657
​https://bugs.webkit.org/show_bug.cgi?id=179520

Patch by Fujii Hironori <Fujii Hironori> on 2017-11-10
Reviewed by Aakash Jain.

There are two problems.

The return value of sys.getwindowsversion() doesn't match with
Version.init expects. Truncate the 4th and 5th of it.

_win_version_tuple_from_cmd was deleted in r224657. But, it is
still needed for Cygwin Python.

• Scripts/webkitpy/common/system/platforminfo.py:

(PlatformInfo._win_version): Return [0:3] of getwindowsversion().
Call _win_version_from_cmd for Cygwin Python.
(PlatformInfo._win_version_from_cmd): Restored.

8:41 AM Changeset in webkit [224684] by Ms2ger@igalia.com

• 9 edits
  2 deletes in trunk

LayoutTests/imported/w3c:
Allow XHR to override the User-Agent header.
​https://bugs.webkit.org/show_bug.cgi?id=179527

Reviewed by Chris Dumez.

• web-platform-tests/XMLHttpRequest/setrequestheader-header-allowed-expected.txt: update expectation.

Source/WebCore:
Allow XHR to override the User-Agent header.
​https://bugs.webkit.org/show_bug.cgi?id=179527

Reviewed by Chris Dumez.

Also rename FrameLoader::applyUserAgent to FrameLoader::applyUserAgentIfNeeded
for clarity.

Test: imported/w3c/web-platform-tests/XMLHttpRequest/setrequestheader-header-allowed.htm

• loader/FrameLoader.cpp:

(WebCore::FrameLoader::addExtraFieldsToRequest):
(WebCore::FrameLoader::applyUserAgentIfNeeded):

• loader/FrameLoader.h:
• loader/ResourceLoadNotifier.cpp:

(WebCore::ResourceLoadNotifier::willSendRequest):

• loader/appcache/ApplicationCacheGroup.cpp:

(WebCore::ApplicationCacheGroup::createResourceHandle):

• loader/cache/CachedResourceRequest.cpp:

(WebCore::CachedResourceRequest::updateReferrerOriginAndUserAgentHeaders):

LayoutTests:
Remove check-combining-headers.html.
​https://bugs.webkit.org/show_bug.cgi?id=179527

Reviewed by Chris Dumez.

This test is an old fork of
imported/w3c/web-platform-tests/XMLHttpRequest/setrequestheader-header-allowed.htm
which is no longer useful.

• http/tests/xmlhttprequest/check-combining-headers-expected.txt: Removed.
• http/tests/xmlhttprequest/check-combining-headers.html: Removed.

8:29 AM Changeset in webkit [224683] by guijemont@igalia.com

• 2 edits in trunk/Tools

build-jsc: build testmasm for all platforms using cmake
​https://bugs.webkit.org/show_bug.cgi?id=179512

Reviewed by Michael Catanzaro.

• Scripts/build-jsc:

8:25 AM Changeset in webkit [224682] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebKitLegacy/mac

[iOS] Use new class name from UIKit when checking UITextSuggestion type for WebKitLegacy
​https://bugs.webkit.org/show_bug.cgi?id=179397

Patch by Frederik Riedel <​frederik.riedel@frogg.io> on 2017-11-10
Reviewed by Wenson Hsieh.

• DOM/DOMHTMLInputElement.mm:

(-[DOMHTMLInputElement insertTextSuggestion:]):

7:43 AM Changeset in webkit [224681] by Ms2ger@igalia.com

• 6 edits in trunk

Source/WebCore:
[GTK] Use fallible allocation in ImageBuffer::ImageBuffer().
​https://bugs.webkit.org/show_bug.cgi?id=179051

Reviewed by Michael Catanzaro.

Test: imported/w3c/web-platform-tests/2dcontext/imagebitmap/createImageBitmap-invalid-args.html

• platform/graphics/cairo/ImageBufferCairo.cpp:

(WebCore::ImageBuffer::ImageBuffer):

Source/WTF:
Export tryFastZeroedMalloc.
​https://bugs.webkit.org/show_bug.cgi?id=179051

Reviewed by Michael Catanzaro.

The other functions were exported in bug 72855. There does not seem to be a
reason not to export this one.

• wtf/FastMalloc.h:

LayoutTests:
[GTK] Update test expectations for imported/w3c/web-platform-tests/2dcontext/imagebitmap/createImageBitmap-invalid-args.html.
​https://bugs.webkit.org/show_bug.cgi?id=179051

Reviewed by Michael Catanzaro.

The expectations are platform-specific because the test times out on mac.
The difference with the mac expectations is only in the last part of the
test, after the timeout.

This follows our policy of creating -expected files with failures for
imported wpt tests, to allow using them as regression tests.

• platform/gtk/imported/w3c/web-platform-tests/2dcontext/imagebitmap/createImageBitmap-invalid-args-expected.txt:

7:07 AM Changeset in webkit [224680] by Chris Dumez

• 2 edits in trunk/LayoutTests

Unreviewed, mark imported/w3c/web-platform-tests/service-workers/service-worker/unregister-then-register-new-script.https.html as flaky

I unskipped it yesterday but it turns out to be flaky.

• TestExpectations:

5:36 AM Changeset in webkit [224679] by Carlos Garcia Campos

• 1 copy in releases/WebKitGTK/webkit-2.18.3

WebKitGTK+ 2.18.3

5:34 AM Changeset in webkit [224678] by Carlos Garcia Campos

• 4 edits in releases/WebKitGTK/webkit-2.18

Unreviewed. Update OptionsGTK.cmake and NEWS for 2.18.3 release.

5:03 AM Changeset in webkit [224677] by Carlos Garcia Campos

• 22 edits
  2 moves
  2 deletes in trunk/Source/WebKit

[GTK][WPE] Switch to use API::NavigationClient
​https://bugs.webkit.org/show_bug.cgi?id=178720

Reviewed by Alex Christensen.

Replace WebKitLoaderClient and WebKitPolicyClient with WebKitNavigationClient that implements
API::NavigationClient.

• PlatformGTK.cmake:
• PlatformWPE.cmake:
• UIProcess/API/APINavigationAction.h: Add new constructor that receives a target frame name instead of a target

frame info.

• UIProcess/API/APINavigationClient.h:

(API::NavigationClient::didDisplayInsecureContent): Added.
(API::NavigationClient::didRunInsecureContent): Added.
(API::NavigationClient::decidePolicyForNavigationResponse): Change NavigationResponse parameter to be a
Ref<NavigationResponse>&& instead of a NavigationResponse&.

• UIProcess/API/C/WKPage.cpp:

(WKPageSetPageNavigationClient): Update NavigationResponse parameter.

• UIProcess/API/glib/WebKitBackForwardList.cpp:

(webkitBackForwardListChanged):

• UIProcess/API/glib/WebKitBackForwardListPrivate.h:
• UIProcess/API/glib/WebKitNavigationAction.cpp:

(webkitNavigationActionCreate): Wrap the given API::NavigationAction.
(webkit_navigation_action_get_navigation_type): Use the wrapped API::NavigationAction.
(webkit_navigation_action_get_mouse_button): Ditto.
(webkit_navigation_action_get_modifiers): Ditto.
(webkit_navigation_action_get_request): Ditto.
(webkit_navigation_action_is_user_gesture): Ditto.
(webkit_navigation_action_is_redirect): Ditto.

• UIProcess/API/glib/WebKitNavigationActionPrivate.h:

(_WebKitNavigationAction::_WebKitNavigationAction):

• UIProcess/API/glib/WebKitNavigationClient.cpp: Renamed from Source/WebKit/UIProcess/API/glib/WebKitLoaderClient.cpp.

(NavigationClient::NavigationClient):
(attachNavigationClientToView):

• UIProcess/API/glib/WebKitNavigationClient.h: Renamed from Source/WebKit/UIProcess/API/glib/WebKitLoaderClient.h.
• UIProcess/API/glib/WebKitNavigationPolicyDecision.cpp:

(webkit_navigation_policy_decision_get_frame_name): Add FIXME.
(webkitNavigationPolicyDecisionCreate): Get the target frame name from the API::NavigationAction.

• UIProcess/API/glib/WebKitNavigationPolicyDecisionPrivate.h:
• UIProcess/API/glib/WebKitPolicyClient.cpp: Removed.
• UIProcess/API/glib/WebKitPolicyClient.h: Removed.
• UIProcess/API/glib/WebKitPolicyDecision.cpp:

(webkitPolicyDecisionSetListener): Remove the madePolicyDecision boolean member, we can null-check the listener instead.
(webkit_policy_decision_use): Ensure listener is nullptr after being invoked to prevent the decision from being made
more than once.
(webkit_policy_decision_ignore): Ditto.
(webkit_policy_decision_download): Ditto.

• UIProcess/API/glib/WebKitPolicyDecisionPrivate.h:
• UIProcess/API/glib/WebKitResponsePolicyDecision.cpp:

(webkit_response_policy_decision_get_request): Use the wrapped API::NavigationResponse.
(webkit_response_policy_decision_get_response): Ditto.
(webkit_response_policy_decision_is_mime_type_supported): Ditto.
(webkitResponsePolicyDecisionCreate): Wrap the given API::NavigationResponse.

• UIProcess/API/glib/WebKitResponsePolicyDecisionPrivate.h:
• UIProcess/API/glib/WebKitUIClient.cpp:

(UIClient::createNewPage): Create the WebKitNavigationAction from a new API::NavigationAction.

• UIProcess/API/glib/WebKitWebView.cpp:

(webkitWebViewConstructed): Attach navigation client.

• UIProcess/Cocoa/NavigationState.h: Update API::NavigationResponse parameter of decidePolicyForNavigationResponse.
• UIProcess/Cocoa/NavigationState.mm:

(WebKit::NavigationState::NavigationClient::decidePolicyForNavigationResponse):

• UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::didDisplayInsecureContentForFrame): Notify the navigation client if it's used.
(WebKit::WebPageProxy::didRunInsecureContentForFrame): Ditto.
(WebKit::WebPageProxy::decidePolicyForNewWindowAction): Use the new API::NavigationAction constructor to pass
the target frame name, instead of a null target frame info.
(WebKit::WebPageProxy::decidePolicyForResponse): Move the API::NavigationResponse.

3:26 AM Changeset in webkit [224676] by Carlos Garcia Campos

• 3 edits in releases/WebKitGTK/webkit-2.18/Source/WebDriver

Merge r224668 - WebDriver: WebDriverService::matchCapabilities should follow the spec
​https://bugs.webkit.org/show_bug.cgi?id=179371

Reviewed by Brian Burg.

The returned object should contain all the entries mentioned in the spec, not only the ones already present in
the passed in capabilities object.

7.2 Processing Capabilities
​https://w3c.github.io/webdriver/webdriver-spec.html#dfn-matching-capabilities

• WebDriverService.cpp:

(WebDriver::WebDriverService::matchCapabilities const):
(WebDriver::WebDriverService::processCapabilities const):

• WebDriverService.h:

3:26 AM Changeset in webkit [224675] by Carlos Garcia Campos

• 2 edits in releases/WebKitGTK/webkit-2.18/Source/WebDriver

Merge r224667 - WebDriver: capabilities with null value shouldn't be added to the validated capabilities object
​https://bugs.webkit.org/show_bug.cgi?id=179369

Reviewed by Brian Burg.

"4. If deserialized is not null, set a property on result with name name and value deserialized."

7.2 Processing Capabilities
​https://w3c.github.io/webdriver/webdriver-spec.html#dfn-validate-capabilities

Fixes: imported/w3c/webdriver/tests/sessions/new_session/create_firstMatch.py::test_valid[platformName-None]

• WebDriverService.cpp:

(WebDriver::WebDriverService::validatedCapabilities const):

3:15 AM Changeset in webkit [224674] by Carlos Garcia Campos

• 2982 edits
  315 adds in releases/WebKitGTK/webkit-2.18/LayoutTests

Unreviewed GTK+ gardening. Rebaseline tests after r224572 and r224573. Part 3.

2:50 AM Changeset in webkit [224673] by Carlos Garcia Campos

• 3572 edits
  1 copy
  5 adds in releases/WebKitGTK/webkit-2.18/LayoutTests

Unreviewed GTK+ gardening. Rebaseline tests after r224572 and r224573. Part 2.

2:19 AM Changeset in webkit [224672] by Carlos Garcia Campos

• 4263 edits in releases/WebKitGTK/webkit-2.18

Unreviewed GTK+ gardening. Rebaseline tests after r224572 and r224573. Part 1.

12:51 AM Changeset in webkit [224671] by magomez@igalia.com

• 2 edits in trunk/Source/WebCore

[GTK][WPE] CoordinatedGraphicsLayer::setNeedsDisplayInRect() converts FloatRect to IntRect erroneously
​https://bugs.webkit.org/show_bug.cgi?id=179476

Reviewed by Žan Doberšek.

Convert the passed FloatRect into an IntRect using enclosingIntRect(), so we are guaranteed that
the rectangle to paint fits into the buffer that the backingStore will allocate.

No behaviour change.

• platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp:

(WebCore::CoordinatedGraphicsLayer::setNeedsDisplayInRect):

12:30 AM Changeset in webkit [224670] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebCore

WebInjectedScriptHost.cpp: warning: variable ‘scope’ set but not used
​https://bugs.webkit.org/show_bug.cgi?id=179524

Patch by Fujii Hironori <Fujii Hironori> on 2017-11-10
Reviewed by Joseph Pecoraro.

r224606 has introduced a new compilation warning if not
ENABLE(PAYMENT_REQUEST).

No new tests (No behavior change).

• inspector/WebInjectedScriptHost.cpp:

(WebCore::WebInjectedScriptHost::getInternalProperties): Do not
define the variable 'scope' if not ENABLE(PAYMENT_REQUEST). Marked
a variable 'vm' with UNUSED_PARAM.

12:18 AM Changeset in webkit [224669] by zandobersek@gmail.com

• 3 edits
  2 adds in trunk/Source/WebCore

[Cairo] Start grouping Cairo GraphicsContext operations behind a separate interface
​https://bugs.webkit.org/show_bug.cgi?id=179467

Reviewed by Carlos Garcia Campos.

Start moving the Cairo operations in GraphicsContext into a separate
translation unit, CairoOperations.cpp. This will ease leveraging these
operations from a pre-recorded list of GraphicsContext commands, or
from a Cairo-specific GraphicsContextImpl, without undermining the
current GraphicsContext implementation that we'll want to maintain
in a working state until necessary.

We start with the clipping operations. Each operation is encapsulated
in a static function inside the WebCore::Cairo namespace that expects
PlatformContextCairo reference as the first argument, which makes sense
since we have to utilize the cairo_t state object that's kept there.
Other parameters are passed as well, as required for some specific
operation.

In the Cairo implementation of GraphicsContext, the affected methods
are changed to assert presence of the platform context (i.e. this is a
GraphicsContext that operates on a valid cairo_t object, and is not
using an m_impl object or is in non-painting mode) before the
PlatformContextCairo object is dereferenced and passed along with
other arguments to the Cairo::clip*() function.

No new tests -- no change in behavior.

• platform/SourcesCairo.txt:
• platform/graphics/cairo/CairoOperations.cpp: Added.

(WebCore::Cairo::clip):
(WebCore::Cairo::clipOut):
(WebCore::Cairo::clipPath):
(WebCore::Cairo::clipToImageBuffer):

• platform/graphics/cairo/CairoOperations.h: Added.
• platform/graphics/cairo/GraphicsContextCairo.cpp:

(WebCore::GraphicsContext::clip):
(WebCore::GraphicsContext::clipPath):
(WebCore::GraphicsContext::clipToImageBuffer):
(WebCore::GraphicsContext::clipOut):

Nov 9, 2017:

11:27 PM Changeset in webkit [224668] by Carlos Garcia Campos

• 3 edits in trunk/Source/WebDriver

WebDriver: WebDriverService::matchCapabilities should follow the spec
​https://bugs.webkit.org/show_bug.cgi?id=179371

Reviewed by Brian Burg.

The returned object should contain all the entries mentioned in the spec, not only the ones already present in
the passed in capabilities object.

7.2 Processing Capabilities
​https://w3c.github.io/webdriver/webdriver-spec.html#dfn-matching-capabilities

• WebDriverService.cpp:

(WebDriver::WebDriverService::matchCapabilities const):
(WebDriver::WebDriverService::processCapabilities const):

• WebDriverService.h:

11:25 PM Changeset in webkit [224667] by Carlos Garcia Campos

• 2 edits in trunk/Source/WebDriver

WebDriver: capabilities with null value shouldn't be added to the validated capabilities object
​https://bugs.webkit.org/show_bug.cgi?id=179369

Reviewed by Brian Burg.

"4. If deserialized is not null, set a property on result with name name and value deserialized."

7.2 Processing Capabilities
​https://w3c.github.io/webdriver/webdriver-spec.html#dfn-validate-capabilities

Fixes: imported/w3c/webdriver/tests/sessions/new_session/create_firstMatch.py::test_valid[platformName-None]

• WebDriverService.cpp:

(WebDriver::WebDriverService::validatedCapabilities const):

11:21 PM Changeset in webkit [224666] by mitz@apple.com

• 2 edits in trunk/Source/WebCore/PAL

[Xcode] An extra copy of FileSizeFormatter.h is installed in /usr/local/include
​https://bugs.webkit.org/show_bug.cgi?id=179525

Reviewed by Wenson Hsieh.

• PAL.xcodeproj/project.pbxproj: Demoted FileSizeFormatter.h to a project header in the PAL target. The Copy PAL Headers target takes care of installing this header under /usr/local/include/pal.

11:03 PM Changeset in webkit [224665] by Chris Dumez

• 8 edits in trunk/Source

Unreviewed, rolling out r224661.

Broke build on several internal Mac/iOS bots

Reverted changeset:

"Ignore HSTS for partitioned, cross-origin subresource
requests"
​https://bugs.webkit.org/show_bug.cgi?id=178993
​https://trac.webkit.org/changeset/224661

10:26 PM Changeset in webkit [224664] by Chris Dumez

• 24 edits
  2 adds in trunk

ServiceWorkerRegistration objects may get recycled for different SWServerRegistration objects
​https://bugs.webkit.org/show_bug.cgi?id=179517

Reviewed by Brady Eidson.

LayoutTests/imported/w3c:

• web-platform-tests/service-workers/service-worker/ready.https-expected.txt:

The test fails differently. The failure is expected here since we do not implement the
"Try Clear Registration" algorithm. As a result, we do not support resurrecting a
registration with the 'uninstalling' flag set. We always clear uninstalling registrations
on server side for now.

• web-platform-tests/service-workers/service-worker/unregister-then-register.https-expected.txt:

Same reason as above. The second checks calls unregister() for a registration that is "in use"
as expects it to get resurrected when calling register() again. We currently always clear
registrations that are unregistered on server side.

Source/WebCore:

ServiceWorkerRegistration objects could get recycled for different SWServerRegistration objects, leading to
flakiness in the tests. We uses ServiceWorkerRegistrationKey as key in the m_registration map on WebProcess
side. The lifetime of the ServiceWorkerRegistration objects is tied to the lifetime of their JS wrapper.
When a test does a registration for a given scope, then unregisters, then registers again for the same scope,
we would end up creating a new SWServerRegistration object on server side, but possibly reuse the same
ServiceWorkerRegistration object on WebProcess side, if its wrapper has not yet been garbage collected.
This is because the registrations have the same ServiceWorkerRegistrationKey in this case.

To address the issue, we now use the ServiceWorkerRegistrationIdentifier as key in the m_registration
hash map. A SWServerRegistration has a unique ServiceWorkerRegistrationIdentifier on server side.
All its clients ServiceWorkerRegistration also use the same ServiceWorkerRegistrationIdentifier.

Test: http/tests/workers/service/basic-unregister-then-register-again-no-reuse.html

• workers/service/ServiceWorkerContainer.cpp:

(WebCore::ServiceWorkerContainer::getRegistration):
(WebCore::ServiceWorkerContainer::scheduleTaskToUpdateRegistrationState):
(WebCore::ServiceWorkerContainer::scheduleTaskToFireUpdateFoundEvent):
(WebCore::ServiceWorkerContainer::jobResolvedWithRegistration):
(WebCore::ServiceWorkerContainer::addRegistration):
(WebCore::ServiceWorkerContainer::removeRegistration):

• workers/service/ServiceWorkerContainer.h:
• workers/service/ServiceWorkerRegistration.h:
• workers/service/ServiceWorkerRegistrationData.h:

(WebCore::ServiceWorkerRegistrationData::decode):

• workers/service/server/SWClientConnection.cpp:

(WebCore::SWClientConnection::updateRegistrationState):
(WebCore::SWClientConnection::fireUpdateFoundEvent):

• workers/service/server/SWClientConnection.h:
• workers/service/server/SWServer.cpp:

(WebCore::SWServer::Connection::addServiceWorkerRegistrationInServer):
(WebCore::SWServer::Connection::removeServiceWorkerRegistrationInServer):
(WebCore::SWServer::resolveRegistrationJob):
(WebCore::SWServer::addClientServiceWorkerRegistration):
(WebCore::SWServer::removeClientServiceWorkerRegistration):

• workers/service/server/SWServer.h:
• workers/service/server/SWServerRegistration.cpp:

(WebCore::generateServiceWorkerRegistrationIdentifier):
(WebCore::SWServerRegistration::SWServerRegistration):
(WebCore::SWServerRegistration::updateRegistrationState):
(WebCore::SWServerRegistration::fireUpdateFoundEvent):
(WebCore::SWServerRegistration::forEachConnection):
(WebCore::SWServerRegistration::addClientServiceWorkerRegistration):
(WebCore::SWServerRegistration::removeClientServiceWorkerRegistration):

• workers/service/server/SWServerRegistration.h:

(WebCore::SWServerRegistration::identifier const):

Source/WebKit:

• Scripts/webkit/messages.py:

(forward_declarations_and_headers):

• StorageProcess/ServiceWorker/WebSWServerConnection.cpp:

(WebKit::WebSWServerConnection::updateRegistrationStateInClient):
(WebKit::WebSWServerConnection::fireUpdateFoundEvent):

• StorageProcess/ServiceWorker/WebSWServerConnection.h:
• StorageProcess/ServiceWorker/WebSWServerConnection.messages.in:
• WebProcess/Storage/WebSWClientConnection.cpp:

(WebKit::WebSWClientConnection::addServiceWorkerRegistrationInServer):
(WebKit::WebSWClientConnection::removeServiceWorkerRegistrationInServer):

• WebProcess/Storage/WebSWClientConnection.h:
• WebProcess/Storage/WebSWClientConnection.messages.in:

LayoutTests:

Add layout test coverage.

• http/tests/workers/service/basic-unregister-then-register-again-no-reuse-expected.txt: Added.
• http/tests/workers/service/basic-unregister-then-register-again-no-reuse.html: Added.

10:06 PM Changeset in webkit [224663] by Chris Dumez

• 14 edits in trunk/LayoutTests

LayoutTests/imported/w3c:
Unreviewed, ebaseline flaky / skipped service worker tests
​https://bugs.webkit.org/show_bug.cgi?id=179521

Rebaseline skipped / flaky service worker tests to get better estimates of our pass rate.

• web-platform-tests/service-workers/service-worker/extendable-event-waituntil.https-expected.txt:
• web-platform-tests/service-workers/service-worker/fetch-canvas-tainting-cache.https-expected.txt:
• web-platform-tests/service-workers/service-worker/fetch-canvas-tainting.https-expected.txt:
• web-platform-tests/service-workers/service-worker/fetch-cors-xhr.https-expected.txt:
• web-platform-tests/service-workers/service-worker/fetch-request-redirect.https-expected.txt:
• web-platform-tests/service-workers/service-worker/foreign-fetch-basics.https-expected.txt:
• web-platform-tests/service-workers/service-worker/performance-timeline.https-expected.txt:
• web-platform-tests/service-workers/service-worker/register-foreign-fetch-errors.https-expected.txt:
• web-platform-tests/service-workers/service-worker/registration-updateviacache.https-expected.txt:
• web-platform-tests/service-workers/service-worker/unregister-controller.https-expected.txt:
• web-platform-tests/service-workers/service-worker/unregister-then-register-new-script.https-expected.txt:
• web-platform-tests/service-workers/service-worker/update-bytecheck.https-expected.txt:

LayoutTests:
Unreviewed, rebaseline flaky / skipped service worker tests
​https://bugs.webkit.org/show_bug.cgi?id=179521

Unskip a test that is no longer timing out.

• TestExpectations:

9:28 PM Changeset in webkit [224662] by Yusuke Suzuki

• 4 edits
  6 adds in trunk

[JSC] Retry module fetching if previous request fails
​https://bugs.webkit.org/show_bug.cgi?id=178168

Reviewed by Saam Barati.

Source/JavaScriptCore:

According to the latest spec, the failed fetching operation can be retried if it is requested again.
For example,

<script type="module" integrity="shaXXX-bad" src="./A.js"></script>
<script type="module" integrity="shaXXX-correct" src="./A.js"></script>

When performing the first module fetching, integrity check fails, and the load of this module becomes failed.
But when loading the second module, we do not use the cached failure result in the first module loading.
We retry fetching for "./A.js". In this case, we have a correct integrity and module fetching succeeds.
This is specified in whatwg/HTML[1]. If the fetching fails, we do not cache it.

Interestingly, fetching result and instantiation result will be cached if they succeeds. This is because we would
like to cache modules based on their URLs. As a result,

<script type="module" integrity="shaXXX-correct" src="./A.js"></script>
<script type="module" integrity="shaXXX-bad" src="./A.js"></script>

In the above case, the first loading succeeds. And the second loading also succeeds since the succeeded fetching and
instantiation are cached in the module pipeline.

This patch implements the above semantics. Previously, our module pipeline always caches the result. If the fetching
failed, all the subsequent fetching for the same URL fails even if we have different integrity values. We retry fetching
if the previous one fails. As an overview of our change,

1. Fetching result should be cached only if it succeeds. Two or more on-the-fly fetching requests to the same URLs should be unified. But if currently executing one fails, other attempts should retry fetching.

2. Instantiation should be cached if fetching succeeds.

3. Satisfying should be cached if it succeeds.

[1]: ​https://html.spec.whatwg.org/#fetch-a-single-module-script

• builtins/ModuleLoaderPrototype.js:

(requestFetch):
(requestInstantiate):
(requestSatisfy):
(link):
(loadModule):

• runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::init):

LayoutTests:

• js/dom/modules/module-fetch-failure-not-cached-expected.txt: Added.
• js/dom/modules/module-fetch-failure-not-cached.html: Added.
• js/dom/modules/module-integrity-bad-value-success-with-cache-expected.txt: Added.
• js/dom/modules/module-integrity-bad-value-success-with-cache.html: Added.
• js/dom/modules/script-tests/module-fetch-failure-not-cached.js: Added.
• js/dom/modules/script-tests/module-integrity-bad-value-success-with-cache.js: Added.

7:21 PM Changeset in webkit [224661] by Brent Fulgham

• 8 edits in trunk/Source

Ignore HSTS for partitioned, cross-origin subresource requests
​https://bugs.webkit.org/show_bug.cgi?id=178993
<rdar://problem/34962462>

Patch by John Wilander <​wilander@apple.com> on 2017-11-09
Reviewed by Brent Fulgham.

Source/WebCore:

No new tests. HSTS is not supported in layout tests.
Tested manually.

• platform/network/mac/WebCoreURLResponse.mm:

(WebCore::synthesizeRedirectResponseIfNecessary):

Source/WebCore/PAL:

• pal/spi/cf/CFNetworkSPI.h:

Added

• (BOOL)_schemeWasUpgradedDueToDynamicHSTS
• (BOOL)_preventHSTSStorage
• (BOOL)_ignoreHSTS
• (void)_setPreventHSTSStorage:(BOOL)preventHSTSStorage
• (void)_setIgnoreHSTS:(BOOL)ignoreHSTS

Source/WebKit:

• NetworkProcess/cocoa/NetworkSessionCocoa.mm:

(downgradeRequest):

Convenience function to downgrade a request if
CFNetwork as already upgraded it during
canonicalization. This allows the rest of
WebKit's processing to function, such as UIR
and mixed content blocking.

(updateIgnoreStrictTransportSecuritySettingIfNecessary):

Adds and removed the ignore request accordingly.

(-[WKNetworkSessionDelegate URLSession:task:willPerformHTTPRedirection:newRequest:completionHandler:]):

Now asks CFNetwork to ignore HSTS on resource loads we
partition cookies for.

(-[WKNetworkSessionDelegate URLSession:task:_schemeUpgraded:completionHandler:]):

Now asks CFNetwork to ignore HSTS on resource loads we
partition cookies for.

Source/WTF:

• wtf/Platform.h:

Added HAVE_CFNETWORK_IGNORE_HSTS.

5:56 PM Changeset in webkit [224660] by Ryan Haddad

• 2 edits in trunk/LayoutTests

Mark multiple service worker tests as flaky.

Unreviewed test gardening.

• TestExpectations: Add flaky tests and alphabetize existing entries.

5:50 PM Changeset in webkit [224659] by Ryan Haddad

• 20 edits
  8 copies
  13 adds in trunk/LayoutTests

[iOS] Rebaseline and re-enable editing/deleting tests
​https://bugs.webkit.org/show_bug.cgi?id=179119

Unreviewed test gardening.

• platform/ios-wk2/TestExpectations:
• platform/ios/TestExpectations:
• platform/ios/editing/deleting/collapse-whitespace-3587601-fix-expected.txt: Added.
• platform/ios/editing/deleting/delete-3608445-fix-expected.txt: Added.
• platform/ios/editing/deleting/delete-3800834-fix-expected.txt: Added.
• platform/ios/editing/deleting/delete-after-span-ws-001-expected.txt: Added.
• platform/ios/editing/deleting/delete-after-span-ws-002-expected.txt: Added.
• platform/ios/editing/deleting/delete-after-span-ws-003-expected.txt: Added.
• platform/ios/editing/deleting/delete-at-paragraph-boundaries-004-expected.txt:
• platform/ios/editing/deleting/delete-at-paragraph-boundaries-010-expected.txt:
• platform/ios/editing/deleting/delete-at-paragraph-boundaries-011-expected.txt:
• platform/ios/editing/deleting/delete-at-start-or-end-expected.txt: Added.
• platform/ios/editing/deleting/delete-block-contents-001-expected.txt: Added.
• platform/ios/editing/deleting/delete-block-contents-002-expected.txt: Copied from LayoutTests/platform/ios/editing/deleting/delete-br-010-expected.txt.
• platform/ios/editing/deleting/delete-block-merge-contents-005-expected.txt:
• platform/ios/editing/deleting/delete-block-merge-contents-006-expected.txt:
• platform/ios/editing/deleting/delete-block-merge-contents-007-expected.txt:
• platform/ios/editing/deleting/delete-block-merge-contents-008-expected.txt:
• platform/ios/editing/deleting/delete-block-merge-contents-023-expected.txt:
• platform/ios/editing/deleting/delete-block-merge-contents-024-expected.txt:
• platform/ios/editing/deleting/delete-br-002-expected.txt: Copied from LayoutTests/platform/ios/editing/deleting/delete-to-select-table-expected.txt.
• platform/ios/editing/deleting/delete-br-004-expected.txt: Copied from LayoutTests/platform/ios/editing/deleting/delete-to-select-table-expected.txt.
• platform/ios/editing/deleting/delete-br-005-expected.txt: Copied from LayoutTests/platform/ios/editing/deleting/delete-to-select-table-expected.txt.
• platform/ios/editing/deleting/delete-br-006-expected.txt: Copied from LayoutTests/platform/ios/editing/deleting/delete-to-select-table-expected.txt.
• platform/ios/editing/deleting/delete-br-008-expected.txt:
• platform/ios/editing/deleting/delete-br-009-expected.txt: Copied from LayoutTests/platform/ios/editing/deleting/delete-br-008-expected.txt.
• platform/ios/editing/deleting/delete-br-010-expected.txt:
• platform/ios/editing/deleting/delete-image-004-expected.txt: Added.
• platform/ios/editing/deleting/delete-leading-ws-001-expected.txt: Copied from LayoutTests/platform/ios/editing/deleting/delete-br-010-expected.txt.
• platform/ios/editing/deleting/delete-line-011-expected.txt: Copied from LayoutTests/platform/ios/editing/deleting/delete-to-select-table-expected.txt.
• platform/ios/editing/deleting/delete-line-015-expected.txt:
• platform/ios/editing/deleting/delete-line-016-expected.txt:
• platform/ios/editing/deleting/delete-line-017-expected.txt:
• platform/ios/editing/deleting/delete-line-end-ws-001-expected.txt: Added.
• platform/ios/editing/deleting/delete-line-end-ws-002-expected.txt: Added.
• platform/ios/editing/deleting/delete-tab-001-expected.txt: Added.
• platform/ios/editing/deleting/delete-tab-004-expected.txt: Added.
• platform/ios/editing/deleting/delete-to-select-table-expected.txt:
• platform/ios/editing/deleting/merge-no-br-expected.txt:
• platform/ios/editing/deleting/table-cells-expected.txt:

5:48 PM Changeset in webkit [224658] by Jonathan Bedard

• 2 edits in trunk/Tools

webkitpy: Unify version parsing code
​https://bugs.webkit.org/show_bug.cgi?id=179426
<rdar://problem/35415191>

Unreviewed fix to r224657.

• Scripts/webkitpy/common/version.py:

(Version.init): Check if an object is iterable.

4:58 PM Changeset in webkit [224657] by Jonathan Bedard

• 8 edits
  2 adds in trunk/Tools

webkitpy: Unify version parsing code
​https://bugs.webkit.org/show_bug.cgi?id=179426
<rdar://problem/35415191>

Reviewed by David Kilzer.

webkitpy needs to parse version strings or version lists frequently. Rather than
duplicate this code each time it's needed, unify it in a Version class.

• Scripts/webkitpy/common/system/platforminfo.py:

(PlatformInfo.init): Convert mac version string to version object and
use _win_version instead of _win_version_tuple.
(PlatformInfo.xcode_sdk_version): Convert SDK version string to Version object
before returning it.
(PlatformInfo.xcode_version): Return Version object instead of version string.
(PlatformInfo._determine_mac_version): Accept Version object instead of string,
eliminate parsing.
(PlatformInfo._determine_win_version): Accept Version object instead of tuple.
(PlatformInfo._win_version): Return Version object instead of tuple, have Version
object own version string parsing.
(PlatformInfo._win_version_tuple): Renamed to _win_version().
(PlatformInfo._win_version_tuple_from_cmd): Deleted.

• Scripts/webkitpy/common/system/platforminfo_mock.py:

(MockPlatformInfo.xcode_sdk_version): Return Version object instead of string.
(MockPlatformInfo.xcode_version): Dittio.

• Scripts/webkitpy/common/version.py: Added.

(Version): Version object.
(Version.init): Initialize the Version object with a string, integer,
tuple of integers, list of integers or another Version object.
(Version.len): Return 5 so that the Version object can be treated as
a list or tuple.
(Version.getitem): Get item in Version object by index or string.
(Version.setitem): Set item in Version object by index or string.
(Version.str): Convert version to printable string, omitting trailing 0's.
(Version.cmp): Compare two version strings, major taking precedence over
minor, minor taking precedence over build.

• Scripts/webkitpy/common/version_unittest.py: Added.

(VersionTestCase): Test behavior of Version object.

• Scripts/webkitpy/port/ios.py:

(IOSPort.default_baseline_search_path): ios_version now returns a Version object.
(IOSPort._is_valid_ios_version): Deleted.
(IOSPort.get_option): Deleted.

• Scripts/webkitpy/port/ios_device.py:

(IOSDevicePort.determine_full_port_name): Use Version object instead of owning parsing.
(IOSDevicePort.ios_version): Return Version object instead of string.

• Scripts/webkitpy/port/ios_simulator.py:

(IOSSimulatorPort.simulator_runtime): Use from_version instead of from_version_string.
(IOSSimulatorPort.ios_version): Return Version object instead of string.
(IOSSimulatorPort.use_multiple_simulator_apps): Use Version object instead of string.

• Scripts/webkitpy/xcode/simulator.py:

(Runtime.from_version): Accept Version object instead of string.
(Runtime.from_version_string): Replaced by from_version.
(Runtime.repr): When printing, a runtime's version will be a Version object instead
of a tuple.
(Simulator._parse_runtimes): Use Version object instead of tuple.
(Simulator._parse_devices): Ditto.

• Scripts/webkitpy/xcode/simulator_unittest.py: Use Version object instead of tuples.

4:48 PM Changeset in webkit [224656] by commit-queue@webkit.org

• 2 edits in trunk/Tools

[WinCairo] Cannot find ImageDiff executable
​https://bugs.webkit.org/show_bug.cgi?id=179508

Patch by Basuke Suzuki <Basuke Suzuki> on 2017-11-09
Reviewed by Per Arne Vollan.

• Scripts/webkitpy/port/win.py:

(WinPort.is_cygwin):
(WinPort._path_to_image_diff):
(WinPort.find_system_pid):

4:41 PM Changeset in webkit [224655] by Ryan Haddad

• 2 edits in trunk/LayoutTests

Mark media/modern-media-controls/media-controller/media-controller-auto-hide-mouse-enter-and-mouse-leave.html as a flaky timeout.
​https://bugs.webkit.org/show_bug.cgi?id=169876

Unreviewed test gardening.

• platform/mac/TestExpectations:

4:31 PM Changeset in webkit [224654] by Ryan Haddad

• 2 edits in trunk/LayoutTests

Skip slow encoding WPT LayoutTests.

Unreviewed test gardening.

• TestExpectations:

4:31 PM Changeset in webkit [224653] by Alan Bujtas

• 5 edits in trunk/Source/WebCore

[LayoutState cleanup] Remove explicit pop from LayoutState
​https://bugs.webkit.org/show_bug.cgi?id=179509
<rdar://problem/35454323>

Reviewed by Antti Koivisto.

Both relayoutForPagination()/relayoutToAvoidWidows() call layout recursively which requires
manual layout state pop. This patch addresses this issue by constructing a new LayoutState object
for the positioned descendants.

Covered by existing tests.

• rendering/LayoutState.cpp:

(WebCore::LayoutStateMaintainer::~LayoutStateMaintainer):
(WebCore::LayoutStateMaintainer::pop): Deleted.

• rendering/LayoutState.h:
• rendering/RenderBlockFlow.cpp:

(WebCore::RenderBlockFlow::layoutBlock):
(WebCore::RenderBlockFlow::relayoutToAvoidWidows):
(WebCore::RenderBlockFlow::relayoutForPagination):

• rendering/RenderBlockFlow.h:

3:45 PM Changeset in webkit [224652] by Chris Dumez

• 32 edits in trunk

Implement real post 'install' event steps of the Install algorithm (steps 14+)
​https://bugs.webkit.org/show_bug.cgi?id=179401

Reviewed by Brady Eidson.

LayoutTests/imported/w3c:

Rebaseline a test that is now failing later (progression).

• web-platform-tests/service-workers/service-worker/navigate-window.https-expected.txt:

Source/WebCore:

Implement step 14+ of Install algorithm, as per:

• ​https://w3c.github.io/ServiceWorker/#installation-algorithm

• dom/Microtasks.h:
• workers/service/ServiceWorker.cpp:

(WebCore::ServiceWorker::ServiceWorker):
(WebCore::ServiceWorker::scheduleTaskToUpdateState):

• workers/service/ServiceWorker.h:
• workers/service/ServiceWorkerContainer.cpp:

(WebCore::ServiceWorkerContainer::scheduleTaskToUpdateRegistrationState):
(WebCore::ServiceWorkerContainer::jobFailedWithException):
(WebCore::ServiceWorkerContainer::scheduleTaskToFireUpdateFoundEvent):
(WebCore::ServiceWorkerContainer::jobResolvedWithRegistration):
(WebCore::ServiceWorkerContainer::jobResolvedWithUnregistrationResult):

• workers/service/ServiceWorkerContainer.h:
• workers/service/ServiceWorkerJob.cpp:

(WebCore::ServiceWorkerJob::resolvedWithRegistration):

• workers/service/ServiceWorkerJob.h:
• workers/service/ServiceWorkerJobClient.h:
• workers/service/ServiceWorkerRegistration.cpp:

(WebCore::ServiceWorkerRegistration::ServiceWorkerRegistration):

• workers/service/ServiceWorkerTypes.h:
• workers/service/server/SWClientConnection.cpp:

(WebCore::SWClientConnection::registrationJobResolvedInServer):
(WebCore::SWClientConnection::forEachContainer):
(WebCore::SWClientConnection::updateRegistrationState):
(WebCore::SWClientConnection::updateWorkerState):
(WebCore::SWClientConnection::fireUpdateFoundEvent):

• workers/service/server/SWClientConnection.h:
• workers/service/server/SWServer.cpp:

(WebCore::SWServer::Connection::didResolveRegistrationPromise):
(WebCore::SWServer::resolveRegistrationJob):
(WebCore::SWServer::didResolveRegistrationPromise):

• workers/service/server/SWServer.h:
• workers/service/server/SWServerJobQueue.cpp:

(WebCore::SWServerJobQueue::install):
(WebCore::SWServerJobQueue::didResolveRegistrationPromise):
(WebCore::SWServerJobQueue::didFinishInstall):
(WebCore::SWServerJobQueue::runRegisterJob):

• workers/service/server/SWServerJobQueue.h:
• workers/service/server/SWServerRegistration.cpp:
• workers/service/server/SWServerRegistration.h:

(WebCore::SWServerRegistration::installingWorker const):
(WebCore::SWServerRegistration::waitingWorker const):
(WebCore::SWServerRegistration::activeWorker const):

• workers/service/server/SWServerWorker.cpp:

(WebCore::SWServerWorker::terminate):

• workers/service/server/SWServerWorker.h:

Source/WebKit:

Implement step 14+ of Install algorithm, as per:

• ​https://w3c.github.io/ServiceWorker/#installation-algorithm

• Scripts/webkit/messages.py:

(headers_for_type):

• Shared/WebCoreArgumentCoders.h:
• StorageProcess/ServiceWorker/WebSWServerConnection.cpp:

(WebKit::WebSWServerConnection::resolveRegistrationJobInClient):

• StorageProcess/ServiceWorker/WebSWServerConnection.h:
• StorageProcess/ServiceWorker/WebSWServerConnection.messages.in:
• WebProcess/Storage/WebSWClientConnection.cpp:

(WebKit::WebSWClientConnection::didResolveRegistrationPromise):

• WebProcess/Storage/WebSWClientConnection.h:
• WebProcess/Storage/WebSWClientConnection.messages.in:

3:40 PM Changeset in webkit [224651] by Nikita Vasilyev

• 3 edits in trunk/Source/WebInspectorUI

Web Inspector: Styles Redesign: clicking on inline swatches and property checkboxes should not add a new property
​https://bugs.webkit.org/show_bug.cgi?id=179507
<rdar://problem/35452204>

Reviewed by Brian Burg.

• UserInterface/Views/SpreadsheetCSSStyleDeclarationSection.js:

(WI.SpreadsheetCSSStyleDeclarationSection.prototype.initialLayout):
(WI.SpreadsheetCSSStyleDeclarationSection.prototype._handleClick):
Don't add new properties when clicking on selector fields, source links, and property checkboxes.

• UserInterface/Views/SpreadsheetStyleProperty.js:

(WI.SpreadsheetStyleProperty.prototype._update):
It is safe to replace "change" event with "click" since it fires even when pressing Space key when the checkbox is focused.

3:35 PM Changeset in webkit [224650] by d_russell@apple.com

• 9 edits
  6 adds in trunk

Bug 179068 - AX: search predicate returns containing group for plain text instead of text element
​https://bugs.webkit.org/show_bug.cgi?id=179068

Reviewed by Darin Adler

Implement a check in AccessibilityRenderObject::hasPlainText(), AccessibilityObject::canHavePlainText(), to confirm the element is capable of providing text.

Source/WebCore:

Tests: accessibility/mac/search-predicate-plaintext.html

accessibility/mac/search-predicate-visible-button.html
accessibility/mac/search-predicate-visited-links.html

• accessibility/AccessibilityNodeObject.cpp:

(WebCore::AccessibilityNodeObject::text const):
(WebCore::AccessibilityNodeObject::stringValue const):

• accessibility/AccessibilityObject.h:

(WebCore::AccessibilityObject::isARIAStaticText const):

• accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::stringValue const):
(WebCore::AccessibilityRenderObject::canHavePlainText const):
(WebCore::AccessibilityRenderObject::hasPlainText const):

• accessibility/AccessibilityRenderObject.h:

LayoutTests:

• accessibility/mac/search-predicate-expected.txt:
• accessibility/mac/search-predicate-plaintext-expected.txt: Added.
• accessibility/mac/search-predicate-plaintext.html: Added.
• accessibility/mac/search-predicate-visible-button-expected.txt: Added.
• accessibility/mac/search-predicate-visible-button.html: Added.
• accessibility/mac/search-predicate-visited-links-expected.txt: Added.
• accessibility/mac/search-predicate-visited-links.html: Added.
• accessibility/mac/search-predicate.html:
• platform/mac-wk2/TestExpectations:

3:26 PM Changeset in webkit [224649] by Wenson Hsieh

• 7 edits
  2 adds in trunk

Inserting an image, selecting, underlining, and then deleting leaves the typing style with both "-webkit-text-decorations-in-effect" and "text-decoration"
​https://bugs.webkit.org/show_bug.cgi?id=179431

Reviewed by Ryosuke Niwa.

Source/WebCore:

When inserting an image element, selecting it, underlining the selection, deleting, and then inserting text, we
crash on a debug assert. This codepath was exercised by an API test added in <​https://trac.webkit.org/r224512>.
This assertion happens due to the following sequence of events:

1. DeleteSelectionCommand::saveTypingStyleState computes a typing style.
2. In doing so, it calls into EditingStyle::init, which observes that "-webkit-text-decorations-in-effect" is present and appends "text-decoration" with an identical CSS value to the EditingStyle's mutable style properties.
3. DeleteSelectionCommand::calculateTypingStyleAfterDelete sets the current selection's typing style to the above typing style.
4. Later on, when we try to insert text, we compute the StyleChange using the above typing style, which calls into reconcileTextDecorationProperties.
5. reconcileTextDecorationProperties debug asserts that "-webkit-text-decorations-in-effect" and "text-decoration" don't coexist on the EditingStyle's (i.e. the typing style's) mutable properties; since (2) added both properties, this assertion fires.

It appears that step (2) shouldn't be adding "text-decoration" in addition to EditingStyle's mutable style
properties, since doing so would violate the requirements of reconcileTextDecorationProperties. As such, we can
tweak EditingStyle::init to *replace* the "-webkit-text-decorations-in-effect" property with "text-decoration"
instead; this matches the behavior of reconcileTextDecorationProperties, and ensures that we only have the
"text-decorations" property when we try to insert text in step (4).

Test: editing/execCommand/underline-selection-containing-image.html

• editing/EditingStyle.cpp:

(WebCore::EditingStyle::init):

LayoutTests:

Adds a new layout test to fix a debug assertion. See WebCore/ChangeLog for more details. Additionally
rebaselines a few existing tests that serialize markup strings to include text-decoration: none;.

• editing/execCommand/underline-selection-containing-image-expected.txt: Added.
• editing/execCommand/underline-selection-containing-image.html: Added.
• editing/pasteboard/data-transfer-get-data-on-drop-rich-text-expected.txt:
• fast/events/before-input-events-prevent-drag-and-drop-expected.txt:
• fast/events/input-events-paste-rich-datatransfer-expected.txt:
• fast/events/ondrop-text-html-expected.txt:

3:12 PM Changeset in webkit [224648] by webkit@devinrousso.com

• 16 edits
  2 adds in trunk

Web Inspector: support undo/redo of insertAdjacentHTML
​https://bugs.webkit.org/show_bug.cgi?id=179283

Reviewed by Joseph Pecoraro.

Source/JavaScriptCore:

• inspector/protocol/DOM.json:

Add insertAdjacentHTML command that executes an undoable version of insertAdjacentHTML
on the given node.

Source/WebCore:

Test: inspector/dom/insertAdjacentHTML.html

Create another version of Element::insertAdjacentHTML that keeps track of the nodes that are
added. This is necessary because the children of a DocumentFragment are removed when it is
added to a ContainerNode. In this way, it is possible to remove those nodes during an undo.

• dom/Element.h:
• dom/Element.cpp:

(WebCore::Element::insertAdjacentHTML):

• inspector/DOMEditor.h:
• inspector/DOMEditor.cpp:

(WebCore::DOMEditor::insertAdjacentHTML):
Drive-by fix: sort functions and class declarations.

• inspector/agents/InspectorDOMAgent.h:
• inspector/agents/InspectorDOMAgent.cpp:

(WebCore::InspectorDOMAgent::insertAdjacentHTML):

Source/WebInspectorUI:

• UserInterface/Models/DOMNode.js:

(WI.DOMNode.prototype.insertAdjacentHTML):

• UserInterface/Views/DOMTreeElement.js:

(WI.DOMTreeElement.prototype._startEditingAsHTML):
Drive-by: only attempt to update the cursor if an initialValue is supplied.

LayoutTests:

• inspector/dom/insertAdjacentHTML-expected.txt: Added.
• inspector/dom/insertAdjacentHTML.html: Added.

2:13 PM Changeset in webkit [224647] by commit-queue@webkit.org

• 2 edits in trunk/Tools

[WinCairo EWS] svn-apply: 'cp' is not recognized as an internal or external command
​https://bugs.webkit.org/show_bug.cgi?id=179469

Patch by Fujii Hironori <Fujii Hironori> on 2017-11-09
Reviewed by Per Arne Vollan.

WinCairo EWS bots haven't installed Cygwin.

• Scripts/svn-apply:

(scmCopy): Use 'copy' function instead of 'cp' command.

2:03 PM Changeset in webkit [224646] by Alan Bujtas

• 3 edits in trunk/Source/WebCore

[LayoutState cleanup] Remove redundant LayoutState c'tor
​https://bugs.webkit.org/show_bug.cgi?id=179505
<rdar://problem/35450650>

Reviewed by Antti Koivisto.

No change in functionality.

• rendering/LayoutState.cpp:
• rendering/LayoutState.h:

1:09 PM Changeset in webkit [224645] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebCore

FetchResponse should set the mime type of its internal ResourceResponse
​https://bugs.webkit.org/show_bug.cgi?id=179487

Patch by Youenn Fablet <​youenn@apple.com> on 2017-11-09
Reviewed by Chris Dumez.

No observable change.
Setting the mime type of the response as navigation loads use that field.
This will be used for navigation loads served by service worker.

• Modules/fetch/FetchResponse.cpp:

(WebCore::FetchResponse::create):

12:58 PM Changeset in webkit [224644] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebCore

ServiceWorker ResourceResponse should not assert in platformCertificateInfo()
​https://bugs.webkit.org/show_bug.cgi?id=179486

Patch by Youenn Fablet <​youenn@apple.com> on 2017-11-09
Reviewed by Chris Dumez.

No change of behavior.
In case a Response is returned by Service Worker, there may be no related internal response.
In that case, platformCertificateInfo is returning an empty CertificateInfo.

• platform/network/cocoa/ResourceResponseCocoa.mm:

(WebCore::ResourceResponse::platformCertificateInfo const):

12:56 PM Changeset in webkit [224643] by clopez@igalia.com

• 2 edits in trunk/Tools

[WPE] Update dyz (WPE MiniBrowser)
​https://bugs.webkit.org/show_bug.cgi?id=179492

Reviewed by Michael Catanzaro.

Update it to the last version as of today.
This version not longer uses the C API.

• wpe/jhbuild.modules:

12:56 PM Changeset in webkit [224642] by Michael Catanzaro

• 2 edits
  1 add in trunk

[WPE] Use linker script to control exported symbols
​https://bugs.webkit.org/show_bug.cgi?id=179358

Reviewed by Carlos Alberto Lopez Perez.

The C API is being inadvertently exported because it's marked as WEBKIT_EXPORT in the header
files. But of course it should only be exported in DEVELOPER_MODE, where it's needed for
WebKitTestRunner. Use (almost) the same linker version script as GTK to fix this. It's
slightly different because WPE does not have WebKitPluginProcess.

This also reduces binary size of libWPEWebKit.so in debug mode from 615 MB down to 497 MB.
(Haven't checked release mode.)

• Source/cmake/OptionsWPE.cmake:
• Source/cmake/wpesymbols.filter: Added.

12:22 PM Changeset in webkit [224641] by Alan Bujtas

• 4 edits in trunk/Source/WebCore

[LayoutState cleanup] Remove conditional push from RenderTableSection::calcRowLogicalHeight
​https://bugs.webkit.org/show_bug.cgi?id=179493
<rdar://problem/35446631>

Reviewed by Antti Koivisto.

Pushing layout states is cheap and we do it for every container anyway.

Covered by existing tests.

• rendering/LayoutState.cpp:

(WebCore::LayoutStateMaintainer::LayoutStateMaintainer):
(WebCore::LayoutStateMaintainer::~LayoutStateMaintainer):
(WebCore::LayoutStateMaintainer::pop):
(WebCore::LayoutStateMaintainer::push): Deleted.

• rendering/LayoutState.h:

(WebCore::LayoutStateMaintainer::didPush const): Deleted.

• rendering/RenderTableSection.cpp:

(WebCore::RenderTableSection::calcRowLogicalHeight):

11:30 AM Changeset in webkit [224640] by Megan Gardner

• 2 edits in trunk/Source/WebKit

Clean out unused selection items from UIKitSPI
​https://bugs.webkit.org/show_bug.cgi?id=179459

Reviewed by Tim Horton.

Many of these should have been removed from previous commits, but they were missed.
None of these enums or methods are being used by WebKit anymore, and removing them will keep things
clean and allow UIKit to remove things that are not used at all by anyone anymore.

• Platform/spi/ios/UIKitSPI.h:

11:13 AM Changeset in webkit [224639] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebCore

CachedResourceLoader::requestRawResource should not assert when destination is set in the context of a service worker
​https://bugs.webkit.org/show_bug.cgi?id=179491

Patch by Youenn Fablet <​youenn@apple.com> on 2017-11-09
Reviewed by Chris Dumez.

No change of behavior.
requestRawResource on web page should have the destination set as the empty string as per fetch spec.
In the context of a service worker, requestRawResource may be used with any destination.
Updating assertion accordingly.

• loader/cache/CachedResourceLoader.cpp:

(WebCore::CachedResourceLoader::requestRawResource):

11:00 AM Changeset in webkit [224638] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebCore

ResourceErrorBase::setType should not ASSERT if it is a no op
​https://bugs.webkit.org/show_bug.cgi?id=179490

Patch by Youenn Fablet <​youenn@apple.com> on 2017-11-09
Reviewed by Chris Dumez.

No change of behavior.

• platform/network/ResourceErrorBase.cpp:

(WebCore::ResourceErrorBase::setType):

10:50 AM Changeset in webkit [224637] by Alan Bujtas

• 5 edits in trunk/Source/WebCore

[LayoutState cleanup] Remove renderer data members from state maintainers.
​https://bugs.webkit.org/show_bug.cgi?id=179483
<rdar://problem/35442548>

Reviewed by Darin Adler.

Although layout is not supposed to mutate the tree anymore, it's safer to use LayoutContext instead.

No change in functionality.

• page/LayoutContext.cpp:
• page/LayoutContext.h:
• rendering/LayoutState.cpp:

(WebCore::SubtreeLayoutStateMaintainer::SubtreeLayoutStateMaintainer):
(WebCore::SubtreeLayoutStateMaintainer::~SubtreeLayoutStateMaintainer):
(WebCore::PaginatedLayoutStateMaintainer::PaginatedLayoutStateMaintainer):
(WebCore::PaginatedLayoutStateMaintainer::~PaginatedLayoutStateMaintainer):

• rendering/LayoutState.h:

10:37 AM Changeset in webkit [224636] by mjs@apple.com

• 5 edits
  3 adds in trunk

Remove support for iOS-only softbank-sjis encoding if possible
​https://bugs.webkit.org/show_bug.cgi?id=179416

Reviewed by Darin Adler.

Source/WebCore:

• platform/text/TextCodecICU.cpp:

(WebCore::TextCodecICU::registerEncodingNames): Remove support for softbank-sjis
codec, because by code inspection it couldn't have possibly worked.
(WebCore::TextCodecICU::registerCodecs): Ditto.

LayoutTests:

• fast/encoding/charset-softbank-sjis.html: Added. Test that <meta charset>

declaration for softbank-sjis is ignored.

• fast/encoding/charset-softbank-sjis-expected.txt: Added.
• fast/encoding/resources/softbank-sjis-iframe.html: Added. Helper for above test.
• fast/encoding/legacy-ios-encodings.html: Add a case for softbank-sjis.
• fast/encoding/legacy-ios-encodings-expected.txt: Result for above.

10:33 AM Changeset in webkit [224635] by commit-queue@webkit.org

• 28 edits in trunk

Use enum classes within FileSystem
​https://bugs.webkit.org/show_bug.cgi?id=175172

Patch by Christopher Reid <​chris.reid@sony.com> on 2017-11-09
Reviewed by Darin Adler.

Source/WebCore:

No new tests, no change in behavior.

Further cleanup to FileSystem's enum classes.
Shortening FileSystem's enum names now that they are enum classes.
Adding OptionSet<FileLockMode> to functions using the FileLockMode enum.

• Modules/webdatabase/OriginLock.cpp:
• loader/appcache/ApplicationCacheStorage.cpp:
• platform/FileHandle.h:
• platform/FileStream.cpp:
• platform/FileSystem.cpp:
• platform/FileSystem.h:
• platform/cocoa/FileMonitorCocoa.mm:
• platform/glib/FileSystemGlib.cpp:
• platform/network/curl/CurlCacheEntry.cpp:
• platform/network/curl/CurlCacheManager.cpp:
• platform/posix/FileSystemPOSIX.cpp:
• platform/win/FileSystemWin.cpp:
• rendering/RenderThemeWin.cpp:

Source/WebKit:

• NetworkProcess/Downloads/BlobDownloadClient.cpp:
• NetworkProcess/NetworkDataTaskBlob.cpp:
• NetworkProcess/cache/NetworkCache.cpp:
• NetworkProcess/capture/NetworkCaptureManager.cpp:
• NetworkProcess/capture/NetworkCaptureRecorder.cpp:
• Shared/WebMemorySampler.cpp:
• UIProcess/API/APIContentRuleListStore.cpp:
• UIProcess/ResourceLoadStatisticsPersistentStorage.cpp:

Source/WebKitLegacy/win:

• Plugins/PluginDatabase.cpp:

Tools:

• TestWebKitAPI/Tests/WebCore/FileMonitor.cpp:
• TestWebKitAPI/Tests/WebCore/cocoa/DatabaseTrackerTest.mm:

10:32 AM Changeset in webkit [224634] by commit-queue@webkit.org

• 34 edits
  1 copy
  1 move
  2 adds in trunk/Source

Web Inspector: Make domain availability a list of types instead of a single type
​https://bugs.webkit.org/show_bug.cgi?id=179457

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2017-11-09
Reviewed by Brian Burg.

Source/JavaScriptCore:

• inspector/scripts/codegen/generate_js_backend_commands.py:

(JSBackendCommandsGenerator.generate_domain):
Update output of InspectorBackend.activateDomain to include the list.

• inspector/scripts/codegen/models.py:

(Protocol.parse_domain):
Parse availability as a list and include a new supported value of "service-worker".

• inspector/protocol/ApplicationCache.json:
• inspector/protocol/CSS.json:
• inspector/protocol/Canvas.json:
• inspector/protocol/DOM.json:
• inspector/protocol/DOMDebugger.json:
• inspector/protocol/DOMStorage.json:
• inspector/protocol/Database.json:
• inspector/protocol/IndexedDB.json:
• inspector/protocol/LayerTree.json:
• inspector/protocol/Memory.json:
• inspector/protocol/Network.json:
• inspector/protocol/Page.json:
• inspector/protocol/Timeline.json:
• inspector/protocol/Worker.json:

Update availability to be a list.

• inspector/scripts/tests/generic/domain-availability.json:
• inspector/scripts/tests/generic/expected/domain-availability.json-result:
• inspector/scripts/tests/generic/expected/fail-on-domain-availability-type.json-error: Added.
• inspector/scripts/tests/generic/expected/fail-on-domain-availability-value.json-error: Added.
• inspector/scripts/tests/generic/expected/fail-on-domain-availability.json-error:
• inspector/scripts/tests/generic/fail-on-domain-availability-type.json: Copied from Source/JavaScriptCore/inspector/scripts/tests/generic/fail-on-domain-availability.json.
• inspector/scripts/tests/generic/fail-on-domain-availability-value.json: Renamed from Source/JavaScriptCore/inspector/scripts/tests/generic/fail-on-domain-availability.json.

Update tests to include a test for the type and an invalid value.

Source/WebInspectorUI:

• UserInterface/Protocol/InspectorBackend.js:

(InspectorBackendClass.prototype.activateDomain):
The second value changed to be an optional list. Check if the active
debuggable type is in the list or not.

• UserInterface/Protocol/Legacy/10.0/InspectorBackendCommands.js:
• UserInterface/Protocol/Legacy/10.3/InspectorBackendCommands.js:
• UserInterface/Protocol/Legacy/11.0/InspectorBackendCommands.js:
• UserInterface/Protocol/Legacy/8.0/InspectorBackendCommands.js:
• UserInterface/Protocol/Legacy/9.0/InspectorBackendCommands.js:
• UserInterface/Protocol/Legacy/9.3/InspectorBackendCommands.js:
• Versions/Inspector-iOS-10.0.json:
• Versions/Inspector-iOS-10.3.json:
• Versions/Inspector-iOS-11.0.json:
• Versions/Inspector-iOS-8.0.json:
• Versions/Inspector-iOS-9.0.json:
• Versions/Inspector-iOS-9.3.json:

Since this is a change to how we generate the frontend resource,
update the legacy versioned backends and regenerate their resource.

10:24 AM Changeset in webkit [224633] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebKit

ServiceWorkerClientFetch should create not null ResourceError
​https://bugs.webkit.org/show_bug.cgi?id=179485

Patch by Youenn Fablet <​youenn@apple.com> on 2017-11-09
Reviewed by Darin Adler.

• WebProcess/Storage/ServiceWorkerClientFetch.cpp:

(WebKit::ServiceWorkerClientFetch::didReceiveResponse):

10:21 AM Changeset in webkit [224632] by Alan Bujtas

• 3 edits in trunk/Source/WebCore

[LayoutState cleanup] LayouState::m_lineGrid should be a weak pointer
​https://bugs.webkit.org/show_bug.cgi?id=179484
<rdar://problem/35442725>

Reviewed by Darin Adler.

Covered by existing tests.

• rendering/LayoutState.cpp:

(WebCore::LayoutState::propagateLineGridInfo):
(WebCore::LayoutState::establishLineGrid):

• rendering/LayoutState.h:

(WebCore::LayoutState::lineGrid const):

9:36 AM Changeset in webkit [224631] by Brent Fulgham

• 3 edits in trunk/Tools

Test fix after r224609
​https://bugs.webkit.org/show_bug.cgi?id=178565
<rdar://problem/11115901>

Unreviewed test fix after r224609.

Correct two test cases that attempt to push local file URLs in violation of our
same origin policies. The fix is to grant universal file access, as we do for similar
LayoutTests.

• TestWebKitAPI/Tests/WebKit/EphemeralSessionPushStateNoHistoryCallback.cpp:

(TestWebKitAPI::TEST):

• TestWebKitAPI/Tests/WebKit/PrivateBrowsingPushStateNoHistoryCallback.cpp:

(TestWebKitAPI::TEST):

9:27 AM BuildingGtk edited by Michael Catanzaro

(diff)

9:26 AM BuildingGtk edited by Michael Catanzaro

(diff)

9:24 AM BuildingGtk edited by Michael Catanzaro

(diff)

9:20 AM Changeset in webkit [224630] by aestes@apple.com

• 3 edits in trunk/Source/WebKit

[iOS] Adopt UIPreviewDataAttachmentListIsContentManaged
​https://bugs.webkit.org/show_bug.cgi?id=179458
<rdar://problem/35034691>

Reviewed by Dan Bernstein.

• Platform/spi/ios/UIKitSPI.h:
• UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView _dataForPreviewItemController:atPosition:type:]):

9:11 AM Changeset in webkit [224629] by pvollan@apple.com

• 3 edits
  26 adds in trunk/Source/WebKitLegacy

[Win] Add WebKitQuartzCoreAdditions library.
​https://bugs.webkit.org/show_bug.cgi?id=179331

Reviewed by Alex Christensen.

Source/WebKitLegacy:

This library should be added to the OpenSource repository.

• CMakeLists.txt:

Source/WebKitLegacy/win:

• WebKitQuartzCoreAdditions: Added.
• WebKitQuartzCoreAdditions/API: Added.
• WebKitQuartzCoreAdditions/API/WKCACFImage.cpp: Added.

(toImage):
(WKCACFImageGetWidth):
(WKCACFImageGetHeight):
(WKCACFImageCopyFileMapping):
(WKCACFImageCreateWithImage):
(WKCACFImageFinalize):
(WKCACFImageCopyFormattingDescription):
(WKCACFImageCopyDebugDescription):
(WKCACFImageGetTypeID):

• WebKitQuartzCoreAdditions/API/WKCACFImage.h: Added.
• WebKitQuartzCoreAdditions/API/WKCACFImageInternal.h: Added.
• WebKitQuartzCoreAdditions/API/WKCACFView.cpp: Added.

(toView):
(toImpl):
(WKCACFViewCreate):
(WKCACFViewSetLayer):
(WKCACFViewUpdate):
(WKCACFViewFlushContext):
(WKCACFViewInvalidateRects):
(WKCACFViewCanDraw):
(WKCACFViewDraw):
(WKCACFViewCopyDrawnImage):
(WKCACFViewDrawIntoDC):
(contextDidChangeCallback):
(WKCACFViewSetContextDidChangeCallback):
(WKCACFViewGetLastCommitTime):
(WKCACFViewSetContextUserData):
(WKCACFViewGetContext):
(WKCACFViewFinalize):
(WKCACFViewCopyFormattingDescription):
(WKCACFViewCopyDebugDescription):
(WKCACFViewGetTypeID):
(WKCACFViewSetShouldInvertColors):
(WKCACFViewGetD3DDevice9):

• WebKitQuartzCoreAdditions/API/WKCACFView.h: Added.
• WebKitQuartzCoreAdditions/API/WKCACFViewPrivate.h: Added.
• WebKitQuartzCoreAdditions/API/WebKitQuartzCoreAdditions.cpp: Added.

(WKQCA::dllInstance):
(DllMain):
(WKCACFShutDown):

• WebKitQuartzCoreAdditions/API/WebKitQuartzCoreAdditionsBase.h: Added.
• WebKitQuartzCoreAdditions/CAD3DRenderer.cpp: Added.

(WKQCA::D3DPostProcessingContext::D3DPostProcessingContext):
(WKQCA::d3d):
(WKQCA::initialPresentationParameters):
(WKQCA::CAD3DRenderer::shared):
(WKQCA::CAD3DRenderer::CAD3DRenderer):
(WKQCA::CAD3DRenderer::swapChain):
(WKQCA::CAD3DRenderer::createD3DPostProcessingContext):
(WKQCA::hardwareCapabilitiesIndicateCoreAnimationSupport):
(WKQCA::CAD3DRenderer::initialize):
(WKQCA::D3DMatrixOrthoOffCenterRH):
(WKQCA::prepareDevice):
(WKQCA::updateBounds):
(WKQCA::CAD3DRenderer::renderAndPresent):
(WKQCA::CAD3DRenderer::renderToImage):
(WKQCA::CAD3DRenderer::setDeviceIsLost):
(WKQCA::CAD3DRenderer::renderInternal):
(WKQCA::CAD3DRenderer::postProcess):
(WKQCA::CAD3DRenderer::resetD3DDevice):
(WKQCA::CAD3DRenderer::createShaderIfNeeded):
(WKQCA::CAD3DRenderer::release):

• WebKitQuartzCoreAdditions/CAD3DRenderer.h: Added.

(WKQCA::D3DPostProcessingContext::sceneTexture const):
(WKQCA::D3DPostProcessingContext::overlayQuad const):
(WKQCA::CAD3DRenderer::d3dDevice9 const):

• WebKitQuartzCoreAdditions/CAView.cpp: Added.

(WKQCA::CAView::Handle::create):
(WKQCA::CAView::Handle::~Handle):
(WKQCA::CAView::Handle::mutex):
(WKQCA::CAView::Handle::view const):
(WKQCA::CAView::Handle::clear):
(WKQCA::CAView::Handle::Handle):
(WKQCA::globalStateMutex):
(WKQCA::registerMessageWindowClass):
(WKQCA::createMessageWindow):
(WKQCA::CAView::releaseAllD3DResources):
(WKQCA::CAView::CAView):
(WKQCA::CAView::~CAView):
(WKQCA::CAView::create):
(WKQCA::CAView::setContextDidChangeCallback):
(WKQCA::CAView::setLayer):
(WKQCA::CAView::update):
(WKQCA::CAView::invalidateRects):
(WKQCA::CAView::drawToWindow):
(WKQCA::CAView::drawToWindowInternal):
(WKQCA::CAView::drawToImage):
(WKQCA::CAView::willDraw):
(WKQCA::CAView::didDraw):
(WKQCA::CAView::drawIntoDC):
(WKQCA::CAView::setShouldInvertColors):
(WKQCA::CAView::scheduleNextDraw):
(WKQCA::CAView::displayLinkReachedCAMediaTime):
(WKQCA::CAView::contextDidChangeCallback):
(WKQCA::CAView::contextDidChange):
(WKQCA::CAView::updateSoon):
(WKQCA::CAView::updateViewsNow):
(WKQCA::CAView::d3dDevice9):

• WebKitQuartzCoreAdditions/CAView.h: Added.

(WKQCA::CAView::context const):
(WKQCA::CAView::canDraw const):
(WKQCA::CAView::ContextDidChangeCallback::ContextDidChangeCallback):

• WebKitQuartzCoreAdditions/CMakeLists.txt: Added.
• WebKitQuartzCoreAdditions/CVDisplayLink.cpp: Added.

(WKQCA::CVDisplayLink::CVDisplayLink):
(WKQCA::CVDisplayLink::~CVDisplayLink):
(WKQCA::CVDisplayLink::create):
(WKQCA::CVDisplayLink::start):
(WKQCA::CVDisplayLink::stop):
(WKQCA::CVDisplayLink::setPaused):
(WKQCA::CVDisplayLink::runIOThread):

• WebKitQuartzCoreAdditions/CVDisplayLink.h: Added.
• WebKitQuartzCoreAdditions/CVDisplayLinkClient.h: Added.

(WKQCA::CVDisplayLinkClient::~CVDisplayLinkClient):

• WebKitQuartzCoreAdditions/Image.cpp: Added.

(WKQCA::numBytesForSize):
(WKQCA::Image::create):
(WKQCA::Image::Image):
(WKQCA::Image::~Image):
(WKQCA::bitmapInfo):
(WKQCA::Image::createDIB const):
(WKQCA::Image::copyFileMapping):

• WebKitQuartzCoreAdditions/Image.h: Added.

(WKQCA::Image::size const):

• WebKitQuartzCoreAdditions/ImageConversion.cpp: Added.

(WKQCA::getBackBufferRectAsRenderTarget):
(WKQCA::getSystemMemoryCopy):
(WKQCA::copyRectToBitmap):
(WKQCA::getImageCopy):
(WKQCA::getBackBufferRectAsImage):

• WebKitQuartzCoreAdditions/ImageConversion.h: Added.
• WebKitQuartzCoreAdditions/InvertColorPS.hlsl: Added.
• WebKitQuartzCoreAdditions/WebKitQuartzCoreAdditionsInternal.h: Added.
• WebKitQuartzCoreAdditions/WebKitQuartzCoreAdditionsPrefix.cpp: Added.
• WebKitQuartzCoreAdditions/WebKitQuartzCoreAdditionsPrefix.h: Added.

8:18 AM Changeset in webkit [224628] by Michael Catanzaro

• 2 edits in trunk/Tools

Unreviewed, remove Dan from the soup network watchlist

Per his request. It's not Hotel California; we should probably let him leave.

• Scripts/webkitpy/common/config/watchlist:

7:22 AM Changeset in webkit [224627] by matthew_hanson@apple.com

• 2 edits in tags/Safari-605.1.13/Source/WebCore

Cherry-pick r224604. rdar://problem/35421652

7:16 AM Changeset in webkit [224626] by Yusuke Suzuki

• 12 edits in trunk/Source/JavaScriptCore

[JSC][JIT] Clean up SlowPathCall stubs
​https://bugs.webkit.org/show_bug.cgi?id=179247

Reviewed by Saam Barati.

We have bunch of duplicate functions that just call a slow path function.
This patch cleans up the above duplication.

• jit/JIT.cpp:

(JSC::JIT::emitSlowCaseCall):
(JSC::JIT::privateCompileSlowCases):

• jit/JIT.h:
• jit/JITArithmetic.cpp:

(JSC::JIT::emitSlow_op_unsigned): Deleted.
(JSC::JIT::emitSlow_op_inc): Deleted.
(JSC::JIT::emitSlow_op_dec): Deleted.
(JSC::JIT::emitSlow_op_bitand): Deleted.
(JSC::JIT::emitSlow_op_bitor): Deleted.
(JSC::JIT::emitSlow_op_bitxor): Deleted.
(JSC::JIT::emitSlow_op_lshift): Deleted.
(JSC::JIT::emitSlow_op_rshift): Deleted.
(JSC::JIT::emitSlow_op_urshift): Deleted.
(JSC::JIT::emitSlow_op_div): Deleted.

• jit/JITArithmetic32_64.cpp:

(JSC::JIT::emitSlow_op_unsigned): Deleted.
(JSC::JIT::emitSlow_op_inc): Deleted.
(JSC::JIT::emitSlow_op_dec): Deleted.

• jit/JITOpcodes.cpp:

(JSC::JIT::emitSlow_op_create_this): Deleted.
(JSC::JIT::emitSlow_op_check_tdz): Deleted.
(JSC::JIT::emitSlow_op_to_this): Deleted.
(JSC::JIT::emitSlow_op_to_primitive): Deleted.
(JSC::JIT::emitSlow_op_not): Deleted.
(JSC::JIT::emitSlow_op_stricteq): Deleted.
(JSC::JIT::emitSlow_op_nstricteq): Deleted.
(JSC::JIT::emitSlow_op_to_number): Deleted.
(JSC::JIT::emitSlow_op_to_string): Deleted.
(JSC::JIT::emitSlow_op_to_object): Deleted.
(JSC::JIT::emitSlow_op_get_direct_pname): Deleted.
(JSC::JIT::emitSlow_op_has_structure_property): Deleted.

• jit/JITOpcodes32_64.cpp:

(JSC::JIT::emitSlow_op_to_primitive): Deleted.
(JSC::JIT::emitSlow_op_not): Deleted.
(JSC::JIT::emitSlow_op_stricteq): Deleted.
(JSC::JIT::emitSlow_op_nstricteq): Deleted.
(JSC::JIT::emitSlow_op_to_number): Deleted.
(JSC::JIT::emitSlow_op_to_string): Deleted.
(JSC::JIT::emitSlow_op_to_object): Deleted.
(JSC::JIT::emitSlow_op_create_this): Deleted.
(JSC::JIT::emitSlow_op_to_this): Deleted.
(JSC::JIT::emitSlow_op_check_tdz): Deleted.
(JSC::JIT::emitSlow_op_get_direct_pname): Deleted.

• jit/JITPropertyAccess.cpp:

(JSC::JIT::emitSlow_op_resolve_scope): Deleted.

• jit/JITPropertyAccess32_64.cpp:

(JSC::JIT::emit_op_resolve_scope):
(JSC::JIT::emitSlow_op_resolve_scope): Deleted.

• jit/SlowPathCall.h:

(JSC::JITSlowPathCall::JITSlowPathCall):

• runtime/CommonSlowPaths.cpp:

(JSC::SLOW_PATH_DECL):

• runtime/CommonSlowPaths.h:

7:08 AM Changeset in webkit [224625] by Alan Bujtas

• 4 edits in trunk/Source/WebCore

[LayoutState cleanup] Add pagination parameter to subtree LayoutState
​https://bugs.webkit.org/show_bug.cgi?id=179465
<rdar://problem/35434096>

Reviewed by Antti Koivisto.

It enables us to remove the last setters from LayoutState.

No change in functionality.

• page/LayoutContext.cpp:

(WebCore::LayoutContext::pushLayoutStateForPaginationIfNeeded):

• rendering/LayoutState.cpp:

(WebCore::LayoutState::LayoutState):
(WebCore::LayoutState::layoutDeltaMatches const):
(WebCore::LayoutState::layoutDeltaMatches): Deleted.

• rendering/LayoutState.h:

(WebCore::LayoutState::isPaginated const):
(WebCore::LayoutState::setIsPaginated): Deleted.
(WebCore::LayoutState::setPageLogicalHeight): Deleted.

4:54 AM WebKitGTK/Gardening/Calendar edited by clopez@igalia.com

(diff)

4:53 AM WebKitGTK/Gardening/Calendar edited by clopez@igalia.com

(diff)

4:36 AM Changeset in webkit [224624] by clopez@igalia.com

• 2 edits in trunk/LayoutTests

[GTK] Gardening 09 nov
​https://bugs.webkit.org/show_bug.cgi?id=179472

Unreviewed GTK gardening

• platform/gtk/TestExpectations:

2:24 AM WebKitGTK/Gardening/Calendar edited by Adrian Perez de Castro

(diff)

1:02 AM Changeset in webkit [224623] by guijemont@igalia.com

• 3 edits in trunk/Source/JavaScriptCore

[JSC][MIPS] Use fcsr to check the validity of the result of trunc.w.d
​https://bugs.webkit.org/show_bug.cgi?id=179446

Reviewed by Žan Doberšek.

The trunc.w.d mips instruction should give a 0x7fffffff result when
the source value is Infinity, NaN, or rounds to an integer outside the
range -2^{31 to 2}31 -1. This is what branchTruncateDoubleToInt32() and
branchTruncateDoubleToUInt32() have been relying on. It turns out that
this assumption is not true on some CPUs, including on the ci20 on
which we run the testbot (we get 0x80000000 instead). We should the
invalid operation cause bit instead to check whether the source value
could be properly truncated. This requires the addition of the cfc1
instruction, as well as the special registers that can be used with it
(control registers of CP1).

• assembler/MIPSAssembler.h:

(JSC::MIPSAssembler::firstSPRegister):
(JSC::MIPSAssembler::lastSPRegister):
(JSC::MIPSAssembler::numberOfSPRegisters):
(JSC::MIPSAssembler::sprName):
Added control registers of CP1.
(JSC::MIPSAssembler::cfc1):
Added.

• assembler/MacroAssemblerMIPS.h:

(JSC::MacroAssemblerMIPS::branchOnTruncateResult):
(JSC::MacroAssemblerMIPS::branchTruncateDoubleToInt32):
(JSC::MacroAssemblerMIPS::branchTruncateDoubleToUint32):
Use fcsr to check if the value could be properly truncated.

12:51 AM Changeset in webkit [224622] by commit-queue@webkit.org

• 2 edits in trunk/LayoutTests

[GTK] Test gardening
​https://bugs.webkit.org/show_bug.cgi?id=179447

Patch by Alicia Boya García <​aboya@igalia.com> on 2017-11-09
Reviewed by Michael Catanzaro.

• platform/gtk/TestExpectations:

12:12 AM Changeset in webkit [224621] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebInspectorUI

REGRESSION(r224566): [GTK][WPE] Many inspector tests are failing after r224566
​https://bugs.webkit.org/show_bug.cgi?id=179419

Patch by Carlos Garcia Campos <​cgarcia@igalia.com> on 2017-11-09
Reviewed by Carlos Alberto Lopez Perez.

All of them fail with the following error:

Uncaught exception in Inspector page: ReferenceError: Can't find variable: CodeMirror [TestCombined.js:36658:15]

This is because Test.html, even when combined, is trying to load CodeMirror from External/CodeMirror, but
CodeMirror was already combined for Main.html. We need to also combine CodeMirror for Test.html.

• Scripts/copy-user-interface-resources.pl: