⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Nov 11, 2017:

6:46 PM Changeset in webkit [224734] by Megan Gardner
  • 3 edits in trunk/Source/WebKitLegacy/ios

Fix a FIXMEs in WebFrameIOS
​https://bugs.webkit.org/show_bug.cgi?id=179510

Reviewed by Darin Adler.

Removed a function that does nothing and is not needed or used anywhere, linked to a radar that is in verify.
This is just some easy cleanup I found while investigating other things.

  • WebCoreSupport/WebFrameIOS.h:
  • WebCoreSupport/WebFrameIOS.mm:

(-[WebFrame imageForNode:allowDownsampling:drawContentBehindTransparentNodes:]): Deleted.

3:45 PM Changeset in webkit [224733] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebInspectorUI

Web Inspector: Network detail views - Include a newline between sections when copying
​https://bugs.webkit.org/show_bug.cgi?id=179577

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2017-11-11
Reviewed by Matt Baker.

  • UserInterface/Views/NetworkResourceDetailView.css:

(.content-view.resource-details):

  • UserInterface/Views/ResourceDetailsSection.css:

(.resource-details > section):
(.resource-details > section > .title):
Adjust styles now that there is a <br> taking up space between sections.
After all the changes, the top section moved up 1px from where it was originally.

  • UserInterface/Views/ResourceDetailsSection.js:

(WI.ResourceDetailsSection):
Include a <br> to get newlines when copying.

1:41 PM Changeset in webkit [224732] by mitz@apple.com
  • 2 edits in trunk/Source/WebCore

[Xcode] WebCore generates unified sources during installhdrs
​https://bugs.webkit.org/show_bug.cgi?id=179578

Reviewed by Anders Carlsson.

  • WebCore.xcodeproj/project.pbxproj: Use GenerateUnifiedSources.xcconfig, which sets INSTALLHDRS_SCRIPT_PHASE to NO, for the Generate Unified Sources target.
12:26 PM Changeset in webkit [224731] by Simon Fraser
  • 7 edits
    2 deletes in trunk/Source/WebCore

Remove redundant platform-specific implementations of Image::drawPattern()
​https://bugs.webkit.org/show_bug.cgi?id=179580

Reviewed by Sam Weinig.

Platform-specific Image files had implementations of Image::drawPattern() but they
were all effectively identical, so put a single implementation into Image.cpp.

  • SourcesCocoa.txt:
  • WebCore.xcodeproj/project.pbxproj:
  • platform/SourcesCairo.txt:
  • platform/graphics/Image.cpp:

(WebCore::Image::drawPattern):

  • platform/graphics/cairo/ImageCairo.cpp: Removed.
  • platform/graphics/cg/ImageCG.cpp: Removed.
  • platform/graphics/win/ImageDirect2D.cpp:

(WebCore::Image::drawPattern): Deleted.

10:54 AM Changeset in webkit [224730] by Chris Dumez
  • 19 edits
    11 adds
    7 deletes in trunk/LayoutTests

Re-sync Service Workers web-platform-tests from upstream
​https://bugs.webkit.org/show_bug.cgi?id=179575

Reviewed by Youenn Fablet.

LayoutTests/imported/w3c:

Re-sync Service Workers web-platform-tests from upstream 04892735ed1.

  • web-platform-tests/service-workers/service-worker/ServiceWorkerGlobalScope/registration-attribute.https-expected.txt:
  • web-platform-tests/service-workers/service-worker/ServiceWorkerGlobalScope/registration-attribute.https.html:
  • web-platform-tests/service-workers/service-worker/ServiceWorkerGlobalScope/resources/registration-attribute-newer-worker.js: Added.

(record):

  • web-platform-tests/service-workers/service-worker/ServiceWorkerGlobalScope/resources/registration-attribute-worker.js:
  • web-platform-tests/service-workers/service-worker/ServiceWorkerGlobalScope/resources/unregister-controlling-worker.html: Added.
  • web-platform-tests/service-workers/service-worker/ServiceWorkerGlobalScope/resources/unregister-worker.js:

(matchQuery):
(e.waitUntil.self.registration.unregister.then):

  • web-platform-tests/service-workers/service-worker/ServiceWorkerGlobalScope/resources/update-worker.js:
  • web-platform-tests/service-workers/service-worker/ServiceWorkerGlobalScope/resources/w3c-import.log:
  • web-platform-tests/service-workers/service-worker/detached-context.https-expected.txt: Added.
  • web-platform-tests/service-workers/service-worker/detached-context.https.html: Added.
  • web-platform-tests/service-workers/service-worker/fetch-event.https-expected.txt:
  • web-platform-tests/service-workers/service-worker/fetch-event.https.html:
  • web-platform-tests/service-workers/service-worker/navigation-preload/empty-preload-response-body.https-expected.txt:
  • web-platform-tests/service-workers/service-worker/navigation-preload/resources/empty-preload-response-body-scope.html: Added.
  • web-platform-tests/service-workers/service-worker/request-body-blob.https-expected.txt: Removed.
  • web-platform-tests/service-workers/service-worker/request-body-blob.https.html: Removed.
  • web-platform-tests/service-workers/service-worker/resources/empty.js: Added.
  • web-platform-tests/service-workers/service-worker/resources/fetch-event-test-worker.js:

(handleHeaders):
(handleRequestBody):

  • web-platform-tests/service-workers/service-worker/resources/interfaces-idls.js:
  • web-platform-tests/service-workers/service-worker/resources/interfaces-worker.sub.js:

(test):

  • web-platform-tests/service-workers/service-worker/resources/request-body-blob-iframe.html: Removed.
  • web-platform-tests/service-workers/service-worker/resources/request-body-blob-worker.js: Removed.
  • web-platform-tests/service-workers/service-worker/resources/respond-with-body-accessed-response-iframe.html: Added.
  • web-platform-tests/service-workers/service-worker/resources/respond-with-body-accessed-response-worker.js: Added.

(getQueryParams):
(createResponse):
(cloneResponseIfNeeded):
(passThroughCacheIfNeeded):
(event.request.url.indexOf):
(event.respondWith.createResponse.params.then):
(then):

  • web-platform-tests/service-workers/service-worker/resources/respond-with-body-accessed-response.jsonp: Added.
  • web-platform-tests/service-workers/service-worker/resources/test-helpers.sub.js:
  • web-platform-tests/service-workers/service-worker/resources/w3c-import.log:
  • web-platform-tests/service-workers/service-worker/resources/websocket-worker.js: Added.

(reportFailure):
(onmessage.event.ws.onopen):
(onmessage.event.ws.onclose):
(onmessage.event.ws.onerror):

  • web-platform-tests/service-workers/service-worker/resources/xhr.js: Removed.
  • web-platform-tests/service-workers/service-worker/respond-with-body-accessed-response.https-expected.txt: Added.
  • web-platform-tests/service-workers/service-worker/respond-with-body-accessed-response.https.html: Added.
  • web-platform-tests/service-workers/service-worker/w3c-import.log:
  • web-platform-tests/service-workers/service-worker/waiting.https-expected.txt:
  • web-platform-tests/service-workers/service-worker/waiting.https.html:
  • web-platform-tests/service-workers/service-worker/websocket-in-service-worker.https-expected.txt: Added.
  • web-platform-tests/service-workers/service-worker/websocket-in-service-worker.https.html: Added.
  • web-platform-tests/service-workers/service-worker/xhr.https-expected.txt: Removed.
  • web-platform-tests/service-workers/service-worker/xhr.https.html: Removed.

LayoutTests:

Skip a few tests that are timing out.

1:42 AM Changeset in webkit [224729] by timothy_horton@apple.com
  • 5 edits in trunk/Source/WebKit

Increase the alignment requirement of WKObject's wrapped C++ object
​https://bugs.webkit.org/show_bug.cgi?id=179518

Reviewed by Dan Bernstein.

  • Shared/API/APIObject.h:
  • Shared/Cocoa/APIObject.mm:

(API::allocateWKObject):
(API::Object::fromWKObjectExtraSpace):
(API::Object::newObject):

  • Shared/Cocoa/WKObject.mm:

(-[WKObject dealloc]):
(-[WKObject _apiObject]):

  • UIProcess/API/Cocoa/WKConnection.mm:

(-[WKConnection dealloc]):
(-[WKConnection _apiObject]):
(-[WKConnection _connection]):
Increase the alignment of the C++ object stored inside WKObject's extra space
to 8-bytes, for platforms where some types require greater-than-pointer alignment.
To achieve this, increase the size of the extra-space allocation by the difference
between 8 bytes and pointer-alignment, and then align within that.

1:24 AM Changeset in webkit [224728] by timothy_horton@apple.com
  • 3 edits in trunk/Source/WebKit

Avoid composing the message + recipient name for crash logs until a failure actually occurs
​https://bugs.webkit.org/show_bug.cgi?id=179576

Reviewed by Dan Bernstein.

  • Platform/IPC/mac/ConnectionMac.mm:

(IPC::Connection::sendMessage):
(IPC::Connection::sendOutgoingMessage):

  • Platform/IPC/mac/MachMessage.h:

(IPC::MachMessage::messageReceiverName const):
(IPC::MachMessage::setMessageReceiverName):
(IPC::MachMessage::messageName const):
(IPC::MachMessage::setMessageName):
Store the message name and receiver name separately on MachMessage,
only composing them into a string if the message is unhandled. This
makes the time spent composing the string in sendOutgoingMessage
completely disappear. In absolute terms, it wasn't huge, but if you
do enough IPC it starts to add up.

1:24 AM Changeset in webkit [224727] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Network waterfall graph - make connection part thinner
​https://bugs.webkit.org/show_bug.cgi?id=179561

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2017-11-11
Reviewed by Devin Rousso.

  • UserInterface/Views/NetworkTableContentView.css:

(.waterfall .block):

1:22 AM Changeset in webkit [224726] by webkit@devinrousso.com
  • 18 edits in trunk

Web Inspector: Canvas tab: show detailed status during canvas recording
​https://bugs.webkit.org/show_bug.cgi?id=178185
<rdar://problem/34939862>

Reviewed by Brian Burg.

Source/JavaScriptCore:

  • inspector/protocol/Canvas.json:

Add a recordingProgress event that is sent to the frontend that contains all the frame
payloads since the last Canvas.recordingProgress event and the current buffer usage.

  • inspector/protocol/Recording.json:

Remove the required frames parameter from the Recording protocol object, as they will be
sent in batches via the Canvas.recordingProgress event.

Source/WebCore:

Updated existing tests to assert that the correct number of progress events are fired.

  • inspector/agents/InspectorCanvasAgent.cpp:

(WebCore::InspectorCanvasAgent::didFinishRecordingCanvasFrame):
After each recorded frame, fire a progress event with the recorded frames as data. This will
release the frames from the associated InspectorCanvas, meaning that the frames must be
aggregated in the frontend before a Recording can be created.

The protocol is designed with arrays so that if we decide to add throttling (e.g. one event
per second) we are able to do so without modifying the protocol.

  • inspector/InspectorCanvas.h:
  • inspector/InspectorCanvas.cpp:

(WebCore::InspectorCanvas::hasRecordingData const):
(WebCore::InspectorCanvas::currentFrameHasData const):
(WebCore::InspectorCanvas::recordAction):
(WebCore::InspectorCanvas::finalizeFrame):
(WebCore::InspectorCanvas::markCurrentFrameIncomplete):
Add additional checks that the list of recorded frames is not nullptr when finalizing or
marking as incomplete.

Source/WebInspectorUI:

  • Localizations/en.lproj/localizedStrings.js:
  • UserInterface/Protocol/CanvasObserver.js:

(WI.CanvasObserver.prototype.recordingProgress):

  • UserInterface/Controllers/CanvasManager.js:

(WI.CanvasManager):
(WI.CanvasManager.prototype.recordingProgress):
(WI.CanvasManager.prototype.recordingFinished):
Maintain arrays of recorded frames for each canvas and add new frames each time a progress
event is fired. When the recording is finished, use the array as part of the payload for
creating a WI.Recording object.

  • UserInterface/Models/Recording.js:

(WI.Recording.fromPayload):

  • UserInterface/Models/RecordingAction.js:

(WI.RecordingAction.prototype.apply.getContent):
(WI.RecordingAction.prototype.apply):
Drive-by fix: toDataURL is very slow, so add alternative ways of getting and comparing the
content of the canvas to determine if the action has a visible effect.

  • UserInterface/Views/CanvasContentView.css:

(.content-view.canvas:not(.tab)):
(.content-view.canvas:not(.tab) > .progress):
(.content-view.canvas:not(.tab) > .progress > .frame-count):

  • UserInterface/Views/CanvasContentView.js:

(WI.CanvasContentView):
(WI.CanvasContentView.prototype.attached):
(WI.CanvasContentView.prototype._recordingStarted):
(WI.CanvasContentView.prototype._recordingProgress):
(WI.CanvasContentView.prototype._recordingStopped):
Steal some space from the preview area to display a count of the number of recorded frames
and the current buffer usage.

  • UserInterface/Views/CanvasOverviewContentView.css:

(.content-view.canvas-overview .content-view.canvas > :matches(header, .progress, .preview, footer)):
(.content-view.canvas-overview .content-view.canvas.selected > :matches(.progress, .preview, footer),):
(.content-view.canvas-overview .content-view.canvas > :matches(.progress, .preview)):
(.content-view.canvas-overview .content-view.canvas > .preview):
(.content-view.canvas-overview .content-view.canvas > .progress ~ .preview):
(.content-view.canvas-overview .content-view.canvas > :matches(header, .preview, footer)): Deleted.
(.content-view.canvas-overview .content-view.canvas.selected > :matches(.preview, footer),): Deleted.

LayoutTests:

  • inspector/canvas/resources/recording-utilities.js:

(TestPage.registerInitializer.window.startRecording.handleRecordingProgress):
(TestPage.registerInitializer.window.startRecording):

12:14 AM WebKitGTK/2.18.x edited by berto@igalia.com
(diff)
12:08 AM Changeset in webkit [224725] by berto@igalia.com
  • 2 edits in trunk/Source/WebCore

[GTK] PlatformGTK.cmake: use the PKG_CONFIG_EXECUTABLE variable
​https://bugs.webkit.org/show_bug.cgi?id=179547

Patch by Helmut Grohne <​helmut@subdivi.de> on 2017-11-11
Reviewed by Michael Catanzaro.

  • PlatformGTK.cmake: Use PKG_CONFIG_EXECUTABLE instead of

hardcoding the executable name.

Nov 10, 2017:

10:15 PM Changeset in webkit [224724] by Chris Dumez
  • 13 edits in trunk/LayoutTests

Unreviewed, unskip & rebaseline several service worker tests

LayoutTests/imported/w3c:

  • web-platform-tests/service-workers/service-worker/ServiceWorkerGlobalScope/unregister.https-expected.txt:
  • web-platform-tests/service-workers/service-worker/ServiceWorkerGlobalScope/update.https-expected.txt:
  • web-platform-tests/service-workers/service-worker/import-scripts-updated-flag.https-expected.txt:
  • web-platform-tests/service-workers/service-worker/navigation-redirect.https-expected.txt:
  • web-platform-tests/service-workers/service-worker/registration-script.https-expected.txt:
  • web-platform-tests/service-workers/service-worker/registration-service-worker-attributes.https-expected.txt:
  • web-platform-tests/service-workers/service-worker/registration-updateviacache.https-expected.txt:
  • web-platform-tests/service-workers/service-worker/unregister-controller.https-expected.txt:
  • web-platform-tests/service-workers/service-worker/unregister-then-register-new-script.https-expected.txt:
  • web-platform-tests/service-workers/service-worker/update-bytecheck.https-expected.txt:

LayoutTests:

9:15 PM Changeset in webkit [224723] by Chris Dumez
  • 10 edits
    3 adds in trunk

[Service Workers] Registration promise should be rejected when the service worker fails to start
​https://bugs.webkit.org/show_bug.cgi?id=179566

Reviewed by Brady Eidson.

LayoutTests/imported/w3c:

Rebaseline WPT tests now that we properly reject registration promises when the worker script
fails to evaluate.

  • web-platform-tests/service-workers/service-worker/ServiceWorkerGlobalScope/registration-attribute.https-expected.txt:
  • web-platform-tests/service-workers/service-worker/navigation-redirect.https-expected.txt:
  • web-platform-tests/service-workers/service-worker/redirected-response.https-expected.txt:
  • web-platform-tests/service-workers/service-worker/update.https-expected.txt:

Source/WebCore:

Registration promise should be rejected when the service worker fails to start.

Though our code intended to do this, there were several issues:

  • Our code failed to properly detect when the script failed to evaluate. This is because it relied on the exception message being non-null but it was always null when same origin due to a bug.
  • Our scriptContextFailedToStart() handler failed to rejected the promise and finish the job as per:

Test: http/tests/workers/service/worker-fails-to-start.html

  • bindings/js/WorkerScriptController.cpp:

(WebCore::WorkerScriptController::evaluate):

  • workers/service/server/SWServerJobQueue.cpp:

(WebCore::SWServerJobQueue::scriptContextFailedToStart):

LayoutTests:

Add layout test coverage.

  • TestExpectations: Mark test as flaky as the console lines sometimes change order.
  • http/tests/workers/service/resources/worker-fails-to-start-worker.js: Added.
  • http/tests/workers/service/worker-fails-to-start-expected.txt: Added.
  • http/tests/workers/service/worker-fails-to-start.html: Added.
8:32 PM Changeset in webkit [224722] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

check-webkit-style: AttributeError: 'NoneType' object has no attribute 'major'
​https://bugs.webkit.org/show_bug.cgi?id=179522

Patch by Fujii Hironori <Fujii Hironori> on 2017-11-10
Reviewed by Aakash Jain.

IOSSimulatorPort.ios_version should return a Version object.

  • Scripts/webkitpy/port/ios_simulator.py:

(IOSSimulatorPort.ios_version): Return a Version object.

6:45 PM Changeset in webkit [224721] by jer.noble@apple.com
  • 2 edits in trunk/Source/WebCore

Unreviewed Win Debug build fix; add FourCC.cpp to the cmake source list for Windows.

  • PlatformWin.cmake:
6:35 PM Changeset in webkit [224720] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[Win] The way to detect Windows 10 is wrong
​https://bugs.webkit.org/show_bug.cgi?id=179344

Patch by Basuke Suzuki <Basuke Suzuki> on 2017-11-10
Reviewed by Alex Christensen.

  • Scripts/webkitpy/common/system/platforminfo.py:

(PlatformInfo._determine_win_version):

5:43 PM Changeset in webkit [224719] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[CG] PDF document cached image is regenerated every time the destination rectangle changes
​https://bugs.webkit.org/show_bug.cgi?id=179516

Patch by Said Abou-Hallawa <​sabouhallawa@apple.com> on 2017-11-10
Reviewed by Tim Horton.

The PDF document cached image was regenerated if m_cachedImageRect didn't
contain the dirty rectangle. When moving the image, its new rectangle is
invalidated. This will set a new dirty rectangle outside m_cachedImageRect
which may not be fully inside m_cachedImageRect.

The PDF document cached image should be reused if we still draw the same
part of the image (srcRet did not change) and we use the same zooming factor
(dstSize did not change).

  • platform/graphics/cg/PDFDocumentImage.cpp:

(WebCore::PDFDocumentImage::cacheParametersMatch const): Remove a check
that was added mainly to force recalculating m_cachedImageRect when the
dirty rectangle changes.

(WebCore::PDFDocumentImage::updateCachedImageIfNeeded): Recalculate
m_cachedImageRect every time this function is called regardless the cached
image will be regenerated or not.

5:22 PM Changeset in webkit [224718] by Ryan Haddad
  • 3 edits in trunk/LayoutTests

Update TestExpectations for imported/w3c/web-platform-tests/html/browsers/origin/relaxing-the-same-origin-restriction/document_domain_setter_null.tentative.html.
​https://bugs.webkit.org/show_bug.cgi?id=177440

Unreviewed test gardening.

5:16 PM Changeset in webkit [224717] by Ryan Haddad
  • 2 edits in trunk/LayoutTests

Mark http/tests/websocket/tests/hybi/contentextensions/upgrade-worker.html as flaky.
​https://bugs.webkit.org/show_bug.cgi?id=179557

Unreviewed test gardening.

  • platform/mac-wk2/TestExpectations:
5:07 PM Changeset in webkit [224716] by Simon Fraser
  • 2 edits in trunk/Source/WebCore

Compositing layers in UIWebView are often missing content after scrolling
​https://bugs.webkit.org/show_bug.cgi?id=179564
rdar://problem/33885639

Reviewed by Tim Horton.

When dropping backing store for layers outside the viewport, we rely on a compositing
layer flush to compute layer visibility and bring the backing store back when necessary.

In UIWebView, we have a mechanism to trigger flushing on user scrolling but it only triggers
when there are tiled layers. Remove that condition so it triggers always, now that
backing store availability also depends on this.

  • page/ios/FrameIOS.mm:

(WebCore::Frame::viewportOffsetChanged):
(WebCore::anyFrameHasTiledLayers): Deleted.

5:07 PM Changeset in webkit [224715] by Simon Fraser
  • 3 edits
    2 adds in trunk

Contents of composited overflow-scroll are missing when newly added
​https://bugs.webkit.org/show_bug.cgi?id=179556
rdar://problem/20368294

Reviewed by Tim Horton.

Source/WebCore:

When content is appended to an oveflow:scroll, we do a subtree layout. That triggered
a compositing code path that failed to call updateAfterDescendants() which is where
we compute whether we can be a simple composited layer without backing store. Fix to
call that after the updateGeometry() call, as we do elsewhere.

Test: compositing/backing/overflow-gains-content.html

  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::updateAfterLayout):

LayoutTests:

  • compositing/backing/overflow-gains-content-expected.html: Added.
  • compositing/backing/overflow-gains-content.html: Added.
4:20 PM Changeset in webkit [224714] by commit-queue@webkit.org
  • 4 edits in trunk/Tools

[WinCairo] LayoutTests doesn't read TextExpectations files correctly
​https://bugs.webkit.org/show_bug.cgi?id=179219

Patch by Basuke Suzuki <Basuke Suzuki> on 2017-11-10
Reviewed by Alex Christensen.

  • Scripts/webkitpy/layout_tests/models/test_expectations.py:

(TestExpectationParser._parse_line):

  • Scripts/webkitpy/port/apple.py:

(ApplePort.init):
(ApplePort._allowed_port_names):
(ApplePort):
(ApplePort._future_port_name):
(ApplePort._generate_all_test_configurations):

  • Scripts/webkitpy/port/win.py:

(WinCairoPort.default_baseline_search_path):
(WinCairoPort):
(WinCairoPort._future_port_name):

4:18 PM Changeset in webkit [224713] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[WinCairo] Treat 'future' version correctly
​https://bugs.webkit.org/show_bug.cgi?id=179345

Patch by Basuke Suzuki <Basuke Suzuki> on 2017-11-10
Reviewed by Alex Christensen.

  • Scripts/webkitpy/port/win.py:

(WinCairoPort.default_baseline_search_path):

4:15 PM Changeset in webkit [224712] by Simon Fraser
  • 6 edits in trunk/Source/WebCore

Remove the 'CompositingChildrenOnly' flag which was always on
​https://bugs.webkit.org/show_bug.cgi?id=179546

Reviewed by Antoine Quint.

All calls to updateAfterLayout() passed the CompositingChildrenOnly flag, so all calls
to updateCompositingDescendantGeometry() had compositedChildrenOnly=true, so remove
these flags.

Also use an OptionSet<>.

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::updateLayerPositions):

  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::updateAfterLayout):
(WebCore::RenderLayerBacking::contentChanged):

  • rendering/RenderLayerBacking.h:
  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::updateCompositingDescendantGeometry):

  • rendering/RenderLayerCompositor.h:
4:03 PM Changeset in webkit [224711] by Chris Dumez
  • 3 edits in trunk/Source/WebCore

Remove dead code from ServiceWorkerRegistration
​https://bugs.webkit.org/show_bug.cgi?id=179555

Reviewed by Ryosuke Niwa.

  • workers/service/ServiceWorkerRegistration.cpp:

(WebCore::ServiceWorkerRegistration::setInstallingWorker): Deleted.
(WebCore::ServiceWorkerRegistration::setWaitingWorker): Deleted.
(WebCore::ServiceWorkerRegistration::setActiveWorker): Deleted.

  • workers/service/ServiceWorkerRegistration.h:
4:00 PM Changeset in webkit [224710] by Chris Dumez
  • 5 edits
    2 adds in trunk

[Service Workers] Implement better support for "Clear Registration" algorithm
​https://bugs.webkit.org/show_bug.cgi?id=179441

Reviewed by Brady Eidson.

LayoutTests/imported/w3c:

Rebaseline WPT test due to behavior change. Unfortunately, the check goes from PASS to FAIL.
The reason is that we do not implement "Try Clear Registration" algorithm, only the "Clear
Registration" one. The test expects that a registration object does not get cleared after
unregistration because it is "in use". However, because we do not yet support checking if
a registration is "in use" in try clear, we proceed to clearing the registration and marking
its service workers as redundant.

Previously, the test was passing because even though we were clearing the registration, we
did not mark its service workers as redundant yet. As a result, we would still report that
the registration as having an active worker with "activated" state and the test would think
we did not clear the registration, even though we did.

  • web-platform-tests/service-workers/service-worker/getregistrations.https-expected.txt:

Source/WebCore:

Implement better support for "Clear Registration" algorithm as per:

In particular, we now properly clear the service workers on the ServiceWorkerRegistration
object and we properly update its service workers' state to "redundant".

Test: http/tests/workers/service/registration-clear-redundant-worker.html

  • workers/service/server/SWServerJobQueue.cpp:

(WebCore::SWServerJobQueue::clearRegistration):

LayoutTests:

Add layout test coverage.

  • http/tests/workers/service/registration-clear-redundant-worker-expected.txt: Added.
  • http/tests/workers/service/registration-clear-redundant-worker.html: Added.
3:44 PM Changeset in webkit [224709] by Ryan Haddad
  • 21 edits
    4 deletes in trunk

Unreviewed, rolling out r224705.

Introduced a LayoutTest crash on WK1.

Reverted changeset:

"[Web Animations] Implement getAnimations()"
​https://bugs.webkit.org/show_bug.cgi?id=179535
​https://trac.webkit.org/changeset/224705

3:13 PM Changeset in webkit [224708] by Wenson Hsieh
  • 2 edits in trunk/Tools

Finish rolling out r224544

Rubber-stamped by Tim Horton.

Now that ​https://bugs.webkit.org/show_bug.cgi?id=179431 has been fixed, we can once again allow one of the API
tests added in r224512 (WKAttachmentTests.AttachmentUpdatesWhenChangingFontStyles) to test toggling underline
style with a selected attachment element.

  • TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:

(TestWebKitAPI::TEST):

3:02 PM Changeset in webkit [224707] by jer.noble@apple.com
  • 20 edits
    8 copies
    1 move
    14 adds
    1 delete in trunk

Add a FairPlay Streaming based CDM for Modern EME
​https://bugs.webkit.org/show_bug.cgi?id=179499
<rdar://problem/35445033>

Reviewed by Eric Carlson.

Source/WebCore:

Tests: platform/mac/media/encrypted-media/fps-createMediaKeys.html

platform/mac/media/encrypted-media/fps-requestMediaKeySystemAccess.html

Add new CDMFairPlayStreaming and CDMInstanceFairPlayStreamingAVFObjC platform classes which implement
the basics of FairPlay Streaming support in Modern EME.

Drive-by fixes:

  • Add a != operator to FourCC
  • Add a virtual setStorageDirectory() method to CDMInstance (and default implementations to CDMClearKey and MockCDM)
  • Move ISOVTTCue into the platform/graphics/iso directory and update all the places where it is called.
  • Modules/encryptedmedia/MediaKeySession.cpp:

(WebCore::MediaKeySession::mediaKeysStorageDirectory const):

  • Modules/encryptedmedia/MediaKeySession.h:
  • Sources.txt:
  • WebCore.xcodeproj/project.pbxproj:
  • platform/encryptedmedia/CDMFactory.cpp:
  • platform/encryptedmedia/CDMInstance.h:
  • platform/encryptedmedia/CDMRestrictions.h:
  • platform/encryptedmedia/clearkey/CDMClearKey.cpp:

(WebCore::CDMInstanceClearKey::setStorageDirectory):

  • platform/encryptedmedia/clearkey/CDMClearKey.h:
  • platform/graphics/FourCC.h:

(WebCore::FourCC::operator!= const):

  • platform/graphics/iso/ISOBox.cpp: Added.

(WebCore::ISOBox::peekBox):
(WebCore::ISOBox::read):
(WebCore::ISOBox::parse):
(WebCore::ISOFullBox::parse):

  • platform/graphics/iso/ISOBox.h: Added.

(WebCore::ISOBox::minimumBoxSize):
(WebCore::ISOBox::size const):
(WebCore::ISOBox::boxType const):
(WebCore::ISOBox::extendedType const):
(WebCore::ISOBox::checkedRead):
(WebCore::ISOFullBox::version const):
(WebCore::ISOFullBox::flags const):

  • platform/graphics/iso/ISOOriginalFormatBox.cpp: Added.

(WebCore::ISOOriginalFormatBox::parse):

  • platform/graphics/iso/ISOOriginalFormatBox.h: Added.

(WebCore::ISOOriginalFormatBox::boxTypeName):
(WebCore::ISOOriginalFormatBox::dataFormat const):

  • platform/graphics/iso/ISOProtectionSchemeInfoBox.cpp: Added.

(WebCore::ISOProtectionSchemeInfoBox::parse):

  • platform/graphics/iso/ISOProtectionSchemeInfoBox.h: Added.

(WebCore::ISOProtectionSchemeInfoBox::boxTypeName):
(WebCore::ISOProtectionSchemeInfoBox::schemeTypeBox const):
(WebCore::ISOProtectionSchemeInfoBox::schemeInformationBox const):

  • platform/graphics/iso/ISOSchemeInformationBox.cpp: Added.

(WebCore::ISOSchemeInformationBox::parse):

  • platform/graphics/iso/ISOSchemeInformationBox.h: Added.

(WebCore::ISOSchemeInformationBox::boxTypeName):
(WebCore::ISOSchemeInformationBox::schemeSpecificData const):

  • platform/graphics/iso/ISOSchemeTypeBox.cpp: Added.

(WebCore::ISOSchemeTypeBox::parse):

  • platform/graphics/iso/ISOSchemeTypeBox.h: Added.

(WebCore::ISOSchemeTypeBox::boxTypeName):
(WebCore::ISOSchemeTypeBox::schemeType const):
(WebCore::ISOSchemeTypeBox::schemeVersion const):

  • platform/graphics/iso/ISOTrackEncryptionBox.cpp: Added.

(WebCore::ISOTrackEncryptionBox::parse):

  • platform/graphics/iso/ISOTrackEncryptionBox.h: Added.

(WebCore::ISOTrackEncryptionBox::boxTypeName):
(WebCore::ISOTrackEncryptionBox::defaultCryptByteBlock const):
(WebCore::ISOTrackEncryptionBox::defaultSkipByteBlock const):
(WebCore::ISOTrackEncryptionBox::defaultIsProtected const):
(WebCore::ISOTrackEncryptionBox::defaultPerSampleIVSize const):
(WebCore::ISOTrackEncryptionBox::defaultKID const):
(WebCore::ISOTrackEncryptionBox::defaultConstantIV const):

  • platform/graphics/iso/ISOVTTCue.cpp: Added.

(WebCore::ISOStringBox::contents):
(WebCore::vttIdBoxType):
(WebCore::vttSettingsBoxType):
(WebCore::vttPayloadBoxType):
(WebCore::vttCurrentTimeBoxType):
(WebCore::vttCueSourceIDBoxType):
(WebCore::ISOWebVTTCue::ISOWebVTTCue):
(WebCore::ISOWebVTTCue::parse):

  • platform/graphics/iso/ISOVTTCue.h: Renamed from Source/WebCore/platform/graphics/ISOVTTCue.h.

(WebCore::ISOWebVTTCue::boxTypeName):
(WebCore::ISOWebVTTCue::presentationTime const):
(WebCore::ISOWebVTTCue::duration const):
(WebCore::ISOWebVTTCue::sourceID const):
(WebCore::ISOWebVTTCue::id const):
(WebCore::ISOWebVTTCue::originalStartTime const):
(WebCore::ISOWebVTTCue::settings const):
(WebCore::ISOWebVTTCue::cueText const):

  • platform/graphics/avfoundation/CDMFairPlayStreaming.cpp: Added.

(WebCore::extractSinfData):
(WebCore::extractSchemeAndKeyIdFromSinf):
(WebCore::extractKeyIDsSinf):
(WebCore::sanitizeSinf):
(WebCore::CDMFactory::platformRegisterFactories):
(WebCore::CDMFactoryFairPlayStreaming::singleton):
(WebCore::CDMFactoryFairPlayStreaming::createCDM):
(WebCore::CDMFactoryFairPlayStreaming::supportsKeySystem):
(WebCore::CDMPrivateFairPlayStreaming::supportsInitDataType const):
(WebCore::CDMPrivateFairPlayStreaming::supportsConfiguration const):
(WebCore::CDMPrivateFairPlayStreaming::supportsConfigurationWithRestrictions const):
(WebCore::CDMPrivateFairPlayStreaming::supportsSessionTypeWithConfiguration const):
(WebCore::CDMPrivateFairPlayStreaming::supportsRobustness const):
(WebCore::CDMPrivateFairPlayStreaming::distinctiveIdentifiersRequirement const):
(WebCore::CDMPrivateFairPlayStreaming::persistentStateRequirement const):
(WebCore::CDMPrivateFairPlayStreaming::distinctiveIdentifiersAreUniquePerOriginAndClearable const):
(WebCore::CDMPrivateFairPlayStreaming::createInstance):
(WebCore::CDMPrivateFairPlayStreaming::loadAndInitialize):
(WebCore::CDMPrivateFairPlayStreaming::supportsServerCertificates const):
(WebCore::CDMPrivateFairPlayStreaming::supportsSessions const):
(WebCore::CDMPrivateFairPlayStreaming::supportsInitData const):
(WebCore::CDMPrivateFairPlayStreaming::sanitizeResponse const):
(WebCore::CDMPrivateFairPlayStreaming::sanitizeSessionId const):

  • platform/graphics/avfoundation/CDMFairPlayStreaming.h: Added.
  • platform/graphics/avfoundation/objc/CDMInstanceFairPlayStreamingAVFObjC.h: Added.
  • platform/graphics/avfoundation/objc/CDMInstanceFairPlayStreamingAVFObjC.mm: Added.

(-[WebCoreFPSContentKeySessionDelegate initWithParent:]):
(-[WebCoreFPSContentKeySessionDelegate invalidate]):
(-[WebCoreFPSContentKeySessionDelegate contentKeySession:didProvideContentKeyRequest:]):
(-[WebCoreFPSContentKeySessionDelegate contentKeySession:didProvideRenewingContentKeyRequest:]):
(-[WebCoreFPSContentKeySessionDelegate contentKeySession:didProvidePersistableContentKeyRequest:]):
(-[WebCoreFPSContentKeySessionDelegate contentKeySession:didUpdatePersistableContentKey:forContentKeyIdentifier:]):
(-[WebCoreFPSContentKeySessionDelegate contentKeySession:contentKeyRequest:didFailWithError:]):
(-[WebCoreFPSContentKeySessionDelegate contentKeySession:shouldRetryContentKeyRequest:reason:]):
(-[WebCoreFPSContentKeySessionDelegate contentKeySessionContentProtectionSessionIdentifierDidChange:]):
(WebCore::CDMInstanceFairPlayStreamingAVFObjC::CDMInstanceFairPlayStreamingAVFObjC):
(WebCore::CDMInstanceFairPlayStreamingAVFObjC::~CDMInstanceFairPlayStreamingAVFObjC):
(WebCore::CDMInstanceFairPlayStreamingAVFObjC::supportsPersistableState):
(WebCore::CDMInstanceFairPlayStreamingAVFObjC::supportsPersistentKeys):
(WebCore::CDMInstanceFairPlayStreamingAVFObjC::mimeTypeIsPlayable):
(WebCore::CDMInstanceFairPlayStreamingAVFObjC::initializeWithConfiguration):
(WebCore::CDMInstanceFairPlayStreamingAVFObjC::setDistinctiveIdentifiersAllowed):
(WebCore::CDMInstanceFairPlayStreamingAVFObjC::setPersistentStateAllowed):
(WebCore::CDMInstanceFairPlayStreamingAVFObjC::setServerCertificate):
(WebCore::CDMInstanceFairPlayStreamingAVFObjC::setStorageDirectory):
(WebCore::CDMInstanceFairPlayStreamingAVFObjC::isLicenseTypeSupported const):
(WebCore::CDMInstanceFairPlayStreamingAVFObjC::requestLicense):
(WebCore::CDMInstanceFairPlayStreamingAVFObjC::updateLicense):
(WebCore::CDMInstanceFairPlayStreamingAVFObjC::loadSession):
(WebCore::CDMInstanceFairPlayStreamingAVFObjC::closeSession):
(WebCore::CDMInstanceFairPlayStreamingAVFObjC::removeSessionData):
(WebCore::CDMInstanceFairPlayStreamingAVFObjC::storeRecordOfKeyUsage):
(WebCore::CDMInstanceFairPlayStreamingAVFObjC::keySystem const):
(WebCore::CDMInstanceFairPlayStreamingAVFObjC::didProvideRequest):
(WebCore::CDMInstanceFairPlayStreamingAVFObjC::didProvideRenewingRequest):
(WebCore::CDMInstanceFairPlayStreamingAVFObjC::didProvidePersistableRequest):
(WebCore::CDMInstanceFairPlayStreamingAVFObjC::didFailToProvideRequest):
(WebCore::CDMInstanceFairPlayStreamingAVFObjC::shouldRetryRequestForReason):
(WebCore::CDMInstanceFairPlayStreamingAVFObjC::sessionIdentifierChanged):

  • platform/graphics/avfoundation/InbandTextTrackPrivateAVF.cpp:

(WebCore::InbandTextTrackPrivateAVF::processNativeSamples):
(WebCore::InbandTextTrackPrivateAVF::readNativeSampleBuffer):

  • testing/MockCDMFactory.cpp:

(WebCore::MockCDMInstance::setStorageDirectory):

  • testing/MockCDMFactory.h:

Source/WTF:

  • wtf/Platform.h:

LayoutTests:

  • platform/mac/TestExpectations:
  • platform/mac/media/encrypted-media/fps-createMediaKeys-expected.txt: Added.
  • platform/mac/media/encrypted-media/fps-createMediaKeys.html: Added.
  • platform/mac/media/encrypted-media/fps-requestMediaKeySystemAccess-expected.txt: Added.
  • platform/mac/media/encrypted-media/fps-requestMediaKeySystemAccess.html: Added.
2:36 PM Changeset in webkit [224706] by Megan Gardner
  • 5 edits in trunk/LayoutTests

Rebase some layout tests
​https://bugs.webkit.org/show_bug.cgi?id=179519

Reviewed by Alex Christensen and Tim Horton.

In helping with cleaning up tests, rebase tests that have only been effected by font changes
and other similarly irrelevant changes. Also turning back on a few tests that actually do work
now.

  • platform/ios-wk2/TestExpectations:
  • platform/ios/editing/selection/3690703-2-expected.txt:
  • platform/ios/editing/selection/3690703-expected.txt:
  • platform/ios/editing/selection/3690719-expected.txt:
2:12 PM Changeset in webkit [224705] by graouts@webkit.org
  • 21 edits
    1 copy
    7 adds in trunk

[Web Animations] Implement getAnimations()
​https://bugs.webkit.org/show_bug.cgi?id=179535
<rdar://problem/34932475>

Reviewed by Simon Fraser.

Source/WebCore:

We now allow a list of animations for a document, with Document.getAnimations(), or for an
element, with Animatable.getAnimations(), to be returned. In order to support this, we maintain
a map on AnimationTimeline of all animations for a given element. This map is invalidated
when an animation's timeline changes and when an animation's effect changes. Note that the
Web Animations spec mandates that an AnimationEffect can only be a single animation's effect.

Additionally, we ensure that the Document-to-DocumentTimeline relationship is cleared when
is being prepared for teardown to avoid a ref-cycle.

Tests: http/wpt/wk-web-animations/interfaces/document-get-animations.html

http/wpt/wk-web-animations/interfaces/element-get-animations.html
http/wpt/wk-web-animations/timing-model/animation-effect-unique-relationship.html

  • CMakeLists.txt: Add Animatable.idl.
  • DerivedSources.make: Add Animatable.idl.
  • WebCore.xcodeproj/project.pbxproj: Add Animatable.idl.
  • animation/Animatable.idl: A new interface that Element implements and which currently only exposes

getAnimations(), the animate() method will be added later.

  • animation/AnimationEffect.h: Add a new m_animation member to reference the animation using this

effect. This relationship is required so we guarantee that an effect is associated with a single
animation at most.
(WebCore::AnimationEffect::animation const):
(WebCore::AnimationEffect::setAnimation):

  • animation/AnimationTimeline.cpp:

(WebCore::AnimationTimeline::animationWasAddedToElement): New method to notify the timeline that an
animation registered with this timeline has been associated with a new element through its effect.
(WebCore::AnimationTimeline::animationWasRemovedFromElement): New method to notify the timeline that an
animation registered with this timeline has been disassociated with an element through its effect.
(WebCore::AnimationTimeline::animationsForElement): New method returning all animations registered with
this timeline for a given element.

  • animation/AnimationTimeline.h:

(WebCore::AnimationTimeline::animations const): All animations registered with this timeline.

  • animation/DocumentTimeline.cpp:

(WebCore::DocumentTimeline::DocumentTimeline):
(WebCore::DocumentTimeline::detachFromDocument): Clear the reference between this timeline and its document.

  • animation/DocumentTimeline.h:
  • animation/WebAnimation.cpp:

(WebCore::WebAnimation::create):
(WebCore::WebAnimation::setEffect): As an animation's effect changes, we need to ensure that the old
effect no longer has an associated animation, and that the new effect is associated with this animation.
Additionally, we update the element-to-animations map on the animation's timeline.
(WebCore::WebAnimation::setTimeline): Update the element-to-animations map on the former and new timeline.

  • dom/Document.cpp:

(WebCore::Document::prepareForDestruction): Clear the relationship between this document and its timeline.
(WebCore::Document::getAnimations): Obtain all animations associated with this document's timeline.

  • dom/Document.h:
  • dom/Document.idl:
  • dom/Element.cpp:

(WebCore::Element::getAnimations): Obtain all animations associated with this element.

  • dom/Element.h:
  • dom/Element.idl:
  • testing/Internals.cpp:

LayoutTests:

Update WPT expectations per new progressions and add three new tests that check the behavior of
Document.getAnimations(), Element.getAnimations() and the unique relationship between an Animation
and an AnimationEffect.

  • http/wpt/web-animations/interfaces/Animatable/animate-expected.txt:
  • http/wpt/web-animations/interfaces/Animatable/getAnimations-expected.txt:
  • http/wpt/web-animations/interfaces/Document/getAnimations-expected.txt:
  • http/wpt/wk-web-animations/interfaces/document-get-animations-expected.txt: Added.
  • http/wpt/wk-web-animations/interfaces/document-get-animations.html: Added.
  • http/wpt/wk-web-animations/interfaces/element-get-animations-expected.txt: Added.
  • http/wpt/wk-web-animations/interfaces/element-get-animations.html: Added.
  • http/wpt/wk-web-animations/timing-model/animation-effect-unique-relationship-expected.txt: Added.
  • http/wpt/wk-web-animations/timing-model/animation-effect-unique-relationship.html: Added.
2:10 PM Changeset in webkit [224704] by commit-queue@webkit.org
  • 4 edits in trunk/Source

Web Inspector: Make http status codes be "integer" instead of "number" in protocol
​https://bugs.webkit.org/show_bug.cgi?id=179543

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2017-11-10
Reviewed by Antoine Quint.

Source/JavaScriptCore:

  • inspector/protocol/Network.json:

Use a better type for the status code.

Source/WebCore:

  • inspector/agents/InspectorNetworkAgent.cpp:

(WebCore::InspectorNetworkAgent::buildObjectForResourceResponse):
No need for the temporary or type change.

2:03 PM Changeset in webkit [224703] by Ryan Haddad
  • 3 edits
    2 deletes in trunk

Unreviewed, rolling out r224602 and r224697.
​https://bugs.webkit.org/show_bug.cgi?id=179545

The LayoutTest for this change is flaky. (Requested by
ryanhaddad on #webkit).

Reverted changesets:

"Add tests to ensure that <source> tags are only preloaded
when the type"
​https://bugs.webkit.org/show_bug.cgi?id=179231
​https://trac.webkit.org/changeset/224602

"Fix race conditions with setBackingScaleFactor, page refresh
and preloader"
​https://bugs.webkit.org/show_bug.cgi?id=179488
​https://trac.webkit.org/changeset/224697

Patch by Commit Queue <​commit-queue@webkit.org> on 2017-11-10

12:30 PM Changeset in webkit [224702] by Chris Dumez
  • 19 edits
    3 adds in trunk

[Service Workers] Implement "Try Activate" / "Activate" algorithms
​https://bugs.webkit.org/show_bug.cgi?id=179436

Reviewed by Brady Eidson.

Source/WebCore:

Implement proper "Try Activate" / "Activate" algorithms as per:

Test: http/tests/workers/service/basic-activate-event.html

  • workers/service/context/SWContextManager.cpp:

(WebCore::SWContextManager::fireActivateEvent):

  • workers/service/context/SWContextManager.h:
  • workers/service/context/ServiceWorkerThread.cpp:

(WebCore::ServiceWorkerThread::fireActivateEvent):

  • workers/service/context/ServiceWorkerThread.h:
  • workers/service/server/SWServer.cpp:

(WebCore::SWServer::Connection::didFinishActivation):
(WebCore::SWServer::didFinishActivation):
(WebCore::SWServer::fireActivateEvent):

  • workers/service/server/SWServer.h:
  • workers/service/server/SWServerJobQueue.cpp:

(WebCore::SWServerJobQueue::didFinishInstall):
(WebCore::SWServerJobQueue::tryActivate):
(WebCore::SWServerJobQueue::activate):
(WebCore::SWServerJobQueue::didFinishActivation):

  • workers/service/server/SWServerJobQueue.h:

Source/WebKit:

Implement proper "Try Activate" / "Activate" algorithms as per:

  • StorageProcess/ServiceWorker/WebSWServerConnection.cpp:

(WebKit::WebSWServerConnection::fireActivateEvent):

  • StorageProcess/ServiceWorker/WebSWServerConnection.h:
  • StorageProcess/StorageProcess.cpp:

(WebKit::StorageProcess::didFinishServiceWorkerActivation):

  • StorageProcess/StorageProcess.h:
  • StorageProcess/StorageProcess.messages.in:
  • WebProcess/Storage/WebSWContextManagerConnection.cpp:

(WebKit::WebSWContextManagerConnection::fireActivateEvent):
(WebKit::WebSWContextManagerConnection::didFinishActivation):

  • WebProcess/Storage/WebSWContextManagerConnection.h:
  • WebProcess/Storage/WebSWContextManagerConnection.messages.in:

LayoutTests:

Add layout test coverage.

  • http/tests/workers/service/basic-activate-event-expected.txt: Added.
  • http/tests/workers/service/basic-activate-event.html: Added.
  • http/tests/workers/service/resources/basic-activate-event-worker.js: Added.
12:11 PM Changeset in webkit [224701] by achristensen@apple.com
  • 2 edits in trunk/Source/WebCore

Fix debug build after r224700
​https://bugs.webkit.org/show_bug.cgi?id=179460

  • platform/text/TextEncodingRegistry.cpp:

(WebCore::addToTextEncodingNameMap):

11:26 AM Changeset in webkit [224700] by mjs@apple.com
  • 5 edits
    2 adds in trunk

Remove TEC decoders that duplicate ICU decoders
​https://bugs.webkit.org/show_bug.cgi?id=179460

Reviewed by Darin Adler.

Source/WebCore:

Test: fast/encoding/duplicate-tec-encodings.html

  • platform/text/TextEncodingRegistry.cpp:

(WebCore::checkExistingName): Deleted.
(WebCore::addToTextEncodingNameMap): Move the check from checkExistingName here,
and make it an ASSERT, since we should now be guaranteed no duplicate encodings.

  • platform/text/mac/mac-encodings.txt: Remove encodings that duplicate ones we

implement with ICU.

  • platform/text/TextCodecICU.cpp: Add some extra encoding aliases that only TEC

knew about.

LayoutTests:

  • fast/encoding/duplicate-tec-encodings-expected.txt: Added.
  • fast/encoding/duplicate-tec-encodings.html: Added.
11:23 AM Changeset in webkit [224699] by achristensen@apple.com
  • 16 edits in trunk/Source/WebCore

Make CachedResource::redirectReceived asynchronous
​https://bugs.webkit.org/show_bug.cgi?id=179503

Reviewed by Antti Koivisto.

There were a few loops where we called redirectReceived many times in a row,
and these are replaced with a completion handler that recursively calls the next
redirectReceived or the code after the loop.

No change in behavior.

  • loader/DocumentLoader.cpp:

(WebCore::DocumentLoader::redirectReceived):

  • loader/DocumentLoader.h:

(WebCore::DocumentLoader::setLastCheckedRequest):

  • loader/DocumentThreadableLoader.cpp:

(WebCore::DocumentThreadableLoader::redirectReceived):

  • loader/DocumentThreadableLoader.h:
  • loader/MediaResourceLoader.cpp:

(WebCore::MediaResource::redirectReceived):

  • loader/MediaResourceLoader.h:
  • loader/PolicyChecker.cpp:

(WebCore::PolicyChecker::checkNavigationPolicy):

  • loader/SubresourceLoader.cpp:

(WebCore::SubresourceLoader::willSendRequestInternal):

  • loader/cache/CachedRawResource.cpp:

(WebCore::iterate):
(WebCore::CachedRawResource::didAddClient):
(WebCore::CachedRawResource::redirectReceived):

  • loader/cache/CachedRawResource.h:
  • loader/cache/CachedRawResourceClient.h:

(WebCore::CachedRawResourceClient::redirectReceived):

  • loader/cache/CachedResource.cpp:

(WebCore::CachedResource::redirectReceived):

  • loader/cache/CachedResource.h:
  • platform/graphics/PlatformMediaResourceLoader.h:

(WebCore::PlatformMediaResourceClient::redirectReceived):

  • platform/network/cocoa/WebCoreNSURLSession.mm:

(WebCore::WebCoreNSURLSessionDataTaskClient::redirectReceived):

11:06 AM Changeset in webkit [224698] by Brent Fulgham
  • 6 edits in trunk/Source

Ignore HSTS for partitioned, cross-origin subresource requests
​https://bugs.webkit.org/show_bug.cgi?id=178993
<rdar://problem/34962462>

Patch by John Wilander <​wilander@apple.com> on 2017-11-10
Reviewed by Brent Fulgham.

Source/WebCore:

No new tests. HSTS is not supported in layout tests.
Tested manually.

  • platform/network/mac/WebCoreURLResponse.mm:

(WebCore::synthesizeRedirectResponseIfNecessary):

Source/WebCore/PAL:

  • pal/spi/cf/CFNetworkSPI.h:

Added

  • (BOOL)_schemeWasUpgradedDueToDynamicHSTS
  • (BOOL)_preventHSTSStorage
  • (BOOL)_ignoreHSTS
  • (void)_setPreventHSTSStorage:(BOOL)preventHSTSStorage
  • (void)_setIgnoreHSTS:(BOOL)ignoreHSTS

Source/WebKit:

  • NetworkProcess/cocoa/NetworkSessionCocoa.mm:

(downgradeRequest):

Convenience function to downgrade a request if
CFNetwork as already upgraded it during
canonicalization. This allows the rest of
WebKit's processing to function, such as UIR
and mixed content blocking.

(updateIgnoreStrictTransportSecuritySettingIfNecessary):

Adds and removed the ignore request accordingly.

(-[WKNetworkSessionDelegate URLSession:task:willPerformHTTPRedirection:newRequest:completionHandler:]):

Now asks CFNetwork to ignore HSTS on resource loads we
partition cookies for.

(-[WKNetworkSessionDelegate URLSession:task:_schemeUpgraded:completionHandler:]):

Now asks CFNetwork to ignore HSTS on resource loads we
partition cookies for.

11:01 AM Changeset in webkit [224697] by commit-queue@webkit.org
  • 3 edits in trunk/LayoutTests

Fix race conditions with setBackingScaleFactor, page refresh and preloader
​https://bugs.webkit.org/show_bug.cgi?id=179488

Patch by Colin Bendell <colin> on 2017-11-10
Reviewed by Darin Adler.

  • http/tests/preload/picture-type-expected.txt: remove DPR test
  • http/tests/preload/picture-type.html: updated srcset to account for

testRunners with DPR > 1

10:45 AM Changeset in webkit [224696] by achristensen@apple.com
  • 4 edits in trunk

_WKThumbnailView initialization with WKWebView needs to call correct initWithFrame
​https://bugs.webkit.org/show_bug.cgi?id=179537
<rdar://problem/35275219>

Reviewed by Darin Adler.

Source/WebKit:

I introduced this in r223439 and made an ObjC mistake. This is what I get for adding SPI with no tests.
I fixed this by making the existing WKView/_WKThumbnailView API tests work with WKWebView.

  • UIProcess/API/Cocoa/_WKThumbnailView.mm:

(-[_WKThumbnailView initWithFrame:fromWKWebView:]):

Tools:

  • TestWebKitAPI/Tests/WebKit/WKThumbnailView.mm:

(-[WKThumbnailViewDelegate webView:didFinishNavigation:]):
(TestWebKitAPI::TEST):

10:30 AM Changeset in webkit [224695] by Jonathan Bedard
  • 4 edits in trunk/Tools

webkitpy: Remove find_system_pid from port classes
​https://bugs.webkit.org/show_bug.cgi?id=179514
<rdar://problem/35456900>

Reviewed by David Kilzer.

Removing dead code.

  • Scripts/webkitpy/port/base.py:

(Port.find_system_pid): Deleted.

  • Scripts/webkitpy/port/server_process.py:

(ServerProcess._start):

  • Scripts/webkitpy/port/win.py:

(WinPort.find_system_pid): Deleted.

10:06 AM Changeset in webkit [224694] by matthew_hanson@apple.com
  • 10 edits
    1 add in tags/Safari-605.1.13.1

Cherry-pick r224687. rdar://problem/35445245

10:02 AM Changeset in webkit [224693] by matthew_hanson@apple.com
  • 7 edits in tags/Safari-605.1.13.1/Source

Versioning.

9:59 AM Changeset in webkit [224692] by matthew_hanson@apple.com
  • 1 copy in tags/Safari-605.1.13.1

New tag.

9:46 AM Changeset in webkit [224691] by aakash_jain@apple.com
  • 4 edits in trunk/Tools

fix style failures in webkitpy: multiple statements on one line (semicolon)
​https://bugs.webkit.org/show_bug.cgi?id=179530

Reviewed by Alex Christensen.

  • Scripts/webkitpy/common/net/buildbot/buildbot.py: Removed semicolon.
  • Scripts/webkitpy/layout_tests/controllers/test_result_writer.py: Ditto.
  • Scripts/webkitpy/tool/steps/runtests.py: Ditto.
9:44 AM Changeset in webkit [224690] by Ryan Haddad
  • 2 edits in trunk/LayoutTests

Mark http/wpt/beacon/contentextensions tests as flaky.
​https://bugs.webkit.org/show_bug.cgi?id=179256

Unreviewed test gardening.

  • platform/mac-wk2/TestExpectations:
9:39 AM Changeset in webkit [224689] by rmorisset@apple.com
  • 6 edits in trunk/Source/JavaScriptCore

The memory consumption of DFG::BasicBlock can be easily reduced a bit
​https://bugs.webkit.org/show_bug.cgi?id=179528

Reviewed by Saam Barati.

A few changes here:

  • Reordering some fields of DFG::BasicBlock to reduce padding
  • Making the enum fields that are glorified booleans fit into a u8
  • Make each Operands object have a single vector that holds all arguments followed by all locals, instead of two vectors. This change works because we never increase the number of arguments after allocating an Operands object. It lets us avoid one extra capacity field and one extra pointer field per Operands, and more importantly one allocation per Operands whenever both vectors would have overflowed their inlined buffer. Additionally, if a single vector would have overflowed its inline buffer, while the other would have had some free space, we have a chance to avoid an allocation.
  • Finally, the three methods argumentForIndex, variableForIndex and indexForOperand were deleted since they were dead code.
  • bytecode/Operands.h:

(JSC::Operands::Operands):
(JSC::Operands::numberOfArguments const):
(JSC::Operands::numberOfLocals const):
(JSC::Operands::argument):
(JSC::Operands::argument const):
(JSC::Operands::local):
(JSC::Operands::local const):
(JSC::Operands::ensureLocals):
(JSC::Operands::setLocal):
(JSC::Operands::getLocal):
(JSC::Operands::setArgumentFirstTime):
(JSC::Operands::setLocalFirstTime):
(JSC::Operands::operand):
(JSC::Operands::setOperand):
(JSC::Operands::size const):
(JSC::Operands::at const):
(JSC::Operands::at):
(JSC::Operands::isArgument const):
(JSC::Operands::isVariable const):
(JSC::Operands::virtualRegisterForIndex const):
(JSC::Operands::fill):
(JSC::Operands::operator== const):
(JSC::Operands::argumentForIndex const): Deleted.
(JSC::Operands::variableForIndex const): Deleted.
(JSC::Operands::indexForOperand const): Deleted.

  • dfg/DFGBasicBlock.cpp:

(JSC::DFG::BasicBlock::BasicBlock):

  • dfg/DFGBasicBlock.h:
  • dfg/DFGBranchDirection.h:
  • dfg/DFGStructureClobberState.h:
9:39 AM Changeset in webkit [224688] by aakash_jain@apple.com
  • 8 edits in trunk/Tools

fix style failures in webkitpy: expected 2 blank lines found 1
​https://bugs.webkit.org/show_bug.cgi?id=179529

Reviewed by Alex Christensen.

  • Scripts/webkitpy/benchmark_runner/run_benchmark.py: Added a blank line to follow style guidelines.
  • Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py: Ditto.
  • Scripts/webkitpy/common/system/platforminfo_mock.py: Ditto.
  • Scripts/webkitpy/common/version.py: Ditto.
  • Scripts/webkitpy/layout_tests/models/test_failures.py: Ditto.
  • Scripts/webkitpy/port/mac_unittest.py: Ditto.
  • Scripts/webkitpy/port/simulator_process.py: Ditto.
9:30 AM Changeset in webkit [224687] by achristensen@apple.com
  • 10 edits
    1 add in trunk

REGRESSION(r224267): WebViews scheduled with custom run loop modes don't load
​https://bugs.webkit.org/show_bug.cgi?id=179515
Source/WebCore:

<rdar://problem/35445245>

Reviewed by Andy Estes.

Covered by a new API test which would have timed out without this change.

  • platform/network/mac/WebCoreResourceHandleAsOperationQueueDelegate.mm:

(schedulePairHashSet):
Collect run loop modes from the NetworkingContext similarly to how we did before ​https://trac.webkit.org/changeset/224267/webkit#file40
(-[WebCoreResourceHandleAsOperationQueueDelegate connection:willSendRequest:redirectResponse:]):
(-[WebCoreResourceHandleAsOperationQueueDelegate connection:didReceiveAuthenticationChallenge:]):
(-[WebCoreResourceHandleAsOperationQueueDelegate connection:canAuthenticateAgainstProtectionSpace:]):
(-[WebCoreResourceHandleAsOperationQueueDelegate connection:didReceiveResponse:]):
(-[WebCoreResourceHandleAsOperationQueueDelegate connection:didReceiveData:lengthReceived:]):
(-[WebCoreResourceHandleAsOperationQueueDelegate connection:didSendBodyData:totalBytesWritten:totalBytesExpectedToWrite:]):
(-[WebCoreResourceHandleAsOperationQueueDelegate connectionDidFinishLoading:]):
(-[WebCoreResourceHandleAsOperationQueueDelegate connection:didFailWithError:]):
(-[WebCoreResourceHandleAsOperationQueueDelegate connection:willCacheResponse:]):

Source/WTF:

<rdar://problem/35445245>

Reviewed by Andy Estes.

  • wtf/MainThread.cpp:

(WTF::callOnMainThread):

  • wtf/MainThread.h:

(WTF::callOnMainThread):
(WTF::scheduleDispatchFunctionsOnMainThread):

  • wtf/generic/MainThreadGeneric.cpp:

(WTF::scheduleDispatchFunctionsOnMainThread):

  • wtf/mac/MainThreadMac.mm:

(WTF::scheduleDispatchFunctionsOnMainThread):

  • wtf/win/MainThreadWin.cpp:

(WTF::scheduleDispatchFunctionsOnMainThread):
Add an optional parameter which is an array of run loop mode names to pass to performSelectorOnMainThread.

Tools:

Reviewed by Andy Estes.

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/Tests/mac/WebViewScheduleInRunLoop.mm: Added.

(-[ScheduleInRunLoopDelegate webView:didFinishLoadForFrame:]):
(TestWebKitAPI::TEST):

9:23 AM Changeset in webkit [224686] by Chris Dumez
  • 4 edits in trunk/Source/WebCore

Simplify SWServerRegistration::forEachConnection()
​https://bugs.webkit.org/show_bug.cgi?id=179523

Reviewed by Alex Christensen.

Simplify SWServerRegistration::forEachConnection() by dropping the hack
introduced in r224590 to work around the fact that we had a race
between Storage & WebProcess processes during registration. After
r224652, we do an IPC handshake between those 2 processes after
resolving the registration promise so we know for sure the
ServiceWorkerRegistration object has registered itself with the
Storage process before we keep going with the install steps.

No new tests, no expected Web-facing behavior change.

  • workers/service/server/SWServerJobQueue.cpp:

(WebCore::SWServerJobQueue::scriptFetchFinished):
(WebCore::SWServerJobQueue::install):
(WebCore::SWServerJobQueue::didResolveRegistrationPromise):
(WebCore::SWServerJobQueue::didFinishInstall):
(WebCore::SWServerJobQueue::runRegisterJob):
(WebCore::SWServerJobQueue::runUnregisterJob):

  • workers/service/server/SWServerRegistration.cpp:

(WebCore::SWServerRegistration::updateRegistrationState):
(WebCore::SWServerRegistration::updateWorkerState):
(WebCore::SWServerRegistration::fireUpdateFoundEvent):
(WebCore::SWServerRegistration::forEachConnection):

  • workers/service/server/SWServerRegistration.h:
9:02 AM Changeset in webkit [224685] by Jonathan Bedard
  • 2 edits in trunk/Tools

[webkitpy] Fix PlatformInfo._win_version since r224657
​https://bugs.webkit.org/show_bug.cgi?id=179520

Patch by Fujii Hironori <Fujii Hironori> on 2017-11-10
Reviewed by Aakash Jain.

There are two problems.

The return value of sys.getwindowsversion() doesn't match with
Version.init expects. Truncate the 4th and 5th of it.

_win_version_tuple_from_cmd was deleted in r224657. But, it is
still needed for Cygwin Python.

  • Scripts/webkitpy/common/system/platforminfo.py:

(PlatformInfo._win_version): Return [0:3] of getwindowsversion().
Call _win_version_from_cmd for Cygwin Python.
(PlatformInfo._win_version_from_cmd): Restored.

8:41 AM Changeset in webkit [224684] by Ms2ger@igalia.com
  • 9 edits
    2 deletes in trunk

LayoutTests/imported/w3c:
Allow XHR to override the User-Agent header.
​https://bugs.webkit.org/show_bug.cgi?id=179527

Reviewed by Chris Dumez.

  • web-platform-tests/XMLHttpRequest/setrequestheader-header-allowed-expected.txt: update expectation.

Source/WebCore:
Allow XHR to override the User-Agent header.
​https://bugs.webkit.org/show_bug.cgi?id=179527

Reviewed by Chris Dumez.

Also rename FrameLoader::applyUserAgent to FrameLoader::applyUserAgentIfNeeded
for clarity.

Test: imported/w3c/web-platform-tests/XMLHttpRequest/setrequestheader-header-allowed.htm

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::addExtraFieldsToRequest):
(WebCore::FrameLoader::applyUserAgentIfNeeded):

  • loader/FrameLoader.h:
  • loader/ResourceLoadNotifier.cpp:

(WebCore::ResourceLoadNotifier::willSendRequest):

  • loader/appcache/ApplicationCacheGroup.cpp:

(WebCore::ApplicationCacheGroup::createResourceHandle):

  • loader/cache/CachedResourceRequest.cpp:

(WebCore::CachedResourceRequest::updateReferrerOriginAndUserAgentHeaders):

LayoutTests:
Remove check-combining-headers.html.
​https://bugs.webkit.org/show_bug.cgi?id=179527

Reviewed by Chris Dumez.

This test is an old fork of
imported/w3c/web-platform-tests/XMLHttpRequest/setrequestheader-header-allowed.htm
which is no longer useful.

  • http/tests/xmlhttprequest/check-combining-headers-expected.txt: Removed.
  • http/tests/xmlhttprequest/check-combining-headers.html: Removed.
8:29 AM Changeset in webkit [224683] by guijemont@igalia.com
  • 2 edits in trunk/Tools

build-jsc: build testmasm for all platforms using cmake
​https://bugs.webkit.org/show_bug.cgi?id=179512

Reviewed by Michael Catanzaro.

  • Scripts/build-jsc:
8:25 AM Changeset in webkit [224682] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKitLegacy/mac

[iOS] Use new class name from UIKit when checking UITextSuggestion type for WebKitLegacy
​https://bugs.webkit.org/show_bug.cgi?id=179397

Patch by Frederik Riedel <​frederik.riedel@frogg.io> on 2017-11-10
Reviewed by Wenson Hsieh.

  • DOM/DOMHTMLInputElement.mm:

(-[DOMHTMLInputElement insertTextSuggestion:]):

7:43 AM Changeset in webkit [224681] by Ms2ger@igalia.com
  • 6 edits in trunk

Source/WebCore:
[GTK] Use fallible allocation in ImageBuffer::ImageBuffer().
​https://bugs.webkit.org/show_bug.cgi?id=179051

Reviewed by Michael Catanzaro.

Test: imported/w3c/web-platform-tests/2dcontext/imagebitmap/createImageBitmap-invalid-args.html

  • platform/graphics/cairo/ImageBufferCairo.cpp:

(WebCore::ImageBuffer::ImageBuffer):

Source/WTF:
Export tryFastZeroedMalloc.
​https://bugs.webkit.org/show_bug.cgi?id=179051

Reviewed by Michael Catanzaro.

The other functions were exported in bug 72855. There does not seem to be a
reason not to export this one.

  • wtf/FastMalloc.h:

LayoutTests:
[GTK] Update test expectations for imported/w3c/web-platform-tests/2dcontext/imagebitmap/createImageBitmap-invalid-args.html.
​https://bugs.webkit.org/show_bug.cgi?id=179051

Reviewed by Michael Catanzaro.

The expectations are platform-specific because the test times out on mac.
The difference with the mac expectations is only in the last part of the
test, after the timeout.

This follows our policy of creating -expected files with failures for
imported wpt tests, to allow using them as regression tests.

  • platform/gtk/imported/w3c/web-platform-tests/2dcontext/imagebitmap/createImageBitmap-invalid-args-expected.txt:
7:07 AM Changeset in webkit [224680] by Chris Dumez
  • 2 edits in trunk/LayoutTests

Unreviewed, mark imported/w3c/web-platform-tests/service-workers/service-worker/unregister-then-register-new-script.https.html as flaky

I unskipped it yesterday but it turns out to be flaky.

5:36 AM Changeset in webkit [224679] by Carlos Garcia Campos
  • 1 copy in releases/WebKitGTK/webkit-2.18.3

WebKitGTK+ 2.18.3

5:34 AM Changeset in webkit [224678] by Carlos Garcia Campos
  • 4 edits in releases/WebKitGTK/webkit-2.18

Unreviewed. Update OptionsGTK.cmake and NEWS for 2.18.3 release.

5:03 AM Changeset in webkit [224677] by Carlos Garcia Campos
  • 22 edits
    2 moves
    2 deletes in trunk/Source/WebKit

[GTK][WPE] Switch to use API::NavigationClient
​https://bugs.webkit.org/show_bug.cgi?id=178720

Reviewed by Alex Christensen.

Replace WebKitLoaderClient and WebKitPolicyClient with WebKitNavigationClient that implements
API::NavigationClient.

  • PlatformGTK.cmake:
  • PlatformWPE.cmake:
  • UIProcess/API/APINavigationAction.h: Add new constructor that receives a target frame name instead of a target

frame info.

  • UIProcess/API/APINavigationClient.h:

(API::NavigationClient::didDisplayInsecureContent): Added.
(API::NavigationClient::didRunInsecureContent): Added.
(API::NavigationClient::decidePolicyForNavigationResponse): Change NavigationResponse parameter to be a
Ref<NavigationResponse>&& instead of a NavigationResponse&.

  • UIProcess/API/C/WKPage.cpp:

(WKPageSetPageNavigationClient): Update NavigationResponse parameter.

  • UIProcess/API/glib/WebKitBackForwardList.cpp:

(webkitBackForwardListChanged):

  • UIProcess/API/glib/WebKitBackForwardListPrivate.h:
  • UIProcess/API/glib/WebKitNavigationAction.cpp:

(webkitNavigationActionCreate): Wrap the given API::NavigationAction.
(webkit_navigation_action_get_navigation_type): Use the wrapped API::NavigationAction.
(webkit_navigation_action_get_mouse_button): Ditto.
(webkit_navigation_action_get_modifiers): Ditto.
(webkit_navigation_action_get_request): Ditto.
(webkit_navigation_action_is_user_gesture): Ditto.
(webkit_navigation_action_is_redirect): Ditto.

  • UIProcess/API/glib/WebKitNavigationActionPrivate.h:

(_WebKitNavigationAction::_WebKitNavigationAction):

  • UIProcess/API/glib/WebKitNavigationClient.cpp: Renamed from Source/WebKit/UIProcess/API/glib/WebKitLoaderClient.cpp.

(NavigationClient::NavigationClient):
(attachNavigationClientToView):

  • UIProcess/API/glib/WebKitNavigationClient.h: Renamed from Source/WebKit/UIProcess/API/glib/WebKitLoaderClient.h.
  • UIProcess/API/glib/WebKitNavigationPolicyDecision.cpp:

(webkit_navigation_policy_decision_get_frame_name): Add FIXME.
(webkitNavigationPolicyDecisionCreate): Get the target frame name from the API::NavigationAction.

  • UIProcess/API/glib/WebKitNavigationPolicyDecisionPrivate.h:
  • UIProcess/API/glib/WebKitPolicyClient.cpp: Removed.
  • UIProcess/API/glib/WebKitPolicyClient.h: Removed.
  • UIProcess/API/glib/WebKitPolicyDecision.cpp:

(webkitPolicyDecisionSetListener): Remove the madePolicyDecision boolean member, we can null-check the listener instead.
(webkit_policy_decision_use): Ensure listener is nullptr after being invoked to prevent the decision from being made
more than once.
(webkit_policy_decision_ignore): Ditto.
(webkit_policy_decision_download): Ditto.

  • UIProcess/API/glib/WebKitPolicyDecisionPrivate.h:
  • UIProcess/API/glib/WebKitResponsePolicyDecision.cpp:

(webkit_response_policy_decision_get_request): Use the wrapped API::NavigationResponse.
(webkit_response_policy_decision_get_response): Ditto.
(webkit_response_policy_decision_is_mime_type_supported): Ditto.
(webkitResponsePolicyDecisionCreate): Wrap the given API::NavigationResponse.

  • UIProcess/API/glib/WebKitResponsePolicyDecisionPrivate.h:
  • UIProcess/API/glib/WebKitUIClient.cpp:

(UIClient::createNewPage): Create the WebKitNavigationAction from a new API::NavigationAction.

  • UIProcess/API/glib/WebKitWebView.cpp:

(webkitWebViewConstructed): Attach navigation client.

  • UIProcess/Cocoa/NavigationState.h: Update API::NavigationResponse parameter of decidePolicyForNavigationResponse.
  • UIProcess/Cocoa/NavigationState.mm:

(WebKit::NavigationState::NavigationClient::decidePolicyForNavigationResponse):

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::didDisplayInsecureContentForFrame): Notify the navigation client if it's used.
(WebKit::WebPageProxy::didRunInsecureContentForFrame): Ditto.
(WebKit::WebPageProxy::decidePolicyForNewWindowAction): Use the new API::NavigationAction constructor to pass
the target frame name, instead of a null target frame info.
(WebKit::WebPageProxy::decidePolicyForResponse): Move the API::NavigationResponse.

3:26 AM Changeset in webkit [224676] by Carlos Garcia Campos
  • 3 edits in releases/WebKitGTK/webkit-2.18/Source/WebDriver

Merge r224668 - WebDriver: WebDriverService::matchCapabilities should follow the spec
​https://bugs.webkit.org/show_bug.cgi?id=179371

Reviewed by Brian Burg.

The returned object should contain all the entries mentioned in the spec, not only the ones already present in
the passed in capabilities object.

7.2 Processing Capabilities
​https://w3c.github.io/webdriver/webdriver-spec.html#dfn-matching-capabilities

  • WebDriverService.cpp:

(WebDriver::WebDriverService::matchCapabilities const):
(WebDriver::WebDriverService::processCapabilities const):

  • WebDriverService.h:
3:26 AM Changeset in webkit [224675] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.18/Source/WebDriver

Merge r224667 - WebDriver: capabilities with null value shouldn't be added to the validated capabilities object
​https://bugs.webkit.org/show_bug.cgi?id=179369

Reviewed by Brian Burg.

"4. If deserialized is not null, set a property on result with name name and value deserialized."

7.2 Processing Capabilities
​https://w3c.github.io/webdriver/webdriver-spec.html#dfn-validate-capabilities

Fixes: imported/w3c/webdriver/tests/sessions/new_session/create_firstMatch.py::test_valid[platformName-None]

  • WebDriverService.cpp:

(WebDriver::WebDriverService::validatedCapabilities const):

3:15 AM Changeset in webkit [224674] by Carlos Garcia Campos
  • 2982 edits
    315 adds in releases/WebKitGTK/webkit-2.18/LayoutTests

Unreviewed GTK+ gardening. Rebaseline tests after r224572 and r224573. Part 3.

2:50 AM Changeset in webkit [224673] by Carlos Garcia Campos
  • 3572 edits
    1 copy
    5 adds in releases/WebKitGTK/webkit-2.18/LayoutTests

Unreviewed GTK+ gardening. Rebaseline tests after r224572 and r224573. Part 2.

2:19 AM Changeset in webkit [224672] by Carlos Garcia Campos
  • 4263 edits in releases/WebKitGTK/webkit-2.18

Unreviewed GTK+ gardening. Rebaseline tests after r224572 and r224573. Part 1.

12:51 AM Changeset in webkit [224671] by magomez@igalia.com
  • 2 edits in trunk/Source/WebCore

[GTK][WPE] CoordinatedGraphicsLayer::setNeedsDisplayInRect() converts FloatRect to IntRect erroneously
​https://bugs.webkit.org/show_bug.cgi?id=179476

Reviewed by Žan Doberšek.

Convert the passed FloatRect into an IntRect using enclosingIntRect(), so we are guaranteed that
the rectangle to paint fits into the buffer that the backingStore will allocate.

No behaviour change.

  • platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp:

(WebCore::CoordinatedGraphicsLayer::setNeedsDisplayInRect):

12:30 AM Changeset in webkit [224670] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

WebInjectedScriptHost.cpp: warning: variable ‘scope’ set but not used
​https://bugs.webkit.org/show_bug.cgi?id=179524

Patch by Fujii Hironori <Fujii Hironori> on 2017-11-10
Reviewed by Joseph Pecoraro.

r224606 has introduced a new compilation warning if not
ENABLE(PAYMENT_REQUEST).

No new tests (No behavior change).

  • inspector/WebInjectedScriptHost.cpp:

(WebCore::WebInjectedScriptHost::getInternalProperties): Do not
define the variable 'scope' if not ENABLE(PAYMENT_REQUEST). Marked
a variable 'vm' with UNUSED_PARAM.

12:18 AM Changeset in webkit [224669] by zandobersek@gmail.com
  • 3 edits
    2 adds in trunk/Source/WebCore

[Cairo] Start grouping Cairo GraphicsContext operations behind a separate interface
​https://bugs.webkit.org/show_bug.cgi?id=179467

Reviewed by Carlos Garcia Campos.

Start moving the Cairo operations in GraphicsContext into a separate
translation unit, CairoOperations.cpp. This will ease leveraging these
operations from a pre-recorded list of GraphicsContext commands, or
from a Cairo-specific GraphicsContextImpl, without undermining the
current GraphicsContext implementation that we'll want to maintain
in a working state until necessary.

We start with the clipping operations. Each operation is encapsulated
in a static function inside the WebCore::Cairo namespace that expects
PlatformContextCairo reference as the first argument, which makes sense
since we have to utilize the cairo_t state object that's kept there.
Other parameters are passed as well, as required for some specific
operation.

In the Cairo implementation of GraphicsContext, the affected methods
are changed to assert presence of the platform context (i.e. this is a
GraphicsContext that operates on a valid cairo_t object, and is not
using an m_impl object or is in non-painting mode) before the
PlatformContextCairo object is dereferenced and passed along with
other arguments to the Cairo::clip*() function.

No new tests -- no change in behavior.

  • platform/SourcesCairo.txt:
  • platform/graphics/cairo/CairoOperations.cpp: Added.

(WebCore::Cairo::clip):
(WebCore::Cairo::clipOut):
(WebCore::Cairo::clipPath):
(WebCore::Cairo::clipToImageBuffer):

  • platform/graphics/cairo/CairoOperations.h: Added.
  • platform/graphics/cairo/GraphicsContextCairo.cpp:

(WebCore::GraphicsContext::clip):
(WebCore::GraphicsContext::clipPath):
(WebCore::GraphicsContext::clipToImageBuffer):
(WebCore::GraphicsContext::clipOut):

Note: See TracTimeline for information about the timeline view.