⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Nov 12, 2017:

11:54 PM Changeset in webkit [224747] by mjs@apple.com
  • 6 edits
    2 adds
    20 deletes in trunk

Remove support for UTF-32 variant text encodings
​https://bugs.webkit.org/show_bug.cgi?id=179435

Reviewed by Darin Adler.

LayoutTests/imported/w3c:

  • web-platform-tests/encoding/unsupported-encodings-expected.txt: Update results now

that UTF-32 support is gone. Still not quite right since we don't sniff UTF-32LE as
UTF-16LE yet.

  • web-platform-tests/encoding/utf-32-expected.txt: ditto

Source/WebCore:

Non-support for these encodings is covered by WPT tests.

  • platform/text/TextCodecICU.cpp: Remove UTF-32 variants.

Technically, we should also ensure that UTF-32LE with a BOM
gets sniffed as UTF-16LE instead of windows-1252. Chrome
does this but Firefox doesn't yet. WPT tests cover it, and
we can fix it later.

LayoutTests:

  • fast/encoding/legacy-utf-32-aliases.html: Added. Check that

we don't support our legacy aliases for utf-32, since WPT doesn't
either.

  • fast/encoding/legacy-utf-32-aliases-expected.txt: Ditto.

Remove the following tests; we no longer want to support UTF-32.

imported/w3c/web-platform-tests/encoding already has tests for lack of support.

  • fast/encoding/utf-32-big-endian-bom-expected.txt: Removed.
  • fast/encoding/utf-32-big-endian-bom.html: Removed.
  • fast/encoding/utf-32-big-endian-nobom-expected.txt: Removed.
  • fast/encoding/utf-32-big-endian-nobom.xml: Removed.
  • fast/encoding/utf-32-little-endian-bom-expected.txt: Removed.
  • fast/encoding/utf-32-little-endian-bom.html: Removed.
  • fast/encoding/utf-32-little-endian-nobom-expected.txt: Removed.
  • fast/encoding/utf-32-little-endian-nobom.xml: Removed.
  • http/tests/misc/submit-get-in-utf32be-expected.txt: Removed.
  • http/tests/misc/submit-get-in-utf32be.html: Removed.
  • http/tests/misc/submit-get-in-utf32le-expected.txt: Removed.
  • http/tests/misc/submit-get-in-utf32le.html: Removed.
  • http/tests/misc/submit-post-in-utf32be-expected.txt: Removed.
  • http/tests/misc/submit-post-in-utf32be.html: Removed.
  • http/tests/misc/submit-post-in-utf32le-expected.txt: Removed.
  • http/tests/misc/submit-post-in-utf32le.html: Removed.
  • http/tests/misc/url-in-utf32be-expected.txt: Removed.
  • http/tests/misc/url-in-utf32be.html: Removed.
  • http/tests/misc/url-in-utf32le-expected.txt: Removed.
  • http/tests/misc/url-in-utf32le.html: Removed.
11:43 PM Changeset in webkit [224746] by zandobersek@gmail.com
  • 5 edits in trunk/Source/WebCore

[Cairo] Move rectangle and path filling, stroking, clearing operations in GraphicsContextCairo to CairoOperations
​https://bugs.webkit.org/show_bug.cgi?id=179599

Reviewed by Carlos Garcia Campos.

Move operations that perform filling, stroking and clearing for
specified rectangles and paths to the CairoOperations file. This limits
operations to only work with a PlatformContextCairo object, along with
any required parameter, and will help with future work in this area.

Helper functions are copied along for the time being, but will later be
removed from the GraphicsContextCairo implementation file.

No new tests -- no change in behavior.

  • platform/graphics/cairo/CairoOperations.cpp:

(WebCore::Cairo::fillRectWithColor):
(WebCore::Cairo::drawPathShadow):
(WebCore::Cairo::fillCurrentCairoPath):
(WebCore::Cairo::fillRect):
(WebCore::Cairo::fillRoundedRect):
(WebCore::Cairo::fillRectWithRoundedHole):
(WebCore::Cairo::fillPath):
(WebCore::Cairo::strokeRect):
(WebCore::Cairo::strokePath):
(WebCore::Cairo::clearRect):

  • platform/graphics/cairo/CairoOperations.h:
  • platform/graphics/cairo/GradientCairo.cpp:

(WebCore::Gradient::fill):

  • platform/graphics/cairo/GraphicsContextCairo.cpp:

(WebCore::GraphicsContext::fillPath):
(WebCore::GraphicsContext::strokePath):
(WebCore::GraphicsContext::fillRect):
(WebCore::GraphicsContext::clearRect):
(WebCore::GraphicsContext::strokeRect):
(WebCore::GraphicsContext::platformFillRoundedRect):
(WebCore::GraphicsContext::fillRectWithRoundedHole):

11:41 PM Changeset in webkit [224745] by Carlos Garcia Campos
  • 4 edits in trunk

REGRESSION(r224566): [GTK] 26 new timeouts on inspector related tests.
​https://bugs.webkit.org/show_bug.cgi?id=179471

Reviewed by Darin Adler.

Source/WebInspectorUI:

TestStub.html and TestStub.js was missing in resources bundle.

  • Scripts/copy-user-interface-resources.pl: Also combine resources for TestStub.

LayoutTests:

Unskip tests that are passing now.

  • platform/gtk/TestExpectations:
11:37 PM Changeset in webkit [224744] by zandobersek@gmail.com
  • 4 edits in trunk/Source/WebCore

[Cairo] Move state stack, CTM, transparency layer operations in GraphicsContextCairo to CairoOperations
​https://bugs.webkit.org/show_bug.cgi?id=179598

Reviewed by Carlos Garcia Campos.

Move operations that save and restore state, adjust CTM and modify the
transparency layer stack to the CairoOperations file. This limits
operations to only work with a PlatformContextCairo object, along with
any required parameter, and will help with future work in this area.

No new tests -- no change in behavior.

  • platform/graphics/cairo/CairoOperations.cpp:

(WebCore::Cairo::save):
(WebCore::Cairo::restore):
(WebCore::Cairo::translate):
(WebCore::Cairo::rotate):
(WebCore::Cairo::scale):
(WebCore::Cairo::concatCTM):
(WebCore::Cairo::beginTransparencyLayer):
(WebCore::Cairo::endTransparencyLayer):

  • platform/graphics/cairo/CairoOperations.h:
  • platform/graphics/cairo/GraphicsContextCairo.cpp:

(WebCore::GraphicsContext::savePlatformState):
(WebCore::GraphicsContext::restorePlatformState):
(WebCore::GraphicsContext::translate):
(WebCore::GraphicsContext::concatCTM):
(WebCore::GraphicsContext::beginPlatformTransparencyLayer):
(WebCore::GraphicsContext::endPlatformTransparencyLayer):
(WebCore::GraphicsContext::rotate):
(WebCore::GraphicsContext::scale):

11:32 PM Changeset in webkit [224743] by zandobersek@gmail.com
  • 4 edits in trunk/Source/WebCore

[Cairo] Move line, miter operations in GraphicsContextCairo to CairoOperations
​https://bugs.webkit.org/show_bug.cgi?id=179597

Reviewed by Carlos Garcia Campos.

Move operations that adjust line cap, line dash, line join and miter
limit to the CairoOperations file. This limits operations to only work
with a PlatformContextCairo object, along with any required parameter,
and will help with future work in this area.

No new tests -- no change in behavior.

  • platform/graphics/cairo/CairoOperations.cpp:

(WebCore::Cairo::setLineCap):
(WebCore::Cairo::setLineDash):
(WebCore::Cairo::setLineJoin):
(WebCore::Cairo::setMiterLimit):

  • platform/graphics/cairo/CairoOperations.h:
  • platform/graphics/cairo/GraphicsContextCairo.cpp:

(WebCore::GraphicsContext::setLineCap):
(WebCore::GraphicsContext::setLineDash):
(WebCore::GraphicsContext::setLineJoin):
(WebCore::GraphicsContext::setMiterLimit):
(WebCore::isDashArrayAllZero): Deleted.

10:54 PM Changeset in webkit [224742] by jonlee@apple.com
  • 3 edits
    2 copies
    2 moves
    3 adds in trunk/PerformanceTests

Add isolated text tests for MotionMark
​https://bugs.webkit.org/show_bug.cgi?id=179226

Reviewed by Darin Adler.

Add a private suite that simplifies the design test.

  • MotionMark/resources/debug-runner/tests.js:
  • MotionMark/resources/runner/tests.js:
  • MotionMark/tests/master/design.html: Copied from PerformanceTests/MotionMark/tests/master/text.html.

Rename the html file to the title of the test.

  • MotionMark/tests/master/resources/design.js: Renamed from PerformanceTests/MotionMark/tests/master/resources/text.js.
  • MotionMark/tests/text/design-6.html: Copied from PerformanceTests/MotionMark/tests/master/text.html.

Six active cells

  • MotionMark/tests/text/design-6.js: Added.
  • MotionMark/tests/text/design.html: Renamed from PerformanceTests/MotionMark/tests/master/text.html.

Replace the text with empty table cells that are populated with desired text.

  • MotionMark/tests/text/design.js: Added.
10:39 PM Changeset in webkit [224741] by Chris Dumez
  • 2 edits in trunk/Source/WebCore

[Service Workers] Activate algorithm says terminate the active worker if it exists
​https://bugs.webkit.org/show_bug.cgi?id=179559

Reviewed by Darin Adler.

Activate algorithm says terminate the active worker if it exists:

No new tests, no-op for now as the terminate() function is not implemented
yet.

  • workers/service/server/SWServerJobQueue.cpp:

(WebCore::SWServerJobQueue::activate):

10:12 PM Changeset in webkit [224740] by Darin Adler
  • 58 edits in trunk/Source

More is<> and downcast<>, less static_cast<>
​https://bugs.webkit.org/show_bug.cgi?id=179600

Reviewed by Chris Dumez.

Source/JavaScriptCore:

  • runtime/JSString.h:

(JSC::jsSubstring): Removed unneeded static_cast; length already returns unsigned.
(JSC::jsSubstringOfResolved): Ditto.

Source/WebCore:

  • Modules/fetch/FetchBody.cpp:

(WebCore::FetchBody::extract): Use downcast instead of static_cast.
(WebCore::FetchBody::bodyAsFormData const): Ditto.

  • Modules/indexeddb/IDBObjectStore.cpp:

(WebCore::IDBObjectStore::putOrAdd): Ditto.

  • Modules/mediastream/CanvasCaptureMediaStreamTrack.cpp:

(WebCore::CanvasCaptureMediaStreamTrack::Source::canvasChanged): Ditto.

  • Modules/mediastream/libwebrtc/LibWebRTCPeerConnectionBackend.cpp:

(WebCore::libWebRTCProvider): Ditto.

  • accessibility/AccessibilityMediaControls.cpp:

(WebCore::AccessibilityMediaTimeDisplay::stringValue const): Got rid of local
variable and used std::abs instead of fabsf. Did not use downcast here because
it doesn't exist for this class.

  • bindings/js/JSEventTargetCustom.h:

(WebCore::IDLOperation<JSEventTarget>::call): Use downcast instead of toDOMWindow.

  • dom/DocumentEventQueue.cpp:

(WebCore::DocumentEventQueue::dispatchEvent): Ditto.

  • dom/Element.h: Added is/downcast for EventTarget.
  • dom/EventContext.cpp:

(WebCore::TouchEventContext::checkReachability const): Use downcast instead
of toNode.

  • dom/EventContext.h:

(WebCore::EventContext::isUnreachableNode const): Ditto.

  • dom/EventPath.cpp:

(WebCore::shouldEventCrossShadowBoundary): Ditto.
(WebCore::EventPath::setRelatedTarget): Ditto.
(WebCore::EventPath::retargetTouch): Ditto.
(WebCore::EventPath::EventPath): Ditto.

  • dom/EventTarget.cpp:

(WebCore::EventTarget::toNode): Deleted.
(WebCore::EventTarget::isNode const): Added.
(WebCore::EventTarget::toDOMWindow): Deleted.
(WebCore::EventTarget::isMessagePort const): Deleted. This was not used.
(WebCore::EventTarget::addEventListener): Use downcast instead of toDOMWindow
and toNode.

  • dom/EventTarget.h: Updated for the above.
  • dom/MessagePort.h: Deleted unused isMessagePort.
  • dom/MouseEvent.cpp:

(WebCore::MouseEvent::toElement const): Use downcast instead of toNode.
Also refactored to make function a little smaller.
(WebCore::MouseEvent::fromElement const): Ditto.

  • dom/MouseRelatedEvent.cpp:

(WebCore::MouseRelatedEvent::computeRelativePosition): Use downcast
instead of toNode.

  • dom/Node.cpp:

(WebCore::Node::isNode const): Added.
(WebCore::Node::toNode): Deleted.

  • dom/Node.h: Updated for the above. Also added SPECIALIZE_TYPE_TRAITS

so we can do is/downcast.

  • dom/ScopedEventQueue.cpp:

(WebCore::ScopedEventQueue::enqueueEvent): Use is instead of toNode.
(WebCore::ScopedEventQueue::dispatchEvent const): Use downcast instead of toNode.

  • dom/make_names.pl:

(printTypeHelpers): Added support for is/downcast from EventTarget.

  • editing/Editor.cpp:

(WebCore::Editor::selectionForCommand): Use is/downcast instead of toNode.

  • editing/EditorCommand.cpp:

(WebCore::targetFrame): Ditto.

  • html/HTMLAnchorElement.cpp:

(WebCore::appendServerMapMousePosition): Ditto.

  • html/HTMLCanvasElement.cpp:

(WebCore::HTMLCanvasElement::createContextWebGL): Use downcast instead of
static_cast.
(WebCore::HTMLCanvasElement::getContextWebGL): Ditto.
(WebCore::HTMLCanvasElement::getImageData): Ditto.

  • html/HTMLElement.h: Added support for is/downcast from EventTarget.
  • html/HTMLFormElement.cpp:

(WebCore::HTMLFormElement::handleLocalEvents): Use is instead of toNode.
(WebCore::submitElementFromEvent): Deleted. Was a duplicate of findSubmitButton.
(WebCore::HTMLFormElement::prepareForSubmission): Rewrote code that calls
submitElementFromEvent to call findSubmitButton instead. Also don't bother
finding the submit button unless we are going to validate, since all we do
after finding it is reconsider whether we should validate.
(WebCore::HTMLFormElement::findSubmitButton const): Rewrote to use is,
downcast, and lineageOfType rather than a handwritten loop and toNode.
Relies on the fact that the target is an element, never a text node.

  • html/HTMLLabelElement.cpp:

(WebCore::HTMLLabelElement::defaultEventHandler): Use is and downcast instead
of toNode.

  • html/HTMLPlugInImageElement.cpp:

(WebCore::HTMLPlugInImageElement::partOfSnapshotOverlay const): Changed argument
type to EventTarget so we can do the type checking and casting here instead of at
each of the callers.

  • html/HTMLPlugInImageElement.h: Updated for the above.
  • html/HTMLSummaryElement.cpp:

(WebCore::isClickableControl): Changed argument type to EventTarget so we can do
the type checking and casting here instead of at each of the callers.
(WebCore::HTMLSummaryElement::defaultEventHandler): Removed call to toNode.

  • html/HTMLTextFormControlElement.h: Added support for is/downcast from EventTarget.
  • html/MediaDocument.cpp:

(WebCore::MediaDocument::defaultEventHandler): Use is/downcast instead of toNode.

  • html/RangeInputType.cpp:

(WebCore::RangeInputType::handleMouseDownEvent): Ditto.

  • html/shadow/MediaControlElements.cpp:

(WebCore::MediaControlVolumeSliderContainerElement::defaultEventHandler): Ditto.
(WebCore::MediaControlClosedCaptionsTrackListElement::defaultEventHandler): Ditto.
Also use get instead of find/end.

  • html/shadow/MediaControls.cpp:

(WebCore::MediaControls::containsRelatedTarget): Use is/downcast instead of toNode.

  • inspector/InspectorFrontendHost.cpp:

(WebCore::InspectorFrontendHost::dispatchEventAsContextMenuEvent): Ditto.

  • inspector/agents/InspectorDOMAgent.cpp:

(WebCore::InspectorDOMAgent::didAddEventListener): Ditto.
(WebCore::InspectorDOMAgent::willRemoveEventListener): Ditto.

  • page/ContextMenuController.cpp:

(WebCore::ContextMenuController::maybeCreateContextMenu): Ditto.

  • page/DOMWindow.cpp:

(WebCore::DOMWindow::toDOMWindow): Deleted.

  • page/DOMWindow.h: Updated for the above. Also added SPECIALIZE_TYPE_TRAITS

so we can do is/downcast.

  • page/EventHandler.cpp:

(WebCore::EventHandler::handleTouchEvent): Use is/downcast instead of toNode.

  • platform/graphics/WidthCache.h:

(WebCore::WidthCache::add): Removed unneeded static_cast; length already returns unsigned.

  • rendering/RenderSnapshottedPlugIn.cpp:

(WebCore::RenderSnapshottedPlugIn::handleEvent): Removed unneeded toNode now that
partOfSnapshotOverlay takes an EventTarget.

Source/WebKit:

  • WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMPrivate.cpp:

(WebKit::wrap): Use is/downcast.

  • WebProcess/WebCoreSupport/gtk/WebEditorClientGtk.cpp:

(WebKit::WebEditorClient::handleKeyboardEvent): Ditto.

  • WebProcess/WebCoreSupport/wpe/WebEditorClientWPE.cpp:

(WebKit::WebEditorClient::handleKeyboardEvent): Ditto.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::handleEditingKeyboardEvent): Ditto.

  • WebProcess/WebPage/mac/WebPageMac.mm:

(WebKit::frameForEvent): Ditto.

Source/WebKitLegacy/mac:

  • DOM/DOM.mm:

(kit): Use is/downcast.

  • WebCoreSupport/WebEditorClient.mm:

(WebEditorClient::handleKeyboardEvent): Ditto.
(WebEditorClient::handleInputMethodKeydown): Ditto.

  • WebView/WebHTMLView.mm:

(-[WebHTMLView _interpretKeyEvent:savingCommands:]): Ditto.

Source/WebKitLegacy/win:

  • WebView.cpp:

(WebView::handleEditingKeyboardEvent): Use downcast.

4:27 PM Changeset in webkit [224739] by matthew_hanson@apple.com
  • 1 copy in tags/Safari-604.3.5.1.2

Tag Safari-604.3.5.1.2.

4:23 PM Changeset in webkit [224738] by matthew_hanson@apple.com
  • 7 edits in trunk/Source

Versioning.

11:50 AM Changeset in webkit [224737] by commit-queue@webkit.org
  • 10 edits in trunk

[GTK] Add functionality to handle font sizes in points
​https://bugs.webkit.org/show_bug.cgi?id=179285

Patch by Gabriel Ivascu <​givascu@igalia.com> on 2017-11-12
Reviewed by Carlos Garcia Campos and Michael Catanzaro.

Source/WebCore:

  • platform/PlatformScreen.h:
  • platform/gtk/PlatformScreenGtk.cpp:

(WebCore::screenDPI):

  • platform/wpe/PlatformScreenWPE.cpp:

(WebCore::screenDPI):

Source/WebKit:

  • UIProcess/API/glib/WebKitSettings.cpp:

(webkit_settings_class_init):
(webkit_settings_font_size_to_points):
(webkit_settings_font_size_to_pixels):

  • UIProcess/API/gtk/WebKitSettings.h:
  • UIProcess/API/gtk/docs/webkit2gtk-4.0-sections.txt:

Tools:

  • TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:

(testWebKitSettings):

9:52 AM Changeset in webkit [224736] by Yusuke Suzuki
  • 6 edits
    5 adds in trunk

[WebCore] Implement import.meta.url
​https://bugs.webkit.org/show_bug.cgi?id=178672

Reviewed by Darin Adler.

Source/WebCore:

This patch implements import.meta.url field, which holds a base url
of the currently executing module[1].

In the case of embedded modules, this field becomes the URL of the
embedding HTML file. In the case of imported modules, the URL becomes
the URL of the executed module script file.

[1]: ​https://github.com/whatwg/html/pull/3141

  • bindings/js/JSDOMWindowBase.cpp:

(WebCore::JSDOMWindowBase::moduleLoaderCreateImportMetaProperties):

  • bindings/js/JSDOMWindowBase.h:
  • bindings/js/ScriptModuleLoader.cpp:

(WebCore::ScriptModuleLoader::moduleURL):
(WebCore::ScriptModuleLoader::evaluate):
(WebCore::ScriptModuleLoader::createImportMetaProperties):

  • bindings/js/ScriptModuleLoader.h:

LayoutTests:

  • js/dom/modules/import-meta-url-expected.txt: Added.
  • js/dom/modules/import-meta-url.html: Added.
  • js/dom/modules/script-tests/import-meta-url-second-level.js: Added.
  • js/dom/modules/script-tests/import-meta-url-top-level.js: Added.
  • js/dom/modules/script-tests/import-meta-url.js: Added.
7:34 AM Changeset in webkit [224735] by mark.lam@apple.com
  • 11 edits
    1 add in trunk

We should ensure that operationStrCat2 and operationStrCat3 are never passed Symbols as arguments.
​https://bugs.webkit.org/show_bug.cgi?id=179562
<rdar://problem/35467022>

Reviewed by Saam Barati.

JSTests:

  • regress-179562.js: Added.

Source/JavaScriptCore:

  • dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode):

  • dfg/DFGOperations.cpp:
  • dfg/DFGSafeToExecute.h:

(JSC::DFG::SafeToExecuteEdge::operator()):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::speculateNotSymbol):
(JSC::DFG::SpeculativeJIT::speculate):

  • dfg/DFGSpeculativeJIT.h:
  • dfg/DFGUseKind.cpp:

(WTF::printInternal):

  • dfg/DFGUseKind.h:

(JSC::DFG::typeFilterFor):

  • ftl/FTLCapabilities.cpp:

(JSC::FTL::canCompile):

  • ftl/FTLLowerDFGToB3.cpp:

(JSC::FTL::DFG::LowerDFGToB3::speculate):
(JSC::FTL::DFG::LowerDFGToB3::speculateNotSymbol):

Nov 11, 2017:

6:46 PM Changeset in webkit [224734] by Megan Gardner
  • 3 edits in trunk/Source/WebKitLegacy/ios

Fix a FIXMEs in WebFrameIOS
​https://bugs.webkit.org/show_bug.cgi?id=179510

Reviewed by Darin Adler.

Removed a function that does nothing and is not needed or used anywhere, linked to a radar that is in verify.
This is just some easy cleanup I found while investigating other things.

  • WebCoreSupport/WebFrameIOS.h:
  • WebCoreSupport/WebFrameIOS.mm:

(-[WebFrame imageForNode:allowDownsampling:drawContentBehindTransparentNodes:]): Deleted.

3:45 PM Changeset in webkit [224733] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebInspectorUI

Web Inspector: Network detail views - Include a newline between sections when copying
​https://bugs.webkit.org/show_bug.cgi?id=179577

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2017-11-11
Reviewed by Matt Baker.

  • UserInterface/Views/NetworkResourceDetailView.css:

(.content-view.resource-details):

  • UserInterface/Views/ResourceDetailsSection.css:

(.resource-details > section):
(.resource-details > section > .title):
Adjust styles now that there is a <br> taking up space between sections.
After all the changes, the top section moved up 1px from where it was originally.

  • UserInterface/Views/ResourceDetailsSection.js:

(WI.ResourceDetailsSection):
Include a <br> to get newlines when copying.

1:41 PM Changeset in webkit [224732] by mitz@apple.com
  • 2 edits in trunk/Source/WebCore

[Xcode] WebCore generates unified sources during installhdrs
​https://bugs.webkit.org/show_bug.cgi?id=179578

Reviewed by Anders Carlsson.

  • WebCore.xcodeproj/project.pbxproj: Use GenerateUnifiedSources.xcconfig, which sets INSTALLHDRS_SCRIPT_PHASE to NO, for the Generate Unified Sources target.
12:26 PM Changeset in webkit [224731] by Simon Fraser
  • 7 edits
    2 deletes in trunk/Source/WebCore

Remove redundant platform-specific implementations of Image::drawPattern()
​https://bugs.webkit.org/show_bug.cgi?id=179580

Reviewed by Sam Weinig.

Platform-specific Image files had implementations of Image::drawPattern() but they
were all effectively identical, so put a single implementation into Image.cpp.

  • SourcesCocoa.txt:
  • WebCore.xcodeproj/project.pbxproj:
  • platform/SourcesCairo.txt:
  • platform/graphics/Image.cpp:

(WebCore::Image::drawPattern):

  • platform/graphics/cairo/ImageCairo.cpp: Removed.
  • platform/graphics/cg/ImageCG.cpp: Removed.
  • platform/graphics/win/ImageDirect2D.cpp:

(WebCore::Image::drawPattern): Deleted.

10:54 AM Changeset in webkit [224730] by Chris Dumez
  • 19 edits
    11 adds
    7 deletes in trunk/LayoutTests

Re-sync Service Workers web-platform-tests from upstream
​https://bugs.webkit.org/show_bug.cgi?id=179575

Reviewed by Youenn Fablet.

LayoutTests/imported/w3c:

Re-sync Service Workers web-platform-tests from upstream 04892735ed1.

  • web-platform-tests/service-workers/service-worker/ServiceWorkerGlobalScope/registration-attribute.https-expected.txt:
  • web-platform-tests/service-workers/service-worker/ServiceWorkerGlobalScope/registration-attribute.https.html:
  • web-platform-tests/service-workers/service-worker/ServiceWorkerGlobalScope/resources/registration-attribute-newer-worker.js: Added.

(record):

  • web-platform-tests/service-workers/service-worker/ServiceWorkerGlobalScope/resources/registration-attribute-worker.js:
  • web-platform-tests/service-workers/service-worker/ServiceWorkerGlobalScope/resources/unregister-controlling-worker.html: Added.
  • web-platform-tests/service-workers/service-worker/ServiceWorkerGlobalScope/resources/unregister-worker.js:

(matchQuery):
(e.waitUntil.self.registration.unregister.then):

  • web-platform-tests/service-workers/service-worker/ServiceWorkerGlobalScope/resources/update-worker.js:
  • web-platform-tests/service-workers/service-worker/ServiceWorkerGlobalScope/resources/w3c-import.log:
  • web-platform-tests/service-workers/service-worker/detached-context.https-expected.txt: Added.
  • web-platform-tests/service-workers/service-worker/detached-context.https.html: Added.
  • web-platform-tests/service-workers/service-worker/fetch-event.https-expected.txt:
  • web-platform-tests/service-workers/service-worker/fetch-event.https.html:
  • web-platform-tests/service-workers/service-worker/navigation-preload/empty-preload-response-body.https-expected.txt:
  • web-platform-tests/service-workers/service-worker/navigation-preload/resources/empty-preload-response-body-scope.html: Added.
  • web-platform-tests/service-workers/service-worker/request-body-blob.https-expected.txt: Removed.
  • web-platform-tests/service-workers/service-worker/request-body-blob.https.html: Removed.
  • web-platform-tests/service-workers/service-worker/resources/empty.js: Added.
  • web-platform-tests/service-workers/service-worker/resources/fetch-event-test-worker.js:

(handleHeaders):
(handleRequestBody):

  • web-platform-tests/service-workers/service-worker/resources/interfaces-idls.js:
  • web-platform-tests/service-workers/service-worker/resources/interfaces-worker.sub.js:

(test):

  • web-platform-tests/service-workers/service-worker/resources/request-body-blob-iframe.html: Removed.
  • web-platform-tests/service-workers/service-worker/resources/request-body-blob-worker.js: Removed.
  • web-platform-tests/service-workers/service-worker/resources/respond-with-body-accessed-response-iframe.html: Added.
  • web-platform-tests/service-workers/service-worker/resources/respond-with-body-accessed-response-worker.js: Added.

(getQueryParams):
(createResponse):
(cloneResponseIfNeeded):
(passThroughCacheIfNeeded):
(event.request.url.indexOf):
(event.respondWith.createResponse.params.then):
(then):

  • web-platform-tests/service-workers/service-worker/resources/respond-with-body-accessed-response.jsonp: Added.
  • web-platform-tests/service-workers/service-worker/resources/test-helpers.sub.js:
  • web-platform-tests/service-workers/service-worker/resources/w3c-import.log:
  • web-platform-tests/service-workers/service-worker/resources/websocket-worker.js: Added.

(reportFailure):
(onmessage.event.ws.onopen):
(onmessage.event.ws.onclose):
(onmessage.event.ws.onerror):

  • web-platform-tests/service-workers/service-worker/resources/xhr.js: Removed.
  • web-platform-tests/service-workers/service-worker/respond-with-body-accessed-response.https-expected.txt: Added.
  • web-platform-tests/service-workers/service-worker/respond-with-body-accessed-response.https.html: Added.
  • web-platform-tests/service-workers/service-worker/w3c-import.log:
  • web-platform-tests/service-workers/service-worker/waiting.https-expected.txt:
  • web-platform-tests/service-workers/service-worker/waiting.https.html:
  • web-platform-tests/service-workers/service-worker/websocket-in-service-worker.https-expected.txt: Added.
  • web-platform-tests/service-workers/service-worker/websocket-in-service-worker.https.html: Added.
  • web-platform-tests/service-workers/service-worker/xhr.https-expected.txt: Removed.
  • web-platform-tests/service-workers/service-worker/xhr.https.html: Removed.

LayoutTests:

Skip a few tests that are timing out.

1:42 AM Changeset in webkit [224729] by timothy_horton@apple.com
  • 5 edits in trunk/Source/WebKit

Increase the alignment requirement of WKObject's wrapped C++ object
​https://bugs.webkit.org/show_bug.cgi?id=179518

Reviewed by Dan Bernstein.

  • Shared/API/APIObject.h:
  • Shared/Cocoa/APIObject.mm:

(API::allocateWKObject):
(API::Object::fromWKObjectExtraSpace):
(API::Object::newObject):

  • Shared/Cocoa/WKObject.mm:

(-[WKObject dealloc]):
(-[WKObject _apiObject]):

  • UIProcess/API/Cocoa/WKConnection.mm:

(-[WKConnection dealloc]):
(-[WKConnection _apiObject]):
(-[WKConnection _connection]):
Increase the alignment of the C++ object stored inside WKObject's extra space
to 8-bytes, for platforms where some types require greater-than-pointer alignment.
To achieve this, increase the size of the extra-space allocation by the difference
between 8 bytes and pointer-alignment, and then align within that.

1:24 AM Changeset in webkit [224728] by timothy_horton@apple.com
  • 3 edits in trunk/Source/WebKit

Avoid composing the message + recipient name for crash logs until a failure actually occurs
​https://bugs.webkit.org/show_bug.cgi?id=179576

Reviewed by Dan Bernstein.

  • Platform/IPC/mac/ConnectionMac.mm:

(IPC::Connection::sendMessage):
(IPC::Connection::sendOutgoingMessage):

  • Platform/IPC/mac/MachMessage.h:

(IPC::MachMessage::messageReceiverName const):
(IPC::MachMessage::setMessageReceiverName):
(IPC::MachMessage::messageName const):
(IPC::MachMessage::setMessageName):
Store the message name and receiver name separately on MachMessage,
only composing them into a string if the message is unhandled. This
makes the time spent composing the string in sendOutgoingMessage
completely disappear. In absolute terms, it wasn't huge, but if you
do enough IPC it starts to add up.

1:24 AM Changeset in webkit [224727] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Network waterfall graph - make connection part thinner
​https://bugs.webkit.org/show_bug.cgi?id=179561

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2017-11-11
Reviewed by Devin Rousso.

  • UserInterface/Views/NetworkTableContentView.css:

(.waterfall .block):

1:22 AM Changeset in webkit [224726] by webkit@devinrousso.com
  • 18 edits in trunk

Web Inspector: Canvas tab: show detailed status during canvas recording
​https://bugs.webkit.org/show_bug.cgi?id=178185
<rdar://problem/34939862>

Reviewed by Brian Burg.

Source/JavaScriptCore:

  • inspector/protocol/Canvas.json:

Add a recordingProgress event that is sent to the frontend that contains all the frame
payloads since the last Canvas.recordingProgress event and the current buffer usage.

  • inspector/protocol/Recording.json:

Remove the required frames parameter from the Recording protocol object, as they will be
sent in batches via the Canvas.recordingProgress event.

Source/WebCore:

Updated existing tests to assert that the correct number of progress events are fired.

  • inspector/agents/InspectorCanvasAgent.cpp:

(WebCore::InspectorCanvasAgent::didFinishRecordingCanvasFrame):
After each recorded frame, fire a progress event with the recorded frames as data. This will
release the frames from the associated InspectorCanvas, meaning that the frames must be
aggregated in the frontend before a Recording can be created.

The protocol is designed with arrays so that if we decide to add throttling (e.g. one event
per second) we are able to do so without modifying the protocol.

  • inspector/InspectorCanvas.h:
  • inspector/InspectorCanvas.cpp:

(WebCore::InspectorCanvas::hasRecordingData const):
(WebCore::InspectorCanvas::currentFrameHasData const):
(WebCore::InspectorCanvas::recordAction):
(WebCore::InspectorCanvas::finalizeFrame):
(WebCore::InspectorCanvas::markCurrentFrameIncomplete):
Add additional checks that the list of recorded frames is not nullptr when finalizing or
marking as incomplete.

Source/WebInspectorUI:

  • Localizations/en.lproj/localizedStrings.js:
  • UserInterface/Protocol/CanvasObserver.js:

(WI.CanvasObserver.prototype.recordingProgress):

  • UserInterface/Controllers/CanvasManager.js:

(WI.CanvasManager):
(WI.CanvasManager.prototype.recordingProgress):
(WI.CanvasManager.prototype.recordingFinished):
Maintain arrays of recorded frames for each canvas and add new frames each time a progress
event is fired. When the recording is finished, use the array as part of the payload for
creating a WI.Recording object.

  • UserInterface/Models/Recording.js:

(WI.Recording.fromPayload):

  • UserInterface/Models/RecordingAction.js:

(WI.RecordingAction.prototype.apply.getContent):
(WI.RecordingAction.prototype.apply):
Drive-by fix: toDataURL is very slow, so add alternative ways of getting and comparing the
content of the canvas to determine if the action has a visible effect.

  • UserInterface/Views/CanvasContentView.css:

(.content-view.canvas:not(.tab)):
(.content-view.canvas:not(.tab) > .progress):
(.content-view.canvas:not(.tab) > .progress > .frame-count):

  • UserInterface/Views/CanvasContentView.js:

(WI.CanvasContentView):
(WI.CanvasContentView.prototype.attached):
(WI.CanvasContentView.prototype._recordingStarted):
(WI.CanvasContentView.prototype._recordingProgress):
(WI.CanvasContentView.prototype._recordingStopped):
Steal some space from the preview area to display a count of the number of recorded frames
and the current buffer usage.

  • UserInterface/Views/CanvasOverviewContentView.css:

(.content-view.canvas-overview .content-view.canvas > :matches(header, .progress, .preview, footer)):
(.content-view.canvas-overview .content-view.canvas.selected > :matches(.progress, .preview, footer),):
(.content-view.canvas-overview .content-view.canvas > :matches(.progress, .preview)):
(.content-view.canvas-overview .content-view.canvas > .preview):
(.content-view.canvas-overview .content-view.canvas > .progress ~ .preview):
(.content-view.canvas-overview .content-view.canvas > :matches(header, .preview, footer)): Deleted.
(.content-view.canvas-overview .content-view.canvas.selected > :matches(.preview, footer),): Deleted.

LayoutTests:

  • inspector/canvas/resources/recording-utilities.js:

(TestPage.registerInitializer.window.startRecording.handleRecordingProgress):
(TestPage.registerInitializer.window.startRecording):

12:14 AM WebKitGTK/2.18.x edited by berto@igalia.com
(diff)
12:08 AM Changeset in webkit [224725] by berto@igalia.com
  • 2 edits in trunk/Source/WebCore

[GTK] PlatformGTK.cmake: use the PKG_CONFIG_EXECUTABLE variable
​https://bugs.webkit.org/show_bug.cgi?id=179547

Patch by Helmut Grohne <​helmut@subdivi.de> on 2017-11-11
Reviewed by Michael Catanzaro.

  • PlatformGTK.cmake: Use PKG_CONFIG_EXECUTABLE instead of

hardcoding the executable name.

Note: See TracTimeline for information about the timeline view.