Timeline

Nov 13, 2017:

11:34 PM Changeset in webkit [224806] by commit-queue@webkit.org

• 9 edits in trunk/Source

Give a ServiceWorker WebContentProcess a different display name
​https://bugs.webkit.org/show_bug.cgi?id=179653

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2017-11-13
Reviewed by Brady Eidson.

Source/WebCore:

• English.lproj/Localizable.strings:

Source/WebKit:

• UIProcess/WebProcessProxy.h:
• UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::create):
Call connect after construction so virtual methods will use subclass implementations.

• UIProcess/ServiceWorkerProcessProxy.h:
• UIProcess/ServiceWorkerProcessProxy.cpp:

(WebKit::ServiceWorkerProcessProxy::create):
Copy the pattern from WebProcessProxy to ensure connect() gets called after construction.

(WebKit::ServiceWorkerProcessProxy::getLaunchOptions):
Set a launch option to signal this is a Service Worker process.

• Shared/EntryPointUtilities/mac/XPCService/XPCServiceEntryPoint.mm:

(WebKit::XPCServiceInitializerDelegate::getExtraInitializationData):

• WebProcess/cocoa/WebProcessCocoa.mm:

(WebKit::WebProcess::initializeProcessName):
Consume the launch option to configuration the process name.

11:26 PM Changeset in webkit [224805] by rniwa@webkit.org

• 2 edits in trunk/Source/WebKit

REGRESSION(r224799): WebKit crashes at launch on macOS Sierra due to a sandbox violation
​https://bugs.webkit.org/show_bug.cgi?id=179656

Unreviewed. Revert r224799 on macOS Sierra.

• WebProcess/com.apple.WebProcess.sb.in:

10:21 PM Changeset in webkit [224804] by Chris Dumez

• 26 edits
  2 copies in trunk

Send ServiceWorkerData structs to the WebProcesses instead of ServiceWorkerIdentifiers
​https://bugs.webkit.org/show_bug.cgi?id=179649

Reviewed by Brady Eidson.

LayoutTests/imported/w3c:

Rebaseline a couple of WPT tests that are now passing.

• web-platform-tests/service-workers/service-worker/register-wait-forever-in-install-worker.https-expected.txt:
• web-platform-tests/service-workers/service-worker/skip-waiting.https-expected.txt:

Source/WebCore:

Send ServiceWorkerData structs to the WebProcesses instead of ServiceWorkerIdentifiers so that the
WebProcesses can correctly construct ServiceWorker objects, with the right attributes / state.

No new tests, rebaselined existing tests.

• Sources.txt:
• WebCore.xcodeproj/project.pbxproj:
• workers/service/ServiceWorker.cpp:

(WebCore::ServiceWorker::getOrCreate):
(WebCore::ServiceWorker::ServiceWorker):
(WebCore::ServiceWorker::~ServiceWorker):
(WebCore::ServiceWorker::scheduleTaskToUpdateState):
(WebCore::ServiceWorker::postMessage):

• workers/service/ServiceWorker.h:
• workers/service/ServiceWorkerContainer.cpp:

(WebCore::ServiceWorkerContainer::scheduleTaskToUpdateRegistrationState):

• workers/service/ServiceWorkerContainer.h:
• workers/service/ServiceWorkerData.cpp: Copied from Source/WebCore/workers/service/ServiceWorkerRegistrationData.cpp.

(WebCore::ServiceWorkerData::isolatedCopy const):

• workers/service/ServiceWorkerData.h: Copied from Source/WebCore/workers/service/server/SWServerWorker.cpp.

(WebCore::ServiceWorkerData::encode const):
(WebCore::ServiceWorkerData::decode):

• workers/service/ServiceWorkerRegistration.cpp:

(WebCore::ServiceWorkerRegistration::ServiceWorkerRegistration):
(WebCore::ServiceWorkerRegistration::updateStateFromServer):

• workers/service/ServiceWorkerRegistration.h:
• workers/service/ServiceWorkerRegistrationData.cpp:

(WebCore::ServiceWorkerRegistrationData::isolatedCopy const):

• workers/service/ServiceWorkerRegistrationData.h:

(WebCore::ServiceWorkerRegistrationData::encode const):
(WebCore::ServiceWorkerRegistrationData::decode):

• workers/service/server/SWClientConnection.cpp:

(WebCore::SWClientConnection::postMessageToServiceWorkerClient):
(WebCore::SWClientConnection::updateRegistrationState):

• workers/service/server/SWClientConnection.h:
• workers/service/server/SWServer.h:
• workers/service/server/SWServerRegistration.cpp:

(WebCore::SWServerRegistration::updateRegistrationState):
(WebCore::SWServerRegistration::data const):

• workers/service/server/SWServerWorker.cpp:

(WebCore::SWServerWorker::SWServerWorker):
(WebCore::m_script):

• workers/service/server/SWServerWorker.h:

(WebCore::SWServerWorker::scriptURL const):
(WebCore::SWServerWorker::type const):
(WebCore::SWServerWorker::identifier const):
(WebCore::SWServerWorker::state const):
(WebCore::SWServerWorker::setState):
(WebCore::SWServerWorker::data const):

Source/WebKit:

• Shared/WebCoreArgumentCoders.h:
• StorageProcess/ServiceWorker/WebSWServerConnection.cpp:

(WebKit::WebSWServerConnection::updateRegistrationStateInClient):
(WebKit::WebSWServerConnection::postMessageToServiceWorkerClient):

• StorageProcess/ServiceWorker/WebSWServerConnection.h:
• WebProcess/Storage/WebSWClientConnection.cpp:

(WebKit::WebSWClientConnection::postMessageToServiceWorkerClient):

• WebProcess/Storage/WebSWClientConnection.h:
• WebProcess/Storage/WebSWClientConnection.messages.in:

10:03 PM Changeset in webkit [224803] by rniwa@webkit.org

• 2 edits in trunk/Source/WebCore

iOS: Enable release asserts in updateStyleIfNeeded() and updateLayout() for WebKit2
​https://bugs.webkit.org/show_bug.cgi?id=179651

Reviewed by Antti Koivisto.

r224604 disabled the release assertions on iOS entirely even though the underlying bug only affected iOS WebKit1 port
due to various time constraints. Enable them back on iOS WebKit2 port.

• dom/Document.cpp:

(WebCore::isSafeToUpdateStyleOrLayout):
(WebCore::Document::updateStyleIfNeeded):
(WebCore::Document::updateLayout):

9:33 PM Changeset in webkit [224802] by sbarati@apple.com

• 9 edits in trunk/Source/JavaScriptCore

Remove pointer caging for HashMapImpl, JSLexicalEnvironment, DirectArguments, ScopedArguments, and ScopedArgumentsTable
​https://bugs.webkit.org/show_bug.cgi?id=179203

Reviewed by Yusuke Suzuki.

This patch only removes the pointer caging for the described types in the title.
These types still allocate out of the gigacage. This is a just a cost vs benefit
tradeoff of performance vs security.

• dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileGetByValOnDirectArguments):
(JSC::DFG::SpeculativeJIT::compileGetByValOnScopedArguments):

• ftl/FTLLowerDFGToB3.cpp:

(JSC::FTL::DFG::LowerDFGToB3::compileGetByVal):

• jit/JITPropertyAccess.cpp:

(JSC::JIT::emitDirectArgumentsGetByVal):
(JSC::JIT::emitScopedArgumentsGetByVal):

• runtime/DirectArguments.h:

(JSC::DirectArguments::storage):

• runtime/HashMapImpl.cpp:

(JSC::HashMapImpl<HashMapBucket>::visitChildren):

• runtime/HashMapImpl.h:
• runtime/JSLexicalEnvironment.h:

(JSC::JSLexicalEnvironment::variables):

• runtime/ScopedArguments.h:

(JSC::ScopedArguments::overflowStorage const):

7:58 PM Changeset in webkit [224801] by beidson@apple.com

• 34 edits
  4 copies
  1 add in trunk/Source

Massive "Server-process-to-context-process" connection overhaul.
​https://bugs.webkit.org/show_bug.cgi?id=179554

Reviewed by Chris Dumez.

Source/WebCore:

No new tests (Refactor, no behavior change).

Having the SWServer::Connection object be overloaded to mean both client->server and server->context
was the wrong design and was starting to crumble under its own weight.

So this patch introduces a SWServerToContextConnection to manage the StorageProcess-side of connections
to context processes.

Any message that is specifically about the connection between the StorageProcess and context process
should use this connection going forward.

Right now there is only one context process, but this design keeps us ready for that to change.

This patch also gets rid of a lot of "server connection identifier" integers being passed amongst processes
that were actually pointless.

This patch is also a prerequisite for many things that are coming up soon, such as termination.

• Sources.txt:
• WebCore.xcodeproj/project.pbxproj:

• workers/service/ServiceWorkerContextData.cpp:

(WebCore::ServiceWorkerContextData::isolatedCopy const):

• workers/service/ServiceWorkerContextData.h:

(WebCore::ServiceWorkerContextData::encode const):
(WebCore::ServiceWorkerContextData::decode):

• workers/service/ServiceWorkerGlobalScope.cpp:

(WebCore::ServiceWorkerGlobalScope::ServiceWorkerGlobalScope):

• workers/service/ServiceWorkerGlobalScope.h:

(WebCore::ServiceWorkerGlobalScope::serverConnectionIdentifier const): Deleted.

• workers/service/ServiceWorkerTypes.h:

• workers/service/context/ServiceWorkerThread.cpp:

(WebCore::ServiceWorkerThread::ServiceWorkerThread):
(WebCore::ServiceWorkerThread::createWorkerGlobalScope):

• workers/service/context/ServiceWorkerThread.h:

(WebCore::ServiceWorkerThread::serverConnectionIdentifier const): Deleted.

• workers/service/context/ServiceWorkerThreadProxy.cpp:

(WebCore::ServiceWorkerThreadProxy::ServiceWorkerThreadProxy):
(WebCore::ServiceWorkerThreadProxy::create): Deleted.

• workers/service/context/ServiceWorkerThreadProxy.h:

• workers/service/server/SWServer.cpp:

(WebCore::generateServiceWorkerIdentifier):
(WebCore::SWServer::~SWServer):
(WebCore::SWServer::SWServer):
(WebCore::SWServer::scriptContextFailedToStart):
(WebCore::SWServer::scriptContextStarted):
(WebCore::SWServer::didFinishInstall):
(WebCore::SWServer::didFinishActivation):
(WebCore::SWServer::didResolveRegistrationPromise):
(WebCore::SWServer::updateWorker):
(WebCore::SWServer::serverToContextConnectionCreated):
(WebCore::SWServer::installContextData):
(WebCore::SWServer::fireInstallEvent):
(WebCore::SWServer::fireActivateEvent):
(WebCore::SWServer::Connection::didFinishInstall): Deleted.
(WebCore::SWServer::Connection::didFinishActivation): Deleted.
(WebCore::SWServer::Connection::setServiceWorkerHasPendingEvents): Deleted.
(WebCore::SWServer::Connection::scriptContextFailedToStart): Deleted.
(WebCore::SWServer::Connection::scriptContextStarted): Deleted.
(WebCore::SWServer::setServiceWorkerHasPendingEvents): Deleted.

• workers/service/server/SWServer.h:

• workers/service/server/SWServerJobQueue.cpp:

(WebCore::SWServerJobQueue::scriptContextFailedToStart):
(WebCore::SWServerJobQueue::scriptContextStarted):
(WebCore::SWServerJobQueue::install):
(WebCore::SWServerJobQueue::didResolveRegistrationPromise):
(WebCore::SWServerJobQueue::didFinishInstall):
(WebCore::SWServerJobQueue::tryActivate):
(WebCore::SWServerJobQueue::activate):

• workers/service/server/SWServerJobQueue.h:

• workers/service/server/SWServerRegistration.cpp:

(WebCore::generateServiceWorkerRegistrationIdentifier):

• workers/service/server/SWServerToContextConnection.cpp: Added.

(WebCore::generateServerToContextConnectionIdentifier):
(WebCore::SWServerToContextConnection::SWServerToContextConnection):
(WebCore::SWServerToContextConnection::~SWServerToContextConnection):
(WebCore::SWServerToContextConnection::connectionForIdentifier):
(WebCore::SWServerToContextConnection::globalServerToContextConnection):
(WebCore::SWServerToContextConnection::scriptContextFailedToStart):
(WebCore::SWServerToContextConnection::scriptContextStarted):
(WebCore::SWServerToContextConnection::didFinishInstall):
(WebCore::SWServerToContextConnection::didFinishActivation):
(WebCore::SWServerToContextConnection::setServiceWorkerHasPendingEvents):

• workers/service/server/SWServerToContextConnection.h: Copied from Source/WebCore/workers/service/server/SWServerWorker.h.

(WebCore::SWServerToContextConnection::identifier const):

• workers/service/server/SWServerWorker.cpp:

(WebCore::SWServerWorker::existingWorkerForIdentifier):
(WebCore::SWServerWorker::SWServerWorker):
(WebCore::SWServerWorker::~SWServerWorker):
(WebCore::SWServerWorker::scriptContextFailedToStart):
(WebCore::SWServerWorker::scriptContextStarted):
(WebCore::SWServerWorker::didFinishInstall):
(WebCore::SWServerWorker::didFinishActivation):

• workers/service/server/SWServerWorker.h:

(WebCore::SWServerWorker::create):
(WebCore::SWServerWorker::registrationKey const):
(WebCore::SWServerWorker::contextConnectionIdentifier const):

Source/WebKit:

• DerivedSources.make:
• WebKit.xcodeproj/project.pbxproj:

• Shared/WebCoreArgumentCoders.h:

• StorageProcess/ServiceWorker/WebSWServerConnection.cpp:

(WebKit::WebSWServerConnection::sendToContextProcess):
(WebKit::WebSWServerConnection::installServiceWorkerContext): Deleted.
(WebKit::WebSWServerConnection::fireInstallEvent): Deleted.
(WebKit::WebSWServerConnection::fireActivateEvent): Deleted.
(WebKit::WebSWServerConnection::setContextConnection): Deleted.

• StorageProcess/ServiceWorker/WebSWServerConnection.h:

• StorageProcess/ServiceWorker/WebSWServerToContextConnection.cpp: Copied from Source/WebCore/workers/service/server/SWServerWorker.cpp.

(WebKit::WebSWServerToContextConnection::WebSWServerToContextConnection):
(WebKit::WebSWServerToContextConnection::messageSenderConnection):
(WebKit::WebSWServerToContextConnection::messageSenderDestinationID):
(WebKit::WebSWServerToContextConnection::connectionClosed):
(WebKit::WebSWServerToContextConnection::installServiceWorkerContext):
(WebKit::WebSWServerToContextConnection::fireInstallEvent):
(WebKit::WebSWServerToContextConnection::fireActivateEvent):

• StorageProcess/ServiceWorker/WebSWServerToContextConnection.h: Copied from Source/WebCore/workers/service/ServiceWorkerTypes.h.

(WebKit::WebSWServerToContextConnection::create):
(WebKit::WebSWServerToContextConnection::ipcConnection const):

• StorageProcess/ServiceWorker/WebSWServerToContextConnection.messages.in: Copied from Source/WebKit/WebProcess/Storage/WebSWContextManagerConnection.messages.in.

• StorageProcess/StorageProcess.cpp:

(WebKit::StorageProcess::didClose):
(WebKit::StorageProcess::didReceiveMessage):
(WebKit::StorageProcess::globalServerToContextConnection):
(WebKit::StorageProcess::createServerToContextConnection):
(WebKit::StorageProcess::didGetWorkerContextProcessConnection):
(WebKit::StorageProcess::workerContextProcessConnection): Deleted.
(WebKit::StorageProcess::createWorkerContextProcessConnection): Deleted.
(WebKit::StorageProcess::serviceWorkerContextFailedToStart): Deleted.
(WebKit::StorageProcess::serviceWorkerContextStarted): Deleted.
(WebKit::StorageProcess::didFinishServiceWorkerInstall): Deleted.
(WebKit::StorageProcess::didFinishServiceWorkerActivation): Deleted.
(WebKit::StorageProcess::setServiceWorkerHasPendingEvents): Deleted.

• StorageProcess/StorageProcess.h:
• StorageProcess/StorageProcess.messages.in:

• StorageProcess/StorageToWebProcessConnection.cpp:

(WebKit::StorageToWebProcessConnection::didReceiveMessage):
(WebKit::StorageToWebProcessConnection::establishSWServerConnection):
(WebKit::StorageToWebProcessConnection::workerContextProcessConnectionCreated):

• WebProcess/Storage/WebSWContextManagerConnection.cpp:

(WebKit::WebSWContextManagerConnection::installServiceWorker):
(WebKit::WebSWContextManagerConnection::serviceWorkerStartedWithMessage):
(WebKit::WebSWContextManagerConnection::fireInstallEvent):
(WebKit::WebSWContextManagerConnection::fireActivateEvent):
(WebKit::WebSWContextManagerConnection::didFinishInstall):
(WebKit::WebSWContextManagerConnection::didFinishActivation):
(WebKit::WebSWContextManagerConnection::setServiceWorkerHasPendingEvents):

• WebProcess/Storage/WebSWContextManagerConnection.h:
• WebProcess/Storage/WebSWContextManagerConnection.messages.in:

Source/WTF:

• wtf/ObjectIdentifier.h:

(WTF::generateObjectIdentifier):
(WTF::makeObjectIdentifier): Deleted.

6:59 PM Changeset in webkit [224800] by mark.lam@apple.com

• 2 edits in trunk/Tools

Pass --useDollarVM=true to all JSC tests.
​https://bugs.webkit.org/show_bug.cgi?id=179647

Reviewed by Saam Barati.

• Scripts/run-jsc-stress-tests:

6:58 PM Changeset in webkit [224799] by Brent Fulgham

• 2 edits in trunk/Source/WebKit

WebContent sandbox should not include 'system.sb'
​https://bugs.webkit.org/show_bug.cgi?id=179548
<rdar://problem/35367154>

Reviewed by Darin Adler.

Stop including 'system.sb', and just include the portions of that sandbox that we
actually use in WebContent Process. This is the first step in some further sandbox
tightening.

• WebProcess/com.apple.WebProcess.sb.in:

6:39 PM Changeset in webkit [224798] by don.olmstead@sony.com

• 2 edits in trunk/Source/WebCore

Unreviewed build fix after r224791.

• platform/network/NetworkStorageSessionStub.cpp:

(WebCore::NetworkStorageSession::ensurePrivateBrowsingSession): Deleted.

6:28 PM Changeset in webkit [224797] by Simon Fraser

• 7 edits in trunk/Source/WebCore

Minor DisplayRefreshMonitor-related cleanup
​https://bugs.webkit.org/show_bug.cgi?id=179648

Reviewed by Alex Christensen.

Use more "#pragma once" and C++ initializers.

Make more member functions of DisplayRefreshMonitor protected.

Improve the ordering of member variables.

Don't mix member variables and member functions in the declaration of ScriptedAnimationController.

• dom/ScriptedAnimationController.h:
• platform/graphics/DisplayRefreshMonitor.cpp:

(WebCore::DisplayRefreshMonitor::DisplayRefreshMonitor):
(WebCore::DisplayRefreshMonitor::displayDidRefresh):

• platform/graphics/DisplayRefreshMonitor.h:

(WebCore::DisplayRefreshMonitor::mutex):

• platform/graphics/DisplayRefreshMonitorManager.h:
• platform/graphics/mac/DisplayRefreshMonitorMac.cpp:

(WebCore::DisplayRefreshMonitorMac::DisplayRefreshMonitorMac):

• platform/graphics/mac/DisplayRefreshMonitorMac.h:

6:01 PM Changeset in webkit [224796] by Simon Fraser

• 17 edits
  1 move
  3 adds in trunk

When navigating back to a page, compositing layers may not use accelerated drawing
​https://bugs.webkit.org/show_bug.cgi?id=178749
rdar://problem/35158946

Reviewed by Dean Jackson.
Source/WebCore:

There were two issues with setting GraphicsLayerCA's "acceleratesDrawing" state which
occurred on back navigation, related to the ordering of style recalcs and layout.

First, at style recalc time, we created a RenderLayerCompositor but hadn't yet called
its cacheAcceleratedCompositingFlags(), so any layers created during style update
didn't get accelerated drawing. Fix by making cacheAcceleratedCompositingFlags() internal
to RenderLayerCompositor and calling it from willRecalcStyle() and updateCompositingLayers().

We have to be careful to avoid m_forceCompositingMode flip-flopping between cacheAcceleratedCompositingFlags()
and cacheAcceleratedCompositingFlagsAfterLayout(), since, for subframes, it depends on layout.

Secondly, GraphicsLayerCA::commitLayerChangesBeforeSublayers() needs to updateAcceleratesDrawing()
before updating tiles, so that new tiles fetch the right acceleratesDrawing state from
the TileController.

Test: compositing/accelerated-layers-after-back.html

• page/FrameView.cpp:

(WebCore::FrameView::updateCompositingLayersAfterLayout):

• platform/graphics/ca/GraphicsLayerCA.cpp:

(WebCore::GraphicsLayerCA::commitLayerChangesBeforeSublayers):

• rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::willRecalcStyle):
(WebCore::RenderLayerCompositor::didRecalcStyleWithNoPendingLayout):
(WebCore::RenderLayerCompositor::updateCompositingLayers):

• rendering/RenderLayerCompositor.h:

Source/WebKit:

Avoid assertions when a test enables accelerated drawing (which we can't support
in the iOS simulator).

• Shared/RemoteLayerTree/RemoteLayerBackingStore.mm:

(WebKit::RemoteLayerBackingStore::ensureBackingStore):

Tools:

Fix WTR and DRT to parse "useAcceleratedDrawing" out of "webkit-test-runner" options
and use it to set the state of the web view.

• DumpRenderTree/TestOptions.h:
• DumpRenderTree/TestOptions.mm:

(TestOptions::TestOptions):

• DumpRenderTree/mac/DumpRenderTree.mm:

(setWebPreferencesForTestOptions):

• WebKitTestRunner/TestController.cpp:

(WTR::TestController::resetPreferencesToConsistentValues):
(WTR::updateTestOptionsFromTestHeader):

• WebKitTestRunner/TestOptions.h:

(WTR::TestOptions::hasSameInitializationOptions const):

LayoutTests:

Moved iframes/resources/page-cache-helper.html up to compositing/resources/go-back.html.

• compositing/accelerated-layers-after-back-expected.txt: Added.
• compositing/accelerated-layers-after-back.html: Added.
• compositing/iframes/page-cache-layer-tree.html:
• compositing/page-cache-back-crash.html:
• compositing/resources/go-back.html: Renamed from LayoutTests/compositing/iframes/resources/page-cache-helper.html.
• platform/ios/compositing/accelerated-layers-after-back-expected.txt: Added.

4:55 PM Changeset in webkit [224795] by commit-queue@webkit.org

• 2 edits in trunk/Tools

[Windows] Fix Python error for subprocess.popen with close_fds
​https://bugs.webkit.org/show_bug.cgi?id=179553

Patch by Basuke Suzuki <Basuke Suzuki> on 2017-11-13
Reviewed by Per Arne Vollan.

• Scripts/webkitpy/port/server_process.py:

(ServerProcess._start):
(ServerProcess._should_close_fds):

4:49 PM Changeset in webkit [224794] by Ryan Haddad

• 2 edits in trunk/LayoutTests

Disable two Modern EME LayoutTests on mac-wk1 until the feature is enabled in DumpRenderTree.
​https://bugs.webkit.org/show_bug.cgi?id=179544

Unreviewed test gardening.

• platform/mac-wk1/TestExpectations:

4:42 PM Changeset in webkit [224793] by Michael Catanzaro

• 4 edits
  1 delete in trunk

[GTK] Require woff2 1.0.2 and drop direct brotli dependency
​https://bugs.webkit.org/show_bug.cgi?id=179630

Reviewed by Frédéric Wang.

.:

• Source/cmake/FindBrotliDec.cmake: Removed.
• Source/cmake/OptionsGTK.cmake:

Tools:

• gtk/jhbuild.modules:

4:20 PM Changeset in webkit [224792] by commit-queue@webkit.org

• 16 edits
  2 copies in trunk

matchRegistration does not need to go to StorageProcess if no service worker is registered
​https://bugs.webkit.org/show_bug.cgi?id=179480

Patch by Youenn Fablet <​youenn@apple.com> on 2017-11-13
Reviewed by Chris Dumez.

LayoutTests/imported/w3c:

• web-platform-tests/service-workers/service-worker/activation.https-expected.txt:
• web-platform-tests/service-workers/service-worker/activation.https.html:
• web-platform-tests/service-workers/service-worker/registration-iframe.https.html:

Source/WebCore:

Covered by existing tests.

Moving the origin store in SWServer since they share the same session ID.
This allows updating the origin store based on each registration map update.
This also allows clearing the origin store when clearing the SWServer.

• Sources.txt:
• WebCore.xcodeproj/project.pbxproj:
• workers/service/server/SWOriginStore.cpp: Added.

(WebCore::SWOriginStore::add):
(WebCore::SWOriginStore::remove):
(WebCore::SWOriginStore::clear):
(WebCore::SWOriginStore::clearAll):

• workers/service/server/SWOriginStore.h: Added.
• workers/service/server/SWServer.cpp:

(WebCore::SWServer::addRegistration):
(WebCore::SWServer::removeRegistration):
(WebCore::SWServer::OriginStore::add):
(WebCore::SWServer::OriginStore::remove):
(WebCore::SWServer::OriginStore::clear):
(WebCore::SWServer::OriginStore::clearAll):
(WebCore::SWServer::clearAll):
(WebCore::SWServer::clear):
(WebCore::SWServer::SWServer):

• workers/service/server/SWServer.h:

(WebCore::SWServer::originStore):

Source/WebKit:

Removed origin store handling from StorageProcess since it is now handled within SWServer.
Updated clearing of web site data accordingly.
Optimized matchRegistration by looking at the origin store before doing any IPC.
Do IPC to the StorageProcess if the origin store is not yet initialized on the WebProcess.

• StorageProcess/ServiceWorker/WebSWOriginStore.h:
• StorageProcess/ServiceWorker/WebSWServerConnection.cpp:

(WebKit::WebSWServerConnection::resolveRegistrationJobInClient):
(WebKit::WebSWServerConnection::resolveUnregistrationJobInClient):

• StorageProcess/StorageProcess.cpp:

(WebKit::StorageProcess::deleteWebsiteData):
(WebKit::StorageProcess::deleteWebsiteDataForOrigins):
(WebKit::StorageProcess::swServerForSession):
(WebKit::StorageProcess::swOriginStoreForSession):
(WebKit::StorageProcess::registerSWServerConnection):
(WebKit::StorageProcess::unregisterSWServerConnection):
(WebKit::StorageProcess::ensureSWOriginStoreForSession): Deleted.
(WebKit::StorageProcess::swOriginStoreForSession const): Deleted.

• StorageProcess/StorageProcess.h:
• StorageProcess/ServiceWorker/WebSWOriginStore.cpp:

(WebKit::WebSWOriginStore::addToStore):
(WebKit::WebSWOriginStore::removeFromStore):
(WebKit::WebSWOriginStore::clearStore):
(WebKit::WebSWOriginStore::add): Deleted.
(WebKit::WebSWOriginStore::remove): Deleted.
(WebKit::WebSWOriginStore::clear): Deleted.

• StorageProcess/ServiceWorker/WebSWOriginStore.h:
• WebProcess/Storage/WebSWClientConnection.cpp:

(WebKit::WebSWClientConnection::matchRegistration):

3:50 PM Changeset in webkit [224791] by achristensen@apple.com

• 26 edits in trunk/Source

Merge NetworkProcess::EnsurePrivateBrowsingSession and NetworkProcess::AddWebsiteDataStore into one message type
​https://bugs.webkit.org/show_bug.cgi?id=178751

Reviewed by Brady Eidson.

Source/WebCore:

The creation of private browsing sessions and persistent browsing sessions has evolved to be the same thing
with differences in parameters, like no sandbox extensions or paths to persistent storage locations for private browsing.
These should be united to simplify future development of WebsiteDataStore construction.

• platform/network/NetworkStorageSession.h:
• platform/network/cf/NetworkStorageSessionCFNet.cpp:

(WebCore::NetworkStorageSession::ensurePrivateBrowsingSession): Deleted.

• platform/network/soup/NetworkStorageSessionSoup.cpp:

(WebCore::NetworkStorageSession::ensureSession):
(WebCore::NetworkStorageSession::ensurePrivateBrowsingSession): Deleted.

Source/WebKit:

• NetworkProcess/NetworkConnectionToWebProcess.cpp:

(WebKit::NetworkConnectionToWebProcess::ensureLegacyPrivateBrowsingSession):

• NetworkProcess/NetworkProcess.cpp:

(WebKit::NetworkProcess::initializeNetworkProcess):
(WebKit::NetworkProcess::ensurePrivateBrowsingSession): Deleted.

• NetworkProcess/NetworkProcess.h:
• NetworkProcess/NetworkProcess.messages.in:
• NetworkProcess/RemoteNetworkingContext.h:
• NetworkProcess/mac/RemoteNetworkingContext.mm:

(WebKit::RemoteNetworkingContext::ensureWebsiteDataStoreSession):
(WebKit::RemoteNetworkingContext::ensurePrivateBrowsingSession): Deleted.

• Shared/WebsiteDataStoreParameters.cpp:

(WebKit::WebsiteDataStoreParameters::legacyPrivateSessionParameters):

• Shared/WebsiteDataStoreParameters.h:
• UIProcess/WebProcessPool.cpp:

(WebKit::WebProcessPool::setAnyPageGroupMightHavePrivateBrowsingEnabled):
(WebKit::WebProcessPool::createNewWebProcess):
(WebKit::WebProcessPool::pageAddedToProcess):

• WebProcess/InjectedBundle/InjectedBundle.cpp:

(WebKit::InjectedBundle::setPrivateBrowsingEnabled):

• WebProcess/WebCoreSupport/mac/WebFrameNetworkingContext.h:
• WebProcess/WebCoreSupport/mac/WebFrameNetworkingContext.mm:

(WebKit::WebFrameNetworkingContext::ensureWebsiteDataStoreSession):
(WebKit::WebFrameNetworkingContext::ensurePrivateBrowsingSession): Deleted.

• WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::setSessionID):

• WebProcess/WebProcess.cpp:

(WebKit::WebProcess::ensurePrivateBrowsingSession): Deleted.

• WebProcess/WebProcess.h:
• WebProcess/WebProcess.messages.in:

Source/WebKitLegacy/mac:

• WebCoreSupport/WebFrameNetworkingContext.mm:

(WebFrameNetworkingContext::ensurePrivateBrowsingSession):

3:25 PM Changeset in webkit [224790] by achristensen@apple.com

• 2 edits in trunk/Source/WebKit

Add logs to debug content extension test failures
​https://bugs.webkit.org/show_bug.cgi?id=179624

Reviewed by Chris Dumez.

• UIProcess/API/APIContentRuleListStore.cpp:

(API::compiledToFile):
Right now I'm seeing this log:
"Rule list compilation failed: Unspecified error during compile."
I need more information to debug what is failing on the bots.

3:21 PM Changeset in webkit [224789] by BJ Burg

• 14 edits
  1 add in trunk/Source

Web Automation: inViewCenterPoint should not include topContentInset when computed in viewport coordinates
​https://bugs.webkit.org/show_bug.cgi?id=179129
<rdar://problem/35297038>

Reviewed by Simon Fraser.

Source/WebCore:

Add or export some helpers needed to compute element layout for WebDriver.

• dom/Element.h: Export the non-DOM version of getClientBounds().
• page/FrameView.h:
• page/FrameView.cpp:

(WebCore::FrameView::clientToDocumentRect const):
Added. This does the same thing as clientToDocumentPoint. Export it, too.

Source/WebDriver:

Adjust code to use the proper coordinate system when requesting element layout.

• Session.cpp:

(WebDriver::Session::computeElementLayout):

Source/WebKit:

When computing the in view center point per W3C specification, the top content inset
is inadvertently added back in when converting to the root view coordinate system.

This patch reworks the protocol command so that it explicitly requests a coordinate
system, with options for "Page" (root / contents), "LayoutViewport", and "VisualViewport".
The latter is not implemented in this patch, since it is intended for use on iOS someday.

• UIProcess/Automation/Automation.json:

Change usesViewport to CoordinateSystem.
Add a new coordinate system enum type and use it.
Fix relevant comments for Automation.computElementLayout.

• UIProcess/Automation/WebAutomationSession.h:
• UIProcess/Automation/WebAutomationSession.cpp:

(WebKit::protocolStringToCoordinateSystem):
(WebKit::WebAutomationSession::computeElementLayout):
Parse the requested coordinate system and send it in the message to the web process.

• WebKit.xcodeproj/project.pbxproj:
• WebProcess/Automation/WebAutomationSessionProxy.messages.in:
• WebProcess/Automation/WebAutomationSessionProxy.h:
• WebProcess/Automation/WebAutomationSessionProxy.cpp:

(WebKit::WebAutomationSessionProxy::computeElementLayout):
Rework the implementation. Get the element bounds and in-view center point in
client coordinates and convert back to root view coordinates for CoordinateSystem::Page.

3:15 PM Changeset in webkit [224788] by Joseph Pecoraro

• 23 edits
  3 copies
  1 add in trunk/Source/WebCore

Web Inspector: Include a NetworkAgent in ServiceWorkers for network debugging
​https://bugs.webkit.org/show_bug.cgi?id=179513
<rdar://problem/35456402>

Reviewed by Brian Burg.

In order to show Network requests for a ServiceWorker, we need to add
inspector networking hooks for Worker loads. While we show Network
requests for DedicatedWorkers, we do that through the Page during Page
inspection. In ServiceWorker inspection, the remote connection is
connected to the ServiceWorkerThreadProxy, and interacts with the
WorkerGlobalScope without making any assumptions about a Page existing.
We don't want to make any assumptions about a Page/Document being needed
for Network hooks, so we should add new hooks that will work in the
WorkerGlobalScope's context.

This patch adds InspectorInstrumentation networking hooks for workers inside
of the WorkerThreadableLoader bridge. This is where the majority of Worker
initiated network requests happen (Fetch/XHR, but not WebSockets). The hooks
are simpler versions of the existing network hooks for a Page, and allow for
complete inspector networking information (will send, did receive response,
did receive data, success, failure, and timing metrics).

This patch generalizes InspectorNetworkAgent to work for a Page and Worker.
Some of the existing functionality was specific to a Page (frameId/loaderId)
but did not make sense for a Worker. In order to handle these cases, all
of the unique logic was extracted out into virtual methods that subclasses
PageNetworkAgent and WorkerNetworkAgent provide as appropriate. The majority
of NetworkAgent remains unchanged and algorithms are shared.

We needed to change the existing InspectorInstrumentation networking hooks
to allow for an optional DocumentLoader. This way we can keep all of the
same hooks leading inside of NetworkAgent, but loads for a Page will have a
DocumentLoader, and loads for a ServiceWorker will not.

While the WorkerNetworkAgent would work for a DedicatedWorker, we still
only create it for a ServiceWorker. The existing behavior of showing Network
loads for a DedicatedWorker will continue to go through the Page inspector
so we can avoid creating a NetworkAgent for DedicatedWorkers. If we created
a way to directly inspect a DedicatedWorker we could look at making this
always available, but it would require extra work to function perfectly.

• Sources.txt:
• WebCore.xcodeproj/project.pbxproj:
• inspector/InspectorAllInOne.cpp:

Add new files.

• inspector/InspectorController.cpp:

(WebCore::InspectorController::InspectorController):
(WebCore::InspectorController::createLazyAgents):
Switch from InspectorNetworkAgent to PageNetworkAgent.

• inspector/WorkerInspectorController.h:
• inspector/WorkerInspectorController.cpp:

(WebCore::WorkerInspectorController::WorkerInspectorController):
(WebCore::WorkerInspectorController::workerAgentContext):
(WebCore::WorkerInspectorController::createLazyAgents):
Create a WorkerNetworkAgent when inside of a ServiceWorker.
Also start the lazy agent pattern for agents that can defer
creation until a frontend attached.

(WebCore::WorkerInspectorController::connectFrontend):
(WebCore::WorkerInspectorController::disconnectFrontend):
When frontends connect/disconnect toggle the necessary states.
Also start the execution stopwatch, otherwise it will always be at 0.

• inspector/InspectorInstrumentation.cpp:

(WebCore::InspectorInstrumentation::willSendRequestImpl):
(WebCore::InspectorInstrumentation::willSendRequestOfTypeImpl):
(WebCore::InspectorInstrumentation::didLoadResourceFromMemoryCacheImpl):
(WebCore::InspectorInstrumentation::didReceiveResourceResponseImpl):
(WebCore::InspectorInstrumentation::didFinishLoadingImpl):
(WebCore::InspectorInstrumentation::didFailLoadingImpl):
(WebCore::InspectorInstrumentation::frameDetachedFromParentImpl):

• inspector/InspectorInstrumentation.h:

(WebCore::InspectorInstrumentation::willSendRequest):
(WebCore::InspectorInstrumentation::didReceiveResourceResponse):
(WebCore::InspectorInstrumentation::didReceiveData):
(WebCore::InspectorInstrumentation::didFinishLoading):
(WebCore::InspectorInstrumentation::didFailLoading):
Add Worker networking hooks that pass through to the same general hooks.

• loader/WorkerThreadableLoader.cpp:

(WebCore::WorkerThreadableLoader::MainThreadBridge::MainThreadBridge):
(WebCore::WorkerThreadableLoader::MainThreadBridge::didReceiveResponse):
(WebCore::WorkerThreadableLoader::MainThreadBridge::didReceiveData):
(WebCore::WorkerThreadableLoader::MainThreadBridge::didFinishLoading):
(WebCore::WorkerThreadableLoader::MainThreadBridge::didFail):
(WebCore::WorkerThreadableLoader::MainThreadBridge::didFinishTiming):

• loader/WorkerThreadableLoader.h:

Use the new worker networking instrumentation hooks.

• loader/ThreadableLoader.cpp:

(WebCore::ThreadableLoader::create):
Drive-by: use a move.

• inspector/agents/InspectorNetworkAgent.h:
• inspector/agents/InspectorNetworkAgent.cpp:

(WebCore::InspectorNetworkAgent::InspectorNetworkAgent):
(WebCore::InspectorNetworkAgent::willSendRequest):
(WebCore::InspectorNetworkAgent::willSendRequestOfType):
(WebCore::InspectorNetworkAgent::didReceiveResponse):
(WebCore::InspectorNetworkAgent::didFinishLoading):
(WebCore::InspectorNetworkAgent::didFailLoading):
(WebCore::InspectorNetworkAgent::didLoadResourceFromMemoryCache):
(WebCore::InspectorNetworkAgent::buildInitiatorObject):
(WebCore::InspectorNetworkAgent::enable):
(WebCore::InspectorNetworkAgent::disable):
(WebCore::InspectorNetworkAgent::setResourceCachingDisabled):
(WebCore::InspectorNetworkAgent::loadResource):
(WebCore::InspectorNetworkAgent::webSocketForRequestId):
(WebCore::InspectorNetworkAgent::resolveWebSocket):
(WebCore::InspectorNetworkAgent::mainFrameNavigated):
Extract logic for subclasses. Transition to DocumentLoader being null.

• inspector/agents/page/PageNetworkAgent.h:
• inspector/agents/page/PageNetworkAgent.cpp: Added.

(WebCore::PageNetworkAgent::PageNetworkAgent):
(WebCore::PageNetworkAgent::loaderIdentifier):
(WebCore::PageNetworkAgent::frameIdentifier):
(WebCore::PageNetworkAgent::setResourceCachingDisabled):
(WebCore::PageNetworkAgent::scriptExecutionContext):
Extracted Page implementation. This is just moving from the original.

• inspector/agents/worker/WorkerNetworkAgent.h:
• inspector/agents/worker/WorkerNetworkAgent.cpp:

(WebCore::WorkerNetworkAgent::WorkerNetworkAgent):
(WebCore::WorkerNetworkAgent::loaderIdentifier):
(WebCore::WorkerNetworkAgent::frameIdentifier):
(WebCore::WorkerNetworkAgent::setResourceCachingDisabled):
(WebCore::WorkerNetworkAgent::scriptExecutionContext):
Implement for a worker.

• inspector/agents/worker/WorkerDebuggerAgent.cpp:

(WebCore::WorkerDebuggerAgent::WorkerDebuggerAgent):

• inspector/agents/worker/WorkerConsoleAgent.cpp:

(WebCore::WorkerConsoleAgent::WorkerConsoleAgent):

• inspector/agents/worker/WorkerRuntimeAgent.cpp:

(WebCore::WorkerRuntimeAgent::WorkerRuntimeAgent):
Add some assertions for all Worker agents for clarify.

• workers/WorkerDebuggerProxy.h:
• workers/WorkerGlobalScope.h:

(WebCore::WorkerGlobalScope::identifier const):
(WebCore::WorkerGlobalScope::createUniqueIdentifier):
Provide a way to get unique identifiers in a worker. For the Page
this is done through the Page's ProgressTracker. For a Worker we just
put this on the WorkerGlobalScope. This is used for request ids.

• workers/WorkerMessagingProxy.h:
• workers/WorkerMessagingProxy.cpp:

(WebCore::WorkerMessagingProxy::setResourceCachingDisabled):

• workers/service/context/ServiceWorkerThreadProxy.h:
• workers/service/context/ServiceWorkerThreadProxy.cpp:

(WebCore::ServiceWorkerThreadProxy::setResourceCachingDisabled):
Add a debug method for disabling the resource cache from a worker.
In service workers this sets the override flag on the hidden page.

3:10 PM Changeset in webkit [224787] by keith_miller@apple.com

• 17 edits in trunk

Async iteration should only fetch the next method once and add feature flag
​https://bugs.webkit.org/show_bug.cgi?id=179451

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

Add feature flag for Async iteration. Also, change async iteration to match
the expected behavior of the proposal.

• Configurations/FeatureDefines.xcconfig:
• builtins/AsyncFromSyncIteratorPrototype.js:

(globalPrivate.createAsyncFromSyncIterator):
(globalPrivate.AsyncFromSyncIteratorConstructor):

• builtins/BuiltinNames.h:
• bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::emitGetAsyncIterator):

• runtime/Options.h:

Source/WebCore:

Add feature flag for Async iteration.

• Configurations/FeatureDefines.xcconfig:

Source/WebCore/PAL:

Add feature flag for Async iteration.

• Configurations/FeatureDefines.xcconfig:

Source/WebKit:

Add feature flag for Async iteration.

• Configurations/FeatureDefines.xcconfig:

Source/WebKitLegacy/mac:

Add feature flag for Async iteration.

• Configurations/FeatureDefines.xcconfig:

Tools:

Add feature flag for Async iteration.

• TestWebKitAPI/Configurations/FeatureDefines.xcconfig:

3:00 PM Changeset in webkit [224786] by achristensen@apple.com

• 2 edits in trunk/Source/WebCore

Call willPerformHTTPRedirection on WebCoreNSURLSession's delegate
​https://bugs.webkit.org/show_bug.cgi?id=179539

Reviewed by Jer Noble.

This is now possible!
This will allow AVFoundation to fix redirect-related bugs.

• platform/network/cocoa/WebCoreNSURLSession.mm:

(-[WebCoreNSURLSession addDelegateOperation:]):
(-[WebCoreNSURLSession resetWithCompletionHandler:]):
(-[WebCoreNSURLSession flushWithCompletionHandler:]):
(WebCore::WebCoreNSURLSessionDataTaskClient::redirectReceived):
(-[WebCoreNSURLSessionDataTask resource:shouldCacheResponse:]):
(-[WebCoreNSURLSessionDataTask resource:receivedData:length:]):
(-[WebCoreNSURLSessionDataTask resource:receivedRedirect:request:completionHandler:]):
(-[WebCoreNSURLSessionDataTask resource:receivedRedirect:request:]): Deleted.

3:00 PM Changeset in webkit [224785] by Chris Dumez

• 2 edits in trunk/Source/WebCore

Add some more assertions in SWServerJobQueue
​https://bugs.webkit.org/show_bug.cgi?id=179626

Reviewed by Alex Christensen.

Add some more assertions in SWServerJobQueue for extra safety.

• workers/service/server/SWServerJobQueue.cpp:

(WebCore::SWServerJobQueue::didResolveRegistrationPromise):
(WebCore::SWServerJobQueue::didFinishInstall):

2:58 PM Changeset in webkit [224784] by mark.lam@apple.com

• 10 edits
  1 add in trunk

Add more overflow check book-keeping for MarkedArgumentBuffer.
​https://bugs.webkit.org/show_bug.cgi?id=179634
<rdar://problem/35492517>

Reviewed by Saam Barati.

JSTests:

• stress/regress-179634.js: Added.

Source/JavaScriptCore:

• runtime/ArgList.h:

(JSC::MarkedArgumentBuffer::overflowCheckNotNeeded):

• runtime/JSJob.cpp:

(JSC::JSJobMicrotask::run):

• runtime/ObjectConstructor.cpp:

(JSC::defineProperties):

• runtime/ReflectObject.cpp:

(JSC::reflectObjectConstruct):

Source/WebKit:

• WebProcess/Plugins/Netscape/NPJSObject.cpp:

(WebKit::NPJSObject::construct):
(WebKit::NPJSObject::invoke):

Source/WebKitLegacy/mac:

• Plugins/Hosted/NetscapePluginInstanceProxy.mm:

(WebKit::NetscapePluginInstanceProxy::invoke):
(WebKit::NetscapePluginInstanceProxy::invokeDefault):
(WebKit::NetscapePluginInstanceProxy::construct):

2:52 PM Changeset in webkit [224783] by guijemont@igalia.com

• 2 edits in trunk/Source/JavaScriptCore

[JSC] Remove ARM implementation of branchTruncateDoubleToUInt32
​https://bugs.webkit.org/show_bug.cgi?id=179542

Reviewed by Alex Christensen.

• assembler/MacroAssemblerARM.h:

(JSC::MacroAssemblerARM::branchTruncateDoubleToUint32): Removed.

2:49 PM Changeset in webkit [224782] by timothy_horton@apple.com

• 2 edits in trunk/Source/WebKit

Address some post-landing review comments from r224728
​https://bugs.webkit.org/show_bug.cgi?id=179576

• Platform/IPC/mac/MachMessage.h:

(IPC::MachMessage::setMessageReceiverName):
(IPC::MachMessage::setMessageName):
More moving!

2:22 PM Changeset in webkit [224781] by timothy_horton@apple.com

• 2 edits in trunk/Source/WebKit

Occasional MobileSafari crash under -[WKPDFView web_setMinimumSize:]
​https://bugs.webkit.org/show_bug.cgi?id=179628
<rdar://problem/34773037>

Reviewed by Simon Fraser.

• UIProcess/ios/WKPDFView.mm:

(-[WKPDFView _computePageAndDocumentFrames]):
Similar to r223444, avoid propagating null CGRects into the view hierarchy.
In this case, the null rect comes from applying margins to a rect that is
smaller than the margins. We could check for that specifically, but a
more-general check for a null rect seems reasonable.

2:13 PM Changeset in webkit [224780] by pvollan@apple.com

• 14 edits in trunk

The css properties stroke-width/stroke-color and -webkit-text-stroke-width/-webkit-text-stroke-color should not be mixed.
​https://bugs.webkit.org/show_bug.cgi?id=174737

Reviewed by Antti Koivisto.

Source/WebCore:

Previously, the stroke width and stroke color would independently fall back to the -webkit-text-stroke-width and
-webkit-text-stroke-color values if stroke-width and/or stroke-color were not explicitly specified. This is
problematic, since we might end up mixing the new stroke properties with the legacy Webkit stroke properties.
The new strategy is to use the stroke-width and stroke-color value combination only if stroke-color has been
explicitly specified. This should work well, since there will be no visible stroke when specifying only
stroke-width (because stroke-color by default is transparent). We can then safely fall back to the legacy Webkit
stroke value combination. In the case where only stroke-color is specified, we should use the stroke-width/
stroke-color combination, since stroke-width by default is 1, and we will then have a visible stroke.

No new tests, existing tests have been updated to reflect behavior changes.

• rendering/TextDecorationPainter.cpp:

(WebCore::decorationColor):

• rendering/TextPaintStyle.cpp:

(WebCore::computeTextPaintStyle):
(WebCore::computeTextSelectionPaintStyle):

• rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::computedStrokeWidth const):
(WebCore::RenderStyle::hasPositiveStrokeWidth const):
(WebCore::RenderStyle::computedStrokeColor const):

• rendering/style/RenderStyle.h:

LayoutTests:

• fast/css/stroke-color-expected.html:
• fast/css/stroke-color-fallback-expected.html:
• fast/css/stroke-color-fallback.html:
• fast/css/stroke-color.html:
• fast/css/stroke-width-expected.html:
• fast/css/stroke-width-fallback-expected.html:
• fast/css/stroke-width-fallback.html:
• fast/css/stroke-width.html:

2:05 PM Changeset in webkit [224779] by timothy_horton@apple.com

• 3 edits in trunk/Source/WebKit

Use the real mach type instead of reinterpret_casting in MachMessage
​https://bugs.webkit.org/show_bug.cgi?id=179629

Reviewed by Dan Bernstein.

• Platform/IPC/mac/MachMessage.cpp:

(IPC::MachMessage::header):

• Platform/IPC/mac/MachMessage.h:

Just use mach_msg_header_t proper, and avoid the reinterpret_cast.
This also corrects the alignment of the struct on platforms where
alignof(mach_msg_header_t) != alignof(uint8_t).

1:45 PM Changeset in webkit [224778] by matthew_hanson@apple.com

• 7 edits in tags/Safari-605.1.13.2/Source

Versioning.

1:43 PM Changeset in webkit [224777] by matthew_hanson@apple.com

• 1 copy in tags/Safari-605.1.13.2

Tag Safari-605.1.13.2.

1:42 PM Changeset in webkit [224776] by commit-queue@webkit.org

• 8 edits in trunk

[GTK] Automatically adjust font size when gtk-xft-dpi changes
​https://bugs.webkit.org/show_bug.cgi?id=142673

Patch by Gabriel Ivascu <​givascu@igalia.com> on 2017-11-13
Reviewed by Michael Catanzaro.

Source/WebCore:

• platform/PlatformScreen.h:
• platform/gtk/PlatformScreenGtk.cpp:

(WebCore::gtkXftDPIChangedCallback):
(WebCore::setScreenDPIObserverHandler):

• platform/wpe/PlatformScreenWPE.cpp:

(WebCore::setScreenDPIObserverHandler):

Source/WebKit:

• UIProcess/API/glib/WebKitSettings.cpp:

(webKitSettingsDispose):
(webKitSettingsConstructed):
(webkit_settings_class_init):

Tools:

• TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:

(testWebKitSettings):

1:41 PM Changeset in webkit [224775] by commit-queue@webkit.org

• 3 edits
  2 deletes in trunk

Unreviewed, rolling out r224763.
​https://bugs.webkit.org/show_bug.cgi?id=179632

test fails on iOS (Requested by alexchristensen on #webkit).

Reverted changeset:

"Add tests to ensure that <source> tags are only preloaded
when the type"
​https://bugs.webkit.org/show_bug.cgi?id=179231
​https://trac.webkit.org/changeset/224763

1:29 PM Changeset in webkit [224774] by Jon Davis

• 2 edits in trunk/Websites/webkit.org

Update safe area CSS for webkit.org
​https://bugs.webkit.org/show_bug.cgi?id=179615

Reviewed by Alexey Proskuryakov.

• wp-content/themes/webkit/style.css:

(@media only screen and (max-height: 415px)):
(@supports(padding:max(0px))):

1:14 PM Changeset in webkit [224773] by Antti Koivisto

• 4 edits in trunk

Don't eliminate whitespace renderer if the previous sibling is a text renderer
​https://bugs.webkit.org/show_bug.cgi?id=179620

Reviewed by Zalan Bujtas.

Source/WebCore:

Currently whitespace elimination code doesn't consider runs of text renderers. We should always make whitespace
renderer if the previous renderer is a text renderer. The behavior should be the same as if those were a single
renderer with merged text. This situation can happen easily with display:contents.

This fixes the remaining flexbox failures in display:contents tests.

• style/RenderTreeUpdater.cpp:

(WebCore::RenderTreeUpdater::textRendererIsNeeded):

We need a renderer if the previous rendere is RenderText.

LayoutTests:

• TestExpectations:

1:06 PM Changeset in webkit [224772] by Chris Dumez

• 17 edits
  3 adds in trunk

Implement "Service Worker Has No Pending Events" / "Update Service Worker Extended Events Set" algorithms
​https://bugs.webkit.org/show_bug.cgi?id=179618

Reviewed by Brady Eidson.

Source/WebCore:

Implement "Service Worker Has No Pending Events" / "Update Service Worker Extended Events Set" algorithms:

• ​https://w3c.github.io/ServiceWorker/#service-worker-has-no-pending-events-algorithm
• ​https://w3c.github.io/ServiceWorker/#update-service-worker-extended-events-set-algorithm

Test: http/tests/workers/service/basic-unregister-then-register-again-reuse.html

• workers/service/context/SWContextManager.h:
• workers/service/context/ServiceWorkerFetch.cpp:

(WebCore::ServiceWorkerFetch::dispatchFetchEvent):

• workers/service/context/ServiceWorkerFetch.h:
• workers/service/context/ServiceWorkerThread.cpp:

(WebCore::ServiceWorkerThread::postFetchTask):
(WebCore::ServiceWorkerThread::postMessageToServiceWorkerGlobalScope):
(WebCore::ServiceWorkerThread::updateExtendedEventsSet):

• workers/service/context/ServiceWorkerThread.h:
• workers/service/server/SWServer.cpp:

(WebCore::SWServer::Connection::setServiceWorkerHasPendingEvents):
(WebCore::SWServer::setServiceWorkerHasPendingEvents):

• workers/service/server/SWServer.h:
• workers/service/server/SWServerJobQueue.cpp:

(WebCore::SWServerJobQueue::tryActivate):
(WebCore::SWServerJobQueue::tryClearRegistration):

• workers/service/server/SWServerWorker.h:

(WebCore::SWServerWorker::hasPendingEvents const):
(WebCore::SWServerWorker::setHasPendingEvents):

Source/WebKit:

• StorageProcess/StorageProcess.cpp:

(WebKit::StorageProcess::setServiceWorkerHasPendingEvents):

• StorageProcess/StorageProcess.h:
• StorageProcess/StorageProcess.messages.in:
• WebProcess/Storage/WebSWContextManagerConnection.cpp:

(WebKit::WebSWContextManagerConnection::setServiceWorkerHasPendingEvents):

• WebProcess/Storage/WebSWContextManagerConnection.h:

LayoutTests:

Add layout test coverage.

• http/tests/workers/service/basic-unregister-then-register-again-reuse-expected.txt: Added.
• http/tests/workers/service/basic-unregister-then-register-again-reuse.html: Added.
• http/tests/workers/service/resources/basic-unregister-then-register-again-reuse-worker.js: Added.

(event.waitUntil.new.Promise):
(setTimeout):

1:02 PM Changeset in webkit [224771] by Ryan Haddad

• 3 edits in trunk/LayoutTests

Adjust TestExpectation for js/intl-datetimeformat.html.
​https://bugs.webkit.org/show_bug.cgi?id=179208

Unreviewed test gardening.

• platform/mac-wk2/TestExpectations:
• platform/mac/TestExpectations:

12:18 PM Changeset in webkit [224770] by mark.lam@apple.com

• 3 edits
  1 add in trunk

Make the jsc shell loadGetterFromGetterSetter() function more robust.
​https://bugs.webkit.org/show_bug.cgi?id=179619
<rdar://problem/35492518>

Reviewed by Saam Barati.

JSTests:

• stress/regress-179619.js: Added.

Source/JavaScriptCore:

• jsc.cpp:

(functionLoadGetterFromGetterSetter):

12:16 PM Changeset in webkit [224769] by Joseph Pecoraro

• 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Network Details Views - make section headers more prominent
​https://bugs.webkit.org/show_bug.cgi?id=179565
<rdar://problem/35510531>

Reviewed by Devin Rousso.

• UserInterface/Views/ResourceDetailsSection.css:

(.resource-details > section > .title):

11:59 AM Changeset in webkit [224768] by Nikita Vasilyev

• 3 edits in trunk/Source/WebInspectorUI

Web Inspector: Styles Redesign: make selector field inline-block when editing
​https://bugs.webkit.org/show_bug.cgi?id=179588
<rdar://problem/35490915>

Reviewed by Brian Burg.

• UserInterface/Views/SpreadsheetCSSStyleDeclarationSection.css:

(.spreadsheet-css-declaration .header.editing-selector .origin):
When the selector field is multiline, it covers the source link entirely.
When the selector field takes only one line, the source link remains where it was before editing.

(.spreadsheet-css-declaration .selector):
Make it position: relative to cover the source link.

(.spreadsheet-css-declaration .selector.spreadsheet-selector-field.editing):

• UserInterface/Views/SpreadsheetCSSStyleDeclarationSection.js:

(WI.SpreadsheetCSSStyleDeclarationSection.prototype.initialLayout):

11:58 AM Changeset in webkit [224767] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebInspectorUI

REGRESSION(r223856): Web Inspector: Cannot view Request Data
​https://bugs.webkit.org/show_bug.cgi?id=179567

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2017-11-13
Reviewed by Brian Burg.

• UserInterface/Views/ResourceClusterContentView.js:

(WI.ResourceClusterContentView.prototype._canShowRequestContentView):
This condition unintentionally got flipped in r223856.

11:57 AM Changeset in webkit [224766] by Matt Baker

• 4 edits
  1 add in trunk/Source/WebInspectorUI

Web Inspector: Add CheckboxNavigationItem
​https://bugs.webkit.org/show_bug.cgi?id=179584
<rdar://problem/35490085>

Reviewed by Brian Burg.

• UserInterface/Main.html:
• UserInterface/Views/ButtonNavigationItem.css:

(.navigation-bar .item.button.text-only.checkbox):
(.navigation-bar .item.button.text-only.checkbox label):

• UserInterface/Views/ButtonNavigationItem.js:

Cleanup and some tweaks to the label to make it work with subclasses
regardless of how label is represented in the DOM.

(WI.ButtonNavigationItem):
(WI.ButtonNavigationItem.prototype.get toolTip):
(WI.ButtonNavigationItem.prototype.set toolTip):
(WI.ButtonNavigationItem.prototype.get label):
(WI.ButtonNavigationItem.prototype.set label):
(WI.ButtonNavigationItem.prototype.set image):
(WI.ButtonNavigationItem.prototype.get enabled):
(WI.ButtonNavigationItem.prototype.set enabled):
(WI.ButtonNavigationItem.prototype.updateButtonText):

• UserInterface/Views/CheckboxNavigationItem.js: Added.

New button item with a checkbox and label. Dispatches a Clicked evennt
whenever the checked state changes.

(WI.CheckboxNavigationItem):
(WI.CheckboxNavigationItem.prototype.get checked):
(WI.CheckboxNavigationItem.prototype.set checked):
(WI.CheckboxNavigationItem.prototype.get additionalClassNames):
(WI.CheckboxNavigationItem.prototype.updateButtonText):
(WI.CheckboxNavigationItem.prototype._checkboxChanged):

11:55 AM Changeset in webkit [224765] by Jonathan Bedard

• 2 edits in trunk/Tools

check-webkit-style cannot construct valid iOS version without an iOS SDK
​https://bugs.webkit.org/show_bug.cgi?id=179616
<rdar://problem/35507018>

Reviewed by David Kilzer.

Instead of throwing an exception when we ask for an unavailable SDK on Mac,
we should return None.

• Scripts/webkitpy/common/system/platforminfo.py:

(PlatformInfo.xcode_sdk_version): Return 'None' version if the machine does not
have the requested SDK.

11:47 AM Changeset in webkit [224764] by keith_miller@apple.com

• 2 edits in trunk/Tools

Uninitialized variable in sort-Xcode-project-file
​https://bugs.webkit.org/show_bug.cgi?id=179581

Reviewed by Simon Fraser.

Previously all the unified source files were named
UnifiedSource<some-number>.mm. This was changed to
UnifiedSource<some-number>-mm.mm to stop Xcode from creating
hashes for mm and cpp unified source files with the same
number. This broke the expectations in sort-Xcode-project-file.

• Scripts/sort-Xcode-project-file:

(sortChildrenByFileName):
(sortFilesByFileName):

11:33 AM Changeset in webkit [224763] by achristensen@apple.com

• 3 edits
  2 adds in trunk

Source/WebCore:
Added mime type check to the picture source preloader to avoid downloading incompatible resources.
​https://bugs.webkit.org/show_bug.cgi?id=179231

Patch by Colin Bendell <colin> on 2017-11-13
Reviewed by Alex Christensen.

Test: http/tests/loading/preload-picture-type.html

• html/parser/HTMLPreloadScanner.cpp:

(WebCore::TokenPreloadScanner::StartTagScanner::processAttributes): include type match state when selecting candidate imgs
(WebCore::TokenPreloadScanner::StartTagScanner::processAttribute): added type attribute evaluation and matching

LayoutTests:
Add tests to ensure that <source> tags are only preloaded when the type
attribute matches.
​https://bugs.webkit.org/show_bug.cgi?id=179231

Patch by Colin Bendell <colin> on 2017-11-13
Reviewed by Alex Christensen.

• http/tests/preload/picture-type-expected.txt: Added.
• http/tests/preload/picture-type.html: Added.

11:19 AM Changeset in webkit [224762] by jfbastien@apple.com

• 4 edits in trunk

std::expected: fix and test move
​https://bugs.webkit.org/show_bug.cgi?id=179617

Reviewed by Alex Christensen.

Source/WTF:

Non-copyable move types should be able to be in an expected
properly.

• wtf/Expected.h:

(WTF::Expected::value const):
(WTF::Expected::error):
(WTF::Expected::error const):

Tools:

Test that unique_ptr can be moved around properly, both has a
value and an error (and in a <void, unique> specialization).

• TestWebKitAPI/Tests/WTF/Expected.cpp:

(TestWebKitAPI::snowflake::reset):
(TestWebKitAPI::snowflake::snowflake):
(TestWebKitAPI::snowflake::~snowflake):
(TestWebKitAPI::TEST):

11:17 AM Changeset in webkit [224761] by commit-queue@webkit.org

• 4 edits in trunk/Source/WebInspectorUI

Web Inspector: Give DataGrid/Table Header ContextMenu a section header to better describe its functions
​https://bugs.webkit.org/show_bug.cgi?id=179560

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2017-11-13
Reviewed by Matt Baker.

• Localizations/en.lproj/localizedStrings.js:

New string.

• UserInterface/Views/DataGrid.js:

(WI.DataGrid.prototype._contextMenuInHeader):

• UserInterface/Views/Table.js:

(WI.Table.prototype._handleHeaderContextMenu):
Include a disabled context menu item as a section header.

11:14 AM Changeset in webkit [224760] by graouts@webkit.org

• 21 edits
  1 copy
  7 adds in trunk

[Web Animations] Implement getAnimations()
​https://bugs.webkit.org/show_bug.cgi?id=179535
<rdar://problem/34932475>

Reviewed by Simon Fraser.

Source/WebCore:

We now allow a list of animations for a document, with Document.getAnimations(), or for an
element, with Animatable.getAnimations(), to be returned. In order to support this, we maintain
a map on AnimationTimeline of all animations for a given element. This map is invalidated
when an animation's timeline changes and when an animation's effect changes. Note that the
Web Animations spec mandates that an AnimationEffect can only be a single animation's effect.

Tests: http/wpt/wk-web-animations/interfaces/document-get-animations.html

http/wpt/wk-web-animations/interfaces/element-get-animations.html
http/wpt/wk-web-animations/timing-model/animation-effect-unique-relationship.html

• CMakeLists.txt: Add Animatable.idl.
• DerivedSources.make: Add Animatable.idl.
• WebCore.xcodeproj/project.pbxproj: Add Animatable.idl.
• animation/Animatable.idl: A new interface that Element implements and which currently only exposes

getAnimations(), the animate() method will be added later.

• animation/AnimationEffect.h: Add a new m_animation member to reference the animation using this

effect. This relationship is required so we guarantee that an effect is associated with a single
animation at most.
(WebCore::AnimationEffect::animation const):
(WebCore::AnimationEffect::setAnimation):

• animation/AnimationTimeline.cpp:

(WebCore::AnimationTimeline::animationWasAddedToElement): New method to notify the timeline that an
animation registered with this timeline has been associated with a new element through its effect.
(WebCore::AnimationTimeline::animationWasRemovedFromElement): New method to notify the timeline that an
animation registered with this timeline has been disassociated with an element through its effect.
(WebCore::AnimationTimeline::animationsForElement): New method returning all animations registered with
this timeline for a given element.

• animation/AnimationTimeline.h:

(WebCore::AnimationTimeline::animations const): All animations registered with this timeline.

• animation/DocumentTimeline.cpp:

(WebCore::DocumentTimeline::DocumentTimeline):
(WebCore::DocumentTimeline::detachFromDocument): Clear the reference between this timeline and its document.
(WebCore::DocumentTimeline::currentTime): Protect against a null Document reference.
(WebCore::DocumentTimeline::createDisplayRefreshMonitor const): Protect against a null Document reference.

• animation/DocumentTimeline.h:
• animation/WebAnimation.cpp:

(WebCore::WebAnimation::create):
(WebCore::WebAnimation::setEffect): As an animation's effect changes, we need to ensure that the old
effect no longer has an associated animation, and that the new effect is associated with this animation.
Additionally, we update the element-to-animations map on the animation's timeline.
(WebCore::WebAnimation::setTimeline): Update the element-to-animations map on the former and new timeline.

• dom/Document.cpp:

(WebCore::Document::prepareForDestruction): Clear the relationship between this document and its timeline.
(WebCore::Document::getAnimations): Obtain all animations associated with this document's timeline.

• dom/Document.h:
• dom/Document.idl:
• dom/Element.cpp:

(WebCore::Element::getAnimations): Obtain all animations associated with this element.

• dom/Element.h:
• dom/Element.idl:
• testing/Internals.cpp:

• CMakeLists.txt:
• DerivedSources.make:
• WebCore.xcodeproj/project.pbxproj:
• animation/Animatable.idl:
• animation/AnimationEffect.h:

(WebCore::AnimationEffect::animation const):
(WebCore::AnimationEffect::setAnimation):

• animation/AnimationTimeline.cpp:

(WebCore::AnimationTimeline::animationWasAddedToElement):
(WebCore::AnimationTimeline::animationWasRemovedFromElement):
(WebCore::AnimationTimeline::animationsForElement):

• animation/AnimationTimeline.h:

(WebCore::AnimationTimeline::animations const):

• animation/DocumentTimeline.cpp:

(WebCore::DocumentTimeline::DocumentTimeline):
(WebCore::DocumentTimeline::detachFromDocument):
(WebCore::DocumentTimeline::currentTime):
(WebCore::DocumentTimeline::createDisplayRefreshMonitor const):

• animation/DocumentTimeline.h:
• animation/WebAnimation.cpp:

(WebCore::WebAnimation::create):
(WebCore::WebAnimation::setEffect):
(WebCore::WebAnimation::setTimeline):

• dom/Document.cpp:

(WebCore::Document::prepareForDestruction):
(WebCore::Document::getAnimations):

• dom/Document.h:
• dom/Document.idl:
• dom/Element.cpp:

(WebCore::Element::getAnimations):

• dom/Element.h:
• dom/Element.idl:
• testing/Internals.cpp:

LayoutTests:

Update WPT expectations per new progressions and add three new tests that check the behavior of
Document.getAnimations(), Element.getAnimations() and the unique relationship between an Animation
and an AnimationEffect.

• http/wpt/web-animations/interfaces/Animatable/animate-expected.txt:
• http/wpt/web-animations/interfaces/Animatable/getAnimations-expected.txt:
• http/wpt/web-animations/interfaces/Document/getAnimations-expected.txt:
• http/wpt/wk-web-animations/interfaces/document-get-animations-expected.txt: Added.
• http/wpt/wk-web-animations/interfaces/document-get-animations.html: Added.
• http/wpt/wk-web-animations/interfaces/element-get-animations-expected.txt: Added.
• http/wpt/wk-web-animations/interfaces/element-get-animations.html: Added.
• http/wpt/wk-web-animations/timing-model/animation-effect-unique-relationship-expected.txt: Added.
• http/wpt/wk-web-animations/timing-model/animation-effect-unique-relationship.html: Added.

10:55 AM Changeset in webkit [224759] by commit-queue@webkit.org

• 2 edits in trunk/Tools

[Windows] Make the port's normalize_test_name() method platform independent.
​https://bugs.webkit.org/show_bug.cgi?id=179572

Patch by Basuke Suzuki <Basuke Suzuki> on 2017-11-13
Reviewed by Alexey Proskuryakov.

• Scripts/webkitpy/port/base.py:

(Port.normalize_test_name):

10:32 AM Changeset in webkit [224758] by achristensen@apple.com

• 6 edits in trunk/Source/WebCore

Make DocumentLoader::willSendRequest asynchronous
​https://bugs.webkit.org/show_bug.cgi?id=179549

Reviewed by Tim Horton.

No change in behavior, except now redirects will wait for PolicyChecker::checkNavigationPolicy's completion handler.
Before, they would just continue in DocumentLoader::redirectReceived hoping the client had responded to
decidePolicyForNavigationAction synchronously or that the client would have been ok with continuing.

• loader/DocumentLoader.cpp:

(WebCore::DocumentLoader::redirectReceived):
(WebCore::DocumentLoader::willSendRequest):
(WebCore::DocumentLoader::startLoadingMainResource):

• loader/DocumentLoader.h:
• loader/FrameLoader.cpp:

(WebCore::FrameLoader::loadURL):
(WebCore::FrameLoader::loadWithDocumentLoader):

• loader/PolicyChecker.cpp:

(WebCore::PolicyChecker::checkNavigationPolicy):

• loader/PolicyChecker.h:

9:40 AM Changeset in webkit [224757] by Jon Davis

• 17 edits
  5 adds in trunk/Websites/webkit.org

Add a new landing page design and site-wide design detail updates for webkit.org
​https://bugs.webkit.org/show_bug.cgi?id=179558

Reviewed by Alexey Proskuryakov.

• wp-content/themes/webkit/404.php: Removed unnecessary prefixed CSS.
• wp-content/themes/webkit/444.php: Removed unnecessary prefixed CSS.
• wp-content/themes/webkit/css-status.php: Removed unnecessary prefixed CSS.
• wp-content/themes/webkit/footer.php: Added new page wrapper container.
• wp-content/themes/webkit/front-header.php: Redesigned landing hero.
• wp-content/themes/webkit/functions.php: Added support for configurable non-breaking words.
• wp-content/themes/webkit/header.php: Added viewport-fit, changed web font, changed logo title.
• wp-content/themes/webkit/images/chevron.svg: Added.
• wp-content/themes/webkit/images/circular.svg: Added.
• wp-content/themes/webkit/images/compass.svg: Added.
• wp-content/themes/webkit/images/download-white.svg: Added.
• wp-content/themes/webkit/images/template.svg: Added.
• wp-content/themes/webkit/loop.php: Updated "read more" link presentation.
• wp-content/themes/webkit/nightly-start.php: Adjusted header background colors.
• wp-content/themes/webkit/nightly-survey.php: Adjusted header background colors.
• wp-content/themes/webkit/nightly.php: Adjusted header background colors.
• wp-content/themes/webkit/page.php: Page clean up.
• wp-content/themes/webkit/single.php: Updated "read more" link presentation.
• wp-content/themes/webkit/status.php: Removed unnecessary prefixed CSS, improved page title.
• wp-content/themes/webkit/style.css: Redesigned.

(html):
(body):
(strong):
(em):
(code):
(main):
(h1,):
(input[type=text]):
(input[type=submit]):
(header):
(.home header):
(@supports ( -webkit-backdrop-filter: blur(10px) )):
(.sub-menu-layer):
(.nextrouter .link,):
(.pagination):
(.pagination::after):
(.pagination .page-numbers):
(.pagination .dots,):
(.pagination .next-button):
(.nextrouter):
(.nextrouter:hover):
(.nextrouter.previous):
(.nextrouter.previous:hover):
(.nextrouter .bodycopy):
(.nextrouter a):
(.nextrouter a:hover):
(.nextrouter-copy):
(.nextrouter .label):
(.nextrouter .title):
(.nextrouter .link):
(.nextrouter a:hover .link):
(footer):
(.tiles):
(.tile):
(.third-tile):
(.two-thirds-tile):
(.tile .background-image):
(.tile .background-image.has-featured-image):
(.tile .featured-image):
(.tile:not(.has-post-thumbnail) .background-image,):
(.tile h1):
(.tile h2):
(.tile .summary,):
(pre):
(article):
(article::after):
(article h1):
(article h2):
(article h3):
(article h4):
(article h5):
(article h6):
(article h2 + h3,):
(article figcaption):
(article figcaption::before):
(.table-of-contents):
(article .table-of-contents label):
(.table-of-contents ul):
(.table-of-contents ul li):
(.table-of-contents ul li > ul):
(.site-logo):
(footer nav):
(header nav li):
(header nav a,):
(header .menu-item-has-children .label-toggle::after):
(header .menu-item):
(@media only screen and (max-width: 1180px)):
(article .byline):
(@media only screen and (max-width: 920px)):
(.main-menu.label-toggle):
(header .menu):
(header nav a):
(header .menu-main-menu-container > ul > li):
(header .sub-menu-layer):
(@media only screen and (max-width: 690px)):
(.third-tile,):
(@media only screen and (max-width: 600px)):
(.table-of-contents label:after):
(@media only screen and (max-width: 415px)):
(@media only screen and (max-height: 415px)):
(@supports(padding:max(0px))):
(header .menu .menu-item > .sub-menu):
(.sub-menu-layer .menu-item:first-child,):
(#template):
(#compass):
(.tile .featured-image,): Deleted.
(.site-logo .tagline): Deleted.
(.timeline): Deleted.
(.timeline:after): Deleted.
(.timeline *): Deleted.
(.timeline:before): Deleted.
(.timeline > li): Deleted.
(.timeline > li:before): Deleted.
(.timeline .content): Deleted.
(.timeline figure): Deleted.
(.timeline .time): Deleted.
(.timeline h2, .timeline h3): Deleted.
(.timeline .time::before): Deleted.
(.timeline img): Deleted.
(@media (min-width: 900px)): Deleted.
(.timeline > li.force-clear): Deleted.
(.timeline > li:nth-child(odd)): Deleted.
(.timeline > li:nth-child(even)): Deleted.
(.timeline > li:nth-child(2),): Deleted.
(.timeline li .time): Deleted.
(.timeline li:nth-child(odd) .time): Deleted.
(.timeline li:nth-child(even) .time): Deleted.
(.timeline li:nth-child(even) .time::before): Deleted.
(.timeline > li:nth-child(even):before): Deleted.
(@media (max-width: 900px)): Deleted.
(.timeline li .time::before): Deleted.
(.hero .logo,): Deleted.
(.home .hero): Deleted.
(.home.admin-bar .hero): Deleted.
(@media only screen and (max-width: 320px)): Deleted.

• wp-content/themes/webkit/widgets/post.php: Updated "read more" link presentation.

7:57 AM Changeset in webkit [224756] by pvollan@apple.com

• 2 edits in trunk/LayoutTests

Mark editing/execCommand/underline-selection-containing-image.html as failing on Windows.
​https://bugs.webkit.org/show_bug.cgi?id=179613

Unreviewed test gardening.

• platform/win/TestExpectations:

7:30 AM Changeset in webkit [224755] by Wenson Hsieh

• 22 edits in trunk

[Attachment Support] Implement SPI for clients to request data for a given attachment
​https://bugs.webkit.org/show_bug.cgi?id=179586
<rdar://problem/35355720>

Reviewed by Darin Adler.

Source/WebCore:

Adds support in WebCore for fetching data for a given attachment element. See per-method comments below for
more detail.

Test coverage by augmenting existing API tests in WKAttachmentTests, and adding 3 new tests.

• dom/Document.cpp:

(WebCore::Document::didInsertAttachmentElement):
(WebCore::Document::didRemoveAttachmentElement):
(WebCore::Document::attachmentForIdentifier const):

Fetches an attachment element matching the given identifier. Using the identifier => attachment element map here
allows us to avoid the cost of walking the DOM in search for HTMLAttachmentElements every time data is
requested.

• dom/Document.h:

Add a map of attachment identifier => HTMLAttachmentElement in Document. This map is updated when attachment
elements are connected to or disconnected from the document. Additionally, delegate attachment insertion and
removal out to the Editor if possible.

• editing/Editor.cpp:

(WebCore::Editor::insertAttachmentFromFile):

• editing/mac/WebContentReaderMac.mm:

(WebCore::WebContentReader::readFilenames):

• editing/markup.cpp:

(WebCore::createFragmentFromMarkup):

Tweak existing logic that transfers file-backed File objects when deserializing HTMLAttachmentElements from
markup to handle the case where the attachment element is not file-backed. In this case, we construct a new
File object using the deserializing constructor. To do this, we use the attachment element's blob URL to make
sure that the new File references an existing blob matching that URL.

• html/HTMLAttachmentElement.cpp:

(WebCore::AttachmentDataReader::create):
(WebCore::AttachmentDataReader::AttachmentDataReader):

Introduce AttachmentDataReader, a helper class local to HTMLAttachmentElement that is responsible for loading
an attachment element's file and invoking a given callback when loading has succeeded or failed.
Each AttachmentDataReader is retained exclusively by its HTMLAttachmentElement, through the
HTMLAttachmentElement's vector of unique_ptrs to AttachmentDataReaders.

(WebCore::HTMLAttachmentElement::~HTMLAttachmentElement):
(WebCore::HTMLAttachmentElement::blobURL const):

Add a convenience getter for the blob URL of the attachment's backing File object.

(WebCore::HTMLAttachmentElement::setFile):

When setting an attachment element's file, set the blob URL attribute as well to the blob URL. Also, tweak this
to take a RefPtr<File>&& instead of a raw File*.

(WebCore::HTMLAttachmentElement::insertedIntoAncestor):
(WebCore::HTMLAttachmentElement::removedFromAncestor):

Instead of delegating attachment insertion and removal to the Editor, just call out to the Document, which will
now call out to the Editor.

(WebCore::HTMLAttachmentElement::attachmentPath const):

Add a convenience getter for the attachment path attribute.

(WebCore::HTMLAttachmentElement::requestData):
(WebCore::HTMLAttachmentElement::destroyReader):

Called when a AttachmentDataReader has completed (either with success or failure), and is ready to be removed
from the attachment element's list of active data readers.

(WebCore::AttachmentDataReader::~AttachmentDataReader):
(WebCore::AttachmentDataReader::didFinishLoading):
(WebCore::AttachmentDataReader::didFail):
(WebCore::AttachmentDataReader::invokeCallbackAndFinishReading):

When the reader is done loading, or has failed, or is about to be destroyed, fire the callback with loaded data
(if any) and cancel the FileReaderLoader.

• html/HTMLAttachmentElement.h:
• html/HTMLAttributeNames.in:

Adds a new "webkitattachmentbloburl" attribute that keeps track of an attachment element's file's blob URL. This
is used to ensure that information about an attachment element's file is not lost between certain editing
operations (for instance, deleting a line break) that involve serializing and then deserializing markup into
DocumentFragments to then insert.

Source/WebKit:

Adds support in WebKit for fetching data for a given attachment element. See WebCore/ChangeLog for more details.
Most of the changes here are boilerplate plumbing of -requestAttachmentData through the client layers.

Test coverage by augmenting existing API tests in WKAttachmentTests, and adding 3 new tests.

• UIProcess/API/APIAttachment.cpp:

(API::Attachment::requestData):

• UIProcess/API/APIAttachment.h:
• UIProcess/API/Cocoa/_WKAttachment.h:
• UIProcess/API/Cocoa/_WKAttachment.mm:

(-[_WKAttachment requestData:]):

• UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::sharedBufferCallback):

Add a new IPC callback helper type, SharedBufferCallback. This is similar to the existing DataCallback, but
instead of deserializing to an API::Data, we convert to a SharedBuffer instead. Additionally,
SharedBufferCallback is able to draw a distinction between null data and empty data. This allows -requestData:
to distinguish between cases where (for instance) the data for a given attachment is an empty blob, and when
the attachment doesn't exist at all.

(WebKit::WebPageProxy::dataCallback):
(WebKit::WebPageProxy::insertAttachment):
(WebKit::WebPage::invokeSharedBufferCallback):
(WebKit::WebPageProxy::requestAttachmentData):

• UIProcess/WebPageProxy.h:
• UIProcess/WebPageProxy.messages.in:
• WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::requestAttachmentData):

• WebProcess/WebPage/WebPage.h:
• WebProcess/WebPage/WebPage.messages.in:

Tools:

Augments existing API tests in WKAttachmentTests to additionally check that -requestData: yields the correct
result when performing various editing operations. Also adds a new API test that cuts and pastes an attachment
inserted using WKWebView attachment SPI, and expects that the data of the attachment can still be fetched using
the _WKAttachment SPI, as well as another test that inserts an empty NSData and expects that requestData: also
yields an empty NSData result.

• TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:

(-[NSData shortDescription]):
(-[_WKAttachment synchronouslyRequestData:]):
(-[_WKAttachment expectRequestedDataToBe:]):
(TestWebKitAPI::TEST):

6:50 AM Changeset in webkit [224754] by zandobersek@gmail.com

• 7 edits in trunk/Source/WebCore

[Cairo] Remove GraphicsContext::mustUseShadowBlur()
​https://bugs.webkit.org/show_bug.cgi?id=179612

Reviewed by Michael Catanzaro.

Remove the Cairo-specific mustUseShadowBlur() method on the
GraphicsContext class. It can now be implemented as a static function
in CairoOperations, using only a PlatformContextCairo object and a
const reference to the relevant GraphicsContextState.

No new tests -- no change in behavior.

• platform/graphics/GraphicsContext.cpp:

(WebCore::GraphicsContext::mustUseShadowBlur const): Deleted.

• platform/graphics/GraphicsContext.h:
• platform/graphics/cairo/CairoOperations.cpp:

(WebCore::Cairo::mustUseShadowBlur):
(WebCore::Cairo::drawGlyphsShadow):
(WebCore::Cairo::fillRectWithRoundedHole):
(WebCore::Cairo::drawGlyphs):

• platform/graphics/cairo/CairoOperations.h:
• platform/graphics/cairo/FontCairo.cpp:

(WebCore::FontCascade::drawGlyphs):

• platform/graphics/cairo/GraphicsContextCairo.cpp:

(WebCore::GraphicsContext::fillRectWithRoundedHole):

5:41 AM Changeset in webkit [224753] by zandobersek@gmail.com

• 4 edits in trunk/Source/WebCore

[Cairo] Move state change operations from GraphicsContextCairo to CairoOperations
​https://bugs.webkit.org/show_bug.cgi?id=179610

Reviewed by Carlos Garcia Campos.

Move operations that perform Cairo state changes to the CairoOperations
file. This enforces only using the PlatformContextCairo object to
achieve the state change, leveraging the cairo_t and ShadowBlur objects
that are owned by PlatformContextCairo.

Along with state modification operations, various state query operations
are also placed under the Cairo::State namespace, again limited to the
PlatformContextCairo object.

No new tests -- no change in behavior.

• platform/graphics/cairo/CairoOperations.cpp:

(WebCore::Cairo::State::setStrokeThickness):
(WebCore::Cairo::State::setGlobalAlpha):
(WebCore::Cairo::State::setCompositeOperation):
(WebCore::Cairo::State::setShouldAntialias):
(WebCore::Cairo::State::setImageInterpolationQuality):
(WebCore::Cairo::State::setCTM):
(WebCore::Cairo::State::getCTM):
(WebCore::Cairo::State::setShadowValues):
(WebCore::Cairo::State::clearShadow):
(WebCore::Cairo::State::getClipBounds):
(WebCore::Cairo::State::roundToDevicePixels):
(WebCore::Cairo::State::isAcceleratedContext):

• platform/graphics/cairo/CairoOperations.h:
• platform/graphics/cairo/GraphicsContextCairo.cpp:

(WebCore::GraphicsContext::getCTM const):
(WebCore::GraphicsContext::restorePlatformState):
(WebCore::GraphicsContext::clipBounds const):
(WebCore::GraphicsContext::roundToDevicePixels):
(WebCore::GraphicsContext::setPlatformStrokeThickness):
(WebCore::GraphicsContext::setCTM):
(WebCore::GraphicsContext::setPlatformShadow):
(WebCore::GraphicsContext::clearPlatformShadow):
(WebCore::GraphicsContext::setPlatformAlpha):
(WebCore::GraphicsContext::setPlatformCompositeOperation):
(WebCore::GraphicsContext::setPlatformShouldAntialias):
(WebCore::GraphicsContext::setPlatformImageInterpolationQuality):
(WebCore::GraphicsContext::isAcceleratedContext const):

5:33 AM Changeset in webkit [224752] by zandobersek@gmail.com

• 3 edits in trunk/Source/WebCore

[Cairo] Move glyph drawing operations from FontCairo to CairoOperations
​https://bugs.webkit.org/show_bug.cgi?id=179609

Reviewed by Carlos Garcia Campos.

Move operations that perform glyph drawing to the CairoOperations file.
This limits operations to only work with a PlatformContextCairo object,
along with other required parameters, and will help with future work
that will rely on isolated Cairo-specific code.

Along with moving the drawGlyphs() code, the helper functions are moved
and adjusted to work specifically on a PlatformContextCairo object and
a const GraphicsContextState reference, only using a GraphicsContext
reference for any required shadowed glyph drawing.

No new tests -- no change in behavior.

• platform/graphics/cairo/CairoOperations.cpp:

(WebCore::Cairo::drawGlyphsToContext):
(WebCore::Cairo::drawGlyphsShadow):
(WebCore::Cairo::drawGlyphs):

• platform/graphics/cairo/FontCairo.cpp:

(WebCore::FontCascade::drawGlyphs):
(WebCore::drawGlyphsToContext): Deleted.
(WebCore::drawGlyphsShadow): Deleted.

5:07 AM FTLJIT edited by Konstantin Tokarev

No more LLVM (diff)

5:03 AM FTLJIT edited by Konstantin Tokarev

No more LLVM (diff)

1:55 AM Changeset in webkit [224751] by Carlos Garcia Campos

• 2 edits in trunk/LayoutTests

Unreviewed GTK+ gardening. Mark editing/execCommand/underline-selection-containing-image.html as failing.

• platform/gtk/TestExpectations:

1:28 AM Changeset in webkit [224750] by Ms2ger@igalia.com

• 2 edits
  4 adds
  1 delete in trunk/LayoutTests

[GTK] Enable some passing XHR tests
​https://bugs.webkit.org/show_bug.cgi?id=179533

Reviewed by Alex Christensen.

• platform/gtk/TestExpectations: Remove failure expectations.
• platform/gtk/imported/w3c/web-platform-tests/XMLHttpRequest/getallresponseheaders-expected.txt: Removed: the platform-neutral expectation file (two passes rather than one pass, one fail) matches the current output on GTK.
• platform/gtk/imported/w3c/web-platform-tests/XMLHttpRequest/send-entity-body-get-head-async-expected.txt: Added: the platform-neutral expectation file has subtests marked as failing, though they all pass on GTK.
• platform/gtk/imported/w3c/web-platform-tests/XMLHttpRequest/send-entity-body-get-head-expected.txt: Added: the platform-neutral expectation file has subtests marked as failing, though they all pass on GTK.
• platform/gtk/imported/w3c/web-platform-tests/XMLHttpRequest/send-redirect-expected.txt: Added: the platform-neutral expectation file has subtests marked as failing, though they all pass on GTK.
• platform/gtk/imported/w3c/web-platform-tests/XMLHttpRequest/setrequestheader-content-type-expected.txt: Added: some of the subtests marked as failing in the platform-neutral expectation file are passing on GTK.

1:19 AM Changeset in webkit [224749] by zandobersek@gmail.com

• 4 edits in trunk/Source/WebCore

[Cairo] Move focus ring drawing operations from GraphicsContextCairo to CairoOperations
​https://bugs.webkit.org/show_bug.cgi?id=179603

Reviewed by Carlos Garcia Campos.

Move operations that perform focus ring drawing to the CairoOperations
file. This limits operations to only work with a PlatformContextCairo
object, along with other required parameters, and will help with future
work in this area.

The Cairo::State namespace is introduced, with the setStrokeStyle()
function placed there. The namespace will be used for operations that
only change an aspect of the Cairo state. More functions will be added
soon, and existing line and miter operations will likely move there as
well.

No new tests -- no change in behavior.

• platform/graphics/cairo/CairoOperations.cpp:

(WebCore::Cairo::adjustFocusRingColor):
(WebCore::Cairo::adjustFocusRingLineWidth):
(WebCore::Cairo::focusRingStrokeStyle):
(WebCore::Cairo::State::setStrokeStyle):
(WebCore::Cairo::drawFocusRing):

• platform/graphics/cairo/CairoOperations.h:
• platform/graphics/cairo/GraphicsContextCairo.cpp:

(WebCore::GraphicsContext::drawFocusRing):
(WebCore::GraphicsContext::setPlatformStrokeStyle):
(WebCore::adjustFocusRingColor): Deleted.
(WebCore::adjustFocusRingLineWidth): Deleted.
(WebCore::focusRingStrokeStyle): Deleted.

12:23 AM Changeset in webkit [224748] by Carlos Garcia Campos

• 2 edits in trunk/Source/WebCore

Unreviewed. Fix debug build with Touch Events enabled after r224740.

• dom/EventContext.cpp:

(WebCore::TouchEventContext::checkReachability const):

Nov 12, 2017:

11:54 PM Changeset in webkit [224747] by mjs@apple.com

• 6 edits
  2 adds
  20 deletes in trunk

Remove support for UTF-32 variant text encodings
​https://bugs.webkit.org/show_bug.cgi?id=179435

Reviewed by Darin Adler.

LayoutTests/imported/w3c:

• web-platform-tests/encoding/unsupported-encodings-expected.txt: Update results now

that UTF-32 support is gone. Still not quite right since we don't sniff UTF-32LE as
UTF-16LE yet.

• web-platform-tests/encoding/utf-32-expected.txt: ditto

Source/WebCore:

Non-support for these encodings is covered by WPT tests.

• platform/text/TextCodecICU.cpp: Remove UTF-32 variants.

Technically, we should also ensure that UTF-32LE with a BOM
gets sniffed as UTF-16LE instead of windows-1252. Chrome
does this but Firefox doesn't yet. WPT tests cover it, and
we can fix it later.

LayoutTests:

• fast/encoding/legacy-utf-32-aliases.html: Added. Check that

we don't support our legacy aliases for utf-32, since WPT doesn't
either.

• fast/encoding/legacy-utf-32-aliases-expected.txt: Ditto.

Remove the following tests; we no longer want to support UTF-32.

imported/w3c/web-platform-tests/encoding already has tests for lack of support.

• fast/encoding/utf-32-big-endian-bom-expected.txt: Removed.
• fast/encoding/utf-32-big-endian-bom.html: Removed.
• fast/encoding/utf-32-big-endian-nobom-expected.txt: Removed.
• fast/encoding/utf-32-big-endian-nobom.xml: Removed.
• fast/encoding/utf-32-little-endian-bom-expected.txt: Removed.
• fast/encoding/utf-32-little-endian-bom.html: Removed.
• fast/encoding/utf-32-little-endian-nobom-expected.txt: Removed.
• fast/encoding/utf-32-little-endian-nobom.xml: Removed.
• http/tests/misc/submit-get-in-utf32be-expected.txt: Removed.
• http/tests/misc/submit-get-in-utf32be.html: Removed.
• http/tests/misc/submit-get-in-utf32le-expected.txt: Removed.
• http/tests/misc/submit-get-in-utf32le.html: Removed.
• http/tests/misc/submit-post-in-utf32be-expected.txt: Removed.
• http/tests/misc/submit-post-in-utf32be.html: Removed.
• http/tests/misc/submit-post-in-utf32le-expected.txt: Removed.
• http/tests/misc/submit-post-in-utf32le.html: Removed.
• http/tests/misc/url-in-utf32be-expected.txt: Removed.
• http/tests/misc/url-in-utf32be.html: Removed.
• http/tests/misc/url-in-utf32le-expected.txt: Removed.
• http/tests/misc/url-in-utf32le.html: Removed.

11:43 PM Changeset in webkit [224746] by zandobersek@gmail.com

• 5 edits in trunk/Source/WebCore

[Cairo] Move rectangle and path filling, stroking, clearing operations in GraphicsContextCairo to CairoOperations
​https://bugs.webkit.org/show_bug.cgi?id=179599

Reviewed by Carlos Garcia Campos.

Move operations that perform filling, stroking and clearing for
specified rectangles and paths to the CairoOperations file. This limits
operations to only work with a PlatformContextCairo object, along with
any required parameter, and will help with future work in this area.

Helper functions are copied along for the time being, but will later be
removed from the GraphicsContextCairo implementation file.

No new tests -- no change in behavior.

• platform/graphics/cairo/CairoOperations.cpp:

(WebCore::Cairo::fillRectWithColor):
(WebCore::Cairo::drawPathShadow):
(WebCore::Cairo::fillCurrentCairoPath):
(WebCore::Cairo::fillRect):
(WebCore::Cairo::fillRoundedRect):
(WebCore::Cairo::fillRectWithRoundedHole):
(WebCore::Cairo::fillPath):
(WebCore::Cairo::strokeRect):
(WebCore::Cairo::strokePath):
(WebCore::Cairo::clearRect):

• platform/graphics/cairo/CairoOperations.h:
• platform/graphics/cairo/GradientCairo.cpp:

(WebCore::Gradient::fill):

• platform/graphics/cairo/GraphicsContextCairo.cpp:

(WebCore::GraphicsContext::fillPath):
(WebCore::GraphicsContext::strokePath):
(WebCore::GraphicsContext::fillRect):
(WebCore::GraphicsContext::clearRect):
(WebCore::GraphicsContext::strokeRect):
(WebCore::GraphicsContext::platformFillRoundedRect):
(WebCore::GraphicsContext::fillRectWithRoundedHole):

11:41 PM Changeset in webkit [224745] by Carlos Garcia Campos

• 4 edits in trunk

REGRESSION(r224566): [GTK] 26 new timeouts on inspector related tests.
​https://bugs.webkit.org/show_bug.cgi?id=179471

Reviewed by Darin Adler.

Source/WebInspectorUI:

TestStub.html and TestStub.js was missing in resources bundle.

• Scripts/copy-user-interface-resources.pl: Also combine resources for TestStub.

LayoutTests:

Unskip tests that are passing now.

• platform/gtk/TestExpectations:

11:37 PM Changeset in webkit [224744] by zandobersek@gmail.com

• 4 edits in trunk/Source/WebCore

[Cairo] Move state stack, CTM, transparency layer operations in GraphicsContextCairo to CairoOperations
​https://bugs.webkit.org/show_bug.cgi?id=179598

Reviewed by Carlos Garcia Campos.

Move operations that save and restore state, adjust CTM and modify the
transparency layer stack to the CairoOperations file. This limits
operations to only work with a PlatformContextCairo object, along with
any required parameter, and will help with future work in this area.

No new tests -- no change in behavior.

• platform/graphics/cairo/CairoOperations.cpp:

(WebCore::Cairo::save):
(WebCore::Cairo::restore):
(WebCore::Cairo::translate):
(WebCore::Cairo::rotate):
(WebCore::Cairo::scale):
(WebCore::Cairo::concatCTM):
(WebCore::Cairo::beginTransparencyLayer):
(WebCore::Cairo::endTransparencyLayer):

• platform/graphics/cairo/CairoOperations.h:
• platform/graphics/cairo/GraphicsContextCairo.cpp:

(WebCore::GraphicsContext::savePlatformState):
(WebCore::GraphicsContext::restorePlatformState):
(WebCore::GraphicsContext::translate):
(WebCore::GraphicsContext::concatCTM):
(WebCore::GraphicsContext::beginPlatformTransparencyLayer):
(WebCore::GraphicsContext::endPlatformTransparencyLayer):
(WebCore::GraphicsContext::rotate):
(WebCore::GraphicsContext::scale):

11:32 PM Changeset in webkit [224743] by zandobersek@gmail.com

• 4 edits in trunk/Source/WebCore

[Cairo] Move line, miter operations in GraphicsContextCairo to CairoOperations
​https://bugs.webkit.org/show_bug.cgi?id=179597

Reviewed by Carlos Garcia Campos.

Move operations that adjust line cap, line dash, line join and miter
limit to the CairoOperations file. This limits operations to only work
with a PlatformContextCairo object, along with any required parameter,
and will help with future work in this area.

No new tests -- no change in behavior.

• platform/graphics/cairo/CairoOperations.cpp:

(WebCore::Cairo::setLineCap):
(WebCore::Cairo::setLineDash):
(WebCore::Cairo::setLineJoin):
(WebCore::Cairo::setMiterLimit):

• platform/graphics/cairo/CairoOperations.h:
• platform/graphics/cairo/GraphicsContextCairo.cpp:

(WebCore::GraphicsContext::setLineCap):
(WebCore::GraphicsContext::setLineDash):
(WebCore::GraphicsContext::setLineJoin):
(WebCore::GraphicsContext::setMiterLimit):
(WebCore::isDashArrayAllZero): Deleted.

10:54 PM Changeset in webkit [224742] by jonlee@apple.com

• 3 edits
  2 copies
  2 moves
  3 adds in trunk/PerformanceTests

Add isolated text tests for MotionMark
​https://bugs.webkit.org/show_bug.cgi?id=179226

Reviewed by Darin Adler.

Add a private suite that simplifies the design test.

• MotionMark/resources/debug-runner/tests.js:
• MotionMark/resources/runner/tests.js:
• MotionMark/tests/master/design.html: Copied from PerformanceTests/MotionMark/tests/master/text.html.

Rename the html file to the title of the test.

• MotionMark/tests/master/resources/design.js: Renamed from PerformanceTests/MotionMark/tests/master/resources/text.js.
• MotionMark/tests/text/design-6.html: Copied from PerformanceTests/MotionMark/tests/master/text.html.

Six active cells

• MotionMark/tests/text/design-6.js: Added.
• MotionMark/tests/text/design.html: Renamed from PerformanceTests/MotionMark/tests/master/text.html.

Replace the text with empty table cells that are populated with desired text.

• MotionMark/tests/text/design.js: Added.

10:39 PM Changeset in webkit [224741] by Chris Dumez

• 2 edits in trunk/Source/WebCore

[Service Workers] Activate algorithm says terminate the active worker if it exists
​https://bugs.webkit.org/show_bug.cgi?id=179559

Reviewed by Darin Adler.

Activate algorithm says terminate the active worker if it exists:

• ​https://w3c.github.io/ServiceWorker/#activation-algorithm (Step 2.1)

No new tests, no-op for now as the terminate() function is not implemented
yet.

• workers/service/server/SWServerJobQueue.cpp:

(WebCore::SWServerJobQueue::activate):

10:12 PM Changeset in webkit [224740] by Darin Adler

• 58 edits in trunk/Source

More is<> and downcast<>, less static_cast<>
​https://bugs.webkit.org/show_bug.cgi?id=179600

Reviewed by Chris Dumez.

Source/JavaScriptCore:

• runtime/JSString.h:

(JSC::jsSubstring): Removed unneeded static_cast; length already returns unsigned.
(JSC::jsSubstringOfResolved): Ditto.

Source/WebCore:

• Modules/fetch/FetchBody.cpp:

(WebCore::FetchBody::extract): Use downcast instead of static_cast.
(WebCore::FetchBody::bodyAsFormData const): Ditto.

• Modules/indexeddb/IDBObjectStore.cpp:

(WebCore::IDBObjectStore::putOrAdd): Ditto.

• Modules/mediastream/CanvasCaptureMediaStreamTrack.cpp:

(WebCore::CanvasCaptureMediaStreamTrack::Source::canvasChanged): Ditto.

• Modules/mediastream/libwebrtc/LibWebRTCPeerConnectionBackend.cpp:

(WebCore::libWebRTCProvider): Ditto.

• accessibility/AccessibilityMediaControls.cpp:

(WebCore::AccessibilityMediaTimeDisplay::stringValue const): Got rid of local
variable and used std::abs instead of fabsf. Did not use downcast here because
it doesn't exist for this class.

• bindings/js/JSEventTargetCustom.h:

(WebCore::IDLOperation<JSEventTarget>::call): Use downcast instead of toDOMWindow.

• dom/DocumentEventQueue.cpp:

(WebCore::DocumentEventQueue::dispatchEvent): Ditto.

• dom/Element.h: Added is/downcast for EventTarget.

• dom/EventContext.cpp:

(WebCore::TouchEventContext::checkReachability const): Use downcast instead
of toNode.

• dom/EventContext.h:

(WebCore::EventContext::isUnreachableNode const): Ditto.

• dom/EventPath.cpp:

(WebCore::shouldEventCrossShadowBoundary): Ditto.
(WebCore::EventPath::setRelatedTarget): Ditto.
(WebCore::EventPath::retargetTouch): Ditto.
(WebCore::EventPath::EventPath): Ditto.

• dom/EventTarget.cpp:

(WebCore::EventTarget::toNode): Deleted.
(WebCore::EventTarget::isNode const): Added.
(WebCore::EventTarget::toDOMWindow): Deleted.
(WebCore::EventTarget::isMessagePort const): Deleted. This was not used.
(WebCore::EventTarget::addEventListener): Use downcast instead of toDOMWindow
and toNode.

• dom/EventTarget.h: Updated for the above.

• dom/MessagePort.h: Deleted unused isMessagePort.

• dom/MouseEvent.cpp:

(WebCore::MouseEvent::toElement const): Use downcast instead of toNode.
Also refactored to make function a little smaller.
(WebCore::MouseEvent::fromElement const): Ditto.

• dom/MouseRelatedEvent.cpp:

(WebCore::MouseRelatedEvent::computeRelativePosition): Use downcast
instead of toNode.

• dom/Node.cpp:

(WebCore::Node::isNode const): Added.
(WebCore::Node::toNode): Deleted.

• dom/Node.h: Updated for the above. Also added SPECIALIZE_TYPE_TRAITS

so we can do is/downcast.

• dom/ScopedEventQueue.cpp:

(WebCore::ScopedEventQueue::enqueueEvent): Use is instead of toNode.
(WebCore::ScopedEventQueue::dispatchEvent const): Use downcast instead of toNode.

• dom/make_names.pl:

(printTypeHelpers): Added support for is/downcast from EventTarget.

• editing/Editor.cpp:

(WebCore::Editor::selectionForCommand): Use is/downcast instead of toNode.

• editing/EditorCommand.cpp:

(WebCore::targetFrame): Ditto.

• html/HTMLAnchorElement.cpp:

(WebCore::appendServerMapMousePosition): Ditto.

• html/HTMLCanvasElement.cpp:

(WebCore::HTMLCanvasElement::createContextWebGL): Use downcast instead of
static_cast.
(WebCore::HTMLCanvasElement::getContextWebGL): Ditto.
(WebCore::HTMLCanvasElement::getImageData): Ditto.

• html/HTMLElement.h: Added support for is/downcast from EventTarget.

• html/HTMLFormElement.cpp:

(WebCore::HTMLFormElement::handleLocalEvents): Use is instead of toNode.
(WebCore::submitElementFromEvent): Deleted. Was a duplicate of findSubmitButton.
(WebCore::HTMLFormElement::prepareForSubmission): Rewrote code that calls
submitElementFromEvent to call findSubmitButton instead. Also don't bother
finding the submit button unless we are going to validate, since all we do
after finding it is reconsider whether we should validate.
(WebCore::HTMLFormElement::findSubmitButton const): Rewrote to use is,
downcast, and lineageOfType rather than a handwritten loop and toNode.
Relies on the fact that the target is an element, never a text node.

• html/HTMLLabelElement.cpp:

(WebCore::HTMLLabelElement::defaultEventHandler): Use is and downcast instead
of toNode.

• html/HTMLPlugInImageElement.cpp:

(WebCore::HTMLPlugInImageElement::partOfSnapshotOverlay const): Changed argument
type to EventTarget so we can do the type checking and casting here instead of at
each of the callers.

• html/HTMLPlugInImageElement.h: Updated for the above.

• html/HTMLSummaryElement.cpp:

(WebCore::isClickableControl): Changed argument type to EventTarget so we can do
the type checking and casting here instead of at each of the callers.
(WebCore::HTMLSummaryElement::defaultEventHandler): Removed call to toNode.

• html/HTMLTextFormControlElement.h: Added support for is/downcast from EventTarget.

• html/MediaDocument.cpp:

(WebCore::MediaDocument::defaultEventHandler): Use is/downcast instead of toNode.

• html/RangeInputType.cpp:

(WebCore::RangeInputType::handleMouseDownEvent): Ditto.

• html/shadow/MediaControlElements.cpp:

(WebCore::MediaControlVolumeSliderContainerElement::defaultEventHandler): Ditto.
(WebCore::MediaControlClosedCaptionsTrackListElement::defaultEventHandler): Ditto.
Also use get instead of find/end.

• html/shadow/MediaControls.cpp:

(WebCore::MediaControls::containsRelatedTarget): Use is/downcast instead of toNode.

• inspector/InspectorFrontendHost.cpp:

(WebCore::InspectorFrontendHost::dispatchEventAsContextMenuEvent): Ditto.

• inspector/agents/InspectorDOMAgent.cpp:

(WebCore::InspectorDOMAgent::didAddEventListener): Ditto.
(WebCore::InspectorDOMAgent::willRemoveEventListener): Ditto.

• page/ContextMenuController.cpp:

(WebCore::ContextMenuController::maybeCreateContextMenu): Ditto.

• page/DOMWindow.cpp:

(WebCore::DOMWindow::toDOMWindow): Deleted.

• page/DOMWindow.h: Updated for the above. Also added SPECIALIZE_TYPE_TRAITS

so we can do is/downcast.

• page/EventHandler.cpp:

(WebCore::EventHandler::handleTouchEvent): Use is/downcast instead of toNode.

• platform/graphics/WidthCache.h:

(WebCore::WidthCache::add): Removed unneeded static_cast; length already returns unsigned.

• rendering/RenderSnapshottedPlugIn.cpp:

(WebCore::RenderSnapshottedPlugIn::handleEvent): Removed unneeded toNode now that
partOfSnapshotOverlay takes an EventTarget.

Source/WebKit:

• WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMPrivate.cpp:

(WebKit::wrap): Use is/downcast.

• WebProcess/WebCoreSupport/gtk/WebEditorClientGtk.cpp:

(WebKit::WebEditorClient::handleKeyboardEvent): Ditto.

• WebProcess/WebCoreSupport/wpe/WebEditorClientWPE.cpp:

(WebKit::WebEditorClient::handleKeyboardEvent): Ditto.

• WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::handleEditingKeyboardEvent): Ditto.

• WebProcess/WebPage/mac/WebPageMac.mm:

(WebKit::frameForEvent): Ditto.

Source/WebKitLegacy/mac:

• DOM/DOM.mm:

(kit): Use is/downcast.

• WebCoreSupport/WebEditorClient.mm:

(WebEditorClient::handleKeyboardEvent): Ditto.
(WebEditorClient::handleInputMethodKeydown): Ditto.

• WebView/WebHTMLView.mm:

(-[WebHTMLView _interpretKeyEvent:savingCommands:]): Ditto.

Source/WebKitLegacy/win:

• WebView.cpp:

(WebView::handleEditingKeyboardEvent): Use downcast.

4:27 PM Changeset in webkit [224739] by matthew_hanson@apple.com

• 1 copy in tags/Safari-604.3.5.1.2

Tag Safari-604.3.5.1.2.

4:23 PM Changeset in webkit [224738] by matthew_hanson@apple.com

• 7 edits in trunk/Source

Versioning.

11:50 AM Changeset in webkit [224737] by commit-queue@webkit.org

• 10 edits in trunk

[GTK] Add functionality to handle font sizes in points
​https://bugs.webkit.org/show_bug.cgi?id=179285

Patch by Gabriel Ivascu <​givascu@igalia.com> on 2017-11-12
Reviewed by Carlos Garcia Campos and Michael Catanzaro.

Source/WebCore:

• platform/PlatformScreen.h:
• platform/gtk/PlatformScreenGtk.cpp:

(WebCore::screenDPI):

• platform/wpe/PlatformScreenWPE.cpp:

(WebCore::screenDPI):

Source/WebKit:

• UIProcess/API/glib/WebKitSettings.cpp:

(webkit_settings_class_init):
(webkit_settings_font_size_to_points):
(webkit_settings_font_size_to_pixels):

• UIProcess/API/gtk/WebKitSettings.h:
• UIProcess/API/gtk/docs/webkit2gtk-4.0-sections.txt:

Tools:

• TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:

(testWebKitSettings):

9:52 AM Changeset in webkit [224736] by Yusuke Suzuki

• 6 edits
  5 adds in trunk

[WebCore] Implement import.meta.url
​https://bugs.webkit.org/show_bug.cgi?id=178672

Reviewed by Darin Adler.

Source/WebCore:

This patch implements import.meta.url field, which holds a base url
of the currently executing module[1].

In the case of embedded modules, this field becomes the URL of the
embedding HTML file. In the case of imported modules, the URL becomes
the URL of the executed module script file.

[1]: ​https://github.com/whatwg/html/pull/3141

• bindings/js/JSDOMWindowBase.cpp:

(WebCore::JSDOMWindowBase::moduleLoaderCreateImportMetaProperties):

• bindings/js/JSDOMWindowBase.h:
• bindings/js/ScriptModuleLoader.cpp:

(WebCore::ScriptModuleLoader::moduleURL):
(WebCore::ScriptModuleLoader::evaluate):
(WebCore::ScriptModuleLoader::createImportMetaProperties):

• bindings/js/ScriptModuleLoader.h:

LayoutTests:

• js/dom/modules/import-meta-url-expected.txt: Added.
• js/dom/modules/import-meta-url.html: Added.
• js/dom/modules/script-tests/import-meta-url-second-level.js: Added.
• js/dom/modules/script-tests/import-meta-url-top-level.js: Added.
• js/dom/modules/script-tests/import-meta-url.js: Added.

7:34 AM Changeset in webkit [224735] by mark.lam@apple.com

• 11 edits
  1 add in trunk

We should ensure that operationStrCat2 and operationStrCat3 are never passed Symbols as arguments.
​https://bugs.webkit.org/show_bug.cgi?id=179562
<rdar://problem/35467022>

Reviewed by Saam Barati.

JSTests:

• regress-179562.js: Added.

Source/JavaScriptCore:

• dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode):

• dfg/DFGOperations.cpp:
• dfg/DFGSafeToExecute.h:

(JSC::DFG::SafeToExecuteEdge::operator()):

• dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::speculateNotSymbol):
(JSC::DFG::SpeculativeJIT::speculate):

• dfg/DFGSpeculativeJIT.h:
• dfg/DFGUseKind.cpp:

(WTF::printInternal):

• dfg/DFGUseKind.h:

(JSC::DFG::typeFilterFor):

• ftl/FTLCapabilities.cpp:

(JSC::FTL::canCompile):

• ftl/FTLLowerDFGToB3.cpp:

(JSC::FTL::DFG::LowerDFGToB3::speculate):
(JSC::FTL::DFG::LowerDFGToB3::speculateNotSymbol):