Timeline
Nov 15, 2017:
- 7:05 PM Changeset in webkit [224909] by
-
- 20 edits in trunk/Source
Implement basics of "Terminate Service Worker" algorithm.
https://bugs.webkit.org/show_bug.cgi?id=179551
Reviewed by Chris Dumez.
Source/WebCore:
No new tests (No observable behavior change yet).
- workers/WorkerGlobalScope.cpp:
(WebCore::WorkerGlobalScope::stopIndexedDatabase):
- workers/WorkerMessagingProxy.cpp:
(WebCore::WorkerMessagingProxy::workerThreadCreated):
(WebCore::WorkerMessagingProxy::terminateWorkerGlobalScope):
- workers/WorkerThread.cpp:
(WebCore::WorkerThread::workerThread):
(WebCore::WorkerThread::stop):
- workers/WorkerThread.h:
- workers/service/context/SWContextManager.cpp:
(WebCore::SWContextManager::terminateWorker):
- workers/service/context/SWContextManager.h:
- workers/service/server/SWServer.cpp:
(WebCore::SWServer::workerContextTerminated):
(WebCore::SWServer::terminateWorker):
- workers/service/server/SWServer.h:
- workers/service/server/SWServerToContextConnection.cpp:
(WebCore::SWServerToContextConnection::workerTerminated):
- workers/service/server/SWServerToContextConnection.h:
- workers/service/server/SWServerWorker.cpp:
(WebCore::SWServerWorker::terminate):
(WebCore::SWServerWorker::contextTerminated):
- workers/service/server/SWServerWorker.h:
Source/WebKit:
- StorageProcess/ServiceWorker/WebSWServerToContextConnection.cpp:
(WebKit::WebSWServerToContextConnection::terminateWorker):
- StorageProcess/ServiceWorker/WebSWServerToContextConnection.h:
- StorageProcess/ServiceWorker/WebSWServerToContextConnection.messages.in:
- WebProcess/Storage/WebSWContextManagerConnection.cpp:
(WebKit::WebSWContextManagerConnection::terminateWorker):
(WebKit::WebSWContextManagerConnection::workerTerminated):
- WebProcess/Storage/WebSWContextManagerConnection.h:
- WebProcess/Storage/WebSWContextManagerConnection.messages.in:
- 5:17 PM Changeset in webkit [224908] by
-
- 2 edits in trunk/Source/WebKit
Remove access to 'com.apple.mediaaccessibility.public' preferences in WebContent sandbox
https://bugs.webkit.org/show_bug.cgi?id=179747
<rdar://problem/35367346>
Reviewed by Dean Jackson.
The 'mediaaccessibilityd' process handles access to MediaAccessibility preferences. We don't need
to grant the WebContent Process sandbox access to them.
- WebProcess/com.apple.WebProcess.sb.in:
- 4:36 PM Changeset in webkit [224907] by
-
- 2 edits in trunk/Source/WTF
Fix fast/events/message-port-postMessage-recursive.html after r224896
https://bugs.webkit.org/show_bug.cgi?id=179749
Reviewed by Jer Noble.
- wtf/mac/MainThreadMac.mm:
(WTF::currentRunLoopInCommonMode):
We sometimes run the runloop in kCFRunLoopDefaultMode, which should also have the responsiveness optimization.
This allows the runloop to continue to iterate when we are doing lots of things on the main thread.
CFRunLoop.h has a special definition of these two constants.
- 4:31 PM Changeset in webkit [224906] by
-
- 3 edits in trunk/Source/WebInspectorUI
Web Inspector: Styles Redesign: typing colon in property name should advance to value field
https://bugs.webkit.org/show_bug.cgi?id=178795
<rdar://problem/35174674>
Reviewed by Devin Rousso.
- UserInterface/Views/SpreadsheetStyleProperty.js:
(WI.SpreadsheetStyleProperty.prototype._update):
(WI.SpreadsheetStyleProperty.prototype._handleNameBeforeInput):
Unlike pressing Tab or Enter, typing ":" in the property name should discard suggestion hint.
(WI.SpreadsheetStyleProperty.prototype._valueCompletionDataProvider):
We use 250ms debounce before updating this._property.name.
When typing "font-f:", we want to discard suggestion hint (i.e. "font-family"),
and immediately show autocomplete for "font-f" (in this case, invalid property).
- UserInterface/Views/SpreadsheetTextField.js:
(WI.SpreadsheetTextField):
(WI.SpreadsheetTextField.prototype.stopEditing):
(WI.SpreadsheetTextField.prototype.discardCompletion):
Call spreadsheetTextFieldDidChange when discarding non-empty suggestion hint.
(WI.SpreadsheetTextField.prototype.detached):
(WI.SpreadsheetTextField.prototype.completionSuggestionsClickedCompletion):
(WI.SpreadsheetTextField.prototype._handleBlur):
(WI.SpreadsheetTextField.prototype._handleKeyDownForSuggestionView):
(WI.SpreadsheetTextField.prototype._updateCompletions):
(WI.SpreadsheetTextField.prototype._applyCompletionHint):
(WI.SpreadsheetTextField.prototype._hideCompletions): Deleted.
- 3:39 PM Changeset in webkit [224905] by
-
- 6 edits in trunk/Source/WebInspectorUI
Web Inspector: REGRESSION (r217750): Navigation sidebar broken after closing and re-opening tab
https://bugs.webkit.org/show_bug.cgi?id=179717
<rdar://problem/35551541>
Reviewed by Devin Rousso.
NavigationSidebarPanels should not be created with WI.instanceForClass.
- UserInterface/Views/DebuggerSidebarPanel.js:
- UserInterface/Views/ResourceSidebarPanel.js:
(WI.ResourceSidebarPanel):
- UserInterface/Views/SearchSidebarPanel.js:
(WI.SearchSidebarPanel):
- UserInterface/Views/StorageSidebarPanel.js:
(WI.StorageSidebarPanel):
- UserInterface/Views/TabContentView.js:
(WI.TabContentView.prototype.get navigationSidebarPanel):
- 3:25 PM Changeset in webkit [224904] by
-
- 6 edits in trunk/Source/WebCore
Log media readyState and networkState as strings
https://bugs.webkit.org/show_bug.cgi?id=179732
Reviewed by Youenn Fablet.
- html/HTMLMediaElement.cpp:
(WebCore::convertEnumerationToString):
(WebCore::HTMLMediaElement::scheduleDelayedAction): Fix logic error.
(WebCore::HTMLMediaElement::pendingActionTimerFired): Fix incorrect log string.
(WebCore::HTMLMediaElement::setNetworkState): Don't cast to int for logging.
(WebCore::HTMLMediaElement::setReadyState): Ditto. Log when autoplay is blocked.
- html/HTMLMediaElementEnums.h:
(PAL::LogArgument<WebCore::HTMLMediaElementEnums::ReadyState>::toString): New.
(PAL::LogArgument<WebCore::HTMLMediaElementEnums::NetworkState>::toString): New.
- platform/graphics/MediaPlayer.cpp:
(WebCore::convertEnumerationToString):
- platform/graphics/MediaPlayerEnums.h:
(PAL::LogArgument<WebCore::MediaPlayerEnums::ReadyState>::toString):
(PAL::LogArgument<WebCore::MediaPlayerEnums::NetworkState>::toString):
- platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:
(WebCore::MediaPlayerPrivateAVFoundation::updateStates): Log strings.
- 3:05 PM Changeset in webkit [224903] by
-
- 7 edits in trunk
Service Worker fetch should handle empty responses
https://bugs.webkit.org/show_bug.cgi?id=179740
Patch by Youenn Fablet <youenn@apple.com> on 2017-11-15
Reviewed by Alex Christensen.
Source/WebCore:
Covered by updated test.
- Modules/streams/ReadableStreamSink.cpp:
(WebCore::ReadableStreamToSharedBufferSink::enqueue): Not create a buffer until actually needed.
- workers/service/context/ServiceWorkerFetch.cpp:
(WebCore::ServiceWorkerFetch::processResponse): Check for null buffers.
LayoutTests:
- http/tests/workers/service/resources/service-worker-fetch-worker.js:
(event.event.request.url.endsWith):
- http/tests/workers/service/resources/service-worker-fetch.js:
(async.test):
- http/tests/workers/service/service-worker-fetch.https-expected.txt:
- 2:56 PM Changeset in webkit [224902] by
-
- 4 edits3 adds in trunk
ReloadFromOrigin loads should not select any service worker
https://bugs.webkit.org/show_bug.cgi?id=179736
Patch by Youenn Fablet <youenn@apple.com> on 2017-11-15
Reviewed by Brady Eidson.
Source/WebCore:
Test: http/tests/workers/service/shift-reload-navigation.html
In case of ReloadFromOrigin (equivalent of shift reload), do not select any service worker.
- loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::startLoadingMainResource):
- loader/FrameLoader.h:
(WebCore::FrameLoader::isReloadingFromOrigin const):
LayoutTests:
- http/tests/workers/service/resources/shift-reload-navigation.js: Added.
(async.test):
- http/tests/workers/service/shift-reload-navigation-expected.txt: Added.
- http/tests/workers/service/shift-reload-navigation.html: Added.
- 2:30 PM Changeset in webkit [224901] by
-
- 8 edits in tags/Safari-605.1.14
Cherry-pick r224896. rdar://problem/35519421
- 2:07 PM Changeset in webkit [224900] by
-
- 2 edits in trunk/Source/WebKit
Revert r224885
https://bugs.webkit.org/show_bug.cgi?id=179719
- UIProcess/API/APIContentRuleListStore.cpp:
(API::compiledToFile):
r224885 was a speculative fix that did not fix anything on the bots.
- 1:50 PM Changeset in webkit [224899] by
-
- 2 edits in trunk/Source/WebCore
AX triggers sync layout while building the render tree on www.macrumors.com.
https://bugs.webkit.org/show_bug.cgi?id=179741
rdar://problem/35462531
Reviewed by Antti Koivisto.
It's unsafe to issue layout while mutating the render tree. If a mutation
requires AX to issue a layout, it needs to be issued in a delayed manner (which the render
tree mutation will trigger anyway).
Unable to reproduce.
- accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::updateBackingStore):
- 1:36 PM Changeset in webkit [224898] by
-
- 9 copies1 add in releases/Apple/Safari Technology Preview 44
Added a tag for Safari Technology Preview release 44.
- 1:35 PM Changeset in webkit [224897] by
-
- 27 edits in trunk
[Web Animations] Implement basic to-from animations
https://bugs.webkit.org/show_bug.cgi?id=179707
<rdar://problem/34932456>
Source/WebCore:
We can now actually perform an animation, in software only, when provided two keyframes on an AnimationEffect.
To parse a keyframes object from JS, we use the StyleResolver to create RenderStyle objects based on the strings
provided for the property names and values. Then, when the DocumentTimeline indicates that animations are ready
to be updated, we invalidate the style of elements with animations, so that during style resolution we can perform
blending between the RenderStyles for each keyframe.
Reviewed by Dean Jackson.
- animation/AnimationEffect.h:
(WebCore::AnimationEffect::~AnimationEffect): Deleted.
- animation/AnimationTimeline.h:
(WebCore::AnimationTimeline::elementToAnimationsMap const):
- animation/DocumentTimeline.cpp:
(WebCore::DocumentTimeline::animationResolutionTimerFired):
(WebCore::DocumentTimeline::updateAnimations): Renamed from resolveAnimations() since we're not
actually resolving animations, merely invalidating styles in preparation for resolution.
(WebCore::DocumentTimeline::resolveAnimations): Deleted.
- animation/DocumentTimeline.h:
- animation/KeyframeEffect.cpp:
(WebCore::KeyframeEffect::create): Pass the keyframes argument to setKeyframes() and forward the
exception in case one was raised in the setter.
(WebCore::KeyframeEffect::setKeyframes): Pass the keyframes argument to processKeyframes() and
forward the exception in case one was raised during processing.
(WebCore::KeyframeEffect::processKeyframes): Deal with exactly two keyframes, set at 0 and 1 offsets,
specified in array forms for the keyframes object. As we parse the content of the provided JS object,
we create RenderStyle objects using the element's StyleResolver from a CSS text string we create
based on the property and values as strings.
(WebCore::KeyframeEffect::applyAtLocalTime): Compute the progress based on the local time and duration,
using the existing CSSPropertyAnimation::blendProperties() mechanics to perform the blend between the
from and to keyframes.
- animation/KeyframeEffect.h:
- animation/KeyframeEffect.idl:
- animation/WebAnimation.cpp:
(WebCore::WebAnimation::resolve):
- animation/WebAnimation.h:
- bindings/IDLTypes.h:
(WebCore::IDLObject::nullValue): Make JSC::Strong an optional type.
- dom/Document.h:
(WebCore::Document::existingTimeline const): Provide an explicit method for call sites to check existence
of a timeline before forcing one to be created if missing by calling timeline().
- dom/Element.cpp:
(WebCore::Element::getAnimations): Do not force the creation of a timeline if one isn't already created.
- style/StyleTreeResolver.cpp:
(WebCore::Style::TreeResolver::createAnimatedElementUpdate): When applying styles, account for any Web
Animation applied to the provided element.
LayoutTests:
Reviewed by Dean Jackson.
Update existing tests to explicitly pass null for keyframes and update WPT expectations.
- http/wpt/web-animations/interfaces/AnimationTimeline/document-timeline-expected.txt:
- http/wpt/web-animations/interfaces/KeyframeEffect/constructor-expected.txt:
- http/wpt/web-animations/interfaces/KeyframeEffect/processing-a-keyframes-argument-001-expected.txt:
- http/wpt/web-animations/interfaces/KeyframeEffect/processing-a-keyframes-argument-002-expected.txt:
- http/wpt/web-animations/interfaces/KeyframeEffect/setKeyframes-expected.txt:
- http/wpt/wk-web-animations/interfaces/element-get-animations.html:
- http/wpt/wk-web-animations/timing-model/animation-creation-basic.html:
- http/wpt/wk-web-animations/timing-model/animation-effect-unique-relationship.html:
- http/wpt/wk-web-animations/timing-model/animation-interface-effect-property.html:
- http/wpt/wk-web-animations/timing-model/keyframe-effect-expected.txt:
- http/wpt/wk-web-animations/timing-model/keyframe-effect-interface-timing-duration.html:
- http/wpt/wk-web-animations/timing-model/keyframe-effect.html:
- 1:28 PM Changeset in webkit [224896] by
-
- 8 edits in trunk
WebViews scheduled in custom run loop modes should be able to do more than 50ms of work at a time
https://bugs.webkit.org/show_bug.cgi?id=179742
<rdar://problem/35519421>
Reviewed by Jer Noble.
Source/WTF:
In r224687 I fixed loading from scheduled WebViews with custom run loop modes, but in
dispatchFunctionsFromMainThread we have an optimization to yield the run loop if we have already
done more than 50ms of work on the main thread in this run loop iteration. When this happens
and we are running in a custom run loop mode, we disable this responsiveness optimization.
We are calling CFRunLoopRunInMode or [NSRunLoop acceptInputForMode:beforeDate:] in a while loop anyways,
so we would not benefit from a responsiveness optimization. We definitely don't want to reschedule
on the main thread in the common run loop mode in this case.
- wtf/MainThread.cpp:
(WTF::dispatchFunctionsFromMainThread):
- wtf/MainThread.h:
- wtf/generic/MainThreadGeneric.cpp:
(WTF::currentRunLoopInCommonMode):
- wtf/mac/MainThreadMac.mm:
(WTF::currentRunLoopInCommonMode):
- wtf/win/MainThreadWin.cpp:
(WTF::currentRunLoopInCommonMode):
Tools:
- TestWebKitAPI/Tests/mac/WebViewScheduleInRunLoop.mm:
(-[ScheduleInRunLoopDelegate webView:didFinishLoadForFrame:]):
(TestWebKitAPI::TEST):
Load more than one scheduled WebView to test work that typically takes more than 50 ms.
- 1:18 PM Changeset in webkit [224895] by
-
- 1 copy in tags/Safari-605.1.14
Tag Safari-605.1.14.
- 12:07 PM Changeset in webkit [224894] by
-
- 11 edits2 adds in trunk
ASSERTION FAILED: !renderer->needsLayout() in WebCore::RenderBlock::checkPositionedObjectsNeedLayout with MathML
https://bugs.webkit.org/show_bug.cgi?id=178865
Patch by Frederic Wang <fwang@igalia.com> on 2017-11-15
Reviewed by Manuel Rego Casasnovas.
Source/WebCore:
MathML token elements can contain HTML elements and hence MathML elements can contain
out-of-flow positioned descendants. Also all MathML elements can be containing block and hence
should position their out-of-flow positioned descendants before calling clearNeedsLayout().
This patch does that in all places in the MathML renderer classes, except a few of them:
- RenderMathMLSpace, which can not have descendants.
- RenderMathMLToken and RenderMathMLOperator, since they will use the layout implementation of RenderMathMLBlock when they contain non-text children.
The patch also fixes an ASSERTION failure in WebCore::RenderBlock::checkPositionedObjectsNeedLayout
due to some descendants that are not laid out.
Test: mathml/out-of-flow-in-token-crash.html
- rendering/mathml/RenderMathMLBlock.cpp:
(WebCore::RenderMathMLBlock::layoutBlock): Call layoutPositionedObjects.
(WebCore::RenderMathMLBlock::layoutInvalidMarkup): Ditto and pass the relayoutChildren boolean.
- rendering/mathml/RenderMathMLBlock.h: Add a relayoutChildren boolean to layoutInvalidMarkup.
- rendering/mathml/RenderMathMLFraction.cpp:
(WebCore::RenderMathMLFraction::layoutBlock): Pass the relayoutChildren boolean to layoutInvalidMarkup
and call layoutPositionedObjects.
- rendering/mathml/RenderMathMLRoot.cpp:
(WebCore::RenderMathMLRoot::layoutBlock): Ditto.
- rendering/mathml/RenderMathMLScripts.cpp:
(WebCore::RenderMathMLScripts::layoutBlock): Ditto.
- rendering/mathml/RenderMathMLUnderOver.cpp:
(WebCore::RenderMathMLUnderOver::layoutBlock): Ditto.
- rendering/mathml/RenderMathMLMenclose.cpp:
(WebCore::RenderMathMLMenclose::layoutBlock): Call layoutPositionedObjects.
- rendering/mathml/RenderMathMLPadded.cpp:
(WebCore::RenderMathMLPadded::layoutBlock): Ditto.
- rendering/mathml/RenderMathMLRow.cpp:
(WebCore::RenderMathMLRow::layoutBlock): Ditto.
LayoutTests:
Add a test to trigger various clearNeedsLayout() in a MathML containing block with
out-of-flow positioned descendants.
- mathml/out-of-flow-in-token-crash-expected.txt: Added.
- mathml/out-of-flow-in-token-crash.html: Added.
- 12:02 PM Changeset in webkit [224893] by
-
- 3 edits in trunk/LayoutTests
[GTK] accessibility/accessibility-object-model.html fails
https://bugs.webkit.org/show_bug.cgi?id=179723
Reviewed by Chris Fleizach.
Updated the test to support different platforms.
- accessibility/accessibility-object-model-expected.txt:
- accessibility/accessibility-object-model.html:
- 11:50 AM Changeset in webkit [224892] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, fix tests introduced in r224880.
This is needed because of the changes in r224876.
- http/tests/workers/service/Client-properties.html:
- 11:40 AM Changeset in webkit [224891] by
-
- 6 edits in trunk/LayoutTests
Some service worker tests are flaky due to console log messages
https://bugs.webkit.org/show_bug.cgi?id=179601
Patch by Youenn Fablet <youenn@apple.com> on 2017-11-15
Reviewed by Alex Christensen.
LayoutTests/imported/w3c:
- web-platform-tests/service-workers/service-worker/fetch-canvas-tainting-cache.https-expected.txt:
- web-platform-tests/service-workers/service-worker/fetch-canvas-tainting.https-expected.txt:
- web-platform-tests/service-workers/service-worker/fetch-cors-xhr.https-expected.txt:
LayoutTests:
- 11:36 AM Changeset in webkit [224890] by
-
- 2 edits in trunk/Source/WebKit
Unreviewed build fix after r224830.
- WebProcess/com.apple.WebProcess.sb.in: Add missing sysctl-read permissions needed
to support testing on Mac Mini hardware.
- 11:28 AM Changeset in webkit [224889] by
-
- 15 edits1 copy in trunk/Source
Add ServiceWorker to WebProcess plumbery for FormData fetch responses
https://bugs.webkit.org/show_bug.cgi?id=179694
Patch by Youenn Fablet <youenn@apple.com> on 2017-11-15
Reviewed by Alex Christensen.
Source/WebCore:
No observable changes since we are not actually loading FormData right now.
- workers/service/context/ServiceWorkerFetch.cpp:
(WebCore::ServiceWorkerFetch::processResponse):
- workers/service/context/ServiceWorkerFetch.h:
Source/WebKit:
Added plumbery from Service Worker up to Web Process to pass form data response bodies.
A follow-up patch should read the data from Network Process and send it to the ResourceLoader.
- Platform/IPC/FormDataReference.h: Added.
(IPC::FormDataReference::FormDataReference):
(IPC::FormDataReference::takeData):
(IPC::FormDataReference::encode const):
(IPC::FormDataReference::decode):
- StorageProcess/ServiceWorker/WebSWServerConnection.cpp:
(WebKit::WebSWServerConnection::didReceiveFetchFormData):
- StorageProcess/ServiceWorker/WebSWServerConnection.h:
- StorageProcess/StorageProcess.cpp:
(WebKit::StorageProcess::didReceiveFetchFormData):
- StorageProcess/StorageProcess.h:
- StorageProcess/StorageProcess.messages.in:
- WebKit.xcodeproj/project.pbxproj:
- WebProcess/Storage/ServiceWorkerClientFetch.cpp:
(WebKit::ServiceWorkerClientFetch::didReceiveFormData):
- WebProcess/Storage/ServiceWorkerClientFetch.h:
- WebProcess/Storage/ServiceWorkerClientFetch.messages.in:
- WebProcess/Storage/WebServiceWorkerFetchTaskClient.cpp:
(WebKit::WebServiceWorkerFetchTaskClient::didReceiveFormData):
- WebProcess/Storage/WebServiceWorkerFetchTaskClient.h:
- 11:22 AM Changeset in webkit [224888] by
-
- 2 edits in trunk
Unreviewed, sort async iteration feature.
- Source/cmake/WebKitFeatures.cmake:
- 11:06 AM Changeset in webkit [224887] by
-
- 10 edits in trunk/Source/WebCore
Add a compile-time-checked string literal initializer for FourCC.
https://bugs.webkit.org/show_bug.cgi?id=179706
Reviewed by Alex Christensen.
Add a contexpr constructor for FourCC that takes a string literal and static_asserts that it
is exactly 4 chars long. Use this string literal constructor everywhere instead of multi-
character literals.
- platform/graphics/FourCC.h:
(WebCore::FourCC::FourCC):
- platform/graphics/iso/ISOBox.cpp:
(WebCore::ISOBox::parse):
- platform/graphics/iso/ISOOriginalFormatBox.h:
(WebCore::ISOOriginalFormatBox::boxTypeName):
- platform/graphics/iso/ISOProtectionSchemeInfoBox.h:
(WebCore::ISOProtectionSchemeInfoBox::boxTypeName):
- platform/graphics/iso/ISOSchemeInformationBox.h:
(WebCore::ISOSchemeInformationBox::boxTypeName):
- platform/graphics/iso/ISOSchemeTypeBox.h:
(WebCore::ISOSchemeTypeBox::boxTypeName):
- platform/graphics/iso/ISOTrackEncryptionBox.h:
(WebCore::ISOTrackEncryptionBox::boxTypeName):
- platform/graphics/iso/ISOVTTCue.h:
(WebCore::ISOWebVTTCue::boxTypeName):
- 10:48 AM Changeset in webkit [224886] by
-
- 2 edits in trunk/Tools
Unreviewed, rolling out r223781.
The test is now returning false, so the FIXME is not needed
anymore.
Reverted changeset:
"WebsiteDataStoreCustomPaths.mm is failing after r223718"
https://bugs.webkit.org/show_bug.cgi?id=178596
https://trac.webkit.org/changeset/223781
- 10:36 AM Changeset in webkit [224885] by
-
- 2 edits in trunk/Source/WebKit
Move a compiled WKContentRuleList to its destination before calling mmap
https://bugs.webkit.org/show_bug.cgi?id=179719
Reviewed by Brady Eidson.
Right now we compile a WKContentRuleList to a temporary file, call mmap, close the file, then move it.
Sometimes, especially on bots running tests, the move fails because the temporary file doesn't exist
any more. Moving the file before mmaping and closing the file might prevent this failure.
- UIProcess/API/APIContentRuleListStore.cpp:
(API::compiledToFile):
- 10:31 AM Changeset in webkit [224884] by
-
- 2 edits in trunk
REGRESSION(r224787): [Linux] Introduced 144 GTK/WPE JS test failures
https://bugs.webkit.org/show_bug.cgi?id=179704
Reviewed by Yusuke Suzuki.
Add feature flag for Async iteration.
- Source/cmake/WebKitFeatures.cmake:
- 10:24 AM Changeset in webkit [224883] by
-
- 2 edits in trunk/LayoutTests
Adjusted expectations for compositing/repaint/fixed-background-scroll.html.
https://bugs.webkit.org/show_bug.cgi?id=154612
Unreviewed test gardening.
- platform/mac-wk1/TestExpectations:
- 10:06 AM Changeset in webkit [224882] by
-
- 2 edits in trunk/Source/WebCore
[Cairo] Clang warns about mismatched declaration type tag for GraphicsContextState
https://bugs.webkit.org/show_bug.cgi?id=179729
Reviewed by Michael Catanzaro.
No new tests needed.
- platform/graphics/cairo/CairoOperations.h: Make the forward declaration use "struct"
as the actual implementation of the type does.
- 10:04 AM Changeset in webkit [224881] by
-
- 7 edits in branches/safari-604.4.7.1-branch/Source
Versioning.
- 10:00 AM Changeset in webkit [224880] by
-
- 30 edits2 copies7 adds in trunk
[Service Workers] Implement Client API
https://bugs.webkit.org/show_bug.cgi?id=179709
Reviewed by Alex Christensen.
Source/WebCore:
Implement Client API as per:
Tests:
http/tests/workers/service/Client-properties.html
http/tests/workers/service/Client-properties-subframe.html
http/tests/workers/service/Client-properties-auxiliary.html
- Sources.txt:
- WebCore.xcodeproj/project.pbxproj:
- workers/service/ServiceWorker.cpp:
(WebCore::ServiceWorker::postMessage):
- workers/service/ServiceWorkerClient.cpp:
(WebCore::ServiceWorkerClient::ServiceWorkerClient):
(WebCore::ServiceWorkerClient::url const):
(WebCore::ServiceWorkerClient::type const):
(WebCore::ServiceWorkerClient::frameType const):
(WebCore::ServiceWorkerClient::id const):
(WebCore::ServiceWorkerClient::postMessage):
- workers/service/ServiceWorkerClient.h:
(WebCore::ServiceWorkerClient::create):
- workers/service/ServiceWorkerClientData.cpp: Copied from Source/WebCore/workers/service/ServiceWorkerWindowClient.cpp.
(WebCore::toServiceWorkerClientFrameType):
(WebCore::ServiceWorkerClientData::isolatedCopy const):
(WebCore::ServiceWorkerClientData::from):
- workers/service/ServiceWorkerClientData.h: Copied from Source/WebCore/workers/service/ServiceWorkerClient.h.
(WebCore::ServiceWorkerClientData::encode const):
(WebCore::ServiceWorkerClientData::decode):
- workers/service/ServiceWorkerClientIdentifier.h:
(WebCore::ServiceWorkerClientIdentifier::encode const):
(WebCore::ServiceWorkerClientIdentifier::decode):
- workers/service/ServiceWorkerTypes.h:
- workers/service/ServiceWorkerWindowClient.cpp:
(WebCore::ServiceWorkerWindowClient::ServiceWorkerWindowClient):
- workers/service/ServiceWorkerWindowClient.h:
- workers/service/context/SWContextManager.cpp:
(WebCore::SWContextManager::postMessageToServiceWorkerGlobalScope):
- workers/service/context/SWContextManager.h:
- workers/service/context/ServiceWorkerThread.cpp:
(WebCore::ServiceWorkerThread::postMessageToServiceWorkerGlobalScope):
- workers/service/context/ServiceWorkerThread.h:
- workers/service/server/SWClientConnection.h:
Source/WebKit:
- Shared/WebCoreArgumentCoders.cpp:
- Shared/WebCoreArgumentCoders.h:
- StorageProcess/ServiceWorker/WebSWServerConnection.cpp:
(WebKit::WebSWServerConnection::postMessageToServiceWorkerGlobalScope):
- StorageProcess/ServiceWorker/WebSWServerConnection.h:
- StorageProcess/ServiceWorker/WebSWServerConnection.messages.in:
- WebProcess/Storage/WebSWClientConnection.cpp:
(WebKit::WebSWClientConnection::postMessageToServiceWorkerGlobalScope):
- WebProcess/Storage/WebSWClientConnection.h:
- WebProcess/Storage/WebSWContextManagerConnection.cpp:
(WebKit::WebSWContextManagerConnection::postMessageToServiceWorkerGlobalScope):
- WebProcess/Storage/WebSWContextManagerConnection.h:
- WebProcess/Storage/WebSWContextManagerConnection.messages.in:
LayoutTests:
Add layout test coverage.
- http/tests/workers/service/Client-properties-auxiliary-expected.txt: Added.
- http/tests/workers/service/Client-properties-auxiliary.html: Added.
- http/tests/workers/service/Client-properties-expected.txt: Added.
- http/tests/workers/service/Client-properties-subframe-expected.txt: Added.
- http/tests/workers/service/Client-properties-subframe.html: Added.
- http/tests/workers/service/Client-properties.html: Added.
- http/tests/workers/service/resources/Client-properties-worker.js: Added.
- 9:13 AM Changeset in webkit [224879] by
-
- 113 edits3 moves2 adds in trunk
Unreviewed, rolling out r224863.
Introduced LayoutTest crashes on iOS Simulator.
Reverted changeset:
"Move JSONValues to WTF and convert uses of InspectorValues.h
to JSONValues.h"
https://bugs.webkit.org/show_bug.cgi?id=173793
https://trac.webkit.org/changeset/224863
- 9:06 AM WebKitGTK/Gardening/Calendar edited by
- (diff)
- 8:59 AM Changeset in webkit [224878] by
-
- 2 edits in trunk/Source/WebKit
Remove access to "com.apple.pbs.fetch_services" from WebContent sandbox
https://bugs.webkit.org/show_bug.cgi?id=179689
<rdar://problem/35369172>
Reviewed by Per Arne Vollan.
WebKit's WebContent process should not have any need to interact with the fetch_services
API exposed to the system. These interactions (if needed) should be happening in the UIProcess,
so we should prevent the untrusted Web Content Process from being able to connect.
- WebProcess/com.apple.WebProcess.sb.in:
- 8:56 AM Changeset in webkit [224877] by
-
- 9 edits1 delete in trunk
Remove GTK web inspector images
https://bugs.webkit.org/show_bug.cgi?id=179716
Reviewed by Carlos Garcia Campos.
Source/WebInspectorUI:
- Scripts/copy-user-interface-resources.pl:
- UserInterface/Images/gtk/AUTHORS: Removed.
- UserInterface/Images/gtk/ActiveCallFrame.svg: Removed.
- UserInterface/Images/gtk/AnimationPlayStatePaused.svg: Removed.
- UserInterface/Images/gtk/AnimationPlayStateRunning.svg: Removed.
- UserInterface/Images/gtk/ApplicationCache.png: Removed.
- UserInterface/Images/gtk/ApplicationCache@2x.png: Removed.
- UserInterface/Images/gtk/ApplicationCacheManifest.png: Removed.
- UserInterface/Images/gtk/ApplicationCacheManifest@2x.png: Removed.
- UserInterface/Images/gtk/ArrowUp.svg: Removed.
- UserInterface/Images/gtk/Assertion.svg: Removed.
- UserInterface/Images/gtk/BackForwardArrows.svg: Removed.
- UserInterface/Images/gtk/Breakpoint.png: Removed.
- UserInterface/Images/gtk/Breakpoint@2x.png: Removed.
- UserInterface/Images/gtk/BreakpointButton.svg: Removed.
- UserInterface/Images/gtk/BreakpointInactive.png: Removed.
- UserInterface/Images/gtk/BreakpointInactive@2x.png: Removed.
- UserInterface/Images/gtk/BreakpointInactiveButton.svg: Removed.
- UserInterface/Images/gtk/Breakpoints.svg: Removed.
- UserInterface/Images/gtk/COPYING: Removed.
- UserInterface/Images/gtk/COPYING_CCBYSA3: Removed.
- UserInterface/Images/gtk/COPYING_LGPL2: Removed.
- UserInterface/Images/gtk/CSSVariable.svg: Removed.
- UserInterface/Images/gtk/CallTrees.svg: Removed.
- UserInterface/Images/gtk/Canvas.svg: Removed.
- UserInterface/Images/gtk/Canvas2D.svg: Removed.
- UserInterface/Images/gtk/Canvas3D.svg: Removed.
- UserInterface/Images/gtk/CanvasOverview.svg: Removed.
- UserInterface/Images/gtk/Checkers.svg: Removed.
- UserInterface/Images/gtk/Circle.svg: Removed.
- UserInterface/Images/gtk/ClearBoth.svg: Removed.
- UserInterface/Images/gtk/ClearLeft.svg: Removed.
- UserInterface/Images/gtk/ClearRight.svg: Removed.
- UserInterface/Images/gtk/ClippingCSS.png: Removed.
- UserInterface/Images/gtk/ClippingCSS@2x.png: Removed.
- UserInterface/Images/gtk/ClippingCSSLarge.png: Removed.
- UserInterface/Images/gtk/ClippingCSSLarge@2x.png: Removed.
- UserInterface/Images/gtk/ClippingGeneric.png: Removed.
- UserInterface/Images/gtk/ClippingGeneric@2x.png: Removed.
- UserInterface/Images/gtk/ClippingGenericLarge.png: Removed.
- UserInterface/Images/gtk/ClippingGenericLarge@2x.png: Removed.
- UserInterface/Images/gtk/ClippingJS.png: Removed.
- UserInterface/Images/gtk/ClippingJS@2x.png: Removed.
- UserInterface/Images/gtk/ClippingJSLarge.png: Removed.
- UserInterface/Images/gtk/ClippingJSLarge@2x.png: Removed.
- UserInterface/Images/gtk/Close.svg: Removed.
- UserInterface/Images/gtk/CloseLarge.svg: Removed.
- UserInterface/Images/gtk/CloseWhite.svg: Removed.
- UserInterface/Images/gtk/ColorIcon.png: Removed.
- UserInterface/Images/gtk/ColorIcon@2x.png: Removed.
- UserInterface/Images/gtk/Console.svg: Removed.
- UserInterface/Images/gtk/Cookie.png: Removed.
- UserInterface/Images/gtk/Cookie@2x.png: Removed.
- UserInterface/Images/gtk/Crosshair.svg: Removed.
- UserInterface/Images/gtk/CubicBezier.svg: Removed.
- UserInterface/Images/gtk/DOMBreakpoint.svg: Removed.
- UserInterface/Images/gtk/DOMCharacterData.svg: Removed.
- UserInterface/Images/gtk/DOMComment.svg: Removed.
- UserInterface/Images/gtk/DOMDocument.svg: Removed.
- UserInterface/Images/gtk/DOMDocumentType.svg: Removed.
- UserInterface/Images/gtk/DOMElement.svg: Removed.
- UserInterface/Images/gtk/DOMNode.svg: Removed.
- UserInterface/Images/gtk/DOMTextNode.svg: Removed.
- UserInterface/Images/gtk/Database.png: Removed.
- UserInterface/Images/gtk/Database@2x.png: Removed.
- UserInterface/Images/gtk/DatabaseTable.png: Removed.
- UserInterface/Images/gtk/DatabaseTable@2x.png: Removed.
- UserInterface/Images/gtk/Debug.svg: Removed.
- UserInterface/Images/gtk/Debugger.svg: Removed.
- UserInterface/Images/gtk/DisclosureTriangles.svg: Removed.
- UserInterface/Images/gtk/DockBottom.svg: Removed.
- UserInterface/Images/gtk/DockLeft.svg: Removed.
- UserInterface/Images/gtk/DockRight.svg: Removed.
- UserInterface/Images/gtk/DocumentCSS.png: Removed.
- UserInterface/Images/gtk/DocumentCSS@2x.png: Removed.
- UserInterface/Images/gtk/DocumentCSSLarge.png: Removed.
- UserInterface/Images/gtk/DocumentCSSLarge@2x.png: Removed.
- UserInterface/Images/gtk/DocumentFont.png: Removed.
- UserInterface/Images/gtk/DocumentFont@2x.png: Removed.
- UserInterface/Images/gtk/DocumentFontLarge.png: Removed.
- UserInterface/Images/gtk/DocumentFontLarge@2x.png: Removed.
- UserInterface/Images/gtk/DocumentGeneric.png: Removed.
- UserInterface/Images/gtk/DocumentGeneric@2x.png: Removed.
- UserInterface/Images/gtk/DocumentGenericLarge.png: Removed.
- UserInterface/Images/gtk/DocumentGenericLarge@2x.png: Removed.
- UserInterface/Images/gtk/DocumentImage.png: Removed.
- UserInterface/Images/gtk/DocumentImage@2x.png: Removed.
- UserInterface/Images/gtk/DocumentImageLarge.png: Removed.
- UserInterface/Images/gtk/DocumentImageLarge@2x.png: Removed.
- UserInterface/Images/gtk/DocumentJS.png: Removed.
- UserInterface/Images/gtk/DocumentJS@2x.png: Removed.
- UserInterface/Images/gtk/DocumentJSLarge.png: Removed.
- UserInterface/Images/gtk/DocumentJSLarge@2x.png: Removed.
- UserInterface/Images/gtk/DocumentMarkup.png: Removed.
- UserInterface/Images/gtk/DocumentMarkup@2x.png: Removed.
- UserInterface/Images/gtk/DocumentMarkupLarge.png: Removed.
- UserInterface/Images/gtk/DocumentMarkupLarge@2x.png: Removed.
- UserInterface/Images/gtk/DownloadArrow.svg: Removed.
- UserInterface/Images/gtk/Elements.svg: Removed.
- UserInterface/Images/gtk/Error.svg: Removed.
- UserInterface/Images/gtk/Errors.svg: Removed.
- UserInterface/Images/gtk/ErrorsEnabled.svg: Removed.
- UserInterface/Images/gtk/EventListener.svg: Removed.
- UserInterface/Images/gtk/Events.svg: Removed.
- UserInterface/Images/gtk/Exception.svg: Removed.
- UserInterface/Images/gtk/Eye.svg: Removed.
- UserInterface/Images/gtk/FilterFieldActiveGlyph.svg: Removed.
- UserInterface/Images/gtk/FilterFieldGlyph.svg: Removed.
- UserInterface/Images/gtk/FloatLeft.svg: Removed.
- UserInterface/Images/gtk/FloatRight.svg: Removed.
- UserInterface/Images/gtk/FolderGeneric.png: Removed.
- UserInterface/Images/gtk/FolderGeneric@2x.png: Removed.
- UserInterface/Images/gtk/FontStyleItalic.svg: Removed.
- UserInterface/Images/gtk/FontStyleNormal.svg: Removed.
- UserInterface/Images/gtk/Function.svg: Removed.
- UserInterface/Images/gtk/Gear.svg: Removed.
- UserInterface/Images/gtk/GoToArrow.svg: Removed.
- UserInterface/Images/gtk/GradientStop.png: Removed.
- UserInterface/Images/gtk/GradientStop@2x.png: Removed.
- UserInterface/Images/gtk/GradientStopSelected.png: Removed.
- UserInterface/Images/gtk/GradientStopSelected@2x.png: Removed.
- UserInterface/Images/gtk/HeapAllocationsInstrument.svg: Removed.
- UserInterface/Images/gtk/HeapSnapshotObjectGraph.svg: Removed.
- UserInterface/Images/gtk/HierarchicalNavigationItemChevron.svg: Removed.
- UserInterface/Images/gtk/HoverMenuButton.png: Removed.
- UserInterface/Images/gtk/HoverMenuButton@2x.png: Removed.
- UserInterface/Images/gtk/IgnoreCaches.svg: Removed.
- UserInterface/Images/gtk/Image.svg: Removed.
- UserInterface/Images/gtk/IndeterminateProgressSpinner1.svg: Removed.
- UserInterface/Images/gtk/IndeterminateProgressSpinner10.svg: Removed.
- UserInterface/Images/gtk/IndeterminateProgressSpinner11.svg: Removed.
- UserInterface/Images/gtk/IndeterminateProgressSpinner12.svg: Removed.
- UserInterface/Images/gtk/IndeterminateProgressSpinner2.svg: Removed.
- UserInterface/Images/gtk/IndeterminateProgressSpinner3.svg: Removed.
- UserInterface/Images/gtk/IndeterminateProgressSpinner4.svg: Removed.
- UserInterface/Images/gtk/IndeterminateProgressSpinner5.svg: Removed.
- UserInterface/Images/gtk/IndeterminateProgressSpinner6.svg: Removed.
- UserInterface/Images/gtk/IndeterminateProgressSpinner7.svg: Removed.
- UserInterface/Images/gtk/IndeterminateProgressSpinner8.svg: Removed.
- UserInterface/Images/gtk/IndeterminateProgressSpinner9.svg: Removed.
- UserInterface/Images/gtk/Info.svg: Removed.
- UserInterface/Images/gtk/InstructionPointer.png: Removed.
- UserInterface/Images/gtk/InstructionPointer@2x.png: Removed.
- UserInterface/Images/gtk/Issues.svg: Removed.
- UserInterface/Images/gtk/IssuesEnabled.svg: Removed.
- UserInterface/Images/gtk/LayerBorders.svg: Removed.
- UserInterface/Images/gtk/Layers.svg: Removed.
- UserInterface/Images/gtk/LayoutInstrument.svg: Removed.
- UserInterface/Images/gtk/ListStylePositionInside.svg: Removed.
- UserInterface/Images/gtk/ListStylePositionOutside.svg: Removed.
- UserInterface/Images/gtk/LocalStorage.png: Removed.
- UserInterface/Images/gtk/LocalStorage@2x.png: Removed.
- UserInterface/Images/gtk/Locked.svg: Removed.
- UserInterface/Images/gtk/Log.svg: Removed.
- UserInterface/Images/gtk/Logs.svg: Removed.
- UserInterface/Images/gtk/MemoryInstrument.svg: Removed.
- UserInterface/Images/gtk/Minus.svg: Removed.
- UserInterface/Images/gtk/Native.svg: Removed.
- UserInterface/Images/gtk/NavigationItemCheckers.svg: Removed.
- UserInterface/Images/gtk/NavigationItemCodeCoverage.svg: Removed.
- UserInterface/Images/gtk/NavigationItemCurleyBraces.svg: Removed.
- UserInterface/Images/gtk/NavigationItemGarbageCollect.svg: Removed.
- UserInterface/Images/gtk/NavigationItemTrash.svg: Removed.
- UserInterface/Images/gtk/NavigationItemTypes.svg: Removed.
- UserInterface/Images/gtk/Network.svg: Removed.
- UserInterface/Images/gtk/NetworkInstrument.svg: Removed.
- UserInterface/Images/gtk/NewTab.svg: Removed.
- UserInterface/Images/gtk/NewTabPlus.svg: Removed.
- UserInterface/Images/gtk/Paint.svg: Removed.
- UserInterface/Images/gtk/Path.svg: Removed.
- UserInterface/Images/gtk/Pause.svg: Removed.
- UserInterface/Images/gtk/PausedBreakpoint.svg: Removed.
- UserInterface/Images/gtk/Pencil.svg: Removed.
- UserInterface/Images/gtk/Plus13.svg: Removed.
- UserInterface/Images/gtk/Plus15.svg: Removed.
- UserInterface/Images/gtk/Printer.svg: Removed.
- UserInterface/Images/gtk/Program.svg: Removed.
- UserInterface/Images/gtk/PseudoElement.svg: Removed.
- UserInterface/Images/gtk/Receiving.svg: Removed.
- UserInterface/Images/gtk/Record.svg: Removed.
- UserInterface/Images/gtk/Recording.svg: Removed.
- UserInterface/Images/gtk/Reflection.svg: Removed.
- UserInterface/Images/gtk/ReloadFull.svg: Removed.
- UserInterface/Images/gtk/ReloadToolbar.svg: Removed.
- UserInterface/Images/gtk/RenderingFrame.svg: Removed.
- UserInterface/Images/gtk/RenderingFramesInstrument.svg: Removed.
- UserInterface/Images/gtk/Request.svg: Removed.
- UserInterface/Images/gtk/Resources.svg: Removed.
- UserInterface/Images/gtk/Response.svg: Removed.
- UserInterface/Images/gtk/ResultLine.svg: Removed.
- UserInterface/Images/gtk/Resume.svg: Removed.
- UserInterface/Images/gtk/ScriptsInstrument.svg: Removed.
- UserInterface/Images/gtk/Search.svg: Removed.
- UserInterface/Images/gtk/SearchResults.svg: Removed.
- UserInterface/Images/gtk/Sending.svg: Removed.
- UserInterface/Images/gtk/SessionStorage.png: Removed.
- UserInterface/Images/gtk/SessionStorage@2x.png: Removed.
- UserInterface/Images/gtk/ShadowDOM.svg: Removed.
- UserInterface/Images/gtk/SliderThumb.png: Removed.
- UserInterface/Images/gtk/SliderThumb@2x.png: Removed.
- UserInterface/Images/gtk/SliderThumbPressed.png: Removed.
- UserInterface/Images/gtk/SliderThumbPressed@2x.png: Removed.
- UserInterface/Images/gtk/SortIndicatorArrows.svg: Removed.
- UserInterface/Images/gtk/Source.svg: Removed.
- UserInterface/Images/gtk/SplitToggleUp.svg: Removed.
- UserInterface/Images/gtk/StepInto.svg: Removed.
- UserInterface/Images/gtk/StepOut.svg: Removed.
- UserInterface/Images/gtk/StepOver.svg: Removed.
- UserInterface/Images/gtk/Stop.svg: Removed.
- UserInterface/Images/gtk/Stopwatch.svg: Removed.
- UserInterface/Images/gtk/Storage.svg: Removed.
- UserInterface/Images/gtk/StyleRule.svg: Removed.
- UserInterface/Images/gtk/StyleRuleInheritedElement.svg: Removed.
- UserInterface/Images/gtk/StyleRulePseudoElement.svg: Removed.
- UserInterface/Images/gtk/TailDeletedFunction.svg: Removed.
- UserInterface/Images/gtk/TextAlignCenter.svg: Removed.
- UserInterface/Images/gtk/TextAlignJustify.svg: Removed.
- UserInterface/Images/gtk/TextAlignLeft.svg: Removed.
- UserInterface/Images/gtk/TextAlignRight.svg: Removed.
- UserInterface/Images/gtk/TextDecorationLineThrough.svg: Removed.
- UserInterface/Images/gtk/TextDecorationOverline.svg: Removed.
- UserInterface/Images/gtk/TextDecorationUnderline.svg: Removed.
- UserInterface/Images/gtk/TextTransformCapitalize.svg: Removed.
- UserInterface/Images/gtk/TextTransformLowercase.svg: Removed.
- UserInterface/Images/gtk/TextTransformUppercase.svg: Removed.
- UserInterface/Images/gtk/Thread.svg: Removed.
- UserInterface/Images/gtk/Time.svg: Removed.
- UserInterface/Images/gtk/Timeline.svg: Removed.
- UserInterface/Images/gtk/TimelineRecordAPI.svg: Removed.
- UserInterface/Images/gtk/TimelineRecordAnimation.svg: Removed.
- UserInterface/Images/gtk/TimelineRecordComposite.svg: Removed.
- UserInterface/Images/gtk/TimelineRecordConsoleProfile.svg: Removed.
- UserInterface/Images/gtk/TimelineRecordEvent.svg: Removed.
- UserInterface/Images/gtk/TimelineRecordLayout.svg: Removed.
- UserInterface/Images/gtk/TimelineRecordPaint.svg: Removed.
- UserInterface/Images/gtk/TimelineRecordProbeSampled.svg: Removed.
- UserInterface/Images/gtk/TimelineRecordScriptEvaluated.svg: Removed.
- UserInterface/Images/gtk/TimelineRecordStyle.svg: Removed.
- UserInterface/Images/gtk/TimelineRecordTimer.svg: Removed.
- UserInterface/Images/gtk/ToggleLeftSidebar.svg: Removed.
- UserInterface/Images/gtk/ToggleRightSidebar.svg: Removed.
- UserInterface/Images/gtk/TypeBoolean.svg: Removed.
- UserInterface/Images/gtk/TypeNull.svg: Removed.
- UserInterface/Images/gtk/TypeNumber.svg: Removed.
- UserInterface/Images/gtk/TypeObject.svg: Removed.
- UserInterface/Images/gtk/TypeRegex.svg: Removed.
- UserInterface/Images/gtk/TypeString.svg: Removed.
- UserInterface/Images/gtk/TypeSymbol.svg: Removed.
- UserInterface/Images/gtk/TypeUndefined.svg: Removed.
- UserInterface/Images/gtk/Undock.svg: Removed.
- UserInterface/Images/gtk/UpDownArrows.svg: Removed.
- UserInterface/Images/gtk/UserInputPrompt.svg: Removed.
- UserInterface/Images/gtk/UserInputPromptPrevious.svg: Removed.
- UserInterface/Images/gtk/UserInputResult.svg: Removed.
- UserInterface/Images/gtk/VisualStyleNone.svg: Removed.
- UserInterface/Images/gtk/VisualStylePropertyLinked.svg: Removed.
- UserInterface/Images/gtk/VisualStylePropertyUnlinked.svg: Removed.
- UserInterface/Images/gtk/Warning.svg: Removed.
- UserInterface/Images/gtk/WebSocket.png: Removed.
- UserInterface/Images/gtk/WebSocket@2x.png: Removed.
- UserInterface/Images/gtk/WebSocketLarge.png: Removed.
- UserInterface/Images/gtk/WebSocketLarge@2x.png: Removed.
- UserInterface/Images/gtk/Weight.svg: Removed.
- UserInterface/Images/gtk/WorkerScript.png: Removed.
- UserInterface/Images/gtk/WorkerScript@2x.png: Removed.
- UserInterface/Images/gtk/WorkerScriptLarge.png: Removed.
- UserInterface/Images/gtk/WorkerScriptLarge@2x.png: Removed.
Source/WebKit:
- InspectorGResources.cmake:
Tools:
- Scripts/webkitdirs.pm:
(shouldRemoveCMakeCache):
- glib/generate-inspector-gresource-manifest.py:
(get_filenames.should_ignore_resource):
- gtk/manifest.txt.in:
- wpe/manifest.txt.in:
- 8:24 AM Changeset in webkit [224876] by
-
- 25 edits1 copy in trunk
Remove service worker selection based on registration
https://bugs.webkit.org/show_bug.cgi?id=179705
Patch by Youenn Fablet <youenn@apple.com> on 2017-11-15
Reviewed by Alex Christensen.
LayoutTests/imported/w3c:
- web-platform-tests/service-workers/service-worker/controller-on-reload.https-expected.txt:
Source/WebCore:
Covered by updated tests.
Selection is now handled at navigation time.
We can remove the selection/unselection of worker based on registration.
- workers/service/ServiceWorkerContainer.cpp:
(WebCore::ServiceWorkerContainer::jobResolvedWithUnregistrationResult):
- workers/service/ServiceWorkerRegistration.cpp:
(WebCore::ServiceWorkerRegistration::ServiceWorkerRegistration):
LayoutTests:
Updating tests to use actual selected frames.
- http/tests/inspector/network/resource-response-service-worker.html:
- http/tests/inspector/network/resources/fetch-service-worker.js:
- http/tests/workers/service/ServiceWorkerGlobalScope-properties.html:
- http/tests/workers/service/basic-fetch.https-expected.txt:
- http/tests/workers/service/cors-image-fetch-expected.txt:
- http/tests/workers/service/cors-image-fetch.html:
- http/tests/workers/service/image-fetch-expected.txt:
- http/tests/workers/service/resources/basic-ServiceWorker-postMessage.js:
(then):
- http/tests/workers/service/resources/basic-fetch-worker.js:
- http/tests/workers/service/resources/basic-fetch.js:
(async.test):
- http/tests/workers/service/resources/cors-image-fetch.js:
(async.test):
(async.loadedImage): Deleted.
(async.erroredImage): Deleted.
(async.logStatus): Deleted.
- http/tests/workers/service/resources/cors-image-fetch-iframe.html: Added.
- http/tests/workers/service/resources/image-fetch.js:
(async.test):
(done): Deleted.
(async.loadedImage): Deleted.
(async.erroredImage): Deleted.
(async.logStatus): Deleted.
- http/tests/workers/service/resources/service-worker-crossorigin-fetch.js:
(async.test):
(done): Deleted.
(async.logStatus): Deleted.
- http/tests/workers/service/resources/service-worker-fetch.js:
(async.test):
(done): Deleted.
(async.logStatus): Deleted.
- http/tests/workers/service/resources/service-worker-importScript.js:
(async.test):
(async.logStatus): Deleted.
- http/tests/workers/service/resources/sw-test-pre.js:
(async.interceptedFrame):
- http/tests/workers/service/resources/tainted-image-fetch.js:
(async.test):
(async.loadedImage): Deleted.
(async.erroredImage): Deleted.
(async.logStatus): Deleted.
- http/tests/workers/service/service-worker-fetch.https-expected.txt:
- http/tests/workers/service/tainted-image-fetch-expected.txt:
- 8:17 AM Changeset in webkit [224875] by
-
- 2 edits in trunk/Tools
REGRESSION(r221877): 'future' handled incorrectly for mac
https://bugs.webkit.org/show_bug.cgi?id=179711
<rdar://problem/35546604>
Reviewed by Alex Christensen.
- Scripts/webkitpy/port/mac.py:
(MacPort.default_baseline_search_path): Use platform/mac-<version> instead of
platform/<version> as the baseline search path.
- 5:26 AM Changeset in webkit [224874] by
-
- 7 edits3 adds2 deletes in trunk/LayoutTests
[GTK][WPE] Unreviewed test gardening
https://bugs.webkit.org/show_bug.cgi?id=179726
Unreviewed test gardening.
- platform/gtk/TestExpectations: Add new expectations.
- platform/gtk/fast/events/input-events-paste-rich-datatransfer-expected.txt: Rebaseline for bug 179431.
- platform/gtk/js/dom/dom-static-property-for-in-iteration-expected.txt: Rebaseline for bug 179494.
- platform/wpe/TestExpectations: Remove expectations that were redundant with other (more correct) expectations in the same file, or with the new expectation file.
- platform/wpe/fast/workers/WorkerGlobalScope-properties-prototype-expected.txt: Removed: bug 179094 improved the results and made them match the platform-neutral expectation file.
- platform/wpe/fast/workers/self-hasOwnProperty-expected.txt: Removed: bug 179094 improved the results and made them match the platform-neutral expectation file.
- platform/wpe/http/tests/uri/css-href-expected.txt: Added: missing baseline.
- platform/wpe/imported/w3c/web-platform-tests/encrypted-media/encrypted-media-default-feature-policy.https.sub-expected.txt: Rebaseline to make the test useful as a regression test.
- platform/wpe/js/dom/dom-static-property-for-in-iteration-expected.txt: Rebaseline for bug 179494.
- 5:00 AM Changeset in webkit [224873] by
-
- 3 edits in trunk/Source/WebCore
[Cairo] GraphicsContext::setPlatformShadow() has to update state's shadow offset when ignoring transforms
https://bugs.webkit.org/show_bug.cgi?id=179725
Reviewed by Carlos Garcia Campos.
In r224753, GraphicsContext::setPlatformShadow() stopped updating the
shadow offset value that's kept in GraphicsContextState. This regressed
a few tests, so the adjustment of the shadow offset value in the
GraphicsContext state is brought back.
- platform/graphics/cairo/CairoOperations.cpp:
(WebCore::Cairo::State::setShadowValues):
- platform/graphics/cairo/GraphicsContextCairo.cpp:
(WebCore::GraphicsContext::setPlatformShadow):
- 4:06 AM Changeset in webkit [224872] by
-
- 6 edits in trunk/Source
[GTK] Automatically adjust font size when gtk-xft-dpi changes
https://bugs.webkit.org/show_bug.cgi?id=142673
Some follow-up fixes for the previous patch.
Patch by Gabriel Ivascu <givascu@igalia.com> on 2017-11-15
Reviewed by Carlos Garcia Campos.
Source/WebCore:
- platform/PlatformScreen.h:
- platform/gtk/PlatformScreenGtk.cpp:
(WebCore::screenDPIObserverHandlersMap):
(WebCore::gtkXftDPIChangedCallback):
(WebCore::setScreenDPIObserverHandler):
- platform/wpe/PlatformScreenWPE.cpp:
(WebCore::setScreenDPIObserverHandler):
Source/WebKit:
- UIProcess/API/glib/WebKitSettings.cpp:
(webKitSettingsDispose):
(webKitSettingsConstructed):
Nov 14, 2017:
- 11:56 PM Changeset in webkit [224871] by
-
- 37 edits5 adds in trunk
AX: AOM: Implement AccessibleNode class and support label and role attributes
https://bugs.webkit.org/show_bug.cgi?id=179494
Reviewed by Ryosuke Niwa.
Source/WebCore:
Accessibility Object Model
Explainer: https://wicg.github.io/aom/explainer.html
Spec: https://wicg.github.io/aom/spec/
This change adds an accessibleNode getter on Element, and implements
the role and label properties of AccessibleNode.
In existing accessibility code, places where we previously retrieve an
ARIA attribute are replaced with a new function that first checks the
AOM property and then checks the equivalent ARIA attribute.
Test: accessibility/accessibility-object-model.html
- CMakeLists.txt:
- DerivedSources.cpp:
- DerivedSources.make:
- Sources.txt:
- WebCore.xcodeproj/project.pbxproj:
- accessibility/AXObjectCache.cpp:
(WebCore::nodeHasRole):
(WebCore::AXObjectCache::handleLiveRegionCreated):
- accessibility/AccessibilityAllInOne.cpp:
- accessibility/AccessibilityImageMapLink.cpp:
(WebCore::AccessibilityImageMapLink::roleValue const):
(WebCore::AccessibilityImageMapLink::accessibilityDescription const):
- accessibility/AccessibilityListBoxOption.cpp:
(WebCore::AccessibilityListBoxOption::stringValue const):
- accessibility/AccessibilityNodeObject.cpp:
(WebCore::AccessibilityNodeObject::ariaAccessibilityDescription const):
(WebCore::siblingWithAriaRole):
(WebCore::AccessibilityNodeObject::textForLabelElement const):
(WebCore::AccessibilityNodeObject::alternativeText const):
(WebCore::AccessibilityNodeObject::alternativeTextForWebArea const):
(WebCore::AccessibilityNodeObject::stringValue const):
(WebCore::accessibleNameForNode):
(WebCore::AccessibilityNodeObject::determineAriaRoleAttribute const):
- accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::hasProperty const):
(WebCore::AccessibilityObject::stringValueForProperty const):
(WebCore::AccessibilityObject::supportsARIAAttributes const):
- accessibility/AccessibilityObject.h:
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::stringValue const):
(WebCore::AccessibilityRenderObject::exposesTitleUIElement const):
(WebCore::AccessibilityRenderObject::determineAccessibilityRole):
- accessibility/AccessibleNode.cpp: Added.
(WebCore::ariaAttributeMap):
(WebCore::isPropertyValueString):
(WebCore::AccessibleNode::hasProperty):
(WebCore::AccessibleNode::valueForProperty):
(WebCore::AccessibleNode::effectiveStringValueForElement):
(WebCore::AccessibleNode::stringValueForProperty):
(WebCore::AccessibleNode::setStringProperty):
(WebCore::AccessibleNode::role const):
(WebCore::AccessibleNode::setRole):
(WebCore::AccessibleNode::label const):
(WebCore::AccessibleNode::setLabel):
- accessibility/AccessibleNode.h: Added.
(WebCore::AXPropertyHashTraits::emptyValue):
(WebCore::AXPropertyHashTraits::constructDeletedValue):
(WebCore::AXPropertyHashTraits::isDeletedValue):
(WebCore::AccessibleNode::AccessibleNode):
(WebCore::AccessibleNode::ref):
(WebCore::AccessibleNode::deref):
- accessibility/AccessibleNode.idl: Added.
- bindings/js/WebCoreBuiltinNames.h:
- dom/Element.cpp:
(WebCore::Element::canContainRangeEndPoint const):
(WebCore::Element::accessibleNode):
(WebCore::Element::existingAccessibleNode const):
- dom/Element.h:
- dom/Element.idl:
- dom/ElementRareData.cpp:
- dom/ElementRareData.h:
(WebCore::ElementRareData::accessibleNode const):
(WebCore::ElementRareData::setAccessibleNode):
- editing/TextIterator.cpp:
(WebCore::isRendererReplacedElement):
- page/RuntimeEnabledFeatures.h:
(WebCore::RuntimeEnabledFeatures::setAccessibilityObjectModelEnabled):
(WebCore::RuntimeEnabledFeatures::accessibilityObjectModelEnabled const):
- rendering/RenderMenuList.cpp:
(RenderMenuList::itemAccessibilityText const):
Source/WebKit:
- Shared/WebPreferences.yaml:
- UIProcess/API/C/WKPreferences.cpp:
(WKPreferencesSetAccessibilityObjectModelEnabled):
(WKPreferencesGetAccessibilityObjectModelEnabled):
- UIProcess/API/C/WKPreferencesRefPrivate.h:
Source/WebKitLegacy/mac:
- WebView/WebPreferenceKeysPrivate.h:
- WebView/WebPreferences.mm:
(+[WebPreferences initialize]):
(-[WebPreferences accessibilityObjectModelEnabled]):
(-[WebPreferences setAccessibilityObjectModelEnabled:]):
- WebView/WebPreferencesPrivate.h:
- WebView/WebView.mm:
(-[WebView _preferencesChanged:]):
Tools:
- DumpRenderTree/mac/DumpRenderTree.mm:
(enableExperimentalFeatures):
- WebKitTestRunner/TestController.cpp:
(WTR::TestController::resetPreferencesToConsistentValues):
LayoutTests:
- accessibility/accessibility-object-model-expected.txt: Added.
- accessibility/accessibility-object-model.html: Added.
- js/dom/dom-static-property-for-in-iteration-expected.txt:
- 10:08 PM Changeset in webkit [224870] by
-
- 2 edits2 adds in trunk/Source/WebCore
[Cairo] Add GraphicsContextImplCairo stub
https://bugs.webkit.org/show_bug.cgi?id=179658
Reviewed by Carlos Garcia Campos.
Add the GraphicsContextImplCairo class, which at this point is still
an empty implementation of the GraphicsContextImpl interface. Plan for
the near future is to start mapping method invocations to CairoOperation
functions, essentially mirroring what the Cairo-specific GraphicsContext
methods do today.
In the future this implementation would hopefully allow us to apply a
recorded list of GraphicsContext commands against a PlatformContextCairo
instance.
- platform/SourcesCairo.txt:
- platform/graphics/cairo/GraphicsContextImplCairo.cpp: Added.
(WebCore::GraphicsContextImplCairo::GraphicsContextImplCairo):
(WebCore::m_platformContext):
(WebCore::GraphicsContextImplCairo::updateState):
(WebCore::GraphicsContextImplCairo::clearShadow):
(WebCore::GraphicsContextImplCairo::setLineCap):
(WebCore::GraphicsContextImplCairo::setLineDash):
(WebCore::GraphicsContextImplCairo::setLineJoin):
(WebCore::GraphicsContextImplCairo::setMiterLimit):
(WebCore::GraphicsContextImplCairo::fillRect):
(WebCore::GraphicsContextImplCairo::fillRoundedRect):
(WebCore::GraphicsContextImplCairo::fillRectWithRoundedHole):
(WebCore::GraphicsContextImplCairo::fillPath):
(WebCore::GraphicsContextImplCairo::fillEllipse):
(WebCore::GraphicsContextImplCairo::strokeRect):
(WebCore::GraphicsContextImplCairo::strokePath):
(WebCore::GraphicsContextImplCairo::strokeEllipse):
(WebCore::GraphicsContextImplCairo::clearRect):
(WebCore::GraphicsContextImplCairo::drawGlyphs):
(WebCore::GraphicsContextImplCairo::drawImage):
(WebCore::GraphicsContextImplCairo::drawTiledImage):
(WebCore::GraphicsContextImplCairo::drawNativeImage):
(WebCore::GraphicsContextImplCairo::drawPattern):
(WebCore::GraphicsContextImplCairo::drawRect):
(WebCore::GraphicsContextImplCairo::drawLine):
(WebCore::GraphicsContextImplCairo::drawLinesForText):
(WebCore::GraphicsContextImplCairo::drawLineForDocumentMarker):
(WebCore::GraphicsContextImplCairo::drawEllipse):
(WebCore::GraphicsContextImplCairo::drawPath):
(WebCore::GraphicsContextImplCairo::drawFocusRing):
(WebCore::GraphicsContextImplCairo::save):
(WebCore::GraphicsContextImplCairo::restore):
(WebCore::GraphicsContextImplCairo::translate):
(WebCore::GraphicsContextImplCairo::rotate):
(WebCore::GraphicsContextImplCairo::scale):
(WebCore::GraphicsContextImplCairo::concatCTM):
(WebCore::GraphicsContextImplCairo::beginTransparencyLayer):
(WebCore::GraphicsContextImplCairo::endTransparencyLayer):
(WebCore::GraphicsContextImplCairo::clip):
(WebCore::GraphicsContextImplCairo::clipOut):
(WebCore::GraphicsContextImplCairo::clipPath):
(WebCore::GraphicsContextImplCairo::applyDeviceScaleFactor):
- platform/graphics/cairo/GraphicsContextImplCairo.h: Added.
- 10:05 PM Changeset in webkit [224869] by
-
- 4 edits in trunk/Source/WebCore
[Cairo] Clean up CairoOperations, GradientCairo, GraphicsContextCairo implementation files
https://bugs.webkit.org/show_bug.cgi?id=179679
Reviewed by Michael Catanzaro.
Clean up random tidbits in the CairoOperations, GradientCairo and
GraphicsContextCairo implementation files that I've been ravaging
through over the last few days.
No new tests -- no change in behavior.
- platform/graphics/cairo/CairoOperations.cpp:
Add a missing <algorithms> include, drop an unnecessary empty line.
(WebCore::Cairo::drawLine):
- platform/graphics/cairo/GradientCairo.cpp:
Add a missing CairoOperations.h include.
- platform/graphics/cairo/GraphicsContextCairo.cpp:
Drop unnecessary includes and a bunch of redundant helper functions.
(WebCore::GraphicsContext::drawLineForText):
Inline the DashArray object construction into the relay call.
(WebCore::GraphicsContext::drawLinesForText):
size_t can't be negative, so just check for DashArray being empty.
(WebCore::fillRectWithColor): Deleted.
(): Deleted.
(WebCore::drawPathShadow): Deleted.
(WebCore::fillCurrentCairoPath): Deleted.
(WebCore::shadowAndFillCurrentCairoPath): Deleted.
(WebCore::shadowAndStrokeCurrentCairoPath): Deleted.
- 9:21 PM Changeset in webkit [224868] by
-
- 2 edits in trunk/Source/JavaScriptCore
Gardening: CLoop build fix after r224862.
https://bugs.webkit.org/show_bug.cgi?id=179699
Not reviewed..
- bytecode/CodeBlock.h:
(JSC::CodeBlock::calleeSaveSpaceAsVirtualRegisters):
- 8:09 PM Changeset in webkit [224867] by
-
- 4 edits in trunk/Source/WebCore
Unreviewed, another attempt to fix builds after r224707
https://bugs.webkit.org/show_bug.cgi?id=179499
<rdar://problem/35445033>
- PlatformWin.cmake:
- Sources.txt:
- WebCore.xcodeproj/project.pbxproj:
- 7:46 PM Changeset in webkit [224866] by
-
- 5 edits in trunk/Tools
[Windows] Fix error while launching subprocess on Windows Python
https://bugs.webkit.org/show_bug.cgi?id=179637
Patch by Basuke Suzuki <Basuke Suzuki> on 2017-11-14
Reviewed by Alex Christensen.
To pass environment variables to subprocess.popen on Windows Python 2,
the dict values must be str not unicode.
Also is_native_win() method is added to port.
- Scripts/webkitpy/common/system/platforminfo.py:
(PlatformInfo.is_native_win):
- Scripts/webkitpy/common/system/platforminfo_mock.py:
(MockPlatformInfo.is_native_win):
- Scripts/webkitpy/common/system/platforminfo_unittest.py:
(TestPlatformInfo.test_os_name_and_wrappers):
- Scripts/webkitpy/port/server_process.py:
(ServerProcess.init):
- 5:25 PM Changeset in webkit [224865] by
-
- 3 edits in trunk/Source/WebCore
Unreviewed, rolling out r224860.
This change broke the macOS and iOS builds.
Reverted changeset:
"Unreviewed, fix CMake debug builds after r224707"
https://bugs.webkit.org/show_bug.cgi?id=179499
https://trac.webkit.org/changeset/224860
- 5:15 PM Changeset in webkit [224864] by
-
- 5 edits in trunk
Media query with :host inside a custom elements doesn't get updated on window resize
https://bugs.webkit.org/show_bug.cgi?id=176101
<rdar://problem/34163850>
Reviewed by Simon Fraser.
Source/WebCore:
If a media query containing :host or ::slotted stops applying we fail to update the style.
- style/StyleScope.cpp:
(WebCore::Style::invalidateHostAndSlottedStyleIfNeeded):
Factor into function.
(WebCore::Style::Scope::updateActiveStyleSheets):
(WebCore::Style::Scope::scheduleUpdate):
Invalidate elements that may match :host and ::slotted before clearing style resolver for full update.
LayoutTests:
Expand the existing test case to cover :host and ::slotted.
- fast/shadow-dom/media-query-in-shadow-style-expected.html:
- fast/shadow-dom/resources/media-query-in-shadow-style-frame.html:
- 4:43 PM Changeset in webkit [224863] by
-
- 113 edits1 copy2 moves2 deletes in trunk
Move JSONValues to WTF and convert uses of InspectorValues.h to JSONValues.h
https://bugs.webkit.org/show_bug.cgi?id=173793
Patch by Carlos Garcia Campos <cgarcia@igalia.com> on 2017-11-14
Reviewed by Brian Burg.
Source/JavaScriptCore:
Based on patch by Brian Burg.
- JavaScriptCore.xcodeproj/project.pbxproj:
- Sources.txt:
- bindings/ScriptValue.cpp:
(Inspector::jsToInspectorValue):
(Inspector::toInspectorValue):
(Deprecated::ScriptValue::toInspectorValue const):
- bindings/ScriptValue.h:
- inspector/AsyncStackTrace.cpp:
- inspector/ConsoleMessage.cpp:
- inspector/ContentSearchUtilities.cpp:
- inspector/InjectedScript.cpp:
(Inspector::InjectedScript::getFunctionDetails):
(Inspector::InjectedScript::functionDetails):
(Inspector::InjectedScript::getPreview):
(Inspector::InjectedScript::getProperties):
(Inspector::InjectedScript::getDisplayableProperties):
(Inspector::InjectedScript::getInternalProperties):
(Inspector::InjectedScript::getCollectionEntries):
(Inspector::InjectedScript::saveResult):
(Inspector::InjectedScript::wrapCallFrames const):
(Inspector::InjectedScript::wrapObject const):
(Inspector::InjectedScript::wrapTable const):
(Inspector::InjectedScript::previewValue const):
(Inspector::InjectedScript::setExceptionValue):
(Inspector::InjectedScript::clearExceptionValue):
(Inspector::InjectedScript::inspectObject):
(Inspector::InjectedScript::releaseObject):
- inspector/InjectedScriptBase.cpp:
(Inspector::InjectedScriptBase::makeCall):
(Inspector::InjectedScriptBase::makeEvalCall):
- inspector/InjectedScriptBase.h:
- inspector/InjectedScriptManager.cpp:
(Inspector::InjectedScriptManager::injectedScriptForObjectId):
- inspector/InspectorBackendDispatcher.cpp:
(Inspector::BackendDispatcher::CallbackBase::sendSuccess):
(Inspector::BackendDispatcher::dispatch):
(Inspector::BackendDispatcher::sendResponse):
(Inspector::BackendDispatcher::sendPendingErrors):
(Inspector::BackendDispatcher::getPropertyValue):
(Inspector::castToInteger):
(Inspector::castToNumber):
(Inspector::BackendDispatcher::getInteger):
(Inspector::BackendDispatcher::getDouble):
(Inspector::BackendDispatcher::getString):
(Inspector::BackendDispatcher::getBoolean):
(Inspector::BackendDispatcher::getObject):
(Inspector::BackendDispatcher::getArray):
(Inspector::BackendDispatcher::getValue):
- inspector/InspectorBackendDispatcher.h:
- inspector/InspectorProtocolTypes.h:
(Inspector::Protocol::Array::openAccessors):
(Inspector::Protocol::PrimitiveBindingTraits::assertValueHasExpectedType):
(Inspector::Protocol::BindingTraits<Protocol::Array<T>>::runtimeCast):
(Inspector::Protocol::BindingTraits<Protocol::Array<T>>::assertValueHasExpectedType):
(Inspector::Protocol::BindingTraits<JSON::Value>::assertValueHasExpectedType):
- inspector/ScriptCallFrame.cpp:
- inspector/ScriptCallStack.cpp:
- inspector/agents/InspectorAgent.cpp:
(Inspector::InspectorAgent::inspect):
- inspector/agents/InspectorAgent.h:
- inspector/agents/InspectorDebuggerAgent.cpp:
(Inspector::buildAssertPauseReason):
(Inspector::buildCSPViolationPauseReason):
(Inspector::InspectorDebuggerAgent::buildBreakpointPauseReason):
(Inspector::InspectorDebuggerAgent::buildExceptionPauseReason):
(Inspector::buildObjectForBreakpointCookie):
(Inspector::InspectorDebuggerAgent::breakpointActionsFromProtocol):
(Inspector::parseLocation):
(Inspector::InspectorDebuggerAgent::setBreakpointByUrl):
(Inspector::InspectorDebuggerAgent::setBreakpoint):
(Inspector::InspectorDebuggerAgent::continueToLocation):
(Inspector::InspectorDebuggerAgent::schedulePauseOnNextStatement):
(Inspector::InspectorDebuggerAgent::didParseSource):
(Inspector::InspectorDebuggerAgent::breakProgram):
- inspector/agents/InspectorDebuggerAgent.h:
- inspector/agents/InspectorRuntimeAgent.cpp:
(Inspector::InspectorRuntimeAgent::callFunctionOn):
(Inspector::InspectorRuntimeAgent::saveResult):
(Inspector::InspectorRuntimeAgent::getRuntimeTypesForVariablesAtOffsets):
- inspector/agents/InspectorRuntimeAgent.h:
- inspector/scripts/codegen/generate_cpp_backend_dispatcher_header.py:
(CppBackendDispatcherHeaderGenerator._generate_dispatcher_declaration_for_command):
- inspector/scripts/codegen/generate_cpp_backend_dispatcher_implementation.py:
(CppBackendDispatcherImplementationGenerator.generate_output):
(CppBackendDispatcherImplementationGenerator._generate_dispatcher_implementation_for_command):
- inspector/scripts/codegen/generate_cpp_frontend_dispatcher_header.py:
(CppFrontendDispatcherHeaderGenerator.generate_output):
- inspector/scripts/codegen/generate_cpp_frontend_dispatcher_implementation.py:
(CppFrontendDispatcherImplementationGenerator._generate_dispatcher_implementation_for_event):
- inspector/scripts/codegen/generate_cpp_protocol_types_header.py:
(_generate_unchecked_setter_for_member):
- inspector/scripts/codegen/generate_cpp_protocol_types_implementation.py:
(CppProtocolTypesImplementationGenerator):
- inspector/scripts/codegen/generate_objc_backend_dispatcher_implementation.py:
(ObjCBackendDispatcherImplementationGenerator.generate_output):
(ObjCBackendDispatcherImplementationGenerator._generate_success_block_for_command):
- inspector/scripts/codegen/generate_objc_frontend_dispatcher_implementation.py:
(ObjCFrontendDispatcherImplementationGenerator.generate_output):
(ObjCFrontendDispatcherImplementationGenerator._generate_event):
(ObjCFrontendDispatcherImplementationGenerator._generate_event_out_parameters):
- inspector/scripts/codegen/generate_objc_internal_header.py:
(ObjCInternalHeaderGenerator.generate_output):
- inspector/scripts/codegen/generate_objc_protocol_types_implementation.py:
(ObjCProtocolTypesImplementationGenerator.generate_output):
- inspector/scripts/codegen/generator.py:
- inspector/scripts/tests/all/expected/definitions-with-mac-platform.json-result:
- inspector/scripts/tests/generic/expected/commands-with-async-attribute.json-result:
- inspector/scripts/tests/generic/expected/commands-with-optional-call-return-parameters.json-result:
- inspector/scripts/tests/generic/expected/definitions-with-mac-platform.json-result:
- inspector/scripts/tests/generic/expected/domain-availability.json-result:
- inspector/scripts/tests/generic/expected/domains-with-varying-command-sizes.json-result:
- inspector/scripts/tests/generic/expected/enum-values.json-result:
- inspector/scripts/tests/generic/expected/events-with-optional-parameters.json-result:
- inspector/scripts/tests/generic/expected/generate-domains-with-feature-guards.json-result:
- inspector/scripts/tests/generic/expected/same-type-id-different-domain.json-result:
- inspector/scripts/tests/generic/expected/shadowed-optional-type-setters.json-result:
- inspector/scripts/tests/generic/expected/type-declaration-aliased-primitive-type.json-result:
- inspector/scripts/tests/generic/expected/type-declaration-array-type.json-result:
- inspector/scripts/tests/generic/expected/type-declaration-enum-type.json-result:
- inspector/scripts/tests/generic/expected/type-declaration-object-type.json-result:
- inspector/scripts/tests/generic/expected/type-requiring-runtime-casts.json-result:
- inspector/scripts/tests/generic/expected/type-with-open-parameters.json-result:
- inspector/scripts/tests/generic/expected/worker-supported-domains.json-result:
- inspector/scripts/tests/ios/expected/definitions-with-mac-platform.json-result:
- inspector/scripts/tests/mac/expected/definitions-with-mac-platform.json-result:
Source/WebCore:
Based on patch by Brian Burg.
- ForwardingHeaders/inspector/InspectorValues.h: Removed.
- Modules/encryptedmedia/InitDataRegistry.cpp:
(WebCore::extractKeyIDsKeyids):
(WebCore::sanitizeKeyids):
- html/parser/XSSAuditorDelegate.cpp:
(WebCore::XSSAuditorDelegate::generateViolationReport):
- inspector/CommandLineAPIHost.cpp:
(WebCore::CommandLineAPIHost::inspect):
- inspector/CommandLineAPIHost.h:
- inspector/InspectorCanvas.cpp:
(WebCore::InspectorCanvas::recordAction):
(WebCore::InspectorCanvas::releaseData):
(WebCore::InspectorCanvas::indexForData):
(WebCore::buildArrayForVector):
(WebCore::InspectorCanvas::buildInitialState):
(WebCore::InspectorCanvas::buildAction):
(WebCore::InspectorCanvas::buildArrayForCanvasGradient):
(WebCore::InspectorCanvas::buildArrayForCanvasPattern):
(WebCore::InspectorCanvas::buildArrayForImageData):
(WebCore::InspectorCanvas::buildArrayForImageBitmap):
- inspector/InspectorCanvas.h:
- inspector/InspectorDatabaseResource.cpp:
- inspector/InspectorOverlay.cpp:
(WebCore::evaluateCommandInOverlay):
(WebCore::InspectorOverlay::evaluateInOverlay):
- inspector/InspectorOverlay.h:
- inspector/InspectorShaderProgram.h:
- inspector/InspectorStyleSheet.h:
(WebCore::InspectorCSSId::InspectorCSSId):
- inspector/TimelineRecordFactory.cpp:
(WebCore::TimelineRecordFactory::createGenericRecord):
(WebCore::TimelineRecordFactory::createFunctionCallData):
(WebCore::TimelineRecordFactory::createConsoleProfileData):
(WebCore::TimelineRecordFactory::createProbeSampleData):
(WebCore::TimelineRecordFactory::createEventDispatchData):
(WebCore::TimelineRecordFactory::createGenericTimerData):
(WebCore::TimelineRecordFactory::createTimerInstallData):
(WebCore::TimelineRecordFactory::createEvaluateScriptData):
(WebCore::TimelineRecordFactory::createTimeStampData):
(WebCore::TimelineRecordFactory::createAnimationFrameData):
(WebCore::createQuad):
(WebCore::TimelineRecordFactory::createPaintData):
(WebCore::TimelineRecordFactory::appendLayoutRoot):
- inspector/TimelineRecordFactory.h:
- inspector/agents/InspectorApplicationCacheAgent.cpp:
- inspector/agents/InspectorApplicationCacheAgent.h:
- inspector/agents/InspectorCSSAgent.cpp:
(WebCore::computePseudoClassMask):
(WebCore::InspectorCSSAgent::setStyleText):
(WebCore::InspectorCSSAgent::setRuleSelector):
(WebCore::InspectorCSSAgent::forcePseudoState):
- inspector/agents/InspectorCSSAgent.h:
- inspector/agents/InspectorDOMAgent.cpp:
(WebCore::parseColor):
(WebCore::parseConfigColor):
(WebCore::parseQuad):
(WebCore::InspectorDOMAgent::performSearch):
(WebCore::InspectorDOMAgent::setSearchingForNode):
(WebCore::InspectorDOMAgent::highlightConfigFromInspectorObject):
(WebCore::InspectorDOMAgent::setInspectModeEnabled):
(WebCore::InspectorDOMAgent::highlightRect):
(WebCore::InspectorDOMAgent::highlightQuad):
(WebCore::InspectorDOMAgent::innerHighlightQuad):
(WebCore::InspectorDOMAgent::highlightSelector):
(WebCore::InspectorDOMAgent::highlightNode):
(WebCore::InspectorDOMAgent::highlightNodeList):
(WebCore::InspectorDOMAgent::highlightFrame):
- inspector/agents/InspectorDOMAgent.h:
- inspector/agents/InspectorDOMDebuggerAgent.cpp:
(WebCore::InspectorDOMDebuggerAgent::didInvalidateStyleAttr):
(WebCore::InspectorDOMDebuggerAgent::willInsertDOMNode):
(WebCore::InspectorDOMDebuggerAgent::willRemoveDOMNode):
(WebCore::InspectorDOMDebuggerAgent::willModifyDOMAttr):
(WebCore::InspectorDOMDebuggerAgent::descriptionForDOMEvent):
(WebCore::InspectorDOMDebuggerAgent::pauseOnNativeEventIfNeeded):
(WebCore::InspectorDOMDebuggerAgent::willSendXMLHttpRequest):
- inspector/agents/InspectorDOMDebuggerAgent.h:
- inspector/agents/InspectorDOMStorageAgent.cpp:
(WebCore::InspectorDOMStorageAgent::getDOMStorageItems):
(WebCore::InspectorDOMStorageAgent::setDOMStorageItem):
(WebCore::InspectorDOMStorageAgent::removeDOMStorageItem):
(WebCore::InspectorDOMStorageAgent::findStorageArea):
- inspector/agents/InspectorDOMStorageAgent.h:
- inspector/agents/InspectorDatabaseAgent.cpp:
- inspector/agents/InspectorIndexedDBAgent.cpp:
(WebCore::Inspector::idbKeyFromInspectorObject):
(WebCore::Inspector::idbKeyRangeFromKeyRange):
(WebCore::InspectorIndexedDBAgent::requestData):
- inspector/agents/InspectorIndexedDBAgent.h:
- inspector/agents/InspectorNetworkAgent.cpp:
(WebCore::buildObjectForHeaders):
(WebCore::InspectorNetworkAgent::buildObjectForResourceResponse):
(WebCore::InspectorNetworkAgent::setExtraHTTPHeaders):
- inspector/agents/InspectorNetworkAgent.h:
- inspector/agents/InspectorPageAgent.cpp:
- inspector/agents/InspectorPageAgent.h:
- inspector/agents/InspectorTimelineAgent.cpp:
(WebCore::InspectorTimelineAgent::setInstruments):
(WebCore::InspectorTimelineAgent::internalStart):
(WebCore::InspectorTimelineAgent::didInvalidateLayout):
(WebCore::InspectorTimelineAgent::willLayout):
(WebCore::InspectorTimelineAgent::didScheduleStyleRecalculation):
(WebCore::InspectorTimelineAgent::willRecalculateStyle):
(WebCore::InspectorTimelineAgent::willComposite):
(WebCore::InspectorTimelineAgent::willPaint):
(WebCore::InspectorTimelineAgent::addRecordToTimeline):
(WebCore::InspectorTimelineAgent::setFrameIdentifier):
(WebCore::InspectorTimelineAgent::appendRecord):
(WebCore::InspectorTimelineAgent::sendEvent):
(WebCore::InspectorTimelineAgent::createRecordEntry):
(WebCore::InspectorTimelineAgent::pushCurrentRecord):
- inspector/agents/InspectorTimelineAgent.h:
- page/csp/ContentSecurityPolicy.cpp:
(WebCore::ContentSecurityPolicy::reportViolation const):
- platform/encryptedmedia/clearkey/CDMClearKey.cpp:
(WebCore::parseJSONObject):
(WebCore::parseLicenseFormat):
(WebCore::parseLicenseReleaseAcknowledgementFormat):
(WebCore::CDMInstanceClearKey::updateLicense):
(WebCore::CDMInstanceClearKey::removeSessionData):
- platform/graphics/avfoundation/CDMFairPlayStreaming.cpp:
(WebCore::extractSinfData):
- testing/Internals.cpp:
Source/WebDriver:
- CMakeLists.txt:
- CommandResult.cpp:
(WebDriver::CommandResult::CommandResult):
- CommandResult.h:
(WebDriver::CommandResult::success):
(WebDriver::CommandResult::fail):
(WebDriver::CommandResult::result const):
(WebDriver::CommandResult::setAdditionalErrorData):
(WebDriver::CommandResult::additionalErrorData const):
- Session.cpp:
(WebDriver::firstWindowHandleInResult):
(WebDriver::Session::handleUserPrompts):
(WebDriver::Session::reportUnexpectedAlertOpen):
(WebDriver::Session::go):
(WebDriver::Session::getCurrentURL):
(WebDriver::Session::back):
(WebDriver::Session::forward):
(WebDriver::Session::refresh):
(WebDriver::Session::getTitle):
(WebDriver::Session::getWindowHandle):
(WebDriver::Session::closeTopLevelBrowsingContext):
(WebDriver::Session::switchToWindow):
(WebDriver::Session::getWindowHandles):
(WebDriver::Session::switchToFrame):
(WebDriver::Session::switchToParentFrame):
(WebDriver::Session::getToplevelBrowsingContextRect):
(WebDriver::Session::moveToplevelBrowsingContextWindow):
(WebDriver::Session::resizeToplevelBrowsingContextWindow):
(WebDriver::Session::createElement):
(WebDriver::Session::extractElement):
(WebDriver::Session::extractElementID):
(WebDriver::Session::computeElementLayout):
(WebDriver::Session::findElements):
(WebDriver::Session::isElementSelected):
(WebDriver::Session::getElementText):
(WebDriver::Session::getElementTagName):
(WebDriver::Session::getElementRect):
(WebDriver::Session::isElementEnabled):
(WebDriver::Session::isElementDisplayed):
(WebDriver::Session::getElementAttribute):
(WebDriver::Session::waitForNavigationToComplete):
(WebDriver::Session::selectOptionElement):
(WebDriver::Session::elementClick):
(WebDriver::Session::elementClear):
(WebDriver::Session::elementSendKeys):
(WebDriver::Session::elementSubmit):
(WebDriver::Session::handleScriptResult):
(WebDriver::Session::executeScript):
(WebDriver::Session::performMouseInteraction):
(WebDriver::Session::performKeyboardInteractions):
(WebDriver::parseAutomationCookie):
(WebDriver::builtAutomationCookie):
(WebDriver::serializeCookie):
(WebDriver::Session::getAllCookies):
(WebDriver::Session::getNamedCookie):
(WebDriver::Session::addCookie):
(WebDriver::Session::deleteCookie):
(WebDriver::Session::deleteAllCookies):
(WebDriver::Session::dismissAlert):
(WebDriver::Session::acceptAlert):
(WebDriver::Session::getAlertText):
(WebDriver::Session::sendAlertText):
(WebDriver::Session::takeScreenshot):
- Session.h:
- SessionHost.cpp:
(WebDriver::SessionHost::sendCommandToBackend):
(WebDriver::SessionHost::dispatchMessage):
- SessionHost.h:
- WebDriverService.cpp:
(WebDriver::WebDriverService::handleRequest):
(WebDriver::WebDriverService::sendResponse const):
(WebDriver::deserializeTimeouts):
(WebDriver::WebDriverService::parseCapabilities const):
(WebDriver::WebDriverService::findSessionOrCompleteWithError):
(WebDriver::WebDriverService::validatedCapabilities const):
(WebDriver::WebDriverService::mergeCapabilities const):
(WebDriver::WebDriverService::matchCapabilities const):
(WebDriver::WebDriverService::processCapabilities const):
(WebDriver::WebDriverService::newSession):
(WebDriver::WebDriverService::deleteSession):
(WebDriver::WebDriverService::setTimeouts):
(WebDriver::WebDriverService::go):
(WebDriver::WebDriverService::getCurrentURL):
(WebDriver::WebDriverService::back):
(WebDriver::WebDriverService::forward):
(WebDriver::WebDriverService::refresh):
(WebDriver::WebDriverService::getTitle):
(WebDriver::WebDriverService::getWindowHandle):
(WebDriver::WebDriverService::getWindowRect):
(WebDriver::valueAsNumberInRange):
(WebDriver::WebDriverService::setWindowRect):
(WebDriver::WebDriverService::closeWindow):
(WebDriver::WebDriverService::switchToWindow):
(WebDriver::WebDriverService::getWindowHandles):
(WebDriver::WebDriverService::switchToFrame):
(WebDriver::WebDriverService::switchToParentFrame):
(WebDriver::findElementOrCompleteWithError):
(WebDriver::findStrategyAndSelectorOrCompleteWithError):
(WebDriver::WebDriverService::findElement):
(WebDriver::WebDriverService::findElements):
(WebDriver::WebDriverService::findElementFromElement):
(WebDriver::WebDriverService::findElementsFromElement):
(WebDriver::WebDriverService::isElementSelected):
(WebDriver::WebDriverService::getElementAttribute):
(WebDriver::WebDriverService::getElementText):
(WebDriver::WebDriverService::getElementTagName):
(WebDriver::WebDriverService::getElementRect):
(WebDriver::WebDriverService::isElementEnabled):
(WebDriver::WebDriverService::isElementDisplayed):
(WebDriver::WebDriverService::elementClick):
(WebDriver::WebDriverService::elementClear):
(WebDriver::WebDriverService::elementSendKeys):
(WebDriver::WebDriverService::elementSubmit):
(WebDriver::findScriptAndArgumentsOrCompleteWithError):
(WebDriver::WebDriverService::executeScript):
(WebDriver::WebDriverService::executeAsyncScript):
(WebDriver::WebDriverService::getAllCookies):
(WebDriver::WebDriverService::getNamedCookie):
(WebDriver::deserializeCookie):
(WebDriver::WebDriverService::addCookie):
(WebDriver::WebDriverService::deleteCookie):
(WebDriver::WebDriverService::deleteAllCookies):
(WebDriver::WebDriverService::dismissAlert):
(WebDriver::WebDriverService::acceptAlert):
(WebDriver::WebDriverService::getAlertText):
(WebDriver::WebDriverService::sendAlertText):
(WebDriver::WebDriverService::takeScreenshot):
(WebDriver::WebDriverService::takeElementScreenshot):
- WebDriverService.h:
- gtk/WebDriverServiceGtk.cpp:
(WebDriver::WebDriverService::platformValidateCapability const):
(WebDriver::WebDriverService::platformMatchCapability const):
(WebDriver::WebDriverService::platformParseCapabilities const):
Source/WebKit:
Based on patch by Brian Burg.
- UIProcess/Automation/WebAutomationSession.cpp:
(WebKit::WebAutomationSession::resizeWindowOfBrowsingContext):
(WebKit::WebAutomationSession::moveWindowOfBrowsingContext):
(WebKit::WebAutomationSession::waitForNavigationToCompleteOnPage):
(WebKit::WebAutomationSession::waitForNavigationToCompleteOnFrame):
(WebKit::WebAutomationSession::respondToPendingPageNavigationCallbacksWithTimeout):
(WebKit::WebAutomationSession::respondToPendingFrameNavigationCallbacksWithTimeout):
(WebKit::WebAutomationSession::navigationOccurredForFrame):
(WebKit::WebAutomationSession::documentLoadedForFrame):
(WebKit::WebAutomationSession::inspectorFrontendLoaded):
(WebKit::WebAutomationSession::keyboardEventsFlushedForPage):
(WebKit::WebAutomationSession::evaluateJavaScriptFunction):
(WebKit::WebAutomationSession::setFilesToSelectForFileUpload):
(WebKit::WebAutomationSession::addSingleCookie):
(WebKit::WebAutomationSession::setSessionPermissions):
(WebKit::WebAutomationSession::performMouseInteraction):
(WebKit::WebAutomationSession::performKeyboardInteractions):
- UIProcess/Automation/WebAutomationSession.h:
Source/WTF:
- WTF.xcodeproj/project.pbxproj:
- wtf/CMakeLists.txt:
- wtf/JSONValues.cpp: Renamed from Source/JavaScriptCore/inspector/InspectorValues.cpp.
(JSON::Value::null):
(JSON::Value::create):
(JSON::Value::asValue):
(JSON::Value::asObject):
(JSON::Value::asArray):
(JSON::Value::parseJSON):
(JSON::Value::toJSONString const):
(JSON::Value::asBoolean const):
(JSON::Value::asDouble const):
(JSON::Value::asInteger const):
(JSON::Value::asString const):
(JSON::Value::writeJSON const):
(JSON::Value::memoryCost const):
(JSON::ObjectBase::~ObjectBase):
(JSON::ObjectBase::asObject):
(JSON::ObjectBase::openAccessors):
(JSON::ObjectBase::memoryCost const):
(JSON::ObjectBase::getBoolean const):
(JSON::ObjectBase::getString const):
(JSON::ObjectBase::getObject const):
(JSON::ObjectBase::getArray const):
(JSON::ObjectBase::getValue const):
(JSON::ObjectBase::remove):
(JSON::ObjectBase::writeJSON const):
(JSON::ObjectBase::ObjectBase):
(JSON::ArrayBase::~ArrayBase):
(JSON::ArrayBase::asArray):
(JSON::ArrayBase::writeJSON const):
(JSON::ArrayBase::ArrayBase):
(JSON::ArrayBase::get const):
(JSON::Object::create):
(JSON::Array::create):
(JSON::ArrayBase::memoryCost const):
- wtf/JSONValues.h: Renamed from Source/JavaScriptCore/inspector/InspectorValues.h.
(JSON::ObjectBase::find):
(JSON::ObjectBase::find const):
(JSON::ObjectBase::setBoolean):
(JSON::ObjectBase::setInteger):
(JSON::ObjectBase::setDouble):
(JSON::ObjectBase::setString):
(JSON::ObjectBase::setValue):
(JSON::ObjectBase::setObject):
(JSON::ObjectBase::setArray):
(JSON::ArrayBase::pushBoolean):
(JSON::ArrayBase::pushInteger):
(JSON::ArrayBase::pushDouble):
(JSON::ArrayBase::pushString):
(JSON::ArrayBase::pushValue):
(JSON::ArrayBase::pushObject):
(JSON::ArrayBase::pushArray):
Tools:
- TestWebKitAPI/CMakeLists.txt:
- TestWebKitAPI/PlatformGTK.cmake:
- TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
- TestWebKitAPI/Tests/WTF/JSONValue.cpp: Renamed from Tools/TestWebKitAPI/Tests/JavaScriptCore/InspectorValue.cpp.
(TestWebKitAPI::TEST):
- 4:40 PM Changeset in webkit [224862] by
-
- 2 edits in trunk/Source/JavaScriptCore
Fix a bit-rotted Interpreter::dumpRegisters() and make it more robust.
https://bugs.webkit.org/show_bug.cgi?id=179699
<rdar://problem/35462346>
Reviewed by Michael Saboff.
- interpreter/Interpreter.cpp:
(JSC::Interpreter::dumpRegisters):
- Need to skip the callee saved registers
- 4:30 PM Changeset in webkit [224861] by
-
- 1 edit1 delete in trunk/Source/WebInspectorUI
Relicense non-distributable web inspector images
https://bugs.webkit.org/show_bug.cgi?id=166460
<rdar://problem/29800966>
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2017-11-14
Reviewed by Brian Burg.
- APPLE_IMAGES_LICENSE.rtf: Removed.
Remove the restrictive Web Inspector images license and default to the
same license as the rest of WebKit.
The Apple Images license was never intended to restrict distribution of
Web Inspector images when used as part of WebKit. Now, all contributions
to Web Inspector, images and source, have the same licensing as all other
WebKit contributions.
- 4:12 PM Changeset in webkit [224860] by
-
- 3 edits in trunk/Source/WebCore
Unreviewed, fix CMake debug builds after r224707
https://bugs.webkit.org/show_bug.cgi?id=179499
<rdar://problem/35445033>
- PlatformWin.cmake:
- Sources.txt:
- 4:12 PM Changeset in webkit [224859] by
-
- 2 edits in trunk/Source/WebCore
Another attempt to fix GTK/WPE debug builds
https://bugs.webkit.org/show_bug.cgi?id=179660
- platform/graphics/cairo/NativeImageCairo.cpp:
(WebCore::drawNativeImage):
- 4:09 PM Changeset in webkit [224858] by
-
- 2 edits in trunk/Source/WebCore
Fix Windows build.
- html/canvas/WebGLRenderingContext.h:
- 4:04 PM Changeset in webkit [224857] by
-
- 21 edits in trunk
[Service Workers] Implement container.getRegistrations()
https://bugs.webkit.org/show_bug.cgi?id=179672
Reviewed by Brady Eidson.
LayoutTests/imported/w3c:
Rebaseline test now that more checks are passing.
- web-platform-tests/service-workers/service-worker/getregistrations.https-expected.txt:
Source/WebCore:
Implement container.getRegistrations():
No new tests, rebaselined existing test.
- workers/service/ServiceWorkerContainer.cpp:
(WebCore::ServiceWorkerContainer::getRegistration):
(WebCore::ServiceWorkerContainer::getRegistrations):
(WebCore::ServiceWorkerContainer::jobResolvedWithRegistration):
- workers/service/ServiceWorkerContainer.h:
- workers/service/ServiceWorkerRegistration.cpp:
(WebCore::ServiceWorkerRegistration::getOrCreate):
- workers/service/ServiceWorkerRegistration.h:
- workers/service/ServiceWorkerRegistrationKey.cpp:
(WebCore::ServiceWorkerRegistrationKey::isMatching const):
(WebCore::ServiceWorkerRegistrationKey::originIsMatching const):
- workers/service/ServiceWorkerRegistrationKey.h:
- workers/service/server/SWClientConnection.h:
- workers/service/server/SWServer.cpp:
(WebCore::SWServer::getRegistrations):
- workers/service/server/SWServer.h:
Source/WebKit:
- StorageProcess/ServiceWorker/WebSWServerConnection.cpp:
(WebKit::WebSWServerConnection::getRegistrations):
- StorageProcess/ServiceWorker/WebSWServerConnection.h:
- StorageProcess/ServiceWorker/WebSWServerConnection.messages.in:
- WebProcess/Storage/WebSWClientConnection.cpp:
(WebKit::WebSWClientConnection::didGetRegistrations):
(WebKit::WebSWClientConnection::getRegistrations):
- WebProcess/Storage/WebSWClientConnection.h:
- WebProcess/Storage/WebSWClientConnection.messages.in:
- 3:49 PM Changeset in webkit [224856] by
-
- 2 edits in trunk/Source/WebCore
Fix Windows build.
- html/canvas/WebGLRenderingContext.h:
- 3:42 PM Changeset in webkit [224855] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed, fix GTK/WPE debug builds even better after r224813
https://bugs.webkit.org/show_bug.cgi?id=179660
- platform/graphics/cairo/NativeImageCairo.cpp:
(WebCore::drawNativeImage):
- 3:40 PM Changeset in webkit [224854] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed, fix GTK/WPE debug builds after r224813
https://bugs.webkit.org/show_bug.cgi?id=179660
- platform/graphics/cairo/NativeImageCairo.cpp:
(WebCore::drawNativeImage):
- 3:32 PM Changeset in webkit [224853] by
-
- 2 edits in trunk/LayoutTests
Mark fast/scrolling/rtl-scrollbars.html as flaky.
https://bugs.webkit.org/show_bug.cgi?id=179455
Unreviewed test gardening.
- platform/mac-wk2/TestExpectations:
- 3:25 PM Changeset in webkit [224852] by
-
- 74 edits in trunk
Implement ServiceWorker handle fetch for navigation loads
https://bugs.webkit.org/show_bug.cgi?id=179404
Patch by Youenn Fablet <youenn@apple.com> on 2017-11-14
Reviewed by Alex Christensen and Chris Dumez.
LayoutTests/imported/w3c:
- web-platform-tests/service-workers/cache-storage/serviceworker/credentials.https-expected.txt:
- web-platform-tests/service-workers/service-worker/ServiceWorkerGlobalScope/extendable-message-event.https-expected.txt:
- web-platform-tests/service-workers/service-worker/claim-not-using-registration.https-expected.txt:
- web-platform-tests/service-workers/service-worker/client-id.https-expected.txt:
- web-platform-tests/service-workers/service-worker/client-navigate.https-expected.txt:
- web-platform-tests/service-workers/service-worker/clients-get-cross-origin.https-expected.txt:
- web-platform-tests/service-workers/service-worker/clients-get.https-expected.txt:
- web-platform-tests/service-workers/service-worker/clients-matchall-client-types.https-expected.txt:
- web-platform-tests/service-workers/service-worker/clients-matchall-include-uncontrolled.https-expected.txt:
- web-platform-tests/service-workers/service-worker/clients-matchall.https-expected.txt:
- web-platform-tests/service-workers/service-worker/controller-on-disconnect.https-expected.txt:
- web-platform-tests/service-workers/service-worker/controller-on-load.https-expected.txt:
- web-platform-tests/service-workers/service-worker/fetch-canvas-tainting-cache.https-expected.txt:
- web-platform-tests/service-workers/service-worker/fetch-canvas-tainting.https-expected.txt:
- web-platform-tests/service-workers/service-worker/fetch-cors-xhr.https-expected.txt:
- web-platform-tests/service-workers/service-worker/fetch-csp.https-expected.txt:
- web-platform-tests/service-workers/service-worker/fetch-event-after-navigation-within-page.https-expected.txt:
- web-platform-tests/service-workers/service-worker/fetch-event-async-respond-with.https-expected.txt:
- web-platform-tests/service-workers/service-worker/fetch-event-network-error.https-expected.txt:
- web-platform-tests/service-workers/service-worker/fetch-event-redirect.https-expected.txt:
- web-platform-tests/service-workers/service-worker/fetch-event-referrer-policy.https-expected.txt:
- web-platform-tests/service-workers/service-worker/fetch-event-respond-with-argument.https-expected.txt:
- web-platform-tests/service-workers/service-worker/fetch-event-respond-with-readable-stream.https-expected.txt:
- web-platform-tests/service-workers/service-worker/fetch-event-respond-with-response-body-with-invalid-chunk.https-expected.txt:
- web-platform-tests/service-workers/service-worker/fetch-event-respond-with-stops-propagation.https-expected.txt:
- web-platform-tests/service-workers/service-worker/fetch-event-within-sw.https-expected.txt:
- web-platform-tests/service-workers/service-worker/fetch-event.https-expected.txt:
- web-platform-tests/service-workers/service-worker/fetch-frame-resource.https-expected.txt:
- web-platform-tests/service-workers/service-worker/fetch-header-visibility.https-expected.txt:
- web-platform-tests/service-workers/service-worker/fetch-mixed-content-to-inscope.https-expected.txt:
- web-platform-tests/service-workers/service-worker/fetch-mixed-content-to-outscope.https-expected.txt:
- web-platform-tests/service-workers/service-worker/fetch-request-css-cross-origin-mime-check.https-expected.txt:
- web-platform-tests/service-workers/service-worker/fetch-request-redirect.https-expected.txt:
- web-platform-tests/service-workers/service-worker/fetch-request-xhr.https-expected.txt:
- web-platform-tests/service-workers/service-worker/fetch-response-taint.https-expected.txt:
- web-platform-tests/service-workers/service-worker/fetch-response-xhr.https-expected.txt:
- web-platform-tests/service-workers/service-worker/foreign-fetch-workers.https-expected.txt:
- web-platform-tests/service-workers/service-worker/interfaces-sw.https-expected.txt:
- web-platform-tests/service-workers/service-worker/invalid-header.https-expected.txt:
- web-platform-tests/service-workers/service-worker/mime-sniffing.https-expected.txt:
- web-platform-tests/service-workers/service-worker/navigation-preload/chunked-encoding.https-expected.txt:
- web-platform-tests/service-workers/service-worker/navigation-preload/request-headers.https-expected.txt:
- web-platform-tests/service-workers/service-worker/navigation-redirect-to-http.https-expected.txt:
- web-platform-tests/service-workers/service-worker/navigation-redirect.https-expected.txt:
- web-platform-tests/service-workers/service-worker/opaque-response-preloaded.https-expected.txt:
- web-platform-tests/service-workers/service-worker/performance-timeline.https-expected.txt:
- web-platform-tests/service-workers/service-worker/postmessage-msgport-to-client.https-expected.txt:
- web-platform-tests/service-workers/service-worker/postmessage-to-client.https-expected.txt:
- web-platform-tests/service-workers/service-worker/referer.https-expected.txt:
- web-platform-tests/service-workers/service-worker/referrer-policy-header.https-expected.txt:
- web-platform-tests/service-workers/service-worker/register-same-scope-different-script-url.https-expected.txt:
- web-platform-tests/service-workers/service-worker/registration-updateviacache.https-expected.txt:
- web-platform-tests/service-workers/service-worker/request-end-to-end.https-expected.txt:
- web-platform-tests/service-workers/service-worker/resource-timing.https-expected.txt:
- web-platform-tests/service-workers/service-worker/serviceworker-message-event-historical.https-expected.txt:
- web-platform-tests/service-workers/service-worker/skip-waiting-installed.https-expected.txt:
- web-platform-tests/service-workers/service-worker/skip-waiting-using-registration.https-expected.txt:
- web-platform-tests/service-workers/service-worker/skip-waiting-without-using-registration.https-expected.txt:
- web-platform-tests/service-workers/service-worker/unregister-controller.https-expected.txt:
- web-platform-tests/service-workers/service-worker/unregister-then-register.https-expected.txt:
- web-platform-tests/service-workers/service-worker/update-bytecheck.https-expected.txt:
- web-platform-tests/service-workers/service-worker/update-recovery.https-expected.txt:
- web-platform-tests/service-workers/service-worker/worker-interception.https-expected.txt:
Source/WebCore:
Covered by rebased tests.
Step 11 of https://w3c.github.io/ServiceWorker/#on-fetch-request-algorithm is implemented in DocumentLoader as it centralizes main request loading
and knows about the context of it.
For each main resource load in document loader, we first check whether there is a matching service worker.
The fetch request is updated accordingly so that there is no difference in the handling of navigation vs. subresource requests after that point.
Updated DocumentThreadableLoader::didReceiveResponse since it can now receive responses from service worker with various response types.
A follow-up patch should properly handle cross origin responses.
- loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::commitData):
(WebCore::DocumentLoader::startLoadingMainResource):
(WebCore::DocumentLoader::doLoadingMainResource):
- loader/DocumentLoader.h:
- loader/DocumentThreadableLoader.cpp:
(WebCore::DocumentThreadableLoader::didReceiveResponse):
- loader/cache/CachedResourceRequest.cpp:
(WebCore::CachedResourceRequest::setNavigationServiceWorkerRegistrationData):
- loader/cache/CachedResourceRequest.h:
- platform/MIMETypeRegistry.h:
- platform/network/cocoa/WebCoreNSURLSession.mm:
(-[WebCoreNSURLSessionDataTask resource:receivedResponse:]):
Source/WebKit:
Update handle fetch algorithm to support navigation requests.
In case of navigation requests, set service worker response mime type to text/html if none is provided.
- WebProcess/Storage/ServiceWorkerClientFetch.cpp:
(WebKit::ServiceWorkerClientFetch::didReceiveResponse):
- WebProcess/Storage/WebSWClientConnection.cpp:
(WebKit::WebSWClientConnection::startFetch):
- WebProcess/Storage/WebServiceWorkerProvider.cpp:
(WebKit::shouldHandleFetch):
(WebKit::WebServiceWorkerProvider::handleFetch):
LayoutTests:
Some new tests are timing out due to missing SW API support.
fetch-request-xhr.https.html is flaky due to always changing assertions.
uncontrolled-page.https.html is probably flaky due to setting the active service worker
in ServiceWorkerRegistration constructor. Plan is to fix that hack as a follow-up.
fetch-event-respond-with-response-body-with-invalid-chunk.https.html might be flaky for the same reason.
Marking unregister-then-register.https.html as flaky. Will follow-up investigating.
- TestExpectations: Skipping some timing out tests and marking some as flaky.
- 3:22 PM Changeset in webkit [224851] by
-
- 4 edits1 move3 adds1 delete in trunk/Source/WebInspectorUI
Web Inspector: Network Detail Views - Split Metrics into Sizes and Timing
https://bugs.webkit.org/show_bug.cgi?id=179569
<rdar://problem/35484914>
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2017-11-14
Reviewed by Brian Burg.
- Localizations/en.lproj/localizedStrings.js:
- UserInterface/Main.html:
New resources and strings.
- UserInterface/Views/NetworkResourceDetailView.js:
(WI.NetworkResourceDetailView):
(WI.NetworkResourceDetailView.prototype.initialLayout):
(WI.NetworkResourceDetailView.prototype._showPreferredContentView):
(WI.NetworkResourceDetailView.prototype._showContentViewForNavigationItem):
(WI.NetworkResourceDetailView.prototype.sizesContentViewGoToHeaders): Renamed.
(WI.NetworkResourceDetailView.prototype.sizesContentViewGoToRequestBody): Renamed.
(WI.NetworkResourceDetailView.prototype.sizesContentViewGoToResponseBody): Renamed.
Split into two navigation items and views.
- UserInterface/Views/ResourceMetricsContentView.css: Removed.
- UserInterface/Views/ResourceMetricsContentView.js: Removed.
- UserInterface/Views/ResourceSizesContentView.css: Added.
- UserInterface/Views/ResourceSizesContentView.js: Added.
- UserInterface/Views/ResourceTimingContentView.css: Added.
- UserInterface/Views/ResourceTimingContentView.js: Added.
Split Metrics into two views.
- 2:59 PM Changeset in webkit [224850] by
-
- 2 edits in trunk/Source/WebCore
Log moveFile failure errors
https://bugs.webkit.org/show_bug.cgi?id=179695
Reviewed by Brady Eidson.
Content extension tests are flaky. In r224790 I added logs to find out why, and they indicate that moveFile is failing.
To further understand why, I'm adding logs to see what's happening sometimes on the bots.
- platform/cocoa/FileSystemCocoa.mm:
(WebCore::FileSystem::moveFile):
- 2:31 PM Changeset in webkit [224849] by
-
- 4 edits in trunk/Source/WebCore
Fix Windows build.
- html/OffscreenCanvas.cpp:
- html/OffscreenCanvas.h:
- html/OffscreenCanvas.idl:
- 2:26 PM Changeset in webkit [224848] by
-
- 1 edit1 copy11 adds1 delete in trunk/LayoutTests
Unreviewed test gardening for High Sierra.
- platform/mac-sierra/http/tests/blink/sendbeacon/beacon-same-origin-expected.txt: Added.
- platform/mac-sierra/imported/w3c/web-platform-tests/beacon/headers/header-content-type-expected.txt: Renamed from LayoutTests/platform/mac-wk2/imported/w3c/web-platform-tests/beacon/headers/header-content-type-expected.txt.
- platform/mac/http/tests/blink/sendbeacon/beacon-same-origin-expected.txt: Added.
- platform/mac/imported/w3c/web-platform-tests/beacon/headers/header-content-type-expected.txt: Added.
- 2:23 PM Changeset in webkit [224847] by
-
- 1 copy in tags/Safari-604.4.7.1.4
Tag Safari-604.4.7.1.4.
- 2:20 PM Changeset in webkit [224846] by
-
- 59 edits3 deletes in trunk/Source
Remove Cocoa CFURLConnection loading code
https://bugs.webkit.org/show_bug.cgi?id=179688
Reviewed by Antti Koivisto.
Source/WebCore:
CFURLConnection is only used on the AppleWin port now.
- PlatformMac.cmake:
- SourcesCocoa.txt:
- SourcesIOS.txt:
- WebCore.xcodeproj/project.pbxproj:
- loader/DocumentLoader.h:
- loader/EmptyFrameLoaderClient.h:
- loader/FrameLoaderClient.h:
- loader/ResourceLoader.cpp:
- loader/ResourceLoader.h:
- loader/SubresourceLoader.h:
- loader/cf/ResourceLoaderCFNet.cpp:
- loader/cocoa/SubresourceLoaderCocoa.mm:
- loader/mac/DocumentLoaderMac.cpp:
- loader/mac/ResourceLoaderMac.mm:
- page/mac/PageMac.mm:
(WebCore::Page::platformInitialize):
(WebCore::Page::addSchedulePair):
(WebCore::Page::removeSchedulePair):
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::shouldWaitForResponseToAuthenticationChallenge):
(WebCore::WebCoreNSURLAuthenticationChallengeClient::create): Deleted.
(WebCore::WebCoreNSURLAuthenticationChallengeClient::WebCoreNSURLAuthenticationChallengeClient): Deleted.
(): Deleted.
- platform/network/ProtectionSpaceBase.cpp:
- platform/network/ResourceHandle.h:
- platform/network/ResourceHandleInternal.h:
- platform/network/cf/AuthenticationCF.cpp:
(WebCore::AuthenticationChallenge::AuthenticationChallenge):
(WebCore::createCF):
(WebCore::core):
(): Deleted.
- platform/network/cf/AuthenticationCF.h:
- platform/network/cf/CookieJarCFNet.cpp:
(WebCore::copyCookiesForURLWithFirstPartyURL):
(WebCore::createCookies):
(WebCore::deleteAllCookiesModifiedSince):
- platform/network/cf/CookieStorageCFNet.cpp:
- platform/network/cf/CredentialStorageCFNet.cpp:
(WebCore::CredentialStorage::getFromPersistentStorage):
- platform/network/cf/ResourceErrorCF.cpp:
(WebCore::ResourceError::setCertificate):
(WebCore::ResourceError::platformLazyInit):
(WebCore::ResourceError::doPlatformIsolatedCopy):
(WebCore::ResourceError::cfError const):
- platform/network/cf/ResourceHandleCFNet.cpp:
- platform/network/cf/ResourceHandleCFURLConnectionDelegate.cpp:
- platform/network/cf/ResourceHandleCFURLConnectionDelegateWithOperationQueue.cpp:
(WebCore::ResourceHandleCFURLConnectionDelegateWithOperationQueue::setupRequest):
(WebCore::installHookToRemoveCFNetworkMessageBlockingMainThread):
(WebCore::ResourceHandleCFURLConnectionDelegateWithOperationQueue::setupConnectionScheduling):
(WebCore::ResourceHandleCFURLConnectionDelegateWithOperationQueue::didReceiveResponse):
(WebCore::ResourceHandleCFURLConnectionDelegateWithOperationQueue::willCacheResponse):
(WebCore::ResourceHandleCFURLConnectionDelegateWithOperationQueue::canRespondToProtectionSpace):
- platform/network/cocoa/CredentialCocoa.mm:
(WebCore::Credential::cfCredential const): Deleted.
- platform/network/cocoa/ProtectionSpaceCocoa.mm:
(WebCore::ProtectionSpace::cfSpace const): Deleted.
- platform/network/cocoa/ResourceRequestCocoa.mm:
(WebCore::ResourceRequest::nsURLRequest const):
(WebCore::ResourceRequest::clearOrUpdateNSURLRequest): Deleted.
- platform/network/cocoa/ResourceResponseCocoa.mm:
(WebCore::ResourceResponse::platformCertificateInfo const):
(WebCore::ResourceResponse::ResourceResponse): Deleted.
- platform/network/ios/ResourceHandleIOS.mm: Removed.
- platform/network/mac/AuthenticationMac.mm:
(WebCore::AuthenticationChallenge::authenticationClient const):
(WebCore::mac):
(-[WebCoreAuthenticationClientAsChallengeSender setCFChallenge:]): Deleted.
(-[WebCoreAuthenticationClientAsChallengeSender cfChallenge]): Deleted.
- platform/network/mac/ResourceHandleMac.mm:
(WebCore::synchronousWillSendRequestEnabled):
- platform/network/mac/ResourceRequestMac.mm: Removed.
Source/WebKit:
- NetworkProcess/Downloads/Download.h:
Source/WebKitLegacy:
- WebCoreSupport/WebResourceLoadScheduler.cpp:
(WebResourceLoadScheduler::scheduleLoad):
Source/WebKitLegacy/mac:
- Misc/WebDownload.mm:
(-[WebDownload _initWithLoadingCFURLConnection:request:response:delegate:proxy:]): Deleted.
- Misc/WebDownloadInternal.h:
- Plugins/WebBaseNetscapePluginView.mm:
- WebCoreSupport/WebFrameLoaderClient.mm:
(WebFrameLoaderClient::convertMainResourceLoadToDownload):
- WebView/WebView.mm:
(-[WebView scheduleInRunLoop:forMode:]):
(-[WebView unscheduleFromRunLoop:forMode:]):
Source/WTF:
- wtf/SchedulePair.h:
- wtf/SchedulePairMac.mm:
- 2:19 PM Changeset in webkit [224845] by
-
- 3 edits in trunk/Tools
webkitpy: Use more verbose version info from simctl
https://bugs.webkit.org/show_bug.cgi?id=179687
<rdar://problem/35539392>
Reviewed by Tim Horton.
- Scripts/webkitpy/xcode/simulator.py:
(Simulator): Address FIXME, use more verbose version.
(Simulator._parse_runtimes): 'Internal' no longer stands along, check os for this
string instead.
- Scripts/webkitpy/xcode/simulator_unittest.py: Mock simctl output specifies iOS
8.4.1, not iOS 8.4.
- 1:55 PM Changeset in webkit [224844] by
-
- 7 edits in tags/Safari-605.1.13.3/Source
Versioning.
- 1:53 PM Changeset in webkit [224843] by
-
- 3 edits in trunk/Source/JavaScriptCore
REGRESSION(r224623) [MIPS] branchTruncateDoubleToInt32() doesn't set return register when branching
https://bugs.webkit.org/show_bug.cgi?id=179563
Reviewed by Carlos Alberto Lopez Perez.
When run with BranchIfTruncateSuccessful,
branchTruncateDoubleToInt32() should set the destination register
before branching.
This change also removes branchTruncateDoubleToUInt32() as it is
deprecated (see r160205), merges branchOnTruncateResult() into
branchTruncateDoubleToInt32() and adds test cases in testmasm.
- assembler/MacroAssemblerMIPS.h:
(JSC::MacroAssemblerMIPS::branchOnTruncateResult): Deleted.
(JSC::MacroAssemblerMIPS::branchTruncateDoubleToInt32):
Properly set dest before branching.
(JSC::MacroAssemblerMIPS::branchTruncateDoubleToUInt32): Deleted.
- assembler/testmasm.cpp:
(JSC::testBranchTruncateDoubleToInt32):
(JSC::run):
Add tests for branchTruncateDoubleToInt32().
- 1:49 PM Changeset in webkit [224842] by
-
- 1 copy in tags/Safari-605.1.13.3
Tag Safari-605.1.13.3.
- 1:30 PM Changeset in webkit [224841] by
-
- 12 edits in trunk
Update comment in FeatureDefines.xcconfig to reflect location of Visual Studio property files
for feature defines
Following r195498 and r201917 the Visual Studio property files for feature defines have
moved from directory WebKitLibraries/win/tools/vsprops to directory Source/cmake/tools/vsprops.
Update the comment in FeatureDefines.xcconfig to reflect the new location and names of these
files.
Source/JavaScriptCore:
- Configurations/FeatureDefines.xcconfig:
Source/WebCore:
- Configurations/FeatureDefines.xcconfig:
Source/WebCore/PAL:
- Configurations/FeatureDefines.xcconfig:
Source/WebKit:
- Configurations/FeatureDefines.xcconfig:
Source/WebKitLegacy/mac:
- Configurations/FeatureDefines.xcconfig:
Tools:
- TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
- 1:26 PM Changeset in webkit [224840] by
-
- 3 edits in trunk/Source/WebCore
Remove StyleResolver::State::document()
https://bugs.webkit.org/show_bug.cgi?id=179678
Reviewed by Antoine Quint.
We don't need both StyleResolver::document() and StyleResolver::State::document().
- css/StyleResolver.cpp:
(WebCore::StyleResolver::State::updateConversionData):
(WebCore::StyleResolver::resolvedVariableValue):
(WebCore::StyleResolver::colorFromPrimitiveValue const):
(WebCore::StyleResolver::createFilterOperations):
- css/StyleResolver.h:
(WebCore::StyleResolver::State::document const): Deleted.
- 1:22 PM Changeset in webkit [224839] by
-
- 7 edits in branches/safari-604.3.5.1-branch/Source
Versioning.
- 1:16 PM Changeset in webkit [224838] by
-
- 8 edits2 deletes in trunk/Source/JavaScriptCore
Remove JSDollarVMPrototype.
https://bugs.webkit.org/show_bug.cgi?id=179685
Reviewed by Saam Barati.
- Move the JSDollarVMPrototype C++ utility functions into VMInspector.cpp.
This allows us to call these functions during lldb debugging sessions using
VMInspector::foo() instead of JSDollarVMPrototype::foo(). It makes sense that
VMInspector provides VM debugging utility methods. It doesn't make sense to
have a JSDollarVMPrototype object provide these methods.
Plus, it's shorter to type VMInspector than JSDollarVMPrototype.
- Move the JSDollarVMPrototype JS functions into JSDollarVM.cpp.
JSDollarVM is a special object used only for debugging purposes. There's no
gain in requiring its methods to be stored in a prototype object other than to
conform to typical JS convention. We can remove this complexity.
- JavaScriptCore.xcodeproj/project.pbxproj:
- Sources.txt:
- runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::init):
- tools/JSDollarVM.cpp:
(JSC::JSDollarVM::addFunction):
(JSC::functionCrash):
(JSC::functionDFGTrue):
(JSC::CallerFrameJITTypeFunctor::CallerFrameJITTypeFunctor):
(JSC::CallerFrameJITTypeFunctor::operator() const):
(JSC::CallerFrameJITTypeFunctor::jitType):
(JSC::functionLLintTrue):
(JSC::functionJITTrue):
(JSC::functionGC):
(JSC::functionEdenGC):
(JSC::functionCodeBlockForFrame):
(JSC::codeBlockFromArg):
(JSC::functionCodeBlockFor):
(JSC::functionPrintSourceFor):
(JSC::functionPrintBytecodeFor):
(JSC::functionPrint):
(JSC::functionPrintCallFrame):
(JSC::functionPrintStack):
(JSC::functionValue):
(JSC::functionGetPID):
(JSC::JSDollarVM::finishCreation):
- tools/JSDollarVM.h:
(JSC::JSDollarVM::create):
- tools/JSDollarVMPrototype.cpp: Removed.
- tools/JSDollarVMPrototype.h: Removed.
- tools/VMInspector.cpp:
(JSC::VMInspector::currentThreadOwnsJSLock):
(JSC::ensureCurrentThreadOwnsJSLock):
(JSC::VMInspector::gc):
(JSC::VMInspector::edenGC):
(JSC::VMInspector::isInHeap):
(JSC::CellAddressCheckFunctor::CellAddressCheckFunctor):
(JSC::CellAddressCheckFunctor::operator() const):
(JSC::VMInspector::isValidCell):
(JSC::VMInspector::isValidCodeBlock):
(JSC::VMInspector::codeBlockForFrame):
(JSC::PrintFrameFunctor::PrintFrameFunctor):
(JSC::PrintFrameFunctor::operator() const):
(JSC::VMInspector::printCallFrame):
(JSC::VMInspector::printStack):
(JSC::VMInspector::printValue):
- tools/VMInspector.h:
- 1:14 PM Changeset in webkit [224837] by
-
- 2 edits in trunk/Source/WebKit
Whitelist some IOKIt properties to avoid sandbox violations on YouTube
https://bugs.webkit.org/show_bug.cgi?id=179683
<rdar://problem/35415368>
Reviewed by Dean Jackson.
YouTube video playback on some hardware (and some video encodings) generates sandbox violations. Add
whitelist entries for the relevant IOKit properties needed to support these activities.
- WebProcess/com.apple.WebProcess.sb.in:
- 1:11 PM Changeset in webkit [224836] by
-
- 6 edits4 adds in trunk
Stub implementations of OffscreenCanvas getContext and transferToImageBitmap
https://bugs.webkit.org/show_bug.cgi?id=179671
<rdar://problem/35534018>
Reviewed by Antoine Quint.
Source/WebCore:
Empty implementations of getContext and transferToImageBitmap. At the moment
only return a WebGLRenderingContext from getContext, since we don't
have an Offscreen 2d context type yet.
Tests: http/wpt/offscreen-canvas/getContext-webgl.html
http/wpt/offscreen-canvas/transferToImageBitmap.html
- html/OffscreenCanvas.cpp:
(WebCore::OffscreenCanvas::getContext):
(WebCore::OffscreenCanvas::transferToImageBitmap):
- html/OffscreenCanvas.h:
- html/OffscreenCanvas.idl:
- html/canvas/GPUBasedCanvasRenderingContext.h: Drive-by parameter rename.
(WebCore::GPUBasedCanvasRenderingContext::GPUBasedCanvasRenderingContext):
LayoutTests:
- http/wpt/offscreen-canvas/getContext-webgl-expected.txt: Added.
- http/wpt/offscreen-canvas/getContext-webgl.html: Added.
- http/wpt/offscreen-canvas/transferToImageBitmap-expected.txt: Added.
- http/wpt/offscreen-canvas/transferToImageBitmap.html: Added.
- 12:48 PM Changeset in webkit [224835] by
-
- 2 edits in trunk/Source/WebKit
Mark WebChromeClient::requestStorageAccess() as final
https://bugs.webkit.org/show_bug.cgi?id=179673
Reviewed by Sam Weinig.
Mark WebChromeClient::requestStorageAccess() as final so that it overrides the virtual function
in ChromeClient with the same name and hence we actually call it through a ChromeClient pointer.
- WebProcess/WebCoreSupport/WebChromeClient.h:
- 12:38 PM Changeset in webkit [224834] by
-
- 3 edits in trunk/LayoutTests
Unreviewed test gardening for High Sierra.
- platform/mac/TestExpectations:
- platform/mac/editing/deleting/delete-emoji-9-expected.txt:
- 12:29 PM Changeset in webkit [224833] by
-
- 10 edits in trunk
Enable Modern EME tests in DumpRenderTree
https://bugs.webkit.org/show_bug.cgi?id=179544
Reviewed by Alex Christensen.
Source/WebKitLegacy/mac:
Add a WebPreferences property to enable the (modern) EME API.
- WebView/WebPreferenceKeysPrivate.h:
- WebView/WebPreferences.mm:
(+[WebPreferences initialize]):
(-[WebPreferences encryptedMediaAPIEnabled]):
(-[WebPreferences setEncryptedMediaAPIEnabled:]):
- WebView/WebPreferencesPrivate.h:
- WebView/WebView.mm:
(-[WebView _preferencesChanged:]):
Tools:
- DumpRenderTree/mac/DumpRenderTree.mm:
(enableExperimentalFeatures):
LayoutTests:
- platform/mac-wk1/TestExpectations:
- platform/mac-wk1/fast/dom/navigator-detached-no-crash-expected.txt:
- 12:28 PM Changeset in webkit [224832] by
-
- 17 edits in trunk
WebSWClientConnection should do IPC to StorageProcess if its WebSWOriginTable is not yet initialized
https://bugs.webkit.org/show_bug.cgi?id=179668
Patch by Youenn Fablet <youenn@apple.com> on 2017-11-14
Reviewed by Chris Dumez.
Source/WebCore:
Covered by existing updated tests.
Removing hasServiceWorkerRegisteredForOrigin and using hasServiceWorkerRegistration instead.
The former is only checking the shared map which might not be initialized at the time the function is called.
The latter is going to the StorageProcess if the map is not yet initialized.
- testing/Internals.cpp:
(WebCore::Internals::hasServiceWorkerRegisteredForOrigin): Deleted.
- testing/Internals.h:
- testing/Internals.idl:
- workers/service/server/SWClientConnection.h:
Source/WebKit:
There may be cases where the origin table is not initialized and we would think there is no service worker registration.
In such a case, we should go to the StorageProcess.
StorageProcess is now sending an IPC message back to each registered SW connection so that WebProcess will know whether its map
is correctly initialized or not.
Renaming hasServiceWorkerRegisteredForOrigin in mayHaveServiceWorkerRegisteredForOrigin.
- WebProcess/Storage/WebSWClientConnection.cpp:
(WebKit::WebSWClientConnection::mayHaveServiceWorkerRegisteredForOrigin const):
(WebKit::WebSWClientConnection::matchRegistration):
(WebKit::WebSWClientConnection::hasServiceWorkerRegisteredForOrigin const): Deleted.
- WebProcess/Storage/WebSWClientConnection.h:
- WebProcess/Storage/WebSWOriginTable.h:
(WebKit::WebSWOriginTable::isInitialized const):
- WebProcess/Storage/WebServiceWorkerProvider.cpp:
(WebKit::shouldHandleFetch):
LayoutTests:
Updated tests to use hasServiceWorkerRegistration instead of hasServiceWorkerRegisteredForOrigin.
Since the latter is trying to match a registration and compares scopes, we need the scopes to be set right on the tests.
- http/tests/workers/service/basic-unregister.https-expected.txt:
- http/tests/workers/service/resources/basic-register.js:
- http/tests/workers/service/resources/basic-unregister.js:
- 12:22 PM Changeset in webkit [224831] by
-
- 2 edits in trunk/Tools
Unreviewed, rolling out r224800.
https://bugs.webkit.org/show_bug.cgi?id=179684
"Broke CLoop test mozilla/js1_6/Array/regress-304828.js"
(Requested by mlam on #webkit).
Reverted changeset:
"Pass --useDollarVM=true to all JSC tests."
https://bugs.webkit.org/show_bug.cgi?id=179647
https://trac.webkit.org/changeset/224800
- 12:09 PM Changeset in webkit [224830] by
-
- 2 edits in trunk/Source/WebKit
Consolidate sysctl-read rules in WebProcess sandbox
https://bugs.webkit.org/show_bug.cgi?id=179674
<rdar://problem/35367154>
Reviewed by Dean Jackson.
Consolidate the various calls to 'allow sysctl-read' imported during Bug 179548 into
the main function in the sandbox profile.
Remove the statement to grant global sysctl-read permissions that was copied into this
sandbox profile in an earlier checkin. We started blocking the blanket read permissions in
macOS 10.13, and want to continue to do so.
The earlier "grant global read access" in 'system.sb' apparently allowed some sysctl reads
to occur before we hit the block declaration in the WebContent sandbox. Now that we are
consistently blocking systcl reads from the start, we need to add whitelist entries for a
few more entries to avoid creating new sandbox violations.
- WebProcess/com.apple.WebProcess.sb.in:
- 12:06 PM Changeset in webkit [224829] by
-
- 8 edits in trunk/LayoutTests/imported/w3c
Unreviewed, rebaseline skipped / flaky service worker tests
- web-platform-tests/service-workers/service-worker/fetch-canvas-tainting-cache.https-expected.txt:
- web-platform-tests/service-workers/service-worker/fetch-canvas-tainting.https-expected.txt:
- web-platform-tests/service-workers/service-worker/fetch-cors-xhr.https-expected.txt:
- web-platform-tests/service-workers/service-worker/fetch-request-redirect.https-expected.txt:
- web-platform-tests/service-workers/service-worker/interfaces-sw.https-expected.txt:
- web-platform-tests/service-workers/service-worker/register-same-scope-different-script-url.https-expected.txt:
- web-platform-tests/service-workers/service-worker/registration-updateviacache.https-expected.txt:
- web-platform-tests/service-workers/service-worker/skip-waiting-without-using-registration.https-expected.txt:
- 11:54 AM Changeset in webkit [224828] by
-
- 13 edits in trunk/Source/WebKit
Remove WebKit CFURLConnection code
https://bugs.webkit.org/show_bug.cgi?id=179645
Reviewed by Alexey Proskuryakov.
The CFURLConnection code is Windows-specific now. Nobody can use it in modern WebKit.
- NetworkProcess/Downloads/Download.h:
- NetworkProcess/Downloads/mac/DownloadMac.mm:
- NetworkProcess/NetworkLoad.h:
- NetworkProcess/cocoa/NetworkDataTaskCocoa.mm:
(WebKit::serverTrustCredential):
- NetworkProcess/mac/NetworkLoadMac.mm:
- Shared/Authentication/AuthenticationManager.cpp:
(WebKit::AuthenticationManager::useCredentialForSingleChallenge):
(WebKit::AuthenticationManager::continueWithoutCredentialForSingleChallenge):
(WebKit::AuthenticationManager::cancelSingleChallenge):
(WebKit::AuthenticationManager::performDefaultHandlingForSingleChallenge):
(WebKit::AuthenticationManager::rejectProtectionSpaceAndContinueForSingleChallenge):
- Shared/Authentication/cocoa/AuthenticationManagerCocoa.mm:
- Shared/Authentication/mac/AuthenticationManager.mac.mm:
(WebKit::AuthenticationManager::tryUseCertificateInfoForChallenge):
- Shared/WebProcessCreationParameters.cpp:
(WebKit::WebProcessCreationParameters::encode const):
(WebKit::WebProcessCreationParameters::decode):
- Shared/WebProcessCreationParameters.h:
- Shared/mac/WebCoreArgumentCodersMac.mm:
(IPC::ArgumentCoder<ResourceRequest>::encodePlatformData):
(IPC::ArgumentCoder<ResourceRequest>::decodePlatformData):
- config.h:
- 11:50 AM Changeset in webkit [224827] by
-
- 3 edits in trunk/Source/WebKit
Remove assertions added in r224791
https://bugs.webkit.org/show_bug.cgi?id=178751#c10
- NetworkProcess/mac/RemoteNetworkingContext.mm:
(WebKit::RemoteNetworkingContext::ensureWebsiteDataStoreSession):
- WebProcess/WebCoreSupport/mac/WebFrameNetworkingContext.mm:
(WebKit::WebFrameNetworkingContext::ensureWebsiteDataStoreSession):
I had added assertions that sandbox extension handle consumption succeeds.
In the API test IndexedDB.StructuredCloneBackwardCompatibility we get a sandbox extension handle
to give access to a directory that does not exist and consumption fails. We want it to fail,
so my optimistic addition of a success assertion was incorrect. The test passes without it
and behaves like it used to.
- 11:44 AM Changeset in webkit [224826] by
-
- 8 edits3 adds in trunk/Source
Web Inspector: Add a ServiceWorker domain to get information about an inspected ServiceWorker
https://bugs.webkit.org/show_bug.cgi?id=179640
<rdar://problem/35517361>
Reviewed by Devin Rousso.
Source/JavaScriptCore:
- CMakeLists.txt:
- DerivedSources.make:
Gate the ServiceWorker domain on the ENABLE feature flag.
- inspector/protocol/ServiceWorker.json: Added.
New domain to be made available inside of a ServiceWorker target.
Source/WebCore:
- Sources.txt:
- WebCore.xcodeproj/project.pbxproj:
- inspector/InspectorAllInOne.cpp:
New files.
- inspector/WorkerInspectorController.cpp:
(WebCore::WorkerInspectorController::createLazyAgents):
Add a ServiceWorkerAgent when the Worker is a ServiceWorker.
- inspector/agents/worker/ServiceWorkerAgent.h: Added.
- inspector/agents/worker/ServiceWorkerAgent.cpp: Added.
(WebCore::ServiceWorkerAgent::ServiceWorkerAgent):
(WebCore::ServiceWorkerAgent::didCreateFrontendAndBackend):
(WebCore::ServiceWorkerAgent::willDestroyFrontendAndBackend):
(WebCore::ServiceWorkerAgent::getInitializationInfo):
Populate initialization info.
- 11:43 AM Changeset in webkit [224825] by
-
- 2 edits in trunk/Source/WebKit
Don't use -[NSString stringWithFormat:] to build defaults keys
https://bugs.webkit.org/show_bug.cgi?id=179680
Reviewed by Simon Fraser.
- UIProcess/mac/WebPreferencesMac.mm:
(WebKit::makeKey):
(WebKit::debugUserDefaultsValue):
Use string concatenation instead of stringWithFormat to build
preference keys. This wasn't a huge cost, but it shaves a few milliseconds
off process launch.
- 11:40 AM Changeset in webkit [224824] by
-
- 2 edits in trunk/Source/WebCore
Remove some accidentally checked-in commented-out code.
Unreviewed.
- workers/service/server/SWServer.cpp:
(WebCore::SWServer::fireInstallEvent):
(WebCore::SWServer::fireActivateEvent):
- 11:15 AM Changeset in webkit [224823] by
-
- 12 edits in trunk
Clean up old URL parser remnants
https://bugs.webkit.org/show_bug.cgi?id=179573
Reviewed by Darin Adler.
LayoutTests/imported/w3c:
- web-platform-tests/url/url-setters-expected.txt:
We're more spec compliant! Hooray!
Source/WebCore:
When we transitioned to the new URLParser, we kept the old character tables which were less spec-conformant.
Removing them and transitioning to URLParser's table makes more web platform tests pass!
- fileapi/BlobURL.cpp:
(WebCore::BlobURL::createBlobURL):
There's no need to percent-encode an origin. It's already ascii, and if it's not, then the URLParser will escape it.
- loader/appcache/ApplicationCacheHost.cpp:
(WebCore::ApplicationCacheHost::createFileURL):
Removed comment that no longer applies.
- platform/URL.cpp:
(WebCore::URL::setProtocol):
(WebCore::percentEncodeCharacters):
(WebCore::URL::setUser):
(WebCore::URL::setPass):
Percent encode the userinfo character set from the URLParser according to https://url.spec.whatwg.org/#set-the-username and https://url.spec.whatwg.org/#set-the-password
(WebCore::URL::setPath):
A ? or a # are the only two characters that need to be pre-encoded when setting the path because they indicate the
beginning of a query or fragment. All other characters will be encoded if necessary during parsing.
(WebCore::protocolIsInternal):
(): Deleted.
(WebCore::isSchemeFirstChar): Deleted.
(WebCore::isSchemeChar): Deleted.
(WebCore::isBadChar): Deleted.
(WebCore::isTabNewline): Deleted.
(WebCore::appendEscapedChar): Deleted.
(WebCore::encodeWithURLEscapeSequences):
Encode characters needed. I used the user info set of characters because that was most similar to the BadChar set of the old parser.
This isn't standardized, and it's only used for the search context menu item which certainly isn't standardized.
(WebCore::isValidProtocol): Deleted.
Remove a bunch of old unused functions.
- platform/URLParser.cpp:
(WebCore::URLParser::isInUserInfoEncodeSet):
(WebCore::URLParser::parseAuthority):
- platform/URLParser.h:
Expose a few functions for URL.cpp to use.
Source/WebKit:
- WebProcess/WebCoreSupport/WebContextMenuClient.cpp:
(WebKit::WebContextMenuClient::searchWithGoogle):
Use https if we do end up searching with google.
Source/WebKitLegacy/win:
- WebCoreSupport/WebContextMenuClient.cpp:
(WebContextMenuClient::searchWithGoogle):
Use https if we do end up searching with google.
- 11:01 AM Changeset in webkit [224822] by
-
- 9 edits in trunk
Enable display:contents by default
https://bugs.webkit.org/show_bug.cgi?id=179655
Reviewed by Sam Weinig.
Source/WebCore:
- page/RuntimeEnabledFeatures.h:
Source/WebKit:
- Shared/WebPreferences.yaml:
Make non-experimental and enabled.
Source/WebKitLegacy/mac:
- WebView/WebPreferences.mm:
(+[WebPreferences initialize]):
Tools:
No need to enable this specifically for tests anymore.
- DumpRenderTree/mac/DumpRenderTree.mm:
(enableExperimentalFeatures):
- WebKitTestRunner/TestController.cpp:
(WTR::TestController::resetPreferencesToConsistentValues):
- 10:36 AM Changeset in webkit [224821] by
-
- 2 edits in trunk/Source/WebKit
Consolidate mach-lookup calls in WebProcess sandbox
https://bugs.webkit.org/show_bug.cgi?id=179650
<rdar://problem/35367154>
Reviewed by Dean Jackson.
Consolidate the various calls to 'allow mach-lookup' imported during Bug 179548 into the main
function in the sandbox profile. Remove some entries that are not needed by WebKit.
Remove the statement to grant global permission to perform mach-lookup for any xpc
service name that was copied into this sandbox profile in Bug 179548. We started blocking
this in macOS 10.13 and want to continue to do so.
The earlier "grant global permission" in 'system.sb' apparently allowed some xpc lookups to occur
before we hit the block declaration in the WebContent sandbox. Now that we are consistently blocking
mach lookups we need to add whitelist entries for a few more services to avoid creating new
sandbox violations.
- WebProcess/com.apple.WebProcess.sb.in:
- 10:02 AM Changeset in webkit [224820] by
-
- 4 edits in trunk/Source/WebCore
[Cairo] Move drawLine operation from GraphicsContextCairo to CairoOperations
https://bugs.webkit.org/show_bug.cgi?id=179669
Reviewed by Carlos Garcia Campos.
Move the drawLine operation implementation into the CairoOperations
implementation file, with the Cairo::drawLine() function only expecting
a PlatformContextCairo object, two FloatingPoints, and a const reference
to a GraphicsContextState object.
As with drawLinesForText(), the drawLine() implementation utilized a few
private GraphicsContext methods that we for now reimplement in the
Cairo namespace as static functions, providing necessary state values to
perform the computations. The GraphicsContext methods should be changed
to become static public functions -- after that we'll be able to remove
the new duplicated helper functions.
No new tests -- no change in behavior.
- platform/graphics/cairo/CairoOperations.cpp:
(WebCore::Cairo::dashedLineCornerWidthForStrokeWidth):
(WebCore::Cairo::dashedLinePatternWidthForStrokeWidth):
(WebCore::Cairo::dashedLinePatternOffsetForPatternAndStrokeWidth):
(WebCore::Cairo::centerLineAndCutOffCorners):
(WebCore::Cairo::drawLine):
- platform/graphics/cairo/CairoOperations.h:
- platform/graphics/cairo/GraphicsContextCairo.cpp:
(WebCore::GraphicsContext::drawLine):
- 9:44 AM Changeset in webkit [224819] by
-
- 8 edits in trunk
Long pressing a phone number with spaces in it results in a link sheet instead of a data detectors sheet
https://bugs.webkit.org/show_bug.cgi?id=179646
<rdar://problem/35337288>
Reviewed by Simon Fraser.
Source/WebCore:
- editing/cocoa/DataDetection.h:
- editing/cocoa/DataDetection.mm:
(WebCore::DataDetection::canBePresentedByDataDetectors):
(WebCore::DataDetection::isDataDetectorLink):
Expose canBePresentedByDataDetectors, which tests if the URL's
scheme is one of Data Detectors' known long-press schemes.
Source/WebKit:
- UIProcess/ios/WKActionSheetAssistant.mm:
(-[WKActionSheetAssistant showImageSheet]):
(-[WKActionSheetAssistant showLinkSheet]):
(-[WKActionSheetAssistant showDataDetectorsSheet]):
- UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView _actionForLongPressFromPositionInformation:]):
(-[WKContentView _interactionShouldBeginFromPreviewItemController:forPosition:]):
Make use of canBePresentedByDataDetectors with our WebCore URL instead
of (sometimes unsucessfully) reparsing the URL with NSURL's parser.
Also, avoid a few unnecessary round-trips through String when converting
from URL to NSURL.
Tools:
- TestWebKitAPI/Tests/ios/ActionSheetTests.mm:
(-[ActionSheetObserver _dataDetectionContextForWebView:]):
(TestWebKitAPI::TEST):
Add a test that ensures that a phone number with spaces in it
invokes a data detectors sheet, not a normal link sheet.
- 9:35 AM Changeset in webkit [224818] by
-
- 7 edits2 adds in trunk
[DFG][FTL] Support Array::DirectArguments with OutOfBounds
https://bugs.webkit.org/show_bug.cgi?id=179594
Reviewed by Saam Barati.
JSTests:
- stress/direct-arguments-in-bounds-to-out-of-bounds.js: Added.
(shouldBe):
(args):
- stress/direct-arguments-out-of-bounds-watchpoint.js: Added.
(shouldBe):
(args):
Source/JavaScriptCore:
Currently we handle OOB access to DirectArguments as GetByVal(Array::Generic).
If we can handle it as GetByVal(Array::DirectArguments+OutOfBounds), we can (1) optimize
arguments[i]accesses if i is in bound, and (2) encourage arguments elimination phase
to convert CreateDirectArguments and GetByVal(Array::DirectArguments+OutOfBounds) to
PhantomDirectArguments and GetMyArgumentOutOfBounds respectively.
This patch introduces Array::DirectArguments+OutOfBounds array mode. GetByVal can
accept this type, and emit optimized code compared to Array::Generic case.
We make OOB check failures in GetByVal(Array::DirectArguments+InBounds) as OutOfBounds
exit instead of ExoticObjectMode.
This change significantly improves SixSpeed rest.es5 since it uses OOB access.
Our arguments elimination phase can change CreateDirectArguments to PhantomDirectArguments.
rest.es5 59.6719+-2.2440 3.1634+-0.5507 definitely 18.8635x faster
- dfg/DFGArgumentsEliminationPhase.cpp:
- dfg/DFGArrayMode.cpp:
(JSC::DFG::ArrayMode::refine const):
- dfg/DFGClobberize.h:
(JSC::DFG::clobberize):
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compileGetByValOnDirectArguments):
- ftl/FTLLowerDFGToB3.cpp:
(JSC::FTL::DFG::LowerDFGToB3::compileGetByVal):
(JSC::FTL::DFG::LowerDFGToB3::compileGetMyArgumentByVal):
- 9:18 AM Changeset in webkit [224817] by
-
- 2 edits in trunk/Source/WebCore
[GTK][WPE] Don't require brotli
https://bugs.webkit.org/show_bug.cgi?id=178122
Reviewed by Frédéric Wang.
Remove stray remaining use of brotli CMake variable.
- CMakeLists.txt:
- 8:37 AM Changeset in webkit [224816] by
-
- 2 edits in trunk/Source/WebKit
REGRESSION(r224799): WebKit crashes on Sierra due to sandbox violation
https://bugs.webkit.org/show_bug.cgi?id=179656
Unreviewed build fix.
- WebProcess/com.apple.WebProcess.sb.in: Switch to Dan's recommended version check.
- 7:47 AM Changeset in webkit [224815] by
-
- 2 edits in trunk/Tools
Add committer status for Emilio Cobos Álvarez.
https://bugs.webkit.org/show_bug.cgi?id=179667
Unreviewed.
- Scripts/webkitpy/common/config/contributors.json:
- 5:45 AM Changeset in webkit [224814] by
-
- 4 edits in trunk/Source/WebCore
[Cairo] Move drawLinesForText operation from GraphicsContextCairo to CairoOperations
https://bugs.webkit.org/show_bug.cgi?id=179661
Reviewed by Carlos Garcia Campos.
Encapsulate the drawLinesForText() operation in the WebCore::Cairo
namespace. Apart from moving gist of the code from GraphicsContextCairo
to CairoOperations, we also (for the moment) have to duplicate the
GraphicsContext::computeLineBoundsAndAntialiasingModeForText() code.
This is necessary because the given method is private on the
GraphicsContext class, and relies on an underlying GraphicsContext
object to retrieve the current CTM and stroke thickness values.
The adjusted reimplementation uses PlatformContextCairo to retrieve
the CTM (just like Cairo's GraphicsContext::getCTM() does), and
requires the stroke thickness value to be passed in as an argument.
Similar modifications will be proposed for the existing
GraphicsContext::computeLineBoundsAndAntialiasingModeForText() code,
and once that's approved the duplicated code will be eliminated.
No new tests -- no change in behavior.
- platform/graphics/cairo/CairoOperations.cpp:
(WebCore::Cairo::computeLineBoundsAndAntialiasingModeForText):
(WebCore::Cairo::drawLinesForText):
- platform/graphics/cairo/CairoOperations.h:
- platform/graphics/cairo/GraphicsContextCairo.cpp:
(WebCore::GraphicsContext::drawLinesForText):
- 5:42 AM Changeset in webkit [224813] by
-
- 5 edits in trunk/Source/WebCore
[Cairo] Move native image drawing operation to CairoOperations
https://bugs.webkit.org/show_bug.cgi?id=179660
Reviewed by Carlos Garcia Campos.
Unify the native image drawing operation behavior between the
Cairo-specific GraphicsContext and drawNativeImage() implementations and
then move the code into the Cairo::drawNativeImage() function, inside
the CairoOperations implementation file.
No new tests -- no change in behavior.
- platform/graphics/cairo/CairoOperations.cpp:
(WebCore::Cairo::cairoSurfaceHasAlpha):
(WebCore::Cairo::drawNativeImage):
- platform/graphics/cairo/CairoOperations.h:
- platform/graphics/cairo/GraphicsContextCairo.cpp:
(WebCore::GraphicsContext::drawNativeImage):
- platform/graphics/cairo/NativeImageCairo.cpp:
(WebCore::drawNativeImage):
- 5:23 AM Changeset in webkit [224812] by
-
- 3 edits in trunk/LayoutTests
Add some bug numbers for failing XHR tests
https://bugs.webkit.org/show_bug.cgi?id=179664
Unreviewed test gardening.
- TestExpectations:
- platform/gtk/TestExpectations: The two send-entity-body tests were not marked as failing anywhere, so the annotations here were superfluous.
- 1:08 AM Changeset in webkit [224811] by
-
- 2 edits in trunk/Source/bmalloc
Make the gigacage runway 32GB
https://bugs.webkit.org/show_bug.cgi?id=175062
Reviewed by Mark Lam.
Making the gigacage runway 32GB defends us against buffer overflows in the
cage reaching memory outside the cage assuming indices are 32-bit unsigned
integers and the type they're indexing into has size <= 8 bytes. This is
exactly the case for many things in JSC. For example, butterfly access in
JSC meet this criteria, as does typed array access.
The 32GB comes from 8 * 232 = 32GB.
- bmalloc/Gigacage.cpp:
- 1:05 AM Changeset in webkit [224810] by
-
- 10 edits1 add in trunk
We need to set topCallFrame when calling Wasm::Memory::grow from the JIT
https://bugs.webkit.org/show_bug.cgi?id=179639
<rdar://problem/35513018>
Reviewed by JF Bastien.
JSTests:
- wasm/function-tests/grow-memory-cause-gc.js: Added.
(escape):
(i.func):
Source/JavaScriptCore:
Calling Wasm::Memory::grow from the JIT may cause us to GC. When we GC, we will
walk the stack for ShadowChicken (and maybe other things). We weren't updating
topCallFrame when calling grow from the Wasm JIT. This would cause the GC to
use stale topCallFrame bits in VM, often leading to crashes. This patch fixes
this bug by giving Wasm::Instance a lambda that is called when we need to store
the topCallFrame. Users of Wasm::Instance can provide a function to do this action.
Currently, JSWebAssemblyInstance passes in a lambda that stores to
VM.topCallFrame.
- wasm/WasmB3IRGenerator.cpp:
(JSC::Wasm::B3IRGenerator::addGrowMemory):
- wasm/WasmInstance.cpp:
(JSC::Wasm::Instance::Instance):
(JSC::Wasm::Instance::create):
- wasm/WasmInstance.h:
(JSC::Wasm::Instance::storeTopCallFrame):
- wasm/js/JSWebAssemblyInstance.cpp:
(JSC::JSWebAssemblyInstance::create):
- wasm/js/JSWebAssemblyInstance.h:
- wasm/js/WasmToJS.cpp:
(JSC::Wasm::wasmToJSException):
- wasm/js/WebAssemblyInstanceConstructor.cpp:
(JSC::constructJSWebAssemblyInstance):
- wasm/js/WebAssemblyPrototype.cpp:
(JSC::instantiate):
- 12:56 AM Changeset in webkit [224809] by
-
- 4 edits in trunk/Source/WebCore
[Cairo] Perform GraphicsContextPlatformPrivate method calls from CairoOperations
https://bugs.webkit.org/show_bug.cgi?id=179657
Reviewed by Carlos Garcia Campos.
To enable encapsulating remaining Cairo operations in static functions
inside the WebCore::Cairo namespace, we have to work around the
GraphicsContextPlatformPrivate methods that are invoked in the current
GraphicsContext implementation for Cairo.
A pointer to the GraphicsContextPlatformPrivate object is now kept on
the PlatformContextCairo instance, and we take care of setting it up
and clearing it out appropriate to the GraphicsContextPlatformPrivate
lifetime (as managed in Cairo-specific GraphicsContext implementation).
The GraphicsContextPlatformPrivate method invocations are then moved
to the appropriate CairoOperations functions.
No new tests -- no change in behavior.
- platform/graphics/cairo/CairoOperations.cpp:
(WebCore::Cairo::State::setCTM):
(WebCore::Cairo::save):
(WebCore::Cairo::restore):
(WebCore::Cairo::translate):
(WebCore::Cairo::rotate):
(WebCore::Cairo::scale):
(WebCore::Cairo::concatCTM):
(WebCore::Cairo::clip):
(WebCore::Cairo::clipPath):
- platform/graphics/cairo/GraphicsContextCairo.cpp:
(WebCore::GraphicsContext::GraphicsContext):
(WebCore::GraphicsContext::platformInit):
(WebCore::GraphicsContext::platformDestroy):
(WebCore::GraphicsContext::savePlatformState):
(WebCore::GraphicsContext::restorePlatformState):
(WebCore::GraphicsContext::clip):
(WebCore::GraphicsContext::clipPath):
(WebCore::GraphicsContext::translate):
(WebCore::GraphicsContext::concatCTM):
(WebCore::GraphicsContext::setCTM):
(WebCore::GraphicsContext::rotate):
(WebCore::GraphicsContext::scale):
- platform/graphics/cairo/PlatformContextCairo.h:
(WebCore::PlatformContextCairo::graphicsContextPrivate):
(WebCore::PlatformContextCairo::setGraphicsContextPrivate):
- 12:50 AM Changeset in webkit [224808] by
-
- 4 edits in trunk/Source/WebCore
[Cairo] Move simpler draw operations from GraphicsContextCairo to CairoOperations
https://bugs.webkit.org/show_bug.cgi?id=179614
Reviewed by Carlos Garcia Campos.
Move operations that perform simpler drawing to the CairoOperations
file. This isolates the Cairo code and encapsulates operation work
into a limited scope. This patch only covers drawing patterns,
rectangles, document marker lines and ellipses. A missing forward
declaration for the drawGlyphs() function is also added in the
CairoOperations header.
No new tests -- no change in behavior.
- platform/graphics/cairo/CairoOperations.cpp:
(WebCore::Cairo::drawPattern):
(WebCore::Cairo::drawRect):
(WebCore::Cairo::drawLineForDocumentMarker):
(WebCore::Cairo::drawEllipse):
- platform/graphics/cairo/CairoOperations.h:
- platform/graphics/cairo/GraphicsContextCairo.cpp:
(WebCore::GraphicsContext::drawRect):
(WebCore::GraphicsContext::drawEllipse):
(WebCore::GraphicsContext::drawLineForDocumentMarker):
(WebCore::GraphicsContext::drawPattern):
- 12:49 AM Changeset in webkit [224807] by
-
- 5 edits in trunk/Source/WebInspectorUI
Web Inspector: Cleanup navigation bar dividers and separators
https://bugs.webkit.org/show_bug.cgi?id=179654
<rdar://problem/35523734>
Reviewed by Devin Rousso.
Update path separator icon, and reduce number of dividers used in the
content browser's navigation bar, to more closely match modern Xcode.
- UserInterface/Images/HierarchicalNavigationItemChevron.svg:
Update icon, remove tapered arrow head.
- UserInterface/Views/ContentBrowser.js:
(WI.ContentBrowser):
Remove divider between back/forward buttons and item name.
(WI.ContentBrowser.prototype._updateContentViewNavigationItems):
- UserInterface/Views/HierarchicalPathComponent.css:
(.hierarchical-path-component > .separator):
- UserInterface/Views/LogContentView.js:
(WI.LogContentView.prototype.get navigationItems):
Remove dividers between buttons provided by the current content view.
