Timeline

Nov 19, 2017:

9:10 PM Changeset in webkit [225042] by timothy_horton@apple.com

• 18 edits in trunk

Remove unused TOUCH_ICON_LOADING feature flag
​https://bugs.webkit.org/show_bug.cgi?id=179873

Reviewed by Simon Fraser.

.:

• Source/cmake/OptionsMac.cmake:
• Source/cmake/WebKitFeatures.cmake:

Source/JavaScriptCore:

• Configurations/FeatureDefines.xcconfig:

Source/WebCore:

• Configurations/FeatureDefines.xcconfig:

Source/WebCore/PAL:

• Configurations/FeatureDefines.xcconfig:

Source/WebKit:

• Configurations/FeatureDefines.xcconfig:

Source/WebKitLegacy/mac:

• Configurations/FeatureDefines.xcconfig:

Source/WTF:

• wtf/FeatureDefines.h:

Tools:

• Scripts/webkitperl/FeatureList.pm:
• TestWebKitAPI/Configurations/FeatureDefines.xcconfig:

7:53 PM Changeset in webkit [225041] by Ms2ger@igalia.com

• 2 edits
  5 adds in trunk/LayoutTests

[WPE] Enable the XMLHttpRequest/ directory of web-platform-tests.
​https://bugs.webkit.org/show_bug.cgi?id=179820

Reviewed by Sam Weinig.

Added test expectations are copied from platform/gtk/

• platform/wpe/TestExpectations:
• platform/wpe/imported/w3c/web-platform-tests/XMLHttpRequest/send-entity-body-get-head-async-expected.txt: Added.
• platform/wpe/imported/w3c/web-platform-tests/XMLHttpRequest/send-entity-body-get-head-expected.txt: Added.
• platform/wpe/imported/w3c/web-platform-tests/XMLHttpRequest/send-redirect-expected.txt: Added.
• platform/wpe/imported/w3c/web-platform-tests/XMLHttpRequest/setrequestheader-content-type-expected.txt: Added.

5:41 PM Changeset in webkit [225040] by Yusuke Suzuki

• 8 edits in trunk

Add CPU(UNKNOWN) to cover all the unknown CPU types
​https://bugs.webkit.org/show_bug.cgi?id=179243

Reviewed by JF Bastien.

.:

Drop SH4, S390, and S390X explicit support. They are handled as CPU(UNKNOWN).

• CMakeLists.txt:

Source/JavaScriptCore:

• CMakeLists.txt:

Source/WTF:

This patch adds a new CPU type, CPU(UNKNOWN) to cover all the unknown CPUs.
This CPU architecture tells conservative assumption to make JSC work on all
the unknown generic CPUs. And we make several CPUs (ALPHA, SH4, S390, S390X, IA64, IA64_32)
UNKNOWN.

We also make InlineASM available only for !CPU(UNKNOWN). In an unknown CPU, inline asm is not useful.

And we also introduce a generic way to detect 64bit pointer environment by using
SIZEOF_POINTER predefined macro, or UINTPTR_MAX > UINT32_MAX.

• wtf/InlineASM.h:
• wtf/Platform.h:
• wtf/dtoa/utils.h:

5:31 PM Changeset in webkit [225039] by timothy_horton@apple.com

• 19 edits in trunk

Remove unused LEGACY_VENDOR_PREFIXES feature flag
​https://bugs.webkit.org/show_bug.cgi?id=179872

Reviewed by Darin Adler.

.:

• Source/cmake/OptionsMac.cmake:
• Source/cmake/OptionsWin.cmake:
• Source/cmake/WebKitFeatures.cmake:

Source/JavaScriptCore:

• Configurations/FeatureDefines.xcconfig:

Source/WebCore:

• Configurations/FeatureDefines.xcconfig:

Source/WebCore/PAL:

• Configurations/FeatureDefines.xcconfig:

Source/WebKit:

• Configurations/FeatureDefines.xcconfig:

Source/WebKitLegacy/mac:

• Configurations/FeatureDefines.xcconfig:

Source/WTF:

• wtf/FeatureDefines.h:

Tools:

• TestWebKitAPI/Configurations/FeatureDefines.xcconfig:

5:08 PM Changeset in webkit [225038] by Chris Dumez

• 2 edits in trunk/Source/WTF

Fix potential thread safety issue in ThreadSafeIdentified
​https://bugs.webkit.org/show_bug.cgi?id=179879

Reviewed by Darin Adler.

Fix potential thread safety issue in ThreadSafeIdentified. Protect static std::atomic
initialization with an std::call_once() given that we build with
--fno-threadsafe-statics.

• wtf/Identified.h:

(WTF::Identified::Identified):
(WTF::Identified::generateIdentifier):
(WTF::ThreadSafeIdentified::ThreadSafeIdentified):
(WTF::ThreadSafeIdentified::generateIdentifier):

4:56 PM Changeset in webkit [225037] by Darin Adler

• 38 edits in trunk/Source

Eliminate some cases of double hashing, other related refactoring
​https://bugs.webkit.org/show_bug.cgi?id=179867

Reviewed by Sam Weinig.

Source/WebCore:

• Modules/indexeddb/IDBTransaction.cpp:

(WebCore::IDBTransaction::objectStore): Use get instead of find.

• Modules/mediasource/MediaSourceRegistry.cpp:

(WebCore::MediaSourceRegistry::unregisterURL): Use take instead of find/remove.

• accessibility/AXObjectCache.cpp:

(WebCore::AXObjectCache::~AXObjectCache): Call setAXObjectID instead of
using the removeAXID, which doesn't do anything else useful in the destructor.
(WebCore::AXObjectCache::remove): Use take instead of get/remove. Also rearrange
logic to eliminate the removeAXID function.
(WebCore::AXObjectCache::removeAXID): Deleted. This only did two things,
setAXObjectID(0) and remove from m_idsInUse, and was only called in one place
besides the destructor. Clearer to not have this funtion.
(WebCore::AXObjectCache::visiblePositionForTextMarkerData): Use m_idsInUse
directly instead of using a function.

• accessibility/AXObjectCache.h: Deleted removeAXID and isIDinUse.

• dom/Document.cpp:

(WebCore::Document::removedLastRef): Call UserActionElementSet::clear instead
of UserActionElementSet::documentDidRemoveLastRef; new name fo the same function.
(WebCore::Document::updateHoverActiveState): Use a reference when calling
setInActiveChain.

• dom/Element.cpp:

(WebCore::Element::isUserActionElementInActiveChain const): Pass reference
instead of pointer.
(WebCore::Element::isUserActionElementActive const): Ditto.
(WebCore::Element::isUserActionElementFocused const): Ditto.
(WebCore::Element::isUserActionElementHovered const): Ditto.
(WebCore::Element::setActive): Ditto.
(WebCore::Element::setFocus): Ditto.
(WebCore::Element::setHovered): Ditto.
(WebCore::Element::clearHoverAndActiveStatusBeforeDetachingRenderer): Ditto.

• dom/GenericEventQueue.cpp:

(WebCore::GenericEventQueue::resume): Removed unneeded speical case for
empty vector.

• dom/ProcessingInstruction.cpp:

(WebCore::ProcessingInstruction::checkStyleSheet): Updated now that
parseAttributes returns an optional instead of using a boolean "OK" out argument.

• dom/SelectorQuery.cpp:

(WebCore::SelectorQueryCache::add): Use get instead of find.

• dom/UserActionElementSet.cpp:

(WebCore::UserActionElementSet::didDetach): Deleted. Moved to class definition and
named clearActiveAndHovered.
(WebCore::UserActionElementSet::clear): Renamed documentDidRemoveLastRef to clear.
(WebCore::UserActionElementSet::hasFlag const): Renamed from hasFlags and also
take reference and enumeration instead of pointer and unsigned. Makes it clearer
this does not allow null and that it works on a single flag, not a set of flags.
(WebCore::UserActionElementSet::clearFlags): Changed argument types to reference
and OptionSet to make it clear this works on a set of flags.
(WebCore::UserActionElementSet::setFlags): Ditto.

• dom/UserActionElementSet.h: Updated for changes above. Also made some name

changes, and used an enum class instead of an enum.

• html/BaseCheckableInputType.cpp:

(WebCore::BaseCheckableInputType::saveFormControlState const): Updated since
FormControlState is now just a vector, not a class.

• html/FileInputType.cpp:

(WebCore::FileInputType::filesFromFormControlState): Ditto.
(WebCore::FileInputType::restoreFormControlState): Removed unneeded check that
valueSize is a multiple of 2. Code will ignore any extra strings at the end, so
there is no need for the validity check.

• html/FormController.cpp:

(WebCore::serializeFormControlStateTo): Made a non-member function since
FormControlState is now just a vector, not a class.
(WebCore::deserializeFormControlState): Ditto. Also return optional instead
of relying on a special failure state.
(WebCore::SavedFormState::deserialize): Updated for above changes.
(WebCore::SavedFormState::serializeTo const): Ditto.
(WebCore::SavedFormState::appendControlState): Use add instead of both find and add
to avoid double hashing.
(WebCore::SavedFormState::takeControlState): Removed unneeded check for empty
hash table and tweaked coding style.
(WebCore::SavedFormState::referencedFilePaths const): Renamed to remove "get".
(WebCore::FormKeyGenerator::formKey): Use ensure instead of find and add.
(WebCore::FormController::formElementsCharacterCount const): Don't call
saveFormControlState for non-text-form-controls since we ignored those values.
(WebCore::FormController::willDeleteForm): Take a reference.
(WebCore::FormController::restoreControlStateFor): Update since FormControlState
is now a vector.
(WebCore::FormController::restoreControlStateIn): Use is/downcast and update
since FormControlState is now a vector.
(WebCore::FormController::referencedFilePaths): Renamed to remove "get".
(WebCore::FormController::registerFormElementWithState):Take a reference.
(WebCore::FormController::unregisterFormElementWithState): Ditto.

• html/FormController.h: Removed FormControlState class since it was just a

Vector<String> with various unneeded features, such as a "failure" state,
and a never-looked-at type of "skip" or "restore". Updated for other changes
above.

• html/HTMLFormControlElementWithState.cpp:

(WebCore::HTMLFormControlElementWithState::insertedIntoAncestor): Pass reference.
(WebCore::HTMLFormControlElementWithState::removedFromAncestor): Ditto.

• html/HTMLFormControlElementWithState.h: Updated for the above. Also added

support for using is/downcast on this.

• html/HTMLFormElement.cpp:

(WebCore::HTMLFormElement::~HTMLFormElement): Pass reference.

• html/HTMLSelectElement.cpp:

(WebCore::HTMLSelectElement::saveFormControlState const): Use reserveInitialCapacit
and uncheckedAppend.
(WebCore::HTMLSelectElement::restoreFormControlState): Updated since state is now
a vector.

• html/HTMLTextAreaElement.cpp:

(WebCore::HTMLTextAreaElement::saveFormControlState const): Ditto.

• html/HiddenInputType.cpp:

(WebCore::HiddenInputType::saveFormControlState const): Ditto.

• html/InputType.cpp:

(WebCore::InputType::saveFormControlState const): Ditto.

• inspector/agents/InspectorCSSAgent.cpp:

(WebCore::InspectorCSSAgent::forcePseudoState): Use get instead of find/end and got
rid of uneeded special case. In another overload, ue add and remove instead of
a find followed by a set or a remove.
(WebCore::InspectorCSSAgent::asInspectorStyleSheet): Use ensure instead of find/set.
(WebCore::InspectorCSSAgent::didRemoveDOMNode): Use take instead of find/remove.
(WebCore::InspectorCSSAgent::didModifyDOMAttr): Use get instead of find.

• inspector/agents/InspectorCSSAgent.h: Removed unneeded NodeToInspectorStyleSheet

typedef and changed value type to Ref instead of RefPtr.

• inspector/agents/InspectorDOMAgent.cpp:

(WebCore::InspectorDOMAgent::unbind): Use remove instead of contains/remove.
(WebCore::InspectorDOMAgent::nodeForId): Use isValidKey instead of just checking for
0 and use get instead of find.
(WebCore::InspectorDOMAgent::setAttributesAsText): Take out bogus const.
(WebCore::InspectorDOMAgent::moveTo): Ditto.
(WebCore::InspectorDOMAgent::resolveNode): Ditto.
(WebCore::InspectorDOMAgent::isWhitespace): Added FIXME. Use is<Text> instead of
slower nodeType.

• inspector/agents/InspectorDOMAgent.h: Removed bogus const.

• inspector/agents/InspectorLayerTreeAgent.cpp:

(WebCore::InspectorLayerTreeAgent::bind): Use ensure instead of get/set.
(WebCore::InspectorLayerTreeAgent::unbind): Use take instead of find/remove.
(WebCore::InspectorLayerTreeAgent::bindPseudoElement): Use ensure instead of get/set.
(WebCore::InspectorLayerTreeAgent::unbindPseudoElement): Use take instead of
find/remove.

• inspector/agents/InspectorPageAgent.cpp:

(WebCore::InspectorPageAgent::getCookies): Use add instead of contains/add.
(WebCore::InspectorPageAgent::frameDetached): Use take instead of find/remove.
(WebCore::InspectorPageAgent::frameId): Use ensure instead of get/set.
(WebCore::InspectorPageAgent::loaderId): Use ensure instead of get/set.
(WebCore::InspectorPageAgent::findFrameWithSecurityOrigin): Got rid of unneeded
local variable.

• loader/cache/CachedResourceLoader.cpp:

(WebCore::CachedResourceLoader::sessionID const): Tweaked coding style and added
a null check for page.
(WebCore::CachedResourceLoader::requestResource): Call page directly on the frame
instead of first getting the main frame. Also use take instead of find/remove.
(WebCore::CachedResourceLoader::removeCachedResource): Rewrite assertion.

• platform/graphics/FontGenericFamilies.cpp:

(WebCore::setGenericFontFamilyForScript): Use remove instead of find/remove.
Simplified the logic a bit in the add case.

• platform/graphics/ca/GraphicsLayerCA.cpp:

(WebCore::GraphicsLayerCA::pauseAnimation): Use add instead of find/add.
Removed code that said "if (action != Remove) action = Pause" since that is a
no-op; there are only two actions, Remove and Pause.

• rendering/RenderThemeMac.mm:

(WebCore::RenderThemeMac::mediaControlsScript): Use makeString instead of StringBuilder.
(WebCore::RenderThemeMac::systemColor const): Rewrote to use ensure instead of add.
Also crunched the code a little.

• testing/Internals.cpp:

(WebCore::Internals::getReferencedFilePaths const): Updated function name.

• xml/parser/XMLDocumentParser.h: Updated for change below.
• xml/parser/XMLDocumentParserLibxml2.cpp:

(WebCore::attributesStartElementNsHandler): Updated to use std::optional instead of
a separate boolean for AttributeParseState.
(WebCore::parseAttributes): Ditto. Also changed the return value to work the same way.

Source/WTF:

• wtf/text/StringImpl.cpp:

(WTF::StringImpl::containsOnlyWhitespace): Added FIXME.

3:06 PM Changeset in webkit [225036] by commit-queue@webkit.org

• 15 edits in trunk/Source/WebCore

Clean up gradient code in preparation for conic gradients
​https://bugs.webkit.org/show_bug.cgi?id=179595

Patch by Sam Weinig <​sam@webkit.org> on 2017-11-19
Reviewed by Darin Adler.

• Switches Gradient to use a Varient with type specific data structs and makes the points / radii immutable.
• Replaces CSSGradientValue::addStops with template function CSSGradientValue::computeStops which dispatches to a helper adoptor struct which is passed in for gradient type specific values, rather than switching on type in the function itself. In addition, the function no longer mutates a Gradient, but rather mutates type specific the data struct (e.g. Linear or Radial for now).

• css/CSSGradientValue.cpp:

(WebCore::LinearGradientAdaptor::LinearGradientAdaptor):
(WebCore::RadialGradientAdaptor::RadialGradientAdaptor):

Add helper structs for the now templatized CSSGradientValue::computeStops that
implement type specific functionality.

(WebCore::CSSGradientValue::computeStops):

Renamed from addStops. Now takes a GradientAdaptor wrapper which abstracts out
the gradient type specific functionlity.

(WebCore::CSSLinearGradientValue::createGradient):
(WebCore::CSSRadialGradientValue::createGradient):
(WebCore::CSSConicGradientValue::createGradient):

Update to call computeStops and use new Gradient create function.

• css/CSSGradientValue.h:

Update for new signature for computeStops.

• html/canvas/CanvasGradient.cpp:

(WebCore::CanvasGradient::CanvasGradient):

Update to use new Gradient create function.

• inspector/InspectorCanvas.cpp:

(WebCore::InspectorCanvas::buildArrayForCanvasGradient):

Update to get gradient point / radii information from the data accessor.

• platform/graphics/Gradient.cpp:

(WebCore::Gradient::Gradient):

Update constructors to the new data structs.

(WebCore::Gradient::type const):

Add helper to get the type of the varient, need for inspector code.

(WebCore::Gradient::adjustParametersForTiledDrawing):
(WebCore::Gradient::isZeroSize const):
(WebCore::Gradient::hash const):

Update to switch on the underlying variant to get data values.

(WebCore::Gradient::addColorStop):

Simplify by having one addColorStop call the other.

(WebCore::Gradient::setSortedColorStops):

Added. Replaces setStopsSorted. Used now that CSSGradientValue computes and sorts
its color stops before creating the gradient.

• platform/graphics/Gradient.h:

(WebCore::Gradient::create):

Replace create functions with ones that take data structs.

(WebCore::Gradient::data const):

Add accessor for the underlying variant.

(WebCore::Gradient::isRadial const): Deleted.

Replaced by type accessor.

(WebCore::Gradient::p0 const): Deleted.
(WebCore::Gradient::p1 const): Deleted.
(WebCore::Gradient::setP0): Deleted.
(WebCore::Gradient::setP1): Deleted.
(WebCore::Gradient::startRadius const): Deleted.
(WebCore::Gradient::endRadius const): Deleted.
(WebCore::Gradient::setStartRadius): Deleted.
(WebCore::Gradient::setEndRadius): Deleted.

Point and radii are now immutable.

(WebCore::Gradient::setStopsSorted): Deleted.

Replaced by setSortedColorStops function.

• platform/graphics/GraphicsContext.cpp:

(WebCore::GraphicsContext::fillRect):

Pass the GraphicsContext by reference.

• platform/graphics/cairo/GradientCairo.cpp:

(WebCore::Gradient::createPlatformGradient):

Update to switch on the underlying variant to get data values.

(WebCore::Gradient::fill):

Pass the GraphicsContext by reference.

• platform/graphics/cg/GradientCG.cpp:

(WebCore::Gradient::platformDestroy):

Use nullptr.

(WebCore::Gradient::fill):

Pass the GraphicsContext by reference.

(WebCore::Gradient::paint):

Update to switch on the underlying variant to get data values.

• platform/graphics/cg/GraphicsContextCG.cpp:

(WebCore::GraphicsContext::fillPath):
(WebCore::GraphicsContext::strokePath):
(WebCore::GraphicsContext::fillRect):
(WebCore::GraphicsContext::strokeRect):

Pass the GraphicsContext by reference.

• platform/graphics/win/GradientDirect2D.cpp:

(WebCore::Gradient::generateGradient):

Update to switch on the underlying variant to get data values.

(WebCore::Gradient::fill):

Pass the GraphicsContext by reference.

• rendering/RenderThemeIOS.mm:

(WebCore::RenderThemeIOS::paintProgressBar):

• rendering/svg/RenderSVGResourceLinearGradient.cpp:

(WebCore::RenderSVGResourceLinearGradient::buildGradient const):

• rendering/svg/RenderSVGResourceRadialGradient.cpp:

(WebCore::RenderSVGResourceRadialGradient::buildGradient const):

Update for new Gradient create function signature.

1:57 PM Changeset in webkit [225035] by Simon Fraser

• 2 edits in trunk/Source/WebCore

Use TypedArrayView's setRange() in FETurbulence
​https://bugs.webkit.org/show_bug.cgi?id=179878

Reviewed by Sam Weinig.

Writing the 4 component values at once makes the function about 10% faster.

• platform/graphics/filters/FETurbulence.cpp:

(WebCore::FETurbulence::fillRegion const):

1:56 PM Changeset in webkit [225034] by Chris Dumez

• 2 edits in trunk/Source/WTF

Fix potential thread safety issue in generateThreadSafeObjectIdentifier()
​https://bugs.webkit.org/show_bug.cgi?id=179877

Reviewed by Sam Weinig.

Fix potential thread safety issue in generateThreadSafeObjectIdentifier().
Protect std::atomic initialization with an std::call_once() given that we
build with --fno-threadsafe-statics.

• wtf/ObjectIdentifier.h:

(WTF::generateThreadSafeObjectIdentifier):

7:06 AM WebKitGTK/2.18.x edited by Adrian Perez de Castro

(diff)

12:19 AM Changeset in webkit [225033] by Yusuke Suzuki

• 5 edits
  2 deletes in trunk/Tools

Unreviewed, rolling out r225016.

Break webkit-patch on Ubuntu and Debian Linux

Reverted changeset:

"webkitpy: Better name-version mapping (Part 1)"
​https://bugs.webkit.org/show_bug.cgi?id=179621
​https://trac.webkit.org/changeset/225016

12:07 AM Changeset in webkit [225032] by Yusuke Suzuki

• 2 edits in trunk/Source/WTF

[WTF] Use system endianess information instead of relying CPU information
​https://bugs.webkit.org/show_bug.cgi?id=179861

Reviewed by JF Bastien.

Currently, we use known CPU information to determine endianess of the current
architecture. But this means that unknown CPU does not work well in WebKit
withou modifying code. Instead, we use compiler or system's macro to determine
endianess. This paves the way to dropping many CPUs in Platform.h by replacing
them with CPU(UNKNOWN)[1].

[1]: ​https://bugs.webkit.org/show_bug.cgi?id=179243

• wtf/Platform.h:

Nov 18, 2017:

11:19 PM Changeset in webkit [225031] by Chris Dumez

• 35 edits
  1 copy in trunk

ASSERTION FAILED: registration in WebCore::SWServerJobQueue::scriptContextStarted(ServiceWorkerIdentifier)
​https://bugs.webkit.org/show_bug.cgi?id=179846

Reviewed by Darin Adler.

Source/WebCore:

We have seen crashes on the bots in SWServerJobQueue because methods such as scriptContextStarted()
can get called after the jobQueue has been cleared. This is because when a jobQueue is cleared,
an asynchronous operation may be pending (e.g. script fetch, service worker starting, install event).

To address the issue, we now pass the identifier of the job that started the asynchronous operation
when calling the methods on SWServerJobQueue. If the identifier does not match the identifier of
the current job in the JobQueue, we ignore it.

This patch also starts using a strongly typed identifier (ServiceWorkerJobIdentifier) for
ServiceWorkerJob, instead of a uint64_t. It also introduces a ServiceWorkerJobDataIdentifier type
which contains both a SWServerConnectionIdentifier and a ServiceWorkerJobIdentifier. This is useful
because ServiceWorkerJobData is passed to the StorageProcess and it needs a globally unique identifier.
ServiceWorkerJobIdentifier is only guaranteed to be unique within a single WebProcess. Augmenting it
with the SWServerConnectionIdentifier of the WebProcess makes it globally unique.

No new tests, unskipped exiting test.

• WebCore.xcodeproj/project.pbxproj:
• workers/service/ServiceWorkerContainer.cpp:

(WebCore::ServiceWorkerContainer::scheduleJob):
(WebCore::ServiceWorkerContainer::startScriptFetchForJob):
(WebCore::ServiceWorkerContainer::jobFinishedLoadingScript):
(WebCore::ServiceWorkerContainer::jobFailedLoadingScript):
(WebCore::ServiceWorkerContainer::jobDidFinish):

• workers/service/ServiceWorkerContainer.h:
• workers/service/ServiceWorkerContextData.cpp:

(WebCore::ServiceWorkerContextData::isolatedCopy const):

• workers/service/ServiceWorkerContextData.h:

(WebCore::ServiceWorkerContextData::encode const):
(WebCore::ServiceWorkerContextData::decode):

• workers/service/ServiceWorkerFetchResult.h:

(WebCore::ServiceWorkerFetchResult::encode const):
(WebCore::ServiceWorkerFetchResult::decode):

• workers/service/ServiceWorkerJob.h:

(WebCore::ServiceWorkerJob::identifier const):

• workers/service/ServiceWorkerJobData.cpp:

(WebCore::ServiceWorkerJobData::ServiceWorkerJobData):
(WebCore::ServiceWorkerJobData::isolatedCopy const):

• workers/service/ServiceWorkerJobData.h:

(WebCore::ServiceWorkerJobData::connectionIdentifier const):
(WebCore::ServiceWorkerJobData::identifier const):
(WebCore::ServiceWorkerJobData::encode const):
(WebCore::ServiceWorkerJobData::decode):

• workers/service/ServiceWorkerJobDataIdentifier.h: Copied from Source/WebCore/workers/service/ServiceWorkerFetchResult.h.

(WebCore::ServiceWorkerJobDataIdentifier::operator== const):
(WebCore::ServiceWorkerJobDataIdentifier::loggingString const):
(WebCore::ServiceWorkerJobDataIdentifier::encode const):
(WebCore::ServiceWorkerJobDataIdentifier::decode):

• workers/service/ServiceWorkerTypes.h:
• workers/service/context/SWContextManager.cpp:

(WebCore::SWContextManager::registerServiceWorkerThreadForInstall):

• workers/service/context/SWContextManager.h:
• workers/service/context/ServiceWorkerThread.cpp:

(WebCore::ServiceWorkerThread::fireInstallEvent):

• workers/service/server/SWClientConnection.cpp:

(WebCore::SWClientConnection::scheduleJob):
(WebCore::SWClientConnection::finishedFetchingScript):
(WebCore::SWClientConnection::failedFetchingScript):
(WebCore::SWClientConnection::jobRejectedInServer):
(WebCore::SWClientConnection::registrationJobResolvedInServer):
(WebCore::SWClientConnection::unregistrationJobResolvedInServer):
(WebCore::SWClientConnection::startScriptFetchForServer):

• workers/service/server/SWClientConnection.h:
• workers/service/server/SWServer.cpp:

(WebCore::SWServer::Connection::scheduleJobInServer):
(WebCore::SWServer::rejectJob):
(WebCore::SWServer::resolveRegistrationJob):
(WebCore::SWServer::startScriptFetch):
(WebCore::SWServer::scriptFetchFinished):
(WebCore::SWServer::scriptContextFailedToStart):
(WebCore::SWServer::scriptContextStarted):
(WebCore::SWServer::didFinishInstall):
(WebCore::SWServer::updateWorker):

• workers/service/server/SWServer.h:
• workers/service/server/SWServerJobQueue.cpp:

(WebCore::SWServerJobQueue::isCurrentlyProcessingJob const):
(WebCore::SWServerJobQueue::scriptFetchFinished):
(WebCore::SWServerJobQueue::scriptContextFailedToStart):
(WebCore::SWServerJobQueue::scriptContextStarted):
(WebCore::SWServerJobQueue::didFinishInstall):

• workers/service/server/SWServerJobQueue.h:
• workers/service/server/SWServerToContextConnection.cpp:

(WebCore::SWServerToContextConnection::scriptContextFailedToStart):
(WebCore::SWServerToContextConnection::scriptContextStarted):
(WebCore::SWServerToContextConnection::didFinishInstall):

• workers/service/server/SWServerToContextConnection.h:
• workers/service/server/SWServerWorker.cpp:

(WebCore::SWServerWorker::scriptContextFailedToStart):
(WebCore::SWServerWorker::scriptContextStarted):
(WebCore::SWServerWorker::didFinishInstall):

• workers/service/server/SWServerWorker.h:

Source/WebKit:

• StorageProcess/ServiceWorker/WebSWServerConnection.cpp:

(WebKit::WebSWServerConnection::rejectJobInClient):
(WebKit::WebSWServerConnection::resolveRegistrationJobInClient):
(WebKit::WebSWServerConnection::resolveUnregistrationJobInClient):
(WebKit::WebSWServerConnection::startScriptFetchInClient):

• StorageProcess/ServiceWorker/WebSWServerConnection.h:
• StorageProcess/ServiceWorker/WebSWServerToContextConnection.messages.in:
• WebProcess/Storage/WebSWClientConnection.messages.in:
• WebProcess/Storage/WebSWContextManagerConnection.cpp:

(WebKit::WebSWContextManagerConnection::serviceWorkerStartedWithMessage):
(WebKit::WebSWContextManagerConnection::didFinishInstall):

• WebProcess/Storage/WebSWContextManagerConnection.h:

Source/WTF:

Add a generateThreadSafeObjectIdentifier() for generating an ObjectIdentifier
in a thread-safe manner, using std::atomic.

• wtf/ObjectIdentifier.h:

(WTF::generateObjectIdentifier):
(WTF::generateThreadSafeObjectIdentifier):

LayoutTests:

Unskip test that use to flakily crash.

• platform/mac/TestExpectations:

10:59 PM Changeset in webkit [225030] by n_wang@apple.com

• 24 edits
  2 adds in trunk

AX: AOM: Implement number type properties
​https://bugs.webkit.org/show_bug.cgi?id=179497

Reviewed by Chris Fleizach.

Source/WebCore:

Accessibility Object Model
Explainer: ​https://wicg.github.io/aom/explainer.html
Spec: ​https://wicg.github.io/aom/spec/

Implemented the number type properties for Accessibility Object Modal.

Test: accessibility/mac/AOM-number-properties.html

• accessibility/AXObjectCache.cpp:

(WebCore::isNodeAriaVisible):

• accessibility/AccessibilityARIAGrid.cpp:

(WebCore::AccessibilityARIAGrid::isMultiSelectable const):

• accessibility/AccessibilityARIAGridCell.cpp:

(WebCore::AccessibilityARIAGridCell::rowIndexRange const):
(WebCore::AccessibilityARIAGridCell::axRowSpanWithRowIndex const):
(WebCore::AccessibilityARIAGridCell::columnIndexRange const):
(WebCore::AccessibilityARIAGridCell::ariaRowSpanWithRowIndex const): Deleted.

• accessibility/AccessibilityARIAGridCell.h:
• accessibility/AccessibilityNodeObject.cpp:

(WebCore::AccessibilityNodeObject::isEnabled const):
(WebCore::AccessibilityNodeObject::isMultiSelectable const):
(WebCore::AccessibilityNodeObject::isRequired const):
(WebCore::AccessibilityNodeObject::headingLevel const):
(WebCore::AccessibilityNodeObject::valueForRange const):
(WebCore::AccessibilityNodeObject::maxValueForRange const):
(WebCore::AccessibilityNodeObject::minValueForRange const):
(WebCore::AccessibilityNodeObject::hierarchicalLevel const):

• accessibility/AccessibilityObject.cpp:

(WebCore::AccessibilityObject::intValueForProperty const):
(WebCore::AccessibilityObject::unsignedValueForProperty const):
(WebCore::AccessibilityObject::doubleValueForProperty const):
(WebCore::AccessibilityObject::supportsSetSize const):
(WebCore::AccessibilityObject::supportsPosInSet const):
(WebCore::AccessibilityObject::setSize const):
(WebCore::AccessibilityObject::posInSet const):
(WebCore::AccessibilityObject::supportsARIASetSize const): Deleted.
(WebCore::AccessibilityObject::supportsARIAPosInSet const): Deleted.
(WebCore::AccessibilityObject::ariaSetSize const): Deleted.
(WebCore::AccessibilityObject::ariaPosInSet const): Deleted.

• accessibility/AccessibilityObject.h:
• accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::defaultObjectInclusion const):
(WebCore::AccessibilityRenderObject::liveRegionAtomic const):

• accessibility/AccessibilityTable.cpp:

(WebCore::AccessibilityTable::isDataTable const):
(WebCore::AccessibilityTable::axColumnCount const):
(WebCore::AccessibilityTable::axRowCount const):
(WebCore::AccessibilityTable::ariaColumnCount const): Deleted.
(WebCore::AccessibilityTable::ariaRowCount const): Deleted.

• accessibility/AccessibilityTable.h:
• accessibility/AccessibilityTableCell.cpp:

(WebCore::AccessibilityTableCell::AccessibilityTableCell):
(WebCore::AccessibilityTableCell::rowIndexRange const):
(WebCore::AccessibilityTableCell::columnIndexRange const):
(WebCore::AccessibilityTableCell::axColumnIndex const):
(WebCore::AccessibilityTableCell::axRowIndex const):
(WebCore::AccessibilityTableCell::axColumnSpan const):
(WebCore::AccessibilityTableCell::axRowSpan const):
(WebCore::AccessibilityTableCell::ariaColumnIndex const): Deleted.
(WebCore::AccessibilityTableCell::ariaRowIndex const): Deleted.
(WebCore::AccessibilityTableCell::ariaColumnSpan const): Deleted.
(WebCore::AccessibilityTableCell::ariaRowSpan const): Deleted.

• accessibility/AccessibilityTableCell.h:

(WebCore::AccessibilityTableCell::setAXColIndexFromRow):
(WebCore::AccessibilityTableCell::setARIAColIndexFromRow): Deleted.

• accessibility/AccessibilityTableRow.cpp:

(WebCore::AccessibilityTableRow::addChildren):
(WebCore::AccessibilityTableRow::axColumnIndex const):
(WebCore::AccessibilityTableRow::axRowIndex const):
(WebCore::AccessibilityTableRow::ariaColumnIndex const): Deleted.
(WebCore::AccessibilityTableRow::ariaRowIndex const): Deleted.

• accessibility/AccessibilityTableRow.h:
• accessibility/AccessibleNode.cpp:

(WebCore::ariaAttributeMap):
(WebCore::isPropertyValueInt):
(WebCore::isPropertyValueUnsigned):
(WebCore::isPropertyValueFloat):
(WebCore::AccessibleNode::setProperty):
(WebCore::AccessibleNode::setOptionalProperty):
(WebCore::AccessibleNode::setStringProperty):
(WebCore::AccessibleNode::optionalValueForProperty):
(WebCore::AccessibleNode::effectiveBoolValueForElement):
(WebCore::AccessibleNode::effectiveIntValueForElement):
(WebCore::AccessibleNode::effectiveUnsignedValueForElement):
(WebCore::AccessibleNode::effectiveDoubleValueForElement):
(WebCore::AccessibleNode::atomic const):
(WebCore::AccessibleNode::setAtomic):
(WebCore::AccessibleNode::setAutocomplete):
(WebCore::AccessibleNode::busy const):
(WebCore::AccessibleNode::setBusy):
(WebCore::AccessibleNode::setChecked):
(WebCore::AccessibleNode::colCount const):
(WebCore::AccessibleNode::setColCount):
(WebCore::AccessibleNode::colIndex const):
(WebCore::AccessibleNode::setColIndex):
(WebCore::AccessibleNode::colSpan const):
(WebCore::AccessibleNode::setColSpan):
(WebCore::AccessibleNode::setCurrent):
(WebCore::AccessibleNode::disabled const):
(WebCore::AccessibleNode::setDisabled):
(WebCore::AccessibleNode::expanded const):
(WebCore::AccessibleNode::setExpanded):
(WebCore::AccessibleNode::setHasPopUp):
(WebCore::AccessibleNode::hidden const):
(WebCore::AccessibleNode::setHidden):
(WebCore::AccessibleNode::setInvalid):
(WebCore::AccessibleNode::setKeyShortcuts):
(WebCore::AccessibleNode::label const):
(WebCore::AccessibleNode::setLabel):
(WebCore::AccessibleNode::level const):
(WebCore::AccessibleNode::setLevel):
(WebCore::AccessibleNode::live const):
(WebCore::AccessibleNode::setLive):
(WebCore::AccessibleNode::modal const):
(WebCore::AccessibleNode::setModal):
(WebCore::AccessibleNode::multiline const):
(WebCore::AccessibleNode::setMultiline):
(WebCore::AccessibleNode::multiselectable const):
(WebCore::AccessibleNode::setMultiselectable):
(WebCore::AccessibleNode::setOrientation):
(WebCore::AccessibleNode::setPlaceholder):
(WebCore::AccessibleNode::posInSet const):
(WebCore::AccessibleNode::setPosInSet):
(WebCore::AccessibleNode::setPressed):
(WebCore::AccessibleNode::readOnly const):
(WebCore::AccessibleNode::setReadOnly):
(WebCore::AccessibleNode::setRelevant):
(WebCore::AccessibleNode::required const):
(WebCore::AccessibleNode::setRequired):
(WebCore::AccessibleNode::setRole):
(WebCore::AccessibleNode::setRoleDescription):
(WebCore::AccessibleNode::rowCount const):
(WebCore::AccessibleNode::setRowCount):
(WebCore::AccessibleNode::rowIndex const):
(WebCore::AccessibleNode::setRowIndex):
(WebCore::AccessibleNode::rowSpan const):
(WebCore::AccessibleNode::setRowSpan):
(WebCore::AccessibleNode::selected const):
(WebCore::AccessibleNode::setSelected):
(WebCore::AccessibleNode::setSize const):
(WebCore::AccessibleNode::setSetSize):
(WebCore::AccessibleNode::setSort):
(WebCore::AccessibleNode::valueMax const):
(WebCore::AccessibleNode::setValueMax):
(WebCore::AccessibleNode::valueMin const):
(WebCore::AccessibleNode::setValueMin):
(WebCore::AccessibleNode::valueNow const):
(WebCore::AccessibleNode::setValueNow):
(WebCore::AccessibleNode::setValueText):
(WebCore::AccessibleNode::boolValueForProperty): Deleted.
(WebCore::AccessibleNode::setBoolProperty): Deleted.

• accessibility/AccessibleNode.h:
• accessibility/AccessibleNode.idl:
• accessibility/atk/WebKitAccessibleInterfaceTable.cpp:

(webkitAccessibleTableGetNColumns):
(webkitAccessibleTableGetNRows):

• accessibility/atk/WebKitAccessibleInterfaceTableCell.cpp:

(webkitAccessibleTableCellGetPosition):

• accessibility/atk/WebKitAccessibleWrapperAtk.cpp:

(webkitAccessibleGetAttributes):

• accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:

(-[WebAccessibilityObjectWrapper accessibilityARIARowCount]):
(-[WebAccessibilityObjectWrapper accessibilityARIAColumnCount]):
(-[WebAccessibilityObjectWrapper accessibilityARIARowIndex]):
(-[WebAccessibilityObjectWrapper accessibilityARIAColumnIndex]):

• accessibility/mac/WebAccessibilityObjectWrapperMac.mm:

(-[WebAccessibilityObjectWrapper additionalAccessibilityAttributeNames]):
(-[WebAccessibilityObjectWrapper accessibilityAttributeValue:]):

LayoutTests:

• accessibility/mac/AOM-number-properties-expected.txt: Added.
• accessibility/mac/AOM-number-properties.html: Added.

9:05 PM Changeset in webkit [225029] by timothy_horton@apple.com

• 3 edits in trunk/Source/WebKit

Rename some Network Capture debugging defines
​https://bugs.webkit.org/show_bug.cgi?id=179870

Reviewed by Darin Adler.

• NetworkProcess/capture/NetworkCaptureLogging.h:
• NetworkProcess/capture/NetworkCaptureManager.cpp:

(WebKit::NetworkCapture::Manager::findMatch):
(WebKit::NetworkCapture::Manager::fuzzyMatchURLs):
These shouldn't have WTF in their name - they have nothing to do with WTF.
These shouldn't use ENABLE(), since they're not features, just debugging macros.

7:48 PM Changeset in webkit [225028] by timothy_horton@apple.com

• 6 edits in trunk/Source

Fix typos in closing ENABLE() comments
​https://bugs.webkit.org/show_bug.cgi?id=179869

Unreviewed.

Source/JavaScriptCore:

• wasm/WasmMemory.h:
• wasm/WasmMemoryMode.h:

Source/WebCore:

• platform/mediastream/ios/AVAudioSessionCaptureDeviceManager.h:
• platform/mediastream/mac/CoreAudioCaptureDeviceManager.h:

7:42 PM Changeset in webkit [225027] by mjs@apple.com

• 11 edits
  2 adds
  9 deletes in trunk

Remove TEC support and all TEC-only encodings except EUC-TW (which now uses ICU)
​https://bugs.webkit.org/show_bug.cgi?id=179582

Reviewed by Darin Adler.

Source/WebCore:

Already covered by fast/encoding/legacy-tec-encodings.html

• platform/text/TextCodecICU.cpp: Add support for EUC-TW.

Remove all vestiges of TEC text codec and its related autogeneration scripts.

• DerivedSources.make:
• PlatformMac.cmake:
• SourcesMac.txt:
• WebCore.order:
• WebCore.xcodeproj/project.pbxproj:
• platform/ThreadGlobalData.cpp:

(WebCore::ThreadGlobalData::ThreadGlobalData): No more cached TEC decoder.
(WebCore::ThreadGlobalData::destroy): ditto

• platform/ThreadGlobalData.h:

(WebCore::ThreadGlobalData::ThreadGlobalData::cachedConverterTEC): Deleted.

• platform/text/TextEncodingRegistry.cpp:

(WebCore::extendTextCodecMaps): Don't add TEC decoders on MAc.

• platform/text/mac/CharsetData.h: Removed.
• platform/text/mac/TextCodecMac.cpp: Removed.
• platform/text/mac/TextCodecMac.h: Removed.
• platform/text/mac/character-sets.txt: Removed.
• platform/text/mac/ios-encodings.txt: Removed.
• platform/text/mac/mac-encodings.txt: Removed.
• platform/text/mac/make-charset-table.pl: Removed.

LayoutTests:

• fast/encoding/legacy-tec-encodings.html: Added. Verify that we

no longer support these encodings.

• fast/encoding/legacy-tec-encodings-expected.txt: Added.
• platform/mac/fast/encoding/xnextstep-decoding.html: Removed. We no longer support this encoding.
• platform/mac/fast/encoding/xnextstep-decoding-expected.txt: Removed.

5:55 PM Changeset in webkit [225026] by Simon Fraser

• 42 edits in trunk/Source/WebCore

Mechanical cleanup of FE* files
​https://bugs.webkit.org/show_bug.cgi?id=179868

Reviewed by Wenson Hsieh.

Remove unused dump() functions.
Make overridden member functions in derived classes private.
Make simple getters inline.

Move common FESpecularLighting and FEDiffuseLighting functions into the
FELighting base class.

• platform/graphics/filters/FEBlend.cpp:

(WebCore::FEBlend::blendMode const): Deleted.
(WebCore::FEBlend::dump): Deleted.

• platform/graphics/filters/FEBlend.h:

(WebCore::FEBlend::blendMode const):

• platform/graphics/filters/FEColorMatrix.cpp:

(WebCore::FEColorMatrix::type const): Deleted.
(WebCore::FEColorMatrix::values const): Deleted.
(WebCore::FEColorMatrix::dump): Deleted.

• platform/graphics/filters/FEColorMatrix.h:

(WebCore::FEColorMatrix::type const):
(WebCore::FEColorMatrix::values const):

• platform/graphics/filters/FEComponentTransfer.cpp:

(WebCore::FEComponentTransfer::redFunction const): Deleted.
(WebCore::FEComponentTransfer::greenFunction const): Deleted.
(WebCore::FEComponentTransfer::blueFunction const): Deleted.
(WebCore::FEComponentTransfer::alphaFunction const): Deleted.
(WebCore::FEComponentTransfer::dump): Deleted.

• platform/graphics/filters/FEComponentTransfer.h:

(WebCore::FEComponentTransfer::redFunction const):
(WebCore::FEComponentTransfer::greenFunction const):
(WebCore::FEComponentTransfer::blueFunction const):
(WebCore::FEComponentTransfer::alphaFunction const):

• platform/graphics/filters/FEComposite.cpp:

(WebCore::FEComposite::operation const): Deleted.
(WebCore::FEComposite::k1 const): Deleted.
(WebCore::FEComposite::k2 const): Deleted.
(WebCore::FEComposite::k3 const): Deleted.
(WebCore::FEComposite::k4 const): Deleted.
(WebCore::FEComposite::dump): Deleted.

• platform/graphics/filters/FEComposite.h:

(WebCore::FEComposite::operation const):
(WebCore::FEComposite::k1 const):
(WebCore::FEComposite::k2 const):
(WebCore::FEComposite::k3 const):
(WebCore::FEComposite::k4 const):

• platform/graphics/filters/FEConvolveMatrix.cpp:

(WebCore::FEConvolveMatrix::kernelSize const): Deleted.
(WebCore::FEConvolveMatrix::kernel const): Deleted.
(WebCore::FEConvolveMatrix::divisor const): Deleted.
(WebCore::FEConvolveMatrix::bias const): Deleted.
(WebCore::FEConvolveMatrix::targetOffset const): Deleted.
(WebCore::FEConvolveMatrix::edgeMode const): Deleted.
(WebCore::FEConvolveMatrix::kernelUnitLength const): Deleted.
(WebCore::FEConvolveMatrix::preserveAlpha const): Deleted.
(WebCore::FEConvolveMatrix::dump): Deleted.

• platform/graphics/filters/FEConvolveMatrix.h:

(WebCore::FEConvolveMatrix::kernelSize const):
(WebCore::FEConvolveMatrix::kernel const):
(WebCore::FEConvolveMatrix::divisor const):
(WebCore::FEConvolveMatrix::bias const):
(WebCore::FEConvolveMatrix::targetOffset const):
(WebCore::FEConvolveMatrix::edgeMode const):
(WebCore::FEConvolveMatrix::kernelUnitLength const):
(WebCore::FEConvolveMatrix::preserveAlpha const):

• platform/graphics/filters/FEDiffuseLighting.cpp:

(WebCore::FEDiffuseLighting::lightingColor const): Deleted.
(WebCore::FEDiffuseLighting::setLightingColor): Deleted.
(WebCore::FEDiffuseLighting::surfaceScale const): Deleted.
(WebCore::FEDiffuseLighting::setSurfaceScale): Deleted.
(WebCore::FEDiffuseLighting::diffuseConstant const): Deleted.
(WebCore::FEDiffuseLighting::kernelUnitLengthX const): Deleted.
(WebCore::FEDiffuseLighting::setKernelUnitLengthX): Deleted.
(WebCore::FEDiffuseLighting::kernelUnitLengthY const): Deleted.
(WebCore::FEDiffuseLighting::setKernelUnitLengthY): Deleted.
(WebCore::FEDiffuseLighting::lightSource const): Deleted.
(WebCore::FEDiffuseLighting::dump): Deleted.

• platform/graphics/filters/FEDiffuseLighting.h:

(WebCore::FEDiffuseLighting::diffuseConstant const):

• platform/graphics/filters/FEDisplacementMap.cpp:

(WebCore::FEDisplacementMap::xChannelSelector const): Deleted.
(WebCore::FEDisplacementMap::yChannelSelector const): Deleted.
(WebCore::FEDisplacementMap::scale const): Deleted.
(WebCore::FEDisplacementMap::dump): Deleted.

• platform/graphics/filters/FEDisplacementMap.h:

(WebCore::FEDisplacementMap::xChannelSelector const):
(WebCore::FEDisplacementMap::yChannelSelector const):
(WebCore::FEDisplacementMap::scale const):

• platform/graphics/filters/FEDropShadow.cpp:

(WebCore::FEDropShadow::dump): Deleted.

• platform/graphics/filters/FEDropShadow.h:
• platform/graphics/filters/FEFlood.cpp:

(WebCore::FEFlood::floodColor const): Deleted.
(WebCore::FEFlood::floodOpacity const): Deleted.
(WebCore::FEFlood::dump): Deleted.

• platform/graphics/filters/FEFlood.h:

(WebCore::FEFlood::floodColor const):
(WebCore::FEFlood::floodOpacity const):

• platform/graphics/filters/FEGaussianBlur.cpp:

(WebCore::FEGaussianBlur::stdDeviationX const): Deleted.
(WebCore::FEGaussianBlur::stdDeviationY const): Deleted.
(WebCore::FEGaussianBlur::edgeMode const): Deleted.
(WebCore::FEGaussianBlur::dump): Deleted.

• platform/graphics/filters/FEGaussianBlur.h:

(WebCore::FEGaussianBlur::stdDeviationX const):
(WebCore::FEGaussianBlur::stdDeviationY const):
(WebCore::FEGaussianBlur::edgeMode const):

• platform/graphics/filters/FELighting.cpp:

(WebCore::FELighting::setSurfaceScale):
(WebCore::FELighting::setLightingColor):
(WebCore::FELighting::setKernelUnitLengthX):
(WebCore::FELighting::setKernelUnitLengthY):

• platform/graphics/filters/FELighting.h:

(WebCore::FELighting::surfaceScale const):
(WebCore::FELighting::lightingColor const):
(WebCore::FELighting::kernelUnitLengthX const):
(WebCore::FELighting::kernelUnitLengthY const):
(WebCore::FELighting::lightSource const):

• platform/graphics/filters/FEMerge.cpp:

(WebCore::FEMerge::dump): Deleted.

• platform/graphics/filters/FEMerge.h:
• platform/graphics/filters/FEMorphology.cpp:

(WebCore::FEMorphology::dump): Deleted.

• platform/graphics/filters/FEMorphology.h:
• platform/graphics/filters/FEOffset.cpp:

(WebCore::FEOffset::dx const): Deleted.
(WebCore::FEOffset::dy const): Deleted.
(WebCore::FEOffset::dump): Deleted.

• platform/graphics/filters/FEOffset.h:

(WebCore::FEOffset::dx const):
(WebCore::FEOffset::dy const):

• platform/graphics/filters/FESpecularLighting.cpp:

(WebCore::FESpecularLighting::lightingColor const): Deleted.
(WebCore::FESpecularLighting::setLightingColor): Deleted.
(WebCore::FESpecularLighting::surfaceScale const): Deleted.
(WebCore::FESpecularLighting::setSurfaceScale): Deleted.
(WebCore::FESpecularLighting::specularConstant const): Deleted.
(WebCore::FESpecularLighting::specularExponent const): Deleted.
(WebCore::FESpecularLighting::kernelUnitLengthX const): Deleted.
(WebCore::FESpecularLighting::setKernelUnitLengthX): Deleted.
(WebCore::FESpecularLighting::kernelUnitLengthY const): Deleted.
(WebCore::FESpecularLighting::setKernelUnitLengthY): Deleted.
(WebCore::FESpecularLighting::lightSource const): Deleted.
(WebCore::FESpecularLighting::dump): Deleted.

• platform/graphics/filters/FESpecularLighting.h:

(WebCore::FESpecularLighting::specularConstant const):
(WebCore::FESpecularLighting::specularExponent const):

• platform/graphics/filters/FETile.cpp:

(WebCore::FETile::dump): Deleted.

• platform/graphics/filters/FETile.h:
• platform/graphics/filters/FETurbulence.cpp:

(WebCore::FETurbulence::dump): Deleted.

• platform/graphics/filters/FETurbulence.h:
• platform/graphics/filters/FilterEffect.h:
• platform/graphics/filters/SourceAlpha.cpp:

(WebCore::SourceAlpha::dump): Deleted.

• platform/graphics/filters/SourceAlpha.h:
• platform/graphics/filters/SourceGraphic.cpp:

(WebCore::SourceGraphic::dump): Deleted.

• platform/graphics/filters/SourceGraphic.h:
• svg/graphics/filters/SVGFEImage.cpp:

(WebCore::FEImage::dump): Deleted.

• svg/graphics/filters/SVGFEImage.h:

5:35 PM Changeset in webkit [225025] by Simon Fraser

• 2 edits in trunk/Source/WebCore

Attempt to fix Windows build failures seen in EWS.

Remove default constructor for ColorComponents, which was ambiguous with the
one that takes 4 values.

• platform/graphics/ColorUtilities.h:

4:48 PM Changeset in webkit [225024] by Simon Fraser

• 3 edits
  2 adds in trunk

Line of garbage pixels at the bottom of an feTurbulence sometimes
​https://bugs.webkit.org/show_bug.cgi?id=179866

Reviewed by Wenson Hsieh.
Source/WebCore:

The ParallelJobs logic was broken in that the sum of the computed job
heights was one too short sometimes. Fix and clean up the logic.

Test: svg/filters/feTurbulence-parallel-jobs.html

• platform/graphics/filters/FETurbulence.cpp:

(WebCore::FETurbulence::platformApplySoftware):

LayoutTests:

• svg/filters/feTurbulence-parallel-jobs-expected.html: Added.
• svg/filters/feTurbulence-parallel-jobs.html: Added.

2:50 PM Changeset in webkit [225023] by Simon Fraser

• 16 edits in trunk/Source/WebCore

Use #pragma once in FE* files.

Rubber-stamped by Dan Bates.

• platform/graphics/filters/FEBlend.h:
• platform/graphics/filters/FEColorMatrix.h:
• platform/graphics/filters/FEComponentTransfer.h:
• platform/graphics/filters/FEComposite.h:
• platform/graphics/filters/FEConvolveMatrix.h:
• platform/graphics/filters/FEDiffuseLighting.h:
• platform/graphics/filters/FEDisplacementMap.h:
• platform/graphics/filters/FEDropShadow.h:
• platform/graphics/filters/FEFlood.h:
• platform/graphics/filters/FEGaussianBlur.h:
• platform/graphics/filters/FELighting.h:
• platform/graphics/filters/FEMerge.h:
• platform/graphics/filters/FEOffset.h:
• platform/graphics/filters/FESpecularLighting.h:
• platform/graphics/filters/FETile.h:

2:44 PM Changeset in webkit [225022] by Simon Fraser

• 2 edits in trunk/Source/WebCore

Remove a TimingScope that I left in by mistake.

• platform/graphics/filters/FETurbulence.cpp:

(WebCore::FETurbulence::platformApplySoftware):

2:40 PM Changeset in webkit [225021] by Simon Fraser

• 3 edits in trunk/Source/WebCore

FETurbulence: round the result according to the spec
​https://bugs.webkit.org/show_bug.cgi?id=179865

Reviewed by Zalan Bujtas.

The spec explicitly says that the floating point results are multiplied by 255 then
clamped between 0 and 255, so do this instead of using lroundf().

This is also faster (about 10%).

• platform/graphics/ColorUtilities.h:

(WebCore::ColorComponents::ColorComponents):

• platform/graphics/filters/FETurbulence.cpp:

(WebCore::toColorComponents):
(WebCore::FETurbulence::calculateTurbulenceValueForPoint const):

2:06 PM Changeset in webkit [225020] by Simon Fraser

• 25 edits in trunk

More FETurbulence cleanup
​https://bugs.webkit.org/show_bug.cgi?id=179863

Reviewed by Zalan Bujtas.

Source/WebCore:

Hoist computation of initial StitchData up to be done once per filter,
not once per pixel. Passing initial StitchData by value to calculateTurbulenceValueForPoint()
ensures that each pixel gets the initial state.

Also, adjusted baseFrequencyX and baseFrequencyY can be computed just once at the start,
and passed through via PaintingData.

Change enum TurbulenceType to be an enum class (requiring casts in a couple of places)
and undo the capitalization of the values.

Fix spelling of TURBULANCE -> TURBULENCE in test output.

• platform/graphics/filters/FETurbulence.cpp:

(WebCore::FETurbulence::computeStitching const):
(WebCore::FETurbulence::calculateTurbulenceValueForPoint const):
(WebCore::FETurbulence::fillRegion const):
(WebCore::FETurbulence::fillRegionWorker):
(WebCore::FETurbulence::platformApplySoftware):
(WebCore::operator<<):

• platform/graphics/filters/FETurbulence.h:

(WebCore::FETurbulence::PaintingData::PaintingData):
(WebCore::FETurbulence::StitchData::StitchData): Deleted.

• svg/SVGAnimatedEnumeration.cpp:

(WebCore::enumerationValueForTargetAttribute):

• svg/SVGFETurbulenceElement.cpp:

(WebCore::SVGFETurbulenceElement::SVGFETurbulenceElement):
(WebCore::SVGFETurbulenceElement::parseAttribute):

• svg/SVGFETurbulenceElement.h:

(WebCore::SVGPropertyTraits<TurbulenceType>::highestEnumValue):
(WebCore::SVGPropertyTraits<TurbulenceType>::toString):
(WebCore::SVGPropertyTraits<TurbulenceType>::fromString):

LayoutTests:

Fix spelling of TURBULANCE -> TURBULENCE.

• platform/gtk/svg/W3C-SVG-1.1-SE/types-dom-04-b-expected.txt:
• platform/gtk/svg/W3C-SVG-1.1/filters-turb-01-f-expected.txt:
• platform/gtk/svg/W3C-SVG-1.1/filters-turb-02-f-expected.txt:
• platform/ios/svg/W3C-SVG-1.1-SE/types-dom-04-b-expected.txt:
• platform/ios/svg/W3C-SVG-1.1/filters-turb-01-f-expected.txt:
• platform/ios/svg/W3C-SVG-1.1/filters-turb-02-f-expected.txt:
• platform/mac/svg/W3C-SVG-1.1-SE/types-dom-04-b-expected.txt:
• platform/mac/svg/W3C-SVG-1.1/filters-turb-01-f-expected.txt:
• platform/mac/svg/W3C-SVG-1.1/filters-turb-02-f-expected.txt:
• platform/win/svg/W3C-SVG-1.1-SE/types-dom-04-b-expected.txt:
• platform/win/svg/W3C-SVG-1.1/filters-turb-01-f-expected.txt:
• platform/win/svg/W3C-SVG-1.1/filters-turb-02-f-expected.txt:
• platform/wpe/svg/W3C-SVG-1.1-SE/types-dom-04-b-expected.txt:
• platform/wpe/svg/W3C-SVG-1.1/filters-turb-01-f-expected.txt:
• platform/wpe/svg/W3C-SVG-1.1/filters-turb-02-f-expected.txt:
• svg/W3C-SVG-1.1-SE/types-dom-04-b-expected.txt:
• svg/W3C-SVG-1.1/filters-turb-01-f-expected.txt:
• svg/W3C-SVG-1.1/filters-turb-02-f-expected.txt:

1:59 PM Changeset in webkit [225019] by commit-queue@webkit.org

• 6 edits in trunk/Source/WebInspectorUI

Web Inspector: Update the Trash / Clear icon
​https://bugs.webkit.org/show_bug.cgi?id=179850

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2017-11-18
Reviewed by Matt Baker.

• UserInterface/Images/NavigationItemTrash.svg:

Update the icon.

• UserInterface/Views/ProbeDetailsSidebarPanel.css:

(.sidebar > .panel.probes > .navigation-bar .item.clear-samples):

• UserInterface/Views/ProbeSetDetailsSection.js:

(WI.ProbeSetDetailsSection):

• UserInterface/Views/ScopeChainDetailsSidebarPanel.css:

(.scope-chain .navigation-bar .item.clear-watch-expressions):

• UserInterface/Views/ScopeChainDetailsSidebarPanel.js:

(WI.ScopeChainDetailsSidebarPanel):
Resize to 15x15 and move it down a pixel.

12:37 PM Changeset in webkit [225018] by Simon Fraser

• 5 edits
  2 adds in trunk

feTurbulence with stitchTiles is broken
​https://bugs.webkit.org/show_bug.cgi?id=179862

Reviewed by Zalan Bujtas.

Source/WebCore:

The "stitchTiles" logic was broken, and not equivalent to the spec sample code,
because it didn't compute and wrap the bx1 and by1 equivalents separately from
bx0 and by0.

Annotated the code with the equivalent sample code from the spec for ease of
comparison.

Also make some functions const.

Test: svg/filters/feTurbulence-stitchTiles.html

• platform/graphics/filters/FETurbulence.cpp:

(WebCore::FETurbulence::noise2D const):
(WebCore::FETurbulence::calculateTurbulenceValueForPoint const):
(WebCore::FETurbulence::fillRegion const):
(WebCore::checkNoise): Deleted.
(WebCore::FETurbulence::noise2D): Deleted.
(WebCore::FETurbulence::calculateTurbulenceValueForPoint): Deleted.
(WebCore::FETurbulence::fillRegion): Deleted.

• platform/graphics/filters/FETurbulence.h:
• platform/graphics/filters/FilterEffect.h:

(WebCore::FilterEffect::filter const):

LayoutTests:

Ref test that masks out an empty area of the filter and compares with a green rectangle.

• svg/filters/feTurbulence-stitchTiles-expected.html: Added.
• svg/filters/feTurbulence-stitchTiles.html: Added.

9:25 AM Changeset in webkit [225017] by Antti Koivisto

• 1 edit
  2 adds in trunk/LayoutTests

Add test for a multicolumn render tree update issue
​https://bugs.webkit.org/show_bug.cgi?id=179860

Reviewed by Zalan Bujtas.

• fast/multicol/column-span-range-crash-expected.txt: Added.
• fast/multicol/column-span-range-crash.html: Added.

7:17 AM Changeset in webkit [225016] by Jonathan Bedard

• 5 edits
  2 adds in trunk/Tools

webkitpy: Better name-version mapping (Part 1)
​https://bugs.webkit.org/show_bug.cgi?id=179621
<rdar://problem/35589585>

Reviewed by David Kilzer.

Mapping version numbers to version names should occur in a central location.
This has a few advantages. First, it makes iterating through versions easier.
Second, it allows for apple_additions to define an additional set of name
mappings. Lastly, it will allow, in a future patch, for us to track version
instead of version name, only mapping version to version name when required.

• Scripts/webkitpy/common/system/platforminfo.py:

(PlatformInfo.init):
(PlatformInfo._determine_os_name): Use VersionNameMap instead of custom functions
mapping version to name.
(PlatformInfo._determine_linux_version): Deleted.
(PlatformInfo._determine_mac_version): Deleted.
(PlatformInfo._determine_win_version): Deleted.

• Scripts/webkitpy/common/system/platforminfo_unittest.py:

(TestPlatformInfo.test_os_name_and_wrappers):
(TestPlatformInfo.test_os_version):
(TestPlatformInfo.test_display_name):
(TestPlatformInfo.test_total_bytes_memory):

• Scripts/webkitpy/common/version.py:

(Version.contained_in): Add partial version mapping.

• Scripts/webkitpy/common/version_name_map.py: Added.

(VersionNameMap): Holds a mapping of version name to version object.
(VersionNameMap.map): Don't re-create VersionNameMap every time.
(VersionNameMap.init): Initialize mapping, use platform to
define the default system platform.
(VersionNameMap._automap_to_major_version): Some operating systems, such
as iOS, have a naming scheme based on their major version and os name.
Automatically generate such mappings.
(VersionNameMap.to_name): Given a version object, platform name and
table, find the closest matching version name.
(VersionNameMap.strip_name_formatting): Remove spaces and extract the major version,
if a version string is included in the name.
(VersionNameMap.from_name): Return an os name and version given a version name.

• Scripts/webkitpy/common/version_name_map_unittest.py: Added.

(VersionMapTestCase):
(VersionMapTestCase.test_default_system_platform):
(VersionMapTestCase.test_mac_version_by_name):
(VersionMapTestCase.test_ios_version_by_name):
(VersionMapTestCase.test_mac_name_by_version):
(VersionMapTestCase.test_ios_name_by_version):

• Scripts/webkitpy/common/version_unittest.py:

(VersionTestCase.test_contained_in):

6:09 AM Changeset in webkit [225015] by Yusuke Suzuki

• 3 edits in trunk/Source/WTF

[WTF] Remove CPU(HPPA) in StackBounds by using runtime stack direction test
​https://bugs.webkit.org/show_bug.cgi?id=179859

Reviewed by JF Bastien.

Currently, we know that CPU(HPPA)'s stack direction is upward! But listing
CPU architectures here is not a scalable way.

Instead, we use runtime stack direction test. By doing so, we can handle
such a strange architecture without listing the CPU to Platform.h. This paves
the way to dropping many CPUs in Platform.h by replacing them with CPU(UNKNOWN)[1].

We also fix StackBounds::isGrowingDownward().

[1]: ​https://bugs.webkit.org/show_bug.cgi?id=179243

• wtf/StackBounds.cpp:

(WTF::StackBounds::stackDirection):
(WTF::testStackDirection2):
(WTF::testStackDirection):
(WTF::StackBounds::newThreadStackBounds):
(WTF::StackBounds::currentThreadStackBoundsInternal):

• wtf/StackBounds.h:

(WTF::StackBounds::isGrowingDownward const):

3:46 AM Changeset in webkit [225014] by Antti Koivisto

• 3 edits
  2 adds in trunk

Source/WebCore:
REGRESSION (r220646): REGRESSION (r220646): RenderTreePosition::computeNextSibling hits assertion with certain first-letter mutations
​https://bugs.webkit.org/show_bug.cgi?id=179855
<rdar://problem/35464071>

Reviewed by Zalan Bujtas.

Test: fast/css-generated-content/first-letter-update-crash.html

• style/RenderTreeUpdaterFirstLetter.cpp:

(WebCore::styleForFirstLetter):
(WebCore::updateFirstLetterStyle):
(WebCore::createFirstLetterRenderer):

Tighten these to take RenderBlock.

(WebCore::supportsFirstLetter):

Test exact conditions where first letter renderer is allowed for fast rejection.

(WebCore::RenderTreeUpdater::FirstLetter::update):

If update was called on a block that doesn't support first letter, getFirstLetter could in
some cases return an ancestor of the block and we would end up mutating a first letter renderer
that wasn't current block's descendant. This violates assumptions of the RenderTreeUpdater
and could cause cached render tree position to become invalid.

Fix by ensuring we are always updating first letter for the current block only.

LayoutTests:

REGRESSION (r220646): ASSERTION FAILED: skipAssert

nextSiblingRenderer(node) == m_nextSibling

​https://bugs.webkit.org/show_bug.cgi?id=179855
<rdar://problem/35464071>

Reviewed by Zalan Bujtas.

• fast/css-generated-content/first-letter-update-crash-expected.txt: Added.
• fast/css-generated-content/first-letter-update-crash.html: Added.