Timeline

Nov 25, 2017:

8:59 AM Changeset in webkit [225145] by Alan Bujtas

• 3 edits in trunk/Source/WebCore

Make RenderSnapshottedPlugIn ISO allocated
​https://bugs.webkit.org/show_bug.cgi?id=180010
<rdar://problem/35671977>

Reviewed by David Kilzer.

RenderEmbeddedObject, the base class is ISO allocated since r224537.

• rendering/RenderSnapshottedPlugIn.cpp:
• rendering/RenderSnapshottedPlugIn.h:

Nov 24, 2017:

6:44 PM Changeset in webkit [225144] by Darin Adler

• 14 edits in trunk/Source

Fix some minor problems in the StringImpl header
​https://bugs.webkit.org/show_bug.cgi?id=160630

Reviewed by Brent Fulgham.

Source/JavaScriptCore:

• inspector/ContentSearchUtilities.cpp: Removed a lot of unneeded explicit

Yarr namespacing since we use "using namespace" in this file.

Source/WebCore:

• html/HTMLOptionElement.cpp:

(WebCore::HTMLOptionElement::text): Use stripLeadingAndTrailingHTMLSpaces
instead of stripWhiteSpace(isHTMLSpace).
(WebCore::HTMLOptionElement::value): Ditto.
(WebCore::HTMLOptionElement::label): Ditto.
(WebCore::HTMLOptionElement::displayLabel): Ditto.

• loader/FrameLoader.cpp:

(WebCore::FrameLoader::didBeginDocument): Use stripLeadingAndTrailingHTMLSpaces
instead of calling the general purpose one and passing isHTMLSpace.

• platform/network/HTTPParsers.h:

(WebCore::stripLeadingAndTrailingHTTPSpaces): Updated to use the
new name, stripLeadingAndTrailingCharacters.

Source/WTF:

• wtf/text/AtomicString.h: Update since CharacterMatchFunctionPtr is now

CodeUnitMatchFunction.

• wtf/text/StringCommon.h: Added CodeUnitMatchFunction, which replaces

CharacterMatchFunctionPtr.

• wtf/text/StringImpl.cpp:

(WTF::StringImpl::stripMatchedCharacters): Changed template argument name
to CodeUnitPredicate to help make it clear this works on code units, not
code points.
(WTF::UCharPredicate): Deleted.
(WTF::SpaceOrNewlinePredicate): Deleted.
(WTF::StringImpl::stripWhiteSpace): Removed unneeded use of predicate class to
turn a function into a functor; functions already work fine as functors without
a class wrapping them.
(WTF::StringImpl::stripLeadingAndTrailingCharacters): Ditto. Also renamed
from stripWhiteSpace, since it strips arbitrary characters.
(WTF::StringImpl::removeCharacters): Fixed various minor style issues and
updated to new type name.
(WTF::StringImpl::simplifyMatchedCharactersToSpace): Ditto.
(WTF::StringImpl::simplifyWhiteSpace): More of the same.
(WTF::StringImpl::find): Ditto.

• wtf/text/StringImpl.h: Removed unneeded include of uchar.h, since it's

included by StringCommon.h. Removed =CharacterMatchFunctionPtr and
IsWhiteSpaceFunctionPtr, both replaced by CodeUnitMatchFunction. Fixed
a mistake recently introduced in isSpaceOrNewline, which was unnecessarily,
inefficiently using ICU for non-ASCII Latin-1 characters.

• wtf/text/StringView.h: Use CodeUnitMatchFunction instead of CharacterMatchFunction.

• wtf/text/WTFString.cpp:

(WTF::String::stripLeadingAndTrailingCharacters): Updated function name and type.
(WTF::String::simplifyWhiteSpace): Updated type.
(WTF::String::removeCharacters): Updated type.

• wtf/text/WTFString.h: Ditto.

5:49 PM Changeset in webkit [225143] by Darin Adler

• 2 edits in trunk/Tools

• TestWebKitAPI/Tests/WTF/OptionSet.cpp:

(TestWebKitAPI::TEST): Added a test for OptionSet operator|.

5:09 PM Changeset in webkit [225142] by Darin Adler

• 34 edits in trunk/Source

Fix dictionary leak in lookup, convert FindOptions to OptionSet, tweak code style nearby
​https://bugs.webkit.org/show_bug.cgi?id=179981

Reviewed by Sam Weinig.

Source/WebCore:

• accessibility/AXObjectCache.cpp:

(WebCore::AXObjectCache::rangeMatchesTextNearRange): Pass { } instead of 0.

• accessibility/AccessibilityObject.cpp:

(WebCore::AccessibilityObject::rangeOfStringClosestToRangeInDirection const): Use { }
instead of | to construct value.

• editing/Editor.cpp:

(WebCore::Editor::findString): Use contains instead of & to test an option.
(WebCore::Editor::rangeOfString): Ditto.
(WebCore::Editor::countMatchesForText): Ditto.

• editing/EditorCommand.cpp:

(WebCore::executeFindString): Use { } instead of | to construct value.

• editing/FindOptions.h: Use OptionSet for type.
• editing/TextIterator.cpp:

(WebCore::SearchBuffer::SearchBuffer): Use contains instead of &. Also use -= instead
of &= coupled with ~ to remove a flag.
(WebCore::SearchBuffer::isWordEndMatch const): Ditto.
(WebCore::SearchBuffer::isWordStartMatch const): Ditto.
(WebCore::SearchBuffer::search): Ditto.
(WebCore::findIteratorOptions): Ditto.
(WebCore::findClosestPlainText): Ditto.
(WebCore::findPlainText): Ditto.

• editing/mac/DictionaryLookup.h: Changed optional dictionary out arguments to

RetainPtr<NSDictionary>. Before, they were returning a retained object, but callers
did not seem to realize that.

• editing/mac/DictionaryLookup.mm:

(WebCore::tokenRange): Added helper. Takes care of doing adoptNS on the options
dictionary, and also handles the Objective-C exception possibility cleanly. Also
fixed the exception case to return NSNotFound instead of a zero-length range at
the location we are searching, which is what the code expects.
(WebCore::DictionaryLookup::rangeForSelection): Refactored to use the tokenRange
helper function, and also to do much less work when the options pointer is null.
(WebCore::DictionaryLookup::rangeAtHitTestResult): Use the tokenRange helper
function and also use auto a bunch to tighten up the code a bit.
(WebCore::DictionaryLookup::stringForPDFSelection): Ditto.

• page/DOMWindow.cpp:

(WebCore::DOMWindow::find const): Use |= instead of | to build find options.

• page/Page.cpp:

(WebCore::Page::findString): Use contains instead of & and also - instead of
& combined with ~.
(WebCore::Page::findStringMatchingRanges): Ditto.
(WebCore::Page::rangeOfString): Ditto.

• page/mac/EventHandlerMac.mm:

(WebCore::EventHandler::selectClosestWordFromHitTestResultBasedOnLookup):
Pass nullptr to indicate we don't need the options dictionary. The code before
was passing a pointer to a null, which meant we would do the work to get the
options dictionary, not use it, and also leak it.

• testing/Internals.cpp:

(WebCore::Internals::rangeOfStringNearLocation): Pass { } instead of 0.
(WebCore::Internals::rangeForDictionaryLookupAtLocation): Pass nullptr to
indicate we don't need the options dictionary as above.
(WebCore::parseFindOptions): Initialize options without an explicit 0, since
an OptionSet starts out empty rather than uninitialized.

Source/WebKit:

• WebProcess/Plugins/PDF/PDFPlugin.h: Use some references instead of pointers. Made more

things final and private. Changed functions with multiple return values to use tuples
instead of out arguments for clarity, especially because some were using pointers and it
was ambiguous whether the pointers could be nullptr. Tweaked formatting. Moved initialization
of data members into the class definition.

• WebProcess/Plugins/PDF/PDFPlugin.mm:

(WebKit::PDFPlugin::create): Take a reference.
(WebKit::PDFPlugin::PDFPlugin): Ditto. Also moved some initialization to the class definition.
(WebKit::PDFPlugin::countFindMatches): Added comment about ignored maxMatchCount argument.
(WebKit::PDFPlugin::findString): Use contains instead of & to check bits in options.
Simplified slightly confusing match count code that was doing some unnecessary comparisons
with the maximum match count. Use auto a bit.
(WebKit::coreCursor): Renamed from pdfLayerControllerCursorTypeToCursor since this is C++
and overloading works based on the argument type.
(WebKit::PDFPlugin::notifyCursorChanged): Updated for name change.
(WebKit::PDFPlugin::lookupTextAtLocation const): Return a tuple instead of using two out
arguments and use a RetainPtr so we don't leak the options dictionary.

• WebProcess/Plugins/PluginProxy.h: Removed unneeded include of FindOptions.h.

• WebProcess/WebCoreSupport/mac/WebContextMenuClientMac.mm:

(WebKit::WebContextMenuClient::lookUpInDictionary): Pass a reference.

• WebProcess/WebPage/FindController.cpp:

(WebKit::core): Use |= instead of | to build up a FindOptions.
(WebKit::FindController::FindController): Initialize data members in the class definition.
(WebKit::pluginViewForFrame): Deleted. Callers now use WebPage::pluginViewForFrame.
(WebKit::FindController::updateFindUIAfterPageScroll): Added a FIXME about some peculiar code.
(WebKit::FindController::findString): Use |= rather than | to add in an option.
(WebKit::FindController::hideFindUI): Use { } rather than 0 for no options.

• WebProcess/WebPage/FindController.h: Moved initialization to the header. Exported the core

function that converts WebKit::FindOptions to WebCore::FindOptions.

• WebProcess/WebPage/WebFrame.cpp:

(WebKit::WebFrame::handlesPageScaleGesture const): Use WebPage::pluginViewForFrame.
(WebKit::WebFrame::requiresUnifiedScaleFactor const): Use WebPage::pluginViewForFrame.

• WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::createPlugin): Removed unneeded local variable and UNUSED_PARAM.
(WebKit::WebPage::focusedPluginViewForFrame): Use pluginViewForFrame.
(WebKit::WebPage::pluginViewForFrame): Added a null check since this takes a pointer.
Use is/downcast insteadof more ad hoc coding style.
(WebKit::WebPage::findStringFromInjectedBundle): Call core to convert WebKit::FindOptions
to WebCore::FindOptions. Before, this was accidentally relying on the bits from the two
enumrations matching! The stricter type checking of OptionSet helps us catch mistakes
like this.

• WebProcess/WebPage/WebPage.h: Updated for the above. Also flattened out nested #if

statements, made forward declarations unconditional, and re-sorted them. Changed the
Mac-specific lookupTextAtLocation to return a tuple (see below).

• WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::performDictionaryLookupForSelection): Take a reference instead of a pointer.
(WebKit::WebPage::performDictionaryLookupForRange): Ditto.
(WebKit::rangeNearPositionMatchesText): Use { } rather than 0 for no options.

• WebProcess/WebPage/mac/WebPageMac.mm:

(WebKit::WebPage::performDictionaryLookupAtLocation): Use RetainPtr<NSDictionary> to fix
code that used to leak.
(WebKit::WebPage::performDictionaryLookupForSelection): Ditto.
(WebKit::WebPage::performDictionaryLookupOfCurrentSelection): Use a reference.
(WebKit::WebPage::dictionaryPopupInfoForRange): Updated for changed argument types.
(WebKit::WebPage::dictionaryPopupInfoForSelectionInPDFPlugin): Ditto.
(WebKit::WebPage::performDictionaryLookupForRange): Ditto.
(WebKit::WebPage::performImmediateActionHitTestAtLocation): Updated to handle the
tuple result from the lookupTextAtLocation functions.
(WebKit::WebPage::lookupTextAtLocation): Changed to return a tuple and use RetainPtr
for the NSDictionary to help fix the leak.

Source/WebKitLegacy/mac:

• WebView/WebImmediateActionController.mm:

(-[WebImmediateActionController _animationControllerForText]): Use RetainPtr so we don't leak.

• WebView/WebView.mm:

(coreOptions): Use |= instead of | to build up FindOptions.

Source/WebKitLegacy/win:

• WebView.cpp:

(WebView::searchFor): Use |= instead of | to build FindOptions.
(WebView::markAllMatchesForText): Create FindOptions with |= instead of |.
(WebView::findString): Create FindOptions with |=; the old code just passed a
WebKit FindOptions through without converting to WebCore::FindOptions.

Source/WTF:

• wtf/OptionSet.h: Added some operators so it's easier to use | and - with individual

options from the set.

1:15 PM Changeset in webkit [225141] by Antti Koivisto

• 4 edits
  2 adds in trunk

Style resolution spin due to calc() values always comparing inequal (seen on arstechnica.com)
​https://bugs.webkit.org/show_bug.cgi?id=179982
<rdar://problem/35677991>

Reviewed by Darin Adler.

Source/WebCore:

Test: transitions/transition-with-calc-spin.html

Something like calc(100% - 10px) would compare inequal to itself. This causes the implicit animation engine think that
there is a new target value after style resolution and restart the transition. Starting the transition triggers another style
resolution on zero duration timer and so on.

• platform/CalculationValue.cpp:

(WebCore::operator==):

• platform/CalculationValue.h:

Deep compare the child vectors.

LayoutTests:

• transitions/transition-with-calc-spin-expected.txt: Added.
• transitions/transition-with-calc-spin.html: Added.

1:02 PM Changeset in webkit [225140] by mark.lam@apple.com

• 7 edits in trunk/Source/JavaScriptCore

Fix CLoop::sanitizeStack() bug where it was clearing part of the JS stack in use.
​https://bugs.webkit.org/show_bug.cgi?id=179936
<rdar://problem/35623998>

Reviewed by Saam Barati.

This issue was uncovered when we enabled --useDollarVM=true on the JSC tests.
See ​https://bugs.webkit.org/show_bug.cgi?id=179684.

Basically, in the case of the failing test we observed, op_tail_call_forward_arguments
was allocating stack space to stash arguments (to be forwarded) and new frame
info. The location of this new stash space happens to lie beyond the top of frame
of the tail call caller frame. After stashing the arguments, the code proceeded
to load the callee codeBlock. This triggered an allocation, which in turn,
triggered stack sanitization. The CLoop stack sanitizer was relying on
frame->topOfFrame() to tell it where the top of the used stack is. In this case,
that turned out to be inadequate. As a result, part of the stashed data was
zeroed out, and subsequently led to a crash.

This bug does not affect JIT builds (i.e. the ASM LLint) for 2 reasons:

1. JIT builds do stack sanitization in the LLInt code itself (different from the CLoop implementation), and the sanitizer there is aware of the true top of stack value (i.e. the stack pointer).
2. JIT builds don't use a parallel stack like the CLoop. The presence of the parallel stack is one condition necessary for reproducing this issue.

The fix is to make the CLoop record the stack pointer in CLoopStack::m_currentStackPointer
every time before it calls out to native C++ code. This also brings the CLoop's
behavior closer to hardware behavior where we can know where the stack pointer
is after calling from JS back into native C++ code, which makes it easier to
reason about correctness.

Also simplified the various stack boundary calculations (removed the +1 and -1
adjustments). The CLoopStack bounds are now:

reservationTop(): the lowest reserved address that can be within stack bounds.
m_commitTop: the lowest address within stack bounds that has been committed.
lowAddress() aka m_end: the lowest stack address that JS code can use.
m_lastStackPointer: cache of the last m_currentStackPointer value.
m_currentStackPointer: the CLoopStack stack pointer value when calling from JS into C++ code.
highAddress(): the highest address just beyond the bounds of the stack.

Also deleted some unneeded code.

• interpreter/CLoopStack.cpp:

(JSC::CLoopStack::CLoopStack):
(JSC::CLoopStack::gatherConservativeRoots):
(JSC::CLoopStack::sanitizeStack):
(JSC::CLoopStack::setSoftReservedZoneSize):

• interpreter/CLoopStack.h:

(JSC::CLoopStack::setCurrentStackPointer):
(JSC::CLoopStack::lowAddress const):

(JSC::CLoopStack::baseOfStack const): Deleted.

• Not needed after we simplified the code and removed all the +1/-1 adjustments. Now, it has the exact same value as highAddress() and can be removed.

• interpreter/CLoopStackInlines.h:

(JSC::CLoopStack::ensureCapacityFor):
(JSC::CLoopStack::currentStackPointer):
(JSC::CLoopStack::setCLoopStackLimit):

(JSC::CLoopStack::topOfFrameFor): Deleted.

• Not needed.

(JSC::CLoopStack::topOfStack): Deleted.

• Supplanted by currentStackPointer().

(JSC::CLoopStack::shrink): Deleted.

• This is unused.

• llint/LowLevelInterpreter.cpp:

(JSC::CLoop::execute):

• Introduce a StackPointerScope to restore the original CLoopStack::m_currentStackPointer upon exitting the interpreter loop.

• offlineasm/cloop.rb:
• Added setting of CLoopStack::m_currentStackPointer at boundary points where we call from JS into C++ code.

• tools/VMInspector.h:
• Added some default argument values. These were being used while debugging this issue.

11:52 AM Changeset in webkit [225139] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebKitLegacy

[WinCairo] WebPreferences IDL not regenerating
​https://bugs.webkit.org/show_bug.cgi?id=179960

Patch by Fujii Hironori <Fujii Hironori> on 2017-11-24
Reviewed by Darin Adler.

WebKitLegacy shouldn't include the forwarding header of
WebKitLegacy itself.

• CMakeLists.txt: Add ${FORWARDING_HEADERS_DIR} and remove

${FORWARDING_HEADERS_DIR}/JavaScriptCore and
${FORWARDING_HEADERS_DIR}/WebKitLegacy from
WebKitLegacy_INCLUDE_DIRECTORIES.

11:27 AM Changeset in webkit [225138] by commit-queue@webkit.org

• 4 edits
  5 adds in trunk

Captions move when <video> with no controls is hovered
​https://bugs.webkit.org/show_bug.cgi?id=178600
<rdar://problem/35112309>

Patch by Antoine Quint <Antoine Quint> on 2017-11-24
Reviewed by Jer Noble.

Source/WebCore:

We should only reduce the text tracks container height to make room for the controls
bar when controls are enabled.

Tests: media/modern-media-controls/text-tracks/text-tracks-height-no-controls.html

media/modern-media-controls/text-tracks/text-tracks-height-with-controls.html

• Modules/modern-media-controls/controls/text-tracks.css:

(video[controls]::-webkit-media-text-track-container.visible-controls-bar):
(video::-webkit-media-text-track-container.visible-controls-bar): Deleted.

LayoutTests:

We add two tests to check that we correctly reduce the height of the text tracks container
when the controls bar should be visible, and that we do not reduce it when the controls are
not visible.

• media/modern-media-controls/text-tracks/text-tracks-height-no-controls-expected.txt: Added.
• media/modern-media-controls/text-tracks/text-tracks-height-no-controls.html: Added.
• media/modern-media-controls/text-tracks/text-tracks-height-with-controls-expected.txt: Added.
• media/modern-media-controls/text-tracks/text-tracks-height-with-controls.html: Added.
• platform/mac/TestExpectations:

9:26 AM Changeset in webkit [225137] by Simon Fraser

• 41 edits in trunk/Source/WebCore

Some FilterEffect cleanup and logging
​https://bugs.webkit.org/show_bug.cgi?id=179932

Reviewed by Darin Adler.

Rename the FilterEffect functions that get the result of the filter
to have "result" in the name.

Re-order FilterEffect member variables and use initializers. webkit.org/b/45614
is closed so remove the comment about things moving to RenderSVGResourceFilterPrimitive.

Add a virtual filterName() function for use by logging.

Add a Filters log channel. Log some stuff.

Rename RenderSVGResourceFilter::m_filter to m_rendererFilterDataMap.

• platform/Logging.h:
• platform/graphics/cpu/arm/filters/FEBlendNEON.h:

(WebCore::FEBlend::platformApplySoftware):

• platform/graphics/filters/FEBlend.cpp:

(WebCore::FEBlend::platformApplySoftware):

• platform/graphics/filters/FEBlend.h:
• platform/graphics/filters/FEColorMatrix.cpp:

(WebCore::FEColorMatrix::platformApplySoftware):

• platform/graphics/filters/FEColorMatrix.h:
• platform/graphics/filters/FEComponentTransfer.cpp:

(WebCore::FEComponentTransfer::platformApplySoftware):

• platform/graphics/filters/FEComponentTransfer.h:
• platform/graphics/filters/FEComposite.cpp:

(WebCore::FEComposite::platformApplySoftware):

• platform/graphics/filters/FEComposite.h:
• platform/graphics/filters/FEConvolveMatrix.cpp:

(WebCore::FEConvolveMatrix::platformApplySoftware):

• platform/graphics/filters/FEConvolveMatrix.h:
• platform/graphics/filters/FEDisplacementMap.cpp:

(WebCore::FEDisplacementMap::platformApplySoftware):

• platform/graphics/filters/FEDisplacementMap.h:
• platform/graphics/filters/FEDropShadow.cpp:

(WebCore::FEDropShadow::platformApplySoftware):

• platform/graphics/filters/FEDropShadow.h:
• platform/graphics/filters/FEFlood.h:
• platform/graphics/filters/FEGaussianBlur.cpp:

(WebCore::FEGaussianBlur::platformApplySoftware):

• platform/graphics/filters/FEGaussianBlur.h:
• platform/graphics/filters/FELighting.cpp:

(WebCore::FELighting::platformApplySoftware):

• platform/graphics/filters/FELighting.h:
• platform/graphics/filters/FEMerge.cpp:

(WebCore::FEMerge::platformApplySoftware):

• platform/graphics/filters/FEMerge.h:
• platform/graphics/filters/FEMorphology.cpp:

(WebCore::FEMorphology::platformApplyDegenerate):
(WebCore::FEMorphology::platformApplySoftware):

• platform/graphics/filters/FEMorphology.h:
• platform/graphics/filters/FEOffset.cpp:

(WebCore::FEOffset::platformApplySoftware):

• platform/graphics/filters/FEOffset.h:
• platform/graphics/filters/FETile.cpp:

(WebCore::FETile::platformApplySoftware):

• platform/graphics/filters/FETile.h:
• platform/graphics/filters/FETurbulence.cpp:

(WebCore::operator<<):

• platform/graphics/filters/FETurbulence.h:
• platform/graphics/filters/FilterEffect.cpp:

(WebCore::FilterEffect::FilterEffect):
(WebCore::FilterEffect::imageBufferResult):
(WebCore::FilterEffect::unmultipliedResult):
(WebCore::FilterEffect::premultipliedResult):
(WebCore::FilterEffect::copyImageBytes const): This can be const. It'a also crazy
to mark a large, slow function like this as 'inline'.
(WebCore::FilterEffect::copyUnmultipliedResult):
(WebCore::FilterEffect::copyPremultipliedResult):
(WebCore::FilterEffect::createImageBufferResult):
(WebCore::FilterEffect::createUnmultipliedImageResult):
(WebCore::FilterEffect::createPremultipliedImageResult):
(WebCore::FilterEffect::transformResultColorSpace):
(WebCore::FilterEffect::asImageBuffer): Deleted.
(WebCore::FilterEffect::asUnmultipliedImage): Deleted.
(WebCore::FilterEffect::asPremultipliedImage): Deleted.
(WebCore::FilterEffect::copyImageBytes): Deleted.
(WebCore::FilterEffect::copyUnmultipliedImage): Deleted.
(WebCore::FilterEffect::copyPremultipliedImage): Deleted.

• platform/graphics/filters/FilterEffect.h:
• platform/graphics/filters/SourceAlpha.cpp:

(WebCore::SourceAlpha::platformApplySoftware):

• platform/graphics/filters/SourceAlpha.h:
• platform/graphics/filters/SourceGraphic.h:
• rendering/FilterEffectRenderer.cpp:

(WebCore::FilterEffectRenderer::output const):

• rendering/svg/RenderSVGResourceFilter.cpp:

(WebCore::RenderSVGResourceFilter::removeAllClientsFromCache):
(WebCore::RenderSVGResourceFilter::removeClientFromCache):
(WebCore::RenderSVGResourceFilter::applyResource):
(WebCore::RenderSVGResourceFilter::postApplyResource):
(WebCore::RenderSVGResourceFilter::primitiveAttributeChanged):
(WebCore::RenderSVGResourceFilter::drawingRegion const):
(WebCore::operator<<):

• rendering/svg/RenderSVGResourceFilter.h:

(WebCore::FilterData::FilterData): Deleted.

• svg/graphics/filters/SVGFEImage.h:

7:36 AM Changeset in webkit [225136] by Ms2ger@igalia.com

• 4 edits
  1 delete in trunk/LayoutTests

LayoutTests/imported/w3c:
Stop importing css-shapes-1/test-plan/index.html.
​https://bugs.webkit.org/show_bug.cgi?id=168553

Unreviewed test gardening.

It's not a test; there's no good reason to import it.

• resources/import-expectations.json:
• web-platform-tests/css/css-shapes-1/test-plan/index-expected.txt: Removed.
• web-platform-tests/css/css-shapes-1/test-plan/index.html: Removed.
• web-platform-tests/css/css-shapes-1/test-plan/w3c-import.log: Removed.

LayoutTests:
[GTK] Remove reference to css-shapes-1/test-plan/index.html.
​https://bugs.webkit.org/show_bug.cgi?id=168553

Unreviewed test gardening.

• platform/gtk/TestExpectations:

6:23 AM Changeset in webkit [225135] by Ms2ger@igalia.com

• 2 edits in trunk/LayoutTests

[WPE] Update some test expectations
​https://bugs.webkit.org/show_bug.cgi?id=180000

Unreviewed test gardening.

• platform/wpe/TestExpectations:
  • Mark as intermittently passing:
    • animations/negative-delay.html (also noted the bug)
    • fast/canvas/canvas-overflow-hidden-animation.html
    • imported/w3c/i18n/bidi/bidi-plaintext-011.html

• Enable tests fixed in r224580:
  • imported/w3c/IndexedDB-private-browsing/idb_webworkers.html
  • storage/indexeddb/basics-workers.html
  • storage/indexeddb/cursor-advance-workers.html
  • storage/indexeddb/deletedatabase-delayed-by-open-and-versionchange-workers.html
  • storage/indexeddb/dont-commit-on-blocked.html
  • storage/indexeddb/index-basics-workers.html
  • storage/indexeddb/modern/blob-simple-workers.html
  • storage/indexeddb/modern/worker-getall.html
  • storage/indexeddb/modern/workers-enable.html
  • storage/indexeddb/objectstore-basics-workers.html
  • storage/indexeddb/open-twice-workers.html
  • storage/indexeddb/pending-activity-workers.html
  • storage/indexeddb/pending-version-change-on-exit.html
  • storage/indexeddb/pending-version-change-on-exit-private.html
  • storage/indexeddb/pending-version-change-stuck.html
  • storage/indexeddb/pending-version-change-stuck-private.html
  • storage/indexeddb/pending-version-change-stuck-works-with-terminate.html
  • storage/indexeddb/pending-version-change-stuck-works-with-terminate-private.html
  • storage/indexeddb/transaction-complete-workers.html
  • storage/indexeddb/transaction-complete-workers-private.html
  • storage/indexeddb/unprefix-workers.html

• Remove failure expectations for tests that are passing on the bot:
  • fast/canvas/webgl/tex-image-and-sub-image-2d-with-video.html: passing since r225060.
  • fast/events/event-view-toString.html: passing since r221858.
  • fast/events/offsetX-offsetY.html: passing since r221858.
  • fast/shapes/shape-outside-floats/shape-outside-floats-shape-margin-percent.html: passing since r221858.
  • webgl/1.0.2/conformance/context/context-creation-and-destruction.html: passing since its missing resource was added in r223632.

• Add some passing expectations for tests that are marked as failing in the platform-neutral file:
  • css2.1/20110323/replaced-intrinsic-001.htm: has been passing for a long time; the baseline probably does not reflect the actual pass condition. (The upstream test is claimed to be invalid, and fails in all browsers.)
  • css2.1/20110323/replaced-intrinsic-002.htm: has been passing for a long time; the baseline probably does not reflect the actual pass condition. (The upstream test is claimed to be invalid, and fails in all browsers.)
  • css3/flexbox/csswg/flexbox_flex-natural-mixed-basis-auto.html: passing since r222128.
  • transitions/svg-text-shadow-transition.html: passing since expectation rebaseline in r222084.

6:17 AM Changeset in webkit [225134] by clopez@igalia.com

• 2 edits in trunk/LayoutTests

REGRESSION(r225098): [WPE] Gardening of tests after r225098.

70 new failures after some features changed of value.
Reported on ​https://bugs.webkit.org/show_bug.cgi?id=180004
Remove also 2 duplicated entries on the expectations file.

Unreviewed gardening.

• platform/wpe/TestExpectations:

5:30 AM Changeset in webkit [225133] by graouts@webkit.org

• 7 edits
  2 adds in trunk

[Web Animations] Allow getComputedStyle() to return animated values for accelerated animations
​https://bugs.webkit.org/show_bug.cgi?id=179975
<rdar://problem/35676811>

Reviewed by Dean Jackson.

Source/WebCore:

In case we're running an accelerated animation, we are not blending RenderStyles as the animation
progresses and thus we need to hook into computeRenderStyleForProperty() to query the DocumentTimeline
for the animated style of running accelerated animations where we blend styles manually for the
animation's current time.

Test: http/wpt/wk-web-animations/interfaces/keyframe-effect-getComputedStyle.html

• animation/DocumentTimeline.cpp:

(WebCore::DocumentTimeline::animatedStyleForRenderer): Iterate through all running accelerated animations
for the element to which the provided renderer is attached and ask for their animated styles.

• animation/DocumentTimeline.h:
• animation/KeyframeEffect.cpp:

(WebCore::KeyframeEffect::getAnimatedStyle): Manually blend all animated properties and populate the provided
RenderStyle with their values, creating the RenderStyle if needed.

• animation/KeyframeEffect.h:
• css/CSSComputedStyleDeclaration.cpp:

(WebCore::computeRenderStyleForProperty): Query the DocumentTimeline for accelerated animated properties in
case such animations are running, otherwise let the CSS animation controller report the animated values.

LayoutTests:

Add a new test that checks that the computed style of accelerated animation returns the animated value.
This test would fail for the accelerated case prior to this patch.

• http/wpt/wk-web-animations/interfaces/keyframe-effect-getComputedStyle-expected.txt: Added.
• http/wpt/wk-web-animations/interfaces/keyframe-effect-getComputedStyle.html: Added.

5:04 AM Changeset in webkit [225132] by zandobersek@gmail.com

• 6 edits in trunk/Source

[CoordGraphics] CoordinatedGraphicsLayer::updateContentBuffers() should always assume a non-null CoordinatedBuffer
​https://bugs.webkit.org/show_bug.cgi?id=179977

Reviewed by Carlos Garcia Campos.

Source/WebCore:

CoordinatedGraphicsLayer::updateContentBuffers() retrieves a RefPtr<CoordinatedBuffer>
from the CompositingCoordinator. This pointer should never be null since if no
existing UpdateAtlas can provide the necessary memory area, a fresh UpdateAtlas is
created and its buffer returned. This can't fail in theory since the tiles that are
being updated are smaller than the UpdateAtlas area.

The CoordinatedGraphicsLayerClient::getCoordinatedBuffer() method is updated to
always return a Ref<CoordinatedBuffer> value. Code in updateContentBuffers() is
updated to remove a null-check on what is now the Ref<CoordinatedBuffer> value.

No new tests -- no change in functionality.

• platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp:

(WebCore::CoordinatedGraphicsLayer::updateContentBuffers):

• platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.h:

Source/WebKit:

Make CompositingCoordinator::getCoordinatedBuffer() return a Ref<CoordinatedBuffer>
value. In case an UpdateAtlas with enough free area is found, its CoordinatedBuffer
is dereferenced into the return value. In case a new UpdateAtlas is created, the
returned CoordinatedBuffer pointer is asserted to be non-null and dereferenced.

The retrieved CoordinatedBuffer pointer on a newly-created UpdateAtlas should never
be null since the tiles are smaller in size than the UpdateAtlas area. The assert
is done in release configurations as well since the code in CoordinatedGraphicsLayer
assumes the returned pointer will be non-null, so it's just a matter of where to
crash first in case somehow a null value is returned.

• WebProcess/WebPage/CoordinatedGraphics/CompositingCoordinator.cpp:

(WebKit::CompositingCoordinator::getCoordinatedBuffer):

• WebProcess/WebPage/CoordinatedGraphics/CompositingCoordinator.h:

3:27 AM Changeset in webkit [225131] by zandobersek@gmail.com

• 4 edits in trunk/Source/WebKit

[CoordGraphics] UpdateAtlas constructor should receive an IntSize, not a dimension value
​https://bugs.webkit.org/show_bug.cgi?id=179976

Reviewed by Carlos Garcia Campos.

Have the UpdateAtlas constructor receive an IntSize object that specifies
the desired size for the CoordinatedBuffer. Passing in a dimension doesn't
really make sense since this value isn't dynamically configurable, and
the only value that is passed in is already a power-of-two.

• WebProcess/WebPage/CoordinatedGraphics/CompositingCoordinator.cpp:

(WebKit::CompositingCoordinator::getCoordinatedBuffer):

• WebProcess/WebPage/CoordinatedGraphics/UpdateAtlas.cpp:

(WebKit::UpdateAtlas::UpdateAtlas):

• WebProcess/WebPage/CoordinatedGraphics/UpdateAtlas.h:

3:04 AM Changeset in webkit [225130] by Yusuke Suzuki

• 5 edits in trunk/Source/JavaScriptCore

[JSC] Make empty key as deleted mark in HashMapBucket and drop m_deleted field
​https://bugs.webkit.org/show_bug.cgi?id=179923

Reviewed by Darin Adler.

We do not set empty as a key in HashMapBucket since JSMap / JSSet can expose it to users.
So we can use it as a marker of deleted bucket.

This patch uses empty key as a deleted flag, and drop m_deleted field of HashMapBucket.
It shrinks the size of HashMapBucket much.

• dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileGetMapBucketNext):

• ftl/FTLAbstractHeapRepository.h:
• ftl/FTLLowerDFGToB3.cpp:

(JSC::FTL::DFG::LowerDFGToB3::compileGetMapBucketNext):

• runtime/HashMapImpl.h:

(JSC::HashMapBucket::createSentinel):
We make sentinel bucket as (undefined, undefined) since DFG/FTL can load a value from sentinels.
While the sentinel's deleted flag becomes false since key is set, it is not a problem since deleted
flag of sentinel bucket is not used.

(JSC::HashMapBucket::HashMapBucket):
(JSC::HashMapBucket::deleted const):
(JSC::HashMapBucket::makeDeleted):
(JSC::HashMapImpl::remove):
(JSC::HashMapImpl::clear):
(JSC::HashMapImpl::setUpHeadAndTail):
(JSC::HashMapImpl::addNormalizedInternal):
(JSC::HashMapBucket::setDeleted): Deleted.
(JSC::HashMapBucket::offsetOfDeleted): Deleted.
(): Deleted.

2:58 AM Changeset in webkit [225129] by mark.lam@apple.com

• 113 edits in trunk

Move unsafe jsc shell test functions to the $vm object.
​https://bugs.webkit.org/show_bug.cgi?id=179980

Reviewed by Yusuke Suzuki.

JSTests:

• controlFlowProfiler/driver/driver.js:
• controlFlowProfiler/execution-count.js:
• controlFlowProfiler/if-statement.js:
• controlFlowProfiler/loop-statements.js:
• controlFlowProfiler/switch-statements.js:
• controlFlowProfiler/test-jit.js:
• exceptionFuzz/3d-cube.js:
• exceptionFuzz/date-format-xparb.js:
• exceptionFuzz/earley-boyer.js:
• heapProfiler/basic-edges.js:
• heapProfiler/property-edge-types.js:
• microbenchmarks/try-get-by-id-basic.js:
• microbenchmarks/try-get-by-id-polymorphic.js:
• modules/namespace-object-try-get.js:
• stress/argument-count-bytecode.js:
• stress/argument-intrinsic-basic.js:
• stress/argument-intrinsic-inlining-use-caller-arg.js:
• stress/argument-intrinsic-inlining-with-result-escape.js:
• stress/argument-intrinsic-inlining-with-vararg-with-enough-arguments.js:
• stress/argument-intrinsic-inlining-with-vararg.js:
• stress/argument-intrinsic-nested-inlining.js:
• stress/argument-intrinsic-not-convert-to-get-argument.js:
• stress/argument-intrinsic-with-stack-write.js:
• stress/arity-mismatch-get-argument.js:
• stress/array-message-passing.js:
• stress/array-push-with-force-exit.js:
• stress/check-dom-with-signature.js:
• stress/check-sub-class.js:
• stress/compare-eq-incomplete-profile.js:
• stress/custom-get-set-inline-caching-one-level-up-proto-chain.js:
• stress/do-eval-virtual-call-correctly.js:
• stress/dom-jit-with-poly-proto.js:
• stress/domjit-exception-ic.js:
• stress/domjit-exception.js:
• stress/domjit-getter-complex-with-incorrect-object.js:
• stress/domjit-getter-complex.js:
• stress/domjit-getter-poly.js:
• stress/domjit-getter-proto.js:
• stress/domjit-getter-super-poly.js:
• stress/domjit-getter-try-catch-getter-as-get-by-id-register-restoration.js:
• stress/domjit-getter-type-check.js:
• stress/domjit-getter.js:
• stress/exit-during-inlined-arity-fixup-recover-proper-frame.js:
• stress/for-in-proxy-target-changed-structure.js:
• stress/for-in-proxy.js:
• stress/generational-opaque-roots.js:
• stress/global-const-redeclaration-setting-2.js:
• stress/global-const-redeclaration-setting-3.js:
• stress/global-const-redeclaration-setting-4.js:
• stress/global-const-redeclaration-setting-5.js:
• stress/global-const-redeclaration-setting.js:
• stress/import-basic.js:
• stress/import-from-eval.js:
• stress/import-reject-with-exception.js:
• stress/import-syntax.js:
• stress/impure-get-own-property-slot-inline-cache.js:
• stress/is-constructor.js:
• stress/istypedarrayview-intrinsic.js:
• stress/jsc-setImpureGetterDelegate-on-bad-type.js:
• stress/jsc-test-functions-should-be-more-robust.js:
• stress/object-toString-with-proxy.js:
• stress/poly-proto-custom-value-and-accessor.js:
• stress/proxy-inline-cache.js:
• stress/re-execute-error-module.js:
• stress/regress-150532.js:
• stress/regress-156992.js:
• stress/regress-179619.js:
• stress/resources/shadow-chicken-support.js:
• stress/runtime-array.js:
• stress/sampling-profiler-microtasks.js:
• stress/shadow-chicken-enabled.js:
• stress/spread-correct-global-object-on-exception.js:
• stress/super-get-by-id.js:
• stress/tailCallForwardArguments.js:
• stress/to-object-intrinsic-boolean-edge.js:
• stress/to-object-intrinsic-null-or-undefined-edge.js:
• stress/to-object-intrinsic-number-edge.js:
• stress/to-object-intrinsic-object-edge.js:
• stress/to-object-intrinsic-string-edge.js:
• stress/to-object-intrinsic-symbol-edge.js:
• stress/to-object-intrinsic.js:
• stress/try-catch-custom-getter-as-get-by-id.js:
• stress/try-get-by-id-poly-proto.js:
• stress/try-get-by-id-should-spill-registers-dfg.js:
• stress/try-get-by-id.js:
• typeProfiler/arrow-functions.js:
• typeProfiler/basic.js:
• typeProfiler/captured.js:
• typeProfiler/classes.js:
• typeProfiler/dfg-jit-optimizations.js:
• typeProfiler/dictionary-mode.js:
• typeProfiler/es6-block-scoping.js:
• typeProfiler/es6-classes.js:
• typeProfiler/inheritance.js:
• typeProfiler/int52-dfg.js:
• typeProfiler/loop.js:
• typeProfiler/optional-fields.js:
• typeProfiler/overflow.js:
• typeProfiler/return.js:
• typeProfiler/symbol.js:
• typeProfiler/weird-prototype-chain.js:

Source/JavaScriptCore:

Also removed setElementRoot() which was not used.

• jsc.cpp:

(GlobalObject::finishCreation):
(WTF::Element::Element): Deleted.
(WTF::Element::root const): Deleted.
(WTF::Element::setRoot): Deleted.
(WTF::Element::create): Deleted.
(WTF::Element::visitChildren): Deleted.
(WTF::Element::createStructure): Deleted.
(WTF::Root::Root): Deleted.
(WTF::Root::element): Deleted.
(WTF::Root::setElement): Deleted.
(WTF::Root::create): Deleted.
(WTF::Root::createStructure): Deleted.
(WTF::Root::visitChildren): Deleted.
(WTF::ImpureGetter::ImpureGetter): Deleted.
(WTF::ImpureGetter::createStructure): Deleted.
(WTF::ImpureGetter::create): Deleted.
(WTF::ImpureGetter::finishCreation): Deleted.
(WTF::ImpureGetter::getOwnPropertySlot): Deleted.
(WTF::ImpureGetter::visitChildren): Deleted.
(WTF::ImpureGetter::setDelegate): Deleted.
(WTF::CustomGetter::CustomGetter): Deleted.
(WTF::CustomGetter::createStructure): Deleted.
(WTF::CustomGetter::create): Deleted.
(WTF::CustomGetter::getOwnPropertySlot): Deleted.
(WTF::CustomGetter::customGetter): Deleted.
(WTF::CustomGetter::customGetterAcessor): Deleted.
(WTF::RuntimeArray::create): Deleted.
(WTF::RuntimeArray::~RuntimeArray): Deleted.
(WTF::RuntimeArray::destroy): Deleted.
(WTF::RuntimeArray::getOwnPropertySlot): Deleted.
(WTF::RuntimeArray::getOwnPropertySlotByIndex): Deleted.
(WTF::RuntimeArray::put): Deleted.
(WTF::RuntimeArray::deleteProperty): Deleted.
(WTF::RuntimeArray::getLength const): Deleted.
(WTF::RuntimeArray::createPrototype): Deleted.
(WTF::RuntimeArray::createStructure): Deleted.
(WTF::RuntimeArray::finishCreation): Deleted.
(WTF::RuntimeArray::RuntimeArray): Deleted.
(WTF::RuntimeArray::lengthGetter): Deleted.
(WTF::SimpleObject::SimpleObject): Deleted.
(WTF::SimpleObject::create): Deleted.
(WTF::SimpleObject::visitChildren): Deleted.
(WTF::SimpleObject::createStructure): Deleted.
(WTF::SimpleObject::hiddenValue): Deleted.
(WTF::SimpleObject::setHiddenValue): Deleted.
(WTF::DOMJITNode::DOMJITNode): Deleted.
(WTF::DOMJITNode::createStructure): Deleted.
(WTF::DOMJITNode::checkSubClassSnippet): Deleted.
(WTF::DOMJITNode::create): Deleted.
(WTF::DOMJITNode::value const): Deleted.
(WTF::DOMJITNode::offsetOfValue): Deleted.
(WTF::DOMJITGetter::DOMJITGetter): Deleted.
(WTF::DOMJITGetter::createStructure): Deleted.
(WTF::DOMJITGetter::create): Deleted.
(WTF::DOMJITGetter::DOMJITAttribute::DOMJITAttribute): Deleted.
(WTF::DOMJITGetter::DOMJITAttribute::slowCall): Deleted.
(WTF::DOMJITGetter::DOMJITAttribute::callDOMGetter): Deleted.
(WTF::DOMJITGetter::customGetter): Deleted.
(WTF::DOMJITGetter::finishCreation): Deleted.
(WTF::DOMJITGetterComplex::DOMJITGetterComplex): Deleted.
(WTF::DOMJITGetterComplex::createStructure): Deleted.
(WTF::DOMJITGetterComplex::create): Deleted.
(WTF::DOMJITGetterComplex::DOMJITAttribute::DOMJITAttribute): Deleted.
(WTF::DOMJITGetterComplex::DOMJITAttribute::slowCall): Deleted.
(WTF::DOMJITGetterComplex::DOMJITAttribute::callDOMGetter): Deleted.
(WTF::DOMJITGetterComplex::functionEnableException): Deleted.
(WTF::DOMJITGetterComplex::customGetter): Deleted.
(WTF::DOMJITGetterComplex::finishCreation): Deleted.
(WTF::DOMJITFunctionObject::DOMJITFunctionObject): Deleted.
(WTF::DOMJITFunctionObject::createStructure): Deleted.
(WTF::DOMJITFunctionObject::create): Deleted.
(WTF::DOMJITFunctionObject::safeFunction): Deleted.
(WTF::DOMJITFunctionObject::unsafeFunction): Deleted.
(WTF::DOMJITFunctionObject::checkSubClassSnippet): Deleted.
(WTF::DOMJITFunctionObject::finishCreation): Deleted.
(WTF::DOMJITCheckSubClassObject::DOMJITCheckSubClassObject): Deleted.
(WTF::DOMJITCheckSubClassObject::createStructure): Deleted.
(WTF::DOMJITCheckSubClassObject::create): Deleted.
(WTF::DOMJITCheckSubClassObject::safeFunction): Deleted.
(WTF::DOMJITCheckSubClassObject::unsafeFunction): Deleted.
(WTF::DOMJITCheckSubClassObject::finishCreation): Deleted.
(WTF::DOMJITGetterBaseJSObject::DOMJITGetterBaseJSObject): Deleted.
(WTF::DOMJITGetterBaseJSObject::createStructure): Deleted.
(WTF::DOMJITGetterBaseJSObject::create): Deleted.
(WTF::DOMJITGetterBaseJSObject::DOMJITAttribute::DOMJITAttribute): Deleted.
(WTF::DOMJITGetterBaseJSObject::DOMJITAttribute::slowCall): Deleted.
(WTF::DOMJITGetterBaseJSObject::DOMJITAttribute::callDOMGetter): Deleted.
(WTF::DOMJITGetterBaseJSObject::customGetter): Deleted.
(WTF::DOMJITGetterBaseJSObject::finishCreation): Deleted.
(WTF::Element::handleOwner): Deleted.
(WTF::Element::finishCreation): Deleted.
(JSTestCustomGetterSetter::JSTestCustomGetterSetter): Deleted.
(JSTestCustomGetterSetter::create): Deleted.
(JSTestCustomGetterSetter::createStructure): Deleted.
(customGetAccessor): Deleted.
(customGetValue): Deleted.
(customSetAccessor): Deleted.
(customSetValue): Deleted.
(JSTestCustomGetterSetter::finishCreation): Deleted.
(GlobalObject::addConstructableFunction): Deleted.
(functionCreateRoot): Deleted.
(functionCreateElement): Deleted.
(functionGetElement): Deleted.
(functionSetElementRoot): Deleted.
(functionCreateSimpleObject): Deleted.
(functionGetHiddenValue): Deleted.
(functionSetHiddenValue): Deleted.
(functionCreateProxy): Deleted.
(functionCreateRuntimeArray): Deleted.
(functionCreateImpureGetter): Deleted.
(functionCreateCustomGetterObject): Deleted.
(functionCreateDOMJITNodeObject): Deleted.
(functionCreateDOMJITGetterObject): Deleted.
(functionCreateDOMJITGetterComplexObject): Deleted.
(functionCreateDOMJITFunctionObject): Deleted.
(functionCreateDOMJITCheckSubClassObject): Deleted.
(functionCreateDOMJITGetterBaseJSObject): Deleted.
(functionSetImpureGetterDelegate): Deleted.
(functionGetGetterSetter): Deleted.
(functionShadowChickenFunctionsOnStack): Deleted.
(functionSetGlobalConstRedeclarationShouldNotThrow): Deleted.
(functionGlobalObjectForObject): Deleted.
(functionLoadGetterFromGetterSetter): Deleted.
(functionCreateCustomTestGetterSetter): Deleted.
(functionAbort): Deleted.
(functionFindTypeForExpression): Deleted.
(functionReturnTypeFor): Deleted.
(functionDumpBasicBlockExecutionRanges): Deleted.
(functionHasBasicBlockExecuted): Deleted.
(functionBasicBlockExecutionCount): Deleted.
(functionEnableExceptionFuzz): Deleted.
(functionCreateBuiltin): Deleted.

• runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::init):

• tools/JSDollarVM.cpp:

(WTF::Element::Element):
(WTF::Element::root const):
(WTF::Element::setRoot):
(WTF::Element::create):
(WTF::Element::visitChildren):
(WTF::Element::createStructure):
(WTF::Root::Root):
(WTF::Root::element):
(WTF::Root::setElement):
(WTF::Root::create):
(WTF::Root::createStructure):
(WTF::Root::visitChildren):
(WTF::SimpleObject::SimpleObject):
(WTF::SimpleObject::create):
(WTF::SimpleObject::visitChildren):
(WTF::SimpleObject::createStructure):
(WTF::SimpleObject::hiddenValue):
(WTF::SimpleObject::setHiddenValue):
(WTF::ImpureGetter::ImpureGetter):
(WTF::ImpureGetter::createStructure):
(WTF::ImpureGetter::create):
(WTF::ImpureGetter::finishCreation):
(WTF::ImpureGetter::getOwnPropertySlot):
(WTF::ImpureGetter::visitChildren):
(WTF::ImpureGetter::setDelegate):
(WTF::CustomGetter::CustomGetter):
(WTF::CustomGetter::createStructure):
(WTF::CustomGetter::create):
(WTF::CustomGetter::getOwnPropertySlot):
(WTF::CustomGetter::customGetter):
(WTF::CustomGetter::customGetterAcessor):
(WTF::RuntimeArray::create):
(WTF::RuntimeArray::~RuntimeArray):
(WTF::RuntimeArray::destroy):
(WTF::RuntimeArray::getOwnPropertySlot):
(WTF::RuntimeArray::getOwnPropertySlotByIndex):
(WTF::RuntimeArray::put):
(WTF::RuntimeArray::deleteProperty):
(WTF::RuntimeArray::getLength const):
(WTF::RuntimeArray::createPrototype):
(WTF::RuntimeArray::createStructure):
(WTF::RuntimeArray::finishCreation):
(WTF::RuntimeArray::RuntimeArray):
(WTF::RuntimeArray::lengthGetter):
(WTF::DOMJITNode::DOMJITNode):
(WTF::DOMJITNode::createStructure):
(WTF::DOMJITNode::checkSubClassSnippet):
(WTF::DOMJITNode::create):
(WTF::DOMJITNode::value const):
(WTF::DOMJITNode::offsetOfValue):
(WTF::DOMJITGetter::DOMJITGetter):
(WTF::DOMJITGetter::createStructure):
(WTF::DOMJITGetter::create):
(WTF::DOMJITGetter::DOMJITAttribute::DOMJITAttribute):
(WTF::DOMJITGetter::DOMJITAttribute::slowCall):
(WTF::DOMJITGetter::DOMJITAttribute::callDOMGetter):
(WTF::DOMJITGetter::customGetter):
(WTF::DOMJITGetter::finishCreation):
(WTF::DOMJITGetterComplex::DOMJITGetterComplex):
(WTF::DOMJITGetterComplex::createStructure):
(WTF::DOMJITGetterComplex::create):
(WTF::DOMJITGetterComplex::DOMJITAttribute::DOMJITAttribute):
(WTF::DOMJITGetterComplex::DOMJITAttribute::slowCall):
(WTF::DOMJITGetterComplex::DOMJITAttribute::callDOMGetter):
(WTF::DOMJITGetterComplex::functionEnableException):
(WTF::DOMJITGetterComplex::customGetter):
(WTF::DOMJITGetterComplex::finishCreation):
(WTF::DOMJITFunctionObject::DOMJITFunctionObject):
(WTF::DOMJITFunctionObject::createStructure):
(WTF::DOMJITFunctionObject::create):
(WTF::DOMJITFunctionObject::safeFunction):
(WTF::DOMJITFunctionObject::unsafeFunction):
(WTF::DOMJITFunctionObject::checkSubClassSnippet):
(WTF::DOMJITFunctionObject::finishCreation):
(WTF::DOMJITCheckSubClassObject::DOMJITCheckSubClassObject):
(WTF::DOMJITCheckSubClassObject::createStructure):
(WTF::DOMJITCheckSubClassObject::create):
(WTF::DOMJITCheckSubClassObject::safeFunction):
(WTF::DOMJITCheckSubClassObject::unsafeFunction):
(WTF::DOMJITCheckSubClassObject::finishCreation):
(WTF::DOMJITGetterBaseJSObject::DOMJITGetterBaseJSObject):
(WTF::DOMJITGetterBaseJSObject::createStructure):
(WTF::DOMJITGetterBaseJSObject::create):
(WTF::DOMJITGetterBaseJSObject::DOMJITAttribute::DOMJITAttribute):
(WTF::DOMJITGetterBaseJSObject::DOMJITAttribute::slowCall):
(WTF::DOMJITGetterBaseJSObject::DOMJITAttribute::callDOMGetter):
(WTF::DOMJITGetterBaseJSObject::customGetter):
(WTF::DOMJITGetterBaseJSObject::finishCreation):
(WTF::Message::releaseContents):
(WTF::Message::index const):
(WTF::JSTestCustomGetterSetter::JSTestCustomGetterSetter):
(WTF::JSTestCustomGetterSetter::create):
(WTF::JSTestCustomGetterSetter::createStructure):
(WTF::customGetAccessor):
(WTF::customGetValue):
(WTF::customSetAccessor):
(WTF::customSetValue):
(WTF::JSTestCustomGetterSetter::finishCreation):
(WTF::Element::handleOwner):
(WTF::Element::finishCreation):
(JSC::functionCrash):
(JSC::functionCreateProxy):
(JSC::functionCreateRuntimeArray):
(JSC::functionCreateImpureGetter):
(JSC::functionCreateCustomGetterObject):
(JSC::functionCreateDOMJITNodeObject):
(JSC::functionCreateDOMJITGetterObject):
(JSC::functionCreateDOMJITGetterComplexObject):
(JSC::functionCreateDOMJITFunctionObject):
(JSC::functionCreateDOMJITCheckSubClassObject):
(JSC::functionCreateDOMJITGetterBaseJSObject):
(JSC::functionSetImpureGetterDelegate):
(JSC::functionCreateBuiltin):
(JSC::functionCreateRoot):
(JSC::functionCreateElement):
(JSC::functionGetElement):
(JSC::functionCreateSimpleObject):
(JSC::functionGetHiddenValue):
(JSC::functionSetHiddenValue):
(JSC::functionShadowChickenFunctionsOnStack):
(JSC::functionSetGlobalConstRedeclarationShouldNotThrow):
(JSC::functionFindTypeForExpression):
(JSC::functionReturnTypeFor):
(JSC::functionDumpBasicBlockExecutionRanges):
(JSC::functionHasBasicBlockExecuted):
(JSC::functionBasicBlockExecutionCount):
(JSC::functionEnableExceptionFuzz):
(JSC::functionGlobalObjectForObject):
(JSC::functionGetGetterSetter):
(JSC::functionLoadGetterFromGetterSetter):
(JSC::functionCreateCustomTestGetterSetter):
(JSC::JSDollarVM::finishCreation):
(JSC::JSDollarVM::addFunction):
(JSC::JSDollarVM::addConstructibleFunction):

• tools/JSDollarVM.h:

(JSC::JSDollarVM::create):

Tools:

Always set --useDollarVM=true for jsc runs of benchmarks. This is needed because
some microbenchmarks relies on createBuiltin().

Also set --useDollarVM=true for runExceptionFuzz and runExecutableAllocationFuzz.

• Scripts/run-jsc-benchmarks:
• Scripts/run-jsc-stress-tests:

LayoutTests:

• js/script-tests/stack-trace.js:
• js/stack-trace-expected.txt:

1:45 AM Changeset in webkit [225128] by graouts@webkit.org

• 9 edits
  8 adds in trunk

Source/WebCore:
[Web Animations] Perform accelerated animations when possible
​https://bugs.webkit.org/show_bug.cgi?id=179973
<rdar://problem/34953922>

Reviewed by Dean Jackson.

When we're entering and leaving the active duration of an animation effect, we now check
whether the animation can be accelerated, using the existing CSSPropertyAnimation::animationOfPropertyIsAccelerated()
utility, and start and stop animations using the startAnimation() and animationFinished() functions on RenderBoxModelObject.

This patch is only a first step towards full support for accelerated animations,
there are two known issues at the moment. Because we're not blending the styles to perform
the animation, getComputedStyle() will not return the animated value (webkit.org/b/179974).
Additionally, if other animations happen to run later during the active state of an animation
that can run accelerated, we will not fall back to software-only animation for this
element and these animations will appear not to run (webkit.org/b/179975). These will be
addressed in follow-up patches.

Tests: webanimations/left-and-opacity-animation-yields-no-compositing.html

webanimations/opacity-animation-no-longer-composited-upon-completion.html
webanimations/opacity-animation-yields-compositing.html
webanimations/width-and-opacity-separate-animation-yields-no-compositing.html

• animation/DocumentTimeline.cpp:

(WebCore::DocumentTimeline::updateAnimations): Check in the map of pending accelerated animations
to see if any animation requires toggling their active state after their styles have been invalidated.
(WebCore::DocumentTimeline::animationAcceleratedRunningStateDidChange): New function to
let animations indicate that they need to have their accelerated backing animation toggled after
style invalidation has been completed.
(WebCore::DocumentTimeline::runningAnimationsForElementAreAllAccelerated): This function is used
in RenderLayerCompositor::requiresCompositingForAnimation() to identify whether an element requires
hardware compositing due to running accelerated animations. We check all running animations for the
provided element to see if they can all be running accelerated and return true in this situation only.

• animation/DocumentTimeline.h:
• animation/KeyframeEffect.cpp:

(WebCore::KeyframeEffect::applyAtLocalTime): Identify if we're crossing into or out of the active state
for an animation and check if it will be or has been running accelerated such that we can notify the
DocumentTimeline, through the associated animation, that the accelerated backing animation will need to
be toggled after style invalidation has been completed.
(WebCore::KeyframeEffect::shouldRunAccelerated): Check that all properties for this animation
effect can be accelerated according to CSSPropertyAnimation::animationOfPropertyIsAccelerated().
(WebCore::KeyframeEffect::startOrStopAccelerated): Start or stop the associated accelerated
animation through the associated element's RenderBoxModelObject renderer.

• animation/KeyframeEffect.h:
• animation/WebAnimation.cpp:

(WebCore::WebAnimation::acceleratedRunningStateDidChange): Called from AnimationEffect::applyAtLocalTime(),
we forward to the DocumentTimeline the information that the animation will cross an active state boundary while
allowing to be backed by hardware compositing.
(WebCore::WebAnimation::startOrStopAccelerated): Forward to the associated KeyframeEffect that accelerated
animation backing should be toggled.

• animation/WebAnimation.h:
• rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::requiresCompositingForAnimation const): Check via the renderer's element's
DocumentTimeline that all running animations for this particular element are accelerated to ensure that
the element will be hardware-composited.

LayoutTests:
[Web Animations] Perform hardware-composited animations when possible
​https://bugs.webkit.org/show_bug.cgi?id=179973
<rdar://problem/34953922>

Reviewed by Dean Jackson.

Add a series of tests to check that we use hardware-compositing for animations when possible.
Specifically, we check that:

1. Specifying both accelerated and non-accelerated properties for a single animation does *not*

yield hardware compositing (left-and-opacity-animation-yields-no-compositing.html).

2. Specifying both accelerated and non-accelerated properties via multiple animations does *not*

yield hardware compositing (width-and-opacity-separate-animation-yields-no-compositing.html).

3. Specifying only accelerated properties *does* yield hardware compositing

(opacity-animation-yields-compositing.html).

4. Hardware-composited animations no longer enforce hardware compositing after their completion

(opacity-animation-no-longer-composited-upon-completion.html).

• webanimations/left-and-opacity-animation-yields-no-compositing-expected.txt: Added.
• webanimations/left-and-opacity-animation-yields-no-compositing.html: Added.
• webanimations/opacity-animation-no-longer-composited-upon-completion-expected.txt: Added.
• webanimations/opacity-animation-no-longer-composited-upon-completion.html: Added.
• webanimations/opacity-animation-yields-compositing-expected.txt: Added.
• webanimations/opacity-animation-yields-compositing.html: Added.
• webanimations/width-and-opacity-separate-animation-yields-no-compositing-expected.txt: Added.
• webanimations/width-and-opacity-separate-animation-yields-no-compositing.html: Added.