Context Navigation

← Previous Period
Next Period →

Timeline

Nov 30, 2017:

9:36 PM Changeset in webkit [225384] by achristensen@apple.com

3 edits in trunk/Source/ThirdParty/ANGLE

Speculative WinCairo fix.
https://bugs.webkit.org/show_bug.cgi?id=180177

CMakeLists.txt:
PlatformWin.cmake:

9:32 PM Changeset in webkit [225383] by achristensen@apple.com

4 edits
1 add in trunk

REGRESSION (r224791): cookies are shared between ephemeral sessions in the same process pool
https://bugs.webkit.org/show_bug.cgi?id=180235

Reviewed by Joseph Pecoraro.

Source/WebKit:

In r224791 I assumed that uiProcessCookieStorageIdentifier would be empty in the ephemeral session initialization message.
This is not the case. We did not catch this because almost all of our ephemeral session testing uses the legacyPrivateSessionID.
I add checks for if the SessionID is ephemeral like we already have in WebFrameNetworkingContext::ensureWebsiteDataStoreSession.
I also add an API test that makes sure cookies are not shared between ephemeral sessions the way they are made through the API.

NetworkProcess/mac/RemoteNetworkingContext.mm:

(WebKit::RemoteNetworkingContext::ensureWebsiteDataStoreSession):

Tools:

TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
TestWebKitAPI/Tests/WebKitCocoa/CookiePrivateBrowsing.mm: Added.

(-[CookiePrivateBrowsingDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
(TEST):

9:30 PM Changeset in webkit [225382] by jmarcell@apple.com

7 edits in branches/safari-604-branch/Source

Versioning.

9:27 PM Changeset in webkit [225381] by achristensen@apple.com

4 edits
4 adds in trunk

Extra PerformanceEntryList entry after iframe navigation
https://bugs.webkit.org/show_bug.cgi?id=178433

Reviewed by Joseph Pecoraro.

Source/WebCore:

Test: http/tests/security/PerformanceEntryList-parent-only-first-navigation.html

When an iframe is loaded, its main resource load should be reported to the parent frame's PerformanceEntryList.
Subsequent main resource loads should not.

loader/FrameLoader.h:

(WebCore::FrameLoader::shouldReportResourceTimingToParentFrame):

loader/ResourceTimingInformation.cpp:

(WebCore::ResourceTimingInformation::addResourceTiming):

LayoutTests:

http/tests/security/PerformanceEntryList-parent-only-first-navigation-expected.txt: Added.
http/tests/security/PerformanceEntryList-parent-only-first-navigation.html: Added.
http/tests/security/resources/navigate-and-postMessage.html: Added.
http/tests/security/resources/postMessage.html: Added.

9:24 PM Changeset in webkit [225380] by jmarcell@apple.com

7 edits in trunk/Source

Versioning.

6:54 PM Changeset in webkit [225379] by Alan Bujtas

3 edits
2 adds in trunk

Source/WebCore:
[Simple line layout] Incorrect repaint rect with vertically shrinking content and bottom-padding.
https://bugs.webkit.org/show_bug.cgi?id=180223
<rdar://problem/34122210>

Reviewed by Simon Fraser.

Repaint rect should be extended all the way to bottom border/padding.

Test: fast/repaint/simple-line-layout-shrinking-content.html

rendering/RenderBlockFlow.cpp:

(WebCore::RenderBlockFlow::layoutSimpleLines):

LayoutTests:
[Simple line layout] Incorrect repaint rect with vertically shrinking content.
https://bugs.webkit.org/show_bug.cgi?id=180223
<rdar://problem/34122210>

Reviewed by Simon Fraser.

fast/repaint/simple-line-layout-shrinking-content-expected.txt: Added.
fast/repaint/simple-line-layout-shrinking-content.html: Added.

6:41 PM Changeset in webkit [225378] by jfbastien@apple.com

17 edits in trunk

WebAssembly: improve stack trace
https://bugs.webkit.org/show_bug.cgi?id=179343

Reviewed by Saam Barati.

JSTests:

Update the tests to follow the new format. Notably, SHA1 module
hash is now included in traces, and stubs are properly identified.

wasm/assert.js: Add an assertion which matches regular expressions.
wasm/function-tests/nameSection.js:
wasm/function-tests/stack-overflow.js:

(import.Builder.from.string_appeared_here.import.as.assert.from.string_appeared_here.assertOverflows):
(assertOverflows.assertThrows.wasm.1):
(assertOverflows.assertThrows.wasm.0):
(assertOverflows.assertThrows):
(assertOverflows):

wasm/function-tests/stack-trace.js:

(import.Builder.from.string_appeared_here.assert): Deleted.

wasm/function-tests/trap-after-cross-instance-call.js:

(wasmFrameCountFromError):

wasm/function-tests/trap-load-2.js:

(wasmFrameCountFromError):

wasm/function-tests/trap-load.js:

(wasmFrameCountFromError):

Source/JavaScriptCore:

Stack traces now include:

Module name, if provided by the name section.
Module SHA1 hash if no name was provided
Stub identification, to differentiate from user code
Slightly different naming to match design from:

https://github.com/WebAssembly/design/blob/master/Web.md#developer-facing-display-conventions

interpreter/StackVisitor.cpp:

(JSC::StackVisitor::Frame::functionName const):

runtime/StackFrame.cpp:

(JSC::StackFrame::functionName const):
(JSC::StackFrame::visitChildren):

wasm/WasmIndexOrName.cpp:

(JSC::Wasm::IndexOrName::IndexOrName):
(JSC::Wasm::makeString):

wasm/WasmIndexOrName.h:

(JSC::Wasm::IndexOrName::nameSection const):

wasm/WasmModuleInformation.cpp:

(JSC::Wasm::ModuleInformation::ModuleInformation):

wasm/WasmModuleInformation.h:
wasm/WasmNameSection.h:

(JSC::Wasm::NameSection::NameSection):
(JSC::Wasm::NameSection::get):

wasm/WasmNameSectionParser.cpp:

(JSC::Wasm::NameSectionParser::parse):

6:04 PM Changeset in webkit [225377] by commit-queue@webkit.org

23 edits in trunk

Make LegacyCustomProtocolManager optional for network process
https://bugs.webkit.org/show_bug.cgi?id=176230

Patch by Stephan Szabo <stephan.szabo@sony.com> on 2017-11-30
Reviewed by Alex Christensen.

Source/cmake/OptionsWin.cmake:
Source/cmake/WebKitFeatures.cmake:

Source/JavaScriptCore:

Configurations/FeatureDefines.xcconfig:

Source/WebCore:

No new tests, only sets up feature define

Configurations/FeatureDefines.xcconfig:

Source/WebCore/PAL:

Configurations/FeatureDefines.xcconfig:

Source/WebKit:

CMakeLists.txt:
Configurations/FeatureDefines.xcconfig:
NetworkProcess/NetworkProcess.cpp:

(WebKit::NetworkProcess::NetworkProcess):
(WebKit::NetworkProcess::initializeNetworkProcess):

PlatformGTK.cmake:
PlatformMac.cmake:
PlatformWPE.cmake:
UIProcess/Network/NetworkProcessProxy.cpp:

(WebKit::NetworkProcessProxy::NetworkProcessProxy):
(WebKit::NetworkProcessProxy::didClose):

UIProcess/Network/NetworkProcessProxy.h:
UIProcess/WebProcessPool.cpp:

(WebKit::WebProcessPool::setLegacyCustomProtocolManagerClient):
(WebKit::WebProcessPool::registerSchemeForCustomProtocol):
(WebKit::WebProcessPool::unregisterSchemeForCustomProtocol):

Source/WebKitLegacy/mac:

Configurations/FeatureDefines.xcconfig:

Tools:

TestWebKitAPI/Configurations/FeatureDefines.xcconfig:

5:52 PM Changeset in webkit [225376] by Dewei Zhu

2 edits in trunk/Tools

HTTP server driver is responsible for ensuring the dependencies of HTTP server.
https://bugs.webkit.org/show_bug.cgi?id=180231

Reviewed by Stephanie Lewis.

Added the logic to ensure system environment meet the requirments of launching the http server.

Scripts/webkitpy/benchmark_runner/http_server_driver/simple_http_server_driver.py:

(SimpleHTTPServerDriver.serve):
(SimpleHTTPServerDriver.set_device_id):
(SimpleHTTPServerDriver):
(SimpleHTTPServerDriver._ensure_http_server_dependencies):

5:02 PM Changeset in webkit [225375] by Yusuke Suzuki

7 edits in trunk/Source

[JSC] Remove easy toRemove & map.remove() use in OAS phase
https://bugs.webkit.org/show_bug.cgi?id=180208

Reviewed by Mark Lam.

Source/JavaScriptCore:

In this patch, we replace Vector<> toRemove & map.remove loop with removeIf,
to optimize this common pattern. This patch only modifies apparent ones.
But we can apply this refactoring further to OAS phase in the future.

One thing we should care is that predicate of removeIf should not touch the
removing set itself. In this patch, we apply this change to (1) apparently
correct one and (2) things in DFG OAS phase since it is very slow.

b3/B3MoveConstants.cpp:
dfg/DFGObjectAllocationSinkingPhase.cpp:

Source/WTF:

wtf/HashMap.h:

(WTF::X>::removeIf):

wtf/HashSet.h:

(WTF::V>::removeIf):

wtf/HashTable.h:

(WTF::KeyTraits>::removeIf):

4:57 PM Changeset in webkit [225374] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

[Cocoa] Fix CVPixelBuffer leak
https://bugs.webkit.org/show_bug.cgi?id=180224

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2017-11-30
Reviewed by Youenn Fablet.

platform/mediastream/mac/RealtimeIncomingVideoSourceCocoa.cpp:

(WebCore::RealtimeIncomingVideoSourceCocoa::pixelBufferFromVideoFrame):
Adopt the newly created pixel buffer.

(WebCore::RealtimeIncomingVideoSourceCocoa::OnFrame):
Release the format description as soon as we are done with it. Otherwise
we could have bailed before releasing it.

4:54 PM Changeset in webkit [225373] by Ryan Haddad

2 edits in trunk/Source/WebKit

Unreviewed build fix, suppress deprecation warnings.

Shared/mac/SandboxExtensionMac.mm:

(WebKit::SandboxExtensionImpl::sandboxExtensionForType):

4:51 PM Changeset in webkit [225372] by dbates@webkit.org

4 edits in trunk/Source/WebKit

Expose SPI didClickAlternativePresentationButtonWithUserInfo on iOS
https://bugs.webkit.org/show_bug.cgi?id=180218
<rdar://problem/35782555>

Reviewed by Alex Christensen.

We want to support the SPI didClickAlternativePresentationButtonWithUserInfo on Cocoa platforms.

UIProcess/API/Cocoa/WKUIDelegatePrivate.h:
UIProcess/Cocoa/UIDelegate.h:
UIProcess/Cocoa/UIDelegate.mm:

(WebKit::UIDelegate::setDelegate):
(WebKit::UIDelegate::UIClient::didClickAlternativePresentationButton):

4:40 PM Changeset in webkit [225371] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit

[Cocoa] Web Automation: _WKAutomationSessionConfiguration leak
https://bugs.webkit.org/show_bug.cgi?id=180222

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2017-11-30
Reviewed by Brian Burg.

UIProcess/Cocoa/AutomationClient.mm:

(WebKit::AutomationClient::requestAutomationSessionWithCapabilities):

4:33 PM Changeset in webkit [225370] by Ryan Haddad

2 edits in trunk/Source/ThirdParty/ANGLE

Unreviewed build fix, remove executable property from a header file.

include/KHR/khrplatform.h: Removed property svn:executable.

4:18 PM Changeset in webkit [225369] by commit-queue@webkit.org

4 edits in trunk/Source

Fix some NSOperationQueue leaks
https://bugs.webkit.org/show_bug.cgi?id=180221

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2017-11-30
Reviewed by Wenson Hsieh.

Source/WebKit:

UIProcess/Cocoa/WebViewImpl.mm:

(WebKit::WebViewImpl::performDragOperation):

Source/WebKitLegacy/mac:

WebView/WebView.mm:

(-[WebView performDragOperation:]):

4:14 PM Changeset in webkit [225368] by commit-queue@webkit.org

9 edits in trunk/Source

Unreviewed, rolling out r225362.
https://bugs.webkit.org/show_bug.cgi?id=180225

removeIf predicate function can touch remove target set
(Requested by yusukesuzuki on #webkit).

Reverted changeset:

"[JSC] Remove easy toRemove & map.remove() use"
https://bugs.webkit.org/show_bug.cgi?id=180208
https://trac.webkit.org/changeset/225362

4:11 PM Changeset in webkit [225367] by BJ Burg

2 edits in trunk/Source/WebKit

Web Automation: computeElementLayout does not correctly translate iframe client coordinates to main frame coordinates
https://bugs.webkit.org/show_bug.cgi?id=180213
<rdar://problem/30260141>

Reviewed by Simon Fraser.

The current implementation computes points in terms of the frame in which the element is located.
However, WebDriver expects coordinates to be relative to the top-level document since
these coordinates are used for generating click events, among other things.

To convert from frame client coordinates to main frame client coordinates, round-trip
both inViewCenterPoint and elementBounds to root view coordinates and back
to the main frame's contents/client coordinates. Then convert this to page coordinates if needed.

This progresses several tests in the Selenium Python test suite:

event_firing_webdriver_tests.py::test_should_fire_navigation_events
frame_switching_tests.py::testShouldBeAbleToClickInAFrameThatRewritesTopWindowLocation
frame_switching_tests.py::testShouldBeAbleToSwitchToTheTopIfTheFrameIsDeletedFromUnderUs
frame_switching_tests.py::testShouldBeAbleToSwitchToTheTopIfTheFrameIsDeletedFromUnderUsWithFrameIndex
frame_switching_tests.py::testShouldBeAbleToSwitchToTheTopIfTheFrameIsDeletedFromUnderUsWithWebelement
frame_switching_tests.py::testShouldNotBeAbleToDoAnythingTheFrameIsDeletedFromUnderUs
position_and_size_tests.py::testShouldGetCoordinatesOfAnInvisibleElement

WebProcess/Automation/WebAutomationSessionProxy.cpp:

(WebKit::WebAutomationSessionProxy::computeElementLayout):
Get both the frame and main frame FrameViews and convert coordinates to the root view.
This is somewhat lossy as clientToDocument* deals with FloatPoints but contentsToRootView
deals with IntPoints. For the purposes of WebDriver, lossiness is not a problem since
integer values are expected anyway.

The imperative nature of the coordinate calculations is difficult to debug, so I converted
this function to only assign to each variable once.

4:05 PM Changeset in webkit [225366] by Simon Fraser

60 edits in trunk

Improve filter logging
https://bugs.webkit.org/show_bug.cgi?id=180182

Reviewed by Sam Weinig.

Source/WebCore:

Add a parameter to FilterEffect::externalRepresentation() so that we can log extra
data without breaking layout tests.

Add TextStream output for ColorSpace.

Improve logging of FEComponentTransfer ComponentTransferFunctions by logging the data
that's appropriate for the function type, and rebaseline affected tests.

platform/graphics/Color.cpp:

(WebCore::operator<<):

platform/graphics/Color.h:
platform/graphics/filters/FEBlend.cpp:

(WebCore::FEBlend::externalRepresentation const):

platform/graphics/filters/FEBlend.h:
platform/graphics/filters/FEColorMatrix.cpp:

(WebCore::FEColorMatrix::externalRepresentation const):

platform/graphics/filters/FEColorMatrix.h:
platform/graphics/filters/FEComponentTransfer.cpp:

(WebCore::operator<<):
(WebCore::FEComponentTransfer::externalRepresentation const):

platform/graphics/filters/FEComponentTransfer.h:
platform/graphics/filters/FEComposite.cpp:

(WebCore::FEComposite::externalRepresentation const):

platform/graphics/filters/FEComposite.h:
platform/graphics/filters/FEConvolveMatrix.cpp:

(WebCore::FEConvolveMatrix::externalRepresentation const):

platform/graphics/filters/FEConvolveMatrix.h:
platform/graphics/filters/FEDiffuseLighting.cpp:

(WebCore::FEDiffuseLighting::externalRepresentation const):

platform/graphics/filters/FEDiffuseLighting.h:
platform/graphics/filters/FEDisplacementMap.cpp:

(WebCore::FEDisplacementMap::externalRepresentation const):

platform/graphics/filters/FEDisplacementMap.h:
platform/graphics/filters/FEDropShadow.cpp:

(WebCore::FEDropShadow::externalRepresentation const):

platform/graphics/filters/FEDropShadow.h:
platform/graphics/filters/FEFlood.cpp:

(WebCore::FEFlood::externalRepresentation const):

platform/graphics/filters/FEFlood.h:
platform/graphics/filters/FEGaussianBlur.cpp:

(WebCore::FEGaussianBlur::externalRepresentation const):

platform/graphics/filters/FEGaussianBlur.h:
platform/graphics/filters/FEMerge.cpp:

(WebCore::FEMerge::externalRepresentation const):

platform/graphics/filters/FEMerge.h:
platform/graphics/filters/FEMorphology.cpp:

(WebCore::FEMorphology::externalRepresentation const):

platform/graphics/filters/FEMorphology.h:
platform/graphics/filters/FEOffset.cpp:

(WebCore::FEOffset::externalRepresentation const):

platform/graphics/filters/FEOffset.h:
platform/graphics/filters/FESpecularLighting.cpp:

(WebCore::FESpecularLighting::externalRepresentation const):

platform/graphics/filters/FESpecularLighting.h:
platform/graphics/filters/FETile.cpp:

(WebCore::FETile::externalRepresentation const):

platform/graphics/filters/FETile.h:
platform/graphics/filters/FETurbulence.cpp:

(WebCore::FETurbulence::externalRepresentation const):

platform/graphics/filters/FETurbulence.h:
platform/graphics/filters/FilterEffect.cpp:

(WebCore::FilterEffect::externalRepresentation const):
(WebCore::operator<<):

platform/graphics/filters/FilterEffect.h:
platform/graphics/filters/SourceAlpha.cpp:

(WebCore::SourceAlpha::externalRepresentation const):

platform/graphics/filters/SourceAlpha.h:
platform/graphics/filters/SourceGraphic.cpp:

(WebCore::SourceGraphic::externalRepresentation const):

platform/graphics/filters/SourceGraphic.h:
rendering/svg/RenderSVGResourceFilter.cpp:

(WebCore::RenderSVGResourceFilter::applyResource):

svg/graphics/filters/SVGFEImage.cpp:

(WebCore::FEImage::externalRepresentation const):

svg/graphics/filters/SVGFEImage.h:

LayoutTests:

Improve logging of FEComponentTransfer ComponentTransferFunctions by logging the data
that's appropriate for the function type, and rebaseline affected tests.

css3/filters/effect-reference-expected.txt:
css3/filters/effect-reference-hw-expected.txt:
platform/mac/svg/W3C-SVG-1.1/filters-comptran-01-b-expected.txt:
platform/mac/svg/custom/feComponentTransfer-Discrete-expected.txt:
platform/mac/svg/custom/feComponentTransfer-Gamma-expected.txt:
platform/mac/svg/custom/feComponentTransfer-Linear-expected.txt:
platform/mac/svg/custom/feComponentTransfer-Table-expected.txt:
svg/filters/filter-refresh-expected.txt:

3:56 PM Changeset in webkit [225365] by Yusuke Suzuki

2 edits in trunk/Source/JavaScriptCore

[JSC] Use AllocatorIfExists for MaterializeNewObject
https://bugs.webkit.org/show_bug.cgi?id=180189

Reviewed by Filip Pizlo.

I don't think anyone guarantees this allocator exists at this phase.
And nullptr allocator just works here. We change AllocatorForMode
to AllocatorIfExists to accept nullptr for allocator.

ftl/FTLLowerDFGToB3.cpp:

(JSC::FTL::DFG::LowerDFGToB3::compileMaterializeNewObject):

3:50 PM Changeset in webkit [225364] by Chris Dumez

5 edits in trunk/LayoutTests

Unreviewed, unskip service worker test that no longer times out after r225346.

LayoutTests/imported/w3c:

web-platform-tests/service-workers/service-worker/skip-waiting-using-registration.https-expected.txt:
web-platform-tests/service-workers/service-worker/skip-waiting-without-client.https-expected.txt:

LayoutTests:

TestExpectations:

3:47 PM Changeset in webkit [225363] by mark.lam@apple.com

41 edits
2 adds in trunk/Source

Let's scramble MacroAssemblerCodePtr values.
https://bugs.webkit.org/show_bug.cgi?id=180169
<rdar://problem/35758340>

Reviewed by Filip Pizlo, Saam Barati, and JF Bastien.

Source/JavaScriptCore:

MacroAssemblerCodePtr now stores a ScrambledPtr instead of a void*.

MacroAssemblerCodePtr's executableAddress() and dataLocation() now take a template argument type that will be used to cast the result. This makes the client code that uses these functions a little less verbose.

Change the code base in general to minimize passing void* code pointers around. We now pass MacroAssemblerCodePtr as much as possible, and descramble it only at the last moment when we need the underlying code pointer.

Added some MasmScrambledPtr paranoid asserts that are disabled (not built) by default. I'm leaving them in because they are instrumental in finding bugs where not all MacroAssemblerCodePtr values were not scrambled as expected. I expect them to be useful in the near future as we add more scrambling.

Also disable the casting operator on MacroAssemblerCodePtr (except for explicit casts to a boolean). This ensures that clients will always explicitly use scrambledBits() or executableAddress() to get a value based on which value they actually need.

Added currentThread() id to the logging in LLIntSlowPath trace functions. This was helpful when debugging tests that ran multiple VMs concurrently on different threads.

MacroAssemblerCodePtr is currently supported on 64-bit builds (including the
CLoop). It is not yet supported in 32-bit and Windows because we don't
currently have a way to read a global variable from their LLInt code.

assembler/AbstractMacroAssembler.h:

(JSC::AbstractMacroAssembler::differenceBetweenCodePtr):
(JSC::AbstractMacroAssembler::linkPointer):

assembler/CodeLocation.h:

(JSC::CodeLocationCommon::instructionAtOffset):
(JSC::CodeLocationCommon::labelAtOffset):
(JSC::CodeLocationCommon::jumpAtOffset):
(JSC::CodeLocationCommon::callAtOffset):
(JSC::CodeLocationCommon::nearCallAtOffset):
(JSC::CodeLocationCommon::dataLabelPtrAtOffset):
(JSC::CodeLocationCommon::dataLabel32AtOffset):
(JSC::CodeLocationCommon::dataLabelCompactAtOffset):
(JSC::CodeLocationCommon::convertibleLoadAtOffset):

assembler/LinkBuffer.cpp:

(JSC::LinkBuffer::finalizeCodeWithDisassembly):

assembler/LinkBuffer.h:

(JSC::LinkBuffer::link):
(JSC::LinkBuffer::patch):

assembler/MacroAssemblerCodeRef.cpp:

(JSC::MacroAssemblerCodePtr::initialize):

assembler/MacroAssemblerCodeRef.h:

(JSC::FunctionPtr::FunctionPtr):
(JSC::FunctionPtr::value const):
(JSC::FunctionPtr::executableAddress const):
(JSC::ReturnAddressPtr::ReturnAddressPtr):
(JSC::ReturnAddressPtr::value const):
(JSC::MacroAssemblerCodePtr::MacroAssemblerCodePtr):
(JSC::MacroAssemblerCodePtr::createFromExecutableAddress):
(JSC::MacroAssemblerCodePtr::scrambledPtr const):
(JSC::MacroAssemblerCodePtr:: const):
(JSC::MacroAssemblerCodePtr::operator! const):
(JSC::MacroAssemblerCodePtr::operator bool const):
(JSC::MacroAssemblerCodePtr::operator== const):
(JSC::MacroAssemblerCodePtr::hash const):
(JSC::MacroAssemblerCodePtr::emptyValue):
(JSC::MacroAssemblerCodePtr::deletedValue):
(JSC::MacroAssemblerCodePtr::executableAddress const): Deleted.
(JSC::MacroAssemblerCodePtr::dataLocation const): Deleted.

b3/B3LowerMacros.cpp:
b3/testb3.cpp:

(JSC::B3::testInterpreter):

dfg/DFGDisassembler.cpp:

(JSC::DFG::Disassembler::dumpDisassembly):

dfg/DFGJITCompiler.cpp:

(JSC::DFG::JITCompiler::link):
(JSC::DFG::JITCompiler::compileFunction):

dfg/DFGOperations.cpp:
dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::emitSwitchIntJump):
(JSC::DFG::SpeculativeJIT::emitSwitchImm):
(JSC::DFG::SpeculativeJIT::emitSwitchCharStringJump):
(JSC::DFG::SpeculativeJIT::emitSwitchChar):

dfg/DFGSpeculativeJIT.h:
disassembler/Disassembler.cpp:

(JSC::disassemble):

disassembler/UDis86Disassembler.cpp:

(JSC::tryToDisassembleWithUDis86):

ftl/FTLCompile.cpp:

(JSC::FTL::compile):

ftl/FTLJITCode.cpp:

(JSC::FTL::JITCode::executableAddressAtOffset):

ftl/FTLLink.cpp:

(JSC::FTL::link):

ftl/FTLLowerDFGToB3.cpp:

(JSC::FTL::DFG::LowerDFGToB3::compileMathIC):
(JSC::FTL::DFG::LowerDFGToB3::compileCallOrConstruct):
(JSC::FTL::DFG::LowerDFGToB3::compileTailCall):
(JSC::FTL::DFG::LowerDFGToB3::compileCallOrConstructVarargsSpread):
(JSC::FTL::DFG::LowerDFGToB3::compileCallOrConstructVarargs):

interpreter/InterpreterInlines.h:

(JSC::Interpreter::getOpcodeID):

jit/JITArithmetic.cpp:

(JSC::JIT::emitMathICFast):
(JSC::JIT::emitMathICSlow):

jit/JITCode.cpp:

(JSC::JITCodeWithCodeRef::executableAddressAtOffset):
(JSC::JITCodeWithCodeRef::dataAddressAtOffset):
(JSC::JITCodeWithCodeRef::offsetOf):

jit/JITDisassembler.cpp:

(JSC::JITDisassembler::dumpDisassembly):

jit/PCToCodeOriginMap.cpp:

(JSC::PCToCodeOriginMap::PCToCodeOriginMap):

jit/Repatch.cpp:

(JSC::ftlThunkAwareRepatchCall):

jit/ThunkGenerators.cpp:

(JSC::virtualThunkFor):
(JSC::boundThisNoArgsFunctionCallGenerator):

llint/LLIntSlowPaths.cpp:

(JSC::LLInt::llint_trace_operand):
(JSC::LLInt::llint_trace_value):
(JSC::LLInt::handleHostCall):
(JSC::LLInt::setUpCall):

llint/LowLevelInterpreter64.asm:
offlineasm/cloop.rb:
runtime/InitializeThreading.cpp:

(JSC::initializeThreading):

wasm/WasmBBQPlan.cpp:

(JSC::Wasm::BBQPlan::complete):

wasm/WasmCallee.h:

(JSC::Wasm::Callee::entrypoint const):

wasm/WasmCodeBlock.cpp:

(JSC::Wasm::CodeBlock::CodeBlock):

wasm/WasmOMGPlan.cpp:

(JSC::Wasm::OMGPlan::work):

wasm/js/WasmToJS.cpp:

(JSC::Wasm::wasmToJS):

wasm/js/WebAssemblyFunction.cpp:

(JSC::callWebAssemblyFunction):

wasm/js/WebAssemblyFunction.h:
wasm/js/WebAssemblyWrapperFunction.cpp:

(JSC::WebAssemblyWrapperFunction::create):

Source/WTF:

Introduce a ScrambledPtr class to facilitate scrambling.

WTF.xcodeproj/project.pbxproj:
wtf/CMakeLists.txt:
wtf/ScrambledPtr.cpp: Added.

(WTF::makeScrambledPtrKey):

wtf/ScrambledPtr.h: Added.

(WTF::ScrambledPtr::ScrambledPtr):
(WTF::ScrambledPtr::paranoidAssertIsScrambled const):
(WTF::ScrambledPtr::paranoidAssertIsNotScrambled const):
(WTF::ScrambledPtr:: const):
(WTF::ScrambledPtr::operator-> const):
(WTF::ScrambledPtr::scrambledBits const):
(WTF::ScrambledPtr::operator! const):
(WTF::ScrambledPtr::operator bool const):
(WTF::ScrambledPtr::operator== const):
(WTF::ScrambledPtr::operator==):
(WTF::ScrambledPtr::scramble):
(WTF::ScrambledPtr::descramble):

3:44 PM Changeset in webkit [225362] by Yusuke Suzuki

9 edits in trunk/Source

[JSC] Remove easy toRemove & map.remove() use
https://bugs.webkit.org/show_bug.cgi?id=180208

Reviewed by Mark Lam.

Source/JavaScriptCore:

b3/B3MoveConstants.cpp:
dfg/DFGArgumentsEliminationPhase.cpp:
dfg/DFGObjectAllocationSinkingPhase.cpp:
wasm/WasmSignature.cpp:

(JSC::Wasm::SignatureInformation::tryCleanup):

Source/WTF:

Return bool from removeIf. It is true if removeIf removes at least one entry.
This interface is similar to existing HashSet::remove, which returns true
if it actually removes entry.

wtf/HashMap.h:

(WTF::X>::removeIf):

wtf/HashSet.h:

(WTF::V>::removeIf):

wtf/HashTable.h:

(WTF::KeyTraits>::removeIf):

3:39 PM Changeset in webkit [225361] by commit-queue@webkit.org

2 edits in trunk/Tools

[WinCairo] Cannot build without Internet connection
https://bugs.webkit.org/show_bug.cgi?id=180068

Patch by Basuke Suzuki <Basuke Suzuki> on 2017-11-30
Reviewed by Alex Christensen

With no Internet connection, if libraries has been downloaded
before, trust that version and keep building.

Scripts/download-latest-github-release.py:

(Status):
(current_release):
(has_latest_release):
(main):

3:22 PM Changeset in webkit [225360] by Yusuke Suzuki

11 edits in trunk/Source/JavaScriptCore

[JSC] Use getEffectiveAddress more in JSC
https://bugs.webkit.org/show_bug.cgi?id=180154

Reviewed by Mark Lam.

We can use MacroAssembler::getEffectiveAddress for stack height calculation.
And we also add MacroAssembler::negPtr(src, dest) variation.

assembler/MacroAssembler.h:

(JSC::MacroAssembler::negPtr):

assembler/MacroAssemblerARM.h:

(JSC::MacroAssemblerARM::neg32):

assembler/MacroAssemblerARM64.h:

(JSC::MacroAssemblerARM64::neg32):
(JSC::MacroAssemblerARM64::neg64):

assembler/MacroAssemblerARMv7.h:

(JSC::MacroAssemblerARMv7::neg32):

assembler/MacroAssemblerMIPS.h:

(JSC::MacroAssemblerMIPS::neg32):

assembler/MacroAssemblerX86Common.h:

(JSC::MacroAssemblerX86Common::neg32):

assembler/MacroAssemblerX86_64.h:

(JSC::MacroAssemblerX86_64::neg64):

dfg/DFGThunks.cpp:

(JSC::DFG::osrEntryThunkGenerator):

ftl/FTLLowerDFGToB3.cpp:

(JSC::FTL::DFG::LowerDFGToB3::compileCallOrConstructVarargsSpread):

jit/SetupVarargsFrame.cpp:

(JSC::emitSetVarargsFrame):

3:17 PM Changeset in webkit [225359] by Ryan Haddad

2 edits in trunk/Source/WebCore

Unreviewed build fix, removed unused lambda captures.

workers/service/context/ServiceWorkerThread.cpp:

(WebCore::ServiceWorkerThread::postFetchTask):
(WebCore::ServiceWorkerThread::postMessageToServiceWorkerGlobalScope):

3:16 PM Changeset in webkit [225358] by achristensen@apple.com

14 edits
2 adds in trunk

WKURLSchemeHandler.request should include HTTPBody
https://bugs.webkit.org/show_bug.cgi?id=180220

Reviewed by Brady Eidson.

Source/WebKit:

Shared/URLSchemeTaskParameters.cpp: Added.

(WebKit::URLSchemeTaskParameters::encode const):
(WebKit::URLSchemeTaskParameters::decode):

Shared/URLSchemeTaskParameters.h: Added.
UIProcess/API/Cocoa/WKURLSchemeTask.mm:

(-[WKURLSchemeTaskImpl request]):

UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::startURLSchemeTask):

UIProcess/WebPageProxy.h:
UIProcess/WebPageProxy.messages.in:
UIProcess/WebURLSchemeHandler.cpp:

(WebKit::WebURLSchemeHandler::startTask):

UIProcess/WebURLSchemeHandler.h:
UIProcess/WebURLSchemeTask.cpp:

(WebKit::WebURLSchemeTask::create):
(WebKit::WebURLSchemeTask::WebURLSchemeTask):

UIProcess/WebURLSchemeTask.h:
WebKit.xcodeproj/project.pbxproj:
WebProcess/WebPage/WebURLSchemeTaskProxy.cpp:

(WebKit::WebURLSchemeTaskProxy::startLoading):

Tools:

TestWebKitAPI/Tests/WebKitCocoa/_WKInputDelegate.mm:

(-[FormSubmissionDelegate webView:startURLSchemeTask:]):

3:10 PM Changeset in webkit [225357] by jmarcell@apple.com

7 edits in tags/Safari-605.1.14.3/Source

Versioning.

3:06 PM Changeset in webkit [225356] by jmarcell@apple.com

1 copy in tags/Safari-605.1.14.3

New tag.

3:06 PM Changeset in webkit [225355] by Chris Dumez

6 edits
2 moves in trunk/Source/WebCore

Move SWClientConnection class out of server/ folder
https://bugs.webkit.org/show_bug.cgi?id=180217

Reviewed by Brady Eidson.

Move SWClientConnection class out of server/ folder since the client connection
lives in the WebProcess, not the Storage process.

Sources.txt:
WebCore.xcodeproj/project.pbxproj:
workers/service/SWClientConnection.cpp: Renamed from Source/WebCore/workers/service/server/SWClientConnection.cpp.

(WebCore::SWClientConnection::scheduleJob):
(WebCore::SWClientConnection::finishedFetchingScript):
(WebCore::SWClientConnection::failedFetchingScript):
(WebCore::SWClientConnection::jobRejectedInServer):
(WebCore::SWClientConnection::registrationJobResolvedInServer):
(WebCore::SWClientConnection::unregistrationJobResolvedInServer):
(WebCore::SWClientConnection::startScriptFetchForServer):
(WebCore::SWClientConnection::postMessageToServiceWorkerClient):
(WebCore::SWClientConnection::forEachContainer):
(WebCore::SWClientConnection::updateRegistrationState):
(WebCore::SWClientConnection::updateWorkerState):
(WebCore::SWClientConnection::fireUpdateFoundEvent):
(WebCore::SWClientConnection::notifyClientsOfControllerChange):

workers/service/SWClientConnection.h: Renamed from Source/WebCore/workers/service/server/SWClientConnection.h.
workers/service/ServiceWorkerContainer.cpp:

3:04 PM Changeset in webkit [225354] by jmarcell@apple.com

1 copy in tags/Safari-604.5.1

Tag Safari-604.5.1.

3:03 PM Changeset in webkit [225353] by jmarcell@apple.com

1 delete in tags/Safari-604.5.1

Delete tag.

2:51 PM Changeset in webkit [225352] by mark.lam@apple.com

3 edits
1 add in trunk

jsc shell's flashHeapAccess() should not do JS work after releasing access to the heap.
https://bugs.webkit.org/show_bug.cgi?id=180219
<rdar://problem/35696536>

Reviewed by Filip Pizlo.

JSTests:

stress/regress-180219.js: Added.

Source/JavaScriptCore:

jsc.cpp:

(functionFlashHeapAccess):

2:35 PM Changeset in webkit [225351] by Chris Dumez

6 edits in trunk/Source/WebCore

ServiceWorkerThread's m_extendedEvents gets destroyed on the wrong thread
https://bugs.webkit.org/show_bug.cgi?id=180216

Reviewed by Brady Eidson.

ServiceWorkerThread's m_extendedEvents gets destroyed on the wrong thread. Those events live on the worker
thread so we should destroy them on the worker thread, not the main thread. To address the issue, m_extendedEvents
was moved to ServiceWorkerGlobalScope, which actually lives on the right thread.

workers/service/ServiceWorkerGlobalScope.cpp:

(WebCore::ServiceWorkerGlobalScope::updateExtendedEventsSet):

workers/service/ServiceWorkerGlobalScope.h:
workers/service/context/ServiceWorkerThread.cpp:

(WebCore::ServiceWorkerThread::postFetchTask):
(WebCore::ServiceWorkerThread::postMessageToServiceWorkerGlobalScope):
(WebCore::ServiceWorkerThread::updateExtendedEventsSet): Deleted.

workers/service/context/ServiceWorkerThread.h:

(WebCore::ServiceWorkerThread::hasPendingEvents const): Deleted.

2:25 PM Changeset in webkit [225350] by dino@apple.com

2 edits in trunk/LayoutTests

Skip WebGL on iOS while working out what ANGLE has broken.

platform/ios/TestExpectations:

2:21 PM Changeset in webkit [225349] by Matt Lewis

2 edits in trunk/LayoutTests

Marked http/tests/loading/resourceLoadStatistics/partitioned-and-unpartitioned-cookie-deletion.html as flaky on High Sierra.
https://bugs.webkit.org/show_bug.cgi?id=179644

Unreviewed test gardening.

platform/mac-wk2/TestExpectations:

1:49 PM Changeset in webkit [225348] by Matt Lewis

2 edits in trunk/LayoutTests

Marked imported/w3c/web-platform-tests/webrtc/RTCPeerConnection-onnegotiationneeded.html as flak on macOS.
https://bugs.webkit.org/show_bug.cgi?id=176078

Unreviewed test gardening.

platform/mac-wk2/TestExpectations:

1:42 PM Changeset in webkit [225347] by Chris Dumez

3 edits in trunk/Source/WebCore

SWServerToContextConnection / SWServerWorker do not need to be ThreadSafeRefCounted
https://bugs.webkit.org/show_bug.cgi?id=180214

Reviewed by Brady Eidson.

SWServerToContextConnection / SWServerWorker do not need to be ThreadSafeRefCounted.
RefCounted is sufficient as there is no longer any multithreading on server side.

workers/service/server/SWServerToContextConnection.h:
workers/service/server/SWServerWorker.h:

1:41 PM Changeset in webkit [225346] by Chris Dumez

4 edits in trunk

ServiceWorkerGlobalScope::skipWaiting() should resolve its promise
https://bugs.webkit.org/show_bug.cgi?id=180204

Reviewed by Brady Eidson.

LayoutTests/imported/w3c:

Rebaseline test which uses skipWaiting().

web-platform-tests/service-workers/service-worker/claim-with-redirect.https-expected.txt:

Source/WebCore:

ServiceWorkerGlobalScope::skipWaiting() should resolve its promise, even if it is not
implemented yet. For now, always reject the promise.

workers/service/ServiceWorkerGlobalScope.cpp:

(WebCore::ServiceWorkerGlobalScope::skipWaiting):

1:35 PM Changeset in webkit [225345] by jmarcell@apple.com

4 edits
2 adds in branches/safari-604-branch

Cherry-pick r225141. rdar://problem/35732184

1:16 PM Changeset in webkit [225344] by Chris Dumez

5 edits in trunk/Source/WebCore

Mark a few heap-allocated service worker types as WTF_MAKE_FAST_ALLOCATED
https://bugs.webkit.org/show_bug.cgi?id=180212

Reviewed by Geoffrey Garen.

Mark a few heap-allocated service worker types as WTF_MAKE_FAST_ALLOCATED for performance.

workers/service/server/SWOriginStore.h:
workers/service/server/SWServer.h:
workers/service/server/SWServerJobQueue.h:
workers/service/server/SWServerRegistration.h:

1:01 PM Changeset in webkit [225343] by beidson@apple.com

3 edits in trunk/Source/WebCore

Make WorkerThread lifetime much more predictable.
https://bugs.webkit.org/show_bug.cgi?id=180203

Reviewed by Chris Dumez.

No new tests (Fixes flakiness in existing and future tests).

The family of classes related to Workers has a complicated ownership model.

For Dedicated Workers, the WorkerThread object is owned by the WorkerMessagingProxy,
which manages its own lifetime. Additionally, other object(s) have raw C++ references
to it, and the expected lifetimes are described in comments scattered through a few files.

What it boils down to is that the "Worker" DOM object - which lives on the main thread -
is the key to the proper destruction of all of these objects.

For ServiceWorkers running in their own context process, there is no "Worker" on the main thread.

As a result, ServiceWorkers can get into a situation where their WorkerThread can be destroyed before
their ServiceWorkerGlobalScope is destroyed on the running background thread.

There's no reason to not have WorkerThread guarantee its own lifetime until its background thread
has actually completed.

workers/WorkerThread.cpp:

(WebCore::WorkerThread::workerThread): Protect the WorkerThread object during the entire runtime

of the background thread itself, and release that protection on the main thread.

workers/WorkerThread.h:

12:48 PM Changeset in webkit [225342] by Yusuke Suzuki

9 edits
7 adds in trunk

[DFG][FTL] operationHasIndexedProperty does not consider negative int32_t
https://bugs.webkit.org/show_bug.cgi?id=180190

Reviewed by Mark Lam.

JSTests:

stress/operation-in-may-have-negative-int32-array-storage.js: Added.

(shouldBe):
(test1):

stress/operation-in-may-have-negative-int32-contiguous-array.js: Added.

(shouldBe):
(test1):

stress/operation-in-may-have-negative-int32-double-array.js: Added.

(shouldBe):
(test1):

stress/operation-in-may-have-negative-int32-generic-array.js: Added.

(shouldBe):
(test1):

stress/operation-in-may-have-negative-int32-int32-array.js: Added.

(shouldBe):
(test1):

stress/operation-in-may-have-negative-int32.js: Added.

(shouldBe):
(test2):

stress/operation-in-negative-int32-cast.js: Added.

(shouldBe):
(test1):

Source/JavaScriptCore:

If DFG HasIndexedProperty node observes negative index, it goes to a slow
path by calling operationHasIndexedProperty. The problem is that
operationHasIndexedProperty does not account negative index. Negative index
was used as uint32 array index.

In this patch we add a path for negative index in operationHasIndexedProperty.
And rename it to operationHasIndexedPropertyByInt to make intension clear.
We also move operationHasIndexedPropertyByInt from JITOperations to DFGOperations
since it is only used in DFG and FTL.

While fixing this bug, we found that our op_in does not record OutOfBound feedback.
This causes repeated OSR exit and significantly regresses the performance. We opened
a bug to track this issue[1].

[1]: https://bugs.webkit.org/show_bug.cgi?id=180192

dfg/DFGOperations.cpp:
dfg/DFGOperations.h:
dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

ftl/FTLLowerDFGToB3.cpp:

(JSC::FTL::DFG::LowerDFGToB3::compileHasIndexedProperty):

jit/JITOperations.cpp:
jit/JITOperations.h:

12:40 PM Changeset in webkit [225341] by Chris Dumez

15 edits in trunk

Populate self.registration.installing/waiting/active inside service workers
https://bugs.webkit.org/show_bug.cgi?id=180168

Reviewed by Brady Eidson.

LayoutTests/imported/w3c:

Rebaseline a couple of WPT that now pass for checks.

web-platform-tests/service-workers/service-worker/ServiceWorkerGlobalScope/registration-attribute.https-expected.txt:
web-platform-tests/service-workers/service-worker/navigation-redirect.https-expected.txt:

Source/WebCore:

Populate self.registration.installing/waiting/active inside service workers.
Also make sure the ServiceWorker's state properly gets updated inside
service workers.

No new tests, extended existing test for self.registration.

workers/service/ServiceWorker.cpp:

(WebCore::ServiceWorker::scheduleTaskToUpdateState):

workers/service/context/SWContextManager.cpp:

(WebCore::SWContextManager::forEachServiceWorkerThread):

workers/service/context/SWContextManager.h:
workers/service/context/ServiceWorkerThread.cpp:

(WebCore::ServiceWorkerThread::fireInstallEvent):
(WebCore::ServiceWorkerThread::fireActivateEvent):

workers/service/server/SWClientConnection.cpp:

(WebCore::SWClientConnection::updateRegistrationState):
(WebCore::SWClientConnection::updateWorkerState):
(WebCore::SWClientConnection::fireUpdateFoundEvent):

workers/service/server/SWClientConnection.h:

Source/WTF:

Add CrossThreadCopier support for std::optional<>.

wtf/CrossThreadCopier.h:

LayoutTests:

Extend layout test coverage.

http/tests/workers/service/resources/self_registration-worker.js:
http/tests/workers/service/self_registration-expected.txt:

12:39 PM Changeset in webkit [225340] by dino@apple.com

691 edits
2 moves
499 adds
51 deletes in trunk

Update ANGLE
https://bugs.webkit.org/show_bug.cgi?id=180177
<rdar://problem/35774734>

Reviewed by Alex Christensen.

Huge list of changed files omitted.

11:54 AM Changeset in webkit [225339] by jmarcell@apple.com

1 copy in tags/Safari-604.5.1

Tag Safari-604.5.1.

11:52 AM Changeset in webkit [225338] by Chris Dumez

2 edits in trunk/LayoutTests

Unreviewed, unskip a few Service Workers tests that no longer seem to be flaky.

TestExpectations:

11:42 AM Changeset in webkit [225337] by jmarcell@apple.com

7 edits in branches/safari-604-branch/Source

Versioning.

11:29 AM Changeset in webkit [225336] by clopez@igalia.com

1 edit
1 add in trunk/Tools

Add a script for automatically running the buildbot configurations on a test environment.
https://bugs.webkit.org/show_bug.cgi?id=169084

Reviewed by Michael Catanzaro.

This new script does the following:

Creates a temporal workingdir.
Installs buildbot and its dependencies there (very same version used by the webkit.org buildbot master https://build.webkit.org/about ). This is important as there are problems that that may not be detected if you don't test with the same version that will be used on production.
Copies the buildmaster config files to the temporal workingdir.
Performs the required steps to start a buildmaster.
Creates the required config for each slave and starts all of them.

The test buildmaster should be accessible at http://localhost:8710/ allowing to trigger manual builds.
This allows to test any configuration changes on this test environment that is pretty much identical to the production one.

BuildSlaveSupport/build.webkit.org-config/run-buildbot-test.py: Added.

(check_tcp_port_open):
(upgrade_db_needed):
(create_tempdir):
(print_if_error_stdout_stderr):
(setup_master_workdir):
(wait_for_master_ready):
(start_master):
(get_list_workers):
(start_worker):
(clean):
(cmd_exists):
(check_buildbot_installed):
(setup_virtualenv):
(configdir_is_valid):
(main):

11:17 AM Changeset in webkit [225335] by Chris Dumez

5 edits in trunk/Source/WebCore

Rename RegistrationOptions to ServiceWorkerRegistrationOptions
https://bugs.webkit.org/show_bug.cgi?id=180207

Reviewed by Geoffrey Garen.

Rename RegistrationOptions to ServiceWorkerRegistrationOptions as the name
RegistrationOptions is too generic and likely to conflict. Also modernize
ServiceWorkerRegistrationOptions' IPC decoder.

workers/service/ServiceWorkerContainer.h:
workers/service/ServiceWorkerJobData.h:

(WebCore::ServiceWorkerJobData::decode):

workers/service/ServiceWorkerRegistrationOptions.cpp:

(WebCore::ServiceWorkerRegistrationOptions::isolatedCopy const):

workers/service/ServiceWorkerRegistrationOptions.h:

(WebCore::ServiceWorkerRegistrationOptions::encode const):
(WebCore::ServiceWorkerRegistrationOptions::decode):

11:14 AM Changeset in webkit [225334] by aakash_jain@apple.com

2 edits
1 copy
1 add in trunk/Tools

[build.webkit.org] Move python code from master.cfg in separate files
https://bugs.webkit.org/show_bug.cgi?id=180180

Reviewed by Alexey Proskuryakov.

BuildSlaveSupport/build.webkit.org-config/master.cfg: Moved code to steps.py and master.cfg appropriately.
BuildSlaveSupport/build.webkit.org-config/factories.py: Moved all factory related code from master.cfg.
BuildSlaveSupport/build.webkit.org-config/steps.py: Moved all steps related code from master.cfg

11:12 AM Changeset in webkit [225333] by msaboff@apple.com

2 edits in trunk/Source/JavaScriptCore

Allow JSC command line tool to accept UTF8
https://bugs.webkit.org/show_bug.cgi?id=180205

Reviewed by Keith Miller.

This unifies the UTF8 handling of interactive mode with that of source files.

jsc.cpp:

(runInteractive):

10:58 AM Changeset in webkit [225332] by Wenson Hsieh

2 edits in trunk/Tools

WKAttachmentTests.InPlaceImageAttachmentToggleDisplayMode times out on macOS bots
https://bugs.webkit.org/show_bug.cgi?id=180200

Reviewed by Alexey Proskuryakov.

Rewrites an API test to avoid checking against the hard-coded platform-dependent size of an attachment element.
Instead, first insert the attachment element as an icon and compute its size, and then check that the size of
the element is restored to this original value after toggling the display mode to in-place mode and back.

TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:

(-[TestWKWebView attachmentElementSize]):
(-[TestWKWebView waitForAttachmentElementSizeToBecome:]):
(TestWebKitAPI::TEST):
(platformAttachmentIconElementSize): Deleted.

10:17 AM Changeset in webkit [225331] by Darin Adler

10 edits in trunk/Source

[Mac] remove unneeded RetainPtr use introduced in r225142
https://bugs.webkit.org/show_bug.cgi?id=180202

Reviewed by Tim Horton.

Source/WebCore:

editing/mac/DictionaryLookup.h: Changed out arguments back to NSDictionary instead

of RetainPtr because these use autorelease.

editing/mac/DictionaryLookup.mm:

(WebCore::tokenRange): Use NSDictionary .
(WebCore::DictionaryLookup::rangeForSelection): Ditto.
(WebCore::DictionaryLookup::rangeAtHitTestResult): Ditto.
(WebCore::DictionaryLookup::stringForPDFSelection): Ditto.

Source/WebKit:

WebProcess/Plugins/PDF/PDFPlugin.h: Got rid of unnecessary RetainPtr.
WebProcess/Plugins/PDF/PDFPlugin.mm:

(WebKit::PDFPlugin::lookupTextAtLocation const): Ditto.

WebProcess/WebPage/WebPage.h: Ditto.
WebProcess/WebPage/mac/WebPageMac.mm:

(WebKit::WebPage::performDictionaryLookupAtLocation): Ditto.
(WebKit::WebPage::performDictionaryLookupForSelection): Ditto.
(WebKit::WebPage::performImmediateActionHitTestAtLocation): Ditto.
(WebKit::WebPage::lookupTextAtLocation): Ditto.

Source/WebKitLegacy/mac:

WebView/WebImmediateActionController.mm:

(-[WebImmediateActionController _animationControllerForText]): Got rid of unnecessary
RetainPtr.

10:02 AM Changeset in webkit [225330] by Chris Dumez

2 edits in trunk/Source/WebCore

Mark ServiceWorkerGlobalScope as final
https://bugs.webkit.org/show_bug.cgi?id=180201

Reviewed by Alex Christensen.

workers/service/ServiceWorkerGlobalScope.h:

8:24 AM Changeset in webkit [225329] by Ms2ger@igalia.com

5 edits
2 copies
1 add
1 delete in trunk/LayoutTests

[GTK] Enable all wpt touch-events tests.
https://bugs.webkit.org/show_bug.cgi?id=180198

Unreviewed test gardening.

LayoutTests/imported/w3c:

web-platform-tests/touch-events/create-touch-touchlist-expected.txt: Added.
web-platform-tests/touch-events/historical-expected.txt: Renamed from LayoutTests/platform/gtk/imported/w3c/web-platform-tests/touch-events/historical-expected.txt.
web-platform-tests/touch-events/touch-globaleventhandler-interface-expected.txt: Renamed from LayoutTests/platform/gtk/imported/w3c/web-platform-tests/touch-events/touch-globaleventhandler-interface-expected.txt.
web-platform-tests/touch-events/touch-retargeting-expected.txt:
web-platform-tests/touch-events/touch-touchevent-constructor-expected.txt:

LayoutTests:

platform/gtk/TestExpectations:

7:12 AM Changeset in webkit [225328] by zandobersek@gmail.com

7 edits
4 adds in trunk/Source

[CoordGraphics] Move CoordinatedGraphicsLayer painting behind Nicosia::PaintingEngine
https://bugs.webkit.org/show_bug.cgi?id=180141

Reviewed by Carlos Garcia Campos.

Source/WebCore:

Introduce a painting engine concept that's used to perform painting
for a given GraphicsLayer object.

The Nicosia::PaintingEngine object is leveraged in the
CoordinatedGraphicsLayer::updateContentBuffers() method. It's retrieved
through the CoordinatedGraphicsLayerClient interface, with a new method
introduced there for this purpose.

The Nicosia::PaintingEngine interface is kept simple for now, with only
a single paint() method. The only current implementation is the
PaintingEngineBasic class, which simply reuses the code that was
previously in CoordinatedGraphicsLayer::updateContentBuffers(),
maintaining the current functionality.

The Nicosia::PaintingEngine::create() function returns a new
PaintingEngine object. For now it defaults to PaintingEngineBasic, but
it could be configured at configure-time or even runtime in the future
to return a more advanced engine implementation.

No new tests -- no change in behavior.

platform/TextureMapper.cmake:
platform/graphics/nicosia/NicosiaPaintingEngine.cpp: Added.

(Nicosia::PaintingEngine::create):

platform/graphics/nicosia/NicosiaPaintingEngine.h: Added.
platform/graphics/nicosia/NicosiaPaintingEngineBasic.cpp: Added.

(Nicosia::PaintingEngineBasic::paint):

platform/graphics/nicosia/NicosiaPaintingEngineBasic.h: Added.
platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp:

(WebCore::CoordinatedGraphicsLayer::updateContentBuffers):

platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.h:

Source/WebKit:

CompositingCoordinator must implement the paintingEngine() method now
that the method's been added to the CoordinatedGraphicsLayerClient
interface. The CompositingCoordinator manages the Nicosia::PaintingEngine
object through the new m_paintingEngine member variable, and returns the
reference to this object in the paintingEngine() method.

WebProcess/WebPage/CoordinatedGraphics/CompositingCoordinator.cpp:

(WebKit::CompositingCoordinator::CompositingCoordinator):
(WebKit::CompositingCoordinator::paintingEngine):

WebProcess/WebPage/CoordinatedGraphics/CompositingCoordinator.h:

Drop unnecessary typedefs.

7:01 AM Changeset in webkit [225327] by Michael Catanzaro

3 edits in trunk/Tools

[WPE] Stop building Wayland in JHBuild moduleset
https://bugs.webkit.org/show_bug.cgi?id=179951

Reviewed by Žan Doberšek.

Since Wayland is not used for running tests, and since it does not seem to depend on
anything in the JHBuild moduleset, I think we can remove it safely without having to worry
that the system version of Wayland might use libraries in the JHBuild environment (which
would be unsafe).

wpe/install-dependencies: Install Wayland.
wpe/jhbuild.modules: Stop building Wayland.

5:48 AM Changeset in webkit [225326] by Carlos Garcia Campos

2 edits in trunk/Source/WebDriver

WebDriver: locator strategy should be validated before trying to find elements
https://bugs.webkit.org/show_bug.cgi?id=180187

Reviewed by Carlos Alberto Lopez Perez.

We currently rely on the js atom to raise an exception in case the locator strategy is not valid, but in case of
find element from element, if the element doesn't exist we fail with stale element error instead of invalid
argument as expected. So, let's validate the strategies when parsing them, which would also avoid going to the
browser in cae of invalid strategy.

Fixes: imported/w3c/webdriver/tests/retrieval/find_element_from_element.py::test_invalid_using_argument[a]

WebDriverService.cpp:

(WebDriver::isValidStrategy):
(WebDriver::findStrategyAndSelectorOrCompleteWithError):

5:47 AM Changeset in webkit [225325] by Carlos Garcia Campos

5 edits in trunk/Source/WebDriver

WebDriver: remove elementSubmit command
https://bugs.webkit.org/show_bug.cgi?id=180186

Reviewed by Carlos Alberto Lopez Perez.

It's not in the spec, we had it only because selenium used it, but now it uses execute_script with custom code
to implement submit, so we can just remove it.

Session.cpp:

(WebDriver::Session::elementSubmit): Deleted.

Session.h:
WebDriverService.cpp:

(WebDriver::WebDriverService::elementSubmit): Deleted.

WebDriverService.h:

4:30 AM Changeset in webkit [225324] by Antti Koivisto

1 edit
7 adds in trunk/PerformanceTests

Add StyleBench
https://bugs.webkit.org/show_bug.cgi?id=180140

Reviewed by Simon Fraser and Joseph Pecoraro.

StyleBench tests performance of the CSS style resolution and style invalidation. Each test run
creates a large document and a large stylesheet using varying settings. It then applies
a series of mutations to the document and measures the time to update the style and rendering.
The resulting layout is simple, most of the pressure is on selector matching.

StyleBench uses Speedometer framework for UI and measurements. For profiling purposes, it can also
be run locally by opening style-bench.html directly.

There are currently four subtests:

child and descendant combinators only (all other tests have these too).
sibling combinators: '~' and '+'
positional pseudo classes: :nth-child and similar
::before and ::after pseudo elements

The measured DOM mutations are:

add classes
remove classes
add leaf elements
remove leaf elements

StyleBench: Added.
StyleBench/InteractiveRunner.html: Added.

Copied and customized from Speedometer.

StyleBench/index.html: Added.

Copied and customized from Speedometer.

StyleBench/resources: Added.
StyleBench/resources/style-bench.html: Added.
StyleBench/resources/style-bench.js: Added.

The test class.

(Random):
(Random.prototype.get next):
(Random.prototype.chance):
(Random.prototype.number):
(nextAnimationFrame):
(defaultConfiguration):
(descendantCombinatorConfiguration):
(siblingCombinatorConfiguration):
(pseudoClassConfiguration):
(beforeAndAfterConfiguration):
(predefinedConfigurations):

Four predefined configurations.

(prototype.randomElementName):
(prototype.randomCombinator):
(prototype.randomPseudoClass):
(prototype.makeSimpleSelector):
(prototype.makeSelector):
(prototype.get randomColorComponent):
(prototype.makeDeclaration):
(prototype.makeRule):
(prototype.makeStylesheet):
(prototype.makeStyle):
(prototype.makeElement):
(prototype.makeTreeWithDepth):
(prototype.makeTree):
(prototype.updateCachedTestElements):
(prototype.randomTreeElement):
(prototype.addClasses):
(prototype.removeClasses):
(prototype.addLeafElements):
(prototype.removeLeafElements):
(prototype.async.runForever):

StyleBench/resources/tests.js: Added.

(makeSteps):
(makeSuite):

Generates Speedometer Suites.

4:00 AM Changeset in webkit [225323] by Adrian Perez de Castro

2 edits in trunk/Source/WebCore

[GStreamer] Builds fails with ENABLE_VIDEO=OFF due to GStreamer usage
https://bugs.webkit.org/show_bug.cgi?id=179373

Reviewed by Xabier Rodriguez-Calvar.

This allows to build with WebAudio enabled even if video support is
disabled by guarding usage of HTMLMediaElement with ENABLE(VIDEO).

No new tests needed.

page/DeprecatedGlobalSettings.cpp:

(WebCore::DeprecatedGlobalSettings::setGStreamerEnabled): Guard usage of HTMLMediaElement.

3:27 AM Changeset in webkit [225322] by Yusuke Suzuki

3 edits in trunk/Source/JavaScriptCore

REGRESSION(r225314): [Linux] More than 2000 jsc tests are failing after r225314
https://bugs.webkit.org/show_bug.cgi?id=180185

Reviewed by Carlos Garcia Campos.

After r225314, we start using AllocatorForMode::MustAlreadyHaveAllocator for JSRopeString's allocatorFor.
But it is different from the original code used before r225314. Since DFGSpeculativeJIT::emitAllocateJSCell
can accept nullptr allocator, the behavior of the original code is AllocatorForMode::AllocatorIfExists.
And JSRopeString's allocator may not exist at this point if any JSRopeString is not allocated. But MakeRope
DFG node can be emitted if we see untaken path includes String + String code.

This patch fixes Linux JSC crashes by changing JSRopeString's AllocatorForMode to AllocatorIfExists.
As a result, only one user of AllocatorForMode::MustAlreadyHaveAllocator is MaterializeNewObject in FTL.
I'm not sure why this condition (MustAlreadyHaveAllocator) is ensured. But this code is the same to the
original code used before r225314.

dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileMakeRope):

ftl/FTLLowerDFGToB3.cpp:

(JSC::FTL::DFG::LowerDFGToB3::compileMakeRope):

2:13 AM WebKitGTK/Gardening/Calendar edited by Ms2ger@igalia.com

(diff)

12:21 AM Changeset in webkit [225321] by ap@apple.com

2 edits in trunk/Tools

Silence the BitVector leak for
https://bugs.webkit.org/show_bug.cgi?id=121662

The out of line data pointer isn't stored directly, so the leaks tool cannot see it.

Scripts/webkitpy/port/leakdetector.py:

(LeakDetector._callstacks_to_exclude_from_leaks):

Nov 29, 2017:

11:53 PM Changeset in webkit [225320] by jfbastien@apple.com

7 edits
1 add in trunk/Source

WTF / bmalloc: don't write to 0xbbadbeef when ASAN is looking
https://bugs.webkit.org/show_bug.cgi?id=180175

Reviewed by Mark Lam.

ASAN knows that 0xbbadbeef is a bbad aaddress, and tells us so
when we write to it, say in an assert. That creates bbad error
reports where ASAN thinks we write to an invalid address, instead
of thinking that we hit an assertion. In some cases, tooling that
use fuzzers aggregate similar issues, and think that we just have
the one bug and not a bunch of different asserts.

Source/bmalloc:

At the same time, bmalloc's version of CRASH just writes to
0xbbadbeef and assumes that's invalid and will crash, which isn't
necessarily true on non-Mac platforms. WTF's version then makes
sure there's a crash, so bmalloc should do the same.

bmalloc.xcodeproj/project.pbxproj:
bmalloc/BAssert.h:
bmalloc/BCompiler.h: Added.
bmalloc/BPlatform.h:

Source/WTF:

wtf/Assertions.cpp:
wtf/Assertions.h:

11:45 PM Changeset in webkit [225319] by aakash_jain@apple.com

2 edits in trunk/Tools

Fix build.webkit.org broken unit-test after r225080
https://bugs.webkit.org/show_bug.cgi?id=180176

Reviewed by Carlos Garcia Campos.

BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py: Updated expected_build_steps.

10:49 PM Changeset in webkit [225318] by jmarcell@apple.com

1 copy in tags/Safari-605.1.15

Tag Safari-605.1.15.

10:15 PM Changeset in webkit [225317] by graouts@webkit.org

3 edits in trunk/LayoutTests

Move modern media controls test expectations from ios-simulator to ios
https://bugs.webkit.org/show_bug.cgi?id=180158

Reviewed by Dean Jackson.

We shouldn't be using the ios-simulator platform for these, ios is the right one.

platform/ios-simulator/TestExpectations:
platform/ios/TestExpectations:

10:13 PM Changeset in webkit [225316] by Chris Dumez

5 edits in trunk/Source/WebCore

ServiceWorker WebProcess sometimes crashes in JSVMClientData::~JSVMClientData()
https://bugs.webkit.org/show_bug.cgi?id=180173

Reviewed by Alex Christensen.

The leak was caused by EventListeners remaining when destroying the VM, because
JSEventListener refs the DOMWrapperWorld. To address the issue, we now call
removeAllEventListeners() in the stop() method of ServiceWorkerContainer,
ServiceWorkerRegistration and ServiceWorker. Those event listeners are no
longer needed after ActiveDOMObject::stop() is called since the script
execution context is about to be destroyed.

This is the same pattern used in IDBDatabase::stop(), IDBRequest::stop().

No new tests, already covered by existing test.

workers/service/ServiceWorker.cpp:

(WebCore::ServiceWorker::stop):

workers/service/ServiceWorkerContainer.cpp:

(WebCore::ServiceWorkerContainer::stop):

workers/service/ServiceWorkerContainer.h:
workers/service/ServiceWorkerRegistration.cpp:

(WebCore::ServiceWorkerRegistration::stop):

8:48 PM Changeset in webkit [225315] by fpizlo@apple.com

2 edits in trunk/Source/JavaScriptCore

CodeBlockSet::deleteUnmarkedAndUnreferenced can be a little more efficient
https://bugs.webkit.org/show_bug.cgi?id=180108

Reviewed by Saam Barati.

This was creating a vector of things to remove and then removing them. I think I remember writing
this code, and I did that because at the time we did not have removeAllMatching, which is
definitely better. This is a minuscule optimization for Speedometer. I wanted to land this
obvious improvement before I did more fundamental things to this code.

heap/CodeBlockSet.cpp:

(JSC::CodeBlockSet::deleteUnmarkedAndUnreferenced):

8:39 PM Changeset in webkit [225314] by fpizlo@apple.com

60 edits
8 moves
13 adds in trunk/Source

GC should support isoheaps
https://bugs.webkit.org/show_bug.cgi?id=179288

Reviewed by Saam Barati.
Source/JavaScriptCore:

This expands the power of the Subspace API in JSC:

Everything associated with describing the types of objects is now part of the HeapCellType class. We have different HeapCellTypes for different destruction strategies. Any Subspace can use any HeapCellType; these are orthogonal things.

There are now two variants of Subspace: CompleteSubspace, which can allocate any size objects using any AlignedMemoryAllocator; and IsoSubspace, which can allocate just one size of object and uses a special virtual memory pool for that purpose. Like bmalloc's IsoHeap, IsoSubspace hoards virtual pages but releases the physical pages as part of the respective allocator's scavenging policy (the Scavenger in bmalloc for IsoHeap and the incremental sweep and full sweep in Riptide for IsoSubspace).

So far, this patch just puts subtypes of ExecutableBase in IsoSubspaces. If it works, we can use it
for more things.

This does not have any effect on JetStream (0.18% faster with p = 0.69).

JavaScriptCore.xcodeproj/project.pbxproj:
Sources.txt:
bytecode/AccessCase.cpp:

(JSC::AccessCase::generateImpl):

bytecode/ObjectAllocationProfileInlines.h:

(JSC::ObjectAllocationProfile::initializeProfile):

dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::emitAllocateRawObject):
(JSC::DFG::SpeculativeJIT::compileMakeRope):
(JSC::DFG::SpeculativeJIT::compileAllocatePropertyStorage):
(JSC::DFG::SpeculativeJIT::compileReallocatePropertyStorage):

dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

ftl/FTLAbstractHeapRepository.h:
ftl/FTLLowerDFGToB3.cpp:

(JSC::FTL::DFG::LowerDFGToB3::compileMakeRope):
(JSC::FTL::DFG::LowerDFGToB3::compileMaterializeNewObject):
(JSC::FTL::DFG::LowerDFGToB3::allocatePropertyStorageWithSizeImpl):
(JSC::FTL::DFG::LowerDFGToB3::allocateObject):
(JSC::FTL::DFG::LowerDFGToB3::allocatorForSize):

heap/AlignedMemoryAllocator.cpp:

(JSC::AlignedMemoryAllocator::registerAllocator):
(JSC::AlignedMemoryAllocator::registerSubspace):

heap/AlignedMemoryAllocator.h:

(JSC::AlignedMemoryAllocator::firstAllocator const):

heap/AllocationFailureMode.h: Added.
heap/CompleteSubspace.cpp: Added.

(JSC::CompleteSubspace::CompleteSubspace):
(JSC::CompleteSubspace::~CompleteSubspace):
(JSC::CompleteSubspace::allocatorFor):
(JSC::CompleteSubspace::allocate):
(JSC::CompleteSubspace::allocateNonVirtual):
(JSC::CompleteSubspace::allocatorForSlow):
(JSC::CompleteSubspace::allocateSlow):
(JSC::CompleteSubspace::tryAllocateSlow):

heap/CompleteSubspace.h: Added.

(JSC::CompleteSubspace::offsetOfAllocatorForSizeStep):
(JSC::CompleteSubspace::allocatorForSizeStep):
(JSC::CompleteSubspace::allocatorForNonVirtual):

heap/HeapCellType.cpp: Added.

(JSC::HeapCellType::HeapCellType):
(JSC::HeapCellType::~HeapCellType):
(JSC::HeapCellType::finishSweep):
(JSC::HeapCellType::destroy):

heap/HeapCellType.h: Added.

(JSC::HeapCellType::attributes const):

heap/IsoAlignedMemoryAllocator.cpp: Added.

(JSC::IsoAlignedMemoryAllocator::IsoAlignedMemoryAllocator):
(JSC::IsoAlignedMemoryAllocator::~IsoAlignedMemoryAllocator):
(JSC::IsoAlignedMemoryAllocator::tryAllocateAlignedMemory):
(JSC::IsoAlignedMemoryAllocator::freeAlignedMemory):
(JSC::IsoAlignedMemoryAllocator::dump const):

heap/IsoAlignedMemoryAllocator.h: Added.
heap/IsoSubspace.cpp: Added.

(JSC::IsoSubspace::IsoSubspace):
(JSC::IsoSubspace::~IsoSubspace):
(JSC::IsoSubspace::allocatorFor):
(JSC::IsoSubspace::allocatorForNonVirtual):
(JSC::IsoSubspace::allocate):
(JSC::IsoSubspace::allocateNonVirtual):

heap/IsoSubspace.h: Added.

(JSC::IsoSubspace::size const):

heap/MarkedAllocator.cpp:

(JSC::MarkedAllocator::MarkedAllocator):
(JSC::MarkedAllocator::setSubspace):
(JSC::MarkedAllocator::allocateSlowCase):
(JSC::MarkedAllocator::tryAllocateSlowCase): Deleted.
(JSC::MarkedAllocator::allocateSlowCaseImpl): Deleted.

heap/MarkedAllocator.h:

(JSC::MarkedAllocator::nextAllocatorInAlignedMemoryAllocator const):
(JSC::MarkedAllocator::setNextAllocatorInAlignedMemoryAllocator):

heap/MarkedAllocatorInlines.h:

(JSC::MarkedAllocator::allocate):
(JSC::MarkedAllocator::tryAllocate): Deleted.

heap/MarkedBlock.h:
heap/MarkedBlockInlines.h:

(JSC::MarkedBlock::Handle::finishSweepKnowingHeapCellType):
(JSC::MarkedBlock::Handle::finishSweepKnowingSubspace): Deleted.

heap/MarkedSpace.cpp:

(JSC::MarkedSpace::addMarkedAllocator):

heap/MarkedSpace.h:
heap/Subspace.cpp:

(JSC::Subspace::Subspace):
(JSC::Subspace::initialize):
(JSC::Subspace::finishSweep):
(JSC::Subspace::destroy):
(JSC::Subspace::prepareForAllocation):
(JSC::Subspace::findEmptyBlockToSteal):
(): Deleted.
(JSC::Subspace::allocate): Deleted.
(JSC::Subspace::tryAllocate): Deleted.
(JSC::Subspace::allocatorForSlow): Deleted.
(JSC::Subspace::allocateSlow): Deleted.
(JSC::Subspace::tryAllocateSlow): Deleted.
(JSC::Subspace::didAllocate): Deleted.

heap/Subspace.h:

(JSC::Subspace::heapCellType const):
(JSC::Subspace::nextSubspaceInAlignedMemoryAllocator const):
(JSC::Subspace::setNextSubspaceInAlignedMemoryAllocator):
(JSC::Subspace::offsetOfAllocatorForSizeStep): Deleted.
(JSC::Subspace::allocatorForSizeStep): Deleted.
(JSC::Subspace::tryAllocatorFor): Deleted.
(JSC::Subspace::allocatorFor): Deleted.

jit/AssemblyHelpers.h:

(JSC::AssemblyHelpers::emitAllocateJSObjectWithKnownSize):
(JSC::AssemblyHelpers::emitAllocateVariableSized):
(JSC::AssemblyHelpers::emitAllocateVariableSizedCell):

jit/JITOpcodes.cpp:

(JSC::JIT::emit_op_new_object):

runtime/ButterflyInlines.h:

(JSC::Butterfly::createUninitialized):
(JSC::Butterfly::tryCreate):
(JSC::Butterfly::growArrayRight):

runtime/DirectArguments.cpp:

(JSC::DirectArguments::overrideThings):

runtime/DirectArguments.h:

(JSC::DirectArguments::subspaceFor):

runtime/DirectEvalExecutable.h:
runtime/EvalExecutable.h:
runtime/ExecutableBase.h:

(JSC::ExecutableBase::subspaceFor):

runtime/FunctionExecutable.h:
runtime/GenericArgumentsInlines.h:

(JSC::GenericArguments<Type>::initModifiedArgumentsDescriptor):

runtime/HashMapImpl.h:

(JSC::HashMapBuffer::create):

runtime/IndirectEvalExecutable.h:
runtime/JSArray.cpp:

(JSC::JSArray::tryCreateUninitializedRestricted):
(JSC::JSArray::unshiftCountSlowCase):

runtime/JSArray.h:

(JSC::JSArray::tryCreate):

runtime/JSArrayBufferView.cpp:

(JSC::JSArrayBufferView::ConstructionContext::ConstructionContext):

runtime/JSCell.h:

(JSC::subspaceFor):

runtime/JSCellInlines.h:

(JSC::JSCell::subspaceFor):
(JSC::tryAllocateCellHelper):
(JSC::allocateCell):
(JSC::tryAllocateCell):

runtime/JSDestructibleObject.h:

(JSC::JSDestructibleObject::subspaceFor):

runtime/JSDestructibleObjectHeapCellType.cpp: Copied from Source/JavaScriptCore/runtime/JSDestructibleObjectSubspace.cpp.

(JSC::JSDestructibleObjectHeapCellType::JSDestructibleObjectHeapCellType):
(JSC::JSDestructibleObjectHeapCellType::~JSDestructibleObjectHeapCellType):
(JSC::JSDestructibleObjectHeapCellType::finishSweep):
(JSC::JSDestructibleObjectHeapCellType::destroy):
(JSC::JSDestructibleObjectSubspace::JSDestructibleObjectSubspace): Deleted.
(JSC::JSDestructibleObjectSubspace::~JSDestructibleObjectSubspace): Deleted.
(JSC::JSDestructibleObjectSubspace::finishSweep): Deleted.
(JSC::JSDestructibleObjectSubspace::destroy): Deleted.

runtime/JSDestructibleObjectHeapCellType.h: Copied from Source/JavaScriptCore/runtime/JSDestructibleObjectSubspace.h.
runtime/JSDestructibleObjectSubspace.cpp: Removed.
runtime/JSDestructibleObjectSubspace.h: Removed.
runtime/JSLexicalEnvironment.h:

(JSC::JSLexicalEnvironment::subspaceFor):

runtime/JSSegmentedVariableObject.h:

(JSC::JSSegmentedVariableObject::subspaceFor):

runtime/JSSegmentedVariableObjectHeapCellType.cpp: Copied from Source/JavaScriptCore/runtime/JSSegmentedVariableObjectSubspace.cpp.

(JSC::JSSegmentedVariableObjectHeapCellType::JSSegmentedVariableObjectHeapCellType):
(JSC::JSSegmentedVariableObjectHeapCellType::~JSSegmentedVariableObjectHeapCellType):
(JSC::JSSegmentedVariableObjectHeapCellType::finishSweep):
(JSC::JSSegmentedVariableObjectHeapCellType::destroy):
(JSC::JSSegmentedVariableObjectSubspace::JSSegmentedVariableObjectSubspace): Deleted.
(JSC::JSSegmentedVariableObjectSubspace::~JSSegmentedVariableObjectSubspace): Deleted.
(JSC::JSSegmentedVariableObjectSubspace::finishSweep): Deleted.
(JSC::JSSegmentedVariableObjectSubspace::destroy): Deleted.

runtime/JSSegmentedVariableObjectHeapCellType.h: Copied from Source/JavaScriptCore/runtime/JSSegmentedVariableObjectSubspace.h.
runtime/JSSegmentedVariableObjectSubspace.cpp: Removed.
runtime/JSSegmentedVariableObjectSubspace.h: Removed.
runtime/JSString.h:

(JSC::JSString::subspaceFor):

runtime/JSStringHeapCellType.cpp: Copied from Source/JavaScriptCore/runtime/JSStringSubspace.cpp.

(JSC::JSStringHeapCellType::JSStringHeapCellType):
(JSC::JSStringHeapCellType::~JSStringHeapCellType):
(JSC::JSStringHeapCellType::finishSweep):
(JSC::JSStringHeapCellType::destroy):
(JSC::JSStringSubspace::JSStringSubspace): Deleted.
(JSC::JSStringSubspace::~JSStringSubspace): Deleted.
(JSC::JSStringSubspace::finishSweep): Deleted.
(JSC::JSStringSubspace::destroy): Deleted.

runtime/JSStringHeapCellType.h: Copied from Source/JavaScriptCore/runtime/JSStringSubspace.h.
runtime/JSStringSubspace.cpp: Removed.
runtime/JSStringSubspace.h: Removed.
runtime/ModuleProgramExecutable.h:
runtime/NativeExecutable.h:
runtime/ProgramExecutable.h:
runtime/RegExpMatchesArray.h:

(JSC::tryCreateUninitializedRegExpMatchesArray):

runtime/ScopedArguments.h:

(JSC::ScopedArguments::subspaceFor):

runtime/VM.cpp:

(JSC::VM::VM):

runtime/VM.h:

(JSC::VM::gigacageAuxiliarySpace):

wasm/js/JSWebAssemblyCodeBlock.h:
wasm/js/JSWebAssemblyCodeBlockHeapCellType.cpp: Copied from Source/JavaScriptCore/wasm/js/JSWebAssemblyCodeBlockSubspace.cpp.

(JSC::JSWebAssemblyCodeBlockHeapCellType::JSWebAssemblyCodeBlockHeapCellType):
(JSC::JSWebAssemblyCodeBlockHeapCellType::~JSWebAssemblyCodeBlockHeapCellType):
(JSC::JSWebAssemblyCodeBlockHeapCellType::finishSweep):
(JSC::JSWebAssemblyCodeBlockHeapCellType::destroy):
(JSC::JSWebAssemblyCodeBlockSubspace::JSWebAssemblyCodeBlockSubspace): Deleted.
(JSC::JSWebAssemblyCodeBlockSubspace::~JSWebAssemblyCodeBlockSubspace): Deleted.
(JSC::JSWebAssemblyCodeBlockSubspace::finishSweep): Deleted.
(JSC::JSWebAssemblyCodeBlockSubspace::destroy): Deleted.

wasm/js/JSWebAssemblyCodeBlockHeapCellType.h: Copied from Source/JavaScriptCore/wasm/js/JSWebAssemblyCodeBlockSubspace.h.
wasm/js/JSWebAssemblyCodeBlockSubspace.cpp: Removed.
wasm/js/JSWebAssemblyCodeBlockSubspace.h: Removed.
wasm/js/JSWebAssemblyMemory.h:

(JSC::JSWebAssemblyMemory::subspaceFor):

Source/WebCore:

No new tests because no new behavior.

Adopting changes in JSC Subspace API.

ForwardingHeaders/runtime/JSDestructibleObjectHeapCellType.h: Added.
ForwardingHeaders/runtime/JSSegmentedVariableObjectHeapCellType.h: Added.
bindings/js/JSDOMWrapper.cpp:

(WebCore::outputConstraintSubspaceFor):
(WebCore::globalObjectOutputConstraintSubspaceFor):

bindings/js/JSDOMWrapper.h:
bindings/js/WebCoreJSClientData.cpp:

(WebCore::JSVMClientData::JSVMClientData):

bindings/js/WebCoreJSClientData.h:

(WebCore::JSVMClientData::outputConstraintSpace):
(WebCore::JSVMClientData::globalObjectOutputConstraintSpace):

bindings/scripts/CodeGeneratorJS.pm:

(GenerateHeader):

Source/WTF:

One of my favorite data structures in the GC is a singly-linked list that knows its tail, so that
things get added to it at the end rather that at the beginning. In this patch, I use this to put
the same node on multiple lists, which our existing linked list templates also don't support.

This adds a new linked list that does those things:

It supports append(). It could also support prepend(), but currently there is no need for it.

It supports nodes that are on multiple lists. The GC uses std::mem_fn() to create a lambda that the list uses to set next.

WTF.xcodeproj/project.pbxproj:
wtf/SinglyLinkedListWithTail.h: Added.

(WTF::SinglyLinkedListWithTail::isEmpty const):
(WTF::SinglyLinkedListWithTail::append):
(WTF::SinglyLinkedListWithTail::first const):
(WTF::SinglyLinkedListWithTail::last const):

7:36 PM Changeset in webkit [225313] by eric.carlson@apple.com

15 edits in trunk/Source/WebCore

[MediaStream] Clean up audio and video capture factories
https://bugs.webkit.org/show_bug.cgi?id=180156
<rdar://problem/35753435>

Reviewed by Youenn Fablet.

No new tests, no behavior change.

platform/mediastream/RealtimeMediaSourceCenter.cpp:

(WebCore::RealtimeMediaSourceCenter::setAudioFactory): Deleted.
(WebCore::RealtimeMediaSourceCenter::unsetAudioFactory): Deleted.
(WebCore::RealtimeMediaSourceCenter::audioFactory): Deleted.
(WebCore::RealtimeMediaSourceCenter::setVideoFactory): Deleted.
(WebCore::RealtimeMediaSourceCenter::unsetVideoFactory): Deleted.
(WebCore::RealtimeMediaSourceCenter::videoFactory): Deleted.
(WebCore::RealtimeMediaSourceCenter::setAudioCaptureDeviceManager): Deleted.
(WebCore::RealtimeMediaSourceCenter::unsetAudioCaptureDeviceManager): Deleted.
(WebCore::RealtimeMediaSourceCenter::audioCaptureDeviceManager): Deleted.
(WebCore::RealtimeMediaSourceCenter::setVideoCaptureDeviceManager): Deleted.
(WebCore::RealtimeMediaSourceCenter::unsetVideoCaptureDeviceManager): Deleted.
(WebCore::RealtimeMediaSourceCenter::videoCaptureDeviceManager): Deleted.

platform/mediastream/RealtimeMediaSourceCenter.h:

(WebCore::RealtimeMediaSourceCenter::setAudioFactory):
(WebCore::RealtimeMediaSourceCenter::unsetAudioFactory):

platform/mediastream/RealtimeMediaSourceSettings.cpp:

(WebCore::RealtimeMediaSourceSettings::facingMode):
(WebCore::RealtimeMediaSourceSettings::videoFacingModeEnum):
(WebCore::userFacing): Deleted.
(WebCore::environmentFacing): Deleted.
(WebCore::leftFacing): Deleted.
(WebCore::rightFacing): Deleted.

platform/mediastream/RealtimeMediaSourceSettings.h:

(WebCore::RealtimeMediaSourceSettings::RealtimeMediaSourceSettings): Deleted.

platform/mediastream/mac/AVVideoCaptureSource.h:
platform/mediastream/mac/AVVideoCaptureSource.mm:

(WebCore::AVVideoCaptureSource::create):
(WebCore::AVVideoCaptureSource::~AVVideoCaptureSource):
(WebCore::AVVideoCaptureSource::setupCaptureSession):
(): Deleted.
(WebCore::AVVideoCaptureSourceFactory::setVideoCapturePageState): Deleted.
(WebCore::avVideoCaptureSourceFactory): Deleted.
(WebCore::AVVideoCaptureSource::factory): Deleted.

platform/mediastream/mac/RealtimeMediaSourceCenterMac.cpp:

(WebCore::videoCaptureSourceFactory):
(WebCore::RealtimeMediaSourceCenterMac::audioFactory):
(WebCore::RealtimeMediaSourceCenterMac::videoFactory):
(WebCore::RealtimeMediaSourceCenterMac::audioCaptureDeviceManager):
(WebCore::RealtimeMediaSourceCenterMac::videoCaptureDeviceManager):
(WebCore::RealtimeMediaSourceCenterMac::RealtimeMediaSourceCenterMac): Deleted.
(WebCore::RealtimeMediaSourceCenterMac::defaultAudioFactory): Deleted.
(WebCore::RealtimeMediaSourceCenterMac::defaultVideoFactory): Deleted.
(WebCore::RealtimeMediaSourceCenterMac::defaultAudioCaptureDeviceManager): Deleted.
(WebCore::RealtimeMediaSourceCenterMac::defaultVideoCaptureDeviceManager): Deleted.

platform/mediastream/mac/RealtimeMediaSourceCenterMac.h:
platform/mock/MockRealtimeAudioSource.cpp:

(WebCore::MockRealtimeAudioSource::~MockRealtimeAudioSource):
(WebCore::MockRealtimeAudioSource::startProducingData):

platform/mock/MockRealtimeMediaSourceCenter.h:
platform/mock/MockRealtimeVideoSource.cpp:

(WebCore::MockRealtimeVideoSource::~MockRealtimeVideoSource):
(WebCore::MockRealtimeVideoSource::startProducingData):

platform/mock/MockRealtimeVideoSource.h:

6:31 PM Changeset in webkit [225312] by Chris Dumez

3 edits in trunk/LayoutTests

LayoutTest http/tests/workers/service/registration-clear-redundant-worker.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=179778

Reviewed by Youenn Fablet.

As per the specification [1], when clearing a registration, the registration's workers are first
marked as redundant *before* the registration's worker is set to null.

The test was waiting for the service worker's state to become redundant and then checking in a
setTimeout(0) that the registration's worker became null. However, a setTimeout(0) is racy here.
To address the issue, we now use setInterval() and wait until the worker becomes null.

[1] https://w3c.github.io/ServiceWorker/#clear-registration-algorithm

TestExpectations:
http/tests/workers/service/registration-clear-redundant-worker.html:

6:23 PM Changeset in webkit [225311] by Wenson Hsieh

22 edits
1 copy in trunk

[Attachment Support] Implement SPI for clients to make an attachment element display in-place
https://bugs.webkit.org/show_bug.cgi?id=180153
<rdar://problem/35735252>

Reviewed by Tim Horton.

Source/WebCore:

Adds SPI support for inserting attachments using in-place display style, and updating display options for
existing attachments. See comments below for more detail.

Tests: WKAttachmentTests.InPlaceImageAttachmentToggleDisplayMode

WKAttachmentTests.InPlaceImageAttachmentParagraphInsertion
WKAttachmentTests.InPlaceVideoAttachmentInsertionWithinList
WKAttachmentTests.InPlacePDFAttachmentCutAndPaste

WebCore.xcodeproj/project.pbxproj:
editing/Editor.cpp:

(WebCore::Editor::insertAttachment):
(WebCore::Editor::insertAttachmentFromFile):

Update display options for the attachment before inserting into the document.

editing/Editor.h:
html/AttachmentTypes.h: Added.

Add a new header to define the new attachment display types. This lets us avoid importing HTMLAttachmentElement.h
and instead just import AttachmentTypes.h in some places in WebKit that only deal with plumbing
AttachmentDisplayOptions to the web process.

(WebCore::AttachmentDisplayOptions::encode const):
(WebCore::AttachmentDisplayOptions::decode):

Support serializing and deserializing attachment display options.

html/HTMLAttachmentElement.cpp:

(WebCore::HTMLAttachmentElement::setFile):

Regenerate the shadow root if needed when setting the file.

(WebCore::HTMLAttachmentElement::updateDisplayMode):

Introduce a new method to update the display mode of an attachment element. This builds up the shadow root of
the attachment if it is displayed in-place.

(WebCore::HTMLAttachmentElement::ensureInnerImage):
(WebCore::HTMLAttachmentElement::ensureInnerVideo):

Helpers to insert image and video elements into the shadow root if needed, and return the image or video element.

(WebCore::HTMLAttachmentElement::innerImage const):
(WebCore::HTMLAttachmentElement::innerVideo const):

Helpers to retrieve existing image and video elements in the shadow root.

(WebCore::HTMLAttachmentElement::populateShadowRootIfNecessary):

Appends and configures the attachment element's shadow root for inline display, initializing an image or video
element or neither, depending on the attachment type.

html/HTMLAttachmentElement.h:

Introduce an AttachmentDisplayOptions struct which mirrors _WKAttachmentDisplayOptions in the WebKit layer. For
now, this only contains a display mode enum.

platform/audio/ios/AudioSessionIOS.mm:

Avoid this AVAudioSession assertion when targeting iOS simulator. AVAudioSession always throws this error when
setting an audio session category in the simulator, even in a basic test app, since AVFoundation doesn't support
audio sessions in the simulator.

(WebCore::AudioSession::setCategory):

Source/WebKit:

Add new WebKit SPI, -[_WKAttachment setDisplayOptions:completion:], and add plumbing for attachment display
options to the web content process. Changes covered by 4 new API tests.

Scripts/webkit/messages.py:

(headers_for_type):

UIProcess/API/APIAttachment.cpp:

(API::Attachment::setDisplayOptions):

UIProcess/API/APIAttachment.h:
UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _insertAttachmentWithFilename:contentType:data:options:completion:]):

Respect given display options when inserting a new attachment.

UIProcess/API/Cocoa/_WKAttachment.h:
UIProcess/API/Cocoa/_WKAttachment.mm:

(-[_WKAttachmentDisplayOptions coreDisplayOptions]):

Introduce a helper to convert from the Cocoa _WKAttachmentDisplayOptions object to platform-agnostic
AttachmentDisplayOptions.

(-[_WKAttachment setDisplayOptions:completion:]):
(WebKit::if): Deleted.

UIProcess/API/Cocoa/_WKAttachmentInternal.h:
UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::insertAttachment):
(WebKit::WebPageProxy::setAttachmentDisplayOptions):

UIProcess/WebPageProxy.h:
WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::insertAttachment):
(WebKit::WebPage::requestAttachmentData):
(WebKit::WebPage::setAttachmentDisplayOptions):
(WebKit::WebPage::attachmentElementWithIdentifier const):

Pull common logic to retrieve an attachment element matching a given identifier out into a helper.

WebProcess/WebPage/WebPage.h:
WebProcess/WebPage/WebPage.messages.in:

Tools:

Adds new API tests to cover inserting in-place attachments and updating the display mode of existing attachments,
as well as performing a few editing operations (paragraph insertion, cut/paste, list insertion) on attachment
elements.

TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:

(platformAttachmentIconElementSize):
(testVideoData):
(testPDFData):
(displayOptionsWithMode):
(-[TestWKWebView waitForAttachmentElementSizeToBecome:]):
(-[_WKAttachment synchronouslySetDisplayOptions:error:]):
(TestWebKitAPI::TEST):

5:50 PM Changeset in webkit [225310] by Simon Fraser

3 edits in trunk/Source/WebCore

Missing layer content when animating elements on-screen
https://bugs.webkit.org/show_bug.cgi?id=180178
rdar://problem/34923438

Reviewed by Dean Jackson.

If a delayed animation starts, that animates layers from offscreen, then we would fail
to run the logic that ensures that those layers have backing store.

Fix by ensuring that if any layer starts or ends a transform animation, we re-evaluate
backing store attachment on all its descendants.

I tried to make a test, but layer flushing is timing-sensitive and the test would have taken
5s, and not been reliable. There's a manual test in the bug.

platform/graphics/ca/GraphicsLayerCA.cpp:

(WebCore::GraphicsLayerCA::recursiveCommitChanges):

platform/graphics/ca/GraphicsLayerCA.h:

5:40 PM Changeset in webkit [225309] by Brent Fulgham

12 edits in trunk/Source

Part 2: Adopt updated NSKeyed[Un]Archiver API when available
https://bugs.webkit.org/show_bug.cgi?id=180127
<rdar://problem/35710738>

Reviewed by Simon Fraser.

The API that accepts a user-allocated NSMutableData is deprecated. Switch (for macOS 10.12 and newer)
to the modern API. Use the original API for macOS builds prior to 10.12.

Source/WebCore/PAL:

pal/spi/cocoa/NSKeyedArchiverSPI.h:

(secureArchiver): Added.
(secureArchiverFromMutableData): Deleted.

Source/WebKit:

Shared/Cocoa/DataDetectionResult.mm:

(WebKit::DataDetectionResult::encode const):

Shared/Cocoa/WebCoreArgumentCodersCocoa.mm:

(IPC::ArgumentCoder<WebCore::Payment>::encode):
(IPC::ArgumentCoder<WebCore::PaymentContact>::encode):
(IPC::ArgumentCoder<WebCore::PaymentMerchantSession>::encode):
(IPC::ArgumentCoder<WebCore::PaymentMethod>::encode):

Shared/ios/InteractionInformationAtPosition.mm:

(WebKit::InteractionInformationAtPosition::encode const):

Shared/mac/WebCoreArgumentCodersMac.mm:

(IPC::ArgumentCoder<ProtectionSpace>::encodePlatformData):
(IPC::ArgumentCoder<Credential>::encodePlatformData):
(IPC::ArgumentCoder<ContentFilterUnblockHandler>::encode):
(IPC::ArgumentCoder<MediaPlaybackTargetContext>::encodePlatformData):

Shared/mac/WebHitTestResultData.mm:

(WebKit::WebHitTestResultData::platformEncode const):

UIProcess/API/Cocoa/WKProcessPool.mm:

(-[WKProcessPool _setObject:forBundleParameter:]):
(-[WKProcessPool _setObjectsForBundleParametersWithDictionary:]):

UIProcess/Cocoa/WebProcessPoolCocoa.mm:

(WebKit::WebProcessPool::platformInitializeWebProcess):

WebProcess/InjectedBundle/API/mac/WKWebProcessPlugInBrowserContextController.mm:

(-[WKWebProcessPlugInBrowserContextController _setFormDelegate:]):

5:19 PM Changeset in webkit [225308] by commit-queue@webkit.org

12 edits in trunk

ServiceWorkerClient objects should be reused if there is already one existing with the same identifier
https://bugs.webkit.org/show_bug.cgi?id=180143

Patch by Youenn Fablet <youenn@apple.com> on 2017-11-29
Reviewed by Chris Dumez.

Source/WebCore:

Covered by updated tests.

ServiceWorkerGlobalScope keeps a map of all live ServiceWorkerClient objects.
Before creating a new client, it checks whether the map has one such object with the same identifier.
If so, it reuses this object. Otherwise it creates either a ServiceWorkerWindowClient or ServiceWorkerClient.

Add support for using a ServiceWorkerClientIdentifier as a HashMap key.

workers/service/ServiceWorkerClient.cpp:

(WebCore::ServiceWorkerClient::ServiceWorkerClient):
(WebCore::ServiceWorkerClient::~ServiceWorkerClient):

workers/service/ServiceWorkerClient.h:

(WebCore::ServiceWorkerClient::getOrCreate):

workers/service/ServiceWorkerClientIdentifier.h:

(WebCore::ServiceWorkerClientIdentifier::hash const):
(WTF::ServiceWorkerClientIdentifierHash::hash):
(WTF::ServiceWorkerClientIdentifierHash::equal):
(WTF::HashTraits<WebCore::ServiceWorkerClientIdentifier>::emptyValue):
(WTF::HashTraits<WebCore::ServiceWorkerClientIdentifier>::constructDeletedValue):
(WTF::HashTraits<WebCore::ServiceWorkerClientIdentifier>::isDeletedValue):

workers/service/ServiceWorkerGlobalScope.cpp:

(WebCore::ServiceWorkerGlobalScope::serviceWorkerClient):
(WebCore::ServiceWorkerGlobalScope::addServiceWorkerClient):
(WebCore::ServiceWorkerGlobalScope::removeServiceWorkerClient):

workers/service/ServiceWorkerGlobalScope.h:
workers/service/ServiceWorkerWindowClient.cpp:

(WebCore::ServiceWorkerWindowClient::ServiceWorkerWindowClient):

workers/service/ServiceWorkerWindowClient.h:
workers/service/context/ServiceWorkerThread.cpp:

(WebCore::ServiceWorkerThread::postMessageToServiceWorkerGlobalScope):

LayoutTests:

http/tests/workers/service/resources/basic-ServiceWorker-postMessage-worker.js:

(event.else):

http/tests/workers/service/resources/basic-ServiceWorker-postMessage.js:

5:05 PM Changeset in webkit [225307] by sbarati@apple.com

24 edits
2 deletes in trunk/Source/JavaScriptCore

Remove pointer caging for double arrays
https://bugs.webkit.org/show_bug.cgi?id=180163

Reviewed by Mark Lam.

This patch removes pointer caging from double arrays. Like
my previous removals of pointer caging, this is a security vs
performance tradeoff. We believe that butterflies being allocated
in the cage and with a 32GB runway gives us enough security that
pointer caging the butterfly just for double arrays does not add
enough security benefit for the performance hit it incurs.

This patch also removes the GetButterflyWithoutCaging node and
the FixedButterflyAccessUncaging phase. The node is no longer needed
because now all GetButterfly nodes are not caged. The phase is removed
since we no longer have two nodes.

dfg/DFGAbstractInterpreterInlines.h:

(JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):

dfg/DFGArgumentsEliminationPhase.cpp:
dfg/DFGClobberize.h:

(JSC::DFG::clobberize):

dfg/DFGDoesGC.cpp:

(JSC::DFG::doesGC):

dfg/DFGFixedButterflyAccessUncagingPhase.cpp: Removed.
dfg/DFGFixedButterflyAccessUncagingPhase.h: Removed.
dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode):

dfg/DFGHeapLocation.cpp:

(WTF::printInternal):

dfg/DFGHeapLocation.h:
dfg/DFGNodeType.h:
dfg/DFGPlan.cpp:

(JSC::DFG::Plan::compileInThreadImpl):

dfg/DFGPredictionPropagationPhase.cpp:
dfg/DFGSafeToExecute.h:

(JSC::DFG::safeToExecute):

dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileSpread):
(JSC::DFG::SpeculativeJIT::compileArraySlice):
(JSC::DFG::SpeculativeJIT::compileGetButterfly):

dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

dfg/DFGTypeCheckHoistingPhase.cpp:

(JSC::DFG::TypeCheckHoistingPhase::identifyRedundantStructureChecks):
(JSC::DFG::TypeCheckHoistingPhase::identifyRedundantArrayChecks):

ftl/FTLCapabilities.cpp:

(JSC::FTL::canCompile):

ftl/FTLLowerDFGToB3.cpp:

(JSC::FTL::DFG::LowerDFGToB3::compileNode):
(JSC::FTL::DFG::LowerDFGToB3::compileGetButterfly):

jit/JITPropertyAccess.cpp:

(JSC::JIT::emitDoubleLoad):
(JSC::JIT::emitGenericContiguousPutByVal):

runtime/Butterfly.h:

(JSC::Butterfly::pointer):
(JSC::Butterfly::contiguousDouble):
(JSC::Butterfly::caged): Deleted.

runtime/ButterflyInlines.h:

(JSC::Butterfly::createOrGrowPropertyStorage):

runtime/JSObject.cpp:

(JSC::JSObject::ensureLengthSlow):
(JSC::JSObject::reallocateAndShrinkButterfly):

4:39 PM Changeset in webkit [225306] by Ryan Haddad

2 edits in trunk/LayoutTests

Mark imported/w3c/web-platform-tests/XMLHttpRequest/firing-events-http-no-content-length.html as flaky.
https://bugs.webkit.org/show_bug.cgi?id=179775

Unreviewed test gardening.

platform/mac-wk1/TestExpectations:

4:39 PM Changeset in webkit [225305] by Ryan Haddad

2 edits in trunk/LayoutTests

Mark media/modern-media-controls/pip-support/pip-support-click.html as flaky.
https://bugs.webkit.org/show_bug.cgi?id=165311

Unreviewed test gardening.

platform/mac/TestExpectations:

4:39 PM Changeset in webkit [225304] by Ryan Haddad

2 edits in trunk/LayoutTests

Mark http/tests/workers/service/registration-clear-redundant-worker.html as flaky.
https://bugs.webkit.org/show_bug.cgi?id=179778

Unreviewed test gardening.

TestExpectations:

4:31 PM Changeset in webkit [225303] by Alan Bujtas

6 edits in trunk/Source/WebCore

Add missing WTF_MAKE_ISO_ALLOCATED macros
https://bugs.webkit.org/show_bug.cgi?id=180165
<rdar://problem/35755617>

Reviewed by Simon Fraser.

rendering/RenderFrame.h:
rendering/RenderFullScreen.cpp:
rendering/RenderIFrame.h:

4:18 PM Changeset in webkit [225302] by Simon Fraser

2 edits in trunk/Tools

API test fix after r225288.

Make the test work on iOS.

TestWebKitAPI/Tests/WebKit/NoHistoryItemScrollToFragment.mm:

(-[DidScrollToFragmentScrollViewDelegate scrollViewDidScroll:]):
(TestWebKitAPI::TEST):

4:16 PM Changeset in webkit [225301] by clopez@igalia.com

8 edits
1 add in trunk/Source

Source/JavaScriptCore:
[MIPS][JSC] Implement MacroAssembler::probe support on MIPS
https://bugs.webkit.org/show_bug.cgi?id=175447

Patch by Stanislav Ocovaj <stanislav.ocovaj@rt-rk.com> on 2017-11-29
Reviewed by Carlos Alberto Lopez Perez.

This patch allows DFG JIT to be enabled on MIPS platforms.

Sources.txt:
assembler/MIPSAssembler.h:

(JSC::MIPSAssembler::lastSPRegister):
(JSC::MIPSAssembler::numberOfSPRegisters):
(JSC::MIPSAssembler::sprName):

assembler/MacroAssemblerMIPS.cpp: Added.

(JSC::MacroAssembler::probe):

assembler/ProbeContext.cpp:

(JSC::Probe::executeProbe):

assembler/ProbeContext.h:

(JSC::Probe::CPUState::pc):

assembler/testmasm.cpp:

(JSC::isSpecialGPR):
(JSC::testProbePreservesGPRS):
(JSC::testProbeModifiesStackPointer):
(JSC::testProbeModifiesStackValues):

Source/WTF:
[DFG][MIPS] Enable DFG JIT on MIPS.
https://bugs.webkit.org/show_bug.cgi?id=175447

Patch by Stanislav Ocovaj <stanislav.ocovaj@rt-rk.com> on 2017-11-29
Reviewed by Carlos Alberto Lopez Perez.

wtf/Platform.h:

3:23 PM Changeset in webkit [225300] by commit-queue@webkit.org

13 edits
2 deletes in trunk/Source

Remove the ImageSource from the class hierarchy that connects BitmapImage to ImageFrame
https://bugs.webkit.org/show_bug.cgi?id=175595

Patch by Said Abou-Hallawa <sabouhallawa@apple.com> on 2017-11-29
Reviewed by Darin Adler.

Source/WebCore:

The class hierarchy that connects BitmapImage to ImageFrame has been
troublesome. ImageSource does not have a clear responsibility other than
a bridge that connects BitmapIamge to ImageFrameCache. Sharing the
ImageDecoder between ImageSource and ImageFrameCache is ugly and caused
few crashes in the past.

This patch will do the first step for fixing this issue. First get rid of
ImageSource by moving its APIs to ImageFrameCache and BitmapImage. Replace
all the instances of ImageSource by ImageFrameCache. The next step will
be to rename ImageFrameCache to ImageSource. But this will be done in a
follow-up patch

Sources.txt:
WebCore.xcodeproj/project.pbxproj:
platform/graphics/BitmapImage.cpp:

(WebCore::BitmapImage::BitmapImage):
(WebCore::BitmapImage::~BitmapImage):
(WebCore::BitmapImage::destroyDecodedData):
(WebCore::BitmapImage::destroyDecodedDataIfNecessary):
(WebCore::BitmapImage::dataChanged):
(WebCore::BitmapImage::frameImageAtIndexCacheIfNeeded):
(WebCore::BitmapImage::draw):
(WebCore::BitmapImage::canUseAsyncDecodingForLargeImages const):
(WebCore::BitmapImage::shouldUseAsyncDecodingForAnimatedImages const):
(WebCore::BitmapImage::subsamplingLevelForScaleFactor):
(WebCore::BitmapImage::canDestroyDecodedData):
(WebCore::BitmapImage::internalStartAnimation):
(WebCore::BitmapImage::stopAnimation):
(WebCore::BitmapImage::decode):
(WebCore::BitmapImage::imageFrameAvailableAtIndex):
(WebCore::BitmapImage::dump const):

platform/graphics/BitmapImage.h:
platform/graphics/GraphicsContext3D.h:
platform/graphics/ImageFrameCache.cpp:

(WebCore::ImageFrameCache::ImageFrameCache):
(WebCore::ImageFrameCache::ensureDecoderAvailable):
(WebCore::ImageFrameCache::setData):
(WebCore::ImageFrameCache::resetData):
(WebCore::ImageFrameCache::dataChanged):
(WebCore::ImageFrameCache::isAllDataReceived):
(WebCore::ImageFrameCache::clearFrameBufferCache):
(WebCore::ImageFrameCache::canUseAsyncDecoding):
(WebCore::ImageFrameCache::maximumSubsamplingLevel):
(WebCore::ImageFrameCache::setTargetContext):
(WebCore::ImageFrameCache::createFrameImageAtIndex):
(WebCore::ImageFrameCache::dump):
(WebCore::ImageFrameCache::setDecoder): Deleted.
(WebCore::ImageFrameCache::decoder const): Deleted.

platform/graphics/ImageFrameCache.h:

(WebCore::ImageFrameCache::create):
(WebCore::ImageFrameCache::requestFrameAsyncDecodingAtIndex):

platform/graphics/ImageSource.cpp: Removed.
platform/graphics/ImageSource.h: Removed.
platform/graphics/cairo/GraphicsContext3DCairo.cpp:

(WebCore::GraphicsContext3D::ImageExtractor::~ImageExtractor):
(WebCore::GraphicsContext3D::ImageExtractor::extractImage):

platform/graphics/cg/GraphicsContext3DCG.cpp:

(WebCore::GraphicsContext3D::ImageExtractor::extractImage):

platform/graphics/cg/ImageSourceCG.h:

Source/WebKitLegacy/mac:

WebView/WebPreferences.mm:

3:16 PM Changeset in webkit [225299] by Nikita Vasilyev

2 edits in trunk/Source/WebInspectorUI

Web Inspector: Styles Redesign: can't add new property after property without trailing semicolon
https://bugs.webkit.org/show_bug.cgi?id=179587
<rdar://problem/35490858>

Reviewed by Timothy Hatcher.

UserInterface/Models/CSSProperty.js:

(WI.CSSProperty.prototype._updateOwnerStyleText):
(WI.CSSProperty.prototype._appendSemicolonIfNeeded):
Add a semicolon before the new property if the last property doesn't have it already.

3:16 PM Changeset in webkit [225298] by beidson@apple.com

13 edits in trunk/Source

When managing context startups, make ServiceWorkerJobDataIdentifier's optional.
https://bugs.webkit.org/show_bug.cgi?id=180166

Reviewed by Chris Dumez.

Source/WebCore:

No new tests (No behavior change).

We'll sometimes be starting SW contexts without an associated job, so ServiceWorkerContextData
should not required actually having a job identifier.

workers/service/ServiceWorkerContextData.h:

(WebCore::ServiceWorkerContextData::decode):

workers/service/context/SWContextManager.h:

workers/service/server/SWServer.cpp:

(WebCore::SWServer::scriptContextFailedToStart):
(WebCore::SWServer::scriptContextStarted):
(WebCore::SWServer::didFinishInstall):

workers/service/server/SWServer.h:

workers/service/server/SWServerToContextConnection.cpp:

(WebCore::SWServerToContextConnection::scriptContextFailedToStart):
(WebCore::SWServerToContextConnection::scriptContextStarted):
(WebCore::SWServerToContextConnection::didFinishInstall):

workers/service/server/SWServerToContextConnection.h:

workers/service/server/SWServerWorker.cpp:

(WebCore::SWServerWorker::scriptContextFailedToStart):
(WebCore::SWServerWorker::scriptContextStarted):
(WebCore::SWServerWorker::didFinishInstall):

workers/service/server/SWServerWorker.h:

Source/WebKit:

StorageProcess/ServiceWorker/WebSWServerToContextConnection.messages.in:

WebProcess/Storage/WebSWContextManagerConnection.cpp:

(WebKit::WebSWContextManagerConnection::serviceWorkerStartedWithMessage):
(WebKit::WebSWContextManagerConnection::didFinishInstall):

WebProcess/Storage/WebSWContextManagerConnection.h:

3:03 PM Changeset in webkit [225297] by commit-queue@webkit.org

15 edits in trunk

Add support for service worker generated redirections
https://bugs.webkit.org/show_bug.cgi?id=179498

Patch by Youenn Fablet <youenn@apple.com> on 2017-11-29
Reviewed by Darin Adler.

Source/WebCore:

Test: http/tests/workers/service/service-worker-redirection-fetch.https.html

Added redirection routines following fetch specification to:

check whether a response is a redirection
generate a redirected request from a request and its redirection response.

Added some specific redirect request generation following existing WebKit networking code.

Modules/fetch/FetchResponse.cpp:

(WebCore::FetchResponse::redirect):
(WebCore::isRedirectStatus): Deleted.

platform/network/ResourceRequestBase.cpp:

(WebCore::shouldUseGet):
(WebCore::ResourceRequestBase::redirectedRequest const):

platform/network/ResourceRequestBase.h:
platform/network/ResourceResponseBase.h:

(WebCore::ResourceResponseBase::isRedirectionStatusCode):
(WebCore::ResourceResponseBase::isRedirection const):

Source/WebKit:

Small refactoring to allow a service worker redirected fetch to follow the redirection through the service worker.

WebProcess/Network/WebLoaderStrategy.cpp:

(WebKit::WebLoaderStrategy::scheduleLoad): Make use of the loader request in case a network load is needed after a service worker redirection.

WebProcess/Storage/ServiceWorkerClientFetch.cpp:

(WebKit::ServiceWorkerClientFetch::create):
(WebKit::ServiceWorkerClientFetch::~ServiceWorkerClientFetch):
(WebKit::ServiceWorkerClientFetch::ServiceWorkerClientFetch):
(WebKit::ServiceWorkerClientFetch::start):
(WebKit::ServiceWorkerClientFetch::didReceiveResponse): Check for response.
Generate redirected request if needed and call loader callback to process the redirection.
Adding some states so that if didFinish is called before the willSendRequest callback, redirection is followed.
(WebKit::ServiceWorkerClientFetch::didFinish):
In case redirection should be followed, wait for didFinish to follow it.
This simplifies the model although introducing some limited latency.

WebProcess/Storage/ServiceWorkerClientFetch.h:
WebProcess/Storage/WebSWClientConnection.cpp:

(WebKit::WebSWClientConnection::startFetch):

WebProcess/Storage/WebSWClientConnection.h:
WebProcess/Storage/WebServiceWorkerProvider.cpp:

(WebKit::WebServiceWorkerProvider::handleFetch):

LayoutTests:

http/tests/workers/service/resources/service-worker-redirection-fetch-worker.js: Added.

(event.event.request.url.indexOf):
(event.event.request.url.endsWith):

http/tests/workers/service/service-worker-redirection-fetch.https-expected.txt: Added.
http/tests/workers/service/service-worker-redirection-fetch.https.html: Added.

2:19 PM Changeset in webkit [225296] by Chris Dumez

19 edits
6 adds in trunk

Start exposing self.registration inside service workers
https://bugs.webkit.org/show_bug.cgi?id=180162

Reviewed by Brady Eidson.

LayoutTests/imported/w3c:

web-platform-tests/service-workers/service-worker/redirected-response.https-expected.txt:

Source/WebCore:

Start exposing self.registration inside service workers as per:

https://w3c.github.io/ServiceWorker/#serviceworkerglobalscope-interface

This is very initial support:

The operations on the registration (such as update) will reject the promise for now.
The registration's service workers are not yet populated.

This will be implemented in a follow-up.

Tests: http/tests/workers/service/ServiceWorkerGlobalScope_registration_SameObject.html

http/tests/workers/service/self_registration.html

bindings/js/JSServiceWorkerGlobalScopeCustom.cpp:

(WebCore::JSServiceWorkerGlobalScope::visitAdditionalChildren):

workers/service/ServiceWorkerContainer.cpp:

(WebCore::ServiceWorkerContainer::addRegistration):

workers/service/ServiceWorkerContextData.cpp:

(WebCore::ServiceWorkerContextData::isolatedCopy const):

workers/service/ServiceWorkerContextData.h:

(WebCore::ServiceWorkerContextData::encode const):
(WebCore::ServiceWorkerContextData::decode):

workers/service/ServiceWorkerGlobalScope.cpp:

(WebCore::ServiceWorkerGlobalScope::ServiceWorkerGlobalScope):

workers/service/ServiceWorkerGlobalScope.h:

(WebCore::ServiceWorkerGlobalScope::registration):

workers/service/server/SWServer.cpp:

(WebCore::SWServer::updateWorker):
(WebCore::SWServer::installContextData):

workers/service/server/SWServer.h:
workers/service/server/SWServerJobQueue.cpp:

(WebCore::SWServerJobQueue::scriptFetchFinished):

LayoutTests:

Add layout test coverage.

TestExpectations:

Skip test that covers self.registration.update() because it now times out. We do not support update()
on registrations inside service workers yet so the test times out waiting for the updatefound event
on the registration.

http/tests/workers/service/ServiceWorkerGlobalScope_registration_SameObject-expected.txt: Added.
http/tests/workers/service/ServiceWorkerGlobalScope_registration_SameObject.html: Added.
http/tests/workers/service/resources/ServiceWorkerGlobalScope_registration_SameObject-worker.js: Added.
http/tests/workers/service/resources/self_registration-worker.js: Added.
http/tests/workers/service/self_registration-expected.txt: Added.
http/tests/workers/service/self_registration.html: Added.

1:53 PM Changeset in webkit [225295] by jmarcell@apple.com

3 edits
1 add in branches/safari-604-branch

Cherry-pick r224539. rdar://problem/35698788

1:47 PM Changeset in webkit [225294] by commit-queue@webkit.org

17 edits in trunk

Add support for FetchEvent.clientId
https://bugs.webkit.org/show_bug.cgi?id=180052

Patch by Youenn Fablet <youenn@apple.com> on 2017-11-29
Reviewed by Chris Dumez.

LayoutTests/imported/w3c:

web-platform-tests/service-workers/service-worker/fetch-event.https-expected.txt:
web-platform-tests/service-workers/service-worker/resources/clients-get-worker.js:
web-platform-tests/service-workers/service-worker/resources/fetch-event-test-worker.js:

Source/WebCore:

Covered by updated test.

Add script execution context identifier as a FetchOptions parameter.
This is then sent to the service worker process which can then set FetchEvent.clientId appropriately.
If the fetch is for a subresource, clientId is used directly.
If it is a navigation, clientId is set to targetClientId.

loader/FetchOptions.h:

(WebCore::FetchOptions::encode const):
(WebCore::FetchOptions::decode):

loader/cache/CachedResourceLoader.cpp:

(WebCore::CachedResourceLoader::prepareFetch):

loader/cache/CachedResourceRequest.cpp:

(WebCore::CachedResourceRequest::setClientIdentifierIfNeeded):

loader/cache/CachedResourceRequest.h:
workers/service/context/ServiceWorkerFetch.cpp:

(WebCore::ServiceWorkerFetch::dispatchFetchEvent):

workers/service/context/ServiceWorkerFetch.h:
workers/service/context/ServiceWorkerThread.cpp:

(WebCore::ServiceWorkerThread::postFetchTask):

workers/service/context/ServiceWorkerThread.h:

Source/WebKit:

Using FetchOption persistency coders for cache API and modernizing IPC FetchOptions decoding.

WebKit/Shared/WebCoreArgumentCoders.cpp:
NetworkProcess/cache/CacheStorageEngineCache.cpp:

(WebKit::CacheStorage::Cache::encode):
(WebKit::CacheStorage::Cache::decodeRecordHeader):

WebProcess/Storage/WebSWContextManagerConnection.cpp:

(WebKit::WebSWContextManagerConnection::startFetch):

WebProcess/Storage/WebSWContextManagerConnection.cpp:

(WebKit::WebSWContextManagerConnection::startFetch):

1:42 PM Changeset in webkit [225293] by Matt Lewis

8 edits
1 delete in trunk/Source

Unreviewed, rolling out r225286.

The source files within this patch have been marked as
executable.

Reverted changeset:

"[MIPS][JSC] Implement MacroAssembler::probe support on MIPS"
https://bugs.webkit.org/show_bug.cgi?id=175447
https://trac.webkit.org/changeset/225286

1:41 PM Changeset in webkit [225292] by achristensen@apple.com

3 edits in trunk/Source/WebKit

Make WebFrameLoaderClient more robust against null pointer dereferencing
https://bugs.webkit.org/show_bug.cgi?id=180157
<rdar://problem/34895616>

Reviewed by Tim Horton.

There has always been rare null pointer crashes in this code, but they have become more common
now that we are waiting for completion handlers for redirects, which makes it more likely that
we are hitting this code after we have detached from the core frame.

WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::dispatchDecidePolicyForResponse):
(WebKit::WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction):
(WebKit::WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):

WebProcess/WebPage/WebFrame.cpp:

(WebKit::WebFrame::page const):

1:39 PM Changeset in webkit [225291] by commit-queue@webkit.org

5 edits in trunk/Source/WebCore

Flaky crash in WebCore::DOMGuardedObject::clear() during service worker tests
https://bugs.webkit.org/show_bug.cgi?id=180045
<rdar://problem/35737288>

Patch by Youenn Fablet <youenn@apple.com> on 2017-11-29
Reviewed by Chris Dumez.

Manually tested by running concurrently service worker tests using FetchEvents which store promise references.

Before the patch, on workers, clearing of DOMGuardedObjects happens at the time WorkerGlobalScope is destroyed.
This is too late as it is expected that the JSDOMGlobalObject is still alive.

This patch adds a clearDOMGuardedObjects method on JSWorkerGlobalScopeBase.
It is called when stopping a WorkerThread, just before releasing the strong reference to JSWorkerGlobalScopeBase.

bindings/js/JSDOMGuardedObject.h:
bindings/js/JSWorkerGlobalScopeBase.cpp:

(WebCore::JSWorkerGlobalScopeBase::clearDOMGuardedObjects):

bindings/js/JSWorkerGlobalScopeBase.h:
bindings/js/WorkerScriptController.cpp:

1:31 PM Changeset in webkit [225290] by achristensen@apple.com

10 edits in trunk

Fix Mac CMake build.

Source/cmake/OptionsMac.cmake:

Source/JavaScriptCore:

PlatformMac.cmake:

Source/WebCore:

PlatformMac.cmake:

Source/WebCore/PAL:

pal/PlatformMac.cmake:

Source/WebKit:

PlatformMac.cmake:

1:11 PM Changeset in webkit [225289] by Chris Dumez

19 edits in trunk/Source/WebKit

StorageToWebProcessConnection & WebSWServerToContextConnection should use the same underlying IPC::Connection
https://bugs.webkit.org/show_bug.cgi?id=180147

Reviewed by Brady Eidson.

StorageToWebProcessConnection & WebSWServerToContextConnection should use the same underlying IPC::Connection.
Otherwise, we have with 2 IPC::Connections between the StorageProcess and the ServiceWorker (aka Context) process,
which makes synchronization of IPC messages difficult.

StorageProcess/StorageProcess.cpp:

(WebKit::StorageProcess::createStorageToWebProcessConnection):
(WebKit::StorageProcess::createServerToContextConnection):

StorageProcess/StorageProcess.h:
StorageProcess/StorageProcess.messages.in:
StorageProcess/StorageToWebProcessConnection.cpp:

(WebKit::StorageToWebProcessConnection::didReceiveMessage):

UIProcess/ServiceWorkerProcessProxy.cpp:

(WebKit::ServiceWorkerProcessProxy::start):

UIProcess/ServiceWorkerProcessProxy.h:
UIProcess/Storage/StorageProcessProxy.cpp:

(WebKit::StorageProcessProxy::getStorageProcessConnection):
(WebKit::StorageProcessProxy::didFinishLaunching):
(WebKit::StorageProcessProxy::establishWorkerContextConnectionToStorageProcess):

UIProcess/Storage/StorageProcessProxy.h:
UIProcess/Storage/StorageProcessProxy.messages.in:
UIProcess/WebProcessPool.cpp:

(WebKit::WebProcessPool::getStorageProcessConnection):
(WebKit::WebProcessPool::establishWorkerContextConnectionToStorageProcess):

UIProcess/WebProcessPool.h:
UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::getStorageProcessConnection):

UIProcess/WebProcessProxy.h:

(WebKit::WebProcessProxy::isServiceWorkerProcess const):

UIProcess/WebProcessProxy.messages.in:
WebProcess/Storage/WebToStorageProcessConnection.cpp:

(WebKit::WebToStorageProcessConnection::didReceiveMessage):

WebProcess/WebProcess.cpp:

(WebKit::WebProcess::didReceiveMessage):
(WebKit::WebProcess::establishWorkerContextConnectionToStorageProcess):

WebProcess/WebProcess.h:
WebProcess/WebProcess.messages.in:

12:41 PM Changeset in webkit [225288] by Simon Fraser

5 edits
2 adds in trunk

REGRESSION (r213590): Scrolling to anchors broken in web views when content loaded via HTML string
https://bugs.webkit.org/show_bug.cgi?id=180155
rdar://problem/34220827

Reviewed by Zalan Bujtas.
Source/WebCore:

When content is loaded in a UIWebView or WKWebView via an HTML string, history().currentItem()
is null so itemAllowsScrollRestoration() would return false, preventing scrolling to anchors.

Fix by allowing scroll restoration if the the history item is null.

Tested by WebKit.NoHistoryItemScrollToFragment API test.

loader/FrameLoader.cpp:

(WebCore::itemAllowsScrollRestoration):

Tools:

API test that loads a page with a relative anchor, and simulates a click to scroll to it.

TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
TestWebKitAPI/Tests/WebKit/MediaStreamTrackDetached.mm:

(TestWebKitAPI::TEST):

TestWebKitAPI/Tests/WebKit/NoHistoryItemScrollToFragment.mm: Added.

(-[DidScrollToFragmentDelegate _webViewDidScroll:]):
(TestWebKitAPI::TEST):

TestWebKitAPI/Tests/WebKit/scroll-to-anchor.html: Added.

12:30 PM Changeset in webkit [225287] by Ryan Haddad

2 edits in trunk/Tools

webkitpy EWS should be present on the dashboard.
https://bugs.webkit.org/show_bug.cgi?id=179801

Reviewed by Aakash Jain.

BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:

(BubbleQueueServer): Add Webkitpy EWS.

12:12 PM Changeset in webkit [225286] by commit-queue@webkit.org

8 edits
1 add in trunk/Source

Source/JavaScriptCore:
[MIPS][JSC] Implement MacroAssembler::probe support on MIPS
https://bugs.webkit.org/show_bug.cgi?id=175447

Patch by Stanislav Ocovaj <stanislav.ocovaj@rt-rk.com> on 2017-11-29
Reviewed by Carlos Alberto Lopez Perez.

This patch allows DFG JIT to be enabled on MIPS platforms.

Sources.txt:
assembler/MIPSAssembler.h:

(JSC::MIPSAssembler::lastSPRegister):
(JSC::MIPSAssembler::numberOfSPRegisters):
(JSC::MIPSAssembler::sprName):

assembler/MacroAssemblerMIPS.cpp: Added.

(JSC::MacroAssembler::probe):

assembler/ProbeContext.cpp:

(JSC::Probe::executeProbe):

assembler/ProbeContext.h:

(JSC::Probe::CPUState::pc):

assembler/testmasm.cpp:

(JSC::isSpecialGPR):
(JSC::testProbePreservesGPRS):
(JSC::testProbeModifiesStackPointer):
(JSC::testProbeModifiesStackValues):

Source/WTF:
[DFG][MIPS] Enable DFG JIT on MIPS.
https://bugs.webkit.org/show_bug.cgi?id=175447

Patch by Stanislav Ocovaj <stanislav.ocovaj@rt-rk.com> on 2017-11-29
Reviewed by Carlos Alberto Lopez Perez.

wtf/Platform.h:

12:05 PM Changeset in webkit [225285] by jmarcell@apple.com

7 edits in tags/Safari-605.1.14.2/Source

Versioning.

12:02 PM Changeset in webkit [225284] by jmarcell@apple.com

1 copy in tags/Safari-605.1.14.2

New tag.

11:41 AM Changeset in webkit [225283] by Chris Dumez

3 edits in trunk/Source/WebCore

Introduce ServiceWorkerContainer::ensureSWClientConnection()
https://bugs.webkit.org/show_bug.cgi?id=180146

Reviewed by Youenn Fablet.

Introduce ServiceWorkerContainer::ensureSWClientConnection() to reduce
code duplication. Also use callOnMainThread() in preparation for this
getting called from a service worker thread (now that ServiceWorkerContainer
is exposed to service workers). This is needed because constructing the
SWClientConnection initializes the IPC connection from the WebProcess to
the StorageProcess, which involves a synchronous IPC with the UIProcess.
Doing a synchronous IPC from a background thread is unsupported.

workers/service/ServiceWorkerContainer.cpp:

(WebCore::ServiceWorkerContainer::addRegistration):
(WebCore::ServiceWorkerContainer::getRegistration):
(WebCore::ServiceWorkerContainer::getRegistrations):
(WebCore::ServiceWorkerContainer::ensureSWClientConnection):

workers/service/ServiceWorkerContainer.h:

11:40 AM Changeset in webkit [225282] by Chris Dumez

19 edits in trunk/Source/WebKit

ensure*Connection() methods on WebProcess should return a reference
https://bugs.webkit.org/show_bug.cgi?id=180149

Reviewed by Alex Christensen.

ensure*Connection() methods on WebProcess should return a reference instead of not returning
anything. Also get rid of the non-ensure variants which called "ensure" internally and are
no longer needed.

Shared/mac/CookieStorageShim.mm:

(WebKit::webKitCookieStorageCopyRequestHeaderFieldsForURL):

WebProcess/Cache/WebCacheStorageConnection.cpp:

(WebKit::WebCacheStorageConnection::connection):

WebProcess/Databases/IndexedDB/WebIDBConnectionToServer.cpp:

(WebKit::WebIDBConnectionToServer::messageSenderConnection):
(WebKit::preregisterSandboxExtensionsIfNecessary):

WebProcess/Databases/WebDatabaseProvider.cpp:

(WebKit::WebDatabaseProvider::idbConnectionToServerForSession):

WebProcess/FileAPI/BlobRegistryProxy.cpp:

(WebKit::BlobRegistryProxy::registerFileBlobURL):
(WebKit::BlobRegistryProxy::registerBlobURL):
(WebKit::BlobRegistryProxy::registerBlobURLOptionallyFileBacked):
(WebKit::BlobRegistryProxy::unregisterBlobURL):
(WebKit::BlobRegistryProxy::registerBlobURLForSlice):
(WebKit::BlobRegistryProxy::blobSize):
(WebKit::BlobRegistryProxy::writeBlobsToTemporaryFiles):

WebProcess/Network/NetworkProcessConnection.cpp:

(WebKit::NetworkProcessConnection::writeBlobsToTemporaryFiles):

WebProcess/Network/WebLoaderStrategy.cpp:

(WebKit::WebLoaderStrategy::scheduleLoadFromNetworkProcess):
(WebKit::WebLoaderStrategy::remove):
(WebKit::WebLoaderStrategy::setDefersLoading):
(WebKit::WebLoaderStrategy::loadResourceSynchronously):
(WebKit::WebLoaderStrategy::startPingLoad):
(WebKit::WebLoaderStrategy::preconnectTo):
(WebKit::WebLoaderStrategy::storeDerivedDataToCache):
(WebKit::WebLoaderStrategy::setCaptureExtraNetworkLoadMetricsEnabled):

WebProcess/Network/WebResourceLoader.cpp:

(WebKit::WebResourceLoader::messageSenderConnection):

WebProcess/Network/WebSocketStream.cpp:

(WebKit::WebSocketStream::WebSocketStream):
(WebKit::WebSocketStream::messageSenderConnection):

WebProcess/Network/webrtc/LibWebRTCResolver.cpp:

(WebKit::sendOnMainThread):

WebProcess/Network/webrtc/LibWebRTCSocket.cpp:

(WebKit::sendOnMainThread):

WebProcess/Network/webrtc/LibWebRTCSocketFactory.cpp:

(WebKit::LibWebRTCSocketFactory::CreateServerTcpSocket):
(WebKit::LibWebRTCSocketFactory::CreateUdpSocket):
(WebKit::LibWebRTCSocketFactory::CreateClientTcpSocket):
(WebKit::LibWebRTCSocketFactory::createNewConnectionSocket):

WebProcess/Network/webrtc/WebRTCMonitor.cpp:

(WebKit::sendOnMainThread):

WebProcess/Storage/WebServiceWorkerProvider.cpp:

(WebKit::WebServiceWorkerProvider::serviceWorkerConnectionForSession):
(WebKit::WebServiceWorkerProvider::handleFetch):

WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:

(WebKit::WebPlatformStrategies::cookiesForDOM):
(WebKit::WebPlatformStrategies::setCookiesFromDOM):
(WebKit::WebPlatformStrategies::cookiesEnabled):
(WebKit::WebPlatformStrategies::cookieRequestHeaderFieldValue):
(WebKit::WebPlatformStrategies::getRawCookies):
(WebKit::WebPlatformStrategies::deleteCookie):

WebProcess/WebPage/WebFrame.cpp:

(WebKit::WebFrame::startDownload):
(WebKit::WebFrame::convertMainResourceLoadToDownload):

WebProcess/WebProcess.cpp:

(WebKit::WebProcess::ensureLegacyPrivateBrowsingSessionInNetworkProcess):
(WebKit::WebProcess::ensureNetworkProcessConnection):
(WebKit::WebProcess::ensureWebToStorageProcessConnection):
(WebKit::WebProcess::prefetchDNS):

WebProcess/WebProcess.h:

11:22 AM Changeset in webkit [225281] by commit-queue@webkit.org

2 edits in trunk/LayoutTests

[GTK] Test gardening
https://bugs.webkit.org/show_bug.cgi?id=180150

Unreviewed test gardening

Patch by Javier M. Mellid <jmunhoz@igalia.com> on 2017-11-29

platform/gtk/TestExpectations:

11:07 AM Changeset in webkit [225280] by Joseph Pecoraro

4 edits in trunk/Source/WebInspectorUI

Web Inspector: Console Tab navigation bar sometimes does not include filter bar, clear console sometimes does not work
https://bugs.webkit.org/show_bug.cgi?id=180124
<rdar://problem/35740353>

Reviewed by Brian Burg.

UserInterface/Views/LogContentView.js:

(WI.LogContentView.prototype.closed):
Avoid removing event listeners if this LogContentView singleton is ever closed.
The singleton will always be alive so we don't want to remove the event listeners
without a way to add them back.

UserInterface/Base/Main.js:

(WI.showSplitConsole):

UserInterface/Views/ConsoleTabContentView.js:

(WI.ConsoleTabContentView.prototype.shown):
When showing the ConsoleTab immediately collapse the split console so that any
following code that checks WI.isShowingSplitConsole will get the expected value.
It is also now possible to share a ContentView across ContentBrowsers via
tombstones, so remove the old code that would frequently close the LogContentView.

11:05 AM Changeset in webkit [225279] by commit-queue@webkit.org

6 edits
2 adds in trunk

[iOS] Media controls should stop updating while media is playing in fullscreen
https://bugs.webkit.org/show_bug.cgi?id=180144
<rdar://problem/35060379>

Patch by Antoine Quint <Antoine Quint> on 2017-11-29
Reviewed by Eric Carlson.

Source/WebCore:

Updating inline media controls while playing media in fullscreen is useless since we're guaranteed not to
have those controls visible, and hurtful since this has impact on battery life. To avoid this, we remove
all media event listeners while in fullscreen on iOS, which will prevent the UI to be udpated since all
updates are driven by media events.

To implement this, we remove the MediaControllerSupport destroy() method and make it a disable() method,
and factor code out of the MediaControllerSupport constructor into an enable() method that registers the
media event listeners. Then, as we enter and exit fullscreen, we call the disable() and enable() method
on the various MediaControllerSupport objects that were created to support the iOS inline media controls.

Test: media/modern-media-controls/media-controller/ios/media-controller-stop-updates-in-fullscreen.html

Modules/modern-media-controls/media/controls-visibility-support.js:

(ControlsVisibilitySupport):
(ControlsVisibilitySupport.prototype.enable):
(ControlsVisibilitySupport.prototype.disable):
(ControlsVisibilitySupport.prototype.destroy): Deleted.

Modules/modern-media-controls/media/media-controller-support.js:

(MediaControllerSupport):
(MediaControllerSupport.prototype.enable):
(MediaControllerSupport.prototype.disable):
(MediaControllerSupport.prototype.destroy): Deleted.

Modules/modern-media-controls/media/media-controller.js:

(MediaController.prototype.handleEvent):
(MediaController.prototype._updateControlsIfNeeded):
(MediaController.prototype._updateSupportingObjectsEnabledState):
(MediaController):

LayoutTests:

Add a new test that enters fullscreen, checks that the elapsed time shown in the inline media controls are the same
at this time and after a few "timeupdate" events, ensuring the DOM is no longer updated while in fullscreen, and then
exits fullscreen and checks that the elapsed time controls now update as expected. This test is skipped in OpenSource
since it uses touch events.

media/modern-media-controls/media-controller/ios/media-controller-stop-updates-in-fullscreen-expected.txt: Added.
media/modern-media-controls/media-controller/ios/media-controller-stop-updates-in-fullscreen.html: Added.
platform/ios-simulator/TestExpectations:

11:03 AM Changeset in webkit [225278] by commit-queue@webkit.org

6 edits
1 delete in trunk/Source/WebKit

Modernize API::SerializedScriptValue
https://bugs.webkit.org/show_bug.cgi?id=180115

Patch by Alex Christensen <achristensen@webkit.org> on 2017-11-29
Reviewed by Brady Eidson.

Also remove some SPI that hasn't been used anywhere since Mountain Lion.

Shared/API/APISerializedScriptValue.h:

(API::SerializedScriptValue::create):
(API::SerializedScriptValue::internalRepresentation):
(API::SerializedScriptValue::SerializedScriptValue):

Shared/API/c/WKSerializedScriptValue.cpp:

(WKSerializedScriptValueDeserialize):
(WKSerializedScriptValueCreateWithInternalRepresentation): Deleted.
(WKSerializedScriptValueGetInternalRepresentation): Deleted.

Shared/API/c/WKSerializedScriptValuePrivate.h: Removed.
UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _evaluateJavaScript:forceUserGesture:completionHandler:]):

WebKit.xcodeproj/project.pbxproj:

10:59 AM Changeset in webkit [225277] by Simon Fraser

5 edits
2 adds in trunk

Viewport unit values affected by Comand-+ zoom
https://bugs.webkit.org/show_bug.cgi?id=145614

Reviewed by Zalan Bujtas.
Source/WebCore:

Don't apply zooming when resolving viewport-relative lengths, since they should not
change based on the zoom level.

Test: fast/css/viewport-units-zoom.html

css/CSSPrimitiveValue.cpp:

(WebCore::CSSPrimitiveValue::computeNonCalcLengthDouble):

Tools:

Fix Command+ and Command- in MiniBrowser to do zooming, rather than being tied
to editing commands.

MiniBrowser/mac/MainMenu.xib:

LayoutTests:

fast/css/viewport-units-zoom-expected.html: Added.
fast/css/viewport-units-zoom.html: Added.

10:59 AM Changeset in webkit [225276] by Brent Fulgham

2 edits in trunk/Source/WebCore

Unreviewed test fix after r225264.
<rdar://problem/35750689>

The changes in r225264 were meant to have no changes in behavior. However, I mistakenly
switched to a secure coding API call in the PlatformPasteboard::write method. This should
have used the 'insecure' version of this function.

platform/ios/PlatformPasteboardIOS.mm:

(WebCore::PlatformPasteboard::write):

10:53 AM Changeset in webkit [225275] by achristensen@apple.com

2 edits in trunk/Tools

Add test for _WKVisitedLinkStore.addVisitedLinkWithString
https://bugs.webkit.org/show_bug.cgi?id=180152

Reviewed by Chris Dumez.

TestWebKitAPI/Tests/WebKitCocoa/VisitedLinkStore.mm:

(TestWebKitAPI::TEST):

10:04 AM Changeset in webkit [225274] by Jonathan Bedard

3 edits in trunk/Tools

webkitpy: Trying to use iOS versions from machines without iOS SDKs doesn't make sense
https://bugs.webkit.org/show_bug.cgi?id=179534
<rdar://problem/35469509>

Reviewed by Brent Fulgham.

Provide more specific information in builders.py so that machines do not try and calculate
an iOS SDK version while running tests.

Scripts/webkitpy/port/builders.py: Explicitly specify a version for iOS Simulator.
Scripts/webkitpy/port/ios_simulator.py:

(IOSSimulatorPort._version_from_name): Attempt to extract the iOS version from the name
of the port.
(IOSSimulatorPort.ios_version): Use specified iOS version if a version is detected in
in the provided name string (just like Mac).

9:46 AM Changeset in webkit [225273] by jfbastien@apple.com

10 edits
7 adds in trunk

Strict and sloppy functions shouldn't share structure

9:45 AM Changeset in webkit [225272] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

LibWebRTCPeerConnectionBackend should clean its stats promises when being cleaned
https://bugs.webkit.org/show_bug.cgi?id=180101

Patch by Youenn Fablet <youenn@apple.com> on 2017-11-29
Reviewed by Eric Carlson.

No change of behavior.

Modules/mediastream/libwebrtc/LibWebRTCPeerConnectionBackend.cpp:

(WebCore::LibWebRTCPeerConnectionBackend::doStop): Cleaning stat promises hash map.

9:37 AM Changeset in webkit [225271] by Yusuke Suzuki

10 edits in trunk/Source/JavaScriptCore

[JSC] Add MacroAssembler::getEffectiveAddress in all platforms
https://bugs.webkit.org/show_bug.cgi?id=180070

Reviewed by Saam Barati.

This patch adds getEffectiveAddress in all JIT platforms.
This is abstracted version of x86 lea.

We also fix a bug in Yarr that uses branch32 instead of branchPtr for addresses.

assembler/MacroAssemblerARM.h:

(JSC::MacroAssemblerARM::getEffectiveAddress):

assembler/MacroAssemblerARM64.h:

(JSC::MacroAssemblerARM64::getEffectiveAddress):
(JSC::MacroAssemblerARM64::getEffectiveAddress64): Deleted.

assembler/MacroAssemblerARMv7.h:

(JSC::MacroAssemblerARMv7::getEffectiveAddress):

assembler/MacroAssemblerMIPS.h:

(JSC::MacroAssemblerMIPS::getEffectiveAddress):

assembler/MacroAssemblerX86.h:

(JSC::MacroAssemblerX86::getEffectiveAddress):

assembler/MacroAssemblerX86_64.h:

(JSC::MacroAssemblerX86_64::getEffectiveAddress):
(JSC::MacroAssemblerX86_64::getEffectiveAddress64): Deleted.

assembler/testmasm.cpp:

(JSC::testGetEffectiveAddress):
(JSC::run):

dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileArrayPush):

yarr/YarrJIT.cpp:

(JSC::Yarr::YarrGenerator::tryReadUnicodeCharImpl):
(JSC::Yarr::YarrGenerator::tryReadUnicodeChar):

9:31 AM Changeset in webkit [225270] by rmorisset@apple.com

6 edits
2 adds in trunk

The recursive tail call optimisation is wrong on closures
https://bugs.webkit.org/show_bug.cgi?id=179835

Reviewed by Saam Barati.

JSTests:

stress/closure-recursive-tail-call.js: Added.

(makeClosure):

PerformanceTests:

This new benchmark is a very close variant of the merge-sort benchmark, that writes mergeSorted in a kinda CPS style,
to stress the use of closures, and of polymorphic calls.

TailBench9000/merge-sort-cps.js: Added.

(createRNG):
(mergeSorted):
(checkSorted.check):
(add):
(build):
(compare):
(checkSpectrum):
(buildArray):
(test):

Source/JavaScriptCore:

The problem is that we only check the executable of the callee, not whatever variables might have been captured.
As a stopgap measure this patch just does not do the optimisation for closures.

dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::handleRecursiveTailCall):

Tools:

This just includes merge-sort-cps.js to the list of benchmarks ran by run-jsc-benchmarks --tail-bench

Scripts/run-jsc-benchmarks:

9:11 AM Changeset in webkit [225269] by Ms2ger@igalia.com

4 edits in trunk/LayoutTests

LayoutTests/imported/w3c:
Rebaseline imported/w3c/web-platform-tests/resource-timing/single-entry-per-resource.html.
https://bugs.webkit.org/show_bug.cgi?id=180142

Unreviewed test gardening.

web-platform-tests/resource-timing/single-entry-per-resource-expected.txt:

LayoutTests:
Enable imported/w3c/web-platform-tests/resource-timing/single-entry-per-resource.html.
https://bugs.webkit.org/show_bug.cgi?id=180142

Unreviewed test gardening.

The -expected file was updated to list a PASS result.

TestExpectations:

9:09 AM Changeset in webkit [225268] by Ms2ger@igalia.com

8 edits in trunk/LayoutTests

[GTK][WPE] Test gardening
https://bugs.webkit.org/show_bug.cgi?id=180136

Unreviewed test gardening.

TestExpectations: Skip more alternative-presentation-button tests.
platform/gtk/TestExpectations: Updated expectations:
- fast/attachment/attachment-without-appearance.html: recently added test for a disabled feature.
- fast/dom/MutationObserver/end-of-task-delivery.html: flaky.
- http/tests/local/link-stylesheet-load-order-preload.html: flaky.
platform/gtk/compositing/overflow/composited-scrolling-paint-phases-expected.txt: rebaseline for r225220.
platform/mac/TestExpectations: Enable the skipped alternative-presentation-button tests.
platform/wpe/TestExpectations: Updated expectations:
- fast/canvas/canvas-createPattern-video-modify.html: passing since r225060.
- webanimations/*: failing since they were added; bug filed.
platform/wpe/imported/w3c/web-platform-tests/dom/events/EventTarget-dispatchEvent-expected.txt: DeviceMotionEvent and DeviceMotionEvent were disabled in r225098 (matching mac ports); the remaining difference with the platform-neutral expectation is that TouchEvent is enabled here.
platform/wpe/imported/w3c/web-platform-tests/dom/nodes/Document-createEvent-expected.txt: DeviceMotionEvent and DeviceMotionEvent were disabled in r225098 (matching mac ports); the remaining difference with the platform-neutral expectation is that TouchEvent is enabled here.

9:06 AM Changeset in webkit [225267] by Michael Catanzaro

2 edits in trunk/Source/WebKit

REGRESSION(r218064): [GTK] Broke entering fullscreen mode in debug builds
https://bugs.webkit.org/show_bug.cgi?id=180120

Reviewed by Carlos Garcia Campos.

These assertions need to be swapped. Fixes /webkit2/WebKitWebView/fullscreen in debug mode.

UIProcess/API/gtk/WebKitWebViewBase.cpp:

(webkitWebViewBaseEnterFullScreen):
(webkitWebViewBaseExitFullScreen):

6:30 AM Changeset in webkit [225266] by zandobersek@gmail.com

17 edits
3 adds
2 deletes in trunk/Source

[CoordGraphics] Rename CoordinatedBuffer to Nicosia::Buffer
https://bugs.webkit.org/show_bug.cgi?id=180135

Reviewed by Carlos Garcia Campos.

Source/WebCore:

Rename CoordinatedBuffer to Nicosia::Buffer, starting an abstraction
layer that will in the future allow us to prototype and potentially
support different 2D rasterization libraries. The layer is envisioned
as separate from the CoordinatedGraphics code, but will in the mid-term
only be used there.

In order to keep CMake changes to a minimum for now, the source code is
included in the build along with the CoordinatedGraphics source files,
in TextureMapper.cmake.

No new tests -- no change in functionality.

platform/TextureMapper.cmake:
platform/graphics/nicosia/NicosiaBuffer.cpp: Renamed from Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedBuffer.cpp.

(Nicosia::Buffer::create):
(Nicosia::Buffer::Buffer):
(Nicosia::Buffer::context):
(Nicosia::Buffer::uploadImage):

platform/graphics/nicosia/NicosiaBuffer.h: Renamed from Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedBuffer.h.

(Nicosia::Buffer::size const):

platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp:

(WebCore::CoordinatedGraphicsLayer::updateContentBuffers):

platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.h:
platform/graphics/texmap/coordinated/CoordinatedGraphicsState.h:
platform/graphics/texmap/coordinated/CoordinatedImageBacking.cpp:

(WebCore::CoordinatedImageBacking::update):

platform/graphics/texmap/coordinated/CoordinatedImageBacking.h:
platform/graphics/texmap/coordinated/Tile.h:

Source/WebKit:

Adjust code to the CoordinatedBuffer -> Nicosia::Buffer transition.

Shared/CoordinatedGraphics/CoordinatedBackingStore.cpp:

(WebKit::CoordinatedBackingStoreTile::setBackBuffer):
(WebKit::CoordinatedBackingStore::updateTile):

Shared/CoordinatedGraphics/CoordinatedBackingStore.h:
Shared/CoordinatedGraphics/CoordinatedGraphicsScene.cpp:

(WebKit::CoordinatedGraphicsScene::createUpdateAtlas):
(WebKit::CoordinatedGraphicsScene::updateImageBacking):

Shared/CoordinatedGraphics/CoordinatedGraphicsScene.h:
WebProcess/WebPage/CoordinatedGraphics/CompositingCoordinator.cpp:

(WebKit::CompositingCoordinator::updateImageBacking):
(WebKit::CompositingCoordinator::createUpdateAtlas):
(WebKit::CompositingCoordinator::getCoordinatedBuffer):

WebProcess/WebPage/CoordinatedGraphics/CompositingCoordinator.h:
WebProcess/WebPage/CoordinatedGraphics/UpdateAtlas.cpp:

(WebKit::UpdateAtlas::UpdateAtlas):
(WebKit::UpdateAtlas::getCoordinatedBuffer):

WebProcess/WebPage/CoordinatedGraphics/UpdateAtlas.h:

5:53 AM WebKitGTK/2.18.x edited by Adrian Perez de Castro

(diff)

5:31 AM Changeset in webkit [225265] by graouts@webkit.org

5 edits
2 adds in trunk

Pressing the space bar while watching a fullscreen video doesn't play or pause
https://bugs.webkit.org/show_bug.cgi?id=180033
<rdar://problem/33610443>

Reviewed by Eric Carlson.

Source/WebCore:

We register a "keydown" event to track when the space bar is pressed, and if the media is playing
in fullscreen, we toggle playback. This does not interfere with full keyboard access since activating
one of the media controls using the keyboard will not let the events we register for be dispatched
this far along the event dispatch phase.

Test: media/modern-media-controls/media-controller/media-controller-space-bar-toggle-playback.html

Modules/modern-media-controls/media/media-controller.js:

(MediaController):
(MediaController.prototype.togglePlayback): Add a catch() statement since calling play() could sometime
lead to some extraneous unhandled promise console logging that pollutes test output.
(MediaController.prototype.handleEvent):

LayoutTests:

Adding a new macOS-only test that checks that pressing the space bar while playing fullscreen
pauses the media and resumes it when pressing the space bar again.

media/modern-media-controls/media-controller/media-controller-space-bar-toggle-playback-expected.txt: Added.
media/modern-media-controls/media-controller/media-controller-space-bar-toggle-playback.html: Added.
media/video-test.js:

(runWithKeyDown): Update the key to not be space since this would cause media to be paused when entering fullscreen.

platform/ios-simulator/TestExpectations:

Note: See TracTimeline for information about the timeline view.

Download in other formats:

RSS Feed