Timeline

Dec 2, 2017:

9:32 PM Changeset in webkit [225457] by commit-queue@webkit.org

• 6 edits in trunk/Source/WebCore

Move registration activation and clearing from SWServerJobQueue to SWServerRegistration
​https://bugs.webkit.org/show_bug.cgi?id=180325

Patch by Youenn Fablet <​youenn@apple.com> on 2017-12-02
Reviewed by Chris Dumez.

No change of behavior.

These algorithms fit naturally in SWServerRegistration and will be used as part of clients.claim.

• workers/service/server/SWServer.cpp:

(WebCore::SWServer::clearAll):
(WebCore::SWServer::didFinishActivation):

• workers/service/server/SWServerJobQueue.cpp:

(WebCore::SWServerJobQueue::scriptFetchFinished):
(WebCore::SWServerJobQueue::scriptContextFailedToStart):
(WebCore::SWServerJobQueue::didFinishInstall):
(WebCore::SWServerJobQueue::runUnregisterJob):
(WebCore::SWServerJobQueue::tryActivate): Deleted.
(WebCore::SWServerJobQueue::activate): Deleted.
(WebCore::SWServerJobQueue::didFinishActivation): Deleted.
(WebCore::SWServerJobQueue::tryClearRegistration): Deleted.
(WebCore::clearRegistrationWorker): Deleted.
(WebCore::SWServerJobQueue::clearRegistration): Deleted.

• workers/service/server/SWServerJobQueue.h:
• workers/service/server/SWServerRegistration.cpp:

(WebCore::SWServerRegistration::tryClear):
(WebCore::clearRegistrationWorker):
(WebCore::SWServerRegistration::clear):
(WebCore::SWServerRegistration::tryActivate):
(WebCore::SWServerRegistration::activate):
(WebCore::SWServerRegistration::didFinishActivation):

• workers/service/server/SWServerRegistration.h:

8:17 PM Changeset in webkit [225456] by Chris Dumez

• 7 edits
  3 adds in trunk

Support container.register() / registration.unregister() / inside service workers
​https://bugs.webkit.org/show_bug.cgi?id=180326

Reviewed by Youenn Fablet.

LayoutTests/imported/w3c:

Rebaseline WPT test that now passes most checks.

• web-platform-tests/service-workers/service-worker/ServiceWorkerGlobalScope/unregister.https-expected.txt:

Source/WebCore:

Support container.register() / registration.unregister() / inside service workers.
This is mostly about removing the is<Document>() checks and adding testing given
that most of the work was done in r225455.

Test: http/tests/workers/service/ServiceWorkerGlobalScope_register.html

• workers/service/ServiceWorkerContainer.cpp:

(WebCore::ServiceWorkerContainer::addRegistration):

• workers/service/ServiceWorkerRegistration.cpp:

(WebCore::ServiceWorkerRegistration::update):
(WebCore::ServiceWorkerRegistration::unregister):

LayoutTests:

• TestExpectations:

Unskip test for registration.unregister() that now passes.

• http/tests/workers/service/ServiceWorkerGlobalScope_register-expected.txt: Added.
• http/tests/workers/service/ServiceWorkerGlobalScope_register.html: Added.
• http/tests/workers/service/resources/ServiceWorkerGlobalScope_register-worker.js: Added.

Add test coverage for container.register().

6:32 PM Changeset in webkit [225455] by Chris Dumez

• 14 edits
  3 adds in trunk

Support serviceWorkerRegistration.update() inside service workers
​https://bugs.webkit.org/show_bug.cgi?id=180215

Reviewed by Darin Adler.

LayoutTests/imported/w3c:

Rebaseline WPT test that no longer times out. The test still fails even
though we support update(). The issue is that the second frame load
uses the new worker (because of the update()) instead of the old one.
The test seems to expect that the new service worker is still in
waiting state at the point the second frame is loaded. However, for us
it is already activated.

• web-platform-tests/service-workers/service-worker/ServiceWorkerGlobalScope/update.https-expected.txt:

Source/WebCore:

Support serviceWorkerRegistration.update() inside service workers. The code paths
for job scheduling and resolution have been made thread safe by hopping to the right
thread when necessary. In particular, ServiceWorkerContainer always makes sure to to
a callOnMainThread() before calling methods on the SWClientConnection. Also, the
SWClientConnection relies on a new postTaskTo() method before calling methods on the
job.

Test: http/tests/workers/service/self_registration_update.html

• workers/service/SWClientConnection.cpp:

(WebCore::SWClientConnection::scheduleJob):
(WebCore::SWClientConnection::finishedFetchingScript):
(WebCore::SWClientConnection::failedFetchingScript):
(WebCore::SWClientConnection::jobRejectedInServer):
(WebCore::SWClientConnection::registrationJobResolvedInServer):
(WebCore::SWClientConnection::unregistrationJobResolvedInServer):
(WebCore::SWClientConnection::startScriptFetchForServer):
(WebCore::SWClientConnection::postMessageToServiceWorkerClient):
(WebCore::SWClientConnection::updateRegistrationState):
(WebCore::SWClientConnection::updateWorkerState):
(WebCore::SWClientConnection::fireUpdateFoundEvent):
(WebCore::SWClientConnection::notifyClientsOfControllerChange):
(WebCore::SWClientConnection::clearPendingJobs):
(WebCore::SWClientConnection::postTaskTo):

• workers/service/SWClientConnection.h:
• workers/service/ServiceWorkerContainer.cpp:

(WebCore::ServiceWorkerContainer::scheduleJob):
(WebCore::ServiceWorkerContainer::jobFailedWithException):
(WebCore::ServiceWorkerContainer::scheduleTaskToFireUpdateFoundEvent):
(WebCore::ServiceWorkerContainer::jobResolvedWithRegistration):
(WebCore::ServiceWorkerContainer::jobResolvedWithUnregistrationResult):
(WebCore::ServiceWorkerContainer::startScriptFetchForJob):
(WebCore::ServiceWorkerContainer::jobFinishedLoadingScript):
(WebCore::ServiceWorkerContainer::jobFailedLoadingScript):
(WebCore::ServiceWorkerContainer::jobDidFinish):
(WebCore::ServiceWorkerContainer::addRegistration):
(WebCore::ServiceWorkerContainer::removeRegistration):
(WebCore::ServiceWorkerContainer::scheduleTaskToFireControllerChangeEvent):
(WebCore::ServiceWorkerContainer::contextIdentifier):

• workers/service/ServiceWorkerContainer.h:
• workers/service/ServiceWorkerJob.cpp:

(WebCore::ServiceWorkerJob::ServiceWorkerJob):

• workers/service/ServiceWorkerJob.h:

(WebCore::ServiceWorkerJob::contextIdentifier):

• workers/service/ServiceWorkerJobClient.h:
• workers/service/ServiceWorkerRegistration.cpp:

(WebCore::ServiceWorkerRegistration::update):

• workers/service/ServiceWorkerTypes.h:

LayoutTests:

Add layout test coverage and unskip WPT test that no longer times out.

• TestExpectations:
• http/tests/workers/service/resources/self_registration_update-worker.js: Added.
• http/tests/workers/service/self_registration_update-expected.txt: Added.
• http/tests/workers/service/self_registration_update.html: Added.

3:11 PM Changeset in webkit [225454] by Simon Fraser

• 4 edits in trunk/Source/WebCore

Make IOSurface::Locker and use it in ImageBufferDataCG
​https://bugs.webkit.org/show_bug.cgi?id=180317

Reviewed by Zalan Bujtas.

Add an RAII IOSurface::Locker which can lock readonly or readwrite. Access
to the IOSurface base address is through the locker.

Add IOSurface::bytesPerRow() to wrap IOSurfaceGetBytesPerRow().

After this, there is only one location where we access the IOSurfaceRef
directly, in WebGL code.

• platform/graphics/cg/ImageBufferDataCG.cpp:

(WebCore::ImageBufferData::toBGRAData const):
(WebCore::ImageBufferData::getData const):
(WebCore::ImageBufferData::putData):

• platform/graphics/cocoa/IOSurface.h:
• platform/graphics/cocoa/IOSurface.mm:

(WebCore::IOSurface::bytesPerRow const):

12:35 PM Changeset in webkit [225453] by Simon Fraser

• 17 edits in trunk/Source/WebCore

Add an AlphaPremultiplication enum and use it consistently
​https://bugs.webkit.org/show_bug.cgi?id=180316

Reviewed by Zalan Bujtas.

ImageBuffer-related code sometimes used the 'Multiply' enum, and sometimes
a bool to represent alpha premultiplication. Make an enum class and use it
everywhere. Re-order and rename some parameters to clarify the meaning of this
argument.

• html/canvas/CanvasRenderingContext2D.cpp:

(WebCore::CanvasRenderingContext2D::putImageData):

• platform/graphics/GraphicsTypes.cpp:

(WebCore::operator<<):

• platform/graphics/GraphicsTypes.h:
• platform/graphics/ImageBuffer.cpp:

(WebCore::ImageBuffer::genericConvertToLuminanceMask):

• platform/graphics/ImageBuffer.h:
• platform/graphics/ShadowBlur.cpp:

(WebCore::ShadowBlur::blurShadowBuffer):

• platform/graphics/cairo/ImageBufferCairo.cpp:

(WebCore::getImageData):
(WebCore::ImageBuffer::getUnmultipliedImageData const):
(WebCore::ImageBuffer::getPremultipliedImageData const):
(WebCore::ImageBuffer::putByteArray):

• platform/graphics/cg/ImageBufferCG.cpp:

(WebCore::ImageBuffer::getUnmultipliedImageData const):
(WebCore::ImageBuffer::getPremultipliedImageData const):
(WebCore::ImageBuffer::putByteArray):

• platform/graphics/cg/ImageBufferDataCG.cpp:

(WebCore::ImageBufferData::getData const):
(WebCore::ImageBufferData::putData):

• platform/graphics/cg/ImageBufferDataCG.h:
• platform/graphics/filters/FEColorMatrix.cpp:

(WebCore::FEColorMatrix::platformApplySoftware):

• platform/graphics/filters/FEDropShadow.cpp:

(WebCore::FEDropShadow::platformApplySoftware):

• platform/graphics/filters/FilterEffect.cpp:

(WebCore::FilterEffect::imageBufferResult):

• platform/graphics/win/ImageBufferDataDirect2D.cpp:

(WebCore::ImageBufferData::getData const):
(WebCore::ImageBufferData::putData):

• platform/graphics/win/ImageBufferDataDirect2D.h:
• platform/graphics/win/ImageBufferDirect2D.cpp:

(WebCore::ImageBuffer::getUnmultipliedImageData const):
(WebCore::ImageBuffer::getPremultipliedImageData const):
(WebCore::ImageBuffer::putByteArray):

11:41 AM Changeset in webkit [225452] by commit-queue@webkit.org

• 23 edits
  2 copies
  3 adds in trunk

Implement ​https://w3c.github.io/ServiceWorker/#clients-getall
​https://bugs.webkit.org/show_bug.cgi?id=180276

Patch by Youenn Fablet <​youenn@apple.com> on 2017-12-02
Reviewed by Chris Dumez.

LayoutTests/imported/w3c:

• web-platform-tests/service-workers/cache-storage/serviceworker/credentials.https-expected.txt:
• web-platform-tests/service-workers/service-worker/navigate-window.https-expected.txt:

Source/WebCore:

Test: http/tests/workers/service/serviceworkerclients-matchAll.https.html

Move Clients QueryOptions to its own class since it is used by various parties.
Add encoder/decoder routines.

Add a ServieWorkerClientInformation which replaces SWServer::ClientInformation structure.
This is what is sent back as a result to matchAll requests.
Add encoder/decoder routines.

Implement matchAll by hopping to the main thread, making IPC to the storage process.
SWServer in storage process then iterates through the relevant service workers and does some filtering.
Additional filtering and information should be gathered in future patches to fully implement the algorithm.

Add to SWServer a HashMap to easily identify by which service worker a client is controlled, if any.
This map is updated at the same time registrations are updated.

matchAll is given a callback as in the future, window client information will be retrieved asynchronously.

• WebCore.xcodeproj/project.pbxproj:
• workers/service/ServiceWorkerClientInformation.h: Added.

(WebCore::ServiceWorkerClientInformation::isolatedCopy const):
(WebCore::ServiceWorkerClientInformation::encode const):
(WebCore::ServiceWorkerClientInformation::decode):

• workers/service/ServiceWorkerClientQueryOptions.h: Added.

(WebCore::ServiceWorkerClientQueryOptions::encode const):
(WebCore::ServiceWorkerClientQueryOptions::decode):

• workers/service/ServiceWorkerClients.cpp:

(WebCore::ServiceWorkerClients::matchAll):

• workers/service/ServiceWorkerClients.h:
• workers/service/context/SWContextManager.h:
• workers/service/server/SWServer.cpp:

(WebCore::SWServer::matchAll):
(WebCore::SWServer::registerServiceWorkerClient):

• workers/service/server/SWServer.h:
• workers/service/server/SWServerToContextConnection.cpp:

(WebCore::SWServerToContextConnection::matchAll):

• workers/service/server/SWServerToContextConnection.h:
• workers/service/server/SWServerWorker.cpp:

(WebCore::SWServerWorker::matchAll):

• workers/service/server/SWServerWorker.h:

Source/WebKit:

Add IPC plumbery for clients.matchAll between ServiceWorker process and Storage process.

• StorageProcess/ServiceWorker/WebSWServerToContextConnection.cpp:

(WebKit::WebSWServerToContextConnection::matchAllCompleted):

• StorageProcess/ServiceWorker/WebSWServerToContextConnection.h:
• StorageProcess/ServiceWorker/WebSWServerToContextConnection.messages.in:
• WebProcess/Storage/WebSWContextManagerConnection.cpp:

(WebKit::WebSWContextManagerConnection::matchAll):
(WebKit::WebSWContextManagerConnection::matchAllCompleted):

• WebProcess/Storage/WebSWContextManagerConnection.h:
• WebProcess/Storage/WebSWContextManagerConnection.messages.in:

LayoutTests:

• http/tests/workers/service/serviceworkerclients-matchAll-worker.js: Added.
• http/tests/workers/service/serviceworkerclients-matchAll.https-expected.txt: Added.
• http/tests/workers/service/serviceworkerclients-matchAll.https.html: Added.

10:41 AM Changeset in webkit [225451] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebKit

Remote Web Inspector window always shows up at the default size
​https://bugs.webkit.org/show_bug.cgi?id=180284
<rdar://problem/35430255>

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2017-12-02
Reviewed by Brian Burg.

• UIProcess/mac/RemoteWebInspectorProxyMac.mm:

(WebKit::RemoteWebInspectorProxy::platformCreateFrontendPageAndWindow):
Give remote web inspector windows an autosave name so that their frame can
be automatically saved and restored by the system.

10:00 AM Changeset in webkit [225450] by beidson@apple.com

• 6 edits
  2 adds in trunk/Source

Factor out the "databaseTaskQueue" parts of IDBServer into something reusable.
​https://bugs.webkit.org/show_bug.cgi?id=180298

Reviewed by Chris Dumez.

Source/WebCore:

No new tests (Refactor only).

• Modules/indexeddb/server/IDBServer.cpp:

(WebCore::IDBServer::IDBServer::IDBServer):
(WebCore::IDBServer::IDBServer::postDatabaseTask):
(WebCore::IDBServer::IDBServer::postDatabaseTaskReply):
(WebCore::IDBServer::IDBServer::databaseRunLoop): Deleted.
(WebCore::IDBServer::IDBServer::handleTaskRepliesOnMainThread): Deleted.

• Modules/indexeddb/server/IDBServer.h:

(): Deleted.

Source/WTF:

• WTF.xcodeproj/project.pbxproj:
• wtf/CMakeLists.txt:

• wtf/CrossThreadTaskHandler.cpp: Added.

(WTF::CrossThreadTaskHandler::CrossThreadTaskHandler):
(WTF::CrossThreadTaskHandler::~CrossThreadTaskHandler):
(WTF::CrossThreadTaskHandler::postTask):
(WTF::CrossThreadTaskHandler::postTaskReply):
(WTF::CrossThreadTaskHandler::taskRunLoop):
(WTF::CrossThreadTaskHandler::handleTaskRepliesOnMainThread):

• wtf/CrossThreadTaskHandler.h: Added.

9:55 AM Changeset in webkit [225449] by Simon Fraser

• 14 edits in trunk/Source

Add a log channel for viewports
​https://bugs.webkit.org/show_bug.cgi?id=180295

Reviewed by Zalan Bujtas.

Add a "Viewports" log channel to log viewport scaling information, and enhance the
WebKit "VisibleRects" channel to log additional data for the same reason.

Source/WebCore:

• dom/Document.cpp:

(WebCore::Document::processViewport):

• loader/FrameLoader.cpp:

(WebCore::FrameLoader::finishedParsing):
(WebCore::FrameLoader::completed):

• page/FrameView.cpp:

(WebCore::FrameView::resetScrollbarsAndClearContentsSize):
(WebCore::FrameView::scrollToAnchor):
(WebCore::FrameView::maintainScrollPositionAtAnchor):
(WebCore::FrameView::setScrollPosition):
(WebCore::FrameView::autoSizeIfEnabled):
(WebCore::FrameView::setWasScrolledByUser):

• page/LayoutContext.cpp:

(WebCore::LayoutContext::layout):

• page/Page.cpp:

(WebCore::Page::setPageScaleFactor):

• page/ViewportConfiguration.cpp:

(WebCore::ViewportConfiguration::setContentsSize):
(WebCore::ViewportConfiguration::setViewportArguments):
(WebCore::ViewportConfiguration::updateConfiguration):
(WebCore::operator<<):
(WebCore::ViewportConfiguration::description const):
(WebCore::ViewportConfiguration::dump const):

• page/ViewportConfiguration.h:
• platform/Logging.h:
• platform/ScrollView.cpp:

(WebCore::ScrollView::setFixedLayoutSize):

Source/WebKit:

• UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _didCommitLayerTree:]):
(-[WKWebView _dynamicViewportUpdateChangedTargetToScale:position:nextValidLayerTreeTransactionID:]):
(-[WKWebView _dispatchSetMinimumLayoutSize:]):
(-[WKWebView _endAnimatedResize]):
(-[WKWebView _resizeWhileHidingContentWithUpdates:]):

• WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::setFixedLayoutSize):
(WebKit::WebPage::mainFrameDidLayout):
(WebKit::WebPage::didCommitLoad):

• WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::scaleAfterViewportWidthChange):
(WebKit::WebPage::setViewportConfigurationMinimumLayoutSize):
(WebKit::WebPage::dynamicViewportSizeUpdate):
(WebKit::WebPage::resetViewportDefaultConfiguration):
(WebKit::WebPage::viewportConfigurationChanged):
(WebKit::WebPage::updateVisibleContentRects):

7:13 AM Changeset in webkit [225448] by Carlos Garcia Campos

• 7 edits in trunk/Source

WebDriver: handle user prompts shown while executing scripts
​https://bugs.webkit.org/show_bug.cgi?id=179979

Reviewed by Brian Burg.

Source/WebDriver:

15.2 Executing Script
​https://w3c.github.io/webdriver/webdriver-spec.html#executing-script

The rules to execute a function body are as follows. The algorithm will return success with the JSON
representation of the function’s return value, or an error if the evaluation of the function results in a
JavaScript exception being thrown or at any point during its execution an unhandled user prompt appears.

If at any point during the algorithm a user prompt appears, the user prompt handler must be invoked. If its
return value is an error, it must immediately return with that error and abort all subsequent substeps of this
algorithm.

This will be covered by new WPT tests that will be available after the next upgrade.

• CommandResult.cpp:

(WebDriver::CommandResult::CommandResult): Handle UnexpectedAlertOpen internal error.

• Session.cpp:

(WebDriver::Session::handleUserPrompts): Move code to handleUnexpectedAlertOpen() and call it instead.
(WebDriver::Session::handleUnexpectedAlertOpen): Code moved here to be used also by executeScript().
(WebDriver::Session::executeScript): In case of UnexpectedAlertOpen error, call handleUnexpectedAlertOpen().

• Session.h:

Source/WebKit:

• UIProcess/Automation/Automation.json: Add UnexpectedAlertOpen error.
• UIProcess/Automation/WebAutomationSession.cpp:

(WebKit::WebAutomationSession::willShowJavaScriptDialog): Finish pending evaluateJavaScriptFunction operations
with UnexpectedAlertOpen error.

6:56 AM Changeset in webkit [225447] by Carlos Garcia Campos

• 16 edits
  1 add
  1 delete in trunk

WebDriver: auto-install pytest instead of importing it from wpt tools directory
​https://bugs.webkit.org/show_bug.cgi?id=180243

Reviewed by Brian Burg.

Tools:

We don't really need the (old) version included in wpt tools dir, so we can simply remove it and use autoinstall
instead.

• Scripts/webkitpy/thirdparty/init.py:

(AutoinstallImportHook.find_module): Check pytest.
(AutoinstallImportHook._install_pytest): Install pytest.

• Scripts/webkitpy/webdriver_tests/webdriver_selenium_executor.py: Import autoinstalled pytest.
• Scripts/webkitpy/webdriver_tests/webdriver_test_runner_w3c.py:

(WebDriverTestRunnerW3C.run): Update the subtest path since the new pytest uses a different strategy for
rootdir.

• Scripts/webkitpy/webdriver_tests/webdriver_w3c_executor.py: Import autoinstalled pytest.

WebDriverTests:

• imported/selenium/py/conftest.py: Stop patching this to use yield_fixture, new pytest supports this.
• imported/selenium/py/setup.cfg: Stop patching this, since pytest supports tool:pytest as group name.
• imported/selenium/py/test/selenium/webdriver/common/alerts_tests.py: Stop patching this to use yield_fixture,

new pytest supports this.

• imported/selenium/py/test/selenium/webdriver/common/cookie_tests.py: Ditto.
• imported/selenium/py/test/selenium/webdriver/common/frame_switching_tests.py: Ditto.
• imported/selenium/py/test/selenium/webdriver/common/page_load_timeout_tests.py: Ditto.
• imported/selenium/py/test/selenium/webdriver/common/window_switching_tests.py: Ditto.
• imported/selenium/py/test/selenium/webdriver/safari/conftest.py: Ditto.
• imported/selenium/py/test/selenium/webdriver/support/event_firing_webdriver_tests.py: Ditto.
• imported/w3c/importer.json: Stop importing pytest.
• imported/w3c/pytest.ini: Added.
• imported/w3c/tools/pytest/: Removed.

12:47 AM Changeset in webkit [225446] by Wenson Hsieh

• 6 edits in trunk/Source/WebKit

Make some minor adjustments to TouchBarMenuData and TouchBarMenuItemData
​https://bugs.webkit.org/show_bug.cgi?id=180305

Reviewed by Joseph Pecoraro.

Mark some methods and parameters as const, use the default constructor in more places, and also remove a few
extraneous imported headers.

• Shared/TouchBarMenuData.cpp:

(WebKit::TouchBarMenuData::TouchBarMenuData):

Add a FIXME regarding the use of the 'id' attribute.

(WebKit::TouchBarMenuData::decode):

• Shared/TouchBarMenuData.h:

(WebKit::TouchBarMenuData::items const):
(WebKit::TouchBarMenuData::setID):
(WebKit::TouchBarMenuData::isPageCustomized const):
(WebKit::TouchBarMenuData::items): Deleted.
(WebKit::TouchBarMenuData::isPageCustomized): Deleted.

• Shared/TouchBarMenuItemData.cpp:

(WebKit::getItemType):

Change a helper method from a static class function to a static function in the implementation file.

(WebKit::TouchBarMenuItemData::TouchBarMenuItemData):
(WebKit::TouchBarMenuItemData::encode const):
(WebKit::TouchBarMenuItemData::decode):
(WebKit::TouchBarMenuItemData::getItemType): Deleted.

• Shared/TouchBarMenuItemData.h:

(WebKit::operator==):

Remove the commandName member variable, since it doesn't make sense to propagate an event handler
attribute from WebCore to the client layer.

• UIProcess/WebPageProxy.messages.in:

Dec 1, 2017:

10:55 PM Changeset in webkit [225445] by zandobersek@gmail.com

• 2 edits in trunk/Source/WebKit

Unreviewed GTK+ debug build fix. Replace ASSERT_UNUSED() with UNUSED_PARAM()
in WebKit::WebPage methods that used to operate on HTMLMenuElement pointer
values (which have been converted to references).

• WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::didInsertMenuElement):
(WebKit::WebPage::didRemoveMenuElement):
(WebKit::WebPage::didInsertMenuItemElement):
(WebKit::WebPage::didRemoveMenuItemElement):

10:48 PM Changeset in webkit [225444] by jfbastien@apple.com

• 1 edit
  1 add in trunk/JSTests

Try proxying all function arguments
​https://bugs.webkit.org/show_bug.cgi?id=180306

Reviewed by Saam Barati.

• stress/proxy-all-the-parameters.js: Added.

(isPropertyOfType):
(getProperties):
(generateObjects):
(getObjects):
(getFunctions):
(get throw):
(let.o.of.getObjects.let.f.of.getFunctions.catch):

9:44 PM Changeset in webkit [225443] by jfbastien@apple.com

• 3 edits
  1 add in trunk

JavaScriptCore: missing exception checks in Math functions that take more than one argument
​https://bugs.webkit.org/show_bug.cgi?id=180297
<rdar://problem/35745556>

Reviewed by Mark Lam.

JSTests:

• stress/math-exceptions.js: Added.

(get try):
(catch):

Source/JavaScriptCore:

• runtime/MathObject.cpp:

(JSC::mathProtoFuncATan2):
(JSC::mathProtoFuncMax):
(JSC::mathProtoFuncMin):
(JSC::mathProtoFuncPow):

9:39 PM Changeset in webkit [225442] by commit-queue@webkit.org

• 6 edits
  4 adds in trunk

[MSE] Use correct range end checks in sourceBufferPrivateDidReceiveSample()
​https://bugs.webkit.org/show_bug.cgi?id=179690

Patch by Alicia Boya García <​aboya@igalia.com> on 2017-12-01
Reviewed by Jer Noble.

Source/WebCore:

The Coded Frame Processing algorithm as defined in
​https://www.w3.org/TR/media-source/#sourcebuffer-coded-frame-processing states:

1.14. Remove existing coded frames in track buffer:

-> If highest end timestamp for track buffer is not set:

[...]

-> If highest end timestamp for track buffer is set and less than or

equal to presentation timestamp:

Remove all coded frames from track buffer that have a
presentation timestamp greater than or equal to highest end
timestamp and less than frame end timestamp.

Note the removal range is closed-open [a, b). WebKit is actually removing
frames using an open-closed range (a, b], which causes frames not to be removed
in situations where they should and frames to be removed in situations when
they should not.

Tests: media/media-source/media-source-range-end-frame-not-removed.html

media/media-source/media-source-range-start-frame-replaced.html

• Modules/mediasource/SampleMap.cpp:

(WebCore::PresentationOrderSampleMap::findSamplesBetweenPresentationTimesFromEnd):

• Modules/mediasource/SampleMap.h:
• Modules/mediasource/SourceBuffer.cpp:

(WebCore::SourceBuffer::sourceBufferPrivateDidReceiveSample):

LayoutTests:

Added test cases for bug #179690.

• media/media-source/media-source-range-end-frame-not-removed-expected.txt: Added.
• media/media-source/media-source-range-end-frame-not-removed.html: Added.
• media/media-source/media-source-range-start-frame-replaced-expected.txt: Added.
• media/media-source/media-source-range-start-frame-replaced.html: Added.

7:19 PM Changeset in webkit [225441] by Simon Fraser

• 6 edits in trunk/Source

Reduce the number of calls to ViewportConfiguration::updateConfiguration()
​https://bugs.webkit.org/show_bug.cgi?id=180299

Reviewed by Zalan Bujtas.

There are several calls to ViewportConfiguration::setDefaultConfiguration() during loading
with the same arguments. We can avoid unnecessary calls to updateConfiguration() by returning
early if the configuration hasn't changed.

Source/WebCore:

• page/ViewportConfiguration.cpp:

(WebCore::ViewportConfiguration::setDefaultConfiguration):

• page/ViewportConfiguration.h:

(WebCore::ViewportConfiguration::Parameters::operator== const):

Source/WebKit:

Also move the fetching of ViewportConfiguration::xhtmlMobileParameters() from didReceiveMobileDocType()
into resetViewportDefaultConfiguration() where we grab all the other default configs.

• WebProcess/WebPage/WebPage.h:
• WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::didReceiveMobileDocType):
(WebKit::WebPage::resetViewportDefaultConfiguration):

5:56 PM Changeset in webkit [225440] by Dewei Zhu

• 2 edits in trunk/Tools

Hardcoded python path is not compatible with virtual environment.
​https://bugs.webkit.org/show_bug.cgi?id=180300

Reviewed by Stephanie Lewis.

Hardcoding '/usr/bin/python' does not work with python virtual environment.
Use 'python' instead.

• Scripts/webkitpy/benchmark_runner/http_server_driver/simple_http_server_driver.py:

(SimpleHTTPServerDriver.serve):

5:56 PM Changeset in webkit [225439] by Ms2ger@igalia.com

• 2 edits in trunk/LayoutTests

[WPE] Enable wpt css tests.
​https://bugs.webkit.org/show_bug.cgi?id=180289

Unreviewed test gardening.

• platform/wpe/TestExpectations:

5:38 PM Changeset in webkit [225438] by commit-queue@webkit.org

• 15 edits
  2 copies
  2 adds in trunk/Source

[Touch Bar Web API] Object representing Touch Bar Menu to send between Web and UI Processes
​https://bugs.webkit.org/show_bug.cgi?id=179714

Patch by Aishwarya Nirmal <​anirmal@apple.com> on 2017-12-01
Reviewed by Wenson Hsieh.

Source/WebCore:

These changes allow the HTMLMenuElement and HTMLMenuItemElement to parse attributes relating
to the touch bar and convey changes to the elements that will eventually be propogated to the
UI process.

No new tests at this point because the changes to HTMLMenuElement and HTMLMenuItemElement are
new properties, which might not be worth testing, and overriden methods for insertedIntoAncestor
and removedFromAncestor, which are involved in sending a message to a UI process but might be
difficult to test at this point since the UI process only receives (and does not yet process)
the message.

• html/HTMLMenuElement.cpp:

(WebCore::HTMLMenuElement::insertedIntoAncestor):
(WebCore::HTMLMenuElement::removedFromAncestor):
(WebCore::HTMLMenuElement::parseAttribute):

• html/HTMLMenuElement.h:
• html/HTMLMenuItemElement.cpp:

(WebCore::HTMLMenuItemElement::insertedIntoAncestor):
(WebCore::HTMLMenuItemElement::removedFromAncestor):

• html/HTMLMenuItemElement.h:
• page/ChromeClient.h:

Source/WebKit:

These changes define the TouchBarMenuData and TouchBarMenuItemData objects which draw information
from touch bar HTMLMenuElement and HTMLMenuItemElement. These objects represent the contents of
the page-customized touch bar. Changes to the html elements representing the touch bar are sent
to the UI process.

• Shared/TouchBarMenuData.cpp: Copied from Source/WebCore/html/HTMLMenuItemElement.cpp.

(WebKit::TouchBarMenuData::TouchBarMenuData):
(WebKit::TouchBarMenuData::addMenuItem):
(WebKit::TouchBarMenuData::removeMenuItem):
(WebKit::TouchBarMenuData::encode const):
(WebKit::TouchBarMenuData::decode):

• Shared/TouchBarMenuData.h: Copied from Source/WebCore/html/HTMLMenuItemElement.h.

(WebKit::TouchBarMenuData::items):
(WebKit::TouchBarMenuData::isPageCustomized):
(WebKit::TouchBarMenuData::setIsPageCustomized):

• Shared/TouchBarMenuItemData.cpp: Added.

(WebKit::TouchBarMenuItemData::getItemType):
(WebKit::TouchBarMenuItemData::TouchBarMenuItemData):
(WebKit::TouchBarMenuItemData::encode const):
(WebKit::TouchBarMenuItemData::decode):

• Shared/TouchBarMenuItemData.h: Added.

(WebKit::operator<):
(WebKit::operator>):
(WebKit::operator<=):
(WebKit::operator>=):
(WebKit::operator==):
(WebKit::operator!=):

• UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::touchBarMenuDataChanged):
(WebKit::WebPageProxy::touchBarMenuItemDataAdded):
(WebKit::WebPageProxy::touchBarMenuItemDataRemoved):

• UIProcess/WebPageProxy.h:

(WebKit::WebPageProxy::touchBarMenuData const):

• UIProcess/WebPageProxy.messages.in:
• WebKit.xcodeproj/project.pbxproj:
• WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::didInsertMenuElement):
(WebKit::WebChromeClient::didRemoveMenuElement):
(WebKit::WebChromeClient::didInsertMenuItemElement):
(WebKit::WebChromeClient::didRemoveMenuItemElement):

• WebProcess/WebCoreSupport/WebChromeClient.h:
• WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::didInsertMenuElement):
(WebKit::WebPage::didRemoveMenuElement):
(WebKit::WebPage::didInsertMenuItemElement):
(WebKit::WebPage::didRemoveMenuItemElement):
(WebKit::WebPage::sendTouchBarMenuDataRemovedUpdate):
(WebKit::WebPage::sendTouchBarMenuDataAddedUpdate):
(WebKit::WebPage::sendTouchBarMenuItemDataAddedUpdate):
(WebKit::WebPage::sendTouchBarMenuItemDataRemovedUpdate):

• WebProcess/WebPage/WebPage.h:

5:12 PM Changeset in webkit [225437] by mark.lam@apple.com

• 18 edits
  2 adds in trunk/Source

Let's scramble ClassInfo pointers in cells.
​https://bugs.webkit.org/show_bug.cgi?id=180291
<rdar://problem/35807620>

Reviewed by JF Bastien.

Source/JavaScriptCore:

• API/JSCallbackObject.h:
• API/JSObjectRef.cpp:

(classInfoPrivate):

• JavaScriptCore.xcodeproj/project.pbxproj:
• Sources.txt:
• assembler/MacroAssemblerCodeRef.cpp:

(JSC::MacroAssemblerCodePtr::initialize): Deleted.

• assembler/MacroAssemblerCodeRef.h:

(JSC::MacroAssemblerCodePtr:: const):
(JSC::MacroAssemblerCodePtr::hash const):

• dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::checkArray):
(JSC::DFG::SpeculativeJIT::compileCheckSubClass):
(JSC::DFG::SpeculativeJIT::compileNewStringObject):

• ftl/FTLLowerDFGToB3.cpp:

(JSC::FTL::DFG::LowerDFGToB3::compileNewStringObject):
(JSC::FTL::DFG::LowerDFGToB3::compileCheckSubClass):

• jit/AssemblyHelpers.h:

(JSC::AssemblyHelpers::emitAllocateDestructibleObject):

• jit/SpecializedThunkJIT.h:

(JSC::SpecializedThunkJIT::loadArgumentWithSpecificClass):

• runtime/InitializeThreading.cpp:

(JSC::initializeThreading):

• runtime/JSCScrambledPtr.cpp: Added.

(JSC::initializeScrambledPtrKeys):

• runtime/JSCScrambledPtr.h: Added.
• runtime/JSDestructibleObject.h:

(JSC::JSDestructibleObject::classInfo const):

• runtime/JSSegmentedVariableObject.h:

(JSC::JSSegmentedVariableObject::classInfo const):

• runtime/Structure.h:
• runtime/VM.h:

Source/WTF:

• wtf/ScrambledPtr.h:

(WTF::ScrambledPtr::descrambled const):
(WTF::ScrambledPtr::bits const):
(WTF::ScrambledPtr::operator==):
(WTF::ScrambledPtr::operator=):
(WTF::ScrambledPtr::scramble):
(WTF::ScrambledPtr::descramble):
(WTF::ScrambledPtr:: const): Deleted.
(WTF::ScrambledPtr::scrambledBits const): Deleted.

5:04 PM Changeset in webkit [225436] by Michael Catanzaro

• 2 edits in trunk/Source/ThirdParty/ANGLE

Unreviewed, fix byte order macros and address new -Wunknown-pragmas warnings
​https://bugs.webkit.org/show_bug.cgi?id=180177
<rdar://problem/35774734>

I'm not sure how this code was developed, as it seems to have been designed for GCC, but it
does not use any of GCC's documented byte order macros, and accordingly does not work. Let's
fix it to guarantee there are no problems when building with GCC. I presume it should help
Clang as well.

This time, hopefully without breaking 32-bit macOS, where BYTE_ORDER actually is defined.

• src/common/third_party/smhasher/src/PMurHash.cpp:

(angle::PMurHash32_Process):

4:41 PM Changeset in webkit [225435] by jfbastien@apple.com

• 1 edit
  1 add in trunk/JSTests

JavaScriptCore: add test for weird class static getters
​https://bugs.webkit.org/show_bug.cgi?id=180281
<rdar://problem/35592139>

Reviewed by Mark Lam.

I fixed a bug for it in r224927 and didn't add a test. Do so.

• stress/class-static-get-weird.js: Added.

(c.prototype.get name):
(c):
(c.prototype.get arguments):
(c.prototype.get caller):
(c.prototype.get length):

4:40 PM Changeset in webkit [225434] by jmarcell@apple.com

• 7 edits in tags/Safari-605.1.15.1/Source

Versioning.

4:39 PM Changeset in webkit [225433] by aakash_jain@apple.com

• 3 edits
  1 copy in trunk/Tools

[build.webkit.org] Move python code to load config from master.cfg in separate file
​https://bugs.webkit.org/show_bug.cgi?id=180278

Reviewed by Daniel Bates.

• BuildSlaveSupport/build.webkit.org-config/master.cfg: Moved appropriate code to loadConfig.py
• BuildSlaveSupport/build.webkit.org-config/loadConfig.py: Ditto.
• BuildSlaveSupport/build.webkit.org-config/steps.py: Removed extra import.

4:29 PM Changeset in webkit [225432] by Matt Lewis

• 2 edits in trunk/LayoutTests

Marked imported/w3c/web-platform-tests/IndexedDB/open-request-queue.html as flaky timeout on wk1.
​https://bugs.webkit.org/show_bug.cgi?id=172044

Unreviewed test gardening.

• platform/mac-wk1/TestExpectations:

4:28 PM Changeset in webkit [225431] by dbates@webkit.org

• 5 edits in trunk

AlternativePresentationButtonSubstitution::unapply() may not undo substitution
​https://bugs.webkit.org/show_bug.cgi?id=180279
<rdar://problem/35800599>

Reviewed by Simon Fraser.

Source/WebCore:

Fixes an issue where removing an alternative presentation button substituted for a non-HTML input
element did not restore the original appearance of the element before the substitution.

To substitute the alternative presentation button for a non-HTML input element we attach a
user-agent shadow root to it. Adding a shadow root, including a user-agent shadow root,
tears down the existing renderers for the element. Currently when we unapply such a substitution
we ultimately just remove the shadow root and do not create new renderers for the subtree
that the shadow root was removed from. We need to create new renderers for this subtree
to restore the original appearance of the element before the substitution.

• editing/cocoa/AlternativePresentationButtonSubstitution.cpp:

(WebCore::AlternativePresentationButtonSubstitution::unapply):

LayoutTests:

Update test to ensure that we undo the alternative presentation button substitution
made to an HTML label element.

• fast/forms/alternative-presentation-button/replace-and-remove-expected.html:
• fast/forms/alternative-presentation-button/replace-and-remove.html:

4:20 PM Changeset in webkit [225430] by commit-queue@webkit.org

• 18 edits
  2 moves in trunk/Source

Move DateComponents into WTF
​https://bugs.webkit.org/show_bug.cgi?id=180211

Patch by Christopher Reid <​chris.reid@sony.com> on 2017-12-01
Reviewed by Myles C. Maxfield.

Source/WebCore:

No new tests no change in behavior.

Moved DateComponents from platform into WTF.

• Sources.txt: Removed DateComponents
• WebCore.xcodeproj/project.pbxproj: Removed DateComponents
• dom/Document.cpp:
• html/BaseDateAndTimeInputType.h:
• html/DateTimeInputType.h: Fixed a call to the wrong parent constructor
• html/HTMLInputElement.h:
• html/InputType.cpp:
• html/InputType.h:
• platform/text/PlatformLocale.cpp:
• platform/text/PlatformLocale.h:
• platform/text/ios/LocalizedDateCache.h:
• platform/text/mac/LocaleMac.h:
• platform/text/win/LocaleWin.cpp:
• platform/text/win/LocaleWin.h:
• rendering/RenderThemeIOS.mm:

Source/WTF:

Moved DateComponents from WebCore/platform into WTF.
Removed isLeapYear from DateComponents as DateMath already has that function.

• WTF.xcodeproj/project.pbxproj:
• wtf/CMakeLists.txt:
• wtf/DateComponents.cpp: Renamed from Source\WebCore\platform\DateComponents.cpp.
• wtf/DateComponents.h: Renamed from Source\WebCore\platform\DateComponents.h.

4:09 PM Changeset in webkit [225429] by dbates@webkit.org

• 14 edits
  2 adds in trunk

Alternative Presentation Button: Provide a way to query for the replaced elements
​https://bugs.webkit.org/show_bug.cgi?id=180114
<rdar://problem/35710539>

Reviewed by Tim Horton.

Source/WebCore:

Add SPI to query for the elements that were replaced by an Alternative Presentation Button.

Test: fast/forms/alternative-presentation-button/replaced-elements.html

• editing/Editor.cpp:

(WebCore::Editor::elementsReplacedByAlternativePresentationButton): Added.

• editing/Editor.h:
• editing/cocoa/AlternativePresentationButtonSubstitution.cpp:

(WebCore::AlternativePresentationButtonSubstitution::replacedElements): Added.

• editing/cocoa/AlternativePresentationButtonSubstitution.h:
• testing/Internals.cpp:

(WebCore::Internals::elementsReplacedByAlternativePresentationButton): Added.

• testing/Internals.h:
• testing/Internals.idl: Expose internals function elementsReplacedByAlternativePresentationButton()

so as to test Editor::elementsReplacedByAlternativePresentationButton().

Source/WebKit:

Add SPI to query for the elements that were replaced by an Alternative Presentation Button.

• WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInFrame.mm:

(-[WKWebProcessPlugInFrame elementsReplacedByAlternativePresentationButtonWithIdentifier:]): Added.

• WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInFramePrivate.h:
• WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp:

(WKBundleElementsReplacedByAlternativePresentationButton): Added.

• WebProcess/InjectedBundle/API/c/WKBundleFramePrivate.h:

LayoutTests:

Add a test to ensure that Editor::elementsReplacedByAlternativePresentationButton()
returns the same list of elements that were specified to Editor::substituteWithAlternativePresentationButton()
up to ordering.

• fast/forms/alternative-presentation-button/replaced-elements-expected.txt: Added.
• fast/forms/alternative-presentation-button/replaced-elements.html: Added.

4:01 PM Changeset in webkit [225428] by commit-queue@webkit.org

• 8 edits
  2 moves in trunk/Source/WebCore

Rename ImageFrameCache to ImageSource
​https://bugs.webkit.org/show_bug.cgi?id=180172

Patch by Said Abou-Hallawa <​sabouhallawa@apple.com> on 2017-12-01
Reviewed by Per Arne Vollan.

This is a follow-up for r225300. ImageSource is the intended name after
merging ImageFrameCache and ImageSource.

• Sources.txt:
• WebCore.xcodeproj/project.pbxproj:
• platform/graphics/BitmapImage.cpp:

(WebCore::BitmapImage::BitmapImage):

• platform/graphics/BitmapImage.h:
• platform/graphics/ImageFrame.h:
• platform/graphics/ImageFrameCache.cpp: Removed.
• platform/graphics/ImageFrameCache.h: Removed.
• platform/graphics/ImageSource.cpp: Added.

(WebCore::ImageSource::ImageSource):
(WebCore::ImageSource::~ImageSource):
(WebCore::ImageSource::ensureDecoderAvailable):
(WebCore::ImageSource::setData):
(WebCore::ImageSource::resetData):
(WebCore::ImageSource::dataChanged):
(WebCore::ImageSource::isAllDataReceived):
(WebCore::ImageSource::destroyDecodedData):
(WebCore::ImageSource::destroyIncompleteDecodedData):
(WebCore::ImageSource::clearFrameBufferCache):
(WebCore::ImageSource::decodedSizeChanged):
(WebCore::ImageSource::decodedSizeIncreased):
(WebCore::ImageSource::decodedSizeDecreased):
(WebCore::ImageSource::decodedSizeReset):
(WebCore::ImageSource::didDecodeProperties):
(WebCore::ImageSource::growFrames):
(WebCore::ImageSource::setNativeImage):
(WebCore::ImageSource::cacheMetadataAtIndex):
(WebCore::ImageSource::cacheNativeImageAtIndex):
(WebCore::ImageSource::cacheNativeImageAtIndexAsync):
(WebCore::ImageSource::decodingQueue):
(WebCore::ImageSource::frameRequestQueue):
(WebCore::ImageSource::canUseAsyncDecoding):
(WebCore::ImageSource::startAsyncDecodingQueue):
(WebCore::ImageSource::requestFrameAsyncDecodingAtIndex):
(WebCore::ImageSource::isAsyncDecodingQueueIdle const):
(WebCore::ImageSource::stopAsyncDecodingQueue):
(WebCore::ImageSource::frameAtIndexCacheIfNeeded):
(WebCore::ImageSource::clearMetadata):
(WebCore::ImageSource::sourceURL const):
(WebCore::ImageSource::mimeType const):
(WebCore::ImageSource::expectedContentLength const):
(WebCore::ImageSource::metadata):
(WebCore::ImageSource::frameMetadataAtIndex):
(WebCore::ImageSource::frameMetadataAtIndexCacheIfNeeded):
(WebCore::ImageSource::encodedDataStatus):
(WebCore::ImageSource::frameCount):
(WebCore::ImageSource::repetitionCount):
(WebCore::ImageSource::uti):
(WebCore::ImageSource::filenameExtension):
(WebCore::ImageSource::hotSpot):
(WebCore::ImageSource::size):
(WebCore::ImageSource::sizeRespectingOrientation):
(WebCore::ImageSource::singlePixelSolidColor):
(WebCore::ImageSource::maximumSubsamplingLevel):
(WebCore::ImageSource::frameIsBeingDecodedAndIsCompatibleWithOptionsAtIndex):
(WebCore::ImageSource::frameDecodingStatusAtIndex):
(WebCore::ImageSource::frameHasAlphaAtIndex):
(WebCore::ImageSource::frameHasFullSizeNativeImageAtIndex):
(WebCore::ImageSource::frameHasDecodedNativeImageCompatibleWithOptionsAtIndex):
(WebCore::ImageSource::frameSubsamplingLevelAtIndex):
(WebCore::ImageSource::frameSizeAtIndex):
(WebCore::ImageSource::frameBytesAtIndex):
(WebCore::ImageSource::frameDurationAtIndex):
(WebCore::ImageSource::frameOrientationAtIndex):
(WebCore::ImageSource::setTargetContext):
(WebCore::ImageSource::createFrameImageAtIndex):
(WebCore::ImageSource::frameImageAtIndex):
(WebCore::ImageSource::frameImageAtIndexCacheIfNeeded):
(WebCore::ImageSource::dump):

• platform/graphics/ImageSource.h: Added.

(WebCore::ImageSource::create):
(WebCore::ImageSource::decodedSize const):
(WebCore::ImageSource::destroyAllDecodedData):
(WebCore::ImageSource::destroyAllDecodedDataExcludeFrame):
(WebCore::ImageSource::destroyDecodedDataBeforeFrame):
(WebCore::ImageSource::clearImage):
(WebCore::ImageSource::requestFrameAsyncDecodingAtIndex):
(WebCore::ImageSource::hasAsyncDecodingQueue const):
(WebCore::ImageSource::isSizeAvailable):
(WebCore::ImageSource::isDecoderAvailable const):
(WebCore::ImageSource::frameAtIndexCacheIfNeeded):
(WebCore::ImageSource::ImageFrameRequest::operator== const):

• platform/graphics/cairo/GraphicsContext3DCairo.cpp:

(WebCore::GraphicsContext3D::ImageExtractor::extractImage):

• platform/graphics/cg/GraphicsContext3DCG.cpp:

(WebCore::GraphicsContext3D::ImageExtractor::extractImage):

4:00 PM Changeset in webkit [225427] by commit-queue@webkit.org

• 25 edits
  3 adds in trunk

Implement ​https://w3c.github.io/ServiceWorker/#clients-get
​https://bugs.webkit.org/show_bug.cgi?id=180167

Patch by Youenn Fablet <​youenn@apple.com> on 2017-12-01
Reviewed by Chris Dumez.

Source/WebCore:

Test: http/tests/workers/service/serviceworkerclients-get.https.html

Implement clients get by having service worker clients do the following:

• Go to main thread to query the SWClientConnection for getting the client.
• SWClientConnection requests it through IPC to StorageProcess SWServer.
• SWServer looks at its client map and returns client data based on the given identifier.
• SWClientConnection sends it back to the right clients for resolving the promise.

Identifier is parsed at service worker process level.

Made ServiceWorkerClients no longer an ActiveDOMObject since it is owned by ServiceWorkerGlobalScope
and is only exposed in service workers.

• workers/service/ServiceWorkerClientIdentifier.h:

(WebCore::ServiceWorkerClientIdentifier::fromString):

• workers/service/ServiceWorkerClients.cpp:

(WebCore::ServiceWorkerClients::ServiceWorkerClients):
(WebCore::ServiceWorkerClients::get):

• workers/service/ServiceWorkerClients.h:

(WebCore::ServiceWorkerClients::create):

• workers/service/context/SWContextManager.cpp:

(WebCore::SWContextManager::postTaskToServiceWorker):

• workers/service/context/SWContextManager.h:
• workers/service/server/SWServer.cpp:

(WebCore::SWServer::getClientFromId):

• workers/service/server/SWServer.h:
• workers/service/server/SWServerToContextConnection.cpp:

(WebCore::SWServerToContextConnection::findClientByIdentifier):

• workers/service/server/SWServerToContextConnection.h:
• workers/service/server/SWServerWorker.cpp:

(WebCore::SWServerWorker::origin const):
(WebCore::SWServerWorker::findClientByIdentifier):

• workers/service/server/SWServerWorker.h:

Source/WebKit:

Add IPC plumbery for clientFromId between ServiceWorker process and Storage process.

• StorageProcess/ServiceWorker/WebSWServerToContextConnection.cpp:

(WebKit::WebSWServerToContextConnection::clientFromIdCompleted):

• StorageProcess/ServiceWorker/WebSWServerToContextConnection.h:
• StorageProcess/ServiceWorker/WebSWServerToContextConnection.messages.in:
• WebProcess/Storage/WebSWContextManagerConnection.cpp:

(WebKit::WebSWContextManagerConnection::findClientByIdentifier):
(WebKit::WebSWContextManagerConnection::findClientByIdentifierCompleted):

• WebProcess/Storage/WebSWContextManagerConnection.h:
• WebProcess/Storage/WebSWContextManagerConnection.messages.in:

Source/WTF:

• wtf/text/StringView.h:

(WTF::StringView::toUInt64Strict const):

• wtf/text/WTFString.h:

LayoutTests:

• http/tests/workers/service/resources/serviceworkerclients-get-worker.js: Added.
• http/tests/workers/service/serviceworkerclients-get.https-expected.txt: Added.
• http/tests/workers/service/serviceworkerclients-get.https.html: Added.

3:52 PM Changeset in webkit [225426] by Ryan Haddad

• 4 edits in trunk/LayoutTests

Update TestExpectations for editing/input tests on iOS.

Unreviewed test gardening.

• platform/ios-wk1/TestExpectations:
• platform/ios-wk2/TestExpectations:
• platform/ios/TestExpectations:

3:45 PM Changeset in webkit [225425] by BJ Burg

• 67 edits in trunk

Web Inspector: move Inspector::Protocol::Array<T> to JSON namespace
​https://bugs.webkit.org/show_bug.cgi?id=173662

Reviewed by Joseph Pecoraro.

Source/JavaScriptCore:

Adopt new type names. Fix protocol generator to use correct type names.

• inspector/ConsoleMessage.cpp:

(Inspector::ConsoleMessage::addToFrontend):
Improve namings and use 'auto' when the type is obvious and repeated.

• inspector/ContentSearchUtilities.cpp:

(Inspector::ContentSearchUtilities::searchInTextByLines):

• inspector/ContentSearchUtilities.h:
• inspector/InjectedScript.cpp:

(Inspector::InjectedScript::getProperties):
(Inspector::InjectedScript::getDisplayableProperties):
(Inspector::InjectedScript::getInternalProperties):
(Inspector::InjectedScript::getCollectionEntries):
(Inspector::InjectedScript::wrapCallFrames const):

• inspector/InjectedScript.h:
• inspector/InspectorProtocolTypes.h:

(Inspector::Protocol::BindingTraits<JSON::ArrayOf<T>>::runtimeCast):
(Inspector::Protocol::Array::Array): Deleted.
(Inspector::Protocol::Array::openAccessors): Deleted.
(Inspector::Protocol::Array::addItem): Deleted.
(Inspector::Protocol::Array::create): Deleted.
(Inspector::Protocol::BindingTraits<Protocol::Array<T>>::runtimeCast): Deleted.
(Inspector::Protocol::BindingTraits<Protocol::Array<T>>::assertValueHasExpectedType): Deleted.
Move the implementation out of this file.

• inspector/ScriptCallStack.cpp:

(Inspector::ScriptCallStack::buildInspectorArray const):

• inspector/ScriptCallStack.h:
• inspector/agents/InspectorAgent.cpp:

(Inspector::InspectorAgent::activateExtraDomain):
(Inspector::InspectorAgent::activateExtraDomains):

• inspector/agents/InspectorAgent.h:
• inspector/agents/InspectorConsoleAgent.cpp:

(Inspector::InspectorConsoleAgent::getLoggingChannels):

• inspector/agents/InspectorConsoleAgent.h:
• inspector/agents/InspectorDebuggerAgent.cpp:

(Inspector::InspectorDebuggerAgent::setBreakpointByUrl):
(Inspector::InspectorDebuggerAgent::searchInContent):
(Inspector::InspectorDebuggerAgent::currentCallFrames):

• inspector/agents/InspectorDebuggerAgent.h:
• inspector/agents/InspectorRuntimeAgent.cpp:

(Inspector::InspectorRuntimeAgent::getProperties):
(Inspector::InspectorRuntimeAgent::getDisplayableProperties):
(Inspector::InspectorRuntimeAgent::getCollectionEntries):
(Inspector::InspectorRuntimeAgent::getRuntimeTypesForVariablesAtOffsets):
(Inspector::InspectorRuntimeAgent::getBasicBlocks):

• inspector/agents/InspectorRuntimeAgent.h:
• inspector/agents/InspectorScriptProfilerAgent.cpp:

(Inspector::buildSamples):
Use more 'auto' and rename a variable.

• inspector/scripts/codegen/cpp_generator.py:

(CppGenerator.cpp_protocol_type_for_type):
Adopt new type names. This exposed a latent bug where we should have been
unwrapping an AliasedType prior to generating a C++ type for it. The aliased
type may be an array, in which case we would have generated the wrong type.

• inspector/scripts/codegen/generate_cpp_protocol_types_header.py:

(_generate_typedefs_for_domain.JSON):
(_generate_typedefs_for_domain.Inspector): Deleted.

• inspector/scripts/codegen/objc_generator.py:

(ObjCGenerator.protocol_type_for_type):
(ObjCGenerator.objc_protocol_export_expression_for_variable):

• inspector/scripts/tests/generic/expected/commands-with-async-attribute.json-result:
• inspector/scripts/tests/generic/expected/commands-with-optional-call-return-parameters.json-result:
• inspector/scripts/tests/generic/expected/events-with-optional-parameters.json-result:
• inspector/scripts/tests/generic/expected/shadowed-optional-type-setters.json-result:
• inspector/scripts/tests/generic/expected/type-declaration-array-type.json-result:
• inspector/scripts/tests/generic/expected/type-declaration-object-type.json-result:

Rebaseline.

• runtime/TypeSet.cpp:

(JSC::TypeSet::allStructureRepresentations const):
(JSC::StructureShape::inspectorRepresentation):

• runtime/TypeSet.h:

Source/WebCore:

Adopt new type names.

• inspector/InspectorCanvas.cpp:

(WebCore::InspectorCanvas::recordAction):
(WebCore::InspectorCanvas::releaseFrames):
(WebCore::InspectorCanvas::releaseData):
(WebCore::InspectorCanvas::indexForData):
(WebCore::buildArrayForAffineTransform):
(WebCore::buildArrayForVector):
(WebCore::InspectorCanvas::buildInitialState):
(WebCore::InspectorCanvas::buildAction):
(WebCore::InspectorCanvas::buildArrayForCanvasGradient):
(WebCore::InspectorCanvas::buildArrayForCanvasPattern):
(WebCore::InspectorCanvas::buildArrayForImageData):
(WebCore::InspectorCanvas::buildArrayForImageBitmap):

• inspector/InspectorCanvas.h:
• inspector/InspectorController.cpp:

(WebCore::InspectorController::buildObjectForHighlightedNodes const):

• inspector/InspectorController.h:
• inspector/InspectorOverlay.cpp:

(WebCore::buildObjectForHighlight):
(WebCore::InspectorOverlay::drawPaintRects):
(WebCore::buildArrayForRendererFragments):
(WebCore::buildObjectForElementData):
(WebCore::InspectorOverlay::buildHighlightObjectForNode const):
(WebCore::InspectorOverlay::buildObjectForHighlightedNodes const):

• inspector/InspectorOverlay.h:
• inspector/InspectorStyleSheet.cpp:

(WebCore::fillMediaListChain):
(WebCore::InspectorStyle::buildArrayForComputedStyle const):
(WebCore::InspectorStyle::styleWithProperties const):
(WebCore::buildObjectForSelectorHelper):
(WebCore::selectorsFromSource):
(WebCore::InspectorStyleSheet::buildObjectForSelectorList):
(WebCore::InspectorStyleSheet::buildObjectForRule):
(WebCore::InspectorStyleSheet::buildObjectForStyle):
(WebCore::InspectorStyleSheet::buildArrayForRuleList):

• inspector/InspectorStyleSheet.h:
• inspector/agents/InspectorApplicationCacheAgent.cpp:

(WebCore::InspectorApplicationCacheAgent::getFramesWithManifests):
(WebCore::InspectorApplicationCacheAgent::buildArrayForApplicationCacheResources):

• inspector/agents/InspectorApplicationCacheAgent.h:
• inspector/agents/InspectorCSSAgent.cpp:

(WebCore::InspectorCSSAgent::getMatchedStylesForNode):
(WebCore::InspectorCSSAgent::getComputedStyleForNode):
(WebCore::InspectorCSSAgent::getAllStyleSheets):
(WebCore::InspectorCSSAgent::getSupportedCSSProperties):
(WebCore::InspectorCSSAgent::getSupportedSystemFontFamilyNames):
(WebCore::InspectorCSSAgent::buildArrayForMatchedRuleList):

• inspector/agents/InspectorCSSAgent.h:
• inspector/agents/InspectorCanvasAgent.cpp:

(WebCore::InspectorCanvasAgent::requestCSSCanvasClientNodes):

• inspector/agents/InspectorCanvasAgent.h:
• inspector/agents/InspectorDOMAgent.cpp:

(WebCore::InspectorDOMAgent::querySelectorAll):
(WebCore::InspectorDOMAgent::pushNodePathToFrontend):
(WebCore::InspectorDOMAgent::getEventListenersForNode):
(WebCore::InspectorDOMAgent::getSearchResults):
(WebCore::InspectorDOMAgent::getAttributes):
(WebCore::InspectorDOMAgent::buildObjectForNode):
(WebCore::InspectorDOMAgent::buildArrayForElementAttributes):
(WebCore::InspectorDOMAgent::buildArrayForContainerChildren):
(WebCore::InspectorDOMAgent::buildArrayForPseudoElements):
(WebCore::InspectorDOMAgent::processAccessibilityChildren):
(WebCore::InspectorDOMAgent::buildObjectForAccessibilityProperties):
(WebCore::InspectorDOMAgent::styleAttributeInvalidated):

• inspector/agents/InspectorDOMAgent.h:
• inspector/agents/InspectorDOMStorageAgent.cpp:

(WebCore::InspectorDOMStorageAgent::getDOMStorageItems):

• inspector/agents/InspectorDOMStorageAgent.h:
• inspector/agents/InspectorDatabaseAgent.cpp:

(WebCore::InspectorDatabaseAgent::getDatabaseTableNames):

• inspector/agents/InspectorDatabaseAgent.h:
• inspector/agents/InspectorIndexedDBAgent.cpp:

(WebCore::Inspector::keyPathFromIDBKeyPath):
(WebCore::InspectorIndexedDBAgent::requestDatabaseNames):

• inspector/agents/InspectorLayerTreeAgent.cpp:

(WebCore::InspectorLayerTreeAgent::layersForNode):
(WebCore::InspectorLayerTreeAgent::gatherLayersUsingRenderObjectHierarchy):
(WebCore::InspectorLayerTreeAgent::gatherLayersUsingRenderLayerHierarchy):

• inspector/agents/InspectorLayerTreeAgent.h:
• inspector/agents/InspectorMemoryAgent.cpp:

(WebCore::InspectorMemoryAgent::collectSample):

• inspector/agents/InspectorNetworkAgent.cpp:

(WebCore::InspectorNetworkAgent::searchOtherRequests):
(WebCore::InspectorNetworkAgent::searchInRequest):

• inspector/agents/InspectorNetworkAgent.h:
• inspector/agents/InspectorPageAgent.cpp:

(WebCore::buildArrayForCookies):
(WebCore::InspectorPageAgent::getCookies):
(WebCore::InspectorPageAgent::searchInResource):
(WebCore::InspectorPageAgent::searchInResources):
(WebCore::InspectorPageAgent::buildObjectForFrameTree):

• inspector/agents/InspectorPageAgent.h:
• inspector/agents/WebConsoleAgent.cpp:

(WebCore::WebConsoleAgent::getLoggingChannels):

• inspector/agents/WebConsoleAgent.h:

Source/WebKit:

Adopt new type names.

• UIProcess/Automation/WebAutomationSession.cpp:

(WebKit::WebAutomationSession::getNextContext):
(WebKit::WebAutomationSession::getBrowsingContexts):
(WebKit::buildArrayForCookies):
(WebKit::WebAutomationSession::getSessionPermissions):

• UIProcess/Automation/WebAutomationSession.h:

Source/WTF:

Move Inspector::Protocol::Array<T> to JSON::ArrayOf<T>.

• wtf/JSONValues.h:

(WTF::JSONImpl::ArrayOf::ArrayOf):
(WTF::JSONImpl::ArrayOf::openAccessors):
(WTF::JSONImpl::ArrayOf::addItem):
(WTF::JSONImpl::ArrayOf::create):

Tools:

Add duplicate test cases for JSON::ArrayOf<T> based on JSON::Array.

• TestWebKitAPI/Tests/WTF/JSONValue.cpp:

(TestWebKitAPI::TEST):

3:44 PM Changeset in webkit [225424] by jmarcell@apple.com

• 1 copy in tags/Safari-604.5.100.1

Tag Safari-604.5.100.1.

3:40 PM Changeset in webkit [225423] by sbarati@apple.com

• 5 edits
  2 adds in trunk

Having a bad time needs to handle ArrayClass indexing type as well
​https://bugs.webkit.org/show_bug.cgi?id=180274
<rdar://problem/35667869>

Reviewed by Keith Miller and Mark Lam.

JSTests:

• stress/array-prototype-slow-put-having-a-bad-time-2.js: Added.

(assert):

• stress/array-prototype-slow-put-having-a-bad-time.js: Added.

(assert):

Source/JavaScriptCore:

We need to make sure to transition ArrayClass to SlowPutArrayStorage as well.
Otherwise, we'll end up with the wrong Structure, which will lead us to not
adhere to the spec. The bug was that we were not considering ArrayClass inside
hasBrokenIndexing. This patch rewrites that function to automatically opt
in non-empty indexing types as broken, instead of having to opt out all
non-empty indexing types besides SlowPutArrayStorage.

• runtime/IndexingType.h:

(JSC::hasSlowPutArrayStorage):
(JSC::shouldUseSlowPut):

• runtime/JSGlobalObject.cpp:
• runtime/JSObject.cpp:

(JSC::JSObject::switchToSlowPutArrayStorage):

3:36 PM Changeset in webkit [225422] by Wenson Hsieh

• 16 edits in trunk

[Attachment Support] Implement SPI for clients to update a given attachment's data
​https://bugs.webkit.org/show_bug.cgi?id=180184
<rdar://problem/35355731>

Reviewed by Tim Horton.

Source/WebCore:

Add native API support for Mail to update the data (and optionally, the name and type) of a given attachment
element. See per-method comments below for more detail.

Test: WKAttachmentTests.ChangeAttachmentDataAndFileInformation

WKAttachmentTests.ChangeAttachmentDataUpdatesWithInPlaceDisplay

• editing/Editor.cpp:

(WebCore::Editor::insertAttachment):

• html/HTMLAttachmentElement.cpp:

(WebCore::HTMLAttachmentElement::setFile):
(WebCore::HTMLAttachmentElement::invalidateShadowRootChildrenIfNecessary):

Pull out logic to hide and reset shadow DOM state into a separate helper, and additionally hide both the image
and video child elements if they exist. This prevents us from getting into a state where both image and video
elements may appear side-by-side when changing data from an image to a video or vice versa.

(WebCore::HTMLAttachmentElement::updateFileWithData):

Add a new helper to update the backing File of an attachment element from data, optionally updating the filename
and content type as well.

(WebCore::HTMLAttachmentElement::populateShadowRootIfNecessary):

• html/HTMLAttachmentElement.h:

Source/WebKit:

Add plumbing to the web process for setting the attachment data (and optionally, the content type and/or file
name) of a given attachment. See WebCore ChangeLog for more detail. Changes covered by new API tests.

• UIProcess/API/APIAttachment.cpp:

(API::Attachment::setDataAndContentType):

• UIProcess/API/APIAttachment.h:
• UIProcess/API/Cocoa/_WKAttachment.h:

Add nullability annotations around _WKAttachment SPI methods.

• UIProcess/API/Cocoa/_WKAttachment.mm:

(-[_WKAttachment setData:newContentType:newFilename:completion:]):

• UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::setAttachmentDataAndContentType):

• UIProcess/WebPageProxy.h:
• WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::setAttachmentDataAndContentType):

• WebProcess/WebPage/WebPage.h:
• WebProcess/WebPage/WebPage.messages.in:

Tools:

Adds two new API tests to exercise the attachment data update flow.

• TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:

(TestWebKitAPI::ObserveAttachmentUpdatesForScope::ObserveAttachmentUpdatesForScope):
(-[_WKAttachment synchronouslySetDisplayOptions:error:]):
(-[_WKAttachment synchronouslyRequestData:]):
(-[_WKAttachment synchronouslySetData:newContentType:newFilename:error:]):
(TestWebKitAPI::TEST):

3:16 PM Changeset in webkit [225421] by Konstantin Tokarev

• 2 edits in trunk

[cmake] Make description of ENABLE_DRAG_SUPPORT more informative
​https://bugs.webkit.org/show_bug.cgi?id=180266

Reviewed by Michael Catanzaro.

When disabled, it also disables selection of text with dragging, and this
comes as a surprise for many people.

• Source/cmake/WebKitFeatures.cmake:

3:16 PM Changeset in webkit [225420] by jmarcell@apple.com

• 1 copy in tags/Safari-605.1.15.1

New tag.

3:13 PM Changeset in webkit [225419] by Ryan Haddad

• 2 edits in trunk/Source/ThirdParty/ANGLE

Unreviewed, rolling out r225412.

Breaks 32-bit macOS builds.

Reverted changeset:

"Unreviewed, fix byte order macros and address new -Wunknown-
pragmas warnings"
​https://bugs.webkit.org/show_bug.cgi?id=180177
​https://trac.webkit.org/changeset/225412

2:34 PM Changeset in webkit [225418] by jmarcell@apple.com

• 7 edits in branches/safari-604.5.100-branch/Source

Versioning.

2:30 PM Changeset in webkit [225417] by jmarcell@apple.com

• 1 copy in branches/safari-604.5.100-branch

New branch.

2:19 PM Changeset in webkit [225416] by jfbastien@apple.com

• 4 edits in trunk/Source/JavaScriptCore

WebAssembly: stack trace improvement follow-ups
​https://bugs.webkit.org/show_bug.cgi?id=180273

Reviewed by Saam Barati.

• wasm/WasmIndexOrName.cpp:

(JSC::Wasm::makeString):

• wasm/WasmIndexOrName.h:

(JSC::Wasm::IndexOrName::nameSection const):

• wasm/WasmNameSection.h:

(JSC::Wasm::NameSection::NameSection):
(JSC::Wasm::NameSection::get):

2:14 PM Changeset in webkit [225415] by Chris Dumez

• 7 edits in trunk/Source/WebCore

Get rid of microtask in ServiceWorkerContainer::jobResolvedWithRegistration()
​https://bugs.webkit.org/show_bug.cgi?id=180263

Reviewed by Youenn Fablet.

Get rid of microtask in ServiceWorkerContainer::jobResolvedWithRegistration(). It
is no longer needed and MicrotaskQueue::mainThreadQueue() is only safe to use from
the main thread, as its name suggest. ServiceWorkerContainer are also instantiated
in Service worker threads nowadays.

• workers/service/SWClientConnection.cpp:

(WebCore::SWClientConnection::registrationJobResolvedInServer):

• workers/service/ServiceWorkerContainer.cpp:

(WebCore::ServiceWorkerContainer::jobResolvedWithRegistration):

• workers/service/ServiceWorkerContainer.h:
• workers/service/ServiceWorkerJob.cpp:

(WebCore::ServiceWorkerJob::resolvedWithRegistration):

• workers/service/ServiceWorkerJob.h:
• workers/service/ServiceWorkerJobClient.h:

2:13 PM Changeset in webkit [225414] by mmaxfield@apple.com

• 6 edits
  2 adds in trunk

Free FontFaceSets may include fonts that were never actually added to them
​https://bugs.webkit.org/show_bug.cgi?id=180164

Reviewed by Simon Fraser.

Source/WebCore:

There are two circumstances where this can occur:

• If script makes a so-called "free" FontFaceSet, by using "new FontFaceSet". This object is not

associated with the document, and should therefore only include fonts which have been manually
added to it from script. However, today, this object includes preinstalled fonts which have the
same names as any fonts manually added to it. (So, if you manually add "Helvetica", the object
would have two objects - the one you just added and the preinstalled version too).

• For the document's FontFaceSet, the same thing would happen. This one is a little trickier

because the spec is not clear whether or not the document's FontFaceSet should include these
preinstalled fonts. However, running this test in Firefox and Chrome, they both agree that
preinstalled fonts should not be present, so this patch adheres to this behavior.

We can't actually remove the preinstalled fonts from the document's FontFaceSet (because that's
how normal font lookups are performed), but we can filter them out at the point they meet the
Javascript API. And, for "free" FontFaceSets, we can avoid adding them in the first place for
performance.

Test: fast/text/font-face-api-preinstalled.html

• css/CSSFontFaceSet.cpp:

(WebCore::CSSFontFaceSet::CSSFontFaceSet):
(WebCore::CSSFontFaceSet::ensureLocalFontFacesForFamilyRegistered):
(WebCore::CSSFontFaceSet::addToFacesLookupTable):
(WebCore::CSSFontFaceSet::matchingFacesExcludingPreinstalledFonts):
(WebCore::CSSFontFaceSet::check):
(WebCore::CSSFontFaceSet::matchingFaces): Deleted.

• css/CSSFontFaceSet.h:
• css/CSSFontSelector.cpp:

(WebCore::CSSFontSelector::CSSFontSelector):

• css/FontFaceSet.cpp:

(WebCore::FontFaceSet::load):

LayoutTests:

• fast/text/font-face-api-preinstalled-expected.txt: Added.
• fast/text/font-face-api-preinstalled.html: Added.

2:12 PM Changeset in webkit [225413] by msaboff@apple.com

• 3 edits in trunk/Source/bmalloc

Gigacage should not be enabled for ARM64_32
​https://bugs.webkit.org/show_bug.cgi?id=180265

Reviewed by Saam Barati.

Disabled Gigacage for ARM64_32.
In the process, restructured Gigacage::shouldBeEnabled() with GIGACAGE_ENABLED set
to 0 to avoid a dead code compiler warning.

• bmalloc/Gigacage.cpp:

(Gigacage::shouldBeEnabled):

• bmalloc/Gigacage.h:

2:09 PM Changeset in webkit [225412] by Michael Catanzaro

• 2 edits in trunk/Source/ThirdParty/ANGLE

Unreviewed, fix byte order macros and address new -Wunknown-pragmas warnings
​https://bugs.webkit.org/show_bug.cgi?id=180177
<rdar://problem/35774734>

I'm not sure how this code was developed, as it seems to have been designed for GCC, but it
does not use any of GCC's documented byte order macros, and accordingly does not work. Let's
fix it to guarantee there are no problems when building with GCC. I presume it should help
Clang as well.

• src/common/third_party/smhasher/src/PMurHash.cpp:

(angle::PMurHash32_Process):

1:58 PM Changeset in webkit [225411] by jfbastien@apple.com

• 8 edits
  1 add in trunk

WebAssembly: restore cached stack limit after out-call
​https://bugs.webkit.org/show_bug.cgi?id=179106
<rdar://problem/35337525>

Reviewed by Saam Barati.

JSTests:

• wasm/function-tests/double-instance.js: Added.

(const.imp.boom):
(const.imp.get callAnother):

Source/JavaScriptCore:

We cache the stack limit on the Instance so that we can do fast
stack checks where required. In regular usage the stack limit
never changes because we always run on the same thread, but in
rare cases an API user can totally migrate which thread (and
therefore stack) is used for execution between WebAssembly
traces. For that reason we set the cached stack limit to
UINTPTR_MAX on the outgoing Instance when transitioning back into
a different Instance. We usually restore the cached stack limit in
Context::store, but this wasn't called on all code paths. We had a
bug where an Instance calling into itself indirectly would
therefore fail to restore its cached stack limit properly.

This patch therefore restores the cached stack limit after direct
calls which could be to imports (both wasm->wasm and
wasm->embedder). We have to do all of them because we have no way
of knowing what imports will do (they're known at instantiation
time, not compilation time, and different instances can have
different imports). To make this efficient we also add a pointer
to the canonical location of the stack limit (i.e. the extra
indirection we're trying to save by caching the stack limit on the
Instance in the first place). This is potentially a small perf hit
on imported direct calls.

It's hard to say what the performance cost will be because we
haven't seen much code in the wild which does this. We're adding
two dependent loads and a store of the loaded value, which is
unlikely to get used soon after. It's more code, but on an
out-of-order processor it doesn't contribute to the critical path.

• wasm/WasmB3IRGenerator.cpp:

(JSC::Wasm::B3IRGenerator::restoreWebAssemblyGlobalState):
(JSC::Wasm::B3IRGenerator::addGrowMemory):
(JSC::Wasm::B3IRGenerator::addCall):
(JSC::Wasm::B3IRGenerator::addCallIndirect):

• wasm/WasmInstance.cpp:

(JSC::Wasm::Instance::Instance):
(JSC::Wasm::Instance::create):

• wasm/WasmInstance.h:

(JSC::Wasm::Instance::offsetOfPointerToActualStackLimit):
(JSC::Wasm::Instance::cachedStackLimit const):
(JSC::Wasm::Instance::setCachedStackLimit):

• wasm/js/JSWebAssemblyInstance.cpp:

(JSC::JSWebAssemblyInstance::create):

• wasm/js/WebAssemblyFunction.cpp:

(JSC::callWebAssemblyFunction):

1:58 PM Changeset in webkit [225410] by dino@apple.com

• 3 edits in trunk/Source/WebCore/platform/graphics

Another attempt to fix 32-bit, this time with a bit more thought!

• platform/graphics/ANGLEWebKitBridge.cpp:

(WebCore::ANGLEWebKitBridge::compileShaderSource):

• platform/graphics/ANGLEWebKitBridge.h:
• platform/graphics/opengl/Extensions3DOpenGLCommon.cpp:

(WebCore::Extensions3DOpenGLCommon::getTranslatedShaderSourceANGLE):

1:50 PM Changeset in webkit [225409] by dino@apple.com

• 4 edits in trunk/Source/WebCore

Attempted build fix.

• platform/graphics/ANGLEWebKitBridge.cpp:

(WebCore::ANGLEWebKitBridge::compileShaderSource):

• platform/graphics/ANGLEWebKitBridge.h:
• platform/graphics/opengl/Extensions3DOpenGLCommon.cpp:

(WebCore::Extensions3DOpenGLCommon::getTranslatedShaderSourceANGLE):

1:44 PM Changeset in webkit [225408] by Ryan Haddad

• 4 edits in trunk/LayoutTests

Update TestExpectations for various editing tests on iOS.

Unreviewed test gardening.

• platform/ios-wk2/TestExpectations:
• platform/ios-wk2/editing/deleting/5144139-2-expected.txt:
• platform/ios/TestExpectations:

1:16 PM Changeset in webkit [225407] by dino@apple.com

• 5 edits
  2 adds in trunk

Use SH_INITIALIZE_UNINITIALIZED_LOCALS now that ANGLE has been updated
​https://bugs.webkit.org/show_bug.cgi?id=177929
<rdar://problem/34866210>

Reviewed by Sam Weinig.

Source/WebCore:

Test: fast/canvas/webgl/uninitialized-locals.html

• platform/graphics/ANGLEWebKitBridge.cpp:

(WebCore::ANGLEWebKitBridge::compileShaderSource):

• platform/graphics/ANGLEWebKitBridge.h:
• platform/graphics/opengl/Extensions3DOpenGLCommon.cpp:

(WebCore::Extensions3DOpenGLCommon::getTranslatedShaderSourceANGLE):

LayoutTests:

• fast/canvas/webgl/uninitialized-locals-expected.txt: Added.
• fast/canvas/webgl/uninitialized-locals.html: Added.

12:36 PM Changeset in webkit [225406] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebCore

Many imported/w3c/web-platform-tests/service-workers/ test are failing together intermittently
​https://bugs.webkit.org/show_bug.cgi?id=180227

Patch by Youenn Fablet <​youenn@apple.com> on 2017-12-01
Reviewed by Mark Lam.

No observable change.

• bindings/js/JSDOMPromise.cpp:

(WebCore::callFunction):

12:31 PM Changeset in webkit [225405] by commit-queue@webkit.org

• 3 edits in trunk/Source/ThirdParty/ANGLE

Fix WinCairo build break after r225340
​https://bugs.webkit.org/show_bug.cgi?id=180230

Unreviewed build fix.

Patch by Tomoki Imai <Tomoki Imai> on 2017-12-01

• CMakeLists.txt: Add missing sources.
• PlatformWin.cmake: Add missing sources.

12:25 PM Changeset in webkit [225404] by Michael Catanzaro

• 3 edits in trunk/Source/ThirdParty/ANGLE

Unreviewed, fix -Wunknown-pragmas warnings.
​https://bugs.webkit.org/show_bug.cgi?id=180177

It seems GCC has started to warn about unrecognized Clang pragmas. Oh well.

This is not sent upstream, because the Clang pragmas appear to be downstream WebKit
additions. changes.diff is not updated, because it was not updated in yesterday's ANGLE
update.

• include/GLSLANG/ShaderVars.h:
• src/libANGLE/Platform.cpp:

11:45 AM Changeset in webkit [225403] by beidson@apple.com

• 33 edits
  1 copy
  1 move
  2 adds in trunk

Add Internals.terminateServiceWorker, and the ability to restart service workers for postMessage.
​https://bugs.webkit.org/show_bug.cgi?id=180170

Reviewed by Chris Dumez.

Source/WebCore:

Test: http/tests/workers/service/postmessage-after-terminate.https.html

• dom/ActiveDOMObject.cpp:

(WebCore::ActiveDOMObject::~ActiveDOMObject):

• testing/Internals.cpp:

(WebCore::Internals::terminateServiceWorker):

• testing/Internals.h:
• testing/Internals.idl:

• workers/service/SWClientConnection.h:

• workers/service/ServiceWorker.idl:

• workers/service/context/SWContextManager.cpp:

(WebCore::SWContextManager::postMessageToServiceWorkerGlobalScope):
(WebCore::SWContextManager::terminateWorker):

• workers/service/context/SWContextManager.h:

• workers/service/context/ServiceWorkerThreadProxy.h:

• workers/service/server/SWServer.cpp:

(WebCore::SWServer::workerByID const):
(WebCore::SWServer::Connection::syncTerminateWorker):
(WebCore::SWServer::installContextData):
(WebCore::SWServer::invokeRunServiceWorker):
(WebCore::SWServer::terminateWorker):
(WebCore::SWServer::syncTerminateWorker):
(WebCore::SWServer::terminateWorkerInternal):
(WebCore::SWServer::workerContextTerminated):

• workers/service/server/SWServer.h:

(WebCore::SWServer::workerByID const): Deleted.

• workers/service/server/SWServerToContextConnection.h:

• workers/service/server/SWServerWorker.cpp:

(WebCore::SWServerWorker::contextData const):

• workers/service/server/SWServerWorker.h:

(WebCore::SWServerWorker::isRunning const):
(WebCore::SWServerWorker::isTerminating const):
(WebCore::SWServerWorker::setState):
(WebCore::SWServerWorker::server):

Source/WebKit:

• StorageProcess/ServiceWorker/WebSWServerConnection.cpp:

(WebKit::WebSWServerConnection::startFetch):
(WebKit::WebSWServerConnection::postMessageToServiceWorkerGlobalScope):

• StorageProcess/ServiceWorker/WebSWServerConnection.h:
• StorageProcess/ServiceWorker/WebSWServerConnection.messages.in:

• StorageProcess/ServiceWorker/WebSWServerToContextConnection.cpp:

(WebKit::WebSWServerToContextConnection::syncTerminateWorker):

• StorageProcess/ServiceWorker/WebSWServerToContextConnection.h:

• StorageProcess/StorageToWebProcessConnection.cpp:

(WebKit::StorageToWebProcessConnection::didReceiveSyncMessage):

• WebProcess/Storage/WebSWClientConnection.cpp:

(WebKit::WebSWClientConnection::syncTerminateWorker):

• WebProcess/Storage/WebSWClientConnection.h:

• WebProcess/Storage/WebSWContextManagerConnection.cpp:

(WebKit::WebSWContextManagerConnection::terminateWorker):
(WebKit::WebSWContextManagerConnection::syncTerminateWorker):

• WebProcess/Storage/WebSWContextManagerConnection.h:
• WebProcess/Storage/WebSWContextManagerConnection.messages.in:

• WebProcess/Storage/WebToStorageProcessConnection.cpp:

(WebKit::WebToStorageProcessConnection::didReceiveSyncMessage):

• WebProcess/Storage/WebToStorageProcessConnection.h:

Source/WTF:

• wtf/CompletionHandler.h:

(WTF::CompletionHandler<Out):

LayoutTests:

• http/tests/workers/service/postmessage-after-terminate.https-expected.txt: Added.
• http/tests/workers/service/postmessage-after-terminate.https.html: Added.
• http/tests/workers/service/resources/basic-ServiceWorker-postMessage.js:

(then):

• http/tests/workers/service/resources/postmessage-after-terminate.js: Copied from LayoutTests/http/tests/workers/service/resources/basic-ServiceWorker-postMessage.js.

(then):

• http/tests/workers/service/resources/postmessage-echo-worker.js: Renamed from LayoutTests/http/tests/workers/service/resources/basic-ServiceWorker-postMessage-worker.js.

11:15 AM Changeset in webkit [225402] by Alan Bujtas

• 4 edits
  2 adds in trunk

Nullptr deref in WebCore::RenderTableCaption::containingBlockLogicalWidthForContent
​https://bugs.webkit.org/show_bug.cgi?id=180251
<rdar://problem/34138562>

Reviewed by Simon Fraser.

Source/WebCore:

containingBlockLogicalWidthForContent should check whether the renderer is actually
attached to the tree.

Test: fast/table/caption-crash-when-layer-backed.html

• rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::containingBlockLogicalWidthForContent const):

• rendering/RenderTableCaption.h:

(WebCore::RenderTableCaption::containingBlockLogicalWidthForContent const):

LayoutTests:

• fast/table/caption-crash-when-layer-backed-expected.txt: Added.
• fast/table/caption-crash-when-layer-backed.html: Added.

10:39 AM Changeset in webkit [225401] by Michael Catanzaro

• 2 edits in trunk

[GStreamer] Fix USE_GSTREAMER_GL check for GStreamer 1.10
​https://bugs.webkit.org/show_bug.cgi?id=180256

Reviewed by Carlos Alberto Lopez Perez.

It's not safe to change the value of build options after WEBKIT_OPTION_END, since it breaks
the option dependency checker. I don't think that actually hurts anything in this case, but
let's not encourage bad practice. Also, it's not good for features to be secretly disabled.
Nobody reads CMake output unless there is a fatal error. Failing the build at the CMake
stage lets distributors know that a feature will be missing. And of course, it's still
possible to disable USE_GSTREAMER_GL to avoid the increased GStreamer requirement.

• Source/cmake/GStreamerChecks.cmake:

10:33 AM Changeset in webkit [225400] by Michael Catanzaro

• 5 edits in trunk

[GTK] [MSE] Turn MSE on by default
​https://bugs.webkit.org/show_bug.cgi?id=167107

Reviewed by Carlos Alberto Lopez Perez.

Turn on the ENABLE_MEDIA_SOURCE build option. Fail the build if GStreamer 1.8 is not
installed and ENABLE_MEDIA_SOURCE has not been disabled.

• Source/cmake/GStreamerChecks.cmake:
• Source/cmake/GStreamerDefinitions.cmake:
• Source/cmake/OptionsGTK.cmake:
• Source/cmake/OptionsWPE.cmake:

10:31 AM Changeset in webkit [225399] by commit-queue@webkit.org

• 9 edits in trunk/Source

Clear WebSWClientConnection in case storage process IPC connection is closing
​https://bugs.webkit.org/show_bug.cgi?id=180210

Patch by Youenn Fablet <​youenn@apple.com> on 2017-12-01
Reviewed by Chris Dumez.

Source/WebCore:

No observable change of behavior.

• dom/Document.h: Keeping a ref since object may be deleted otherwise.

Source/WebKit:

Clear the sw connection maps when connection is closing.
Call related completion handlers for each connection.

• WebProcess/Storage/WebSWClientConnection.cpp:

(WebKit::WebSWClientConnection::connectionToServerLost):

• WebProcess/Storage/WebSWClientConnection.h:
• WebProcess/Storage/WebToStorageProcessConnection.cpp:

(WebKit::WebToStorageProcessConnection::didClose):
(WebKit::WebToStorageProcessConnection::idbConnectionToServerForSession):
(WebKit::WebToStorageProcessConnection::serviceWorkerConnectionForSession):

• WebProcess/Storage/WebToStorageProcessConnection.h:

10:29 AM Changeset in webkit [225398] by Chris Dumez

• 6 edits in trunk

Drop clientCreationURL from ServiceWorkerRegistrationKey
​https://bugs.webkit.org/show_bug.cgi?id=180255

Reviewed by Youenn Fablet.

LayoutTests/imported/w3c:

Rebaseline WPT test that is now passing.

• web-platform-tests/service-workers/service-worker/multiple-register.https-expected.txt:

Source/WebCore:

Drop clientCreationURL from ServiceWorkerRegistrationKey. It is not needed and leads to
wrong behavior when using the Service Worker API from inside service workers.

• workers/service/ServiceWorkerJobData.cpp:

(WebCore::ServiceWorkerJobData::registrationKey const):

• workers/service/ServiceWorkerRegistrationKey.cpp:

(WebCore::ServiceWorkerRegistrationKey::ServiceWorkerRegistrationKey):
(WebCore::ServiceWorkerRegistrationKey::hash const):
(WebCore::ServiceWorkerRegistrationKey::operator== const):
(WebCore::ServiceWorkerRegistrationKey::isolatedCopy const):
(WebCore::ServiceWorkerRegistrationKey::loggingString const):

• workers/service/ServiceWorkerRegistrationKey.h:

(WebCore::ServiceWorkerRegistrationKey::scope const):
(WebCore::ServiceWorkerRegistrationKey::setScope):
(WebCore::ServiceWorkerRegistrationKey::encode const):
(WebCore::ServiceWorkerRegistrationKey::decode):
(WTF::HashTraits<WebCore::ServiceWorkerRegistrationKey>::constructDeletedValue):
(WTF::HashTraits<WebCore::ServiceWorkerRegistrationKey>::isDeletedValue):
(WebCore::ServiceWorkerRegistrationKey::clientCreationURL const): Deleted.
(WebCore::ServiceWorkerRegistrationKey::setClientCreationURL): Deleted.

10:20 AM Changeset in webkit [225397] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebCore

[WinCairo] Wrongly placed scroll bars in HiDPI
​https://bugs.webkit.org/show_bug.cgi?id=180066

Patch by Fujii Hironori <Fujii Hironori> on 2017-12-01
Reviewed by Žan Doberšek.

PlatformContextCairo wasn't properly initialized. It should have a
pointer to GraphicsContextPrivate in WinCairo port to paint
controls in right places.

No new tests, no behavior change.

• platform/graphics/win/GraphicsContextCairoWin.cpp:

(WebCore::GraphicsContext::platformInit): Call PlatformContextCairo::setGraphicsContextPrivate.

10:11 AM Changeset in webkit [225396] by commit-queue@webkit.org

• 2 edits in trunk/Tools

[GTK] Add SampleMap.cpp API tests to CMake
​https://bugs.webkit.org/show_bug.cgi?id=180252

Patch by Alicia Boya García <​aboya@igalia.com> on 2017-12-01
Reviewed by Žan Doberšek.

• TestWebKitAPI/PlatformGTK.cmake:

10:09 AM Changeset in webkit [225395] by eric.carlson@apple.com

• 30 edits in trunk/Source

[MediaStream] Use CaptureDevice instead of device ID to identify devices
​https://bugs.webkit.org/show_bug.cgi?id=180206
<rdar://problem/35775758>

Reviewed by Youenn Fablet.

Source/WebCore:

No new tests, no change in behavior.

• Modules/mediastream/UserMediaRequest.cpp:

(WebCore::UserMediaRequest::allow):

• Modules/mediastream/UserMediaRequest.h:

(WebCore::UserMediaRequest::allowedAudioDeviceUID const): Deleted.
(WebCore::UserMediaRequest::allowedVideoDeviceUID const): Deleted.

• platform/mediastream/RealtimeMediaSource.h:
• platform/mediastream/RealtimeMediaSourceCenter.cpp:

(WebCore::RealtimeMediaSourceCenter::createMediaStream):
(WebCore::RealtimeMediaSourceCenter::validateRequestConstraints):

• platform/mediastream/RealtimeMediaSourceCenter.h:
• platform/mediastream/mac/CoreAudioCaptureSource.cpp:
• platform/mediastream/mac/RealtimeMediaSourceCenterMac.cpp:
• platform/mock/MockRealtimeAudioSource.cpp:
• platform/mock/MockRealtimeVideoSource.cpp:

Source/WebKit:

• UIProcess/Cocoa/UserMediaCaptureManagerProxy.cpp:

(WebKit::UserMediaCaptureManagerProxy::createMediaSourceForCaptureDeviceWithConstraints):

• UIProcess/Cocoa/UserMediaCaptureManagerProxy.h:
• UIProcess/Cocoa/UserMediaCaptureManagerProxy.messages.in:
• UIProcess/UserMediaPermissionRequestManagerProxy.cpp:

(WebKit::UserMediaPermissionRequestManagerProxy::userMediaAccessWasGranted):
(WebKit::UserMediaPermissionRequestManagerProxy::grantAccess):
(WebKit::UserMediaPermissionRequestManagerProxy::requestUserMediaPermissionForFrame):

• UIProcess/UserMediaPermissionRequestManagerProxy.h:
• UIProcess/UserMediaPermissionRequestProxy.cpp:

(WebKit::UserMediaPermissionRequestProxy::allow):

• WebProcess/MediaStream/UserMediaPermissionRequestManager.cpp:

(WebKit::UserMediaPermissionRequestManager::userMediaAccessWasGranted):

• WebProcess/MediaStream/UserMediaPermissionRequestManager.h:
• WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::userMediaAccessWasGranted):

• WebProcess/WebPage/WebPage.h:
• WebProcess/WebPage/WebPage.messages.in:
• WebProcess/cocoa/UserMediaCaptureManager.cpp:

(WebKit::UserMediaCaptureManager::createCaptureSource):

• WebProcess/cocoa/UserMediaCaptureManager.h:

9:51 AM Changeset in webkit [225394] by zandobersek@gmail.com

• 8 edits in trunk/LayoutTests

Unreviewed GTK+ gardening. Updating baselines affected in r225366.

• platform/gtk/css3/filters/effect-reference-expected.txt:
• platform/gtk/css3/filters/effect-reference-hw-expected.txt:
• platform/gtk/svg/W3C-SVG-1.1/filters-comptran-01-b-expected.txt:
• platform/gtk/svg/custom/feComponentTransfer-Discrete-expected.txt:
• platform/gtk/svg/custom/feComponentTransfer-Gamma-expected.txt:
• platform/gtk/svg/custom/feComponentTransfer-Linear-expected.txt:
• platform/gtk/svg/custom/feComponentTransfer-Table-expected.txt:

8:50 AM Changeset in webkit [225393] by Matt Lewis

• 2 edits in trunk/LayoutTests

Marked imported/w3c/web-platform-tests/service-workers/service-worker/worker-interception.https.html as flaky on macOS.
​https://bugs.webkit.org/show_bug.cgi?id=179351

Unreviewed test expectations.

• platform/mac-wk2/TestExpectations:

7:31 AM Changeset in webkit [225392] by Antti Koivisto

• 2 edits in trunk/PerformanceTests

Add StyleBench
​https://bugs.webkit.org/show_bug.cgi?id=180140
<rdar://problem/35366401>

• Skipped: Skip InteractiveRunner.html

4:10 AM Changeset in webkit [225391] by Ms2ger@igalia.com

• 2 edits
  4 adds in trunk/LayoutTests

[WPE] Enable some more wpt tests.
​https://bugs.webkit.org/show_bug.cgi?id=180242

Unreviewed test gardening.

• platform/wpe/TestExpectations: enable tests.
• platform/wpe/imported/w3c/web-platform-tests/eventsource/format-field-id-2-expected.txt: Copied from gtk.
• platform/wpe/imported/w3c/web-platform-tests/eventsource/format-field-id-expected.txt: Copied from gtk.
• platform/wpe/imported/w3c/web-platform-tests/eventsource/format-mime-bogus-expected.txt: Copied from gtk.

3:30 AM Changeset in webkit [225390] by Carlos Garcia Campos

• 8 edits
  423 adds
  1 delete in trunk

WebDriver: add support for importing and running selenium tests
​https://bugs.webkit.org/show_bug.cgi?id=180145

Reviewed by Brian Burg.

Tools:

We currently import and run W3C tests, which are the best ones to ensure our implementation is spec
compliant. However, the selenium API is what user will actually use in the end, so it's important to ensure that
we don't break the selenium support. This patch adds webdriver_test_runner_selenium.py and
webdriver_selenium_executor.py to run selenium tests. The script import-w3c-webdriver-tests has been renamed as
import-webdriver-tests and it can now import selenium tests too.

• Scripts/import-w3c-webdriver-tests: Removed.
• Scripts/import-webdriver-tests: Added.

(Importer):
(Importer.init):
(Importer.download_tests):
(Importer.import_tests):
(Importer.import_tests.should_skip_file):

• Scripts/webkitpy/webdriver_tests/webdriver_driver.py:

(WebDriver.browser_path):
(WebDriver):
(WebDriver.browser_args):
(WebDriver.selenium_name):

• Scripts/webkitpy/webdriver_tests/webdriver_driver_gtk.py:

(WebDriverGtk.browser_path):
(WebDriverGtk):
(WebDriverGtk.browser_args):
(WebDriverGtk.capabilities):
(WebDriverGtk.selenium_name):

• Scripts/webkitpy/webdriver_tests/webdriver_driver_wpe.py:

(WebDriverWPE.browser_args):
(WebDriverWPE.capabilities):

• Scripts/webkitpy/webdriver_tests/webdriver_selenium_executor.py: Added.

(_ensure_directory_in_path):
(CollectRecorder):
(CollectRecorder.init):
(CollectRecorder.pytest_collectreport):
(WebDriverSeleniumExecutor):
(WebDriverSeleniumExecutor.init):
(WebDriverSeleniumExecutor.collect):
(WebDriverSeleniumExecutor.run):

• Scripts/webkitpy/webdriver_tests/webdriver_test_runner.py:

(WebDriverTestRunner):
(WebDriverTestRunner.init):
(WebDriverTestRunner.run):
(WebDriverTestRunner.print_results):
(WebDriverTestRunner.dump_results_to_json_file):

• Scripts/webkitpy/webdriver_tests/webdriver_test_runner_selenium.py: Added.

(WebDriverTestRunnerSelenium):
(WebDriverTestRunnerSelenium.init):
(WebDriverTestRunnerSelenium._tests_dir):
(WebDriverTestRunnerSelenium.collect_tests):
(WebDriverTestRunnerSelenium.run):
(WebDriverTestRunnerSelenium.results):

• Scripts/webkitpy/webdriver_tests/webdriver_test_runner_w3c.py:

(WebDriverTestRunnerW3C.init):
(WebDriverTestRunnerW3C.run):

• Scripts/webkitpy/webdriver_tests/webdriver_w3c_executor.py:

WebDriverTests:

• imported/selenium/importer.json: Added.
• imported/selenium/common/: Added.
• imported/selenium/py/: Added.

3:04 AM Changeset in webkit [225389] by Ms2ger@igalia.com

• 2 edits in trunk/LayoutTests

Mark imported/w3c/web-platform-tests/resource-timing/single-entry-per-resource.html as flaky
​https://bugs.webkit.org/show_bug.cgi?id=180241

Unreviewed test gardening.

• TestExpectations:

1:50 AM Changeset in webkit [225388] by Carlos Garcia Campos

• 2 edits in trunk/Source/WebKit

WebDriver: link and partial links queries don't work in xhtml documents
​https://bugs.webkit.org/show_bug.cgi?id=180191

Reviewed by Brian Burg.

We convert the queries to use xpath, which works for html documents, but it doesn't work for xhtml. In case of
xhtml we would need to provide a namespace resolver and elements would need to be prefixed with 'xhtml:'. It's
easier to simply iterate the link elements and compare the text.

Fixes: imported/w3c/webdriver/tests/retrieval/find_element_from_element.py::test_xhtml_namespace[link text-full link text]

imported/w3c/webdriver/tests/retrieval/find_element_from_element.py::test_xhtml_namespace[partial link text-link text]
imported/w3c/webdriver/tests/retrieval/find_element_from_elements.py::test_xhtml_namespace[link text-full link text]
imported/w3c/webdriver/tests/retrieval/find_element_from_elements.py::test_xhtml_namespace[partial link text-link text]
imported/w3c/webdriver/tests/retrieval/find_element.py::test_xhtml_namespace[link text-full link text]
imported/w3c/webdriver/tests/retrieval/find_element.py::test_xhtml_namespace[partial link text-link text]
imported/w3c/webdriver/tests/retrieval/find_elements.py::test_xhtml_namespace[link text-full link text]
imported/w3c/webdriver/tests/retrieval/find_elements.py::test_xhtml_namespace[partial link text-link text]

• UIProcess/Automation/atoms/FindNodes.js:

(switch):
(tryToFindNode):

1:49 AM Changeset in webkit [225387] by Carlos Garcia Campos

• 3 edits in trunk/Source/WebDriver

WebDriver: implement status command
​https://bugs.webkit.org/show_bug.cgi?id=180133

Reviewed by Brian Burg.

8.3 Status
​https://w3c.github.io/webdriver/webdriver-spec.html#status

Fixes: imported/w3c/webdriver/tests/sessions/status.py::test_get_status_no_session

imported/w3c/webdriver/tests/sessions/status.py::test_status_with_session_running_on_endpoint_node

• WebDriverService.cpp:

(WebDriver::WebDriverService::status):

• WebDriverService.h:

1:47 AM Changeset in webkit [225386] by Carlos Garcia Campos

• 3 edits in trunk/Source/WebDriver

WebDriver: end point nodes are only allowed to have one session
​https://bugs.webkit.org/show_bug.cgi?id=180131

Reviewed by Brian Burg.

We are currently keeping a map of sessions, but our service is always and end point node, so only one session
can exist at a time. Make findSessionOrCompleteWithError() return a boolean instead, failing in case the sessionID
parameter is not found or it doesn't match the current session. Replace the session map and active session
pointer with a single session member and return SessionNotCreated error when new session command is received and
there's an active session.

8. Sessions

A remote end has an associated maximum active sessions (an integer) that defines the number of active sessions
that are supported. This may be “unlimited” for intermediary nodes, but must be exactly one for a remote end
that is an endpoint node.
​https://w3c.github.io/webdriver/webdriver-spec.html#dfn-maximum-active-sessions

Fixes: imported/w3c/webdriver/tests/sessions/new_session/default_values.py::test_repeat_new_session

• WebDriverService.cpp:

(WebDriver::WebDriverService::findSessionOrCompleteWithError):
(WebDriver::WebDriverService::newSession):
(WebDriver::WebDriverService::deleteSession):
(WebDriver::WebDriverService::status):
(WebDriver::WebDriverService::setTimeouts):
(WebDriver::WebDriverService::go):
(WebDriver::WebDriverService::getCurrentURL):
(WebDriver::WebDriverService::back):
(WebDriver::WebDriverService::forward):
(WebDriver::WebDriverService::refresh):
(WebDriver::WebDriverService::getTitle):
(WebDriver::WebDriverService::getWindowHandle):
(WebDriver::WebDriverService::setWindowRect):
(WebDriver::WebDriverService::closeWindow):
(WebDriver::WebDriverService::switchToWindow):
(WebDriver::WebDriverService::getWindowHandles):
(WebDriver::WebDriverService::switchToFrame):
(WebDriver::WebDriverService::switchToParentFrame):
(WebDriver::findStrategyAndSelectorOrCompleteWithError):
(WebDriver::WebDriverService::findElement):
(WebDriver::WebDriverService::findElements):
(WebDriver::WebDriverService::findElementFromElement):
(WebDriver::WebDriverService::findElementsFromElement):
(WebDriver::WebDriverService::getActiveElement):
(WebDriver::WebDriverService::isElementSelected):
(WebDriver::WebDriverService::getElementAttribute):
(WebDriver::WebDriverService::getElementText):
(WebDriver::WebDriverService::getElementTagName):
(WebDriver::WebDriverService::getElementRect):
(WebDriver::WebDriverService::isElementEnabled):
(WebDriver::WebDriverService::isElementDisplayed):
(WebDriver::WebDriverService::elementClick):
(WebDriver::WebDriverService::elementClear):
(WebDriver::WebDriverService::elementSendKeys):
(WebDriver::findScriptAndArgumentsOrCompleteWithError):
(WebDriver::WebDriverService::executeScript):
(WebDriver::WebDriverService::executeAsyncScript):
(WebDriver::WebDriverService::getAllCookies):
(WebDriver::WebDriverService::getNamedCookie):
(WebDriver::deserializeCookie):
(WebDriver::WebDriverService::addCookie):
(WebDriver::WebDriverService::deleteCookie):
(WebDriver::WebDriverService::deleteAllCookies):
(WebDriver::WebDriverService::dismissAlert):
(WebDriver::WebDriverService::acceptAlert):
(WebDriver::WebDriverService::getAlertText):
(WebDriver::WebDriverService::sendAlertText):
(WebDriver::WebDriverService::takeScreenshot):
(WebDriver::WebDriverService::takeElementScreenshot):

• WebDriverService.h:

12:18 AM Changeset in webkit [225385] by Yusuke Suzuki

• 33 edits in trunk/Source/JavaScriptCore

[JSC] Use JSFixedArray for op_new_array_buffer
​https://bugs.webkit.org/show_bug.cgi?id=180084

Reviewed by Saam Barati.

For op_new_array_buffer, we have a special constant buffer in CodeBlock.
But using JSFixedArray is better because,

1. In DFG, we have special hashing mechanism to avoid duplicating constant buffer from the same CodeBlock. If we use JSFixedArray, this is unnecessary since JSFixedArray is handled just as JS constant.

2. In a subsequent patch[1], we would like to support Spread(PhantomNewArrayBuffer). If NewArrayBuffer has JSFixedArray, we can just emit a held JSFixedArray.

3. We can reduce length of op_new_array_buffer since JSFixedArray holds this.

4. We can fold NewArrayBufferData into uint64_t. No need to maintain a bag of NewArrayBufferData in DFG.

5. We do not need to look up constant buffer from CodeBlock if buffer data is necessary. Our NewArrayBuffer DFG node has JSFixedArray as its cellOperand. This makes materializing PhantomNewArrayBuffer easy, which will be introduced in [1].

[1]: ​https://bugs.webkit.org/show_bug.cgi?id=179762

• bytecode/BytecodeDumper.cpp:

(JSC::BytecodeDumper<Block>::dumpBytecode):

• bytecode/BytecodeList.json:
• bytecode/BytecodeUseDef.h:

(JSC::computeUsesForBytecodeOffset):

• bytecode/CodeBlock.cpp:

(JSC::CodeBlock::finishCreation):

• bytecode/CodeBlock.h:

(JSC::CodeBlock::numberOfConstantBuffers const): Deleted.
(JSC::CodeBlock::addConstantBuffer): Deleted.
(JSC::CodeBlock::constantBufferAsVector): Deleted.
(JSC::CodeBlock::constantBuffer): Deleted.

• bytecode/UnlinkedCodeBlock.cpp:

(JSC::UnlinkedCodeBlock::shrinkToFit):

• bytecode/UnlinkedCodeBlock.h:

(JSC::UnlinkedCodeBlock::constantBufferCount): Deleted.
(JSC::UnlinkedCodeBlock::addConstantBuffer): Deleted.
(JSC::UnlinkedCodeBlock::constantBuffer const): Deleted.
(JSC::UnlinkedCodeBlock::constantBuffer): Deleted.

• bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::emitNewArray):
(JSC::BytecodeGenerator::addConstantBuffer): Deleted.

• bytecompiler/BytecodeGenerator.h:
• dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::parseBlock):
(JSC::DFG::ByteCodeParser::InlineStackEntry::InlineStackEntry):
(JSC::DFG::ConstantBufferKey::ConstantBufferKey): Deleted.
(JSC::DFG::ConstantBufferKey::operator== const): Deleted.
(JSC::DFG::ConstantBufferKey::hash const): Deleted.
(JSC::DFG::ConstantBufferKey::isHashTableDeletedValue const): Deleted.
(JSC::DFG::ConstantBufferKey::codeBlock const): Deleted.
(JSC::DFG::ConstantBufferKey::index const): Deleted.
(JSC::DFG::ConstantBufferKeyHash::hash): Deleted.
(JSC::DFG::ConstantBufferKeyHash::equal): Deleted.

• dfg/DFGClobberize.h:

(JSC::DFG::clobberize):

• dfg/DFGGraph.cpp:

(JSC::DFG::Graph::dump):

• dfg/DFGGraph.h:
• dfg/DFGNode.h:

(JSC::DFG::Node::hasNewArrayBufferData):
(JSC::DFG::Node::newArrayBufferData):
(JSC::DFG::Node::hasVectorLengthHint):
(JSC::DFG::Node::vectorLengthHint):
(JSC::DFG::Node::indexingType):
(JSC::DFG::Node::hasCellOperand):
(JSC::DFG::Node::OpInfoWrapper::operator=):
(JSC::DFG::Node::OpInfoWrapper::asNewArrayBufferData const):
(JSC::DFG::Node::hasConstantBuffer): Deleted.
(JSC::DFG::Node::startConstant): Deleted.
(JSC::DFG::Node::numConstants): Deleted.

• dfg/DFGOperations.cpp:
• dfg/DFGOperations.h:
• dfg/DFGSpeculativeJIT.h:

(JSC::DFG::SpeculativeJIT::callOperation):

• dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

• dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

• ftl/FTLLowerDFGToB3.cpp:

(JSC::FTL::DFG::LowerDFGToB3::compileNewArrayBuffer):

• jit/JIT.cpp:

(JSC::JIT::privateCompileMainPass):

• jit/JIT.h:
• jit/JITOpcodes.cpp:

(JSC::JIT::emit_op_new_array_buffer): Deleted.

• jit/JITOperations.cpp:
• jit/JITOperations.h:
• llint/LLIntSlowPaths.cpp:
• llint/LLIntSlowPaths.h:
• llint/LowLevelInterpreter.asm:
• runtime/CommonSlowPaths.cpp:

(JSC::SLOW_PATH_DECL):

• runtime/CommonSlowPaths.h:
• runtime/JSFixedArray.cpp:

(JSC::JSFixedArray::dumpToStream):

• runtime/JSFixedArray.h:

(JSC::JSFixedArray::create):
(JSC::JSFixedArray::get const):
(JSC::JSFixedArray::set):
(JSC::JSFixedArray::buffer const):
(JSC::JSFixedArray::values const):
(JSC::JSFixedArray::length const):
(JSC::JSFixedArray::get): Deleted.